Change in vdsm[master]: vdsm: Rely on system for logrotation

gerrit-hooks has posted comments on this change. Change subject: vdsm: Rely on system for logrotation .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: gluster: set selinux labels while creating bricks

Francesco Romani has posted comments on this change. Change subject: gluster: set selinux labels while creating bricks .. Patch Set 5: Code-Review-1 -1 for visibility -- To view, visit https://gerrit.ovirt.org/62773 To

Change in vdsm[master]: gluster: set selinux labels while creating bricks

Francesco Romani has posted comments on this change. Change subject: gluster: set selinux labels while creating bricks .. Patch Set 5: Isn't this something that must be handled at selinux policy levels? To fix it afterwards is

Change in vdsm[ovirt-4.0]: net: early IP+link setup

gerrit-hooks has posted comments on this change. Change subject: net: early IP+link setup .. Patch Set 2: * #1364087::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1364087::OK, public bug * Check

Change in vdsm[ovirt-4.0]: net: early IP+link setup

Hello Dan Kenigsberg, Edward Haas, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/63988 to review the following change. Change subject: net: early IP+link setup .. net: early IP+link setup Host

Change in vdsm[master]: v2v: Support for ova exported from AWS

Shahar Havivi has posted comments on this change. Change subject: v2v: Support for ova exported from AWS .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/63517 To unsubscribe, visit

Change in vdsm[master]: v2v: Support for ova exported from AWS

gerrit-hooks has posted comments on this change. Change subject: v2v: Support for ova exported from AWS .. Patch Set 3: * #1371843::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1371843::OK, public bug * Check

Change in vdsm[master]: net: Consume ifcfg files that have a non vdsm standard name

Petr Horáček has posted comments on this change. Change subject: net: Consume ifcfg files that have a non vdsm standard name .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/63990/1//COMMIT_MSG Commit Message: Line

Change in vdsm[master]: net: edit bond detached from bridge but still attached to a ...

Edward Haas has posted comments on this change. Change subject: net: edit bond detached from bridge but still attached to a vlan .. Patch Set 5: Is there any way to generalize it under the bond umbrella? It will be nice to see

Change in vdsm[master]: net: Consume ifcfg files that have a non vdsm standard name

Petr Horáček has posted comments on this change. Change subject: net: Consume ifcfg files that have a non vdsm standard name .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/63990/1//COMMIT_MSG Commit

Change in vdsm[master]: net: Consume ifcfg files that have a non vdsm standard name

gerrit-hooks has posted comments on this change. Change subject: net: Consume ifcfg files that have a non vdsm standard name .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: net: Consume ifcfg files that have a non vdsm standard name

Edward Haas has uploaded a new change for review. Change subject: net: Consume ifcfg files that have a non vdsm standard name .. net: Consume ifcfg files that have a non vdsm standard name VDSM assumes that the ifcfg files

Change in vdsm[master]: v2v: Support for ova exported from AWS

Shahar Havivi has posted comments on this change. Change subject: v2v: Support for ova exported from AWS .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/63517/2/lib/vdsm/v2v.py File lib/vdsm/v2v.py: Line 1187:

Change in vdsm[master]: vm: avoid mark unresponsive on startup

Michal Skrivanek has posted comments on this change. Change subject: vm: avoid mark unresponsive on startup .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/63008/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 514:

Change in vdsm[master]: net: Remove OVS bond implementation.

Edward Haas has posted comments on this change. Change subject: net: Remove OVS bond implementation. .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/63850/3/tests/network/ovs_info_test.py File

Change in vdsm[master]: net: edit bond detached from bridge but still attached to a ...

Petr Horáček has posted comments on this change. Change subject: net: edit bond detached from bridge but still attached to a vlan .. Patch Set 5: Verified+1 func_ifcfg_test failed without extra bond configuration, it passed

Change in vdsm[master]: net: Use Linux bonds with OVS networks

gerrit-hooks has posted comments on this change. Change subject: net: Use Linux bonds with OVS networks .. Patch Set 23: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: net: Remove OVS bond implementation.

gerrit-hooks has posted comments on this change. Change subject: net: Remove OVS bond implementation. .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: vdsm: Rely on system for logrotation

gerrit-hooks has posted comments on this change. Change subject: vdsm: Rely on system for logrotation .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: automation: add a repo with a fresh nose

Sandro Bonazzola has posted comments on this change. Change subject: automation: add a repo with a fresh nose .. Patch Set 1: Verified+1 Worked fine: http://jenkins.ovirt.org/job/vdsm_master_build-artifacts-el7-x86_64/839/

Change in vdsm[ovirt-4.0]: net: early IP+link setup

gerrit-hooks has posted comments on this change. Change subject: net: early IP+link setup .. Patch Set 1: * #1364087::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1364087::OK, public bug * Check

Change in vdsm[master]: net tests: keep connectivity

gerrit-hooks has posted comments on this change. Change subject: net tests: keep connectivity .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/63683 To unsubscribe, visit

Change in vdsm[master]: net: edit bond detached from bridge but still attached to a ...

gerrit-hooks has posted comments on this change. Change subject: net: edit bond detached from bridge but still attached to a vlan .. Patch Set 5: * #1372798::Update tracker: OK * Check Bug-Url::OK * Check Public

Change in vdsm[master]: net tests: keep connectivity

Petr Horáček has abandoned this change. Change subject: net tests: keep connectivity .. Abandoned -- To view, visit https://gerrit.ovirt.org/63683 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType:

Change in vdsm[master]: net: edit bond detached from bridge but still attached to a ...

Petr Horáček has posted comments on this change. Change subject: net: edit bond detached from bridge but still attached to a vlan .. Patch Set 4: (1 comment)

Change in vdsm[master]: automation: add a repo with a fresh nose

Dan Kenigsberg has uploaded a new change for review. Change subject: automation: add a repo with a fresh nose .. automation: add a repo with a fresh nose We need nose >= 1.3.7 to test vdsm, but don't have it on el7. One option

Change in vdsm[master]: automation: add a repo with a fresh nose

gerrit-hooks has posted comments on this change. Change subject: automation: add a repo with a fresh nose .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: build: Disable tests during build

Dan Kenigsberg has posted comments on this change. Change subject: build: Disable tests during build .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/63966/3//COMMIT_MSG Commit Message: Line 5: CommitDate: 2016-09-15

Change in vdsm[master]: functional tests: fix supervdsmServer test

Irit Goihman has posted comments on this change. Change subject: functional tests: fix supervdsmServer test .. Patch Set 19: (1 comment) https://gerrit.ovirt.org/#/c/61902/19/tests/functional/supervdsmFuncTests.py File

Change in vdsm[master]: jobs: Allow run and abort only from valid states

gerrit-hooks has posted comments on this change. Change subject: jobs: Allow run and abort only from valid states .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: jobs: Autodelete

gerrit-hooks has posted comments on this change. Change subject: jobs: Autodelete .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: jobs: Allow run and abort only from valid states

Nir Soffer has posted comments on this change. Change subject: jobs: Allow run and abort only from valid states .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/63711 To unsubscribe, visit

Change in vdsm[master]: jobs: Autodelete

Nir Soffer has posted comments on this change. Change subject: jobs: Autodelete .. Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/62002 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: jobs: Guard against racy state changes

Nir Soffer has posted comments on this change. Change subject: jobs: Guard against racy state changes .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/63712 To unsubscribe, visit

Change in vdsm[master]: jobs: Autodelete

Nir Soffer has submitted this change and it was merged. Change subject: jobs: Autodelete .. jobs: Autodelete For storage jobs we like to delete finished jobs automatically after some delay, giving engine enough time to

Change in vdsm[master]: functional tests: fix supervdsmServer test

Nir Soffer has posted comments on this change. Change subject: functional tests: fix supervdsmServer test .. Patch Set 19: Code-Review+2 (1 comment) Nice!

Change in vdsm[master]: build: Disable tests during build

Nir Soffer has posted comments on this change. Change subject: build: Disable tests during build .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/63966/3//COMMIT_MSG Commit Message: Line 5: CommitDate: 2016-09-15

Change in vdsm[master]: net: Remove OVS bond implementation.

gerrit-hooks has posted comments on this change. Change subject: net: Remove OVS bond implementation. .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: net: Use Linux bonds with OVS networks

gerrit-hooks has posted comments on this change. Change subject: net: Use Linux bonds with OVS networks .. Patch Set 22: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: build: Disable tests during build

Dan Kenigsberg has posted comments on this change. Change subject: build: Disable tests during build .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/63966/3//COMMIT_MSG Commit Message: Line 5: CommitDate: 2016-09-15

Change in vdsm[ovirt-3.6]: virt: Correct disconnectAction parameter extraction

Francesco Romani has posted comments on this change. Change subject: virt: Correct disconnectAction parameter extraction .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/63974 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: virt: Ensure uncaught exceptions on disconnect events are ca...

Francesco Romani has posted comments on this change. Change subject: virt: Ensure uncaught exceptions on disconnect events are caught .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/63973 To

Change in vdsm[ovirt-3.6]: virt: Pass missing parameter on desktopLogoff

Francesco Romani has posted comments on this change. Change subject: virt: Pass missing parameter on desktopLogoff .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/63972 To unsubscribe, visit

Change in vdsm[master]: WIP: add helper to enforce the `common` rules

gerrit-hooks has posted comments on this change. Change subject: WIP: add helper to enforce the `common` rules .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: WIP: add helper to enforce the `common` rules

gerrit-hooks has posted comments on this change. Change subject: WIP: add helper to enforce the `common` rules .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: sos: collect 'nodectl info' output

Irit Goihman has posted comments on this change. Change subject: sos: collect 'nodectl info' output .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/63765/1/vdsm/sos/vdsm.py.in File vdsm/sos/vdsm.py.in: Line 131:

Change in vdsm[ovirt-3.6]: virt: Ensure uncaught exceptions on disconnect events are ca...

gerrit-hooks has posted comments on this change. Change subject: virt: Ensure uncaught exceptions on disconnect events are caught .. Patch Set 3: * #1371264::Update tracker: OK * Check Bug-Url::OK * Check Public

Change in vdsm[ovirt-3.6]: virt: Correct disconnectAction parameter extraction

gerrit-hooks has posted comments on this change. Change subject: virt: Correct disconnectAction parameter extraction .. Patch Set 3: * #1371264::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1371264::OK, public

Change in vdsm[ovirt-3.6]: virt: Pass missing parameter on desktopLogoff

gerrit-hooks has posted comments on this change. Change subject: virt: Pass missing parameter on desktopLogoff .. Patch Set 3: * #1371264::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1371264::OK, public bug *

Change in vdsm[master]: functional tests: fix supervdsmServer test

Yaniv Bronhaim has posted comments on this change. Change subject: functional tests: fix supervdsmServer test .. Patch Set 19: Code-Review+1 amazing. much simpler -- To view, visit https://gerrit.ovirt.org/61902 To

Change in vdsm[ovirt-3.6]: virt: Correct disconnectAction parameter extraction

Jenkins CI has posted comments on this change. Change subject: virt: Correct disconnectAction parameter extraction .. Patch Set 2: Continuous-Integration-1 Propagate review hook: Continuous Integration value inherited from

Change in vdsm[ovirt-3.6]: virt: Ensure uncaught exceptions on disconnect events are ca...

gerrit-hooks has posted comments on this change. Change subject: virt: Ensure uncaught exceptions on disconnect events are caught .. Patch Set 2: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#1371264::ERROR,

Change in vdsm[ovirt-3.6]: virt: Pass missing parameter on desktopLogoff

gerrit-hooks has posted comments on this change. Change subject: virt: Pass missing parameter on desktopLogoff .. Patch Set 2: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#1371264::ERROR, private bug * Check

Change in vdsm[ovirt-3.6]: virt: Correct disconnectAction parameter extraction

gerrit-hooks has posted comments on this change. Change subject: virt: Correct disconnectAction parameter extraction .. Patch Set 2: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#1371264::ERROR, private bug *

Change in vdsm[master]: sos: remove jsonrpcvdscli.connect parameters

Irit Goihman has posted comments on this change. Change subject: sos: remove jsonrpcvdscli.connect parameters .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/63728 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: virt: Correct disconnectAction parameter extraction

gerrit-hooks has posted comments on this change. Change subject: virt: Correct disconnectAction parameter extraction .. Patch Set 1: * #1349383::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1349383::OK, public

Change in vdsm[ovirt-3.6]: virt: Correct disconnectAction parameter extraction

Hello Francesco Romani, Milan Zamazal, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/63974 to review the following change. Change subject: virt: Correct disconnectAction parameter extraction ..

Change in vdsm[master]: sos: remove jsonrpcvdscli.connect parameters

Piotr Kliczewski has posted comments on this change. Change subject: sos: remove jsonrpcvdscli.connect parameters .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/63728 To unsubscribe, visit

Change in vdsm[master]: jobs: Guard against racy state changes

Piotr Kliczewski has posted comments on this change. Change subject: jobs: Guard against racy state changes .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/63712 To unsubscribe, visit

Change in vdsm[master]: lib: api: allow to return prebuilt responses

gerrit-hooks has posted comments on this change. Change subject: lib: api: allow to return prebuilt responses .. Patch Set 15: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: jobs: Allow run and abort only from valid states

Piotr Kliczewski has posted comments on this change. Change subject: jobs: Allow run and abort only from valid states .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/63711 To unsubscribe, visit

Change in vdsm[master]: WIP: API: more cleanups

gerrit-hooks has posted comments on this change. Change subject: WIP: API: more cleanups .. Patch Set 14: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '

Change in vdsm[master]: lib: api.py: preserve signature in decorator

gerrit-hooks has posted comments on this change. Change subject: lib: api.py: preserve signature in decorator .. Patch Set 12: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: lib: move the response.py under common

gerrit-hooks has posted comments on this change. Change subject: lib: move the response.py under common .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: API: modernize VM methods

gerrit-hooks has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 15: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: WIP: add helper to enforce the `common` rules

gerrit-hooks has posted comments on this change. Change subject: WIP: add helper to enforce the `common` rules .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: lib: response: helper to detect valid responses

gerrit-hooks has posted comments on this change. Change subject: lib: response: helper to detect valid responses .. Patch Set 12: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: WIP benchmark decorator module speed

gerrit-hooks has posted comments on this change. Change subject: WIP benchmark decorator module speed .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: jobs: Autodelete

Piotr Kliczewski has posted comments on this change. Change subject: jobs: Autodelete .. Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62002 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[ovirt-3.6]: virt: Ensure uncaught exceptions on disconnect events are ca...

gerrit-hooks has posted comments on this change. Change subject: virt: Ensure uncaught exceptions on disconnect events are caught .. Patch Set 1: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#1371264::ERROR,

Change in vdsm[ovirt-3.6]: virt: Pass missing parameter on desktopLogoff

gerrit-hooks has posted comments on this change. Change subject: virt: Pass missing parameter on desktopLogoff .. Patch Set 1: * #1349383::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1349383::OK, public bug *

Change in vdsm[ovirt-3.6]: virt: Ensure uncaught exceptions on disconnect events are ca...

Hello Francesco Romani, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/63973 to review the following change. Change subject: virt: Ensure uncaught exceptions on disconnect events are caught ..

Change in vdsm[ovirt-3.6]: virt: Pass missing parameter on desktopLogoff

Hello Francesco Romani, Milan Zamazal, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/63972 to review the following change. Change subject: virt: Pass missing parameter on desktopLogoff .. virt:

Change in vdsm[master]: jobs: Allow run and abort only from valid states

Francesco Romani has posted comments on this change. Change subject: jobs: Allow run and abort only from valid states .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/63711 To unsubscribe, visit

Change in vdsm[master]: jobs: Autodelete

Francesco Romani has posted comments on this change. Change subject: jobs: Autodelete .. Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62002 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: v2v: Support for ova exported from AWS

Francesco Romani has posted comments on this change. Change subject: v2v: Support for ova exported from AWS .. Patch Set 2: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/63517/2/lib/vdsm/v2v.py File lib/vdsm/v2v.py:

Change in vdsm[master]: v2v: add test for Xen block device

Francesco Romani has posted comments on this change. Change subject: v2v: add test for Xen block device .. Patch Set 3: Code-Review-1 (1 comment) just one update and we are good to go. -1 for visibility

Change in vdsm[master]: net: remove default route before adding a new one

Edward Haas has posted comments on this change. Change subject: net: remove default route before adding a new one .. Patch Set 3: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/63220/3/lib/vdsm/network/ip/address.py

<    1   2