Change in vdsm[master]: vdsm: move logic to python module and create wrapper

2017-01-03 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: vdsm: move logic to python module and create wrapper .. Patch Set 9: Code-Review+1 -- To view, visit

Change in vdsm[master]: vdsm: remove os.setgrp() call

2017-01-03 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: vdsm: remove os.setgrp() call .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/69448 To

Change in vdsm[master]: rpmlint: silence isolatedprivatevlan-related error

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: rpmlint: silence isolatedprivatevlan-related error .. Patch Set 1: Code-Review+2 -- To view, visit

Change in vdsm[master]: rpmlint: silence isolatedprivatevlan-related error

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: rpmlint: silence isolatedprivatevlan-related error .. rpmlint: silence isolatedprivatevlan-related error

Change in vdsm[master]: vdsm-client: Refine complex argument examples

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm-client: Refine complex argument examples .. vdsm-client: Refine complex argument examples Use Lease

Change in vdsm[master]: vdsm-client: Use passed arguments

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm-client: Use passed arguments .. vdsm-client: Use passed arguments client.main() accept arguments and

Change in vdsm[master]: vdsm-client: Make executable in the source

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm-client: Make executable in the source .. vdsm-client: Make executable in the source Having an

Change in vdsm[master]: network: fix invalid argument names in __exit__

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: network: fix invalid argument names in __exit__ .. network: fix invalid argument names in __exit__

Change in vdsm[master]: network: fix invalid argument names in __exit__

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: network: fix invalid argument names in __exit__ .. Patch Set 1: Verified+1 passing CI is good enough verification for

Change in vdsm[master]: testValidation: Raise TypeError on decorator misuse

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: testValidation: Raise TypeError on decorator misuse .. testValidation: Raise TypeError on decorator misuse

Change in vdsm[ovirt-4.1]: storage: Add API for SDM update_volume

2017-01-03 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: storage: Add API for SDM update_volume .. Patch Set 2: Continuous-Integration+1 -- To view, visit

Change in vdsm[ovirt-4.1]: storage: Add API for SDM update_volume

2017-01-03 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has submitted this change and it was merged. Change subject: storage: Add API for SDM update_volume .. storage: Add API for SDM update_volume Add API for

Change in vdsm[master]: shell_helper: change vdsClient reference to vdsm-client

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: shell_helper: change vdsClient reference to vdsm-client .. shell_helper: change vdsClient reference to

Change in vdsm[master]: rpmlint: silence isolatedprivatevlan-related error

2017-01-03 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: rpmlint: silence isolatedprivatevlan-related error .. Patch Set 1: Code-Review+1 -- To view, visit

Change in vdsm[master]: testValidation: Add @xfail decorator

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: testValidation: Add @xfail decorator .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/69321

Change in vdsm[master]: testValidation: Add @xfail decorator

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: testValidation: Add @xfail decorator .. testValidation: Add @xfail decorator This decorator should be used

Change in vdsm[master]: vdsm.spec: ship vdsm-client with vdsm-cli package

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm.spec: ship vdsm-client with vdsm-cli package .. vdsm.spec: ship vdsm-client with vdsm-cli package

Change in vdsm[master]: vdsm: move try except block inside main function

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: vdsm: move try except block inside main function .. Patch Set 6: Code-Review+2 -- To view, visit

Change in vdsm[master]: vdsm: move try except block inside main function

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm: move try except block inside main function .. vdsm: move try except block inside main function This

Change in vdsm[master]: vdsm: remove os.setgrp() call

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm: remove os.setgrp() call .. vdsm: remove os.setgrp() call This is a leftover from rhel6 and not needed

Change in vdsm[master]: rpmlint: ignore only limited set of errors

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: rpmlint: ignore only limited set of errors .. Patch Set 5: Verified+1 (1 comment)

Change in vdsm[master]: rpmlint: ignore only limited set of errors

2017-01-03 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: rpmlint: ignore only limited set of errors .. Patch Set 4: (1 comment)

Change in vdsm[ovirt-4.1]: storage: Add API for SDM update_volume

2017-01-03 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: storage: Add API for SDM update_volume .. Patch Set 1: Code-Review+2 -- To view, visit

Change in vdsm[ovirt-4.1]: storage: rename volume attributes class

2017-01-03 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has submitted this change and it was merged. Change subject: storage: rename volume attributes class .. storage: rename volume attributes class amend_volume should

Change in vdsm[ovirt-4.1]: storage: rename volume attributes class

2017-01-03 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: storage: rename volume attributes class .. Patch Set 1: Code-Review+2 -- To view, visit

Change in vdsm[ovirt-4.1]: storage: Add API for SDM update_volume

2017-01-03 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: storage: Add API for SDM update_volume .. Patch Set 2: please update the bug with the next Target Release version

Change in vdsm[master]: rpmlint: ignore only limited set of errors

2017-01-03 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: rpmlint: ignore only limited set of errors .. Patch Set 4: (2 comments)

Change in vdsm[master]: Adding grub2-tool requirement which host-deploy requires

2017-01-03 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has uploaded a new change for review. Change subject: Adding grub2-tool requirement which host-deploy requires .. Adding grub2-tool requirement which host-deploy

Change in vdsm[master]: vdsm: move logic to python module and create wrapper

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm: move logic to python module and create wrapper .. vdsm: move logic to python module and create wrapper

Change in vdsm[master]: test: Remove testEmptyAddress test which does not ran

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: test: Remove testEmptyAddress test which does not ran .. test: Remove testEmptyAddress test which does not

Change in vdsm[master]: test: Fix misuse of @brokentest in vmApiTests module

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: test: Fix misuse of @brokentest in vmApiTests module .. test: Fix misuse of @brokentest in vmApiTests module

Change in vdsm[master]: testValidation: Raise TypeError on decorator misuse

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: testValidation: Raise TypeError on decorator misuse .. Patch Set 4: Code-Review+2 -- To view, visit

Change in vdsm[master]: netlink: monitor: join scanner thread on __exit__

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: netlink: monitor: join scanner thread on __exit__ .. Patch Set 3: Code-Review-1 (2 comments)

Change in vdsm[master]: net: extract the configuration action from sourceroute

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: extract the configuration action from sourceroute .. Patch Set 3: Code-Review-1 (1 comment)

Change in vdsm[master]: net: Relocate (libvirt) code from sourceroute to libvirt

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Relocate (libvirt) code from sourceroute to libvirt .. Patch Set 1: Code-Review+2 -- To view, visit

Change in vdsm[master]: net func test: Existing NM test should cleanup even if it fails

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net func test: Existing NM test should cleanup even if it fails .. Patch Set 1: (1 comment)

Change in vdsm[master]: tests/README: resource leak plugins: succinct doc

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has abandoned this change. Change subject: tests/README: resource leak plugins: succinct doc .. Abandoned I find the existing doc as boringly repetitious; if you find it

Change in vdsm[ovirt-4.1]: automation: adding fc25 conf files

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: automation: adding fc25 conf files .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/69244 To

Change in vdsm[master]: net test: Bonds need a slave to be considered operational up

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net test: Bonds need a slave to be considered operational up .. Patch Set 2: Code-Review+2 (1 comment)

Change in vdsm[master]: network: fix invalid argument names in __exit__

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: network: fix invalid argument names in __exit__ .. Patch Set 1: Code-Review+2 regards from younger Petr ;-) -- To

Change in vdsm[master]: rpmlint: ignore only limited set of errors

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: rpmlint: ignore only limited set of errors .. Patch Set 7: Verified+1 -- To view, visit

Change in vdsm[master]: net: configurators - refactor source route flow (no logic ch...

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: configurators - refactor source route flow (no logic change) .. Patch Set 4: Code-Review+2 -- To view, visit

Change in vdsm[master]: net: configurators - refactor source route flow (no logic ch...

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: net: configurators - refactor source route flow (no logic change) .. net: configurators - refactor source

Change in vdsm[master]: net: configurators - refactor source route flow (no logic ch...

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: configurators - refactor source route flow (no logic change) .. Patch Set 5: (1 comment)

Change in vdsm[master]: Adding grub2-tool requirement which host-deploy requires

2017-01-03 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: Adding grub2-tool requirement which host-deploy requires .. Patch Set 1: Verified+1 -- To view, visit

Change in vdsm[master]: Adding grub2-tool requirement which host-deploy requires

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: Adding grub2-tool requirement which host-deploy requires .. Patch Set 1: Code-Review+2 -- To view, visit

Change in vdsm[master]: vdsm script: rename to vdsmd

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: vdsm script: rename to vdsmd .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/69429/6//COMMIT_MSG Commit

Change in vdsm[master]: rpmlint: ignore only limited set of errors

2017-01-03 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: rpmlint: ignore only limited set of errors .. Patch Set 5: (1 comment)

Change in vdsm[master]: automation: adding fc25 conf files

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: automation: adding fc25 conf files .. automation: adding fc25 conf files added conf files for build

Change in vdsm[master]: automation: adding fc25 conf files

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: automation: adding fc25 conf files .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/69176 To

Change in vdsm[master]: net: rename sourceroutethread module to dhclient_monitor

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: rename sourceroutethread module to dhclient_monitor .. Patch Set 3: Code-Review+2 -- To view, visit

Change in vdsm[master]: net: Aggregate network initializations under one roof

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Aggregate network initializations under one roof .. Patch Set 2: (1 comment)

Change in vdsm[master]: net: rename sourceroutethread module to dhclient_monitor

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: net: rename sourceroutethread module to dhclient_monitor .. net: rename sourceroutethread module to

Change in vdsm[ovirt-4.1]: gluster: fix import issue in gfapi module.

2017-01-03 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: gluster: fix import issue in gfapi module. .. Patch Set 1: Code-Review+2 -- To view, visit

Change in vdsm[ovirt-4.1]: gluster: fix import issue in gfapi module.

2017-01-03 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has submitted this change and it was merged. Change subject: gluster: fix import issue in gfapi module. .. gluster: fix import issue in gfapi module. gluster module is

Change in vdsm[master]: vdsm script: rename to vdsmd

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: vdsm script: rename to vdsmd .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/69429/6//COMMIT_MSG Commit

Change in vdsm[ovirt-4.1]: net: drop special ovirt-node handling from netconfpersistence

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: drop special ovirt-node handling from netconfpersistence .. Patch Set 1: Code-Review+2 -- To view, visit

Change in vdsm[ovirt-4.1]: net: drop special ovirt-node handling from netconfpersistence

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: net: drop special ovirt-node handling from netconfpersistence .. net: drop special ovirt-node handling from

Change in vdsm[master]: tests: migrated ...AddBondWithManyVlans to the new functiona...

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: tests: migrated ...AddBondWithManyVlans to the new functional tests .. Patch Set 2: Code-Review-1 (2 comments)

Change in vdsm[master]: netlink: monitor: join scanner thread on __exit__

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: netlink: monitor: join scanner thread on __exit__ .. Patch Set 3: (1 comment)

Change in vdsm[master]: netlink: monitor: join scanner thread on __exit__

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: netlink: monitor: join scanner thread on __exit__ .. Patch Set 3: (1 comment)

Change in vdsm[master]: netlink: monitor: join scanner thread on __exit__

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: netlink: monitor: join scanner thread on __exit__ .. Patch Set 4: Code-Review+1 -- To view, visit

Change in vdsm[master]: Adding grub2-tool requirement which host-deploy requires

2017-01-03 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: Adding grub2-tool requirement which host-deploy requires .. Patch Set 2: (1 comment)

Change in vdsm[master]: rpmlint: ignore only limited set of errors

2017-01-03 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: rpmlint: ignore only limited set of errors .. Patch Set 7: Code-Review+1 -- To view, visit

Change in vdsm[ovirt-4.1]: automation: adding fc25 conf files

2017-01-03 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: automation: adding fc25 conf files .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/69244

Change in vdsm[ovirt-4.1]: automation: adding fc25 conf files

2017-01-03 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: automation: adding fc25 conf files .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/69244 To

Change in vdsm[ovirt-4.1]: automation: adding fc25 conf files

2017-01-03 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has submitted this change and it was merged. Change subject: automation: adding fc25 conf files .. automation: adding fc25 conf files added conf files for build

Change in vdsm[master]: Adding grub2-tool requirement which host-deploy requires

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: Adding grub2-tool requirement which host-deploy requires .. Patch Set 2: -Code-Review (1 comment)

Change in vdsm[master]: tests: Fix EINTR errors in checker tests

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: tests: Fix EINTR errors in checker tests .. Patch Set 4: Code-Review+2 seems sane. -- To view, visit

Change in vdsm[master]: tests: Fix EINTR errors in checker tests

2017-01-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: Fix EINTR errors in checker tests .. tests: Fix EINTR errors in checker tests This patch fixes this