gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Move wait_for_completion inside QemuImgOperation
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Move wait_for_completion inside QemuImgOperation
..
Patch Set 3: Continuous-Integration+1
jenkins is broken on fedora now, ignoring it.
--
To view,
Nir Soffer has submitted this change and it was merged.
Change subject: qemuimg: Move wait_for_completion inside QemuImgOperation
..
qemuimg: Move wait_for_completion inside QemuImgOperation
The Image class implemented logic
Adam Litke has posted comments on this change.
Change subject: qemuimg: Move wait_for_completion inside QemuImgOperation
..
Patch Set 3: Verified+1
Verified with SPM Move Disk flow.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: Implement SDM.copy_data
..
Patch Set 6: Code-Review-1
(4 comments)
Lets separate locking into the next patch.
Nir Soffer has posted comments on this change.
Change subject: Implement SDM.copy_data
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/60420/4/vdsm/storage/sdm/api/copy_data.py
File
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Move wait_for_completion inside QemuImgOperation
..
Patch Set 3:
Can you verify?
--
To view, visit https://gerrit.ovirt.org/60691
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Move wait_for_completion inside QemuImgOperation
..
Patch Set 3: Code-Review+2
(1 comment)
Thanks
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Move wait_for_completion inside QemuImgOperation
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
gerrit-hooks has posted comments on this change.
Change subject: Implement SDM.copy_data
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
Adam Litke has posted comments on this change.
Change subject: qemuimg: Move wait_for_completion inside QemuImgOperation
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/60691/1/lib/vdsm/qemuimg.py
File
Adam Litke has posted comments on this change.
Change subject: Implement SDM.copy_data
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/60420/4/vdsm/storage/sdm/api/copy_data.py
File
gerrit-hooks has posted comments on this change.
Change subject: sdm: base.Job should not always require host_id
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/60418
To
Adam Litke has abandoned this change.
Change subject: sdm: base.Job should not always require host_id
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/60418
To unsubscribe, visit https://gerrit.ovirt.org/settings
Nir Soffer has posted comments on this change.
Change subject: storage: add getDeviceList discard related fields
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/60628/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Nir Soffer has posted comments on this change.
Change subject: vm: storage: drop legacy graphics config support
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/60325/5//COMMIT_MSG
Commit Message:
Line 6:
Line 7:
Nir Soffer has posted comments on this change.
Change subject: vm: storage: drop legacy network config support
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/60324/5//COMMIT_MSG
Commit Message:
Line 6:
Line 7: vm:
Francesco Romani has posted comments on this change.
Change subject: docs: add README about logging configuration
..
Patch Set 1: Verified+1
only doc, we can't break anything here.
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: vm: storage: drop legacy graphics config support
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/60325/5//COMMIT_MSG
Commit Message:
Line 6:
Line
Francesco Romani has posted comments on this change.
Change subject: vm: storage: drop legacy network config support
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/60324/5//COMMIT_MSG
Commit Message:
Line 6:
Line
Francesco Romani has posted comments on this change.
Change subject: vm: storage: drop legacy drive config support
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/60323/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line
Nir Soffer has posted comments on this change.
Change subject: vm: storage: drop legacy graphics config support
..
Patch Set 5: Code-Review-1
Please fix the commit message, this is not about storage.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: vm: always expect Vm devices to be sent
..
Patch Set 5: Code-Review+2
Based on Arik and Milan reviews.
--
To view, visit https://gerrit.ovirt.org/60322
To
gerrit-hooks has posted comments on this change.
Change subject: schema: fix VM.create parameters
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: vm: storage: drop legacy drive config support
..
Patch Set 5: Code-Review-1
Please answer the questions in
Nir Soffer has posted comments on this change.
Change subject: vm: storage: drop legacy drive config support
..
Patch Set 5:
Waiting for acks from the virt team.
--
To view, visit https://gerrit.ovirt.org/60323
To
Nir Soffer has posted comments on this change.
Change subject: vm: storage: drop legacy network config support
..
Patch Set 5: Code-Review-1
Please fix the commit message, this is not about storage.
--
To view, visit
Nir Soffer has submitted this change and it was merged.
Change subject: schema: fix VM.create parameters
..
schema: fix VM.create parameters
Fix the parameters of this verb to match what Engine 4.0.0 actually sends.
gerrit-hooks has posted comments on this change.
Change subject: contrib: add simple tool to prettify python dumps
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Nir Soffer has submitted this change and it was merged.
Change subject: contrib: add simple tool to prettify python dumps
..
contrib: add simple tool to prettify python dumps
We often need to feed log dumps into tests, like
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Move wait_for_completion inside QemuImgOperation
..
Patch Set 2: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/60691
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: tests: Introduce qemu-io pattern verification utils
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Nir Soffer has submitted this change and it was merged.
Change subject: tests: Introduce qemu-io pattern verification utils
..
tests: Introduce qemu-io pattern verification utils
qemu-io is a utility that is useful for testing
Nir Soffer has posted comments on this change.
Change subject: tests: Introduce qemu-io pattern verification utils
..
Patch Set 3: Verified+1
Verified by tests on el7.
--
To view, visit https://gerrit.ovirt.org/60615
To
Nir Soffer has posted comments on this change.
Change subject: tests: Introduce qemu-io pattern verification utils
..
Patch Set 3: Continuous-Integration+1
Fedora tests are broken, we will have to continue without them.
--
Nir Soffer has posted comments on this change.
Change subject: tests: Introduce qemu-io pattern verification utils
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60615
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Move wait_for_completion inside QemuImgOperation
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/60691/1/lib/vdsm/qemuimg.py
File
Nir Soffer has posted comments on this change.
Change subject: automation: add fc24
..
Patch Set 1: Code-Review-1
This create another duplicate of packages list for other distributions.
We cannot maintain this duplication.
Francesco Romani has posted comments on this change.
Change subject: rpc: Use Suppressed class instead of logging workarounds
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60099
To unsubscribe,
Francesco Romani has posted comments on this change.
Change subject: logging: Introduce throttledlog
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60100
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: rpc: Log calls of API methods with possibly large results
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60098
To unsubscribe,
Francesco Romani has posted comments on this change.
Change subject: xmlrpc: Hide fenceNode password in the log
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60096
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: rpc: Lower logging priority just for getAllVmStats
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60097
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: rpc: Log RPC call summary on info level
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60102
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60101
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: sla: Use GuestIoTuneOptional collector in MOM
..
Patch Set 2:
* #1353559::Update tracker: OK
* Set MODIFIED::bug 1353559#1353559FAILED, illegal change
Francesco Romani has posted comments on this change.
Change subject: Configure mom to ignore missing balloon device
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60524
To unsubscribe, visit
Francesco Romani has submitted this change and it was merged.
Change subject: sla: Use GuestIoTuneOptional collector in MOM
..
sla: Use GuestIoTuneOptional collector in MOM
All major collectors in MOM now have the optional
gerrit-hooks has posted comments on this change.
Change subject: Configure mom to ignore missing balloon device
..
Patch Set 2:
* #1337882::Update tracker: OK
* Set MODIFIED::bug 1337882#1337882FAILED, illegal change
Francesco Romani has posted comments on this change.
Change subject: sla: Use GuestIoTuneOptional collector in MOM
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60525
To unsubscribe, visit
Francesco Romani has submitted this change and it was merged.
Change subject: Configure mom to ignore missing balloon device
..
Configure mom to ignore missing balloon device
In the past MOM was only responsible for
Francesco Romani has posted comments on this change.
Change subject: schema: fix VM.create parameters
..
Patch Set 9: Verified+1
This works (VM gets created), but doesn't seem to completely fix the issue. I'm
not sure all the
Edward Haas has posted comments on this change.
Change subject: net: Silently skip persisting a non existance running-config
..
Patch Set 1:
I'm not sure if this is the correct approach to the issue seen.
The scenario of the
gerrit-hooks has posted comments on this change.
Change subject: net: Silently skip persisting a non existance running-config
..
Patch Set 1:
* #1329387::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1329387::OK,
Edward Haas has uploaded a new change for review.
Change subject: net: Silently skip persisting a non existance running-config
..
net: Silently skip persisting a non existance running-config
In vdsm-store-net-config unified,
Francesco Romani has posted comments on this change.
Change subject: vm: api: move vm status check into migrate()
..
Patch Set 3:
Id90a39820141365b865e861e1f89704947452c78 was merged recently, that should
explain the PS2->3
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 8:
CI failure is unrelated:
13:10:58 == Running the shellscript automation/check-patch.sh
Francesco Romani has posted comments on this change.
Change subject: api: tests: add test for VM.create
..
Patch Set 2: Verified-1
need to fix Makefiles
--
To view, visit https://gerrit.ovirt.org/60382
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: tests: Introduce qemu-io pattern verification utils
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/60615/2/tests/storagetestlibTests.py
File
gerrit-hooks has posted comments on this change.
Change subject: tests: Introduce qemu-io pattern verification utils
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Move wait_for_completion inside QemuImgOperation
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
gerrit-hooks has posted comments on this change.
Change subject: Implement SDM.copy_data
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
Adam Litke has posted comments on this change.
Change subject: qemuimg: Move wait_for_completion inside QemuImgOperation
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/60691/1/lib/vdsm/qemuimg.py
File
Adam Litke has posted comments on this change.
Change subject: qemuimg: Move wait_for_completion inside QemuImgOperation
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/60691/1/lib/vdsm/qemuimg.py
File
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/59834/6/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
Line 722:
gerrit-hooks has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 8:
* #1350465::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1350465::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 7:
* #1350465::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1350465::OK, public bug
* Check
Martin Polednik has posted comments on this change.
Change subject: vm: api: move vm status check into migrate()
..
Patch Set 3: Code-Review+1
Not sure if rebased correctly (see API.py PS#2->3), but that is just gerrit
Francesco Romani has posted comments on this change.
Change subject: Fix return value names for VM.ioTune calls
..
Patch Set 2:
Ignore my comment, I was fooled by a wrong 'git grep'.
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: Fix return value names for VM.ioTune calls
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60513
To unsubscribe, visit
Martin Sivák has posted comments on this change.
Change subject: Fix return value names for VM.ioTune calls
..
Patch Set 2:
I do not see any reference to the return value name in the schema. Can you be
more specific?
--
To
Francesco Romani has posted comments on this change.
Change subject: Fix return value names for VM.ioTune calls
..
Patch Set 2: Code-Review+1
I think the schema needs to be updated too
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: Fix return value names for VM.ioTune calls
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60513
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: Modify reports to metrics
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60450
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: command: Make AsyncProc accept None in stderr
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Francesco Romani has posted comments on this change.
Change subject: automation: add fc24
..
Patch Set 1: Code-Review+1
Thanks Sandro!
--
To view, visit https://gerrit.ovirt.org/60725
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vm: api: move vm status check into migrate()
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/60608/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
PS2,
Sandro Bonazzola has uploaded a new change for review.
Change subject: automation: add fc24
..
automation: add fc24
Change-Id: I5c1f04d112ed8eab2e72ba629a3d21ec89536e02
Signed-off-by: Sandro Bonazzola
---
gerrit-hooks has posted comments on this change.
Change subject: automation: add fc24
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: vm: api: move vm status check into migrate()
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: vm: reorder operations in _domDependentInit
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: vmxml: move namespace declaration
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: tests: containers: add testsuite
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: vm: split guest agent init from domDependentInit
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: vm: split device init from domDependentInit
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: vmxml: export container metadata
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: network: supervdsm: configure container networks
..
Patch Set 28:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 35:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: supervdsm: expose systemd utilities
..
Patch Set 16:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: vm: split vcpu settings from domDependentInit
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: virt: utils: add is_kvm helper
..
Patch Set 20:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: cmdutils: enhance systemd_run
..
Patch Set 16:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module
..
Patch Set 16:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: vm: reorder sampling initialization
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: hostdev: use specific device classes in HostDevice
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: hostdev: move pci device code to separate class
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: hostdev: use proper scsi address
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: hostdev: move scsi device code to separate class
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: hostdev: cleanup udev files after PCI host devices
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: hostdev: move usb device code to separate class
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
1 - 100 of 151 matches
Mail list logo