Federico Simoncelli has posted comments on this change.
Change subject: build: closer to open source versioning and release cycle
..
Patch Set 1: (2 inline comments)
Commit
Federico Simoncelli has posted comments on this change.
Change subject: build: closer to open source versioning and release cycle
..
Patch Set 1: (1 inline comment)
Commit
Federico Simoncelli has posted comments on this change.
Change subject: Override getLocalPathBase in GlusterFSConnection
..
Patch Set 1: Looks good to me, but someone else must approve
My only remark, given the small size of
Federico Simoncelli has posted comments on this change.
Change subject: Introduce getLocalPathBase for MountConnection
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit
Federico Simoncelli has posted comments on this change.
Change subject: build: closer to open source versioning and release cycle
..
Patch Set 1: I would prefer that you didn't submit this
(5 inline comments)
Federico Simoncelli has posted comments on this change.
Change subject: If attachSD fails - rescan for new vgs not visible from spm
..
Patch Set 1: No score
--
To view, visit http://gerrit.ovirt.org/10495
To unsubscribe, visit
Federico Simoncelli has submitted this change and it was merged.
Change subject: tool: _enable_bond_dev: reopen bonding_masters per bond
..
tool: _enable_bond_dev: reopen bonding_masters per bond
Writing multiple +bondnames
Federico Simoncelli has uploaded a new change for review.
Change subject: build: add load_needed_modules.py.in to EXTRA_DIST
..
build: add load_needed_modules.py.in to EXTRA_DIST
Change-Id:
Federico Simoncelli has posted comments on this change.
Change subject: build: add load_needed_modules.py.in to EXTRA_DIST
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Federico Simoncelli has uploaded a new change for review.
Change subject: hsm: always check validateNotSPM when disconnecting from a pool
..
hsm: always check validateNotSPM when disconnecting from a pool
At the moment of this
Federico Simoncelli has uploaded a new change for review.
Change subject: spec: use the fedora systemd macros
..
spec: use the fedora systemd macros
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=850412
Change-Id:
Federico Simoncelli has uploaded a new change for review.
Change subject: spec: update sanlock dependencies
..
spec: update sanlock dependencies
Forcing some old fedora installations to update sanlock to the latest
version.
Federico Simoncelli has posted comments on this change.
Change subject: spec: use the fedora systemd macros
..
Patch Set 1:
Federico, do you mind to rebase your patch based on the new macro
with_systemd ? It's not only
Federico Simoncelli has uploaded a new change for review.
Change subject: schema: add getStorageRepoStats to the json schema
..
schema: add getStorageRepoStats to the json schema
Change-Id:
Federico Simoncelli has abandoned this change.
Change subject: schema: add getStorageRepoStats to the json schema
..
Patch Set 1: Abandoned
This was already present as StorageDomainVitals.
--
To view, visit
Federico Simoncelli has submitted this change and it was merged.
Change subject: After fail to connect to supervdsm more than 3 time vdsm gets
into panic
..
After fail to connect to supervdsm more than 3 time vdsm gets into
Federico Simoncelli has posted comments on this change.
Change subject: Added a support for a guest hibernate command.
..
Patch Set 16: I would prefer that you didn't submit this
(3 inline comments)
Federico Simoncelli has abandoned this change.
Change subject: image: do not delete the template on deleteImage
..
Patch Set 2: Abandoned
--
To view, visit http://gerrit.ovirt.org/12105
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: image: do not delete the template on deleteImage
..
Patch Set 1: (1 inline comment)
File
Federico Simoncelli has posted comments on this change.
Change subject: image: do not delete the template on deleteImage
..
Patch Set 1: (1 inline comment)
File
Federico Simoncelli has posted comments on this change.
Change subject: image: do not delete the template on deleteImage
..
Patch Set 2: (2 inline comments)
File
Federico Simoncelli has posted comments on this change.
Change subject: Do not delete the template when zeroing a dependant image.
..
Patch Set 1: Verified
Verified with the provided tests and by Lee on his environment (see
Federico Simoncelli has posted comments on this change.
Change subject: Do not delete the template when zeroing a dependant image.
..
Patch Set 1: No score
Wrong patch. Sorry.
--
To view, visit http://gerrit.ovirt.org/12178
Federico Simoncelli has posted comments on this change.
Change subject: image: do not delete the template on deleteImage
..
Patch Set 2: Verified
Verified with the provided tests and by Lee on his environment (see previous
Federico Simoncelli has posted comments on this change.
Change subject: image: do not delete the template on deleteImage
..
Patch Set 1: (2 inline comments)
File
Federico Simoncelli has posted comments on this change.
Change subject: image: do not delete the template on deleteImage
..
Patch Set 1: (1 inline comment)
File
Federico Simoncelli has uploaded a new change for review.
Change subject: image: do not delete the template on deleteImage
..
image: do not delete the template on deleteImage
Bug-Url:
Federico Simoncelli has posted comments on this change.
Change subject: hsm: Check image alignment using virt-alignment-scan
..
Patch Set 1: (1 inline comment)
File
Federico Simoncelli has posted comments on this change.
Change subject: stats: compute the iso prefix asynchronously
..
Patch Set 2: (1 inline comment)
File
Federico Simoncelli has posted comments on this change.
Change subject: stats: compute the iso prefix asynchronously
..
Patch Set 2: (1 inline comment)
File
Federico Simoncelli has uploaded a new change for review.
Change subject: blocksd: skip broken images in getAllVolumes
..
blocksd: skip broken images in getAllVolumes
When one of the images in the storage pool was damaged some
Federico Simoncelli has posted comments on this change.
Change subject: blocksd: skip broken images in getAllVolumes
..
Patch Set 2: Verified
Verified: before the patch it is impossible to delete a VM if any image in the
Federico Simoncelli has posted comments on this change.
Change subject: misc: handle properly timeout=-1 in NoIntrPoll
..
Patch Set 1: (1 inline comment)
File
Federico Simoncelli has posted comments on this change.
Change subject: Fedora 18: require a newer udev
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11534
To unsubscribe, visit
Federico Simoncelli has submitted this change and it was merged.
Change subject: Fedora 18: require a newer udev
..
Fedora 18: require a newer udev
Due to https://bugzilla.redhat.com/903716 `udev: device node permissions
not
Federico Simoncelli has posted comments on this change.
Change subject: removing the use of zombie reaper from supervdsm
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11491
To
Federico Simoncelli has posted comments on this change.
Change subject: fix sloppy backport of safelease rename
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11544
To unsubscribe, visit
Federico Simoncelli has submitted this change and it was merged.
Change subject: fix sloppy backport of safelease rename
..
fix sloppy backport of safelease rename
Somehow, this sloppy backport of I74070ebb43dd726362900a0746c
Federico Simoncelli has submitted this change and it was merged.
Change subject: removing the use of zombie reaper from supervdsm
..
removing the use of zombie reaper from supervdsm
This may solve validateAccess errors, but
Federico Simoncelli has posted comments on this change.
Change subject: Storage: Check that underlying file system supports direct IO
..
Patch Set 7: Looks good to me, but someone else must approve
--
To view, visit
Federico Simoncelli has posted comments on this change.
Change subject: upgrade: catch MetaDataKeyNotFoundError when preparing images
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11485
Federico Simoncelli has submitted this change and it was merged.
Change subject: upgrade: catch MetaDataKeyNotFoundError when preparing images
..
upgrade: catch MetaDataKeyNotFoundError when preparing images
Ensure that we
Federico Simoncelli has posted comments on this change.
Change subject: Fedora 18: require a newer udev
..
Patch Set 1: Looks good to me, approved
I just verified that systemd-197-1.fc18.2.x86_64.rpm is fixing our issue.
--
Federico Simoncelli has posted comments on this change.
Change subject: clusterlock: add the local locking implementation
..
Patch Set 4: (2 inline comments)
File
Federico Simoncelli has posted comments on this change.
Change subject: udev: Race fix- load and trigger dev rule
..
Patch Set 2: (1 inline comment)
Commit Message
Line 11:
Federico Simoncelli has posted comments on this change.
Change subject: misc: handle properly timeout=-1 in NoIntrPoll
..
Patch Set 1: (2 inline comments)
File
Federico Simoncelli has submitted this change and it was merged.
Change subject: udev: Race fix- load and trigger dev rule
..
udev: Race fix- load and trigger dev rule
The rule file is generated, yet not synch-loaded in
Federico Simoncelli has posted comments on this change.
Change subject: Change scsi_id command path to be configured at runtime
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/11393
To unsubscribe, visit
Federico Simoncelli has submitted this change and it was merged.
Change subject: Change scsi_id command path to be configured at runtime
..
Change scsi_id command path to be configured at runtime
On fedora 18 scsi_id path is
Hello Allon Mureinik, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/11464
to review the following change.
Change subject: domain: select the cluster lock using makeClusterLock
..
Hello Allon Mureinik, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/11463
to review the following change.
Change subject: misc: rename safelease to clusterlock
..
misc: rename
Hello Ayal Baron, Haim Ateya,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/11462
to review the following change.
Change subject: upgrade: force upgrade to v2 before upgrading to v3
..
upgrade:
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/11465
to review the following change.
Change subject: clusterlock: add the local locking implementation
..
clusterlock: add the
Federico Simoncelli has posted comments on this change.
Change subject: upgrade: force upgrade to v2 before upgrading to v3
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11462
Federico Simoncelli has submitted this change and it was merged.
Change subject: upgrade: force upgrade to v2 before upgrading to v3
..
upgrade: force upgrade to v2 before upgrading to v3
During the upgrade of a domain to
Federico Simoncelli has posted comments on this change.
Change subject: misc: rename safelease to clusterlock
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11463
To unsubscribe,
Federico Simoncelli has posted comments on this change.
Change subject: clusterlock: add the local locking implementation
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11465
To
Federico Simoncelli has submitted this change and it was merged.
Change subject: clusterlock: add the local locking implementation
..
clusterlock: add the local locking implementation
In order to have a faster and more
Federico Simoncelli has posted comments on this change.
Change subject: Explicitly shutdown m2crypto socket
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11384
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: spec: requires selinux-policy to avoid selinux failure on
access tls cert
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/11364
To
Federico Simoncelli has posted comments on this change.
Change subject: spec: requires selinux-policy to avoid selinux failure on
access tls cert
..
Patch Set 1: Looks good to me, approved
--
To view, visit
Federico Simoncelli has posted comments on this change.
Change subject: spec: require policycoreutils and skip sebool errors
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11363
Federico Simoncelli has submitted this change and it was merged.
Change subject: spec: require policycoreutils and skip sebool errors
..
spec: require policycoreutils and skip sebool errors
In order to avoid a policycoreutils
Federico Simoncelli has submitted this change and it was merged.
Change subject: spec: requires selinux-policy to avoid selinux failure on
access tls cert
..
spec: requires selinux-policy to avoid selinux failure on access tls
Federico Simoncelli has posted comments on this change.
Change subject: vdsmd.service: require either ntpd or chronyd
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11366
To
Federico Simoncelli has submitted this change and it was merged.
Change subject: vdsmd.service: require either ntpd or chronyd
..
vdsmd.service: require either ntpd or chronyd
Fedora 18 ships with chronyd by default, which
Federico Simoncelli has posted comments on this change.
Change subject: isRunning didn't check local variable before reading saved data
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit
Federico Simoncelli has submitted this change and it was merged.
Change subject: isRunning didn't check local variable before reading saved data
..
isRunning didn't check local variable before reading saved data
All internal
Federico Simoncelli has uploaded a new change for review.
Change subject: misc: handle properly timeout=-1 in NoIntrPoll
..
misc: handle properly timeout=-1 in NoIntrPoll
Change-Id: Iefc4d17559d3335ef6699cb83923c3bd255c916b
Federico Simoncelli has posted comments on this change.
Change subject: clusterlock: add the local locking implementation
..
Patch Set 4: Verified
Verified: create a V3 iscsi domain, create a V3 local domain. SPM is acquired.
Federico Simoncelli has posted comments on this change.
Change subject: misc: handle properly timeout=-1 in NoIntrPoll
..
Patch Set 1: Verified
Verified with the provided test (both positive and negative).
--
To view, visit
Federico Simoncelli has posted comments on this change.
Change subject: upgrade: Catch MetaDataKeyNotFoundError when preparing
partially removed volumes.
..
Patch Set 1: I would prefer that you didn't submit this
(2 inline
Federico Simoncelli has posted comments on this change.
Change subject: domain: remove race condition in extend
..
Patch Set 2: Verified
Verified: a block storage domain was successfully extended.
--
To view, visit
Federico Simoncelli has posted comments on this change.
Change subject: misc: rename safelease to clusterlock
..
Patch Set 5: Verified; Looks good to me, but someone else must approve
Minor change in Makefile.am. Verified
Federico Simoncelli has posted comments on this change.
Change subject: upgrade: catch MetaDataKeyNotFoundError when preparing images
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11281
Federico Simoncelli has posted comments on this change.
Change subject: clusterlock: add the local locking implementation
..
Patch Set 3: (1 inline comment)
File
Federico Simoncelli has abandoned this change.
Change subject: tool: skip sebool entry setup when missing
..
Patch Set 2: Abandoned
--
To view, visit http://gerrit.ovirt.org/9827
To unsubscribe, visit
Federico Simoncelli has uploaded a new change for review.
Change subject: domain: remove race condition in extend
..
domain: remove race condition in extend
During a domain extension the metadata mappings are checked against
Federico Simoncelli has posted comments on this change.
Change subject: Nits on isLocalFsDomain()
..
Patch Set 2: (4 inline comments)
Commit Message
Line 3: AuthorDate:
Federico Simoncelli has posted comments on this change.
Change subject: misc: rename safelease to clusterlock
..
Patch Set 4: Verified
Verified: acquire spm on V3 on iscsi (no regressions), acquire spm on a local
domain (no
Federico Simoncelli has posted comments on this change.
Change subject: domain: select the cluster lock using makeClusterLock
..
Patch Set 3: Verified
Verified: acquire spm on V3 on iscsi (no regressions), acquire spm on a
Federico Simoncelli has posted comments on this change.
Change subject: clusterlock: add the local locking implementation
..
Patch Set 3: Verified
Verified: acquire spm on V3 on iscsi (no regressions), acquire spm on a local
Federico Simoncelli has posted comments on this change.
Change subject: Support for GLUSTERFS_DOMAIN
..
Patch Set 14: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6856
To unsubscribe, visit
Federico Simoncelli has abandoned this change.
Change subject: netinfo: remove special characters from DUMMY_BRIDGE
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/10653
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: Check that underlying filesystem supports direct IO before
creating a domain on it
..
Patch Set 5: (1 inline comment)
Federico Simoncelli has posted comments on this change.
Change subject: Storage: Check that underlying file system supports direct IO
..
Patch Set 6: (1 inline comment)
File
Federico Simoncelli has posted comments on this change.
Change subject: use qemu-img convert to copy sparse volumes when moving a vm
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10979
To
Federico Simoncelli has posted comments on this change.
Change subject: misc: rename safelease to clusterlock
..
Patch Set 3:
Just to make sure Jenkins doesn't go ignored by Ayal's +2.
Please double check, they're not pep8
Federico Simoncelli has posted comments on this change.
Change subject: Support for GLUSTERFS_DOMAIN
..
Patch Set 13: I would prefer that you didn't submit this
(1 inline comment)
Minor issue. The rest looks fine to me.
Federico Simoncelli has posted comments on this change.
Change subject: use qemu-img convert to copy sparse volumes when moving a vm
..
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
It's a -1
Federico Simoncelli has posted comments on this change.
Change subject: Check that underlying filesystem supports direct IO before
creating a domain on it
..
Patch Set 5: I would prefer that you didn't submit this
(2 inline
Federico Simoncelli has posted comments on this change.
Change subject: udev: Race fix- load and trigger dev rule
..
Patch Set 10: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10758
Federico Simoncelli has posted comments on this change.
Change subject: tests/functional: Add GlusterSD functional test
..
Patch Set 4: (2 inline comments)
File
Federico Simoncelli has posted comments on this change.
Change subject: Support for GLUSTERFS_DOMAIN
..
Patch Set 12: (6 inline comments)
Few minor comments. Marking as -1 for visibility. WRT the architecture I'm not
sure if
Federico Simoncelli has posted comments on this change.
Change subject: Support for GLUSTERFS_DOMAIN
..
Patch Set 12: I would prefer that you didn't submit this
Few minor comments. Marking as -1 for visibility. WRT the
Federico Simoncelli has posted comments on this change.
Change subject: seboolsetup: catch RuntimeError expection
..
Patch Set 1:
I'm not sure I understand/like this logic:
except RuntimeError, e:
if
Federico Simoncelli has posted comments on this change.
Change subject: upgrade: force upgrade to v2 before upgrading to v3
..
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
Federico Simoncelli has posted comments on this change.
Change subject: udev: Race fix- load and trigger dev rule(#891300)
..
Patch Set 3: (3 inline comments)
Commit Message
Federico Simoncelli has posted comments on this change.
Change subject: udev: Race fix- load and trigger dev rule
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10758
Federico Simoncelli has posted comments on this change.
Change subject: udev: Race fix- load and trigger dev rule
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10758
501 - 600 of 1323 matches
Mail list logo
