Change in vdsm[master]: xmlrpc: Support HTTP 1.1

Ayal Baron has posted comments on this change. Change subject: xmlrpc: Support HTTP 1.1 .. Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/24294/6//COMMIT_MSG Commit Message: Line 16: methods are used only on Python

Change in vdsm[master]: [WIP] Towards a more (block) secure HSM.

Ayal Baron has posted comments on this change. Change subject: [WIP] Towards a more (block) secure HSM. .. Patch Set 7: (3 comments) http://gerrit.ovirt.org/#/c/2218/7/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 310:

Change in vdsm[master]: [WIP] lvm: Add an option to replace locking type 4

Ayal Baron has posted comments on this change. Change subject: [WIP] lvm: Add an option to replace locking type 4 .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/23645/2/vdsm/storage/lvm.py File vdsm/storage/lvm.py:

Change in vdsm[master]: [WIP] Create storage pool using command type 1

Ayal Baron has posted comments on this change. Change subject: [WIP] Create storage pool using command type 1 .. Patch Set 2: (5 comments) http://gerrit.ovirt.org/#/c/23647/2/vdsm/storage/blockSD.py File

Change in vdsm[master]: sp: Remove invalid validation of stale meta data

Ayal Baron has posted comments on this change. Change subject: sp: Remove invalid validation of stale meta data .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24568 To unsubscribe, visit

Change in vdsm[master]: sp: stop all poolMonitoredDomains on disconnect

Ayal Baron has posted comments on this change. Change subject: sp: stop all poolMonitoredDomains on disconnect .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24088 To unsubscribe, visit

Change in vdsm[master]: sp: Nest try-finally for temporary secure change

Ayal Baron has posted comments on this change. Change subject: sp: Nest try-finally for temporary secure change .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/23955 To unsubscribe, visit

Change in vdsm[master]: vm: discover volume path from xml definition

Ayal Baron has posted comments on this change. Change subject: vm: discover volume path from xml definition .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24202 To unsubscribe, visit

Change in vdsm[master]: api: domainDict is optional in connectStoragePool

Ayal Baron has posted comments on this change. Change subject: api: domainDict is optional in connectStoragePool .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24089 To unsubscribe, visit

Change in vdsm[master]: sp: stop all poolMonitoredDomains on disconnect

Ayal Baron has posted comments on this change. Change subject: sp: stop all poolMonitoredDomains on disconnect .. Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/24088/1/vdsm/storage/sp.py File

Change in vdsm[master]: sp: stop all poolMonitoredDomains on disconnect

Ayal Baron has posted comments on this change. Change subject: sp: stop all poolMonitoredDomains on disconnect .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24088/1/vdsm/storage/sp.py File vdsm/storage/sp.py: Line

Change in vdsm[master]: clientIF: Remove unnecessary device is disk check in prepare...

Ayal Baron has posted comments on this change. Change subject: clientIF: Remove unnecessary device is disk check in prepareVolumePath .. Patch Set 2: Code-Review+2 This patch is fine, the discussion about yes or no removing

Change in vdsm[master]: clientIF: Teardown volume path only for VDSM images

Ayal Baron has posted comments on this change. Change subject: clientIF: Teardown volume path only for VDSM images .. Patch Set 7: Code-Review+2 Symmetricity issue is solved by http://gerrit.ovirt.org/#/c/22363 -- To view,

Change in vdsm[master]: sp: improve pool creation error handling

Ayal Baron has posted comments on this change. Change subject: sp: improve pool creation error handling .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/22818/2/vdsm/storage/sp.py File vdsm/storage/sp.py: Line 139:

Change in vdsm[master]: sp: fix pool membership check in attachSD

Ayal Baron has posted comments on this change. Change subject: sp: fix pool membership check in attachSD .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/23446/2/vdsm/storage/sp.py File

Change in vdsm[master]: sp: fix pool membership check in attachSD

Ayal Baron has posted comments on this change. Change subject: sp: fix pool membership check in attachSD .. Patch Set 2: -Code-Review well, once you fix Dan's comment -- To view, visit http://gerrit.ovirt.org/23446 To

Change in vdsm[master]: sd: add inquireClusterLock method to StorageDomain

Ayal Baron has posted comments on this change. Change subject: sd: add inquireClusterLock method to StorageDomain .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21426 To unsubscribe, visit

Change in vdsm[master]: sp: receive domains map in connectStoragePool

Ayal Baron has posted comments on this change. Change subject: sp: receive domains map in connectStoragePool .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21427 To unsubscribe, visit

Change in vdsm[master]: sp: refactor out the metadata access from StoragePool

Ayal Baron has posted comments on this change. Change subject: sp: refactor out the metadata access from StoragePool .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22132 To unsubscribe, visit

Change in vdsm[master]: sp: use setDomainsMap in reconstructMaster

Ayal Baron has posted comments on this change. Change subject: sp: use setDomainsMap in reconstructMaster .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/23385 To unsubscribe, visit

Change in vdsm[master]: securable: refactor the securable implementation

Ayal Baron has posted comments on this change. Change subject: securable: refactor the securable implementation .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22115 To unsubscribe, visit

Change in vdsm[master]: sp: changing un-shared treatment in the createVolume function

Ayal Baron has posted comments on this change. Change subject: sp: changing un-shared treatment in the createVolume function .. Patch Set 9: Code-Review+2 The changes don't cover the general safety problem that existed before

Change in vdsm[master]: securable: refactor the securable implementation

Ayal Baron has posted comments on this change. Change subject: securable: refactor the securable implementation .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22115 To unsubscribe, visit

Change in vdsm[master]: sd: add inquireClusterLock method to StorageDomain

Ayal Baron has posted comments on this change. Change subject: sd: add inquireClusterLock method to StorageDomain .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21426 To unsubscribe, visit

Change in vdsm[master]: sp: refactor out the metadata access from StoragePool

Ayal Baron has posted comments on this change. Change subject: sp: refactor out the metadata access from StoragePool .. Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/22132/2/vdsm/storage/hsm.py File

Change in vdsm[master]: sp: receive domains map in connectStoragePool

Ayal Baron has posted comments on this change. Change subject: sp: receive domains map in connectStoragePool .. Patch Set 2: (4 comments) http://gerrit.ovirt.org/#/c/21427/2/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line

Change in vdsm[master]: storageTests: Extract storage types and versions to an envir...

Ayal Baron has posted comments on this change. Change subject: storageTests: Extract storage types and versions to an environment variable .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/23259 To

Change in vdsm[master]: changing un-shared treatment in the volume share function

Ayal Baron has posted comments on this change. Change subject: changing un-shared treatment in the volume share function .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/23260/3/vdsm/storage/volume.py

Change in vdsm[master]: sp: move validatePoolSD in the StoragePool class

Ayal Baron has posted comments on this change. Change subject: sp: move validatePoolSD in the StoragePool class .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21787 To unsubscribe, visit

Change in vdsm[master]: sp: improve masterMigrate safety

Ayal Baron has posted comments on this change. Change subject: sp: improve masterMigrate safety .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22419 To unsubscribe, visit

Change in vdsm[master]: downloadFromStream

Ayal Baron has posted comments on this change. Change subject: downloadFromStream .. Patch Set 4: (7 comments) Commit Message Line 5: CommitDate: 2014-01-12 14:05:19 +0200

Change in vdsm[master]: sp: improve masterMigrate safety

Ayal Baron has posted comments on this change. Change subject: sp: improve masterMigrate safety .. Patch Set 3: (1 comment) File vdsm/storage/sp.py Line 866:

Change in vdsm[master]: sp: move validatePoolSD in the StoragePool class

Ayal Baron has posted comments on this change. Change subject: sp: move validatePoolSD in the StoragePool class .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21787 To unsubscribe, visit

Change in vdsm[master]: sp: split metadata transaction in createMaster

Ayal Baron has posted comments on this change. Change subject: sp: split metadata transaction in createMaster .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22418 To unsubscribe, visit

Change in vdsm[master]: bootstrap: Return recovery error until hsm is ready

Ayal Baron has posted comments on this change. Change subject: bootstrap: Return recovery error until hsm is ready .. Patch Set 5: (1 comment) File

Change in vdsm[master]: hsm: Rescan multipath before loading lvm cache

Ayal Baron has posted comments on this change. Change subject: hsm: Rescan multipath before loading lvm cache .. Patch Set 3: Code-Review+2 Actually the race doesn't exist since sdCache.refreshStorage calls

Change in vdsm[master]: sp: improve masterMigrate safety

Ayal Baron has posted comments on this change. Change subject: sp: improve masterMigrate safety .. Patch Set 3: (1 comment) File vdsm/storage/sp.py Line 869:

Change in vdsm[master]: hsm: remove master info from getStorageDomainInfo

Ayal Baron has posted comments on this change. Change subject: hsm: remove master info from getStorageDomainInfo .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22824 To unsubscribe, visit

Change in vdsm[master]: misc: Fix exception re-raising in RollbackContext

Ayal Baron has posted comments on this change. Change subject: misc: Fix exception re-raising in RollbackContext .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22860 To unsubscribe, visit

Change in vdsm[master]: utils: Moved RollbackContext from misc to utils

Ayal Baron has posted comments on this change. Change subject: utils: Moved RollbackContext from misc to utils .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22861 To unsubscribe, visit

Change in vdsm[master]: utils: cleanup - typos, grammar and comments refinement

Ayal Baron has posted comments on this change. Change subject: utils: cleanup - typos, grammar and comments refinement .. Patch Set 8: (1 comment) File lib/vdsm/utils.py

Change in vdsm[master]: sp: improve pool creation error handling

Ayal Baron has posted comments on this change. Change subject: sp: improve pool creation error handling .. Patch Set 1: (1 comment) File vdsm/storage/sp.py Line 620:

Change in vdsm[master]: sp: refresh metadata on hsm when listing domains

Ayal Baron has posted comments on this change. Change subject: sp: refresh metadata on hsm when listing domains .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21786 To unsubscribe, visit

Change in vdsm[master]: sp: split metadata transaction in createMaster

Ayal Baron has posted comments on this change. Change subject: sp: split metadata transaction in createMaster .. Patch Set 4: (1 comment) See patch set 4 File

Change in vdsm[master]: sp: split metadata transaction in createMaster

Ayal Baron has posted comments on this change. Change subject: sp: split metadata transaction in createMaster .. Patch Set 4: (1 comment) File vdsm/storage/sp.py Line 695:

Change in vdsm[master]: sp: improve masterMigrate safety

Ayal Baron has posted comments on this change. Change subject: sp: improve masterMigrate safety .. Patch Set 2: (2 comments) File vdsm/storage/sp.py Line 768:

Change in vdsm[master]: hsm: remove master info from getStorageDomainInfo

Ayal Baron has posted comments on this change. Change subject: hsm: remove master info from getStorageDomainInfo .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22824 To unsubscribe, visit

Change in vdsm[master]: sp: encapsulate spm status in StoragePool

Ayal Baron has posted comments on this change. Change subject: sp: encapsulate spm status in StoragePool .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21527 To unsubscribe, visit

Change in vdsm[master]: sp: split metadata transaction in createMaster

Ayal Baron has posted comments on this change. Change subject: sp: split metadata transaction in createMaster .. Patch Set 2: (1 comment) File vdsm/storage/sd.py Line 771:

Change in vdsm[master]: Revert clientIF: rescan devices on failed hotplugDisk

Ayal Baron has posted comments on this change. Change subject: Revert clientIF: rescan devices on failed hotplugDisk .. Patch Set 4: Looks like there is a rebase issue with this patch, other than that looks fine. -- To view,

Change in vdsm[master]: hsm: Check all devices visibility after multipath rescan

Ayal Baron has posted comments on this change. Change subject: hsm: Check all devices visibility after multipath rescan .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21182 To unsubscribe, visit

Change in vdsm[master]: hsm: Do not hide errors when checking device visibility

Ayal Baron has posted comments on this change. Change subject: hsm: Do not hide errors when checking device visibility .. Patch Set 4: Code-Review-1 (1 comment) File

Change in vdsm[master]: clientIF: Rescan devices if device not found after vmHotplug...

Ayal Baron has posted comments on this change. Change subject: clientIF: Rescan devices if device not found after vmHotplugDisk .. Patch Set 6: (1 comment) File

Change in vdsm[master]: clientIF: Rescan devices if device not found after vmHotplug...

Ayal Baron has posted comments on this change. Change subject: clientIF: Rescan devices if device not found after vmHotplugDisk .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21181 To unsubscribe,

Change in vdsm[master]: Revert clientIF: rescan devices on failed hotplugDisk

Ayal Baron has posted comments on this change. Change subject: Revert clientIF: rescan devices on failed hotplugDisk .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21173 To unsubscribe, visit

Change in vdsm[master]: hsm: Do not hide errors when checking device visibility

Ayal Baron has posted comments on this change. Change subject: hsm: Do not hide errors when checking device visibility .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21211 To unsubscribe, visit

Change in vdsm[master]: clientIF: Rescan devices if device not found after vmHotplug...

Ayal Baron has posted comments on this change. Change subject: clientIF: Rescan devices if device not found after vmHotplugDisk .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21181 To unsubscribe,

Change in vdsm[ovirt-3.3]: fileSD: Fix image deletion on gluster domain

Ayal Baron has posted comments on this change. Change subject: fileSD: Fix image deletion on gluster domain .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22563 To unsubscribe, visit

Change in vdsm[master]: hsm: Check all devices visibility after multipath rescan

Ayal Baron has posted comments on this change. Change subject: hsm: Check all devices visibility after multipath rescan .. Patch Set 5: Code-Review+2 u -- To view, visit http://gerrit.ovirt.org/21182 To unsubscribe, visit

Change in vdsm[master]: supervdsmServer: Run sourceRouteThread in a thread

Ayal Baron has posted comments on this change. Change subject: supervdsmServer: Run sourceRouteThread in a thread .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22718 To unsubscribe, visit

Change in vdsm[master]: sp: split metadata transaction in createMaster

Ayal Baron has posted comments on this change. Change subject: sp: split metadata transaction in createMaster .. Patch Set 2: (3 comments) Commit Message Line 21: The two

Change in vdsm[master]: sp: remove unused recoveryMode from spmStart

Ayal Baron has posted comments on this change. Change subject: sp: remove unused recoveryMode from spmStart .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21556 To unsubscribe, visit

Change in vdsm[master]: sp: remove unused scsiFencing parameter

Ayal Baron has posted comments on this change. Change subject: sp: remove unused scsiFencing parameter .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21555 To unsubscribe, visit

Change in vdsm[master]: sp: specific method to validate the master version

Ayal Baron has posted comments on this change. Change subject: sp: specific method to validate the master version .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22130 To unsubscribe, visit

Change in vdsm[master]: hsm: refresh pool connection on connectStoragePool

Ayal Baron has posted comments on this change. Change subject: hsm: refresh pool connection on connectStoragePool .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22467 To unsubscribe, visit

Change in vdsm[master]: sp: add setMasterDomain to StoragePool

Ayal Baron has posted comments on this change. Change subject: sp: add setMasterDomain to StoragePool .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21659 To unsubscribe, visit

Change in vdsm[master]: sp: remove unused transaction in createMaster

Ayal Baron has posted comments on this change. Change subject: sp: remove unused transaction in createMaster .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22418 To unsubscribe, visit

Change in vdsm[master]: sp: remove automatic storage pool reconnection

Ayal Baron has posted comments on this change. Change subject: sp: remove automatic storage pool reconnection .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21424 To unsubscribe, visit

Change in vdsm[master]: sp: improve masterMigrate safety

Ayal Baron has posted comments on this change. Change subject: sp: improve masterMigrate safety .. Patch Set 1: (6 comments) File vdsm/storage/sp.py Line 879:

Change in vdsm[master]: sp: consolidate getMasterVersion in one method

Ayal Baron has posted comments on this change. Change subject: sp: consolidate getMasterVersion in one method .. Patch Set 4: (1 comment) File vdsm/storage/sp.py Line 1503:

Change in vdsm[master]: vdsm: Reboot capability for VM

Ayal Baron has posted comments on this change. Change subject: vdsm: Reboot capability for VM .. Patch Set 38: Dan, this is patchset number 37. The patch started out as seperate patches and that didn't make sense (there is

Change in vdsm[master]: sp: move reconnection info check to StoragePool

Ayal Baron has posted comments on this change. Change subject: sp: move reconnection info check to StoragePool .. Patch Set 8: (2 comments) File vdsm/storage/hsm.py Line

Change in vdsm[master]: sp: encapsulate spm status in StoragePool

Ayal Baron has posted comments on this change. Change subject: sp: encapsulate spm status in StoragePool .. Patch Set 7: (1 comment) File vdsm/storage/sp.py Line 167:

Change in vdsm[master]: sp: add setMasterDomain to StoragePool

Ayal Baron has posted comments on this change. Change subject: sp: add setMasterDomain to StoragePool .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21659 To unsubscribe, visit

Change in vdsm[master]: clientIF: Teardown volume path only for VDSM images

Ayal Baron has posted comments on this change. Change subject: clientIF: Teardown volume path only for VDSM images .. Patch Set 5: Code-Review+1 (1 comment) File

Change in vdsm[master]: clientIF: Check device visibility on failed hotplugDisk

Ayal Baron has posted comments on this change. Change subject: clientIF: Check device visibility on failed hotplugDisk .. Patch Set 4: (1 comment) File vdsm/clientIF.py

Change in vdsm[master]: sp: consolidate getMasterVersion in one method

Ayal Baron has posted comments on this change. Change subject: sp: consolidate getMasterVersion in one method .. Patch Set 1: (1 comment) File vdsm/storage/sp.py Line 489:

Change in vdsm[master]: securable: refactor the scurable implementation

Ayal Baron has posted comments on this change. Change subject: securable: refactor the scurable implementation .. Patch Set 2: (3 comments) Commit Message Line 3:

Change in vdsm[master]: sp: avoid masking uuid in StoragePool methods

Ayal Baron has posted comments on this change. Change subject: sp: avoid masking uuid in StoragePool methods .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21873 To unsubscribe, visit

Change in vdsm[master]: domainMonitor: Separate change detection from lastCheck value

Ayal Baron has posted comments on this change. Change subject: domainMonitor: Separate change detection from lastCheck value .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21878 To unsubscribe, visit

Change in vdsm[master]: threadPool: Do not keep reference to tasks

Ayal Baron has posted comments on this change. Change subject: threadPool: Do not keep reference to tasks .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22136 To unsubscribe, visit

Change in vdsm[master]: sp: _refreshDomainLinks must not change the metadata

Ayal Baron has posted comments on this change. Change subject: sp: _refreshDomainLinks must not change the metadata .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22131 To unsubscribe, visit

Change in vdsm[master]: threadPool: Do not keep reference to tasks

Ayal Baron has posted comments on this change. Change subject: threadPool: Do not keep reference to tasks .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22136 To unsubscribe, visit

Change in vdsm[master]: domainMonitor: Rename confusing lastCheck variable

Ayal Baron has posted comments on this change. Change subject: domainMonitor: Rename confusing lastCheck variable .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21879 To unsubscribe, visit

Change in vdsm[master]: domainMonitor: Improve logging

Ayal Baron has posted comments on this change. Change subject: domainMonitor: Improve logging .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21904 To unsubscribe, visit

Change in vdsm[master]: sp: avoid masking uuid in StoragePool methods

Ayal Baron has posted comments on this change. Change subject: sp: avoid masking uuid in StoragePool methods .. Patch Set 1: (1 comment) File vdsm/storage/sp.py Line 1895:

Change in vdsm[master]: sp: remove the getFormat method

Ayal Baron has posted comments on this change. Change subject: sp: remove the getFormat method .. Patch Set 3: Are you saying that there's a logical difference between getVersion and getFormat? Or you're saying that we can

Change in vdsm[master]: getStorageDomainInfo: SP keys when disconnected.

Ayal Baron has posted comments on this change. Change subject: getStorageDomainInfo: SP keys when disconnected. .. Patch Set 2: (1 comment) File vdsm/storage/hsm.py Line

Change in vdsm[ovirt-3.3]: Fix getStorageDomainInfo() logic.

Ayal Baron has posted comments on this change. Change subject: Fix getStorageDomainInfo() logic. .. Patch Set 2: Verified-1 Code-Review-1 This patch will break 3.3 as it expects pool.getInfo to return the info without the

Change in vdsm[master]: sp: encapsulate spm status in StoragePool

Ayal Baron has posted comments on this change. Change subject: sp: encapsulate spm status in StoragePool .. Patch Set 6: (1 comment) File vdsm/storage/sp.py Line 145: Line

Change in vdsm[master]: sp: add setMasterDomain to StoragePool

Ayal Baron has posted comments on this change. Change subject: sp: add setMasterDomain to StoragePool .. Patch Set 4: 1. I've never noticed this 2. You failed to explain that connectStoragePool returns true if you're already

Change in vdsm[master]: sp: remove unused scsiFencing parameter

Ayal Baron has posted comments on this change. Change subject: sp: remove unused scsiFencing parameter .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21555 To unsubscribe, visit

Change in vdsm[master]: sp: remove unused recoveryMode from spmStart

Ayal Baron has posted comments on this change. Change subject: sp: remove unused recoveryMode from spmStart .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21556 To unsubscribe, visit

Change in vdsm[master]: sp: remove the getFormat method

Ayal Baron has posted comments on this change. Change subject: sp: remove the getFormat method .. Patch Set 3: why? Until we get rid of the whole thing Format is actually the correct terminology (vs. the old 'version'). --

Change in vdsm[master]: sp: refresh metadata on hsm when listing domains

Ayal Baron has posted comments on this change. Change subject: sp: refresh metadata on hsm when listing domains .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21786 To unsubscribe, visit

Change in vdsm[master]: sp: move validatePoolSD in the StoragePool class

Ayal Baron has posted comments on this change. Change subject: sp: move validatePoolSD in the StoragePool class .. Patch Set 3: (2 comments) File vdsm/storage/hsm.py Line

Change in vdsm[master]: sd: add inquireClusterLock method to StorageDomain

Ayal Baron has posted comments on this change. Change subject: sd: add inquireClusterLock method to StorageDomain .. Patch Set 2: Code-Review+1 (1 comment) Commit Message

Change in vdsm[master]: getStorageDomainInfo: SP keys when disconnected.

Ayal Baron has posted comments on this change. Change subject: getStorageDomainInfo: SP keys when disconnected. .. Patch Set 2: Code-Review-1 (6 comments) 1. No clear motivation for this patch. 2. It is breaking encapsulation

Change in vdsm[ovirt-3.3]: Fix getStorageDomainInfo() logic.

Ayal Baron has posted comments on this change. Change subject: Fix getStorageDomainInfo() logic. .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/20209 To unsubscribe, visit

Change in vdsm[master]: sp: move reconnection info check to StoragePool

Ayal Baron has posted comments on this change. Change subject: sp: move reconnection info check to StoragePool .. Patch Set 3: Code-Review-1 (5 comments) File

  1   2   3   4   5   6   7   8   9   10   >