Petr Horáček has posted comments on this change.
Change subject: net: switch type switch
..
Patch Set 13: Verified+1
Passed all network/*_test.py OK
--
To view, visit https://gerrit.ovirt.org/62330
To unsubscribe, visit https
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/65760
to review the following change.
Change subject: net: edit nic detached from bridge but still attached to a vlan
..
net: e
Petr Horáček has posted comments on this change.
Change subject: net: support nameserver address with %iface tail
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65693
To unsubscribe, visit https://ger
Petr Horáček has posted comments on this change.
Change subject: net: support nameserver address with %iface tail
..
Patch Set 3: Code-Review-1
We should add a test to func_dns_test.py, to check if both ifcfg and our caps
repo
Petr Horáček has posted comments on this change.
Change subject: network: supervdsm: configure container networks
..
Patch Set 51: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/54998/51/vdsm/API.py
File vdsm/API.py:
Petr Horáček has posted comments on this change.
Change subject: py3: make toolBondingTests pass
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/65666/1/lib/vdsm/network/netinfo/bonding.py
File lib/vdsm/
Petr Horáček has restored this change.
Change subject: net: edit nic detached from bridge but still attached to a vlan
..
Restored
--
To view, visit https://gerrit.ovirt.org/65232
To unsubscribe, visit https://gerrit.ovirt.org
Petr Horáček has restored this change.
Change subject: net: edit nic detached from bridge but still attached to a vlan
..
Restored
--
To view, visit https://gerrit.ovirt.org/65233
To unsubscribe, visit https://gerrit.ovirt.org
Petr Horáček has abandoned this change.
Change subject: net: edit nic detached from bridge but still attached to a vlan
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/65233
To unsubscribe, visit https://gerrit.ovirt.o
Petr Horáček has abandoned this change.
Change subject: net: edit nic detached from bridge but still attached to a vlan
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/65232
To unsubscribe, visit https://gerrit.ovirt.o
Petr Horáček has posted comments on this change.
Change subject: net: edit nic detached from bridge but still attached to a vlan
..
Patch Set 4:
I cannot check the ifcfg for BRIDGE, it works OK when I use dummies, have no
idea
Petr Horáček has posted comments on this change.
Change subject: net: Change classmethod to staticmethod in IPv4 and IPv6 classes
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65609
To unsubscribe, v
Petr Horáček has posted comments on this change.
Change subject: net: Validate nameservers setup
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65613
To unsubscribe, visit https://gerrit.ovirt.org/set
Petr Horáček has posted comments on this change.
Change subject: py3: make ovs_test pass
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65599
To unsubscribe, visit https://gerrit.ovirt.org/settings
G
Petr Horáček has posted comments on this change.
Change subject: net: Change classmethod to staticmethod in IPv4 and IPv6 classes
..
Patch Set 2:
Why don't we just extract them into standalone functions?
--
To view, visit htt
Petr Horáček has posted comments on this change.
Change subject: net: Change classmethod to staticmethod in IPv4 and IPv6 classes
..
Patch Set 2:
this way we just abuse staticmethods to use IPvX as a module.
--
To view, visit
Petr Horáček has posted comments on this change.
Change subject: net: edit nic detached from bridge but still attached to a vlan
..
Patch Set 4: Verified+1
Manually tested with physical nic. Passed network/*_test.py and
functi
Petr Horáček has posted comments on this change.
Change subject: net: edit nic detached from bridge but still attached to a vlan
..
Patch Set 2: Verified-1
(1 comment)
https://gerrit.ovirt.org/#/c/65231/2/tests/network/func_ne
Petr Horáček has posted comments on this change.
Change subject: py3: fix remaining references to monitor.MonitorError as
iterable
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64929
To unsubscribe,
Petr Horáček has posted comments on this change.
Change subject: net: remove default route before adding a new one
..
Patch Set 2:
If you are talking about the 'setting default route for non-management
networks' problem, it is
Petr Horáček has posted comments on this change.
Change subject: net: canonicalize IPv4 prefix to netmask
..
Patch Set 3: Verified+1
(1 comment)
Passed network/*_test.py and functional/networkTests.py OK.
I added task to impl
Petr Horáček has posted comments on this change.
Change subject: net tests: minor libvirt_tests style refactoring
..
Patch Set 6: Verified+1
libvirt test passed OK
--
To view, visit https://gerrit.ovirt.org/65091
To unsubscri
Petr Horáček has posted comments on this change.
Change subject: net tests: separate ifcfg and libvirt unit tests
..
Patch Set 6: Verified+1
(2 comments)
Both tests passed.
https://gerrit.ovirt.org/#/c/65090/5/tests/Makefile.
Petr Horáček has posted comments on this change.
Change subject: net: edit nic detached from bridge but still attached to a vlan
..
Patch Set 1:
I tried to, but it does not fail with dummy (only with system NIC), I don't
know
Petr Horáček has uploaded a new change for review.
Change subject: net: edit nic detached from bridge but still attached to a vlan
..
net: edit nic detached from bridge but still attached to a vlan
Change-Id: I460cb08cf436b932e7
Petr Horáček has uploaded a new change for review.
Change subject: net: edit nic detached from bridge but still attached to a vlan
..
net: edit nic detached from bridge but still attached to a vlan
Change-Id: I460cb08cf436b932e7
Petr Horáček has uploaded a new change for review.
Change subject: net: edit nic detached from bridge but still attached to a vlan
..
net: edit nic detached from bridge but still attached to a vlan
Change-Id: I460cb08cf436b932e7
Petr Horáček has posted comments on this change.
Change subject: net: edit bond detached from bridge but still attached to a vlan
..
Patch Set 2: Verified+1
Passed functional/networkTests.py and manual testing (add untagged net
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/65219
to review the following change.
Change subject: net: edit bond detached from bridge but still attached to a vlan
..
net:
Petr Horáček has uploaded a new change for review.
Change subject: Revert "virt net: Change graphics type from network to address"
..
Revert "virt net: Change graphics type from network to address"
Now we save even OVS networks
Petr Horáček has uploaded a new change for review.
Change subject: net libvirt: make network/libvirt.py suitable for OVS
..
net libvirt: make network/libvirt.py suitable for OVS
Make network/libvirt.py suitable for OVS (add supp
Petr Horáček has posted comments on this change.
Change subject: net tests: minor libvirt_tests style refactoring
..
Patch Set 1: Verified+1
Tests passed.
--
To view, visit https://gerrit.ovirt.org/65091
To unsubscribe, visit
Petr Horáček has uploaded a new change for review.
Change subject: net tests: separate ifcfg and libvirt unit tests
..
net tests: separate ifcfg and libvirt unit tests
Change-Id: Ieca34a3f361586346d76ec22b11554c4a7c6e84d
---
M t
Petr Horáček has posted comments on this change.
Change subject: net tests: separate ifcfg and libvirt unit tests
..
Patch Set 1: Verified+1
Both tests passed.
--
To view, visit https://gerrit.ovirt.org/65090
To unsubscribe,
Petr Horáček has uploaded a new change for review.
Change subject: net tests: minor libvirt_tests style refactoring
..
net tests: minor libvirt_tests style refactoring
Change-Id: I64dedb9859d204082a1516574e9b8650a3e4ffe5
---
M t
Petr Horáček has posted comments on this change.
Change subject: net test: fix ovs_test:test_dry_run
..
Patch Set 1: Verified+1
Passed ovs_test.py
--
To view, visit https://gerrit.ovirt.org/65058
To unsubscribe, visit https:/
Petr Horáček has uploaded a new change for review.
Change subject: net test: fix ovs_test:test_dry_run
..
net test: fix ovs_test:test_dry_run
The test was using NetsAdditionSetup.add() as a standard function
although it is a con
Petr Horáček has posted comments on this change.
Change subject: net: remove default route before adding a new one
..
Patch Set 2: Verified+1
Passed network/*_test.py OK.
--
To view, visit https://gerrit.ovirt.org/65056
To un
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/65056
to review the following change.
Change subject: net: remove default route before adding a new one
..
net: remove default
Petr Horáček has posted comments on this change.
Change subject: net: canonicalize IPv4 prefix to netmask
..
Patch Set 2: Verified+1
Passed network/*_test.py and functional/networkTests.py
--
To view, visit https://gerrit.ovi
Petr Horáček has posted comments on this change.
Change subject: net ifcfg: fix bond rollback
..
Patch Set 1: Verified+1
With this patch, network/*_test.py passed OK. It did no break
functional/networkTests.py
--
To view, vi
Hello Dan Kenigsberg, Edward Haas,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/64509
to review the following change.
Change subject: net ifcfg: fix bond rollback
..
net ifcfg: fix bond rollback
Petr Horáček has uploaded a new change for review.
Change subject: net: canonicalize IPv4 prefix to netmask
..
net: canonicalize IPv4 prefix to netmask
In order to fix OVS switch, this patch moves canonicalization of
passed IPv4
Petr Horáček has posted comments on this change.
Change subject: net: canonicalize IPv4 prefix to netmask
..
Patch Set 3: Verified+1
Passed network/*_test.py and functional/networkTests.py OK.
--
To view, visit https://gerrit
Petr Horáček has posted comments on this change.
Change subject: net: Ignore missing graphics from VM conf on target host
..
Patch Set 1: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/64300/1//COMMIT_MSG
Commit Messa
Petr Horáček has uploaded a new change for review.
Change subject: net: canonicalize IPv4 prefix to netmask
..
net: canonicalize IPv4 prefix to netmask
In order to simplify static IP handling and fix OVS switch, this
patch intro
Petr Horáček has posted comments on this change.
Change subject: net: Log a setup networks transaction failure when using ovs
switch
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64415
To unsubscrib
Petr Horáček has posted comments on this change.
Change subject: net: Setup validation for OVS - Check nics usage
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64414
To unsubscribe, visit https://ger
Petr Horáček has posted comments on this change.
Change subject: net: Delete an OVS bridge when the last SB is detached.
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64413
To unsubscribe, visit http
Petr Horáček has posted comments on this change.
Change subject: net: Split OVS setup transaction to adjust for bond setup
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64412
To unsubscribe, visit ht
Petr Horáček has posted comments on this change.
Change subject: net: Use Linux bonds with OVS networks
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64411
To unsubscribe, visit https://gerrit.ovirt.
Petr Horáček has posted comments on this change.
Change subject: net: Relocate sysfs_bond_permission to nettestlib
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64410
To unsubscribe, visit https://ge
Petr Horáček has posted comments on this change.
Change subject: net: Remove OVS bond implementation.
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64409
To unsubscribe, visit https://gerrit.ovirt.or
Petr Horáček has posted comments on this change.
Change subject: net: test ovs info with southbound nic
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64408
To unsubscribe, visit https://gerrit.ovirt.
Petr Horáček has posted comments on this change.
Change subject: net: Disable IPv6 on OVS southbound iface (nic or bonding)
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64407
To unsubscribe, visit h
Petr Horáček has posted comments on this change.
Change subject: net: Link setup module - includes bond setup logic.
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64406
To unsubscribe, visit https://
Petr Horáček has posted comments on this change.
Change subject: net: Bond - preserve original slaves link state.
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64405
To unsubscribe, visit https://ger
Petr Horáček has posted comments on this change.
Change subject: net: Bond - add refresh method to update bond config
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64404
To unsubscribe, visit https:/
Petr Horáček has posted comments on this change.
Change subject: net: Bond - Add logging to the bond driver.
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64403
To unsubscribe, visit https://gerrit.o
Petr Horáček has posted comments on this change.
Change subject: net: Bond - adding a transaction context.
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64402
To unsubscribe, visit https://gerrit.ovi
Petr Horáček has posted comments on this change.
Change subject: net: Bond - Expose the (kernel) bond list.
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64401
To unsubscribe, visit https://gerrit.ov
Petr Horáček has posted comments on this change.
Change subject: net: Fix reference to CONFFILE_HEADER_BASE which was moved
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64445
To unsubscribe, visit h
Petr Horáček has posted comments on this change.
Change subject: net: Expose owned_device method through the configurator
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64095
To unsubscribe, visit htt
Petr Horáček has posted comments on this change.
Change subject: net: dhclient - address flush before starting and on shutdown
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64400
To unsubscribe, visi
Petr Horáček has posted comments on this change.
Change subject: net: dhclient kill - early exit if iface does not exists
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64399
To unsubscribe, visit htt
Petr Horáček has posted comments on this change.
Change subject: net: Introduce iface.exists and start using it in ip.dhclient
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64398
To unsubscribe, visi
Petr Horáček has posted comments on this change.
Change subject: net: ifcfg - dhclient should always be stopped
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64397
To unsubscribe, visit https://gerri
Petr Horáček has posted comments on this change.
Change subject: net: Expose disable IPv6 through ip.address module
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64396
To unsubscribe, visit https://g
Petr Horáček has posted comments on this change.
Change subject: net: Use is_link_up instead of operstate in netfunctestlib
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64395
To unsubscribe, visit h
Petr Horáček has posted comments on this change.
Change subject: net: For IP-less networks, wait for link-up on ifup execution
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64394
To unsubscribe, visi
Petr Horáček has posted comments on this change.
Change subject: net: Relocating wait-for-event under its own module.
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64393
To unsubscribe, visit https:/
Petr Horáček has posted comments on this change.
Change subject: net tests: Set dummy ifaces up by default.
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64392
To unsubscribe, visit https://gerrit.ov
Petr Horáček has posted comments on this change.
Change subject: net func tests: Cleanup ifcfg files after each func test.
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64391
To unsubscribe, visit ht
Petr Horáček has posted comments on this change.
Change subject: net: Adding bond api with sysfs driver under link
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64390
To unsubscribe, visit https://ge
Petr Horáček has posted comments on this change.
Change subject: net: Adding the 'link' package with an iface module
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64389
To unsubscribe, visit https://
Petr Horáček has posted comments on this change.
Change subject: net: dhclient command - iface name should appear at the tail
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64388
To unsubscribe, visit
Petr Horáček has posted comments on this change.
Change subject: net: Define netlink netdev flags constants under netlink.link
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64387
To unsubscribe, visi
Petr Horáček has posted comments on this change.
Change subject: net test: sourceroute thread crashes due to a test race
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64386
To unsubscribe, visit http
Petr Horáček has posted comments on this change.
Change subject: net test: Rename link_test module to netlink_test
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64385
To unsubscribe, visit https://ge
Petr Horáček has posted comments on this change.
Change subject: net: Consume ifcfg files that have a non vdsm standard name
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64096
To unsubscribe, visit
Petr Horáček has posted comments on this change.
Change subject: net: edit bond detached from bridge but still attached to a vlan
..
Patch Set 15: Verified+1
Just renamed test class.
--
To view, visit https://gerrit.ovirt.org
Petr Horáček has uploaded a new change for review.
Change subject: net tests: bond tests fails on CI with ctypes.AttributeError
..
net tests: bond tests fails on CI with ctypes.AttributeError
Change-Id: I6c88dd66056cbb1f65f77e8b
Petr Horáček has posted comments on this change.
Change subject: net test: shared nic between bond and network
..
Patch Set 3: Verified+1
Passed network/*_test.py OK.
--
To view, visit https://gerrit.ovirt.org/64206
To unsubs
Petr Horáček has posted comments on this change.
Change subject: net: edit bond detached from bridge but still attached to a vlan
..
Patch Set 14: Verified+1
Passed network/*_test.py OK.
--
To view, visit https://gerrit.ovirt
Petr Horáček has posted comments on this change.
Change subject: net: edit bond detached from bridge but still attached to a vlan
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/63723/11/tests/network/func_net_bond_t
Petr Horáček has posted comments on this change.
Change subject: net test: shared nic between bond and network
..
Patch Set 1: -Verified
(3 comments)
https://gerrit.ovirt.org/#/c/64206/1/tests/network/func_net_bond_test.py
Fil
Petr Horáček has posted comments on this change.
Change subject: net: Consume ifcfg files that have a non vdsm standard name
..
Patch Set 4: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/63990/4/lib/vdsm/network/confi
Petr Horáček has posted comments on this change.
Change subject: net: Consume ifcfg files that have a non vdsm standard name
..
Patch Set 4: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/63990/4/lib/vdsm/network/conf
Petr Horáček has posted comments on this change.
Change subject: net: Setup validation for OVS - Check nics usage
..
Patch Set 5: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/64212/4/lib/vdsm/network/ovs/validator.py
Petr Horáček has posted comments on this change.
Change subject: net: Log a setup networks transaction failure when using ovs
switch
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64242
To unsubscrib
Petr Horáček has posted comments on this change.
Change subject: net: Setup validation for OVS - Check nics usage
..
Patch Set 4: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/64212/4/lib/vdsm/network/netswitch.py
Fi
Petr Horáček has posted comments on this change.
Change subject: net: Delete an OVS bridge when the last SB is detached.
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64192
To unsubscribe, visit http
Petr Horáček has posted comments on this change.
Change subject: net: Split OVS setup transaction to adjust for bond setup
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64118
To unsubscribe, visit ht
Petr Horáček has posted comments on this change.
Change subject: net test: shared nic between bond and network
..
Patch Set 1: Verified-1
Fails for OVS, we must fix verification and exception raising.
--
To view, visit https:
Petr Horáček has posted comments on this change.
Change subject: net: Split OVS setup transaction to adjust for bond setup
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/64118/4/lib/vdsm/network/netswitch.py
File lib
Petr Horáček has uploaded a new change for review.
Change subject: net test: shared nic between bond and network
..
net test: shared nic between bond and network
Change-Id: Ice4ead640d45d0717d2a30bd01398cbbfff3f88a
Signed-off-by
Petr Horáček has posted comments on this change.
Change subject: net: edit bond detached from bridge but still attached to a vlan
..
Patch Set 9: Verified-1
Test is not using both switches
--
To view, visit https://gerrit.ovi
Petr Horáček has posted comments on this change.
Change subject: net: Delete an OVS bridge when the last SB is detached.
..
Patch Set 1: Code-Review+1
Really nice
--
To view, visit https://gerrit.ovirt.org/64192
To unsubscrib
Petr Horáček has posted comments on this change.
Change subject: net: Split OVS setup transaction to adjust for bond setup
..
Patch Set 4:
(3 comments)
https://gerrit.ovirt.org/#/c/64118/4/lib/vdsm/network/netswitch.py
File li
Petr Horáček has posted comments on this change.
Change subject: net: Use Linux bonds with OVS networks
..
Patch Set 31: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63119
To unsubscribe, visit https://gerrit.ovirt
1 - 100 of 2069 matches
Mail list logo