Francesco Romani has posted comments on this change.
Change subject: virt: sampling: consolidate disk statistics
..
Patch Set 9:
updated commit message with explanation about the involved libvirt calls.
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: virt: sampling: consolidate disk statistics
..
Patch Set 9: Verified+1
verified using vdsClient, inspecting output of getAllVmStats.
- booted a VM on a
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: sampling: consolidate disk statistics
..
Patch Set 9:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12873/ :
Dan Kenigsberg has posted comments on this change.
Change subject: virt: sampling: consolidate disk statistics
..
Patch Set 9: Code-Review+2
(1 comment)
http://gerrit.ovirt.org/#/c/29953/9/vdsm/virt/vm.py
File
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: sampling: consolidate disk statistics
..
virt: sampling: consolidate disk statistics
We used to have two different sampling, and thus two
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: sampling: consolidate disk statistics
..
Patch Set 10:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4066/ :
Francesco Romani has posted comments on this change.
Change subject: virt: sampling: consolidate disk statistics
..
Patch Set 7:
rebased. Shed more no longer needed code.
documented VIR_TYPED_PARAM_STRING_OKAY as requested.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: sampling: consolidate disk statistics
..
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12845/ :
Nir Soffer has posted comments on this change.
Change subject: virt: sampling: consolidate disk statistics
..
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/29953/7/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 299:
Nir Soffer has posted comments on this change.
Change subject: virt: sampling: consolidate disk statistics
..
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/29953/7/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 299:
Francesco Romani has posted comments on this change.
Change subject: virt: sampling: consolidate disk statistics
..
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/29953/7/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 299:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: sampling: consolidate disk statistics
..
Patch Set 8:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12852/ :
Nir Soffer has posted comments on this change.
Change subject: virt: sampling: consolidate disk statistics
..
Patch Set 8: Code-Review+1
Can be nice if you explain the difference between blockStats() and
blockStatsFlags() in
Francesco Romani has posted comments on this change.
Change subject: virt: sampling: consolidate disk statistics
..
Patch Set 5:
(3 comments)
http://gerrit.ovirt.org/#/c/29953/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: sampling: consolidate disk statistics
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12779/ :
Nir Soffer has posted comments on this change.
Change subject: virt: sampling: consolidate disk statistics
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29953
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: virt: sampling: consolidate disk statistics
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/29953/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 306:
Line
Martin Polednik has posted comments on this change.
Change subject: virt: sampling: consolidate disk statistics
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29953
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: virt: sampling: consolidate disk statistics
..
Patch Set 5: Code-Review-1
(3 comments)
Please remove unrelated changes.
Nir Soffer has posted comments on this change.
Change subject: virt: sampling: consolidate disk statistics
..
Patch Set 4:
(1 comment)
Partial review
http://gerrit.ovirt.org/#/c/29953/4//COMMIT_MSG
Commit Message:
Line 16:
Francesco Romani has posted comments on this change.
Change subject: virt: sampling: consolidate disk statistics
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/29953/4//COMMIT_MSG
Commit Message:
Line 16: and
Martin Polednik has posted comments on this change.
Change subject: virt: sampling: consolidate disk statistics
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29953
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: sampling: consolidate disk statistics
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11791/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: sampling: consolidate disk statistics
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11755/ :
Francesco Romani has posted comments on this change.
Change subject: virt: sampling: consolidate disk statistics
..
Patch Set 3:
rebased.
--
To view, visit http://gerrit.ovirt.org/29953
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: sampling: consolidate disk statistics
..
Patch Set 3:
Build Successful
Dan Kenigsberg has posted comments on this change.
Change subject: virt: sampling: consolidate disk statistics
..
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/29953/2/vdsm/virt/vm.py
File
Francesco Romani has posted comments on this change.
Change subject: virt: sampling: consolidate disk statistics
..
Patch Set 2: Verified+1
verified with 29951 and 29952 using both the new and old flow.
Stats shows correctly
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: sampling: consolidate disk statistics
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10223/ :
Francesco Romani has uploaded a new change for review.
Change subject: virt: sampling: consolidate disk statistics
..
virt: sampling: consolidate disk statistics
We used to have two different sampling, and thus two
libvirt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: sampling: consolidate disk statistics
..
Patch Set 1: Code-Review-1 Verified-1
Build Failed
31 matches
Mail list logo