Re: [vim/vim] Refactor to remove STRLEN() part 6 (PR #14796)

2024-05-21 Fir de Conversatie John Marriott
On 21-May-2024 09:57, zeertzjq (Vim Github Repository) wrote: *@zeertzjq* commented on this pull request. In src/tag.c : >

Re: Commit: patch 9.1.0409: too many strlen() calls in the regexp engine

2024-05-11 Fir de Conversatie John Marriott
On 12-May-2024 08:54, Tony Mechelynck wrote: On Sun, May 12, 2024 at 12:15 AM Christian Brabandt wrote: patch 9.1.0409: too many strlen() calls in the regexp engine Commit: https://github.com/vim/vim/commit/82792db6315f7c7b0e299cdde1566f2932a463f8 Author: John Marriott Date: Sun May 12

Re: Query about updating search stats

2024-05-10 Fir de Conversatie John Marriott
On 10-May-2024 06:30, John Marriott wrote: Hi all, Does anyone know why the update_search_stat() function (in search.c) considers the search direction and cursor position when deciding if it needs to recompute the search stats? In my testing they don't seem to matter. In fact they just

Query about updating search stats

2024-05-09 Fir de Conversatie John Marriott
Hi all, Does anyone know why the update_search_stat() function (in search.c) considers the search direction and cursor position when deciding if it needs to recompute the search stats? In my testing they don't seem to matter. In fact they just cause recomputation when it's not required.

Re: [vim/vim] Refactor to remove STRLEN() part 1 (PR #14287)

2024-04-03 Fir de Conversatie John Marriott
On 03-Apr-2024 05:03, Christian Brabandt (Vim Github Repository) wrote: Thanks, looks good to me. Did you meaure how much this saves (e.g. startup time)? — Reply to this email directly, view it on GitHub . You are receiving

Re: [vim/vim] Reduce number of calls to STRLEN() (Issue #14002)

2024-02-13 Fir de Conversatie John Marriott
On 12-Feb-2024 02:32, Christian Brabandt (Vim Github Repository) wrote: can you make a PR for this please? — Reply to this email directly, view it on GitHub . You are receiving this because you are subscribed to this

Re: Commit: patch 9.1.0071: Need a diff() Vim script function

2024-02-03 Fir de Conversatie John Marriott
On 04-Feb-2024 03:44, Christian Brabandt wrote: On Sa, 03 Feb 2024, John Marriott wrote: Sorry, I'm not sure what the correct fix is. I see Yegappan has already a patch for it in #13964. I'll merge it in a second. Jost wondering, are you usually building without the diff feature? Thanks

Re: Commit: patch 9.1.0071: Need a diff() Vim script function

2024-02-02 Fir de Conversatie John Marriott
On 02-Feb-2024 08:30, Christian Brabandt wrote: patch 9.1.0071: Need a diff() Vim script function Commit:https://github.com/vim/vim/commit/fa37835b8c0ed0f83952978fca4c332335ca7c46 Author: Yegappan Lakshmanan Date: Thu Feb 1 22:05:27 2024 +0100 patch 9.1.0071: Need a diff() Vim script

Re: Commit: patch 9.1.0061: UX of visual highlighting can be improved

2024-01-30 Fir de Conversatie John Marriott
On 31-Jan-2024 04:21, John Marriott wrote: On 31-Jan-2024 03:56, Christian Brabandt wrote: Can you try the following patch please? (this partly restores the old behaviour for 8 color terminals): #v+ diff --git a/src/highlight.c b/src/highlight.c index 85726f828..df2b97c27 100644 --- a/src

Re: Commit: patch 9.1.0061: UX of visual highlighting can be improved

2024-01-30 Fir de Conversatie John Marriott
On 31-Jan-2024 03:56, Christian Brabandt wrote: On Mi, 31 Jan 2024, John Marriott wrote: The terminal is VT220 emulation. Is that what you meant? so $TERM=vt220? I don't know about number of colours. How do you determine that? >From within Vim :set t_Co? Anyway, :hi Vis

Re: Commit: patch 9.1.0061: UX of visual highlighting can be improved

2024-01-29 Fir de Conversatie John Marriott
On 29-Jan-2024 09:41, Christian Brabandt wrote: I know this change could be considered quite controversial. However, I hope I have improved readability and UX of visual highlighting quite a bit, even so the syntax highlighting of the visual highlighted items got lost. Let me know if you think

Re: Commit: patch 9.1.0030: Cannot use terminal alternate font

2024-01-16 Fir de Conversatie John Marriott
On 16-Jan-2024 08:30, Christian Brabandt wrote: patch 9.1.0030: Cannot use terminal alternate font Commit:https://github.com/vim/vim/commit/a606f3ac036e5f3dc313f620e6b4bc00812314f9 Author: PMunch Date: Wed Nov 15 15:35:49 2023 +0100 patch 9.1.0030: Cannot use terminal alternate font

Re: Commit: patch 9.0.1991: no cmdline completion for setting the font

2023-10-05 Fir de Conversatie John Marriott
On 06-Oct-2023 06:00, Christian Brabandt wrote: patch 9.0.1991: no cmdline completion for setting the font Commit:https://github.com/vim/vim/commit/290b887e8cc2c0d3dfc7f315b2052472c7c589cc Author: Yee Cheng Chin Date: Thu Oct 5 20:54:21 2023 +0200 patch 9.0.1991: no cmdline completion

Re: patch 9.0.1704: Cannot use positional arguments for printf()

2023-08-15 Fir de Conversatie John Marriott
On 14-Aug-2023 02:15, Christian Brabandt wrote: patch 9.0.1704: Cannot use positional arguments for printf() Commit: https://github.com/vim/vim/commit/0c6181fec4c362eb9682d5af583341eb20cb1af5 Author: Christ van Willegen Date: Sun Aug 13 18:03:14 2023 +0200 patch 9.0.1704: Cannot use

Re: Patch 9.0.1418

2023-03-21 Fir de Conversatie John Marriott
On 21-Mar-2023 04:31, Bram Moolenaar wrote: Patch 9.0.1418 Problem:The included xdiff code is a bit outdated. Solution: Sync with the latest git xdiff code. (Yee Cheng Chin, closes #12181) Files: src/xdiff/README.txt, src/xdiff/xdiff.h, src/xdiff/xdiffi.c,

Re: Patch 9.0.1411

2023-03-17 Fir de Conversatie John Marriott
On 17-Mar-2023 08:43, Bram Moolenaar wrote: Patch 9.0.1411 Problem:Accuracy of profiling is not optimal. Solution: Use CLOCK_MONOTONIC if possible. (Ernie Rael, closes #12129) Files: runtime/doc/builtin.txt, runtime/doc/repeat.txt, src/evalfunc.c, src/profiler.c,

Re: Patch 9.0.1397

2023-03-15 Fir de Conversatie John Marriott
On 16-Mar-2023 04:09, Bram Moolenaar wrote: John Marriott wrote: On 11-Mar-2023 03:36, Bram Moolenaar wrote: Patch 9.0.1397 Problem:Highlight for popupmenu kind and extra cannot be set. Solution: Add PmenuKind, PmenuKindSel, PmenuExtra and PmenuExtraSel highlight groups

Re: Patch 9.0.1397

2023-03-14 Fir de Conversatie John Marriott
On 11-Mar-2023 03:36, Bram Moolenaar wrote: Patch 9.0.1397 Problem:Highlight for popupmenu kind and extra cannot be set. Solution: Add PmenuKind, PmenuKindSel, PmenuExtra and PmenuExtraSel highlight groups and use them. (Gianmaria Bajo, closes #12114) Files:

Re: Patch 9.0.1320

2023-02-18 Fir de Conversatie John Marriott
On 19-Feb-2023 01:43, Bram Moolenaar wrote: Patch 9.0.1320 Problem:Checking the type of a null object causes a crash. Solution: Don't try to get the class of a null object. (closes #12005) Handle error from calling a user function better. Files: src/vim9type.c,

Re: Patch 9.0.1208

2023-01-16 Fir de Conversatie John Marriott
On 17-Jan-2023 06:35, Enan Ajmain wrote: On Tue, 17 Jan 2023 06:09:22 +1100 John Marriott wrote: After this patch, msys64 (clang 15.0.5) gives this error: [...] Unrelated but wanted clarification. By 'msys64' do you mean clang64 build system of msys2 (i.e., msys/clang64)? or do you mean

Re: Patch 9.0.1208

2023-01-16 Fir de Conversatie John Marriott
On 17-Jan-2023 05:19, Bram Moolenaar wrote: Patch 9.0.1208 Problem:Code is indented more than necessary. Solution: Use an early return where it makes sense. (Yegappan Lakshmanan, closes #11819) Files: src/netbeans.c, src/normal.c, src/ops.c, src/option.c,

Re: Patch 9.0.1192

2023-01-13 Fir de Conversatie John Marriott
On 14-Jan-2023 04:37, Bram Moolenaar wrote: Patch 9.0.1192 Problem:No error when class function argument shadows a member. Solution: Check for shadowing. Files: src/vim9class.c, src/testdir/test_vim9_class.vim After this patch, msys64 (clang 15.0.5) gives this warning: clang -c

Re: Patch 9.0.1175

2023-01-11 Fir de Conversatie John Marriott
On 11-Jan-2023 22:46, Bram Moolenaar wrote: Patch 9.0.1175 Problem:The set_ref_in_item() function is too long. Solution: Use a separate function for more complicated types. (Yegappan Lakshmanan, closes #11802) Files: src/eval.c After this patch msys64 (clang 15.0.5)

Re: Patch 9.0.1168

2023-01-10 Fir de Conversatie John Marriott
On 10-Jan-2023 23:38, Bram Moolenaar wrote: Patch 9.0.1168 Problem:Code to enable/disable mouse is not from terminfo/termcap. Solution: Request the "XM" entry and use it to set 'ttymouse' if possible. Files: runtime/doc/options.txt, src/term.c, src/proto/term.pro,

Re: Patch 9.0.1150

2023-01-05 Fir de Conversatie John Marriott
On 06-Jan-2023 07:00, Bram Moolenaar wrote: Patch 9.0.1150 Problem::interface is not implemented yet. Solution: Implement the basics of :interface. Files: src/ex_cmds.h, src/ex_docmd.c, src/vim9class.c, src/proto/vim9class.pro, src/errors.h, src/vim.h, src/userfunc.c,

Re: Patch 9.0.1111

2022-12-30 Fir de Conversatie John Marriott
On 30-Dec-2022 22:16, Bram Moolenaar wrote: Patch 9.0. Problem:Termcap entries for RGB colors are not set automatically. Solution: Always set the termcap entries when +termguicolors is enabled. Files: src/term.c After this patch, msys2-64 (clang 15.0.5) gives this warning:

Re: Patch 9.0.1086

2022-12-23 Fir de Conversatie John Marriott
On 23-Dec-2022 09:37, Christopher Plewright wrote: On 23-Dec-2022 00:44, Bram Moolenaar wrote: Thanks again John. No worries  -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit

Re: Patch 9.0.1086

2022-12-22 Fir de Conversatie John Marriott
On 23-Dec-2022 00:44, Bram Moolenaar wrote: Patch 9.0.1086 Problem:Display wrong in Windows terminal after exiting Vim. Solution: Apply screen restore fix for Windows 11 also to Windows 10 builds. (Christopher Plewright, closes #11713, closes #11706) Files:

Re: Patch 9.0.1084

2022-12-20 Fir de Conversatie John Marriott
On 21-Dec-2022 07:02, Bram Moolenaar wrote: Patch 9.0.1084 Problem:Code handling low level MS-Windows events cannot be tested. Solution: Add test_mswin_event() and tests using it. (Christopher Plewright, closes #11622) Files: runtime/doc/builtin.txt,

Re: Patch 9.0.0977

2022-12-01 Fir de Conversatie John Marriott
On 01-Dec-2022 07:19, Bram Moolenaar wrote: John Marriott wrote: On 01-Dec-2022 05:12, Bram Moolenaar wrote: Patch 9.0.0977 Problem:It is not easy to see what client-server commands are doing. Solution: Add channel log messages if ch_log() is available. Move the channel

Re: Patch 9.0.0977

2022-11-30 Fir de Conversatie John Marriott
On 01-Dec-2022 05:12, Bram Moolenaar wrote: Patch 9.0.0977 Problem:It is not easy to see what client-server commands are doing. Solution: Add channel log messages if ch_log() is available. Move the channel logging and make it available with the +eval feature. Files:

Re: Patch 9.0.0965

2022-11-28 Fir de Conversatie John Marriott
On 29-Nov-2022 05:52, Bram Moolenaar wrote: Patch 9.0.0965 Problem:Using one window for executing autocommands is insufficient. Solution: Use up to five windows for executing autocommands. Files: src/globals.h, src/structs.h, src/autocmd.c, src/proto/autocmd.pro,

clang 15.0.4 windres error

2022-11-11 Fir de Conversatie John Marriott
Hi All, When compiling with clang x64 15.0.4 (from msys2) on Win8.1 x64, I get this error from windres: windres  -DWIN32 -DWINVER=0x0603 -D_WIN32_WINNT=0x0603 -DHAVE_PATHDEF -DFEAT_NORMAL -DHAVE_STDINT_H -DMS_WIN64 -DFEAT_GUI_MSWIN -DFEAT_CLIPBOARD \     --input-format=rc

clang 15.0.4 warnings

2022-11-05 Fir de Conversatie John Marriott
Hi All, clang x64 15.0.4 on Win8.1 x64 gives these 3 warnings: clang -c -I. -Iproto -DWIN32 -DWINVER=0x0603 -D_WIN32_WINNT=0x0603 -DHAVE_PATHDEF -DFEAT_NORMAL -DHAVE_STDINT_H -D__USE_MINGW_ANSI_STDIO -pipe -Wall -O3 -fomit-frame-pointer -fpie -fPIE -DFEAT_GUI_MSWIN -DFEAT_CLIPBOARD

Re: Patch 9.0.0787

2022-10-18 Fir de Conversatie John Marriott
On 18-Oct-2022 23:34, Bram Moolenaar wrote: Patch 9.0.0787 (after 9.0.0775) Problem:MS-Windows: mouse scrolling in terminal misbehaves without dll. Solution: Add #ifdef as a temporary solution. (Christopher Plewright, closes #11392) Files: src/os_win32.c I know this

Re: Patch 9.0.0683

2022-10-07 Fir de Conversatie John Marriott
On 08-Oct-2022 01:11, Bram Moolenaar wrote: Patch 9.0.0683 Problem:Cannot specify a time for :echowindow. Solution: A count can be used to specify the display time. Add popup_findecho(). Files: runtime/doc/eval.txt, runtime/doc/popup.txt,

Re: Patch 9.0.0466

2022-09-14 Fir de Conversatie John Marriott
On 15-Sept-2022 07:14, Bram Moolenaar wrote: Patch 9.0.0466 Problem:Virtual text wrong after adding line break after line. Solution: Pass an "eol" flag to where text properties are adjusted. (closes #11131) Files: src/change.c, src/textprop.c, src/proto/textprop.pro,

Re: Patch 9.0.0419

2022-09-08 Fir de Conversatie John Marriott
On 09-Sept-2022 04:53, Bram Moolenaar wrote: Patch 9.0.0419 Problem:The :defer command does not check the function argument count and types. Solution: Check the function arguments when adding a deferred function. Files: src/userfunc.c, src/vim9instr.c,

Re: Patch 9.0.0366

2022-09-03 Fir de Conversatie John Marriott
On 03-Sept-2022 21:09, Bram Moolenaar wrote: Patch 9.0.0366 Problem:Cannot use import->Func() in lambda. (Israel Chauca Fuentes) Solution: Adjust how an expression in a lambda is parsed. (closes #11042) Files: src/eval.c, src/testdir/test_vim9_import.vim After this patch mingw64

Re: Patch 9.0.0067

2022-07-25 Fir de Conversatie John Marriott
On 26-July-2022 03:14, Bram Moolenaar wrote: Patch 9.0.0067 Problem:Cannot show virtual text. Solution: Initial changes for virtual text support, using text properties. Files: runtime/doc/textprop.txt, src/beval.c, src/charset.c, src/drawline.c, src/edit.c, src/errors.h,

Re: Patch 9.0.0058

2022-07-23 Fir de Conversatie John Marriott
On 23-July-2022 14:05, Bram Moolenaar wrote: Patch 9.0.0058 Problem:Win32: cannot test low level events. Solution: Add "sendevent" to test_gui_event(). (Yegappan Lakshmanan, closes #10679) Files: runtime/doc/testing.txt, src/errors.h, src/gui_w32.c,

Re: Patch 9.0.0025

2022-07-02 Fir de Conversatie John Marriott
On 02-July-2022 22:43, Bram Moolenaar wrote: Patch 9.0.0025 Problem:Accessing beyond allocated memory when using the cmdline window in Ex mode. Solution: Use "*" instead of "'<,'>" for Visual mode. Files: src/ex_docmd.c, src/testdir/test_cmdline.vim // Special

Re: Vim 9.0 is released!

2022-06-28 Fir de Conversatie John Marriott
On 29-June-2022 00:55, Bram Moolenaar wrote: Hello Vim users! Announcing: Vim (Vi IMproved) version 9.0 Congratulations and thank-you to you Bram and to everyone involved. Cheers! -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the

Re: Patch 8.2.5087

2022-06-14 Fir de Conversatie John Marriott
On 15-June-2022 05:57, Yegappan Lakshmanan wrote: Hi, On Tue, Jun 14, 2022 at 12:41 PM John Marriott wrote: On 15-June-2022 05:34, Christian J. Robinson wrote: This is related to my problem. I temporarily fixed the problem with this command-line: CC='' CXX='' make ... Thanks :-) Can

Re: Patch 8.2.5087

2022-06-14 Fir de Conversatie John Marriott
On 15-June-2022 05:34, Christian J. Robinson wrote: This is related to my problem. I temporarily fixed the problem with this command-line: CC='' CXX='' make ... Thanks :-) -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are

Re: Patch 8.2.5087

2022-06-14 Fir de Conversatie John Marriott
On 14-June-2022 21:31, Bram Moolenaar wrote: Patch 8.2.5087 Problem:Cannot build with clang on MS-Windows. Solution: Add support for building with clang. (Yegappan Lakshmanan, closes #10557) Files: src/GvimExt/Make_ming.mak, src/INSTALLpc.txt,

Re: Patch 8.2.5084

2022-06-13 Fir de Conversatie John Marriott
On 14-June-2022 06:43, Bram Moolenaar wrote: Patch 8.2.5084 Problem:When the GUI shows a dialog tests get stuck. Solution: Add the --gui-dialog-file argument. Files: runtime/doc/starting.txt, src/Make_mvc.mak, src/gui.c, src/main.c, src/message.c, src/os_mswin.c,

Re: mingw64 gcc 12.1.0 warnings

2022-06-09 Fir de Conversatie John Marriott
On 07-June-2022 07:15, Bram Moolenaar wrote: John Marriott wrote: I just moved up to mingw64 with gcc 12.1.0 on my windows 8.1 x64 box. I now have two warnings. The first: gcc -c -I. -Iproto -DWIN32 -DWINVER=0x0603 -D_WIN32_WINNT=0x0603 -DHAVE_PATHDEF -DFEAT_NORMAL -DHAVE_STDINT_H

Re: mingw64 gcc 12.1.0 warnings

2022-06-09 Fir de Conversatie John Marriott
On 07-June-2022 07:15, Bram Moolenaar wrote: John Marriott wrote: I just moved up to mingw64 with gcc 12.1.0 on my windows 8.1 x64 box. I now have two warnings. The first: gcc -c -I. -Iproto -DWIN32 -DWINVER=0x0603 -D_WIN32_WINNT=0x0603 -DHAVE_PATHDEF -DFEAT_NORMAL -DHAVE_STDINT_H

Re: mingw64 gcc 12.1.0 warnings

2022-06-07 Fir de Conversatie John Marriott
On 07-June-2022 07:15, Bram Moolenaar wrote: John Marriott wrote: I just moved up to mingw64 with gcc 12.1.0 on my windows 8.1 x64 box. I now have two warnings. The first: gcc -c -I. -Iproto -DWIN32 -DWINVER=0x0603 -D_WIN32_WINNT=0x0603 -DHAVE_PATHDEF -DFEAT_NORMAL -DHAVE_STDINT_H

mingw64 gcc 12.1.0 warnings

2022-06-06 Fir de Conversatie John Marriott
Hi All, I just moved up to mingw64 with gcc 12.1.0 on my windows 8.1 x64 box. I now have two warnings. The first: gcc -c -I. -Iproto -DWIN32 -DWINVER=0x0603 -D_WIN32_WINNT=0x0603 -DHAVE_PATHDEF -DFEAT_NORMAL -DHAVE_STDINT_H -D__USE_MINGW_ANSI_STDIO -pipe -march=native -Wall -O3

Re: Patch 8.2.5030

2022-05-27 Fir de Conversatie John Marriott
On 28-May-2022 03:06, Bram Moolenaar wrote: Patch 8.2.5030 Problem:autocmd_add() can only handle one event and pattern. Solution: Support a list of events and patterns. (Yegappan Lakshmanan, closes #10483) Files: runtime/doc/builtin.txt, src/autocmd.c, src/errors.h,

Re: Patch 8.2.5003

2022-05-22 Fir de Conversatie John Marriott
On 23-May-2022 05:08, John Marriott wrote: On 23-May-2022 04:14, Bram Moolenaar wrote: Patch 8.2.5003 Problem:    Cannot do bitwise shifts. Solution:   Add the >> and << operators. (Yegappan Lakshmanan, closes #8457) Files:  runtime/doc/eval.txt, src/errors.h, src/

Re: Patch 8.2.5003

2022-05-22 Fir de Conversatie John Marriott
On 23-May-2022 04:14, Bram Moolenaar wrote: Patch 8.2.5003 Problem:Cannot do bitwise shifts. Solution: Add the >> and << operators. (Yegappan Lakshmanan, closes #8457) Files: runtime/doc/eval.txt, src/errors.h, src/eval.c, src/structs.h, src/vim.h, src/vim9execute.c,

Link failure if FEAT_PROP_POPUP is defined without FEAT_SPELL or FEAT_QUICKFIX

2022-05-15 Fir de Conversatie John Marriott
Hi All, mingw64 (gcc 11.3.0) link fails if FEAT_PROP_POPUP is defined but FEAT_QUICKFIX and FEAT_SPELL are not with this error message: gcc -I. -Iproto -DWIN32 -DWINVER=0x0603 -D_WIN32_WINNT=0x0603 -DHAVE_PATHDEF -DFEAT_NORMAL -DHAVE_STDINT_H -D__USE_MINGW_ANSI_STDIO -pipe -march=native

Re: Patch 8.2.4902

2022-05-08 Fir de Conversatie John Marriott
On 07-May-2022 21:26, Bram Moolenaar wrote: Patch 8.2.4902 Problem:Mouse wheel scrolling is inconsistent. Solution: Use the MS-Winows system setting. (closes #10368) Files: runtime/doc/scroll.txt, src/gui_w32.c, src/mouse.c, src/proto/mouse.pro, src/testing.c,

Re: Patch 8.2.4850

2022-04-30 Fir de Conversatie John Marriott
On 01-May-2022 06:50, Tony Mechelynck wrote: On Sat, Apr 30, 2022 at 5:12 PM Bram Moolenaar wrote: Patch 8.2.4850 Problem:Mksession mixes up "tabpages" and "curdir" arguments. Solution: Correct logic for storing tabpage in session. (closes #10312) Files: src/session.c,

Patch 8.2.4792

2022-04-19 Fir de Conversatie John Marriott
After this patch, mingw (gcc 11.2.0) throws this warning: gcc -c -I. -Iproto -DWIN32 -DWINVER=0x0603 -D_WIN32_WINNT=0x0603 -DHAVE_PATHDEF -DFEAT_NORMAL -DHAVE_STDINT_H -D__USE_MINGW_ANSI_STDIO -pipe -march=native -Wall -O3 -fomit-frame-pointer -freg-struct-return -fpie -fPIE -DFEAT_GUI_MSWIN

Re: Compile warning on ucrt build of mingw

2022-04-17 Fir de Conversatie John Marriott
On 17-Apr-2022 19:58, Bram Moolenaar wrote: John Marriott wrote: I recently started using a ucrt enabled build of mingw64 (gcc 11.2.0) which gives me this compile warning: gcc -c -I. -Iproto -DWIN32 -DWINVER=0x0603 -D_WIN32_WINNT=0x0603 -DHAVE_PATHDEF -DFEAT_NORMAL -DHAVE_STDINT_H

Compile warning on ucrt build of mingw

2022-04-16 Fir de Conversatie John Marriott
I recently started using a ucrt enabled build of mingw64 (gcc 11.2.0) which gives me this compile warning: gcc -c -I. -Iproto -DWIN32 -DWINVER=0x0603 -D_WIN32_WINNT=0x0603 -DHAVE_PATHDEF -DFEAT_NORMAL -DHAVE_STDINT_H -D__USE_MINGW_ANSI_STDIO -pipe -march=native -Wall -O3 -fomit-frame-pointer

Re: Patch 8.2.4678

2022-04-03 Fir de Conversatie John Marriott
On 04-Apr-2022 06:12, Bram Moolenaar wrote: Patch 8.2.4678 Problem:Vim9: not all code is tested. Solution: Add a few more tests. Files: src/vim9execute.c, src/testdir/test_vim9_script.vim, src/testdir/test_vim9_import.vim, src/testdir/test_vim9_cmd.vim After this

Re: Patch 8.2.4670

2022-04-03 Fir de Conversatie John Marriott
On 04-Apr-2022 06:10, John Marriott wrote: On 03-Apr-2022 20:23, Bram Moolenaar wrote: Patch 8.2.4670 Problem:    Memory allocation failures for new tab page not tested. Solution:   Add tests with failing memory allocation. (Yegappan Lakshmanan, closes #10067) Files:  src

Re: Patch 8.2.4670

2022-04-03 Fir de Conversatie John Marriott
On 03-Apr-2022 20:23, Bram Moolenaar wrote: Patch 8.2.4670 Problem:Memory allocation failures for new tab page not tested. Solution: Add tests with failing memory allocation. (Yegappan Lakshmanan, closes #10067) Files: src/alloc.h, src/blob.c, src/buffer.c,

Re: Patch 8.2.4559

2022-03-13 Fir de Conversatie John Marriott
On 14-Mar-2022 02:53, Bram Moolenaar wrote: Patch 8.2.4559 (after 8.24555) Problem:getmousepos() returns the screen column. (Ernie Rael) Solution: Return the text column, as documented. Files: src/mouse.c, src/testdir/test_functions.vim After this patch, mingw64 (gcc 11.2.0)

Re: Patch 8.2.4528

2022-03-08 Fir de Conversatie John Marriott
On 09-Mar-2022 03:53, Bram Moolenaar wrote: Patch 8.2.4528 Problem:Crash when using null_function for a partial. Solution: Don't call fname_trans_sid() with NULL. (closes #9908) Files: src/userfunc.c, src/testdir/test_vim9_func.vim After this patch, mingw64 (gcc 11.2.0) throws

Re: Patch 8.2.4520

2022-03-06 Fir de Conversatie John Marriott
On 07-Mar-2022 06:56, Bram Moolenaar wrote: Patch 8.2.4520 Problem:Using wrong highlight for cursor line number. Solution: Take filler lines into account when using CursorLineNr. (closes #9897) Files: src/drawline.c, src/testdir/test_diffmode.vim,

Re: Patch 8.2.4487

2022-03-01 Fir de Conversatie John Marriott
On 02-Mar-2022 06:23, Bram Moolenaar wrote: Patch 8.2.4487 Problem:Vim9: cannot compare with v:null. Solution: Allow comparing anything with v:null. (closes #9866) Files: src/vim9instr.c, src/typval.c, src/proto/typval.pro, src/vim9.h, src/vim9execute.c, src/evalvars.c,

Re: Patch 8.2.4482

2022-02-28 Fir de Conversatie John Marriott
On 28-Feb-2022 08:03, Bram Moolenaar wrote: Patch 8.2.4482 Problem:No fuzzy cmdline completion for user defined completion. Solution: Add fuzzy completion for user defined completion. (Yegappan Lakshmanan, closes #9858) Files: src/cmdexpand.c,

Re: Patch 8.2.4264

2022-01-30 Fir de Conversatie John Marriott
On 31-Jan-2022 07:01, Bram Moolenaar wrote: I saw your patch only after sending out patch 8.2.4266. The effect should be the same. By the way, are we sure that line 4833 (did_emsg |= saved_did_emsg) is correct? Shouldn't it be: did_emsg = save_did_emsg? We don't want to reset did_emsg

Re: Patch 8.2.4264

2022-01-30 Fir de Conversatie John Marriott
On 31-Jan-2022 05:41, Bram Moolenaar wrote: Patch 8.2.4264 Problem:Vim9: can use old style autoload function name. Solution: Give an error for old style autoload function name. Files: src/errors.h, src/userfunc.c, src/testdir/test_vim9_import.vim,

Re: Patch 8.2.4050

2022-01-09 Fir de Conversatie John Marriott
On 10-Jan-2022 08:37, Bram Moolenaar wrote: Patch 8.2.4050 Problem:Vim9: need to prefix every item in an autoload script. Solution: First step in supporting "vim9script autoload" and "import autoload". Files: runtime/doc/repeat.txt, runtime/doc/vim9.txt, src/structs.h,

Re: Patch 8.2.4008

2022-01-05 Fir de Conversatie John Marriott
On 06-Jan-2022 03:09, Bram Moolenaar wrote: Patch 8.2.4008 Problem:Error messages are spread out. Solution: Move more error messages to errors.h. Files: src/errors.h, src/diff.c, src/digraph.c, src/evalfunc.c, src/evalvars.c, src/ex_cmds.c, src/ex_docmd.c,

Re: Patch 8.2.3897

2022-01-04 Fir de Conversatie John Marriott
On 26-Dec-2021 08:48, Bram Moolenaar wrote: Patch 8.2.3897 Problem:Vim9: the second argument of map() and filter() is not checked at compile time. Solution: Add more specific type check for the second argument. Files: src/evalfunc.c, src/globals.h, src/list.c,

Re: Patch 8.2.3920

2021-12-28 Fir de Conversatie John Marriott
On 29-Dec-2021 00:16, Bram Moolenaar wrote: Patch 8.2.3920 Problem:Restoring directory after using another window is inefficient. Solution: Only restore the directory for win_execute(). Apply 'autochdir' only when needed. Files: src/evalwindow.c,

Re: Patch 8.2.3871

2021-12-22 Fir de Conversatie John Marriott
On 23-Dec-2021 06:19, Bram Moolenaar wrote: John Marriott wrote: On 23-Dec-2021 05:20, Bram Moolenaar wrote: Patch 8.2.3871 Problem:List.c contains code for dict and blob. Solution: Refactor to put code where it belongs. (Yegappan Lakshmanan, closes #9386) Files

Re: Patch 8.2.3871

2021-12-22 Fir de Conversatie John Marriott
On 23-Dec-2021 05:20, Bram Moolenaar wrote: Patch 8.2.3871 Problem:List.c contains code for dict and blob. Solution: Refactor to put code where it belongs. (Yegappan Lakshmanan, closes #9386) Files: src/blob.c, src/dict.c, src/list.c, src/proto/blob.pro,

Re: Patch 8.2.3787

2021-12-12 Fir de Conversatie John Marriott
On 13-Dec-2021 01:17, Bram Moolenaar wrote: Patch 8.2.3787 Problem:No proper formatting of a C line comment after a statement. Solution: Find the start of the line comment, insert the comment leader and indent the comment properly. Files: src/change.c,

Re: Patch 8.2.3700

2021-12-01 Fir de Conversatie John Marriott
On 30-Nov-2021 08:13, Bram Moolenaar wrote: Patch 8.2.3700 Problem:Text property highlighting continues over breakindent. Solution: Stop before the end column. (closes #9242) Files: src/drawline.c, src/testdir/test_textprop.vim, src/testdir/dumps/Test_prop_linebreak.dump

Re: Patch 8.2.3562

2021-10-25 Fir de Conversatie John Marriott
On 25-Oct-2021 20:37, Bram Moolenaar wrote: Thanks, I'll include that. Next time please use a context or unified diff, makes it a bit easier to understand the patch. Whoops! Sorry about the diff. -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply

Re: Patch 8.2.3562

2021-10-24 Fir de Conversatie John Marriott
On 25-Oct-2021 06:35, Bram Moolenaar wrote: Patch 8.2.3562 Problem:Cannot add color names. Solution: Add the v:colornames dictionary. (Drew Vogel, closes #8761) Files: Filelist, READMEdir/README_extra.txt, nsis/gvim.nsi, runtime/colors/README.txt,

Re: Patch 8.2.3536

2021-10-19 Fir de Conversatie John Marriott
On 19-Oct-2021 08:14, Bram Moolenaar wrote: Patch 8.2.3536 Problem:The do_highlight() function is way too long. Solution: Split it into several functions. (Yegappan Lakshmanan, closes #9011) Files: src/highlight.c After this patch mingw64 (gcc 11.2) throws these

Re: Patch 8.2.3424

2021-09-10 Fir de Conversatie John Marriott
On 11-Sept-2021 00:59, Bram Moolenaar wrote: Patch 8.2.3424 Problem:A sequence of spaces is hard to see in list mode. Solution: Add the "multispace" option to 'listchars'. (closes #8834) Files: runtime/doc/options.txt, src/drawline.c, src/message.c, src/screen.c,

Re: Patch 8.2.3348

2021-08-16 Fir de Conversatie John Marriott
On 16-Aug-2021 18:24, Bram Moolenaar wrote: John Marriott wrote: On 15-Aug-2021 22:32, Bram Moolenaar wrote: Patch 8.2.3348 Problem:line2byte() returns wrong value after adding textprop. (Yuto Kimura) Solution: Reduce the length by the size of the text property

Re: Patch 8.2.3348

2021-08-15 Fir de Conversatie John Marriott
On 16-Aug-2021 06:11, Bram Moolenaar wrote: John Marriott wrote: On 15-Aug-2021 22:32, Bram Moolenaar wrote: Patch 8.2.3348 Problem:line2byte() returns wrong value after adding textprop. (Yuto Kimura) Solution: Reduce the length by the size of the text property. (closes

Re: Patch 8.2.3348

2021-08-15 Fir de Conversatie John Marriott
On 15-Aug-2021 22:32, Bram Moolenaar wrote: Patch 8.2.3348 Problem:line2byte() returns wrong value after adding textprop. (Yuto Kimura) Solution: Reduce the length by the size of the text property. (closes #8759) Files: src/memline.c, src/testdir/test_textprop.vim Hi

Re: Patch 8.2.3263

2021-07-31 Fir de Conversatie John Marriott
On 01-Aug-2021 06:51, Bram Moolenaar wrote: Patch 8.2.3263 Problem:Vim9: "..=" does not accept same types as the ".." operator. Solution: Convert value to string like ".." does. (issue #8664) Files: src/vim9compile.c, src/testdir/test_vim9_assign.vim,

Re: Patch 8.2.2996

2021-06-14 Fir de Conversatie John Marriott
On 15-Jun-2021 04:41, Bram Moolenaar wrote: Patch 8.2.2996 Problem:Vim9: when debugging cannot inspect local variables. Solution: Make local variables available when debugging. Files: src/vim9execute.c, src/proto/vim9execute.pro, src/vim9compile.c, src/vim9.h,

Re: Patch 8.2.2944

2021-06-05 Fir de Conversatie John Marriott
On 06-Jun-2021 04:52, Bram Moolenaar wrote: Patch 8.2.2944 Problem:Vim9: no error when using job or channel as a string. Solution: Be more strict about conversion to string. (closes #8312) Files: src/typval.c, src/job.c, src/proto/job.pro, src/channel.c,

Re: Patch 8.2.2834

2021-05-05 Fir de Conversatie John Marriott
On 06-May-2021 05:59, John Marriott wrote: On 06-May-2021 05:32, Bram Moolenaar wrote: Patch 8.2.2834 Problem:    Vim9: :cexpr does not work with local variables. Solution:   Compile :cexpr. Files:  src/vim9compile.c, src/vim9.h, src/vim9execute.c, src/quickfix.c, src/proto

Re: Patch 8.2.2834

2021-05-05 Fir de Conversatie John Marriott
On 06-May-2021 05:32, Bram Moolenaar wrote: Patch 8.2.2834 Problem:Vim9: :cexpr does not work with local variables. Solution: Compile :cexpr. Files: src/vim9compile.c, src/vim9.h, src/vim9execute.c, src/quickfix.c, src/proto/quickfix.pro, src/testdir/test_quickfix.vim,

Re: Patch 8.2.2812

2021-04-26 Fir de Conversatie John Marriott
On 27-Apr-2021 04:33, Bram Moolenaar wrote: Patch 8.2.2812 Problem:Vim9: still crash when using substitute expression. Solution: Put the instruction list in the stack frame. (closes #8154) Files: src/vim9execute.c, src/vim9.h, src/testdir/test_vim9_cmd.vim After this patch I

Re: Patch 8.2.2759

2021-04-13 Fir de Conversatie John Marriott
On 14-Apr-2021 04:54, Bram Moolenaar wrote: Patch 8.2.2759 Problem:Vim9: for loop infers type of loop variable. Solution: Do not get the member type. (closes #8102) Files: src/vim9type.c, src/proto/vim9type.pro, src/list.c, src/vim9script.c, src/proto/vim9script.pro,

Re: Patch 8.2.2518

2021-02-16 Fir de Conversatie John Marriott
On 17-Feb-2021 08:26, Bram Moolenaar wrote: I used another solution in patch 8.2.2521. I hope it works for this compiler. Patch 8.2.2521 works ok with HP-UX. Thanks John -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are

Re: Patch 8.2.2518

2021-02-16 Fir de Conversatie John Marriott
On 16-Feb-2021 06:39, Bram Moolenaar wrote: Patch 8.2.2518 Problem:'listchars' should be window-local. Solution: Make 'listchars' global-local. (Yegappan Lakshmanan, Marco Hinz, closes #5206, closes #7850) Files: runtime/doc/options.txt, src/buffer.c, src/charset.c,

Re: Patch 8.2.2409

2021-01-25 Fir de Conversatie John Marriott
On 26-Jan-2021 07:02, Bram Moolenaar wrote: Patch 8.2.2409 Problem:Vim9: profiling only works for one function. Solution: Select the right instructions when calling and returning. (closes #7743) Files: src/vim9compile.c, src/vim9execute.c, src/vim9.h,

Re: Patch 8.2.2345

2021-01-17 Fir de Conversatie John Marriott
in feature.h, including FEAT_MOUSE_XTERM. Sorry for any confusion. Cheers John On 16-Jan-2021 08:28, Bram Moolenaar wrote: John Marriott wrote: On 15-Jan-2021 03:35, Bram Moolenaar wrote: Patch 8.2.2345 Problem:No focus events in a terminal. Solution: Add the t_fd and t_fe termcap

Re: Patch 8.2.2345

2021-01-15 Fir de Conversatie John Marriott
On 15-Jan-2021 03:35, Bram Moolenaar wrote: Patch 8.2.2345 Problem:No focus events in a terminal. Solution: Add the t_fd and t_fe termcap entries and implement detecting focus events. (Hayaki Saito, Magnus Groß, closes #7673, closes #609, closes #5526) Files:

Re: Patch 8.2.2324

2021-01-10 Fir de Conversatie John Marriott
On 11-Jan-2021 06:23, Bram Moolenaar wrote: Patch 8.2.2324 Problem:Not easy to get mark en cursor posotion by character count. Solution: Add functions that use character index. (Yegappan Lakshmanan, closes #7648) Files: runtime/doc/eval.txt, runtime/doc/usr_41.txt,

Re: Patch 8.2.2002

2020-11-17 Fir de Conversatie John Marriott
On 18-Nov-2020 04:51, Bram Moolenaar wrote: Patch 8.2.2002 Problem:Vim9: lambda argument shadowed by function name. Solution: Let function name be shadowed by lambda argument. (closes #7313) Files: src/vim9compile.c, src/testdir/test_vim9_func.vim After this patch, mingw64 (gcc

Re: Patch 8.2.1880

2020-10-21 Fir de Conversatie John Marriott
On 22-Oct-2020 01:50, Bram Moolenaar wrote: Patch 8.2.1880 Problem:Vim9: Asan complains about adding zero to NULL. Solution: Check for argument count first. Files: src/vim9compile.c After this patch mingw64 (gcc 10.2) throws this warning: gcc -c -I. -Iproto -DWIN32

  1   2   3   >