Re: [virt-tools-list] I can't found usb device under virtual machine manager!

2017-04-05 Thread Cole Robinson
On 04/04/2017 11:01 PM, Liao Yunpeng wrote: > I can't find usb device after install windows 10 in virtual machine manager > usb device list! > > I use vir-manager in debian linux, new installation of windows 10 in it with > default configuration of virtual machine manager.But under windows 10, I

Re: [virt-tools-list] [virt-manager] Reset Guest.domain to None on domain creation error

2017-04-13 Thread Cole Robinson
On 04/13/2017 05:18 AM, Christophe Fergeau wrote: > When an error occurs when the VM creation wizard tries to start the VM, > it's then not possible to press again the "Finish" button to try again > to start it, as this errors out with: > > Traceback (most recent call last): > File

Re: [virt-tools-list] [virt-manager PATCH v2] virtinst: tweak distros in the 'supported' workaround

2017-04-13 Thread Cole Robinson
On 04/10/2017 11:37 AM, Pino Toscano wrote: > - pick only the latest version for centos6.x, centos7.x, and > freebsd11.x; the latter two have only one element each currently, > so this is preparing for future versions > - bump the minimum supported version of Fedora to 24 > - enable also

Re: [virt-tools-list] [PATCH] Replace GtkHBox and GtkVBox with GtkBox.

2017-04-13 Thread Cole Robinson
On 04/12/2017 06:47 AM, Radostin Stoyanov wrote: > From: rst0git > > Problem: > - GtkHBox and GtkVBox have been deprecated since version 3.2 and should > not be used in newly-written code. > > Solution: Replace GtkHBox and GtkVBox with GtkBox. > - I have used the

Re: [virt-tools-list] [virt-manager] Reset Guest.domain to None on domain creation error

2017-04-13 Thread Cole Robinson
On 04/13/2017 07:04 AM, Xiaodai Wang wrote: > > > > > - Original Message - >> From: "Christophe Fergeau" >> To: virt-tools-list@redhat.com >> Sent: Thursday, April 13, 2017 5:18:46 PM >> Subject: [virt-tools-list] [virt-manager] Reset Guest.domain to None on

Re: [virt-tools-list] [virt-manager] Reset Guest.domain to None on domain creation error

2017-04-16 Thread Cole Robinson
On 04/14/2017 01:45 AM, Xiaodai Wang wrote: > >> >> - Original Message ----- >>> From: "Cole Robinson" <crobi...@redhat.com> >>> To: "Xiaodai Wang" <xiaod...@redhat.com>, "Christophe Fergeau" >>> <cferg...@

Re: [virt-tools-list] [virt-manager PATCH] cloner: preserve the disk type in the cloned domain

2017-03-03 Thread Cole Robinson
On 03/03/2017 12:25 PM, Pavel Hrdina wrote: > On Fri, Mar 03, 2017 at 12:02:37PM -0500, Cole Robinson wrote: >> On 03/03/2017 02:19 AM, Pavel Hrdina wrote: >>> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1420187 >>> >>> Signed-off-

Re: [virt-tools-list] [virt-manager PATCH] cloner: preserve the disk type in the cloned domain

2017-03-03 Thread Cole Robinson
On 03/03/2017 02:19 AM, Pavel Hrdina wrote: > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1420187 > > Signed-off-by: Pavel Hrdina > --- > virtinst/cloner.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/virtinst/cloner.py

Re: [virt-tools-list] [virt-manager PATCH 1/2] hostdev: add support for specify driver name when adding host device

2017-03-03 Thread Cole Robinson
On 03/03/2017 05:39 AM, Chen Hanxiao wrote: > From: Chen Hanxiao > > When adding host device, we could specify driver names, > such as vfio, xen, etc. We can, but is it important enough to expose in the UI? VFIO is preferred and we want to encourage it, which is why it's

Re: [virt-tools-list] [virt-manager PATCH 2/2] virt-install: add driver_name example in man-page

2017-03-03 Thread Cole Robinson
On 03/03/2017 05:39 AM, Chen Hanxiao wrote: > From: Chen Hanxiao > > Give some examples for driver_name of host device. > > Signed-off-by: Chen Hanxiao > --- > man/virt-install.pod | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

[virt-tools-list] ANNOUNCE: virt-manager 1.4.1 released

2017-03-08 Thread Cole Robinson
I'm happy to announce the release of virt-manager 1.4.1! virt-manager is a desktop application for managing KVM, Xen, and LXC virtualization via libvirt. The release can be downloaded from: http://virt-manager.org/download/ This release includes: - storage/nodedev event API support (Jovanka

Re: [virt-tools-list] [virt-manager PATCH v3] domain: add support to rename domain with nvram vars file

2017-03-08 Thread Cole Robinson
On 03/08/2017 03:59 AM, Pavel Hrdina wrote: > Libvirt storage API doesn't support renaming storage volumes so > we need to copy the nvram file and remove the old one. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1368922 > > Signed-off-by: Pavel Hrdina ACK

Re: [virt-tools-list] [virt-manager PATCH 0/6] cloning improvements and bug fixes

2017-03-06 Thread Cole Robinson
On 03/06/2017 03:28 AM, Pavel Hrdina wrote: > Pavel Hrdina (6): > virtinst.diskbackend: unify how we get disk type > virtinst.storage: improve detection of disk type > virtManager.clone: set new manual path before we populate storage list > virtManager.clone: don't generate clone path if

Re: [virt-tools-list] [virt-manager PATCH 1/2] domain: add support to rename domain with nvram vars file

2017-03-06 Thread Cole Robinson
On 03/06/2017 03:43 AM, Pavel Hrdina wrote: > Libvirt storage API doesn't support renaming storage volumes so > we need to copy the nvram file and remove the old one. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1368922 > > Signed-off-by: Pavel Hrdina > --- >

Re: [virt-tools-list] [virt-manager PATCH 2/2] virt-clone: add support to clone nvram VARS

2017-03-06 Thread Cole Robinson
On 03/06/2017 03:43 AM, Pavel Hrdina wrote: > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1243335 > > Signed-off-by: Pavel Hrdina > --- > man/virt-clone.pod | 6 ++ > tests/clone-xml/nvram-auto-in.xml | 23 +++ >

Re: [virt-tools-list] [virt-manager PATCH v2] domain: add support to rename domain with nvram vars file

2017-03-07 Thread Cole Robinson
On 03/07/2017 07:33 AM, Pavel Hrdina wrote: > Libvirt storage API doesn't support renaming storage volumes so > we need to copy the nvram file and remove the old one. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1368922 > > Signed-off-by: Pavel Hrdina > --- > >

Re: [virt-tools-list] [PATCH v3 1/6] Add GUI to create wizzard for virtuozzo containers

2017-03-01 Thread Cole Robinson
On 02/21/2017 09:27 AM, Mikhail Feoktistov wrote: > Add virtuozzo hypervisor to connection list. > Add radio buttons for choosing VM or container virtualization type. > New wizzard window for setting template name for containers. > --- > ui/create.ui | 149 >

Re: [virt-tools-list] [PATCH v3 2/6] Set default action in case of on_crash as destroy

2017-03-01 Thread Cole Robinson
ided to take it a bit further and push a more comprehensive change. It contains this change though so it should fix the vz issue Working on the rest of your patches now... Thanks, Cole commit fc6778108b1ea3f8a178e444fe547e9355a06dd5 Author: Cole Robinson <crobi...@redhat.com> Date: Tue Feb 21 17:27:56 2017 +0300

Re: [virt-tools-list] [PATCH v3 5/6] Do not use createXML for non transient domains

2017-03-01 Thread Cole Robinson
On 02/21/2017 09:27 AM, Mikhail Feoktistov wrote: > For these domains use defineXML > Also do not call secocd defineXML if install_xml == final_xml > --- > virtinst/guest.py | 12 +++- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/virtinst/guest.py

Re: [virt-tools-list] [PATCH v3 6/6] Add tests for Virtuozzo hypervisor

2017-03-01 Thread Cole Robinson
On 02/21/2017 09:28 AM, Mikhail Feoktistov wrote: > UI and CLI tests > --- > tests/capabilities-xml/vz.xml | 53 > ++ > .../compare/virt-install-vz-ct-template.xml| 26 +++ > tests/clitest.py | 15 ++ >

Re: [virt-tools-list] [PATCH] inspection: try harder to show a pkg summary

2017-03-01 Thread Cole Robinson
On 02/27/2017 05:29 AM, Pino Toscano wrote: > If a package has no summary, try to use the description (if available): > - if it is just one line (mostly because the package manager only has > a single line as description of a package), then use it fully > - if it contains more lines, then take

Re: [virt-tools-list] [virt-manager PATCH v2 0/9] Inspection: rework queue, allow refresh

2017-03-01 Thread Cole Robinson
On 02/23/2017 05:22 AM, Pino Toscano wrote: > Hi, > > this patch series cleans up the queue used to inspect the various VMs, > reacting also to additions/removals of connections and VMs. > Other than for making the inspection code better, also it hels for > implemeting the possibility to refresh

Re: [virt-tools-list] [virt-manager] [PATCH 5/5] pycodestyle: Do not use bare 'except:'

2017-08-02 Thread Cole Robinson
On 07/24/2017 04:26 AM, Radostin Stoyanov wrote: > A bare 'except:' catches all exceptions [1], including SystemExit, > KeyboardInterrupt, and GeneratorExit (which is not an error and should > not normally be caught by user code). In situations where you need to > catch all “normal” errors, you

Re: [virt-tools-list] [RFC] VM configuration templates

2017-08-03 Thread Cole Robinson
On 08/03/2017 10:47 AM, Cedric Bosdonnat wrote: > On Thu, 2017-08-03 at 10:05 -0400, Cole Robinson wrote: >> On 07/24/2017 04:04 AM, Cedric Bosdonnat wrote: >>> Hi all, >>> >>> While working on a special VM setup here, I was wondering about introducing >

Re: [virt-tools-list] [RFC] VM configuration templates

2017-08-03 Thread Cole Robinson
On 08/03/2017 10:34 AM, Peter Crowther wrote: > As a slightly different wish, but perhaps related, I'd love a tool that could > consume several host configuration definitions and tell me the maximal guest > configuration that could run on any of them. It's not simple to guess > processor features

Re: [virt-tools-list] [PATCH] engine: improve message about missing binaries

2017-08-16 Thread Cole Robinson
On 08/14/2017 10:04 AM, Christian Ehrhardt wrote: > The message when failing to connect can be misleading as package names > will differ per Distribution as well as not apply for e.g. self built > binaries. > This changes the message in a way to be more generic not implying literal > package

Re: [virt-tools-list] [virt-manager] [PATCH v4 0/4] Integration of virt-bootstrap

2017-07-13 Thread Cole Robinson
On 07/13/2017 03:49 AM, Radostin Stoyanov wrote: > Thank you for the feedback. I revised the patch series. > > Radostin > > Commits (4): > create: Call virt-bootstrap asynchronously > create: Show progress of container bootstrap > asyncjob: Add enable/update details methods > create:

Re: [virt-tools-list] [virt-manager] [PATCH v2 4/8] gschema: Populate/Store previous container URLs

2017-07-10 Thread Cole Robinson
On 07/05/2017 12:51 PM, Radostin Stoyanov wrote: > --- > data/org.virt-manager.virt-manager.gschema.xml | 6 > virtManager/config.py | 4 +++ > virtManager/create.py | 38 > ++ > 3 files changed, 37 insertions(+),

Re: [virt-tools-list] [virt-manager] [PATCH v2 2/8] create: Validate input on container bootstrap

2017-07-10 Thread Cole Robinson
On 07/05/2017 12:51 PM, Radostin Stoyanov wrote: > - Show error if source URL is not provided. > - Require password for authentication to source registry when username > is provided. > - Show error if destination path is not directory. > - Show error if the user has no write permissions to

Re: [virt-tools-list] [virt-manager] [PATCH v2 5/8] create: Call virt-bootstrap asynchronously

2017-07-10 Thread Cole Robinson
On 07/05/2017 12:51 PM, Radostin Stoyanov wrote: > Log messages from the virtBootstrap's logger are stored in string > buffer and shown in case of failure. > > The bootstrap method is called at the end of the "create dialog" (when > "Finish" button is clicked). > > For coordination we use global

Re: [virt-tools-list] virt-manager and sheepdog volumes

2017-07-14 Thread Cole Robinson
On 06/21/2017 08:46 AM, Thomas Fjellstrom wrote: > I've setup a working sheepdog "cluster" (one backend store on NAS, one > gateweay on vm host) . When creating a new vm with virt-manager does not set > up the volume properly. Selecting a sheepdog volume leaves the virtual > machine > with a

Re: [virt-tools-list] [virt-manager] [PATCH v2 3/8] pylint: Redefining name 'os' from outer scope

2017-07-10 Thread Cole Robinson
I reviewed + pushed this first since it's a good idea even if it isn't triggering a pylint warning with master yet Thanks, Cole On 07/05/2017 12:51 PM, Radostin Stoyanov wrote: > --- > virtManager/create.py | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git

Re: [virt-tools-list] Question on virgl opengl requirement

2017-07-16 Thread Cole Robinson
On 07/15/2017 03:03 PM, Kajinofe wrote: > Hello, > > I'm trying to enable virgl on Fedora 26 host & client using KVM/qemu and was > wondering what the minimum requirement is as far as the host's GPU goes. I'm > working with a very old GPU at the moment, link below: > > Radeon X1950XTX > OpenGL

Re: [virt-tools-list] [virt-manager PATCH] gfxdetails: add checkbox for password visibility toggle

2017-07-19 Thread Cole Robinson
On 07/18/2017 11:09 PM, Chen Hanxiao wrote: > From: Chen Hanxiao > > This patch add a checkbox for password visibility toggle. > As we stored password of SPICE/VNC in clear text in XML, > it's easy to use in UI. > > Signed-off-by: Chen Hanxiao

Re: [virt-tools-list] Adding support for cloud-init in virt-manager

2017-07-19 Thread Cole Robinson
On 07/19/2017 07:59 AM, Delemotte Barthelemy wrote: > Hello everybody, > > What do you think about allowing users to send cloud-init customization script > directly from virt-manager ? (for instance open-stack's GUI horizon includes > this feature) > Here a blog article showing how to do with the

Re: [virt-tools-list] Any Interest in GPU Pass-through UI Enhancements for Virtual Machine Manager?

2017-04-27 Thread Cole Robinson
On 04/20/2017 11:00 AM, Clif Houck wrote: > Hi virt-tools, > > I've been playing around with vfio and GPU pass-through for a while now, and > I've noticed that the Virtual Machine Manager UI makes it a bit difficult to > configure a VM properly to use GPU pass-through, and by extension PCI >

Re: [virt-tools-list] [virt-manager PATCH v2 0/4] Improve the distro tree in Create dialog

2017-04-27 Thread Cole Robinson
On 04/24/2017 10:20 AM, Pino Toscano wrote: > Hi, > > The Create dialog has a combobox to select the OS, by type and actual > variant. The problem is that if you select the option to show all the > OSes, maybe because the wanted one is not among the restricted list of > supported OSes, the lists

Re: [virt-tools-list] [virt-manager] 2 questions about libvirt virtual network

2017-04-27 Thread Cole Robinson
On 04/26/2017 06:09 AM, Lin Ma wrote: > Hi all, > > I have 2 questions about libvirt virtual network, hope can get some feedback > for you: > > 1. About forward mode 'open' of libvirt virtual network > libvirt supports creating virtual network with forward mode='open' by commit > 25e8112d. >

Re: [virt-tools-list] [virt-manager] Reset Guest.domain to None on domain creation error

2017-04-27 Thread Cole Robinson
On 04/16/2017 01:54 PM, Cole Robinson wrote: > On 04/14/2017 01:45 AM, Xiaodai Wang wrote: >> >>> >>> - Original Message - >>>> From: "Cole Robinson" <crobi...@redhat.com> >>>> To: "Xiaodai Wang" <xiaod...@

Re: [virt-tools-list] Easier container creation

2017-04-27 Thread Cole Robinson
On 04/24/2017 03:35 AM, Cedric Bosdonnat wrote: > Hi Radostin, > > On Sat, 2017-04-22 at 17:47 +0100, Radostin Stoyanov wrote: >> I am working on integration of the tool virt-bootstrap >> (https://github.com/cbosdo/virt-bootstrap) with virt-manager. >> The integration aims to replace the message

Re: [virt-tools-list] [virt-manager] [PATCH 1/5] create: Stop if virt-bootstrap has failed

2017-08-02 Thread Cole Robinson
On 07/26/2017 12:06 PM, Radostin wrote: > The check here should be done only if virt-bootstrap has been called. > >> Prevent container creation if virt-bootstrap has not finished >> successfully. >> --- >> virtManager/asyncjob.py | 3 +++ >> virtManager/create.py | 6 +- >> 2 files

Re: [virt-tools-list] [virt-manager] [PATCH 4/5] tests: Upgrade pep8 to pycodestyle

2017-08-02 Thread Cole Robinson
On 07/24/2017 10:03 AM, Cedric Bosdonnat wrote: > On Mon, 2017-07-24 at 09:26 +0100, Radostin Stoyanov wrote: >> The PEP8 [1] project has been renamed to pycodestyle [2]. >> >> [1] https://github.com/codeclimate/pep8 >> [2] https://github.com/pycqa/pycodestyle >> --- >> HACKING.md| 2

Re: [virt-tools-list] [virt-manager PATCH] pycodestyle: fix all E203 warnings

2017-08-09 Thread Cole Robinson
On 08/09/2017 10:47 AM, Chen Hanxiao wrote: > From: Chen Hanxiao > >Fix all E203 whitespace before ':' > > Signed-off-by: Chen Hanxiao > --- > v2: fix a small indent ACK, but amend the patch to also remove E203 from the pycodestyle.cfg so we

Re: [virt-tools-list] [virt-manager PATCH 1/2] pycodestyle: add ignore option

2017-08-06 Thread Cole Robinson
On 08/05/2017 03:01 AM, Chen Hanxiao wrote: > From: Chen Hanxiao > > Also disabled: >E128 continuation line under-indented for visual indent > > Signed-off-by: Chen Hanxiao > --- > setup.py | 2 ++ > 1 file changed, 2 insertions(+) > > diff

Re: [virt-tools-list] [virt-manager PATCH 2/2] pycodestyle: fix all E203 warnings

2017-08-06 Thread Cole Robinson
On 08/05/2017 03:01 AM, Chen Hanxiao wrote: > From: Chen Hanxiao > >Fix all E203 whitespace before ':' > > Signed-off-by: Chen Hanxiao This one is also already ignored in tests/pycodestyle.cfg, is it giving you warnings? That said this is one

Re: [virt-tools-list] [PATCH virt-manager] Do not use deprecated gdk_cursor_new

2017-05-03 Thread Cole Robinson
On 05/03/2017 05:09 AM, Pavel Grunt wrote: > It relies on the presence of X cursor fonts in the system. Use > recommended gdk_cursor_new_from_name and use cursor names that works > on different backends. > > Deprecated since Gdk 3.16 > > https://bugzilla.redhat.com/show_bug.cgi?id=1442612 > ---

Re: [virt-tools-list] [PATCH virt-manager] Do not use deprecated gdk_cursor_new

2017-05-03 Thread Cole Robinson
On 05/03/2017 10:50 AM, Pavel Grunt wrote: > On Wed, 2017-05-03 at 10:31 -0400, Cole Robinson wrote: >> On 05/03/2017 05:09 AM, Pavel Grunt wrote: >>> It relies on the presence of X cursor fonts in the system. Use >>> recommended gdk_cursor_new_from_name and use

Re: [virt-tools-list] [virt-manager PATCH] domain: treat VIR_DOMAIN_CRASHED not as runnable but rather as stoppable

2017-05-03 Thread Cole Robinson
On 05/01/2017 09:29 PM, Chen Hanxiao wrote: > At 2017-05-01 20:58:47, "Eric Blake" <ebl...@redhat.com> wrote: > >> On 04/30/2017 04:33 PM, Cole Robinson wrote: >> >>>> >>> >>> Is there an easy way to move a qemu VM into the crashed s

Re: [virt-tools-list] [virt-manager PATCH 0/3] add support to create open forward mode network

2017-05-03 Thread Cole Robinson
On 05/03/2017 11:56 AM, Lin Ma wrote: > Lin Ma (3): > testdriver: Add network example of open network forward mode > tests: add test for network forward mode 'open' > network: add support for network forward mode 'open' > > tests/testdriver.xml| 13 + >

Re: [virt-tools-list] [virt-manager PATCH v2] virtManager: UI: add support enable setting multifunction on hostdev

2017-05-11 Thread Cole Robinson
On 05/10/2017 06:57 AM, Pavel Hrdina wrote: > On Wed, May 10, 2017 at 06:40:30PM +0800, Chen Hanxiao wrote: >> From: Chen Hanxiao >> >> We could turn on/off multifunction of hostdev >> in page details. >> >> Signed-off-by: Chen Hanxiao >> --- >>

Re: [virt-tools-list] virt-manager password management

2017-05-09 Thread Cole Robinson
On 05/05/2017 09:34 PM, Jason Staudenmayer wrote: > I'd like to connect to two different KVM servers with two different accounts > (systems are not on the same network) without using keys. Unless I have the > two systems passwords exactly the same I can only connect to one. Where does > the

Re: [virt-tools-list] How to force em1 during virt-install?

2017-05-09 Thread Cole Robinson
On 05/05/2017 05:34 PM, William D. Colburn wrote: > I want to use virt-install on a raw hard disk to kickstart a machine. > It all works fine, but the intitial install has an eth0, and when I move > the disk to physical hardware the ethernet is em1 instead. Admittedly, > I already have to delete

Re: [virt-tools-list] [virt-manager PATCH v2] virtinst.diskbackend: set pool after creating StorageVolume

2017-05-17 Thread Cole Robinson
On 05/17/2017 04:16 AM, Pavel Hrdina wrote: > The _pool_xml in StorageVolume is used unconditionally, we need to > set it right away. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1450311 > > Signed-off-by: Pavel Hrdina > --- > virtinst/diskbackend.py | 1 + > 1

Re: [virt-tools-list] [PATCH] Remove redundant call of strip()

2017-05-17 Thread Cole Robinson
On 05/17/2017 07:53 AM, Radostin Stoyanov wrote: > Remove redundant call of the strip() function. It is already done in lines > 1302 and 1303. > > https://github.com/virt-manager/virt-manager/blob/master/virtManager/create.py#L1302 >

Re: [virt-tools-list] How to force em1 during virt-install?

2017-05-09 Thread Cole Robinson
On 05/09/2017 12:53 PM, William D. Colburn wrote: > On Tue, May 09, 2017 at 12:32:26PM -0400, Cole Robinson wrote: >> The em1 naming is set by biosdevname software inside the VM. I think it >> determines the name based on some smbios data, so there might be a way to >> inject

Re: [virt-tools-list] GSoC Project

2017-05-11 Thread Cole Robinson
On 05/09/2017 03:49 AM, Cedric Bosdonnat wrote: > Hi Radostin, > > This kind of email could be sent out to the mailing list so that others > know about your progress and difficulties. This would allow others to > jump into the topic to help you if they can. > > On Mon, 2017-05-08 at 07:58 +0100,

Re: [virt-tools-list] [virt-manager] [PATCHv2 0/2] Resolve issue with LXC filesystem

2017-06-20 Thread Cole Robinson
On 06/19/2017 04:18 AM, Radostin Stoyanov wrote: > To create "OS container" from qcow2 image > we have to check on "Customise configuration before install." > before we click Finish. > > Then under "Filesystem" when we have to set: > Type to "File", Driver to "Nbd", Format to "qcow2" and click

Re: [virt-tools-list] [virt-manager] [PATCH 0/9] Integration of virt-bootstrap

2017-06-23 Thread Cole Robinson
On 06/22/2017 10:53 AM, Radostin Stoyanov wrote: > Hi all, > > > These series of patches aim to integrate virt-bootstrap with virt-manager. > The goal is to replace the current message: > > "The OS directory tree must already exist. Creating an OS directory tree > is not yet supported" > >

Re: [virt-tools-list] [virt-manager] [PATCH 2/9] gschema: Store source URIs for container bootstrap

2017-06-23 Thread Cole Robinson
On 06/22/2017 10:53 AM, Radostin Stoyanov wrote: > --- > data/org.virt-manager.virt-manager.gschema.xml | 6 ++ > virtManager/config.py | 4 > 2 files changed, 10 insertions(+) Looks good, but combine this with patch #5 so it's one combined change Thanks, Cole

Re: [virt-tools-list] [virt-manager] [PATCH 3/9] create: Refactor OS container to enable bootstrap

2017-06-23 Thread Cole Robinson
On 06/22/2017 10:54 AM, Radostin Stoyanov wrote: > --- > ui/create.ui | 2 ++ > virtManager/create.py | 42 ++ > 2 files changed, 44 insertions(+) > > diff --git a/ui/create.ui b/ui/create.ui > index ae4227b..c9d2637 100644 > --- a/ui/create.ui >

Re: [virt-tools-list] [virt-manager] [PATCH 0/9] Integration of virt-bootstrap

2017-06-23 Thread Cole Robinson
On 06/23/2017 01:20 PM, Cole Robinson wrote: > On 06/22/2017 10:53 AM, Radostin Stoyanov wrote: >> Hi all, >> >> >> These series of patches aim to integrate virt-bootstrap with virt-manager. >> The goal is to replace the current message: >> >> "

Re: [virt-tools-list] [virt-manager] [PATCH 1/9] ui: create: Adjust UI to add support for OS tree creation

2017-06-23 Thread Cole Robinson
On 06/22/2017 10:53 AM, Radostin Stoyanov wrote: > --- > ui/create.ui | 183 > ++- > 1 file changed, 180 insertions(+), 3 deletions(-) I say combine this with patch 3 so it's semi testable Thanks, Cole

Re: [virt-tools-list] [virt-manager] [PATCH 9/9] create: Show state/details of container bootstrap

2017-06-23 Thread Cole Robinson
On 06/22/2017 10:54 AM, Radostin Stoyanov wrote: > --- > virtManager/create.py | 39 --- > 1 file changed, 36 insertions(+), 3 deletions(-) > > diff --git a/virtManager/create.py b/virtManager/create.py > index 7396aba..d540bae 100644 > ---

Re: [virt-tools-list] [virt-manager] [PATCH 5/9] create: Populate previous bootstrap source URLs

2017-06-23 Thread Cole Robinson
On 06/22/2017 10:54 AM, Radostin Stoyanov wrote: > --- > virtManager/create.py | 26 ++ > 1 file changed, 18 insertions(+), 8 deletions(-) > > diff --git a/virtManager/create.py b/virtManager/create.py > index 4bedcfe..7396aba 100644 > --- a/virtManager/create.py > +++

Re: [virt-tools-list] [virt-manager] [PATCH 6/9] ui: asyncjob: Add "Details" expander

2017-06-23 Thread Cole Robinson
On 06/22/2017 10:54 AM, Radostin Stoyanov wrote: > --- > ui/asyncjob.ui | 33 - > 1 file changed, 32 insertions(+), 1 deletion(-) Combine this with patch #8 Thanks, Cole ___ virt-tools-list mailing list

Re: [virt-tools-list] [virt-manager] [PATCH 7/9] ui: asyncjob: Align Cancel button at bottom-right

2017-06-23 Thread Cole Robinson
On 06/22/2017 10:54 AM, Radostin Stoyanov wrote: > --- > ui/asyncjob.ui | 13 ++--- > 1 file changed, 2 insertions(+), 11 deletions(-) > > diff --git a/ui/asyncjob.ui b/ui/asyncjob.ui > index 5e9ff93..d854246 100644 > --- a/ui/asyncjob.ui > +++ b/ui/asyncjob.ui > @@ -142,17 +142,6 @@ >

Re: [virt-tools-list] [virt-manager] [PATCH 4/9] create: Call virt-bootstrap asynchronously

2017-06-23 Thread Cole Robinson
On 06/22/2017 10:54 AM, Radostin Stoyanov wrote: > --- > virtManager/create.py | 74 > +++ > 1 file changed, 74 insertions(+) > > diff --git a/virtManager/create.py b/virtManager/create.py > index 658135c..4bedcfe 100644 > ---

Re: [virt-tools-list] [virt-manager] [PATCH 0/9] Integration of virt-bootstrap

2017-06-27 Thread Cole Robinson
On 06/23/2017 02:49 PM, Radostin wrote: > Hi Cole, > > Thank you for the feedback. > > To solve the problem with virt-bootstrap/skopeo use: > > virt-bootstrap docker://fedora /tmp/foo Thanks, indeed that works. Guess I'm just used to the libvirt qemu:///system URI :) Trying it now with

Re: [virt-tools-list] [virt-manager PATCH] virtManager.connection: introduce cb_add_new_pool

2017-05-22 Thread Cole Robinson
On 05/19/2017 08:34 AM, Pavel Hrdina wrote: > The cb_add_new_pool callback will add a newly created storage pool > into virt-manager's cache so we don't have to wait for the libvirt > event to be handled. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1435064 > > Signed-off-by: Pavel

Re: [virt-tools-list] Problem with firewalls on Arch Linux

2017-05-25 Thread Cole Robinson
On 05/25/2017 06:08 AM, Derek Richline wrote: > Hi all: > > I noticed that Virt Manager will not start the network "default" unless > it detects a running firewalld. Arch Linux only ships with iptables by > default. Can Virt-Manager be patched to not check as aggressively for a > firewall (or

Re: [virt-tools-list] [virt-manager PATCH] virtinst.storage: check _pool_xml before using it

2017-05-16 Thread Cole Robinson
On 05/16/2017 10:59 AM, Pavel Hrdina wrote: > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1450311 > > Signed-off-by: Pavel Hrdina > --- > virtinst/storage.py | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/virtinst/storage.py

Re: [virt-tools-list] [virt-manager PATCHv2 00/13] Drop Gtk deprecation

2017-05-31 Thread Cole Robinson
On 05/31/2017 09:08 AM, Radostin Stoyanov wrote: > This is revised version of the patch which aims to resolve Gtk deprecations > in the UI files. Glade version 3.20 was used for validation. > > Commits (13): > Format UI files with Glade 3.20 > Use GtkButtonBox instead of GtkHButtonBox >

Re: [virt-tools-list] [virt-manager PATCH 0/3] add support for UEFI secure boot features

2017-05-31 Thread Cole Robinson
On 05/31/2017 11:36 AM, Pavel Hrdina wrote: > Pavel Hrdina (3): > virt-install: add support for SMM feature > virt-install: add support for loader secure attribute > virtinst: if required by UEFI enable SMM feature and set q35 machine > type > > man/virt-install.pod

Re: [virt-tools-list] [virt-manager PATCH 1/2] Resolve incorrect label alignment

2017-06-01 Thread Cole Robinson
On 06/01/2017 01:40 AM, Radostin Stoyanov wrote: > The "xalign" property determines the horizontal alignment of the label > text inside the labels size allocation. Compare this to “halign”, > which determines how the labels size allocation is positioned > in the space available for the label. [1]

Re: [virt-tools-list] virt-manager: exit from the guest console

2017-06-01 Thread Cole Robinson
On 06/01/2017 10:43 AM, jean-philippe constantin wrote: > Hello, > > When you are in fullscreen and you want to unmaximize the guest console you > move the mouse on the little sliver of white at the top center of the screen. > > But when the mouse and the keyboard freeze for an unknowned reason,

Re: [virt-tools-list] Need help about IP aliases!!

2017-06-08 Thread Cole Robinson
On 06/08/2017 09:11 AM, Cécile Mignot wrote: > Hello, > > > I'm a french student in an internship and I'm working on virtualisation. I > began to work on Qemu/KVM and install virt-manager to set my network. > Here is my configuration: > > > On my RedHat 32bits guest: I have 4 interfaces eth0

Re: [virt-tools-list] [virt-manager] [PATCH 2/2] Set default Filesystem type for LXC to "Mount"

2017-06-16 Thread Cole Robinson
On 06/16/2017 06:32 AM, Radostin Stoyanov wrote: > --- > virtinst/devicefilesystem.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/virtinst/devicefilesystem.py b/virtinst/devicefilesystem.py > index be8f841..5c1645f 100644 > --- a/virtinst/devicefilesystem.py > +++

Re: [virt-tools-list] [virt-manager PATCH] pylint: disable undefined-loop-variable

2017-06-16 Thread Cole Robinson
On 06/14/2017 10:17 PM, Chen Hanxiao wrote: > From: Chen Hanxiao > > pylint brings noise, disable it. > > Signed-off-by: Chen Hanxiao > --- > virtinst/urlfetcher.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/virtinst/urlfetcher.py

Re: [virt-tools-list] [PATCH] Add alpine linux 3.5 and 3.6

2017-06-13 Thread Cole Robinson
libosinfo has its own list, CCd now - Cole On 06/13/2017 01:24 PM, Natanael Copa wrote: > Signed-off-by: Natanael Copa > --- > data/os/alpinelinux.org/alpinelinux-3.5.xml.in | 23 +++ > data/os/alpinelinux.org/alpinelinux-3.6.xml.in | 25

Re: [virt-tools-list] [virt-manager PATCH 0/3] add support for memory device

2017-05-05 Thread Cole Robinson
On 05/05/2017 06:22 AM, Pavel Hrdina wrote: > Pavel Hrdina (3): > virtinst.cpu: don't validate "cpus" for NUMA cells > virtinst: introduce support for element > virtinst: add support for memory device > > man/virt-install.pod | 14 +- > man/virt-xml.pod

Re: [virt-tools-list] virt-manager Start Manager error : unsupported format character '�(0xffffffef) at index 30

2017-05-05 Thread Cole Robinson
On 05/04/2017 10:12 PM, zhao...@foxmail.com wrote: > hello,friends > > I have a kvm host, the virtual machine is running normally, I can use > the |virsh| command to manage the virtual machine, but > start |virt-manager| error, the error message is as follows: |unsupported > format character '

Re: [virt-tools-list] [virt-manager PATCH] domain: treat VIR_DOMAIN_CRASHED not as runnable but rather as stoppable

2017-04-30 Thread Cole Robinson
On 04/28/2017 04:07 AM, Chen Hanxiao wrote: > From: Chen Hanxiao > > If we set on_crash as `preserve`, we'll get a crashed > VM state. > At this time, it's impossible to start this VM. > > Signed-off-by: Chen Hanxiao > --- > virtManager/domain.py

[virt-tools-list] ANNOUNCE: virt-manager 1.4.3 released

2017-09-19 Thread Cole Robinson
I'm happy to announce the release of virt-manager 1.4.3! virt-manager is a desktop application for managing KVM, Xen, and LXC virtualization via libvirt. The release can be downloaded from: http://virt-manager.org/download/ This release includes: - Improve install of debian/ubuntu non-x86

Re: [virt-tools-list] [virt-manager PATCH] choosecd: change order of check operations

2017-09-19 Thread Cole Robinson
On 09/19/2017 07:23 PM, Cole Robinson wrote: > On 09/19/2017 10:18 AM, Pavel Hrdina wrote: >> The current order of check operations is wrong. First we set the new >> path for the disk in question and after that we check whether some >> guest already uses a disk with the same

Re: [virt-tools-list] [virt-manager PATCH] cloner: get original XML with security informations

2017-09-15 Thread Cole Robinson
On 09/15/2017 12:59 PM, Pavel Hrdina wrote: > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1455491 > > Signed-off-by: Pavel Hrdina > --- > tests/clone-xml/graphics-password-in.xml | 23 +++ > tests/clone-xml/graphics-password-out.xml | 23

Re: [virt-tools-list] [PATCH 0/3] Fixes for Debian and Ubuntu CD detection

2017-09-14 Thread Cole Robinson
On 09/11/2017 11:19 AM, Viktor Mihajlovski wrote: > When playing around with --location I couldn't get > Ubuntu to work because there was no .disk/mini-info but only a > .disk/info as on Debian CDs. > > Further I've refactored the code a bit, so all CD detection is done > in one method. > > And

Re: [virt-tools-list] [virt-manager PATCH] virt-install: add a host cpu passthrough example to the -help output

2017-09-14 Thread Cole Robinson
On 09/13/2017 11:30 PM, Lin Ma wrote: > Signed-off-by: Lin Ma > --- > virtinst/cli.py | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/virtinst/cli.py b/virtinst/cli.py > index 900d185..7007ddc 100644 > --- a/virtinst/cli.py > +++ b/virtinst/cli.py > @@

Re: [virt-tools-list] [virt-manager PATCH V2] virt-install: add param cache.mode and cache.level for option '--cpu'

2017-09-14 Thread Cole Robinson
On 09/14/2017 12:09 AM, Lin Ma wrote: > libvirt supports guest CPU cache by commit df13c0b, So add this feature > to virt-install to configure cpu L3 cache mode. > > Currently, The valid values are 'passthrough', 'emulate' or 'disable'. > say: > --cpu host-passthrough,cache.mode=passthrough >

Re: [virt-tools-list] [virt-manager PATCH 0/1] virtinst: Use sudo where root permission is needed

2017-09-14 Thread Cole Robinson
On 09/09/2017 11:25 AM, Andrew Wong wrote: > On 09/09/17 05:29 AM, Pavel Hrdina wrote: >> On Fri, Sep 08, 2017 at 11:49:47PM -0400, Andrew Wong wrote: >>> Hello, >>> >>> I have a small request that I hope is reasonable. For testing VMs, I like to >>> install VMs as non-root. However, if I want to

Re: [virt-tools-list] [virt-manager PATCH] domain: invalidate domain caps if machine type is changed

2017-09-19 Thread Cole Robinson
On 09/19/2017 04:41 AM, Pavel Hrdina wrote: > This forces to reload domain capabilities. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1461684 > > Signed-off-by: Pavel Hrdina > --- > virtManager/domain.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [virt-tools-list] [virt-manager PATCH] cli: introduce snapshot parameter for disk device

2017-09-08 Thread Cole Robinson
On 09/06/2017 03:18 AM, Pavel Hrdina wrote: > This allows to configure snapshot behavior for each disk. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1430642 > > Signed-off-by: Pavel Hrdina Hmm. Part of my worry naming this 'snapshot' on the cli is that people

Re: [virt-tools-list] [virt-manager PATCH] connection: change blacklist from array to dict

2017-09-08 Thread Cole Robinson
On 09/08/2017 04:32 AM, Pavel Hrdina wrote: > If initialization of new object fails we put it into blacklist and > newer parse it again until virt-manager is restarted. This helps to > reduce number of failures if some object fails initialization every > time. > > However, there are some cases

Re: [virt-tools-list] [virt-manager PATCH] virtinst: adjust media paths for s390x

2017-08-29 Thread Cole Robinson
On 08/29/2017 09:51 AM, Viktor Mihajlovski wrote: > The install kernel and intrd files are located in /generic > of the Debian and Ubuntu s390x install trees. Further they follow a > different naming scheme than on x86. Adjust the url fetching accordingly. > ACK, pushed now. Do you have an

Re: [virt-tools-list] [virt-manager PATCH] virtinst: adjust media paths for s390x

2017-08-30 Thread Cole Robinson
On 08/30/2017 03:33 AM, Viktor Mihajlovski wrote: > On 29.08.2017 18:33, Cole Robinson wrote: >> On 08/29/2017 09:51 AM, Viktor Mihajlovski wrote: >>> The install kernel and intrd files are located in /generic >>> of the Debian and Ubuntu s390x install trees. Further

Re: [virt-tools-list] [virt-manager PATCH] cli: introduce snapshot parameter for disk device

2017-09-11 Thread Cole Robinson
On 09/09/2017 04:46 AM, Pavel Hrdina wrote: > On Fri, Sep 08, 2017 at 04:04:47PM -0400, Cole Robinson wrote: >> On 09/06/2017 03:18 AM, Pavel Hrdina wrote: >>> This allows to configure snapshot behavior for each disk. >>> >>> Resolves: https://bugzill

Re: [virt-tools-list] [virt-manager PATCH 0/2] fix tunneled migration

2017-09-08 Thread Cole Robinson
On 09/06/2017 03:23 AM, Pavel Hrdina wrote: > Pavel Hrdina (2): > domain: use correct name for variables in migration code > domain: use migrateToURI3() for tunneled migration > > virtManager/domain.py | 19 +++ > 1 file changed, 11 insertions(+), 8 deletions(-) > ACK -

Re: [virt-tools-list] UEFI/Q35: System BootOrder not found

2017-08-25 Thread Cole Robinson
On 08/24/2017 07:34 AM, ov...@fateknollogee.com wrote: > I used virt-manager (in a previous Fedora 25 install) to create a Fedora 26 > virtual machine. > This Fedora26 image was qcow2 and UEFI (firmware/chipset: EFI/Q35. > The qcow2 images were stored on a separate disk (not on the same disk as

Re: [virt-tools-list] [virt-manager PATCH] pycodestyle: fix all E131 warnings

2017-08-25 Thread Cole Robinson
On 08/17/2017 09:18 PM, Chen Hanxiao wrote: > From: Chen Hanxiao > >Fix all E131: > Continuation line unaligned for hanging indent > >Also remove ignore options of E131 > ACK - Cole ___ virt-tools-list mailing

Re: [virt-tools-list] [virt-manager PATCH 0/2] add guest cpu cache configuration for virt-install

2017-08-25 Thread Cole Robinson
On 08/21/2017 06:17 AM, Lin Ma wrote: > Currently three cache modes are supported: > host cpu L3 cache passthrough, emulated L3 cache and disable l3. > > Lin Ma (2): > virt-install: add param 'cachemode' for option '--cpu' > tests: add test for param 'cachemode' of '--cpu' > >

Re: [virt-tools-list] [virt-manager PATCH 1/2] virt-install: add param 'cachemode' for option '--cpu'

2017-08-25 Thread Cole Robinson
Firstly I suggest for this instance where the test case is small to just squash patch #2 into this one. On 08/21/2017 06:17 AM, Lin Ma wrote: > libvirt supports guest CPU cache by commit df13c0b, So add this feature > to virt-install to configure cpu L3 cache mode. > GUI support will be added

<    9   10   11   12   13   14   15   16   17   18   >