Re: [Warzone-dev] Oil anim fix patch
On Mon, 04 Jun 2007 03:11:04 -0400 Gerard Krol [EMAIL PROTECTED] wrote: My intention was Now only transparent objects are rendered by the bucket sort. (as it doesn't have any benefit for solid ones) The moving health bar was a side effect which I didn't notice. Again rendering animated components using the bucket sort is not what we want. I would suggest fixing renderAnimComponent so that it doesn't have this side-effect. (maybe pushing/popping the transform matrix) - Gerard I no think you can do simple push/pop, that is not how routine works. Much easier to just use, as original code intend, the bucketAddTypeToList( ) so they can be draw in right order. Then no need to add push/pop specific code to handle this when that call does work for us. If not broke, no fix right? -- Click to find great rates on life insurance, save big, shop here http://tagline.hushmail.com/fc/CAaCXv1QSYLRCwre8TRDgU8J4GT1QlDk/ ___ Warzone-dev mailing list Warzone-dev@gna.org https://mail.gna.org/listinfo/warzone-dev
Re: [Warzone-dev] Oil anim fix patch
Am Samstag, 2. Juni 2007 schrieb [EMAIL PROTECTED]: I guess even stupid people can fix things? :( Did someone say that? --Dennis signature.asc Description: This is a digitally signed message part. ___ Warzone-dev mailing list Warzone-dev@gna.org https://mail.gna.org/listinfo/warzone-dev
Re: [Warzone-dev] Oil anim fix patch
On Sat, 02 Jun 2007 08:07:00 -0400 Dennis Schridde [EMAIL PROTECTED] wrote: Am Samstag, 2. Juni 2007 schrieb [EMAIL PROTECTED]: I guess even stupid people can fix things? :( Did someone say that? --Dennis Yes, as pointed out by my friend who is on irc channel. :( -- Click here to find experienced pros to help with your home improvement project. http://tagline.hushmail.com/fc/CAaCXv1SNNQKAPYp2xB2nSX2lsvqE7y6/ ___ Warzone-dev mailing list Warzone-dev@gna.org https://mail.gna.org/listinfo/warzone-dev
Re: [Warzone-dev] Oil anim fix patch
On Sat, 02 Jun 2007 15:06:01 -0400 Dennis Schridde [EMAIL PROTECTED] wrote: Am Samstag, 2. Juni 2007 schrieb [EMAIL PROTECTED]: Yes, as pointed out by my friend who is on irc channel. :( In case you are refering to my talk with Giel: It was not about you being stupid in any way. You, just as other people incl. me do at times, asked about something which was discussed long before and which was clear to anyone else. In case I appeared rude, I appologize. I didn't meant to be. I can't speak for Giel, but I think he neither meant to say you are stupid. But the Smart Questions guide is really a good one and I read it again from time to time just to remind me of how I should ask and point out issues. And for the issue in question, when accepting the decision and thinking about it a while, you would have come to the conclusion that the absense of MALLOC doesn't mean the end of the world and you can still use memset and friends in cases _where that is needed_. --Dennis So patch good or not? -- No medical insurance? Click here to protect yourself and your family. http://tagline.hushmail.com/fc/CAaCXv1QUc4LVSy1wK4hYfDnEu1Eegyz/ ___ Warzone-dev mailing list Warzone-dev@gna.org https://mail.gna.org/listinfo/warzone-dev
Re: [Warzone-dev] Oil anim fix patch
On 6/2/07, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: So patch good or not? I am curious as to why it is correct, and what else might break, not just whether it fixes the bug. I see that gerard changed it in r1007: r1007 | gerard_ | 2007-04-05 17:24:03 +0200 (Thu, 05 Apr 2007) | 2 lines 1. Now only transparent objects are rendered by the bucket sort. 2. Added some asserts to check if droids stay on the map. @@ -1891,7 +1851,7 @@ psComp-orientation.y = vecRot.y; psComp-orientation.z = vecRot.z; - bucketAddTypeToList( RENDER_ANIMATION, psComp ); + renderAnimComponent( psComp ); } } } Gerard, any comment on how this should be fixed? - Per ___ Warzone-dev mailing list Warzone-dev@gna.org https://mail.gna.org/listinfo/warzone-dev
Re: [Warzone-dev] Oil anim fix patch
On Sat, 02 Jun 2007 16:31:31 -0400 Per Inge Mathisen [EMAIL PROTECTED] wrote: On 6/2/07, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: So patch good or not? I am curious as to why it is correct, and what else might break, not just whether it fixes the bug. I see that gerard changed it in r1007: --- - r1007 | gerard_ | 2007-04-05 17:24:03 +0200 (Thu, 05 Apr 2007) | 2 lines 1. Now only transparent objects are rendered by the bucket sort. 2. Added some asserts to check if droids stay on the map. @@ -1891,7 +1851,7 @@ psComp-orientation.y = vecRot.y; psComp-orientation.z = vecRot.z; - bucketAddTypeToList( RENDER_ANIMATION, psComp ); + renderAnimComponent( psComp ); } } } Gerard, any comment on how this should be fixed? - Per Gerard make mistake, since when renderAnimComponent() is call, it uses new position. This is why it swing up and down. With bucketAddTypeToList () (original) call, then it adds to list, and it no calculate position of new animation frame to draw. If this is original call, how can this break something else ? The other calls may also need change back to original, but I have not notice any other quirks. -- Save money on your project by attaining multiple quotes from contractors. Click here. http://tagline.hushmail.com/fc/CAaCXv1SNNPVPo65wOz5fPEzQ2mSIfgj/ ___ Warzone-dev mailing list Warzone-dev@gna.org https://mail.gna.org/listinfo/warzone-dev
Re: [Warzone-dev] Oil anim fix patch
Am Samstag, 2. Juni 2007 schrieb [EMAIL PROTECTED]: On Sat, 02 Jun 2007 16:31:31 -0400 Per Inge Mathisen [EMAIL PROTECTED] wrote: On 6/2/07, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: So patch good or not? I am curious as to why it is correct, and what else might break, not just whether it fixes the bug. I see that gerard changed it in r1007: --- - r1007 | gerard_ | 2007-04-05 17:24:03 +0200 (Thu, 05 Apr 2007) | 2 lines 1. Now only transparent objects are rendered by the bucket sort. 2. Added some asserts to check if droids stay on the map. @@ -1891,7 +1851,7 @@ psComp-orientation.y = vecRot.y; psComp-orientation.z = vecRot.z; - bucketAddTypeToList( RENDER_ANIMATION, psComp ); + renderAnimComponent( psComp ); } } } Gerard, any comment on how this should be fixed? - Per Gerard make mistake, since when renderAnimComponent() is call, it uses new position. This is why it swing up and down. With bucketAddTypeToList () (original) call, then it adds to list, and it no calculate position of new animation frame to draw. If this is original call, how can this break something else ? The other calls may also need change back to original, but I have not notice any other quirks. I guess Gerard had some reason to change it in the way he did. I think we should wait for his comment before we revert anything... signature.asc Description: This is a digitally signed message part. ___ Warzone-dev mailing list Warzone-dev@gna.org https://mail.gna.org/listinfo/warzone-dev
[Warzone-dev] Oil anim fix patch
I guess even stupid people can fix things? :( Index: src/display3d.c === --- src/display3d.c (revision 1430) +++ src/display3d.c (working copy) @@ -1614,7 +1614,8 @@ psComp-orientation.y = vecRot.y; psComp-orientation.z = vecRot.z; - renderAnimComponent( psComp ); + bucketAddTypeToList( RENDER_ANIMATION, psComp );//This needed to correctly draw ANIM frame. +// renderAnimComponent( psComp );//we no want to draw base on position! } } } -- Click to compare save $100's on medical insurance, free quote http://tagline.hushmail.com/fc/CAaCXv1QS4WL4c3aW39VT0UOfQlEhwKe/ ___ Warzone-dev mailing list Warzone-dev@gna.org https://mail.gna.org/listinfo/warzone-dev
