Am Samstag, 2. Juni 2007 schrieb [EMAIL PROTECTED]:
> On Sat, 02 Jun 2007 16:31:31 -0400 Per Inge Mathisen
>
> <[EMAIL PROTECTED]> wrote:
> >On 6/2/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
> >> So patch good or not?
> >
> >I am curious as to why it is correct, and what else might break,
> >not
> >just whether it fixes the bug. I see that gerard changed it in
> >r1007:
> >
> >-------------------------------------------------------------------
> >-----
> >r1007 | gerard_ | 2007-04-05 17:24:03 +0200 (Thu, 05 Apr 2007) | 2
> >lines
> >
> >1. Now only transparent objects are rendered by the bucket sort.
> >2.
> >Added some asserts to check if droids stay on the map.
> >
> >@@ -1891,7 +1851,7 @@
> >                        psComp->orientation.y = vecRot.y;
> >                        psComp->orientation.z = vecRot.z;
> >
> >-                       bucketAddTypeToList( RENDER_ANIMATION,
> >psComp );
> >+                       renderAnimComponent( psComp );
> >                }
> >        }
> > }
> >
> >Gerard, any comment on how this should be fixed?
> >
> >  - Per
>
> Gerard make mistake, since when renderAnimComponent() is call, it
> uses new position.  This is why it swing up and down.
> With bucketAddTypeToList () (original) call, then it adds to list,
> and it no calculate position of new animation frame to draw.
>
> If this is original call, how can this break something else ?  The
> other calls may also need change back to original, but I have not
> notice any other quirks.
I guess Gerard had some reason to change it in the way he did. I think we 
should wait for his comment before we revert anything...

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
Warzone-dev mailing list
[email protected]
https://mail.gna.org/listinfo/warzone-dev

Reply via email to