Re: Wave with HTTPS?

2012-01-16 Thread Ali Lown
I have also been playing around with this. I went for using stunnel to handle the actual termination, and then editing the socket.io code to force the websockets to be initialised using wss:// instead. On 16 January 2012 09:27, Thomas Leonard t...@it-innovation.soton.ac.uk wrote: Are there any

Re: Review Request: Decouple the search implementation from the waves persistence logic.

2012-01-16 Thread Andrew Kaplanov
This is a very desirable and timely addition. Thank you very much. I would ask to add the following. Now interface org.waveprotocol.box.server.waveserver.SearchProvider consists of this function: *SearchResult search(ParticipantId user, String query, int startAt, int numResults);* I think

Re: Review Request: Decouple the search implementation from the waves persistence logic.

2012-01-16 Thread Yuri Z
Currently the startAt index is not really used in the search results representation, only numResults. But you are probably right. Anyway, I am planning to work on more simple MongoDB indexing as herehttp://goo.gl/Xczzb . On Mon, Jan 16, 2012 at 9:48 PM, Andrew Kaplanov akapla...@gmail.comwrote:

Re: Review Request: Print wave title in blue bar and page title

2012-01-16 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3512/#review4410 --- Hmm, I think I already implemented something like this for

Re: Review Request: Implement fix for WAVE-321 to prevent a complete crash when only a delta corruption issue occurs

2012-01-16 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3432/#review4412 --- Ship it! If it lets the server to continue with loading - it LGTM.

Re: Review Request: Implement fix for WAVE-321 to prevent a complete crash when only a delta corruption issue occurs

2012-01-16 Thread Yuri Zelikov
On 2012-01-16 21:55:27, Yuri Zelikov wrote: If it lets the server to continue with loading - it LGTM. But maybe need to open another issue to prevent this condition to happen. Committed as r1232186. Thanks! Please close the review request. - Yuri

Re: Current project status at http://incubator.apache.org/wave/

2012-01-16 Thread Kyle Johnston
Thanks Christian! Kirill, I honestly have no idea, and while I'd love to help with the research and implementation I simply don't have the time right now. A HS diploma and college admission are my time sapping priorities. [?] God Bless, Kyle Johnston KyleJohnston.net http://kylejohnston.net/

WiaB client code usage in the wild (a.k.a Undercurrent in Blogger)

2012-01-16 Thread Patrick Coleman
Fellow wave-dev'ers; For those who missed the recent announcement, my current project (Blogger) just launched threaded commenting: http://buzz.blogger.com/2012/01/engage-with-your-readers-through.html The reason I'm emailing here though is that all the comment rendering code uses the

Re: Current project status at http://incubator.apache.org/wave/

2012-01-16 Thread Kirill Kostyuchenko
I will send patch and show site this evening. 2012/1/17 Kyle Johnston k...@kylejohnston.net Thanks Christian! Kirill, I honestly have no idea, and while I'd love to help with the research and implementation I simply don't have the time right now. A HS diploma and college admission are my