Re: [PATCH weston 1/4] ivi-shell: change layer visibility to bool

Hi Emil, On 13 February 2018 at 16:37, Emil Velikov wrote: > The following two questions come to mind: > - app bugs - using threads? ivi-shell-user-interface.c mentions > pthread, but haven't looked closely Hm, I couldn't find any threading-related bugs at all:

Re: [PATCH weston 1/4] ivi-shell: change layer visibility to bool

On 13 February 2018 at 15:11, Daniel Stone wrote: > Hi, > > On 13 February 2018 at 15:00, Pekka Paalanen wrote: >> On Thu, 8 Feb 2018 13:53:54 + >> "Ucan, Emre (ADITG/ESB)" wrote: >>> Yes I saw a similar problem when I tested

Re: [PATCH libinput] evdev: fail before open_restricted if the devnode doesn't exist

> + if (!devnode) { > + log_info(libinput, "%s: no device node associated\n", > sysname); > + return NULL; > + } > + > if (udev_device_should_be_ignored(udev_device)) { > log_debug(libinput, "%s: device is ignored\n", sysname); >

Re: [PATCH weston 1/4] ivi-shell: change layer visibility to bool

On Tue, 13 Feb 2018 15:11:19 + Daniel Stone wrote: > Hi, > > On 13 February 2018 at 15:00, Pekka Paalanen wrote: > > On Thu, 8 Feb 2018 13:53:54 + > > "Ucan, Emre (ADITG/ESB)" wrote: > >> Yes I saw a similar problem

Re: [PATCH weston] desktop-shell: fix shell_output_destroy_move_layer unused variable

Hi Pekka, On 13 February 2018 at 14:21, Pekka Paalanen wrote: > /home/pq/git/weston/desktop-shell/shell.c: In function > ‘shell_output_destroy_move_layer’: > /home/pq/git/weston/desktop-shell/shell.c:4718:24: warning: unused variable > ‘output’ [-Wunused-variable] >

RE: [PATCH weston] desktop-shell: fix shell_output_destroy_move_layer unused variable

Thanks for spotting this. Reviewed-by: Marius-Vlad -Original Message- From: wayland-devel [mailto:wayland-devel-boun...@lists.freedesktop.org] On Behalf Of Pekka Paalanen Sent: Tuesday, February 13, 2018 4:22 PM To: wayland-devel@lists.freedesktop.org Cc:

Re: [PATCH weston] libweston-desktop/xdg-shell-v5: Drop xdg-shell v5 support

On 2018-02-13 08:20 AM, Alexandros Frantzis wrote: Drop support for the obsolete xdg-shell v5 protocol. This clears the path to properly support xdg-shell stable, since xdg-shell stable and xdg-shell v5 can't currently co-exist in the same compositor, as both define structures with the same name

RE: [PATCH weston 1/4] ivi-shell: change layer visibility to bool

Hi Pekka, I will check. Best regards Emre Ucan Engineering Software Base (ADITG/ESB) Tel. +49 5121 49 6937 > -Original Message- > From: Pekka Paalanen [mailto:ppaala...@gmail.com] > Sent: Dienstag, 13. Februar 2018 16:01 > To: Ucan, Emre (ADITG/ESB) > Cc:

Re: [PATCH weston 1/4] ivi-shell: change layer visibility to bool

Hi, On 13 February 2018 at 15:00, Pekka Paalanen wrote: > On Thu, 8 Feb 2018 13:53:54 + > "Ucan, Emre (ADITG/ESB)" wrote: >> Yes I saw a similar problem when I tested previous ivi patches. >> I run make clean & make & make check. Then it worked. >>

Re: [PATCH weston 1/4] ivi-shell: change layer visibility to bool

On Thu, 8 Feb 2018 13:53:54 + "Ucan, Emre (ADITG/ESB)" wrote: > Hi Pekka, > > Yes I saw a similar problem when I tested previous ivi patches. > I run make clean & make & make check. Then it worked. > > Maybe it is releated to weston-tests-env changes from this commit:

[PATCH weston] desktop-shell: fix shell_output_destroy_move_layer unused variable

From: Pekka Paalanen /home/pq/git/weston/desktop-shell/shell.c: In function ‘shell_output_destroy_move_layer’: /home/pq/git/weston/desktop-shell/shell.c:4718:24: warning: unused variable ‘output’ [-Wunused-variable] struct weston_output *output = data; Since

[PATCH weston] libweston-desktop/xdg-shell-v5: Drop xdg-shell v5 support

Drop support for the obsolete xdg-shell v5 protocol. This clears the path to properly support xdg-shell stable, since xdg-shell stable and xdg-shell v5 can't currently co-exist in the same compositor, as both define structures with the same name (such as struct xdg_surface_interface).

Re: [PATCH wayland 1/4] scanner: use c99 initializers for the wl_interface * array

Hi Emil, Discussing the scanner symbol visibility patch made me realise that I never replied here. On 15 September 2017 at 15:39, Pekka Paalanen wrote: > On Wed, 30 Aug 2017 16:33:15 +0100 Emil Velikov > wrote: >> Allows us to remove the explicit

Re: [PATCH weston v2 3/7] libweston: Make weston_seat release safe

On 2/13/18 11:58 AM, Pekka Paalanen wrote: On Thu, 8 Feb 2018 15:37:54 +0200 Alexandros Frantzis wrote: Ensure the server can safely handle client requests for wl_seat resource that have become inert due to weston_seat object release and subsequent

Re: [PATCH weston v2 0/7] libweston: Make input object destruction safe

Hi Alexandros, On 8 February 2018 at 13:37, Alexandros Frantzis wrote: > When a weston seat or input object is destroyed, any associated client > resources should become inert and put in a state in which they can > safely handle client requests. Currently,

Re: [PATCH weston v2 7/7] tests: Add test for seat destruction and creation

On Thu, 8 Feb 2018 15:37:58 +0200 Alexandros Frantzis wrote: > Add a test to check that we can destroy and create the test seat. Since > after test seat destruction the test client releases any associated > input resources, this test also checks that libweston

Re: [PATCH weston v2 6/7] tests: Run devices tests using the test desktop shell

On Thu, 8 Feb 2018 15:37:57 +0200 Alexandros Frantzis wrote: > Use the weston-test-desktop-shell to run the devices tests, instead of > the currently used desktop-shell. The test desktop shell doesn't > interact with temporary globals (e.g. wl_seat), thus

Re: [PATCH weston v2 5/7] tests: Support setting the test client input dynamically

On Thu, 8 Feb 2018 15:37:56 +0200 Alexandros Frantzis wrote: > The current test client code waits for all wl_seat globals to arrive > before checking them and deciding which one is the test seat global to > use for the input object. Test code that needs to

Re: [PATCH weston v2 4/7] tests: Handle removal of seat global in test clients

On Thu, 8 Feb 2018 15:37:55 +0200 Alexandros Frantzis wrote: > The current test client code completely ignores removal of globals. > This commit updates the code to properly handle removal of globals in > general, and of seat globals in particular. This

Re: [PATCH weston 0/3 v2] DRM lease support

Hi all, On 13 February 2018 at 11:02, Marius-cristian Vlad wrote: > The sample client I've posted seems to be using the overlay plane. > Also, Daniel Stone confirmed a while back that they can be used. > > However it seems that page flipping on the overlay plane can

Re: [PATCH weston 0/3 v2] DRM lease support

Hi, The sample client I've posted seems to be using the overlay plane. Also, Daniel Stone confirmed a while back that they can be used. However it seems that page flipping on the overlay plane can not be used if the connector is used in the same time (and I'm not treating that case -- I disable

Re: [PATCH weston v2 3/7] libweston: Make weston_seat release safe

On Thu, 8 Feb 2018 15:37:54 +0200 Alexandros Frantzis wrote: > Ensure the server can safely handle client requests for wl_seat resource > that have become inert due to weston_seat object release and subsequent > destruction. > > The clean-up involves, among

Re: [PATCH weston v2 2/7] libweston: Make weston_pointer destruction safe

On Thu, 8 Feb 2018 15:37:53 +0200 Alexandros Frantzis wrote: > Properly clean up all sub-objects (e.g., weston_pointer_client objects) > when a weston_pointer object is destroyed. The clean-up ensures that the > server is able to safely handle client requests

Re: [PATCH weston v2 1/7] libweston: Support NULL weston_pointer in init_pointer_constraint

On Thu, 8 Feb 2018 15:37:52 +0200 Alexandros Frantzis wrote: > Fix init_pointer_constraint so that it creates a valid, but inert, > resource if a NULL weston_pointer value is passed in. In that case no > constraint object is associated with the resource, but