Re: [PATCH weston 2/2] input: Update to-be-restored focus when unfocused

On 8/2/18 10:29 AM, Quentin Glidic wrote: From: Quentin Glidic If we start a special (grabbing) client when Weston is unfocused, it would lose focus when coming back to Weston. A first attempt to fix this was 85d55540cb64bf97a08b40f79dc66843f8295d3b but it messed with VT switching. This fix

[PATCH weston 2/2] input: Update to-be-restored focus when unfocused

From: Quentin Glidic If we start a special (grabbing) client when Weston is unfocused, it would lose focus when coming back to Weston. A first attempt to fix this was 85d55540cb64bf97a08b40f79dc66843f8295d3b but it messed with VT switching. This fix just updates the saved focus, so when Weston

[PATCH weston 1/2] Revert "input: Do not override keyboard focus on restore"

From: Quentin Glidic This reverts commit 85d55540cb64bf97a08b40f79dc66843f8295d3b. It brought issues for proper VT switching focus handling. Signed-off-by: Quentin Glidic --- libweston/input.c | 26 +++--- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git

Re: [PATCH weston 3/4] README: Move to Markdown, rewrite introduction

features, don’t you think? :-) Then, all four patches are: Reviewed-by: Quentin Glidic (With or without the split.) Thanks, +The core focus of Weston is correctness and reliability. Weston aims to be lean +and fast, but more importantly, to be predictable. Whilst Weston does have known +bugs a

Re: [PATCH weston] build: don't manually parse the weston.ini.in templates

On 6/27/18 3:04 PM, Emil Velikov wrote: From: Emil Velikov Adding those to configure.ac ensures that: - the weston.ini files are {re,}generated only when needed - the .in files are shipped in the tarball - all the manual handling of the above can be removed ;-) Did you actually test

Re: [writing a compositor] Displaying something on the screen

Hi, On 5/31/18 5:42 AM, adlo wrote: I am attempting to write a simple test compositor using libweston. Here is my code so far: https://github.com/adlocode/test-libweston-desktop What else do I need to do in order to get it to the point where something appears on the screen, such as a

Re: [PATCH v2 weston] Partially revert "xwm: Add icon support to the frame" and friends

thing. Signed-off-by: Derek Foreman <der...@osg.samsung.com> > --- Changes from v1: Only reverts the changes in window-manager.c (and updates frame_create call to pass NULL for icon surface. Yeah, looks safer to me: Reviewed-by: Quentin Glidic <sardemff7+...@sardemff7.net>

Re: [PATCH wayland 2/2] wayland-egl: Make symbol test fail on failure

On 3/19/18 1:31 PM, Daniel Stone wrote: The previous rewrite of the wayland-egl ABI checker introduced checks for removed symbols as well as added symbols, but broke some failure conditions. Add an explict return-code variable set in failure paths, rather than chaining or conditions. If we

Re: [PATCH wayland 1/2] wayland-egl: Pass nm path to check script

Pekka Paalanen <pekka.paala...@collabora.co.uk> Fixes: 6903e4d53925 ("wayland-egl: use correct `nm` path when cross-compiling") Cc: Emil Velikov <emil.veli...@collabora.com> Straightforward: Reviewed-by: Quentin Glidic <sardemff7+...@sardemff7.net> Thanks, --- Mak

Re: [PATCH weston] libweston-desktop/xdg-shell-v6: Fix crash when surface has buffer at creation

() will walk an uninitialized list and dereference a NULL pointer. Initializing the list earlier prevents this from happening. Signed-off-by: Derek Foreman <der...@osg.samsung.com> Good catch: Reviewed-by: Quentin Glidic <sardemff7+...@sardemff7.net> Thanks, --- libweston-desktop/xdg-sh

Re: [PATCH wayland-protcols v2] unstable: add xdg-toplevel-decoration protocol

On 3/11/18 9:49 PM, Simon Ser wrote: [snip] + + + + This interface permits choosing between client-side and server-side + window decorations for a toplevel surface. + + A window decoration is a user interface component used to move, resize and + change a window's

Re: [PATCH wayland-protcols v2] unstable: add xdg-toplevel-decoration protocol

On 3/2/18 4:33 PM, Simon Ser wrote: This adds a new protocol to negotiate server- and client-side rendering of window decorations for xdg-toplevels. This allows compositors that want to draw decorations themselves to send their preference to clients, and clients that prefer server-side

Re: [PATCH wayland-protocols] unstable: add xdg-toplevel-decoration protocol

(I wonder if Pekka or Daniel would like to be dropped off the CC list as it may be too desktop-ish for them?) On 3/3/18 10:58 AM, Simon Ser wrote: Hi, Thanks for taking time reviewing the protocol and suggesting an alternative design. On March 2, 2018 4:36 PM, Mike Blumenkrantz

[RFC weston 2/2] compositor-x11: Use event loop abstraction API

From: Quentin Glidic <sardemff7+...@sardemff7.net> Signed-off-by: Quentin Glidic <sardemff7+...@sardemff7.net> --- libweston/compositor-x11.c | 64 +- 1 file changed, 29 insertions(+), 35 deletions(-) diff --git a/libweston/compos

[RFC weston 0/2] Event loop abstraction API

From: Quentin Glidic <sardemff7+...@sardemff7.net> We discussed on IRC about races between the several event sources that exist in libweston, libwayland and compositor code. Adding a priority system in the event loop is a first step to fix these potential races and help cope with bad c

[RFC weston 1/2] libweston: Add event loop abstraction API

From: Quentin Glidic <sardemff7+...@sardemff7.net> This will allow compositors to pick any event loop implementation they want, and integrating the libweston components with it. Specifically, idle and timeout sources can now have proper priorities to avoid being ghosted by client event proc

Re: [PATCH weston v3 3/7] libweston: Make weston_seat release safe

* parent with a destroyed weston_seat */ + if (seat == NULL) + parent_is_toplevel = true; + Good comment. Now I’m not sure if it belongs here or in weston_desktop_seat_popup_grab_get_topmost_surface() (with a separate if). Probably no big deal anyway. With these 3

Re: [PATCH weston v2 3/7] libweston: Make weston_seat release safe

pecifically for v5 where it creates an xdg_popup object while this patch would not. With that fixed (or v5 just left as unmaintained/unused), the libweston-desktop stuff is: Reviewed-by: Quentin Glidic <sardemff7+...@sardemff7.net> Thanks, + return; + } + +

Re: [PATCH] Unconditionally add linux-dmabuf’s protocol to BUILT_SOURCES

enmail.cc> Tested-by: Cedric Sodhi <man...@openmail.cc> Reviewed-by: Quentin Glidic <sardemff7+...@sardemff7.net> And pushed: 14a7e371f..0a5439961 master -> master Thanks, --- Makefile.am | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile.am b

Re: [PATCH weston v3] libweston-desktop: add signal for title/app-id changes

On 12/8/17 3:13 PM, Matt Hoosier wrote: On Fri, Dec 8, 2017 at 4:26 AM, Quentin Glidic <sardemff7+wayl...@sardemff7.net> wrote: On 12/8/17 11:22 AM, Quentin Glidic wrote: From: Matt Hoosier <matt.hoos...@gmail.com> As discussed on https://lists.freedesktop.org/archives/waylan

Re: [PATCH weston v3] libweston-desktop: add signal for title/app-id changes

On 12/8/17 11:22 AM, Quentin Glidic wrote: From: Matt Hoosier <matt.hoos...@gmail.com> As discussed on https://lists.freedesktop.org/archives/wayland-devel/2017-August/034720.html, it's useful for the shell implementation to know when these change, for example to relay the infor

[PATCH weston v3] libweston-desktop: add signal for title/app-id changes

hanges or the need to make the weston_desktop_surface definition public, new functions are introduced for attaching listeners to these signals. Signed-off-by: Matt Hoosier <matt.hoos...@gmail.com> Reviewed-by: Quentin Glidic <sardemff7+...@sardemff7.net> Signed-off-by: Quentin Glidic <sa

[PATCH weston v2] libweston-desktop/xwayland: Make sure racy surfaces are properly mapped

From: Quentin Glidic <sardemff7+...@sardemff7.net> This fixes a race between Xwayland committing the surface content via the wl_surface, and the XWM setting the role of the surface. We now keep track of the (first) content commit on the surface and forward it to the shell when we final

Re: [PATCH weston v4] xwm: Add icon support to the frame

too, like in xcb_get_property_reply_t. Signed-off-by: Emmanuel Gil Peyrot <linkma...@linkmauve.fr> Reviewed-by: Quentin Glidic <sardemff7+...@sardemff7.net> Just re-checked to be sure, found a tiny thing I overlooked (see below), but the Rb still stands anyway. --- clie

[PATCH libinput 1/2] meson: Fix absolute libdir case in install script

From: Quentin Glidic <sardemff7+...@sardemff7.net> If libdir is an absolute path (which means it’s outside of prefix) we would wrongly add the prefix to it in the install script. Just pass the correct libdir from Meson directly thanks to join_paths() magic. Signed-off-by: Quentin

[PATCH libinput 2/2] meson: Fix bindir usage in install script

From: Quentin Glidic <sardemff7+...@sardemff7.net> Since the install script cannot know the correct bindir, just pass it from Meson directly. Signed-off-by: Quentin Glidic <sardemff7+...@sardemff7.net> --- meson.build | 3 ++- tools/install-compat-scr

Re: {RFC weston] 3D window manager using libweston

On 11/16/17 4:04 PM, Harsha Manjula Mallikarjun (RBEI/ECF3) wrote: Hi All, we are developing a middleware frame work for a 3D window manager. The window manager should be able to map the client buffers to 3D shapes (cube, cylinder and so on). Our idea is that "3D window manager" uses libweston

Re: [weston v2 5/8] xwm: Make sure we respect the window's size hints

On 11/13/17 10:20 PM, Louis-Francis Ratté-Boulianne wrote: Don't just ignore the minimal and maximal sizes requested by the application. Signed-off-by: Louis-Francis Ratté-Boulianne --- xwayland/window-manager.c | 14 ++ 1 file changed, 14 insertions(+) diff

Re: [PATCH weston 00/14] Desktop Protocol Support for IVI-Shell

On 11/7/17 6:01 PM, Matt Hoosier wrote: Hi Pekka, On Wed, Oct 25, 2017 at 10:09 AM, Ucan, Emre (ADITG/ESB) wrote: Actually, IMO ivi-shell is not a proper wayland compositor. Because it is violating wayland protocol by not supporting wl_shell interface. The wl_shell

Re: [PATCH weston 3/3] weston-launch: improve help text for -u and -t

nteger, weston-launch takes a full device path. Signed-off-by: Pekka Paalanen <pekka.paala...@collabora.co.uk> Seems good: Reviewed-by: Quentin Glidic <sardemff7+...@sardemff7.net> Thanks, --- libweston/weston-launch.c | 6 -- 1 file changed, 4 insertions(+), 2 deleti

Re: [PATCH weston 2/3] weston-launch: fix -t option parsing

ve to work as expected. Signed-off-by: Pekka Paalanen <pekka.paala...@collabora.co.uk> Good catch! Reviewed-by: Quentin Glidic <sardemff7+...@sardemff7.net> Thanks, --- libweston/weston-launch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libweston/weston-la

Re: [PATCH weston 1/3] weston-launch: quit if -t without -u

quot;Too many arguments to pass to weston"); + if (tty && !wl.new_user) + error(1, 0, "tty option requires -u option as well."); Nit: maybe EINVAL? And maybe "-t/--tty … -u/--user", at least use the same format to make it clearer? Any

Re: [PATCH weston] weston: add wait-for-debugger option

resume execution with SIGCONT. Signed-off-by: Pekka Paalanen <pekka.paala...@collabora.co.uk> Quite useful indeed: Reviewed-by: Quentin Glidic <sardemff7+...@sardemff7.net> Thanks, --- compositor/main.c | 13 + man/weston.ini.man | 8 man/weston.man | 8

Re: [PATCH weston v3 06/36] libweston: refactor weston_mode_switch_finish

;pekka.paala...@collabora.co.uk> Quite obvious: Reviewed-by: Quentin Glidic <sardemff7+...@sardemff7.net> Thanks, --- libweston/compositor.c | 57 +++--- 1 file changed, 36 insertions(+), 21 deletions(-) diff --git a/libweston/com

Re: [PATCH weston v3 08/36] libweston: strdup head make, model, serial_number

alanen <pekka.paala...@collabora.co.uk> Straightforward: Reviewed-by: Quentin Glidic <sardemff7+...@sardemff7.net> As a nitpick, maybe we could add xstrdup or safe_strdup to handle the NULL case? Thanks, --- libweston/compositor.c | 14 +++--- 1 file changed, 1

Re: [PATCH weston v3 01/36] weston: arm SEGV handler earlier

r from dereferencing NULL when we don't yet have a compositor or a backend. The SEGV handler uses weston_log(), so cannot move catch_signals() any earlier. Signed-off-by: Pekka Paalanen <pekka.paala...@collabora.co.uk> Sounds good: Reviewed-by: Quentin Glidic <sardemff7+...@sardemf

Re: [PATCH weston 00/10] wayland-backend fixes

rtions(+), 29 deletions(-) Great work! The whole series is: Reviewed-by: Quentin Glidic <sardemff7+...@sardemff7.net> Thanks, -- Quentin “Sardem FF7” Glidic ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop

Re: [PATCH weston v4 1/9] protocol: add weston-debug.xml

On 10/23/17 8:55 AM, Pekka Paalanen wrote: Hi, I'm CC'ing Quentin for the automake comments below. On Thu, 12 Oct 2017 13:13:41 +0200 Emre Ucan wrote: From: Pekka Paalanen This is a new debugging extension for non-production environments. The aim is to

[PATCH wayland] cursor: Use shm_open() instead of XDG_RUNTIME_DIR files

From: Quentin Glidic <sardemff7+...@sardemff7.net> Using XDG_RUNTIME_DIR to create anonymous files is problematic when XDG_RUNTIME_DIR is not a tmpfs. OTOH, shm_open is in POSIX.1-2001, so it should be available on all platforms we care about. As a bonus, the created fd is already C

Re: [PATCH weston v2] libweston-desktop/xdg-shell-v6: Actually send same-as-current configure if needed

On 10/18/17 11:01 AM, Jonas Ådahl wrote: On Wed, Oct 18, 2017 at 10:58:44AM +0200, Quentin Glidic wrote: From: Quentin Glidic <sardemff7+...@sardemff7.net> If a surface is in state A, and we just sent a configure for state B, setting back state A would be ignored, because state B has no

[PATCH weston v2] libweston-desktop/xdg-shell-v6: Actually send same-as-current configure if needed

From: Quentin Glidic <sardemff7+...@sardemff7.net> If a surface is in state A, and we just sent a configure for state B, setting back state A would be ignored, because state B has not been committed yet. Now, we check against the latest configured state (which is current state if configur

[PATCH weston] libweston-desktop/xdg-shell-v6: Actually send same-as-current configure if needed

From: Quentin Glidic <sardemff7+...@sardemff7.net> If a surface is in state A, and we just sent a configure for state B, setting back state A would be ignored, because state B has not been committed yet. Since we only send a configure event if the state was different, consider p

Re: [PATCH weston 8/14] ivi-shell: added libweston-desktop-api implementation

Hi, I will limit my review to the libweston-desktop usage, as it’s the only part I know. On 10/17/17 11:59 AM, Michael Teyfel wrote: Signed-off-by: Michael Teyfel --- ivi-shell/ivi-shell.c | 172 ++ 1 file changed,

Re: [PATCH wayland v2 6/8] build: wire-up wayland-egl

On 10/10/17 5:21 PM, Emil Velikov wrote: On 10 October 2017 at 15:19, Quentin Glidic <sardemff7+wayl...@sardemff7.net> wrote: On 10/10/17 3:43 PM, Emil Velikov wrote: From: Emil Velikov <emil.veli...@collabora.com> Wire-up the imported sources, test and pkg-config files. v2

Re: [PATCH wayland v2 6/8] build: wire-up wayland-egl

On 10/10/17 3:43 PM, Emil Velikov wrote: From: Emil Velikov Wire-up the imported sources, test and pkg-config files. v2: - Don't mangle with existing EXTRA_DIST list - Add the symbols check script to the `make check' target - Rename

[PATCH weston] libweston-desktop/xdg-shell-v6: Ensure first configure is sent

From: Quentin Glidic <sardemff7+...@sardemff7.net> The old code for scheduling configure events on idle looked like: if (configure_scheduled) { if (this_event_is_the_same) { remove_timer(); return; } } If we queued one new event (either changed, or the client had never re

Re: [PATCH wayland] scanner: Add autoconf macro to check for the proper scanner

On 8/18/17 11:30 AM, Quentin Glidic wrote: From: Quentin Glidic <sardemff7+...@sardemff7.net> Projects have been using various ways to check for the wayland-scanner, mostly based on their developper own use case, and often not allowing others use cases to work without a workaround. Hop

[PATCH wayland] scanner: Add autoconf macro to check for the proper scanner

From: Quentin Glidic <sardemff7+...@sardemff7.net> Projects have been using various ways to check for the wayland-scanner, mostly based on their developper own use case, and often not allowing others use cases to work without a workaround. Hopefully this macro will support all use cases w

Re: [PATCH weston 4/4] libweston-desktop/xdg-shell-v5: initialize configure list

On 8/5/17 4:38 PM, Quentin Glidic wrote: Pushed this one as a critical bug fix (since we are in RC1): 18e77af6..3000a1c7  master -> master I’ll let someone else push the others while in RC if they find them critical enough. Otherwise, I’ll push them after the release. Release done, pus

Re: [PATCH weston 4/4] libweston-desktop/xdg-shell-v5: initialize configure list

On 8/5/17 1:59 PM, Arnaud Vrac wrote: Without this weston crashes when a client using xdg-shell-v5 is run. Signed-off-by: Arnaud Vrac --- libweston-desktop/xdg-shell-v5.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libweston-desktop/xdg-shell-v5.c

Re: [PATCH weston 4/4] libweston-desktop/xdg-shell-v5: initialize configure list

On 8/5/17 1:59 PM, Arnaud Vrac wrote: Without this weston crashes when a client using xdg-shell-v5 is run. Signed-off-by: Arnaud Vrac <raw...@gmail.com> Oops. Good catch: Reviewed-by: Quentin Glidic <sardemff7+...@sardemff7.net> Thanks, --- libweston-desktop/xdg-shell-v5.

Re: [PATCH weston 3/4] configure.ac: remove dependency on mtdev

On 8/5/17 1:59 PM, Arnaud Vrac wrote: It's been unused since the legacy (non-libinput) input backends have been removed. Signed-off-by: Arnaud Vrac <raw...@gmail.com> Sounds good: Reviewed-by: Quentin Glidic <sardemff7+...@sardemff7.net> Thanks, --- configure.ac

Re: [PATCH weston 1/4] gl-renderer: fix leak on dmabuf image destroy

weston/gl-renderer.c @@ -337,6 +337,7 @@ dmabuf_image_destroy(struct dmabuf_image *image) linux_dmabuf_buffer_set_user_data(image->dmabuf, NULL, NULL); wl_list_remove(>link); + free(image); } static const char * Good: Reviewed-by: Quentin Glidi

Re: [PATCH weston 2/4] configure.ac: fix linking when using compiler sanitizers

this by checking for dlsym instead of dlopen. This can be reproduced by configuring the build with: CFLAGS="-fsanitize=address -fsanitize=undefined" LDFLAGS="-fsanitize=address -fsanitize=undefined" Signed-off-by: Arnaud Vrac <raw...@gmail.com> Well explained: R

Re: [PATCH weston] desktop-shell: Set surface resizing state during interactive resize

. Signed-off-by: Philipp Kerling <pkerl...@casix.org> I’ll take that as a bug fix, so let’s land it in beta. Added a couple of variables to avoid the long lines breaks and: Reviewed-by: Quentin Glidic <sardemff7+...@sardemff7.net> Then pushed: e3715527..c5f12416 master ->

Re: [PATCH weston] libweston-desktop: fix the size of unmaximized xdg surfaces

On 7/27/17 3:01 PM, Giulio Camuffo wrote: When unmaximizing a surface the configure event should send 0,0 as the requested size, so that the client can use the size that it had before maximizing Hi, I disagree on this patch for a few reasons: - the size can be ignored in this case, so there

Re: [PATCH] libweston-desktop/xdg-shell: Check window geometry instead of surface size against configured size

urface->height)) { + (toplevel->next.size.width != geometry.width || +toplevel->next.size.height != geometry.height)) { struct weston_desktop_client *client = weston_desktop_surface_get_client(toplevel->base.desktop_surface);

Re: [PATCH] desktop-shell: Track focused shell surface by main surface

sed for shell_surface keyboard focus tracking. As said on IRC, added your Sob, and: Reviewed-by: Quentin Glidic <sardemff7+...@sardemff7.net> And pushed: 4c4b9cfb..ba8a0d04 master -> master Thanks! --- desktop-shell/shell.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH weston] libweston-desktop/xwayland: Make sure racy surfaces are properly mapped

On 5/15/17 4:40 PM, Pekka Paalanen wrote: On Mon, 15 May 2017 15:29:29 +0200 Quentin Glidic <sardemff7+wayl...@sardemff7.net> wrote: From: Quentin Glidic <sardemff7+...@sardemff7.net> Signed-off-by: Quentin Glidic <sardemff7+...@sardemff7.net> --- libweston-deskt

Re: [RFC weston] xwm: update override-redirect surface's position upon configure_notify

should always call view_set_position(), not just the first time we set this state. Signed-off-by: Ilia Bozhinov <amme...@gmail.com> Good: Reviewed-by: Quentin Glidic <sardemff7+...@sardemff7.net> And pushed: 749637a8..3e5303da master -> master Thanks, --- libweston-desktop/

Re: [PATCH] libweston-desktop: add signals for title, app_id

On 7/20/17 4:33 PM, Matt Hoosier wrote: It's useful for the shell implementation to know when these change, for example to relay the information on to taskbars or similar. The idea is good, we need something like that. (But maybe not, see below). To avoid ABI changes or the need to make the

[PATCH weston v2] input: Do not override keyboard focus on restore

From: Quentin Glidic <sardemff7+...@sardemff7.net> If we start a special (grabbing) client when Weston is unfocused, it would lose focus when coming back to Weston. Signed-off-by: Quentin Glidic <sardemff7+...@sardemff7.net> --- v2: Reset saved focus in weston_keybord_set_focus

Re: [PATCH][weston] configure.ac: Add --with-wayland-scanner-path

On 7/18/17 3:58 PM, Pekka Paalanen wrote: On Wed, 24 May 2017 11:32:21 +0300 Jussi Kukkonen <jussi.kukko...@intel.com> wrote: On 23 May 2017 at 14:51, Quentin Glidic <sardemff7+wayl...@sardemff7.net> wrote: So you want to break the simple (cross-compiling) cases to f

Re: [PATCH wayland-protocols] sysroot prefix

On 7/20/17 11:25 AM, Daniel Stone wrote: Hi, On 20 July 2017 at 10:14, Quentin Glidic <sardemff7+wayl...@sardemff7.net> wrote: Using ${pc_sysrootdir} sounds like the correct thing to do. However, your patch introduces a triple / when PKG_CONFIG_SYSROOT_DIR is not set. Having two / is a

Re: [PATCH wayland-protocols] sysroot prefix

On 7/6/17 11:02 AM, Tomek Bury wrote: Hi, I've attached a trivial patch we discussed yesterday on #wayland channel. The patch adds a sysroot prefix to the "pkgdatadir" variable. The pkg-config automatically adds sysroot to paths returned by --cflags and --libs but *NOT* to --variable. The

Re: [PATCH weston v4] libweston-desktop/xdg-shell: Properly handle ack_configure

On 7/20/17 10:49 AM, Jonas Ådahl wrote: On Thu, Jul 20, 2017 at 10:45:38AM +0200, Quentin Glidic wrote: From: Quentin Glidic <sardemff7+...@sardemff7.net> Now we keep track of serial->state association and we discard the states that the client ignored. Signed-off-by: Quentin Glidic &

[PATCH weston v3] libweston-desktop/xdg-shell: Properly handle ack_configure

From: Quentin Glidic <sardemff7+...@sardemff7.net> Now we keep track of serial->state association and we discard the states that the client ignored. Signed-off-by: Quentin Glidic <sardemff7+...@sardemff7.net> --- v3: Fixed a tiny style issue Now send an error on wrong ser

Re: [PATCH weston v2 2/2] libweston-desktop/xdg-shell: Properly handle ack_configure

On 7/20/17 5:56 AM, Jonas Ådahl wrote: On Tue, Jul 18, 2017 at 01:14:49PM +0200, Quentin Glidic wrote: From: Quentin Glidic <sardemff7+...@sardemff7.net> Now we keep track of serial->state association and we discard the states that the client ignored. Signed-off-by: Quentin Glidic &

[PATCH weston v2 2/2] libweston-desktop/xdg-shell: Properly handle ack_configure

From: Quentin Glidic <sardemff7+...@sardemff7.net> Now we keep track of serial->state association and we discard the states that the client ignored. Signed-off-by: Quentin Glidic <sardemff7+...@sardemff7.net> --- libweston-desktop/xdg-shell-v5.c | 45 +++-

[PATCH weston v2 1/2] libweston-desktop/xdg-shell: Check surface size against acknowledged size

From: Quentin Glidic <sardemff7+...@sardemff7.net> We were checking against the pending size, which lead some clients (simple-egl) to crash because they sent a buffer before acknowledging the latest configure event. Signed-off-by: Quentin Glidic <sardemff7+...@sardemff7.net> Tested-

Re: [PATCH weston 2/3] libweston-desktop/xdg-shell: Add pending/next/current structs

On 7/12/17 11:09 AM, Jonas Ådahl wrote: On Wed, Jul 12, 2017 at 09:53:03AM +0200, Quentin Glidic wrote: From: Quentin Glidic <sardemff7+...@sardemff7.net> Signed-off-by: Quentin Glidic <sardemff7+...@sardemff7.net> Reviewed-by: Jonas Ådahl <jad...@gmail.com> Thanks. Adde

Re: [PATCH weston 3/3] libweston-desktop/xdg-shell: Check surface size against acknowledged size

On 7/12/17 12:07 PM, Jonas Ådahl wrote: On Wed, Jul 12, 2017 at 12:02:29PM +0200, Quentin Glidic wrote: On 7/12/17 11:23 AM, Jonas Ådahl wrote: On Wed, Jul 12, 2017 at 09:53:04AM +0200, Quentin Glidic wrote: From: Quentin Glidic <sardemff7+...@sardemff7.net> We were checking a

Re: [PATCH weston 3/3] libweston-desktop/xdg-shell: Check surface size against acknowledged size

On 7/12/17 11:23 AM, Jonas Ådahl wrote: On Wed, Jul 12, 2017 at 09:53:04AM +0200, Quentin Glidic wrote: From: Quentin Glidic <sardemff7+...@sardemff7.net> We were checking against the pending size, which lead some clients (simple-egl) to crash because they sent a buffer before acknowl

[PATCH weston 1/3] libweston-desktop/xdg-shell: Rename requested_ to pending_

From: Quentin Glidic <sardemff7+...@sardemff7.net> Signed-off-by: Quentin Glidic <sardemff7+...@sardemff7.net> --- libweston-desktop/xdg-shell-v5.c | 56 +++--- libweston-desktop/xdg-shell-v6.c | 58 2 files

[PATCH weston 2/3] libweston-desktop/xdg-shell: Add pending/next/current structs

From: Quentin Glidic <sardemff7+...@sardemff7.net> Signed-off-by: Quentin Glidic <sardemff7+...@sardemff7.net> --- libweston-desktop/xdg-shell-v5.c | 80 ++--- libweston-desktop/xdg-shell-v6.c | 97 ++-- 2 files

[PATCH weston 3/3] libweston-desktop/xdg-shell: Check surface size against acknowledged size

From: Quentin Glidic <sardemff7+...@sardemff7.net> We were checking against the pending size, which lead some clients (simple-egl) to crash because they sent a buffer before acknowledging the latest configure event. Signed-off-by: Quentin Glidic <sardemff7+...@sardemff7.net> --

Re: [PATCH weston] libweston-desktop/xdg-shell: Consolidate configure event sending

On 6/23/17 1:11 PM, Daniel Stone wrote: Hi Quentin, On 13 April 2017 at 20:15, Quentin Glidic <sardemff7+wayl...@sardemff7.net> wrote: When switching a state twice in a row, we were overwriting the old value without setting it back, sending a wrong state to the client. Now we upda

Re: [PATCH weston] libweston-desktop/xdg_shell_v6: Send error on wrongly-sized buffer

On 6/23/17 12:59 PM, Daniel Stone wrote: Hi Quentin, On 10 March 2017 at 10:50, Quentin Glidic <sardemff7+wayl...@sardemff7.net> wrote: @@ -634,22 +633,27 @@ weston_desktop_xdg_toplevel_committed(struct weston_desktop_xdg_toplevel *toplev + if ((toplevel->next_state.

Re: libweston versions and tutorials

On 5/31/17 2:37 PM, adlo wrote: Is libweston 1.0 good enough for writing a compositor? Yes, but each major version is adding or changing API to make it simpler to write a compositor. Specifically, libweston 2 has introduced a much nicer output API, thanks to Armin’s GSoC work. Are there

Re: Return values in Wayland XML specification

On 5/24/17 8:37 PM, adlo wrote: On 24 May 2017, at 16:43, Quentin Glidic <sardemff7+wayl...@sardemff7.net> wrote: There is no need, because the compositor is supposed to list only relevant surfaces. What I would like to do is get the desktop window so that I can display a fake live

Re: Return values in Wayland XML specification

On 5/24/17 5:41 PM, adlo wrote: On 15 May 2017, at 10:52, Quentin Glidic <sardemff7+wayl...@sardemff7.net> wrote: If you are writing/porting a window switcher, please consider using Wayland Wall window-switcher protocol[1]. If you are not, please don’t, as this protocol is very sp

Re: [PATCH][weston] configure.ac: Add --with-wayland-scanner-path

that works for everyone, then we failed at defining what wayland-scanner is and how it should be used. Jussi On 23 May 2017 at 11:56, Quentin Glidic <sardemff7+wayl...@sardemff7.net <mailto:sardemff7%2bwayl...@sardemff7.net>> wrote: > > On 5/23/17 10:05 AM, Ju

Re: [PATCH weston v6 0/6] Implement screensaver/idle inhibition

On 9/9/16 4:31 AM, Bryce Harrington wrote: Updated to include review feedback from Quentin on the v5. That involves refinements to the destructor behavior, reorganizing patches a bit, and noting that if the idle manager is destroyed by the client, the individual inhibitor objects remain active.

Re: [PATCH] configure.ac: use AC_HEADER_MAJOR to detect major()/minor()

On 3/13/17 11:40 AM, Sergei Trofimovich wrote: Before the change build failed on Gentoo as: libweston/weston_launch-weston-launch.o: In function `handle_open': weston/libweston/weston-launch.c:363: undefined reference to `major' weston/libweston/weston-launch.c:365: undefined reference

Re: [PATCH weston v3] xwm: Add icon support to the frame

>icon_surface) != CAIRO_STATUS_SUCCESS) { + cairo_surface_destroy(window->icon_surface); + window->icon_surface = NULL; + } If we wait until success to replace the icon, we could keep a good (though outdated) icon if we failed to import the new one. Wit

Re: [PATCH] weston fbdev: Instead of less than 1 Hz use default refresh rate

doing: Reviewed-by: Quentin Glidic <sardemff7+...@sardemff7.net> And pushed: 47bbdc72..a5066e00 master -> master Thanks, --- libweston/compositor-fbdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libweston/compositor-fbdev.c b/libweston/compositor-fbdev.

Re: [PATCH v2] weston: Add support for "--foo bar" style options

n_with_arg() to assert Signed-off-by: Lyude <ly...@redhat.com> Reviewed-by: Eric Engestrom <e...@engestrom.ch> Nice one, I had one a lng time ago but never really rebased it: Reviewed-by: Quentin Glidic <sardemff7+...@sardemff7.net> Changed the style a tiny bit (line

Re: [PATCH][weston] configure.ac: Add --with-wayland-scanner-path

On 5/23/17 10:05 AM, Jussi Kukkonen wrote: Modify wayland-scanner lookup: Use the path given by pkg-config but offer an option to override the path with "--with-wayland-scanner-path=PATH". The latter is useful for cross-compile situations. I would rather use --with-wayland-scanner.

Re: Return values in Wayland XML specification

On 5/19/17 4:57 PM, adlo wrote: Do any compositors support this protocol? Any compositor based on libweston and capable of loading weston plugins (and later libweston plugins), using Weston Wall[1]. The implementation is limited (no workspaces support) but that is something fixable in the

[PATCH weston] libweston-desktop/xwayland: Make sure racy surfaces are properly mapped

From: Quentin Glidic <sardemff7+...@sardemff7.net> Signed-off-by: Quentin Glidic <sardemff7+...@sardemff7.net> --- libweston-desktop/xwayland.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libweston-desktop/xwayland.c b/libweston-desktop/xwayland.c index 4f4b45

Re: Return values in Wayland XML specification

On 5/15/17 3:13 PM, adlo wrote: On 15 May 2017, at 10:52, Quentin Glidic <sardemff7+wayl...@sardemff7.net> wrote: If you are writing/porting a window switcher, please consider using Wayland Wall window-switcher protocol[1]. If you are not, please don’t, as this protocol is very sp

Re: Return values in Wayland XML specification

On 5/15/17 9:46 AM, Pekka Paalanen wrote: On Mon, 15 May 2017 07:05:26 +0200 Wojciech Kluczka wrote: In Wayland array can contain only integers. Hi, not exactly. The data type inside an array is unspecified by the XML language. You can use literally anything,

Re: [PATCH libinput 5/5] Add meson.build file

On 4/26/17 4:20 AM, Peter Hutterer wrote: Signed-off-by: Peter Hutterer --- meson.build | 596 ++ meson_options.txt | 16 ++ 2 files changed, 612 insertions(+) create mode 100644 meson.build create mode

Re: [PATCH libinput 5/5] Add meson.build file

On 4/26/17 4:20 AM, Peter Hutterer wrote: Signed-off-by: Peter Hutterer --- meson.build | 596 ++ meson_options.txt | 16 ++ 2 files changed, 612 insertions(+) create mode 100644 meson.build create mode

Re: [PATCH weston 1/6 v7] desktop-shell: Enable per-output fade animations

Harrington <br...@osg.samsung.com> Reviewed-by: Quentin Glidic <sardemff7+...@sardemff7.net> Let’s start small and push this one for now: 2cd87fe8..9ad4de1f master -> master Thanks, --- desktop-shell/shell.c | 137 -- deskto

[PATCH weston] libweston-desktop/xdg-shell: Consolidate configure event sending

From: Quentin Glidic <sardemff7+...@sardemff7.net> When switching a state twice in a row, we were overwriting the old value without setting it back, sending a wrong state to the client. Now we update our requested state, then check if we need to schedule a configure event, if we ha

Re: [PATCH weston v2] desktop-shell: Position maximized surfaces on the correct output.

ce fix: Reviewed-by: Quentin Glidic <sardemff7+...@sardemff7.net> And pushed: 597dde5c..c3941794 master -> master As said on IRC (and written in my TODO), these “was there a change” checks should eventually be in libweston-desktop, to conditionally call the committed callback. Thanks,

Re: [PATCH weston 3/3] build: make libdrm a hard build-time dependency

ed-off-by: Pekka Paalanen <pekka.paala...@collabora.co.uk> Nice(ly documented) cleanup :-) Reviewed-by: Quentin Glidic <sardemff7+...@sardemff7.net> (Nitpick below, for the sake of nitpicking. ;-) ) Thanks, --- Makefile.am | 2 +- configure.ac | 12 +--- 2 files chan

Re: [PATCH weston 2/3] build: do not link libdrm without DRM backend

ne, but both ways: Reviewed-by: Quentin Glidic <sardemff7+...@sardemff7.net> Thanks, --- Makefile.am | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index 7ee613b..ff927c1 100644 --- a/Makefile.am +++ b/Makefile.am

Re: [PATCH weston 1/3] configure: replace HAVE_LIBDRM with BUILD_DRM_COMPOSITOR

emoved completely. Signed-off-by: Pekka Paalanen <pekka.paala...@collabora.co.uk> It makes clear these are DRM-specific: Reviewed-by: Quentin Glidic <sardemff7+...@sardemff7.net> Thanks, --- configure.ac | 3 +-- libweston/launcher-direct.c| 2 +-

  1   2   3   4   5   6   >