[webkit-changes] [239328] trunk/JSTests

2018-12-18 Thread mark . lam
Title: [239328] trunk/JSTests Revision 239328 Author mark@apple.com Date 2018-12-18 00:16:14 -0800 (Tue, 18 Dec 2018) Log Message Skip the stress/elidable-new-object-roflcopter-then-exit.js test on 32-bit. https://bugs.webkit.org/show_bug.cgi?id=191374 Reviewed by Yusuke Suzuki.

[webkit-changes] [239327] trunk/JSTests

2018-12-18 Thread mark . lam
Title: [239327] trunk/JSTests Revision 239327 Author mark@apple.com Date 2018-12-17 23:58:59 -0800 (Mon, 17 Dec 2018) Log Message Skip the stress/materialized-regexp-has-correct-last-index-set-by-match.js test on 32-bit. https://bugs.webkit.org/show_bug.cgi?id=192019 Reviewed by

[webkit-changes] [239329] trunk/Tools

2018-12-18 Thread philn
Title: [239329] trunk/Tools Revision 239329 Author ph...@webkit.org Date 2018-12-18 05:00:36 -0800 (Tue, 18 Dec 2018) Log Message Unreviewed, JHBuild GTK build fix attempt * gtk/jhbuild.modules: There's no libffi in this moduleset anymore. There's no ninja module either, it should be

[webkit-changes] [239335] trunk/Source/WebCore

2018-12-18 Thread zalan
Title: [239335] trunk/Source/WebCore Revision 239335 Author za...@apple.com Date 2018-12-18 07:28:47 -0800 (Tue, 18 Dec 2018) Log Message [LFC][BFC][MarginCollapsing] Implement marginAfterCollapsesWithSiblingMarginBeforeWithClearance https://bugs.webkit.org/show_bug.cgi?id=192799

[webkit-changes] [239331] trunk/Source/WebCore

2018-12-18 Thread zalan
Title: [239331] trunk/Source/WebCore Revision 239331 Author za...@apple.com Date 2018-12-18 07:23:47 -0800 (Tue, 18 Dec 2018) Log Message [LFC][BFC][MarginCollapsing] Expand marginAfterCollapsesWithNextSibling and marginBeforeCollapsesWithPreviousSibling collapsing logic

[webkit-changes] [239336] trunk/Source/WebCore

2018-12-18 Thread zalan
Title: [239336] trunk/Source/WebCore Revision 239336 Author za...@apple.com Date 2018-12-18 07:30:25 -0800 (Tue, 18 Dec 2018) Log Message [LFC][BFC][MarginCollapsing] Implement marginBeforeCollapsesWithParentMarginAfter https://bugs.webkit.org/show_bug.cgi?id=192801 Reviewed by Antti

[webkit-changes] [239330] trunk/Source/WebCore

2018-12-18 Thread zalan
Title: [239330] trunk/Source/WebCore Revision 239330 Author za...@apple.com Date 2018-12-18 07:19:21 -0800 (Tue, 18 Dec 2018) Log Message [LFC][BFC][MarginCollapsing] Expand marginAfterCollapsesWithParentMarginAfter and marginBeforeCollapsesWithParentMarginBefore collapsing logic

[webkit-changes] [239333] trunk

2018-12-18 Thread cdumez
Title: [239333] trunk Revision 239333 Author cdu...@apple.com Date 2018-12-18 07:26:50 -0800 (Tue, 18 Dec 2018) Log Message Regression(r239182) SuspendedPage's process reuse for link navigation optimization sometimes broken https://bugs.webkit.org/show_bug.cgi?id=192772 Reviewed by

[webkit-changes] [239334] trunk/Source/WebCore

2018-12-18 Thread zalan
Title: [239334] trunk/Source/WebCore Revision 239334 Author za...@apple.com Date 2018-12-18 07:27:09 -0800 (Tue, 18 Dec 2018) Log Message [LFC][BFC][MarginCollapsing] Implement marginAfterCollapsesWithParentMarginBefore https://bugs.webkit.org/show_bug.cgi?id=192798 Reviewed by Antti

[webkit-changes] [239337] trunk

2018-12-18 Thread wenson_hsieh
Title: [239337] trunk Revision 239337 Author wenson_hs...@apple.com Date 2018-12-18 07:37:10 -0800 (Tue, 18 Dec 2018) Log Message Calling setValue() while typing should invoke -textDidChangeInTextField in the injected bundle https://bugs.webkit.org/show_bug.cgi?id=192785 Reviewed by

[webkit-changes] [239332] trunk/Source/WebCore

2018-12-18 Thread zalan
Title: [239332] trunk/Source/WebCore Revision 239332 Author za...@apple.com Date 2018-12-18 07:25:32 -0800 (Tue, 18 Dec 2018) Log Message [LFC][BFC][MarginCollapsing] Expand marginsCollapseThrough collapsing logic https://bugs.webkit.org/show_bug.cgi?id=192794 Reviewed by Antti

[webkit-changes] [239338] trunk/LayoutTests

2018-12-18 Thread simon . fraser
Title: [239338] trunk/LayoutTests Revision 239338 Author simon.fra...@apple.com Date 2018-12-18 09:11:50 -0800 (Tue, 18 Dec 2018) Log Message Fix test failure after r239306. Need Mojave WK1 results for this test. *

[webkit-changes] [239339] trunk

2018-12-18 Thread achristensen
Title: [239339] trunk Revision 239339 Author achristen...@apple.com Date 2018-12-18 10:26:33 -0800 (Tue, 18 Dec 2018) Log Message WKWebView has old URL while displaying SafeBrowsing interstitial, for link-click navigations https://bugs.webkit.org/show_bug.cgi?id=192675 Reviewed by

[webkit-changes] [239343] trunk

2018-12-18 Thread joepeck
Title: [239343] trunk Revision 239343 Author joep...@webkit.org Date 2018-12-18 11:18:44 -0800 (Tue, 18 Dec 2018) Log Message Web Inspector: m3u8 content not shown, it should be text https://bugs.webkit.org/show_bug.cgi?id=192731 Reviewed by Devin Rousso. Source/WebCore: *

[webkit-changes] [239340] trunk/Source/JavaScriptCore

2018-12-18 Thread sbarati
Title: [239340] trunk/Source/_javascript_Core Revision 239340 Author sbar...@apple.com Date 2018-12-18 10:40:28 -0800 (Tue, 18 Dec 2018) Log Message Unreviewed. Appease a build error where we weren't using a variable defined in an "if" * dfg/DFGAbstractInterpreterInlines.h:

[webkit-changes] [239341] trunk

2018-12-18 Thread justin_michaud
Title: [239341] trunk Revision 239341 Author justin_mich...@apple.com Date 2018-12-18 10:51:05 -0800 (Tue, 18 Dec 2018) Log Message CSS Typed OM should expose attributeStyleMap https://bugs.webkit.org/show_bug.cgi?id=192671 Reviewed by Ryosuke Niwa. LayoutTests/imported/w3c: *

[webkit-changes] [239342] trunk

2018-12-18 Thread dbates
Title: [239342] trunk Revision 239342 Author dba...@webkit.org Date 2018-12-18 11:17:15 -0800 (Tue, 18 Dec 2018) Log Message Remove support https://bugs.webkit.org/show_bug.cgi?id=185077 Reviewed by Brent Fulgham. Source/WebCore: Remove support for the HTTP-equiv. pragma Set-Cookie

[webkit-changes] [239348] trunk/Source/WebKit

2018-12-18 Thread commit-queue
Title: [239348] trunk/Source/WebKit Revision 239348 Author commit-qu...@webkit.org Date 2018-12-18 12:59:53 -0800 (Tue, 18 Dec 2018) Log Message HTTPS Upgrade: Scripts / preprocessing necessary to create new database in future https://bugs.webkit.org/show_bug.cgi?id=192612 Patch by

[webkit-changes] [239349] trunk/Source/WebCore

2018-12-18 Thread youenn
Title: [239349] trunk/Source/WebCore Revision 239349 Author you...@apple.com Date 2018-12-18 13:41:34 -0800 (Tue, 18 Dec 2018) Log Message Make ReadableStreamXX constructs use PrivateIdentifier https://bugs.webkit.org/show_bug.cgi?id=192771 Reviewed by Chris Dumez. PrivateIdentifier is

[webkit-changes] [239351] trunk

2018-12-18 Thread justin_fan
Title: [239351] trunk Revision 239351 Author justin_...@apple.com Date 2018-12-18 13:51:56 -0800 (Tue, 18 Dec 2018) Log Message [WebGPU] BindGroupLayout and Device::createBindGroupLayout https://bugs.webkit.org/show_bug.cgi?id=192817 Reviewed by Dean Jackson. Update bind-group-layouts

[webkit-changes] [239350] trunk/LayoutTests

2018-12-18 Thread ryanhaddad
Title: [239350] trunk/LayoutTests Revision 239350 Author ryanhad...@apple.com Date 2018-12-18 13:51:06 -0800 (Tue, 18 Dec 2018) Log Message Unreviewed test gardening after r239306 and r239338. Move test compositing/contents-format baselines for Mojave into platform/mac, add new

[webkit-changes] [239352] trunk/Source

2018-12-18 Thread ddkilzer
Title: [239352] trunk/Source Revision 239352 Author ddkil...@apple.com Date 2018-12-18 13:54:24 -0800 (Tue, 18 Dec 2018) Log Message clang-tidy: Use const reference for MediaTime parameter to prevent object copy Reviewed by Mark Lam. Source/_javascript_Core: * runtime/JSCJSValue.h:

[webkit-changes] [239353] trunk/Source/WebCore

2018-12-18 Thread rniwa
Title: [239353] trunk/Source/WebCore Revision 239353 Author rn...@webkit.org Date 2018-12-18 14:03:07 -0800 (Tue, 18 Dec 2018) Log Message Some iOS app crash in FrameLoader::checkCompleted https://bugs.webkit.org/show_bug.cgi?id=192804 Reviewed by Tim Horton. It's possible for the

[webkit-changes] [239354] trunk

2018-12-18 Thread ross . kirsling
Title: [239354] trunk Revision 239354 Author ross.kirsl...@sony.com Date 2018-12-18 14:14:20 -0800 (Tue, 18 Dec 2018) Log Message Redeclaration of var over let/const/class should be a syntax error. https://bugs.webkit.org/show_bug.cgi?id=192298 Reviewed by Keith Miller. JSTests: *

[webkit-changes] [239355] trunk

2018-12-18 Thread mark . lam
Title: [239355] trunk Revision 239355 Author mark@apple.com Date 2018-12-18 14:24:33 -0800 (Tue, 18 Dec 2018) Log Message JSON.stringify() should throw OOM on StringBuilder overflows. https://bugs.webkit.org/show_bug.cgi?id=192822 Reviewed by Saam Barati. JSTests: *

[webkit-changes] [239346] trunk/Source/WebKit

2018-12-18 Thread wenson_hsieh
Title: [239346] trunk/Source/WebKit Revision 239346 Author wenson_hs...@apple.com Date 2018-12-18 11:45:24 -0800 (Tue, 18 Dec 2018) Log Message Unreviewed, fix the 32-bit watchOS build after r239314 * UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView

[webkit-changes] [239344] trunk/Tools

2018-12-18 Thread jbedard
Title: [239344] trunk/Tools Revision 239344 Author jbed...@apple.com Date 2018-12-18 11:42:55 -0800 (Tue, 18 Dec 2018) Log Message webkitpy: Ignore device type for test when using --force https://bugs.webkit.org/show_bug.cgi?id=192786 Reviewed by Daniel Bates. It is sometimes the case

[webkit-changes] [239345] trunk/Source/WebInspectorUI

2018-12-18 Thread drousso
Title: [239345] trunk/Source/WebInspectorUI Revision 239345 Author drou...@apple.com Date 2018-12-18 11:43:55 -0800 (Tue, 18 Dec 2018) Log Message Web Inspector: Layers: increase default column width for other localizations https://bugs.webkit.org/show_bug.cgi?id=192812 Reviewed by

[webkit-changes] [239347] trunk

2018-12-18 Thread zalan
Title: [239347] trunk Revision 239347 Author za...@apple.com Date 2018-12-18 12:09:32 -0800 (Tue, 18 Dec 2018) Log Message Synchronous media query evaluation could destroy current Frame/FrameView. https://bugs.webkit.org/show_bug.cgi?id=192781 Reviewed by Chris Dumez. Source/WebCore:

[webkit-changes] [239362] trunk/Source/WebKit

2018-12-18 Thread jiewen_tan
Title: [239362] trunk/Source/WebKit Revision 239362 Author jiewen_...@apple.com Date 2018-12-18 17:25:52 -0800 (Tue, 18 Dec 2018) Log Message [Mac] Layout Test http/wpt/webauthn/public-key-credential-create-success-hid.https.html and

[webkit-changes] [239368] trunk/Source/WebCore

2018-12-18 Thread mcatanzaro
Title: [239368] trunk/Source/WebCore Revision 239368 Author mcatanz...@igalia.com Date 2018-12-18 21:31:11 -0800 (Tue, 18 Dec 2018) Log Message Unreviewed, add a missing UNUSED_PARAM() * Modules/mediarecorder/MediaRecorder.cpp: (WebCore::MediaRecorder::getPrivateImpl): Modified Paths

[webkit-changes] [239367] trunk/Source/WebKit

2018-12-18 Thread achristensen
Title: [239367] trunk/Source/WebKit Revision 239367 Author achristen...@apple.com Date 2018-12-18 21:01:04 -0800 (Tue, 18 Dec 2018) Log Message REGRESSION(r239134) iOS safe browsing warning unable to show details https://bugs.webkit.org/show_bug.cgi?id=192837 Reviewed by Tim Horton. *

[webkit-changes] [239357] trunk

2018-12-18 Thread mmaxfield
Title: [239357] trunk Revision 239357 Author mmaxfi...@apple.com Date 2018-12-18 15:38:54 -0800 (Tue, 18 Dec 2018) Log Message Thick overlines and line-throughs grow in the wrong direction https://bugs.webkit.org/show_bug.cgi?id=192264 Reviewed by Dean Jackson. Source/WebCore:

[webkit-changes] [239363] trunk/Source/WebKit

2018-12-18 Thread wenson_hsieh
Title: [239363] trunk/Source/WebKit Revision 239363 Author wenson_hs...@apple.com Date 2018-12-18 18:11:58 -0800 (Tue, 18 Dec 2018) Log Message [macOS] fast/forms/datalist/datalist-textinput-suggestions-order.html sometimes crashes after r239337

[webkit-changes] [239356] trunk/Tools

2018-12-18 Thread achristensen
Title: [239356] trunk/Tools Revision 239356 Author achristen...@apple.com Date 2018-12-18 15:02:16 -0800 (Tue, 18 Dec 2018) Log Message Fix API test introduced in r239339 on iOS. https://bugs.webkit.org/show_bug.cgi?id=192675 * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm: (TEST):

[webkit-changes] [239359] trunk/Tools

2018-12-18 Thread david_quesada
Title: [239359] trunk/Tools Revision 239359 Author david_ques...@apple.com Date 2018-12-18 15:59:34 -0800 (Tue, 18 Dec 2018) Log Message REGRESSION: [iOS] API test TestWebKitAPI._WKDownload.OriginatingWebView is a flaky failure https://bugs.webkit.org/show_bug.cgi?id=192810 Reviewed by

[webkit-changes] [239366] trunk/Source/WebKit

2018-12-18 Thread Hironori . Fujii
Title: [239366] trunk/Source/WebKit Revision 239366 Author hironori.fu...@sony.com Date 2018-12-18 20:35:34 -0800 (Tue, 18 Dec 2018) Log Message [Win][Clang] Fix compilation warnings under Source/WebKit directory https://bugs.webkit.org/show_bug.cgi?id=192695 Reviewed by Alex

[webkit-changes] [239369] trunk

2018-12-18 Thread wenson_hsieh
Title: [239369] trunk Revision 239369 Author wenson_hs...@apple.com Date 2018-12-18 22:10:28 -0800 (Tue, 18 Dec 2018) Log Message [iOS] A copied text selection is pasted as a web archive attachment in the entry view in Messages https://bugs.webkit.org/show_bug.cgi?id=192842 Reviewed by

[webkit-changes] [239358] trunk

2018-12-18 Thread sihui_liu
Title: [239358] trunk Revision 239358 Author sihui_...@apple.com Date 2018-12-18 15:56:23 -0800 (Tue, 18 Dec 2018) Log Message Clean up IndexedDB files between tests https://bugs.webkit.org/show_bug.cgi?id=192796 Reviewed by Geoffrey Garen. Source/WebCore: We should clean up the

[webkit-changes] [239364] trunk/Source/JavaScriptCore

2018-12-18 Thread sbarati
Title: [239364] trunk/Source/_javascript_Core Revision 239364 Author sbar...@apple.com Date 2018-12-18 18:27:00 -0800 (Tue, 18 Dec 2018) Log Message Update ARM64EHash https://bugs.webkit.org/show_bug.cgi?id=192823 Reviewed by Mark Lam. * assembler/ARM64Assembler.h:

[webkit-changes] [239361] trunk/Source/WebCore

2018-12-18 Thread dbates
Title: [239361] trunk/Source/WebCore Revision 239361 Author dba...@webkit.org Date 2018-12-18 16:23:21 -0800 (Tue, 18 Dec 2018) Log Message Wrong value for key property in keydown and keyup events generated holding Control key https://bugs.webkit.org/show_bug.cgi?id=192788 Reviewed by

[webkit-changes] [239370] trunk

2018-12-18 Thread ross . kirsling
Title: [239370] trunk Revision 239370 Author ross.kirsl...@sony.com Date 2018-12-18 22:37:46 -0800 (Tue, 18 Dec 2018) Log Message Error message for `-x ** y` contains a typo. https://bugs.webkit.org/show_bug.cgi?id=192832 Reviewed by Saam Barati. JSTests: *

[webkit-changes] [239360] trunk/JSTests

2018-12-18 Thread mark . lam
Title: [239360] trunk/JSTests Revision 239360 Author mark@apple.com Date 2018-12-18 16:02:45 -0800 (Tue, 18 Dec 2018) Log Message Gardening: test options fix. https://bugs.webkit.org/show_bug.cgi?id=192822 Unreviewed. * stress/json-stringify-string-builder-overflow.js: Modified