[webkit-changes] [238603] branches/safari-606-branch/Source/WebKit
Title: [238603] branches/safari-606-branch/Source/WebKit
Revision 238603
Author achristen...@apple.com
Date 2018-11-27 22:53:58 -0800 (Tue, 27 Nov 2018)
Log Message
Build fix after r238572
* Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h:
(WebKit::XPCServiceInitializer):
JSC::ExecutableAllocator is protected by ENABLE(ASSEMBLER).
When there is no assembler, there is no JIT to disable.
Modified Paths
branches/safari-606-branch/Source/WebKit/ChangeLog
branches/safari-606-branch/Source/WebKit/Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h
Diff
Modified: branches/safari-606-branch/Source/WebKit/ChangeLog (238602 => 238603)
--- branches/safari-606-branch/Source/WebKit/ChangeLog 2018-11-28 06:49:34 UTC (rev 238602)
+++ branches/safari-606-branch/Source/WebKit/ChangeLog 2018-11-28 06:53:58 UTC (rev 238603)
@@ -1,3 +1,13 @@
+2018-11-27 Alex Christensen
+
+Build fix after r238572
+
+
+* Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h:
+(WebKit::XPCServiceInitializer):
+JSC::ExecutableAllocator is protected by ENABLE(ASSEMBLER).
+When there is no assembler, there is no JIT to disable.
+
2018-11-13 Alan Coon
Apply patch. rdar://problem/45996792
Modified: branches/safari-606-branch/Source/WebKit/Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h (238602 => 238603)
--- branches/safari-606-branch/Source/WebKit/Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h 2018-11-28 06:49:34 UTC (rev 238602)
+++ branches/safari-606-branch/Source/WebKit/Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h 2018-11-28 06:53:58 UTC (rev 238603)
@@ -71,8 +71,10 @@
template
void XPCServiceInitializer(OSObjectPtr connection, xpc_object_t initializerMessage, xpc_object_t priorityBoostMessage)
{
+#if ENABLE(ASSEMBLER)
if (initializerMessage && xpc_dictionary_get_bool(initializerMessage, "disable-jit"))
JSC::ExecutableAllocator::setJITEnabled(false);
+#endif
XPCServiceInitializerDelegateType delegate(WTFMove(connection), initializerMessage);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [238602] trunk/Source/WebInspectorUI
Title: [238602] trunk/Source/WebInspectorUI Revision 238602 Author mattba...@apple.com Date 2018-11-27 22:49:34 -0800 (Tue, 27 Nov 2018) Log Message Web Inspector: Elements tab should allow selecting/deleting multiple DOM nodes https://bugs.webkit.org/show_bug.cgi?id=192059 Reviewed by Devin Rousso. Enable multiple DOM node selection in the DOMTreeContentView. * UserInterface/Controllers/SelectionController.js: (WI.SelectionController): (WI.SelectionController.prototype.get allowsEmptySelection): (WI.SelectionController.prototype.set allowsEmptySelection): Allow clients to control whether the last selected item can be deselected. (WI.SelectionController.prototype.deselectItem): (WI.SelectionController.prototype.didInsertItem): Rewritten to prevent infinite loop. (WI.SelectionController.prototype.didRemoveItem): (WI.SelectionController.prototype._updateSelectedItems): (WI.SelectionController.prototype._adjustIndexesAfter): Deleted. * UserInterface/Views/DOMTreeContentView.js: (WI.DOMTreeContentView): * UserInterface/Views/DOMTreeElement.js: (WI.DOMTreeElement.prototype.updateSelectionArea): * UserInterface/Views/DOMTreeOutline.js: (WI.DOMTreeOutline.prototype.updateSelection): Updating the selection area DOM element should not assume that only one TreeElement is selected at a time. * UserInterface/Views/TreeOutline.js: (WI.TreeOutline.prototype.get allowsEmptySelection): (WI.TreeOutline.prototype.set allowsEmptySelection): (WI.TreeOutline.prototype.set selectedTreeElement): (WI.TreeOutline.prototype.get selectedTreeElements): (WI.TreeOutline.prototype._treeKeyDown): * UserInterface/Views/TreeOutlineGroup.js: (WI.TreeOutlineGroup): (WI.TreeOutlineGroup.prototype._removeConflictingTreeSelections): Eliminate use of `TreeElement.prototype.deselect`. Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Controllers/SelectionController.js trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutlineGroup.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (238601 => 238602) --- trunk/Source/WebInspectorUI/ChangeLog 2018-11-28 04:48:30 UTC (rev 238601) +++ trunk/Source/WebInspectorUI/ChangeLog 2018-11-28 06:49:34 UTC (rev 238602) @@ -1,5 +1,49 @@ 2018-11-27 Matt Baker +Web Inspector: Elements tab should allow selecting/deleting multiple DOM nodes +https://bugs.webkit.org/show_bug.cgi?id=192059 + + +Reviewed by Devin Rousso. + +Enable multiple DOM node selection in the DOMTreeContentView. + +* UserInterface/Controllers/SelectionController.js: +(WI.SelectionController): +(WI.SelectionController.prototype.get allowsEmptySelection): +(WI.SelectionController.prototype.set allowsEmptySelection): +Allow clients to control whether the last selected item can be deselected. +(WI.SelectionController.prototype.deselectItem): +(WI.SelectionController.prototype.didInsertItem): +Rewritten to prevent infinite loop. +(WI.SelectionController.prototype.didRemoveItem): +(WI.SelectionController.prototype._updateSelectedItems): +(WI.SelectionController.prototype._adjustIndexesAfter): Deleted. + +* UserInterface/Views/DOMTreeContentView.js: +(WI.DOMTreeContentView): + +* UserInterface/Views/DOMTreeElement.js: +(WI.DOMTreeElement.prototype.updateSelectionArea): +* UserInterface/Views/DOMTreeOutline.js: +(WI.DOMTreeOutline.prototype.updateSelection): +Updating the selection area DOM element should not assume that only one +TreeElement is selected at a time. + +* UserInterface/Views/TreeOutline.js: +(WI.TreeOutline.prototype.get allowsEmptySelection): +(WI.TreeOutline.prototype.set allowsEmptySelection): +(WI.TreeOutline.prototype.set selectedTreeElement): +(WI.TreeOutline.prototype.get selectedTreeElements): +(WI.TreeOutline.prototype._treeKeyDown): + +* UserInterface/Views/TreeOutlineGroup.js: +(WI.TreeOutlineGroup): +(WI.TreeOutlineGroup.prototype._removeConflictingTreeSelections): +Eliminate use of `TreeElement.prototype.deselect`. + +2018-11-27 Matt Baker + Web Inspector: TreeOutline should re-use multiple-selection logic from Table https://bugs.webkit.org/show_bug.cgi?id=191483 Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/SelectionController.js (238601 => 238602) --- trunk/Source/WebInspectorUI/UserInterface/Controllers/SelectionController.js 2018-11-28 04:48:30 UTC (rev 238601) +++ trunk/Source/WebInspectorUI/UserInterface/Controllers/SelectionController.js 2018-11-28 06:49:34
[webkit-changes] [238601] trunk/Source/WebCore
Title: [238601] trunk/Source/WebCore
Revision 238601
Author you...@apple.com
Date 2018-11-27 20:48:30 -0800 (Tue, 27 Nov 2018)
Log Message
Log WebRTC stats in inspector console only when setting is verbose
https://bugs.webkit.org/show_bug.cgi?id=192014
Reviewed by Eric Carlson.
Add a WebRTCStats channel that is used by default to output WebRTC stats in console.
When WebRTC Debug logging is enabled, log WebRTC stats in WebRTC channel,
so that they appear as debug information in Web Inspector.
No change of JS behavior.
Covered by manually testing what is logged in inspector and console.
* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::LibWebRTCMediaEndpoint::OnStatsDelivered):
* platform/Logging.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp
trunk/Source/WebCore/platform/Logging.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (238600 => 238601)
--- trunk/Source/WebCore/ChangeLog 2018-11-28 03:05:16 UTC (rev 238600)
+++ trunk/Source/WebCore/ChangeLog 2018-11-28 04:48:30 UTC (rev 238601)
@@ -1,3 +1,21 @@
+2018-11-27 Youenn Fablet
+
+Log WebRTC stats in inspector console only when setting is verbose
+https://bugs.webkit.org/show_bug.cgi?id=192014
+
+Reviewed by Eric Carlson.
+
+Add a WebRTCStats channel that is used by default to output WebRTC stats in console.
+When WebRTC Debug logging is enabled, log WebRTC stats in WebRTC channel,
+so that they appear as debug information in Web Inspector.
+
+No change of JS behavior.
+Covered by manually testing what is logged in inspector and console.
+
+* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
+(WebCore::LibWebRTCMediaEndpoint::OnStatsDelivered):
+* platform/Logging.h:
+
2018-11-27 Simon Fraser
Fix the mis-spelled "m_clienstWaitingForAsyncDecoding"
Modified: trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp (238600 => 238601)
--- trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp 2018-11-28 03:05:16 UTC (rev 238600)
+++ trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp 2018-11-28 04:48:30 UTC (rev 238601)
@@ -854,8 +854,18 @@
m_statsLogTimer.startRepeating(statsLogInterval(timestamp));
}
-for (auto iterator = report->begin(); iterator != report->end(); ++iterator)
-ALWAYS_LOG(Logger::LogSiteIdentifier("LibWebRTCMediaEndpoint", "OnStatsDelivered", logIdentifier()), RTCStatsLogger { *iterator });
+for (auto iterator = report->begin(); iterator != report->end(); ++iterator) {
+if (logger().willLog(logChannel(), WTFLogLevelDebug)) {
+// Stats are very verbose, let's only display them in inspector console in verbose mode.
+logger().debug(LogWebRTC,
+Logger::LogSiteIdentifier("LibWebRTCMediaEndpoint", "OnStatsDelivered", logIdentifier()),
+RTCStatsLogger { *iterator });
+} else {
+logger().logAlways(LogWebRTCStats,
+Logger::LogSiteIdentifier("LibWebRTCMediaEndpoint", "OnStatsDelivered", logIdentifier()),
+RTCStatsLogger { *iterator });
+}
+}
});
#else
UNUSED_PARAM(report);
Modified: trunk/Source/WebCore/platform/Logging.h (238600 => 238601)
--- trunk/Source/WebCore/platform/Logging.h 2018-11-28 03:05:16 UTC (rev 238600)
+++ trunk/Source/WebCore/platform/Logging.h 2018-11-28 04:48:30 UTC (rev 238601)
@@ -103,6 +103,7 @@
M(WebGPU) \
M(WebMetal) \
M(WebRTC) \
+M(WebRTCStats) \
M(WheelEventTestTriggers) \
#undef DECLARE_LOG_CHANNEL
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [238600] trunk/Source/WebCore
Title: [238600] trunk/Source/WebCore
Revision 238600
Author simon.fra...@apple.com
Date 2018-11-27 19:05:16 -0800 (Tue, 27 Nov 2018)
Log Message
Fix the mis-spelled "m_clienstWaitingForAsyncDecoding"
https://bugs.webkit.org/show_bug.cgi?id=192060
Reviewed by Wenson Hsieh.
Fix the mis-spelling of "m_clienstWaitingForAsyncDecoding".
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::didRemoveClient):
(WebCore::CachedImage::isClientWaitingForAsyncDecoding const):
(WebCore::CachedImage::addClientWaitingForAsyncDecoding):
(WebCore::CachedImage::removeAllClientsWaitingForAsyncDecoding):
(WebCore::CachedImage::allClientsRemoved):
(WebCore::CachedImage::clear):
(WebCore::CachedImage::createImage):
(WebCore::CachedImage::imageFrameAvailable):
* loader/cache/CachedImage.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/cache/CachedImage.cpp
trunk/Source/WebCore/loader/cache/CachedImage.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (238599 => 238600)
--- trunk/Source/WebCore/ChangeLog 2018-11-28 02:55:42 UTC (rev 238599)
+++ trunk/Source/WebCore/ChangeLog 2018-11-28 03:05:16 UTC (rev 238600)
@@ -1,3 +1,23 @@
+2018-11-27 Simon Fraser
+
+Fix the mis-spelled "m_clienstWaitingForAsyncDecoding"
+https://bugs.webkit.org/show_bug.cgi?id=192060
+
+Reviewed by Wenson Hsieh.
+
+Fix the mis-spelling of "m_clienstWaitingForAsyncDecoding".
+
+* loader/cache/CachedImage.cpp:
+(WebCore::CachedImage::didRemoveClient):
+(WebCore::CachedImage::isClientWaitingForAsyncDecoding const):
+(WebCore::CachedImage::addClientWaitingForAsyncDecoding):
+(WebCore::CachedImage::removeAllClientsWaitingForAsyncDecoding):
+(WebCore::CachedImage::allClientsRemoved):
+(WebCore::CachedImage::clear):
+(WebCore::CachedImage::createImage):
+(WebCore::CachedImage::imageFrameAvailable):
+* loader/cache/CachedImage.h:
+
2018-11-27 Mark Lam
ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.
Modified: trunk/Source/WebCore/loader/cache/CachedImage.cpp (238599 => 238600)
--- trunk/Source/WebCore/loader/cache/CachedImage.cpp 2018-11-28 02:55:42 UTC (rev 238599)
+++ trunk/Source/WebCore/loader/cache/CachedImage.cpp 2018-11-28 03:05:16 UTC (rev 238600)
@@ -130,7 +130,7 @@
ASSERT(client.resourceClientType() == CachedImageClient::expectedType());
m_pendingContainerContextRequests.remove(_cast(client));
-m_clienstWaitingForAsyncDecoding.remove(_cast(client));
+m_clientsWaitingForAsyncDecoding.remove(_cast(client));
if (m_svgImageCache)
m_svgImageCache->removeClientFromCache(_cast(client));
@@ -142,36 +142,36 @@
bool CachedImage::isClientWaitingForAsyncDecoding(CachedImageClient& client) const
{
-return m_clienstWaitingForAsyncDecoding.contains();
+return m_clientsWaitingForAsyncDecoding.contains();
}
void CachedImage::addClientWaitingForAsyncDecoding(CachedImageClient& client)
{
ASSERT(client.resourceClientType() == CachedImageClient::expectedType());
-if (m_clienstWaitingForAsyncDecoding.contains())
+if (m_clientsWaitingForAsyncDecoding.contains())
return;
if (!m_clients.contains()) {
// If the element does not have its own background specified, painting the root box
// renderer uses the style of the element, see RenderView::rendererForRootBackground().
// In this case, the client we are asked to add is the root box renderer. Since we can't add
-// a client to m_clienstWaitingForAsyncDecoding unless it is one of the m_clients, we are going
+// a client to m_clientsWaitingForAsyncDecoding unless it is one of the m_clients, we are going
// to cancel the repaint optimization we do in CachedImage::imageFrameAvailable() by adding
-// all the m_clients to m_clienstWaitingForAsyncDecoding.
+// all the m_clients to m_clientsWaitingForAsyncDecoding.
CachedResourceClientWalker walker(m_clients);
while (auto* client = walker.next())
-m_clienstWaitingForAsyncDecoding.add(client);
+m_clientsWaitingForAsyncDecoding.add(client);
} else
-m_clienstWaitingForAsyncDecoding.add();
+m_clientsWaitingForAsyncDecoding.add();
}
void CachedImage::removeAllClientsWaitingForAsyncDecoding()
{
-if (m_clienstWaitingForAsyncDecoding.isEmpty() || !hasImage() || !is(image()))
+if (m_clientsWaitingForAsyncDecoding.isEmpty() || !hasImage() || !is(image()))
return;
downcast(image())->stopAsyncDecodingQueue();
-for (auto* client : m_clienstWaitingForAsyncDecoding)
+for (auto* client : m_clientsWaitingForAsyncDecoding)
client->imageChanged(this);
-m_clienstWaitingForAsyncDecoding.clear();
+m_clientsWaitingForAsyncDecoding.clear();
}
void CachedImage::switchClientsToRevalidatedResource()
@@ -196,7 +196,7 @@
void CachedImage::allClientsRemoved()
{
[webkit-changes] [238599] trunk/Source/WebInspectorUI
Title: [238599] trunk/Source/WebInspectorUI Revision 238599 Author mattba...@apple.com Date 2018-11-27 18:55:42 -0800 (Tue, 27 Nov 2018) Log Message Web Inspector: TreeOutline should re-use multiple-selection logic from Table https://bugs.webkit.org/show_bug.cgi?id=191483 Reviewed by Devin Rousso. Update TreeOutline to use SelectionController. Adopting SelectionController in TreeOutline is not as straightforward as it was in Table. Selected items are tracked by index, and TreeElement lacks an explicit index. As a consequence TreeElement indexes are calcualted as needed and cached. The cache is cleared whenever an element is added or removed. * UserInterface/Controllers/SelectionController.js: (WI.SelectionController.prototype.didInsertItem): (WI.SelectionController.prototype.didRemoveItem): (WI.SelectionController.prototype.handleKeyDown): Drive-by syntax error fix. (WI.SelectionController.prototype._adjustIndexesAfter): (WI.SelectionController): * UserInterface/Views/DOMTreeElement.js: (WI.DOMTreeElement.prototype.canSelectOnMouseDown): (WI.DOMTreeElement.prototype.selectOnMouseDown): Deleted. * UserInterface/Views/DOMTreeOutline.js: (WI.DOMTreeOutline.prototype._onmousedown): Item selection is now handled by SelectionController. * UserInterface/Views/ShaderProgramTreeElement.js: (WI.ShaderProgramTreeElement.prototype.canSelectOnMouseDown): (WI.ShaderProgramTreeElement.prototype.selectOnMouseDown): Deleted. * UserInterface/Views/TreeElement.js: (WI.TreeElement.prototype.canSelectOnMouseDown): (WI.TreeElement.prototype._attach): (WI.TreeElement.prototype.select): (WI.TreeElement.prototype.deselect): Route item selection through the parent TreeOutline, in order to go though the TreeOutline's SelectionController. (WI.TreeElement.treeElementMouseDown): Deleted. Moved handler to TreeOutline, which owns the SelectionController that needs to respond to mouse events. * UserInterface/Views/TreeOutline.js: (WI.TreeOutline): (WI.TreeOutline.prototype.get allowsMultipleSelection): (WI.TreeOutline.prototype.set allowsMultipleSelection): (WI.TreeOutline.prototype.get selectedTreeElement): (WI.TreeOutline.prototype.set selectedTreeElement): (WI.TreeOutline.prototype.insertChild): (WI.TreeOutline.prototype.removeChildAtIndex): (WI.TreeOutline.prototype._rememberTreeElement): (WI.TreeOutline.prototype._forgetTreeElement): (WI.TreeOutline.prototype._treeKeyDown): (WI.TreeOutline.prototype.selectionControllerNumberOfItems): (WI.TreeOutline.prototype.selectionControllerSelectionDidChange): (WI.TreeOutline.prototype.selectionControllerNextSelectableIndex): (WI.TreeOutline.prototype.selectionControllerPreviousSelectableIndex): (WI.TreeOutline.prototype.selectTreeElementInternal): (WI.TreeOutline._generateStyleRulesIfNeeded._indexOfTreeElement.previousElement): (WI.TreeOutline._generateStyleRulesIfNeeded): Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Controllers/SelectionController.js trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js trunk/Source/WebInspectorUI/UserInterface/Views/ShaderProgramTreeElement.js trunk/Source/WebInspectorUI/UserInterface/Views/TreeElement.js trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (238598 => 238599) --- trunk/Source/WebInspectorUI/ChangeLog 2018-11-28 02:16:25 UTC (rev 238598) +++ trunk/Source/WebInspectorUI/ChangeLog 2018-11-28 02:55:42 UTC (rev 238599) @@ -1,3 +1,68 @@ +2018-11-27 Matt Baker + +Web Inspector: TreeOutline should re-use multiple-selection logic from Table +https://bugs.webkit.org/show_bug.cgi?id=191483 + + +Reviewed by Devin Rousso. + +Update TreeOutline to use SelectionController. Adopting SelectionController +in TreeOutline is not as straightforward as it was in Table. Selected items +are tracked by index, and TreeElement lacks an explicit index. As a consequence +TreeElement indexes are calcualted as needed and cached. The cache is cleared +whenever an element is added or removed. + +* UserInterface/Controllers/SelectionController.js: +(WI.SelectionController.prototype.didInsertItem): +(WI.SelectionController.prototype.didRemoveItem): +(WI.SelectionController.prototype.handleKeyDown): +Drive-by syntax error fix. +(WI.SelectionController.prototype._adjustIndexesAfter): +(WI.SelectionController): + +* UserInterface/Views/DOMTreeElement.js: +(WI.DOMTreeElement.prototype.canSelectOnMouseDown): +(WI.DOMTreeElement.prototype.selectOnMouseDown): Deleted. + +* UserInterface/Views/DOMTreeOutline.js: +(WI.DOMTreeOutline.prototype._onmousedown): +Item selection is now handled by SelectionController. + +* UserInterface/Views/ShaderProgramTreeElement.js: +
[webkit-changes] [238598] trunk/LayoutTests
Title: [238598] trunk/LayoutTests
Revision 238598
Author jiewen_...@apple.com
Date 2018-11-27 18:16:25 -0800 (Tue, 27 Nov 2018)
Log Message
Unreviewed, test gardening
Add a time out parameter to the following test cases such that WebAuthN requests will timeout
themselves instead of letting the wpt wrapper or test runner kill them.
* http/wpt/webauthn/public-key-credential-create-success-hid.https.html:
* http/wpt/webauthn/public-key-credential-get-success-hid.https.html:
* platform/mac-wk2/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-success-hid.https.html
trunk/LayoutTests/http/wpt/webauthn/public-key-credential-get-success-hid.https.html
trunk/LayoutTests/platform/mac-wk2/TestExpectations
Diff
Modified: trunk/LayoutTests/ChangeLog (238597 => 238598)
--- trunk/LayoutTests/ChangeLog 2018-11-28 02:10:50 UTC (rev 238597)
+++ trunk/LayoutTests/ChangeLog 2018-11-28 02:16:25 UTC (rev 238598)
@@ -1,3 +1,14 @@
+2018-11-27 Jiewen Tan
+
+Unreviewed, test gardening
+
+Add a time out parameter to the following test cases such that WebAuthN requests will timeout
+themselves instead of letting the wpt wrapper or test runner kill them.
+
+* http/wpt/webauthn/public-key-credential-create-success-hid.https.html:
+* http/wpt/webauthn/public-key-credential-get-success-hid.https.html:
+* platform/mac-wk2/TestExpectations:
+
2018-11-27 Chris Dumez
Resync service-workers web platform tests from upstream
Modified: trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-success-hid.https.html (238597 => 238598)
--- trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-success-hid.https.html 2018-11-28 02:10:50 UTC (rev 238597)
+++ trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-success-hid.https.html 2018-11-28 02:16:25 UTC (rev 238598)
@@ -47,6 +47,7 @@
},
challenge: Base64URL.parse("MTIzNDU2"),
pubKeyCredParams: [{ type: "public-key", alg: -7 }],
+timeout: 10
}
};
@@ -90,7 +91,8 @@
},
challenge: Base64URL.parse("MTIzNDU2"),
pubKeyCredParams: [{ type: "public-key", alg: -7 }],
-authenticatorSelection: { requireResidentKey: false }
+authenticatorSelection: { requireResidentKey: false },
+timeout: 10
}
};
@@ -112,7 +114,8 @@
},
challenge: Base64URL.parse("MTIzNDU2"),
pubKeyCredParams: [{ type: "public-key", alg: -7 }],
-authenticatorSelection: { userVerification: "preferred" }
+authenticatorSelection: { userVerification: "preferred" },
+timeout: 10
}
};
@@ -134,7 +137,8 @@
},
challenge: Base64URL.parse("MTIzNDU2"),
pubKeyCredParams: [{ type: "public-key", alg: -7 }],
-authenticatorSelection: { userVerification: "discouraged" }
+authenticatorSelection: { userVerification: "discouraged" },
+timeout: 10
}
};
@@ -156,7 +160,8 @@
},
challenge: Base64URL.parse("MTIzNDU2"),
pubKeyCredParams: [{ type: "public-key", alg: -7 }],
-authenticatorSelection: { authenticatorAttachment: "cross-platform", requireResidentKey: false, userVerification: "preferred" }
+authenticatorSelection: { authenticatorAttachment: "cross-platform", requireResidentKey: false, userVerification: "preferred" },
+timeout: 10
}
};
Modified: trunk/LayoutTests/http/wpt/webauthn/public-key-credential-get-success-hid.https.html (238597 => 238598)
--- trunk/LayoutTests/http/wpt/webauthn/public-key-credential-get-success-hid.https.html 2018-11-28 02:10:50 UTC (rev 238597)
+++ trunk/LayoutTests/http/wpt/webauthn/public-key-credential-get-success-hid.https.html 2018-11-28 02:16:25 UTC (rev 238598)
@@ -27,7 +27,8 @@
promise_test(t => {
const options = {
publicKey: {
-challenge: Base64URL.parse("MTIzNDU2")
+challenge: Base64URL.parse("MTIzNDU2"),
+timeout: 10
}
};
@@ -42,7 +43,8 @@
challenge: Base64URL.parse("MTIzNDU2"),
allowCredentials: [
{ type: "public-key", id: Base64URL.parse(testHidCredentialIdBase64), transports: ["usb"] }
-]
+],
+timeout: 10
}
};
@@ -55,7 +57,8 @@
const options = {
publicKey: {
challenge: Base64URL.parse("MTIzNDU2"),
-userVerification: "preferred"
+userVerification: "preferred",
+
[webkit-changes] [238597] trunk
Title: [238597] trunk Revision 238597 Author mark@apple.com Date 2018-11-27 18:10:50 -0800 (Tue, 27 Nov 2018) Log Message ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac. https://bugs.webkit.org/show_bug.cgi?id=192055 Reviewed by Saam Barati. Source/_javascript_Core: * Configurations/FeatureDefines.xcconfig: Source/WebCore: No new tests needed. Removing an invalid configuration that is not used in WebCore. * Configurations/FeatureDefines.xcconfig: Source/WebCore/PAL: * Configurations/FeatureDefines.xcconfig: Source/WebKit: * Configurations/FeatureDefines.xcconfig: Source/WebKitLegacy/mac: * Configurations/FeatureDefines.xcconfig: Tools: * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig trunk/Source/WebCore/PAL/ChangeLog trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Configurations/FeatureDefines.xcconfig trunk/Source/WebKitLegacy/mac/ChangeLog trunk/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig Diff Modified: trunk/Source/_javascript_Core/ChangeLog (238596 => 238597) --- trunk/Source/_javascript_Core/ChangeLog 2018-11-28 02:03:20 UTC (rev 238596) +++ trunk/Source/_javascript_Core/ChangeLog 2018-11-28 02:10:50 UTC (rev 238597) @@ -1,3 +1,13 @@ +2018-11-27 Mark Lam + +ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac. +https://bugs.webkit.org/show_bug.cgi?id=192055 + + +Reviewed by Saam Barati. + +* Configurations/FeatureDefines.xcconfig: + 2018-11-27 Saam barati r238510 broke scopes of size zero Modified: trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (238596 => 238597) --- trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig 2018-11-28 02:03:20 UTC (rev 238596) +++ trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig 2018-11-28 02:10:50 UTC (rev 238597) @@ -155,7 +155,7 @@ ENABLE_FAST_JIT_PERMISSIONS = $(ENABLE_FAST_JIT_PERMISSIONS_$(WK_PLATFORM_NAME)); ENABLE_FAST_JIT_PERMISSIONS_iphoneos[arch=arm64*] = $(ENABLE_FAST_JIT_PERMISSIONS_iphoneos_$(USE_INTERNAL_SDK)); ENABLE_FAST_JIT_PERMISSIONS_iphoneos_YES = ENABLE_FAST_JIT_PERMISSIONS; -ENABLE_FAST_JIT_PERMISSIONS_iosmac = ENABLE_FAST_JIT_PERMISSIONS; +ENABLE_FAST_JIT_PERMISSIONS_iosmac = ; ENABLE_FILTERS_LEVEL_2 = ENABLE_FILTERS_LEVEL_2; Modified: trunk/Source/WebCore/ChangeLog (238596 => 238597) --- trunk/Source/WebCore/ChangeLog 2018-11-28 02:03:20 UTC (rev 238596) +++ trunk/Source/WebCore/ChangeLog 2018-11-28 02:10:50 UTC (rev 238597) @@ -1,3 +1,15 @@ +2018-11-27 Mark Lam + +ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac. +https://bugs.webkit.org/show_bug.cgi?id=192055 + + +Reviewed by Saam Barati. + +No new tests needed. Removing an invalid configuration that is not used in WebCore. + +* Configurations/FeatureDefines.xcconfig: + 2018-11-27 Jiewen Tan Remove kCCNotVerified Modified: trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig (238596 => 238597) --- trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig 2018-11-28 02:03:20 UTC (rev 238596) +++ trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig 2018-11-28 02:10:50 UTC (rev 238597) @@ -155,7 +155,7 @@ ENABLE_FAST_JIT_PERMISSIONS = $(ENABLE_FAST_JIT_PERMISSIONS_$(WK_PLATFORM_NAME)); ENABLE_FAST_JIT_PERMISSIONS_iphoneos[arch=arm64*] = $(ENABLE_FAST_JIT_PERMISSIONS_iphoneos_$(USE_INTERNAL_SDK)); ENABLE_FAST_JIT_PERMISSIONS_iphoneos_YES = ENABLE_FAST_JIT_PERMISSIONS; -ENABLE_FAST_JIT_PERMISSIONS_iosmac = ENABLE_FAST_JIT_PERMISSIONS; +ENABLE_FAST_JIT_PERMISSIONS_iosmac = ; ENABLE_FILTERS_LEVEL_2 = ENABLE_FILTERS_LEVEL_2; Modified: trunk/Source/WebCore/PAL/ChangeLog (238596 => 238597) --- trunk/Source/WebCore/PAL/ChangeLog 2018-11-28 02:03:20 UTC (rev 238596) +++ trunk/Source/WebCore/PAL/ChangeLog 2018-11-28 02:10:50 UTC (rev 238597) @@ -1,3 +1,13 @@ +2018-11-27 Mark Lam + +ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac. +https://bugs.webkit.org/show_bug.cgi?id=192055 + + +Reviewed by Saam Barati. + +* Configurations/FeatureDefines.xcconfig: + 2018-11-27 Alexey Proskuryakov Modernize the check for async _saveCookies existence Modified: trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig (238596 => 238597) --- trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig 2018-11-28 02:03:20 UTC (rev 238596) +++ trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig 2018-11-28 02:10:50 UTC (rev 238597) @@ -155,7 +155,7 @@
[webkit-changes] [238596] trunk
Title: [238596] trunk
Revision 238596
Author sbar...@apple.com
Date 2018-11-27 18:03:20 -0800 (Tue, 27 Nov 2018)
Log Message
r238510 broke scopes of size zero
https://bugs.webkit.org/show_bug.cgi?id=192033
Reviewed by Keith Miller.
JSTests:
* stress/r238510-bad-loop.js: Added.
(foo):
Source/_javascript_Core:
In r238510, I wrote the loop like this:
`for (ScopeOffset offset { 0 }; offset <= symbolTable->maxScopeOffset(); offset += 1)`
This breaks for scopes of size zero because maxScopeOffset() will be UINT_MAX.
This patch fixes this by writing the loop as:
`for (unsigned offset = 0; offset < symbolTable->scopeSize(); ++offset)`
* dfg/DFGObjectAllocationSinkingPhase.cpp:
Modified Paths
trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGObjectAllocationSinkingPhase.cpp
Added Paths
trunk/JSTests/stress/r238510-bad-loop.js
Diff
Modified: trunk/JSTests/ChangeLog (238595 => 238596)
--- trunk/JSTests/ChangeLog 2018-11-28 01:48:36 UTC (rev 238595)
+++ trunk/JSTests/ChangeLog 2018-11-28 02:03:20 UTC (rev 238596)
@@ -1,3 +1,14 @@
+2018-11-27 Saam barati
+
+r238510 broke scopes of size zero
+https://bugs.webkit.org/show_bug.cgi?id=192033
+
+
+Reviewed by Keith Miller.
+
+* stress/r238510-bad-loop.js: Added.
+(foo):
+
2018-11-27 Mark Lam
[Re-landing] NaNs read from Wasm code needs to be be purified.
Added: trunk/JSTests/stress/r238510-bad-loop.js (0 => 238596)
--- trunk/JSTests/stress/r238510-bad-loop.js (rev 0)
+++ trunk/JSTests/stress/r238510-bad-loop.js 2018-11-28 02:03:20 UTC (rev 238596)
@@ -0,0 +1,10 @@
+function foo() {
+return function () {
+eval();
+}
+}
+noInline(foo);
+
+for (let i = 0; i < 10; ++i) {
+foo();
+}
Modified: trunk/Source/_javascript_Core/ChangeLog (238595 => 238596)
--- trunk/Source/_javascript_Core/ChangeLog 2018-11-28 01:48:36 UTC (rev 238595)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-11-28 02:03:20 UTC (rev 238596)
@@ -1,3 +1,21 @@
+2018-11-27 Saam barati
+
+r238510 broke scopes of size zero
+https://bugs.webkit.org/show_bug.cgi?id=192033
+
+
+Reviewed by Keith Miller.
+
+In r238510, I wrote the loop like this:
+`for (ScopeOffset offset { 0 }; offset <= symbolTable->maxScopeOffset(); offset += 1)`
+
+This breaks for scopes of size zero because maxScopeOffset() will be UINT_MAX.
+
+This patch fixes this by writing the loop as:
+`for (unsigned offset = 0; offset < symbolTable->scopeSize(); ++offset)`
+
+* dfg/DFGObjectAllocationSinkingPhase.cpp:
+
2018-11-27 Mark Lam
ASSERTION FAILED: capacity && isPageAligned(capacity) in JSC::CLoopStack::CLoopStack(JSC::VM&).
Modified: trunk/Source/_javascript_Core/dfg/DFGObjectAllocationSinkingPhase.cpp (238595 => 238596)
--- trunk/Source/_javascript_Core/dfg/DFGObjectAllocationSinkingPhase.cpp 2018-11-28 01:48:36 UTC (rev 238595)
+++ trunk/Source/_javascript_Core/dfg/DFGObjectAllocationSinkingPhase.cpp 2018-11-28 02:03:20 UTC (rev 238596)
@@ -878,9 +878,9 @@
{
SymbolTable* symbolTable = node->castOperand();
LazyNode initialValue(m_graph.freeze(node->initializationValueForActivation()));
-for (ScopeOffset offset { 0 }; offset <= symbolTable->maxScopeOffset(); offset += 1) {
+for (unsigned offset = 0; offset < symbolTable->scopeSize(); ++offset) {
writes.add(
-PromotedLocationDescriptor(ClosureVarPLoc, offset.offset()),
+PromotedLocationDescriptor(ClosureVarPLoc, offset),
initialValue);
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [238595] trunk/Source/JavaScriptCore
Title: [238595] trunk/Source/_javascript_Core
Revision 238595
Author mark@apple.com
Date 2018-11-27 17:48:36 -0800 (Tue, 27 Nov 2018)
Log Message
ASSERTION FAILED: capacity && isPageAligned(capacity) in JSC::CLoopStack::CLoopStack(JSC::VM&).
https://bugs.webkit.org/show_bug.cgi?id=192018
Reviewed by Saam Barati.
This assertion failed because the regress-191579.js test was specifying
--maxPerThreadStackUsage=40 i.e. it was running with a stack size that is not
page aligned. Given that the user can specify any arbitrary stack size, and the
CLoop stack expects to be page aligned, we'll just round up the requested capacity
to the next page alignment.
* interpreter/CLoopStack.cpp:
(JSC::CLoopStack::CLoopStack):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/interpreter/CLoopStack.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (238594 => 238595)
--- trunk/Source/_javascript_Core/ChangeLog 2018-11-28 01:45:17 UTC (rev 238594)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-11-28 01:48:36 UTC (rev 238595)
@@ -1,5 +1,21 @@
2018-11-27 Mark Lam
+ASSERTION FAILED: capacity && isPageAligned(capacity) in JSC::CLoopStack::CLoopStack(JSC::VM&).
+https://bugs.webkit.org/show_bug.cgi?id=192018
+
+Reviewed by Saam Barati.
+
+This assertion failed because the regress-191579.js test was specifying
+--maxPerThreadStackUsage=40 i.e. it was running with a stack size that is not
+page aligned. Given that the user can specify any arbitrary stack size, and the
+CLoop stack expects to be page aligned, we'll just round up the requested capacity
+to the next page alignment.
+
+* interpreter/CLoopStack.cpp:
+(JSC::CLoopStack::CLoopStack):
+
+2018-11-27 Mark Lam
+
[Re-landing] NaNs read from Wasm code needs to be be purified.
https://bugs.webkit.org/show_bug.cgi?id=191056
Modified: trunk/Source/_javascript_Core/interpreter/CLoopStack.cpp (238594 => 238595)
--- trunk/Source/_javascript_Core/interpreter/CLoopStack.cpp 2018-11-28 01:45:17 UTC (rev 238594)
+++ trunk/Source/_javascript_Core/interpreter/CLoopStack.cpp 2018-11-28 01:48:36 UTC (rev 238595)
@@ -56,6 +56,7 @@
, m_softReservedZoneSizeInRegisters(0)
{
size_t capacity = Options::maxPerThreadStackUsage();
+capacity = WTF::roundUpToMultipleOf(pageSize(), capacity);
ASSERT(capacity && isPageAligned(capacity));
m_reservation = PageReservation::reserve(WTF::roundUpToMultipleOf(commitSize(), capacity), OSAllocator::JSVMStackPages);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [238594] trunk/Source/WebInspectorUI
Title: [238594] trunk/Source/WebInspectorUI
Revision 238594
Author nvasil...@apple.com
Date 2018-11-27 17:45:17 -0800 (Tue, 27 Nov 2018)
Log Message
Web Inspector: Experimental Computed panel is unreadable in Dark Mode
https://bugs.webkit.org/show_bug.cgi?id=192053
Reviewed by Matt Baker.
* UserInterface/Views/ComputedStyleDetailsPanel.css:
(@media (prefers-dark-interface)):
(.computed-with-traces .details-section.computed-style-properties:not(.collapsed) > :matches(.header, .content)):
* UserInterface/Views/ComputedStyleSection.css:
(.computed-style-section .computed-property-item.expanded):
(.computed-style-section .computed-property-item.expanded + .computed-property-item):
(@media (prefers-dark-interface)):
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.css
trunk/Source/WebInspectorUI/UserInterface/Views/ComputedStyleSection.css
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (238593 => 238594)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-11-28 01:44:28 UTC (rev 238593)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-11-28 01:45:17 UTC (rev 238594)
@@ -1,5 +1,20 @@
2018-11-27 Nikita Vasilyev
+Web Inspector: Experimental Computed panel is unreadable in Dark Mode
+https://bugs.webkit.org/show_bug.cgi?id=192053
+
+Reviewed by Matt Baker.
+
+* UserInterface/Views/ComputedStyleDetailsPanel.css:
+(@media (prefers-dark-interface)):
+(.computed-with-traces .details-section.computed-style-properties:not(.collapsed) > :matches(.header, .content)):
+* UserInterface/Views/ComputedStyleSection.css:
+(.computed-style-section .computed-property-item.expanded):
+(.computed-style-section .computed-property-item.expanded + .computed-property-item):
+(@media (prefers-dark-interface)):
+
+2018-11-27 Nikita Vasilyev
+
Web Inspector: Computed panel: allow to expand properties to show list of overridden values
https://bugs.webkit.org/show_bug.cgi?id=191984
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.css (238593 => 238594)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.css 2018-11-28 01:44:28 UTC (rev 238593)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.css 2018-11-28 01:45:17 UTC (rev 238594)
@@ -55,3 +55,9 @@
width: var(--disclosure-button-size);
height: var(--disclosure-button-size);
}
+
+@media (prefers-dark-interface) {
+.computed-with-traces .details-section.computed-style-properties:not(.collapsed) > :matches(.header, .content) {
+background-color: var(--background-color);
+}
+}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ComputedStyleSection.css (238593 => 238594)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ComputedStyleSection.css 2018-11-28 01:44:28 UTC (rev 238593)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ComputedStyleSection.css 2018-11-28 01:45:17 UTC (rev 238594)
@@ -42,12 +42,12 @@
.computed-style-section .computed-property-item.expanded {
padding-bottom: 2px;
-background-color: var(--background-color);
-border-top-color: hsla(0, 0%, 0%, 0.2);
+background-color: var(--background-color-code);
+border-top-color: var(--text-color-quaternary);
}
.computed-style-section .computed-property-item.expanded + .computed-property-item {
-border-top-color: hsla(0, 0%, 0%, 0.2);
+border-top-color: var(--text-color-quaternary);
}
.computed-style-section .computed-property-item .disclosure-button {
@@ -146,3 +146,9 @@
.computed-style-properties.details-section > .content > .group {
display: block;
}
+
+@media (prefers-dark-interface) {
+.computed-style-section .computed-property-item.expanded {
+background-color: var(--background-color-code);
+}
+}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [238593] trunk
Title: [238593] trunk
Revision 238593
Author commit-qu...@webkit.org
Date 2018-11-27 17:44:28 -0800 (Tue, 27 Nov 2018)
Log Message
Make synchronous IPC introduced in r237267 asynchronous
https://bugs.webkit.org/show_bug.cgi?id=190757
Patch by Alex Christensen on 2018-11-27
Reviewed by Chris Dumez.
Source/WebKit:
* UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool _getActivePagesOriginsInWebProcessForTesting:completionHandler:]):
(-[WKProcessPool _getActivePagesOriginsInWebProcessForTesting:]): Deleted.
* UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::activePagesOriginsInWebProcessForTesting):
* UIProcess/WebProcessPool.h:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::activePagesDomainsForTesting):
* UIProcess/WebProcessProxy.h:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::getActivePagesOriginsForTesting):
* WebProcess/WebProcess.messages.in:
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::getActivePagesOriginsForTesting):
Tools:
* TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h
trunk/Source/WebKit/UIProcess/WebProcessPool.cpp
trunk/Source/WebKit/UIProcess/WebProcessPool.h
trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp
trunk/Source/WebKit/UIProcess/WebProcessProxy.h
trunk/Source/WebKit/WebProcess/WebProcess.cpp
trunk/Source/WebKit/WebProcess/WebProcess.h
trunk/Source/WebKit/WebProcess/WebProcess.messages.in
trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (238592 => 238593)
--- trunk/Source/WebKit/ChangeLog 2018-11-28 01:14:50 UTC (rev 238592)
+++ trunk/Source/WebKit/ChangeLog 2018-11-28 01:44:28 UTC (rev 238593)
@@ -1,5 +1,28 @@
2018-11-27 Alex Christensen
+Make synchronous IPC introduced in r237267 asynchronous
+https://bugs.webkit.org/show_bug.cgi?id=190757
+
+Reviewed by Chris Dumez.
+
+* UIProcess/API/Cocoa/WKProcessPool.mm:
+(-[WKProcessPool _getActivePagesOriginsInWebProcessForTesting:completionHandler:]):
+(-[WKProcessPool _getActivePagesOriginsInWebProcessForTesting:]): Deleted.
+* UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
+* UIProcess/WebProcessPool.cpp:
+(WebKit::WebProcessPool::activePagesOriginsInWebProcessForTesting):
+* UIProcess/WebProcessPool.h:
+* UIProcess/WebProcessProxy.cpp:
+(WebKit::WebProcessProxy::activePagesDomainsForTesting):
+* UIProcess/WebProcessProxy.h:
+* WebProcess/WebProcess.cpp:
+(WebKit::WebProcess::getActivePagesOriginsForTesting):
+* WebProcess/WebProcess.messages.in:
+* WebProcess/cocoa/WebProcessCocoa.mm:
+(WebKit::WebProcess::getActivePagesOriginsForTesting):
+
+2018-11-27 Alex Christensen
+
Safe browsing warning text needs to be visible on High Sierra
https://bugs.webkit.org/show_bug.cgi?id=192022
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm (238592 => 238593)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm 2018-11-28 01:14:50 UTC (rev 238592)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm 2018-11-28 01:44:28 UTC (rev 238593)
@@ -49,6 +49,7 @@
#import
#import
#import
+#import
#import
#import
@@ -579,14 +580,14 @@
return wrapper(_processPool->resumeDownload(API::Data::createWithoutCopying(resumeData).ptr(), path));
}
-- (NSArray *)_getActivePagesOriginsInWebProcessForTesting:(pid_t)pid
+- (void)_getActivePagesOriginsInWebProcessForTesting:(pid_t)pid completionHandler:(void(^)(NSArray *))completionHandler
{
-auto activePagesOrigins = _processPool->activePagesOriginsInWebProcessForTesting(pid);
-
-NSMutableArray *array = [[NSMutableArray alloc] initWithCapacity:activePagesOrigins.size()];
-for (auto& origin : activePagesOrigins)
-[array addObject:(NSString *)origin];
-return [array autorelease];
+_processPool->activePagesOriginsInWebProcessForTesting(pid, [completionHandler = makeBlockPtr(completionHandler)] (Vector&& activePagesOrigins) {
+NSMutableArray *array = [[[NSMutableArray alloc] initWithCapacity:activePagesOrigins.size()] autorelease];
+for (auto& origin : activePagesOrigins)
+[array addObject:origin];
+completionHandler(array);
+});
}
- (BOOL)_networkProcessHasEntitlementForTesting:(NSString *)entitlement
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h (238592 => 238593)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h 2018-11-28 01:14:50 UTC (rev 238592)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h 2018-11-28 01:44:28 UTC (rev 238593)
@@ -114,7
[webkit-changes] [238591] tags/Safari-606.4.1.2.2/
Title: [238591] tags/Safari-606.4.1.2.2/ Revision 238591 Author alanc...@apple.com Date 2018-11-27 16:30:43 -0800 (Tue, 27 Nov 2018) Log Message Tag Safari-606.4.1.2.2. Added Paths tags/Safari-606.4.1.2.2/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [238590] trunk/Tools
Title: [238590] trunk/Tools Revision 238590 Author jbed...@apple.com Date 2018-11-27 16:29:40 -0800 (Tue, 27 Nov 2018) Log Message webkitpy: Add watchOS ports https://bugs.webkit.org/show_bug.cgi?id=191974 Reviewed by Aakash Jain. * Scripts/webkitpy/port/factory.py: (PortFactory): Add WatchDevice and WatchSimulator ports. * Scripts/webkitpy/port/watch.py: Added. (WatchPort): Base class for watchOS ports. * Scripts/webkitpy/port/watch_device.py: Added. (WatchDevicePort): Class for running layout tests on a watchOS device. * Scripts/webkitpy/port/watch_simulator.py: Added. (WatchSimulatorPort): Class for running layout tests on a watchOS simulator. * Scripts/webkitpy/port/watch_simulator_unittest.py: Added. (WatchSimulatorTest): * Scripts/webkitpy/port/watch_testcase.py: Added. (WatchTest): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/port/factory.py Added Paths trunk/Tools/Scripts/webkitpy/port/watch.py trunk/Tools/Scripts/webkitpy/port/watch_device.py trunk/Tools/Scripts/webkitpy/port/watch_simulator.py trunk/Tools/Scripts/webkitpy/port/watch_simulator_unittest.py trunk/Tools/Scripts/webkitpy/port/watch_testcase.py Diff Modified: trunk/Tools/ChangeLog (238589 => 238590) --- trunk/Tools/ChangeLog 2018-11-28 00:28:06 UTC (rev 238589) +++ trunk/Tools/ChangeLog 2018-11-28 00:29:40 UTC (rev 238590) @@ -1,3 +1,24 @@ +2018-11-27 Jonathan Bedard + +webkitpy: Add watchOS ports +https://bugs.webkit.org/show_bug.cgi?id=191974 + + +Reviewed by Aakash Jain. + +* Scripts/webkitpy/port/factory.py: +(PortFactory): Add WatchDevice and WatchSimulator ports. +* Scripts/webkitpy/port/watch.py: Added. +(WatchPort): Base class for watchOS ports. +* Scripts/webkitpy/port/watch_device.py: Added. +(WatchDevicePort): Class for running layout tests on a watchOS device. +* Scripts/webkitpy/port/watch_simulator.py: Added. +(WatchSimulatorPort): Class for running layout tests on a watchOS simulator. +* Scripts/webkitpy/port/watch_simulator_unittest.py: Added. +(WatchSimulatorTest): +* Scripts/webkitpy/port/watch_testcase.py: Added. +(WatchTest): + 2018-11-27 Alex Christensen Safe browsing warning text needs to be visible on High Sierra Modified: trunk/Tools/Scripts/webkitpy/port/factory.py (238589 => 238590) --- trunk/Tools/Scripts/webkitpy/port/factory.py 2018-11-28 00:28:06 UTC (rev 238589) +++ trunk/Tools/Scripts/webkitpy/port/factory.py 2018-11-28 00:29:40 UTC (rev 238590) @@ -1,5 +1,5 @@ # Copyright (C) 2010 Google Inc. All rights reserved. -# Copyright (C) 2013 Apple Inc. All rights reserved. +# Copyright (C) 2013-2018 Apple Inc. All rights reserved. # Copyright (C) 2013 Nokia Corporation and/or its subsidiary(-ies). # # Redistribution and use in source and binary forms, with or without @@ -91,6 +91,8 @@ 'gtk.GtkPort', 'ios_simulator.IOSSimulatorPort', 'ios_device.IOSDevicePort', +'watch_simulator.WatchSimulatorPort', +'watch_device.WatchDevicePort', 'jsc_only.JscOnlyPort', 'mac.MacPort', 'mock_drt.MockDRTPort', Added: trunk/Tools/Scripts/webkitpy/port/watch.py (0 => 238590) --- trunk/Tools/Scripts/webkitpy/port/watch.py (rev 0) +++ trunk/Tools/Scripts/webkitpy/port/watch.py 2018-11-28 00:29:40 UTC (rev 238590) @@ -0,0 +1,103 @@ +# Copyright (C) 2018 Apple Inc. All rights reserved. +# +# Redistribution and use in source and binary forms, with or without +# modification, are permitted provided that the following conditions +# are met: +# 1. Redistributions of source code must retain the above copyright +# notice, this list of conditions and the following disclaimer. +# 2. Redistributions in binary form must reproduce the above copyright +# notice, this list of conditions and the following disclaimer in the +# documentation and/or other materials provided with the distribution. +# +# THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND +# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED +# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE +# DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR +# ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL +# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR +# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER +# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, +# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +import logging + +from webkitpy.common.memoized import memoized +from webkitpy.common.version import Version +from webkitpy.common.version_name_map import VersionNameMap, INTERNAL_TABLE
[webkit-changes] [238589] trunk/Source/WebInspectorUI
Title: [238589] trunk/Source/WebInspectorUI Revision 238589 Author nvasil...@apple.com Date 2018-11-27 16:28:06 -0800 (Tue, 27 Nov 2018) Log Message Web Inspector: Computed panel: allow to expand properties to show list of overridden values https://bugs.webkit.org/show_bug.cgi?id=191984 Reviewed by Devin Rousso. Introduce the new experimental Computed Style Cascades. Each property now can expand to show a list of overridden values, their corresponding selectors, and source locations. * Localizations/en.lproj/localizedStrings.js: * UserInterface/Base/Setting.js: * UserInterface/Main.html: * UserInterface/Models/DOMNodeStyles.js: (WI.DOMNodeStyles.prototype.get uniqueOrderedStyles): Move `uniqueOrderedStyles` function unmodified from SpreadsheetRulesStyleDetailsPanel so it can be used by ComputedStyleDetailsPanel, too. * UserInterface/Views/ComputedStyleDetailsPanel.css: (.computed-with-traces .computed-style-properties): (.computed-with-traces .details-section.computed-style-properties:not(.collapsed) > :matches(.header, .content)): (.computed-with-traces .details-section.computed-style-properties > .content): (.computed-with-traces .computed-style-properties .property .go-to-arrow): * UserInterface/Views/ComputedStyleDetailsPanel.js: (WI.ComputedStyleDetailsPanel.prototype.refresh): (WI.ComputedStyleDetailsPanel.prototype.applyFilter): (WI.ComputedStyleDetailsPanel.prototype.focusFirstSection): (WI.ComputedStyleDetailsPanel.prototype.initialLayout): (WI.ComputedStyleDetailsPanel.prototype._computePropertyTraces): (WI.ComputedStyleDetailsPanel.prototype._computedStyleShowAllCheckboxValueChanged): (WI.ComputedStyleDetailsPanel.prototype._handlePropertiesSectionCollapsedStateChanged): (WI.ComputedStyleDetailsPanel.prototype._handleEditorFilterApplied): (WI.ComputedStyleDetailsPanel): Use the new Computed section (WI.ComputedStyleSection) only when it's enabled in the experimental settings. Otherwise, use the current Computed section. * UserInterface/Views/ComputedStyleDetailsSidebarPanel.js: (WI.ComputedStyleDetailsSidebarPanel): * UserInterface/Views/ComputedStyleSection.css: Added. (.computed-style-section): (.computed-style-section .computed-property-item): (.computed-style-section .computed-property-item.expanded): (.computed-style-section .computed-property-item.expanded + .computed-property-item): (.computed-style-section .computed-property-item .disclosure-button): (.computed-style-section .computed-property-item .property-traces): (.computed-style-section .computed-property-item.expanded .property-traces): (.computed-style-section .computed-property-item.expanded .disclosure-button): (.computed-style-section .computed-property-item .property-trace-item): (.computed-style-section .computed-property-item .property-trace-item .property.overridden .value): (.computed-style-section .property-trace-item-left,): (.computed-style-section .property-trace-item-right): (.computed-style-section .computed-property-item .property-trace-item .value): (.computed-style-section .property .value): (.computed-style-section .computed-property-item .property): (.computed-style-section .computed-property-item .property .name): (.computed-style-section .computed-property-item .property-trace-item .selector): (.computed-style-section .computed-property-item .origin): (.computed-style-section .computed-property-item .go-to-link): (.computed-style-section .property-trace-item .property .name,): (.computed-style-section .property-trace-item .property .value + span): (.computed-style-properties.details-section > .content,): * UserInterface/Views/ComputedStyleSection.js: Added. (WI.ComputedStyleSection): (WI.ComputedStyleSection.prototype.get style): (WI.ComputedStyleSection.prototype.set style): (WI.ComputedStyleSection.prototype.get styleTraces): (WI.ComputedStyleSection.prototype.set styleTraces): (WI.ComputedStyleSection.prototype.set showsImplicitProperties): (WI.ComputedStyleSection.prototype.set alwaysShowPropertyNames): (WI.ComputedStyleSection.prototype.set propertyVisibilityMode): (WI.ComputedStyleSection.prototype.set hideFilterNonMatchingProperties): (WI.ComputedStyleSection.prototype.get propertiesToRender): (WI.ComputedStyleSection.prototype.layout): (WI.ComputedStyleSection.prototype.detached): (WI.ComputedStyleSection.prototype.hidden): (WI.ComputedStyleSection.prototype.applyFilter): (WI.ComputedStyleSection.prototype.spreadsheetStylePropertyShowProperty): (WI.ComputedStyleSection.prototype._createTrace): (WI.ComputedStyleSection.prototype._handlePropertiesChanged): * UserInterface/Views/ExpandableView.js: Added. (WI.ExpandableView): (WI.ExpandableView.prototype.get element): (WI.ExpandableView.prototype._onDisclosureButtonClick): (WI.ExpandableView.prototype._update): * UserInterface/Views/SettingsTabContentView.js: (WI.SettingsTabContentView.prototype._createExperimentalSettingsView): * UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:
[webkit-changes] [238588] trunk/Source/WebCore
Title: [238588] trunk/Source/WebCore
Revision 238588
Author jiewen_...@apple.com
Date 2018-11-27 16:26:09 -0800 (Tue, 27 Nov 2018)
Log Message
Remove kCCNotVerified
https://bugs.webkit.org/show_bug.cgi?id=192034
Reviewed by Alexey Proskuryakov.
No change of behaviours.
* crypto/CommonCryptoUtilities.h:
* crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:
(WebCore::verifyRSASSA_PKCS1_v1_5):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/crypto/CommonCryptoUtilities.h
trunk/Source/WebCore/crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (238587 => 238588)
--- trunk/Source/WebCore/ChangeLog 2018-11-28 00:20:28 UTC (rev 238587)
+++ trunk/Source/WebCore/ChangeLog 2018-11-28 00:26:09 UTC (rev 238588)
@@ -1,3 +1,17 @@
+2018-11-27 Jiewen Tan
+
+Remove kCCNotVerified
+https://bugs.webkit.org/show_bug.cgi?id=192034
+
+
+Reviewed by Alexey Proskuryakov.
+
+No change of behaviours.
+
+* crypto/CommonCryptoUtilities.h:
+* crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:
+(WebCore::verifyRSASSA_PKCS1_v1_5):
+
2018-11-27 Simon Fraser
Avoid triggering compositing updates when only the root layer is composited
Modified: trunk/Source/WebCore/crypto/CommonCryptoUtilities.h (238587 => 238588)
--- trunk/Source/WebCore/crypto/CommonCryptoUtilities.h 2018-11-28 00:20:28 UTC (rev 238587)
+++ trunk/Source/WebCore/crypto/CommonCryptoUtilities.h 2018-11-28 00:26:09 UTC (rev 238588)
@@ -71,10 +71,6 @@
ccRSAPSSPadding = 1005
};
typedef uint32_t CCAsymmetricPadding;
-
-enum {
-kCCNotVerified = -4306
-};
#endif
typedef struct _CCBigNumRef *CCBigNumRef;
Modified: trunk/Source/WebCore/crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp (238587 => 238588)
--- trunk/Source/WebCore/crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp 2018-11-28 00:20:28 UTC (rev 238587)
+++ trunk/Source/WebCore/crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp 2018-11-28 00:26:09 UTC (rev 238588)
@@ -77,7 +77,7 @@
auto status = CCRSACryptorVerify(key, ccPKCS1Padding, digestData.data(), digestData.size(), digestAlgorithm, 0, signature.data(), signature.size());
if (!status)
return true;
-if (status == kCCNotVerified || status == kCCDecodeError) // CCRSACryptorVerify returns kCCDecodeError instead of kCCNotVerified sometimes
+if (status == kCCDecodeError)
return false;
return Exception { OperationError };
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [238586] tags/Safari-607.1.14.4/Source/JavaScriptCore
Title: [238586] tags/Safari-607.1.14.4/Source/_javascript_Core
Revision 238586
Author kocsen_ch...@apple.com
Date 2018-11-27 16:20:00 -0800 (Tue, 27 Nov 2018)
Log Message
Revert r238573. rdar://problem/45494310
Modified Paths
tags/Safari-607.1.14.4/Source/_javascript_Core/ChangeLog
tags/Safari-607.1.14.4/Source/_javascript_Core/config.h
tags/Safari-607.1.14.4/Source/_javascript_Core/jit/ExecutableAllocator.cpp
tags/Safari-607.1.14.4/Source/_javascript_Core/jit/ExecutableAllocator.h
tags/Safari-607.1.14.4/Source/_javascript_Core/runtime/Options.cpp
Diff
Modified: tags/Safari-607.1.14.4/Source/_javascript_Core/ChangeLog (238585 => 238586)
--- tags/Safari-607.1.14.4/Source/_javascript_Core/ChangeLog 2018-11-28 00:15:01 UTC (rev 238585)
+++ tags/Safari-607.1.14.4/Source/_javascript_Core/ChangeLog 2018-11-28 00:20:00 UTC (rev 238586)
@@ -1,5 +1,9 @@
2018-11-27 Alan Coon
+Revert r238573. rdar://problem/45494310
+
+2018-11-27 Alan Coon
+
Cherry-pick r238564. rdar://problem/45494310
Introducing a ENABLE_SEPARATED_WX_HEAP macro.
Modified: tags/Safari-607.1.14.4/Source/_javascript_Core/config.h (238585 => 238586)
--- tags/Safari-607.1.14.4/Source/_javascript_Core/config.h 2018-11-28 00:15:01 UTC (rev 238585)
+++ tags/Safari-607.1.14.4/Source/_javascript_Core/config.h 2018-11-28 00:20:00 UTC (rev 238586)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2006-2018 Apple Inc. All rights reserved.
+ * Copyright (C) 2006, 2007, 2008, 2013 Apple Inc. All rights reserved.
* Copyright (C) 2006 Samuel Weinig
*
* This library is free software; you can redistribute it and/or
@@ -37,11 +37,3 @@
#endif
#include
-
-#if !defined(ENABLE_SEPARATED_WX_HEAP)
-#if (!ENABLE(FAST_JIT_PERMISSIONS) || !CPU(ARM64E)) && PLATFORM(IOS_FAMILY) && CPU(ARM64)
-#define ENABLE_SEPARATED_WX_HEAP 1
-#else
-#define ENABLE_SEPARATED_WX_HEAP 0
-#endif
-#endif // !defined(ENABLE_SEPARATED_WX_HEAP)
Modified: tags/Safari-607.1.14.4/Source/_javascript_Core/jit/ExecutableAllocator.cpp (238585 => 238586)
--- tags/Safari-607.1.14.4/Source/_javascript_Core/jit/ExecutableAllocator.cpp 2018-11-28 00:15:01 UTC (rev 238585)
+++ tags/Safari-607.1.14.4/Source/_javascript_Core/jit/ExecutableAllocator.cpp 2018-11-28 00:20:00 UTC (rev 238586)
@@ -104,7 +104,7 @@
static const double executablePoolReservationFraction = 0.25;
#endif
-#if ENABLE(SEPARATED_WX_HEAP)
+#if !ENABLE(FAST_JIT_PERMISSIONS) || !CPU(ARM64E)
JS_EXPORT_PRIVATE bool useFastPermisionsJITCopy { false };
JS_EXPORT_PRIVATE JITWriteSeparateHeapsFunction jitWriteSeparateHeapsFunction;
#endif
@@ -154,11 +154,11 @@
ASSERT(m_reservation.size() == reservationSize);
void* reservationBase = m_reservation.base();
-#if ENABLE(FAST_JIT_PERMISSIONS) && !ENABLE(SEPARATED_WX_HEAP)
+#if ENABLE(FAST_JIT_PERMISSIONS) && CPU(ARM64E)
RELEASE_ASSERT(os_thread_self_restrict_rwx_is_supported());
os_thread_self_restrict_rwx_to_rx();
-#else // not ENABLE(FAST_JIT_PERMISSIONS) or ENABLE(SEPARATED_WX_HEAP)
+#else // not ENABLE(FAST_JIT_PERMISSIONS) or not CPU(ARM64E)
#if ENABLE(FAST_JIT_PERMISSIONS)
if (os_thread_self_restrict_rwx_is_supported()) {
useFastPermisionsJITCopy = true;
@@ -172,7 +172,7 @@
reservationSize -= pageSize();
initializeSeparatedWXHeaps(m_reservation.base(), pageSize(), reservationBase, reservationSize);
}
-#endif // not ENABLE(FAST_JIT_PERMISSIONS) or ENABLE(SEPARATED_WX_HEAP)
+#endif // not ENABLE(FAST_JIT_PERMISSIONS) or not CPU(ARM64E)
addFreshFreeSpace(reservationBase, reservationSize);
@@ -266,7 +266,7 @@
// Zero out writableAddr to avoid leaking the address of the writable mapping.
memset_s(, sizeof(writableAddr), 0, sizeof(writableAddr));
-#if ENABLE(SEPARATED_WX_HEAP)
+#if !ENABLE(FAST_JIT_PERMISSIONS) || !CPU(ARM64E)
jitWriteSeparateHeapsFunction = reinterpret_cast(writeThunk.code().executableAddress());
#endif
}
Modified: tags/Safari-607.1.14.4/Source/_javascript_Core/jit/ExecutableAllocator.h (238585 => 238586)
--- tags/Safari-607.1.14.4/Source/_javascript_Core/jit/ExecutableAllocator.h 2018-11-28 00:15:01 UTC (rev 238585)
+++ tags/Safari-607.1.14.4/Source/_javascript_Core/jit/ExecutableAllocator.h 2018-11-28 00:20:00 UTC (rev 238586)
@@ -78,13 +78,13 @@
JS_EXPORT_PRIVATE bool isJITPC(void* pc);
-#if ENABLE(SEPARATED_WX_HEAP)
+#if !ENABLE(FAST_JIT_PERMISSIONS) || !CPU(ARM64E)
typedef void (*JITWriteSeparateHeapsFunction)(off_t, const void*, size_t);
extern JS_EXPORT_PRIVATE JITWriteSeparateHeapsFunction jitWriteSeparateHeapsFunction;
extern JS_EXPORT_PRIVATE bool useFastPermisionsJITCopy;
-#endif // ENABLE(SEPARATED_WX_HEAP)
+#endif // !ENABLE(FAST_JIT_PERMISSIONS) || !CPU(ARM64E)
static inline void* performJITMemcpy(void *dst, const void *src, size_t n)
{
@@ -96,7 +96,7 @@
if (isJITPC(dst)) {
[webkit-changes] [238587] branches/safari-606.4.1.2-branch/Source
Title: [238587] branches/safari-606.4.1.2-branch/Source Revision 238587 Author alanc...@apple.com Date 2018-11-27 16:20:28 -0800 (Tue, 27 Nov 2018) Log Message Versioning. Modified Paths branches/safari-606.4.1.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-606.4.1.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-606.4.1.2-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-606.4.1.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-606.4.1.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-606.4.1.2-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-606.4.1.2-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-606.4.1.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig (238586 => 238587) --- branches/safari-606.4.1.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2018-11-28 00:20:00 UTC (rev 238586) +++ branches/safari-606.4.1.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2018-11-28 00:20:28 UTC (rev 238587) @@ -25,7 +25,7 @@ MINOR_VERSION = 4; TINY_VERSION = 1; MICRO_VERSION = 2; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-606.4.1.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (238586 => 238587) --- branches/safari-606.4.1.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2018-11-28 00:20:00 UTC (rev 238586) +++ branches/safari-606.4.1.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2018-11-28 00:20:28 UTC (rev 238587) @@ -25,7 +25,7 @@ MINOR_VERSION = 4; TINY_VERSION = 1; MICRO_VERSION = 2; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-606.4.1.2-branch/Source/WebCore/Configurations/Version.xcconfig (238586 => 238587) --- branches/safari-606.4.1.2-branch/Source/WebCore/Configurations/Version.xcconfig 2018-11-28 00:20:00 UTC (rev 238586) +++ branches/safari-606.4.1.2-branch/Source/WebCore/Configurations/Version.xcconfig 2018-11-28 00:20:28 UTC (rev 238587) @@ -25,7 +25,7 @@ MINOR_VERSION = 4; TINY_VERSION = 1; MICRO_VERSION = 2; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-606.4.1.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (238586 => 238587) --- branches/safari-606.4.1.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2018-11-28 00:20:00 UTC (rev 238586) +++ branches/safari-606.4.1.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2018-11-28 00:20:28 UTC (rev 238587) @@ -25,7 +25,7 @@ MINOR_VERSION = 4; TINY_VERSION = 1; MICRO_VERSION = 2; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-606.4.1.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (238586 => 238587) --- branches/safari-606.4.1.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2018-11-28 00:20:00 UTC (rev 238586) +++ branches/safari-606.4.1.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2018-11-28 00:20:28 UTC (rev 238587) @@ -2,7 +2,7 @@ MINOR_VERSION = 4; TINY_VERSION = 1; MICRO_VERSION = 2; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The system version prefix is based on the current system version. Modified: branches/safari-606.4.1.2-branch/Source/WebKit/Configurations/Version.xcconfig (238586 => 238587) --- branches/safari-606.4.1.2-branch/Source/WebKit/Configurations/Version.xcconfig 2018-11-28 00:20:00 UTC (rev 238586) +++ branches/safari-606.4.1.2-branch/Source/WebKit/Configurations/Version.xcconfig 2018-11-28 00:20:28 UTC (rev 238587) @@ -25,7 +25,7 @@ MINOR_VERSION = 4; TINY_VERSION = 1; MICRO_VERSION = 2; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified:
[webkit-changes] [238585] trunk
Title: [238585] trunk
Revision 238585
Author achristen...@apple.com
Date 2018-11-27 16:15:01 -0800 (Tue, 27 Nov 2018)
Log Message
Safe browsing warning text needs to be visible on High Sierra
https://bugs.webkit.org/show_bug.cgi?id=192022
Reviewed by Tim Horton.
Source/WebKit:
Something about AppKit, autolayout, view insertion order, and NSTextView makes the text lay
out with initial size of {0, 0} on High Sierra. Using an NSTextField instead makes the details visible.
Covered by an API test.
* UIProcess/Cocoa/WKSafeBrowsingWarning.h:
* UIProcess/Cocoa/WKSafeBrowsingWarning.mm:
(makeLabel):
(-[WKSafeBrowsingWarning addContent]):
(-[WKSafeBrowsingWarning showDetailsClicked]):
(-[WKSafeBrowsingWarning layoutText]):
(makeTitleLabel): Deleted.
Tools:
* TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
(TEST):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/WKSafeBrowsingWarning.h
trunk/Source/WebKit/UIProcess/Cocoa/WKSafeBrowsingWarning.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (238584 => 238585)
--- trunk/Source/WebKit/ChangeLog 2018-11-27 23:54:06 UTC (rev 238584)
+++ trunk/Source/WebKit/ChangeLog 2018-11-28 00:15:01 UTC (rev 238585)
@@ -1,3 +1,23 @@
+2018-11-27 Alex Christensen
+
+Safe browsing warning text needs to be visible on High Sierra
+https://bugs.webkit.org/show_bug.cgi?id=192022
+
+Reviewed by Tim Horton.
+
+Something about AppKit, autolayout, view insertion order, and NSTextView makes the text lay
+out with initial size of {0, 0} on High Sierra. Using an NSTextField instead makes the details visible.
+
+Covered by an API test.
+
+* UIProcess/Cocoa/WKSafeBrowsingWarning.h:
+* UIProcess/Cocoa/WKSafeBrowsingWarning.mm:
+(makeLabel):
+(-[WKSafeBrowsingWarning addContent]):
+(-[WKSafeBrowsingWarning showDetailsClicked]):
+(-[WKSafeBrowsingWarning layoutText]):
+(makeTitleLabel): Deleted.
+
2018-11-27 Tim Horton
WKNavigation.AutomaticViewReloadAfterWebProcessCrash asserts after r238538
Modified: trunk/Source/WebKit/UIProcess/Cocoa/WKSafeBrowsingWarning.h (238584 => 238585)
--- trunk/Source/WebKit/UIProcess/Cocoa/WKSafeBrowsingWarning.h 2018-11-27 23:54:06 UTC (rev 238584)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WKSafeBrowsingWarning.h 2018-11-28 00:15:01 UTC (rev 238585)
@@ -57,7 +57,7 @@
@package
CompletionHandler&&)> _completionHandler;
RefPtr _warning;
-RetainPtr> _textViews;
+WeakObjCPtr _details;
}
- (instancetype)initWithFrame:(RectType)frame safeBrowsingWarning:(const WebKit::SafeBrowsingWarning&)warning completionHandler:(CompletionHandler&&)>&&)completionHandler;
Modified: trunk/Source/WebKit/UIProcess/Cocoa/WKSafeBrowsingWarning.mm (238584 => 238585)
--- trunk/Source/WebKit/UIProcess/Cocoa/WKSafeBrowsingWarning.mm 2018-11-27 23:54:06 UTC (rev 238584)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WKSafeBrowsingWarning.mm 2018-11-28 00:15:01 UTC (rev 238585)
@@ -197,12 +197,8 @@
#endif
}
-static ViewType *makeTitleLabel(NSString *title, ViewType *warning)
+static ViewType *makeLabel(NSAttributedString *attributedString)
{
-auto attributedString = [[[NSAttributedString alloc] initWithString:title attributes:@{
-NSFontAttributeName:[FontType boldSystemFontOfSize:titleSize],
-NSForegroundColorAttributeName:colorForItem(WarningItem::TitleText, warning)
-}] autorelease];
#if PLATFORM(MAC)
return [NSTextField labelWithAttributedString:attributedString];
#else
@@ -251,15 +247,19 @@
- (void)addContent
{
auto exclamationPoint = [[WKSafeBrowsingExclamationPoint new] autorelease];
-auto title = makeTitleLabel(_warning->title(), self);
-auto warning = [[[WKSafeBrowsingTextView alloc] initWithAttributedString:[[[NSAttributedString alloc] initWithString:_warning->warning() attributes:@{ NSFontAttributeName:[FontType systemFontOfSize:textSize] }] autorelease] forWarning:self] autorelease];
+auto title = makeLabel([[[NSAttributedString alloc] initWithString:_warning->title() attributes:@{
+NSFontAttributeName:[FontType boldSystemFontOfSize:titleSize],
+NSForegroundColorAttributeName:colorForItem(WarningItem::TitleText, self)
+}] autorelease]);
+auto warning = makeLabel([[[NSAttributedString alloc] initWithString:_warning->warning() attributes:@{
+NSFontAttributeName:[FontType systemFontOfSize:textSize],
+NSForegroundColorAttributeName:colorForItem(WarningItem::MessageText, self)
+}] autorelease]);
auto showDetails = makeButton(WarningItem::ShowDetailsButton, self, @selector(showDetailsClicked));
auto goBack = makeButton(WarningItem::GoBackButton, self, @selector(goBackClicked));
auto box = [[ViewType new] autorelease];
setBackground(box, colorForItem(WarningItem::BoxBackground, self));
[webkit-changes] [238584] trunk/Tools
Title: [238584] trunk/Tools
Revision 238584
Author wenson_hs...@apple.com
Date 2018-11-27 15:54:06 -0800 (Tue, 27 Nov 2018)
Log Message
Unreviewed, fix the watchOS engineering build
Disable a newly added API test, since DDScannerResult is unavailable on watchOS.
* TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm
Diff
Modified: trunk/Tools/ChangeLog (238583 => 238584)
--- trunk/Tools/ChangeLog 2018-11-27 23:46:18 UTC (rev 238583)
+++ trunk/Tools/ChangeLog 2018-11-27 23:54:06 UTC (rev 238584)
@@ -1,3 +1,11 @@
+2018-11-27 Wenson Hsieh
+
+Unreviewed, fix the watchOS engineering build
+
+Disable a newly added API test, since DDScannerResult is unavailable on watchOS.
+
+* TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm:
+
2018-11-27 Chris Dumez
Regression(PSON) crash under WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame()
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm (238583 => 238584)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm 2018-11-27 23:46:18 UTC (rev 238583)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm 2018-11-27 23:54:06 UTC (rev 238584)
@@ -126,6 +126,8 @@
expectLinkCount(webView.get(), @"yesterday at 6PM", 1);
}
+#if PLATFORM(IOS)
+
TEST(WebKit, AddAndRemoveDataDetectors)
{
auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
@@ -164,4 +166,6 @@
checkDataDetectionResults([webView _dataDetectionResults]);
}
+#endif // PLATFORM(IOS)
+
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [238583] trunk
Title: [238583] trunk
Revision 238583
Author simon.fra...@apple.com
Date 2018-11-27 15:46:18 -0800 (Tue, 27 Nov 2018)
Log Message
Avoid triggering compositing updates when only the root layer is composited
https://bugs.webkit.org/show_bug.cgi?id=191813
Reviewed by Zalan Bujtas.
If we know that the only composited layer is the root, we can avoid triggering deep
compositing updates sometimes, for example when layout changes size or position,
or when z-order lists change.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::addChild):
(WebCore::RenderLayer::removeChild):
(WebCore::RenderLayer::updateLayerPosition):
(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::updateCompositingLayersAfterScroll):
(WebCore::outputPaintOrderTreeRecursive):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateBackingAndHierarchy): Consult the layer.hasCompositingDescendant()
flag to cut off descendants traversal when possible.
(WebCore::RenderLayerCompositor::layerStyleChanged):
Modified Paths
trunk/LayoutTests/platform/ios-wk2/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
Diff
Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (238582 => 238583)
--- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2018-11-27 23:45:43 UTC (rev 238582)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2018-11-27 23:46:18 UTC (rev 238583)
@@ -1124,6 +1124,10 @@
svg/animations/animate-linear-discrete-additive.svg [ ImageOnlyFailure ]
svg/animations/mozilla/animateMotion-mpath-pathLength-1.svg [ ImageOnlyFailure ]
+webkit.org/b/192045 css3/filters/blur-filter-page-scroll-parents.html
+webkit.org/b/192045 css3/filters/blur-filter-page-scroll-self.html
+webkit.org/b/192045 css3/filters/blur-filter-page-scroll.html
+
webkit.org/b/159379 fast/history/page-cache-webdatabase-pending-transaction.html [ Pass Failure ]
webkit.org/b/159840 http/tests/cache/disk-cache/disk-cache-request-max-stale.html [ Pass Timeout ]
Modified: trunk/Source/WebCore/ChangeLog (238582 => 238583)
--- trunk/Source/WebCore/ChangeLog 2018-11-27 23:45:43 UTC (rev 238582)
+++ trunk/Source/WebCore/ChangeLog 2018-11-27 23:46:18 UTC (rev 238583)
@@ -1,3 +1,26 @@
+2018-11-27 Simon Fraser
+
+Avoid triggering compositing updates when only the root layer is composited
+https://bugs.webkit.org/show_bug.cgi?id=191813
+
+Reviewed by Zalan Bujtas.
+
+If we know that the only composited layer is the root, we can avoid triggering deep
+compositing updates sometimes, for example when layout changes size or position,
+or when z-order lists change.
+
+* rendering/RenderLayer.cpp:
+(WebCore::RenderLayer::addChild):
+(WebCore::RenderLayer::removeChild):
+(WebCore::RenderLayer::updateLayerPosition):
+(WebCore::RenderLayer::scrollTo):
+(WebCore::RenderLayer::updateCompositingLayersAfterScroll):
+(WebCore::outputPaintOrderTreeRecursive):
+* rendering/RenderLayerCompositor.cpp:
+(WebCore::RenderLayerCompositor::updateBackingAndHierarchy): Consult the layer.hasCompositingDescendant()
+flag to cut off descendants traversal when possible.
+(WebCore::RenderLayerCompositor::layerStyleChanged):
+
2018-11-27 Eric Carlson
Refactor duplicate code for calling into media controls
Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (238582 => 238583)
--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2018-11-27 23:45:43 UTC (rev 238582)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2018-11-27 23:46:18 UTC (rev 238583)
@@ -405,7 +405,7 @@
if (child.isSelfPaintingLayer() || child.hasSelfPaintingLayerDescendant())
setAncestorChainHasSelfPaintingLayerDescendant();
-if (compositor().usesCompositing())
+if (compositor().hasContentCompositingLayers())
setDescendantsNeedCompositingRequirementsTraversal();
if (child.hasDescendantNeedingCompositingRequirementsTraversal() || child.needsCompositingRequirementsTraversal())
@@ -451,7 +451,7 @@
if (oldChild.isSelfPaintingLayer() || oldChild.hasSelfPaintingLayerDescendant())
dirtyAncestorChainHasSelfPaintingLayerDescendantStatus();
-if (compositor().usesCompositing())
+if (compositor().hasContentCompositingLayers())
setDescendantsNeedCompositingRequirementsTraversal();
#if ENABLE(CSS_COMPOSITING)
@@ -1577,7 +1577,7 @@
positionOrOffsetChanged |= location() != localPoint;
setLocation(localPoint);
-if (positionOrOffsetChanged && compositor().usesCompositing()) {
+if (positionOrOffsetChanged && compositor().hasContentCompositingLayers()) {
if (isComposited())
setNeedsCompositingGeometryUpdate();
// This layer's position can affect the location of a composited descendant (which may be a sibling in
[webkit-changes] [238582] trunk/Source/WebCore
Title: [238582] trunk/Source/WebCore
Revision 238582
Author eric.carl...@apple.com
Date 2018-11-27 15:45:43 -0800 (Tue, 27 Nov 2018)
Log Message
Refactor duplicate code for calling into media controls
https://bugs.webkit.org/show_bug.cgi?id=192040
Reviewed by Youenn Fablet.
No new tests, no functional change.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setupAndCallJS):
(WebCore::HTMLMediaElement::updateCaptionContainer):
(WebCore::HTMLMediaElement::configureTextTrackDisplay):
(WebCore::HTMLMediaElement::ensureMediaControlsInjectedScript):
(WebCore::HTMLMediaElement::setControllerJSProperty):
(WebCore::HTMLMediaElement::didAddUserAgentShadowRoot):
(WebCore::HTMLMediaElement::updateMediaControlsAfterPresentationModeChange):
(WebCore::HTMLMediaElement::getCurrentMediaControlsStatus):
* html/HTMLMediaElement.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/HTMLMediaElement.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (238581 => 238582)
--- trunk/Source/WebCore/ChangeLog 2018-11-27 23:23:42 UTC (rev 238581)
+++ trunk/Source/WebCore/ChangeLog 2018-11-27 23:45:43 UTC (rev 238582)
@@ -1,3 +1,24 @@
+2018-11-27 Eric Carlson
+
+Refactor duplicate code for calling into media controls
+https://bugs.webkit.org/show_bug.cgi?id=192040
+
+
+Reviewed by Youenn Fablet.
+
+No new tests, no functional change.
+
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::setupAndCallJS):
+(WebCore::HTMLMediaElement::updateCaptionContainer):
+(WebCore::HTMLMediaElement::configureTextTrackDisplay):
+(WebCore::HTMLMediaElement::ensureMediaControlsInjectedScript):
+(WebCore::HTMLMediaElement::setControllerJSProperty):
+(WebCore::HTMLMediaElement::didAddUserAgentShadowRoot):
+(WebCore::HTMLMediaElement::updateMediaControlsAfterPresentationModeChange):
+(WebCore::HTMLMediaElement::getCurrentMediaControlsStatus):
+* html/HTMLMediaElement.h:
+
2018-11-27 Simon Fraser
Momentum scrolling ends at the wrong place when a scrolling overflow element has a non-zero border
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (238581 => 238582)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2018-11-27 23:23:42 UTC (rev 238581)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2018-11-27 23:45:43 UTC (rev 238582)
@@ -4355,6 +4355,26 @@
m_creatingControls = false;
}
+bool HTMLMediaElement::setupAndCallJS(const JSSetupFunction& task)
+{
+Page* page = document().page();
+if (!page)
+return false;
+
+auto pendingActivity = makePendingActivity(*this);
+auto& world = ensureIsolatedWorld();
+auto& scriptController = document().frame()->script();
+auto* globalObject = JSC::jsCast(scriptController.globalObject(world));
+auto& vm = globalObject->vm();
+JSC::JSLockHolder lock(vm);
+auto scope = DECLARE_THROW_SCOPE(vm);
+auto* exec = globalObject->globalExec();
+
+RETURN_IF_EXCEPTION(scope, false);
+
+return task(*globalObject, *exec, scriptController, world);
+}
+
void HTMLMediaElement::updateCaptionContainer()
{
#if ENABLE(MEDIA_CONTROLS_SCRIPT)
@@ -4361,12 +4381,6 @@
if (m_haveSetUpCaptionContainer)
return;
-Page* page = document().page();
-if (!page)
-return;
-
-DOMWrapperWorld& world = ensureIsolatedWorld();
-
if (!ensureMediaControlsInjectedScript())
return;
@@ -4375,40 +4389,40 @@
if (!m_mediaControlsHost)
m_mediaControlsHost = MediaControlsHost::create(this);
-ScriptController& scriptController = document().frame()->script();
-JSDOMGlobalObject* globalObject = JSC::jsCast(scriptController.globalObject(world));
-JSC::VM& vm = globalObject->vm();
-JSC::JSLockHolder lock(vm);
-auto scope = DECLARE_CATCH_SCOPE(vm);
-JSC::ExecState* exec = globalObject->globalExec();
+setupAndCallJS([this](JSDOMGlobalObject& globalObject, JSC::ExecState& exec, ScriptController&, DOMWrapperWorld&) {
+auto& vm = globalObject.vm();
+auto scope = DECLARE_CATCH_SCOPE(vm);
+auto controllerValue = controllerJSValue(exec, globalObject, *this);
+auto* controllerObject = JSC::jsDynamicCast(vm, controllerValue);
+if (!controllerObject)
+return false;
-JSC::JSValue controllerValue = controllerJSValue(*exec, *globalObject, *this);
-JSC::JSObject* controllerObject = JSC::jsDynamicCast(vm, controllerValue);
-if (!controllerObject)
-return;
+// The media controls script must provide a method on the Controller object with the following details.
+// Name: updateCaptionContainer
+// Parameters:
+// None
+// Return value:
+// None
+auto methodValue = controllerObject->get(, JSC::Identifier::fromString(, "updateCaptionContainer"));
+
[webkit-changes] [238581] trunk/JSTests
Title: [238581] trunk/JSTests
Revision 238581
Author mark@apple.com
Date 2018-11-27 15:23:42 -0800 (Tue, 27 Nov 2018)
Log Message
[Re-landing] NaNs read from Wasm code needs to be be purified.
https://bugs.webkit.org/show_bug.cgi?id=191056
Reviewed by Filip Pizlo.
* wasm/regress/regress-191056.js: Added.
Modified Paths
trunk/JSTests/ChangeLog
Added Paths
trunk/JSTests/wasm/regress/regress-191056.js
Diff
Modified: trunk/JSTests/ChangeLog (238580 => 238581)
--- trunk/JSTests/ChangeLog 2018-11-27 23:20:25 UTC (rev 238580)
+++ trunk/JSTests/ChangeLog 2018-11-27 23:23:42 UTC (rev 238581)
@@ -1,3 +1,13 @@
+2018-11-27 Mark Lam
+
+[Re-landing] NaNs read from Wasm code needs to be be purified.
+https://bugs.webkit.org/show_bug.cgi?id=191056
+
+
+Reviewed by Filip Pizlo.
+
+* wasm/regress/regress-191056.js: Added.
+
2018-11-27 Ryan Haddad
Unreviewed, rolling out r238509.
Added: trunk/JSTests/wasm/regress/regress-191056.js (0 => 238581)
--- trunk/JSTests/wasm/regress/regress-191056.js (rev 0)
+++ trunk/JSTests/wasm/regress/regress-191056.js 2018-11-27 23:23:42 UTC (rev 238581)
@@ -0,0 +1,15 @@
+var importObject = {
+env: {
+print_number: function (number) {
+print('[+] importObject callback.');
+print(number);
+}
+}
+};
+var wasmCode = new Uint8Array([0x0,0x61,0x73,0x6d,0x1,0x0,0x0,0x0,0x1,0x7,0x1,0x60,0x2,0x7e,0x7f,0x1,0x7f,0x3,0x2,0x1,0x0,0x4,0x4,0x1,0x70,0x0,0x4,0x6,0x2e,0x5,0x7f,0x0,0x41,0x2a,0xb,0x7d,0x0,0x43,0x74,0x0,0x0,0x4d,0xb,0x7c,0x0,0x44,0x83,0x88,0x88,0x00,0x0,0x0,0xff,0xff,0xb,0x7d,0x0,0x43,0x0,0x0,0x9,0x7f,0xb,0x7c,0x0,0x44,0x0,0x3c,0x0,0x0,0x0,0x0,0xf8,0x7f,0xb,0x7,0x40,0x7,0x5,0x74,0x61,0x62,0x3f,0x45,0x1,0x0,0x3,0x7d,0x75,0x6d,0x0,0x0,0x6,0x61,0x3d,0x22,0x0,0xd,0x72,0x3,0x0,0x7,0x4f,0x7c,0x68,0x77,0x65,0x20,0x31,0x3,0x1,0x7,0x41,0x41,0x41,0x41,0x41,0x41,0x41,0x3,0x2,0x7,0x61,0x6e,0x73,0x77,0x65,0x72,0x3c,0x3,0x3,0x7,0x61,0x6e,0x73,0x77,0x65,0x72,0x34,0x3,0x4,0x9,0x7,0x1,0x0,0x41,0x0,0xb,0x1,0x0,0xa,0x9,0x1,0x7,0x0,0x20,0x1,0x0,0x1,0x0,0xb,]);
+var wasmModule = new WebAssembly.Module(wasmCode);
+var wasmInstance = new WebAssembly.Instance(wasmModule, importObject);
+
+var res = wasmInstance.exports.AAA;
+res = res + 'string';
+
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [238580] trunk/Source/WebKit
Title: [238580] trunk/Source/WebKit
Revision 238580
Author timothy_hor...@apple.com
Date 2018-11-27 15:20:25 -0800 (Tue, 27 Nov 2018)
Log Message
WKNavigation.AutomaticViewReloadAfterWebProcessCrash asserts after r238538
https://bugs.webkit.org/show_bug.cgi?id=192038
Reviewed by Wenson Hsieh.
* UIProcess/WebPageProxy.cpp:
(WebKit::m_resetRecentCrashCountTimer):
(WebKit::WebPageProxy::finishAttachingToWebProcess):
(WebKit::WebPageProxy::resetState):
(WebKit::m_editableImageController): Deleted.
Properly invalidate m_editableImageController when resetting WebPageProxy.
Otherwise, the MessageReceiverMaps get invalidated, then later when
EditableImageController goes away we assert trying to remove the receiver.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (238579 => 238580)
--- trunk/Source/WebKit/ChangeLog 2018-11-27 22:40:51 UTC (rev 238579)
+++ trunk/Source/WebKit/ChangeLog 2018-11-27 23:20:25 UTC (rev 238580)
@@ -1,3 +1,20 @@
+2018-11-27 Tim Horton
+
+WKNavigation.AutomaticViewReloadAfterWebProcessCrash asserts after r238538
+https://bugs.webkit.org/show_bug.cgi?id=192038
+
+
+Reviewed by Wenson Hsieh.
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::m_resetRecentCrashCountTimer):
+(WebKit::WebPageProxy::finishAttachingToWebProcess):
+(WebKit::WebPageProxy::resetState):
+(WebKit::m_editableImageController): Deleted.
+Properly invalidate m_editableImageController when resetting WebPageProxy.
+Otherwise, the MessageReceiverMaps get invalidated, then later when
+EditableImageController goes away we assert trying to remove the receiver.
+
2018-11-27 Jiewen Tan
(r238246) [ MacOS Debug ] Layout Test http/wpt/webauthn/ctap-hid-failure.https.html is Crashing
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (238579 => 238580)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2018-11-27 22:40:51 UTC (rev 238579)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2018-11-27 23:20:25 UTC (rev 238580)
@@ -837,6 +837,10 @@
m_credentialsMessenger = std::make_unique(*this);
#endif
+#if HAVE(PENCILKIT)
+m_editableImageController = std::make_unique(*this);
+#endif
+
initializeWebPage(shouldDelayAttachingDrawingArea);
m_inspector->updateForNewPageProcess(this);
@@ -6361,6 +6365,10 @@
m_credentialsMessenger = nullptr;
#endif
+#if HAVE(PENCILKIT)
+m_editableImageController = nullptr;
+#endif
+
CallbackBase::Error error;
switch (resetStateReason) {
case ResetStateReason::NavigationSwap:
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [238579] trunk/Source/WebKit
Title: [238579] trunk/Source/WebKit
Revision 238579
Author jiewen_...@apple.com
Date 2018-11-27 14:40:51 -0800 (Tue, 27 Nov 2018)
Log Message
(r238246) [ MacOS Debug ] Layout Test http/wpt/webauthn/ctap-hid-failure.https.html is Crashing
https://bugs.webkit.org/show_bug.cgi?id=191757
Reviewed by Chris Dumez.
Wrong nonce error causes retransmission, which then trigger wrong nonce error. This is expected
behavior for mock testing. However, the main thread could time out when MockHidConnection::send
is excuting the block on another thread. The block will then return without invoking the callback,
which triggers this WTFCrash. The solution is always invoking the callback before return in the
block.
* UIProcess/WebAuthentication/Mock/MockHidConnection.cpp:
(WebKit::MockHidConnection::send):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidConnection.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (238578 => 238579)
--- trunk/Source/WebKit/ChangeLog 2018-11-27 22:14:56 UTC (rev 238578)
+++ trunk/Source/WebKit/ChangeLog 2018-11-27 22:40:51 UTC (rev 238579)
@@ -1,3 +1,19 @@
+2018-11-27 Jiewen Tan
+
+(r238246) [ MacOS Debug ] Layout Test http/wpt/webauthn/ctap-hid-failure.https.html is Crashing
+https://bugs.webkit.org/show_bug.cgi?id=191757
+
+Reviewed by Chris Dumez.
+
+Wrong nonce error causes retransmission, which then trigger wrong nonce error. This is expected
+behavior for mock testing. However, the main thread could time out when MockHidConnection::send
+is excuting the block on another thread. The block will then return without invoking the callback,
+which triggers this WTFCrash. The solution is always invoking the callback before return in the
+block.
+
+* UIProcess/WebAuthentication/Mock/MockHidConnection.cpp:
+(WebKit::MockHidConnection::send):
+
2018-11-27 Keith Rollin
Better parsing of comments in generate-message*.py
Modified: trunk/Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidConnection.cpp (238578 => 238579)
--- trunk/Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidConnection.cpp 2018-11-27 22:14:56 UTC (rev 238578)
+++ trunk/Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidConnection.cpp 2018-11-27 22:40:51 UTC (rev 238579)
@@ -73,8 +73,10 @@
auto task = BlockPtr::fromCallable([weakThis = makeWeakPtr(*this), data = "" callback = WTFMove(callback)]() mutable {
ASSERT(!RunLoop::isMain());
RunLoop::main().dispatch([weakThis, data = "" callback = WTFMove(callback)]() mutable {
-if (!weakThis)
+if (!weakThis) {
+callback(DataSent::No);
return;
+}
weakThis->assembleRequest(WTFMove(data));
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [238578] trunk/Source/JavaScriptCore
Title: [238578] trunk/Source/_javascript_Core Revision 238578 Author mark@apple.com Date 2018-11-27 14:14:56 -0800 (Tue, 27 Nov 2018) Log Message [Re-landing] NaNs read from Wasm code needs to be be purified. https://bugs.webkit.org/show_bug.cgi?id=191056 Reviewed by Filip Pizlo. * wasm/js/WebAssemblyModuleRecord.cpp: (JSC::WebAssemblyModuleRecord::link): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/wasm/js/WebAssemblyModuleRecord.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (238577 => 238578) --- trunk/Source/_javascript_Core/ChangeLog 2018-11-27 22:12:53 UTC (rev 238577) +++ trunk/Source/_javascript_Core/ChangeLog 2018-11-27 22:14:56 UTC (rev 238578) @@ -1,3 +1,14 @@ +2018-11-27 Mark Lam + +[Re-landing] NaNs read from Wasm code needs to be be purified. +https://bugs.webkit.org/show_bug.cgi?id=191056 + + +Reviewed by Filip Pizlo. + +* wasm/js/WebAssemblyModuleRecord.cpp: +(JSC::WebAssemblyModuleRecord::link): + 2018-11-27 Timothy Hatcher Web Inspector: Add support for forcing color scheme appearance in DOM tree. Modified: trunk/Source/_javascript_Core/wasm/js/WebAssemblyModuleRecord.cpp (238577 => 238578) --- trunk/Source/_javascript_Core/wasm/js/WebAssemblyModuleRecord.cpp 2018-11-27 22:12:53 UTC (rev 238577) +++ trunk/Source/_javascript_Core/wasm/js/WebAssemblyModuleRecord.cpp 2018-11-27 22:14:56 UTC (rev 238578) @@ -388,11 +388,11 @@ return; case Wasm::F32: -exportedValue = JSValue(m_instance->instance().loadF32Global(exp.kindIndex)); +exportedValue = jsNumber(purifyNaN(m_instance->instance().loadF32Global(exp.kindIndex))); break; case Wasm::F64: -exportedValue = JSValue(m_instance->instance().loadF64Global(exp.kindIndex)); +exportedValue = jsNumber(purifyNaN(m_instance->instance().loadF64Global(exp.kindIndex))); break; default: ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [238577] trunk/Source/WebKit
Title: [238577] trunk/Source/WebKit
Revision 238577
Author krol...@apple.com
Date 2018-11-27 14:12:53 -0800 (Tue, 27 Nov 2018)
Log Message
Better parsing of comments in generate-message*.py
https://bugs.webkit.org/show_bug.cgi?id=191866
Reviewed by Chris Dumez.
The script parsing the *.messages.in files would treat a line starting
with '#' as a comment, but not a line starting with '#'.
This means that jamming a '#' right in front of the first character of
a message definition (as opposed to the beginning of a line) will have
no effect and the line will get treated just the same as a
non-commented line. Fix this by trimming all white space from the
beginning and ending of the line before processing it.
* Scripts/webkit/parser.py:
(parse):
* Scripts/webkit/test-messages.in:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Scripts/webkit/parser.py
trunk/Source/WebKit/Scripts/webkit/test-messages.in
Diff
Modified: trunk/Source/WebKit/ChangeLog (238576 => 238577)
--- trunk/Source/WebKit/ChangeLog 2018-11-27 22:03:19 UTC (rev 238576)
+++ trunk/Source/WebKit/ChangeLog 2018-11-27 22:12:53 UTC (rev 238577)
@@ -1,3 +1,23 @@
+2018-11-27 Keith Rollin
+
+Better parsing of comments in generate-message*.py
+https://bugs.webkit.org/show_bug.cgi?id=191866
+
+
+Reviewed by Chris Dumez.
+
+The script parsing the *.messages.in files would treat a line starting
+with '#' as a comment, but not a line starting with '#'.
+This means that jamming a '#' right in front of the first character of
+a message definition (as opposed to the beginning of a line) will have
+no effect and the line will get treated just the same as a
+non-commented line. Fix this by trimming all white space from the
+beginning and ending of the line before processing it.
+
+* Scripts/webkit/parser.py:
+(parse):
+* Scripts/webkit/test-messages.in:
+
2018-11-27 Thibault Saunier
[GTK|WPE] Allow disabling WebRTC unified plan SDP through an env var
Modified: trunk/Source/WebKit/Scripts/webkit/parser.py (238576 => 238577)
--- trunk/Source/WebKit/Scripts/webkit/parser.py 2018-11-27 22:03:19 UTC (rev 238576)
+++ trunk/Source/WebKit/Scripts/webkit/parser.py 2018-11-27 22:12:53 UTC (rev 238577)
@@ -50,6 +50,7 @@
master_condition = None
superclass = []
for line in file:
+line = line.strip()
match = re.search(r'messages -> (?P[A-Za-z_0-9]+) \s*(?::\s*(?P.*?) \s*)?(?:(?P.*?)\s+)?{', line)
if match:
receiver_attributes = parse_attributes_string(match.group('attributes'))
@@ -61,13 +62,12 @@
destination = match.group('destination')
continue
if line.startswith('#'):
-trimmed = line.rstrip()
if line.startswith('#if '):
-conditions.append(trimmed[4:])
+conditions.append(line[4:])
elif line.startswith('#endif') and conditions:
conditions.pop()
elif line.startswith('#else') or line.startswith('#elif'):
-raise Exception("ERROR: '%s' is not supported in the *.in files" % trimmed)
+raise Exception("ERROR: '%s' is not supported in the *.in files" % line)
continue
match = re.search(r'([A-Za-z_0-9]+)\((.*?)\)(?:(?:\s+->\s+)\((.*?)\))?(?:\s+(.*))?', line)
if match:
Modified: trunk/Source/WebKit/Scripts/webkit/test-messages.in (238576 => 238577)
--- trunk/Source/WebKit/Scripts/webkit/test-messages.in 2018-11-27 22:03:19 UTC (rev 238576)
+++ trunk/Source/WebKit/Scripts/webkit/test-messages.in 2018-11-27 22:12:53 UTC (rev 238577)
@@ -23,6 +23,13 @@
#if ENABLE(WEBKIT2)
#if NESTED_MASTER_CONDITION || MASTER_OR && MASTER_AND
+
+# The parser should treat all of these as comments
+#FakeLoadURLA(String url)
+# FakeLoadURLB(String url)
+#FakeLoadURLC(String url)
+# FakeLoadURLD(String url)
+
messages -> WebPage {
LoadURL(String url)
#if ENABLE(TOUCH_EVENTS)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [238576] trunk
Title: [238576] trunk Revision 238576 Author simon.fra...@apple.com Date 2018-11-27 14:03:19 -0800 (Tue, 27 Nov 2018) Log Message Momentum scrolling ends at the wrong place when a scrolling overflow element has a non-zero border https://bugs.webkit.org/show_bug.cgi?id=191322 Reviewed by Dean Jackson. Source/WebCore: The scrolling momentum logic in ScrollController::handleWheelEvent() which computes whether the scroll is pinned to the end makes use of ScrollableArea::visibleContentRect(). RenderLayer's implementation of this was incorrect when the layer's element had borders, causing the momentum scroll to stop early. Fix by using the correct size (visible size, not layer size). Test: fast/scrolling/momentum-scroll-with-borders.html * rendering/RenderLayer.cpp: (WebCore::RenderLayer::visibleContentRectInternal const): LayoutTests: * fast/scrolling/momentum-scroll-with-borders-expected.txt: Added. * fast/scrolling/momentum-scroll-with-borders.html: Added. * platform/ios/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/accessibility/ios-simulator/scroll-in-overflow-div-expected.txt trunk/LayoutTests/platform/ios/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderLayer.cpp Added Paths trunk/LayoutTests/fast/scrolling/momentum-scroll-with-borders-expected.txt trunk/LayoutTests/fast/scrolling/momentum-scroll-with-borders.html Diff Modified: trunk/LayoutTests/ChangeLog (238575 => 238576) --- trunk/LayoutTests/ChangeLog 2018-11-27 21:50:03 UTC (rev 238575) +++ trunk/LayoutTests/ChangeLog 2018-11-27 22:03:19 UTC (rev 238576) @@ -1,5 +1,16 @@ 2018-11-27 Simon Fraser +Momentum scrolling ends at the wrong place when a scrolling overflow element has a non-zero border +https://bugs.webkit.org/show_bug.cgi?id=191322 + +Reviewed by Dean Jackson. + +* fast/scrolling/momentum-scroll-with-borders-expected.txt: Added. +* fast/scrolling/momentum-scroll-with-borders.html: Added. +* platform/ios/TestExpectations: + +2018-11-27 Simon Fraser + Composited and tiled layers fail to update on scrolling in WebView https://bugs.webkit.org/show_bug.cgi?id=191821 rdar://problem/46009272 Modified: trunk/LayoutTests/accessibility/ios-simulator/scroll-in-overflow-div-expected.txt (238575 => 238576) --- trunk/LayoutTests/accessibility/ios-simulator/scroll-in-overflow-div-expected.txt 2018-11-27 21:50:03 UTC (rev 238575) +++ trunk/LayoutTests/accessibility/ios-simulator/scroll-in-overflow-div-expected.txt 2018-11-27 22:03:19 UTC (rev 238576) @@ -3,41 +3,41 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -AXScrollByPage received: data: AXScroll [position: 0.00 224.00] +AXScrollByPage received: data: AXScroll [position: 0.00 220.00] scroll down 0 : success true -AXScrollByPage received: data: AXScroll [position: 0.00 448.00] +AXScrollByPage received: data: AXScroll [position: 0.00 440.00] scroll down 1 : success true -AXScrollByPage received: data: AXScroll [position: 0.00 672.00] +AXScrollByPage received: data: AXScroll [position: 0.00 660.00] scroll down 2 : success true -AXScrollByPage received: data: AXScroll [position: 0.00 712.00] +AXScrollByPage received: data: AXScroll [position: 0.00 716.00] scroll down 3 : success true scroll down 4 : success false -AXScrollByPage received: data: AXScroll [position: 0.00 488.00] +AXScrollByPage received: data: AXScroll [position: 0.00 496.00] scroll up 0 : success true -AXScrollByPage received: data: AXScroll [position: 0.00 264.00] +AXScrollByPage received: data: AXScroll [position: 0.00 276.00] scroll up 1 : success true -AXScrollByPage received: data: AXScroll [position: 0.00 40.00] +AXScrollByPage received: data: AXScroll [position: 0.00 56.00] scroll up 2 : success true AXScrollByPage received: data: AXScroll [position: 0.00 0.00] scroll up 3 : success true scroll up 4 : success false -AXScrollByPage received: data: AXScroll [position: 424.00 0.00] +AXScrollByPage received: data: AXScroll [position: 420.00 0.00] scroll left 0 : success true -AXScrollByPage received: data: AXScroll [position: 848.00 0.00] +AXScrollByPage received: data: AXScroll [position: 840.00 0.00] scroll left 1 : success true -AXScrollByPage received: data: AXScroll [position: 1272.00 0.00] +AXScrollByPage received: data: AXScroll [position: 1260.00 0.00] scroll left 2 : success true -AXScrollByPage received: data: AXScroll [position: 1696.00 0.00] +AXScrollByPage received: data: AXScroll [position: 1680.00 0.00] scroll left 3 : success true -AXScrollByPage received: data: AXScroll [position: 2120.00 0.00] +AXScrollByPage received: data: AXScroll [position: 2100.00 0.00] scroll left 4 : success true -AXScrollByPage received: data: AXScroll [position: 1696.00 0.00] +AXScrollByPage received: data: AXScroll [position: 1680.00 0.00] scroll right 0 : success true -AXScrollByPage received: data:
[webkit-changes] [238575] trunk
Title: [238575] trunk Revision 238575 Author simon.fra...@apple.com Date 2018-11-27 13:50:03 -0800 (Tue, 27 Nov 2018) Log Message Composited and tiled layers fail to update on scrolling in WebView https://bugs.webkit.org/show_bug.cgi?id=191821 rdar://problem/46009272 Reviewed by Zalan Bujtas. Source/WebCore: We relied on AppKit calling -[NSView viewWillDraw] on scrolling to trigger compositing layer flushes which are necessary to update backing store attachment, and tile coverage for tiled layers. However, we no longer get these reliably in WebView, so explicitly trigger flushes if necessary from FrameView::scrollOffsetChangedViaPlatformWidgetImpl(). didChangeVisibleRect() is the same code path used by iOS UIWebView for the same purpose. Tests: compositing/backing/backing-store-attachment-scroll.html compositing/tiling/tile-coverage-on-scroll.html * page/FrameView.cpp: (WebCore::FrameView::scrollOffsetChangedViaPlatformWidgetImpl): * platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::updateCoverage): LayoutTests: Tests for backing store attachment, and tile coverage before and after scrolling. * compositing/backing/backing-store-attachment-scroll-expected.txt: Added. * compositing/backing/backing-store-attachment-scroll.html: Added. * compositing/tiling/tile-coverage-on-scroll-expected.txt: Added. * compositing/tiling/tile-coverage-on-scroll.html: Added. * platform/mac-wk1/compositing/tiling/tile-coverage-on-scroll-expected.txt: Added. Root isn't tiled on WK1, so different result. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/FrameView.cpp trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp Added Paths trunk/LayoutTests/compositing/backing/backing-store-attachment-scroll-expected.txt trunk/LayoutTests/compositing/backing/backing-store-attachment-scroll.html trunk/LayoutTests/compositing/tiling/tile-coverage-on-scroll-expected.txt trunk/LayoutTests/compositing/tiling/tile-coverage-on-scroll.html trunk/LayoutTests/platform/ios-wk2/compositing/backing/backing-store-attachment-scroll-expected.txt trunk/LayoutTests/platform/ios-wk2/compositing/tiling/tile-coverage-on-scroll-expected.txt trunk/LayoutTests/platform/mac-wk1/compositing/tiling/tile-coverage-on-scroll-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (238574 => 238575) --- trunk/LayoutTests/ChangeLog 2018-11-27 21:48:47 UTC (rev 238574) +++ trunk/LayoutTests/ChangeLog 2018-11-27 21:50:03 UTC (rev 238575) @@ -1,3 +1,19 @@ +2018-11-27 Simon Fraser + +Composited and tiled layers fail to update on scrolling in WebView +https://bugs.webkit.org/show_bug.cgi?id=191821 +rdar://problem/46009272 + +Reviewed by Zalan Bujtas. + +Tests for backing store attachment, and tile coverage before and after scrolling. + +* compositing/backing/backing-store-attachment-scroll-expected.txt: Added. +* compositing/backing/backing-store-attachment-scroll.html: Added. +* compositing/tiling/tile-coverage-on-scroll-expected.txt: Added. +* compositing/tiling/tile-coverage-on-scroll.html: Added. +* platform/mac-wk1/compositing/tiling/tile-coverage-on-scroll-expected.txt: Added. Root isn't tiled on WK1, so different result. + 2018-11-27 Daniel Bates Fix test timeout following Added: trunk/LayoutTests/compositing/backing/backing-store-attachment-scroll-expected.txt (0 => 238575) --- trunk/LayoutTests/compositing/backing/backing-store-attachment-scroll-expected.txt (rev 0) +++ trunk/LayoutTests/compositing/backing/backing-store-attachment-scroll-expected.txt 2018-11-27 21:50:03 UTC (rev 238575) @@ -0,0 +1,71 @@ +Before +(GraphicsLayer + (anchor 0.00 0.00) + (bounds 785.00 2916.00) + (backingStoreAttached 1) + (children 1 +(GraphicsLayer + (bounds 785.00 2916.00) + (contentsOpaque 1) + (backingStoreAttached 1) + (children 3 +(GraphicsLayer + (position 8.00 8.00) + (bounds 300.00 300.00) + (drawsContent 1) + (backingStoreAttached 1) +) +(GraphicsLayer + (position 8.00 1308.00) + (bounds 300.00 300.00) + (drawsContent 1) + (backingStoreAttached 0) +) +(GraphicsLayer + (position 8.00 2608.00) + (bounds 300.00 300.00) + (drawsContent 1) + (backingStoreAttached 0) +) + ) +) + ) +) + + +After +(GraphicsLayer + (anchor 0.00 0.00) + (bounds 785.00 2916.00) + (backingStoreAttached 1) + (children 1 +(GraphicsLayer + (bounds 785.00 2916.00) + (contentsOpaque 1) + (backingStoreAttached 1) + (children 3 +(GraphicsLayer + (position 8.00 8.00) + (bounds 300.00 300.00) + (drawsContent 1) + (backingStoreAttached 0) +) +(GraphicsLayer + (position 8.00 1308.00) +
[webkit-changes] [238574] trunk/Source/WebKit
Title: [238574] trunk/Source/WebKit
Revision 238574
Author commit-qu...@webkit.org
Date 2018-11-27 13:48:47 -0800 (Tue, 27 Nov 2018)
Log Message
[GTK|WPE] Allow disabling WebRTC unified plan SDP through an env var
https://bugs.webkit.org/show_bug.cgi?id=192024
Patch by Thibault Saunier on 2018-11-27
Reviewed by Michael Catanzaro.
* UIProcess/API/glib/WebKitSettings.cpp:
(webKitSettingsConstructed):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (238573 => 238574)
--- trunk/Source/WebKit/ChangeLog 2018-11-27 21:41:38 UTC (rev 238573)
+++ trunk/Source/WebKit/ChangeLog 2018-11-27 21:48:47 UTC (rev 238574)
@@ -1,3 +1,13 @@
+2018-11-27 Thibault Saunier
+
+[GTK|WPE] Allow disabling WebRTC unified plan SDP through an env var
+https://bugs.webkit.org/show_bug.cgi?id=192024
+
+Reviewed by Michael Catanzaro.
+
+* UIProcess/API/glib/WebKitSettings.cpp:
+(webKitSettingsConstructed):
+
2018-11-27 Alexey Proskuryakov
Modernize the check for async _saveCookies existence
Modified: trunk/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp (238573 => 238574)
--- trunk/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp 2018-11-27 21:41:38 UTC (rev 238573)
+++ trunk/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp 2018-11-27 21:48:47 UTC (rev 238574)
@@ -178,6 +178,9 @@
WebPreferences* prefs = settings->priv->preferences.get();
prefs->setShouldRespectImageOrientation(true);
+if (g_getenv("WEBKIT_WEBRTC_DISABLE_UNIFIED_PLAN"))
+prefs->setWebRTCUnifiedPlanEnabled(FALSE);
+
bool mediaStreamEnabled = prefs->mediaStreamEnabled();
prefs->setMediaDevicesEnabled(mediaStreamEnabled);
prefs->setPeerConnectionEnabled(mediaStreamEnabled);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [238573] tags/Safari-607.1.14.4/Source/JavaScriptCore
Title: [238573] tags/Safari-607.1.14.4/Source/_javascript_Core Revision 238573 Author alanc...@apple.com Date 2018-11-27 13:41:38 -0800 (Tue, 27 Nov 2018) Log Message Cherry-pick r238564. rdar://problem/45494310 Introducing a ENABLE_SEPARATED_WX_HEAP macro. https://bugs.webkit.org/show_bug.cgi?id=192013 Reviewed by Keith Miller. This makes the code a little more readable. I put the definition of ENABLE_SEPARATED_WX_HEAP in JSC's config.h instead of Platform.h because ENABLE_SEPARATED_WX_HEAP is only needed inside JSC. Also, ENABLE_SEPARATED_WX_HEAP depends on ENABLE(FAST_JIT_PERMISSIONS), which is only defined for JSC. * config.h: * jit/ExecutableAllocator.cpp: (JSC::FixedVMPoolExecutableAllocator::FixedVMPoolExecutableAllocator): (JSC::FixedVMPoolExecutableAllocator::initializeSeparatedWXHeaps): * jit/ExecutableAllocator.h: (JSC::performJITMemcpy): * runtime/Options.cpp: (JSC::recomputeDependentOptions): git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238564 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths tags/Safari-607.1.14.4/Source/_javascript_Core/ChangeLog tags/Safari-607.1.14.4/Source/_javascript_Core/config.h tags/Safari-607.1.14.4/Source/_javascript_Core/jit/ExecutableAllocator.cpp tags/Safari-607.1.14.4/Source/_javascript_Core/jit/ExecutableAllocator.h tags/Safari-607.1.14.4/Source/_javascript_Core/runtime/Options.cpp Diff Modified: tags/Safari-607.1.14.4/Source/_javascript_Core/ChangeLog (238572 => 238573) --- tags/Safari-607.1.14.4/Source/_javascript_Core/ChangeLog 2018-11-27 21:29:29 UTC (rev 238572) +++ tags/Safari-607.1.14.4/Source/_javascript_Core/ChangeLog 2018-11-27 21:41:38 UTC (rev 238573) @@ -1,3 +1,57 @@ +2018-11-27 Alan Coon + +Cherry-pick r238564. rdar://problem/45494310 + +Introducing a ENABLE_SEPARATED_WX_HEAP macro. +https://bugs.webkit.org/show_bug.cgi?id=192013 + + +Reviewed by Keith Miller. + +This makes the code a little more readable. + +I put the definition of ENABLE_SEPARATED_WX_HEAP in JSC's config.h instead of +Platform.h because ENABLE_SEPARATED_WX_HEAP is only needed inside JSC. Also, +ENABLE_SEPARATED_WX_HEAP depends on ENABLE(FAST_JIT_PERMISSIONS), which is only +defined for JSC. + +* config.h: +* jit/ExecutableAllocator.cpp: +(JSC::FixedVMPoolExecutableAllocator::FixedVMPoolExecutableAllocator): +(JSC::FixedVMPoolExecutableAllocator::initializeSeparatedWXHeaps): +* jit/ExecutableAllocator.h: +(JSC::performJITMemcpy): +* runtime/Options.cpp: +(JSC::recomputeDependentOptions): + + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238564 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2018-11-27 Mark Lam + +Introducing a ENABLE_SEPARATED_WX_HEAP macro. +https://bugs.webkit.org/show_bug.cgi?id=192013 + + +Reviewed by Keith Miller. + +This makes the code a little more readable. + +I put the definition of ENABLE_SEPARATED_WX_HEAP in JSC's config.h instead of +Platform.h because ENABLE_SEPARATED_WX_HEAP is only needed inside JSC. Also, +ENABLE_SEPARATED_WX_HEAP depends on ENABLE(FAST_JIT_PERMISSIONS), which is only +defined for JSC. + +* config.h: +* jit/ExecutableAllocator.cpp: +(JSC::FixedVMPoolExecutableAllocator::FixedVMPoolExecutableAllocator): +(JSC::FixedVMPoolExecutableAllocator::initializeSeparatedWXHeaps): +* jit/ExecutableAllocator.h: +(JSC::performJITMemcpy): +* runtime/Options.cpp: +(JSC::recomputeDependentOptions): + 2018-11-13 Saam Barati ProxyObject should check for VMInquiry and return early before throwing a stack overflow exception Modified: tags/Safari-607.1.14.4/Source/_javascript_Core/config.h (238572 => 238573) --- tags/Safari-607.1.14.4/Source/_javascript_Core/config.h 2018-11-27 21:29:29 UTC (rev 238572) +++ tags/Safari-607.1.14.4/Source/_javascript_Core/config.h 2018-11-27 21:41:38 UTC (rev 238573) @@ -1,5 +1,5 @@ /* - * Copyright (C) 2006, 2007, 2008, 2013 Apple Inc. All rights reserved. + * Copyright (C) 2006-2018 Apple Inc. All rights reserved. * Copyright (C) 2006 Samuel Weinig * * This library is free software; you can redistribute it and/or @@ -37,3 +37,11 @@ #endif #include + +#if !defined(ENABLE_SEPARATED_WX_HEAP) +#if (!ENABLE(FAST_JIT_PERMISSIONS) || !CPU(ARM64E)) && PLATFORM(IOS_FAMILY) && CPU(ARM64) +#define ENABLE_SEPARATED_WX_HEAP 1 +#else +#define ENABLE_SEPARATED_WX_HEAP 0 +#endif +#endif // !defined(ENABLE_SEPARATED_WX_HEAP) Modified: tags/Safari-607.1.14.4/Source/_javascript_Core/jit/ExecutableAllocator.cpp (238572 => 238573) --- tags/Safari-607.1.14.4/Source/_javascript_Core/jit/ExecutableAllocator.cpp 2018-11-27 21:29:29 UTC (rev 238572) +++
[webkit-changes] [238572] branches/safari-606-branch
Title: [238572] branches/safari-606-branch
Revision 238572
Author alanc...@apple.com
Date 2018-11-27 13:29:29 -0800 (Tue, 27 Nov 2018)
Log Message
Apply patch. rdar://problem/46259202
Modified Paths
branches/safari-606-branch/Source/_javascript_Core/jit/ExecutableAllocator.cpp
branches/safari-606-branch/Source/_javascript_Core/jit/ExecutableAllocator.h
branches/safari-606-branch/Source/WebKit/Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h
branches/safari-606-branch/Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.cpp
branches/safari-606-branch/Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.h
branches/safari-606-branch/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
branches/safari-606-branch/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h
branches/safari-606-branch/Source/WebKit/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h
branches/safari-606-branch/Source/WebKit/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm
branches/safari-606-branch/Source/WebKit/UIProcess/Launcher/ProcessLauncher.h
branches/safari-606-branch/Source/WebKit/UIProcess/Launcher/mac/ProcessLauncherMac.mm
branches/safari-606-branch/Source/WebKit/UIProcess/WebPageProxy.cpp
branches/safari-606-branch/Source/WebKit/UIProcess/WebPageProxy.h
branches/safari-606-branch/Source/WebKit/UIProcess/WebProcessProxy.cpp
branches/safari-606-branch/Source/WebKit/UIProcess/WebProcessProxy.h
branches/safari-606-branch/Source/WebKit/WebProcess/WebProcess.cpp
branches/safari-606-branch/Source/WebKit/WebProcess/WebProcess.h
branches/safari-606-branch/Source/WebKit/WebProcess/WebProcess.messages.in
branches/safari-606-branch/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
Added Paths
branches/safari-606-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/JITEnabled.mm
Diff
Modified: branches/safari-606-branch/Source/_javascript_Core/jit/ExecutableAllocator.cpp (238571 => 238572)
--- branches/safari-606-branch/Source/_javascript_Core/jit/ExecutableAllocator.cpp 2018-11-27 21:22:35 UTC (rev 238571)
+++ branches/safari-606-branch/Source/_javascript_Core/jit/ExecutableAllocator.cpp 2018-11-27 21:29:29 UTC (rev 238572)
@@ -114,15 +114,42 @@
static uintptr_t startOfFixedWritableMemoryPool;
#endif
-static bool allowJIT()
+class FixedVMPoolExecutableAllocator;
+static FixedVMPoolExecutableAllocator* allocator = nullptr;
+static ExecutableAllocator* executableAllocator = nullptr;
+
+static bool s_isJITEnabled = true;
+static bool isJITEnabled()
{
#if PLATFORM(IOS) && (CPU(ARM64) || CPU(ARM))
-return processHasEntitlement("dynamic-codesigning");
+return processHasEntitlement("dynamic-codesigning") && s_isJITEnabled;
#else
-return true;
+return s_isJITEnabled;
#endif
}
+void ExecutableAllocator::setJITEnabled(bool enabled)
+{
+ASSERT(!allocator);
+if (s_isJITEnabled == enabled)
+return;
+s_isJITEnabled = enabled;
+
+#if PLATFORM(IOS_FAMILY) && (CPU(ARM64) || CPU(ARM))
+if (!enabled) {
+constexpr size_t size = 1;
+constexpr int protection = PROT_READ | PROT_WRITE | PROT_EXEC;
+constexpr int flags = MAP_PRIVATE | MAP_ANON | MAP_JIT;
+constexpr int fd = OSAllocator::JSJITCodePages;
+void* allocation = mmap(nullptr, size, protection, flags, fd, 0);
+const void* executableMemoryAllocationFailure = reinterpret_cast(-1);
+RELEASE_ASSERT_WITH_MESSAGE(allocation && allocation != executableMemoryAllocationFailure, "We should not have allocated executable memory before disabling the JIT.");
+RELEASE_ASSERT_WITH_MESSAGE(!munmap(allocation, size), "Unmapping executable memory should succeed so we do not have any executable memory in the address space");
+RELEASE_ASSERT_WITH_MESSAGE(mmap(nullptr, size, protection, flags, fd, 0) == executableMemoryAllocationFailure, "Allocating executable memory should fail after setJITEnabled(false) is called.");
+}
+#endif
+}
+
class FixedVMPoolExecutableAllocator : public MetaAllocator {
WTF_MAKE_FAST_ALLOCATED;
public:
@@ -129,7 +156,7 @@
FixedVMPoolExecutableAllocator()
: MetaAllocator(jitAllocationGranule) // round up all allocations to 32 bytes
{
-if (!allowJIT())
+if (!isJITEnabled())
return;
size_t reservationSize;
@@ -350,9 +377,6 @@
PageReservation m_reservation;
};
-static FixedVMPoolExecutableAllocator* allocator;
-static ExecutableAllocator* executableAllocator;
-
void ExecutableAllocator::initializeAllocator()
{
ASSERT(!allocator);
Modified: branches/safari-606-branch/Source/_javascript_Core/jit/ExecutableAllocator.h (238571 => 238572)
--- branches/safari-606-branch/Source/_javascript_Core/jit/ExecutableAllocator.h 2018-11-27 21:22:35 UTC (rev 238571)
+++ branches/safari-606-branch/Source/_javascript_Core/jit/ExecutableAllocator.h 2018-11-27 21:29:29 UTC (rev 238572)
@@ -130,6 +130,8 @@
static void dumpProfile() { }
#endif
+JS_EXPORT_PRIVATE static
[webkit-changes] [238571] trunk/LayoutTests
Title: [238571] trunk/LayoutTests
Revision 238571
Author dba...@webkit.org
Date 2018-11-27 13:22:35 -0800 (Tue, 27 Nov 2018)
Log Message
Fix test timeout following
(https://bugs.webkit.org/show_bug.cgi?id=191969)
Actually call HTMLInputElement.setSelectionRange().
* fast/forms/auto-fill-button/caps-lock-indicator-should-be-visible-after-hiding-auto-fill-strong-password-button-expected.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/forms/auto-fill-button/caps-lock-indicator-should-be-visible-after-hiding-auto-fill-strong-password-button-expected.html
Diff
Modified: trunk/LayoutTests/ChangeLog (238570 => 238571)
--- trunk/LayoutTests/ChangeLog 2018-11-27 21:16:07 UTC (rev 238570)
+++ trunk/LayoutTests/ChangeLog 2018-11-27 21:22:35 UTC (rev 238571)
@@ -1,3 +1,12 @@
+2018-11-27 Daniel Bates
+
+Fix test timeout following
+(https://bugs.webkit.org/show_bug.cgi?id=191969)
+
+Actually call HTMLInputElement.setSelectionRange().
+
+* fast/forms/auto-fill-button/caps-lock-indicator-should-be-visible-after-hiding-auto-fill-strong-password-button-expected.html:
+
2018-11-27 Timothy Hatcher
Web Inspector: Add support for forcing color scheme appearance in DOM tree.
Modified: trunk/LayoutTests/fast/forms/auto-fill-button/caps-lock-indicator-should-be-visible-after-hiding-auto-fill-strong-password-button-expected.html (238570 => 238571)
--- trunk/LayoutTests/fast/forms/auto-fill-button/caps-lock-indicator-should-be-visible-after-hiding-auto-fill-strong-password-button-expected.html 2018-11-27 21:16:07 UTC (rev 238570)
+++ trunk/LayoutTests/fast/forms/auto-fill-button/caps-lock-indicator-should-be-visible-after-hiding-auto-fill-strong-password-button-expected.html 2018-11-27 21:22:35 UTC (rev 238571)
@@ -21,7 +21,7 @@
{
console.assert(event.key === "CapsLock");
// Move the caret to the beginning of the field to ensure consistent test results.
-input.setSelectionRange(0, 0);
+document.querySelector("input").setSelectionRange(0, 0);
// FIXME: For some reason it takes up to 100ms for the caps lock indicator to be painted (why?).
window.setTimeout(done, 100);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [238570] trunk
Title: [238570] trunk Revision 238570 Author timo...@apple.com Date 2018-11-27 13:16:07 -0800 (Tue, 27 Nov 2018) Log Message Web Inspector: Add support for forcing color scheme appearance in DOM tree. https://bugs.webkit.org/show_bug.cgi?id=191820 rdar://problem/46153172 Reviewed by Devin Rousso. Source/_javascript_Core: * inspector/protocol/Page.json: Added setForcedAppearance. Also added the defaultAppearanceDidChange event and Appearance enum. Source/WebCore: Test: inspector/css/force-page-appearance.html * inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::defaultAppearanceDidChangeImpl): * inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::defaultAppearanceDidChange): * inspector/agents/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::enable): Fire defaultAppearanceDidChange() on macOS Majave. (WebCore::InspectorPageAgent::disable): Call setForcedAppearance() with empty string. (WebCore::InspectorPageAgent::defaultAppearanceDidChange): Added. (WebCore::InspectorPageAgent::setForcedAppearance): Added. * inspector/agents/InspectorPageAgent.h: * page/Page.cpp: (WebCore::Page::setUseDarkAppearance): Call InspectorInstrumentation::defaultAppearanceDidChange(). (WebCore::Page::useDarkAppearance const): Return override value if not nullopt. (WebCore::Page::setUseDarkAppearanceOverride): Added. * page/Page.h: (WebCore::Page::defaultUseDarkAppearance const): Added. Source/WebInspectorUI: * Localizations/en.lproj/localizedStrings.js: Updated. * UserInterface/Controllers/CSSManager.js: (WI.CSSManager): (WI.CSSManager.prototype.get defaultAppearance): Added. (WI.CSSManager.prototype.get forcedAppearance): Added. (WI.CSSManager.prototype.set forcedAppearance): Added. (WI.CSSManager.prototype.canForceAppearance): Added. (WI.CSSManager.prototype.defaultAppearanceDidChange): Added. * UserInterface/Images/Appearance.svg: Added. * UserInterface/Protocol/PageObserver.js: (WI.PageObserver.prototype.defaultAppearanceChanged): Added. * UserInterface/Views/DOMTreeContentView.js: (WI.DOMTreeContentView): (WI.DOMTreeContentView.prototype.get navigationItems): (WI.DOMTreeContentView.prototype._defaultAppearanceDidChange): Added. (WI.DOMTreeContentView.prototype._toggleAppearance): Added. LayoutTests: * TestExpectations: Skip dark mode tests on other platforms. * inspector/css/force-page-appearance-expected.txt: Added. * inspector/css/force-page-appearance.html: Added. * platform/mac/TestExpectations: Expect dark mode tests to pass on Mojave and later. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/platform/mac/TestExpectations trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/inspector/protocol/Page.json trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp trunk/Source/WebCore/inspector/InspectorInstrumentation.h trunk/Source/WebCore/inspector/agents/InspectorPageAgent.cpp trunk/Source/WebCore/inspector/agents/InspectorPageAgent.h trunk/Source/WebCore/page/Page.cpp trunk/Source/WebCore/page/Page.h trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js trunk/Source/WebInspectorUI/UserInterface/Controllers/CSSManager.js trunk/Source/WebInspectorUI/UserInterface/Protocol/PageObserver.js trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js Added Paths trunk/LayoutTests/inspector/css/force-page-appearance-expected.txt trunk/LayoutTests/inspector/css/force-page-appearance.html trunk/Source/WebInspectorUI/UserInterface/Images/Appearance.svg Diff Modified: trunk/LayoutTests/ChangeLog (238569 => 238570) --- trunk/LayoutTests/ChangeLog 2018-11-27 21:06:52 UTC (rev 238569) +++ trunk/LayoutTests/ChangeLog 2018-11-27 21:16:07 UTC (rev 238570) @@ -1,3 +1,16 @@ +2018-11-27 Timothy Hatcher + +Web Inspector: Add support for forcing color scheme appearance in DOM tree. +https://bugs.webkit.org/show_bug.cgi?id=191820 +rdar://problem/46153172 + +Reviewed by Devin Rousso. + +* TestExpectations: Skip dark mode tests on other platforms. +* inspector/css/force-page-appearance-expected.txt: Added. +* inspector/css/force-page-appearance.html: Added. +* platform/mac/TestExpectations: Expect dark mode tests to pass on Mojave and later. + 2018-11-27 Tim Horton Serialize and deserialize editable image strokes Modified: trunk/LayoutTests/TestExpectations (238569 => 238570) --- trunk/LayoutTests/TestExpectations 2018-11-27 21:06:52 UTC (rev 238569) +++ trunk/LayoutTests/TestExpectations 2018-11-27 21:16:07 UTC (rev 238570) @@ -74,7 +74,9 @@ fast/xmlhttprequest/set-dangerous-headers-in-dashboard.html [ WontFix ] # Only applicable on macOS +css-dark-mode [ Skip ] fast/css/apple-system-control-colors.html [ Skip ] +inspector/css/force-page-appearance.html [ Skip ] # Only Mac supports force tests.
[webkit-changes] [238569] trunk/Source/WebInspectorUI
Title: [238569] trunk/Source/WebInspectorUI
Revision 238569
Author mattba...@apple.com
Date 2018-11-27 13:06:52 -0800 (Tue, 27 Nov 2018)
Log Message
Web Inspector: Cookies table needs copy keyboard shortcut and context menu support
https://bugs.webkit.org/show_bug.cgi?id=191482
Reviewed by Joseph Pecoraro.
* UserInterface/Views/CookieStorageContentView.js:
(WI.CookieStorageContentView.prototype.handleCopyEvent):
(WI.CookieStorageContentView.prototype.tableCellContextMenuClicked):
As with Delete, if the target row is selected, all selected rows are copied.
Otherwise only the target row is copied. This distinction will be surfaced
in the UI in https://webkit.org/b/191095.
(WI.CookieStorageContentView.prototype.tablePopulateCell):
(WI.CookieStorageContentView.prototype._cookiesAtIndexes):
(WI.CookieStorageContentView.prototype._formatCookiesAsText):
(WI.CookieStorageContentView.prototype._formatCookiePropertyForColumn):
(WI.CookieStorageContentView):
Break Cookie property formatting into a helper method, which is used for
formatting Table cells and creating plain text for the clipboard.
* UserInterface/Views/Table.js:
(WI.Table.prototype.get columns):
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js
trunk/Source/WebInspectorUI/UserInterface/Views/Table.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (238568 => 238569)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-11-27 21:03:29 UTC (rev 238568)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-11-27 21:06:52 UTC (rev 238569)
@@ -1,5 +1,31 @@
2018-11-27 Matt Baker
+Web Inspector: Cookies table needs copy keyboard shortcut and context menu support
+https://bugs.webkit.org/show_bug.cgi?id=191482
+
+
+Reviewed by Joseph Pecoraro.
+
+* UserInterface/Views/CookieStorageContentView.js:
+(WI.CookieStorageContentView.prototype.handleCopyEvent):
+(WI.CookieStorageContentView.prototype.tableCellContextMenuClicked):
+As with Delete, if the target row is selected, all selected rows are copied.
+Otherwise only the target row is copied. This distinction will be surfaced
+in the UI in https://webkit.org/b/191095.
+
+(WI.CookieStorageContentView.prototype.tablePopulateCell):
+(WI.CookieStorageContentView.prototype._cookiesAtIndexes):
+(WI.CookieStorageContentView.prototype._formatCookiesAsText):
+(WI.CookieStorageContentView.prototype._formatCookiePropertyForColumn):
+(WI.CookieStorageContentView):
+Break Cookie property formatting into a helper method, which is used for
+formatting Table cells and creating plain text for the clipboard.
+
+* UserInterface/Views/Table.js:
+(WI.Table.prototype.get columns):
+
+2018-11-27 Matt Baker
+
Web Inspector: Table selection should be handled by a SelectionController
https://bugs.webkit.org/show_bug.cgi?id=191977
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js (238568 => 238569)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js 2018-11-27 21:03:29 UTC (rev 238568)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js 2018-11-27 21:06:52 UTC (rev 238569)
@@ -59,6 +59,20 @@
return [this._table.scrollContainer];
}
+handleCopyEvent(event)
+{
+if (!this._table || !this._table.selectedRows.length)
+return;
+
+let cookies = this._cookiesAtIndexes(this._table.selectedRows);
+if (!cookies.length)
+return;
+
+event.clipboardData.setData("text/plain", this._formatCookiesAsText(cookies));
+event.stopPropagation();
+event.preventDefault();
+}
+
// Table dataSource
tableNumberOfRows(table)
@@ -84,6 +98,17 @@
let contextMenu = WI.ContextMenu.createFromEvent(event);
contextMenu.appendSeparator();
+contextMenu.appendItem(WI.UIString("Copy"), () => {
+let rowIndexes;
+if (table.isRowSelected(rowIndex))
+rowIndexes = table.selectedRows;
+else
+rowIndexes = [rowIndex];
+
+let cookies = this._cookiesAtIndexes(rowIndexes);
+InspectorFrontendHost.copyText(this._formatCookiesAsText(cookies));
+});
+
contextMenu.appendItem(WI.UIString("Delete"), () => {
if (table.isRowSelected(rowIndex))
table.removeSelectedRows();
@@ -117,39 +142,7 @@
tablePopulateCell(table, cell, column, rowIndex)
{
let cookie = this._cookies[rowIndex];
-
-const checkmark = "\u2713";
-
-switch (column.identifier) {
-case "name":
-cell.textContent = cookie.name;
-break;
-case "value":
-cell.textContent = cookie.value;
-break;
-
[webkit-changes] [238568] trunk
Title: [238568] trunk
Revision 238568
Author ryanhad...@apple.com
Date 2018-11-27 13:03:29 -0800 (Tue, 27 Nov 2018)
Log Message
Unreviewed, rolling out r238509.
Causes JSC tests to fail on iOS.
Reverted changeset:
"NaNs read from Wasm code needs to be be purified."
https://bugs.webkit.org/show_bug.cgi?id=191056
https://trac.webkit.org/changeset/238509
Modified Paths
trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wasm/js/WebAssemblyModuleRecord.cpp
Removed Paths
trunk/JSTests/wasm/regress/regress-191056.js
Diff
Modified: trunk/JSTests/ChangeLog (238567 => 238568)
--- trunk/JSTests/ChangeLog 2018-11-27 20:40:40 UTC (rev 238567)
+++ trunk/JSTests/ChangeLog 2018-11-27 21:03:29 UTC (rev 238568)
@@ -1,3 +1,15 @@
+2018-11-27 Ryan Haddad
+
+Unreviewed, rolling out r238509.
+
+Causes JSC tests to fail on iOS.
+
+Reverted changeset:
+
+"NaNs read from Wasm code needs to be be purified."
+https://bugs.webkit.org/show_bug.cgi?id=191056
+https://trac.webkit.org/changeset/238509
+
2018-11-26 Caio Lima
Re-introduce op_bitnot
Deleted: trunk/JSTests/wasm/regress/regress-191056.js (238567 => 238568)
--- trunk/JSTests/wasm/regress/regress-191056.js 2018-11-27 20:40:40 UTC (rev 238567)
+++ trunk/JSTests/wasm/regress/regress-191056.js 2018-11-27 21:03:29 UTC (rev 238568)
@@ -1,15 +0,0 @@
-var importObject = {
-env: {
-print_number: function (number) {
-print('[+] importObject callback.');
-print(number);
-}
-}
-};
-var wasmCode = new Uint8Array([0x0,0x61,0x73,0x6d,0x1,0x0,0x0,0x0,0x1,0x7,0x1,0x60,0x2,0x7e,0x7f,0x1,0x7f,0x3,0x2,0x1,0x0,0x4,0x4,0x1,0x70,0x0,0x4,0x6,0x2e,0x5,0x7f,0x0,0x41,0x2a,0xb,0x7d,0x0,0x43,0x74,0x0,0x0,0x4d,0xb,0x7c,0x0,0x44,0x83,0x88,0x88,0x00,0x0,0x0,0xff,0xff,0xb,0x7d,0x0,0x43,0x0,0x0,0x9,0x7f,0xb,0x7c,0x0,0x44,0x0,0x3c,0x0,0x0,0x0,0x0,0xf8,0x7f,0xb,0x7,0x40,0x7,0x5,0x74,0x61,0x62,0x3f,0x45,0x1,0x0,0x3,0x7d,0x75,0x6d,0x0,0x0,0x6,0x61,0x3d,0x22,0x0,0xd,0x72,0x3,0x0,0x7,0x4f,0x7c,0x68,0x77,0x65,0x20,0x31,0x3,0x1,0x7,0x41,0x41,0x41,0x41,0x41,0x41,0x41,0x3,0x2,0x7,0x61,0x6e,0x73,0x77,0x65,0x72,0x3c,0x3,0x3,0x7,0x61,0x6e,0x73,0x77,0x65,0x72,0x34,0x3,0x4,0x9,0x7,0x1,0x0,0x41,0x0,0xb,0x1,0x0,0xa,0x9,0x1,0x7,0x0,0x20,0x1,0x0,0x1,0x0,0xb,]);
-var wasmModule = new WebAssembly.Module(wasmCode);
-var wasmInstance = new WebAssembly.Instance(wasmModule, importObject);
-
-var res = wasmInstance.exports.AAA;
-res = res + 'string';
-
Modified: trunk/Source/_javascript_Core/ChangeLog (238567 => 238568)
--- trunk/Source/_javascript_Core/ChangeLog 2018-11-27 20:40:40 UTC (rev 238567)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-11-27 21:03:29 UTC (rev 238568)
@@ -1,3 +1,15 @@
+2018-11-27 Ryan Haddad
+
+Unreviewed, rolling out r238509.
+
+Causes JSC tests to fail on iOS.
+
+Reverted changeset:
+
+"NaNs read from Wasm code needs to be be purified."
+https://bugs.webkit.org/show_bug.cgi?id=191056
+https://trac.webkit.org/changeset/238509
+
2018-11-27 Mark Lam
Introducing a ENABLE_SEPARATED_WX_HEAP macro.
Modified: trunk/Source/_javascript_Core/wasm/js/WebAssemblyModuleRecord.cpp (238567 => 238568)
--- trunk/Source/_javascript_Core/wasm/js/WebAssemblyModuleRecord.cpp 2018-11-27 20:40:40 UTC (rev 238567)
+++ trunk/Source/_javascript_Core/wasm/js/WebAssemblyModuleRecord.cpp 2018-11-27 21:03:29 UTC (rev 238568)
@@ -388,11 +388,11 @@
return;
case Wasm::F32:
-exportedValue = jsNumber(purifyNaN(m_instance->instance().loadF32Global(exp.kindIndex)));
+exportedValue = JSValue(m_instance->instance().loadF32Global(exp.kindIndex));
break;
case Wasm::F64:
-exportedValue = jsNumber(purifyNaN(m_instance->instance().loadF64Global(exp.kindIndex)));
+exportedValue = JSValue(m_instance->instance().loadF64Global(exp.kindIndex));
break;
default:
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [238567] trunk/Source
Title: [238567] trunk/Source Revision 238567 Author a...@apple.com Date 2018-11-27 12:40:40 -0800 (Tue, 27 Nov 2018) Log Message Modernize the check for async _saveCookies existence https://bugs.webkit.org/show_bug.cgi?id=191987 Reviewed by Dean Jackson. Source/WebCore/PAL: * pal/spi/cf/CFNetworkSPI.h: Also removed a check around _socketStreamProperties, which exists everywhere. Source/WebKit: * NetworkProcess/cocoa/NetworkProcessCocoa.mm: (WebKit::NetworkProcess::platformSyncAllCookies): Source/WTF: * wtf/Platform.h: Added a specific macro for this. Not changing the behavior here, although it seems very likely that we want to do the same on other iOS family OSes. Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/Platform.h trunk/Source/WebCore/PAL/ChangeLog trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm Diff Modified: trunk/Source/WTF/ChangeLog (238566 => 238567) --- trunk/Source/WTF/ChangeLog 2018-11-27 20:20:18 UTC (rev 238566) +++ trunk/Source/WTF/ChangeLog 2018-11-27 20:40:40 UTC (rev 238567) @@ -1,3 +1,13 @@ +2018-11-27 Alexey Proskuryakov + +Modernize the check for async _saveCookies existence +https://bugs.webkit.org/show_bug.cgi?id=191987 + +Reviewed by Dean Jackson. + +* wtf/Platform.h: Added a specific macro for this. Not changing the behavior here, +although it seems very likely that we want to do the same on other iOS family OSes. + 2018-11-26 Fujii Hironori [Win][Clang] SOFT_LINK reports warning: implicit conversion between pointer-to-function and pointer-to-object is a Microsoft extension [-Wmicrosoft-cast] Modified: trunk/Source/WTF/wtf/Platform.h (238566 => 238567) --- trunk/Source/WTF/wtf/Platform.h 2018-11-27 20:20:18 UTC (rev 238566) +++ trunk/Source/WTF/wtf/Platform.h 2018-11-27 20:40:40 UTC (rev 238567) @@ -1375,3 +1375,8 @@ #if PLATFORM(COCOA) && USE(CA) && !PLATFORM(IOS_FAMILY_SIMULATOR) #define USE_IOSURFACE_CANVAS_BACKING_STORE 1 #endif + +/* FIXME: Should this be enabled or IOS_FAMILY, not just IOS? */ +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400) || PLATFORM(IOS) +#define HAVE_FOUNDATION_WITH_SAVE_COOKIES_WITH_COMPLETION_HANDLER 1 +#endif Modified: trunk/Source/WebCore/PAL/ChangeLog (238566 => 238567) --- trunk/Source/WebCore/PAL/ChangeLog 2018-11-27 20:20:18 UTC (rev 238566) +++ trunk/Source/WebCore/PAL/ChangeLog 2018-11-27 20:40:40 UTC (rev 238567) @@ -1,3 +1,13 @@ +2018-11-27 Alexey Proskuryakov + +Modernize the check for async _saveCookies existence +https://bugs.webkit.org/show_bug.cgi?id=191987 + +Reviewed by Dean Jackson. + +* pal/spi/cf/CFNetworkSPI.h: Also removed a check around _socketStreamProperties, +which exists everywhere. + 2018-11-27 Jer Noble Adopt -setOverrideRouteSharingPolicy:routingContextUID: SPI Modified: trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h (238566 => 238567) --- trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h 2018-11-27 20:20:18 UTC (rev 238566) +++ trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h 2018-11-27 20:40:40 UTC (rev 238567) @@ -137,7 +137,9 @@ - (id)_initWithCFHTTPCookieStorage:(CFHTTPCookieStorageRef)cfStorage; - (CFHTTPCookieStorageRef)_cookieStorage; - (void)_saveCookies; +#if HAVE(FOUNDATION_WITH_SAVE_COOKIES_WITH_COMPLETION_HANDLER) - (void)_saveCookies:(dispatch_block_t) completionHandler; +#endif @end @interface NSURLConnection () @@ -372,10 +374,8 @@ @end @interface NSURLSessionConfiguration () -#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400) || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 12) // FIXME: Remove this once rdar://problem/40650244 is in a build. @property (copy) NSDictionary *_socketStreamProperties; -#endif @end @interface NSURLSessionTask () Modified: trunk/Source/WebKit/ChangeLog (238566 => 238567) --- trunk/Source/WebKit/ChangeLog 2018-11-27 20:20:18 UTC (rev 238566) +++ trunk/Source/WebKit/ChangeLog 2018-11-27 20:40:40 UTC (rev 238567) @@ -1,3 +1,13 @@ +2018-11-27 Alexey Proskuryakov + +Modernize the check for async _saveCookies existence +https://bugs.webkit.org/show_bug.cgi?id=191987 + +Reviewed by Dean Jackson. + +* NetworkProcess/cocoa/NetworkProcessCocoa.mm: +(WebKit::NetworkProcess::platformSyncAllCookies): + 2018-11-27 Tim Horton Serialize and deserialize editable image strokes Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm (238566 => 238567) --- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm 2018-11-27 20:20:18 UTC (rev 238566) +++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm 2018-11-27 20:40:40 UTC (rev 238567) @@ -211,7 +211,7 @@ }); } -#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400) ||
[webkit-changes] [238566] trunk
Title: [238566] trunk Revision 238566 Author timothy_hor...@apple.com Date 2018-11-27 12:20:18 -0800 (Tue, 27 Nov 2018) Log Message Serialize and deserialize editable image strokes https://bugs.webkit.org/show_bug.cgi?id=192002 Reviewed by Dean Jackson. Source/WebCore: Test: editing/images/paste-editable-image.html * html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::parseAttribute): (WebCore::HTMLImageElement::insertedIntoAncestor): (WebCore::HTMLImageElement::didFinishInsertingNode): (WebCore::HTMLImageElement::removedFromAncestor): (WebCore::HTMLImageElement::hasEditableImageAttribute const): (WebCore::HTMLImageElement::updateEditableImage): Call updateEditableImage() from didFinishInsertingNode instead of insertedIntoAncestor. This is helpful because it means we get the final, deduplicated attachment identifier instead of the original one when cloning or pasting. This also means that isConnected() is now always accurate when updateEditableImage() is called, so we can remove the argument that allowed us to lie from inside insertedIntoAncestor. * html/HTMLImageElement.h: * rendering/RenderImage.cpp: (WebCore::RenderImage::isEditableImage const): Make use of hasEditableImage instead of separately checking for the attribute. Source/WebKit: * UIProcess/API/APIAttachment.cpp: (API::Attachment::updateAttributes): * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::willUpdateAttachmentAttributes): * UIProcess/WebPageProxy.h: When an attachment would update its DOM attributes, plumb a notification to EditableImageController, and allow it to block the update (because we don't really want to set src for editable image attachments, we just want the UI process to fully own the data). * Platform/spi/ios/PencilKitSPI.h: Add some SPI. * UIProcess/ios/EditableImageController.h: * UIProcess/ios/EditableImageController.mm: (WebKit::EditableImageController::loadStrokesFromAttachment): Add a helper to load strokes from an attachment. (WebKit::EditableImageController::associateWithAttachment): Try to load strokes from the attachment when initially associated. Don't create a file wrapper around a null image, so it will be regenerated later. (WebKit::EditableImageController::willUpdateAttachmentAttributes): The aforementioned plumbing at update time. * UIProcess/ios/WKDrawingView.h: * UIProcess/ios/WKDrawingView.mm: (-[WKDrawingView layoutSubviews]): Invalidate the attachment (so it will be regenerated upon request) if the canvas size changes. (-[WKDrawingView PNGRepresentation]): Serialize strokes into the EXIF User Comment field. We will find a different field to use (ideally a custom vendor-specific field that nobody else will use for anything), but this works for now. Don't try to render an image if we don't have a size or scale; PKImageRenderer will just fail anyway, so bail early. In the iOS Simulator, PKImageRenderer currently returns an unusable image. Instead, so that we have a image on which to serialize the strokes, create a transparent 1x1 image. This makes it possible to serialize strokes even though we don't have a usable rendered image, so that we can still test this change (and future changes). (-[WKDrawingView loadDrawingFromPNGRepresentation:]): If available, deserialize strokes from the EXIF User Comment field. (-[WKDrawingView drawingDidChange:]): (-[WKDrawingView invalidateAttachment]): Factor invalidateAttachment out of drawingDidChange so we can call it from layoutSubviews too! LayoutTests: * editing/images/paste-editable-image-expected.txt: Added. * editing/images/paste-editable-image.html: Added. Add a test that we can copy and paste and editable image and continue to edit it, and are affecting a different attachment than the original. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLImageElement.cpp trunk/Source/WebCore/html/HTMLImageElement.h trunk/Source/WebCore/rendering/RenderImage.cpp trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Platform/spi/ios/PencilKitSPI.h trunk/Source/WebKit/UIProcess/API/APIAttachment.cpp trunk/Source/WebKit/UIProcess/WebPageProxy.cpp trunk/Source/WebKit/UIProcess/WebPageProxy.h trunk/Source/WebKit/UIProcess/ios/EditableImageController.h trunk/Source/WebKit/UIProcess/ios/EditableImageController.mm trunk/Source/WebKit/UIProcess/ios/WKDrawingView.h trunk/Source/WebKit/UIProcess/ios/WKDrawingView.mm Added Paths trunk/LayoutTests/editing/images/paste-editable-image-expected.txt trunk/LayoutTests/editing/images/paste-editable-image.html Diff Modified: trunk/LayoutTests/ChangeLog (238565 => 238566) --- trunk/LayoutTests/ChangeLog 2018-11-27 19:52:36 UTC (rev 238565) +++ trunk/LayoutTests/ChangeLog 2018-11-27 20:20:18 UTC (rev 238566) @@ -1,3 +1,16 @@ +2018-11-27 Tim Horton + +Serialize and deserialize editable image strokes +https://bugs.webkit.org/show_bug.cgi?id=192002 + + +Reviewed by Dean Jackson. + +*
[webkit-changes] [238565] trunk
Title: [238565] trunk
Revision 238565
Author cdu...@apple.com
Date 2018-11-27 11:52:36 -0800 (Tue, 27 Nov 2018)
Log Message
Regression(PSON) crash under WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame()
https://bugs.webkit.org/show_bug.cgi?id=191983
Reviewed by Geoffrey Garen.
Source/WebKit:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::continueNavigationInNewProcess):
Make sure the navigation still exists in m_mainFrameCreationHandler and return early if it
does not.
(WebKit::WebPageProxy::resetState):
Clear out m_mainFrameCreationHandler / m_mainFrameWindowCreationHandler if we resetting the state
after a crash. At this point, there is no chance the WebProcess will send us the IPC that will
cause these to get called and we do not want old state to remain for future navigations.
Tools:
Add API test coverage.
* TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (238564 => 238565)
--- trunk/Source/WebKit/ChangeLog 2018-11-27 19:47:17 UTC (rev 238564)
+++ trunk/Source/WebKit/ChangeLog 2018-11-27 19:52:36 UTC (rev 238565)
@@ -1,3 +1,21 @@
+2018-11-27 Chris Dumez
+
+Regression(PSON) crash under WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame()
+https://bugs.webkit.org/show_bug.cgi?id=191983
+
+
+Reviewed by Geoffrey Garen.
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::continueNavigationInNewProcess):
+Make sure the navigation still exists in m_mainFrameCreationHandler and return early if it
+does not.
+
+(WebKit::WebPageProxy::resetState):
+Clear out m_mainFrameCreationHandler / m_mainFrameWindowCreationHandler if we resetting the state
+after a crash. At this point, there is no chance the WebProcess will send us the IPC that will
+cause these to get called and we do not want old state to remain for future navigations.
+
2018-11-16 Jiewen Tan
Disallow loading webarchives as iframes
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (238564 => 238565)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2018-11-27 19:47:17 UTC (rev 238564)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2018-11-27 19:52:36 UTC (rev 238565)
@@ -2704,8 +2704,12 @@
loadRequestWithNavigation(navigation, ResourceRequest { navigation->currentRequest() }, WebCore::ShouldOpenExternalURLsPolicy::ShouldAllowExternalSchemes, nullptr, ShouldTreatAsContinuingLoad::Yes);
ASSERT(!m_mainFrame);
-m_mainFrameCreationHandler = [this, protectedThis = WTFMove(protectedThis), navigation = navigation.copyRef(), request = navigation->currentRequest(), mainFrameURL, isServerRedirect = navigation->currentRequestIsRedirect()]() mutable {
+m_mainFrameCreationHandler = [this, protectedThis = WTFMove(protectedThis), navigationID = navigation->navigationID(), request = navigation->currentRequest(), mainFrameURL, isServerRedirect = navigation->currentRequestIsRedirect()]() mutable {
ASSERT(m_mainFrame);
+// This navigation was destroyed so no need to notify of redirect.
+if (!navigationState().navigation(navigationID))
+return;
+
// Restore the main frame's committed URL as some clients may rely on it until the next load is committed.
m_mainFrame->frameLoadState().setURL(mainFrameURL);
@@ -2714,7 +2718,7 @@
// In this case we have the UIProcess synthesize the redirect notification at the appropriate time.
if (isServerRedirect) {
m_mainFrame->frameLoadState().didStartProvisionalLoad(request.url());
-didReceiveServerRedirectForProvisionalLoadForFrame(m_mainFrame->frameID(), navigation->navigationID(), WTFMove(request), { });
+didReceiveServerRedirectForProvisionalLoadForFrame(m_mainFrame->frameID(), navigationID, WTFMove(request), { });
}
};
@@ -6264,6 +6268,9 @@
void WebPageProxy::resetState(ResetStateReason resetStateReason)
{
m_mainFrame = nullptr;
+m_mainFrameCreationHandler = nullptr;
+m_mainFrameWindowCreationHandler = nullptr;
+
#if PLATFORM(COCOA)
m_scrollingPerformanceData = nullptr;
#endif
Modified: trunk/Tools/ChangeLog (238564 => 238565)
--- trunk/Tools/ChangeLog 2018-11-27 19:47:17 UTC (rev 238564)
+++ trunk/Tools/ChangeLog 2018-11-27 19:52:36 UTC (rev 238565)
@@ -1,3 +1,15 @@
+2018-11-27 Chris Dumez
+
+Regression(PSON) crash under WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame()
+https://bugs.webkit.org/show_bug.cgi?id=191983
+
+
+Reviewed by Geoffrey Garen.
+
+Add API test coverage.
+
+*
[webkit-changes] [238564] trunk/Source/JavaScriptCore
Title: [238564] trunk/Source/_javascript_Core
Revision 238564
Author mark@apple.com
Date 2018-11-27 11:47:17 -0800 (Tue, 27 Nov 2018)
Log Message
Introducing a ENABLE_SEPARATED_WX_HEAP macro.
https://bugs.webkit.org/show_bug.cgi?id=192013
Reviewed by Keith Miller.
This makes the code a little more readable.
I put the definition of ENABLE_SEPARATED_WX_HEAP in JSC's config.h instead of
Platform.h because ENABLE_SEPARATED_WX_HEAP is only needed inside JSC. Also,
ENABLE_SEPARATED_WX_HEAP depends on ENABLE(FAST_JIT_PERMISSIONS), which is only
defined for JSC.
* config.h:
* jit/ExecutableAllocator.cpp:
(JSC::FixedVMPoolExecutableAllocator::FixedVMPoolExecutableAllocator):
(JSC::FixedVMPoolExecutableAllocator::initializeSeparatedWXHeaps):
* jit/ExecutableAllocator.h:
(JSC::performJITMemcpy):
* runtime/Options.cpp:
(JSC::recomputeDependentOptions):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/config.h
trunk/Source/_javascript_Core/jit/ExecutableAllocator.cpp
trunk/Source/_javascript_Core/jit/ExecutableAllocator.h
trunk/Source/_javascript_Core/runtime/Options.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (238563 => 238564)
--- trunk/Source/_javascript_Core/ChangeLog 2018-11-27 19:41:17 UTC (rev 238563)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-11-27 19:47:17 UTC (rev 238564)
@@ -1,3 +1,27 @@
+2018-11-27 Mark Lam
+
+Introducing a ENABLE_SEPARATED_WX_HEAP macro.
+https://bugs.webkit.org/show_bug.cgi?id=192013
+
+
+Reviewed by Keith Miller.
+
+This makes the code a little more readable.
+
+I put the definition of ENABLE_SEPARATED_WX_HEAP in JSC's config.h instead of
+Platform.h because ENABLE_SEPARATED_WX_HEAP is only needed inside JSC. Also,
+ENABLE_SEPARATED_WX_HEAP depends on ENABLE(FAST_JIT_PERMISSIONS), which is only
+defined for JSC.
+
+* config.h:
+* jit/ExecutableAllocator.cpp:
+(JSC::FixedVMPoolExecutableAllocator::FixedVMPoolExecutableAllocator):
+(JSC::FixedVMPoolExecutableAllocator::initializeSeparatedWXHeaps):
+* jit/ExecutableAllocator.h:
+(JSC::performJITMemcpy):
+* runtime/Options.cpp:
+(JSC::recomputeDependentOptions):
+
2018-11-26 Caio Lima
Re-introduce op_bitnot
Modified: trunk/Source/_javascript_Core/config.h (238563 => 238564)
--- trunk/Source/_javascript_Core/config.h 2018-11-27 19:41:17 UTC (rev 238563)
+++ trunk/Source/_javascript_Core/config.h 2018-11-27 19:47:17 UTC (rev 238564)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2006, 2007, 2008, 2013 Apple Inc. All rights reserved.
+ * Copyright (C) 2006-2018 Apple Inc. All rights reserved.
* Copyright (C) 2006 Samuel Weinig
*
* This library is free software; you can redistribute it and/or
@@ -37,3 +37,11 @@
#endif
#include
+
+#if !defined(ENABLE_SEPARATED_WX_HEAP)
+#if (!ENABLE(FAST_JIT_PERMISSIONS) || !CPU(ARM64E)) && PLATFORM(IOS_FAMILY) && CPU(ARM64)
+#define ENABLE_SEPARATED_WX_HEAP 1
+#else
+#define ENABLE_SEPARATED_WX_HEAP 0
+#endif
+#endif // !defined(ENABLE_SEPARATED_WX_HEAP)
Modified: trunk/Source/_javascript_Core/jit/ExecutableAllocator.cpp (238563 => 238564)
--- trunk/Source/_javascript_Core/jit/ExecutableAllocator.cpp 2018-11-27 19:41:17 UTC (rev 238563)
+++ trunk/Source/_javascript_Core/jit/ExecutableAllocator.cpp 2018-11-27 19:47:17 UTC (rev 238564)
@@ -104,7 +104,7 @@
static const double executablePoolReservationFraction = 0.25;
#endif
-#if !ENABLE(FAST_JIT_PERMISSIONS) || !CPU(ARM64E)
+#if ENABLE(SEPARATED_WX_HEAP)
JS_EXPORT_PRIVATE bool useFastPermisionsJITCopy { false };
JS_EXPORT_PRIVATE JITWriteSeparateHeapsFunction jitWriteSeparateHeapsFunction;
#endif
@@ -182,11 +182,11 @@
ASSERT(m_reservation.size() == reservationSize);
void* reservationBase = m_reservation.base();
-#if ENABLE(FAST_JIT_PERMISSIONS) && CPU(ARM64E)
+#if ENABLE(FAST_JIT_PERMISSIONS) && !ENABLE(SEPARATED_WX_HEAP)
RELEASE_ASSERT(os_thread_self_restrict_rwx_is_supported());
os_thread_self_restrict_rwx_to_rx();
-#else // not ENABLE(FAST_JIT_PERMISSIONS) or not CPU(ARM64E)
+#else // not ENABLE(FAST_JIT_PERMISSIONS) or ENABLE(SEPARATED_WX_HEAP)
#if ENABLE(FAST_JIT_PERMISSIONS)
if (os_thread_self_restrict_rwx_is_supported()) {
useFastPermisionsJITCopy = true;
@@ -200,7 +200,7 @@
reservationSize -= pageSize();
initializeSeparatedWXHeaps(m_reservation.base(), pageSize(), reservationBase, reservationSize);
}
-#endif // not ENABLE(FAST_JIT_PERMISSIONS) or not CPU(ARM64E)
+#endif // not ENABLE(FAST_JIT_PERMISSIONS) or ENABLE(SEPARATED_WX_HEAP)
addFreshFreeSpace(reservationBase, reservationSize);
@@ -294,7 +294,7 @@
// Zero out writableAddr to avoid leaking the address of the writable mapping.
memset_s(, sizeof(writableAddr), 0,
[webkit-changes] [238563] trunk/Source/WebInspectorUI
Title: [238563] trunk/Source/WebInspectorUI Revision 238563 Author mattba...@apple.com Date 2018-11-27 11:41:17 -0800 (Tue, 27 Nov 2018) Log Message Web Inspector: Table selection should be handled by a SelectionController https://bugs.webkit.org/show_bug.cgi?id=191977 Reviewed by Devin Rousso. Add a SelectionController class, which manages an IndexSet of selected items, and provides operations for adding and removing items from the selection. Complex behaviors such as shift-clicking to select a range of items, and updating the selection using the keyboard, are forwarded to the controller using special-purpose methods that accept DOM Event objects. * UserInterface/Base/Utilities.js: * UserInterface/Controllers/SelectionController.js: Added. (WI.SelectionController): (WI.SelectionController.prototype.get delegate): (WI.SelectionController.prototype.get lastSelectedItem): (WI.SelectionController.prototype.get selectedItems): (WI.SelectionController.prototype.get allowsMultipleSelection): (WI.SelectionController.prototype.set allowsMultipleSelection): (WI.SelectionController.prototype.get numberOfItems): (WI.SelectionController.prototype.hasSelectedItem): (WI.SelectionController.prototype.selectItem): (WI.SelectionController.prototype.deselectItem): (WI.SelectionController.prototype.selectAll): (WI.SelectionController.prototype.deselectAll): (WI.SelectionController.prototype.removeSelectedItems): (WI.SelectionController.prototype.reset): (WI.SelectionController.prototype.didRemoveItem): (WI.SelectionController.prototype.handleKeyDown): (WI.SelectionController.prototype.handleItemMouseDown.normalizeRange): (WI.SelectionController.prototype.handleItemMouseDown): (WI.SelectionController.prototype._deselectAllAndSelect): (WI.SelectionController.prototype._selectItemsFromArrowKey): (WI.SelectionController.prototype._nextSelectableIndex): (WI.SelectionController.prototype._previousSelectableIndex): (WI.SelectionController.prototype._updateSelectedItems): * UserInterface/Main.html: * UserInterface/Test.html: * UserInterface/Views/Table.js: (WI.Table): (WI.Table.prototype.get selectedRow): (WI.Table.prototype.get selectedRows): (WI.Table.prototype.get allowsMultipleSelection): (WI.Table.prototype.set allowsMultipleSelection): (WI.Table.prototype.isRowSelected): (WI.Table.prototype.reloadData): (WI.Table.prototype.selectRow): (WI.Table.prototype.deselectRow): (WI.Table.prototype.selectAll): (WI.Table.prototype.deselectAll): (WI.Table.prototype.removeRow): (WI.Table.prototype.removeSelectedRows): (WI.Table.prototype.selectionControllerSelectionDidChange): (WI.Table.prototype.selectionControllerNumberOfItems): (WI.Table.prototype.selectionControllerNextSelectableIndex): (WI.Table.prototype.selectionControllerPreviousSelectableIndex): (WI.Table.prototype._handleKeyDown): (WI.Table.prototype._handleMouseDown): (WI.Table.prototype._removeRows): (WI.Table.prototype._toggleSelectedRowStyle): (WI.Table.prototype._selectRowsFromArrowKey): Deleted. (WI.Table.prototype._handleMouseDown.normalizeRange): Deleted. (WI.Table.prototype._deselectAllAndSelect): Deleted. (WI.Table.prototype._notifySelectionDidChange): Deleted. (WI.Table.prototype._updateSelectedRows): Deleted. Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Base/Utilities.js trunk/Source/WebInspectorUI/UserInterface/Main.html trunk/Source/WebInspectorUI/UserInterface/Test.html trunk/Source/WebInspectorUI/UserInterface/Views/Table.js Added Paths trunk/Source/WebInspectorUI/UserInterface/Controllers/SelectionController.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (238562 => 238563) --- trunk/Source/WebInspectorUI/ChangeLog 2018-11-27 19:38:18 UTC (rev 238562) +++ trunk/Source/WebInspectorUI/ChangeLog 2018-11-27 19:41:17 UTC (rev 238563) @@ -1,3 +1,75 @@ +2018-11-27 Matt Baker + +Web Inspector: Table selection should be handled by a SelectionController +https://bugs.webkit.org/show_bug.cgi?id=191977 + + +Reviewed by Devin Rousso. + +Add a SelectionController class, which manages an IndexSet of selected +items, and provides operations for adding and removing items from the +selection. Complex behaviors such as shift-clicking to select a range of +items, and updating the selection using the keyboard, are forwarded to +the controller using special-purpose methods that accept DOM Event objects. + +* UserInterface/Base/Utilities.js: + +* UserInterface/Controllers/SelectionController.js: Added. +(WI.SelectionController): +(WI.SelectionController.prototype.get delegate): +(WI.SelectionController.prototype.get lastSelectedItem): +(WI.SelectionController.prototype.get selectedItems): +(WI.SelectionController.prototype.get allowsMultipleSelection): +(WI.SelectionController.prototype.set allowsMultipleSelection): +(WI.SelectionController.prototype.get
[webkit-changes] [238562] trunk
Title: [238562] trunk Revision 238562 Author jiewen_...@apple.com Date 2018-11-27 11:38:18 -0800 (Tue, 27 Nov 2018) Log Message Disallow loading webarchives as iframes https://bugs.webkit.org/show_bug.cgi?id=191728 Reviewed by Youenn Fablet. Source/WebCore: Disallow loading webarchives as iframes. We don't allow loading remote webarchives. Now, this policy is hardened to disallow loading webarchives as iframes for local documents as well. To allow old tests still be able to run, a flag is added to always allow loading local webarchives in document. The flag can be set via window.internals. Tests: webarchive/loading/test-loading-archive-subresource.html webarchive/loading/test-loading-top-archive.html * dom/Document.h: (WebCore::Document::setAlwaysAllowLocalWebarchive): (WebCore::Document::alwaysAllowLocalWebarchive): * loader/DocumentLoader.cpp: (WebCore::disallowWebArchive): (WebCore::DocumentLoader::continueAfterContentPolicy): (WebCore::isRemoteWebArchive): Deleted. * testing/Internals.cpp: (WebCore::Internals::setAlwaysAllowLocalWebarchive const): * testing/Internals.h: * testing/Internals.idl: Source/WebKit: * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::unableToImplementPolicy): Add a check to prevent null pointer dereference. LayoutTests: * platform/mac-wk1/webarchive/loading/test-loading-archive-subresource-expected.txt: Added. * platform/mac/fast/loader/webarchive-encoding-respected.html: * webarchive/loading/cache-expired-subresource.html: * webarchive/loading/mainresource-null-mimetype-crash.html: * webarchive/loading/missing-data.html: * webarchive/loading/resources/test-loading-archive-main.webarchive: Copied from LayoutTests/webarchive/loading/test-loading-archive.html. * webarchive/loading/test-loading-archive-subresource-expected.txt: Added. * webarchive/loading/test-loading-archive-subresource-null-mimetype.html: * webarchive/loading/test-loading-archive-subresource.html: Copied from LayoutTests/webarchive/loading/test-loading-archive.html. * webarchive/loading/test-loading-archive.html: * webarchive/loading/test-loading-top-archive-expected.txt: Added. * webarchive/loading/test-loading-top-archive.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/fast/loader/webarchive-encoding-respected.html trunk/LayoutTests/webarchive/loading/cache-expired-subresource.html trunk/LayoutTests/webarchive/loading/mainresource-null-mimetype-crash.html trunk/LayoutTests/webarchive/loading/missing-data.html trunk/LayoutTests/webarchive/loading/test-loading-archive-subresource-null-mimetype.html trunk/LayoutTests/webarchive/loading/test-loading-archive.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/Document.h trunk/Source/WebCore/loader/DocumentLoader.cpp trunk/Source/WebCore/loader/DocumentLoader.h trunk/Source/WebCore/testing/Internals.cpp trunk/Source/WebCore/testing/Internals.h trunk/Source/WebCore/testing/Internals.idl trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/WebPageProxy.cpp Added Paths trunk/LayoutTests/platform/mac-wk1/webarchive/ trunk/LayoutTests/platform/mac-wk1/webarchive/loading/ trunk/LayoutTests/platform/mac-wk1/webarchive/loading/test-loading-archive-subresource-expected.txt trunk/LayoutTests/webarchive/loading/resources/top.webarchive trunk/LayoutTests/webarchive/loading/test-loading-archive-subresource-expected.txt trunk/LayoutTests/webarchive/loading/test-loading-archive-subresource.html trunk/LayoutTests/webarchive/loading/test-loading-top-archive-expected.txt trunk/LayoutTests/webarchive/loading/test-loading-top-archive.html Diff Modified: trunk/LayoutTests/ChangeLog (238561 => 238562) --- trunk/LayoutTests/ChangeLog 2018-11-27 19:34:06 UTC (rev 238561) +++ trunk/LayoutTests/ChangeLog 2018-11-27 19:38:18 UTC (rev 238562) @@ -1,3 +1,24 @@ +2018-11-16 Jiewen Tan + +Disallow loading webarchives as iframes +https://bugs.webkit.org/show_bug.cgi?id=191728 + + +Reviewed by Youenn Fablet. + +* platform/mac-wk1/webarchive/loading/test-loading-archive-subresource-expected.txt: Added. +* platform/mac/fast/loader/webarchive-encoding-respected.html: +* webarchive/loading/cache-expired-subresource.html: +* webarchive/loading/mainresource-null-mimetype-crash.html: +* webarchive/loading/missing-data.html: +* webarchive/loading/resources/test-loading-archive-main.webarchive: Copied from LayoutTests/webarchive/loading/test-loading-archive.html. +* webarchive/loading/test-loading-archive-subresource-expected.txt: Added. +* webarchive/loading/test-loading-archive-subresource-null-mimetype.html: +* webarchive/loading/test-loading-archive-subresource.html: Copied from LayoutTests/webarchive/loading/test-loading-archive.html. +* webarchive/loading/test-loading-archive.html: +* webarchive/loading/test-loading-top-archive-expected.txt: Added. +*
[webkit-changes] [238561] trunk/Source/WebCore
Title: [238561] trunk/Source/WebCore
Revision 238561
Author jer.no...@apple.com
Date 2018-11-27 11:34:06 -0800 (Tue, 27 Nov 2018)
Log Message
Unregister CDMSessionMediaSourceAVFObjC for error notifications during destruction.
https://bugs.webkit.org/show_bug.cgi?id=191985
Reviewed by Eric Carlson.
* platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:
(WebCore::CDMSessionMediaSourceAVFObjC::~CDMSessionMediaSourceAVFObjC):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (238560 => 238561)
--- trunk/Source/WebCore/ChangeLog 2018-11-27 19:31:51 UTC (rev 238560)
+++ trunk/Source/WebCore/ChangeLog 2018-11-27 19:34:06 UTC (rev 238561)
@@ -1,3 +1,14 @@
+2018-11-27 Jer Noble
+
+Unregister CDMSessionMediaSourceAVFObjC for error notifications during destruction.
+https://bugs.webkit.org/show_bug.cgi?id=191985
+
+
+Reviewed by Eric Carlson.
+
+* platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:
+(WebCore::CDMSessionMediaSourceAVFObjC::~CDMSessionMediaSourceAVFObjC):
+
2018-11-27 Thibault Saunier
[GStreamer][WebRTC] Use LibWebRTC provided vp8 decoders and encoders
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm (238560 => 238561)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm 2018-11-27 19:31:51 UTC (rev 238560)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm 2018-11-27 19:34:06 UTC (rev 238561)
@@ -45,6 +45,10 @@
{
if (m_cdm)
m_cdm->invalidateSession(this);
+
+for (auto& sourceBuffer : m_sourceBuffers)
+sourceBuffer->unregisterForErrorNotifications(this);
+m_sourceBuffers.clear();
}
void CDMSessionMediaSourceAVFObjC::layerDidReceiveError(AVSampleBufferDisplayLayer *, NSError *error, bool& shouldIgnore)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [238560] trunk/Source/WebCore/PAL
Title: [238560] trunk/Source/WebCore/PAL Revision 238560 Author jer.no...@apple.com Date 2018-11-27 11:31:51 -0800 (Tue, 27 Nov 2018) Log Message Adopt -setOverrideRouteSharingPolicy:routingContextUID: SPI https://bugs.webkit.org/show_bug.cgi?id=190951 Further follow-up build fix; add ASSUME_NONNULL macros to SPI declaration. * pal/spi/cocoa/AVKitSPI.h: Modified Paths trunk/Source/WebCore/PAL/ChangeLog trunk/Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h Diff Modified: trunk/Source/WebCore/PAL/ChangeLog (238559 => 238560) --- trunk/Source/WebCore/PAL/ChangeLog 2018-11-27 18:20:31 UTC (rev 238559) +++ trunk/Source/WebCore/PAL/ChangeLog 2018-11-27 19:31:51 UTC (rev 238560) @@ -4,6 +4,16 @@ https://bugs.webkit.org/show_bug.cgi?id=190951 +Further follow-up build fix; add ASSUME_NONNULL macros to SPI declaration. + +* pal/spi/cocoa/AVKitSPI.h: + +2018-11-27 Jer Noble + +Adopt -setOverrideRouteSharingPolicy:routingContextUID: SPI +https://bugs.webkit.org/show_bug.cgi?id=190951 + + Follow-up build fix when building against older SDKs. * pal/spi/cocoa/AVKitSPI.h: Modified: trunk/Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h (238559 => 238560) --- trunk/Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h 2018-11-27 18:20:31 UTC (rev 238559) +++ trunk/Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h 2018-11-27 19:31:51 UTC (rev 238560) @@ -91,9 +91,11 @@ NS_ASSUME_NONNULL_END #elif __IPHONE_OS_VERSION_MAX_ALLOWED < 120200 +NS_ASSUME_NONNULL_BEGIN @interface AVPlayerViewController (AVPlayerViewController_WebKitOnly_OverrideRouteSharingPolicy) - (void)setWebKitOverrideRouteSharingPolicy:(NSUInteger)routeSharingPolicy routingContextUID:(NSString *)routingContextUID; @end +NS_ASSUME_NONNULL_END #endif #else ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [238559] tags/Safari-607.1.14.4/Source
Title: [238559] tags/Safari-607.1.14.4/Source Revision 238559 Author kocsen_ch...@apple.com Date 2018-11-27 10:20:31 -0800 (Tue, 27 Nov 2018) Log Message Versioning. Modified Paths tags/Safari-607.1.14.4/Source/_javascript_Core/Configurations/Version.xcconfig tags/Safari-607.1.14.4/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig tags/Safari-607.1.14.4/Source/WebCore/Configurations/Version.xcconfig tags/Safari-607.1.14.4/Source/WebCore/PAL/Configurations/Version.xcconfig tags/Safari-607.1.14.4/Source/WebInspectorUI/Configurations/Version.xcconfig tags/Safari-607.1.14.4/Source/WebKit/Configurations/Version.xcconfig tags/Safari-607.1.14.4/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: tags/Safari-607.1.14.4/Source/_javascript_Core/Configurations/Version.xcconfig (238558 => 238559) --- tags/Safari-607.1.14.4/Source/_javascript_Core/Configurations/Version.xcconfig 2018-11-27 18:16:06 UTC (rev 238558) +++ tags/Safari-607.1.14.4/Source/_javascript_Core/Configurations/Version.xcconfig 2018-11-27 18:20:31 UTC (rev 238559) @@ -24,7 +24,7 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; TINY_VERSION = 14; -MICRO_VERSION = 3; +MICRO_VERSION = 4; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: tags/Safari-607.1.14.4/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (238558 => 238559) --- tags/Safari-607.1.14.4/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2018-11-27 18:16:06 UTC (rev 238558) +++ tags/Safari-607.1.14.4/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2018-11-27 18:20:31 UTC (rev 238559) @@ -24,7 +24,7 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; TINY_VERSION = 14; -MICRO_VERSION = 3; +MICRO_VERSION = 4; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: tags/Safari-607.1.14.4/Source/WebCore/Configurations/Version.xcconfig (238558 => 238559) --- tags/Safari-607.1.14.4/Source/WebCore/Configurations/Version.xcconfig 2018-11-27 18:16:06 UTC (rev 238558) +++ tags/Safari-607.1.14.4/Source/WebCore/Configurations/Version.xcconfig 2018-11-27 18:20:31 UTC (rev 238559) @@ -24,7 +24,7 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; TINY_VERSION = 14; -MICRO_VERSION = 3; +MICRO_VERSION = 4; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: tags/Safari-607.1.14.4/Source/WebCore/PAL/Configurations/Version.xcconfig (238558 => 238559) --- tags/Safari-607.1.14.4/Source/WebCore/PAL/Configurations/Version.xcconfig 2018-11-27 18:16:06 UTC (rev 238558) +++ tags/Safari-607.1.14.4/Source/WebCore/PAL/Configurations/Version.xcconfig 2018-11-27 18:20:31 UTC (rev 238559) @@ -24,7 +24,7 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; TINY_VERSION = 14; -MICRO_VERSION = 3; +MICRO_VERSION = 4; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: tags/Safari-607.1.14.4/Source/WebInspectorUI/Configurations/Version.xcconfig (238558 => 238559) --- tags/Safari-607.1.14.4/Source/WebInspectorUI/Configurations/Version.xcconfig 2018-11-27 18:16:06 UTC (rev 238558) +++ tags/Safari-607.1.14.4/Source/WebInspectorUI/Configurations/Version.xcconfig 2018-11-27 18:20:31 UTC (rev 238559) @@ -1,7 +1,7 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; TINY_VERSION = 14; -MICRO_VERSION = 3; +MICRO_VERSION = 4; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: tags/Safari-607.1.14.4/Source/WebKit/Configurations/Version.xcconfig (238558 => 238559) --- tags/Safari-607.1.14.4/Source/WebKit/Configurations/Version.xcconfig 2018-11-27 18:16:06 UTC (rev 238558) +++ tags/Safari-607.1.14.4/Source/WebKit/Configurations/Version.xcconfig 2018-11-27 18:20:31 UTC (rev 238559) @@ -24,7 +24,7 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; TINY_VERSION = 14; -MICRO_VERSION = 3; +MICRO_VERSION = 4; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: tags/Safari-607.1.14.4/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (238558 => 238559) --- tags/Safari-607.1.14.4/Source/WebKitLegacy/mac/Configurations/Version.xcconfig 2018-11-27 18:16:06 UTC (rev 238558) +++ tags/Safari-607.1.14.4/Source/WebKitLegacy/mac/Configurations/Version.xcconfig 2018-11-27 18:20:31 UTC (rev 238559) @@ -24,7 +24,7 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; TINY_VERSION = 14; -MICRO_VERSION = 3; +MICRO_VERSION = 4; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [238558] tags/Safari-607.1.14.4/
Title: [238558] tags/Safari-607.1.14.4/ Revision 238558 Author kocsen_ch...@apple.com Date 2018-11-27 10:16:06 -0800 (Tue, 27 Nov 2018) Log Message New tag. Added Paths tags/Safari-607.1.14.4/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [238557] trunk/Source
Title: [238557] trunk/Source Revision 238557 Author commit-qu...@webkit.org Date 2018-11-27 09:34:28 -0800 (Tue, 27 Nov 2018) Log Message [GStreamer][WebRTC] Use LibWebRTC provided vp8 decoders and encoders https://bugs.webkit.org/show_bug.cgi?id=191861 Source/ThirdParty/libwebrtc: Patch by Thibault Saunier on 2018-11-27 Reviewed by Philippe Normand. * CMakeLists.txt: Build LibVPX vp8 encoder and decoders. Source/WebCore: The GStreamer implementations are less feature full and less tested, now that Apple also use the LibWebRTC provided implementations it makes a lot of sense for us to do the same. Basically everything related to temporal scalability is not implemented in GStreamer. We should make sure to use GStreamer elements on low powered platforms and for accelerated encoders and decoders. Patch by Thibault Saunier on 2018-11-27 Reviewed by Philippe Normand. This is mostly refactoring, no new test required. * platform/graphics/gstreamer/GStreamerCommon.h: Added GstMappedFrame similar to GstMappedBuffer but for video frames. (WebCore::GstMappedFrame::GstMappedFrame): (WebCore::GstMappedFrame::get): (WebCore::GstMappedFrame::ComponentData): (WebCore::GstMappedFrame::ComponentStride): (WebCore::GstMappedFrame::info): (WebCore::GstMappedFrame::width): (WebCore::GstMappedFrame::height): (WebCore::GstMappedFrame::format): (WebCore::GstMappedFrame::~GstMappedFrame): (WebCore::GstMappedFrame::operator bool const): * platform/graphics/gstreamer/GUniquePtrGStreamer.h: * platform/mediastream/gstreamer/GStreamerVideoFrameLibWebRTC.cpp: (WebCore::GStreamerVideoFrameLibWebRTC::ToI420): Implemented support for converting frame formats with the GstVideoConverter API * platform/mediastream/libwebrtc/GStreamerVideoDecoderFactory.cpp: (WebCore::GStreamerVideoDecoder::GstDecoderFactory): (WebCore::GStreamerVideoDecoder::HasGstDecoder): (WebCore::VP8Decoder::Create): Creates a `webrtc::LibvpxVp8Decoder()` if GStreamer decoder would be the LibVPX based one. (WebCore::GStreamerVideoDecoderFactory::CreateVideoDecoder): * platform/mediastream/libwebrtc/GStreamerVideoEncoder.cpp: (gst_webrtc_video_encoder_class_init): * platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp: Stop using vp8enc and use LibWebRTC based implementation (WebCore::GStreamerH264Encoder::GStreamerH264Encoder): Renamed H264Encoder to GStreamerH264Encoder to be more coherent with what is done in LibVPX (WebCore::GStreamerVP8Encoder::GStreamerVP8Encoder): Renamed VP8Encoder to GStreamerVP8Encoder to be more coherent with what is done in LibVPX (WebCore::GStreamerVideoEncoderFactory::CreateVideoEncoder): (WebCore::GStreamerVideoEncoderFactory::GetSupportedFormats const): Modified Paths trunk/Source/ThirdParty/libwebrtc/CMakeLists.txt trunk/Source/ThirdParty/libwebrtc/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h trunk/Source/WebCore/platform/graphics/gstreamer/GUniquePtrGStreamer.h trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoFrameLibWebRTC.cpp trunk/Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoDecoderFactory.cpp trunk/Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoder.cpp trunk/Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp Diff Modified: trunk/Source/ThirdParty/libwebrtc/CMakeLists.txt (238556 => 238557) --- trunk/Source/ThirdParty/libwebrtc/CMakeLists.txt 2018-11-27 17:28:23 UTC (rev 238556) +++ trunk/Source/ThirdParty/libwebrtc/CMakeLists.txt 2018-11-27 17:34:28 UTC (rev 238557) @@ -1050,6 +1050,11 @@ Source/webrtc/modules/video_coding/codecs/i420/i420.cc Source/webrtc/modules/video_coding/codecs/vp8/default_temporal_layers.cc Source/webrtc/modules/video_coding/codecs/vp8/screenshare_layers.cc +Source/webrtc/modules/video_coding/codecs/vp8/vp8_temporal_layers.cc +Source/webrtc/modules/video_coding/codecs/vp8/libvpx_vp8_decoder.cc +Source/webrtc/modules/video_coding/codecs/vp8/libvpx_interface.cc +Source/webrtc/modules/video_coding/codecs/vp8/temporal_layers_checker.cc +Source/webrtc/modules/video_coding/codecs/vp8/libvpx_vp8_encoder.cc Source/webrtc/modules/video_coding/codecs/vp9/svc_config.cc Source/webrtc/modules/video_coding/codecs/vp9/svc_rate_allocator.cc Source/webrtc/modules/video_coding/decoder_database.cc Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (238556 => 238557) --- trunk/Source/ThirdParty/libwebrtc/ChangeLog 2018-11-27 17:28:23 UTC (rev 238556) +++ trunk/Source/ThirdParty/libwebrtc/ChangeLog 2018-11-27 17:34:28 UTC (rev 238557) @@ -1,3 +1,12 @@ +2018-11-27 Thibault Saunier + +[GStreamer][WebRTC] Use LibWebRTC provided vp8 decoders and encoders +https://bugs.webkit.org/show_bug.cgi?id=191861 + +Reviewed by Philippe Normand. + +* CMakeLists.txt: Build LibVPX vp8 encoder and decoders. + 2018-11-14 Youenn Fablet Convert libwebrtc error types to
[webkit-changes] [238556] trunk/Source/WebCore/PAL
Title: [238556] trunk/Source/WebCore/PAL Revision 238556 Author jer.no...@apple.com Date 2018-11-27 09:28:23 -0800 (Tue, 27 Nov 2018) Log Message Adopt -setOverrideRouteSharingPolicy:routingContextUID: SPI https://bugs.webkit.org/show_bug.cgi?id=190951 Follow-up build fix when building against older SDKs. * pal/spi/cocoa/AVKitSPI.h: Modified Paths trunk/Source/WebCore/PAL/ChangeLog trunk/Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h Diff Modified: trunk/Source/WebCore/PAL/ChangeLog (238555 => 238556) --- trunk/Source/WebCore/PAL/ChangeLog 2018-11-27 17:05:35 UTC (rev 238555) +++ trunk/Source/WebCore/PAL/ChangeLog 2018-11-27 17:28:23 UTC (rev 238556) @@ -1,3 +1,13 @@ +2018-11-27 Jer Noble + +Adopt -setOverrideRouteSharingPolicy:routingContextUID: SPI +https://bugs.webkit.org/show_bug.cgi?id=190951 + + +Follow-up build fix when building against older SDKs. + +* pal/spi/cocoa/AVKitSPI.h: + 2018-11-26 Jer Noble Adopt -setOverrideRouteSharingPolicy:routingContextUID: SPI Modified: trunk/Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h (238555 => 238556) --- trunk/Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h 2018-11-27 17:05:35 UTC (rev 238555) +++ trunk/Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h 2018-11-27 17:28:23 UTC (rev 238556) @@ -90,6 +90,10 @@ NS_ASSUME_NONNULL_END +#elif __IPHONE_OS_VERSION_MAX_ALLOWED < 120200 +@interface AVPlayerViewController (AVPlayerViewController_WebKitOnly_OverrideRouteSharingPolicy) +- (void)setWebKitOverrideRouteSharingPolicy:(NSUInteger)routeSharingPolicy routingContextUID:(NSString *)routingContextUID; +@end #endif #else ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [238555] trunk/LayoutTests
Title: [238555] trunk/LayoutTests Revision 238555 Author pvol...@apple.com Date 2018-11-27 09:05:35 -0800 (Tue, 27 Nov 2018) Log Message Layout Test svg/text/monospace-text-size-in-img.html is failing https://bugs.webkit.org/show_bug.cgi?id=192011 Unreviewed test gardening. * platform/win/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (238554 => 238555) --- trunk/LayoutTests/ChangeLog 2018-11-27 17:00:48 UTC (rev 238554) +++ trunk/LayoutTests/ChangeLog 2018-11-27 17:05:35 UTC (rev 238555) @@ -1,5 +1,14 @@ 2018-11-27 Per Arne Vollan +Layout Test svg/text/monospace-text-size-in-img.html is failing +https://bugs.webkit.org/show_bug.cgi?id=192011 + +Unreviewed test gardening. + +* platform/win/TestExpectations: + +2018-11-27 Per Arne Vollan + Layout Test fast/inline/simple-inline-with-out-of-flow-descendant.html is failing https://bugs.webkit.org/show_bug.cgi?id=192010 Modified: trunk/LayoutTests/platform/win/TestExpectations (238554 => 238555) --- trunk/LayoutTests/platform/win/TestExpectations 2018-11-27 17:00:48 UTC (rev 238554) +++ trunk/LayoutTests/platform/win/TestExpectations 2018-11-27 17:05:35 UTC (rev 238555) @@ -4267,3 +4267,5 @@ webkit.org/b/192010 fast/inline/simple-inline-inflow-positioned.html [ Failure ] webkit.org/b/192010 fast/inline/simple-inline-with-out-of-flow-descendant.html [ Failure ] webkit.org/b/192010 fast/inline/simple-inline-with-out-of-flow-descendant2.html [ Failure ] + +webkit.org/b/192011 svg/text/monospace-text-size-in-img.html [ ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [238554] trunk/LayoutTests
Title: [238554] trunk/LayoutTests Revision 238554 Author pvol...@apple.com Date 2018-11-27 09:00:48 -0800 (Tue, 27 Nov 2018) Log Message Layout Test fast/inline/simple-inline-with-out-of-flow-descendant.html is failing https://bugs.webkit.org/show_bug.cgi?id=192010 Unreviewed test gardening. * platform/win/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (238553 => 238554) --- trunk/LayoutTests/ChangeLog 2018-11-27 15:51:43 UTC (rev 238553) +++ trunk/LayoutTests/ChangeLog 2018-11-27 17:00:48 UTC (rev 238554) @@ -1,3 +1,12 @@ +2018-11-27 Per Arne Vollan + +Layout Test fast/inline/simple-inline-with-out-of-flow-descendant.html is failing +https://bugs.webkit.org/show_bug.cgi?id=192010 + +Unreviewed test gardening. + +* platform/win/TestExpectations: + 2018-11-26 Daniel Bates REGRESSION (r238078): Do not draw caps lock indicator when Strong Password button is shown Modified: trunk/LayoutTests/platform/win/TestExpectations (238553 => 238554) --- trunk/LayoutTests/platform/win/TestExpectations 2018-11-27 15:51:43 UTC (rev 238553) +++ trunk/LayoutTests/platform/win/TestExpectations 2018-11-27 17:00:48 UTC (rev 238554) @@ -4262,3 +4262,8 @@ webkit.org/b/191584 webanimations/accelerated-animation-with-delay.html [ ImageOnlyFailure ] webkit.org/b/191584 webanimations/accelerated-transition-by-removing-property.html [ ImageOnlyFailure ] webkit.org/b/191584 fast/animation/css-animation-resuming-when-visible-with-style-change.html [ Timeout ] + +webkit.org/b/192010 fast/inline/inline-content-with-float-and-margin.html [ Failure ] +webkit.org/b/192010 fast/inline/simple-inline-inflow-positioned.html [ Failure ] +webkit.org/b/192010 fast/inline/simple-inline-with-out-of-flow-descendant.html [ Failure ] +webkit.org/b/192010 fast/inline/simple-inline-with-out-of-flow-descendant2.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [238553] trunk/Source/WebKit
Title: [238553] trunk/Source/WebKit
Revision 238553
Author wenson_hs...@apple.com
Date 2018-11-27 07:51:43 -0800 (Tue, 27 Nov 2018)
Log Message
WebKit.AddAndRemoveDataDetectors hits a debug assertion after r238515
https://bugs.webkit.org/show_bug.cgi?id=191996
Reviewed by Tim Horton.
This assertion is hit because `decode(Decoder& decoder, NSArray *allowedClasses)` expects the decoded
object (of class `_NSArrayM`) to be equal to `NSArray.class`.
We fix the crash by relaxing the debug assertion when decoding securely-codable objects over IPC. Instead of
checking that the class of the decoded object is equal to one of the allowed classes, check that the object is a
kind of any of the allowed classes.
* Shared/Cocoa/ArgumentCodersCocoa.h:
(IPC::isObjectClassAllowed):
(IPC::decode):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.h
Diff
Modified: trunk/Source/WebKit/ChangeLog (238552 => 238553)
--- trunk/Source/WebKit/ChangeLog 2018-11-27 15:29:55 UTC (rev 238552)
+++ trunk/Source/WebKit/ChangeLog 2018-11-27 15:51:43 UTC (rev 238553)
@@ -1,3 +1,21 @@
+2018-11-27 Wenson Hsieh
+
+WebKit.AddAndRemoveDataDetectors hits a debug assertion after r238515
+https://bugs.webkit.org/show_bug.cgi?id=191996
+
+Reviewed by Tim Horton.
+
+This assertion is hit because `decode(Decoder& decoder, NSArray *allowedClasses)` expects the decoded
+object (of class `_NSArrayM`) to be equal to `NSArray.class`.
+
+We fix the crash by relaxing the debug assertion when decoding securely-codable objects over IPC. Instead of
+checking that the class of the decoded object is equal to one of the allowed classes, check that the object is a
+kind of any of the allowed classes.
+
+* Shared/Cocoa/ArgumentCodersCocoa.h:
+(IPC::isObjectClassAllowed):
+(IPC::decode):
+
2018-11-27 Tomas Popela
[GTK][WPE] Remove temporary workaround in Source/WebKit/Platform*.cmake
Modified: trunk/Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.h (238552 => 238553)
--- trunk/Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.h 2018-11-27 15:29:55 UTC (rev 238552)
+++ trunk/Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.h 2018-11-27 15:51:43 UTC (rev 238553)
@@ -43,6 +43,19 @@
return decode(decoder, @[ allowedClass ]);
}
+#ifndef NDEBUG
+
+static inline bool isObjectClassAllowed(id object, NSArray *allowedClasses)
+{
+for (Class allowedClass in allowedClasses) {
+if ([object isKindOfClass:allowedClass])
+return true;
+}
+return false;
+}
+
+#endif
+
template
std::optional> decode(Decoder& decoder, NSArray *allowedClasses)
{
@@ -54,7 +67,7 @@
return { nullptr };
id object = result->leakRef();
-ASSERT([allowedClasses containsObject:[object class]]);
+ASSERT(isObjectClassAllowed(object, allowedClasses));
return { adoptNS(static_cast(object)) };
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [238552] trunk/Source/WebKit
Title: [238552] trunk/Source/WebKit
Revision 238552
Author tpop...@redhat.com
Date 2018-11-27 07:29:55 -0800 (Tue, 27 Nov 2018)
Log Message
[GTK][WPE] Remove temporary workaround in Source/WebKit/Platform*.cmake
https://bugs.webkit.org/show_bug.cgi?id=192008
Reviewed by Michael Catanzaro.
Looks like it's not needed anymore as the code compiles fine without
it.
* PlatformGTK.cmake:
* PlatformWPE.cmake:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/PlatformGTK.cmake
trunk/Source/WebKit/PlatformWPE.cmake
Diff
Modified: trunk/Source/WebKit/ChangeLog (238551 => 238552)
--- trunk/Source/WebKit/ChangeLog 2018-11-27 13:52:57 UTC (rev 238551)
+++ trunk/Source/WebKit/ChangeLog 2018-11-27 15:29:55 UTC (rev 238552)
@@ -1,3 +1,16 @@
+2018-11-27 Tomas Popela
+
+[GTK][WPE] Remove temporary workaround in Source/WebKit/Platform*.cmake
+https://bugs.webkit.org/show_bug.cgi?id=192008
+
+Reviewed by Michael Catanzaro.
+
+Looks like it's not needed anymore as the code compiles fine without
+it.
+
+* PlatformGTK.cmake:
+* PlatformWPE.cmake:
+
2018-11-27 Antti Koivisto
Factor mask layer applying in RemoteLayerTreePropertyApplier into a shared function
Modified: trunk/Source/WebKit/PlatformGTK.cmake (238551 => 238552)
--- trunk/Source/WebKit/PlatformGTK.cmake 2018-11-27 13:52:57 UTC (rev 238551)
+++ trunk/Source/WebKit/PlatformGTK.cmake 2018-11-27 15:29:55 UTC (rev 238552)
@@ -26,9 +26,6 @@
WEBKIT_ADD_TARGET_PROPERTIES(WebKit LINK_FLAGS "-Wl,--version-script,${CMAKE_CURRENT_SOURCE_DIR}/webkitglib-symbols.map")
endif ()
-# Temporary workaround to allow the build to succeed.
-file(REMOVE "${FORWARDING_HEADERS_DIR}/WebCore/Settings.h")
-
set(WebKit_USE_PREFIX_HEADER ON)
list(APPEND WebKit_UNIFIED_SOURCE_LIST_FILES
Modified: trunk/Source/WebKit/PlatformWPE.cmake (238551 => 238552)
--- trunk/Source/WebKit/PlatformWPE.cmake 2018-11-27 13:52:57 UTC (rev 238551)
+++ trunk/Source/WebKit/PlatformWPE.cmake 2018-11-27 15:29:55 UTC (rev 238552)
@@ -24,9 +24,6 @@
WEBKIT_ADD_TARGET_PROPERTIES(WebKit LINK_FLAGS "-Wl,--version-script,${CMAKE_CURRENT_SOURCE_DIR}/webkitglib-symbols.map")
endif ()
-# Temporary workaround to allow the build to succeed.
-file(REMOVE "${FORWARDING_HEADERS_DIR}/WebCore/Settings.h")
-
set(WebKit_USE_PREFIX_HEADER ON)
add_custom_target(webkitwpe-forwarding-headers
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [238551] trunk
Title: [238551] trunk Revision 238551 Author jfernan...@igalia.com Date 2018-11-27 05:52:57 -0800 (Tue, 27 Nov 2018) Log Message [css-grid] align-self center and position sticky don't work together https://bugs.webkit.org/show_bug.cgi?id=191963 Reviewed by Manuel Rego Casasnovas. LayoutTests/imported/w3c: This change makes several cases of the following tests to pass now. * web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-sticky-positioned-items-001-expected.txt: * web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-sticky-positioned-items-002-expected.txt: * web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-sticky-positioned-items-001-expected.txt: * web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-sticky-positioned-items-002-expected.txt: Source/WebCore: This is a fix for a regression introduced in r515391, where we landed the implementation of alignment for positioned objects in a Grid Layout container. We assumed that items with non-static positions shouldn't honor the CSS Box Alignment properties. This is only true for out-of-flow items, absolute or fixed positioned elements. However, sticky positioned elements are treated as relative positioned items, but they indeed use non-static position to define their behavior. No new tests, this change is covered by current tests and make several cases to pass now. * rendering/RenderGrid.cpp: (WebCore::RenderGrid::columnAxisPositionForChild const): (WebCore::RenderGrid::rowAxisPositionForChild const): Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-sticky-positioned-items-001-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-sticky-positioned-items-002-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-sticky-positioned-items-001-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-sticky-positioned-items-002-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderGrid.cpp Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (238550 => 238551) --- trunk/LayoutTests/imported/w3c/ChangeLog 2018-11-27 13:34:17 UTC (rev 238550) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2018-11-27 13:52:57 UTC (rev 238551) @@ -1,3 +1,17 @@ +2018-11-27 Javier Fernandez + +[css-grid] align-self center and position sticky don't work together +https://bugs.webkit.org/show_bug.cgi?id=191963 + +Reviewed by Manuel Rego Casasnovas. + +This change makes several cases of the following tests to pass now. + +* web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-sticky-positioned-items-001-expected.txt: +* web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-sticky-positioned-items-002-expected.txt: +* web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-sticky-positioned-items-001-expected.txt: +* web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-sticky-positioned-items-002-expected.txt: + 2018-11-26 Javier Fernandez [css-grid] absolute positioned child is sized wrongly when using auto-fit, generating spurious collapsed tracks Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-sticky-positioned-items-001-expected.txt (238550 => 238551) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-sticky-positioned-items-001-expected.txt 2018-11-27 13:34:17 UTC (rev 238550) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-sticky-positioned-items-001-expected.txt 2018-11-27 13:52:57 UTC (rev 238551) @@ -1,38 +1,4 @@ -FAIL .grid 1 assert_equals: - - - - - - - - - - - - - - - - -offsetTop expected 140 but got 100 -FAIL .grid 2 assert_equals: - - - - - - - - - - - - - - - - -offsetTop expected 140 but got 100 +PASS .grid 1 +PASS .grid 2 Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-sticky-positioned-items-002-expected.txt (238550 => 238551) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-sticky-positioned-items-002-expected.txt 2018-11-27 13:34:17 UTC (rev 238550) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-sticky-positioned-items-002-expected.txt 2018-11-27 13:52:57 UTC (rev 238551) @@ -1,38 +1,4 @@ -FAIL .grid 1 assert_equals: -
[webkit-changes] [238550] trunk/Source/WebKit
Title: [238550] trunk/Source/WebKit
Revision 238550
Author an...@apple.com
Date 2018-11-27 05:34:17 -0800 (Tue, 27 Nov 2018)
Log Message
Factor mask layer applying in RemoteLayerTreePropertyApplier into a shared function
https://bugs.webkit.org/show_bug.cgi?id=192001
Reviewed by Tim Horton.
* Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.h:
* Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm:
(WebKit::RemoteLayerTreePropertyApplier::applyProperties):
(WebKit::RemoteLayerTreePropertyApplier::updateMask):
Shared function, with some special tricks for iOS backdrop layers.
(WebKit::RemoteLayerTreePropertyApplier::applyPropertiesToUIView):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.h
trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (238549 => 238550)
--- trunk/Source/WebKit/ChangeLog 2018-11-27 12:39:27 UTC (rev 238549)
+++ trunk/Source/WebKit/ChangeLog 2018-11-27 13:34:17 UTC (rev 238550)
@@ -1,5 +1,21 @@
2018-11-27 Antti Koivisto
+Factor mask layer applying in RemoteLayerTreePropertyApplier into a shared function
+https://bugs.webkit.org/show_bug.cgi?id=192001
+
+Reviewed by Tim Horton.
+
+* Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.h:
+* Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm:
+(WebKit::RemoteLayerTreePropertyApplier::applyProperties):
+(WebKit::RemoteLayerTreePropertyApplier::updateMask):
+
+Shared function, with some special tricks for iOS backdrop layers.
+
+(WebKit::RemoteLayerTreePropertyApplier::applyPropertiesToUIView):
+
+2018-11-27 Antti Koivisto
+
Stop collecting related layers in RemoteLayerTreeHost::updateLayerTree
https://bugs.webkit.org/show_bug.cgi?id=192003
Modified: trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.h (238549 => 238550)
--- trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.h 2018-11-27 12:39:27 UTC (rev 238549)
+++ trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.h 2018-11-27 13:34:17 UTC (rev 238550)
@@ -41,6 +41,7 @@
private:
static void updateChildren(RemoteLayerTreeNode&, const RemoteLayerTreeTransaction::LayerProperties&, const RelatedLayerMap&);
+static void updateMask(RemoteLayerTreeNode&, const RemoteLayerTreeTransaction::LayerProperties&, const RelatedLayerMap&);
#if PLATFORM(IOS_FAMILY)
static void applyPropertiesToUIView(UIView *, const RemoteLayerTreeTransaction::LayerProperties&, const RelatedLayerMap&);
#endif
Modified: trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm (238549 => 238550)
--- trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm 2018-11-27 12:39:27 UTC (rev 238549)
+++ trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm 2018-11-27 13:34:17 UTC (rev 238550)
@@ -258,25 +258,14 @@
{
BEGIN_BLOCK_OBJC_EXCEPTIONS;
-CALayer *layer = node.layer();
-
-applyPropertiesToLayer(layer, layerTreeHost, properties, layerContentsType);
+applyPropertiesToLayer(node.layer(), layerTreeHost, properties, layerContentsType);
updateChildren(node, properties, relatedLayers);
+updateMask(node, properties, relatedLayers);
#if PLATFORM(IOS_FAMILY)
applyPropertiesToUIView(node.uiView(), properties, relatedLayers);
-#else
-if (properties.changedProperties & RemoteLayerTreeTransaction::MaskLayerChanged) {
-if (!properties.maskLayerID)
-layer.mask = nullptr;
-else {
-CALayer *maskLayer = relatedLayers.get(properties.maskLayerID)->layer();
-ASSERT(!maskLayer.superlayer);
-if (!maskLayer.superlayer)
-layer.mask = maskLayer;
-}
-}
#endif
+
END_BLOCK_OBJC_EXCEPTIONS;
}
@@ -328,30 +317,39 @@
node.layer().sublayers = sublayers.get();
}
-#if PLATFORM(IOS_FAMILY)
-void RemoteLayerTreePropertyApplier::applyPropertiesToUIView(UIView *view, const RemoteLayerTreeTransaction::LayerProperties& properties, const RelatedLayerMap& relatedLayers)
+void RemoteLayerTreePropertyApplier::updateMask(RemoteLayerTreeNode& node, const RemoteLayerTreeTransaction::LayerProperties& properties, const RelatedLayerMap& relatedLayers)
{
-if (properties.changedProperties.contains(RemoteLayerTreeTransaction::MaskLayerChanged)) {
-CALayer *maskOwnerLayer = view.layer;
+if (!properties.changedProperties.contains(RemoteLayerTreeTransaction::MaskLayerChanged))
+return;
+auto maskOwnerLayer = [&] {
+CALayer *layer = node.layer();
+#if PLATFORM(IOS_FAMILY)
if (properties.customAppearance == GraphicsLayer::CustomAppearance::LightBackdrop || properties.customAppearance == GraphicsLayer::CustomAppearance::DarkBackdrop) {
// This is a
[webkit-changes] [238549] trunk/Source/WebKit
Title: [238549] trunk/Source/WebKit
Revision 238549
Author an...@apple.com
Date 2018-11-27 04:39:27 -0800 (Tue, 27 Nov 2018)
Log Message
Stop collecting related layers in RemoteLayerTreeHost::updateLayerTree
https://bugs.webkit.org/show_bug.cgi?id=192003
Reviewed by Tim Horton.
We can pass the node hash directly to RemoteLayerTreePropertyApplier. The collection step doesn't seem
to add anything except an extra hash lookup.
* Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.h:
* UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::updateLayerTree):
Pass m_nodes directly.
Some random cleanups.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.h
trunk/Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (238548 => 238549)
--- trunk/Source/WebKit/ChangeLog 2018-11-27 12:27:29 UTC (rev 238548)
+++ trunk/Source/WebKit/ChangeLog 2018-11-27 12:39:27 UTC (rev 238549)
@@ -1,5 +1,22 @@
2018-11-27 Antti Koivisto
+Stop collecting related layers in RemoteLayerTreeHost::updateLayerTree
+https://bugs.webkit.org/show_bug.cgi?id=192003
+
+Reviewed by Tim Horton.
+
+We can pass the node hash directly to RemoteLayerTreePropertyApplier. The collection step doesn't seem
+to add anything except an extra hash lookup.
+
+* Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.h:
+* UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:
+(WebKit::RemoteLayerTreeHost::updateLayerTree):
+
+Pass m_nodes directly.
+Some random cleanups.
+
+2018-11-27 Antti Koivisto
+
Remote tile layers shouldn't be UIViews
https://bugs.webkit.org/show_bug.cgi?id=191953
Modified: trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.h (238548 => 238549)
--- trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.h 2018-11-27 12:27:29 UTC (rev 238548)
+++ trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.h 2018-11-27 12:39:27 UTC (rev 238549)
@@ -35,7 +35,7 @@
class RemoteLayerTreePropertyApplier {
public:
-using RelatedLayerMap = HashMap;
+using RelatedLayerMap = HashMap>;
static void applyProperties(RemoteLayerTreeNode&, RemoteLayerTreeHost*, const RemoteLayerTreeTransaction::LayerProperties&, const RelatedLayerMap&, RemoteLayerBackingStore::LayerContentsType);
static void applyPropertiesToLayer(CALayer *, RemoteLayerTreeHost*, const RemoteLayerTreeTransaction::LayerProperties&, RemoteLayerBackingStore::LayerContentsType);
Modified: trunk/Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm (238548 => 238549)
--- trunk/Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm 2018-11-27 12:27:29 UTC (rev 238548)
+++ trunk/Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm 2018-11-27 12:39:27 UTC (rev 238549)
@@ -82,8 +82,11 @@
rootLayerChanged = true;
}
-typedef std::pair LayerIDPair;
-Vector clonesToUpdate;
+struct LayerAndClone {
+GraphicsLayer::PlatformLayerID layerID;
+GraphicsLayer::PlatformLayerID cloneLayerID;
+};
+Vector clonesToUpdate;
#if PLATFORM(MAC) || PLATFORM(IOSMAC)
// Can't use the iOS code on macOS yet: rdar://problem/31247730
@@ -99,33 +102,20 @@
auto* node = nodeForID(layerID);
ASSERT(node);
-RemoteLayerTreePropertyApplier::RelatedLayerMap relatedLayers;
-if (properties.changedProperties & RemoteLayerTreeTransaction::ChildrenChanged) {
-for (auto& child : properties.children)
-relatedLayers.set(child, nodeForID(child));
-}
+if (properties.changedProperties.contains(RemoteLayerTreeTransaction::ClonedContentsChanged) && properties.clonedLayerID)
+clonesToUpdate.append({ layerID, properties.clonedLayerID });
-if (properties.changedProperties & RemoteLayerTreeTransaction::MaskLayerChanged && properties.maskLayerID)
-relatedLayers.set(properties.maskLayerID, nodeForID(properties.maskLayerID));
+RemoteLayerTreePropertyApplier::applyProperties(*node, this, properties, m_nodes, layerContentsType);
-if (properties.changedProperties & RemoteLayerTreeTransaction::ClonedContentsChanged && properties.clonedLayerID)
-clonesToUpdate.append(LayerIDPair(layerID, properties.clonedLayerID));
-
if (m_isDebugLayerTreeHost) {
-RemoteLayerTreePropertyApplier::applyProperties(*node, this, properties, relatedLayers, layerContentsType);
-
-if (properties.changedProperties & RemoteLayerTreeTransaction::BorderWidthChanged)
+if (properties.changedProperties.contains(RemoteLayerTreeTransaction::BorderWidthChanged))
node->layer().borderWidth = properties.borderWidth / indicatorScaleFactor;
[webkit-changes] [238548] trunk/Tools
Title: [238548] trunk/Tools
Revision 238548
Author aakash_j...@apple.com
Date 2018-11-27 04:27:29 -0800 (Tue, 27 Nov 2018)
Log Message
[ews-app] Add support to communicate with Buildbot (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=191935
Unreviewed infrastructure fix.
* BuildSlaveSupport/ews-app/ews/common/buildbot.py:
(Buildbot.send_patch_to_buildbot):
Modified Paths
trunk/Tools/BuildSlaveSupport/ews-app/ews/common/buildbot.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-app/ews/common/buildbot.py (238547 => 238548)
--- trunk/Tools/BuildSlaveSupport/ews-app/ews/common/buildbot.py 2018-11-27 09:12:03 UTC (rev 238547)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/common/buildbot.py 2018-11-27 12:27:29 UTC (rev 238548)
@@ -34,7 +34,7 @@
def send_patch_to_buildbot(cls, patch_path, properties=[]):
command = ['buildbot', 'try',
'--connect=pb',
- '--master={}:{}'.format(config.BUG_SERVER_HOST, config.BUILDBOT_SERVER_PORT),
+ '--master={}:{}'.format(config.BUILDBOT_SERVER_HOST, config.BUILDBOT_SERVER_PORT),
'--username={}'.format(config.BUILDBOT_PB_USERNAME),
'--passwd={}'.format(config.BUILDBOT_PB_PASSWORD),
'--diff={}'.format(patch_path),
Modified: trunk/Tools/ChangeLog (238547 => 238548)
--- trunk/Tools/ChangeLog 2018-11-27 09:12:03 UTC (rev 238547)
+++ trunk/Tools/ChangeLog 2018-11-27 12:27:29 UTC (rev 238548)
@@ -1,3 +1,14 @@
+2018-11-27 Aakash Jain
+
+[ews-app] Add support to communicate with Buildbot (Follow-up fix)
+https://bugs.webkit.org/show_bug.cgi?id=191935
+
+
+Unreviewed infrastructure fix.
+
+* BuildSlaveSupport/ews-app/ews/common/buildbot.py:
+(Buildbot.send_patch_to_buildbot):
+
2018-11-26 Wenson Hsieh
[Cocoa] No way for clients to tell whether the content view is in the responder chain when the web view is
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [238547] trunk/Source/WebKit
Title: [238547] trunk/Source/WebKit Revision 238547 Author an...@apple.com Date 2018-11-27 01:12:03 -0800 (Tue, 27 Nov 2018) Log Message Remote tile layers shouldn't be UIViews https://bugs.webkit.org/show_bug.cgi?id=191953 Reviewed by Tim Horton. They don't need any UIView functionality, nor do they ever have UIView descendants. We can use lighter weight objects. * Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.h: * Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm: (WebKit::RemoteLayerTreePropertyApplier::applyProperties): (WebKit::RemoteLayerTreePropertyApplier::updateChildren): Factor to a function shared between platforms. Support having both views and plain layers in the same tree. Assert that all siblings are of the same type and that we don't attempt to add views to layers. (WebKit::RemoteLayerTreePropertyApplier::applyPropertiesToUIView): * UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm: (WebKit::RemoteLayerTreeHost::makeNode): Use new plain layer on Mac too. * UIProcess/RemoteLayerTree/RemoteLayerTreeNode.h: * UIProcess/RemoteLayerTree/RemoteLayerTreeNode.mm: (-[WKPlainRemoteLayer description]): Add a CALayer subclass so we can have a description, similar to WKCompositingView and pals. (WebKit::RemoteLayerTreeNode::createWithPlainLayer): (WebKit::RemoteLayerTreeNode::detachFromParent): Support having null view. (WebKit::RemoteLayerTreeNode::appendLayerDescription): Helper for layer descriptions. * UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm: (WebKit::RemoteLayerTreeHost::makeNode): Construct plain layers for tiles. * UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm: (-[WKCompositingView description]): (-[WKUIRemoteView description]): (-[WKBackdropView description]): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.h trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm trunk/Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm trunk/Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.h trunk/Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.mm trunk/Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm trunk/Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm Diff Modified: trunk/Source/WebKit/ChangeLog (238546 => 238547) --- trunk/Source/WebKit/ChangeLog 2018-11-27 08:59:00 UTC (rev 238546) +++ trunk/Source/WebKit/ChangeLog 2018-11-27 09:12:03 UTC (rev 238547) @@ -1,3 +1,53 @@ +2018-11-27 Antti Koivisto + +Remote tile layers shouldn't be UIViews +https://bugs.webkit.org/show_bug.cgi?id=191953 + +Reviewed by Tim Horton. + +They don't need any UIView functionality, nor do they ever have UIView descendants. +We can use lighter weight objects. + +* Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.h: +* Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm: +(WebKit::RemoteLayerTreePropertyApplier::applyProperties): +(WebKit::RemoteLayerTreePropertyApplier::updateChildren): + +Factor to a function shared between platforms. +Support having both views and plain layers in the same tree. +Assert that all siblings are of the same type and that we don't attempt to add views to layers. + +(WebKit::RemoteLayerTreePropertyApplier::applyPropertiesToUIView): +* UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm: +(WebKit::RemoteLayerTreeHost::makeNode): + +Use new plain layer on Mac too. + +* UIProcess/RemoteLayerTree/RemoteLayerTreeNode.h: +* UIProcess/RemoteLayerTree/RemoteLayerTreeNode.mm: +(-[WKPlainRemoteLayer description]): + +Add a CALayer subclass so we can have a description, similar to WKCompositingView and pals. + +(WebKit::RemoteLayerTreeNode::createWithPlainLayer): +(WebKit::RemoteLayerTreeNode::detachFromParent): + +Support having null view. + +(WebKit::RemoteLayerTreeNode::appendLayerDescription): + +Helper for layer descriptions. + +* UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm: +(WebKit::RemoteLayerTreeHost::makeNode): + +Construct plain layers for tiles. + +* UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm: +(-[WKCompositingView description]): +(-[WKUIRemoteView description]): +(-[WKBackdropView description]): + 2018-11-27 Fujii Hironori Remove "using namespace WebCore" under Source/WebKit/WebProcess/InjectedBundle/API Modified: trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.h (238546 => 238547) --- trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.h 2018-11-27 08:59:00 UTC (rev 238546) +++ trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.h 2018-11-27 09:12:03 UTC (rev 238547) @@ -40,6 +40,7 @@ static
[webkit-changes] [238546] trunk/Source/WebKit
Title: [238546] trunk/Source/WebKit
Revision 238546
Author hironori.fu...@sony.com
Date 2018-11-27 00:59:00 -0800 (Tue, 27 Nov 2018)
Log Message
Remove "using namespace WebCore" under Source/WebKit/WebProcess/InjectedBundle/API
https://bugs.webkit.org/show_bug.cgi?id=191995
Reviewed by Alex Christensen.
The statement "using namespace WebCore" should be placed inside
namespace WebKit for unified source builds. But, source files
defining WebKit API can't be enclosed by namespace WebKit { }
becuase they are defined in the global scope.
"using namespace WebCore" in global scope and unified source
builds may cause build breaks (Bug 191853).
Remove "using namespace WebCore" in the global scope. Use
"WebCore::" prefix instead.
* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleClearAllDatabases):
(WKBundleSetDatabaseQuota):
(WKBundleClearResourceLoadStatistics):
(WKBundleResourceLoadStatisticsNotifyObserver):
* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameGetFrameLoadState):
(WKBundleFrameClearOpener):
(WKBundleFrameCallShouldCloseOnWebView):
(WKBundleFrameCopySecurityOrigin):
(WKBundleFrameFocus):
* WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp:
* WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundle.cpp
trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp
trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp
trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (238545 => 238546)
--- trunk/Source/WebKit/ChangeLog 2018-11-27 04:17:11 UTC (rev 238545)
+++ trunk/Source/WebKit/ChangeLog 2018-11-27 08:59:00 UTC (rev 238546)
@@ -1,3 +1,35 @@
+2018-11-27 Fujii Hironori
+
+Remove "using namespace WebCore" under Source/WebKit/WebProcess/InjectedBundle/API
+https://bugs.webkit.org/show_bug.cgi?id=191995
+
+Reviewed by Alex Christensen.
+
+The statement "using namespace WebCore" should be placed inside
+namespace WebKit for unified source builds. But, source files
+defining WebKit API can't be enclosed by namespace WebKit { }
+becuase they are defined in the global scope.
+
+"using namespace WebCore" in global scope and unified source
+builds may cause build breaks (Bug 191853).
+
+Remove "using namespace WebCore" in the global scope. Use
+"WebCore::" prefix instead.
+
+* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
+(WKBundleClearAllDatabases):
+(WKBundleSetDatabaseQuota):
+(WKBundleClearResourceLoadStatistics):
+(WKBundleResourceLoadStatisticsNotifyObserver):
+* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
+(WKBundleFrameGetFrameLoadState):
+(WKBundleFrameClearOpener):
+(WKBundleFrameCallShouldCloseOnWebView):
+(WKBundleFrameCopySecurityOrigin):
+(WKBundleFrameFocus):
+* WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp:
+* WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
+
2018-11-26 Wenson Hsieh
[Cocoa] No way for clients to tell whether the content view is in the responder chain when the web view is
Modified: trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundle.cpp (238545 => 238546)
--- trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundle.cpp 2018-11-27 04:17:11 UTC (rev 238545)
+++ trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundle.cpp 2018-11-27 08:59:00 UTC (rev 238546)
@@ -48,7 +48,6 @@
#include
#include
-using namespace WebCore;
using namespace WebKit;
WKTypeID WKBundleGetTypeID()
@@ -250,13 +249,13 @@
void WKBundleClearAllDatabases(WKBundleRef)
{
-DatabaseTracker::singleton().deleteAllDatabasesImmediately();
+WebCore::DatabaseTracker::singleton().deleteAllDatabasesImmediately();
}
void WKBundleSetDatabaseQuota(WKBundleRef bundleRef, uint64_t quota)
{
// Historically, we've used the following (somewhat nonsensical) string for the databaseIdentifier of local files.
-DatabaseTracker::singleton().setQuota(*SecurityOriginData::fromDatabaseIdentifier("file__0"), quota);
+WebCore::DatabaseTracker::singleton().setQuota(*SecurityOriginData::fromDatabaseIdentifier("file__0"), quota);
}
void WKBundleReleaseMemory(WKBundleRef)
@@ -321,12 +320,12 @@
void WKBundleClearResourceLoadStatistics(WKBundleRef)
{
-ResourceLoadObserver::shared().clearState();
+WebCore::ResourceLoadObserver::shared().clearState();
}
void WKBundleResourceLoadStatisticsNotifyObserver(WKBundleRef)
{
-ResourceLoadObserver::shared().notifyObserver();
+WebCore::ResourceLoadObserver::shared().notifyObserver();
}
Modified: trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp (238545 => 238546)
---
