date:20181130

[webkit-changes] [238777] trunk/Source/WebKit

2018-11-30 Thread achristensen

Title: [238777] trunk/Source/WebKit








Revision 238777
Author achristen...@apple.com
Date 2018-11-30 22:17:55 -0800 (Fri, 30 Nov 2018)


Log Message
Fix Windows build.

* UIProcess/API/C/curl/WKWebsiteDataStoreRefCurl.cpp:
(WKWebsiteDataStoreEnableCustomNetworkProxySettings):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/C/curl/WKWebsiteDataStoreRefCurl.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (238776 => 238777)

--- trunk/Source/WebKit/ChangeLog	2018-12-01 05:58:58 UTC (rev 238776)
+++ trunk/Source/WebKit/ChangeLog	2018-12-01 06:17:55 UTC (rev 238777)
@@ -1,5 +1,12 @@
 2018-11-30  Alex Christensen  
 
+Fix Windows build.
+
+* UIProcess/API/C/curl/WKWebsiteDataStoreRefCurl.cpp:
+(WKWebsiteDataStoreEnableCustomNetworkProxySettings):
+
+2018-11-30  Alex Christensen  
+
 Move URL from WebCore to WTF
 https://bugs.webkit.org/show_bug.cgi?id=190234
 


Modified: trunk/Source/WebKit/UIProcess/API/C/curl/WKWebsiteDataStoreRefCurl.cpp (238776 => 238777)

--- trunk/Source/WebKit/UIProcess/API/C/curl/WKWebsiteDataStoreRefCurl.cpp	2018-12-01 05:58:58 UTC (rev 238776)
+++ trunk/Source/WebKit/UIProcess/API/C/curl/WKWebsiteDataStoreRefCurl.cpp	2018-12-01 06:17:55 UTC (rev 238777)
@@ -29,8 +29,8 @@
 #include "APIWebsiteDataStore.h"
 #include "WKAPICast.h"
 #include 
-#include 
 #include 
+#include 
 
 using namespace WebKit;
 
@@ -41,7 +41,7 @@
 
 void WKWebsiteDataStoreEnableCustomNetworkProxySettings(WKWebsiteDataStoreRef dataStoreRef, WKURLRef proxyUrl, WKStringRef ignoreHosts)
 {
-toImpl(dataStoreRef)->websiteDataStore().setNetworkProxySettings(WebCore::CurlProxySettings(WebCore::URL(WebCore::URL(), toWTFString(proxyUrl)), toWTFString(ignoreHosts)));
+toImpl(dataStoreRef)->websiteDataStore().setNetworkProxySettings(WebCore::CurlProxySettings(URL(URL(), toWTFString(proxyUrl)), toWTFString(ignoreHosts)));
 }
 
 void WKWebsiteDataStoreDisableNetworkProxySettings(WKWebsiteDataStoreRef dataStoreRef)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238776] trunk/Tools

2018-11-30 Thread zalan

Title: [238776] trunk/Tools








Revision 238776
Author za...@apple.com
Date 2018-11-30 21:58:58 -0800 (Fri, 30 Nov 2018)


Log Message
Unreviewed LFC passing test list update.

* LayoutReloaded/misc/LFC-passing-tests.txt:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/LayoutReloaded/misc/LFC-passing-tests.txt




Diff

Modified: trunk/Tools/ChangeLog (238775 => 238776)

--- trunk/Tools/ChangeLog	2018-12-01 04:58:40 UTC (rev 238775)
+++ trunk/Tools/ChangeLog	2018-12-01 05:58:58 UTC (rev 238776)
@@ -1,3 +1,9 @@
+2018-11-30  Zalan Bujtas  
+
+Unreviewed LFC passing test list update.
+
+* LayoutReloaded/misc/LFC-passing-tests.txt:
+
 2018-11-30  Alex Christensen  
 
 Move URL from WebCore to WTF


Modified: trunk/Tools/LayoutReloaded/misc/LFC-passing-tests.txt (238775 => 238776)

--- trunk/Tools/LayoutReloaded/misc/LFC-passing-tests.txt	2018-12-01 04:58:40 UTC (rev 238775)
+++ trunk/Tools/LayoutReloaded/misc/LFC-passing-tests.txt	2018-12-01 05:58:58 UTC (rev 238776)
@@ -147,3 +147,26 @@
 fast/block/positioning/054.html
 fast/block/inside-inlines/basic-float-intrusion.html
 fast/block/inside-inlines/crash-on-first-line-change.html
+fast/borders/0px-borders-no-line-height.html
+fast/borders/0px-borders.html
+fast/borders/block-mask-overlay-image-outset.html
+fast/borders/block-mask-overlay-image.html
+fast/borders/border-image-reset-by-border-shorthand.html
+fast/borders/border-image-scaled-gradient.html
+fast/borders/border-image-slice-omission.html
+fast/borders/border-left-right-same-bottom-different-color.html
+fast/borders/border-painting-dashed-at-all.html
+fast/borders/border-painting-dashed.html
+fast/borders/border-painting-dotted-at-all.html
+fast/borders/border-painting-dotted.html
+fast/borders/border-painting-double-at-all.html
+fast/borders/border-painting-double.html
+fast/borders/border-painting-groove-at-all.html
+fast/borders/border-painting-inset-at-all.html
+fast/borders/border-painting-inset.html
+fast/borders/border-painting-outset-at-all.html
+fast/borders/border-painting-outset.html
+fast/borders/border-painting-ridge-at-all.html
+fast/borders/border-painting-solid-at-all.html
+fast/borders/border-painting-solid.html
+fast/inline-block/004.html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238775] trunk/Source/WebKitLegacy/win

2018-11-30 Thread achristensen

Title: [238775] trunk/Source/WebKitLegacy/win








Revision 238775
Author achristen...@apple.com
Date 2018-11-30 20:58:40 -0800 (Fri, 30 Nov 2018)


Log Message
Fix Windows build.

* WebView.cpp:

Modified Paths

trunk/Source/WebKitLegacy/win/ChangeLog
trunk/Source/WebKitLegacy/win/WebView.cpp




Diff

Modified: trunk/Source/WebKitLegacy/win/ChangeLog (238774 => 238775)

--- trunk/Source/WebKitLegacy/win/ChangeLog	2018-12-01 04:49:56 UTC (rev 238774)
+++ trunk/Source/WebKitLegacy/win/ChangeLog	2018-12-01 04:58:40 UTC (rev 238775)
@@ -2,6 +2,12 @@
 
 Fix Windows build.
 
+* WebView.cpp:
+
+2018-11-30  Alex Christensen  
+
+Fix Windows build.
+
 * WebCoreSupport/WebFrameLoaderClient.h:
 
 2018-11-30  Alex Christensen  


Modified: trunk/Source/WebKitLegacy/win/WebView.cpp (238774 => 238775)

--- trunk/Source/WebKitLegacy/win/WebView.cpp	2018-12-01 04:49:56 UTC (rev 238774)
+++ trunk/Source/WebKitLegacy/win/WebView.cpp	2018-12-01 04:58:40 UTC (rev 238775)
@@ -186,8 +186,8 @@
 #if USE(CFURLCONNECTION)
 #include 
 #include 
-#include 
 #include 
+#include 
 #elif USE(CURL)
 #include 
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238774] trunk/Source

2018-11-30 Thread achristensen

Title: [238774] trunk/Source








Revision 238774
Author achristen...@apple.com
Date 2018-11-30 20:49:56 -0800 (Fri, 30 Nov 2018)


Log Message
Fix Windows build.

Source/WebCore:

* platform/network/curl/CookieJarCurl.cpp:
* platform/network/curl/PublicSuffixCurl.cpp:

Source/WebKitLegacy/win:

* WebCoreSupport/WebFrameLoaderClient.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/curl/CookieJarCurl.cpp
trunk/Source/WebCore/platform/network/curl/PublicSuffixCurl.cpp
trunk/Source/WebKitLegacy/win/ChangeLog
trunk/Source/WebKitLegacy/win/WebCoreSupport/WebFrameLoaderClient.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (238773 => 238774)

--- trunk/Source/WebCore/ChangeLog	2018-12-01 04:42:51 UTC (rev 238773)
+++ trunk/Source/WebCore/ChangeLog	2018-12-01 04:49:56 UTC (rev 238774)
@@ -2,6 +2,13 @@
 
 Fix Windows build.
 
+* platform/network/curl/CookieJarCurl.cpp:
+* platform/network/curl/PublicSuffixCurl.cpp:
+
+2018-11-30  Alex Christensen  
+
+Fix Windows build.
+
 * platform/network/curl/CookieJarCurl.h:
 
 2018-11-30  Alex Christensen  


Modified: trunk/Source/WebCore/platform/network/curl/CookieJarCurl.cpp (238773 => 238774)

--- trunk/Source/WebCore/platform/network/curl/CookieJarCurl.cpp	2018-12-01 04:42:51 UTC (rev 238773)
+++ trunk/Source/WebCore/platform/network/curl/CookieJarCurl.cpp	2018-12-01 04:49:56 UTC (rev 238774)
@@ -31,9 +31,9 @@
 #include "CookieRequestHeaderFieldProxy.h"
 #include "NetworkStorageSession.h"
 #include "NotImplemented.h"
-#include "URL.h"
 
 #include 
+#include 
 #include 
 #include 
 


Modified: trunk/Source/WebCore/platform/network/curl/PublicSuffixCurl.cpp (238773 => 238774)

--- trunk/Source/WebCore/platform/network/curl/PublicSuffixCurl.cpp	2018-12-01 04:42:51 UTC (rev 238773)
+++ trunk/Source/WebCore/platform/network/curl/PublicSuffixCurl.cpp	2018-12-01 04:49:56 UTC (rev 238774)
@@ -28,8 +28,8 @@
 
 #if ENABLE(PUBLIC_SUFFIX_LIST)
 
-#include "URL.h"
 #include 
+#include 
 
 namespace WebCore {
 


Modified: trunk/Source/WebKitLegacy/win/ChangeLog (238773 => 238774)

--- trunk/Source/WebKitLegacy/win/ChangeLog	2018-12-01 04:42:51 UTC (rev 238773)
+++ trunk/Source/WebKitLegacy/win/ChangeLog	2018-12-01 04:49:56 UTC (rev 238774)
@@ -6,6 +6,12 @@
 
 2018-11-30  Alex Christensen  
 
+Fix Windows build.
+
+* WebCoreSupport/WebFrameLoaderClient.h:
+
+2018-11-30  Alex Christensen  
+
 Move URL from WebCore to WTF
 https://bugs.webkit.org/show_bug.cgi?id=190234
 


Modified: trunk/Source/WebKitLegacy/win/WebCoreSupport/WebFrameLoaderClient.h (238773 => 238774)

--- trunk/Source/WebKitLegacy/win/WebCoreSupport/WebFrameLoaderClient.h	2018-12-01 04:42:51 UTC (rev 238773)
+++ trunk/Source/WebKitLegacy/win/WebCoreSupport/WebFrameLoaderClient.h	2018-12-01 04:49:56 UTC (rev 238774)
@@ -184,15 +184,9 @@
 
 bool canCachePage() const override;
 
-<<< HEAD
-RefPtr createFrame(const WebCore::URL&, const WTF::String& name, WebCore::HTMLFrameOwnerElement&,
+RefPtr createFrame(const URL&, const WTF::String& name, WebCore::HTMLFrameOwnerElement&,
 const WTF::String& referrer) override;
-RefPtr createPlugin(const WebCore::IntSize&, WebCore::HTMLPlugInElement&, const WebCore::URL&, const Vector&, const Vector&, const WTF::String&, bool loadManually) override;
-===
-RefPtr createFrame(const URL&, const WTF::String& name, WebCore::HTMLFrameOwnerElement&,
-const WTF::String& referrer, bool allowsScrolling, int marginWidth, int marginHeight) override;
 RefPtr createPlugin(const WebCore::IntSize&, WebCore::HTMLPlugInElement&, const URL&, const Vector&, const Vector&, const WTF::String&, bool loadManually) override;
->>> changes
 void recreatePlugin(WebCore::Widget*) override { }
 void redirectDataToPlugin(WebCore::Widget&) override;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238773] trunk/Source

2018-11-30 Thread achristensen

Title: [238773] trunk/Source








Revision 238773
Author achristen...@apple.com
Date 2018-11-30 20:42:51 -0800 (Fri, 30 Nov 2018)


Log Message
Fix Windows build.

Source/WebCore:

* platform/network/curl/CookieJarCurl.h:

Source/WebKitLegacy/win:

* WebCoreSupport/WebFrameLoaderClient.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/curl/CookieJarCurl.h
trunk/Source/WebKitLegacy/win/ChangeLog
trunk/Source/WebKitLegacy/win/WebCoreSupport/WebFrameLoaderClient.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (238772 => 238773)

--- trunk/Source/WebCore/ChangeLog	2018-12-01 04:28:18 UTC (rev 238772)
+++ trunk/Source/WebCore/ChangeLog	2018-12-01 04:42:51 UTC (rev 238773)
@@ -1,5 +1,11 @@
 2018-11-30  Alex Christensen  
 
+Fix Windows build.
+
+* platform/network/curl/CookieJarCurl.h:
+
+2018-11-30  Alex Christensen  
+
 Move URL from WebCore to WTF
 https://bugs.webkit.org/show_bug.cgi?id=190234
 


Modified: trunk/Source/WebCore/platform/network/curl/CookieJarCurl.h (238772 => 238773)

--- trunk/Source/WebCore/platform/network/curl/CookieJarCurl.h	2018-12-01 04:28:18 UTC (rev 238772)
+++ trunk/Source/WebCore/platform/network/curl/CookieJarCurl.h	2018-12-01 04:42:51 UTC (rev 238773)
@@ -26,6 +26,7 @@
 
 #include 
 #include 
+#include 
 #include 
 #include 
 
@@ -32,7 +33,6 @@
 namespace WebCore {
 
 class NetworkStorageSession;
-class URL;
 enum class IncludeSecureCookies : bool;
 struct Cookie;
 struct CookieRequestHeaderFieldProxy;


Modified: trunk/Source/WebKitLegacy/win/ChangeLog (238772 => 238773)

--- trunk/Source/WebKitLegacy/win/ChangeLog	2018-12-01 04:28:18 UTC (rev 238772)
+++ trunk/Source/WebKitLegacy/win/ChangeLog	2018-12-01 04:42:51 UTC (rev 238773)
@@ -1,5 +1,11 @@
 2018-11-30  Alex Christensen  
 
+Fix Windows build.
+
+* WebCoreSupport/WebFrameLoaderClient.h:
+
+2018-11-30  Alex Christensen  
+
 Move URL from WebCore to WTF
 https://bugs.webkit.org/show_bug.cgi?id=190234
 


Modified: trunk/Source/WebKitLegacy/win/WebCoreSupport/WebFrameLoaderClient.h (238772 => 238773)

--- trunk/Source/WebKitLegacy/win/WebCoreSupport/WebFrameLoaderClient.h	2018-12-01 04:28:18 UTC (rev 238772)
+++ trunk/Source/WebKitLegacy/win/WebCoreSupport/WebFrameLoaderClient.h	2018-12-01 04:42:51 UTC (rev 238773)
@@ -85,11 +85,7 @@
 void dispatchDidDispatchOnloadEvents() override;
 void dispatchDidReceiveServerRedirectForProvisionalLoad() override;
 void dispatchDidCancelClientRedirect() override;
-<<< HEAD
-void dispatchWillPerformClientRedirect(const WebCore::URL&, double interval, WallTime fireDate, WebCore::LockBackForwardList) override;
-===
-void dispatchWillPerformClientRedirect(const URL&, double interval, WallTime fireDate) override;
->>> changes
+void dispatchWillPerformClientRedirect(const URL&, double interval, WallTime fireDate, WebCore::LockBackForwardList) override;
 void dispatchDidChangeLocationWithinPage() override;
 void dispatchDidPushStateWithinPage() override;
 void dispatchDidReplaceStateWithinPage() override;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238772] trunk/Source/WTF

2018-11-30 Thread achristensen

Title: [238772] trunk/Source/WTF








Revision 238772
Author achristen...@apple.com
Date 2018-11-30 20:28:18 -0800 (Fri, 30 Nov 2018)


Log Message
Fix Windows build after r238771
https://bugs.webkit.org/show_bug.cgi?id=190234

* wtf/URLParser.h:
Just make defaultPortForProtocol public so we don't have to worry about DLL linkage.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/URLParser.h




Diff

Modified: trunk/Source/WTF/ChangeLog (238771 => 238772)

--- trunk/Source/WTF/ChangeLog	2018-12-01 03:28:36 UTC (rev 238771)
+++ trunk/Source/WTF/ChangeLog	2018-12-01 04:28:18 UTC (rev 238772)
@@ -1,5 +1,13 @@
 2018-11-30  Alex Christensen  
 
+Fix Windows build after r238771
+https://bugs.webkit.org/show_bug.cgi?id=190234
+
+* wtf/URLParser.h:
+Just make defaultPortForProtocol public so we don't have to worry about DLL linkage.
+
+2018-11-30  Alex Christensen  
+
 Move URL from WebCore to WTF
 https://bugs.webkit.org/show_bug.cgi?id=190234
 


Modified: trunk/Source/WTF/wtf/URLParser.h (238771 => 238772)

--- trunk/Source/WTF/wtf/URLParser.h	2018-12-01 03:28:36 UTC (rev 238771)
+++ trunk/Source/WTF/wtf/URLParser.h	2018-12-01 04:28:18 UTC (rev 238772)
@@ -50,12 +50,12 @@
 static const UIDNA& internationalDomainNameTranscoder();
 static bool isInUserInfoEncodeSet(UChar);
 
+static std::optional defaultPortForProtocol(StringView);
+
 private:
 URLParser(const String&, const URL& = { }, const URLTextEncoding* = nullptr);
 URL result() { return m_url; }
 
-static std::optional defaultPortForProtocol(StringView);
-friend std::optional defaultPortForProtocol(StringView);
 friend class URL;
 
 URL m_url;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238770] trunk/LayoutTests

2018-11-30 Thread youenn

Title: [238770] trunk/LayoutTests








Revision 238770
Author you...@apple.com
Date 2018-11-30 19:25:50 -0800 (Fri, 30 Nov 2018)


Log Message
Test that CSS subresource loading are exposed to resource timing in case of a CORS loaded CSS stylesheet but not imported stylesheets
https://bugs.webkit.org/show_bug.cgi?id=192232

Reviewed by Dean Jackson.

* http/tests/security/cross-origin-clean-css-resource-timing-expected.txt: Added.
* http/tests/security/cross-origin-clean-css-resource-timing.html: Added.
* http/tests/security/resources/loading-subresources.php: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/http/tests/security/cross-origin-clean-css-resource-timing-expected.txt
trunk/LayoutTests/http/tests/security/cross-origin-clean-css-resource-timing.html
trunk/LayoutTests/http/tests/security/resources/loading-subresources.php




Diff

Modified: trunk/LayoutTests/ChangeLog (238769 => 238770)

--- trunk/LayoutTests/ChangeLog	2018-12-01 03:09:40 UTC (rev 238769)
+++ trunk/LayoutTests/ChangeLog	2018-12-01 03:25:50 UTC (rev 238770)
@@ -1,3 +1,14 @@
+2018-11-30  Youenn Fablet  
+
+Test that CSS subresource loading are exposed to resource timing in case of a CORS loaded CSS stylesheet but not imported stylesheets
+https://bugs.webkit.org/show_bug.cgi?id=192232
+
+Reviewed by Dean Jackson.
+
+* http/tests/security/cross-origin-clean-css-resource-timing-expected.txt: Added.
+* http/tests/security/cross-origin-clean-css-resource-timing.html: Added.
+* http/tests/security/resources/loading-subresources.php: Added.
+
 2018-11-30  Truitt Savell  
 
 Rebaseline test after https://trac.webkit.org/changeset/238725/webkit


Added: trunk/LayoutTests/http/tests/security/cross-origin-clean-css-resource-timing-expected.txt (0 => 238770)

--- trunk/LayoutTests/http/tests/security/cross-origin-clean-css-resource-timing-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/security/cross-origin-clean-css-resource-timing-expected.txt	2018-12-01 03:25:50 UTC (rev 238770)
@@ -0,0 +1,3 @@
+
+PASS CSS subresources of a clean stylesheet should populate resource timing entries, but not for imported stylesheets 
+


Added: trunk/LayoutTests/http/tests/security/cross-origin-clean-css-resource-timing.html (0 => 238770)

--- trunk/LayoutTests/http/tests/security/cross-origin-clean-css-resource-timing.html	(rev 0)
+++ trunk/LayoutTests/http/tests/security/cross-origin-clean-css-resource-timing.html	2018-12-01 03:25:50 UTC (rev 238770)
@@ -0,0 +1,51 @@
+
+
+
+CSS subresources of a clean stylesheet should populate resource timing entries, but not for imported stylesheets
+
+
+
+Test
+