[webkit-changes] [238927] trunk/Source/WebKit

[rniwa]

Title: [238927] trunk/Source/WebKit








Revision 238927
Author rn...@webkit.org
Date 2018-12-05 22:12:28 -0800 (Wed, 05 Dec 2018)


Log Message
REGRESSION(PSON): Process swapping code doesn't set DisplayID in WebContent process
https://bugs.webkit.org/show_bug.cgi?id=192290

Reviewed by Simon Fraser.

Fixed the bug by updating the DisplayID upon attaching to a WebContent process
after a process swap as well as after the previous WebContent process had crashed.

Unfortunately no new tests since WebKitTestRunner / DumpRenderTree should use 0 as DisplayID
as they have an off-screen NSWindow. The issue that this results in no fallback for
the animation timer is tracked by webkit.org/b/192448.

* UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::didRelaunchProcess):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (238926 => 238927)

--- trunk/Source/WebKit/ChangeLog	2018-12-06 04:45:57 UTC (rev 238926)
+++ trunk/Source/WebKit/ChangeLog	2018-12-06 06:12:28 UTC (rev 238927)
@@ -1,3 +1,20 @@
+2018-12-05  Ryosuke Niwa  
+
+REGRESSION(PSON): Process swapping code doesn't set DisplayID in WebContent process
+https://bugs.webkit.org/show_bug.cgi?id=192290
+
+Reviewed by Simon Fraser.
+
+Fixed the bug by updating the DisplayID upon attaching to a WebContent process
+after a process swap as well as after the previous WebContent process had crashed.
+
+Unfortunately no new tests since WebKitTestRunner / DumpRenderTree should use 0 as DisplayID
+as they have an off-screen NSWindow. The issue that this results in no fallback for
+the animation timer is tracked by webkit.org/b/192448.
+
+* UIProcess/Cocoa/WebViewImpl.mm:
+(WebKit::WebViewImpl::didRelaunchProcess):
+
 2018-12-05  Youenn Fablet  
 
 Remove a document entry from NetworkMDNSRegister::m_services when document goes away


Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm (238926 => 238927)

--- trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm	2018-12-06 04:45:57 UTC (rev 238926)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm	2018-12-06 06:12:28 UTC (rev 238927)
@@ -1498,6 +1498,7 @@
 m_gestureController->connectToProcess();
 
 accessibilityRegisterUIProcessTokens();
+windowDidChangeScreen(); // Make sure DisplayID is set.
 }
 
 void WebViewImpl::setDrawsBackground(bool drawsBackground)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238926] releases/Apple

[mitz]

Title: [238926] releases/Apple








Revision 238926
Author m...@apple.com
Date 2018-12-05 20:45:57 -0800 (Wed, 05 Dec 2018)


Log Message
Added a tag for Safari 12.0.2.

Added Paths

releases/Apple/Safari 12.0.2/
releases/Apple/Safari 12.0.2/ANGLE/
releases/Apple/Safari 12.0.2/_javascript_Core/
releases/Apple/Safari 12.0.2/WTF/
releases/Apple/Safari 12.0.2/WebCore/
releases/Apple/Safari 12.0.2/WebInspectorUI/
releases/Apple/Safari 12.0.2/WebKit/
releases/Apple/Safari 12.0.2/WebKitLegacy/
releases/Apple/Safari 12.0.2/bmalloc/
releases/Apple/Safari 12.0.2/libwebrtc/




Diff
Index: releases/Apple/Safari 12.0.2/ANGLE
===
--- tags/Safari-606.3.4.1.4/Source/ThirdParty/ANGLE	2018-12-06 04:45:48 UTC (rev 238925)
+++ releases/Apple/Safari 12.0.2/ANGLE	2018-12-06 04:45:57 UTC (rev 238926)

Property changes: releases/Apple/Safari 12.0.2/ANGLE



Added: allow-tabs
+true
\ No newline at end of property

Added: svn:mergeinfo
+/trunk/Source/ThirdParty/ANGLE:53455,235254,235419,235666,236554,236576,236587
\ No newline at end of property
Index: releases/Apple/Safari 12.0.2/_javascript_Core
===
--- tags/Safari-606.3.4.1.4/Source/_javascript_Core	2018-12-06 04:45:48 UTC (rev 238925)
+++ releases/Apple/Safari 12.0.2/_javascript_Core	2018-12-06 04:45:57 UTC (rev 238926)

Property changes: releases/Apple/Safari 12.0.2/_javascript_Core



Added: svn:mergeinfo
+/trunk/Source/_javascript_Core:53455,235254,235419,235666,236554,236576,236587
\ No newline at end of property
Index: releases/Apple/Safari 12.0.2/WTF
===
--- tags/Safari-606.3.4.1.4/Source/WTF	2018-12-06 04:45:48 UTC (rev 238925)
+++ releases/Apple/Safari 12.0.2/WTF	2018-12-06 04:45:57 UTC (rev 238926)

Property changes: releases/Apple/Safari 12.0.2/WTF



Added: svn:mergeinfo
+/trunk/Source/WTF:53455,235254,235419,235666,236554,236576,236587
\ No newline at end of property
Index: releases/Apple/Safari 12.0.2/WebInspectorUI
===
--- tags/Safari-606.3.4.1.4/Source/WebInspectorUI	2018-12-06 04:45:48 UTC (rev 238925)
+++ releases/Apple/Safari 12.0.2/WebInspectorUI	2018-12-06 04:45:57 UTC (rev 238926)

Property changes: releases/Apple/Safari 12.0.2/WebInspectorUI



Added: svn:mergeinfo
+/trunk/Source/WebInspectorUI:53455,235254,235419,235666,236554,236576,236587
\ No newline at end of property
Index: releases/Apple/Safari 12.0.2/bmalloc
===
--- tags/Safari-606.3.4.1.4/Source/bmalloc	2018-12-06 04:45:48 UTC (rev 238925)
+++ releases/Apple/Safari 12.0.2/bmalloc	2018-12-06 04:45:57 UTC (rev 238926)

Property changes: releases/Apple/Safari 12.0.2/bmalloc



Added: svn:mergeinfo
+/trunk/Source/bmalloc:53455,235254,235419,235666,236554,236576,236587
\ No newline at end of property
Index: releases/Apple/Safari 12.0.2/libwebrtc
===
--- tags/Safari-606.3.4.1.4/Source/ThirdParty/libwebrtc	2018-12-06 04:45:48 UTC (rev 238925)
+++ releases/Apple/Safari 12.0.2/libwebrtc	2018-12-06 04:45:57 UTC (rev 238926)

Property changes: releases/Apple/Safari 12.0.2/libwebrtc



Added: svn:mergeinfo
+/trunk/Source/ThirdParty/libwebrtc:53455,235254,235419,235666,236554,236576,236587
\ No newline at end of property




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238925] releases/Apple

[mitz]

Title: [238925] releases/Apple








Revision 238925
Author m...@apple.com
Date 2018-12-05 20:45:48 -0800 (Wed, 05 Dec 2018)


Log Message
Added a tag for iOS 12.1.1.

Added Paths

releases/Apple/iOS 12.1.1/
releases/Apple/iOS 12.1.1/ANGLE/
releases/Apple/iOS 12.1.1/_javascript_Core/
releases/Apple/iOS 12.1.1/WTF/
releases/Apple/iOS 12.1.1/WebCore/
releases/Apple/iOS 12.1.1/WebKit/
releases/Apple/iOS 12.1.1/WebKitLegacy/
releases/Apple/iOS 12.1.1/bmalloc/
releases/Apple/iOS 12.1.1/libwebrtc/




Diff
Index: releases/Apple/iOS 12.1.1/ANGLE
===
--- tags/Safari-606.3.4.0.2/Source/ThirdParty/ANGLE	2018-12-06 04:45:41 UTC (rev 238924)
+++ releases/Apple/iOS 12.1.1/ANGLE	2018-12-06 04:45:48 UTC (rev 238925)

Property changes: releases/Apple/iOS 12.1.1/ANGLE



Added: allow-tabs
+true
\ No newline at end of property

Added: svn:mergeinfo
+/trunk/Source/ThirdParty/ANGLE:53455,235254,235419,235666,236554,236576,236587
\ No newline at end of property
Index: releases/Apple/iOS 12.1.1/_javascript_Core
===
--- tags/Safari-606.3.4.0.2/Source/_javascript_Core	2018-12-06 04:45:41 UTC (rev 238924)
+++ releases/Apple/iOS 12.1.1/_javascript_Core	2018-12-06 04:45:48 UTC (rev 238925)

Property changes: releases/Apple/iOS 12.1.1/_javascript_Core



Added: svn:mergeinfo
+/trunk/Source/_javascript_Core:53455,235254,235419,235666,236554,236576,236587
\ No newline at end of property
Index: releases/Apple/iOS 12.1.1/WTF
===
--- tags/Safari-606.3.4.0.2/Source/WTF	2018-12-06 04:45:41 UTC (rev 238924)
+++ releases/Apple/iOS 12.1.1/WTF	2018-12-06 04:45:48 UTC (rev 238925)

Property changes: releases/Apple/iOS 12.1.1/WTF



Added: svn:mergeinfo
+/trunk/Source/WTF:53455,235254,235419,235666,236554,236576,236587
\ No newline at end of property
Index: releases/Apple/iOS 12.1.1/bmalloc
===
--- tags/Safari-606.3.4.0.2/Source/bmalloc	2018-12-06 04:45:41 UTC (rev 238924)
+++ releases/Apple/iOS 12.1.1/bmalloc	2018-12-06 04:45:48 UTC (rev 238925)

Property changes: releases/Apple/iOS 12.1.1/bmalloc



Added: svn:mergeinfo
+/trunk/Source/bmalloc:53455,235254,235419,235666,236554,236576,236587
\ No newline at end of property
Index: releases/Apple/iOS 12.1.1/libwebrtc
===
--- tags/Safari-606.3.4.0.2/Source/ThirdParty/libwebrtc	2018-12-06 04:45:41 UTC (rev 238924)
+++ releases/Apple/iOS 12.1.1/libwebrtc	2018-12-06 04:45:48 UTC (rev 238925)

Property changes: releases/Apple/iOS 12.1.1/libwebrtc



Added: svn:mergeinfo
+/trunk/Source/ThirdParty/libwebrtc:53455,235254,235419,235666,236554,236576,236587
\ No newline at end of property




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238924] releases/Apple

[mitz]

Title: [238924] releases/Apple








Revision 238924
Author m...@apple.com
Date 2018-12-05 20:45:41 -0800 (Wed, 05 Dec 2018)


Log Message
Added a tag for Safari Technology Preview release 71.

Added Paths

releases/Apple/Safari Technology Preview 71/
releases/Apple/Safari Technology Preview 71/ANGLE/
releases/Apple/Safari Technology Preview 71/_javascript_Core/
releases/Apple/Safari Technology Preview 71/WTF/
releases/Apple/Safari Technology Preview 71/WebCore/
releases/Apple/Safari Technology Preview 71/WebInspectorUI/
releases/Apple/Safari Technology Preview 71/WebKit/
releases/Apple/Safari Technology Preview 71/WebKitLegacy/
releases/Apple/Safari Technology Preview 71/bmalloc/
releases/Apple/Safari Technology Preview 71/libwebrtc/




Diff
Index: releases/Apple/Safari Technology Preview 71/ANGLE
===
--- tags/Safari-607.1.15/Source/ThirdParty/ANGLE	2018-12-06 04:34:27 UTC (rev 238923)
+++ releases/Apple/Safari Technology Preview 71/ANGLE	2018-12-06 04:45:41 UTC (rev 238924)

Property changes: releases/Apple/Safari Technology Preview 71/ANGLE



Added: allow-tabs
+true
\ No newline at end of property

Added: svn:mergeinfo
+/trunk/Source/ThirdParty/ANGLE:53455
\ No newline at end of property
Index: releases/Apple/Safari Technology Preview 71/_javascript_Core
===
--- tags/Safari-607.1.15/Source/_javascript_Core	2018-12-06 04:34:27 UTC (rev 238923)
+++ releases/Apple/Safari Technology Preview 71/_javascript_Core	2018-12-06 04:45:41 UTC (rev 238924)

Property changes: releases/Apple/Safari Technology Preview 71/_javascript_Core



Added: svn:mergeinfo
+/trunk/Source/_javascript_Core:53455
\ No newline at end of property
Index: releases/Apple/Safari Technology Preview 71/WTF
===
--- tags/Safari-607.1.15/Source/WTF	2018-12-06 04:34:27 UTC (rev 238923)
+++ releases/Apple/Safari Technology Preview 71/WTF	2018-12-06 04:45:41 UTC (rev 238924)

Property changes: releases/Apple/Safari Technology Preview 71/WTF



Added: svn:mergeinfo
+/trunk/Source/WTF:53455
\ No newline at end of property
Index: releases/Apple/Safari Technology Preview 71/WebInspectorUI
===
--- tags/Safari-607.1.15/Source/WebInspectorUI	2018-12-06 04:34:27 UTC (rev 238923)
+++ releases/Apple/Safari Technology Preview 71/WebInspectorUI	2018-12-06 04:45:41 UTC (rev 238924)

Property changes: releases/Apple/Safari Technology Preview 71/WebInspectorUI



Added: svn:mergeinfo
+/trunk/Source/WebInspectorUI:53455
\ No newline at end of property
Index: releases/Apple/Safari Technology Preview 71/bmalloc
===
--- tags/Safari-607.1.15/Source/bmalloc	2018-12-06 04:34:27 UTC (rev 238923)
+++ releases/Apple/Safari Technology Preview 71/bmalloc	2018-12-06 04:45:41 UTC (rev 238924)

Property changes: releases/Apple/Safari Technology Preview 71/bmalloc



Added: svn:mergeinfo
+/trunk/Source/bmalloc:53455
\ No newline at end of property
Index: releases/Apple/Safari Technology Preview 71/libwebrtc
===
--- tags/Safari-607.1.15/Source/ThirdParty/libwebrtc	2018-12-06 04:34:27 UTC (rev 238923)
+++ releases/Apple/Safari Technology Preview 71/libwebrtc	2018-12-06 04:45:41 UTC (rev 238924)

Property changes: releases/Apple/Safari Technology Preview 71/libwebrtc



Added: svn:mergeinfo
+/trunk/Source/ThirdParty/libwebrtc:53455
\ No newline at end of property




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238923] trunk

[mark . lam]

Title: [238923] trunk








Revision 238923
Author mark@apple.com
Date 2018-12-05 20:34:27 -0800 (Wed, 05 Dec 2018)


Log Message
speculationFromCell() should speculate non-Identifier strings as SpecString instead of SpecStringVar.
https://bugs.webkit.org/show_bug.cgi?id=192441


Reviewed by Saam Barati.

JSTests:

* stress/regress-192441.js: Added.

Source/_javascript_Core:

This is because a regular String (non-Identifier) can be converted into an
Identifier.  During DFG/FTL compilation, AbstractValue::checkConsistency() may
expect a value to be of type SpecStringVar, but the mutator thread may have
converted the string into an Identifier.  This creates a race where
AbstractValue::checkConsistency() may fail because it sees a SpecStringIdent when
it expects the a SpecStringVar.

The fix is to speculate non-Identifier strings as type SpecString which allows it
to be SpecStringVar or SpecStringIndent.

* bytecode/SpeculatedType.cpp:
(JSC::speculationFromCell):

Modified Paths

trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/SpeculatedType.cpp


Added Paths

trunk/JSTests/stress/regress-192441.js




Diff

Modified: trunk/JSTests/ChangeLog (238922 => 238923)

--- trunk/JSTests/ChangeLog	2018-12-06 03:46:37 UTC (rev 238922)
+++ trunk/JSTests/ChangeLog	2018-12-06 04:34:27 UTC (rev 238923)
@@ -1,3 +1,13 @@
+2018-12-05  Mark Lam  
+
+speculationFromCell() should speculate non-Identifier strings as SpecString instead of SpecStringVar.
+https://bugs.webkit.org/show_bug.cgi?id=192441
+
+
+Reviewed by Saam Barati.
+
+* stress/regress-192441.js: Added.
+
 2018-12-04  Mark Lam  
 
 DFG's StrengthReduction phase should not reduce Construct into DirectContruct when the executable does not have constructAbility.


Added: trunk/JSTests/stress/regress-192441.js (0 => 238923)

--- trunk/JSTests/stress/regress-192441.js	(rev 0)
+++ trunk/JSTests/stress/regress-192441.js	2018-12-06 04:34:27 UTC (rev 238923)
@@ -0,0 +1,12 @@
+//@ requireOptions("--jitPolicyScale=0")
+
+// This test passes if it does not crash.
+
+let x = {}
+let enUS = ['en', 'US'].join('-')
+for (let i=0; i<100; i++) {
+Intl.NumberFormat(enUS)
+}
+for (let i=0; i<1; i++) {
+x[enUS]
+};


Modified: trunk/Source/_javascript_Core/ChangeLog (238922 => 238923)

--- trunk/Source/_javascript_Core/ChangeLog	2018-12-06 03:46:37 UTC (rev 238922)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-12-06 04:34:27 UTC (rev 238923)
@@ -1,3 +1,24 @@
+2018-12-05  Mark Lam  
+
+speculationFromCell() should speculate non-Identifier strings as SpecString instead of SpecStringVar.
+https://bugs.webkit.org/show_bug.cgi?id=192441
+
+
+Reviewed by Saam Barati.
+
+This is because a regular String (non-Identifier) can be converted into an
+Identifier.  During DFG/FTL compilation, AbstractValue::checkConsistency() may
+expect a value to be of type SpecStringVar, but the mutator thread may have
+converted the string into an Identifier.  This creates a race where
+AbstractValue::checkConsistency() may fail because it sees a SpecStringIdent when
+it expects the a SpecStringVar.  
+
+The fix is to speculate non-Identifier strings as type SpecString which allows it
+to be SpecStringVar or SpecStringIndent.
+
+* bytecode/SpeculatedType.cpp:
+(JSC::speculationFromCell):
+
 2018-12-04  Mark Lam  
 
 DFG's StrengthReduction phase should not reduce Construct into DirectContruct when the executable does not have constructAbility.


Modified: trunk/Source/_javascript_Core/bytecode/SpeculatedType.cpp (238922 => 238923)

--- trunk/Source/_javascript_Core/bytecode/SpeculatedType.cpp	2018-12-06 03:46:37 UTC (rev 238922)
+++ trunk/Source/_javascript_Core/bytecode/SpeculatedType.cpp	2018-12-06 04:34:27 UTC (rev 238923)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2011-2017 Apple Inc. All rights reserved.
+ * Copyright (C) 2011-2018 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -480,7 +480,7 @@
 if (impl->isAtomic())
 return SpecStringIdent;
 }
-return SpecStringVar;
+return SpecString;
 }
 return speculationFromStructure(cell->structure());
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238922] trunk/Source/WebKit

[youenn]

Title: [238922] trunk/Source/WebKit








Revision 238922
Author you...@apple.com
Date 2018-12-05 19:46:37 -0800 (Wed, 05 Dec 2018)


Log Message
Remove a document entry from NetworkMDNSRegister::m_services when document goes away
https://bugs.webkit.org/show_bug.cgi?id=192429

Reviewed by Eric Carlson.

* NetworkProcess/webrtc/NetworkMDNSRegister.cpp:
(WebKit::NetworkMDNSRegister::unregisterMDNSNames):
We should remove the entry to limit the size of the map.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/webrtc/NetworkMDNSRegister.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (238921 => 238922)

--- trunk/Source/WebKit/ChangeLog	2018-12-06 03:09:29 UTC (rev 238921)
+++ trunk/Source/WebKit/ChangeLog	2018-12-06 03:46:37 UTC (rev 238922)
@@ -1,3 +1,14 @@
+2018-12-05  Youenn Fablet  
+
+Remove a document entry from NetworkMDNSRegister::m_services when document goes away
+https://bugs.webkit.org/show_bug.cgi?id=192429
+
+Reviewed by Eric Carlson.
+
+* NetworkProcess/webrtc/NetworkMDNSRegister.cpp:
+(WebKit::NetworkMDNSRegister::unregisterMDNSNames):
+We should remove the entry to limit the size of the map.
+
 2018-12-05  Jiewen Tan  
 
 [Mac] Layout Test http/wpt/webauthn/public-key-credential-create-success-hid.https.html and http/wpt/webauthn/public-key-credential-get-success-hid.https.html are flaky


Modified: trunk/Source/WebKit/NetworkProcess/webrtc/NetworkMDNSRegister.cpp (238921 => 238922)

--- trunk/Source/WebKit/NetworkProcess/webrtc/NetworkMDNSRegister.cpp	2018-12-06 03:09:29 UTC (rev 238921)
+++ trunk/Source/WebKit/NetworkProcess/webrtc/NetworkMDNSRegister.cpp	2018-12-06 03:46:37 UTC (rev 238922)
@@ -60,6 +60,7 @@
 if (iterator == m_services.end())
 return;
 DNSServiceRefDeallocate(iterator->value);
+m_services.remove(iterator);
 }
 
 struct PendingRegistrationRequest {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238921] trunk/Tools

[wenson_hsieh]

Title: [238921] trunk/Tools








Revision 238921
Author wenson_hs...@apple.com
Date 2018-12-05 19:09:29 -0800 (Wed, 05 Dec 2018)


Log Message
[Cocoa] Share ClassMethodSwizzler and InstanceMethodSwizzler between TestWebKitAPI and WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=192437

Reviewed by Tim Horton.

* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* TestRunnerShared/cocoa/ClassMethodSwizzler.h: Renamed from Tools/TestWebKitAPI/ClassMethodSwizzler.h.
* TestRunnerShared/cocoa/ClassMethodSwizzler.mm: Renamed from Tools/TestWebKitAPI/ClassMethodSwizzler.mm.
(ClassMethodSwizzler::ClassMethodSwizzler):
(ClassMethodSwizzler::~ClassMethodSwizzler):
* TestRunnerShared/cocoa/InstanceMethodSwizzler.h: Renamed from Tools/TestWebKitAPI/cocoa/InstanceMethodSwizzler.h.
* TestRunnerShared/cocoa/InstanceMethodSwizzler.mm: Renamed from Tools/TestWebKitAPI/cocoa/InstanceMethodSwizzler.mm.
(InstanceMethodSwizzler::InstanceMethodSwizzler):
(InstanceMethodSwizzler::~InstanceMethodSwizzler):

Move these swizzling helper classes into TestRunnerShared.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:
* TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
(safeBrowsingView):
* TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDefaultNavigationDelegate.mm:
* TestWebKitAPI/cocoa/TestWKWebView.mm:
(-[TestWKWebView initWithFrame:configuration:addToWindow:]):

Remove namespacing around ClassMethodSwizzler and InstanceMethodSwizzler in a few API tests.

* TestWebKitAPI/mac/TestFontOptions.mm:
* WebKitTestRunner/TestController.h:
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
* WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::ClassMethodSwizzler::ClassMethodSwizzler): Deleted.
(WTR::ClassMethodSwizzler::~ClassMethodSwizzler): Deleted.

Remove this duplicate implementation of ClassMethodSwizzler in WebKitTestRunner.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDefaultNavigationDelegate.mm
trunk/Tools/TestWebKitAPI/cocoa/TestWKWebView.mm
trunk/Tools/TestWebKitAPI/mac/TestFontOptions.mm
trunk/Tools/WebKitTestRunner/TestController.h
trunk/Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj
trunk/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm


Added Paths

trunk/Tools/TestRunnerShared/cocoa/ClassMethodSwizzler.h
trunk/Tools/TestRunnerShared/cocoa/ClassMethodSwizzler.mm
trunk/Tools/TestRunnerShared/cocoa/InstanceMethodSwizzler.h
trunk/Tools/TestRunnerShared/cocoa/InstanceMethodSwizzler.mm


Removed Paths

trunk/Tools/TestWebKitAPI/ClassMethodSwizzler.h
trunk/Tools/TestWebKitAPI/ClassMethodSwizzler.mm
trunk/Tools/TestWebKitAPI/cocoa/InstanceMethodSwizzler.h
trunk/Tools/TestWebKitAPI/cocoa/InstanceMethodSwizzler.mm




Diff

Modified: trunk/Tools/ChangeLog (238920 => 238921)

--- trunk/Tools/ChangeLog	2018-12-06 03:02:19 UTC (rev 238920)
+++ trunk/Tools/ChangeLog	2018-12-06 03:09:29 UTC (rev 238921)
@@ -1,3 +1,41 @@
+2018-12-05  Wenson Hsieh  
+
+[Cocoa] Share ClassMethodSwizzler and InstanceMethodSwizzler between TestWebKitAPI and WebKitTestRunner
+https://bugs.webkit.org/show_bug.cgi?id=192437
+
+Reviewed by Tim Horton.
+
+* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
+* TestRunnerShared/cocoa/ClassMethodSwizzler.h: Renamed from Tools/TestWebKitAPI/ClassMethodSwizzler.h.
+* TestRunnerShared/cocoa/ClassMethodSwizzler.mm: Renamed from Tools/TestWebKitAPI/ClassMethodSwizzler.mm.
+(ClassMethodSwizzler::ClassMethodSwizzler):
+(ClassMethodSwizzler::~ClassMethodSwizzler):
+* TestRunnerShared/cocoa/InstanceMethodSwizzler.h: Renamed from Tools/TestWebKitAPI/cocoa/InstanceMethodSwizzler.h.
+* TestRunnerShared/cocoa/InstanceMethodSwizzler.mm: Renamed from Tools/TestWebKitAPI/cocoa/InstanceMethodSwizzler.mm.
+(InstanceMethodSwizzler::InstanceMethodSwizzler):
+(InstanceMethodSwizzler::~InstanceMethodSwizzler):
+
+Move these swizzling helper classes into TestRunnerShared.
+
+* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+* TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:
+* TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
+(safeBrowsingView):
+* TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDefaultNavigationDelegate.mm:
+* TestWebKitAPI/cocoa/TestWKWebView.mm:
+(-[TestWKWebView initWithFrame:configuration:addToWindow:]):
+
+Remove namespacing around ClassMethodSwizzler and InstanceMethodSwizzler in a few API tests.
+
+* TestWebKitAPI/mac/TestFontOptions.mm:
+* WebKitTestRunner/TestController.h:
+* 

[webkit-changes] [238920] trunk/LayoutTests

[aboya]

Title: [238920] trunk/LayoutTests








Revision 238920
Author ab...@igalia.com
Date 2018-12-05 19:02:19 -0800 (Wed, 05 Dec 2018)


Log Message
[GTK] Unreviewed test gardening
https://bugs.webkit.org/show_bug.cgi?id=192436


* platform/gtk/TestExpectations:
* platform/gtk/editing/deleting/delete-emoji-1-expected.txt:
* platform/gtk/editing/deleting/delete-emoji-expected.txt:
* platform/wpe/animations/lineheight-animation-expected.txt:
* platform/wpe/animations/simultaneous-start-transform-expected.txt:
* platform/wpe/animations/width-using-ems-expected.txt:
* platform/wpe/legacy-animation-engine/animations/lineheight-animation-expected.txt:
* platform/wpe/legacy-animation-engine/animations/simultaneous-start-transform-expected.txt:
* platform/wpe/legacy-animation-engine/animations/width-using-ems-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/gtk/editing/deleting/delete-emoji-1-expected.txt
trunk/LayoutTests/platform/gtk/editing/deleting/delete-emoji-expected.txt
trunk/LayoutTests/platform/wpe/animations/lineheight-animation-expected.txt
trunk/LayoutTests/platform/wpe/animations/simultaneous-start-transform-expected.txt
trunk/LayoutTests/platform/wpe/animations/width-using-ems-expected.txt
trunk/LayoutTests/platform/wpe/legacy-animation-engine/animations/lineheight-animation-expected.txt
trunk/LayoutTests/platform/wpe/legacy-animation-engine/animations/simultaneous-start-transform-expected.txt
trunk/LayoutTests/platform/wpe/legacy-animation-engine/animations/width-using-ems-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (238919 => 238920)

--- trunk/LayoutTests/ChangeLog	2018-12-06 02:28:23 UTC (rev 238919)
+++ trunk/LayoutTests/ChangeLog	2018-12-06 03:02:19 UTC (rev 238920)
@@ -1,3 +1,18 @@
+2018-12-05  Alicia Boya García  
+
+[GTK] Unreviewed test gardening
+https://bugs.webkit.org/show_bug.cgi?id=192436
+
+* platform/gtk/TestExpectations:
+* platform/gtk/editing/deleting/delete-emoji-1-expected.txt:
+* platform/gtk/editing/deleting/delete-emoji-expected.txt:
+* platform/wpe/animations/lineheight-animation-expected.txt:
+* platform/wpe/animations/simultaneous-start-transform-expected.txt:
+* platform/wpe/animations/width-using-ems-expected.txt:
+* platform/wpe/legacy-animation-engine/animations/lineheight-animation-expected.txt:
+* platform/wpe/legacy-animation-engine/animations/simultaneous-start-transform-expected.txt:
+* platform/wpe/legacy-animation-engine/animations/width-using-ems-expected.txt:
+
 2018-12-05  Youenn Fablet  
 
 REGRESSION: Layout Test http/tests/security/cross-origin-css-resource-timing.html is flaky


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (238919 => 238920)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2018-12-06 02:28:23 UTC (rev 238919)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2018-12-06 03:02:19 UTC (rev 238920)
@@ -1926,7 +1926,7 @@
 # Tests that fail on the EWS queue since we enabled tests there
 webkit.org/b/186638 printing/print-close-crash.html [ Timeout Pass ]
 webkit.org/b/186638 fast/media/print-restores-previous-mediatype.html [ Timeout Pass ]
-webkit.org/b/186638 editing/execCommand/print.html [ Timeout Pass ]
+webkit.org/b/186638 editing/execCommand/print.html [ Timeout Pass Failure ]
 webkit.org/b/186638 animations/play-state-paused.html [ Failure Pass ]
 webkit.org/b/186638 imported/w3c/web-platform-tests/streams/piping/error-propagation-forward.html [ Failure Pass ]
 webkit.org/b/186638 imported/mozilla/css-transitions/test_animation-finished.html [ Timeout Pass ]
@@ -3392,8 +3392,6 @@
 
 webkit.org/b/179722 compositing/accelerated-layers-after-back.html [ Failure ]
 
-webkit.org/b/179113 fast/inline/padding-ellipsis-right.html [ ImageOnlyFailure ]
-webkit.org/b/179113 fast/text/ellipsis-text-rtl.html [ ImageOnlyFailure ]
 webkit.org/b/179113 imported/w3c/web-platform-tests/css/css-ui/text-overflow-013.html [ ImageOnlyFailure ]
 # This one is only failing on the release bots.
 webkit.org/b/18328 [ Release ] imported/w3c/web-platform-tests/css/css-ui/text-overflow-022.html [ ImageOnlyFailure ]
@@ -3647,6 +3645,12 @@
 webkit.org/b/192150 imported/w3c/web-platform-tests/xhr/getresponseheader.any.worker.html [ Failure ]
 webkit.org/b/192150 imported/w3c/web-platform-tests/xhr/setrequestheader-content-type.htm [ Failure ]
 
+webkit.org/b/192432 compositing/backing/backing-store-attachment-scroll.html [ Failure ]
+webkit.org/b/192432 compositing/tiling/tile-coverage-on-scroll.html [ Failure ]
+webkit.org/b/192433 compositing/iframes/remove-reinsert-webview-with-iframe.html [ Failure ]
+webkit.org/b/192434 fast/inline/inline-content-with-float-and-margin.html [ Failure ]
+webkit.org/b/166536 fast/canvas/webgl/hide-some-renderer-info.html [ Failure ]
+webkit.org/b/192435 fast/css-custom-paint/leaks.html [ Failure ]
 
 

[webkit-changes] [238919] trunk/Source/WebKit

[jiewen_tan]

Title: [238919] trunk/Source/WebKit








Revision 238919
Author jiewen_...@apple.com
Date 2018-12-05 18:28:23 -0800 (Wed, 05 Dec 2018)


Log Message
[Mac] Layout Test http/wpt/webauthn/public-key-credential-create-success-hid.https.html and http/wpt/webauthn/public-key-credential-get-success-hid.https.html are flaky
https://bugs.webkit.org/show_bug.cgi?id=192061

Reviewed by Dewei Zhu.

Part 1.

Add some loggings to determine possible causes for the flakiness.

* UIProcess/WebAuthentication/Cocoa/HidService.mm:
(WebKit::HidService::continueAddDeviceAfterGetInfo):
* UIProcess/WebAuthentication/Mock/MockHidService.cpp:
(WebKit::MockHidService::platformStartDiscovery):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/HidService.mm
trunk/Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidService.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (238918 => 238919)

--- trunk/Source/WebKit/ChangeLog	2018-12-06 00:26:27 UTC (rev 238918)
+++ trunk/Source/WebKit/ChangeLog	2018-12-06 02:28:23 UTC (rev 238919)
@@ -1,3 +1,19 @@
+2018-12-05  Jiewen Tan  
+
+[Mac] Layout Test http/wpt/webauthn/public-key-credential-create-success-hid.https.html and http/wpt/webauthn/public-key-credential-get-success-hid.https.html are flaky
+https://bugs.webkit.org/show_bug.cgi?id=192061
+
+Reviewed by Dewei Zhu.
+
+Part 1.
+
+Add some loggings to determine possible causes for the flakiness.
+
+* UIProcess/WebAuthentication/Cocoa/HidService.mm:
+(WebKit::HidService::continueAddDeviceAfterGetInfo):
+* UIProcess/WebAuthentication/Mock/MockHidService.cpp:
+(WebKit::MockHidService::platformStartDiscovery):
+
 2018-12-05  Chris Dumez  
 
 Simplify logic inside WebPageProxy::continueNavigationInNewProcess()


Modified: trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/HidService.mm (238918 => 238919)

--- trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/HidService.mm	2018-12-06 00:26:27 UTC (rev 238918)
+++ trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/HidService.mm	2018-12-06 02:28:23 UTC (rev 238919)
@@ -115,6 +115,7 @@
 return;
 }
 // FIXME(191535): Support U2F authenticators.
+LOG_ERROR("Couldn't parse a ctap get info response.");
 }
 
 } // namespace WebKit


Modified: trunk/Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidService.cpp (238918 => 238919)

--- trunk/Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidService.cpp	2018-12-06 00:26:27 UTC (rev 238918)
+++ trunk/Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidService.cpp	2018-12-06 02:28:23 UTC (rev 238919)
@@ -43,6 +43,7 @@
 {
 if (!!m_configuration.hid)
 deviceAdded(nullptr);
+LOG_ERROR("No hid authenticators is available.");
 }
 
 UniqueRef MockHidService::createHidConnection(IOHIDDeviceRef device) const






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238918] branches/safari-606-branch/Source/WebCore

[alancoon]

Title: [238918] branches/safari-606-branch/Source/WebCore








Revision 238918
Author alanc...@apple.com
Date 2018-12-05 16:26:27 -0800 (Wed, 05 Dec 2018)


Log Message
Apply patch. rdar://problem/46085280

Modified Paths

branches/safari-606-branch/Source/WebCore/ChangeLog
branches/safari-606-branch/Source/WebCore/html/HTMLMediaElement.cpp




Diff

Modified: branches/safari-606-branch/Source/WebCore/ChangeLog (238917 => 238918)

--- branches/safari-606-branch/Source/WebCore/ChangeLog	2018-12-06 00:13:46 UTC (rev 238917)
+++ branches/safari-606-branch/Source/WebCore/ChangeLog	2018-12-06 00:26:27 UTC (rev 238918)
@@ -1,5 +1,29 @@
 2018-12-05  Alan Coon  
 
+Apply patch. rdar://problem/46085280
+
+2018-12-05  Brent Fulgham  
+
+Lifetime of HTMLMediaElement is not properly handled in asynchronous actions
+https://bugs.webkit.org/show_bug.cgi?id=192087
+
+
+Reviewed by Dean Jackson.
+
+The HTMLMediaElement performs operations that allow arbitrary _javascript_ to run. We need to make
+sure the active media element is protected until those calls complete.
+
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::didFinishInsertingNode):
+(WebCore::HTMLMediaElement::exitFullscreen):
+(WebCore::HTMLMediaElement::markCaptionAndSubtitleTracksAsUnconfigured):
+(WebCore::HTMLMediaElement::scheduleConfigureTextTracks):
+(WebCore::HTMLMediaElement::scheduleMediaEngineWasUpdated):
+(WebCore::HTMLMediaElement::scheduleUpdatePlayState):
+(WebCore::HTMLMediaElement::scheduleUpdateMediaState):
+
+2018-12-05  Alan Coon  
+
 Apply patch. rdar://problem/45997392
 
 2018-12-05  Jiewen Tan  


Modified: branches/safari-606-branch/Source/WebCore/html/HTMLMediaElement.cpp (238917 => 238918)

--- branches/safari-606-branch/Source/WebCore/html/HTMLMediaElement.cpp	2018-12-06 00:13:46 UTC (rev 238917)
+++ branches/safari-606-branch/Source/WebCore/html/HTMLMediaElement.cpp	2018-12-06 00:26:27 UTC (rev 238918)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2007-2017 Apple Inc. All rights reserved.
+ * Copyright (C) 2007-2018 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -954,6 +954,8 @@
 
 void HTMLMediaElement::didFinishInsertingNode()
 {
+Ref protectedThis(*this); // prepareForLoad may result in a 'beforeload' event, which can make arbitrary DOM mutations.
+
 if (m_inActiveDocument && m_networkState == NETWORK_EMPTY && !attributeWithoutSynchronization(srcAttr).isEmpty())
 prepareForLoad();
 
@@ -5950,6 +5952,7 @@
 VideoFullscreenMode oldVideoFullscreenMode = m_videoFullscreenMode;
 fullscreenModeChanged(VideoFullscreenModeNone);
 #if ENABLE(MEDIA_CONTROLS_SCRIPT)
+Ref protectedThis(*this); // updateMediaControlsAfterPresentationModeChange calls methods that can trigger arbitrary DOM mutations.
 updateMediaControlsAfterPresentationModeChange();
 #endif
 if (hasMediaControls())
@@ -6505,9 +6508,10 @@
 
 m_processingPreferenceChange = true;
 clearFlags(m_pendingActionFlags, ConfigureTextTracks);
-if (mode == Immediately)
+if (mode == Immediately) {
+Ref protectedThis(*this); // configureTextTracks calls methods that can trigger arbitrary DOM mutations.
 configureTextTracks();
-else
+} else
 scheduleDelayedAction(ConfigureTextTracks);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238917] trunk/LayoutTests

[youenn]

Title: [238917] trunk/LayoutTests








Revision 238917
Author you...@apple.com
Date 2018-12-05 16:13:46 -0800 (Wed, 05 Dec 2018)


Log Message
REGRESSION: Layout Test http/tests/security/cross-origin-css-resource-timing.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=192408


Reviewed by Ryosuke Niwa.

Some of the tests are loading the same subresource and check for resource timing.
We need to clear internal caches to have stable results.

* http/tests/security/clean-origin-css-exposed-resource-timing.html:
* http/tests/security/cross-origin-clean-css-resource-timing.html:
* http/tests/security/cross-origin-css-resource-timing.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/security/clean-origin-css-exposed-resource-timing.html
trunk/LayoutTests/http/tests/security/cross-origin-clean-css-resource-timing.html
trunk/LayoutTests/http/tests/security/cross-origin-css-resource-timing.html




Diff

Modified: trunk/LayoutTests/ChangeLog (238916 => 238917)

--- trunk/LayoutTests/ChangeLog	2018-12-05 23:51:12 UTC (rev 238916)
+++ trunk/LayoutTests/ChangeLog	2018-12-06 00:13:46 UTC (rev 238917)
@@ -1,3 +1,18 @@
+2018-12-05  Youenn Fablet  
+
+REGRESSION: Layout Test http/tests/security/cross-origin-css-resource-timing.html is flaky
+https://bugs.webkit.org/show_bug.cgi?id=192408
+
+
+Reviewed by Ryosuke Niwa.
+
+Some of the tests are loading the same subresource and check for resource timing.
+We need to clear internal caches to have stable results.
+
+* http/tests/security/clean-origin-css-exposed-resource-timing.html:
+* http/tests/security/cross-origin-clean-css-resource-timing.html:
+* http/tests/security/cross-origin-css-resource-timing.html:
+
 2018-12-05  Matt Baker  
 
 Web Inspector: SelectionController should not extend the selection when allowsMultipleSelection is false


Modified: trunk/LayoutTests/http/tests/security/clean-origin-css-exposed-resource-timing.html (238916 => 238917)

--- trunk/LayoutTests/http/tests/security/clean-origin-css-exposed-resource-timing.html	2018-12-05 23:51:12 UTC (rev 238916)
+++ trunk/LayoutTests/http/tests/security/clean-origin-css-exposed-resource-timing.html	2018-12-06 00:13:46 UTC (rev 238917)
@@ -9,6 +9,10 @@
 
 Test
 

[webkit-changes] [238915] branches/safari-606-branch/Source/WebKit

[alancoon]

Title: [238915] branches/safari-606-branch/Source/WebKit








Revision 238915
Author alanc...@apple.com
Date 2018-12-05 15:51:02 -0800 (Wed, 05 Dec 2018)


Log Message
Cherry-pick r238799. rdar://problem/46432866

[Cocoa] Check descriptor types in createMessageDecoder
https://bugs.webkit.org/show_bug.cgi?id=192302

Reviewed by Chris Dumez.

Not sure how to construct a test case for Connection, so not adding any
tests at this time.

* Platform/IPC/mac/ConnectionMac.mm:
(IPC::createMessageDecoder): Check descriptor types and return nullptr if they
are incorrect. Retained the assertions to help with debugging.
(IPC::Connection::receiveSourceEventHandler): Ignore the message if no decoder
is created, which means the message is invalid.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-606-branch/Source/WebKit/ChangeLog
branches/safari-606-branch/Source/WebKit/Platform/IPC/mac/ConnectionMac.mm




Diff

Modified: branches/safari-606-branch/Source/WebKit/ChangeLog (238914 => 238915)

--- branches/safari-606-branch/Source/WebKit/ChangeLog	2018-12-05 23:50:08 UTC (rev 238914)
+++ branches/safari-606-branch/Source/WebKit/ChangeLog	2018-12-05 23:51:02 UTC (rev 238915)
@@ -1,3 +1,39 @@
+2018-12-04  Alan Coon  
+
+Cherry-pick r238799. rdar://problem/46432866
+
+[Cocoa] Check descriptor types in createMessageDecoder
+https://bugs.webkit.org/show_bug.cgi?id=192302
+
+Reviewed by Chris Dumez.
+
+Not sure how to construct a test case for Connection, so not adding any
+tests at this time.
+
+* Platform/IPC/mac/ConnectionMac.mm:
+(IPC::createMessageDecoder): Check descriptor types and return nullptr if they
+are incorrect. Retained the assertions to help with debugging.
+(IPC::Connection::receiveSourceEventHandler): Ignore the message if no decoder
+is created, which means the message is invalid.
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238799 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2018-12-03  Darin Adler  
+
+[Cocoa] Check descriptor types in createMessageDecoder
+https://bugs.webkit.org/show_bug.cgi?id=192302
+
+Reviewed by Chris Dumez.
+
+Not sure how to construct a test case for Connection, so not adding any
+tests at this time.
+
+* Platform/IPC/mac/ConnectionMac.mm:
+(IPC::createMessageDecoder): Check descriptor types and return nullptr if they
+are incorrect. Retained the assertions to help with debugging.
+(IPC::Connection::receiveSourceEventHandler): Ignore the message if no decoder
+is created, which means the message is invalid.
+
 2018-11-27  Alex Christensen  
 
 Build fix after r238572


Modified: branches/safari-606-branch/Source/WebKit/Platform/IPC/mac/ConnectionMac.mm (238914 => 238915)

--- branches/safari-606-branch/Source/WebKit/Platform/IPC/mac/ConnectionMac.mm	2018-12-05 23:50:08 UTC (rev 238914)
+++ branches/safari-606-branch/Source/WebKit/Platform/IPC/mac/ConnectionMac.mm	2018-12-05 23:51:02 UTC (rev 238915)
@@ -459,29 +459,26 @@
 
 for (mach_msg_size_t i = 0; i < numDescriptors; ++i) {
 mach_msg_descriptor_t* descriptor = reinterpret_cast(descriptorData);
+ASSERT(descriptor->type.type == MACH_MSG_PORT_DESCRIPTOR);
+if (descriptor->type.type != MACH_MSG_PORT_DESCRIPTOR)
+return nullptr;
 
-switch (descriptor->type.type) {
-case MACH_MSG_PORT_DESCRIPTOR:
-attachments[numDescriptors - i - 1] = Attachment(descriptor->port.name, descriptor->port.disposition);
-descriptorData += sizeof(mach_msg_port_descriptor_t);
-break;
-default:
-ASSERT(false && "Unhandled descriptor type");
-}
+attachments[numDescriptors - i - 1] = Attachment(descriptor->port.name, descriptor->port.disposition);
+descriptorData += sizeof(mach_msg_port_descriptor_t);
 }
 
 if (messageBodyIsOOL) {
 mach_msg_descriptor_t* descriptor = reinterpret_cast(descriptorData);
 ASSERT(descriptor->type.type == MACH_MSG_OOL_DESCRIPTOR);
+if (descriptor->type.type != MACH_MSG_OOL_DESCRIPTOR)
+return nullptr;
 
 uint8_t* messageBody = static_cast(descriptor->out_of_line.address);
 size_t messageBodySize = descriptor->out_of_line.size;
 
-auto decoder = std::make_unique(messageBody, messageBodySize, [](const uint8_t* buffer, size_t length) {
+return std::make_unique(messageBody, messageBodySize, [](const uint8_t* buffer, size_t length) {
 vm_deallocate(mach_task_self(), reinterpret_cast(buffer), length);
 }, WTFMove(attachments));
-
-return decoder;
 }
 
 uint8_t* messageBody = descriptorData;
@@ -549,7 +546,8 @@
 }
 
 std::unique_ptr decoder = 

[webkit-changes] [238916] branches/safari-606-branch

[alancoon]

Title: [238916] branches/safari-606-branch








Revision 238916
Author alanc...@apple.com
Date 2018-12-05 15:51:12 -0800 (Wed, 05 Dec 2018)


Log Message
Apply patch. rdar://problem/45997392

Modified Paths

branches/safari-606-branch/LayoutTests/ChangeLog
branches/safari-606-branch/LayoutTests/platform/mac/fast/loader/webarchive-encoding-respected.html
branches/safari-606-branch/LayoutTests/webarchive/loading/cache-expired-subresource.html
branches/safari-606-branch/LayoutTests/webarchive/loading/mainresource-null-mimetype-crash.html
branches/safari-606-branch/LayoutTests/webarchive/loading/missing-data.html
branches/safari-606-branch/LayoutTests/webarchive/loading/test-loading-archive-subresource-null-mimetype.html
branches/safari-606-branch/LayoutTests/webarchive/loading/test-loading-archive.html
branches/safari-606-branch/Source/WebCore/ChangeLog
branches/safari-606-branch/Source/WebCore/dom/Document.h
branches/safari-606-branch/Source/WebCore/loader/DocumentLoader.cpp
branches/safari-606-branch/Source/WebCore/loader/DocumentLoader.h
branches/safari-606-branch/Source/WebCore/testing/Internals.cpp
branches/safari-606-branch/Source/WebCore/testing/Internals.h
branches/safari-606-branch/Source/WebCore/testing/Internals.idl
branches/safari-606-branch/Source/WebKit/ChangeLog
branches/safari-606-branch/Source/WebKit/UIProcess/WebPageProxy.cpp


Added Paths

branches/safari-606-branch/LayoutTests/platform/mac-wk1/webarchive/
branches/safari-606-branch/LayoutTests/platform/mac-wk1/webarchive/loading/
branches/safari-606-branch/LayoutTests/platform/mac-wk1/webarchive/loading/test-loading-archive-subresource-expected.txt
branches/safari-606-branch/LayoutTests/webarchive/loading/resources/top.webarchive
branches/safari-606-branch/LayoutTests/webarchive/loading/test-loading-archive-subresource-expected.txt
branches/safari-606-branch/LayoutTests/webarchive/loading/test-loading-archive-subresource.html
branches/safari-606-branch/LayoutTests/webarchive/loading/test-loading-top-archive-expected.txt
branches/safari-606-branch/LayoutTests/webarchive/loading/test-loading-top-archive.html




Diff

Modified: branches/safari-606-branch/LayoutTests/ChangeLog (238915 => 238916)

--- branches/safari-606-branch/LayoutTests/ChangeLog	2018-12-05 23:51:02 UTC (rev 238915)
+++ branches/safari-606-branch/LayoutTests/ChangeLog	2018-12-05 23:51:12 UTC (rev 238916)
@@ -1,3 +1,28 @@
+2018-12-05  Alan Coon  
+
+Apply patch. rdar://problem/45997392
+
+2018-12-05  Jiewen Tan  
+
+Disallow loading webarchives as iframes
+https://bugs.webkit.org/show_bug.cgi?id=191728
+
+
+Reviewed by Youenn Fablet.
+
+* platform/mac-wk1/webarchive/loading/test-loading-archive-subresource-expected.txt: Added.
+* platform/mac/fast/loader/webarchive-encoding-respected.html:
+* webarchive/loading/cache-expired-subresource.html:
+* webarchive/loading/mainresource-null-mimetype-crash.html:
+* webarchive/loading/missing-data.html:
+* webarchive/loading/resources/test-loading-archive-main.webarchive: Copied from LayoutTests/webarchive/loading/test-loading-archive.html.
+* webarchive/loading/test-loading-archive-subresource-expected.txt: Added.
+* webarchive/loading/test-loading-archive-subresource-null-mimetype.html:
+* webarchive/loading/test-loading-archive-subresource.html: Copied from LayoutTests/webarchive/loading/test-loading-archive.html.
+* webarchive/loading/test-loading-archive.html:
+* webarchive/loading/test-loading-top-archive-expected.txt: Added.
+* webarchive/loading/test-loading-top-archive.html: Added.
+
 2018-11-16  Alan Coon  
 
 Cherry-pick r238222. rdar://problem/45997333


Modified: branches/safari-606-branch/LayoutTests/platform/mac/fast/loader/webarchive-encoding-respected.html (238915 => 238916)

--- branches/safari-606-branch/LayoutTests/platform/mac/fast/loader/webarchive-encoding-respected.html	2018-12-05 23:51:02 UTC (rev 238915)
+++ branches/safari-606-branch/LayoutTests/platform/mac/fast/loader/webarchive-encoding-respected.html	2018-12-05 23:51:12 UTC (rev 238916)
@@ -3,6 +3,8 @@
 	testRunner.dumpAsText();
 	testRunner.dumpChildFramesAsText();
 }
+if (window.internals)
+internals.setAlwaysAllowLocalWebarchive();
 
 The webarchive in this iframe is utf-8 encoded and will only display properly if the webarchive's encoding is respected.
 

Added: branches/safari-606-branch/LayoutTests/platform/mac-wk1/webarchive/loading/test-loading-archive-subresource-expected.txt (0 => 238916)

--- branches/safari-606-branch/LayoutTests/platform/mac-wk1/webarchive/loading/test-loading-archive-subresource-expected.txt	(rev 0)
+++ branches/safari-606-branch/LayoutTests/platform/mac-wk1/webarchive/loading/test-loading-archive-subresource-expected.txt	2018-12-05 23:51:12 UTC (rev 238916)
@@ -0,0 +1,8 @@
+main frame 

[webkit-changes] [238914] trunk

[mattbaker]

Title: [238914] trunk








Revision 238914
Author mattba...@apple.com
Date 2018-12-05 15:50:08 -0800 (Wed, 05 Dec 2018)


Log Message
Web Inspector: SelectionController should not extend the selection when allowsMultipleSelection is false
https://bugs.webkit.org/show_bug.cgi?id=192390


Reviewed by Devin Rousso.

Source/WebInspectorUI:

* UserInterface/Controllers/SelectionController.js:
(WI.SelectionController.prototype.selectItem):

LayoutTests:

* inspector/table/table-selection-expected.txt:
* inspector/table/table-selection.html:
Drive-by fix: removed `allowsMultipleSelection` check from test case
Table.SelectMultipleRows.ExtendSelection since it is tested in Table.AllowsMultipleSelection.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/table/table-selection-expected.txt
trunk/LayoutTests/inspector/table/table-selection.html
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Controllers/SelectionController.js




Diff

Modified: trunk/LayoutTests/ChangeLog (238913 => 238914)

--- trunk/LayoutTests/ChangeLog	2018-12-05 23:25:47 UTC (rev 238913)
+++ trunk/LayoutTests/ChangeLog	2018-12-05 23:50:08 UTC (rev 238914)
@@ -1,3 +1,16 @@
+2018-12-05  Matt Baker  
+
+Web Inspector: SelectionController should not extend the selection when allowsMultipleSelection is false
+https://bugs.webkit.org/show_bug.cgi?id=192390
+
+
+Reviewed by Devin Rousso.
+
+* inspector/table/table-selection-expected.txt:
+* inspector/table/table-selection.html:
+Drive-by fix: removed `allowsMultipleSelection` check from test case
+Table.SelectMultipleRows.ExtendSelection since it is tested in Table.AllowsMultipleSelection.
+
 2018-12-05  Ryosuke Niwa  
 
 Null pointer crash in DocumentOrderedMap::getElementById via FormAssociatedElement::findAssociatedForm


Modified: trunk/LayoutTests/inspector/table/table-selection-expected.txt (238913 => 238914)

--- trunk/LayoutTests/inspector/table/table-selection-expected.txt	2018-12-05 23:25:47 UTC (rev 238913)
+++ trunk/LayoutTests/inspector/table/table-selection-expected.txt	2018-12-05 23:50:08 UTC (rev 238914)
@@ -31,7 +31,6 @@
 PASS: allowsMultipleSelection disabled.
 
 -- Running test case: Table.SelectMultipleRows.ExtendSelection
-PASS: allowsMultipleSelection enabled.
 Selecting row 0.
 PASS: Table selection changed.
 PASS: selectedRow should be 0.
@@ -43,6 +42,15 @@
 PASS: selectedRow should be 9.
 PASS: selectedRows should be [0, 1, 9].
 
+-- Running test case: Table.SelectMultipleRows.ExtendSelection.MultipleSelectionDisabled
+Selecting row 0.
+PASS: Table selection changed.
+PASS: selectedRow should be 0.
+Selecting row 1.
+PASS: Table selection changed.
+PASS: selectedRow should be 1.
+PASS: selectedRows should be [1].
+
 -- Running test case: Table.SelectMultipleRows.SelectTheSameRowTwice.ExtendSelection
 Selecting row 0.
 PASS: Table selection changed.


Modified: trunk/LayoutTests/inspector/table/table-selection.html (238913 => 238914)

--- trunk/LayoutTests/inspector/table/table-selection.html	2018-12-05 23:25:47 UTC (rev 238913)
+++ trunk/LayoutTests/inspector/table/table-selection.html	2018-12-05 23:50:08 UTC (rev 238914)
@@ -78,6 +78,7 @@
 return true;
 }
 });
+
 suite.addTestCase({
 name: "Table.SelectMultipleRows.ExtendSelection",
 description: "Select multiple rows, extending the selection.",
@@ -84,7 +85,6 @@
 test() {
 let table = InspectorTest.createTable();
 table.allowsMultipleSelection = true;
-InspectorTest.expectThat(table.allowsMultipleSelection, "allowsMultipleSelection enabled.");
 
 const extendSelection = true;
 
@@ -98,6 +98,23 @@
 });
 
 suite.addTestCase({
+name: "Table.SelectMultipleRows.ExtendSelection.MultipleSelectionDisabled",
+description: "Attempt to extend the selection when multiple selection is disabled.",
+test() {
+let table = InspectorTest.createTable();
+table.allowsMultipleSelection = false;
+
+const extendSelection = true;
+
+triggerSelectRow(table, 0, extendSelection);
+triggerSelectRow(table, 1, extendSelection);
+InspectorTest.expectShallowEqual(table.selectedRows, [1], "selectedRows should be [1].");
+
+return true;
+}
+});
+
+suite.addTestCase({
 name: "Table.SelectMultipleRows.SelectTheSameRowTwice.ExtendSelection",
 description: "Select an already selected row, and extend the selection.",
 test() {


Modified: trunk/Source/WebInspectorUI/ChangeLog (238913 => 238914)

--- trunk/Source/WebInspectorUI/ChangeLog	2018-12-05 23:25:47 UTC (rev 238913)
+++ trunk/Source/WebInspectorUI/ChangeLog	2018-12-05 23:50:08 UTC (rev 238914)
@@ -1,3 +1,14 @@
+2018-12-05  Matt Baker  
+
+Web Inspector: SelectionController should not extend the selection when 

[webkit-changes] [238912] trunk

[rniwa]

Title: [238912] trunk








Revision 238912
Author rn...@webkit.org
Date 2018-12-05 15:06:49 -0800 (Wed, 05 Dec 2018)


Log Message
Null pointer crash in DocumentOrderedMap::getElementById via FormAssociatedElement::findAssociatedForm
https://bugs.webkit.org/show_bug.cgi?id=192392

Reviewed by Dean Jackson.

Source/WebCore:

The crash was caused by FormAssociatedElement::findAssociatedForm invoking DocumentOrderedMap::getElementById
and de-referencing nullptr Attribute* via IdTargetObserver before Element::attributeChanged had updated
ElementData::m_idForStyleResolution.

Fixed it by updating m_idForStyleResolution before invoking IdTargetObservers.

Test: fast/dom/remove-id-form-associated-elemet-id-observer-crash.html

* dom/Element.cpp:
(WebCore::Element::attributeChanged): Fixed the bug.

LayoutTests:

Added a regression test.

* fast/dom/remove-id-form-associated-elemet-id-observer-crash-expected.txt: Added.
* fast/dom/remove-id-form-associated-elemet-id-observer-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.cpp


Added Paths

trunk/LayoutTests/fast/dom/remove-id-form-associated-elemet-id-observer-crash-expected.txt
trunk/LayoutTests/fast/dom/remove-id-form-associated-elemet-id-observer-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (238911 => 238912)

--- trunk/LayoutTests/ChangeLog	2018-12-05 22:44:30 UTC (rev 238911)
+++ trunk/LayoutTests/ChangeLog	2018-12-05 23:06:49 UTC (rev 238912)
@@ -1,3 +1,15 @@
+2018-12-05  Ryosuke Niwa  
+
+Null pointer crash in DocumentOrderedMap::getElementById via FormAssociatedElement::findAssociatedForm
+https://bugs.webkit.org/show_bug.cgi?id=192392
+
+Reviewed by Dean Jackson.
+
+Added a regression test.
+
+* fast/dom/remove-id-form-associated-elemet-id-observer-crash-expected.txt: Added.
+* fast/dom/remove-id-form-associated-elemet-id-observer-crash.html: Added.
+
 2018-12-05  Youenn Fablet  
 
 [iOS] Layout Test imported/w3c/web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https.html is a flaky failure


Added: trunk/LayoutTests/fast/dom/remove-id-form-associated-elemet-id-observer-crash-expected.txt (0 => 238912)

--- trunk/LayoutTests/fast/dom/remove-id-form-associated-elemet-id-observer-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/dom/remove-id-form-associated-elemet-id-observer-crash-expected.txt	2018-12-05 23:06:49 UTC (rev 238912)
@@ -0,0 +1,3 @@
+This tests removing the id from an element when there is a form associated element observing the same ID. WebKit should not crash.
+
+PASS


Added: trunk/LayoutTests/fast/dom/remove-id-form-associated-elemet-id-observer-crash.html (0 => 238912)

--- trunk/LayoutTests/fast/dom/remove-id-form-associated-elemet-id-observer-crash.html	(rev 0)
+++ trunk/LayoutTests/fast/dom/remove-id-form-associated-elemet-id-observer-crash.html	2018-12-05 23:06:49 UTC (rev 238912)
@@ -0,0 +1,19 @@
+
+
+
+This tests removing the id from an element when there is a form associated element observing the same ID.
+WebKit should not crash.
+
+
+
+
+
+
+if (window.testRunner)
+testRunner.dumpAsText();
+document.querySelector('#container p').removeAttribute('id');
+container.remove();
+document.write('PASS');
+
+
+


Modified: trunk/Source/WebCore/ChangeLog (238911 => 238912)

--- trunk/Source/WebCore/ChangeLog	2018-12-05 22:44:30 UTC (rev 238911)
+++ trunk/Source/WebCore/ChangeLog	2018-12-05 23:06:49 UTC (rev 238912)
@@ -1,3 +1,21 @@
+2018-12-05  Ryosuke Niwa  
+
+Null pointer crash in DocumentOrderedMap::getElementById via FormAssociatedElement::findAssociatedForm
+https://bugs.webkit.org/show_bug.cgi?id=192392
+
+Reviewed by Dean Jackson.
+
+The crash was caused by FormAssociatedElement::findAssociatedForm invoking DocumentOrderedMap::getElementById
+and de-referencing nullptr Attribute* via IdTargetObserver before Element::attributeChanged had updated
+ElementData::m_idForStyleResolution.
+
+Fixed it by updating m_idForStyleResolution before invoking IdTargetObservers.
+
+Test: fast/dom/remove-id-form-associated-elemet-id-observer-crash.html
+
+* dom/Element.cpp:
+(WebCore::Element::attributeChanged): Fixed the bug.
+
 2018-12-05  Youenn Fablet  
 
 Enable the possibility to do video capture in UIProcess


Modified: trunk/Source/WebCore/dom/Element.cpp (238911 => 238912)

--- trunk/Source/WebCore/dom/Element.cpp	2018-12-05 22:44:30 UTC (rev 238911)
+++ trunk/Source/WebCore/dom/Element.cpp	2018-12-05 23:06:49 UTC (rev 238912)
@@ -1500,11 +1500,6 @@
 
 if (!valueIsSameAsBefore) {
 if (name == HTMLNames::idAttr) {
-if (!oldValue.isEmpty())
-treeScope().idTargetObserverRegistry().notifyObservers(*oldValue.impl());
-if (!newValue.isEmpty())
-

[webkit-changes] [238911] trunk/Source/WebKit

[cdumez]

Title: [238911] trunk/Source/WebKit








Revision 238911
Author cdu...@apple.com
Date 2018-12-05 14:44:30 -0800 (Wed, 05 Dec 2018)


Log Message
Simplify logic inside WebPageProxy::continueNavigationInNewProcess()
https://bugs.webkit.org/show_bug.cgi?id=192404

Reviewed by Alex Christensen.

Simplify get the item state from the current back/forward list item, instead of
relying on WebBackForwardList::filteredItemStates().

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::continueNavigationInNewProcess):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (238910 => 238911)

--- trunk/Source/WebKit/ChangeLog	2018-12-05 22:34:51 UTC (rev 238910)
+++ trunk/Source/WebKit/ChangeLog	2018-12-05 22:44:30 UTC (rev 238911)
@@ -1,3 +1,16 @@
+2018-12-05  Chris Dumez  
+
+Simplify logic inside WebPageProxy::continueNavigationInNewProcess()
+https://bugs.webkit.org/show_bug.cgi?id=192404
+
+Reviewed by Alex Christensen.
+
+Simplify get the item state from the current back/forward list item, instead of
+relying on WebBackForwardList::filteredItemStates().
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::continueNavigationInNewProcess):
+
 2018-12-05  Youenn Fablet  
 
 Enable the possibility to do video capture in UIProcess


Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (238910 => 238911)

--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp	2018-12-05 22:34:51 UTC (rev 238910)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp	2018-12-05 22:44:30 UTC (rev 238911)
@@ -2700,14 +2700,10 @@
 return;
 }
 
-if (navigation->lockBackForwardList() == LockBackForwardList::Yes || navigation->lockHistory() == LockHistory::Yes) {
+if (m_backForwardList->currentItem() && (navigation->lockBackForwardList() == LockBackForwardList::Yes || navigation->lockHistory() == LockHistory::Yes)) {
 // If WebCore is supposed to lock the history for this load, then the new process needs to know about the current history item so it can update
 // it instead of creating a new one.
-auto itemStates = m_backForwardList->filteredItemStates([currentItem = m_backForwardList->currentItem()](WebBackForwardListItem& item) {
-return  == currentItem;
-});
-RELEASE_ASSERT(itemStates.size() == 1);
-m_process->send(Messages::WebPage::SetCurrentHistoryItemForReattach(itemStates[0]), m_pageID);
+m_process->send(Messages::WebPage::SetCurrentHistoryItemForReattach(m_backForwardList->currentItem()->itemState()), m_pageID);
 }
 
 // FIXME: Work out timing of responding with the last policy delegate, etc






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238910] trunk/Tools

[jbedard]

Title: [238910] trunk/Tools








Revision 238910
Author jbed...@apple.com
Date 2018-12-05 14:34:51 -0800 (Wed, 05 Dec 2018)


Log Message
webkitpy: Clean-up apple_additions
https://bugs.webkit.org/show_bug.cgi?id=192413


Reviewed by Lucas Forschler.

After the addition of watchOS, some functions which were originally iOS specific were
generalized to include all devices.

* Scripts/webkitpy/port/ios_device.py:
(IOSDevicePort._driver_class): Replace iOS specific call with generalized device call.
(IOSDevicePort.path_to_crash_logs): Ditto.
(IOSDevicePort.clean_up_test_run): Ditto.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/port/ios_device.py




Diff

Modified: trunk/Tools/ChangeLog (238909 => 238910)

--- trunk/Tools/ChangeLog	2018-12-05 22:32:26 UTC (rev 238909)
+++ trunk/Tools/ChangeLog	2018-12-05 22:34:51 UTC (rev 238910)
@@ -1,5 +1,21 @@
 2018-12-05  Jonathan Bedard  
 
+webkitpy: Clean-up apple_additions
+https://bugs.webkit.org/show_bug.cgi?id=192413
+
+
+Reviewed by Lucas Forschler.
+
+After the addition of watchOS, some functions which were originally iOS specific were
+generalized to include all devices.
+
+* Scripts/webkitpy/port/ios_device.py:
+(IOSDevicePort._driver_class): Replace iOS specific call with generalized device call.
+(IOSDevicePort.path_to_crash_logs): Ditto.
+(IOSDevicePort.clean_up_test_run): Ditto.
+
+2018-12-05  Jonathan Bedard  
+
 webkitpy: Ignore case when comparing device types
 https://bugs.webkit.org/show_bug.cgi?id=192409
 


Modified: trunk/Tools/Scripts/webkitpy/port/ios_device.py (238909 => 238910)

--- trunk/Tools/Scripts/webkitpy/port/ios_device.py	2018-12-05 22:32:26 UTC (rev 238909)
+++ trunk/Tools/Scripts/webkitpy/port/ios_device.py	2018-12-05 22:34:51 UTC (rev 238910)
@@ -46,7 +46,7 @@
 
 def _driver_class(self):
 if apple_additions():
-return apple_additions().ios_device_driver()
+return apple_additions().device_driver()
 return super(IOSDevicePort, self)._driver_class()
 
 @classmethod
@@ -61,7 +61,7 @@
 def path_to_crash_logs(self):
 if not apple_additions():
 raise RuntimeError(self.NO_ON_DEVICE_TESTING)
-return apple_additions().ios_crash_log_path()
+return apple_additions().device_crash_log_path()
 
 def _look_for_all_crash_logs_in_log_dir(self, newer_than):
 log_list = {}
@@ -111,4 +111,4 @@
 
 def clean_up_test_run(self):
 super(IOSDevicePort, self).clean_up_test_run()
-apple_additions().ios_device_clean_up_test_run(self, self._path_to_driver(), self._build_path())
+apple_additions().device_clean_up_test_run(self, self._path_to_driver(), self._build_path())






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238909] trunk/Source

[youenn]

Title: [238909] trunk/Source








Revision 238909
Author you...@apple.com
Date 2018-12-05 14:32:26 -0800 (Wed, 05 Dec 2018)


Log Message
Enable the possibility to do video capture in UIProcess
https://bugs.webkit.org/show_bug.cgi?id=192394

Reviewed by Eric Carlson.

Source/WebCore:

Create IOSurface-backed sample buffers so that we can easily send them through IPC.
Manually tested.

* platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::setSizeAndFrameRateWithPreset):

Source/WebKit:

Add two web preferences to toggle audio/video capture in UIProcess or WebProcess.
Add mechanism for video capture that was not implemented yet.

* Shared/WebPreferences.yaml:
* Shared/WebPreferencesDefaultValues.h:
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
* UIProcess/API/APIProcessPoolConfiguration.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetCaptureAudioInUIProcessEnabled):
(WKPreferencesGetCaptureAudioInUIProcessEnabled):
(WKPreferencesSetCaptureVideoInUIProcessEnabled):
(WKPreferencesGetCaptureVideoInUIProcessEnabled):
* UIProcess/API/C/WKPreferencesRef.h:
* UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::updateBoolValueForInternalDebugFeatureKey):
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::initializeNewWebProcess):
(WebKit::WebProcessPool::createWebPage):
* WebProcess/cocoa/UserMediaCaptureManager.cpp:
(WebKit::UserMediaCaptureManager::initialize):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebPreferences.yaml
trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h
trunk/Source/WebKit/Shared/WebProcessCreationParameters.cpp
trunk/Source/WebKit/Shared/WebProcessCreationParameters.h
trunk/Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.h
trunk/Source/WebKit/UIProcess/API/C/WKPreferences.cpp
trunk/Source/WebKit/UIProcess/API/C/WKPreferencesRef.h
trunk/Source/WebKit/UIProcess/WebPreferences.cpp
trunk/Source/WebKit/UIProcess/WebProcessPool.cpp
trunk/Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (238908 => 238909)

--- trunk/Source/WebCore/ChangeLog	2018-12-05 21:35:50 UTC (rev 238908)
+++ trunk/Source/WebCore/ChangeLog	2018-12-05 22:32:26 UTC (rev 238909)
@@ -1,5 +1,18 @@
 2018-12-05  Youenn Fablet  
 
+Enable the possibility to do video capture in UIProcess
+https://bugs.webkit.org/show_bug.cgi?id=192394
+
+Reviewed by Eric Carlson.
+
+Create IOSurface-backed sample buffers so that we can easily send them through IPC.
+Manually tested.
+
+* platform/mediastream/mac/AVVideoCaptureSource.mm:
+(WebCore::AVVideoCaptureSource::setSizeAndFrameRateWithPreset):
+
+2018-12-05  Youenn Fablet  
+
 Update ServiceWorkerContainer::getRegistration lambdas
 https://bugs.webkit.org/show_bug.cgi?id=192376
 


Modified: trunk/Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm (238908 => 238909)

--- trunk/Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm	2018-12-05 21:35:50 UTC (rev 238908)
+++ trunk/Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm	2018-12-05 22:32:26 UTC (rev 238909)
@@ -342,7 +342,8 @@
 auto settingsDictionary = @{
 (__bridge NSString *)kCVPixelBufferPixelFormatTypeKey: @(avVideoCapturePixelBufferFormat()),
 (__bridge NSString *)kCVPixelBufferWidthKey: @(avPreset->size.width()),
-(__bridge NSString *)kCVPixelBufferHeightKey: @(avPreset->size.height())
+(__bridge NSString *)kCVPixelBufferHeightKey: @(avPreset->size.height()),
+(__bridge NSString *)kCVPixelBufferIOSurfacePropertiesKey : @{ }
 };
 [m_videoOutput setVideoSettings:settingsDictionary];
 #endif


Modified: trunk/Source/WebKit/ChangeLog (238908 => 238909)

--- trunk/Source/WebKit/ChangeLog	2018-12-05 21:35:50 UTC (rev 238908)
+++ trunk/Source/WebKit/ChangeLog	2018-12-05 22:32:26 UTC (rev 238909)
@@ -1,3 +1,34 @@
+2018-12-05  Youenn Fablet  
+
+Enable the possibility to do video capture in UIProcess
+https://bugs.webkit.org/show_bug.cgi?id=192394
+
+Reviewed by Eric Carlson.
+
+Add two web preferences to toggle audio/video capture in UIProcess or WebProcess.
+Add mechanism for video capture that was not implemented yet.
+
+* Shared/WebPreferences.yaml:
+* Shared/WebPreferencesDefaultValues.h:
+* Shared/WebProcessCreationParameters.cpp:
+(WebKit::WebProcessCreationParameters::encode const):
+(WebKit::WebProcessCreationParameters::decode):
+* Shared/WebProcessCreationParameters.h:
+* 

[webkit-changes] [238908] trunk/Source/WebCore

[youenn]

Title: [238908] trunk/Source/WebCore








Revision 238908
Author you...@apple.com
Date 2018-12-05 13:35:50 -0800 (Wed, 05 Dec 2018)


Log Message
Update ServiceWorkerContainer::getRegistration lambdas
https://bugs.webkit.org/show_bug.cgi?id=192376

Reviewed by Chris Dumez.

There is no need to pass 'this' in lambdas as the last lambda
takes a ScriptExecutionContext&.
No change of behavior.

* workers/service/ServiceWorkerContainer.cpp:
(WebCore::ServiceWorkerContainer::getRegistration):
(WebCore::ServiceWorkerContainer::getRegistrations):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/workers/service/ServiceWorkerContainer.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (238907 => 238908)

--- trunk/Source/WebCore/ChangeLog	2018-12-05 21:15:36 UTC (rev 238907)
+++ trunk/Source/WebCore/ChangeLog	2018-12-05 21:35:50 UTC (rev 238908)
@@ -1,3 +1,18 @@
+2018-12-05  Youenn Fablet  
+
+Update ServiceWorkerContainer::getRegistration lambdas
+https://bugs.webkit.org/show_bug.cgi?id=192376
+
+Reviewed by Chris Dumez.
+
+There is no need to pass 'this' in lambdas as the last lambda
+takes a ScriptExecutionContext&.
+No change of behavior.
+
+* workers/service/ServiceWorkerContainer.cpp:
+(WebCore::ServiceWorkerContainer::getRegistration):
+(WebCore::ServiceWorkerContainer::getRegistrations):
+
 2018-12-05  Chris Dumez  
 
 Crash under WebCore::cachedDocumentWrapper()


Modified: trunk/Source/WebCore/workers/service/ServiceWorkerContainer.cpp (238907 => 238908)

--- trunk/Source/WebCore/workers/service/ServiceWorkerContainer.cpp	2018-12-05 21:15:36 UTC (rev 238907)
+++ trunk/Source/WebCore/workers/service/ServiceWorkerContainer.cpp	2018-12-05 21:35:50 UTC (rev 238908)
@@ -269,10 +269,16 @@
 m_pendingPromises.add(pendingPromiseIdentifier, WTFMove(pendingPromise));
 
 auto contextIdentifier = this->contextIdentifier();
-callOnMainThread([connection = makeRef(ensureSWClientConnection()), this, topOrigin = context->topOrigin().data().isolatedCopy(), parsedURL = parsedURL.isolatedCopy(), contextIdentifier, pendingPromiseIdentifier]() mutable {
-connection->matchRegistration(WTFMove(topOrigin), parsedURL, [this, contextIdentifier, pendingPromiseIdentifier] (auto&& result) mutable {
-ScriptExecutionContext::postTaskTo(contextIdentifier, [this, pendingPromiseIdentifier, result = crossThreadCopy(result)](ScriptExecutionContext&) mutable {
-this->didFinishGetRegistrationRequest(pendingPromiseIdentifier, WTFMove(result));
+callOnMainThread([connection = makeRef(ensureSWClientConnection()), topOrigin = context->topOrigin().data().isolatedCopy(), parsedURL = parsedURL.isolatedCopy(), contextIdentifier, pendingPromiseIdentifier]() mutable {
+connection->matchRegistration(WTFMove(topOrigin), parsedURL, [contextIdentifier, pendingPromiseIdentifier] (auto&& result) mutable {
+ScriptExecutionContext::postTaskTo(contextIdentifier, [pendingPromiseIdentifier, result = crossThreadCopy(result)](auto& context) mutable {
+auto* serviceWorkerContainer = context.serviceWorkerContainer();
+if (!serviceWorkerContainer)
+return;
+if (serviceWorkerContainer->m_isStopped || !context.sessionID().isValid())
+return;
+
+serviceWorkerContainer->didFinishGetRegistrationRequest(pendingPromiseIdentifier, WTFMove(result));
 });
 });
 });
@@ -332,10 +338,16 @@
 
 auto contextIdentifier = this->contextIdentifier();
 auto contextURL = context->url();
-callOnMainThread([connection = makeRef(ensureSWClientConnection()), this, topOrigin = context->topOrigin().data().isolatedCopy(), contextURL = contextURL.isolatedCopy(), contextIdentifier, pendingPromiseIdentifier]() mutable {
-connection->getRegistrations(WTFMove(topOrigin), contextURL, [this, contextIdentifier, pendingPromiseIdentifier] (auto&& registrationDatas) mutable {
-ScriptExecutionContext::postTaskTo(contextIdentifier, [this, pendingPromiseIdentifier, registrationDatas = crossThreadCopy(registrationDatas)](ScriptExecutionContext&) mutable {
-this->didFinishGetRegistrationsRequest(pendingPromiseIdentifier, WTFMove(registrationDatas));
+callOnMainThread([connection = makeRef(ensureSWClientConnection()), topOrigin = context->topOrigin().data().isolatedCopy(), contextURL = contextURL.isolatedCopy(), contextIdentifier, pendingPromiseIdentifier]() mutable {
+connection->getRegistrations(WTFMove(topOrigin), contextURL, [contextIdentifier, pendingPromiseIdentifier] (auto&& registrationDatas) mutable {
+ScriptExecutionContext::postTaskTo(contextIdentifier, [pendingPromiseIdentifier, registrationDatas = crossThreadCopy(registrationDatas)](auto& context) mutable {
+auto* serviceWorkerContainer = 

[webkit-changes] [238907] trunk/LayoutTests

[youenn]

Title: [238907] trunk/LayoutTests








Revision 238907
Author you...@apple.com
Date 2018-12-05 13:15:36 -0800 (Wed, 05 Dec 2018)


Log Message
[iOS] Layout Test imported/w3c/web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=189727


Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

Make the test more deterministic and output more test to ease debugging.

* web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https-expected.txt:
* web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https.html:
* web-platform-tests/service-workers/service-worker/resources/fetch-cors-xhr-iframe.html:

LayoutTests:

* TestExpectations:
* platform/ios/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https.html
trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/resources/fetch-cors-xhr-iframe.html
trunk/LayoutTests/platform/ios/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (238906 => 238907)

--- trunk/LayoutTests/ChangeLog	2018-12-05 21:02:46 UTC (rev 238906)
+++ trunk/LayoutTests/ChangeLog	2018-12-05 21:15:36 UTC (rev 238907)
@@ -1,3 +1,14 @@
+2018-12-05  Youenn Fablet  
+
+[iOS] Layout Test imported/w3c/web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=189727
+
+
+Reviewed by Chris Dumez.
+
+* TestExpectations:
+* platform/ios/TestExpectations:
+
 2018-12-05  Commit Queue  
 
 Unreviewed, rolling out r238844, r238846, and r238874.


Modified: trunk/LayoutTests/TestExpectations (238906 => 238907)

--- trunk/LayoutTests/TestExpectations	2018-12-05 21:02:46 UTC (rev 238906)
+++ trunk/LayoutTests/TestExpectations	2018-12-05 21:15:36 UTC (rev 238907)
@@ -263,7 +263,6 @@
 imported/w3c/web-platform-tests/fetch/api/redirect/redirect-mode-worker.html [ DumpJSConsoleLogInStdErr ]
 imported/w3c/web-platform-tests/fetch/api/redirect/redirect-to-dataurl.html [ DumpJSConsoleLogInStdErr ]
 
-webkit.org/b/181901 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https.html [ DumpJSConsoleLogInStdErr ]
 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-response-taint.https.html [ DumpJSConsoleLogInStdErr ]
 imported/w3c/web-platform-tests/service-workers/service-worker/register-closed-window.https.html [ DumpJSConsoleLogInStdErr ]
 imported/w3c/web-platform-tests/service-workers/service-worker/registration-security-error.https.html [ DumpJSConsoleLogInStdErr ]


Modified: trunk/LayoutTests/imported/w3c/ChangeLog (238906 => 238907)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2018-12-05 21:02:46 UTC (rev 238906)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2018-12-05 21:15:36 UTC (rev 238907)
@@ -1,3 +1,17 @@
+2018-12-05  Youenn Fablet  
+
+[iOS] Layout Test imported/w3c/web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=189727
+
+
+Reviewed by Chris Dumez.
+
+Make the test more deterministic and output more test to ease debugging.
+
+* web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https-expected.txt:
+* web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https.html:
+* web-platform-tests/service-workers/service-worker/resources/fetch-cors-xhr-iframe.html:
+
 2018-12-05  Frederic Wang  
 
 Import css overscroll behavior WPT test


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https-expected.txt (238906 => 238907)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https-expected.txt	2018-12-05 21:02:46 UTC (rev 238906)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https-expected.txt	2018-12-05 21:15:36 UTC (rev 238907)
@@ -1,3 +1,87 @@
+CONSOLE MESSAGE: FetchEvent.respondWith received an error: undefined
+CONSOLE MESSAGE: XMLHttpRequest cannot load https://localhost:9443/service-workers/service-worker/resources/fetch-access-control.py?reject.
+CONSOLE MESSAGE: FetchEvent.respondWith received an error: undefined
+CONSOLE MESSAGE: XMLHttpRequest cannot load https://localhost:9443/service-workers/service-worker/resources/fetch-access-control.py?reject.
+CONSOLE MESSAGE: FetchEvent.respondWith received an error: undefined
+CONSOLE MESSAGE: XMLHttpRequest cannot load 

[webkit-changes] [238906] trunk/Tools

[jbedard]

Title: [238906] trunk/Tools








Revision 238906
Author jbed...@apple.com
Date 2018-12-05 13:02:46 -0800 (Wed, 05 Dec 2018)


Log Message
webkitpy: Ignore case when comparing device types
https://bugs.webkit.org/show_bug.cgi?id=192409


Reviewed by Lucas Forschler.

This allows DeviceTypes constructed with lowercase strings to correctly compare
against DeviceTypes coming from the simulator runtime.

* Scripts/webkitpy/xcode/device_type.py:
(DeviceType.__eq__):
(DeviceType.__contains__):
* Scripts/webkitpy/xcode/device_type_unittest.py:
(DeviceTypeTest):
(DeviceTypeTest.test_comparsion_lower_case):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/xcode/device_type.py
trunk/Tools/Scripts/webkitpy/xcode/device_type_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (238905 => 238906)

--- trunk/Tools/ChangeLog	2018-12-05 20:58:55 UTC (rev 238905)
+++ trunk/Tools/ChangeLog	2018-12-05 21:02:46 UTC (rev 238906)
@@ -1,5 +1,23 @@
 2018-12-05  Jonathan Bedard  
 
+webkitpy: Ignore case when comparing device types
+https://bugs.webkit.org/show_bug.cgi?id=192409
+
+
+Reviewed by Lucas Forschler.
+
+This allows DeviceTypes constructed with lowercase strings to correctly compare
+against DeviceTypes coming from the simulator runtime.
+
+* Scripts/webkitpy/xcode/device_type.py:
+(DeviceType.__eq__):
+(DeviceType.__contains__):
+* Scripts/webkitpy/xcode/device_type_unittest.py:
+(DeviceTypeTest):
+(DeviceTypeTest.test_comparsion_lower_case):
+
+2018-12-05  Jonathan Bedard  
+
 webkitpy: Sort tests by associated device type
 https://bugs.webkit.org/show_bug.cgi?id=192161
 


Modified: trunk/Tools/Scripts/webkitpy/xcode/device_type.py (238905 => 238906)

--- trunk/Tools/Scripts/webkitpy/xcode/device_type.py	2018-12-05 20:58:55 UTC (rev 238905)
+++ trunk/Tools/Scripts/webkitpy/xcode/device_type.py	2018-12-05 21:02:46 UTC (rev 238906)
@@ -117,11 +117,11 @@
 # This technique of matching treats 'None' a wild-card.
 def __eq__(self, other):
 assert isinstance(other, DeviceType)
-if self.hardware_family is not None and other.hardware_family is not None and self.hardware_family != other.hardware_family:
+if self.hardware_family is not None and other.hardware_family is not None and self.hardware_family.lower() != other.hardware_family.lower():
 return False
-if self.hardware_type is not None and other.hardware_type is not None and self.hardware_type != other.hardware_type:
+if self.hardware_type is not None and other.hardware_type is not None and self.hardware_type.lower() != other.hardware_type.lower():
 return False
-if self.software_variant is not None and other.software_variant is not None and self.software_variant != other.software_variant:
+if self.software_variant is not None and other.software_variant is not None and self.software_variant.lower() != other.software_variant.lower():
 return False
 if self.software_version is not None and other.software_version is not None and self.software_version != other.software_version:
 return False
@@ -129,11 +129,11 @@
 
 def __contains__(self, other):
 assert isinstance(other, DeviceType)
-if self.hardware_family is not None and self.hardware_family != other.hardware_family:
+if self.hardware_family is not None and (not other.hardware_family or self.hardware_family.lower() != other.hardware_family.lower()):
 return False
-if self.hardware_type is not None and self.hardware_type != other.hardware_type:
+if self.hardware_type is not None and (not other.hardware_type or self.hardware_type.lower() != other.hardware_type.lower()):
 return False
-if self.software_variant is not None and self.software_variant != other.software_variant:
+if self.software_variant is not None and (not other.software_variant or self.software_variant.lower() != other.software_variant.lower()):
 return False
 if self.software_version is not None and other.software_version is not None and not other.software_version in self.software_version:
 return False


Modified: trunk/Tools/Scripts/webkitpy/xcode/device_type_unittest.py (238905 => 238906)

--- trunk/Tools/Scripts/webkitpy/xcode/device_type_unittest.py	2018-12-05 20:58:55 UTC (rev 238905)
+++ trunk/Tools/Scripts/webkitpy/xcode/device_type_unittest.py	2018-12-05 21:02:46 UTC (rev 238906)
@@ -143,3 +143,15 @@
 self.assertFalse(DeviceType.from_string('iPhone') in DeviceType.from_string('iPhone 6s'))
 self.assertTrue(DeviceType.from_string('iPhone', Version(11, 1)) in DeviceType.from_string('iPhone', Version(11)))
 self.assertFalse(DeviceType.from_string('iPhone', Version(11)) in DeviceType.from_string('iPhone', Version(11, 1)))
+
+def 

[webkit-changes] [238905] trunk/Source/WebCore

[cdumez]

Title: [238905] trunk/Source/WebCore








Revision 238905
Author cdu...@apple.com
Date 2018-12-05 12:58:55 -0800 (Wed, 05 Dec 2018)


Log Message
Crash under WebCore::cachedDocumentWrapper()
https://bugs.webkit.org/show_bug.cgi?id=192421


Reviewed by Alex Christensen.

Fix potential null defererence of the value returned by toJSDOMWindow(). For example,
if the window is frameless, it would return null.

* bindings/js/JSDocumentCustom.cpp:
(WebCore::cachedDocumentWrapper):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDocumentCustom.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (238904 => 238905)

--- trunk/Source/WebCore/ChangeLog	2018-12-05 20:21:54 UTC (rev 238904)
+++ trunk/Source/WebCore/ChangeLog	2018-12-05 20:58:55 UTC (rev 238905)
@@ -1,3 +1,17 @@
+2018-12-05  Chris Dumez  
+
+Crash under WebCore::cachedDocumentWrapper()
+https://bugs.webkit.org/show_bug.cgi?id=192421
+
+
+Reviewed by Alex Christensen.
+
+Fix potential null defererence of the value returned by toJSDOMWindow(). For example,
+if the window is frameless, it would return null.
+
+* bindings/js/JSDocumentCustom.cpp:
+(WebCore::cachedDocumentWrapper):
+
 2018-12-05  Eric Carlson  
 
 [MediaStream] Cleanup up Mac screen capture class


Modified: trunk/Source/WebCore/bindings/js/JSDocumentCustom.cpp (238904 => 238905)

--- trunk/Source/WebCore/bindings/js/JSDocumentCustom.cpp	2018-12-05 20:21:54 UTC (rev 238904)
+++ trunk/Source/WebCore/bindings/js/JSDocumentCustom.cpp	2018-12-05 20:58:55 UTC (rev 238905)
@@ -57,8 +57,12 @@
 if (!window)
 return nullptr;
 
+auto* documentGlobalObject = toJSDOMWindow(state.vm(), toJS(, *window));
+if (!documentGlobalObject)
+return nullptr;
+
 // Creating a wrapper for domWindow might have created a wrapper for document as well.
-return getCachedWrapper(toJSDOMWindow(state.vm(), toJS(, *window))->world(), document);
+return getCachedWrapper(documentGlobalObject->world(), document);
 }
 
 void reportMemoryForDocumentIfFrameless(ExecState& state, Document& document)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238904] trunk/Source/WebCore

[eric . carlson]

Title: [238904] trunk/Source/WebCore








Revision 238904
Author eric.carl...@apple.com
Date 2018-12-05 12:21:54 -0800 (Wed, 05 Dec 2018)


Log Message
[MediaStream] Cleanup up Mac screen capture class
https://bugs.webkit.org/show_bug.cgi?id=192379


Reviewed by Youenn Fablet.

No new tests, tested manually.

* platform/mediastream/mac/DisplayCaptureManagerCocoa.cpp:
(WebCore::DisplayCaptureManagerCocoa::captureDevices): Initialize Screen devices first so
they are first in the list of devices.

* platform/mediastream/mac/ScreenDisplayCaptureSourceMac.h:
* platform/mediastream/mac/ScreenDisplayCaptureSourceMac.mm:
(WebCore::ScreenDisplayCaptureSourceMac::createDisplayStream): Cleanup. Always capture at the
native screen size to work around a bug.
(WebCore::ScreenDisplayCaptureSourceMac::settingsDidChange): Deleted.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mediastream/mac/DisplayCaptureManagerCocoa.cpp
trunk/Source/WebCore/platform/mediastream/mac/ScreenDisplayCaptureSourceMac.h
trunk/Source/WebCore/platform/mediastream/mac/ScreenDisplayCaptureSourceMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (238903 => 238904)

--- trunk/Source/WebCore/ChangeLog	2018-12-05 19:30:47 UTC (rev 238903)
+++ trunk/Source/WebCore/ChangeLog	2018-12-05 20:21:54 UTC (rev 238904)
@@ -1,3 +1,23 @@
+2018-12-05  Eric Carlson  
+
+[MediaStream] Cleanup up Mac screen capture class
+https://bugs.webkit.org/show_bug.cgi?id=192379
+
+
+Reviewed by Youenn Fablet.
+
+No new tests, tested manually.
+
+* platform/mediastream/mac/DisplayCaptureManagerCocoa.cpp:
+(WebCore::DisplayCaptureManagerCocoa::captureDevices): Initialize Screen devices first so
+they are first in the list of devices.
+
+* platform/mediastream/mac/ScreenDisplayCaptureSourceMac.h:
+* platform/mediastream/mac/ScreenDisplayCaptureSourceMac.mm:
+(WebCore::ScreenDisplayCaptureSourceMac::createDisplayStream): Cleanup. Always capture at the
+native screen size to work around a bug.
+(WebCore::ScreenDisplayCaptureSourceMac::settingsDidChange): Deleted.
+
 2018-12-05  Commit Queue  
 
 Unreviewed, rolling out r238844, r238846, and r238874.


Modified: trunk/Source/WebCore/platform/mediastream/mac/DisplayCaptureManagerCocoa.cpp (238903 => 238904)

--- trunk/Source/WebCore/platform/mediastream/mac/DisplayCaptureManagerCocoa.cpp	2018-12-05 19:30:47 UTC (rev 238903)
+++ trunk/Source/WebCore/platform/mediastream/mac/DisplayCaptureManagerCocoa.cpp	2018-12-05 20:21:54 UTC (rev 238904)
@@ -52,8 +52,8 @@
 {
 m_devices.clear();
 
+updateDisplayCaptureDevices();
 updateWindowCaptureDevices();
-updateDisplayCaptureDevices();
 
 return m_devices;
 }


Modified: trunk/Source/WebCore/platform/mediastream/mac/ScreenDisplayCaptureSourceMac.h (238903 => 238904)

--- trunk/Source/WebCore/platform/mediastream/mac/ScreenDisplayCaptureSourceMac.h	2018-12-05 19:30:47 UTC (rev 238903)
+++ trunk/Source/WebCore/platform/mediastream/mac/ScreenDisplayCaptureSourceMac.h	2018-12-05 20:21:54 UTC (rev 238904)
@@ -61,7 +61,6 @@
 
 void startProducingData() final;
 void stopProducingData() final;
-void settingsDidChange(OptionSet) final;
 void commitConfiguration() final;
 
 bool createDisplayStream();
@@ -95,8 +94,6 @@
 mutable Lock m_currentFrameMutex;
 DisplaySurface m_currentFrame;
 RetainPtr m_displayStream;
-CGDisplayStreamFrameAvailableHandler m_frameAvailableBlock;
-
 OSObjectPtr m_captureQueue;
 
 uint32_t m_displayID { 0 };


Modified: trunk/Source/WebCore/platform/mediastream/mac/ScreenDisplayCaptureSourceMac.mm (238903 => 238904)

--- trunk/Source/WebCore/platform/mediastream/mac/ScreenDisplayCaptureSourceMac.mm	2018-12-05 19:30:47 UTC (rev 238903)
+++ trunk/Source/WebCore/platform/mediastream/mac/ScreenDisplayCaptureSourceMac.mm	2018-12-05 20:21:54 UTC (rev 238904)
@@ -124,6 +124,7 @@
 if (m_displayID != actualDisplayID.value()) {
 m_displayID = actualDisplayID.value();
 RELEASE_LOG(Media, "ScreenDisplayCaptureSourceMac::createDisplayStream: display ID changed to %d", static_cast(m_displayID));
+m_displayStream = nullptr;
 }
 
 if (!m_displayStream) {
@@ -140,34 +141,22 @@
 if (!m_captureQueue)
 m_captureQueue = adoptOSObject(dispatch_queue_create("ScreenDisplayCaptureSourceMac Capture Queue", DISPATCH_QUEUE_SERIAL));
 
-double frameTime = 1 / frameRate();
-auto frameTimeCF = adoptCF(CFNumberCreate(nullptr,  kCFNumberDoubleType,  ));
-int depth = screenQueueMaximumLength;
-auto depthCF = adoptCF(CFNumberCreate(nullptr,  kCFNumberIntType,  ));
-CFTypeRef keys[] = {
-kCGDisplayStreamMinimumFrameTime,
-kCGDisplayStreamQueueDepth,
-kCGDisplayStreamColorSpace,
-kCGDisplayStreamShowCursor,
+CFDictionaryRef streamOptions = (__bridge 

[webkit-changes] [238903] trunk/Tools

[jbedard]

Title: [238903] trunk/Tools








Revision 238903
Author jbed...@apple.com
Date 2018-12-05 11:30:47 -0800 (Wed, 05 Dec 2018)


Log Message
webkitpy: Sort tests by associated device type
https://bugs.webkit.org/show_bug.cgi?id=192161


Reviewed by Lucas Forschler.

Sort tests by device type and make an effort to run each specified device type.
Do not run tests if their specified device is not available.

* Scripts/webkitpy/common/system/platforminfo.py:
(PlatformInfo.is_watchos): Add watchos bits to platform info.
(PlatformInfo._determine_os_name): Ditto.
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.run): Assign each test a device type. Then, generate a list of
device types to sequentially iterate through. Note that a test will run
on the first device which matches.
(Manager._end_test_run): Handle the case where no devices are available and no
tests are run.
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(_set_up_derived_options): Manage child processes in manager.
* Scripts/webkitpy/port/base.py:
(Port):
(Port.default_child_processes): Accept additional arguments.
(Port.max_child_processes): Add upper limit for number of child processes.
* Scripts/webkitpy/port/device_port.py:
(DevicePort):
(DevicePort._device_type_with_version): Adds version to the DeviceType.
(DevicePort.default_child_processes): Allows default_child_processes to be
attached to a device type.
(DevicePort.max_child_processes): Add upper limit to the maximum number of child processes.
(DevicePort.setup_test_run): Use _device_type_with_version.
* Scripts/webkitpy/port/ios_device.py:
(IOSDevicePort):
(IOSDevicePort.default_child_processes): Deleted.
* Scripts/webkitpy/port/ios_simulator.py:
(IOSSimulatorPort.default_child_processes): Deleted.
(IOSSimulatorPort.check_sys_deps): Deleted.
* Scripts/webkitpy/port/mac.py:
(MacPort.default_child_processes): Accept additional arguments.
* Scripts/webkitpy/port/test.py:
* Scripts/webkitpy/port/watch_device.py:
(WatchDevicePort):
(WatchDevicePort.default_child_processes): Deleted.
* Scripts/webkitpy/port/watch_simulator.py:
(WatchSimulatorPort.default_child_processes): Deleted.
(WatchSimulatorPort.check_sys_deps): Deleted.
* Scripts/webkitpy/xcode/simulated_device.py:
(SimulatedDeviceManager):
(SimulatedDeviceManager.device_count_for_type): Count the number of devices
available for a specific device type.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/system/platforminfo.py
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
trunk/Tools/Scripts/webkitpy/port/base.py
trunk/Tools/Scripts/webkitpy/port/device_port.py
trunk/Tools/Scripts/webkitpy/port/ios_device.py
trunk/Tools/Scripts/webkitpy/port/ios_simulator.py
trunk/Tools/Scripts/webkitpy/port/mac.py
trunk/Tools/Scripts/webkitpy/port/test.py
trunk/Tools/Scripts/webkitpy/port/watch_device.py
trunk/Tools/Scripts/webkitpy/port/watch_simulator.py
trunk/Tools/Scripts/webkitpy/xcode/simulated_device.py




Diff

Modified: trunk/Tools/ChangeLog (238902 => 238903)

--- trunk/Tools/ChangeLog	2018-12-05 19:21:23 UTC (rev 238902)
+++ trunk/Tools/ChangeLog	2018-12-05 19:30:47 UTC (rev 238903)
@@ -1,3 +1,56 @@
+2018-12-05  Jonathan Bedard  
+
+webkitpy: Sort tests by associated device type
+https://bugs.webkit.org/show_bug.cgi?id=192161
+
+
+Reviewed by Lucas Forschler.
+
+Sort tests by device type and make an effort to run each specified device type.
+Do not run tests if their specified device is not available.
+
+* Scripts/webkitpy/common/system/platforminfo.py:
+(PlatformInfo.is_watchos): Add watchos bits to platform info.
+(PlatformInfo._determine_os_name): Ditto.
+* Scripts/webkitpy/layout_tests/controllers/manager.py:
+(Manager.run): Assign each test a device type. Then, generate a list of
+device types to sequentially iterate through. Note that a test will run
+on the first device which matches.
+(Manager._end_test_run): Handle the case where no devices are available and no
+tests are run.
+* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
+(_set_up_derived_options): Manage child processes in manager.
+* Scripts/webkitpy/port/base.py:
+(Port):
+(Port.default_child_processes): Accept additional arguments.
+(Port.max_child_processes): Add upper limit for number of child processes.
+* Scripts/webkitpy/port/device_port.py:
+(DevicePort):
+(DevicePort._device_type_with_version): Adds version to the DeviceType.
+(DevicePort.default_child_processes): Allows default_child_processes to be
+attached to a device type.
+(DevicePort.max_child_processes): Add upper limit to the maximum number of child processes.
+(DevicePort.setup_test_run): Use _device_type_with_version.
+* 

[webkit-changes] [238902] trunk

[commit-queue]

Title: [238902] trunk








Revision 238902
Author commit-qu...@webkit.org
Date 2018-12-05 11:21:23 -0800 (Wed, 05 Dec 2018)


Log Message
Unreviewed, rolling out r238844, r238846, and r238874.
https://bugs.webkit.org/show_bug.cgi?id=192414

The layout tests added with this change are flaky. (Requested
by ryanhaddad on #webkit).

Reverted changesets:

"Implement non-timeslice mode encoding for MediaRecorder"
https://bugs.webkit.org/show_bug.cgi?id=192069
https://trac.webkit.org/changeset/238844

"Fix the build"
https://trac.webkit.org/changeset/238846

"Fix MediaRecorder flaky tests"
https://bugs.webkit.org/show_bug.cgi?id=192371
https://trac.webkit.org/changeset/238874

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/wpt/mediarecorder/MediaRecorder-dataavailable.html
trunk/LayoutTests/http/wpt/mediarecorder/MediaRecorder-mock-dataavailable.html
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/wpe/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediarecorder/MediaRecorder.cpp
trunk/Source/WebCore/Modules/mediarecorder/MediaRecorder.h
trunk/Source/WebCore/Modules/mediarecorder/MediaRecorder.idl
trunk/Source/WebCore/SourcesCocoa.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/platform/mediarecorder/MediaRecorderPrivate.h
trunk/Source/WebCore/platform/mediarecorder/MediaRecorderPrivateMock.cpp
trunk/Source/WebCore/platform/mediarecorder/MediaRecorderPrivateMock.h
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl


Removed Paths

trunk/LayoutTests/http/wpt/mediarecorder/MediaRecorder-AV-audio-only-dataavailable-expected.txt
trunk/LayoutTests/http/wpt/mediarecorder/MediaRecorder-AV-audio-only-dataavailable.html
trunk/LayoutTests/http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable-expected.txt
trunk/LayoutTests/http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable.html
trunk/LayoutTests/http/wpt/mediarecorder/MediaRecorder-AV-video-only-dataavailable-expected.txt
trunk/LayoutTests/http/wpt/mediarecorder/MediaRecorder-AV-video-only-dataavailable.html
trunk/Source/WebCore/platform/mediarecorder/MediaRecorderPrivateAVFImpl.cpp
trunk/Source/WebCore/platform/mediarecorder/MediaRecorderPrivateAVFImpl.h
trunk/Source/WebCore/platform/mediarecorder/cocoa/




Diff

Modified: trunk/LayoutTests/ChangeLog (238901 => 238902)

--- trunk/LayoutTests/ChangeLog	2018-12-05 19:19:00 UTC (rev 238901)
+++ trunk/LayoutTests/ChangeLog	2018-12-05 19:21:23 UTC (rev 238902)
@@ -1,3 +1,24 @@
+2018-12-05  Commit Queue  
+
+Unreviewed, rolling out r238844, r238846, and r238874.
+https://bugs.webkit.org/show_bug.cgi?id=192414
+
+The layout tests added with this change are flaky. (Requested
+by ryanhaddad on #webkit).
+
+Reverted changesets:
+
+"Implement non-timeslice mode encoding for MediaRecorder"
+https://bugs.webkit.org/show_bug.cgi?id=192069
+https://trac.webkit.org/changeset/238844
+
+"Fix the build"
+https://trac.webkit.org/changeset/238846
+
+"Fix MediaRecorder flaky tests"
+https://bugs.webkit.org/show_bug.cgi?id=192371
+https://trac.webkit.org/changeset/238874
+
 2018-12-05  Per Arne Vollan  
 
 Layout Test http/tests/misc/resource-timing-resolution.html is a flaky failure


Deleted: trunk/LayoutTests/http/wpt/mediarecorder/MediaRecorder-AV-audio-only-dataavailable-expected.txt (238901 => 238902)

--- trunk/LayoutTests/http/wpt/mediarecorder/MediaRecorder-AV-audio-only-dataavailable-expected.txt	2018-12-05 19:19:00 UTC (rev 238901)
+++ trunk/LayoutTests/http/wpt/mediarecorder/MediaRecorder-AV-audio-only-dataavailable-expected.txt	2018-12-05 19:21:23 UTC (rev 238902)
@@ -1,3 +0,0 @@
-
-PASS MediaRecorder can successfully record the audio for a audio-only stream 
-


Deleted: trunk/LayoutTests/http/wpt/mediarecorder/MediaRecorder-AV-audio-only-dataavailable.html (238901 => 238902)

--- trunk/LayoutTests/http/wpt/mediarecorder/MediaRecorder-AV-audio-only-dataavailable.html	2018-12-05 19:19:00 UTC (rev 238901)
+++ trunk/LayoutTests/http/wpt/mediarecorder/MediaRecorder-AV-audio-only-dataavailable.html	2018-12-05 19:21:23 UTC (rev 238902)
@@ -1,45 +0,0 @@
-
-
-
-MediaRecorder can successfully record the audio for a audio-only stream
-
-
-
-
-
-
-const ac = new webkitAudioContext();
-const osc = ac.createOscillator();
-const dest = ac.createMediaStreamDestination();
-const audio = dest.stream;
-osc.connect(dest);
-const recorder = new MediaRecorder(audio);
-recorder._ondataavailable_ = (blobEvent) => {
-assert_true(blobEvent instanceof BlobEvent, 'the type of event should be BlobEvent');
-assert_equals(blobEvent.type, 'dataavailable', 'the event type should be dataavailable');
-assert_true(blobEvent.isTrusted, 'isTrusted should be true when the event is created 

[webkit-changes] [238901] trunk/Tools

[drousso]

Title: [238901] trunk/Tools








Revision 238901
Author drou...@apple.com
Date 2018-12-05 11:19:00 -0800 (Wed, 05 Dec 2018)


Log Message
Unreviewed, add myself to some watch lists.

* Scripts/webkitpy/common/config/watchlist:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/watchlist




Diff

Modified: trunk/Tools/ChangeLog (238900 => 238901)

--- trunk/Tools/ChangeLog	2018-12-05 18:42:21 UTC (rev 238900)
+++ trunk/Tools/ChangeLog	2018-12-05 19:19:00 UTC (rev 238901)
@@ -1,3 +1,9 @@
+2018-12-05  Devin Rousso  
+
+Unreviewed, add myself to some watch lists.
+
+* Scripts/webkitpy/common/config/watchlist:
+
 2018-12-05  Alicia Boya García  
 
 [MSE][GStreamer] Remove the AppendPipeline state machine


Modified: trunk/Tools/Scripts/webkitpy/common/config/watchlist (238900 => 238901)

--- trunk/Tools/Scripts/webkitpy/common/config/watchlist	2018-12-05 18:42:21 UTC (rev 238900)
+++ trunk/Tools/Scripts/webkitpy/common/config/watchlist	2018-12-05 19:19:00 UTC (rev 238901)
@@ -421,8 +421,8 @@
 "WTF": [ "benja...@webkit.org", "cmarc...@webkit.org", "cdu...@apple.com", "dba...@webkit.org" ],
 "WebGL": [ "d...@apple.com", "kondapallykal...@gmail.com", "grao...@webkit.org" ],
 "WebIDL": [ "esprehn+aut...@chromium.org", "cdu...@apple.com", "kondapallykal...@gmail.com" ],
-"WebInspectorBackend": [ "joep...@webkit.org" ],
-"WebInspectorGenerator": [ "bb...@apple.com", "joep...@webkit.org" ],
+"WebInspectorBackend": [ "joep...@webkit.org", "drou...@apple.com" ],
+"WebInspectorGenerator": [ "bb...@apple.com", "joep...@webkit.org", "drou...@apple.com" ],
 "WebInspectorRecording": [ "drou...@apple.com" ],
 "JSBuiltins": [ "joep...@webkit.org" ],
 "JSBuiltinsGenerator": [ "bb...@apple.com" ],






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238900] trunk/Source/WebKit

[achristensen]

Title: [238900] trunk/Source/WebKit








Revision 238900
Author achristen...@apple.com
Date 2018-12-05 10:42:21 -0800 (Wed, 05 Dec 2018)


Log Message
Make WebsiteDataStoreConfiguration a proper API object
https://bugs.webkit.org/show_bug.cgi?id=192380

Reviewed by Youenn Fablet.

In the immediate future I'll need to add things to _WKWebsiteDataStoreConfiguration.
Instead of making ivars, setting them, copying them to a local object, make this a wrapper of an API::Object
like all our other ObjC API objects are.

* Shared/API/APIObject.h:
(API::Object::wrapper const):
(API::Object::wrapper): Deleted.
* Shared/Cocoa/APIObject.mm:
(API::Object::ref const):
(API::Object::deref const):
(API::Object::newObject):
(API::Object::ref): Deleted.
(API::Object::deref): Deleted.
* Sources.txt:
* UIProcess/API/APIProcessPoolConfiguration.cpp:
(API::ProcessPoolConfiguration::createWithWebsiteDataStoreConfiguration):
* UIProcess/API/APIProcessPoolConfiguration.h:
* UIProcess/API/APIWebsiteDataStore.cpp:
(API::WebsiteDataStore::createLegacy):
(API::WebsiteDataStore::WebsiteDataStore):
(API::WebsiteDataStore::legacyDefaultDataStoreConfiguration):
* UIProcess/API/APIWebsiteDataStore.h:
* UIProcess/API/Cocoa/APIWebsiteDataStoreCocoa.mm:
(API::WebsiteDataStore::defaultDataStoreConfiguration):
* UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(-[WKWebsiteDataStore _initWithConfiguration:]):
* UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.mm:
(-[_WKWebsiteDataStoreConfiguration _webStorageDirectory]):
(-[_WKWebsiteDataStoreConfiguration _setWebStorageDirectory:]):
(-[_WKWebsiteDataStoreConfiguration _indexedDBDatabaseDirectory]):
(-[_WKWebsiteDataStoreConfiguration _setIndexedDBDatabaseDirectory:]):
(-[_WKWebsiteDataStoreConfiguration _webSQLDatabaseDirectory]):
(-[_WKWebsiteDataStoreConfiguration _setWebSQLDatabaseDirectory:]):
(-[_WKWebsiteDataStoreConfiguration _cookieStorageFile]):
(-[_WKWebsiteDataStoreConfiguration _setCookieStorageFile:]):
(-[_WKWebsiteDataStoreConfiguration _resourceLoadStatisticsDirectory]):
(-[_WKWebsiteDataStoreConfiguration _setResourceLoadStatisticsDirectory:]):
(-[_WKWebsiteDataStoreConfiguration _cacheStorageDirectory]):
(-[_WKWebsiteDataStoreConfiguration _setCacheStorageDirectory:]):
(-[_WKWebsiteDataStoreConfiguration _serviceWorkerRegistrationDirectory]):
(-[_WKWebsiteDataStoreConfiguration _setServiceWorkerRegistrationDirectory:]):
(-[_WKWebsiteDataStoreConfiguration setSourceApplicationBundleIdentifier:]):
(-[_WKWebsiteDataStoreConfiguration sourceApplicationBundleIdentifier]):
(-[_WKWebsiteDataStoreConfiguration sourceApplicationSecondaryIdentifier]):
(-[_WKWebsiteDataStoreConfiguration setSourceApplicationSecondaryIdentifier:]):
(-[_WKWebsiteDataStoreConfiguration _apiObject]):
* UIProcess/API/Cocoa/_WKWebsiteDataStoreConfigurationInternal.h: Added.
* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::retrieveCacheStorageParameters):
* UIProcess/WebProcessPool.cpp:
(WebKit::legacyWebsiteDataStoreConfiguration):
(WebKit::WebProcessPool::mayHaveRegisteredServiceWorkers):
* UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStore::parameters):
* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::create):
(WebKit::WebsiteDataStore::WebsiteDataStore):
(WebKit::WebsiteDataStore::resolveDirectoriesIfNecessary):
(WebKit::WebsiteDataStore::fetchDataAndApply):
(WebKit::WebsiteDataStore::removeData):
(WebKit::WebsiteDataStore::parameters):
(WebKit::WebsiteDataStore::Configuration::Configuration): Deleted.
* UIProcess/WebsiteData/WebsiteDataStore.h:
(WebKit::WebsiteDataStore::cacheStoragePerOriginQuota const):
(WebKit::WebsiteDataStore::setCacheStoragePerOriginQuota):
(WebKit::WebsiteDataStore::cacheStorageDirectory const):
(WebKit::WebsiteDataStore::setCacheStorageDirectory):
(WebKit::WebsiteDataStore::serviceWorkerRegistrationDirectory const):
(WebKit::WebsiteDataStore::setServiceWorkerRegistrationDirectory):
(WebKit::WebsiteDataStore::resolvedApplicationCacheDirectory const):
(WebKit::WebsiteDataStore::resolvedMediaCacheDirectory const):
(WebKit::WebsiteDataStore::resolvedMediaKeysDirectory const):
(WebKit::WebsiteDataStore::resolvedDatabaseDirectory const):
(WebKit::WebsiteDataStore::resolvedJavaScriptConfigurationDirectory const):
(WebKit::WebsiteDataStore::resolvedCookieStorageFile const):
(WebKit::WebsiteDataStore::resolvedIndexedDatabaseDirectory const):
(WebKit::WebsiteDataStore::resolvedServiceWorkerRegistrationDirectory const):
(WebKit::WebsiteDataStore::resolvedResourceLoadStatisticsDirectory const):
* UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp: Added.
(WebKit::WebsiteDataStoreConfiguration::WebsiteDataStoreConfiguration):
* UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h: Added.
(WebKit::WebsiteDataStoreConfiguration::create):
(WebKit::WebsiteDataStoreConfiguration::cacheStoragePerOriginQuota):
(WebKit::WebsiteDataStoreConfiguration::setCacheStoragePerOriginQuota):

[webkit-changes] [238899] trunk/LayoutTests

[pvollan]

Title: [238899] trunk/LayoutTests








Revision 238899
Author pvol...@apple.com
Date 2018-12-05 10:33:14 -0800 (Wed, 05 Dec 2018)


Log Message
Layout Test http/tests/misc/resource-timing-resolution.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=181957

Unreviewed test gardening.

* platform/win/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (238898 => 238899)

--- trunk/LayoutTests/ChangeLog	2018-12-05 18:20:56 UTC (rev 238898)
+++ trunk/LayoutTests/ChangeLog	2018-12-05 18:33:14 UTC (rev 238899)
@@ -1,3 +1,12 @@
+2018-12-05  Per Arne Vollan  
+
+Layout Test http/tests/misc/resource-timing-resolution.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=181957
+
+Unreviewed test gardening.
+
+* platform/win/TestExpectations:
+
 2018-12-05  Alicia Boya García  
 
 [MSE][GStreamer] Remove the AppendPipeline state machine


Modified: trunk/LayoutTests/platform/win/TestExpectations (238898 => 238899)

--- trunk/LayoutTests/platform/win/TestExpectations	2018-12-05 18:20:56 UTC (rev 238898)
+++ trunk/LayoutTests/platform/win/TestExpectations	2018-12-05 18:33:14 UTC (rev 238899)
@@ -4273,3 +4273,5 @@
 # This only applies to file:// loading of ES6 Modules via the import syntax. When
 # Windows recognizes .mjs files as _javascript_, this will just work.
 js/dom/modules/import-mjs-module.html [ Skip ]
+
+webkit.org/b/181957 http/tests/misc/resource-timing-resolution.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238898] trunk/Source/WebCore

[simon . fraser]

Title: [238898] trunk/Source/WebCore








Revision 238898
Author simon.fra...@apple.com
Date 2018-12-05 10:20:56 -0800 (Wed, 05 Dec 2018)


Log Message
Minor refactoring of the scrolling code
https://bugs.webkit.org/show_bug.cgi?id=192398

Patch by Frederic Wang  on 2018-12-05
Reviewed by Simon Fraser.

Based on an earlier patch by Simon Fraser.

This patch performs some minor refactoring of the scrolling code:
- Rename ScrollingCoordinator::uniqueScrollLayerID() to uniqueScrollingNodeID() since it
  is really a node id.
- Inline ScrollingStateTree::setRootStateNode() so we only need to forward declare
  ScrollingStateFrameScrollingNode in headers.
- Pass argument to ScrollingStateTree::addNode() as a reference rather than a pointer.
- Initialize ScrollingStateTree::m_changedProperties and ScrollingStateTree::m_parent in
  the header file.
- Remove obsolete comment about ScrollingCoordinatorMac.

No new tests, behavior unchanged.

* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::uniqueScrollingNodeID):
(WebCore::ScrollingCoordinator::uniqueScrollLayerID): Deleted.
* page/scrolling/ScrollingCoordinator.h:
* page/scrolling/ScrollingStateNode.cpp:
(WebCore::ScrollingStateNode::ScrollingStateNode):
* page/scrolling/ScrollingStateNode.h:
* page/scrolling/ScrollingStateTree.cpp:
(WebCore::ScrollingStateTree::attachNode):
(WebCore::ScrollingStateTree::setRootStateNode):
(WebCore::ScrollingStateTree::addNode):
* page/scrolling/ScrollingStateTree.h:
(WebCore::ScrollingStateTree::setRootStateNode): Deleted.
* page/scrolling/ScrollingTree.cpp:
* page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::attachScrollingNode):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp
trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.h
trunk/Source/WebCore/page/scrolling/ScrollingStateNode.cpp
trunk/Source/WebCore/page/scrolling/ScrollingStateNode.h
trunk/Source/WebCore/page/scrolling/ScrollingStateTree.cpp
trunk/Source/WebCore/page/scrolling/ScrollingStateTree.h
trunk/Source/WebCore/page/scrolling/ScrollingTree.cpp
trunk/Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.h
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (238897 => 238898)

--- trunk/Source/WebCore/ChangeLog	2018-12-05 18:14:26 UTC (rev 238897)
+++ trunk/Source/WebCore/ChangeLog	2018-12-05 18:20:56 UTC (rev 238898)
@@ -1,3 +1,42 @@
+2018-12-05  Frederic Wang  
+
+Minor refactoring of the scrolling code
+https://bugs.webkit.org/show_bug.cgi?id=192398
+
+Reviewed by Simon Fraser.
+
+Based on an earlier patch by Simon Fraser.
+
+This patch performs some minor refactoring of the scrolling code:
+- Rename ScrollingCoordinator::uniqueScrollLayerID() to uniqueScrollingNodeID() since it
+  is really a node id.
+- Inline ScrollingStateTree::setRootStateNode() so we only need to forward declare
+  ScrollingStateFrameScrollingNode in headers.
+- Pass argument to ScrollingStateTree::addNode() as a reference rather than a pointer.
+- Initialize ScrollingStateTree::m_changedProperties and ScrollingStateTree::m_parent in
+  the header file.
+- Remove obsolete comment about ScrollingCoordinatorMac.
+
+No new tests, behavior unchanged.
+
+* page/scrolling/ScrollingCoordinator.cpp:
+(WebCore::ScrollingCoordinator::uniqueScrollingNodeID):
+(WebCore::ScrollingCoordinator::uniqueScrollLayerID): Deleted.
+* page/scrolling/ScrollingCoordinator.h:
+* page/scrolling/ScrollingStateNode.cpp:
+(WebCore::ScrollingStateNode::ScrollingStateNode):
+* page/scrolling/ScrollingStateNode.h:
+* page/scrolling/ScrollingStateTree.cpp:
+(WebCore::ScrollingStateTree::attachNode):
+(WebCore::ScrollingStateTree::setRootStateNode):
+(WebCore::ScrollingStateTree::addNode):
+* page/scrolling/ScrollingStateTree.h:
+(WebCore::ScrollingStateTree::setRootStateNode): Deleted.
+* page/scrolling/ScrollingTree.cpp:
+* page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.h:
+* rendering/RenderLayerCompositor.cpp:
+(WebCore::RenderLayerCompositor::attachScrollingNode):
+
 2018-12-05  Wenson Hsieh  
 
 Turn WritingDirection into an enum class


Modified: trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp (238897 => 238898)

--- trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp	2018-12-05 18:14:26 UTC (rev 238897)
+++ trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp	2018-12-05 18:20:56 UTC (rev 238898)
@@ -361,10 +361,10 @@
 return true;
 }
 
-ScrollingNodeID ScrollingCoordinator::uniqueScrollLayerID()
+ScrollingNodeID ScrollingCoordinator::uniqueScrollingNodeID()
 {
-static 

[webkit-changes] [238897] tags/Safari-607.1.16.1/Source

[alancoon]

Title: [238897] tags/Safari-607.1.16.1/Source








Revision 238897
Author alanc...@apple.com
Date 2018-12-05 10:14:26 -0800 (Wed, 05 Dec 2018)


Log Message
Versioning.

Modified Paths

tags/Safari-607.1.16.1/Source/_javascript_Core/Configurations/Version.xcconfig
tags/Safari-607.1.16.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
tags/Safari-607.1.16.1/Source/WebCore/Configurations/Version.xcconfig
tags/Safari-607.1.16.1/Source/WebCore/PAL/Configurations/Version.xcconfig
tags/Safari-607.1.16.1/Source/WebInspectorUI/Configurations/Version.xcconfig
tags/Safari-607.1.16.1/Source/WebKit/Configurations/Version.xcconfig
tags/Safari-607.1.16.1/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: tags/Safari-607.1.16.1/Source/_javascript_Core/Configurations/Version.xcconfig (238896 => 238897)

--- tags/Safari-607.1.16.1/Source/_javascript_Core/Configurations/Version.xcconfig	2018-12-05 18:12:32 UTC (rev 238896)
+++ tags/Safari-607.1.16.1/Source/_javascript_Core/Configurations/Version.xcconfig	2018-12-05 18:14:26 UTC (rev 238897)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 607;
 MINOR_VERSION = 1;
 TINY_VERSION = 16;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-607.1.16.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (238896 => 238897)

--- tags/Safari-607.1.16.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-12-05 18:12:32 UTC (rev 238896)
+++ tags/Safari-607.1.16.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-12-05 18:14:26 UTC (rev 238897)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 607;
 MINOR_VERSION = 1;
 TINY_VERSION = 16;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-607.1.16.1/Source/WebCore/Configurations/Version.xcconfig (238896 => 238897)

--- tags/Safari-607.1.16.1/Source/WebCore/Configurations/Version.xcconfig	2018-12-05 18:12:32 UTC (rev 238896)
+++ tags/Safari-607.1.16.1/Source/WebCore/Configurations/Version.xcconfig	2018-12-05 18:14:26 UTC (rev 238897)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 607;
 MINOR_VERSION = 1;
 TINY_VERSION = 16;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-607.1.16.1/Source/WebCore/PAL/Configurations/Version.xcconfig (238896 => 238897)

--- tags/Safari-607.1.16.1/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-12-05 18:12:32 UTC (rev 238896)
+++ tags/Safari-607.1.16.1/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-12-05 18:14:26 UTC (rev 238897)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 607;
 MINOR_VERSION = 1;
 TINY_VERSION = 16;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-607.1.16.1/Source/WebInspectorUI/Configurations/Version.xcconfig (238896 => 238897)

--- tags/Safari-607.1.16.1/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-12-05 18:12:32 UTC (rev 238896)
+++ tags/Safari-607.1.16.1/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-12-05 18:14:26 UTC (rev 238897)
@@ -1,9 +1,9 @@
 MAJOR_VERSION = 607;
 MINOR_VERSION = 1;
 TINY_VERSION = 16;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The system version prefix is based on the current system version.
 SYSTEM_VERSION_PREFIX[sdk=iphone*] = 8;


Modified: tags/Safari-607.1.16.1/Source/WebKit/Configurations/Version.xcconfig (238896 => 238897)

--- tags/Safari-607.1.16.1/Source/WebKit/Configurations/Version.xcconfig	2018-12-05 18:12:32 UTC (rev 238896)
+++ tags/Safari-607.1.16.1/Source/WebKit/Configurations/Version.xcconfig	2018-12-05 18:14:26 UTC (rev 238897)
@@ -24,9 

[webkit-changes] [238896] tags/Safari-607.1.16.1/Source/WebKit

[alancoon]

Title: [238896] tags/Safari-607.1.16.1/Source/WebKit








Revision 238896
Author alanc...@apple.com
Date 2018-12-05 10:12:32 -0800 (Wed, 05 Dec 2018)


Log Message
Cherry-pick r238818. rdar://problem/45928708

Swipe snapshot stays up too long swiping around on apple.com (waiting for first paint)
https://bugs.webkit.org/show_bug.cgi?id=192319


Reviewed by Simon Fraser.

* UIProcess/Cocoa/ViewGestureController.cpp:
(WebKit::ViewGestureController::didStartProvisionalLoadForMainFrame):
* UIProcess/Cocoa/ViewGestureController.h:
* UIProcess/ios/ViewGestureControllerIOS.mm:
(WebKit::ViewGestureController::endSwipeGesture):
In r236966, I reverted slightly too much of r232416.
We still need to defer requesting a presentation update callback until
after the provisional load starts. Otherwise, we could get the callback
while we're in the 'paused' state, and drop it on the floor. That would
then mean that we time out instead of promptly removing the snapshot.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

tags/Safari-607.1.16.1/Source/WebKit/ChangeLog
tags/Safari-607.1.16.1/Source/WebKit/UIProcess/Cocoa/ViewGestureController.cpp
tags/Safari-607.1.16.1/Source/WebKit/UIProcess/Cocoa/ViewGestureController.h
tags/Safari-607.1.16.1/Source/WebKit/UIProcess/ios/ViewGestureControllerIOS.mm




Diff

Modified: tags/Safari-607.1.16.1/Source/WebKit/ChangeLog (238895 => 238896)

--- tags/Safari-607.1.16.1/Source/WebKit/ChangeLog	2018-12-05 18:03:54 UTC (rev 238895)
+++ tags/Safari-607.1.16.1/Source/WebKit/ChangeLog	2018-12-05 18:12:32 UTC (rev 238896)
@@ -1,3 +1,46 @@
+2018-12-05  Alan Coon  
+
+Cherry-pick r238818. rdar://problem/45928708
+
+Swipe snapshot stays up too long swiping around on apple.com (waiting for first paint)
+https://bugs.webkit.org/show_bug.cgi?id=192319
+
+
+Reviewed by Simon Fraser.
+
+* UIProcess/Cocoa/ViewGestureController.cpp:
+(WebKit::ViewGestureController::didStartProvisionalLoadForMainFrame):
+* UIProcess/Cocoa/ViewGestureController.h:
+* UIProcess/ios/ViewGestureControllerIOS.mm:
+(WebKit::ViewGestureController::endSwipeGesture):
+In r236966, I reverted slightly too much of r232416.
+We still need to defer requesting a presentation update callback until
+after the provisional load starts. Otherwise, we could get the callback
+while we're in the 'paused' state, and drop it on the floor. That would
+then mean that we time out instead of promptly removing the snapshot.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238818 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2018-12-03  Tim Horton  
+
+Swipe snapshot stays up too long swiping around on apple.com (waiting for first paint)
+https://bugs.webkit.org/show_bug.cgi?id=192319
+
+
+Reviewed by Simon Fraser.
+
+* UIProcess/Cocoa/ViewGestureController.cpp:
+(WebKit::ViewGestureController::didStartProvisionalLoadForMainFrame):
+* UIProcess/Cocoa/ViewGestureController.h:
+* UIProcess/ios/ViewGestureControllerIOS.mm:
+(WebKit::ViewGestureController::endSwipeGesture):
+In r236966, I reverted slightly too much of r232416.
+We still need to defer requesting a presentation update callback until
+after the provisional load starts. Otherwise, we could get the callback
+while we're in the 'paused' state, and drop it on the floor. That would
+then mean that we time out instead of promptly removing the snapshot.
+
 2018-12-04  Alan Coon  
 
 Revert r238869. rdar://problem/45928708


Modified: tags/Safari-607.1.16.1/Source/WebKit/UIProcess/Cocoa/ViewGestureController.cpp (238895 => 238896)

--- tags/Safari-607.1.16.1/Source/WebKit/UIProcess/Cocoa/ViewGestureController.cpp	2018-12-05 18:03:54 UTC (rev 238895)
+++ tags/Safari-607.1.16.1/Source/WebKit/UIProcess/Cocoa/ViewGestureController.cpp	2018-12-05 18:12:32 UTC (rev 238896)
@@ -148,6 +148,9 @@
 void ViewGestureController::didStartProvisionalLoadForMainFrame()
 {
 m_snapshotRemovalTracker.resume();
+
+if (auto provisionalLoadCallback = WTFMove(m_provisionalLoadCallback))
+provisionalLoadCallback();
 }
 
 void ViewGestureController::didFirstVisuallyNonEmptyLayoutForMainFrame()


Modified: tags/Safari-607.1.16.1/Source/WebKit/UIProcess/Cocoa/ViewGestureController.h (238895 => 238896)

--- tags/Safari-607.1.16.1/Source/WebKit/UIProcess/Cocoa/ViewGestureController.h	2018-12-05 18:03:54 UTC (rev 238895)
+++ tags/Safari-607.1.16.1/Source/WebKit/UIProcess/Cocoa/ViewGestureController.h	2018-12-05 18:12:32 UTC (rev 238896)
@@ -312,6 +312,7 @@
 bool m_isConnectedToProcess { false };
 
 SnapshotRemovalTracker m_snapshotRemovalTracker;
+WTF::Function m_provisionalLoadCallback;
 };
 
 } // 

[webkit-changes] [238895] tags/Safari-607.1.16.1/

[alancoon]

Title: [238895] tags/Safari-607.1.16.1/








Revision 238895
Author alanc...@apple.com
Date 2018-12-05 10:03:54 -0800 (Wed, 05 Dec 2018)


Log Message
New tag.

Added Paths

tags/Safari-607.1.16.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238894] trunk/Source

[wenson_hsieh]

Title: [238894] trunk/Source








Revision 238894
Author wenson_hs...@apple.com
Date 2018-12-05 09:51:03 -0800 (Wed, 05 Dec 2018)


Log Message
Turn WritingDirection into an enum class
https://bugs.webkit.org/show_bug.cgi?id=192401
Work towards 

Reviewed by Dan Bernstein.

Change WritingDirection from an enum to an enum class. No change in behavior.

Source/WebCore:

* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi):
(WebCore::ApplyStyleCommand::applyInlineStyle):
* editing/EditingStyle.cpp:
(WebCore::EditingStyle::textDirection const):
(WebCore::EditingStyle::textDirectionForSelection):
* editing/Editor.cpp:
(WebCore::Editor::setBaseWritingDirection):
(WebCore::Editor::baseWritingDirectionForSelectionStart const):
* editing/EditorCommand.cpp:
(WebCore::stateTextWritingDirectionLeftToRight):
(WebCore::stateTextWritingDirectionNatural):
(WebCore::stateTextWritingDirectionRightToLeft):
* editing/WritingDirection.h:

Additionally wrap this enum in `namespace WebCore`, and update the copyright year.

* editing/ios/EditorIOS.mm:
(WebCore::Editor::setTextAlignmentForChangedBaseWritingDirection):
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected):
* testing/Internals.cpp:
(WebCore::Internals::setBaseWritingDirection):

Source/WebKit:

* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::setTextDirection):

Source/WebKitLegacy/ios:

* WebCoreSupport/WebFrameIOS.mm:
(-[WebFrame selectionBaseWritingDirection]):
(-[WebFrame setBaseWritingDirection:]):

Source/WebKitLegacy/mac:

* WebView/WebHTMLView.mm:
(-[WebHTMLView toggleBaseWritingDirection:]):
(-[WebHTMLView changeBaseWritingDirection:]):
(-[WebHTMLView _changeBaseWritingDirectionTo:]):

Source/WebKitLegacy/win:

* WebFrame.cpp:
(WebFrame::setTextDirection):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/ApplyStyleCommand.cpp
trunk/Source/WebCore/editing/EditingStyle.cpp
trunk/Source/WebCore/editing/Editor.cpp
trunk/Source/WebCore/editing/EditorCommand.cpp
trunk/Source/WebCore/editing/WritingDirection.h
trunk/Source/WebCore/editing/ios/EditorIOS.mm
trunk/Source/WebCore/page/ContextMenuController.cpp
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/WebFrame.cpp
trunk/Source/WebKitLegacy/ios/ChangeLog
trunk/Source/WebKitLegacy/ios/WebCoreSupport/WebFrameIOS.mm
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm
trunk/Source/WebKitLegacy/win/ChangeLog
trunk/Source/WebKitLegacy/win/WebFrame.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (238893 => 238894)

--- trunk/Source/WebCore/ChangeLog	2018-12-05 16:05:58 UTC (rev 238893)
+++ trunk/Source/WebCore/ChangeLog	2018-12-05 17:51:03 UTC (rev 238894)
@@ -1,3 +1,37 @@
+2018-12-05  Wenson Hsieh  
+
+Turn WritingDirection into an enum class
+https://bugs.webkit.org/show_bug.cgi?id=192401
+Work towards 
+
+Reviewed by Dan Bernstein.
+
+Change WritingDirection from an enum to an enum class. No change in behavior.
+
+* editing/ApplyStyleCommand.cpp:
+(WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi):
+(WebCore::ApplyStyleCommand::applyInlineStyle):
+* editing/EditingStyle.cpp:
+(WebCore::EditingStyle::textDirection const):
+(WebCore::EditingStyle::textDirectionForSelection):
+* editing/Editor.cpp:
+(WebCore::Editor::setBaseWritingDirection):
+(WebCore::Editor::baseWritingDirectionForSelectionStart const):
+* editing/EditorCommand.cpp:
+(WebCore::stateTextWritingDirectionLeftToRight):
+(WebCore::stateTextWritingDirectionNatural):
+(WebCore::stateTextWritingDirectionRightToLeft):
+* editing/WritingDirection.h:
+
+Additionally wrap this enum in `namespace WebCore`, and update the copyright year.
+
+* editing/ios/EditorIOS.mm:
+(WebCore::Editor::setTextAlignmentForChangedBaseWritingDirection):
+* page/ContextMenuController.cpp:
+(WebCore::ContextMenuController::contextMenuItemSelected):
+* testing/Internals.cpp:
+(WebCore::Internals::setBaseWritingDirection):
+
 2018-12-05  Alicia Boya García  
 
 [MSE][GStreamer] Remove the AppendPipeline state machine


Modified: trunk/Source/WebCore/editing/ApplyStyleCommand.cpp (238893 => 238894)

--- trunk/Source/WebCore/editing/ApplyStyleCommand.cpp	2018-12-05 16:05:58 UTC (rev 238893)
+++ trunk/Source/WebCore/editing/ApplyStyleCommand.cpp	2018-12-05 17:51:03 UTC (rev 238894)
@@ -484,7 +484,7 @@
 HTMLElement* unsplitAncestor = nullptr;
 
 WritingDirection highestAncestorDirection;
-if (allowedDirection != NaturalWritingDirection
+if (allowedDirection != WritingDirection::Natural
 && highestAncestorUnicodeBidi != CSSValueBidiOverride
 && is(*highestAncestorWithUnicodeBidi)
 && 

[webkit-changes] [238893] trunk/LayoutTests/imported/w3c

[commit-queue]

Title: [238893] trunk/LayoutTests/imported/w3c








Revision 238893
Author commit-qu...@webkit.org
Date 2018-12-05 08:05:58 -0800 (Wed, 05 Dec 2018)


Log Message
Import css overscroll behavior WPT test
https://bugs.webkit.org/show_bug.cgi?id=192397

Patch by Frederic Wang  on 2018-12-05
Reviewed by Manuel Rego Casasnovas.

* resources/import-expectations.json:
* web-platform-tests/css/css-overscroll-behavior/META.yml: Added.
* web-platform-tests/css/css-overscroll-behavior/inheritance-expected.txt: Added.
* web-platform-tests/css/css-overscroll-behavior/inheritance.html: Added.
* web-platform-tests/css/css-overscroll-behavior/w3c-import.log: Added.

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/resources/import-expectations.json


Added Paths

trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-overscroll-behavior/
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-overscroll-behavior/META.yml
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-overscroll-behavior/inheritance-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-overscroll-behavior/inheritance.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-overscroll-behavior/w3c-import.log




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (238892 => 238893)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2018-12-05 14:56:33 UTC (rev 238892)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2018-12-05 16:05:58 UTC (rev 238893)
@@ -1,3 +1,16 @@
+2018-12-05  Frederic Wang  
+
+Import css overscroll behavior WPT test
+https://bugs.webkit.org/show_bug.cgi?id=192397
+
+Reviewed by Manuel Rego Casasnovas.
+
+* resources/import-expectations.json:
+* web-platform-tests/css/css-overscroll-behavior/META.yml: Added.
+* web-platform-tests/css/css-overscroll-behavior/inheritance-expected.txt: Added.
+* web-platform-tests/css/css-overscroll-behavior/inheritance.html: Added.
+* web-platform-tests/css/css-overscroll-behavior/w3c-import.log: Added.
+
 2018-12-05  Alicia Boya García  
 
 [MSE][GStreamer] Remove the AppendPipeline state machine


Modified: trunk/LayoutTests/imported/w3c/resources/import-expectations.json (238892 => 238893)

--- trunk/LayoutTests/imported/w3c/resources/import-expectations.json	2018-12-05 14:56:33 UTC (rev 238892)
+++ trunk/LayoutTests/imported/w3c/resources/import-expectations.json	2018-12-05 16:05:58 UTC (rev 238893)
@@ -71,6 +71,7 @@
 "web-platform-tests/css/css-grid/layout-algorithm/": "import", 
 "web-platform-tests/css/css-logical": "import", 
 "web-platform-tests/css/css-multicol": "import", 
+"web-platform-tests/css/css-overscroll-behavior": "import", 
 "web-platform-tests/css/css-properties-values-api": "import", 
 "web-platform-tests/css/css-pseudo": "import", 
 "web-platform-tests/css/css-scoping": "import", 


Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-overscroll-behavior/META.yml (0 => 238893)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-overscroll-behavior/META.yml	(rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-overscroll-behavior/META.yml	2018-12-05 16:05:58 UTC (rev 238893)
@@ -0,0 +1,3 @@
+spec: https://drafts.csswg.org/css-overscroll-behavior/
+suggested_reviewers:
+  - majido


Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-overscroll-behavior/inheritance-expected.txt (0 => 238893)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-overscroll-behavior/inheritance-expected.txt	(rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-overscroll-behavior/inheritance-expected.txt	2018-12-05 16:05:58 UTC (rev 238893)
@@ -0,0 +1,6 @@
+
+PASS Property overscroll-behavior-x has initial value auto 
+PASS Property overscroll-behavior-x does not inherit 
+PASS Property overscroll-behavior-y has initial value auto 
+PASS Property overscroll-behavior-y does not inherit 
+


Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-overscroll-behavior/inheritance.html (0 => 238893)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-overscroll-behavior/inheritance.html	(rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-overscroll-behavior/inheritance.html	2018-12-05 16:05:58 UTC (rev 238893)
@@ -0,0 +1,22 @@
+
+
+
+
+Inheritance of CSS Overscroll Behavior properties
+
+
+
+
+

+  

+
+