[webkit-changes] [239588] trunk/Source/WebInspectorUI

2019-01-02 Thread nvasilyev 
Title: [239588] trunk/Source/WebInspectorUI








Revision 239588
Author nvasil...@apple.com
Date 2019-01-02 23:18:32 -0800 (Wed, 02 Jan 2019)


Log Message
Web Inspector: Styles: selection lost when inspector is blurred
https://bugs.webkit.org/show_bug.cgi?id=192124


Reviewed by Devin Rousso.

* UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:
(body:matches(.window-docked-inactive, .window-inactive) .spreadsheet-style-declaration-editor .property.selected):
Selection should be gray when Web Inspector window isn't focused.

* UserInterface/Views/SpreadsheetStyleProperty.js:

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css
trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (239587 => 239588)

--- trunk/Source/WebInspectorUI/ChangeLog	2019-01-03 06:42:52 UTC (rev 239587)
+++ trunk/Source/WebInspectorUI/ChangeLog	2019-01-03 07:18:32 UTC (rev 239588)
@@ -1,5 +1,19 @@
 2019-01-02  Nikita Vasilyev  
 
+Web Inspector: Styles: selection lost when inspector is blurred
+https://bugs.webkit.org/show_bug.cgi?id=192124
+
+
+Reviewed by Devin Rousso.
+
+* UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:
+(body:matches(.window-docked-inactive, .window-inactive) .spreadsheet-style-declaration-editor .property.selected):
+Selection should be gray when Web Inspector window isn't focused.
+
+* UserInterface/Views/SpreadsheetStyleProperty.js:
+
+2019-01-02  Nikita Vasilyev  
+
 Web Inspector: Styles: it shouldn't be possible to delete read-only properties
 https://bugs.webkit.org/show_bug.cgi?id=193099
 


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css (239587 => 239588)

--- trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css	2019-01-03 06:42:52 UTC (rev 239587)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css	2019-01-03 07:18:32 UTC (rev 239588)
@@ -133,6 +133,10 @@
 background-color: var(--background-color-selected);
 }
 
+body:matches(.window-docked-inactive, .window-inactive) .spreadsheet-style-declaration-editor .property.selected {
+background-color: var(--selected-background-color-unfocused);
+}
+
 .spreadsheet-style-declaration-editor .property.selected:focus {
 border-left-color: var(--border-color-selected);
 }


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js (239587 => 239588)

--- trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js	2019-01-03 06:42:52 UTC (rev 239587)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js	2019-01-03 07:18:32 UTC (rev 239588)
@@ -54,6 +54,10 @@
 this._element.tabIndex = -1;
 
 this._element.addEventListener("blur", (event) => {
+// Keep selection after tabbing out of Web Inspector window and back.
+if (document.activeElement === this._element)
+return;
+
 if (this._delegate.spreadsheetStylePropertyBlur)
 this._delegate.spreadsheetStylePropertyBlur(event, this);
 });






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239587] trunk/Source/WebCore

2019-01-02 Thread ddkilzer 
Title: [239587] trunk/Source/WebCore








Revision 239587
Author ddkil...@apple.com
Date 2019-01-02 22:42:52 -0800 (Wed, 02 Jan 2019)


Log Message
Leak of CMSampleBuffer (752 bytes) in com.apple.WebKit.WebContent running WebKit layout tests



Reviewed by Simon Fraser.

* platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:
(WebCore::copySampleBufferWithCurrentTimeStamp):
- Change to return RetainPtr.
- Check return value of CMSampleBufferCreateCopyWithNewTiming().
(WebCore::MediaRecorderPrivateWriter::appendVideoSampleBuffer):
- Check return value of copySampleBufferWithCurrentTimeStamp().
- Fix leak by using RetainPtr returned from
  copySampleBufferWithCurrentTimeStamp() instead of leaking
  `bufferWithCurrentTime` by using retainPtr().
(WebCore::createAudioFormatDescription):
- Extract method from appendAudioSampleBuffer() to return
  RetainPtr after calling
  CMAudioFormatDescriptionCreate().
- Check return value of CMAudioFormatDescriptionCreate().
(WebCore::createAudioSampleBufferWithPacketDescriptions):
- Extract method from appendAudioSampleBuffer() to return
  RetainPtr after calling
  CMAudioSampleBufferCreateWithPacketDescriptions().
(WebCore::MediaRecorderPrivateWriter::appendAudioSampleBuffer):
- Check return values of createAudioFormatDescription() and
  createAudioSampleBufferWithPacketDescriptions().
- Fix leaks by extracting code into helper methods that return
  RetainPtr<> objects instead of leaking CMFormatDescriptionRef
  directly or leaking `sampleBuffer` by using retainPtr().

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (239586 => 239587)

--- trunk/Source/WebCore/ChangeLog	2019-01-03 04:33:52 UTC (rev 239586)
+++ trunk/Source/WebCore/ChangeLog	2019-01-03 06:42:52 UTC (rev 239587)
@@ -1,3 +1,36 @@
+2019-01-02  David Kilzer  
+
+Leak of CMSampleBuffer (752 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
+
+
+
+Reviewed by Simon Fraser.
+
+* platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:
+(WebCore::copySampleBufferWithCurrentTimeStamp):
+- Change to return RetainPtr.
+- Check return value of CMSampleBufferCreateCopyWithNewTiming().
+(WebCore::MediaRecorderPrivateWriter::appendVideoSampleBuffer):
+- Check return value of copySampleBufferWithCurrentTimeStamp().
+- Fix leak by using RetainPtr returned from
+  copySampleBufferWithCurrentTimeStamp() instead of leaking
+  `bufferWithCurrentTime` by using retainPtr().
+(WebCore::createAudioFormatDescription):
+- Extract method from appendAudioSampleBuffer() to return
+  RetainPtr after calling
+  CMAudioFormatDescriptionCreate().
+- Check return value of CMAudioFormatDescriptionCreate().
+(WebCore::createAudioSampleBufferWithPacketDescriptions):
+- Extract method from appendAudioSampleBuffer() to return
+  RetainPtr after calling
+  CMAudioSampleBufferCreateWithPacketDescriptions().
+(WebCore::MediaRecorderPrivateWriter::appendAudioSampleBuffer):
+- Check return values of createAudioFormatDescription() and
+  createAudioSampleBufferWithPacketDescriptions().
+- Fix leaks by extracting code into helper methods that return
+  RetainPtr<> objects instead of leaking CMFormatDescriptionRef
+  directly or leaking `sampleBuffer` by using retainPtr().
+
 2019-01-02  Wenson Hsieh  
 
 Add support for using the current text selection as the find string on iOS


Modified: trunk/Source/WebCore/platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm (239586 => 239587)

--- trunk/Source/WebCore/platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm	2019-01-03 04:33:52 UTC (rev 239586)
+++ trunk/Source/WebCore/platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm	2019-01-03 06:42:52 UTC (rev 239587)
@@ -196,7 +196,7 @@
 return true;
 }
 
-static inline CMSampleBufferRef copySampleBufferWithCurrentTimeStamp(CMSampleBufferRef originalBuffer)
+static inline RetainPtr copySampleBufferWithCurrentTimeStamp(CMSampleBufferRef originalBuffer)
 {
 CMTime startTime = CMClockGetTime(CMClockGetHostTimeClock());
 CMItemCount count = 0;
@@ -210,9 +210,11 @@
 timeInfo[i].presentationTimeStamp = startTime;
 }
 
-CMSampleBufferRef newBuffer;
-CMSampleBufferCreateCopyWithNewTiming(kCFAllocatorDefault, originalBuffer, count, timeInfo.data(), );
-return newBuffer;
+CMSampleBufferRef newBuffer = nullptr;
+auto error = CMSampleBufferCreateCopyWithNewTiming(kCFAllocatorDefault, originalBuffer, count, timeInfo.data(), );
+if (error)
+return nullptr;
+return adoptCF(newBuffer);
 }
 
 void MediaRecorderPrivateWriter::appendVideoSampleBuffer(CMSampleBufferRef sampleBuffer)
@@

[webkit-changes] [239586] trunk

2019-01-02 Thread achristensen 
Title: [239586] trunk








Revision 239586
Author achristen...@apple.com
Date 2019-01-02 20:33:52 -0800 (Wed, 02 Jan 2019)


Log Message
Homograph with LATIN SMALL LETTER R WITH FISHHOOK
https://bugs.webkit.org/show_bug.cgi?id=192944

Reviewed by Tim Horton.

Source/WTF:

* wtf/cocoa/NSURLExtras.mm:
(WTF::isLookalikeCharacter):

Tools:

* TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
(TestWebKitAPI::TEST):

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/cocoa/NSURLExtras.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm




Diff

Modified: trunk/Source/WTF/ChangeLog (239585 => 239586)

--- trunk/Source/WTF/ChangeLog	2019-01-03 04:05:04 UTC (rev 239585)
+++ trunk/Source/WTF/ChangeLog	2019-01-03 04:33:52 UTC (rev 239586)
@@ -1,3 +1,13 @@
+2019-01-02  Alex Christensen  
+
+Homograph with LATIN SMALL LETTER R WITH FISHHOOK
+https://bugs.webkit.org/show_bug.cgi?id=192944
+
+Reviewed by Tim Horton.
+
+* wtf/cocoa/NSURLExtras.mm:
+(WTF::isLookalikeCharacter):
+
 2019-01-02  Commit Queue  
 
 Unreviewed, rolling out r239524.


Modified: trunk/Source/WTF/wtf/cocoa/NSURLExtras.mm (239585 => 239586)

--- trunk/Source/WTF/wtf/cocoa/NSURLExtras.mm	2019-01-03 04:05:04 UTC (rev 239585)
+++ trunk/Source/WTF/wtf/cocoa/NSURLExtras.mm	2019-01-03 04:33:52 UTC (rev 239586)
@@ -92,8 +92,6 @@
 }
 }
 
-
-
 static BOOL isLookalikeCharacter(Optional previousCodePoint, UChar32 charCode)
 {
 // This function treats the following as unsafe, lookalike characters:
@@ -115,9 +113,11 @@
 case 0x00BD: /* VULGAR FRACTION ONE HALF */
 case 0x00BE: /* VULGAR FRACTION THREE QUARTERS */
 case 0x00ED: /* LATIN SMALL LETTER I WITH ACUTE */
+/* 0x0131 LATIN SMALL LETTER DOTLESS I is intentionally not considered a lookalike character because it is visually distinguishable from i and it has legitimate use in the Turkish language. */
 case 0x01C3: /* LATIN LETTER RETROFLEX CLICK */
 case 0x0251: /* LATIN SMALL LETTER ALPHA */
 case 0x0261: /* LATIN SMALL LETTER SCRIPT G */
+case 0x027E: /* LATIN SMALL LETTER R WITH FISHHOOK */
 case 0x02D0: /* MODIFIER LETTER TRIANGULAR COLON */
 case 0x0335: /* COMBINING SHORT STROKE OVERLAY */
 case 0x0337: /* COMBINING SHORT SOLIDUS OVERLAY */


Modified: trunk/Tools/ChangeLog (239585 => 239586)

--- trunk/Tools/ChangeLog	2019-01-03 04:05:04 UTC (rev 239585)
+++ trunk/Tools/ChangeLog	2019-01-03 04:33:52 UTC (rev 239586)
@@ -1,3 +1,13 @@
+2019-01-02  Alex Christensen  
+
+Homograph with LATIN SMALL LETTER R WITH FISHHOOK
+https://bugs.webkit.org/show_bug.cgi?id=192944
+
+Reviewed by Tim Horton.
+
+* TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
+(TestWebKitAPI::TEST):
+
 2019-01-02  Wenson Hsieh  
 
 Add support for using the current text selection as the find string on iOS


Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm (239585 => 239586)

--- trunk/Tools/TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm	2019-01-03 04:05:04 UTC (rev 239585)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm	2019-01-03 04:33:52 UTC (rev 239586)
@@ -101,6 +101,7 @@
 "xn--qdb1b", // U+05D5 U+05C2
 "xn--sdb7a", // U+05D5 U+05C4
 "xn--2-zic", // U+0032 U+05E1
+"xn--uoa", // U+027E
 };
 for (const String& host : punycodedSpoofHosts) {
 auto url = "" host, "/").utf8();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239585] trunk/Source/WebInspectorUI

2019-01-02 Thread nvasilyev 
Title: [239585] trunk/Source/WebInspectorUI








Revision 239585
Author nvasil...@apple.com
Date 2019-01-02 20:05:04 -0800 (Wed, 02 Jan 2019)


Log Message
Web Inspector: Styles: it shouldn't be possible to delete read-only properties
https://bugs.webkit.org/show_bug.cgi?id=193099


Reviewed by Devin Rousso.

* UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:
(WI.SpreadsheetCSSStyleDeclarationEditor):
Drive-by: Forward Delete should work the same way as Delete (Backspace).

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (239584 => 239585)

--- trunk/Source/WebInspectorUI/ChangeLog	2019-01-03 04:00:47 UTC (rev 239584)
+++ trunk/Source/WebInspectorUI/ChangeLog	2019-01-03 04:05:04 UTC (rev 239585)
@@ -1,3 +1,15 @@
+2019-01-02  Nikita Vasilyev  
+
+Web Inspector: Styles: it shouldn't be possible to delete read-only properties
+https://bugs.webkit.org/show_bug.cgi?id=193099
+
+
+Reviewed by Devin Rousso.
+
+* UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:
+(WI.SpreadsheetCSSStyleDeclarationEditor):
+Drive-by: Forward Delete should work the same way as Delete (Backspace).
+
 2019-01-02  Devin Rousso  
 
 Web Inspector: Implement `queryObjects` Command Line API


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js (239584 => 239585)

--- trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js	2019-01-03 04:00:47 UTC (rev 239584)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js	2019-01-03 04:05:04 UTC (rev 239585)
@@ -533,7 +533,10 @@
 event.stop();
 property.startEditingName();
 }
-} else if (event.key === "Backspace") {
+} else if (event.key === "Backspace" || event.key === "Delete") {
+if (!this.style.editable)
+return;
+
 let [startIndex, endIndex] = this.selectionRange;
 
 let propertyIndexToSelect = NaN;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239584] trunk

2019-01-02 Thread wenson_hsieh 
Title: [239584] trunk








Revision 239584
Author wenson_hs...@apple.com
Date 2019-01-02 20:00:47 -0800 (Wed, 02 Jan 2019)


Log Message
Add support for using the current text selection as the find string on iOS
https://bugs.webkit.org/show_bug.cgi?id=193034


Reviewed by Tim Horton.

Source/WebCore:

Add support for "TakeFindStringFromSelection" on iOS. Unlike macOS, iOS does not have a notion of a "find
pasteboard" like macOS; instead, we handle this editing command by sending the selection string to the UI
process, where it is exposed via WebKit SPI so that clients that present find-in-page UI (i.e. MobileSafari) are
able to trigger find-in-page with this string.

Test: WebKit.UseSelectionAsFindString

* editing/Editor.cpp:
(WebCore::Editor::canCopyExcludingStandaloneImages const):

Make this helper function cross-platform.

* editing/Editor.h:
* editing/EditorCommand.cpp:
(WebCore::createCommandMap):
* editing/cocoa/EditorCocoa.mm:
(WebCore::Editor::takeFindStringFromSelection):

Move this from EditorMac to EditorCocoa, and implement it on iOS by calling into the editor client to update the
find string (see WebKit/ChangeLog for more details).

* editing/mac/EditorMac.mm:
(WebCore::Editor::canCopyExcludingStandaloneImages): Deleted.
(WebCore::Editor::takeFindStringFromSelection): Deleted.
* loader/EmptyClients.cpp:
* page/EditorClient.h:

Add a new editor client method to send the string for find-in-page to the UI process.

Source/WebKit:

* SourcesCocoa.txt:
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _takeFindStringFromSelection:]):

Provides a way to set the find string on iOS and macOS (an aside: takeFindStringFromSelection: already exists on
macOS, but there is no equivalent protocol method on iOS, so this new SPI acts as a cross-platform way for
WebKit clients to take the find string from the selection across all Cocoa platforms).

(+[WKWebView _stringForFind]):
(+[WKWebView _setStringForFind:]):

Call into find-in-page helper functions.

(-[WKWebView _findString:options:maxCount:]):

On iOS, additionally update the find-in-page string when exercising the _findString:options:maxCount: SPI. This
mirrors macOS behavior of updating the find pasteboard every time the find string changes; however, on macOS,
this is implemented by the platform (in AppKit), whereas there's no platform find pasteboard on iOS, let alone
logic to update it in UIKit. As such, we directly drive updates to the find string within WebKit.

* UIProcess/API/Cocoa/WKWebViewPrivate.h:

Add some new cross-platform find-in-page SPI. See above for more details.

* UIProcess/Cocoa/GlobalFindInPageState.h: Added.
* UIProcess/Cocoa/GlobalFindInPageState.mm: Added.
(WebKit::findPasteboard):
(WebKit::globalStringForFind):

Fetch the string to use when finding text in the page. On macOS, this accesses the AppKit find pasteboard; on
iOS, this instead returns the current global find string.

(WebKit::updateStringForFind):

Sets the global find string. Uses the find pasteboard on macOS, and sets the global find string on iOS.

(WebKit::stringForFind):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:

Add plumbing to allow WebEditorClient to deliver the update the global find string in the UI process.

* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::updateStringForFind):
* WebKit.xcodeproj/project.pbxproj:
* WebProcess/WebCoreSupport/WebEditorClient.h:
* WebProcess/WebCoreSupport/ios/WebEditorClientIOS.mm:
(WebKit::WebEditorClient::updateStringForFind):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::updateStringForFind):

Source/WebKitLegacy/mac:

Add a method stub for WebKitLegacy.

* WebCoreSupport/WebEditorClient.h:

Tools:

Add a new API test to verify that the new WebKit SPI (_stringForFind, _takeFindStringFromSelection:, and
_setStringForFind) works as expected.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKitCocoa/UseSelectionAsFindString.mm: Added.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/Editor.cpp
trunk/Source/WebCore/editing/Editor.h
trunk/Source/WebCore/editing/EditorCommand.cpp
trunk/Source/WebCore/editing/cocoa/EditorCocoa.mm
trunk/Source/WebCore/editing/mac/EditorMac.mm
trunk/Source/WebCore/loader/EmptyClients.cpp
trunk/Source/WebCore/page/EditorClient.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/SourcesCocoa.txt
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Source/WebKit/UIProcess/WebPageProxy.messages.in
trunk/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
trunk/Source/WebKit/WebProcess/WebCoreSupport/WebEditorClient.h
trunk/Source/WebKit/WebProcess/WebCoreSupport/ios/WebEditorClientIOS.mm
trunk/Source/WebKit/WebProcess/WebPage/WebPage.h
trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm

[webkit-changes] [239582] trunk/Tools

2019-01-02 Thread aakash_jain 
Title: [239582] trunk/Tools








Revision 239582
Author aakash_j...@apple.com
Date 2019-01-02 16:48:44 -0800 (Wed, 02 Jan 2019)


Log Message
[ews-build] Use git on OpenSource EWS bots
https://bugs.webkit.org/show_bug.cgi?id=193092

Reviewed by Lucas Forschler.

* BuildSlaveSupport/ews-build/steps.py:
(CheckOutSource): Use git instead of svn.
(CheckOutSource.__init__): Use timeout of 2 hours since the initial checkout might take a long time.

Modified Paths

trunk/Tools/BuildSlaveSupport/ews-build/steps.py
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (239581 => 239582)

--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py	2019-01-03 00:09:37 UTC (rev 239581)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py	2019-01-03 00:48:44 UTC (rev 239582)
@@ -23,7 +23,7 @@
 from buildbot.process import buildstep, logobserver, properties
 from buildbot.process.results import Results, SUCCESS, FAILURE, WARNINGS, SKIPPED, EXCEPTION, RETRY
 from buildbot.steps import master, shell, transfer
-from buildbot.steps.source import svn
+from buildbot.steps.source import git
 from twisted.internet import defer
 
 import re
@@ -90,14 +90,15 @@
 return '{}show_bug.cgi?id={}'.format(BUG_SERVER_URL, bug_id)
 
 
-class CheckOutSource(svn.SVN):
+class CheckOutSource(git.Git):
 CHECKOUT_DELAY_AND_MAX_RETRIES_PAIR = (0, 2)
 
 def __init__(self, **kwargs):
-self.repourl = 'https://svn.webkit.org/repository/webkit/trunk'
+self.repourl = 'https://git.webkit.org/git/WebKit.git'
 super(CheckOutSource, self).__init__(repourl=self.repourl,
 retry=self.CHECKOUT_DELAY_AND_MAX_RETRIES_PAIR,
-preferLastChangedRev=True,
+timeout=2 * 60 * 60,
+progress=True,
 **kwargs)
 
 


Modified: trunk/Tools/ChangeLog (239581 => 239582)

--- trunk/Tools/ChangeLog	2019-01-03 00:09:37 UTC (rev 239581)
+++ trunk/Tools/ChangeLog	2019-01-03 00:48:44 UTC (rev 239582)
@@ -1,3 +1,14 @@
+2019-01-02  Aakash Jain  
+
+[ews-build] Use git on OpenSource EWS bots
+https://bugs.webkit.org/show_bug.cgi?id=193092
+
+Reviewed by Lucas Forschler.
+
+* BuildSlaveSupport/ews-build/steps.py:
+(CheckOutSource): Use git instead of svn.
+(CheckOutSource.__init__): Use timeout of 2 hours since the initial checkout might take a long time.
+
 2019-01-02  Daniel Bates  
 
 [lldb-webkit] Remove broken code to print WTF::OptionSet::m_storage






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239581] tags/Safari-607.1.18/

2019-01-02 Thread alancoon 
Title: [239581] tags/Safari-607.1.18/








Revision 239581
Author alanc...@apple.com
Date 2019-01-02 16:09:37 -0800 (Wed, 02 Jan 2019)


Log Message
Tag Safari-607.1.18.

Added Paths

tags/Safari-607.1.18/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239580] trunk/Source/WebKit

2019-01-02 Thread bfulgham 
Title: [239580] trunk/Source/WebKit








Revision 239580
Author bfulg...@apple.com
Date 2019-01-02 15:50:22 -0800 (Wed, 02 Jan 2019)


Log Message
Allow WebContent process access to some drawing-related IOKit properties
https://bugs.webkit.org/show_bug.cgi?id=193086


Reviewed by Eric Carlson.

Update the iOS WebContent process sandbox to allow access to some IOKit properties
that are needed for drawing and media playback operations.

* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
* WebProcess/com.apple.WebKit.WebContent.sb.in:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb
trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in




Diff

Modified: trunk/Source/WebKit/ChangeLog (239579 => 239580)

--- trunk/Source/WebKit/ChangeLog	2019-01-02 23:41:56 UTC (rev 239579)
+++ trunk/Source/WebKit/ChangeLog	2019-01-02 23:50:22 UTC (rev 239580)
@@ -1,5 +1,19 @@
 2019-01-02  Brent Fulgham  
 
+Allow WebContent process access to some drawing-related IOKit properties
+https://bugs.webkit.org/show_bug.cgi?id=193086
+
+
+Reviewed by Eric Carlson.
+
+Update the iOS WebContent process sandbox to allow access to some IOKit properties
+that are needed for drawing and media playback operations.
+
+* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
+* WebProcess/com.apple.WebKit.WebContent.sb.in:
+
+2019-01-02  Brent Fulgham  
+
 Remove unused logging service 
 https://bugs.webkit.org/show_bug.cgi?id=193081
 


Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb (239579 => 239580)

--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb	2019-01-02 23:41:56 UTC (rev 239579)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb	2019-01-02 23:50:22 UTC (rev 239580)
@@ -330,11 +330,16 @@
 (iokit-property "HEVCSupported")
 (iokit-property-regex #"^IOGL(|ES(|Metal))BundleName")
 (iokit-property "IOGLESDefaultUseMetal")
+(iokit-property-regex #"IOGVA(BGRAEnc|Codec|EncoderRestricted|Scaler)")
 (iokit-property "IOClassNameOverride")
 (iokit-property "IOSurfaceAcceleratorCapabilitiesDict")
 (iokit-property-regex #"^MetalPlugin(Name|ClassName)")
 (iokit-property "Protocol Characteristics")
 (iokit-property "artwork-device-subtype")
+(iokit-property-regex #"^canvas-(height|width)")
+(iokit-property "class-code")
+(iokit-property "color-accuracy-index")
+(iokit-property "device-id")
 (iokit-property "device-perf-memory-class")
 (iokit-property "emu")
 (iokit-property "hdcp-hoover-protocol")
@@ -341,6 +346,7 @@
 (iokit-property "iommu-present")
 (iokit-property "product-id")
 (iokit-property "software-behavior")
+(iokit-property "vendor-id")
 )
 
 ;; Read-only preferences and data


Modified: trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (239579 => 239580)

--- trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2019-01-02 23:41:56 UTC (rev 239579)
+++ trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2019-01-02 23:50:22 UTC (rev 239580)
@@ -288,6 +288,7 @@
 (iokit-property "NVArch")
 (iokit-property-regex #"^NVC(AP|LASS)")
 (iokit-property-regex #"^NVDA,(Features|NVPresentment-version|accel-loaded|invalid-config|mm-version)")
+(iokit-property "NVDA,Enable-A2R10G10B10Format")
 (iokit-property-regex #"^NVDA(Type|initgl_created)")
 (iokit-property "NVRAMProperty")
 (iokit-property "NXSystemInfo")
@@ -323,7 +324,9 @@
 (iokit-property "boot-gamma-restored")
 (iokit-property "built-in")
 (iokit-property "cail_properties")
+(iokit-property-regex #"^canvas-(height|width)")
 (iokit-property "class-code")
+(iokit-property "color-accuracy-index")
 (iokit-property "compatible")
 (iokit-property "connector-type")
 (iokit-property-regex #"^(device|revision|subsystem-vendor|touch-size)-id")






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239579] trunk

2019-01-02 Thread commit-queue 
Title: [239579] trunk








Revision 239579
Author commit-qu...@webkit.org
Date 2019-01-02 15:41:56 -0800 (Wed, 02 Jan 2019)


Log Message
Fix resourcetimingbufferfull bubbles attribute
https://bugs.webkit.org/show_bug.cgi?id=193087

Patch by Charles Vazac  on 2019-01-02
Reviewed by Chris Dumez.

Source/WebCore:

This change is covered by web-platform-tests [1].

[1] https://github.com/web-platform-tests/wpt/blob/master/resource-timing/buffer-full-when-populate-entries.html#L20

* page/Performance.cpp:
(WebCore::Performance::resourceTimingBufferFullTimerFired):

LayoutTests:

* http/wpt/resource-timing/rt-performance-extensions.js:
(promise_test):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/wpt/resource-timing/rt-performance-extensions.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Performance.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (239578 => 239579)

--- trunk/LayoutTests/ChangeLog	2019-01-02 21:32:07 UTC (rev 239578)
+++ trunk/LayoutTests/ChangeLog	2019-01-02 23:41:56 UTC (rev 239579)
@@ -1,3 +1,13 @@
+2019-01-02  Charles Vazac  
+
+Fix resourcetimingbufferfull bubbles attribute
+https://bugs.webkit.org/show_bug.cgi?id=193087
+
+Reviewed by Chris Dumez.
+
+* http/wpt/resource-timing/rt-performance-extensions.js:
+(promise_test):
+
 2019-01-02  Simon Fraser  
 
 Support css-color-4 rgb functions


Modified: trunk/LayoutTests/http/wpt/resource-timing/rt-performance-extensions.js (239578 => 239579)

--- trunk/LayoutTests/http/wpt/resource-timing/rt-performance-extensions.js	2019-01-02 21:32:07 UTC (rev 239578)
+++ trunk/LayoutTests/http/wpt/resource-timing/rt-performance-extensions.js	2019-01-02 23:41:56 UTC (rev 239579)
@@ -102,7 +102,7 @@
 assert_equals(entries.length, 2, "context should have observed 1 resource");
 assert_equals(performance.getEntriesByType("resource").length, 1, "context global buffer should be full at 1 resource");
 assert_equals(bufferFullEvent.target, performance, "event should dispatch at the performance object");
-assert_true(bufferFullEvent.bubbles, "event should bubble");
+assert_false(bufferFullEvent.bubbles, "event should not bubble");
 });
 }, "resourcetimingbufferfull event properties", {timeout: 3000});
 


Modified: trunk/Source/WebCore/ChangeLog (239578 => 239579)

--- trunk/Source/WebCore/ChangeLog	2019-01-02 21:32:07 UTC (rev 239578)
+++ trunk/Source/WebCore/ChangeLog	2019-01-02 23:41:56 UTC (rev 239579)
@@ -1,3 +1,17 @@
+2019-01-02  Charles Vazac  
+
+Fix resourcetimingbufferfull bubbles attribute
+https://bugs.webkit.org/show_bug.cgi?id=193087
+
+Reviewed by Chris Dumez.
+
+This change is covered by web-platform-tests [1].
+
+[1] https://github.com/web-platform-tests/wpt/blob/master/resource-timing/buffer-full-when-populate-entries.html#L20
+
+* page/Performance.cpp:
+(WebCore::Performance::resourceTimingBufferFullTimerFired):
+
 2019-01-02  Simon Fraser  
 
 Rename LayerScrollCoordinationRole to ScrollCoordinationRole and make an enum class


Modified: trunk/Source/WebCore/page/Performance.cpp (239578 => 239579)

--- trunk/Source/WebCore/page/Performance.cpp	2019-01-02 21:32:07 UTC (rev 239578)
+++ trunk/Source/WebCore/page/Performance.cpp	2019-01-02 23:41:56 UTC (rev 239579)
@@ -216,7 +216,7 @@
 ASSERT(m_backupResourceTimingBuffer.isEmpty());
 
 m_resourceTimingBufferFullFlag = true;
-dispatchEvent(Event::create(eventNames().resourcetimingbufferfullEvent, Event::CanBubble::Yes, Event::IsCancelable::No));
+dispatchEvent(Event::create(eventNames().resourcetimingbufferfullEvent, Event::CanBubble::No, Event::IsCancelable::No));
 
 if (m_resourceTimingBufferFullFlag) {
 for (auto& entry : backupBuffer)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239578] trunk/Source/WebKit

2019-01-02 Thread bfulgham 
Title: [239578] trunk/Source/WebKit








Revision 239578
Author bfulg...@apple.com
Date 2019-01-02 13:32:07 -0800 (Wed, 02 Jan 2019)


Log Message
Remove unused logging service
https://bugs.webkit.org/show_bug.cgi?id=193081


Reviewed by Alexey Proskuryakov.

We don't use this logging service, so don't open an exception for it.

* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb




Diff

Modified: trunk/Source/WebKit/ChangeLog (239577 => 239578)

--- trunk/Source/WebKit/ChangeLog	2019-01-02 21:30:54 UTC (rev 239577)
+++ trunk/Source/WebKit/ChangeLog	2019-01-02 21:32:07 UTC (rev 239578)
@@ -1,5 +1,17 @@
 2019-01-02  Brent Fulgham  
 
+Remove unused logging service 
+https://bugs.webkit.org/show_bug.cgi?id=193081
+
+
+Reviewed by Alexey Proskuryakov.
+
+We don't use this logging service, so don't open an exception for it.
+
+* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
+
+2019-01-02  Brent Fulgham  
+
 Remove temporary workaround for CVMS code signing objects
 https://bugs.webkit.org/show_bug.cgi?id=193079
 


Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb (239577 => 239578)

--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb	2019-01-02 21:30:54 UTC (rev 239577)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb	2019-01-02 21:32:07 UTC (rev 239578)
@@ -1,4 +1,4 @@
-; Copyright (C) 2010-2018 Apple Inc. All rights reserved.
+; Copyright (C) 2010-2019 Apple Inc. All rights reserved.
 ;
 ; Redistribution and use in source and binary forms, with or without
 ; modification, are permitted provided that the following conditions
@@ -235,9 +235,6 @@
 ;; 
 (mobile-preferences-read "kCFPreferencesAnyApplication")
 
-;; 
-(marco-logging-client)
-
 ;; 
 (mobile-preferences-read "com.apple.mediaaccessibility")
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239577] trunk/Source/WebKit

2019-01-02 Thread bfulgham 
Title: [239577] trunk/Source/WebKit








Revision 239577
Author bfulg...@apple.com
Date 2019-01-02 13:30:54 -0800 (Wed, 02 Jan 2019)


Log Message
Remove temporary workaround for CVMS code signing objects
https://bugs.webkit.org/show_bug.cgi?id=193079


Reviewed by Alexey Proskuryakov.

* WebProcess/com.apple.WebProcess.sb.in:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in




Diff

Modified: trunk/Source/WebKit/ChangeLog (239576 => 239577)

--- trunk/Source/WebKit/ChangeLog	2019-01-02 21:22:07 UTC (rev 239576)
+++ trunk/Source/WebKit/ChangeLog	2019-01-02 21:30:54 UTC (rev 239577)
@@ -1,3 +1,13 @@
+2019-01-02  Brent Fulgham  
+
+Remove temporary workaround for CVMS code signing objects
+https://bugs.webkit.org/show_bug.cgi?id=193079
+
+
+Reviewed by Alexey Proskuryakov.
+
+* WebProcess/com.apple.WebProcess.sb.in:
+
 2019-01-02  Wenson Hsieh  
 
 REGRESSION (r239441): [iOS] Selection UI sometimes doesn't change after tapping "select all" in the callout bar


Modified: trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (239576 => 239577)

--- trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2019-01-02 21:22:07 UTC (rev 239576)
+++ trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2019-01-02 21:30:54 UTC (rev 239577)
@@ -105,9 +105,6 @@
 (allow mach-lookup
 (global-name "com.apple.cvmsServ"))
 #if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
-;; Needed by , remove when  is fixed.
-(allow file-read* file-write-unlink
-(prefix "/private/tmp/cvmsCodeSignObj"))
 (allow file-read*
 (prefix "/private/var/db/CVMS/cvmsCodeSignObj"))
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239576] trunk/Source/WebCore

2019-01-02 Thread simon . fraser 
Title: [239576] trunk/Source/WebCore








Revision 239576
Author simon.fra...@apple.com
Date 2019-01-02 13:22:07 -0800 (Wed, 02 Jan 2019)


Log Message
Rename LayerScrollCoordinationRole to ScrollCoordinationRole and make an enum class
https://bugs.webkit.org/show_bug.cgi?id=193010

Reviewed by Zalan Bujtas.

Move the enum LayerScrollCoordinationRole from RenderLayer.h to RenderLayerCompositor.h,
and make it an enum class.

* page/FrameView.cpp:
(WebCore::FrameView::scrollLayerID const):
* rendering/RenderLayer.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::~RenderLayerBacking):
(WebCore::RenderLayerBacking::detachFromScrollingCoordinator):
(WebCore::operator<<):
* rendering/RenderLayerBacking.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateScrollCoordinatedStatus):
(WebCore::RenderLayerCompositor::removeFromScrollCoordinatedLayers):
(WebCore::scrollCoordinationRoleForNodeType):
(WebCore::RenderLayerCompositor::attachScrollingNode):
(WebCore::RenderLayerCompositor::detachScrollCoordinatedLayer):
(WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer):
(WebCore::RenderLayerCompositor::willRemoveScrollingLayerWithBacking):
* rendering/RenderLayerCompositor.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/rendering/RenderLayer.h
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp
trunk/Source/WebCore/rendering/RenderLayerBacking.h
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
trunk/Source/WebCore/rendering/RenderLayerCompositor.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (239575 => 239576)

--- trunk/Source/WebCore/ChangeLog	2019-01-02 21:09:13 UTC (rev 239575)
+++ trunk/Source/WebCore/ChangeLog	2019-01-02 21:22:07 UTC (rev 239576)
@@ -1,5 +1,33 @@
 2019-01-02  Simon Fraser  
 
+Rename LayerScrollCoordinationRole to ScrollCoordinationRole and make an enum class
+https://bugs.webkit.org/show_bug.cgi?id=193010
+
+Reviewed by Zalan Bujtas.
+
+Move the enum LayerScrollCoordinationRole from RenderLayer.h to RenderLayerCompositor.h,
+and make it an enum class.
+
+* page/FrameView.cpp:
+(WebCore::FrameView::scrollLayerID const):
+* rendering/RenderLayer.h:
+* rendering/RenderLayerBacking.cpp:
+(WebCore::RenderLayerBacking::~RenderLayerBacking):
+(WebCore::RenderLayerBacking::detachFromScrollingCoordinator):
+(WebCore::operator<<):
+* rendering/RenderLayerBacking.h:
+* rendering/RenderLayerCompositor.cpp:
+(WebCore::RenderLayerCompositor::updateScrollCoordinatedStatus):
+(WebCore::RenderLayerCompositor::removeFromScrollCoordinatedLayers):
+(WebCore::scrollCoordinationRoleForNodeType):
+(WebCore::RenderLayerCompositor::attachScrollingNode):
+(WebCore::RenderLayerCompositor::detachScrollCoordinatedLayer):
+(WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer):
+(WebCore::RenderLayerCompositor::willRemoveScrollingLayerWithBacking):
+* rendering/RenderLayerCompositor.h:
+
+2019-01-02  Simon Fraser  
+
 Don't spin up a CalcParser if the current token is not a function token
 https://bugs.webkit.org/show_bug.cgi?id=193067
 


Modified: trunk/Source/WebCore/page/FrameView.cpp (239575 => 239576)

--- trunk/Source/WebCore/page/FrameView.cpp	2019-01-02 21:09:13 UTC (rev 239575)
+++ trunk/Source/WebCore/page/FrameView.cpp	2019-01-02 21:22:07 UTC (rev 239576)
@@ -905,7 +905,7 @@
 if (!backing)
 return 0;
 
-return backing->scrollingNodeIDForRole(Scrolling);
+return backing->scrollingNodeIDForRole(ScrollCoordinationRole::Scrolling);
 }
 
 ScrollableArea* FrameView::scrollableAreaForScrollLayerID(uint64_t nodeID) const


Modified: trunk/Source/WebCore/rendering/RenderLayer.h (239575 => 239576)

--- trunk/Source/WebCore/rendering/RenderLayer.h	2019-01-02 21:09:13 UTC (rev 239575)
+++ trunk/Source/WebCore/rendering/RenderLayer.h	2019-01-02 21:22:07 UTC (rev 239576)
@@ -107,11 +107,6 @@
 IgnoreRootOffsetForFragments
 };
 
-enum LayerScrollCoordinationRole {
-ViewportConstrained = 1 << 0,
-Scrolling   = 1 << 1
-};
-
 enum class RequestState {
 Unknown,
 DontCare,


Modified: trunk/Source/WebCore/rendering/RenderLayerBacking.cpp (239575 => 239576)

--- trunk/Source/WebCore/rendering/RenderLayerBacking.cpp	2019-01-02 21:09:13 UTC (rev 239575)
+++ trunk/Source/WebCore/rendering/RenderLayerBacking.cpp	2019-01-02 21:22:07 UTC (rev 239576)
@@ -244,7 +244,7 @@
 updateBackgroundLayer(false);
 updateMaskingLayer(false, false);
 updateScrollingLayers(false);
-detachFromScrollingCoordinator({ Scrolling, ViewportConstrained });
+detachFromScrollingCoordinator({ ScrollCoordinationRole::Scrolling, ScrollCoordinationRole::ViewportConstrained });
 destroyGraphicsLayers();
 }
 
@@ -1772,7 +1772,7 @@
 return true;
 }
 
-void

[webkit-changes] [239575] trunk/Source/WebCore

2019-01-02 Thread simon . fraser 
Title: [239575] trunk/Source/WebCore








Revision 239575
Author simon.fra...@apple.com
Date 2019-01-02 13:09:13 -0800 (Wed, 02 Jan 2019)


Log Message
Don't spin up a CalcParser if the current token is not a function token
https://bugs.webkit.org/show_bug.cgi?id=193067

Reviewed by Zalan Bujtas.

Various functions in CSSPropertyParserHelpers fall back to trying to parse
a calc _expression_ if the normal parsing fails. Don't do this unless the
current token is a function token, which should be slightly more efficient.

* css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeInteger):
(WebCore::CSSPropertyParserHelpers::consumePositiveIntegerRaw):
(WebCore::CSSPropertyParserHelpers::consumeNumberRaw):
(WebCore::CSSPropertyParserHelpers::consumeNumber):
(WebCore::CSSPropertyParserHelpers::consumeFontWeightNumber):
(WebCore::CSSPropertyParserHelpers::consumeLength):
(WebCore::CSSPropertyParserHelpers::consumePercent):
(WebCore::CSSPropertyParserHelpers::consumeLengthOrPercent):
(WebCore::CSSPropertyParserHelpers::consumeAngle):
(WebCore::CSSPropertyParserHelpers::consumeAngleOrPercent):
(WebCore::CSSPropertyParserHelpers::consumeTime):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (239574 => 239575)

--- trunk/Source/WebCore/ChangeLog	2019-01-02 20:53:37 UTC (rev 239574)
+++ trunk/Source/WebCore/ChangeLog	2019-01-02 21:09:13 UTC (rev 239575)
@@ -1,5 +1,29 @@
 2019-01-02  Simon Fraser  
 
+Don't spin up a CalcParser if the current token is not a function token
+https://bugs.webkit.org/show_bug.cgi?id=193067
+
+Reviewed by Zalan Bujtas.
+
+Various functions in CSSPropertyParserHelpers fall back to trying to parse
+a calc _expression_ if the normal parsing fails. Don't do this unless the
+current token is a function token, which should be slightly more efficient.
+
+* css/parser/CSSPropertyParserHelpers.cpp:
+(WebCore::CSSPropertyParserHelpers::consumeInteger):
+(WebCore::CSSPropertyParserHelpers::consumePositiveIntegerRaw):
+(WebCore::CSSPropertyParserHelpers::consumeNumberRaw):
+(WebCore::CSSPropertyParserHelpers::consumeNumber):
+(WebCore::CSSPropertyParserHelpers::consumeFontWeightNumber):
+(WebCore::CSSPropertyParserHelpers::consumeLength):
+(WebCore::CSSPropertyParserHelpers::consumePercent):
+(WebCore::CSSPropertyParserHelpers::consumeLengthOrPercent):
+(WebCore::CSSPropertyParserHelpers::consumeAngle):
+(WebCore::CSSPropertyParserHelpers::consumeAngleOrPercent):
+(WebCore::CSSPropertyParserHelpers::consumeTime):
+
+2019-01-02  Simon Fraser  
+
 Support css-color-4 rgb functions
 https://bugs.webkit.org/show_bug.cgi?id=192321
 


Modified: trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp (239574 => 239575)

--- trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp	2019-01-02 20:53:37 UTC (rev 239574)
+++ trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp	2019-01-02 21:09:13 UTC (rev 239575)
@@ -138,6 +138,10 @@
 return nullptr;
 return CSSValuePool::singleton().createValue(range.consumeIncludingWhitespace().numericValue(), CSSPrimitiveValue::UnitType::CSS_NUMBER);
 }
+
+if (token.type() != FunctionToken)
+return nullptr;
+
 CalcParser calcParser(range, CalculationCategory::Number);
 if (const CSSCalcValue* calculation = calcParser.value()) {
 if (calculation->category() != CalculationCategory::Number || !calculation->isInt())
@@ -147,6 +151,7 @@
 return nullptr;
 return calcParser.consumeNumber();
 }
+
 return nullptr;
 }
 
@@ -164,6 +169,10 @@
 result = range.consumeIncludingWhitespace().numericValue();
 return true;
 }
+
+if (token.type() != FunctionToken)
+return false;
+
 CalcParser calcParser(range, CalculationCategory::Number);
 return calcParser.consumePositiveIntegerRaw(result);
 }
@@ -170,10 +179,15 @@
 
 bool consumeNumberRaw(CSSParserTokenRange& range, double& result)
 {
-if (range.peek().type() == NumberToken) {
+const CSSParserToken& token = range.peek();
+if (token.type() == NumberToken) {
 result = range.consumeIncludingWhitespace().numericValue();
 return true;
 }
+
+if (token.type() != FunctionToken)
+return false;
+
 CalcParser calcParser(range, CalculationCategory::Number, ValueRangeAll);
 return calcParser.consumeNumberRaw(result);
 }
@@ -187,6 +201,10 @@
 return nullptr;
 return CSSValuePool::singleton().createValue(range.consumeIncludingWhitespace().numericValue(), token.unitType());
 }
+
+if (token.type() != FunctionToken)
+return nullptr;
+
 CalcParser calcParser(range, CalculationCategory::Number, ValueRangeAll);
 if (const

[webkit-changes] [239573] trunk

2019-01-02 Thread wenson_hsieh 
Title: [239573] trunk








Revision 239573
Author wenson_hs...@apple.com
Date 2019-01-02 12:28:24 -0800 (Wed, 02 Jan 2019)


Log Message
REGRESSION (r239441): [iOS] Selection UI sometimes doesn't change after tapping "select all" in the callout bar
https://bugs.webkit.org/show_bug.cgi?id=193070


Reviewed by Tim Horton.

Source/WebKit:

r239441 added logic to include an EditorState in the next layer tree commit when refocusing an element; this was
done to ensure that after tapping an element that has already been programmatically focused, we still send up-
to-date editor information to the UI process for the purposes of zooming to the selection rect, even if the
selection in the DOM is unchanged, since other aspects of the editor state may have changed since the element
was initially focused.

We currently try to flag the next layer tree commit by setting `m_hasPendingEditorStateUpdate` to `true`.
However, this is problematic since we aren't guaranteed in all cases that a compositing flush has been
scheduled. In the case where it hasn't, we'll end up in a state where the editor state update flag has been set,
yet the update will not make it over to the UI process until something happens that forces a layer tree commit
(e.g. scrolling, pinch zooming). Worse still, if the selection is then programmatically changed from the web
process, we will bail from sending a subsequent editor state update to the UI process because `WebPage` thinks
that a pending editor state has already been scheduled. This manifests in selection UI not updating after
tapping "Select All" in the callout bar, if the callout bar was brought up by tapping near the selection (since
this refocuses the element).

To fix this, we adjust this logic in `WebPage::elementDidRefocus` so that it sets the flag and then schedules a
compositing flush, but only if the user is actually interacting with the focused element (i.e., if the page
calls `focus` repeatedly, we won't continue to schedule compositing flushes).

Test: editing/selection/ios/change-selection-after-tapping-focused-element.html

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::elementDidRefocus):
(WebKit::WebPage::sendEditorStateUpdate):
(WebKit::WebPage::scheduleFullEditorStateUpdate):

Add a private helper method to schedule an editor state update by setting `m_hasPendingEditorStateUpdate` to
`true` and then scheduling a compositing layer flush. Also, add a FIXME aluding to the fact that scheduling an
entire compositing layer flush to send an editor state update is somewhat wasteful, and should be replaced by
just scheduling this work to be done before the next frame (see:  for more detail).

We also use this helper method in a few places where we currently turn on the editor state flag and schedule a
subsequent compositing flush.

(WebKit::WebPage::sendPartialEditorStateAndSchedulePostLayoutUpdate):
* WebProcess/WebPage/WebPage.h:

LayoutTests:

Add a test to ensure that selection UI is shown after tapping on a focused element and then changing the
selection programmatically.

* editing/selection/ios/change-selection-after-tapping-focused-element-expected.txt: Added.
* editing/selection/ios/change-selection-after-tapping-focused-element.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit/WebProcess/WebPage/WebPage.h


Added Paths

trunk/LayoutTests/editing/selection/ios/change-selection-after-tapping-focused-element-expected.txt
trunk/LayoutTests/editing/selection/ios/change-selection-after-tapping-focused-element.html




Diff

Modified: trunk/LayoutTests/ChangeLog (239572 => 239573)

--- trunk/LayoutTests/ChangeLog	2019-01-02 19:40:05 UTC (rev 239572)
+++ trunk/LayoutTests/ChangeLog	2019-01-02 20:28:24 UTC (rev 239573)
@@ -1,3 +1,17 @@
+2019-01-02  Wenson Hsieh  
+
+REGRESSION (r239441): [iOS] Selection UI sometimes doesn't change after tapping "select all" in the callout bar
+https://bugs.webkit.org/show_bug.cgi?id=193070
+
+
+Reviewed by Tim Horton.
+
+Add a test to ensure that selection UI is shown after tapping on a focused element and then changing the
+selection programmatically.
+
+* editing/selection/ios/change-selection-after-tapping-focused-element-expected.txt: Added.
+* editing/selection/ios/change-selection-after-tapping-focused-element.html: Added.
+
 2019-01-02  Simon Fraser  
 
 Handle calc() expressions in gradient color stops


Added: trunk/LayoutTests/editing/selection/ios/change-selection-after-tapping-focused-element-expected.txt (0 => 239573)

--- trunk/LayoutTests/editing/selection/ios/change-selection-after-tapping-focused-element-expected.txt	(rev 0)
+++ trunk/LayoutTests/editing/selection/ios/change-selection-after-tapping-focused-element-expected.txt	2019-01-02 20:28:24 UTC (rev 239573)
@@ -0,0 +1,14 @@
+WebKit
+Verifies that after tapping a

[webkit-changes] [239572] trunk/Source

2019-01-02 Thread commit-queue 
Title: [239572] trunk/Source








Revision 239572
Author commit-qu...@webkit.org
Date 2019-01-02 11:40:05 -0800 (Wed, 02 Jan 2019)


Log Message
Unreviewed, rolling out r239524.
https://bugs.webkit.org/show_bug.cgi?id=193083

basic browsing seems not to work (Requested by thorton on
#webkit).

Reverted changeset:

"Expand use of sourceApplicationAuditData"
https://bugs.webkit.org/show_bug.cgi?id=192995
https://trac.webkit.org/changeset/239524

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Platform.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm
trunk/Source/WebKit/Platform/IPC/Connection.h
trunk/Source/WebKit/Platform/IPC/mac/ConnectionMac.mm
trunk/Source/WebKit/WebProcess/WebProcess.cpp
trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm




Diff

Modified: trunk/Source/WTF/ChangeLog (239571 => 239572)

--- trunk/Source/WTF/ChangeLog	2019-01-02 19:24:48 UTC (rev 239571)
+++ trunk/Source/WTF/ChangeLog	2019-01-02 19:40:05 UTC (rev 239572)
@@ -1,3 +1,17 @@
+2019-01-02  Commit Queue  
+
+Unreviewed, rolling out r239524.
+https://bugs.webkit.org/show_bug.cgi?id=193083
+
+basic browsing seems not to work (Requested by thorton on
+#webkit).
+
+Reverted changeset:
+
+"Expand use of sourceApplicationAuditData"
+https://bugs.webkit.org/show_bug.cgi?id=192995
+https://trac.webkit.org/changeset/239524
+
 2018-12-28  Yusuke Suzuki  
 
 Add ENABLE_UNIFIED_BUILDS option to cmake ports


Modified: trunk/Source/WTF/wtf/Platform.h (239571 => 239572)

--- trunk/Source/WTF/wtf/Platform.h	2019-01-02 19:24:48 UTC (rev 239571)
+++ trunk/Source/WTF/wtf/Platform.h	2019-01-02 19:40:05 UTC (rev 239572)
@@ -1359,10 +1359,6 @@
 #define HAVE_RSA_PSS 1
 #endif
 
-#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500) || PLATFORM(IOS_FAMILY)
-#define USE_SOURCE_APPLICATION_AUDIT_DATA 1
-#endif
-
 #if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400) || PLATFORM(IOS) || PLATFORM(IOSMAC)
 #define HAVE_URL_FORMATTING 1
 #endif


Modified: trunk/Source/WebKit/ChangeLog (239571 => 239572)

--- trunk/Source/WebKit/ChangeLog	2019-01-02 19:24:48 UTC (rev 239571)
+++ trunk/Source/WebKit/ChangeLog	2019-01-02 19:40:05 UTC (rev 239572)
@@ -1,3 +1,17 @@
+2019-01-02  Commit Queue  
+
+Unreviewed, rolling out r239524.
+https://bugs.webkit.org/show_bug.cgi?id=193083
+
+basic browsing seems not to work (Requested by thorton on
+#webkit).
+
+Reverted changeset:
+
+"Expand use of sourceApplicationAuditData"
+https://bugs.webkit.org/show_bug.cgi?id=192995
+https://trac.webkit.org/changeset/239524
+
 2019-01-01  Jeff Miller  
 
 Update user-visible copyright strings to include 2019


Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm (239571 => 239572)

--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm	2019-01-02 19:24:48 UTC (rev 239571)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm	2019-01-02 19:40:05 UTC (rev 239572)
@@ -133,14 +133,12 @@
 
 RetainPtr NetworkProcess::sourceApplicationAuditData() const
 {
-#if USE(SOURCE_APPLICATION_AUDIT_DATA)
+#if PLATFORM(IOS_FAMILY) && !PLATFORM(IOSMAC)
+audit_token_t auditToken;
 ASSERT(parentProcessConnection());
-if (!parentProcessConnection())
+if (!parentProcessConnection() || !parentProcessConnection()->getAuditToken(auditToken))
 return nullptr;
-Optional auditToken = parentProcessConnection()->getAuditToken();
-if (!auditToken)
-return nullptr;
-return adoptCF(CFDataCreate(nullptr, (const UInt8*)&*auditToken, sizeof(*auditToken)));
+return adoptCF(CFDataCreate(nullptr, (const UInt8*), sizeof(auditToken)));
 #else
 return nullptr;
 #endif


Modified: trunk/Source/WebKit/Platform/IPC/Connection.h (239571 => 239572)

--- trunk/Source/WebKit/Platform/IPC/Connection.h	2019-01-02 19:24:48 UTC (rev 239571)
+++ trunk/Source/WebKit/Platform/IPC/Connection.h	2019-01-02 19:40:05 UTC (rev 239572)
@@ -137,7 +137,7 @@
 };
 static bool identifierIsValid(Identifier identifier) { return MACH_PORT_VALID(identifier.port); }
 xpc_connection_t xpcConnection() const { return m_xpcConnection.get(); }
-Optional getAuditToken();
+bool getAuditToken(audit_token_t&);
 pid_t remoteProcessID() const;
 #elif OS(WINDOWS)
 typedef HANDLE Identifier;


Modified: trunk/Source/WebKit/Platform/IPC/mac/ConnectionMac.mm (239571 => 239572)

--- trunk/Source/WebKit/Platform/IPC/mac/ConnectionMac.mm	2019-01-02 19:24:48 UTC (rev 239571)
+++ trunk/Source/WebKit/Platform/IPC/mac/ConnectionMac.mm	2019-01-02 19:40:05 UTC (rev 239572)
@@ -603,14 +603,13 @@
 return Identifier(m_isServer ? m_receivePort : m_sendPort, m_xpcConnection);
 }
 
-Optional Connection::getAuditToken()
+bool Connection::getAuditToken(audit_token_t& auditToken)
 {
 if (!m_xpcConnection)
-return

[webkit-changes] [239571] trunk

2019-01-02 Thread simon . fraser 
Title: [239571] trunk








Revision 239571
Author simon.fra...@apple.com
Date 2019-01-02 11:24:48 -0800 (Wed, 02 Jan 2019)


Log Message
Handle calc() expressions in gradient color stops
https://bugs.webkit.org/show_bug.cgi?id=193066
rdar://problem/46961985

Reviewed by Sam Weinig.
Source/WebCore:

Fix two issues that prevented calc() expressions from working in conic-gradient color stops,
for the angle or percent value. First, consumeAngleOrPercent() needs to look for CalculationCategory::Percent
calc values as well as angle ones.

Second, CSSPrimitiveValue::isAngle() needs to use primitiveType() (which takes calc into account),
just as isPx() etc do.

Test: fast/gradients/conic-calc-stop-position.html

* css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::isAngle const):
* css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeAngleOrPercent):
(WebCore::CSSPropertyParserHelpers::consumeGradientColorStops):

LayoutTests:

* fast/gradients/conic-calc-stop-position-expected.html: Added.
* fast/gradients/conic-calc-stop-position.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSPrimitiveValue.h
trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp


Added Paths

trunk/LayoutTests/fast/gradients/conic-calc-stop-position-expected.html
trunk/LayoutTests/fast/gradients/conic-calc-stop-position.html




Diff

Modified: trunk/LayoutTests/ChangeLog (239570 => 239571)

--- trunk/LayoutTests/ChangeLog	2019-01-02 18:50:16 UTC (rev 239570)
+++ trunk/LayoutTests/ChangeLog	2019-01-02 19:24:48 UTC (rev 239571)
@@ -1,3 +1,14 @@
+2019-01-02  Simon Fraser  
+
+Handle calc() expressions in gradient color stops
+https://bugs.webkit.org/show_bug.cgi?id=193066
+rdar://problem/46961985
+
+Reviewed by Sam Weinig.
+
+* fast/gradients/conic-calc-stop-position-expected.html: Added.
+* fast/gradients/conic-calc-stop-position.html: Added.
+
 2018-12-31  Carlos Garcia Campos  
 
 Unreviewed. Support PHP 7.3 in Debian.


Added: trunk/LayoutTests/fast/gradients/conic-calc-stop-position-expected.html (0 => 239571)

--- trunk/LayoutTests/fast/gradients/conic-calc-stop-position-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/gradients/conic-calc-stop-position-expected.html	2019-01-02 19:24:48 UTC (rev 239571)
@@ -0,0 +1,20 @@
+
+
+
+.box {
+margin: 10px;
+height: 200px;
+width: 200px;
+border: 1px solid black;
+float: left;
+}
+
+
+
+All boxes should look the same.
+
+
+
+
+
+


Added: trunk/LayoutTests/fast/gradients/conic-calc-stop-position.html (0 => 239571)

--- trunk/LayoutTests/fast/gradients/conic-calc-stop-position.html	(rev 0)
+++ trunk/LayoutTests/fast/gradients/conic-calc-stop-position.html	2019-01-02 19:24:48 UTC (rev 239571)
@@ -0,0 +1,20 @@
+
+
+
+.box {
+margin: 10px;
+height: 200px;
+width: 200px;
+border: 1px solid black;
+float: left;
+}
+
+
+
+All boxes should look the same.
+
+
+
+
+
+


Modified: trunk/Source/WebCore/ChangeLog (239570 => 239571)

--- trunk/Source/WebCore/ChangeLog	2019-01-02 18:50:16 UTC (rev 239570)
+++ trunk/Source/WebCore/ChangeLog	2019-01-02 19:24:48 UTC (rev 239571)
@@ -1,3 +1,26 @@
+2019-01-02  Simon Fraser  
+
+Handle calc() expressions in gradient color stops
+https://bugs.webkit.org/show_bug.cgi?id=193066
+rdar://problem/46961985
+
+Reviewed by Sam Weinig.
+
+Fix two issues that prevented calc() expressions from working in conic-gradient color stops,
+for the angle or percent value. First, consumeAngleOrPercent() needs to look for CalculationCategory::Percent
+calc values as well as angle ones.
+
+Second, CSSPrimitiveValue::isAngle() needs to use primitiveType() (which takes calc into account),
+just as isPx() etc do.
+
+Test: fast/gradients/conic-calc-stop-position.html
+
+* css/CSSPrimitiveValue.h:
+(WebCore::CSSPrimitiveValue::isAngle const):
+* css/parser/CSSPropertyParserHelpers.cpp:
+(WebCore::CSSPropertyParserHelpers::consumeAngleOrPercent):
+(WebCore::CSSPropertyParserHelpers::consumeGradientColorStops):
+
 2018-12-31  Keith Miller  
 
 SourceProviders should use an actual URL instead of a string


Modified: trunk/Source/WebCore/css/CSSPrimitiveValue.h (239570 => 239571)

--- trunk/Source/WebCore/css/CSSPrimitiveValue.h	2019-01-02 18:50:16 UTC (rev 239570)
+++ trunk/Source/WebCore/css/CSSPrimitiveValue.h	2019-01-02 19:24:48 UTC (rev 239571)
@@ -352,10 +352,11 @@
 
 inline bool CSSPrimitiveValue::isAngle() const
 {
-return m_primitiveUnitType == CSS_DEG
-|| m_primitiveUnitType == CSS_RAD
-|| m_primitiveUnitType ==

[webkit-changes] [239570] trunk/Tools

2019-01-02 Thread dbates 
Title: [239570] trunk/Tools








Revision 239570
Author dba...@webkit.org
Date 2019-01-02 10:50:16 -0800 (Wed, 02 Jan 2019)


Log Message
[lldb-webkit] Remove broken code to print WTF::OptionSet::m_storage
https://bugs.webkit.org/show_bug.cgi?id=193023

Reviewed by Simon Fraser.

The code to print WTF::OptionSet::m_storage as an item in the set never worked and does
not seem meaningful to fix because WTF::OptionSet::m_storage is just the sum of the printed
enumerator values. We should just remove this code.

* lldb/lldb_webkit.py:
(WTFOptionSetProvider.has_children):
(WTFOptionSetProvider.num_children):
(WTFOptionSetProvider.get_child_index):
(WTFOptionSetProvider.get_child_at_index):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/lldb/lldb_webkit.py




Diff

Modified: trunk/Tools/ChangeLog (239569 => 239570)

--- trunk/Tools/ChangeLog	2019-01-02 17:59:08 UTC (rev 239569)
+++ trunk/Tools/ChangeLog	2019-01-02 18:50:16 UTC (rev 239570)
@@ -1,3 +1,20 @@
+2019-01-02  Daniel Bates  
+
+[lldb-webkit] Remove broken code to print WTF::OptionSet::m_storage
+https://bugs.webkit.org/show_bug.cgi?id=193023
+
+Reviewed by Simon Fraser.
+
+The code to print WTF::OptionSet::m_storage as an item in the set never worked and does
+not seem meaningful to fix because WTF::OptionSet::m_storage is just the sum of the printed
+enumerator values. We should just remove this code.
+
+* lldb/lldb_webkit.py:
+(WTFOptionSetProvider.has_children):
+(WTFOptionSetProvider.num_children):
+(WTFOptionSetProvider.get_child_index):
+(WTFOptionSetProvider.get_child_at_index):
+
 2018-12-29  Yusuke Suzuki  
 
 .ycm_extra_conf.py should handle XXXInlines.h


Modified: trunk/Tools/lldb/lldb_webkit.py (239569 => 239570)

--- trunk/Tools/lldb/lldb_webkit.py	2019-01-02 17:59:08 UTC (rev 239569)
+++ trunk/Tools/lldb/lldb_webkit.py	2019-01-02 18:50:16 UTC (rev 239570)
@@ -705,13 +705,10 @@
 def has_children(self):
 return bool(self._elements)
 
-#  Metadata is stored at indices greater than or equal to the number of elements in the set.
 def num_children(self):
-return len(self._elements) + 1
+return len(self._elements)
 
 def get_child_index(self, name):
-if name == 'm_storage':
-return self.num_children()
 try:
 return int(name.lstrip('[').rstrip(']'))
 except:
@@ -720,8 +717,6 @@
 def get_child_at_index(self, index):
 if index < 0 or not self.valobj.IsValid():
 return None
-if index == self.num_children():
-return self.storage
 if index < len(self._elements):
 (name, value) = self._elements[index]
 return self.valobj.CreateValueFromExpression(name, str(value))






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239569] trunk/Source

2019-01-02 Thread keith_miller 
Title: [239569] trunk/Source








Revision 239569
Author keith_mil...@apple.com
Date 2019-01-02 09:59:08 -0800 (Wed, 02 Jan 2019)


Log Message
SourceProviders should use an actual URL instead of a string
https://bugs.webkit.org/show_bug.cgi?id=192734

Reviewed by Yusuke Suzuki.

Source/_javascript_Core:

This will be useful for the Module loader API in the future where
by default it will use the relative path from the referring module
to resolve dependencies.

I didn't change the JSC shell's urls to be absolute paths as it
caused problems with the stack traces in our Chakra tests. Since
the absolute paths included system directories the diff would
appear incorrect.
See: https://bugs.webkit.org/show_bug.cgi?id=193077

* API/JSBase.cpp:
(JSEvaluateScript):
(JSCheckScriptSyntax):
* API/JSScriptRef.cpp:
(OpaqueJSScript::create):
(OpaqueJSScript::OpaqueJSScript):
* API/glib/JSCContext.cpp:
(jsc_context_check_syntax):
* jsc.cpp:
(jscSource):
(GlobalObject::moduleLoaderFetch):
(functionCheckModuleSyntax):
(runWithOptions):
* parser/SourceCode.h:
(JSC::makeSource):
* parser/SourceProvider.cpp:
(JSC::SourceProvider::SourceProvider):
* parser/SourceProvider.h:
(JSC::SourceProvider::url const):
(JSC::StringSourceProvider::create):
(JSC::StringSourceProvider::StringSourceProvider):
(JSC::WebAssemblySourceProvider::create):
(JSC::WebAssemblySourceProvider::WebAssemblySourceProvider):
* runtime/FunctionConstructor.cpp:
(JSC::constructFunctionSkippingEvalEnabledCheck):
* tools/CodeProfile.h:
(JSC::CodeProfile::CodeProfile):
* tools/FunctionOverrides.cpp:
(JSC::initializeOverrideInfo):

Source/WebCore:

Remove ScriptSourceCode's URL member and make the url() method
reference the URL on the SourceProvider. Also, avoid some
ref count churn.

Additionally, this patch fixes an existing bug in
WorkletGlobalScope() that would use a ScriptSourceCode after
WTFMoving it.

* bindings/js/CachedScriptSourceProvider.h:
(WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):
* bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::execute):
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::executeScriptInWorld):
(WebCore::ScriptController::executeScript):
* bindings/js/ScriptSourceCode.h:
(WebCore::ScriptSourceCode::ScriptSourceCode):
(WebCore::ScriptSourceCode::m_code):
(WebCore::ScriptSourceCode::url const):
(WebCore::ScriptSourceCode::m_url): Deleted.
* dom/ScriptElement.cpp:
(WebCore::ScriptElement::prepareScript):
(WebCore::ScriptElement::requestModuleScript):
(WebCore::ScriptElement::executePendingScript):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::ensureMediaControlsInjectedScript):
* page/Frame.cpp:
(WebCore::Frame::injectUserScriptImmediately):
* workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::importScripts):
* workers/WorkerThread.cpp:
(WebCore::WorkerThread::workerThread):
* worklets/WorkletGlobalScope.cpp:
(WebCore::WorkletGlobalScope::WorkletGlobalScope):
* xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::endElementNs):

Modified Paths

trunk/Source/_javascript_Core/API/JSBase.cpp
trunk/Source/_javascript_Core/API/JSScriptRef.cpp
trunk/Source/_javascript_Core/API/glib/JSCContext.cpp
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jsc.cpp
trunk/Source/_javascript_Core/parser/SourceCode.h
trunk/Source/_javascript_Core/parser/SourceProvider.cpp
trunk/Source/_javascript_Core/parser/SourceProvider.h
trunk/Source/_javascript_Core/runtime/FunctionConstructor.cpp
trunk/Source/_javascript_Core/tools/CodeProfile.h
trunk/Source/_javascript_Core/tools/FunctionOverrides.cpp
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/CachedScriptSourceProvider.h
trunk/Source/WebCore/bindings/js/ScheduledAction.cpp
trunk/Source/WebCore/bindings/js/ScriptController.cpp
trunk/Source/WebCore/bindings/js/ScriptSourceCode.h
trunk/Source/WebCore/dom/ScriptElement.cpp
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/page/Frame.cpp
trunk/Source/WebCore/workers/WorkerGlobalScope.cpp
trunk/Source/WebCore/workers/WorkerThread.cpp
trunk/Source/WebCore/worklets/WorkletGlobalScope.cpp
trunk/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp




Diff

Modified: trunk/Source/_javascript_Core/API/JSBase.cpp (239568 => 239569)

--- trunk/Source/_javascript_Core/API/JSBase.cpp	2019-01-01 19:29:55 UTC (rev 239568)
+++ trunk/Source/_javascript_Core/API/JSBase.cpp	2019-01-02 17:59:08 UTC (rev 239569)
@@ -64,7 +64,7 @@
 // evaluate sets "this" to the global object if it is NULL
 JSGlobalObject* globalObject = vm.vmEntryGlobalObject(exec);
 auto sourceURLString = sourceURL ? sourceURL->string() : String();
-SourceCode source = makeSource(script->string(), SourceOrigin { sourceURLString }, sourceURLString, TextPosition(OrdinalNumber::fromOneBasedInt(startingLineNumber), OrdinalNumber()));
+SourceCode source = makeSource(script->string(), SourceOrigin { sourceURLString }, URL({ }, sourceURLString),