[webkit-changes] [291332] trunk/Source/JavaScriptCore
Title: [291332] trunk/Source/_javascript_Core
Revision 291332
Author ysuz...@apple.com
Date 2022-03-15 22:35:12 -0700 (Tue, 15 Mar 2022)
Log Message
[JSC] Add UnlinkedDFG compilation mode enum
https://bugs.webkit.org/show_bug.cgi?id=237934
Reviewed by Mark Lam.
This patch adds UnlinkedDFG compilation mode to prepare new unlinked DFG.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::inliningCost):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::watchCondition):
(JSC::DFG::Graph::watchConditions):
(JSC::DFG::Graph::watchGlobalProperty):
(JSC::DFG::Graph::tryGetConstantProperty):
(JSC::DFG::Graph::tryGetConstantClosureVar):
(JSC::DFG::Graph::tryGetFoldableView):
(JSC::DFG::Graph::getRegExpPrototypeProperty):
(JSC::DFG::Graph::canOptimizeStringObjectAccess):
(JSC::DFG::Graph::canDoFastSpread):
* dfg/DFGGraph.h:
* dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThreadImpl):
* dfg/DFGTierUpCheckInjectionPhase.cpp:
(JSC::DFG::TierUpCheckInjectionPhase::run):
* jit/JITCompilationMode.cpp:
(WTF::printInternal):
* jit/JITCompilationMode.h:
(JSC::isDFG):
(JSC::isUnlinked):
* jit/JITPlan.cpp:
(JSC::JITPlan::tier const):
(JSC::JITPlan::reportCompileTimes const):
* jit/JITPlan.h:
(JSC::JITPlan::isDFG const):
(JSC::JITPlan::isUnlinked const):
* profiler/ProfilerCompilationKind.cpp:
(WTF::printInternal):
* profiler/ProfilerCompilationKind.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
trunk/Source/_javascript_Core/dfg/DFGGraph.cpp
trunk/Source/_javascript_Core/dfg/DFGGraph.h
trunk/Source/_javascript_Core/dfg/DFGPlan.cpp
trunk/Source/_javascript_Core/dfg/DFGTierUpCheckInjectionPhase.cpp
trunk/Source/_javascript_Core/jit/JITCompilationMode.cpp
trunk/Source/_javascript_Core/jit/JITCompilationMode.h
trunk/Source/_javascript_Core/jit/JITPlan.cpp
trunk/Source/_javascript_Core/jit/JITPlan.h
trunk/Source/_javascript_Core/profiler/ProfilerCompilationKind.cpp
trunk/Source/_javascript_Core/profiler/ProfilerCompilationKind.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (291331 => 291332)
--- trunk/Source/_javascript_Core/ChangeLog 2022-03-16 05:19:45 UTC (rev 291331)
+++ trunk/Source/_javascript_Core/ChangeLog 2022-03-16 05:35:12 UTC (rev 291332)
@@ -1,5 +1,46 @@
2022-03-15 Yusuke Suzuki
+[JSC] Add UnlinkedDFG compilation mode enum
+https://bugs.webkit.org/show_bug.cgi?id=237934
+
+Reviewed by Mark Lam.
+
+This patch adds UnlinkedDFG compilation mode to prepare new unlinked DFG.
+
+* dfg/DFGByteCodeParser.cpp:
+(JSC::DFG::ByteCodeParser::inliningCost):
+* dfg/DFGGraph.cpp:
+(JSC::DFG::Graph::watchCondition):
+(JSC::DFG::Graph::watchConditions):
+(JSC::DFG::Graph::watchGlobalProperty):
+(JSC::DFG::Graph::tryGetConstantProperty):
+(JSC::DFG::Graph::tryGetConstantClosureVar):
+(JSC::DFG::Graph::tryGetFoldableView):
+(JSC::DFG::Graph::getRegExpPrototypeProperty):
+(JSC::DFG::Graph::canOptimizeStringObjectAccess):
+(JSC::DFG::Graph::canDoFastSpread):
+* dfg/DFGGraph.h:
+* dfg/DFGPlan.cpp:
+(JSC::DFG::Plan::compileInThreadImpl):
+* dfg/DFGTierUpCheckInjectionPhase.cpp:
+(JSC::DFG::TierUpCheckInjectionPhase::run):
+* jit/JITCompilationMode.cpp:
+(WTF::printInternal):
+* jit/JITCompilationMode.h:
+(JSC::isDFG):
+(JSC::isUnlinked):
+* jit/JITPlan.cpp:
+(JSC::JITPlan::tier const):
+(JSC::JITPlan::reportCompileTimes const):
+* jit/JITPlan.h:
+(JSC::JITPlan::isDFG const):
+(JSC::JITPlan::isUnlinked const):
+* profiler/ProfilerCompilationKind.cpp:
+(WTF::printInternal):
+* profiler/ProfilerCompilationKind.h:
+
+2022-03-15 Yusuke Suzuki
+
[JSC] Concurrent byteOffsetImpl should not assume non-detached array-buffer
https://bugs.webkit.org/show_bug.cgi?id=237935
Modified: trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp (291331 => 291332)
--- trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp 2022-03-16 05:19:45 UTC (rev 291331)
+++ trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp 2022-03-16 05:35:12 UTC (rev 291332)
@@ -1566,6 +1566,11 @@
return UINT_MAX;
}
+if (m_graph.m_plan.isUnlinked()) {
+VERBOSE_LOG("Failing because the compilation mode is unlinked DFG.\n");
+return UINT_MAX;
+}
+
FunctionExecutable* executable = callee.functionExecutable();
if (!executable) {
VERBOSE_LOG("Failing because there is no function executable.\n");
Modified: trunk/Source/_javascript_Core/dfg/DFGGraph.cpp (291331 => 291332)
--- trunk/Source/_javascript_Core/dfg/DFGGraph.cpp 2022-03-16 05:19:45 UTC (rev 291331)
+++ trunk/Source/_javascript_Core/dfg/DFGGraph.cpp 2022-03-16 05:35:12 UTC (rev 291332)
@@ -1061,6 +1061,9 @@
bool Graph::watchCondition(const ObjectPropertyCondition& key)
[webkit-changes] [291331] trunk/Source/JavaScriptCore
Title: [291331] trunk/Source/_javascript_Core
Revision 291331
Author ysuz...@apple.com
Date 2022-03-15 22:19:45 -0700 (Tue, 15 Mar 2022)
Log Message
[JSC] Concurrent byteOffsetImpl should not assume non-detached array-buffer
https://bugs.webkit.org/show_bug.cgi?id=237935
Reviewed by Saam Barati.
r279707 is not enough to fix the issue since underlying ArrayBuffer can be also detached concurrently to
the compiler thread too. This patch fixes it by using dataWithoutPACValidation in the concurrent compiler
thread.
* runtime/ArrayBuffer.h:
(JSC::ArrayBufferContents::dataWithoutPACValidation const):
(JSC::ArrayBuffer::dataWithoutPACValidation):
(JSC::ArrayBuffer::dataWithoutPACValidation const):
* runtime/JSArrayBufferViewInlines.h:
(JSC::JSArrayBufferView::byteOffsetImpl):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/ArrayBuffer.h
trunk/Source/_javascript_Core/runtime/JSArrayBufferViewInlines.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (291330 => 291331)
--- trunk/Source/_javascript_Core/ChangeLog 2022-03-16 04:11:41 UTC (rev 291330)
+++ trunk/Source/_javascript_Core/ChangeLog 2022-03-16 05:19:45 UTC (rev 291331)
@@ -1,3 +1,21 @@
+2022-03-15 Yusuke Suzuki
+
+[JSC] Concurrent byteOffsetImpl should not assume non-detached array-buffer
+https://bugs.webkit.org/show_bug.cgi?id=237935
+
+Reviewed by Saam Barati.
+
+r279707 is not enough to fix the issue since underlying ArrayBuffer can be also detached concurrently to
+the compiler thread too. This patch fixes it by using dataWithoutPACValidation in the concurrent compiler
+thread.
+
+* runtime/ArrayBuffer.h:
+(JSC::ArrayBufferContents::dataWithoutPACValidation const):
+(JSC::ArrayBuffer::dataWithoutPACValidation):
+(JSC::ArrayBuffer::dataWithoutPACValidation const):
+* runtime/JSArrayBufferViewInlines.h:
+(JSC::JSArrayBufferView::byteOffsetImpl):
+
2022-03-14 Adrian Perez de Castro
[GLib] Expose typed arrays in the public API
Modified: trunk/Source/_javascript_Core/runtime/ArrayBuffer.h (291330 => 291331)
--- trunk/Source/_javascript_Core/runtime/ArrayBuffer.h 2022-03-16 04:11:41 UTC (rev 291330)
+++ trunk/Source/_javascript_Core/runtime/ArrayBuffer.h 2022-03-16 05:19:45 UTC (rev 291331)
@@ -88,6 +88,7 @@
explicit operator bool() { return !!m_data; }
void* data() const { return m_data.getMayBeNull(sizeInBytes()); }
+void* dataWithoutPACValidation() const { return m_data.getUnsafe(); }
size_t sizeInBytes() const { return m_sizeInBytes; }
bool isShared() const { return m_shared; }
@@ -136,6 +137,9 @@
inline void* data();
inline const void* data() const;
inline size_t byteLength() const;
+
+inline void* dataWithoutPACValidation();
+inline const void* dataWithoutPACValidation() const;
void makeShared();
void setSharingMode(ArrayBufferSharingMode);
@@ -201,6 +205,16 @@
return m_contents.data();
}
+void* ArrayBuffer::dataWithoutPACValidation()
+{
+return m_contents.dataWithoutPACValidation();
+}
+
+const void* ArrayBuffer::dataWithoutPACValidation() const
+{
+return m_contents.dataWithoutPACValidation();
+}
+
size_t ArrayBuffer::byteLength() const
{
return m_contents.sizeInBytes();
Modified: trunk/Source/_javascript_Core/runtime/JSArrayBufferViewInlines.h (291330 => 291331)
--- trunk/Source/_javascript_Core/runtime/JSArrayBufferViewInlines.h 2022-03-16 04:11:41 UTC (rev 291330)
+++ trunk/Source/_javascript_Core/runtime/JSArrayBufferViewInlines.h 2022-03-16 05:19:45 UTC (rev 291331)
@@ -91,16 +91,21 @@
ArrayBuffer* buffer = possiblySharedBufferImpl();
ASSERT(buffer);
-if (requester == Mutator) {
+ptrdiff_t delta = 0;
+if constexpr (requester == Mutator) {
ASSERT(!isCompilationThread());
ASSERT(!vector() == !buffer->data());
+delta = bitwise_cast(vector()) - static_cast(buffer->data());
+} else {
+uint8_t* vector = bitwise_cast(vectorWithoutPACValidation());
+uint8_t* data = ""
+if (!vector || !data)
+return 0;
+delta = vector - data;
}
-ptrdiff_t delta =
-bitwise_cast(vectorWithoutPACValidation()) - static_cast(buffer->data());
-
size_t result = static_cast(delta);
-if (requester == Mutator)
+if constexpr (requester == Mutator)
ASSERT(static_cast(result) == delta);
else {
if (static_cast(result) != delta)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291330] trunk
Title: [291330] trunk
Revision 291330
Author za...@apple.com
Date 2022-03-15 21:11:41 -0700 (Tue, 15 Mar 2022)
Log Message
REGRESSION (r282737): `text-shadow` is clipped
https://bugs.webkit.org/show_bug.cgi?id=237898
Reviewed by Darin Adler.
Source/WebCore:
Inflate the ink overflow rect with the text shadow values (note that here, in the display builder we work with physical coordinates).
Test: fast/text/text-shadow-ink-overflow-missing.html
* layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::appendTextDisplayBox):
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::getTextShadowHorizontalExtent const):
(WebCore::RenderStyle::getTextShadowVerticalExtent const):
LayoutTests:
* fast/text/text-shadow-ink-overflow-missing-expected.html: Added.
* fast/text/text-shadow-ink-overflow-missing.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
trunk/Source/WebCore/rendering/style/RenderStyle.h
Added Paths
trunk/LayoutTests/fast/text/text-shadow-ink-overflow-missing-expected.html
trunk/LayoutTests/fast/text/text-shadow-ink-overflow-missing.html
Diff
Modified: trunk/LayoutTests/ChangeLog (291329 => 291330)
--- trunk/LayoutTests/ChangeLog 2022-03-16 04:06:29 UTC (rev 291329)
+++ trunk/LayoutTests/ChangeLog 2022-03-16 04:11:41 UTC (rev 291330)
@@ -1,3 +1,14 @@
+2022-03-15 Alan Bujtas
+
+REGRESSION (r282737): `text-shadow` is clipped
+https://bugs.webkit.org/show_bug.cgi?id=237898
+
+
+Reviewed by Darin Adler.
+
+* fast/text/text-shadow-ink-overflow-missing-expected.html: Added.
+* fast/text/text-shadow-ink-overflow-missing.html: Added.
+
2022-03-15 Jean-Yves Avenard
REGRESSION(r287249): [ Monterey wk2 ] media/media-source/media-webm-vorbis-partial.html is a constant text failure
Added: trunk/LayoutTests/fast/text/text-shadow-ink-overflow-missing-expected.html (0 => 291330)
--- trunk/LayoutTests/fast/text/text-shadow-ink-overflow-missing-expected.html (rev 0)
+++ trunk/LayoutTests/fast/text/text-shadow-ink-overflow-missing-expected.html 2022-03-16 04:11:41 UTC (rev 291330)
@@ -0,0 +1,9 @@
+
+div {
+ font-size: 20px;
+ text-shadow: 0px 100px 1px black;
+ font-family: Ahem;
+ will-change: transform;
+}
+
+PASS if this line is doubled.
Added: trunk/LayoutTests/fast/text/text-shadow-ink-overflow-missing.html (0 => 291330)
--- trunk/LayoutTests/fast/text/text-shadow-ink-overflow-missing.html (rev 0)
+++ trunk/LayoutTests/fast/text/text-shadow-ink-overflow-missing.html 2022-03-16 04:11:41 UTC (rev 291330)
@@ -0,0 +1,26 @@
+
+.wrapper {
+ position: relative;
+ font-family: Ahem;
+}
+
+.shadow {
+ position: relative;
+ z-index: 1;
+ font-size: 20px;
+ text-shadow: 0px 100px 1px black;
+}
+
+.absolute {
+ position: absolute;
+ left: 0;
+ top: 0;
+ will-change: transform;
+}
+
+
+
+ PASS if this line is doubled.
+
+
+
Modified: trunk/Source/WebCore/ChangeLog (291329 => 291330)
--- trunk/Source/WebCore/ChangeLog 2022-03-16 04:06:29 UTC (rev 291329)
+++ trunk/Source/WebCore/ChangeLog 2022-03-16 04:11:41 UTC (rev 291330)
@@ -1,3 +1,21 @@
+2022-03-15 Alan Bujtas
+
+REGRESSION (r282737): `text-shadow` is clipped
+https://bugs.webkit.org/show_bug.cgi?id=237898
+
+
+Reviewed by Darin Adler.
+
+Inflate the ink overflow rect with the text shadow values (note that here, in the display builder we work with physical coordinates).
+
+Test: fast/text/text-shadow-ink-overflow-missing.html
+
+* layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
+(WebCore::Layout::InlineDisplayContentBuilder::appendTextDisplayBox):
+* rendering/style/RenderStyle.h:
+(WebCore::RenderStyle::getTextShadowHorizontalExtent const):
+(WebCore::RenderStyle::getTextShadowVerticalExtent const):
+
2022-03-15 Diego Pino Garcia
[GLIB] REGRESSION(r291257): Unreviewed, fix build when using ATK
Modified: trunk/Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp (291329 => 291330)
--- trunk/Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp 2022-03-16 04:06:29 UTC (rev 291329)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp 2022-03-16 04:11:41 UTC (rev 291330)
@@ -135,6 +135,7 @@
: formattingState().layoutState().geometryForBox(layoutBox.initialContainingBlock()).contentBox().size();
auto strokeOverflow = ceilf(style.computedStrokeWidth(ceiledIntSize(initialContaingBlockSize)));
auto inkOverflow = textRunRect;
+
inkOverflow.inflate(strokeOverflow);
auto letterSpacing = style.fontCascade().letterSpacing();
[webkit-changes] [291329] trunk/Source/WebCore
Title: [291329] trunk/Source/WebCore Revision 291329 Author dp...@igalia.com Date 2022-03-15 21:06:29 -0700 (Tue, 15 Mar 2022) Log Message [GLIB] REGRESSION(r291257): Unreviewed, fix build when using ATK https://bugs.webkit.org/show_bug.cgi?id=237939 r291257 renamed RenderStyle::textDecoration() to RenderStyle::textDecorationLine() in the ATSPI module, but it missed to do the same for the ATK module. ATK is still in use when building with flag -DUSE_ATSPI=OFF, which is used by Ubuntu 18.04 and Debian Stable bots. * accessibility/atk/WebKitAccessibleInterfaceText.cpp: (getAttributeSetForAccessibilityObject): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (291328 => 291329) --- trunk/Source/WebCore/ChangeLog 2022-03-16 03:51:02 UTC (rev 291328) +++ trunk/Source/WebCore/ChangeLog 2022-03-16 04:06:29 UTC (rev 291329) @@ -1,3 +1,18 @@ +2022-03-15 Diego Pino Garcia + +[GLIB] REGRESSION(r291257): Unreviewed, fix build when using ATK +https://bugs.webkit.org/show_bug.cgi?id=237939 + +r291257 renamed RenderStyle::textDecoration() to +RenderStyle::textDecorationLine() in the ATSPI module, but it missed +to do the same for the ATK module. + +ATK is still in use when building with flag -DUSE_ATSPI=OFF, which is +used by Ubuntu 18.04 and Debian Stable bots. + +* accessibility/atk/WebKitAccessibleInterfaceText.cpp: +(getAttributeSetForAccessibilityObject): + 2022-03-15 Eric Carlson Video poster disappears prematurely on play, leaving transparent video element. Modified: trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp (291328 => 291329) --- trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp 2022-03-16 03:51:02 UTC (rev 291328) +++ trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp 2022-03-16 04:06:29 UTC (rev 291329) @@ -164,11 +164,11 @@ result = addToAtkAttributeSet(result, atk_text_attribute_get_name(ATK_TEXT_ATTR_JUSTIFICATION), "fill"); } -result = addToAtkAttributeSet(result, atk_text_attribute_get_name(ATK_TEXT_ATTR_UNDERLINE), (style->textDecoration() & TextDecorationLine::Underline) ? "single" : "none"); +result = addToAtkAttributeSet(result, atk_text_attribute_get_name(ATK_TEXT_ATTR_UNDERLINE), (style->textDecorationLine() & TextDecorationLine::Underline) ? "single" : "none"); result = addToAtkAttributeSet(result, atk_text_attribute_get_name(ATK_TEXT_ATTR_STYLE), style->fontCascade().italic() ? "italic" : "normal"); -result = addToAtkAttributeSet(result, atk_text_attribute_get_name(ATK_TEXT_ATTR_STRIKETHROUGH), (style->textDecoration() & TextDecorationLine::LineThrough) ? "true" : "false"); +result = addToAtkAttributeSet(result, atk_text_attribute_get_name(ATK_TEXT_ATTR_STRIKETHROUGH), (style->textDecorationLine() & TextDecorationLine::LineThrough) ? "true" : "false"); result = addToAtkAttributeSet(result, atk_text_attribute_get_name(ATK_TEXT_ATTR_INVISIBLE), (style->visibility() == Visibility::Hidden) ? "true" : "false"); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291328] trunk/Source/bmalloc
Title: [291328] trunk/Source/bmalloc
Revision 291328
Author mark@apple.com
Date 2022-03-15 20:51:02 -0700 (Tue, 15 Mar 2022)
Log Message
Remove unused directory local variable in pas_enumerate_segregated_heaps.
https://bugs.webkit.org/show_bug.cgi?id=237931
Reviewed by Geoffrey Garen.
Also remove the call to pas_unwrap_local_view_cache_node(). It doesn't add any
value. The only thing of substance that it does is a PAS_ASSERT that turns out to
be redundant because pas_enumerate_segregated_heaps() already asserts the same
thing before calling pas_unwrap_local_view_cache_node().
* libpas/src/libpas/pas_enumerate_segregated_heaps.c:
(pas_enumerate_segregated_heaps):
Modified Paths
trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/libpas/src/libpas/pas_enumerate_segregated_heaps.c
Diff
Modified: trunk/Source/bmalloc/ChangeLog (291327 => 291328)
--- trunk/Source/bmalloc/ChangeLog 2022-03-16 03:25:52 UTC (rev 291327)
+++ trunk/Source/bmalloc/ChangeLog 2022-03-16 03:51:02 UTC (rev 291328)
@@ -1,3 +1,18 @@
+2022-03-15 Mark Lam
+
+Remove unused directory local variable in pas_enumerate_segregated_heaps.
+https://bugs.webkit.org/show_bug.cgi?id=237931
+
+Reviewed by Geoffrey Garen.
+
+Also remove the call to pas_unwrap_local_view_cache_node(). It doesn't add any
+value. The only thing of substance that it does is a PAS_ASSERT that turns out to
+be redundant because pas_enumerate_segregated_heaps() already asserts the same
+thing before calling pas_unwrap_local_view_cache_node().
+
+* libpas/src/libpas/pas_enumerate_segregated_heaps.c:
+(pas_enumerate_segregated_heaps):
+
2022-03-14 Elliott Williams
bmalloc.xcodeproj: Remove duplicate file reference
Modified: trunk/Source/bmalloc/libpas/src/libpas/pas_enumerate_segregated_heaps.c (291327 => 291328)
--- trunk/Source/bmalloc/libpas/src/libpas/pas_enumerate_segregated_heaps.c 2022-03-16 03:25:52 UTC (rev 291327)
+++ trunk/Source/bmalloc/libpas/src/libpas/pas_enumerate_segregated_heaps.c 2022-03-16 03:51:02 UTC (rev 291328)
@@ -728,12 +728,7 @@
allocator_index = redundant_node->allocator_index;
has_allocator = true;
} else {
-pas_segregated_size_directory* directory;
-
PAS_ASSERT_WITH_DETAIL(pas_is_wrapped_local_view_cache_node(layout_node));
-
-directory = pas_unwrap_local_view_cache_node(layout_node);
-
allocator_index = 0;
has_allocator = false;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291327] trunk/Tools
Title: [291327] trunk/Tools Revision 291327 Author dp...@igalia.com Date 2022-03-15 20:25:52 -0700 (Tue, 15 Mar 2022) Log Message [GLIB] Unreviewed, fix build for Ubuntu 18.04 and Debian Stable after r291229 https://bugs.webkit.org/show_bug.cgi?id=237938 * TestWebKitAPI/Tests/_javascript_Core/glib/TestJSC.cpp: (elementSize): Modified Paths trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/_javascript_Core/glib/TestJSC.cpp Diff Modified: trunk/Tools/ChangeLog (291326 => 291327) --- trunk/Tools/ChangeLog 2022-03-16 03:21:32 UTC (rev 291326) +++ trunk/Tools/ChangeLog 2022-03-16 03:25:52 UTC (rev 291327) @@ -1,3 +1,11 @@ +2022-03-15 Diego Pino Garcia + +[GLIB] Unreviewed, fix build for Ubuntu 18.04 and Debian Stable after r291229 +https://bugs.webkit.org/show_bug.cgi?id=237938 + +* TestWebKitAPI/Tests/_javascript_Core/glib/TestJSC.cpp: +(elementSize): + 2022-03-15 Saam Barati Add support for chrome-beta and chrome-dev to run-benchmark Modified: trunk/Tools/TestWebKitAPI/Tests/_javascript_Core/glib/TestJSC.cpp (291326 => 291327) --- trunk/Tools/TestWebKitAPI/Tests/_javascript_Core/glib/TestJSC.cpp 2022-03-16 03:21:32 UTC (rev 291326) +++ trunk/Tools/TestWebKitAPI/Tests/_javascript_Core/glib/TestJSC.cpp 2022-03-16 03:25:52 UTC (rev 291327) @@ -2986,8 +2986,9 @@ case JSC_TYPED_ARRAY_FLOAT32: return sizeof(float); case JSC_TYPED_ARRAY_FLOAT64: return sizeof(double); case JSC_TYPED_ARRAY_NONE: break; +default: +RELEASE_ASSERT_NOT_REACHED(); } -RELEASE_ASSERT_NOT_REACHED(); } void testJSCTypedArray() ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291326] trunk/Source
Title: [291326] trunk/Source Revision 291326 Author eric.carl...@apple.com Date 2022-03-15 20:21:32 -0700 (Tue, 15 Mar 2022) Log Message Video poster disappears prematurely on play, leaving transparent video element. https://bugs.webkit.org/show_bug.cgi?id=226960 Reviewed by Jer Noble. Source/WebCore: If a media file has an enabled video track, don't advance readyState to HAVE_ENOUGH_DATA until we have the first frame so we won't hide the poster image until AVFoundation has something to render. Tested manually. * html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::mediaPlayerFirstVideoFrameAvailable): Always log. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::updateStates): Move the test for the first video frame above the player item status check. If a file has a video track, don't advance to HAVE_ENOUGH_DATA unless we have the first video frame. * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h: * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad): Clear m_cachedHasEnabledVideo. (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerLayer): Remove unneeded local variable. (WebCore::MediaPlayerPrivateAVFoundationObjC::platformSetVisible): Minro cleanup. (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Set `hasVideo` if AVPlayerItem.hasEnabledVideo is true, because it remains stable while AVAssetTracks sometimes disappear and reappear. (WebCore::MediaPlayerPrivateAVFoundationObjC::firstFrameAvailableDidChange): Add logging. (WebCore::MediaPlayerPrivateAVFoundationObjC::hasEnabledAudioDidChange): Ditto (WebCore::MediaPlayerPrivateAVFoundationObjC::hasEnabledVideoDidChange): New, cache AVPlayerItem.hasEnabledVideo. (WebCore::itemKVOProperties): (-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]): Respond to @"hasEnabledVideo". * platform/graphics/avfoundation/objc/VideoLayerManagerObjC.h: Source/WebKit: * WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp: (WebKit::MediaPlayerPrivateRemote::MediaPlayerPrivateRemote): Always log. (WebKit::MediaPlayerPrivateRemote::~MediaPlayerPrivateRemote): Ditto. (WebKit::MediaPlayerPrivateRemote::prepareForPlayback): Pass the player's content rect box to createVideoLayerRemote so it can be sized correctly even before it becomes visible. (WebKit::MediaPlayerPrivateRemote::firstVideoFrameAvailable): Always log. (WebKit::MediaPlayerPrivateRemote::renderingModeChanged): Ditto. * WebProcess/GPU/media/VideoLayerRemote.h: * WebProcess/GPU/media/cocoa/VideoLayerRemoteCocoa.mm: (WebKit::createVideoLayerRemote): Set the new layer's frame so its children will be positioned correctly when the are made visible. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLVideoElement.cpp trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm trunk/Source/WebCore/platform/graphics/avfoundation/objc/VideoLayerManagerObjC.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp trunk/Source/WebKit/WebProcess/GPU/media/VideoLayerRemote.h trunk/Source/WebKit/WebProcess/GPU/media/cocoa/VideoLayerRemoteCocoa.mm trunk/Source/WebKit/WebProcess/GPU/media/gstreamer/VideoLayerRemoteGStreamer.cpp trunk/Source/WebKit/WebProcess/GPU/media/playstation/VideoLayerRemotePlayStation.cpp trunk/Source/WebKit/WebProcess/GPU/media/win/VideoLayerRemoteWin.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (291325 => 291326) --- trunk/Source/WebCore/ChangeLog 2022-03-16 02:35:33 UTC (rev 291325) +++ trunk/Source/WebCore/ChangeLog 2022-03-16 03:21:32 UTC (rev 291326) @@ -1,3 +1,43 @@ +2022-03-15 Eric Carlson + +Video poster disappears prematurely on play, leaving transparent video element. +https://bugs.webkit.org/show_bug.cgi?id=226960 + + +Reviewed by Jer Noble. + +If a media file has an enabled video track, don't advance readyState to +HAVE_ENOUGH_DATA until we have the first frame so we won't hide the poster image +until AVFoundation has something to render. + +Tested manually. + +* html/HTMLVideoElement.cpp: +(WebCore::HTMLVideoElement::mediaPlayerFirstVideoFrameAvailable): Always log. + +* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: +(WebCore::MediaPlayerPrivateAVFoundation::updateStates): Move the test for the +first video frame above the player item status check. If a file has a video track, +don't advance to HAVE_ENOUGH_DATA unless we have the first video frame. + +* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h: +
[webkit-changes] [291325] trunk/Tools
Title: [291325] trunk/Tools Revision 291325 Author sbar...@apple.com Date 2022-03-15 19:35:33 -0700 (Tue, 15 Mar 2022) Log Message Add support for chrome-beta and chrome-dev to run-benchmark https://bugs.webkit.org/show_bug.cgi?id=237937 Reviewed by Stephanie Lewis. * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: (set_binary_location_impl): (OSXChromeDriver._set_chrome_binary_location): (OSXChromeCanaryDriver): (OSXChromeCanaryDriver._set_chrome_binary_location): (OSXChromeBetaDriver): (OSXChromeBetaDriver._set_chrome_binary_location): (OSXChromeDevDriver): (OSXChromeDevDriver._set_chrome_binary_location): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py Diff Modified: trunk/Tools/ChangeLog (291324 => 291325) --- trunk/Tools/ChangeLog 2022-03-16 00:51:40 UTC (rev 291324) +++ trunk/Tools/ChangeLog 2022-03-16 02:35:33 UTC (rev 291325) @@ -1,3 +1,20 @@ +2022-03-15 Saam Barati + +Add support for chrome-beta and chrome-dev to run-benchmark +https://bugs.webkit.org/show_bug.cgi?id=237937 + +Reviewed by Stephanie Lewis. + +* Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: +(set_binary_location_impl): +(OSXChromeDriver._set_chrome_binary_location): +(OSXChromeCanaryDriver): +(OSXChromeCanaryDriver._set_chrome_binary_location): +(OSXChromeBetaDriver): +(OSXChromeBetaDriver._set_chrome_binary_location): +(OSXChromeDevDriver): +(OSXChromeDevDriver._set_chrome_binary_location): + 2022-03-15 Jonathan Bedard [Merge-Queue] Rename bugzilla_comment_text Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py (291324 => 291325) --- trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py 2022-03-16 00:51:40 UTC (rev 291324) +++ trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py 2022-03-16 02:35:33 UTC (rev 291325) @@ -41,7 +41,14 @@ def _set_chrome_binary_location(self, options, browser_build_path): pass +def set_binary_location_impl(options, browser_build_path, app_name, process_name): +if not browser_build_path: +return +app_path = os.path.join(browser_build_path, app_name) +binary_path = os.path.join(app_path, "Contents/MacOS", process_name) +options.binary_location = binary_path + class OSXChromeDriver(OSXChromeDriverBase): process_name = 'Google Chrome' browser_name = 'chrome' @@ -49,14 +56,10 @@ bundle_id = 'com.google.Chrome' def _set_chrome_binary_location(self, options, browser_build_path): -if not browser_build_path: -return -app_path = os.path.join(browser_build_path, self.app_name) -binary_path = os.path.join(app_path, "Contents/MacOS", self.process_name) -options.binary_location = binary_path +set_binary_location_impl(options, browser_build_path, self.app_name, self.process_name) -class OSXChromeCanaryDriver(OSXBrowserDriver): +class OSXChromeCanaryDriver(OSXChromeDriverBase): process_name = 'Google Chrome Canary' browser_name = 'chrome-canary' app_name = 'Google Chrome Canary.app' @@ -63,8 +66,23 @@ bundle_id = 'com.google.Chrome.canary' def _set_chrome_binary_location(self, options, browser_build_path): -if not browser_build_path: -browser_build_path = '/Applications/' -app_path = os.path.join(browser_build_path, self.app_name) -binary_path = os.path.join(app_path, "Contents/MacOS", self.process_name) -options.binary_location = binary_path +set_binary_location_impl(options, browser_build_path, self.app_name, self.process_name) + + +class OSXChromeBetaDriver(OSXChromeDriverBase): +process_name = 'Google Chrome Beta' +browser_name = 'chrome-beta' +app_name = 'Google Chrome Beta.app' +bundle_id = 'com.google.Chrome.beta' + +def _set_chrome_binary_location(self, options, browser_build_path): +set_binary_location_impl(options, browser_build_path, self.app_name, self.process_name) + +class OSXChromeDevDriver(OSXChromeDriverBase): +process_name = 'Google Chrome Dev' +browser_name = 'chrome-dev' +app_name = 'Google Chrome Dev.app' +bundle_id = 'com.google.Chrome.dev' + +def _set_chrome_binary_location(self, options, browser_build_path): +set_binary_location_impl(options, browser_build_path, self.app_name, self.process_name) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291324] trunk/Source/WebCore
Title: [291324] trunk/Source/WebCore
Revision 291324
Author pvol...@apple.com
Date 2022-03-15 17:51:40 -0700 (Tue, 15 Mar 2022)
Log Message
Crash under HTMLDocumentParser::didBeginYieldingParser()
https://bugs.webkit.org/show_bug.cgi?id=237930
Reviewed by Geoffrey Garen.
Add null pointer check.
No new tests, unable to reproduce.
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::didBeginYieldingParser):
(WebCore::HTMLDocumentParser::didEndYieldingParser):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (291323 => 291324)
--- trunk/Source/WebCore/ChangeLog 2022-03-15 23:44:09 UTC (rev 291323)
+++ trunk/Source/WebCore/ChangeLog 2022-03-16 00:51:40 UTC (rev 291324)
@@ -1,3 +1,19 @@
+2022-03-15 Per Arne Vollan
+
+Crash under HTMLDocumentParser::didBeginYieldingParser()
+https://bugs.webkit.org/show_bug.cgi?id=237930
+
+
+Reviewed by Geoffrey Garen.
+
+Add null pointer check.
+
+No new tests, unable to reproduce.
+
+* html/parser/HTMLDocumentParser.cpp:
+(WebCore::HTMLDocumentParser::didBeginYieldingParser):
+(WebCore::HTMLDocumentParser::didEndYieldingParser):
+
2022-03-15 Sihui Liu
Add RELEASE_LOG_FAULT to ApplicationCache entry function
Modified: trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp (291323 => 291324)
--- trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp 2022-03-15 23:44:09 UTC (rev 291323)
+++ trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp 2022-03-16 00:51:40 UTC (rev 291324)
@@ -161,12 +161,14 @@
void HTMLDocumentParser::didBeginYieldingParser()
{
-m_parserScheduler->didBeginYieldingParser();
+if (m_parserScheduler)
+m_parserScheduler->didBeginYieldingParser();
}
void HTMLDocumentParser::didEndYieldingParser()
{
-m_parserScheduler->didEndYieldingParser();
+if (m_parserScheduler)
+m_parserScheduler->didEndYieldingParser();
}
bool HTMLDocumentParser::isParsingFragment() const
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291323] trunk/Source
Title: [291323] trunk/Source Revision 291323 Author mmaxfi...@apple.com Date 2022-03-15 16:44:09 -0700 (Tue, 15 Mar 2022) Log Message [WebGPU] Migrate from WTF::Function to WTF::CompletionHandler https://bugs.webkit.org/show_bug.cgi?id=237925 Reviewed by Geoffrey Garen. Source/WebCore/PAL: CompletionHandlers make sure they are called exactly 1 time, and eagerly free up resources. There are still 2 places which continue to use Functions, becuase they are expected to be called multiple times: - Device::setDeviceLostCallback() - Device::setUncapturedErrorCallback() * pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.cpp: (PAL::WebGPU::AdapterImpl::requestDevice): * pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.h: * pal/graphics/WebGPU/Impl/WebGPUBufferImpl.cpp: (PAL::WebGPU::BufferImpl::mapAsync): * pal/graphics/WebGPU/Impl/WebGPUBufferImpl.h: * pal/graphics/WebGPU/Impl/WebGPUDeviceImpl.cpp: (PAL::WebGPU::DeviceImpl::createComputePipelineAsync): (PAL::WebGPU::DeviceImpl::createRenderPipelineAsync): (PAL::WebGPU::DeviceImpl::popErrorScope): * pal/graphics/WebGPU/Impl/WebGPUDeviceImpl.h: * pal/graphics/WebGPU/Impl/WebGPUImpl.cpp: (PAL::WebGPU::GPUImpl::requestAdapter): * pal/graphics/WebGPU/Impl/WebGPUImpl.h: * pal/graphics/WebGPU/Impl/WebGPUQueueImpl.cpp: (PAL::WebGPU::QueueImpl::onSubmittedWorkDone): * pal/graphics/WebGPU/Impl/WebGPUQueueImpl.h: * pal/graphics/WebGPU/Impl/WebGPUShaderModuleImpl.cpp: (PAL::WebGPU::ShaderModuleImpl::compilationInfo): * pal/graphics/WebGPU/Impl/WebGPUShaderModuleImpl.h: * pal/graphics/WebGPU/WebGPU.h: * pal/graphics/WebGPU/WebGPUAdapter.h: * pal/graphics/WebGPU/WebGPUBuffer.h: * pal/graphics/WebGPU/WebGPUDevice.h: * pal/graphics/WebGPU/WebGPUQueue.h: * pal/graphics/WebGPU/WebGPUShaderModule.h: Source/WebGPU: * WebGPU/Adapter.h: * WebGPU/Adapter.mm: (WebGPU::Adapter::requestDevice): * WebGPU/Buffer.h: * WebGPU/Buffer.mm: (WebGPU::Buffer::mapAsync): * WebGPU/ComputePipeline.mm: (WebGPU::Device::createComputePipelineAsync): * WebGPU/Device.h: * WebGPU/Device.mm: (WebGPU::Device::popErrorScope): (WebGPU::Device::setDeviceLostCallback): (WebGPU::Device::setUncapturedErrorCallback): * WebGPU/Instance.h: * WebGPU/Instance.mm: (WebGPU::Instance::requestAdapter): * WebGPU/Queue.h: * WebGPU/Queue.mm: (WebGPU::Queue::onSubmittedWorkDone): * WebGPU/RenderPassEncoder.h: * WebGPU/RenderPipeline.mm: (WebGPU::Device::createRenderPipelineAsync): * WebGPU/ShaderModule.h: * WebGPU/ShaderModule.mm: (WebGPU::ShaderModule::getCompilationInfo): Source/WebKit: * GPUProcess/graphics/WebGPU/RemoteAdapter.cpp: (WebKit::RemoteAdapter::requestDevice): * GPUProcess/graphics/WebGPU/RemoteAdapter.h: * GPUProcess/graphics/WebGPU/RemoteBuffer.cpp: (WebKit::RemoteBuffer::mapAsync): * GPUProcess/graphics/WebGPU/RemoteBuffer.h: * GPUProcess/graphics/WebGPU/RemoteDevice.cpp: (WebKit::RemoteDevice::createComputePipelineAsync): (WebKit::RemoteDevice::createRenderPipelineAsync): (WebKit::RemoteDevice::popErrorScope): * GPUProcess/graphics/WebGPU/RemoteDevice.h: * GPUProcess/graphics/WebGPU/RemoteGPU.cpp: (WebKit::RemoteGPU::requestAdapter): * GPUProcess/graphics/WebGPU/RemoteGPU.h: * GPUProcess/graphics/WebGPU/RemoteQueue.cpp: (WebKit::RemoteQueue::onSubmittedWorkDone): * GPUProcess/graphics/WebGPU/RemoteQueue.h: * GPUProcess/graphics/WebGPU/RemoteShaderModule.cpp: (WebKit::RemoteShaderModule::compilationInfo): * GPUProcess/graphics/WebGPU/RemoteShaderModule.h: * WebProcess/GPU/graphics/WebGPU/RemoteAdapterProxy.cpp: (WebKit::WebGPU::RemoteAdapterProxy::requestDevice): * WebProcess/GPU/graphics/WebGPU/RemoteAdapterProxy.h: * WebProcess/GPU/graphics/WebGPU/RemoteBufferProxy.cpp: (WebKit::WebGPU::RemoteBufferProxy::mapAsync): * WebProcess/GPU/graphics/WebGPU/RemoteBufferProxy.h: * WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.cpp: (WebKit::WebGPU::RemoteDeviceProxy::createComputePipelineAsync): (WebKit::WebGPU::RemoteDeviceProxy::createRenderPipelineAsync): (WebKit::WebGPU::RemoteDeviceProxy::popErrorScope): * WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.h: * WebProcess/GPU/graphics/WebGPU/RemoteGPUProxy.cpp: (WebKit::RemoteGPUProxy::requestAdapter): * WebProcess/GPU/graphics/WebGPU/RemoteGPUProxy.h: * WebProcess/GPU/graphics/WebGPU/RemoteQueueProxy.cpp: (WebKit::WebGPU::RemoteQueueProxy::onSubmittedWorkDone): * WebProcess/GPU/graphics/WebGPU/RemoteQueueProxy.h: * WebProcess/GPU/graphics/WebGPU/RemoteShaderModuleProxy.cpp: (WebKit::WebGPU::RemoteShaderModuleProxy::compilationInfo): * WebProcess/GPU/graphics/WebGPU/RemoteShaderModuleProxy.h: Modified Paths trunk/Source/WebCore/PAL/ChangeLog trunk/Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.cpp trunk/Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.h trunk/Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUBufferImpl.cpp trunk/Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUBufferImpl.h trunk/Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUDeviceImpl.cpp
[webkit-changes] [291322] trunk/Source/WebCore
Title: [291322] trunk/Source/WebCore
Revision 291322
Author sihui_...@apple.com
Date 2022-03-15 16:40:34 -0700 (Tue, 15 Mar 2022)
Log Message
Add RELEASE_LOG_FAULT to ApplicationCache entry function
https://bugs.webkit.org/show_bug.cgi?id=237866
Reviewed by Alex Christensen.
To help learn remaining ApplicationCache usage.
* html/HTMLHtmlElement.cpp:
(WebCore::HTMLHtmlElement::insertedByParser):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLHtmlElement.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (291321 => 291322)
--- trunk/Source/WebCore/ChangeLog 2022-03-15 23:23:54 UTC (rev 291321)
+++ trunk/Source/WebCore/ChangeLog 2022-03-15 23:40:34 UTC (rev 291322)
@@ -1,3 +1,15 @@
+2022-03-15 Sihui Liu
+
+Add RELEASE_LOG_FAULT to ApplicationCache entry function
+https://bugs.webkit.org/show_bug.cgi?id=237866
+
+Reviewed by Alex Christensen.
+
+To help learn remaining ApplicationCache usage.
+
+* html/HTMLHtmlElement.cpp:
+(WebCore::HTMLHtmlElement::insertedByParser):
+
2022-03-15 Chris Dumez
Make it clearer in the loading logging when it is for the main frame or not
Modified: trunk/Source/WebCore/html/HTMLHtmlElement.cpp (291321 => 291322)
--- trunk/Source/WebCore/html/HTMLHtmlElement.cpp 2022-03-15 23:23:54 UTC (rev 291321)
+++ trunk/Source/WebCore/html/HTMLHtmlElement.cpp 2022-03-15 23:40:34 UTC (rev 291322)
@@ -32,6 +32,7 @@
#include "Frame.h"
#include "FrameLoader.h"
#include "HTMLNames.h"
+#include "Logging.h"
#include
namespace WebCore {
@@ -78,6 +79,7 @@
if (manifest.isEmpty())
documentLoader->applicationCacheHost().selectCacheWithoutManifest();
else {
+RELEASE_LOG_FAULT(Storage, "HTMLHtmlElement::insertedByParser: ApplicationCache is deprecated.");
document().addConsoleMessage(MessageSource::AppCache, MessageLevel::Warning, "ApplicationCache is deprecated. Please use ServiceWorkers instead."_s);
documentLoader->applicationCacheHost().selectCacheWithManifest(document().completeURL(manifest));
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291321] trunk/Source/WebKit
Title: [291321] trunk/Source/WebKit
Revision 291321
Author j_pas...@apple.com
Date 2022-03-15 16:23:54 -0700 (Tue, 15 Mar 2022)
Log Message
[WebAuthn] Mock UI interactions whenever virtual authenticators are in use.
https://bugs.webkit.org/show_bug.cgi?id=237856
rdar://problem/90274854
Reviewed by Brent Fulgham.
Tested by wpt's webauthn tests.
* UIProcess/WebAuthentication/AuthenticatorManager.h:
* UIProcess/WebAuthentication/Virtual/VirtualAuthenticatorManager.cpp:
(WebKit::VirtualAuthenticatorManager::runPanel):
(WebKit::VirtualAuthenticatorManager::selectAssertionResponse):
(WebKit::VirtualAuthenticatorManager::decidePolicyForLocalAuthenticator):
* UIProcess/WebAuthentication/Virtual/VirtualAuthenticatorManager.h:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.h
trunk/Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualAuthenticatorManager.cpp
trunk/Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualAuthenticatorManager.h
Diff
Modified: trunk/Source/WebKit/ChangeLog (291320 => 291321)
--- trunk/Source/WebKit/ChangeLog 2022-03-15 23:16:02 UTC (rev 291320)
+++ trunk/Source/WebKit/ChangeLog 2022-03-15 23:23:54 UTC (rev 291321)
@@ -1,3 +1,20 @@
+2022-03-15 J Pascoe
+
+[WebAuthn] Mock UI interactions whenever virtual authenticators are in use.
+https://bugs.webkit.org/show_bug.cgi?id=237856
+rdar://problem/90274854
+
+Reviewed by Brent Fulgham.
+
+Tested by wpt's webauthn tests.
+
+* UIProcess/WebAuthentication/AuthenticatorManager.h:
+* UIProcess/WebAuthentication/Virtual/VirtualAuthenticatorManager.cpp:
+(WebKit::VirtualAuthenticatorManager::runPanel):
+(WebKit::VirtualAuthenticatorManager::selectAssertionResponse):
+(WebKit::VirtualAuthenticatorManager::decidePolicyForLocalAuthenticator):
+* UIProcess/WebAuthentication/Virtual/VirtualAuthenticatorManager.h:
+
2022-03-15 Chris Dumez
Make it clearer in the loading logging when it is for the main frame or not
Modified: trunk/Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.h (291320 => 291321)
--- trunk/Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.h 2022-03-15 23:16:02 UTC (rev 291320)
+++ trunk/Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.h 2022-03-15 23:23:54 UTC (rev 291321)
@@ -80,6 +80,12 @@
void clearState();
void invokePendingCompletionHandler(Respond&&);
+void decidePolicyForLocalAuthenticator(CompletionHandler&&);
+TransportSet getTransports() const;
+virtual void runPanel();
+void selectAssertionResponse(Vector>&&, WebAuthenticationSource, CompletionHandler&&);
+void startDiscovery(const TransportSet&);
+
private:
enum class Mode {
Compatible,
@@ -96,8 +102,6 @@
void downgrade(Authenticator* id, Ref&& downgradedAuthenticator) final;
void authenticatorStatusUpdated(WebAuthenticationStatus) final;
void requestPin(uint64_t retries, CompletionHandler&&) final;
-void selectAssertionResponse(Vector>&&, WebAuthenticationSource, CompletionHandler&&) final;
-void decidePolicyForLocalAuthenticator(CompletionHandler&&) final;
void requestLAContextForUserVerification(CompletionHandler&&) final;
void cancelRequest() final;
@@ -108,13 +112,10 @@
virtual void filterTransports(TransportSet&) const;
virtual void runPresenterInternal(const TransportSet&);
-void startDiscovery(const TransportSet&);
void initTimeOutTimer();
void timeOutTimerFired();
-void runPanel();
void runPresenter();
void restartDiscovery();
-TransportSet getTransports() const;
void dispatchPanelClientCall(Function&&) const;
// Request: We only allow one request per time. A new request will cancel any pending ones.
Modified: trunk/Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualAuthenticatorManager.cpp (291320 => 291321)
--- trunk/Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualAuthenticatorManager.cpp 2022-03-15 23:16:02 UTC (rev 291320)
+++ trunk/Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualAuthenticatorManager.cpp 2022-03-15 23:23:54 UTC (rev 291321)
@@ -63,6 +63,27 @@
return VirtualService::createVirtual(transport, observer, configs);
}
+void VirtualAuthenticatorManager::runPanel()
+{
+auto transports = getTransports();
+if (transports.isEmpty()) {
+cancel();
+return;
+}
+
+startDiscovery(transports);
+}
+
+void VirtualAuthenticatorManager::selectAssertionResponse(Vector>&& responses, WebAuthenticationSource source, CompletionHandler&& completionHandler)
+{
+completionHandler(responses[0].ptr());
+}
+
+void VirtualAuthenticatorManager::decidePolicyForLocalAuthenticator(CompletionHandler&& completionHandler)
+{
+completionHandler(LocalAuthenticatorPolicy::Allow);
+}
+
} // namespace WebKit
#endif // ENABLE(WEB_AUTHN)
[webkit-changes] [291320] trunk/Source
Title: [291320] trunk/Source
Revision 291320
Author cdu...@apple.com
Date 2022-03-15 16:16:02 -0700 (Tue, 15 Mar 2022)
Log Message
Make it clearer in the loading logging when it is for the main frame or not
https://bugs.webkit.org/show_bug.cgi?id=237913
Reviewed by Alex Christensen.
Source/WebCore:
* dom/Document.cpp:
* loader/DocumentLoader.cpp:
* loader/FrameLoader.cpp:
* page/FrameView.cpp:
Source/WebKit:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::receivedNavigationPolicyDecision):
(WebKit::WebPageProxy::didStartProvisionalLoadForFrameShared):
(WebKit::WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrameShared):
(WebKit::WebPageProxy::willPerformClientRedirectForFrame):
(WebKit::WebPageProxy::didCancelClientRedirectForFrame):
(WebKit::WebPageProxy::didFailProvisionalLoadForFrameShared):
(WebKit::WebPageProxy::didCommitLoadForFrame):
(WebKit::WebPageProxy::didFinishDocumentLoadForFrame):
(WebKit::WebPageProxy::didFinishLoadForFrame):
(WebKit::WebPageProxy::didFailLoadForFrame):
(WebKit::WebPageProxy::didSameDocumentNavigationForFrame):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::didPerformClientRedirectShared):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/loader/DocumentLoader.cpp
trunk/Source/WebCore/loader/FrameLoader.cpp
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (291319 => 291320)
--- trunk/Source/WebCore/ChangeLog 2022-03-15 22:22:25 UTC (rev 291319)
+++ trunk/Source/WebCore/ChangeLog 2022-03-15 23:16:02 UTC (rev 291320)
@@ -1,3 +1,15 @@
+2022-03-15 Chris Dumez
+
+Make it clearer in the loading logging when it is for the main frame or not
+https://bugs.webkit.org/show_bug.cgi?id=237913
+
+Reviewed by Alex Christensen.
+
+* dom/Document.cpp:
+* loader/DocumentLoader.cpp:
+* loader/FrameLoader.cpp:
+* page/FrameView.cpp:
+
2022-03-15 Commit Queue
Unreviewed, reverting r291282.
Modified: trunk/Source/WebCore/dom/Document.cpp (291319 => 291320)
--- trunk/Source/WebCore/dom/Document.cpp 2022-03-15 22:22:25 UTC (rev 291319)
+++ trunk/Source/WebCore/dom/Document.cpp 2022-03-15 23:16:02 UTC (rev 291320)
@@ -355,8 +355,8 @@
#include "HTMLVideoElement.h"
#endif
-#define DOCUMENT_RELEASE_LOG(channel, fmt, ...) RELEASE_LOG(channel, "%p - [pageID=%" PRIu64 ", frameID=%" PRIu64 ", main=%d] Document::" fmt, this, valueOrDefault(pageID()).toUInt64(), valueOrDefault(frameID()).toUInt64(), this == (), ##__VA_ARGS__)
-#define DOCUMENT_RELEASE_LOG_ERROR(channel, fmt, ...) RELEASE_LOG_ERROR(channel, "%p - [pageID=%" PRIu64 ", frameID=%" PRIu64 ", main=%d] Document::" fmt, this, valueOrDefault(pageID()).toUInt64(), valueOrDefault(frameID()).toUInt64(), this == (), ##__VA_ARGS__)
+#define DOCUMENT_RELEASE_LOG(channel, fmt, ...) RELEASE_LOG(channel, "%p - [pageID=%" PRIu64 ", frameID=%" PRIu64 ", isMainFrame=%d] Document::" fmt, this, valueOrDefault(pageID()).toUInt64(), valueOrDefault(frameID()).toUInt64(), this == (), ##__VA_ARGS__)
+#define DOCUMENT_RELEASE_LOG_ERROR(channel, fmt, ...) RELEASE_LOG_ERROR(channel, "%p - [pageID=%" PRIu64 ", frameID=%" PRIu64 ", isMainFrame=%d] Document::" fmt, this, valueOrDefault(pageID()).toUInt64(), valueOrDefault(frameID()).toUInt64(), this == (), ##__VA_ARGS__)
namespace WebCore {
Modified: trunk/Source/WebCore/loader/DocumentLoader.cpp (291319 => 291320)
--- trunk/Source/WebCore/loader/DocumentLoader.cpp 2022-03-15 22:22:25 UTC (rev 291319)
+++ trunk/Source/WebCore/loader/DocumentLoader.cpp 2022-03-15 23:16:02 UTC (rev 291320)
@@ -130,7 +130,7 @@
#define PAGE_ID ((m_frame ? valueOrDefault(m_frame->pageID()) : PageIdentifier()).toUInt64())
#define FRAME_ID ((m_frame ? valueOrDefault(m_frame->frameID()) : FrameIdentifier()).toUInt64())
#define IS_MAIN_FRAME (m_frame ? m_frame->isMainFrame() : false)
-#define DOCUMENTLOADER_RELEASE_LOG(fmt, ...) RELEASE_LOG(Network, "%p - [pageID=%" PRIu64 ", frameID=%" PRIu64 ", main=%d] DocumentLoader::" fmt, this, PAGE_ID, FRAME_ID, IS_MAIN_FRAME, ##__VA_ARGS__)
+#define DOCUMENTLOADER_RELEASE_LOG(fmt, ...) RELEASE_LOG(Network, "%p - [pageID=%" PRIu64 ", frameID=%" PRIu64 ", isMainFrame=%d] DocumentLoader::" fmt, this, PAGE_ID, FRAME_ID, IS_MAIN_FRAME, ##__VA_ARGS__)
#if USE(APPLE_INTERNAL_SDK)
#include
Modified: trunk/Source/WebCore/loader/FrameLoader.cpp (291319 => 291320)
--- trunk/Source/WebCore/loader/FrameLoader.cpp 2022-03-15 22:22:25 UTC (rev 291319)
+++ trunk/Source/WebCore/loader/FrameLoader.cpp 2022-03-15 23:16:02 UTC (rev 291320)
@@ -155,8 +155,8 @@
#define PAGE_ID (valueOrDefault(pageID()).toUInt64())
#define FRAME_ID (valueOrDefault(frameID()).toUInt64())
-#define FRAMELOADER_RELEASE_LOG(channel, fmt, ...) RELEASE_LOG(channel, "%p - [pageID=%" PRIu64 ", frameID=%" PRIu64 ",
[webkit-changes] [291319] trunk/LayoutTests
Title: [291319] trunk/LayoutTests Revision 291319 Author j...@apple.com Date 2022-03-15 15:22:25 -0700 (Tue, 15 Mar 2022) Log Message REGRESSION(r287249): [ Monterey wk2 ] media/media-source/media-webm-vorbis-partial.html is a constant text failure https://bugs.webkit.org/show_bug.cgi?id=236656 rdar://88978504 Reviewed by Eric Carlson. Update test expectations, they didn't get committed after the test got modified in bug 236211 * media/media-source/media-webm-vorbis-partial-expected.txt: * platform/mac-wk1/TestExpectations: * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/media/media-source/media-webm-vorbis-partial-expected.txt trunk/LayoutTests/platform/mac-wk1/TestExpectations trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (291318 => 291319) --- trunk/LayoutTests/ChangeLog 2022-03-15 22:09:23 UTC (rev 291318) +++ trunk/LayoutTests/ChangeLog 2022-03-15 22:22:25 UTC (rev 291319) @@ -1,3 +1,18 @@ +2022-03-15 Jean-Yves Avenard + +REGRESSION(r287249): [ Monterey wk2 ] media/media-source/media-webm-vorbis-partial.html is a constant text failure +https://bugs.webkit.org/show_bug.cgi?id=236656 +rdar://88978504 + +Reviewed by Eric Carlson. + +Update test expectations, they didn't get committed after the test got +modified in bug 236211 + +* media/media-source/media-webm-vorbis-partial-expected.txt: +* platform/mac-wk1/TestExpectations: +* platform/mac-wk2/TestExpectations: + 2022-03-15 Patrick Griffis Add initial implementation of Fetch Metadata Modified: trunk/LayoutTests/media/media-source/media-webm-vorbis-partial-expected.txt (291318 => 291319) --- trunk/LayoutTests/media/media-source/media-webm-vorbis-partial-expected.txt 2022-03-15 22:09:23 UTC (rev 291318) +++ trunk/LayoutTests/media/media-source/media-webm-vorbis-partial-expected.txt 2022-03-15 22:22:25 UTC (rev 291319) @@ -1,13 +1,22 @@ RUN(video.src = "" EVENT(sourceopen) -RUN(source.duration = loader.duration()) RUN(sourceBuffer = source.addSourceBuffer(loader.type())) RUN(sourceBuffer.appendBuffer(loader.initSegment())) EVENT(update) -Append a media segment. -RUN(sourceBuffer.appendBuffer(loader.mediaSegment(0))) +Divide the first media segment in two. +RUN(partial1 = loader.mediaSegment(0).slice(0, loader.mediaSegment(0).byteLength / 2)) +RUN(partial2 = loader.mediaSegment(0).slice(loader.mediaSegment(0).byteLength / 2)) +Append a partial media segment. +RUN(sourceBuffer.appendBuffer(partial1)) EVENT(update) +EXPECTED (sourceBuffer.buffered.length == '1') OK +EXPECTED (sourceBuffer.buffered.end(0).toFixed(2) == '0.64') OK +Complete the partial media segment. +RUN(sourceBuffer.appendBuffer(partial2)) +EVENT(update) +EXPECTED (sourceBuffer.buffered.length == '1') OK +EXPECTED (sourceBuffer.buffered.end(0).toFixed(2) == '1.34') OK EXPECTED (sourceBuffer.buffered.end(0) == source.duration == 'true') OK END OF TEST Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (291318 => 291319) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2022-03-15 22:09:23 UTC (rev 291318) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2022-03-15 22:22:25 UTC (rev 291319) @@ -1574,9 +1574,6 @@ # rdar://80346975 [ Debug ] media/track/track-in-band-cues-added-once.html [ Pass Failure Crash ] -# rdar://80346516 -media/media-source/media-webm-vorbis-partial.html [ Skip ] - # rdar://80343074 ([ Mac wk1 ] http/tests/websocket/tests/hybi/client-close-2.html [ Failure ]) http/tests/websocket/tests/hybi/client-close-2.html [ Pass Failure ] Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (291318 => 291319) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2022-03-15 22:09:23 UTC (rev 291318) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2022-03-15 22:22:25 UTC (rev 291319) @@ -1131,8 +1131,6 @@ webkit.org/b/214683 [ Debug ] imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-implicit.html [ Pass Failure ] -webkit.org/b/236656 [ Monterey ] media/media-source/media-webm-vorbis-partial.html [ Failure ] - webkit.org/b/214824 [ Debug ] js/throw-large-string-oom.html [ Skip ] webkit.org/b/215245 [ Release ] imported/w3c/web-platform-tests/content-security-policy/worker-src/service-worker-src-child-fallback.https.sub.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291318] trunk
Title: [291318] trunk
Revision 291318
Author commit-qu...@webkit.org
Date 2022-03-15 15:09:23 -0700 (Tue, 15 Mar 2022)
Log Message
Unreviewed, reverting r291282.
https://bugs.webkit.org/show_bug.cgi?id=237924
Speedometer2 1-2% regression
Reverted changeset:
"Dialog element only animates once"
https://bugs.webkit.org/show_bug.cgi?id=236274
https://commits.webkit.org/r291282
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/support/testcommon.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/style/Styleable.cpp
Removed Paths
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/dialog-animation-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/dialog-animation.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/dialog-backdrop-animation-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/dialog-backdrop-animation.html
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (291317 => 291318)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2022-03-15 21:52:40 UTC (rev 291317)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-03-15 22:09:23 UTC (rev 291318)
@@ -1,3 +1,16 @@
+2022-03-15 Commit Queue
+
+Unreviewed, reverting r291282.
+https://bugs.webkit.org/show_bug.cgi?id=237924
+
+Speedometer2 1-2% regression
+
+Reverted changeset:
+
+"Dialog element only animates once"
+https://bugs.webkit.org/show_bug.cgi?id=236274
+https://commits.webkit.org/r291282
+
2022-03-15 Patrick Griffis
Add initial implementation of Fetch Metadata
Deleted: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/dialog-animation-expected.txt (291317 => 291318)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/dialog-animation-expected.txt 2022-03-15 21:52:40 UTC (rev 291317)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/dialog-animation-expected.txt 2022-03-15 22:09:23 UTC (rev 291318)
@@ -1,3 +0,0 @@
-
-PASS CSS Animations tied to are canceled and restarted as the dialog is hidden and shown
-
Deleted: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/dialog-animation.html (291317 => 291318)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/dialog-animation.html 2022-03-15 21:52:40 UTC (rev 291317)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/dialog-animation.html 2022-03-15 22:09:23 UTC (rev 291318)
@@ -1,44 +0,0 @@
-
-
-CSS Animations on a dialog>
-
-
-dialog[open] {
-animation: dialog-open-animation 1ms;
-}
-
-@keyframes dialog-open-animation {
-from { opacity: 0 }
-}
-
-
-
-
-
-"use strict";
-
-promise_test(async t => {
- const dialog = addElement(t, "dialog");
-
- // Open the dialog a first time, this should trigger a CSS Animation.
- dialog.open = true;
- const animations = dialog.getAnimations();
- assert_equals(animations.length, 1, "As the
[webkit-changes] [291317] trunk/Source/WebGPU
Title: [291317] trunk/Source/WebGPU Revision 291317 Author mmaxfi...@apple.com Date 2022-03-15 14:52:40 -0700 (Tue, 15 Mar 2022) Log Message [WebGPU] Update WebGPU CommandLinePlayground to execute asynchronous tasks https://bugs.webkit.org/show_bug.cgi?id=237852 Reviewed by Kimmo Kinnunen. This patch hooks up dispatch_async(dispatch_get_main_queue()) to WebGPU's CommandLinePlayground, so asynchronous tasks get run. * CommandLinePlayground/CommandLinePlayground-Bridging-Header.h: Copied from Source/WebGPU/CommandLinePlayground/main.swift. * CommandLinePlayground/Utilities.c: Copied from Source/WebGPU/CommandLinePlayground/main.swift. (createDefaultInstance): * CommandLinePlayground/Utilities.h: Copied from Source/WebGPU/CommandLinePlayground/main.swift. * CommandLinePlayground/config.h: Copied from Source/WebGPU/CommandLinePlayground/main.swift. * CommandLinePlayground/main.swift: (adapter): * Configurations/CommandLinePlayground.xcconfig: * WebGPU.xcodeproj/project.pbxproj: * WebGPU/TextureView.mm: Modified Paths trunk/Source/WebGPU/ChangeLog trunk/Source/WebGPU/CommandLinePlayground/main.swift trunk/Source/WebGPU/Configurations/CommandLinePlayground.xcconfig trunk/Source/WebGPU/WebGPU/TextureView.mm trunk/Source/WebGPU/WebGPU.xcodeproj/project.pbxproj Added Paths trunk/Source/WebGPU/CommandLinePlayground/CommandLinePlayground-Bridging-Header.h trunk/Source/WebGPU/CommandLinePlayground/Utilities.c trunk/Source/WebGPU/CommandLinePlayground/Utilities.h trunk/Source/WebGPU/CommandLinePlayground/config.h Diff Modified: trunk/Source/WebGPU/ChangeLog (291316 => 291317) --- trunk/Source/WebGPU/ChangeLog 2022-03-15 21:39:38 UTC (rev 291316) +++ trunk/Source/WebGPU/ChangeLog 2022-03-15 21:52:40 UTC (rev 291317) @@ -1,5 +1,26 @@ 2022-03-15 Myles C. Maxfield +[WebGPU] Update WebGPU CommandLinePlayground to execute asynchronous tasks +https://bugs.webkit.org/show_bug.cgi?id=237852 + +Reviewed by Kimmo Kinnunen. + +This patch hooks up dispatch_async(dispatch_get_main_queue()) to WebGPU's CommandLinePlayground, +so asynchronous tasks get run. + +* CommandLinePlayground/CommandLinePlayground-Bridging-Header.h: Copied from Source/WebGPU/CommandLinePlayground/main.swift. +* CommandLinePlayground/Utilities.c: Copied from Source/WebGPU/CommandLinePlayground/main.swift. +(createDefaultInstance): +* CommandLinePlayground/Utilities.h: Copied from Source/WebGPU/CommandLinePlayground/main.swift. +* CommandLinePlayground/config.h: Copied from Source/WebGPU/CommandLinePlayground/main.swift. +* CommandLinePlayground/main.swift: +(adapter): +* Configurations/CommandLinePlayground.xcconfig: +* WebGPU.xcodeproj/project.pbxproj: +* WebGPU/TextureView.mm: + +2022-03-15 Myles C. Maxfield + [WebGPU] Repeated calls to wgpuDeviceGetQueue() are supposed to return the same pointer https://bugs.webkit.org/show_bug.cgi?id=237861 Copied: trunk/Source/WebGPU/CommandLinePlayground/CommandLinePlayground-Bridging-Header.h (from rev 291316, trunk/Source/WebGPU/CommandLinePlayground/main.swift) (0 => 291317) --- trunk/Source/WebGPU/CommandLinePlayground/CommandLinePlayground-Bridging-Header.h (rev 0) +++ trunk/Source/WebGPU/CommandLinePlayground/CommandLinePlayground-Bridging-Header.h 2022-03-15 21:52:40 UTC (rev 291317) @@ -0,0 +1,26 @@ +/* + * Copyright (c) 2022 Apple Inc. All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in the + *documentation and/or other materials provided with the distribution. + * + * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY + * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR + * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR + * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, + * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, + * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR + * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY + * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + */ + +#import "Utilities.h" Copied: trunk/Source/WebGPU/CommandLinePlayground/Utilities.c (from rev 291316, trunk/Source/WebGPU/CommandLinePlayground/main.swift) (0 => 291317) ---
[webkit-changes] [291316] trunk/Source/WebCore
Title: [291316] trunk/Source/WebCore
Revision 291316
Author sihui_...@apple.com
Date 2022-03-15 14:39:38 -0700 (Tue, 15 Mar 2022)
Log Message
Add RELEASE_LOG_FAULT to WebSQL entry functions
https://bugs.webkit.org/show_bug.cgi?id=237865
Reviewed by Geoffrey Garen.
To help learn remaining WebSQL usage.
* Modules/webdatabase/Database.cpp:
(WebCore::Database::transaction):
(WebCore::Database::readTransaction):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webdatabase/Database.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (291315 => 291316)
--- trunk/Source/WebCore/ChangeLog 2022-03-15 21:30:06 UTC (rev 291315)
+++ trunk/Source/WebCore/ChangeLog 2022-03-15 21:39:38 UTC (rev 291316)
@@ -1,3 +1,16 @@
+2022-03-15 Sihui Liu
+
+Add RELEASE_LOG_FAULT to WebSQL entry functions
+https://bugs.webkit.org/show_bug.cgi?id=237865
+
+Reviewed by Geoffrey Garen.
+
+To help learn remaining WebSQL usage.
+
+* Modules/webdatabase/Database.cpp:
+(WebCore::Database::transaction):
+(WebCore::Database::readTransaction):
+
2022-03-15 Alan Bujtas
[IFC][Integration] Rename selection* to enclosing* in InlineIterator::Line
Modified: trunk/Source/WebCore/Modules/webdatabase/Database.cpp (291315 => 291316)
--- trunk/Source/WebCore/Modules/webdatabase/Database.cpp 2022-03-15 21:30:06 UTC (rev 291315)
+++ trunk/Source/WebCore/Modules/webdatabase/Database.cpp 2022-03-15 21:39:38 UTC (rev 291316)
@@ -589,11 +589,13 @@
void Database::transaction(RefPtr&& callback, RefPtr&& errorCallback, RefPtr&& successCallback)
{
+RELEASE_LOG_FAULT(SQLDatabase, "Database::transaction: Web SQL is deprecated.");
runTransaction(WTFMove(callback), WTFMove(errorCallback), WTFMove(successCallback), nullptr, false);
}
void Database::readTransaction(RefPtr&& callback, RefPtr&& errorCallback, RefPtr&& successCallback)
{
+RELEASE_LOG_FAULT(SQLDatabase, "Database::readTransaction: Web SQL is deprecated.");
runTransaction(WTFMove(callback), WTFMove(errorCallback), WTFMove(successCallback), nullptr, true);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291315] trunk/Source/WebGPU
Title: [291315] trunk/Source/WebGPU
Revision 291315
Author mmaxfi...@apple.com
Date 2022-03-15 14:30:06 -0700 (Tue, 15 Mar 2022)
Log Message
[WebGPU] Repeated calls to wgpuDeviceGetQueue() are supposed to return the same pointer
https://bugs.webkit.org/show_bug.cgi?id=237861
Reviewed by Kimmo Kinnunen.
Previously, wgpuDeviceGetQueue() had "new WGPUQueueImpl { ... }" but this is wrong because
the default queue doesn't change from one call to the next.
* WebGPU/Adapter.mm:
(WebGPU::Adapter::requestDevice):
(wgpuAdapterRequestDevice):
(wgpuAdapterRequestDeviceWithBlock):
* WebGPU/Device.h:
* WebGPU/Device.mm:
(WebGPU::Device::create):
(WebGPU::Device::getQueue):
(wgpuDeviceGetQueue):
Modified Paths
trunk/Source/WebGPU/ChangeLog
trunk/Source/WebGPU/WebGPU/Adapter.mm
trunk/Source/WebGPU/WebGPU/Device.h
trunk/Source/WebGPU/WebGPU/Device.mm
Diff
Modified: trunk/Source/WebGPU/ChangeLog (291314 => 291315)
--- trunk/Source/WebGPU/ChangeLog 2022-03-15 21:30:05 UTC (rev 291314)
+++ trunk/Source/WebGPU/ChangeLog 2022-03-15 21:30:06 UTC (rev 291315)
@@ -1,5 +1,25 @@
2022-03-15 Myles C. Maxfield
+[WebGPU] Repeated calls to wgpuDeviceGetQueue() are supposed to return the same pointer
+https://bugs.webkit.org/show_bug.cgi?id=237861
+
+Reviewed by Kimmo Kinnunen.
+
+Previously, wgpuDeviceGetQueue() had "new WGPUQueueImpl { ... }" but this is wrong because
+the default queue doesn't change from one call to the next.
+
+* WebGPU/Adapter.mm:
+(WebGPU::Adapter::requestDevice):
+(wgpuAdapterRequestDevice):
+(wgpuAdapterRequestDeviceWithBlock):
+* WebGPU/Device.h:
+* WebGPU/Device.mm:
+(WebGPU::Device::create):
+(WebGPU::Device::getQueue):
+(wgpuDeviceGetQueue):
+
+2022-03-15 Myles C. Maxfield
+
[WebGPU] Allow for scheduling asynchronous work
https://bugs.webkit.org/show_bug.cgi?id=237755
Modified: trunk/Source/WebGPU/WebGPU/Adapter.mm (291314 => 291315)
--- trunk/Source/WebGPU/WebGPU/Adapter.mm 2022-03-15 21:30:05 UTC (rev 291314)
+++ trunk/Source/WebGPU/WebGPU/Adapter.mm 2022-03-15 21:30:06 UTC (rev 291315)
@@ -120,9 +120,7 @@
return;
}
-// See the comment in Device::setLabel() about why we're not setting the label here.
-
-callback(WGPURequestDeviceStatus_Success, Device::create(m_device), nullptr);
+callback(WGPURequestDeviceStatus_Success, Device::create(m_device, descriptor.label), nullptr);
}
} // namespace WebGPU
@@ -155,7 +153,11 @@
void wgpuAdapterRequestDevice(WGPUAdapter adapter, const WGPUDeviceDescriptor* descriptor, WGPURequestDeviceCallback callback, void* userdata)
{
adapter->adapter->requestDevice(*descriptor, [callback, userdata] (WGPURequestDeviceStatus status, RefPtr&& device, const char* message) {
-callback(status, device ? new WGPUDeviceImpl { device.releaseNonNull() } : nullptr, message, userdata);
+if (device) {
+auto& queue = device->getQueue();
+callback(status, new WGPUDeviceImpl { device.releaseNonNull(), { queue } }, message, userdata);
+} else
+callback(status, nullptr, message, userdata);
});
}
@@ -162,6 +164,10 @@
void wgpuAdapterRequestDeviceWithBlock(WGPUAdapter adapter, WGPUDeviceDescriptor const * descriptor, WGPURequestDeviceBlockCallback callback)
{
adapter->adapter->requestDevice(*descriptor, [callback] (WGPURequestDeviceStatus status, RefPtr&& device, const char* message) {
-callback(status, device ? new WGPUDeviceImpl { device.releaseNonNull() } : nullptr, message);
+if (device) {
+auto& queue = device->getQueue();
+callback(status, new WGPUDeviceImpl { device.releaseNonNull(), { queue } }, message);
+} else
+callback(status, nullptr, message);
});
}
Modified: trunk/Source/WebGPU/WebGPU/Device.h (291314 => 291315)
--- trunk/Source/WebGPU/WebGPU/Device.h 2022-03-15 21:30:05 UTC (rev 291314)
+++ trunk/Source/WebGPU/WebGPU/Device.h 2022-03-15 21:30:06 UTC (rev 291315)
@@ -25,6 +25,7 @@
#pragma once
+#import "Queue.h"
#import
#import
#import
@@ -47,12 +48,11 @@
class Surface;
class SwapChain;
class Texture;
-class Queue;
class Device : public RefCounted {
WTF_MAKE_FAST_ALLOCATED;
public:
-static RefPtr create(id);
+static RefPtr create(id, const char* deviceLabel);
~Device();
@@ -74,7 +74,7 @@
void destroy();
size_t enumerateFeatures(WGPUFeatureName* features);
bool getLimits(WGPUSupportedLimits&);
-RefPtr getQueue();
+Queue& getQueue();
bool hasFeature(WGPUFeatureName);
bool popErrorScope(WTF::Function&& callback);
void pushErrorScope(WGPUErrorFilter);
@@ -93,4 +93,5 @@
struct WGPUDeviceImpl {
Ref device;
+WGPUQueueImpl defaultQueue;
};
Modified: trunk/Source/WebGPU/WebGPU/Device.mm (291314 => 291315)
--- trunk/Source/WebGPU/WebGPU/Device.mm 2022-03-15
[webkit-changes] [291314] trunk/Source/WebKit
Title: [291314] trunk/Source/WebKit
Revision 291314
Author commit-qu...@webkit.org
Date 2022-03-15 14:30:05 -0700 (Tue, 15 Mar 2022)
Log Message
RemoteGraphicsContextGLProxy omits context lost checks for back and front buffer access functions
https://bugs.webkit.org/show_bug.cgi?id=237891
Patch by Kimmo Kinnunen on 2022-03-15
Reviewed by Myles Maxfield.
Add missing isContextLost() checks to RemoteGraphicsContextGLProxy functions.
WebGLRenderingContextBase would call as follows:
void WebGLRenderingContextBase::paintRenderingResultsToCanvas()
{
if (isContextLostOrPending())
return;
...
m_context->prepareForDisplay();
...
m_context->paintCompositedResultsToCanvas();
}
The context may be ok during the first check but then fail later,
and so all the context functions need to check for validity.
No new tests, testing hooks need non-trivial implementation.
This is tracked in bug 237891.
* WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp:
(WebKit::RemoteGraphicsContextGLProxy::paintRenderingResultsToCanvas):
(WebKit::RemoteGraphicsContextGLProxy::paintCompositedResultsToCanvas):
(WebKit::RemoteGraphicsContextGLProxy::copyTextureFromMedia):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (291313 => 291314)
--- trunk/Source/WebKit/ChangeLog 2022-03-15 21:22:35 UTC (rev 291313)
+++ trunk/Source/WebKit/ChangeLog 2022-03-15 21:30:05 UTC (rev 291314)
@@ -1,3 +1,33 @@
+2022-03-15 Kimmo Kinnunen
+
+RemoteGraphicsContextGLProxy omits context lost checks for back and front buffer access functions
+https://bugs.webkit.org/show_bug.cgi?id=237891
+
+Reviewed by Myles Maxfield.
+
+Add missing isContextLost() checks to RemoteGraphicsContextGLProxy functions.
+WebGLRenderingContextBase would call as follows:
+void WebGLRenderingContextBase::paintRenderingResultsToCanvas()
+{
+if (isContextLostOrPending())
+return;
+...
+m_context->prepareForDisplay();
+...
+m_context->paintCompositedResultsToCanvas();
+}
+
+The context may be ok during the first check but then fail later,
+and so all the context functions need to check for validity.
+
+No new tests, testing hooks need non-trivial implementation.
+This is tracked in bug 237891.
+
+* WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp:
+(WebKit::RemoteGraphicsContextGLProxy::paintRenderingResultsToCanvas):
+(WebKit::RemoteGraphicsContextGLProxy::paintCompositedResultsToCanvas):
+(WebKit::RemoteGraphicsContextGLProxy::copyTextureFromMedia):
+
2022-03-15 Myles C. Maxfield
[WebGPU] Allow for scheduling asynchronous work
Modified: trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp (291313 => 291314)
--- trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp 2022-03-15 21:22:35 UTC (rev 291313)
+++ trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp 2022-03-15 21:30:05 UTC (rev 291314)
@@ -138,6 +138,8 @@
void RemoteGraphicsContextGLProxy::paintRenderingResultsToCanvas(ImageBuffer& buffer)
{
+if (isContextLost())
+return;
// FIXME: the buffer is "relatively empty" always, but for consistency, we need to ensure
// no pending operations are targeted for the `buffer`.
buffer.flushDrawingContext();
@@ -158,6 +160,8 @@
void RemoteGraphicsContextGLProxy::paintCompositedResultsToCanvas(ImageBuffer& buffer)
{
+if (isContextLost())
+return;
buffer.flushDrawingContext();
auto sendResult = sendSync(Messages::RemoteGraphicsContextGL::PaintCompositedResultsToCanvas(buffer.renderingResourceIdentifier()), Messages::RemoteGraphicsContextGL::PaintCompositedResultsToCanvas::Reply());
if (!sendResult) {
@@ -186,6 +190,8 @@
#if ENABLE(VIDEO)
bool RemoteGraphicsContextGLProxy::copyTextureFromMedia(MediaPlayer& mediaPlayer, PlatformGLObject texture, GCGLenum target, GCGLint level, GCGLenum internalFormat, GCGLenum format, GCGLenum type, bool premultiplyAlpha, bool flipY)
{
+if (isContextLost())
+return false;
auto videoFrame = mediaPlayer.videoFrameForCurrentTime();
// Video in WP while WebGL in GPUP is not supported.
if (!videoFrame || !is(*videoFrame))
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291313] trunk/Source
Title: [291313] trunk/Source
Revision 291313
Author mmaxfi...@apple.com
Date 2022-03-15 14:22:35 -0700 (Tue, 15 Mar 2022)
Log Message
[WebGPU] Allow for scheduling asynchronous work
https://bugs.webkit.org/show_bug.cgi?id=237755
Reviewed by Kimmo Kinnunen.
Source/WebCore/PAL:
WebGPU doesn't know how to schedule asynchronous work, so that will have to be handled
by dependency injection from the caller. The way it works is Instance creation takes
a block, which is retained. Whenever asynchronous work needs to be scheduled on the
relevant thread, this block is called, and is passed another block for the work to be
performed.
The API contract is: callers of WebGPU must call its functions in a non-racey way. The
schedule function will execute on a background thread, and it must schedule the block
it's passed to be run in a non-racey way with regards to all the other WebGPU calls.
The schedule function can be NULL, in which case the asynchronous tasks will just be
internally queued up inside WebGPU, and then users will have to call
wgpuInstanceProcessEvents() periodically to synchronously call the queued callbacks.
* pal/graphics/WebGPU/Impl/WebGPUImpl.cpp:
(PAL::WebGPU::GPUImpl::create):
* pal/graphics/WebGPU/Impl/WebGPUImpl.h:
Source/WebGPU:
* WebGPU/Instance.h:
(WebGPU::Instance::runLoop const): Deleted.
* WebGPU/Instance.mm:
(WebGPU::Instance::create):
(WebGPU::Instance::Instance):
(WebGPU::Instance::scheduleWork):
(WebGPU::Instance::defaultScheduleWork):
(WebGPU::Instance::processEvents):
* WebGPU/WebGPUExt.h:
Source/WebKit:
* GPUProcess/graphics/WebGPU/RemoteGPU.cpp:
(WebKit::RemoteGPU::workQueueInitialize):
(WebKit::RemoteGPU::workQueueUninitialize):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createGPUForWebGPU const):
Source/WebKitLegacy/mac:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::createGPUForWebGPU const):
Modified Paths
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUImpl.cpp
trunk/Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUImpl.h
trunk/Source/WebGPU/ChangeLog
trunk/Source/WebGPU/WebGPU/Instance.h
trunk/Source/WebGPU/WebGPU/Instance.mm
trunk/Source/WebGPU/WebGPU/WebGPUExt.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/graphics/WebGPU/RemoteGPU.cpp
trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm
Diff
Modified: trunk/Source/WebCore/PAL/ChangeLog (291312 => 291313)
--- trunk/Source/WebCore/PAL/ChangeLog 2022-03-15 21:17:33 UTC (rev 291312)
+++ trunk/Source/WebCore/PAL/ChangeLog 2022-03-15 21:22:35 UTC (rev 291313)
@@ -1,3 +1,27 @@
+2022-03-15 Myles C. Maxfield
+
+[WebGPU] Allow for scheduling asynchronous work
+https://bugs.webkit.org/show_bug.cgi?id=237755
+
+Reviewed by Kimmo Kinnunen.
+
+WebGPU doesn't know how to schedule asynchronous work, so that will have to be handled
+by dependency injection from the caller. The way it works is Instance creation takes
+a block, which is retained. Whenever asynchronous work needs to be scheduled on the
+relevant thread, this block is called, and is passed another block for the work to be
+performed.
+
+The API contract is: callers of WebGPU must call its functions in a non-racey way. The
+schedule function will execute on a background thread, and it must schedule the block
+it's passed to be run in a non-racey way with regards to all the other WebGPU calls.
+The schedule function can be NULL, in which case the asynchronous tasks will just be
+internally queued up inside WebGPU, and then users will have to call
+wgpuInstanceProcessEvents() periodically to synchronously call the queued callbacks.
+
+* pal/graphics/WebGPU/Impl/WebGPUImpl.cpp:
+(PAL::WebGPU::GPUImpl::create):
+* pal/graphics/WebGPU/Impl/WebGPUImpl.h:
+
2022-03-15 Jer Noble
[Cocoa] Adopt AVAssetPrefersSandboxedParsingOptionKey
Modified: trunk/Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUImpl.cpp (291312 => 291313)
--- trunk/Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUImpl.cpp 2022-03-15 21:17:33 UTC (rev 291312)
+++ trunk/Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUImpl.cpp 2022-03-15 21:22:35 UTC (rev 291313)
@@ -31,6 +31,7 @@
#include "WebGPUAdapterImpl.h"
#include "WebGPUDowncastConvertToBackingContext.h"
#include
+#include
#if PLATFORM(COCOA)
#include
@@ -40,9 +41,21 @@
namespace PAL::WebGPU {
-RefPtr GPUImpl::create()
+RefPtr GPUImpl::create(ScheduleWorkFunction&& scheduleWorkFunction)
{
-WGPUInstanceDescriptor descriptor = { nullptr };
+auto scheduleWorkBlock = makeBlockPtr([scheduleWorkFunction = WTFMove(scheduleWorkFunction)](WGPUWorkItem workItem)
+{
+scheduleWorkFunction(makeBlockPtr(WTFMove(workItem)));
+});
+
[webkit-changes] [291312] trunk/Source/WebCore
Title: [291312] trunk/Source/WebCore Revision 291312 Author za...@apple.com Date 2022-03-15 14:17:33 -0700 (Tue, 15 Mar 2022) Log Message [IFC][Integration] Rename selection* to enclosing* in InlineIterator::Line https://bugs.webkit.org/show_bug.cgi?id=237909 Reviewed by Antti Koivisto. These functions return enclosing (line box and content) geometries which we happen to use to compute selection boundaries (among other things). * editing/VisiblePosition.cpp: (WebCore::VisiblePosition::absoluteSelectionBoundsForLine const): * layout/integration/InlineIteratorLine.cpp: (WebCore::InlineIterator::Line::blockDirectionPointInLine const): (WebCore::InlineIterator::Line::enclosingTopAdjustedForPrecedingBlock const): (WebCore::InlineIterator::Line::enclosingHeightAdjustedForPrecedingBlock const): (WebCore::InlineIterator::Line::selectionTopAdjustedForPrecedingBlock const): Deleted. (WebCore::InlineIterator::Line::selectionHeightAdjustedForPrecedingBlock const): Deleted. * layout/integration/InlineIteratorLine.h: (WebCore::InlineIterator::Line::enclosingTop const): (WebCore::InlineIterator::Line::enclosingTopForHitTesting const): (WebCore::InlineIterator::Line::enclosingBottom const): (WebCore::InlineIterator::Line::enclosingHeight const): (WebCore::InlineIterator::Line::enclosingLogicalRect const): (WebCore::InlineIterator::Line::enclosingPhysicalRect const): (WebCore::InlineIterator::Line::selectionTop const): Deleted. (WebCore::InlineIterator::Line::selectionTopForHitTesting const): Deleted. (WebCore::InlineIterator::Line::selectionBottom const): Deleted. (WebCore::InlineIterator::Line::selectionHeight const): Deleted. (WebCore::InlineIterator::Line::selectionLogicalRect const): Deleted. (WebCore::InlineIterator::Line::selectionPhysicalRect const): Deleted. * layout/integration/InlineIteratorTextBox.cpp: (WebCore::InlineIterator::TextBox::selectionRect const): * rendering/CaretRectComputation.cpp: (WebCore::computeCaretRectForLinePosition): * rendering/LegacyRootInlineBox.cpp: (WebCore::LegacyRootInlineBox::selectionTopAdjustedForPrecedingBlock const): * rendering/RenderBlockFlow.cpp: (WebCore::RenderBlockFlow::adjustEnclosingTopForPrecedingBlock const): (WebCore::RenderBlockFlow::inlineSelectionGaps): (WebCore::RenderBlockFlow::positionForPointWithInlineChildren): (WebCore::RenderBlockFlow::adjustSelectionTopForPrecedingBlock const): Deleted. * rendering/RenderBlockFlow.h: * rendering/RenderImage.cpp: (WebCore::RenderImage::collectSelectionGeometries): * rendering/RenderLineBreak.cpp: (WebCore::RenderLineBreak::collectSelectionGeometries): * rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::positionForPoint): * rendering/RenderText.cpp: (WebCore::RenderText::positionForPoint): * rendering/TextBoxPainter.cpp: (WebCore::TextBoxPainter::paintBackground): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/editing/VisiblePosition.cpp trunk/Source/WebCore/layout/integration/InlineIteratorLine.cpp trunk/Source/WebCore/layout/integration/InlineIteratorLine.h trunk/Source/WebCore/layout/integration/InlineIteratorLineLegacyPath.h trunk/Source/WebCore/layout/integration/InlineIteratorLineModernPath.h trunk/Source/WebCore/layout/integration/InlineIteratorTextBox.cpp trunk/Source/WebCore/rendering/CaretRectComputation.cpp trunk/Source/WebCore/rendering/LegacyRootInlineBox.cpp trunk/Source/WebCore/rendering/RenderBlockFlow.cpp trunk/Source/WebCore/rendering/RenderBlockFlow.h trunk/Source/WebCore/rendering/RenderImage.cpp trunk/Source/WebCore/rendering/RenderLineBreak.cpp trunk/Source/WebCore/rendering/RenderReplaced.cpp trunk/Source/WebCore/rendering/RenderText.cpp trunk/Source/WebCore/rendering/TextBoxPainter.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (291311 => 291312) --- trunk/Source/WebCore/ChangeLog 2022-03-15 20:45:47 UTC (rev 291311) +++ trunk/Source/WebCore/ChangeLog 2022-03-15 21:17:33 UTC (rev 291312) @@ -1,3 +1,56 @@ +2022-03-15 Alan Bujtas + +[IFC][Integration] Rename selection* to enclosing* in InlineIterator::Line +https://bugs.webkit.org/show_bug.cgi?id=237909 + +Reviewed by Antti Koivisto. + +These functions return enclosing (line box and content) geometries which we happen to use to compute selection boundaries (among other things). + +* editing/VisiblePosition.cpp: +(WebCore::VisiblePosition::absoluteSelectionBoundsForLine const): +* layout/integration/InlineIteratorLine.cpp: +(WebCore::InlineIterator::Line::blockDirectionPointInLine const): +(WebCore::InlineIterator::Line::enclosingTopAdjustedForPrecedingBlock const): +(WebCore::InlineIterator::Line::enclosingHeightAdjustedForPrecedingBlock const): +(WebCore::InlineIterator::Line::selectionTopAdjustedForPrecedingBlock const): Deleted. +(WebCore::InlineIterator::Line::selectionHeightAdjustedForPrecedingBlock const): Deleted. +* layout/integration/InlineIteratorLine.h: +
[webkit-changes] [291311] trunk/Source/WebKit
Title: [291311] trunk/Source/WebKit
Revision 291311
Author cdu...@apple.com
Date 2022-03-15 13:45:47 -0700 (Tue, 15 Mar 2022)
Log Message
Fix logging in GPUProcessProxy::didCreateContextForVisibilityPropagation()
https://bugs.webkit.org/show_bug.cgi?id=237907
Reviewed by Simon Fraser.
LayerHostingContextID is a uint32_t. The current printing ends up logging negative values:
`GPUProcessProxy::didCreateContextForVisibilityPropagation: webPageProxyID: 7, pagePID: 79, contextID: -2041854761`
* UIProcess/GPU/GPUProcessProxy.cpp:
(WebKit::GPUProcessProxy::didCreateContextForVisibilityPropagation):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (291310 => 291311)
--- trunk/Source/WebKit/ChangeLog 2022-03-15 20:30:16 UTC (rev 291310)
+++ trunk/Source/WebKit/ChangeLog 2022-03-15 20:45:47 UTC (rev 291311)
@@ -1,3 +1,16 @@
+2022-03-15 Chris Dumez
+
+Fix logging in GPUProcessProxy::didCreateContextForVisibilityPropagation()
+https://bugs.webkit.org/show_bug.cgi?id=237907
+
+Reviewed by Simon Fraser.
+
+LayerHostingContextID is a uint32_t. The current printing ends up logging negative values:
+`GPUProcessProxy::didCreateContextForVisibilityPropagation: webPageProxyID: 7, pagePID: 79, contextID: -2041854761`
+
+* UIProcess/GPU/GPUProcessProxy.cpp:
+(WebKit::GPUProcessProxy::didCreateContextForVisibilityPropagation):
+
2022-03-15 Aditya Keerthi
[iOS] Indefinite hang when printing using a UIPrintPageRenderer
Modified: trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp (291310 => 291311)
--- trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp 2022-03-15 20:30:16 UTC (rev 291310)
+++ trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp 2022-03-15 20:45:47 UTC (rev 291311)
@@ -590,7 +590,7 @@
#if HAVE(VISIBILITY_PROPAGATION_VIEW)
void GPUProcessProxy::didCreateContextForVisibilityPropagation(WebPageProxyIdentifier webPageProxyID, WebCore::PageIdentifier pageID, LayerHostingContextID contextID)
{
-RELEASE_LOG(Process, "GPUProcessProxy::didCreateContextForVisibilityPropagation: webPageProxyID: %" PRIu64 ", pagePID: %" PRIu64 ", contextID: %d", webPageProxyID.toUInt64(), pageID.toUInt64(), contextID);
+RELEASE_LOG(Process, "GPUProcessProxy::didCreateContextForVisibilityPropagation: webPageProxyID: %" PRIu64 ", pagePID: %" PRIu64 ", contextID: %u", webPageProxyID.toUInt64(), pageID.toUInt64(), contextID);
auto* page = WebProcessProxy::webPage(webPageProxyID);
if (!page) {
RELEASE_LOG(Process, "GPUProcessProxy::didCreateContextForVisibilityPropagation() No WebPageProxy with this identifier");
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291310] trunk
Title: [291310] trunk Revision 291310 Author pgrif...@igalia.com Date 2022-03-15 13:30:16 -0700 (Tue, 15 Mar 2022) Log Message Add initial implementation of Fetch Metadata https://bugs.webkit.org/show_bug.cgi?id=204744 Reviewed by Youenn Fablet. LayoutTests/imported/w3c: Update expectations for Fetch Metadata. * web-platform-tests/fetch/metadata/download.https.sub-expected.txt: * web-platform-tests/fetch/metadata/download.https.sub.html: * web-platform-tests/fetch/metadata/fetch-preflight.https.sub.any-expected.txt: Added. * web-platform-tests/fetch/metadata/fetch-preflight.https.sub.any.worker-expected.txt: Added. * web-platform-tests/fetch/metadata/fetch-via-serviceworker--fallback.https.sub-expected.txt: * web-platform-tests/fetch/metadata/fetch-via-serviceworker--respondWith.https.sub-expected.txt: * web-platform-tests/fetch/metadata/fetch.https.sub.any-expected.txt: Added. * web-platform-tests/fetch/metadata/fetch.https.sub.any.worker-expected.txt: Added. * web-platform-tests/fetch/metadata/fetch.sub-expected.txt: * web-platform-tests/fetch/metadata/font.https.sub-expected.txt: * web-platform-tests/fetch/metadata/img.https.sub-expected.txt: * web-platform-tests/fetch/metadata/redirect/cross-site-redirect.https.sub-expected.txt: * web-platform-tests/fetch/metadata/redirect/multiple-redirect-cross-site.https.sub-expected.txt: * web-platform-tests/fetch/metadata/script.https.sub-expected.txt: * web-platform-tests/fetch/metadata/script.sub-expected.txt: * web-platform-tests/fetch/metadata/serviceworker-accessors.https.sub-expected.txt: Added. * web-platform-tests/fetch/metadata/serviceworker.https.sub-expected.txt: * web-platform-tests/fetch/metadata/sharedworker.https.sub-expected.txt: * web-platform-tests/fetch/metadata/trailing-dot.https.sub.any-expected.txt: Added. * web-platform-tests/fetch/metadata/trailing-dot.https.sub.any.worker-expected.txt: Added. * web-platform-tests/fetch/metadata/unload.https.sub-expected.txt: * web-platform-tests/fetch/metadata/worker.https.sub-expected.txt: * web-platform-tests/fetch/metadata/xslt.https.sub-expected.txt: * web-platform-tests/service-workers/service-worker/update-module-request-mode.https-expected.txt: Source/WebCore: Add initial implementation of Fetch Metadata as specified here: https://w3c.github.io/webappsec-fetch-metadata/ Currently only Fetch-Sec-Mode and Fetch-Sec-Dest are implemented with more to come in later patches. Test: http/wpt/fetch/fetch-metadata-same-origin-redirect.html * loader/CrossOriginAccessControl.cpp: (WebCore::cleanHTTPRequestHeadersForAccessControl): * loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::updateHTTPRequestHeaders): * loader/cache/CachedResourceRequest.cpp: (WebCore::CachedResourceRequest::updateFetchMetadataHeaders): * loader/cache/CachedResourceRequest.h: * platform/network/HTTPHeaderNames.in: Source/WTF: Add new experimental preference for Fetch Metadata, disabled by default. * Scripts/Preferences/WebPreferencesExperimental.yaml: LayoutTests: Skip fewer of the Fetch Metadata tests. Many still timeout and are still being worked on. * TestExpectations: * http/wpt/fetch/fetch-metadata-same-origin-redirect-expected.txt: Added. * http/wpt/fetch/fetch-metadata-same-origin-redirect.html: Added. * platform/mac-wk1/TestExpectations: * platform/mac-wk1/imported/w3c/web-platform-tests/fetch/metadata/fetch-preflight.https.sub.any-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/metadata/download.https.sub-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/metadata/download.https.sub.html trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/metadata/fetch-via-serviceworker--fallback.https.sub-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/metadata/fetch-via-serviceworker--respondWith.https.sub-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/metadata/fetch.sub-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/metadata/font.https.sub-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/metadata/img.https.sub-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/metadata/redirect/cross-site-redirect.https.sub-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/metadata/redirect/multiple-redirect-cross-site.https.sub-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/metadata/script.https.sub-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/metadata/script.sub-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/metadata/serviceworker.https.sub-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/metadata/sharedworker.https.sub-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/metadata/unload.https.sub-expected.txt
[webkit-changes] [291309] trunk/Source/WebCore
Title: [291309] trunk/Source/WebCore Revision 291309 Author commit-qu...@webkit.org Date 2022-03-15 13:09:33 -0700 (Tue, 15 Mar 2022) Log Message REGRESSION(r291270): Changes need better build-time guards https://bugs.webkit.org/show_bug.cgi?id=237908 Unreviewed, rolling out r291270 and r291294 until proper build guards and relevant configuration options are introduced. Patch by Zan Dobersek on 2022-03-15 * SourcesGTK.txt: * SourcesWPE.txt: * platform/TextureMapper.cmake: * platform/graphics/gbm/DMABufFormat.h: Removed. * platform/graphics/gbm/DMABufObject.h: Removed. * platform/graphics/gbm/DMABufReleaseFlag.h: Removed. * platform/graphics/gbm/GBMBufferSwapchain.cpp: Removed. * platform/graphics/gbm/GBMBufferSwapchain.h: Removed. * platform/graphics/gstreamer/DMABufVideoSinkGStreamer.cpp: (webKitDMABufVideoSinkProbePlatform): (webKitDMABufVideoSinkIsEnabled): Deleted. * platform/graphics/gstreamer/DMABufVideoSinkGStreamer.h: * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer): (WebCore::MediaPlayerPrivateGStreamer::platformLayer const): (WebCore::MediaPlayerPrivateGStreamer::pushTextureToCompositor): (WebCore::MediaPlayerPrivateGStreamer::triggerRepaint): (WebCore::MediaPlayerPrivateGStreamer::createVideoSink): (WebCore::fourccValue): Deleted. (WebCore::MediaPlayerPrivateGStreamer::pushDMABufToCompositor): Deleted. (WebCore::MediaPlayerPrivateGStreamer::createVideoSinkDMABuf): Deleted. * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: * platform/graphics/nicosia/texmap/NicosiaContentLayerTextureMapperImpl.cpp: (Nicosia::ContentLayerTextureMapperImpl::createFactory): * platform/graphics/nicosia/texmap/NicosiaContentLayerTextureMapperImpl.h: * platform/graphics/texmap/TextureMapperPlatformLayerProxyDMABuf.cpp: Removed. * platform/graphics/texmap/TextureMapperPlatformLayerProxyDMABuf.h: Removed. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/SourcesGTK.txt trunk/Source/WebCore/SourcesWPE.txt trunk/Source/WebCore/platform/TextureMapper.cmake trunk/Source/WebCore/platform/graphics/gstreamer/DMABufVideoSinkGStreamer.cpp trunk/Source/WebCore/platform/graphics/gstreamer/DMABufVideoSinkGStreamer.h trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h trunk/Source/WebCore/platform/graphics/nicosia/texmap/NicosiaContentLayerTextureMapperImpl.cpp trunk/Source/WebCore/platform/graphics/nicosia/texmap/NicosiaContentLayerTextureMapperImpl.h Removed Paths trunk/Source/WebCore/platform/graphics/gbm/DMABufFormat.h trunk/Source/WebCore/platform/graphics/gbm/DMABufObject.h trunk/Source/WebCore/platform/graphics/gbm/DMABufReleaseFlag.h trunk/Source/WebCore/platform/graphics/gbm/GBMBufferSwapchain.cpp trunk/Source/WebCore/platform/graphics/gbm/GBMBufferSwapchain.h trunk/Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyDMABuf.cpp trunk/Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyDMABuf.h Diff Modified: trunk/Source/WebCore/ChangeLog (291308 => 291309) --- trunk/Source/WebCore/ChangeLog 2022-03-15 19:34:43 UTC (rev 291308) +++ trunk/Source/WebCore/ChangeLog 2022-03-15 20:09:33 UTC (rev 291309) @@ -1,3 +1,39 @@ +2022-03-15 Zan Dobersek + +REGRESSION(r291270): Changes need better build-time guards +https://bugs.webkit.org/show_bug.cgi?id=237908 + +Unreviewed, rolling out r291270 and r291294 until proper build guards +and relevant configuration options are introduced. + +* SourcesGTK.txt: +* SourcesWPE.txt: +* platform/TextureMapper.cmake: +* platform/graphics/gbm/DMABufFormat.h: Removed. +* platform/graphics/gbm/DMABufObject.h: Removed. +* platform/graphics/gbm/DMABufReleaseFlag.h: Removed. +* platform/graphics/gbm/GBMBufferSwapchain.cpp: Removed. +* platform/graphics/gbm/GBMBufferSwapchain.h: Removed. +* platform/graphics/gstreamer/DMABufVideoSinkGStreamer.cpp: +(webKitDMABufVideoSinkProbePlatform): +(webKitDMABufVideoSinkIsEnabled): Deleted. +* platform/graphics/gstreamer/DMABufVideoSinkGStreamer.h: +* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: +(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer): +(WebCore::MediaPlayerPrivateGStreamer::platformLayer const): +(WebCore::MediaPlayerPrivateGStreamer::pushTextureToCompositor): +(WebCore::MediaPlayerPrivateGStreamer::triggerRepaint): +(WebCore::MediaPlayerPrivateGStreamer::createVideoSink): +(WebCore::fourccValue): Deleted. +(WebCore::MediaPlayerPrivateGStreamer::pushDMABufToCompositor): Deleted. +(WebCore::MediaPlayerPrivateGStreamer::createVideoSinkDMABuf): Deleted. +* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: +*
[webkit-changes] [291308] trunk/Tools
Title: [291308] trunk/Tools
Revision 291308
Author jbed...@apple.com
Date 2022-03-15 12:34:43 -0700 (Tue, 15 Mar 2022)
Log Message
[Merge-Queue] Rename bugzilla_comment_text
https://bugs.webkit.org/show_bug.cgi?id=237911
Reviewed by Aakash Jain.
Rename bugzilla_comment_text to comment_text to re-use
code to comment on pull requests.
* Tools/CISupport/ews-build/steps.py:
(ApplyPatch.evaluateCommand):
(ValidateCommiterAndReviewer.fail_build):
(ValidateChangeLogAndReviewer.evaluateCommand):
(CommentOnBug.start):
(AnalyzeCompileWebKitResults.analyzeResults):
(AnalyzeLayoutTestsResults.report_failure):
(FindModifiedChangeLogs.evaluateCommand):
(CreateLocalGITCommit.evaluateCommand):
(PushCommitToWebKitRepo.evaluateCommand):
* Tools/CISupport/ews-build/steps_unittest.py:
Canonical link: https://commits.webkit.org/248447@main
Modified Paths
trunk/Tools/CISupport/ews-build/steps.py
trunk/Tools/CISupport/ews-build/steps_unittest.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/CISupport/ews-build/steps.py (291307 => 291308)
--- trunk/Tools/CISupport/ews-build/steps.py 2022-03-15 19:22:07 UTC (rev 291307)
+++ trunk/Tools/CISupport/ews-build/steps.py 2022-03-15 19:34:43 UTC (rev 291308)
@@ -689,7 +689,7 @@
message = 'Tools/Scripts/svn-apply failed to apply patch {} to trunk'.format(patch_id)
if self.getProperty('buildername', '').lower() == 'commit-queue':
comment_text = '{}.\nPlease resolve the conflicts and upload a new patch.'.format(message.replace('patch', 'attachment'))
-self.setProperty('bugzilla_comment_text', comment_text)
+self.setProperty('comment_text', comment_text)
self.setProperty('build_finish_summary', message)
self.build.addStepsAfterCurrentStep([CommentOnBug(), SetCommitQueueMinusFlagOnPatch()])
else:
@@ -1414,7 +1414,7 @@
reason = '{} does not have {} permissions'.format(email, status)
comment = '{} does not have {} permissions according to {}.'.format(email, status, Contributors.url)
comment += '\n\nRejecting attachment {} from commit queue.'.format(self.getProperty('patch_id', ''))
-self.setProperty('bugzilla_comment_text', comment)
+self.setProperty('comment_text', comment)
self._addToLog('stdio', reason)
self.setProperty('build_finish_summary', reason)
@@ -1493,7 +1493,7 @@
rc = shell.ShellCommand.evaluateCommand(self, cmd)
if rc == FAILURE:
log_text = self.log_observer.getStdout() + self.log_observer.getStderr()
-self.setProperty('bugzilla_comment_text', log_text)
+self.setProperty('comment_text', log_text)
self.setProperty('build_finish_summary', 'ChangeLog validation failed')
self.build.addStepsAfterCurrentStep([CommentOnBug(), SetCommitQueueMinusFlagOnPatch()])
return rc
@@ -1619,10 +1619,10 @@
def start(self):
self.bug_id = self.getProperty('bug_id', '')
-self.comment_text = self.getProperty('bugzilla_comment_text', '')
+self.comment_text = self.getProperty('comment_text', '')
if not self.comment_text:
-self._addToLog('stdio', 'bugzilla_comment_text build property not found.\n')
+self._addToLog('stdio', 'comment_text build property not found.\n')
self.descriptionDone = 'No bugzilla comment found'
self.finished(WARNINGS)
return None
@@ -2249,7 +2249,7 @@
if patch_id:
if self.getProperty('buildername', '').lower() == 'commit-queue':
-self.setProperty('bugzilla_comment_text', message)
+self.setProperty('comment_text', message)
self.build.addStepsAfterCurrentStep([CommentOnBug(), SetCommitQueueMinusFlagOnPatch()])
else:
self.build.addStepsAfterCurrentStep([SetCommitQueueMinusFlagOnPatch()])
@@ -3075,7 +3075,7 @@
self.setProperty('build_finish_summary', message)
if self.getProperty('buildername', '').lower() == 'commit-queue':
-self.setProperty('bugzilla_comment_text', message)
+self.setProperty('comment_text', message)
self.build.addStepsAfterCurrentStep([CommentOnBug(), SetCommitQueueMinusFlagOnPatch()])
else:
self.build.addStepsAfterCurrentStep([SetCommitQueueMinusFlagOnPatch(), BlockPullRequest()])
@@ -4246,7 +4246,7 @@
patch_id = self.getProperty('patch_id', '')
message = 'Unable to find any modified ChangeLog in Patch {}'.format(patch_id)
if self.getProperty('buildername', '').lower() == 'commit-queue':
-self.setProperty('bugzilla_comment_text', message.replace('Patch', 'Attachment'))
+self.setProperty('comment_text', message.replace('Patch', 'Attachment'))
self.setProperty('build_finish_summary', message)
[webkit-changes] [291307] trunk/LayoutTests
Title: [291307] trunk/LayoutTests Revision 291307 Author matteo_flo...@apple.com Date 2022-03-15 12:22:07 -0700 (Tue, 15 Mar 2022) Log Message [ iOS ] ASSERTION FAILED: m_isWaitingForDidUpdateGeometry on accessibility/visible-character-range.html https://bugs.webkit.org/show_bug.cgi?id=237557 Unreviewed test gardening. * platform/ios-simulator-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (291306 => 291307) --- trunk/LayoutTests/ChangeLog 2022-03-15 18:53:28 UTC (rev 291306) +++ trunk/LayoutTests/ChangeLog 2022-03-15 19:22:07 UTC (rev 291307) @@ -1,3 +1,12 @@ +2022-03-15 Matteo Flores + +[ iOS ] ASSERTION FAILED: m_isWaitingForDidUpdateGeometry on accessibility/visible-character-range.html +https://bugs.webkit.org/show_bug.cgi?id=237557 + +Unreviewed test gardening. + +* platform/ios-simulator-wk2/TestExpectations: + 2022-03-15 Lauro Moura [GLIB] Unreviewed gardening Modified: trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations (291306 => 291307) --- trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations 2022-03-15 18:53:28 UTC (rev 291306) +++ trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations 2022-03-15 19:22:07 UTC (rev 291307) @@ -108,6 +108,8 @@ webkit.org/b/203112 scrollingcoordinator/ios/ui-scroll-fixed.html [ Pass Failure ] +webkit.org/b/237557 [ Debug ] accessibility/visible-character-range.html [ Crash ] + webkit.org/b/215033 imported/w3c/web-platform-tests/websockets/cookies/third-party-cookie-accepted.https.html [ Pass Failure ] webkit.org/b/215216 imported/w3c/web-platform-tests/svg/import/interact-zoom-01-t-manual.svg [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291306] trunk/Source/WebCore
Title: [291306] trunk/Source/WebCore
Revision 291306
Author cdu...@apple.com
Date 2022-03-15 11:53:28 -0700 (Tue, 15 Mar 2022)
Log Message
Fix SQL statement in ApplicationCacheStorage::verifySchemaVersion()
https://bugs.webkit.org/show_bug.cgi?id=237905
Reviewed by Geoffrey Garen.
This was leading to the following logging:
`SQLiteDatabase::prepareStatement: Failed to prepare statement PRAGMA user_version=%7`
* loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::ApplicationCacheStorage::verifySchemaVersion):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (291305 => 291306)
--- trunk/Source/WebCore/ChangeLog 2022-03-15 18:47:49 UTC (rev 291305)
+++ trunk/Source/WebCore/ChangeLog 2022-03-15 18:53:28 UTC (rev 291306)
@@ -1,3 +1,16 @@
+2022-03-15 Chris Dumez
+
+Fix SQL statement in ApplicationCacheStorage::verifySchemaVersion()
+https://bugs.webkit.org/show_bug.cgi?id=237905
+
+Reviewed by Geoffrey Garen.
+
+This was leading to the following logging:
+`SQLiteDatabase::prepareStatement: Failed to prepare statement PRAGMA user_version=%7`
+
+* loader/appcache/ApplicationCacheStorage.cpp:
+(WebCore::ApplicationCacheStorage::verifySchemaVersion):
+
2022-03-15 Antti Koivisto
background-clip:text doesn't work with display:flex
Modified: trunk/Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp (291305 => 291306)
--- trunk/Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp 2022-03-15 18:47:49 UTC (rev 291305)
+++ trunk/Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp 2022-03-15 18:53:28 UTC (rev 291306)
@@ -567,7 +567,7 @@
SQLiteTransaction setDatabaseVersion(m_database);
setDatabaseVersion.begin();
-auto statement = m_database.prepareStatementSlow(makeString("PRAGMA user_version=%", schemaVersion));
+auto statement = m_database.prepareStatementSlow(makeString("PRAGMA user_version=", schemaVersion));
if (!statement)
return;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291305] trunk/Source/WTF
Title: [291305] trunk/Source/WTF Revision 291305 Author ph...@webkit.org Date 2022-03-15 11:47:49 -0700 (Tue, 15 Mar 2022) Log Message Unreviewed, CMake Debug build fix attempt after 248407@main * wtf/CMakeLists.txt: Include StackCheck source unit. Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/CMakeLists.txt Diff Modified: trunk/Source/WTF/ChangeLog (291304 => 291305) --- trunk/Source/WTF/ChangeLog 2022-03-15 17:39:30 UTC (rev 291304) +++ trunk/Source/WTF/ChangeLog 2022-03-15 18:47:49 UTC (rev 291305) @@ -1,3 +1,9 @@ +2022-03-15 Philippe Normand + +Unreviewed, CMake Debug build fix attempt after 248407@main + +* wtf/CMakeLists.txt: Include StackCheck source unit. + 2022-03-15 Aditya Keerthi [iOS] Indefinite hang when printing using a UIPrintPageRenderer Modified: trunk/Source/WTF/wtf/CMakeLists.txt (291304 => 291305) --- trunk/Source/WTF/wtf/CMakeLists.txt 2022-03-15 17:39:30 UTC (rev 291304) +++ trunk/Source/WTF/wtf/CMakeLists.txt 2022-03-15 18:47:49 UTC (rev 291305) @@ -471,6 +471,7 @@ SixCharacterHash.cpp SmallSet.cpp StackBounds.cpp +StackCheck.cpp StackPointer.cpp StackStats.cpp StackTrace.cpp ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291304] trunk
Title: [291304] trunk Revision 291304 Author akeer...@apple.com Date 2022-03-15 10:39:30 -0700 (Tue, 15 Mar 2022) Log Message [iOS] Indefinite hang when printing using a UIPrintPageRenderer https://bugs.webkit.org/show_bug.cgi?id=237835 rdar://90002387 Reviewed by Devin Rousso. Source/WebKit: r290186 adopted UIKit API to support printing web content on a background thread, to avoid blocking the main thread while waiting on PDF data from the web process. However, the changes made the assumption that, with the new API, all printing would be performed on a background thread. While this is the case when using UIPrintInteractionController, clients can also print using UIPrintPageRenderer on the main thread. The background thread logic waits on a semaphore, until PDF data is received on the main thread. However, if the logic runs on the main thread, it will wait on the semaphore indefinitely. To fix, restore the original sync IPC codepath when performing printing on the main thread. Additionally, make the BinarySemaphore a unique_ptr, so that it can be signalled and reset in failure scenarios, regardless of whether a thread was waiting on the semaphore. This change also allows us to avoid creating the BinarySemaphore unless it is actually needed. All uses of HAVE(UIKIT_BACKGROUND_THREAD_PRINTING) are removed, as the API adoption only involves a method override, which is harmless in builds that lack support for the new API. * UIProcess/WebPageProxy.h: * UIProcess/_WKWebViewPrintFormatter.mm: * UIProcess/_WKWebViewPrintFormatterInternal.h: * UIProcess/ios/WKContentView.mm: (-[WKContentView _processDidExit]): (-[WKContentView _wk_pageCountForPrintFormatter:]): (-[WKContentView _waitForDrawToPDFCallbackIfNeeded]): (-[WKContentView _wk_printedDocument]): * UIProcess/ios/WKPDFView.mm: * UIProcess/ios/WebPageProxyIOS.mm: * WebProcess/WebPage/WebPage.h: * WebProcess/WebPage/WebPage.messages.in: * WebProcess/WebPage/ios/WebPageIOS.mm: Source/WTF: Remove unused HAVE macro. * wtf/PlatformHave.h: Tools: Add API test coverage for printing web content to a PDF, using a UIPrintPageRenderer (which uses the main thread) and a UIPrintInteractionController (which uses a background thread). * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: (TEST): Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/PlatformHave.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/WebPageProxy.h trunk/Source/WebKit/UIProcess/_WKWebViewPrintFormatter.mm trunk/Source/WebKit/UIProcess/_WKWebViewPrintFormatterInternal.h trunk/Source/WebKit/UIProcess/ios/WKContentView.mm trunk/Source/WebKit/UIProcess/ios/WKPDFView.mm trunk/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm trunk/Source/WebKit/WebProcess/WebPage/WebPage.h trunk/Source/WebKit/WebProcess/WebPage/WebPage.messages.in trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm Diff Modified: trunk/Source/WTF/ChangeLog (291303 => 291304) --- trunk/Source/WTF/ChangeLog 2022-03-15 17:36:18 UTC (rev 291303) +++ trunk/Source/WTF/ChangeLog 2022-03-15 17:39:30 UTC (rev 291304) @@ -1,3 +1,15 @@ +2022-03-15 Aditya Keerthi + +[iOS] Indefinite hang when printing using a UIPrintPageRenderer +https://bugs.webkit.org/show_bug.cgi?id=237835 +rdar://90002387 + +Reviewed by Devin Rousso. + +Remove unused HAVE macro. + +* wtf/PlatformHave.h: + 2022-03-15 Jer Noble [Cocoa] Adopt AVAssetPrefersSandboxedParsingOptionKey Modified: trunk/Source/WTF/wtf/PlatformHave.h (291303 => 291304) --- trunk/Source/WTF/wtf/PlatformHave.h 2022-03-15 17:36:18 UTC (rev 291303) +++ trunk/Source/WTF/wtf/PlatformHave.h 2022-03-15 17:39:30 UTC (rev 291304) @@ -1223,7 +1223,3 @@ #if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 13) || (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 16) || (PLATFORM(WATCHOS) && __WATCH_OS_VERSION_MIN_REQUIRED >= 9) #define HAVE_SAFE_BROWSING_RESULT_DETAILS 1 #endif - -#if (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 16) -#define HAVE_UIKIT_BACKGROUND_THREAD_PRINTING 1 -#endif Modified: trunk/Source/WebKit/ChangeLog (291303 => 291304) --- trunk/Source/WebKit/ChangeLog 2022-03-15 17:36:18 UTC (rev 291303) +++ trunk/Source/WebKit/ChangeLog 2022-03-15 17:39:30 UTC (rev 291304) @@ -1,3 +1,47 @@ +2022-03-15 Aditya Keerthi + +[iOS] Indefinite hang when printing using a UIPrintPageRenderer +https://bugs.webkit.org/show_bug.cgi?id=237835 +rdar://90002387 + +Reviewed by Devin Rousso. + +r290186 adopted UIKit API to support printing web content on a +background thread, to avoid blocking the main thread while waiting +on PDF data from the web process. However, the changes made the +assumption that, with the new API, all printing would be performed on +a background thread. While this is
[webkit-changes] [291303] trunk
Title: [291303] trunk
Revision 291303
Author an...@apple.com
Date 2022-03-15 10:36:18 -0700 (Tue, 15 Mar 2022)
Log Message
background-clip:text doesn't work with display:flex
https://bugs.webkit.org/show_bug.cgi?id=169125
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
* web-platform-tests/css/css-backgrounds/background-clip/clip-text-flex-expected.html: Added.
* web-platform-tests/css/css-backgrounds/background-clip/clip-text-flex-ref.html: Added.
* web-platform-tests/css/css-backgrounds/background-clip/clip-text-flex.html: Added.
Source/WebCore:
Tests: imported/w3c/web-platform-tests/css/css-backgrounds/background-clip/clip-text-flex.html
* rendering/RenderElement.cpp:
(WebCore::RenderElement::paintAsInlineBlock):
Flexbox children paint as inline blocks. This path didn't support text clip paint phase.
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderElement.cpp
Added Paths
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-clip/clip-text-flex-expected.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-clip/clip-text-flex-ref.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-clip/clip-text-flex.html
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (291302 => 291303)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2022-03-15 17:31:04 UTC (rev 291302)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-03-15 17:36:18 UTC (rev 291303)
@@ -1,3 +1,15 @@
+2022-03-15 Antti Koivisto
+
+background-clip:text doesn't work with display:flex
+https://bugs.webkit.org/show_bug.cgi?id=169125
+
+
+Reviewed by Simon Fraser.
+
+* web-platform-tests/css/css-backgrounds/background-clip/clip-text-flex-expected.html: Added.
+* web-platform-tests/css/css-backgrounds/background-clip/clip-text-flex-ref.html: Added.
+* web-platform-tests/css/css-backgrounds/background-clip/clip-text-flex.html: Added.
+
2022-03-15 Joseph Griego
Expose some web APIs on Shadow Realms and Worklets
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-clip/clip-text-flex-expected.html (0 => 291303)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-clip/clip-text-flex-expected.html (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-clip/clip-text-flex-expected.html 2022-03-15 17:36:18 UTC (rev 291303)
@@ -0,0 +1,16 @@
+
+
+.clip {
+ font-size: 80px;
+ color: green;
+}
+.flex {
+display: flex;
+}
+.inline-flex {
+display: inline-flex;
+}
+
+flex
+inline-flex
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-clip/clip-text-flex-ref.html (0 => 291303)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-clip/clip-text-flex-ref.html (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-clip/clip-text-flex-ref.html 2022-03-15 17:36:18 UTC (rev 291303)
@@ -0,0 +1,16 @@
+
+
+.clip {
+ font-size: 80px;
+ color: green;
+}
+.flex {
+display: flex;
+}
+.inline-flex {
+display: inline-flex;
+}
+
+flex
+inline-flex
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-clip/clip-text-flex.html (0 => 291303)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-clip/clip-text-flex.html (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-clip/clip-text-flex.html 2022-03-15 17:36:18 UTC (rev 291303)
@@ -0,0 +1,21 @@
+
+background-clip:text with display:flex
+
+.clip {
+ font-size: 80px;
+ color: transparent;
+ background-color: green;
+ background-clip: text;
+}
+.flex {
+display: flex;
+}
+.inline-flex {
+display: inline-flex;
+}
+
+flex
+inline-flex
Modified: trunk/Source/WebCore/ChangeLog (291302 => 291303)
--- trunk/Source/WebCore/ChangeLog 2022-03-15 17:31:04 UTC (rev 291302)
+++ trunk/Source/WebCore/ChangeLog 2022-03-15 17:36:18 UTC (rev 291303)
@@ -1,3 +1,18 @@
+2022-03-15 Antti Koivisto
+
+background-clip:text doesn't work with display:flex
+https://bugs.webkit.org/show_bug.cgi?id=169125
+
+
+Reviewed by Simon Fraser.
+
+Tests: imported/w3c/web-platform-tests/css/css-backgrounds/background-clip/clip-text-flex.html
+
+* rendering/RenderElement.cpp:
+(WebCore::RenderElement::paintAsInlineBlock):
+
+Flexbox children paint as inline blocks. This path didn't support text clip paint phase.
+
2022-03-15 Alex Christensen
Stop using DYLD_INTERPOSE
Modified: trunk/Source/WebCore/rendering/RenderElement.cpp (291302 => 291303)
---
[webkit-changes] [291302] trunk
Title: [291302] trunk Revision 291302 Author commit-qu...@webkit.org Date 2022-03-15 10:31:04 -0700 (Tue, 15 Mar 2022) Log Message Stop using DYLD_INTERPOSE https://bugs.webkit.org/show_bug.cgi?id=237867 Patch by Alex Christensen on 2022-03-15 Reviewed by Anders Carlsson. Source/WebCore: It never worked on iOS, and it doesn't work on M1 Macs. It used to be used for NPAPI and the SecItemShim, but those have been removed and updated to use other methods that work on M1 Macs. It is currently only used for tests in editing/secure-input which continue to pass as much as they did before this change. * Configurations/WebCoreTestShim.xcconfig: Removed. * WebCore.xcodeproj/project.pbxproj: * platform/mac/DynamicLinkerInterposing.h: Removed. * testing/WebCoreTestShimLibrary.cpp: Removed. Tools: * Scripts/webkitpy/port/mac.py: (MacPort.setup_environ_for_server): * Scripts/webkitpy/port/mac_unittest.py: (MacTest.test_setup_environ_for_server): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/port/mac.py trunk/Tools/Scripts/webkitpy/port/mac_unittest.py Removed Paths trunk/Source/WebCore/Configurations/WebCoreTestShim.xcconfig trunk/Source/WebCore/platform/mac/DynamicLinkerInterposing.h trunk/Source/WebCore/testing/WebCoreTestShimLibrary.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (291301 => 291302) --- trunk/Source/WebCore/ChangeLog 2022-03-15 17:24:09 UTC (rev 291301) +++ trunk/Source/WebCore/ChangeLog 2022-03-15 17:31:04 UTC (rev 291302) @@ -1,3 +1,21 @@ +2022-03-15 Alex Christensen + +Stop using DYLD_INTERPOSE +https://bugs.webkit.org/show_bug.cgi?id=237867 + +Reviewed by Anders Carlsson. + +It never worked on iOS, and it doesn't work on M1 Macs. +It used to be used for NPAPI and the SecItemShim, +but those have been removed and updated to use other methods that work on M1 Macs. +It is currently only used for tests in editing/secure-input which continue to pass +as much as they did before this change. + +* Configurations/WebCoreTestShim.xcconfig: Removed. +* WebCore.xcodeproj/project.pbxproj: +* platform/mac/DynamicLinkerInterposing.h: Removed. +* testing/WebCoreTestShimLibrary.cpp: Removed. + 2022-03-15 Antoine Quint [model] model-element/model-element-camera.html is a failure Deleted: trunk/Source/WebCore/Configurations/WebCoreTestShim.xcconfig (291301 => 291302) --- trunk/Source/WebCore/Configurations/WebCoreTestShim.xcconfig 2022-03-15 17:24:09 UTC (rev 291301) +++ trunk/Source/WebCore/Configurations/WebCoreTestShim.xcconfig 2022-03-15 17:31:04 UTC (rev 291302) @@ -1,50 +0,0 @@ -// Copyright (C) 2013, 2014 Apple Inc. All rights reserved. -// -// Redistribution and use in source and binary forms, with or without -// modification, are permitted provided that the following conditions -// are met: -// 1. Redistributions of source code must retain the above copyright -//notice, this list of conditions and the following disclaimer. -// 2. Redistributions in binary form must reproduce the above copyright -//notice, this list of conditions and the following disclaimer in the -//documentation and/or other materials provided with the distribution. -// -// THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY -// EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE -// IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR -// PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR -// CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, -// EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, -// PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR -// PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY -// OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT -// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE -// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. - -#include "WebCore.xcconfig" - -INSTALL_PATH = $(INSTALL_PATH_$(CONFIGURATION)); -INSTALL_PATH_Production = $(INSTALL_PATH_Production_$(WK_USE_ALTERNATE_FRAMEWORKS_DIR)) -INSTALL_PATH_Production_NO = /usr/local/lib; -INSTALL_PATH_Production_YES = $(WK_ALTERNATE_FRAMEWORKS_DIR)/usr/local/lib; - -SKIP_INSTALL = $(SKIP_INSTALL_$(FORCE_TOOL_INSTALL)); -SKIP_INSTALL_ = YES; -SKIP_INSTALL_NO = YES; -SKIP_INSTALL_YES = NO; - -DYLIB_INSTALL_NAME_BASE = $(DYLIB_INSTALL_NAME_BASE_$(CONFIGURATION)); -DYLIB_INSTALL_NAME_BASE_Production = $(INSTALL_PATH); -DYLIB_INSTALL_NAME_BASE_Debug = @rpath; -DYLIB_INSTALL_NAME_BASE_Release = $(DYLIB_INSTALL_NAME_BASE_Debug); - -PRODUCT_NAME = WebCoreTestShim; -EXECUTABLE_PREFIX = lib; -EXPORTED_SYMBOLS_FILE = ; -OTHER_LDFLAGS = $(ASAN_OTHER_LDFLAGS); -OTHER_LDFLAGS[sdk=macosx*] = $(ASAN_OTHER_LDFLAGS) -framework Carbon; -
[webkit-changes] [291301] trunk/Source/WebCore
Title: [291301] trunk/Source/WebCore
Revision 291301
Author grao...@webkit.org
Date 2022-03-15 10:24:09 -0700 (Tue, 15 Mar 2022)
Log Message
[model] model-element/model-element-camera.html is a failure
https://bugs.webkit.org/show_bug.cgi?id=237894
rdar://88982597
Reviewed by Tim Horton.
Ensure we have a non-zero contentSize() and model data before attempting to
create a player. Otherwise, we could end up with a zero frame when calling
into ARKit and the model would fail to load and the ready promise would be
rejected, causing this test to fail.
We can change the existing call site to sizeMayHaveChanged() to no longer
check whether we are using a platform layer since sizeMayHaveChanged() now
takes care of checking whether it has a player.
* Modules/model-element/HTMLModelElement.cpp:
(WebCore::HTMLModelElement::createModelPlayer):
(WebCore::HTMLModelElement::sizeMayHaveChanged):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateConfiguration):
(WebCore::RenderLayerBacking::updateGeometry):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/model-element/HTMLModelElement.cpp
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (291300 => 291301)
--- trunk/Source/WebCore/ChangeLog 2022-03-15 17:14:54 UTC (rev 291300)
+++ trunk/Source/WebCore/ChangeLog 2022-03-15 17:24:09 UTC (rev 291301)
@@ -1,3 +1,27 @@
+2022-03-15 Antoine Quint
+
+[model] model-element/model-element-camera.html is a failure
+https://bugs.webkit.org/show_bug.cgi?id=237894
+rdar://88982597
+
+Reviewed by Tim Horton.
+
+Ensure we have a non-zero contentSize() and model data before attempting to
+create a player. Otherwise, we could end up with a zero frame when calling
+into ARKit and the model would fail to load and the ready promise would be
+rejected, causing this test to fail.
+
+We can change the existing call site to sizeMayHaveChanged() to no longer
+check whether we are using a platform layer since sizeMayHaveChanged() now
+takes care of checking whether it has a player.
+
+* Modules/model-element/HTMLModelElement.cpp:
+(WebCore::HTMLModelElement::createModelPlayer):
+(WebCore::HTMLModelElement::sizeMayHaveChanged):
+* rendering/RenderLayerBacking.cpp:
+(WebCore::RenderLayerBacking::updateConfiguration):
+(WebCore::RenderLayerBacking::updateGeometry):
+
2022-03-15 Brandon Stewart
Line Builder and Content Breaker out of sync
Modified: trunk/Source/WebCore/Modules/model-element/HTMLModelElement.cpp (291300 => 291301)
--- trunk/Source/WebCore/Modules/model-element/HTMLModelElement.cpp 2022-03-15 17:14:54 UTC (rev 291300)
+++ trunk/Source/WebCore/Modules/model-element/HTMLModelElement.cpp 2022-03-15 17:24:09 UTC (rev 291301)
@@ -255,6 +255,13 @@
void HTMLModelElement::createModelPlayer()
{
+if (!m_model)
+return;
+
+auto size = contentSize();
+if (size.isEmpty())
+return;
+
ASSERT(document().page());
m_modelPlayer = document().page()->modelPlayerProvider().createModelPlayer(*this);
if (!m_modelPlayer) {
@@ -264,7 +271,7 @@
// FIXME: We need to tell the player if the size changes as well, so passing this
// in with load probably doesn't make sense.
-m_modelPlayer->load(*m_model, contentSize());
+m_modelPlayer->load(*m_model, size);
}
bool HTMLModelElement::usesPlatformLayer() const
@@ -281,7 +288,10 @@
void HTMLModelElement::sizeMayHaveChanged()
{
-m_modelPlayer->sizeDidChange(contentSize());
+if (m_modelPlayer)
+m_modelPlayer->sizeDidChange(contentSize());
+else
+createModelPlayer();
}
void HTMLModelElement::didFinishLoading(ModelPlayer& modelPlayer)
Modified: trunk/Source/WebCore/rendering/RenderLayerBacking.cpp (291300 => 291301)
--- trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2022-03-15 17:14:54 UTC (rev 291300)
+++ trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2022-03-15 17:24:09 UTC (rev 291301)
@@ -1110,6 +1110,8 @@
else if (auto model = element->model())
m_graphicsLayer->setContentsToModel(WTFMove(model), element->isInteractive() ? GraphicsLayer::ModelInteraction::Enabled : GraphicsLayer::ModelInteraction::Disabled);
+element->sizeMayHaveChanged();
+
layerConfigChanged = true;
}
#endif
@@ -1518,11 +1520,8 @@
setContentsNeedDisplay();
#if ENABLE(MODEL_ELEMENT)
-if (is(renderer())) {
-auto* element = downcast(renderer().element());
-if (element->usesPlatformLayer())
-element->sizeMayHaveChanged();
-}
+if (is(renderer()))
+downcast(renderer().element())->sizeMayHaveChanged();
#endif
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
[webkit-changes] [291300] trunk/Tools/Scripts/webkitpy/xcode/simulated_device.py
Title: [291300] trunk/Tools/Scripts/webkitpy/xcode/simulated_device.py
Revision 291300
Author ryanhad...@apple.com
Date 2022-03-15 10:14:54 -0700 (Tue, 15 Mar 2022)
Log Message
[webkitpy] Make SimulatedDevice.is_usable check more robust
https://bugs.webkit.org/show_bug.cgi?id=237795
Reviewed by Jonathan Bedard.
Rather than searching for the service name in the output of `launchctl list`,
pass in the name as an additional argument so that it prints out information
about that particular service. I have verified that this works in local testing
for both iOS and watchOS simulators.
* Scripts/webkitpy/xcode/simulated_device.py:
(SimulatedDevice):
(SimulatedDevice.is_usable):
Canonical link: https://commits.webkit.org/248439@main
Modified Paths
trunk/Tools/Scripts/webkitpy/xcode/simulated_device.py
Diff
Modified: trunk/Tools/Scripts/webkitpy/xcode/simulated_device.py (291299 => 291300)
--- trunk/Tools/Scripts/webkitpy/xcode/simulated_device.py 2022-03-15 17:06:49 UTC (rev 291299)
+++ trunk/Tools/Scripts/webkitpy/xcode/simulated_device.py 2022-03-15 17:14:54 UTC (rev 291300)
@@ -540,8 +540,8 @@
]
UI_MANAGER_SERVICE = {
-'iOS': 'com.apple.springboard.services',
-'watchOS': 'com.apple.carousel.sessionservice',
+'iOS': 'com.apple.SpringBoard',
+'watchOS': 'com.apple.Carousel',
}
def __init__(self, name, udid, host, device_type, build_version):
@@ -596,8 +596,8 @@
_log.debug(u'{} has no service to check if the device is usable'.format(self.device_type.software_variant))
return True
-system_processes = self.executive.run_command([SimulatedDeviceManager.xcrun, 'simctl', 'spawn', self.udid, 'launchctl', 'print', 'system'], decode_output=True, return_stderr=False)
-if re.search(r'"{}"'.format(service), system_processes) or re.search(r'A\s+{}'.format(service), system_processes):
+exit_code = self.executive.run_command([SimulatedDeviceManager.xcrun, 'simctl', 'spawn', self.udid, 'launchctl', 'list', service], return_exit_code=True)
+if exit_code == 0:
return True
return False
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291299] trunk/Source/WebCore
Title: [291299] trunk/Source/WebCore
Revision 291299
Author brandonstew...@apple.com
Date 2022-03-15 10:06:49 -0700 (Tue, 15 Mar 2022)
Log Message
Line Builder and Content Breaker out of sync
https://bugs.webkit.org/show_bug.cgi?id=237903
Reviewed by Simon Fraser.
Line builder and content breaker could become out of sync in the case where
the first line style was different than following styles. This could result
in issues with wrapping later on.
* layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::handleInlineContent):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (291298 => 291299)
--- trunk/Source/WebCore/ChangeLog 2022-03-15 16:56:07 UTC (rev 291298)
+++ trunk/Source/WebCore/ChangeLog 2022-03-15 17:06:49 UTC (rev 291299)
@@ -1,3 +1,17 @@
+2022-03-15 Brandon Stewart
+
+Line Builder and Content Breaker out of sync
+https://bugs.webkit.org/show_bug.cgi?id=237903
+
+Reviewed by Simon Fraser.
+
+Line builder and content breaker could become out of sync in the case where
+the first line style was different than following styles. This could result
+in issues with wrapping later on.
+
+* layout/formattingContexts/inline/InlineLineBuilder.cpp:
+(WebCore::Layout::LineBuilder::handleInlineContent):
+
2022-03-15 Jer Noble
[Cocoa] Adopt AVAssetPrefersSandboxedParsingOptionKey
Modified: trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp (291298 => 291299)
--- trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp 2022-03-15 16:56:07 UTC (rev 291298)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp 2022-03-15 17:06:49 UTC (rev 291299)
@@ -953,9 +953,14 @@
if (lineCandidate.inlineContent.hasTrailingSoftWrapOpportunity() && m_line.hasContent()) {
auto& trailingRun = candidateRuns.last();
auto& trailingInlineItem = trailingRun.inlineItem;
+
// Note that wrapping here could be driven both by the style of the parent and the inline item itself.
// e.g inline boxes set the wrapping rules for their content and not for themselves.
-auto& parentStyle = trailingInlineItem.layoutBox().parent().style();
+auto& layoutBoxParent = trailingInlineItem.layoutBox().parent();
+
+// Need to ensure we use the correct style here, so the content breaker and line builder remain in sync.
+auto& parentStyle = isFirstLine() ? layoutBoxParent.firstLineStyle() : layoutBoxParent.style();
+
auto isWrapOpportunity = TextUtil::isWrappingAllowed(parentStyle);
if (!isWrapOpportunity && (trailingInlineItem.isInlineBoxStart() || trailingInlineItem.isInlineBoxEnd()))
isWrapOpportunity = TextUtil::isWrappingAllowed(trailingRun.style);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291298] trunk/LayoutTests
Title: [291298] trunk/LayoutTests Revision 291298 Author lmo...@igalia.com Date 2022-03-15 09:56:07 -0700 (Tue, 15 Mar 2022) Log Message [GLIB] Unreviewed gardening https://bugs.webkit.org/show_bug.cgi?id=237902 * platform/glib/TestExpectations: * platform/gtk/TestExpectations: * platform/wpe/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/glib/TestExpectations trunk/LayoutTests/platform/gtk/TestExpectations trunk/LayoutTests/platform/wpe/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (291297 => 291298) --- trunk/LayoutTests/ChangeLog 2022-03-15 16:52:02 UTC (rev 291297) +++ trunk/LayoutTests/ChangeLog 2022-03-15 16:56:07 UTC (rev 291298) @@ -1,3 +1,12 @@ +2022-03-15 Lauro Moura + +[GLIB] Unreviewed gardening +https://bugs.webkit.org/show_bug.cgi?id=237902 + +* platform/glib/TestExpectations: +* platform/gtk/TestExpectations: +* platform/wpe/TestExpectations: + 2022-03-15 Matteo Flores A combination of scrolling and a content change can leave a fixed layer in the wrong place Modified: trunk/LayoutTests/platform/glib/TestExpectations (291297 => 291298) --- trunk/LayoutTests/platform/glib/TestExpectations 2022-03-15 16:52:02 UTC (rev 291297) +++ trunk/LayoutTests/platform/glib/TestExpectations 2022-03-15 16:56:07 UTC (rev 291298) @@ -911,6 +911,8 @@ webkit.org/b/237872 webrtc/vp8-then-h264.html [ Crash ] +webkit.org/b/237901 media/media-source/media-source-interruption-with-resume-allowing-play.html [ Slow ] + # # End of GStreamer-related bugs # @@ -1096,6 +1098,12 @@ # Previous expectation: webkit.org/b/173412 fast/scrolling/overflow-scrollable-after-back.html [ Failure Pass ] webkit.org/b/212202 fast/scrolling/overflow-scrollable-after-back.html [ Skip ] +# Previous: webkit.org/b/223729 [ Release ] css3/scroll-snap/scroll-snap-wheel-event.html [ Pass Failure ] +# Previous: webkit.org/b/223729 [ Debug ] css3/scroll-snap/scroll-snap-wheel-event.html [ Pass ] +webkit.org/b/212202 css3/scroll-snap/scroll-snap-wheel-event.html [ Skip ] + + + # Warning: this test is expected to fail in the global expectations file, but # we expect it to Pass because we support RTL scrollbars. When fixed, it should # not be removed, but moved to the expected passes section of this file. @@ -1784,6 +1792,9 @@ # UNSUPPORTED tests. Things we must skip. # +# Tests behavior specific to MediaSessionManagerCocoa +media/audio-session-category.html [ Skip ] + # This test assumes we cannot play RTSP, but we can. media/unsupported-rtsp.html [ WontFix Skip ] Modified: trunk/LayoutTests/platform/gtk/TestExpectations (291297 => 291298) --- trunk/LayoutTests/platform/gtk/TestExpectations 2022-03-15 16:52:02 UTC (rev 291297) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2022-03-15 16:56:07 UTC (rev 291298) @@ -614,9 +614,6 @@ webkit.org/b/152620 css3/font-variant-petite-caps-synthesis.html [ ImageOnlyFailure ] webkit.org/b/152620 css3/font-variant-small-caps-synthesis.html [ ImageOnlyFailure ] -# monitorWheelEvents doesn't work in this test. -css3/scroll-snap/scroll-snap-wheel-event.html [ Skip ] - # Requires ENABLE(SAMPLING_PROFILER) webkit.org/b/153466 inspector/sampling-profiler [ Skip ] @@ -937,9 +934,6 @@ # End of Crashing tests # -# Tests behavior specific to MediaSessionManagerCocoa -media/audio-session-category.html [ Skip ] - # # 4. FLAKY TESTS # Modified: trunk/LayoutTests/platform/wpe/TestExpectations (291297 => 291298) --- trunk/LayoutTests/platform/wpe/TestExpectations 2022-03-15 16:52:02 UTC (rev 291297) +++ trunk/LayoutTests/platform/wpe/TestExpectations 2022-03-15 16:56:07 UTC (rev 291298) @@ -230,10 +230,6 @@ # We don't yet support EXIF-based resolution webkit.org/b/217821 imported/w3c/web-platform-tests/density-size-correction/ [ Skip ] -# Scrolling -webkit.org/b/223729 [ Release ] css3/scroll-snap/scroll-snap-wheel-event.html [ Pass Failure ] -webkit.org/b/223729 [ Debug ] css3/scroll-snap/scroll-snap-wheel-event.html [ Pass ] - # Scrolling coordinator webkit.org/b/215508 [ Release ] scrollingcoordinator/overflow-proxy-reattach.html [ Pass Timeout ] webkit.org/b/215508 [ Release ] scrollingcoordinator/fixed-node-reattach.html [ Pass Timeout ] @@ -1265,6 +1261,7 @@ webkit.org/b/208188 webgl/2.0.0 [ Skip ] webkit.org/b/208188 webgl/2.0.y [ Skip ] webkit.org/b/208188 webgl/pending/conformance2 [ Skip ]
[webkit-changes] [291297] trunk/Source/WebKit
Title: [291297] trunk/Source/WebKit Revision 291297 Author pvol...@apple.com Date 2022-03-15 09:52:02 -0700 (Tue, 15 Mar 2022) Log Message [macOS][WP] Add required syscall https://bugs.webkit.org/show_bug.cgi?id=237846 Reviewed by Brent Fulgham. Add required syscall to the WebContent process' sandbox on macOS. * WebProcess/com.apple.WebProcess.sb.in: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in Diff Modified: trunk/Source/WebKit/ChangeLog (291296 => 291297) --- trunk/Source/WebKit/ChangeLog 2022-03-15 16:40:55 UTC (rev 291296) +++ trunk/Source/WebKit/ChangeLog 2022-03-15 16:52:02 UTC (rev 291297) @@ -1,3 +1,15 @@ +2022-03-15 Per Arne Vollan + +[macOS][WP] Add required syscall +https://bugs.webkit.org/show_bug.cgi?id=237846 + + +Reviewed by Brent Fulgham. + +Add required syscall to the WebContent process' sandbox on macOS. + +* WebProcess/com.apple.WebProcess.sb.in: + 2022-03-15 Jer Noble [Cocoa] Adopt AVAssetPrefersSandboxedParsingOptionKey Modified: trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (291296 => 291297) --- trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2022-03-15 16:40:55 UTC (rev 291296) +++ trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2022-03-15 16:52:02 UTC (rev 291297) @@ -2009,6 +2009,8 @@ #if !PLATFORM(MAC) || __MAC_OS_X_VERSION_MIN_REQUIRED < 12 SYS_rmdir #endif +;; FIXME: SYS_setsockopt can be removed when contentfiltering has moved to the Network process +SYS_setsockopt ;; SYS_shm_open SYS_sigaction SYS_sysctl ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291296] trunk/Source
Title: [291296] trunk/Source Revision 291296 Author jer.no...@apple.com Date 2022-03-15 09:40:55 -0700 (Tue, 15 Mar 2022) Log Message [Cocoa] Adopt AVAssetPrefersSandboxedParsingOptionKey https://bugs.webkit.org/show_bug.cgi?id=237832 Reviewed by Eric Carlson. Source/WebCore: Adopt a AVURLAsset option which would allow the media file parser to run out-of-process. Because this adoption may have a performance impact (though it should not affect the functionality of AVURLAsset), add a Setting to disable this adoption at runtime for the purpose of A/B testing. * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::requestInstallMissingPlugins): * html/HTMLMediaElement.h: * platform/graphics/MediaPlayer.h: (WebCore::MediaPlayerClient::mediaPlayerPrefersSandboxedParsing const): * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Source/WebCore/PAL: * pal/cocoa/AVFoundationSoftLink.h: Source/WebKit: Propogate the `prefersSandboxedParsing()` property across to the GPU process. * GPUProcess/media/RemoteMediaPlayerProxy.h: * GPUProcess/media/RemoteMediaPlayerProxyConfiguration.h: (WebKit::RemoteMediaPlayerProxyConfiguration::encode const): (WebKit::RemoteMediaPlayerProxyConfiguration::decode): * WebProcess/GPU/media/RemoteMediaPlayerManager.cpp: (WebKit::RemoteMediaPlayerManager::createRemoteMediaPlayer): Source/WTF: * Scripts/Preferences/WebPreferencesInternal.yaml: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/PAL/ChangeLog trunk/Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.h trunk/Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.mm trunk/Source/WebCore/html/HTMLMediaElement.cpp trunk/Source/WebCore/html/HTMLMediaElement.h trunk/Source/WebCore/platform/graphics/MediaPlayer.h trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.h trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxyConfiguration.h trunk/Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerManager.cpp Diff Modified: trunk/Source/WTF/ChangeLog (291295 => 291296) --- trunk/Source/WTF/ChangeLog 2022-03-15 16:37:20 UTC (rev 291295) +++ trunk/Source/WTF/ChangeLog 2022-03-15 16:40:55 UTC (rev 291296) @@ -1,3 +1,13 @@ +2022-03-15 Jer Noble + +[Cocoa] Adopt AVAssetPrefersSandboxedParsingOptionKey +https://bugs.webkit.org/show_bug.cgi?id=237832 + + +Reviewed by Eric Carlson. + +* Scripts/Preferences/WebPreferencesInternal.yaml: + 2022-03-14 Mark Lam Enhance StackCheck debugging support and bump up the ASAN reserved zone size. Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml (291295 => 291296) --- trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml 2022-03-15 16:37:20 UTC (rev 291295) +++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml 2022-03-15 16:40:55 UTC (rev 291296) @@ -745,6 +745,19 @@ "HAVE(UIKIT_WEBKIT_INTERNALS)": false default: true +PreferSandboxedMediaParsing: + type: bool + humanReadableName: "Prefer Sandboxed Parsing of Media" + humanReadableDescription: "Prefer parsing media out-of-process in a sandboxed service" + condition: ENABLE(VIDEO) + defaultValue: +WebCore: + default: true +WebKitLegacy: + default: true +WebKit: + default: true + ReplayCGDisplayListsIntoBackingStore: type: bool humanReadableName: "CG Display Lists: Replay for Testing" Modified: trunk/Source/WebCore/ChangeLog (291295 => 291296) --- trunk/Source/WebCore/ChangeLog 2022-03-15 16:37:20 UTC (rev 291295) +++ trunk/Source/WebCore/ChangeLog 2022-03-15 16:40:55 UTC (rev 291296) @@ -1,3 +1,24 @@ +2022-03-15 Jer Noble + +[Cocoa] Adopt AVAssetPrefersSandboxedParsingOptionKey +https://bugs.webkit.org/show_bug.cgi?id=237832 + + +Reviewed by Eric Carlson. + +Adopt a AVURLAsset option which would allow the media file parser to run out-of-process. +Because this adoption may have a performance impact (though it should not affect the +functionality of AVURLAsset), add a Setting to disable this adoption at runtime for the +purpose of A/B testing. + +* html/HTMLMediaElement.cpp: +(WebCore::HTMLMediaElement::requestInstallMissingPlugins): +* html/HTMLMediaElement.h: +* platform/graphics/MediaPlayer.h: +(WebCore::MediaPlayerClient::mediaPlayerPrefersSandboxedParsing const): +* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: +(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): + 2022-03-15 Joseph Griego Expose some web APIs on Shadow Realms and Worklets Modified:
[webkit-changes] [291294] trunk/Source/WebCore
Title: [291294] trunk/Source/WebCore
Revision 291294
Author lmo...@igalia.com
Date 2022-03-15 09:18:28 -0700 (Tue, 15 Mar 2022)
Log Message
[GStreamer] Unreviewed, tentative clang build fix after 248419@main
https://bugs.webkit.org/show_bug.cgi?id=237897
Adds static_cast to avoid "non-const-_expression_ cannot be narrowed"
error.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::pushDMABufToCompositor):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (291293 => 291294)
--- trunk/Source/WebCore/ChangeLog 2022-03-15 16:13:55 UTC (rev 291293)
+++ trunk/Source/WebCore/ChangeLog 2022-03-15 16:18:28 UTC (rev 291294)
@@ -1,3 +1,14 @@
+2022-03-15 Lauro Moura
+
+[GStreamer] Unreviewed, tentative clang build fix after 248419@main
+https://bugs.webkit.org/show_bug.cgi?id=237897
+
+Adds static_cast to avoid "non-const-_expression_ cannot be narrowed"
+error.
+
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+(WebCore::MediaPlayerPrivateGStreamer::pushDMABufToCompositor):
+
2022-03-15 Enrique Ocaña González
[GStreamer] clarify playback errors with MediaError.message
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (291293 => 291294)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2022-03-15 16:13:55 UTC (rev 291293)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2022-03-15 16:18:28 UTC (rev 291294)
@@ -3117,7 +3117,7 @@
// and copy over the data for each plane.
GBMBufferSwapchain::BufferDescription bufferDescription {
DMABufFormat::create(fourccValue(GST_VIDEO_INFO_FORMAT())),
-GST_VIDEO_INFO_WIDTH(), GST_VIDEO_INFO_HEIGHT(),
+static_castGST_VIDEO_INFO_WIDTH(), static_castGST_VIDEO_INFO_HEIGHT(),
};
if (bufferDescription.format.fourcc == DMABufFormat::FourCC::Invalid)
return;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291293] trunk/LayoutTests/imported/w3c
Title: [291293] trunk/LayoutTests/imported/w3c Revision 291293 Author an...@apple.com Date 2022-03-15 09:13:55 -0700 (Tue, 15 Mar 2022) Log Message [CSS Container Queries] Some more WPT updates https://bugs.webkit.org/show_bug.cgi?id=237890 Reviewed by Antoine Quint. * web-platform-tests/css/css-contain/container-queries/canvas-as-container-005.html: * web-platform-tests/css/css-contain/container-queries/canvas-as-container-006.html: * web-platform-tests/css/css-contain/container-queries/chrome-legacy-skip-recalc.html: * web-platform-tests/css/css-contain/container-queries/container-computed-expected.txt: * web-platform-tests/css/css-contain/container-queries/container-computed.html: * web-platform-tests/css/css-contain/container-queries/container-parsing-expected.txt: * web-platform-tests/css/css-contain/container-queries/container-parsing.html: * web-platform-tests/css/css-contain/container-queries/container-type-parsing-expected.txt: * web-platform-tests/css/css-contain/container-queries/container-type-parsing.html: * web-platform-tests/css/css-contain/container-queries/container-units-animation-expected.txt: * web-platform-tests/css/css-contain/container-queries/container-units-animation.html: * web-platform-tests/css/css-contain/container-queries/container-units-basic.html: * web-platform-tests/css/css-contain/container-queries/container-units-computational-independence-expected.txt: * web-platform-tests/css/css-contain/container-queries/container-units-computational-independence.html: * web-platform-tests/css/css-contain/container-queries/container-units-invalidation-expected.txt: * web-platform-tests/css/css-contain/container-queries/container-units-invalidation.html: * web-platform-tests/css/css-contain/container-queries/container-units-selection.html: * web-platform-tests/css/css-contain/container-queries/container-units-small-viewport-fallback.html: * web-platform-tests/css/css-contain/container-queries/container-units-typed-om-expected.txt: * web-platform-tests/css/css-contain/container-queries/container-units-typed-om.html: * web-platform-tests/css/css-contain/container-queries/display-none-expected.txt: * web-platform-tests/css/css-contain/container-queries/display-none.html: * web-platform-tests/css/css-contain/container-queries/fragmented-container-001.html: * web-platform-tests/css/css-contain/container-queries/multicol-container-001.html: * web-platform-tests/css/css-contain/container-queries/sibling-layout-dependency-expected.txt: Added. * web-platform-tests/css/css-contain/container-queries/sibling-layout-dependency.html: Added. * web-platform-tests/css/css-contain/container-queries/svg-foreignobject-no-size-container.html: * web-platform-tests/css/css-contain/container-queries/svg-root-size-container.html: * web-platform-tests/css/css-contain/container-queries/table-inside-container-changing-display.html: * web-platform-tests/css/css-contain/container-queries/w3c-import.log: * web-platform-tests/css/css-contain/container-queries/whitespace-update-after-removal.html: Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/canvas-as-container-005.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/canvas-as-container-006.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/chrome-legacy-skip-recalc.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-computed-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-computed.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-parsing-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-parsing.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-type-parsing-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-type-parsing.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-animation-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-animation.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-basic.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-computational-independence-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-computational-independence.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-invalidation-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-invalidation.html
[webkit-changes] [291292] trunk/Tools
Title: [291292] trunk/Tools
Revision 291292
Author jbed...@apple.com
Date 2022-03-15 08:38:21 -0700 (Tue, 15 Mar 2022)
Log Message
[Merge-Queue] Fail draft PRs
https://bugs.webkit.org/show_bug.cgi?id=237859
Reviewed by Aakash Jain.
We should never merge a draft pull request.
* Tools/CISupport/ews-build/factories.py:
(MergeQueueFactory.__init__): Verify that provided change is not a draft.
* Tools/CISupport/ews-build/steps.py:
(GitHubMixin._is_pr_draft): Check if pr_json indicates a draft PR.
(ValidateChange.__init__): Accept verifyNoDraft flag.
(ValidateChange.start):
(ValidateChange.fail_build):
(ValidateChange.validate_github): Fail the build if the provided PR is a draft.
* Tools/CISupport/ews-build/steps_unittest.py:
Canonical link: https://commits.webkit.org/248431@main
Modified Paths
trunk/Tools/CISupport/ews-build/factories.py
trunk/Tools/CISupport/ews-build/steps.py
trunk/Tools/CISupport/ews-build/steps_unittest.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/CISupport/ews-build/factories.py (291291 => 291292)
--- trunk/Tools/CISupport/ews-build/factories.py 2022-03-15 15:26:35 UTC (rev 291291)
+++ trunk/Tools/CISupport/ews-build/factories.py 2022-03-15 15:38:21 UTC (rev 291292)
@@ -320,4 +320,4 @@
def __init__(self, platform, configuration=None, architectures=None, additionalArguments=None, **kwargs):
factory.BuildFactory.__init__(self)
self.addStep(ConfigureBuild(platform=platform, configuration=configuration, architectures=architectures, buildOnly=False, triggers=None, remotes=None, additionalArguments=additionalArguments))
-self.addStep(ValidateChange(verifyMergeQueue=True))
+self.addStep(ValidateChange(verifyMergeQueue=True, verifyNoDraftForMergeQueue=True))
Modified: trunk/Tools/CISupport/ews-build/steps.py (291291 => 291292)
--- trunk/Tools/CISupport/ews-build/steps.py 2022-03-15 15:26:35 UTC (rev 291291)
+++ trunk/Tools/CISupport/ews-build/steps.py 2022-03-15 15:38:21 UTC (rev 291292)
@@ -216,6 +216,11 @@
return 1
return 0
+def _is_pr_draft(self, pr_json):
+if pr_json.get('draft', False):
+return 1
+return 0
+
def should_send_email_for_pr(self, pr_number):
pr_json = self.get_pr_json(pr_number)
if not pr_json:
@@ -1242,6 +1247,7 @@
addURLs=True,
verifycqplus=False,
verifyMergeQueue=False,
+verifyNoDraftForMergeQueue=False,
):
self.verifyObsolete = verifyObsolete
self.verifyBugClosed = verifyBugClosed
@@ -1248,6 +1254,7 @@
self.verifyReviewDenied = verifyReviewDenied
self.verifycqplus = verifycqplus
self.verifyMergeQueue = verifyMergeQueue
+self.verifyNoDraftForMergeQueue = verifyNoDraftForMergeQueue
self.addURLs = addURLs
buildstep.BuildStep.__init__(self)
@@ -1266,6 +1273,13 @@
self.descriptionDone = reason
self.build.buildFinished([reason], SKIPPED)
+def fail_build(self, reason):
+self._addToLog('stdio', reason)
+self.finished(FAILURE)
+self.build.results = FAILURE
+self.descriptionDone = reason
+self.build.buildFinished([reason], FAILURE)
+
def start(self):
patch_id = self.getProperty('patch_id', '')
pr_number = self.getProperty('github.number', '')
@@ -1296,6 +1310,8 @@
if self.verifycqplus and patch_id:
self._addToLog('stdio', 'Change is in commit queue.\n')
self._addToLog('stdio', 'Change has been reviewed.\n')
+if self.verifyNoDraftForMergeQueue and pr_number:
+self._addToLog('stdio', 'Change is not a draft.\n')
if self.verifyMergeQueue and pr_number:
self._addToLog('stdio', 'Change is in merge queue.\n')
self.finished(SUCCESS)
@@ -1361,7 +1377,12 @@
self.skip_build("PR {} does not have a merge queue label".format(pr_number))
return False
-if -1 in (obsolete, pr_closed, blocked, merge_queue):
+draft = self._is_pr_draft(pr_json) if self.verifyNoDraftForMergeQueue else 0
+if draft == 1:
+self.fail_build("PR {} is a draft pull request".format(pr_number))
+return False
+
+if -1 in (obsolete, pr_closed, blocked, merge_queue, draft):
self.finished(WARNINGS)
return False
Modified: trunk/Tools/CISupport/ews-build/steps_unittest.py (291291 => 291292)
--- trunk/Tools/CISupport/ews-build/steps_unittest.py 2022-03-15 15:26:35 UTC (rev 291291)
+++ trunk/Tools/CISupport/ews-build/steps_unittest.py 2022-03-15 15:38:21 UTC (rev 291292)
@@ -5021,12 +5021,13 @@
"is_patch": 1,
"summary": "{}"}}'''.format(obsolete, title))
-def get_pr(self, pr_number, title='Sample pull request', closed=False, labels=None):
+def get_pr(self, pr_number, title='Sample pull request', closed=False, labels=None, draft=False):
[webkit-changes] [291291] trunk/LayoutTests
Title: [291291] trunk/LayoutTests Revision 291291 Author matteo_flo...@apple.com Date 2022-03-15 08:26:35 -0700 (Tue, 15 Mar 2022) Log Message A combination of scrolling and a content change can leave a fixed layer in the wrong place https://bugs.webkit.org/show_bug.cgi?id=203112 Unreviewed test gardening. * platform/ios-simulator-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (291290 => 291291) --- trunk/LayoutTests/ChangeLog 2022-03-15 15:23:14 UTC (rev 291290) +++ trunk/LayoutTests/ChangeLog 2022-03-15 15:26:35 UTC (rev 291291) @@ -1,5 +1,14 @@ 2022-03-15 Matteo Flores +A combination of scrolling and a content change can leave a fixed layer in the wrong place +https://bugs.webkit.org/show_bug.cgi?id=203112 + +Unreviewed test gardening. + +* platform/ios-simulator-wk2/TestExpectations: + +2022-03-15 Matteo Flores + Implement ElementInternals https://bugs.webkit.org/show_bug.cgi?id=197960 Modified: trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations (291290 => 291291) --- trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations 2022-03-15 15:23:14 UTC (rev 291290) +++ trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations 2022-03-15 15:26:35 UTC (rev 291291) @@ -106,6 +106,8 @@ webkit.org/b/214824 [ Debug ] js/throw-large-string-oom.html [ Skip ] +webkit.org/b/203112 scrollingcoordinator/ios/ui-scroll-fixed.html [ Pass Failure ] + webkit.org/b/215033 imported/w3c/web-platform-tests/websockets/cookies/third-party-cookie-accepted.https.html [ Pass Failure ] webkit.org/b/215216 imported/w3c/web-platform-tests/svg/import/interact-zoom-01-t-manual.svg [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291290] trunk/Source/WebCore
Title: [291290] trunk/Source/WebCore
Revision 291290
Author eoca...@igalia.com
Date 2022-03-15 08:23:14 -0700 (Tue, 15 Mar 2022)
Log Message
[GStreamer] clarify playback errors with MediaError.message
https://bugs.webkit.org/show_bug.cgi?id=237602
Reviewed by Philippe Normand.
This patch is co-authored by Eugene Mutavchi
See: https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/797
* html/HTMLMediaElement.cpp: Use internal last error message from the player, if available.
* platform/graphics/MediaPlayer.cpp: Cache the last error message from the player private and update it when NetworkState changes to an error state. This allows the player private to be regenerated (as it has always been) while providing access to the former player private error after that.
* platform/graphics/MediaPlayer.h: Added lastErrorMessage() method to get the last internal error message from the player private.
* platform/graphics/MediaPlayerPrivate.h: Default lastErrorMessage() empty implementation.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: Detect decryption and no-key errors.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: Added errorMessage() to expose the internal error message.
* platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp: Post multiple kind of errors to the GstBus to notify upper layers instead of just logging them.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp
trunk/Source/WebCore/platform/graphics/MediaPlayer.h
trunk/Source/WebCore/platform/graphics/MediaPlayerPrivate.h
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h
trunk/Source/WebCore/platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (291289 => 291290)
--- trunk/Source/WebCore/ChangeLog 2022-03-15 15:02:03 UTC (rev 291289)
+++ trunk/Source/WebCore/ChangeLog 2022-03-15 15:23:14 UTC (rev 291290)
@@ -1,3 +1,21 @@
+2022-03-15 Enrique Ocaña González
+
+[GStreamer] clarify playback errors with MediaError.message
+https://bugs.webkit.org/show_bug.cgi?id=237602
+
+Reviewed by Philippe Normand.
+
+This patch is co-authored by Eugene Mutavchi
+See: https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/797
+
+* html/HTMLMediaElement.cpp: Use internal last error message from the player, if available.
+* platform/graphics/MediaPlayer.cpp: Cache the last error message from the player private and update it when NetworkState changes to an error state. This allows the player private to be regenerated (as it has always been) while providing access to the former player private error after that.
+* platform/graphics/MediaPlayer.h: Added lastErrorMessage() method to get the last internal error message from the player private.
+* platform/graphics/MediaPlayerPrivate.h: Default lastErrorMessage() empty implementation.
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: Detect decryption and no-key errors.
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: Added errorMessage() to expose the internal error message.
+* platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp: Post multiple kind of errors to the GstBus to notify upper layers instead of just logging them.
+
2022-03-15 Antti Koivisto
CSSConditionRule.conditionText should be readonly
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (291289 => 291290)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2022-03-15 15:02:03 UTC (rev 291289)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2022-03-15 15:23:14 UTC (rev 291290)
@@ -2175,7 +2175,9 @@
// 6.1 - Set the error attribute to a new MediaError object whose code attribute is set to
// MEDIA_ERR_SRC_NOT_SUPPORTED.
-m_error = MediaError::create(MediaError::MEDIA_ERR_SRC_NOT_SUPPORTED, "Unsupported source type"_s);
+m_error = m_player
+? MediaError::create(MediaError::MEDIA_ERR_SRC_NOT_SUPPORTED, m_player->lastErrorMessage())
+: MediaError::create(MediaError::MEDIA_ERR_SRC_NOT_SUPPORTED, "Unsupported source type"_s);
// 6.2 - Forget the media element's media-resource-specific text tracks.
forgetResourceSpecificTracks();
@@ -2213,12 +2215,24 @@
stopPeriodicTimers();
m_loadState = WaitingForSource;
+const auto getErrorMessage = [&] (String&& defaultMessage) {
+String message = WTFMove(defaultMessage);
+if (!m_player)
+return message;
+
+auto lastErrorMessage = m_player->lastErrorMessage();
+if (!lastErrorMessage)
+return message;
+
+return makeString(message, ": ", lastErrorMessage);
+};
+
// 2 - Set the
[webkit-changes] [291289] trunk/LayoutTests
Title: [291289] trunk/LayoutTests Revision 291289 Author matteo_flo...@apple.com Date 2022-03-15 08:02:03 -0700 (Tue, 15 Mar 2022) Log Message Implement ElementInternals https://bugs.webkit.org/show_bug.cgi?id=197960 Unreviewed test gardening. * platform/ipad/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ipad/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (291288 => 291289) --- trunk/LayoutTests/ChangeLog 2022-03-15 14:49:50 UTC (rev 291288) +++ trunk/LayoutTests/ChangeLog 2022-03-15 15:02:03 UTC (rev 291289) @@ -1,5 +1,14 @@ 2022-03-15 Matteo Flores +Implement ElementInternals +https://bugs.webkit.org/show_bug.cgi?id=197960 + +Unreviewed test gardening. + +* platform/ipad/TestExpectations: + +2022-03-15 Matteo Flores + [GPU Process] Test failures in writing modes https://bugs.webkit.org/show_bug.cgi?id=236921 Modified: trunk/LayoutTests/platform/ipad/TestExpectations (291288 => 291289) --- trunk/LayoutTests/platform/ipad/TestExpectations 2022-03-15 14:49:50 UTC (rev 291288) +++ trunk/LayoutTests/platform/ipad/TestExpectations 2022-03-15 15:02:03 UTC (rev 291289) @@ -113,6 +113,8 @@ webkit.org/b/228622 [ Debug ] accessibility/ios-simulator/scroll-in-overflow-div.html [ Crash ] +webkit.org/b/197960 imported/w3c/web-platform-tests/html/dom/idlharness.https.html [ Pass Failure] + webkit.org/b/228663 fast/canvas/canvas-color-space-display-p3.html [ ImageOnlyFailure ] webkit.org/b/230419 platform/ipad/media/modern-media-controls/media-documents/media-document-video-ios-sizing.html [ Pass Timeout Crash ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291288] trunk/LayoutTests
Title: [291288] trunk/LayoutTests Revision 291288 Author matteo_flo...@apple.com Date 2022-03-15 07:49:50 -0700 (Tue, 15 Mar 2022) Log Message [GPU Process] Test failures in writing modes https://bugs.webkit.org/show_bug.cgi?id=236921 Unreviewed test gardening. * gpu-process/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/gpu-process/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (291287 => 291288) --- trunk/LayoutTests/ChangeLog 2022-03-15 14:25:38 UTC (rev 291287) +++ trunk/LayoutTests/ChangeLog 2022-03-15 14:49:50 UTC (rev 291288) @@ -1,5 +1,14 @@ 2022-03-15 Matteo Flores +[GPU Process] Test failures in writing modes +https://bugs.webkit.org/show_bug.cgi?id=236921 + +Unreviewed test gardening. + +* gpu-process/TestExpectations: + +2022-03-15 Matteo Flores + REGRESSION: [ iOS release wk2 ] compositing/debug-borders-dynamic.html is a flaky image failure https://github.com/Smackteo Modified: trunk/LayoutTests/gpu-process/TestExpectations (291287 => 291288) --- trunk/LayoutTests/gpu-process/TestExpectations 2022-03-15 14:25:38 UTC (rev 291287) +++ trunk/LayoutTests/gpu-process/TestExpectations 2022-03-15 14:49:50 UTC (rev 291288) @@ -362,4 +362,10 @@ webkit.org/b/232090 imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/canvas-createImageBitmap-video-resize.html [ Pass ] webkit.org/b/292090 imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/createImageBitmap-drawImage.html [ Pass ] webkit.org/b/292090 imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/createImageBitmap-flipY.html [ Pass ] -webkit.org/b/292090 media/video-canvas-createPattern.html [ Pass ] \ No newline at end of file +webkit.org/b/292090 media/video-canvas-createPattern.html [ Pass ] + +#webkit.org/b/236921 +imported/w3c/web-platform-tests/css/css-writing-modes/block-flow-direction-vlr-010.xht [ Pass Failure ] +imported/w3c/web-platform-tests/css/css-writing-modes/table-column-order-003.xht [ Pass Failure ] +imported/w3c/web-platform-tests/css/css-writing-modes/row-progression-vlr-007.xht [ Pass Failure ] +imported/w3c/web-platform-tests/css/css-writing-modes/line-box-direction-vrl-002.xht [ Pass Failure ] \ No newline at end of file ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291287] trunk/Source
Title: [291287] trunk/Source
Revision 291287
Author wenson_hs...@apple.com
Date 2022-03-15 07:25:38 -0700 (Tue, 15 Mar 2022)
Log Message
[macOS] Tooltip no longer disappears after leaving hovered element
https://bugs.webkit.org/show_bug.cgi?id=237815
rdar://90187247
Reviewed by Tim Horton.
Source/WebKit:
On certain versions of macOS, AppKit's tooltip management system installs tracking areas (NSTrackingArea) using
`-addTrackingArea:` instead of tracking rects. This breaks our existing mechanism for keeping track of the
current tracking rect owner by overriding `-addTrackingRect:owner:userData:assumeInside:` (which assumes that
the only client that adds tracking rects is the tooltip manager). Since `-addTrackingRect:` isn't called,
`m_trackingRectOwner` remains nil, which causes both `sendToolTipMouseExited()` and `sendToolTipMouseEntered()`
to be no-ops.
To fix this, in the case where `m_trackingRectOwner` is nil, we instead fall back on `-[WKWebView trackingAreas]`
and look for an NSTrackingArea that's owned by AppKit's NSToolTipManager. We then send fake mouse enter/exit
events to this owner, the same way as we currently do.
* UIProcess/Cocoa/WebViewImpl.h:
* UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::addTrackingRect):
(WebKit::WebViewImpl::addTrackingRectWithTrackingNum):
(WebKit::WebViewImpl::addTrackingRectsWithTrackingNums):
(WebKit::WebViewImpl::toolTipTrackingAreaOwner const):
(WebKit::WebViewImpl::sendToolTipMouseExited):
(WebKit::WebViewImpl::sendToolTipMouseEntered):
Source/WebKitLegacy/mac:
Apply the same fix to legacy WebKit; see WebKit/ChangeLog for more information.
* WebView/WebHTMLView.mm:
Also wrap the owner in a WeakObjCPtr to avoid the possibility of calling methods on deallocated instances.
(-[WebHTMLView _toolTipOwnerForSendingMouseEvents]):
(-[WebHTMLView _sendToolTipMouseExited]):
(-[WebHTMLView _sendToolTipMouseEntered]):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.h
trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (291286 => 291287)
--- trunk/Source/WebKit/ChangeLog 2022-03-15 14:16:27 UTC (rev 291286)
+++ trunk/Source/WebKit/ChangeLog 2022-03-15 14:25:38 UTC (rev 291287)
@@ -1,3 +1,31 @@
+2022-03-15 Wenson Hsieh
+
+[macOS] Tooltip no longer disappears after leaving hovered element
+https://bugs.webkit.org/show_bug.cgi?id=237815
+rdar://90187247
+
+Reviewed by Tim Horton.
+
+On certain versions of macOS, AppKit's tooltip management system installs tracking areas (NSTrackingArea) using
+`-addTrackingArea:` instead of tracking rects. This breaks our existing mechanism for keeping track of the
+current tracking rect owner by overriding `-addTrackingRect:owner:userData:assumeInside:` (which assumes that
+the only client that adds tracking rects is the tooltip manager). Since `-addTrackingRect:` isn't called,
+`m_trackingRectOwner` remains nil, which causes both `sendToolTipMouseExited()` and `sendToolTipMouseEntered()`
+to be no-ops.
+
+To fix this, in the case where `m_trackingRectOwner` is nil, we instead fall back on `-[WKWebView trackingAreas]`
+and look for an NSTrackingArea that's owned by AppKit's NSToolTipManager. We then send fake mouse enter/exit
+events to this owner, the same way as we currently do.
+
+* UIProcess/Cocoa/WebViewImpl.h:
+* UIProcess/Cocoa/WebViewImpl.mm:
+(WebKit::WebViewImpl::addTrackingRect):
+(WebKit::WebViewImpl::addTrackingRectWithTrackingNum):
+(WebKit::WebViewImpl::addTrackingRectsWithTrackingNums):
+(WebKit::WebViewImpl::toolTipTrackingAreaOwner const):
+(WebKit::WebViewImpl::sendToolTipMouseExited):
+(WebKit::WebViewImpl::sendToolTipMouseEntered):
+
2022-03-15 Youenn Fablet
Mark permission as denied if system forbids access to camera and/or microphone
Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.h (291286 => 291287)
--- trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.h 2022-03-15 14:16:27 UTC (rev 291286)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.h 2022-03-15 14:25:38 UTC (rev 291287)
@@ -737,6 +737,8 @@
void viewWillMoveToWindowImpl(NSWindow *);
+id toolTipOwnerForSendingMouseEvents() const;
+
#if ENABLE(DRAG_SUPPORT)
void sendDragEndToPage(CGPoint endPoint, NSDragOperation);
#endif
@@ -820,7 +822,7 @@
RetainPtr m_primaryTrackingArea;
NSToolTipTag m_lastToolTipTag { 0 };
-id m_trackingRectOwner { nil };
+WeakObjCPtr m_trackingRectOwner;
void* m_trackingRectUserData { nullptr };
RetainPtr m_rootLayer;
Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm (291286 => 291287)
--- trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm 2022-03-15 14:16:27 UTC (rev
[webkit-changes] [291286] trunk
Title: [291286] trunk
Revision 291286
Author an...@apple.com
Date 2022-03-15 07:16:27 -0700 (Tue, 15 Mar 2022)
Log Message
CSSConditionRule.conditionText should be readonly
https://bugs.webkit.org/show_bug.cgi?id=237880
Reviewed by Antoine Quint.
LayoutTests/imported/w3c:
* web-platform-tests/interfaces/css-conditional.idl:
Source/WebCore:
Per CSSWG resolution https://github.com/w3c/csswg-drafts/issues/6819#issuecomment-1016695585
This also matches Blink.
* css/CSSConditionRule.h:
* css/CSSConditionRule.idl:
* css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::setConditionText): Deleted.
* css/CSSMediaRule.h:
* css/CSSSupportsRule.cpp:
(WebCore::CSSSupportsRule::setConditionText): Deleted.
* css/CSSSupportsRule.h:
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/interfaces/css-conditional.idl
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSConditionRule.h
trunk/Source/WebCore/css/CSSConditionRule.idl
trunk/Source/WebCore/css/CSSMediaRule.cpp
trunk/Source/WebCore/css/CSSMediaRule.h
trunk/Source/WebCore/css/CSSSupportsRule.cpp
trunk/Source/WebCore/css/CSSSupportsRule.h
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (291285 => 291286)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2022-03-15 13:57:29 UTC (rev 291285)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-03-15 14:16:27 UTC (rev 291286)
@@ -1,3 +1,12 @@
+2022-03-15 Antti Koivisto
+
+CSSConditionRule.conditionText should be readonly
+https://bugs.webkit.org/show_bug.cgi?id=237880
+
+Reviewed by Antoine Quint.
+
+* web-platform-tests/interfaces/css-conditional.idl:
+
2022-03-15 Antoine Quint
Dialog element only animates once
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/interfaces/css-conditional.idl (291285 => 291286)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/interfaces/css-conditional.idl 2022-03-15 13:57:29 UTC (rev 291285)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/interfaces/css-conditional.idl 2022-03-15 14:16:27 UTC (rev 291286)
@@ -9,7 +9,7 @@
[Exposed=Window]
interface CSSConditionRule : CSSGroupingRule {
-attribute CSSOMString conditionText;
+readonly attribute CSSOMString conditionText;
};
[Exposed=Window]
Modified: trunk/Source/WebCore/ChangeLog (291285 => 291286)
--- trunk/Source/WebCore/ChangeLog 2022-03-15 13:57:29 UTC (rev 291285)
+++ trunk/Source/WebCore/ChangeLog 2022-03-15 14:16:27 UTC (rev 291286)
@@ -1,3 +1,23 @@
+2022-03-15 Antti Koivisto
+
+CSSConditionRule.conditionText should be readonly
+https://bugs.webkit.org/show_bug.cgi?id=237880
+
+Reviewed by Antoine Quint.
+
+Per CSSWG resolution https://github.com/w3c/csswg-drafts/issues/6819#issuecomment-1016695585
+
+This also matches Blink.
+
+* css/CSSConditionRule.h:
+* css/CSSConditionRule.idl:
+* css/CSSMediaRule.cpp:
+(WebCore::CSSMediaRule::setConditionText): Deleted.
+* css/CSSMediaRule.h:
+* css/CSSSupportsRule.cpp:
+(WebCore::CSSSupportsRule::setConditionText): Deleted.
+* css/CSSSupportsRule.h:
+
2022-03-15 Enrique Ocaña González
[GStreamer][MSE] add ac-3,ec-3 and flac codecs gst caps
Modified: trunk/Source/WebCore/css/CSSConditionRule.h (291285 => 291286)
--- trunk/Source/WebCore/css/CSSConditionRule.h 2022-03-15 13:57:29 UTC (rev 291285)
+++ trunk/Source/WebCore/css/CSSConditionRule.h 2022-03-15 14:16:27 UTC (rev 291286)
@@ -36,7 +36,6 @@
class CSSConditionRule : public CSSGroupingRule {
public:
virtual String conditionText() const = 0;
-virtual void setConditionText(const String&) = 0;
protected:
CSSConditionRule(StyleRuleGroup&, CSSStyleSheet* parent);
Modified: trunk/Source/WebCore/css/CSSConditionRule.idl (291285 => 291286)
--- trunk/Source/WebCore/css/CSSConditionRule.idl 2022-03-15 13:57:29 UTC (rev 291285)
+++ trunk/Source/WebCore/css/CSSConditionRule.idl 2022-03-15 14:16:27 UTC (rev 291286)
@@ -32,5 +32,5 @@
[
Exposed=Window
] interface CSSConditionRule : CSSGroupingRule {
-attribute CSSOMString conditionText;
+readonly attribute CSSOMString conditionText;
};
Modified: trunk/Source/WebCore/css/CSSMediaRule.cpp (291285 => 291286)
--- trunk/Source/WebCore/css/CSSMediaRule.cpp 2022-03-15 13:57:29 UTC (rev 291285)
+++ trunk/Source/WebCore/css/CSSMediaRule.cpp 2022-03-15 14:16:27 UTC (rev 291286)
@@ -60,11 +60,6 @@
return mediaQueries().mediaText();
}
-void CSSMediaRule::setConditionText(const String& text)
-{
-mediaQueries().set(text);
-}
-
MediaList* CSSMediaRule::media() const
{
if (!m_mediaCSSOMWrapper)
Modified: trunk/Source/WebCore/css/CSSMediaRule.h (291285 => 291286)
--- trunk/Source/WebCore/css/CSSMediaRule.h 2022-03-15 13:57:29 UTC (rev 291285)
+++ trunk/Source/WebCore/css/CSSMediaRule.h 2022-03-15 14:16:27 UTC (rev 291286)
@@ -44,7 +44,6 @@
void
[webkit-changes] [291285] trunk/LayoutTests
Title: [291285] trunk/LayoutTests Revision 291285 Author matteo_flo...@apple.com Date 2022-03-15 06:57:29 -0700 (Tue, 15 Mar 2022) Log Message REGRESSION: [ iOS release wk2 ] compositing/debug-borders-dynamic.html is a flaky image failure https://github.com/Smackteo Unreviewed test gardening. * platform/ios-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (291284 => 291285) --- trunk/LayoutTests/ChangeLog 2022-03-15 13:21:05 UTC (rev 291284) +++ trunk/LayoutTests/ChangeLog 2022-03-15 13:57:29 UTC (rev 291285) @@ -1,3 +1,12 @@ +2022-03-15 Matteo Flores + +REGRESSION: [ iOS release wk2 ] compositing/debug-borders-dynamic.html is a flaky image failure +https://github.com/Smackteo + +Unreviewed test gardening. + +* platform/ios-wk2/TestExpectations: + 2022-03-15 Gabriel Nava Marino Crash in KeyframeList.cpp:183 in WebCore::KeyframeList::fillImplicitKeyframes Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (291284 => 291285) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2022-03-15 13:21:05 UTC (rev 291284) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2022-03-15 13:57:29 UTC (rev 291285) @@ -2125,6 +2125,8 @@ webkit.org/b/230434 http/tests/navigation/back-to-slow-frame.html [ Pass Crash ] +webkit.org/b/217114 compositing/debug-borders-dynamic.html [ Pass Failure ] + webkit.org/b/230695 imported/w3c/web-platform-tests/css/css-pseudo/highlight-painting-003.html [ Pass ImageOnlyFailure ] webkit.org/b/230695 imported/w3c/web-platform-tests/css/css-pseudo/highlight-painting-004.html [ Pass ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291284] trunk
Title: [291284] trunk
Revision 291284
Author you...@apple.com
Date 2022-03-15 06:21:05 -0700 (Tue, 15 Mar 2022)
Log Message
Mark permission as denied if system forbids access to camera and/or microphone
https://bugs.webkit.org/show_bug.cgi?id=237823
Reviewed by Eric Carlson.
Source/WebKit:
If application has not set the camera/microphone usage string, we do not need to call ther permission delegate.
Ditto if TCC prompt is denied. Instead, we can return deny if possible or prompt otherwise.
Covered by API test.
* UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
* UIProcess/UserMediaPermissionRequestManagerProxy.h:
* UIProcess/WebPageProxy.cpp:
Tools:
* TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:
* TestWebKitAPI/Tests/WebKit/getUserMediaPermission.html:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp
trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.h
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm
trunk/Tools/TestWebKitAPI/Tests/WebKit/getUserMediaPermission.html
Diff
Modified: trunk/Source/WebKit/ChangeLog (291283 => 291284)
--- trunk/Source/WebKit/ChangeLog 2022-03-15 12:40:14 UTC (rev 291283)
+++ trunk/Source/WebKit/ChangeLog 2022-03-15 13:21:05 UTC (rev 291284)
@@ -1,5 +1,20 @@
2022-03-15 Youenn Fablet
+Mark permission as denied if system forbids access to camera and/or microphone
+https://bugs.webkit.org/show_bug.cgi?id=237823
+
+Reviewed by Eric Carlson.
+
+If application has not set the camera/microphone usage string, we do not need to call ther permission delegate.
+Ditto if TCC prompt is denied. Instead, we can return deny if possible or prompt otherwise.
+Covered by API test.
+
+* UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
+* UIProcess/UserMediaPermissionRequestManagerProxy.h:
+* UIProcess/WebPageProxy.cpp:
+
+2022-03-15 Youenn Fablet
+
Rename VideoSampleMetadata to VideoFrameTimeMetadata
https://bugs.webkit.org/show_bug.cgi?id=237593
Modified: trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp (291283 => 291284)
--- trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp 2022-03-15 12:40:14 UTC (rev 291283)
+++ trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp 2022-03-15 13:21:05 UTC (rev 291284)
@@ -883,6 +883,21 @@
syncWithWebCorePrefs();
}
+bool UserMediaPermissionRequestManagerProxy::mockCaptureDevicesEnabled() const
+{
+return m_mockDevicesEnabledOverride ? *m_mockDevicesEnabledOverride : m_page.preferences().mockCaptureDevicesEnabled();
+}
+
+bool UserMediaPermissionRequestManagerProxy::canAudioCaptureSucceed() const
+{
+return mockCaptureDevicesEnabled() || permittedToCaptureAudio();
+}
+
+bool UserMediaPermissionRequestManagerProxy::canVideoCaptureSucceed() const
+{
+return mockCaptureDevicesEnabled() || permittedToCaptureVideo();
+}
+
void UserMediaPermissionRequestManagerProxy::syncWithWebCorePrefs() const
{
#if ENABLE(MEDIA_STREAM)
Modified: trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.h (291283 => 291284)
--- trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.h 2022-03-15 12:40:14 UTC (rev 291283)
+++ trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.h 2022-03-15 13:21:05 UTC (rev 291284)
@@ -100,6 +100,8 @@
Prompt
};
+bool canAudioCaptureSucceed() const;
+bool canVideoCaptureSucceed() const;
void setMockCaptureDevicesEnabledOverride(std::optional);
bool hasPendingCapture() const { return m_hasPendingCapture; }
@@ -157,6 +159,8 @@
void platformValidateUserMediaRequestConstraints(WebCore::RealtimeMediaSourceCenter::ValidConstraintsHandler&& validHandler, WebCore::RealtimeMediaSourceCenter::InvalidConstraintsHandler&& invalidHandler, String&& deviceIDHashSalt);
#endif
+bool mockCaptureDevicesEnabled() const;
+
void watchdogTimerFired();
void processNextUserMediaRequestIfNeeded();
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (291283 => 291284)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2022-03-15 12:40:14 UTC (rev 291283)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2022-03-15 13:21:05 UTC (rev 291284)
@@ -8587,6 +8587,7 @@
void WebPageProxy::queryPermission(const ClientOrigin& clientOrigin, const PermissionDescriptor& descriptor, CompletionHandler, bool shouldCache)>&& completionHandler)
{
+bool canAPISucceed = true;
bool shouldChangeDeniedToPrompt = true;
bool shouldChangePromptToGrant = false;
String name;
@@ -8593,6 +8594,7 @@
if (descriptor.name == PermissionName::Camera) {
#if ENABLE(MEDIA_STREAM)
name = "camera"_s;
+canAPISucceed = userMediaPermissionRequestManager().canVideoCaptureSucceed();
[webkit-changes] [291283] trunk/Source/WebCore
Title: [291283] trunk/Source/WebCore
Revision 291283
Author eoca...@igalia.com
Date 2022-03-15 05:40:14 -0700 (Tue, 15 Mar 2022)
Log Message
[GStreamer][MSE] add ac-3,ec-3 and flac codecs gst caps
https://bugs.webkit.org/show_bug.cgi?id=237843
Reviewed by Philippe Normand.
AC-3, EC-3 and FLAC formats should be supported on MSE and EME on those
platforms having the appropriate decoders for them.
This patch adds the appropriate mime types, factories and caps to the
set of codecs whose local support will be tested on MSE.
This patch is authored by Eugene Mutavchi
See: https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/804
* platform/graphics/gstreamer/GStreamerRegistryScanner.cpp: Add support for the codecs, factories and caps.
* platform/graphics/gstreamer/eme/WebKitThunderDecryptorGStreamer.cpp: Add support for the caps.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/eme/WebKitThunderDecryptorGStreamer.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (291282 => 291283)
--- trunk/Source/WebCore/ChangeLog 2022-03-15 11:40:00 UTC (rev 291282)
+++ trunk/Source/WebCore/ChangeLog 2022-03-15 12:40:14 UTC (rev 291283)
@@ -1,3 +1,22 @@
+2022-03-15 Enrique Ocaña González
+
+[GStreamer][MSE] add ac-3,ec-3 and flac codecs gst caps
+https://bugs.webkit.org/show_bug.cgi?id=237843
+
+Reviewed by Philippe Normand.
+
+AC-3, EC-3 and FLAC formats should be supported on MSE and EME on those
+platforms having the appropriate decoders for them.
+
+This patch adds the appropriate mime types, factories and caps to the
+set of codecs whose local support will be tested on MSE.
+
+This patch is authored by Eugene Mutavchi
+See: https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/804
+
+* platform/graphics/gstreamer/GStreamerRegistryScanner.cpp: Add support for the codecs, factories and caps.
+* platform/graphics/gstreamer/eme/WebKitThunderDecryptorGStreamer.cpp: Add support for the caps.
+
2022-03-15 Antoine Quint
Dialog element only animates once
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp (291282 => 291283)
--- trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp 2022-03-15 11:40:00 UTC (rev 291282)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp 2022-03-15 12:40:14 UTC (rev 291283)
@@ -337,6 +337,13 @@
m_decoderCodecMap.add(AtomString("x-av1"), av1DecoderAvailable.isUsingHardware);
}
+Vector mseCompatibleMapping = {
+{ ElementFactories::Type::AudioDecoder, "audio/x-ac3", { }, {"x-ac3", "ac-3", "ac3"} },
+{ ElementFactories::Type::AudioDecoder, "audio/x-eac3", {"audio/x-ac3"}, {"x-eac3", "ec3", "ec-3", "eac3"} },
+{ ElementFactories::Type::AudioDecoder, "audio/x-flac", {"audio/x-flac", "audio/flac"}, {"x-flac", "flac" } },
+};
+fillMimeTypeSetFromCapsMapping(factories, mseCompatibleMapping);
+
if (m_isMediaSource)
return;
@@ -344,10 +351,7 @@
Vector mapping = {
{ ElementFactories::Type::AudioDecoder, "audio/midi", { "audio/midi", "audio/riff-midi" }, { } },
-{ ElementFactories::Type::AudioDecoder, "audio/x-ac3", { }, { } },
{ ElementFactories::Type::AudioDecoder, "audio/x-dts", { }, { } },
-{ ElementFactories::Type::AudioDecoder, "audio/x-eac3", { "audio/x-ac3" }, { } },
-{ ElementFactories::Type::AudioDecoder, "audio/x-flac", { "audio/x-flac", "audio/flac" }, { } },
{ ElementFactories::Type::AudioDecoder, "audio/x-sbc", { }, { } },
{ ElementFactories::Type::AudioDecoder, "audio/x-sid", { }, { } },
{ ElementFactories::Type::AudioDecoder, "audio/x-speex", { "audio/speex", "audio/x-speex" }, { } },
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/eme/WebKitThunderDecryptorGStreamer.cpp (291282 => 291283)
--- trunk/Source/WebCore/platform/graphics/gstreamer/eme/WebKitThunderDecryptorGStreamer.cpp 2022-03-15 11:40:00 UTC (rev 291282)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/eme/WebKitThunderDecryptorGStreamer.cpp 2022-03-15 12:40:14 UTC (rev 291283)
@@ -46,7 +46,7 @@
GST_DEBUG_CATEGORY(webkitMediaThunderDecryptDebugCategory);
#define GST_CAT_DEFAULT webkitMediaThunderDecryptDebugCategory
-static const char* cencEncryptionMediaTypes[] = { "video/mp4", "audio/mp4", "video/x-h264", "video/x-h265", "audio/mpeg", "video/x-vp9", nullptr };
+static const char* cencEncryptionMediaTypes[] = { "video/mp4", "audio/mp4", "video/x-h264", "video/x-h265", "audio/mpeg", "audio/x-eac3", "audio/x-ac3", "audio/x-flac", "video/x-vp9", nullptr };
static const char** cbcsEncryptionMediaTypes = cencEncryptionMediaTypes;
static const char* webmEncryptionMediaTypes[] = { "video/webm", "audio/webm", "video/x-vp9",
[webkit-changes] [291282] trunk
Title: [291282] trunk Revision 291282 Author grao...@webkit.org Date 2022-03-15 04:40:00 -0700 (Tue, 15 Mar 2022) Log Message Dialog element only animates once https://bugs.webkit.org/show_bug.cgi?id=236274 Reviewed by Dean Jackson, Tim Nguyen and Antti Koivisto. LayoutTests/imported/w3c: Import relevant WPT tests that had already been upstreamed in a previous, reverted version of this patch. * web-platform-tests/css/css-animations/dialog-animation-expected.txt: Added. * web-platform-tests/css/css-animations/dialog-animation.html: Added. * web-platform-tests/css/css-animations/dialog-backdrop-animation-expected.txt: Added. * web-platform-tests/css/css-animations/dialog-backdrop-animation.html: Added. * web-platform-tests/css/css-animations/support/testcommon.js: (addElement): (addDiv): Source/WebCore: Two issues related to CSS Animation surfaced in this bug which animates both and its ::backdrop as the dialog is open and eventually re-opened. The first issue was that we didn't clear all CSS Animations state when a was closed and its style was set to `display: none`. We now call setAnimationsCreatedByMarkup to correctly clear such state both when we identify a Styleable is newly getting `display: none`. We do the same when cancelDeclarativeAnimations() is called, but also call setCSSAnimationList() on the associated effect stack since that wasn't done either. Now both functions do similar cleanup. This allows us to remove removeCSSAnimationCreatedByMarkup() which did a fair bit of work to clear CSS Animation state per-animation when we only ever used that function for _all_ animations. The second issue was that we never called cancelDeclarativeAnimations() for ::backdrop. We now do that inside of Element::removeFromTopLayer() at a point where the code in Styleable::fromRenderer() will still work as the element will still be contained in Document::topLayerElements(). Tests: imported/w3c/web-platform-tests/css/css-animations/dialog-animation.html imported/w3c/web-platform-tests/css/css-animations/dialog-backdrop-animation.html * dom/Element.cpp: (WebCore::Element::removeFromTopLayer): * style/Styleable.cpp: (WebCore::Styleable::cancelDeclarativeAnimations const): (WebCore::Styleable::updateCSSAnimations const): (WebCore::removeCSSAnimationCreatedByMarkup): Deleted. Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/support/testcommon.js trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/Element.cpp trunk/Source/WebCore/style/Styleable.cpp Added Paths trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/dialog-animation-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/dialog-animation.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/dialog-backdrop-animation-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/dialog-backdrop-animation.html Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (291281 => 291282) --- trunk/LayoutTests/imported/w3c/ChangeLog 2022-03-15 11:01:41 UTC (rev 291281) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-03-15 11:40:00 UTC (rev 291282) @@ -1,3 +1,21 @@ +2022-03-15 Antoine Quint + +Dialog element only animates once +https://bugs.webkit.org/show_bug.cgi?id=236274 + +Reviewed by Dean Jackson, Tim Nguyen and Antti Koivisto. + +Import relevant WPT tests that had already been upstreamed in a previous, reverted +version of this patch. + +* web-platform-tests/css/css-animations/dialog-animation-expected.txt: Added. +* web-platform-tests/css/css-animations/dialog-animation.html: Added. +* web-platform-tests/css/css-animations/dialog-backdrop-animation-expected.txt: Added. +* web-platform-tests/css/css-animations/dialog-backdrop-animation.html: Added. +* web-platform-tests/css/css-animations/support/testcommon.js: +(addElement): +(addDiv): + 2022-03-14 Oriol Brufau [css-cascade] Fix 'revert' on low-priority properties Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/dialog-animation-expected.txt (0 => 291282) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/dialog-animation-expected.txt (rev 0) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/dialog-animation-expected.txt 2022-03-15 11:40:00 UTC (rev 291282) @@ -0,0 +1,3 @@ + +PASS CSS Animations tied to are canceled and restarted as the dialog is hidden and shown + Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/dialog-animation.html (0 => 291282) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/dialog-animation.html (rev 0) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/dialog-animation.html
[webkit-changes] [291281] trunk
Title: [291281] trunk
Revision 291281
Author gnavamar...@apple.com
Date 2022-03-15 04:01:41 -0700 (Tue, 15 Mar 2022)
Log Message
Crash in KeyframeList.cpp:183 in WebCore::KeyframeList::fillImplicitKeyframes
https://bugs.webkit.org/show_bug.cgi?id=237858
Reviewed by Antoine Quint.
Source/WebCore:
When filling implicit key frames, we iterate through the current keyframes (m_keyframes),
and cache the address of the implicitZeroKeyframe and implicitOneKeyframe.
However, if we're not provided with an existing implicit zero keyframe, we will create a new one
and insert it to the list of current keyframes.
This mutates m_keyframes and the old address for the implicitOneKeyframe would no longer be valid.
Thus we should iterate through the current keyframes, after the insertion, to get the latest address.
Test: animations/fill-implicit-keyframes-crash.html
* rendering/style/KeyframeList.cpp:
(WebCore::KeyframeList::fillImplicitKeyframes):
LayoutTests:
* animations/fill-implicit-keyframes-crash-expected.txt: Added.
* animations/fill-implicit-keyframes-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/style/KeyframeList.cpp
Added Paths
trunk/LayoutTests/animations/fill-implicit-keyframes-crash-expected.txt
trunk/LayoutTests/animations/fill-implicit-keyframes-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (291280 => 291281)
--- trunk/LayoutTests/ChangeLog 2022-03-15 10:50:45 UTC (rev 291280)
+++ trunk/LayoutTests/ChangeLog 2022-03-15 11:01:41 UTC (rev 291281)
@@ -1,3 +1,13 @@
+2022-03-15 Gabriel Nava Marino
+
+Crash in KeyframeList.cpp:183 in WebCore::KeyframeList::fillImplicitKeyframes
+https://bugs.webkit.org/show_bug.cgi?id=237858
+
+Reviewed by Antoine Quint.
+
+* animations/fill-implicit-keyframes-crash-expected.txt: Added.
+* animations/fill-implicit-keyframes-crash.html: Added.
+
2022-03-15 Youenn Fablet
Make sure to end any pending AudioSession interruption when activating it
Added: trunk/LayoutTests/animations/fill-implicit-keyframes-crash-expected.txt (0 => 291281)
--- trunk/LayoutTests/animations/fill-implicit-keyframes-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/animations/fill-implicit-keyframes-crash-expected.txt 2022-03-15 11:01:41 UTC (rev 291281)
@@ -0,0 +1,2 @@
+CONSOLE MESSAGE: This test passes if it does not crash.
+
Added: trunk/LayoutTests/animations/fill-implicit-keyframes-crash.html (0 => 291281)
--- trunk/LayoutTests/animations/fill-implicit-keyframes-crash.html (rev 0)
+++ trunk/LayoutTests/animations/fill-implicit-keyframes-crash.html 2022-03-15 11:01:41 UTC (rev 291281)
@@ -0,0 +1,23 @@
+
+
+ body {
+animation-name: a0;
+animation-duration: 100ms
+ }
+ @keyframes a0 {
+10% {
+ scale: 1
+}
+11%, 12%, 13%, 14%, 15%, 16%, 17%, 18%, 19%, 20%, 21%, 22%, 23%, 24%, 100% {
+ background: blue
+}
+
+ }
+
+
+ _onload_ = () => {
+if (window.testRunner)
+ testRunner.dumpAsText();
+console.log("This test passes if it does not crash.");
+ }
+
Modified: trunk/Source/WebCore/ChangeLog (291280 => 291281)
--- trunk/Source/WebCore/ChangeLog 2022-03-15 10:50:45 UTC (rev 291280)
+++ trunk/Source/WebCore/ChangeLog 2022-03-15 11:01:41 UTC (rev 291281)
@@ -1,3 +1,24 @@
+2022-03-15 Gabriel Nava Marino
+
+Crash in KeyframeList.cpp:183 in WebCore::KeyframeList::fillImplicitKeyframes
+https://bugs.webkit.org/show_bug.cgi?id=237858
+
+Reviewed by Antoine Quint.
+
+When filling implicit key frames, we iterate through the current keyframes (m_keyframes),
+and cache the address of the implicitZeroKeyframe and implicitOneKeyframe.
+
+However, if we're not provided with an existing implicit zero keyframe, we will create a new one
+and insert it to the list of current keyframes.
+
+This mutates m_keyframes and the old address for the implicitOneKeyframe would no longer be valid.
+Thus we should iterate through the current keyframes, after the insertion, to get the latest address.
+
+Test: animations/fill-implicit-keyframes-crash.html
+
+* rendering/style/KeyframeList.cpp:
+(WebCore::KeyframeList::fillImplicitKeyframes):
+
2022-03-15 Zan Dobersek
[GTK][WPE] Provide DMABuf-based composition layers, DMABufVideoSink integration
Modified: trunk/Source/WebCore/rendering/style/KeyframeList.cpp (291280 => 291281)
--- trunk/Source/WebCore/rendering/style/KeyframeList.cpp 2022-03-15 10:50:45 UTC (rev 291280)
+++ trunk/Source/WebCore/rendering/style/KeyframeList.cpp 2022-03-15 11:01:41 UTC (rev 291281)
@@ -168,11 +168,6 @@
zeroKeyframeImplicitProperties.remove(cssPropertyId);
if (!implicitZeroKeyframe && isSuitableKeyframeForImplicitValues(keyframe))
implicitZeroKeyframe =
-} else if
[webkit-changes] [291280] releases/WebKitGTK/webkit-2.36/Tools
Title: [291280] releases/WebKitGTK/webkit-2.36/Tools Revision 291280 Author carlo...@webkit.org Date 2022-03-15 03:50:45 -0700 (Tue, 15 Mar 2022) Log Message Merge r290982 - [GTK][WPE] Do not add new modules under ThirdParty to the tarball https://bugs.webkit.org/show_bug.cgi?id=237519 Reviewed by Michael Catanzaro. We currently include ThirdParty and exclude individually what we don't want in the tarball. That means every time something new is added to ThirdParty we have to manually exclude it. It's better to exclude ThirdParty and manually add what we need instead. * gtk/manifest.txt.in: * wpe/manifest.txt.in: Modified Paths releases/WebKitGTK/webkit-2.36/Tools/ChangeLog releases/WebKitGTK/webkit-2.36/Tools/gtk/manifest.txt.in releases/WebKitGTK/webkit-2.36/Tools/wpe/manifest.txt.in Diff Modified: releases/WebKitGTK/webkit-2.36/Tools/ChangeLog (291279 => 291280) --- releases/WebKitGTK/webkit-2.36/Tools/ChangeLog 2022-03-15 10:00:05 UTC (rev 291279) +++ releases/WebKitGTK/webkit-2.36/Tools/ChangeLog 2022-03-15 10:50:45 UTC (rev 291280) @@ -1,3 +1,17 @@ +2022-03-08 Carlos Garcia Campos + +[GTK][WPE] Do not add new modules under ThirdParty to the tarball +https://bugs.webkit.org/show_bug.cgi?id=237519 + +Reviewed by Michael Catanzaro. + +We currently include ThirdParty and exclude individually what we don't want in the tarball. That means every +time something new is added to ThirdParty we have to manually exclude it. It's better to exclude ThirdParty and +manually add what we need instead. + +* gtk/manifest.txt.in: +* wpe/manifest.txt.in: + 2022-02-25 Carlos Garcia Campos AX: List item marker not exposed when not a direct child of a list item Modified: releases/WebKitGTK/webkit-2.36/Tools/gtk/manifest.txt.in (291279 => 291280) --- releases/WebKitGTK/webkit-2.36/Tools/gtk/manifest.txt.in 2022-03-15 10:00:05 UTC (rev 291279) +++ releases/WebKitGTK/webkit-2.36/Tools/gtk/manifest.txt.in 2022-03-15 10:50:45 UTC (rev 291280) @@ -47,10 +47,6 @@ directory Source exclude Source/_javascript_Core/tests -exclude Source/ThirdParty/capstone -exclude Source/ThirdParty/libwebrtc -exclude Source/ThirdParty/qunit -exclude Source/ThirdParty/openvr exclude Source/WebCore/platform/audio/resources exclude Source/WebCore/bindings/scripts/test exclude Source/WebCore/Resources @@ -61,6 +57,11 @@ exclude Source/cmake/OptionsWPE.cmake$ exclude Source/WebInspectorUI/Tools +exclude Source/ThirdParty +directory Source/ThirdParty/ANGLE +directory Source/ThirdParty/gtest +directory Source/ThirdParty/xdgmime + exclude Source/WebKit/Resources directory Source/WebKit/Resources/gtk Modified: releases/WebKitGTK/webkit-2.36/Tools/wpe/manifest.txt.in (291279 => 291280) --- releases/WebKitGTK/webkit-2.36/Tools/wpe/manifest.txt.in 2022-03-15 10:00:05 UTC (rev 291279) +++ releases/WebKitGTK/webkit-2.36/Tools/wpe/manifest.txt.in 2022-03-15 10:50:45 UTC (rev 291280) @@ -47,10 +47,6 @@ directory Source exclude Source/_javascript_Core/tests -exclude Source/ThirdParty/capstone -exclude Source/ThirdParty/libwebrtc -exclude Source/ThirdParty/qunit -exclude Source/ThirdParty/openvr exclude Source/WebCore/platform/audio/resources exclude Source/WebCore/bindings/scripts/test exclude Source/WebCore/Resources @@ -61,6 +57,11 @@ exclude Source/cmake/OptionsGTK.cmake$ exclude Source/WebInspectorUI/Tools +exclude Source/ThirdParty +directory Source/ThirdParty/ANGLE +directory Source/ThirdParty/gtest +directory Source/ThirdParty/xdgmime + exclude Source/WebKit/Resources # We do want to include the NEWS, but we want it to be in the root of the archive. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291279] releases/WebKitGTK/webkit-2.36
Title: [291279] releases/WebKitGTK/webkit-2.36
Revision 291279
Author carlo...@webkit.org
Date 2022-03-15 03:00:05 -0700 (Tue, 15 Mar 2022)
Log Message
Merge r29 - REGRESSION(r284711): [GStreamer] Buffering, seek broken on youtube.com
https://bugs.webkit.org/show_bug.cgi?id=233861
Unreviewed, manual revert of 284711.
Patch by Philippe Normand on 2022-03-10
Source/WebCore:
* Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::currentTimeFudgeFactor):
* platform/graphics/SourceBufferPrivate.h:
(WebCore::SourceBufferPrivate::timeFudgeFactor const):
* platform/graphics/gstreamer/GStreamerCommon.h:
(WebCore::toGstClockTime):
* platform/graphics/gstreamer/MediaSampleGStreamer.cpp:
(WebCore::MediaSampleGStreamer::MediaSampleGStreamer):
* platform/graphics/gstreamer/mse/AppendPipeline.cpp:
(WebCore::AppendPipeline::appsinkNewSample):
(WebCore::bufferTimeToStreamTime): Deleted.
LayoutTests:
* platform/glib/imported/w3c/web-platform-tests/media-source/mediasource-remove-expected.txt:
Modified Paths
releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.36/LayoutTests/platform/glib/imported/w3c/web-platform-tests/media-source/mediasource-remove-expected.txt
releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebCore/Modules/mediasource/MediaSource.cpp
releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/graphics/SourceBufferPrivate.h
releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h
releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.cpp
releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp
Diff
Modified: releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog (291278 => 291279)
--- releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog 2022-03-15 09:35:36 UTC (rev 291278)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog 2022-03-15 10:00:05 UTC (rev 291279)
@@ -1,3 +1,12 @@
+2022-03-10 Philippe Normand
+
+REGRESSION(r284711): [GStreamer] Buffering, seek broken on youtube.com
+https://bugs.webkit.org/show_bug.cgi?id=233861
+
+Unreviewed, manual revert of 284711.
+
+* platform/glib/imported/w3c/web-platform-tests/media-source/mediasource-remove-expected.txt:
+
2022-03-02 Carlos Garcia Campos
REGRESSION(r216096): [GTK] Test accessibility/gtk/menu-list-unfocused-notifications.html is failing since r216096
Modified: releases/WebKitGTK/webkit-2.36/LayoutTests/platform/glib/imported/w3c/web-platform-tests/media-source/mediasource-remove-expected.txt (291278 => 291279)
--- releases/WebKitGTK/webkit-2.36/LayoutTests/platform/glib/imported/w3c/web-platform-tests/media-source/mediasource-remove-expected.txt 2022-03-15 09:35:36 UTC (rev 291278)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/platform/glib/imported/w3c/web-platform-tests/media-source/mediasource-remove-expected.txt 2022-03-15 10:00:05 UTC (rev 291279)
@@ -11,8 +11,8 @@
PASS Test aborting a remove operation.
PASS Test remove with a start at the duration.
PASS Test remove transitioning readyState from 'ended' to 'open'.
-PASS Test removing all appended data.
-PASS Test removing beginning of appended data.
-FAIL Test removing the middle of appended data. assert_equals: Buffered ranges after remove(). expected "{ [0.095, 0.997) [3.298, 6.548) }" but got "{ [0.095, 0.975) [3.298, 6.548) }"
-FAIL Test removing the end of appended data. assert_equals: Buffered ranges after remove(). expected "{ [0.095, 1.022) }" but got "{ [0.095, 0.995) }"
+FAIL Test removing all appended data. assert_equals: Initial buffered range. expected "{ [0.095, 6.548) }" but got "{ [0.000, 6.548) }"
+FAIL Test removing beginning of appended data. assert_equals: Initial buffered range. expected "{ [0.095, 6.548) }" but got "{ [0.000, 6.548) }"
+FAIL Test removing the middle of appended data. assert_equals: Initial buffered range. expected "{ [0.095, 6.548) }" but got "{ [0.000, 6.548) }"
+FAIL Test removing the end of appended data. assert_equals: Initial buffered range. expected "{ [0.095, 6.548) }" but got "{ [0.000, 6.548) }"
Modified: releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog (291278 => 291279)
--- releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog 2022-03-15 09:35:36 UTC (rev 291278)
+++ releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog 2022-03-15 10:00:05 UTC (rev 291279)
@@ -1,3 +1,22 @@
+2022-03-10 Philippe Normand
+
+REGRESSION(r284711): [GStreamer] Buffering, seek broken on youtube.com
+https://bugs.webkit.org/show_bug.cgi?id=233861
+
+Unreviewed, manual revert of 284711.
+
+* Modules/mediasource/MediaSource.cpp:
+(WebCore::MediaSource::currentTimeFudgeFactor):
+* platform/graphics/SourceBufferPrivate.h:
+(WebCore::SourceBufferPrivate::timeFudgeFactor const):
+*
[webkit-changes] [291277] releases/WebKitGTK/webkit-2.36/Source/WebCore
Title: [291277] releases/WebKitGTK/webkit-2.36/Source/WebCore
Revision 291277
Author carlo...@webkit.org
Date 2022-03-15 02:35:33 -0700 (Tue, 15 Mar 2022)
Log Message
Merge r290883 - makeprop.pl breaks reproducible builds
https://bugs.webkit.org/show_bug.cgi?id=237521
Reviewed by Carlos Garcia Campos.
* css/makeprop.pl: Sort hash elements so the output file is always
the same across different builds.
Modified Paths
releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebCore/css/makeprop.pl
Diff
Modified: releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog (291276 => 291277)
--- releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog 2022-03-15 09:35:29 UTC (rev 291276)
+++ releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog 2022-03-15 09:35:33 UTC (rev 291277)
@@ -1,3 +1,13 @@
+2022-03-07 Alberto Garcia
+
+makeprop.pl breaks reproducible builds
+https://bugs.webkit.org/show_bug.cgi?id=237521
+
+Reviewed by Carlos Garcia Campos.
+
+* css/makeprop.pl: Sort hash elements so the output file is always
+the same across different builds.
+
2022-03-01 Michael Catanzaro
Misc compiler warnings, late Feb 2022 edition
Modified: releases/WebKitGTK/webkit-2.36/Source/WebCore/css/makeprop.pl (291276 => 291277)
--- releases/WebKitGTK/webkit-2.36/Source/WebCore/css/makeprop.pl 2022-03-15 09:35:29 UTC (rev 291276)
+++ releases/WebKitGTK/webkit-2.36/Source/WebCore/css/makeprop.pl 2022-03-15 09:35:33 UTC (rev 291277)
@@ -55,7 +55,7 @@
my $jsonDecoder = JSON::PP->new->utf8;
my $jsonHashRef = $jsonDecoder->decode($input);
my $propertiesHashRef = $jsonHashRef->{properties};
-my @allNames = keys(%$propertiesHashRef);
+my @allNames = sort keys(%$propertiesHashRef);
die "We've reached more than 1024 CSS properties, please make sure to update CSSProperty/StylePropertyMetadata accordingly" if @allNames > 1024;
my %defines = map { $_ => 1 } split(/ /, $defines);
@@ -472,7 +472,7 @@
{
switch (id) {
EOF
- foreach my $name (keys %runtimeFlags) {
+ foreach my $name (sort keys %runtimeFlags) {
print GPERF "case CSSPropertyID::CSSProperty" . $nameToId{$name} . ":\n";
print GPERF "return RuntimeEnabledFeatures::sharedFeatures()." . $runtimeFlags{$name} . "Enabled();\n";
}
@@ -500,7 +500,7 @@
switch (id) {
EOF
-foreach my $name (keys %settingsFlags) {
+foreach my $name (sort keys %settingsFlags) {
print GPERF "case CSSPropertyID::CSSProperty" . $nameToId{$name} . ":\n";
print GPERF "return settings->" . $settingsFlags{$name} . "();\n";
}
@@ -647,8 +647,8 @@
{
switch (id) {
EOF
-for my $logicalPropertyGroup (values %logicalPropertyGroups) {
-for my $name (values %{ $logicalPropertyGroup->{"logical"} }) {
+for my $logicalPropertyGroup (sort values %logicalPropertyGroups) {
+for my $name (sort values %{ $logicalPropertyGroup->{"logical"} }) {
print GPERF "case CSSPropertyID::CSSProperty" . $nameToId{$name} . ":\n";
}
}
@@ -665,9 +665,9 @@
switch (id) {
EOF
-for my $logicalPropertyGroup (values %logicalPropertyGroups) {
+for my $logicalPropertyGroup (sort values %logicalPropertyGroups) {
for my $kind ("logical", "physical") {
-for my $name (values %{ $logicalPropertyGroup->{$kind} }) {
+for my $name (sort values %{ $logicalPropertyGroup->{$kind} }) {
print GPERF "case CSSPropertyID::CSSProperty" . $nameToId{$name} . ":\n";
}
}
@@ -685,16 +685,18 @@
switch (id1) {
EOF
-for my $logicalPropertyGroup (values %logicalPropertyGroups) {
+for my $logicalPropertyGroup (sort values %logicalPropertyGroups) {
my $logical = $logicalPropertyGroup->{"logical"};
my $physical = $logicalPropertyGroup->{"physical"};
for my $first ($logical, $physical) {
my $second = $first eq $logical ? $physical : $logical;
-while (my ($resolver, $name) = each %{ $first }) {
+for my $resolver (sort keys %{ $first }) {
+my $name = $first->{$resolver};
print GPERF "case CSSPropertyID::CSSProperty" . $nameToId{$name} . ":\n";
}
print GPERF "switch (id2) {\n";
-while (my ($resolver, $name) = each %{ $second }) {
+for my $resolver (sort keys %{ $second }) {
+my $name = $second->{$resolver};
print GPERF "case CSSPropertyID::CSSProperty" . $nameToId{$name} . ":\n";
}
print GPERF << "EOF";
@@ -718,8 +720,9 @@
switch (propertyID) {
EOF
-for my $logicalPropertyGroup (values %logicalPropertyGroups) {
-while (my ($resolver, $name) = each %{ $logicalPropertyGroup->{"logical"} }) {
+for my $logicalPropertyGroup (sort values %logicalPropertyGroups) {
+for my $resolver (sort keys %{ $logicalPropertyGroup->{"logical"} }) {
+my $name = $logicalPropertyGroup->{"logical"}->{$resolver};
my $kind =
[webkit-changes] [291278] releases/WebKitGTK/webkit-2.36/Source/WebKit
Title: [291278] releases/WebKitGTK/webkit-2.36/Source/WebKit Revision 291278 Author carlo...@webkit.org Date 2022-03-15 02:35:36 -0700 (Tue, 15 Mar 2022) Log Message Merge r290890 - [GTK] generate-automation-atom.py breaks reproducible builds https://bugs.webkit.org/show_bug.cgi?id=237506 Reviewed by Carlos Garcia Campos. * Scripts/generate-automation-atom.py: (append_functions): Sort utility functions to produce stable output. Modified Paths releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog releases/WebKitGTK/webkit-2.36/Source/WebKit/Scripts/generate-automation-atom.py Diff Modified: releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog (291277 => 291278) --- releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog 2022-03-15 09:35:33 UTC (rev 291277) +++ releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog 2022-03-15 09:35:36 UTC (rev 291278) @@ -1,3 +1,13 @@ +2022-03-07 Adrian Perez de Castro + +[GTK] generate-automation-atom.py breaks reproducible builds +https://bugs.webkit.org/show_bug.cgi?id=237506 + +Reviewed by Carlos Garcia Campos. + +* Scripts/generate-automation-atom.py: +(append_functions): Sort utility functions to produce stable output. + 2022-03-01 Michael Catanzaro Misc compiler warnings, late Feb 2022 edition Modified: releases/WebKitGTK/webkit-2.36/Source/WebKit/Scripts/generate-automation-atom.py (291277 => 291278) --- releases/WebKitGTK/webkit-2.36/Source/WebKit/Scripts/generate-automation-atom.py 2022-03-15 09:35:33 UTC (rev 291277) +++ releases/WebKitGTK/webkit-2.36/Source/WebKit/Scripts/generate-automation-atom.py 2022-03-15 09:35:36 UTC (rev 291278) @@ -50,7 +50,9 @@ def append_functions(utils_data, util_functions, util_functions_impl, functions_written): -for function in util_functions: +util_functions_list = list(util_functions) +util_functions_list.sort() +for function in util_functions_list: if function in functions_written: continue ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291276] releases/WebKitGTK/webkit-2.36/Source
Title: [291276] releases/WebKitGTK/webkit-2.36/Source
Revision 291276
Author carlo...@webkit.org
Date 2022-03-15 02:35:29 -0700 (Tue, 15 Mar 2022)
Log Message
Merge r290681 - Misc compiler warnings, late Feb 2022 edition
https://bugs.webkit.org/show_bug.cgi?id=237275
Patch by Michael Catanzaro on 2022-03-01
Reviewed by Adrian Perez de Castro.
Source/_javascript_Core:
Suppress suspected false-positive -Wstringop-overflow and -Wformat-overflow warnings. Also,
remove an unused variable.
* API/tests/MultithreadedMultiVMExecutionTest.cpp:
(startMultithreadedMultiVMExecutionTest):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):
* ftl/FTLOSRExit.cpp:
(JSC::FTL::OSRExitDescriptor::prepareOSRExitHandle):
* yarr/YarrJIT.cpp:
Source/WebCore:
Remove a redundant move. Sprinkle RELEASE_ASSERT_NOT_REACHED() as required to avoid
-Wreturn-type warnings.
* Modules/push-api/PushDatabase.cpp:
(WebCore::openAndMigrateDatabaseImpl):
* style/ContainerQueryEvaluator.cpp:
(WebCore::Style::ContainerQueryEvaluator::evaluateCondition const):
(WebCore::Style::ContainerQueryEvaluator::evaluateSizeFeature const):
* style/ContainerQueryEvaluator.h:
(WebCore::Style::operator!):
* style/StyleScope.cpp:
(WebCore::Style::Scope::updateQueryContainerState):
Source/WebKit:
Delete an unused function. Remove a redundant move.
* Shared/AuxiliaryProcess.cpp:
(WebKit::applySandboxProfileForDaemon): Deleted.
* Shared/WebFoundTextRange.cpp:
(WebKit::WebFoundTextRange::decode):
Modified Paths
releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/API/tests/MultithreadedMultiVMExecutionTest.cpp
releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp
releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/ftl/FTLOSRExit.cpp
releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/yarr/YarrJIT.cpp
releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebCore/Modules/push-api/PushDatabase.cpp
releases/WebKitGTK/webkit-2.36/Source/WebCore/style/ContainerQueryEvaluator.cpp
releases/WebKitGTK/webkit-2.36/Source/WebCore/style/ContainerQueryEvaluator.h
releases/WebKitGTK/webkit-2.36/Source/WebCore/style/StyleScope.cpp
releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/AuxiliaryProcess.cpp
releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/WebFoundTextRange.cpp
Diff
Modified: releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/API/tests/MultithreadedMultiVMExecutionTest.cpp (291275 => 291276)
--- releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/API/tests/MultithreadedMultiVMExecutionTest.cpp 2022-03-15 09:05:02 UTC (rev 291275)
+++ releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/API/tests/MultithreadedMultiVMExecutionTest.cpp 2022-03-15 09:35:29 UTC (rev 291276)
@@ -85,7 +85,9 @@
std::vector buffer;
buffer.resize(JSStringGetMaximumUTF8CStringSize(string));
JSStringGetUTF8CString(string, buffer.data(), buffer.size());
+IGNORE_GCC_WARNINGS_BEGIN("format-overflow")
printf("FAIL: MultithreadedMultiVMExecutionTest: %d %d %s\n", threadNumber, i, buffer.data());
+IGNORE_GCC_WARNINGS_END
JSStringRelease(string);
} else
printf("FAIL: MultithreadedMultiVMExecutionTest: %d %d stringifying exception failed\n", threadNumber, i);
Modified: releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/ChangeLog (291275 => 291276)
--- releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/ChangeLog 2022-03-15 09:05:02 UTC (rev 291275)
+++ releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/ChangeLog 2022-03-15 09:35:29 UTC (rev 291276)
@@ -1,3 +1,21 @@
+2022-03-01 Michael Catanzaro
+
+Misc compiler warnings, late Feb 2022 edition
+https://bugs.webkit.org/show_bug.cgi?id=237275
+
+Reviewed by Adrian Perez de Castro.
+
+Suppress suspected false-positive -Wstringop-overflow and -Wformat-overflow warnings. Also,
+remove an unused variable.
+
+* API/tests/MultithreadedMultiVMExecutionTest.cpp:
+(startMultithreadedMultiVMExecutionTest):
+* ftl/FTLLowerDFGToB3.cpp:
+(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):
+* ftl/FTLOSRExit.cpp:
+(JSC::FTL::OSRExitDescriptor::prepareOSRExitHandle):
+* yarr/YarrJIT.cpp:
+
2022-02-23 Adrian Perez de Castro
Ensure generated inline assembler that setups segments returns to previous state
Modified: releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp (291275 => 291276)
--- releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp 2022-03-15 09:05:02 UTC (rev 291275)
+++ releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp 2022-03-15 09:35:29 UTC (rev 291276)
[webkit-changes] [291275] releases/WebKitGTK/webkit-2.36
Title: [291275] releases/WebKitGTK/webkit-2.36 Revision 291275 Author carlo...@webkit.org Date 2022-03-15 02:05:02 -0700 (Tue, 15 Mar 2022) Log Message Merge r290597 - -Wodr warning spam caused by ENABLE(BINDING_INTEGRITY) https://bugs.webkit.org/show_bug.cgi?id=229867 Patch by Michael Catanzaro on 2022-02-28 Reviewed by Carlos Garcia Campos. Build WebKit with -Wno-odr. This warning is not salvagable, and it's impossible to suppress locally. * Source/cmake/WebKitCompilerFlags.cmake: 2022-02-24 Matt Woodrow Unreviewed, update my (Matt Woodrow) status to committer. * metadata/contributors.json: Modified Paths releases/WebKitGTK/webkit-2.36/ChangeLog releases/WebKitGTK/webkit-2.36/Source/cmake/WebKitCompilerFlags.cmake Diff Modified: releases/WebKitGTK/webkit-2.36/ChangeLog (291274 => 291275) --- releases/WebKitGTK/webkit-2.36/ChangeLog 2022-03-15 09:04:59 UTC (rev 291274) +++ releases/WebKitGTK/webkit-2.36/ChangeLog 2022-03-15 09:05:02 UTC (rev 291275) @@ -1,3 +1,16 @@ +2022-02-28 Michael Catanzaro + +-Wodr warning spam caused by ENABLE(BINDING_INTEGRITY) +https://bugs.webkit.org/show_bug.cgi?id=229867 + + +Reviewed by Carlos Garcia Campos. + +Build WebKit with -Wno-odr. This warning is not salvagable, and it's impossible to suppress +locally. + +* Source/cmake/WebKitCompilerFlags.cmake: + 2022-02-25 Adrian Perez de Castro Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.35.90 release Modified: releases/WebKitGTK/webkit-2.36/Source/cmake/WebKitCompilerFlags.cmake (291274 => 291275) --- releases/WebKitGTK/webkit-2.36/Source/cmake/WebKitCompilerFlags.cmake 2022-03-15 09:04:59 UTC (rev 291274) +++ releases/WebKitGTK/webkit-2.36/Source/cmake/WebKitCompilerFlags.cmake 2022-03-15 09:05:02 UTC (rev 291275) @@ -150,6 +150,12 @@ WEBKIT_PREPEND_GLOBAL_CXX_FLAGS(-Wno-stringop-overread) endif () +# -Wodr trips over our bindings integrity feature when LTO is enabled. +# https://bugs.webkit.org/show_bug.cgi?id=229867 +if (CMAKE_CXX_COMPILER_ID MATCHES "GNU") +WEBKIT_PREPEND_GLOBAL_CXX_FLAGS(-Wno-odr) +endif () + # -Wexpansion-to-defined produces false positives with GCC but not Clang # https://bugs.webkit.org/show_bug.cgi?id=167643#c13 if (CMAKE_CXX_COMPILER_ID MATCHES "GNU") ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291274] releases/WebKitGTK/webkit-2.36
Title: [291274] releases/WebKitGTK/webkit-2.36
Revision 291274
Author carlo...@webkit.org
Date 2022-03-15 02:04:59 -0700 (Tue, 15 Mar 2022)
Log Message
Merge r290724 - REGRESSION(r216096): [GTK] Test accessibility/gtk/menu-list-unfocused-notifications.html is failing since r216096
https://bugs.webkit.org/show_bug.cgi?id=171598
Reviewed by Adrian Perez de Castro.
Source/WebCore:
Enable accessibility when a WTR observer is added.
* accessibility/atspi/AccessibilityAtspi.cpp:
(WebCore::AccessibilityAtspi::addNotificationObserver):
LayoutTests:
Since r216096 the notification for menu list changes is deffered, so we need to wait one run loop cycle to get
the notifications. Also update the test to ignore notifications that are not interesting like AXLoadComplete and
AXElementBusyChanged, and update expectations for the new behavior with ATSPI where the notification is emitted
on the menu and not the combo.
* accessibility/gtk/menu-list-unfocused-notifications-expected.txt:
* accessibility/gtk/menu-list-unfocused-notifications.html:
* platform/gtk/TestExpectations:
Modified Paths
releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/menu-list-unfocused-notifications-expected.txt
releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/menu-list-unfocused-notifications.html
releases/WebKitGTK/webkit-2.36/LayoutTests/platform/gtk/TestExpectations
releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp
Diff
Modified: releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog (291273 => 291274)
--- releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog 2022-03-15 09:04:54 UTC (rev 291273)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog 2022-03-15 09:04:59 UTC (rev 291274)
@@ -1,5 +1,21 @@
2022-03-02 Carlos Garcia Campos
+REGRESSION(r216096): [GTK] Test accessibility/gtk/menu-list-unfocused-notifications.html is failing since r216096
+https://bugs.webkit.org/show_bug.cgi?id=171598
+
+Reviewed by Adrian Perez de Castro.
+
+Since r216096 the notification for menu list changes is deffered, so we need to wait one run loop cycle to get
+the notifications. Also update the test to ignore notifications that are not interesting like AXLoadComplete and
+AXElementBusyChanged, and update expectations for the new behavior with ATSPI where the notification is emitted
+on the menu and not the combo.
+
+* accessibility/gtk/menu-list-unfocused-notifications-expected.txt:
+* accessibility/gtk/menu-list-unfocused-notifications.html:
+* platform/gtk/TestExpectations:
+
+2022-03-02 Carlos Garcia Campos
+
[ATSPI] Test accessibility/select-element-at-index.html is failing
https://bugs.webkit.org/show_bug.cgi?id=237315
Modified: releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/menu-list-unfocused-notifications-expected.txt (291273 => 291274)
--- releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/menu-list-unfocused-notifications-expected.txt 2022-03-15 09:04:54 UTC (rev 291273)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/menu-list-unfocused-notifications-expected.txt 2022-03-15 09:04:59 UTC (rev 291274)
@@ -9,15 +9,15 @@
Focused element is: AXRole: AXButton
Changing selected item in non-focused combobox.
-AXSelectedChildrenChanged: AXRole: AXComboBox
+AXMenuItemSelected: AXRole: AXMenu
+Selected item is: AXTitle: four
Focused element is: AXRole: AXButton
Changing selected item in non-focused combobox.
-AXSelectedChildrenChanged: AXRole: AXComboBox
+AXMenuItemSelected: AXRole: AXMenu
+Selected item is: AXTitle: three
Focused element is: AXRole: AXButton
-AXLoadComplete: AXRole: AXWebArea
-AXElementBusyChanged: AXRole: AXWebArea
PASS successfullyParsed is true
TEST COMPLETE
Modified: releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/menu-list-unfocused-notifications.html (291273 => 291274)
--- releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/menu-list-unfocused-notifications.html 2022-03-15 09:04:54 UTC (rev 291273)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/menu-list-unfocused-notifications.html 2022-03-15 09:04:59 UTC (rev 291274)
@@ -19,28 +19,39 @@
if (window.testRunner && window.accessibilityController) {
accessibilityController.addNotificationListener(function(element, notification) {
-debug(notification + ": " + element.role);
+if (notification == "AXFocusedUIElementChanged" || notification == "AXMenuItemSelected")
+debug(notification + ": " + element.role);
});
-debug("Changing focus to button.");
-document.getElementById('button').focus();
-debug("Focused element is: " + accessibilityController.focusedElement.role + "\n");
+window.setTimeout(function() {
+debug("Changing focus
[webkit-changes] [291273] releases/WebKitGTK/webkit-2.36/LayoutTests
Title: [291273] releases/WebKitGTK/webkit-2.36/LayoutTests
Revision 291273
Author carlo...@webkit.org
Date 2022-03-15 02:04:54 -0700 (Tue, 15 Mar 2022)
Log Message
Merge r290723 - [ATSPI] Test accessibility/select-element-at-index.html is failing
https://bugs.webkit.org/show_bug.cgi?id=237315
Reviewed by Adrian Perez de Castro.
This is because the test contains platform specific behavior for ATK that was migrated to ATSPI by mistake. We
should behave like all other ports now.
* accessibility/select-element-at-index.html:
* platform/glib/TestExpectations:
Modified Paths
releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/select-element-at-index.html
releases/WebKitGTK/webkit-2.36/LayoutTests/platform/glib/TestExpectations
Diff
Modified: releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog (291272 => 291273)
--- releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog 2022-03-15 09:04:50 UTC (rev 291272)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog 2022-03-15 09:04:54 UTC (rev 291273)
@@ -1,3 +1,16 @@
+2022-03-02 Carlos Garcia Campos
+
+[ATSPI] Test accessibility/select-element-at-index.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=237315
+
+Reviewed by Adrian Perez de Castro.
+
+This is because the test contains platform specific behavior for ATK that was migrated to ATSPI by mistake. We
+should behave like all other ports now.
+
+* accessibility/select-element-at-index.html:
+* platform/glib/TestExpectations:
+
2022-03-01 Carlos Garcia Campos
[ATSPI] Remove layout tests checking children added/removed notifications
Modified: releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/select-element-at-index.html (291272 => 291273)
--- releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/select-element-at-index.html 2022-03-15 09:04:50 UTC (rev 291272)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/select-element-at-index.html 2022-03-15 09:04:54 UTC (rev 291273)
@@ -51,13 +51,7 @@
// "Option 4" is the third of three selected items, thus the index should be 2.
shouldBeTrue("selectElement.selectedChildAtIndex(2).isEqual(option4)");
-// In ATSPI removeSelectionAtIndex() the index is with respect to the array of
-// selected children; not the array of all children. Thus to remove the selection
-// from "Option 4" in ATSPI, we again need to specify an index of 2.
-if (accessibilityController.platformName == "atspi")
-selectElement.removeSelectionAtIndex(2);
-else
-selectElement.removeSelectionAtIndex(3);
+selectElement.removeSelectionAtIndex(3);
shouldBeFalse("option4.isSelected");
shouldBe("selectElement.selectedChildrenCount", "2");
Modified: releases/WebKitGTK/webkit-2.36/LayoutTests/platform/glib/TestExpectations (291272 => 291273)
--- releases/WebKitGTK/webkit-2.36/LayoutTests/platform/glib/TestExpectations 2022-03-15 09:04:50 UTC (rev 291272)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/platform/glib/TestExpectations 2022-03-15 09:04:54 UTC (rev 291273)
@@ -413,9 +413,6 @@
webkit.org/b/232256 accessibility/auto-fill-crash.html [ Timeout ]
-# Tests failing with ATSPI implementation.
-webkit.org/b/235941 accessibility/select-element-at-index.html [ Failure ]
-
#
# End of Accessibility-related bugs
#
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291272] releases/WebKitGTK/webkit-2.36
Title: [291272] releases/WebKitGTK/webkit-2.36 Revision 291272 Author carlo...@webkit.org Date 2022-03-15 02:04:50 -0700 (Tue, 15 Mar 2022) Log Message Merge r290633 - [ATSPI] Remove layout tests checking children added/removed notifications https://bugs.webkit.org/show_bug.cgi?id=237272 Reviewed by Adrian Perez de Castro. Source/WebCore: Do not send children-changed notifications to WTR observers. * accessibility/atspi/AccessibilityAtspi.cpp: (WebCore::AccessibilityAtspi::childrenChanged): (WebCore::AccessibilityAtspi::notifyChildrenChanged const): Deleted. * accessibility/atspi/AccessibilityAtspi.h: LayoutTests: Children changed notifications are not expected by any other tests because other ports don't support them. We already have unit tests to ensure they work as expected so we can just remove the layout tests and ensure we don't emit those notifications either. * accessibility/children-changed-sends-notification-expected.txt: Removed. * accessibility/children-changed-sends-notification.html: Removed. * accessibility/gtk/menu-list-unfocused-notifications-expected.txt: * accessibility/gtk/no-notification-for-unrendered-iframe-children-expected.txt: Removed. * accessibility/gtk/no-notification-for-unrendered-iframe-children.html: Removed. * platform/glib/TestExpectations: * platform/gtk/TestExpectations: * platform/mac/TestExpectations: * platform/win/TestExpectations: * platform/wincairo-wk1/TestExpectations: Modified Paths releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/menu-list-unfocused-notifications-expected.txt releases/WebKitGTK/webkit-2.36/LayoutTests/platform/glib/TestExpectations releases/WebKitGTK/webkit-2.36/LayoutTests/platform/gtk/TestExpectations releases/WebKitGTK/webkit-2.36/LayoutTests/platform/mac/TestExpectations releases/WebKitGTK/webkit-2.36/LayoutTests/platform/win/TestExpectations releases/WebKitGTK/webkit-2.36/LayoutTests/platform/wincairo-wk1/TestExpectations releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog releases/WebKitGTK/webkit-2.36/Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp releases/WebKitGTK/webkit-2.36/Source/WebCore/accessibility/atspi/AccessibilityAtspi.h Removed Paths releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/children-changed-sends-notification-expected.txt releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/children-changed-sends-notification.html releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/no-notification-for-unrendered-iframe-children-expected.txt releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/no-notification-for-unrendered-iframe-children.html Diff Modified: releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog (291271 => 291272) --- releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog 2022-03-15 09:04:41 UTC (rev 291271) +++ releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog 2022-03-15 09:04:50 UTC (rev 291272) @@ -1,3 +1,25 @@ +2022-03-01 Carlos Garcia Campos + +[ATSPI] Remove layout tests checking children added/removed notifications +https://bugs.webkit.org/show_bug.cgi?id=237272 + +Reviewed by Adrian Perez de Castro. + +Children changed notifications are not expected by any other tests because other ports don't support them. We +already have unit tests to ensure they work as expected so we can just remove the layout tests and ensure we +don't emit those notifications either. + +* accessibility/children-changed-sends-notification-expected.txt: Removed. +* accessibility/children-changed-sends-notification.html: Removed. +* accessibility/gtk/menu-list-unfocused-notifications-expected.txt: +* accessibility/gtk/no-notification-for-unrendered-iframe-children-expected.txt: Removed. +* accessibility/gtk/no-notification-for-unrendered-iframe-children.html: Removed. +* platform/glib/TestExpectations: +* platform/gtk/TestExpectations: +* platform/mac/TestExpectations: +* platform/win/TestExpectations: +* platform/wincairo-wk1/TestExpectations: + 2022-02-25 Carlos Garcia Campos AX: List item marker not exposed when not a direct child of a list item Deleted: releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/children-changed-sends-notification-expected.txt (291271 => 291272) --- releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/children-changed-sends-notification-expected.txt 2022-03-15 09:04:41 UTC (rev 291271) +++ releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/children-changed-sends-notification-expected.txt 2022-03-15 09:04:50 UTC (rev 291272) @@ -1,17 +0,0 @@ -This test ensures that a notification is being emitted when children are added or removed for an accessibility object - -On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". - - -Plain text paragraph - -PARAGRAPH notification: AXChildrenAdded
[webkit-changes] [291271] releases/WebKitGTK/webkit-2.36
Title: [291271] releases/WebKitGTK/webkit-2.36
Revision 291271
Author carlo...@webkit.org
Date 2022-03-15 02:04:41 -0700 (Tue, 15 Mar 2022)
Log Message
Merge r290502 - AX: List item marker not exposed when not a direct child of a list item
https://bugs.webkit.org/show_bug.cgi?id=236777
Reviewed by Adrian Perez de Castro.
Source/WebCore:
It can happen that the marker is not a direct child of a list item, in which case the marker is ignored and not
exposed to ATs.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::parentObjectUnignored const): In case of list marker find the marker list item.
(WebCore::AccessibilityRenderObject::markerRenderer const): Helper to return the list item marker renderer.
(WebCore::AccessibilityRenderObject::addListItemMarker): Add always the list item marker as the first child of
list items.
(WebCore::AccessibilityRenderObject::addChildren): Do not add list item marker children, they will be added to
the right parent in addListItemMarker().
* accessibility/AccessibilityRenderObject.h:
Tools:
* WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:
(WTR::roleValueToString): Return AXStatic for Text role too.
LayoutTests:
Update test results.
* accessibility/gtk/list-items-always-exposed-expected.txt:
* accessibility/gtk/list-items-always-exposed.html:
* accessibility/gtk/spans-expected.txt:
* accessibility/gtk/spans.html:
* platform/gtk/TestExpectations:
Modified Paths
releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/list-items-always-exposed-expected.txt
releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/list-items-always-exposed.html
releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/spans-expected.txt
releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/spans.html
releases/WebKitGTK/webkit-2.36/LayoutTests/platform/gtk/TestExpectations
releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
releases/WebKitGTK/webkit-2.36/Source/WebCore/accessibility/AccessibilityRenderObject.h
releases/WebKitGTK/webkit-2.36/Tools/ChangeLog
releases/WebKitGTK/webkit-2.36/Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp
Diff
Modified: releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog (291270 => 291271)
--- releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog 2022-03-15 08:55:30 UTC (rev 291270)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog 2022-03-15 09:04:41 UTC (rev 291271)
@@ -1,3 +1,19 @@
+2022-02-25 Carlos Garcia Campos
+
+AX: List item marker not exposed when not a direct child of a list item
+https://bugs.webkit.org/show_bug.cgi?id=236777
+
+
+Reviewed by Adrian Perez de Castro.
+
+Update test results.
+
+* accessibility/gtk/list-items-always-exposed-expected.txt:
+* accessibility/gtk/list-items-always-exposed.html:
+* accessibility/gtk/spans-expected.txt:
+* accessibility/gtk/spans.html:
+* platform/gtk/TestExpectations:
+
2022-02-28 Carlos Garcia Campos
[ATSPI] Always expose table cells (layout and CSS) that have rendered text content
Modified: releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/list-items-always-exposed-expected.txt (291270 => 291271)
--- releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/list-items-always-exposed-expected.txt 2022-03-15 08:55:30 UTC (rev 291270)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/list-items-always-exposed-expected.txt 2022-03-15 09:04:41 UTC (rev 291271)
@@ -8,7 +8,9 @@
PASS list.role is 'AXRole: AXList'
PASS item1.role is 'AXRole: AXListItem'
+PASS marker1.role is 'AXRole: AXStatic'
PASS item2.role is 'AXRole: AXListItem'
+PASS marker2.role is 'AXRole: AXStatic'
PASS paragraph.role is 'AXRole: AXParagraph'
PASS successfullyParsed is true
Modified: releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/list-items-always-exposed.html (291270 => 291271)
--- releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/list-items-always-exposed.html 2022-03-15 08:55:30 UTC (rev 291270)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/list-items-always-exposed.html 2022-03-15 09:04:41 UTC (rev 291271)
@@ -23,12 +23,16 @@
var list = webArea.childAtIndex(0);
var item1 = list.childAtIndex(0);
+var marker1 = item1.childAtIndex(0);
var item2 = list.childAtIndex(1);
-var paragraph = item2.childAtIndex(0);
+var marker2 = item2.childAtIndex(0);
+var paragraph = item2.childAtIndex(1);
shouldBe("list.role", "'AXRole: AXList'");
shouldBe("item1.role", "'AXRole: AXListItem'");
+shouldBe("marker1.role", "'AXRole: AXStatic'");
shouldBe("item2.role", "'AXRole: AXListItem'");
+shouldBe("marker2.role", "'AXRole: AXStatic'");
[webkit-changes] [291270] trunk/Source/WebCore
Title: [291270] trunk/Source/WebCore Revision 291270 Author commit-qu...@webkit.org Date 2022-03-15 01:55:30 -0700 (Tue, 15 Mar 2022) Log Message [GTK][WPE] Provide DMABuf-based composition layers, DMABufVideoSink integration https://bugs.webkit.org/show_bug.cgi?id=237328 Patch by Zan Dobersek on 2022-03-15 Reviewed by Alejandro G. Castro. Introduce TextureMapperPlatformLayerProxyDMABuf, a TextureMapper proxy implementation that handles platform layers backed by dmabuf objects. This will be used to handle display of dmabuf producers like GStreamer pipelines or ANGLE-backed WebGL contexts. The DMABufLayer class is the platform layer object, handling display of the actual dmabuf. The proxy itself is tasked with creating and caching such layers for any dmabuf object that originates from the producer. For each dmabuf object pushed into the proxy, the according DMABufLayer object is spawned and cached for future reuse, expecting the producer to be able to provide dmabufs from a pool or swapchain of these objects. The cache is emptied whenever dmabufs go unused for a certain amount of swaps, or if the size of the provided dmabufs changes. DMABufFormat provides information for different DRM formats, for instance how different planes for specific formats are formatted and sized. DMABufObject is a class that handles a given grouping of dmabufs according to the specified format. It has an associated handle value, size, and per-plane dmabuf file descriptors, offsets, strides and modifiers, along with a DMABufReleaseFlag instance. DMABufReleaseFlag objects are used as an eventfd-based release mechanism that indicates to the producer that the given DMABufObject has been presented and subsequently released and is thus available for reuse. GBMBufferSwapchain provides a custom swapchain implementation that's based on libgbm functionality. Each such swapchain has a capacity specified during construction, with the capacities of four or eight currently supported. getBuffer() is called by the producer to obtain a buffer object that's then used for backing of specific content like ANGLE execution or media's software-decoded video frames. Buffers obtained this way are moved over to the end of the buffer array, with the expectation of reusing them once they are released by the composition engine. MediaPlayerPrivateGStreamer implementation is enhanced to use the recently-added WebKitDMABufVideoSink element if its use is enabled through the development-purpose environment variable and if the necessary GStreamer facilities are present on the system. When these conditions are met, the Nicosia::ContentLayer instance is also constructed with a TextureMapperPlatformLayerProxyDMABuf instance, since we expect to present the dmabufs through that functionality. With the WebKitDMABufVideoSink, the incoming samples are either based on dmabufs (in case of dmabuf-capable hardware decoder) or are just raw data (most likely coming from a software-based decoder). In case of dmabufs we can use the GstMemory pointer as the handle through which the relevant data is cached in TextureMapperPlatformLayerProxyDMABuf, and upon the first occurrence we retrieve all the relevant dmabuf data so that it can be used by that proxy implementation to construct a renderable EGLImage. In case of software-decoded raw data, we have to use the swapchain object and copy the data on a per-plane basis for each such sample, finally pushing the dmabuf data of that swapchain buffer into the TextureMapperPlatformLayerProxyDMABuf instance. * SourcesGTK.txt: * SourcesWPE.txt: * platform/TextureMapper.cmake: * platform/graphics/gbm/DMABufFormat.h: Added. (WebCore::DMABufFormatImpl::createFourCC): (WebCore::DMABufFormat::planeWidth const): (WebCore::DMABufFormat::planeHeight const): (WebCore::DMABufFormat::Plane::Plane): (WebCore::DMABufFormatImpl::createSinglePlaneRGBA): (WebCore::DMABufFormatImpl::definePlane): (WebCore::DMABufFormat::instantiate): (WebCore::DMABufFormat::create): * platform/graphics/gbm/DMABufObject.h: Added. (WebCore::DMABufObject::DMABufObject): (WebCore::DMABufObject::~DMABufObject): (WebCore::DMABufObject::operator=): * platform/graphics/gbm/DMABufReleaseFlag.h: Added. (WebCore::DMABufReleaseFlag::DMABufReleaseFlag): (WebCore::DMABufReleaseFlag::~DMABufReleaseFlag): (WebCore::DMABufReleaseFlag::operator=): (WebCore::DMABufReleaseFlag::dup const): (WebCore::DMABufReleaseFlag::released const): (WebCore::DMABufReleaseFlag::release): * platform/graphics/gbm/GBMBufferSwapchain.cpp: Added. (WebCore::GBMBufferSwapchain::GBMBufferSwapchain): (WebCore::GBMBufferSwapchain::getBuffer): (WebCore::GBMBufferSwapchain::Buffer::Buffer): (WebCore::GBMBufferSwapchain::Buffer::createDMABufObject const): (WebCore::GBMBufferSwapchain::Buffer::PlaneData::~PlaneData): * platform/graphics/gbm/GBMBufferSwapchain.h: Added. (WebCore::GBMBufferSwapchain::Buffer::handle const): (WebCore::GBMBufferSwapchain::Buffer::numPlanes const):
[webkit-changes] [291269] trunk/Source
Title: [291269] trunk/Source Revision 291269 Author you...@apple.com Date 2022-03-15 00:52:24 -0700 (Tue, 15 Mar 2022) Log Message Rename VideoSampleMetadata to VideoFrameTimeMetadata https://bugs.webkit.org/show_bug.cgi?id=237593 Reviewed by Eric Carlson. Source/WebCore: We are going to rename videoSampleAvailable to videoFrameAvailable and move from passing MediaSample to VideoFrame. We rename VideoSampleMetadata to VideoFrameTimeMetadata for consistency. No change of behavior. * Headers.cmake: * Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp: (WebCore::CanvasCaptureMediaStreamTrack::Source::captureCanvas): * WebCore.xcodeproj/project.pbxproj: * platform/VideoFrameTimeMetadata.h: Renamed from Source/WebCore/platform/VideoSampleMetadata.h. (WebCore::VideoFrameTimeMetadata::encode const): (WebCore::VideoFrameTimeMetadata::decode): * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h: * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm: (WebCore::MediaPlayerPrivateMediaStreamAVFObjC::videoSampleAvailable): (WebCore::MediaPlayerPrivateMediaStreamAVFObjC::processNewVideoSample): * platform/graphics/gstreamer/MediaSampleGStreamer.cpp: (WebCore::MediaSampleGStreamer::MediaSampleGStreamer): (WebCore::MediaSampleGStreamer::createImageSample): * platform/graphics/gstreamer/MediaSampleGStreamer.h: (WebCore::MediaSampleGStreamer::create): (WebCore::MediaSampleGStreamer::createImageSample): * platform/graphics/gstreamer/VideoFrameMetadataGStreamer.cpp: (webkitGstBufferSetVideoFrameTimeMetadata): (webkitGstBufferSetVideoSampleMetadata): Deleted. * platform/graphics/gstreamer/VideoFrameMetadataGStreamer.h: * platform/mediarecorder/MediaRecorderPrivateAVFImpl.cpp: (WebCore::MediaRecorderPrivateAVFImpl::videoSampleAvailable): * platform/mediarecorder/MediaRecorderPrivateAVFImpl.h: * platform/mediarecorder/MediaRecorderPrivateGStreamer.h: * platform/mediarecorder/MediaRecorderPrivateMock.cpp: (WebCore::MediaRecorderPrivateMock::videoSampleAvailable): * platform/mediarecorder/MediaRecorderPrivateMock.h: * platform/mediastream/RealtimeIncomingVideoSource.cpp: (WebCore::RealtimeIncomingVideoSource::metadataFromVideoFrame): * platform/mediastream/RealtimeIncomingVideoSource.h: * platform/mediastream/RealtimeMediaSource.cpp: (WebCore::RealtimeMediaSource::videoSampleAvailable): * platform/mediastream/RealtimeMediaSource.h: * platform/mediastream/RealtimeOutgoingVideoSource.h: * platform/mediastream/RealtimeVideoCaptureSource.cpp: (WebCore::RealtimeVideoCaptureSource::dispatchMediaSampleToObservers): * platform/mediastream/RealtimeVideoCaptureSource.h: * platform/mediastream/RealtimeVideoSource.cpp: (WebCore::RealtimeVideoSource::videoSampleAvailable): * platform/mediastream/RealtimeVideoSource.h: * platform/mediastream/cocoa/DisplayCaptureSourceCocoa.cpp: (WebCore::DisplayCaptureSourceCocoa::emitFrame): * platform/mediastream/gstreamer/GStreamerCapturer.cpp: (WebCore::GStreamerCapturer::createSource): * platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp: * platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.cpp: (WebCore::MockDisplayCaptureSourceGStreamer::videoSampleAvailable): (WebCore::MockRealtimeVideoSourceGStreamer::updateSampleBuffer): * platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.h: * platform/mediastream/libwebrtc/gstreamer/RealtimeOutgoingVideoSourceLibWebRTC.cpp: (WebCore::RealtimeOutgoingVideoSourceLibWebRTC::videoSampleAvailable): * platform/mediastream/libwebrtc/gstreamer/RealtimeOutgoingVideoSourceLibWebRTC.h: * platform/mediastream/mac/AVVideoCaptureSource.mm: (WebCore::AVVideoCaptureSource::captureOutputDidOutputSampleBufferFromConnection): * platform/mediastream/mac/MockRealtimeVideoSourceMac.mm: (WebCore::MockRealtimeVideoSourceMac::updateSampleBuffer): * platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.cpp: (WebCore::RealtimeOutgoingVideoSourceCocoa::videoSampleAvailable): * platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.h: * testing/Internals.cpp: (WebCore::Internals::videoSampleAvailable): * testing/Internals.h: Source/WebKit: * UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp: * WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp: (WebKit::MediaRecorderPrivate::videoSampleAvailable): * WebProcess/GPU/webrtc/MediaRecorderPrivate.h: * WebProcess/cocoa/RemoteCaptureSampleManager.cpp: (WebKit::RemoteCaptureSampleManager::videoFrameAvailable): (WebKit::RemoteCaptureSampleManager::videoFrameAvailableCV): (WebKit::RemoteCaptureSampleManager::RemoteVideo::videoFrameAvailable): * WebProcess/cocoa/RemoteCaptureSampleManager.h: * WebProcess/cocoa/RemoteCaptureSampleManager.messages.in: * WebProcess/cocoa/RemoteRealtimeDisplaySource.h: * WebProcess/cocoa/RemoteRealtimeVideoSource.cpp: (WebKit::RemoteRealtimeVideoSource::videoSampleAvailable): * WebProcess/cocoa/RemoteRealtimeVideoSource.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Headers.cmake
[webkit-changes] [291268] trunk
Title: [291268] trunk Revision 291268 Author you...@apple.com Date 2022-03-15 00:28:45 -0700 (Tue, 15 Mar 2022) Log Message Make sure to end any pending AudioSession interruption when activating it https://bugs.webkit.org/show_bug.cgi?id=237654 Reviewed by Eric Carlson. Source/WebCore: In some cases, we receive audio session interruptions without receiving any end of interruption notification. In those cases, if we reactivate the audio session, we should end this pending interruption so that our WebCore code gets its expected end of interruption message. This for instance allows to get back regular autoplay behavior. Test: platform/ios/mediastream/getUserMedia-override-audio-session-interruption.html * platform/audio/AudioSession.cpp: * platform/audio/AudioSession.h: * testing/Internals.cpp: * testing/Internals.h: * testing/Internals.idl: LayoutTests: * platform/ios/mediastream/getUserMedia-override-audio-session-interruption-expected.txt: Added. * platform/ios/mediastream/getUserMedia-override-audio-session-interruption.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/audio/AudioSession.cpp trunk/Source/WebCore/platform/audio/AudioSession.h trunk/Source/WebCore/testing/Internals.cpp trunk/Source/WebCore/testing/Internals.h trunk/Source/WebCore/testing/Internals.idl Added Paths trunk/LayoutTests/platform/ios/mediastream/getUserMedia-override-audio-session-interruption-expected.txt trunk/LayoutTests/platform/ios/mediastream/getUserMedia-override-audio-session-interruption.html Diff Modified: trunk/LayoutTests/ChangeLog (291267 => 291268) --- trunk/LayoutTests/ChangeLog 2022-03-15 07:19:08 UTC (rev 291267) +++ trunk/LayoutTests/ChangeLog 2022-03-15 07:28:45 UTC (rev 291268) @@ -1,5 +1,16 @@ 2022-03-15 Youenn Fablet +Make sure to end any pending AudioSession interruption when activating it +https://bugs.webkit.org/show_bug.cgi?id=237654 + + +Reviewed by Eric Carlson. + +* platform/ios/mediastream/getUserMedia-override-audio-session-interruption-expected.txt: Added. +* platform/ios/mediastream/getUserMedia-override-audio-session-interruption.html: Added. + +2022-03-15 Youenn Fablet + AudioContext stops playing when minimizing or moving the macOS Safari window to the background. https://bugs.webkit.org/show_bug.cgi?id=231105 Added: trunk/LayoutTests/platform/ios/mediastream/getUserMedia-override-audio-session-interruption-expected.txt (0 => 291268) --- trunk/LayoutTests/platform/ios/mediastream/getUserMedia-override-audio-session-interruption-expected.txt (rev 0) +++ trunk/LayoutTests/platform/ios/mediastream/getUserMedia-override-audio-session-interruption-expected.txt 2022-03-15 07:28:45 UTC (rev 291268) @@ -0,0 +1,4 @@ + + +PASS call getUserMedia, stop, interrupt and recall getUserMedia + Added: trunk/LayoutTests/platform/ios/mediastream/getUserMedia-override-audio-session-interruption.html (0 => 291268) --- trunk/LayoutTests/platform/ios/mediastream/getUserMedia-override-audio-session-interruption.html (rev 0) +++ trunk/LayoutTests/platform/ios/mediastream/getUserMedia-override-audio-session-interruption.html 2022-03-15 07:28:45 UTC (rev 291268) @@ -0,0 +1,40 @@ + + + +override interruption with getUserMedia + + + +