[webkit-changes] [WebKit/WebKit] 4726e7: Move OrganizationStorageAccessPromptQuirk.h to an ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4726e7aef86fec61c8d9ca1c8183f767964dfbd2 https://github.com/WebKit/WebKit/commit/4726e7aef86fec61c8d9ca1c8183f767964dfbd2 Author: Matthew Finkel Date: 2024-03-22 (Fri, 22 Mar 2024) Changed paths: M Source/WebCore/WebCore.xcodeproj/project.pbxproj Log Message: --- Move OrganizationStorageAccessPromptQuirk.h to an appropriate location in XCode project https://bugs.webkit.org/show_bug.cgi?id=271434 rdar://125204479 Reviewed by Tim Horton. In 271748@main I added OrganizationStorageAccessPromptQuirk.h, but I didn't put it in a reasonable place in the project. This patch moves it into the appropriate directory. * Source/WebCore/WebCore.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/276564@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 82f00c: Build fix: WK_LIBFUZZER_COVERAGE should default to...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 82f00cc8423edec797db214ddac522782ac082f8 https://github.com/WebKit/WebKit/commit/82f00cc8423edec797db214ddac522782ac082f8 Author: David Kilzer Date: 2024-03-22 (Fri, 22 Mar 2024) Changed paths: M Makefile.shared Log Message: --- Build fix: WK_LIBFUZZER_COVERAGE should default to trace-pc-guard when Fuzzilli is enabled https://bugs.webkit.org/show_bug.cgi?id=269796 Unreviewed build fix. * Makefile.shared: - Change WK_LIBFUZZER_COVERAGE to WK_SANITIZER_COVERAGE since the variable name changed in 275632@main for another build fix. Canonical link: https://commits.webkit.org/276547@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9e4d69: Remove non-standard `width()` and `height()` funct...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9e4d6906a76b73fae8fa281245ec884929dbd6a5 https://github.com/WebKit/WebKit/commit/9e4d6906a76b73fae8fa281245ec884929dbd6a5 Author: Ahmad Saleem Date: 2024-03-21 (Thu, 21 Mar 2024) Changed paths: M Source/WebCore/html/HTMLDocument.cpp M Source/WebCore/html/HTMLDocument.h M Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLDocument.cpp M Source/WebKitLegacy/mac/DOM/DOMHTMLDocument.mm Log Message: --- Remove non-standard `width()` and `height()` functions of HTMLDocument https://bugs.webkit.org/show_bug.cgi?id=271190 Reviewed by Ryosuke Niwa and Michael Catanzaro. This patch is to remove remaining code for dropped `HTMLDocument.width / height` attributes, which were dropped in 171244@main (via IDL changes) and later removed in 179619@main (both in 2016 - via removal from IDL). * Source/WebCore/html/HTMLDocument.cpp: (HTMLDocument::width): Deleted (HTMLDocument::height): Deleted * Source/WebCore/html/HTMLDocument.h: * Source/WebKitLegacy/mac/DOM/DOMHTMLDocument.mm: (width): (height): * Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLDocument.cpp: (webkit_dom_html_document_get_width): (webkit_dom_html_document_get_height): Canonical link: https://commits.webkit.org/276488@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1d87ff: Further adjustments to the organization storage ac...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1d87ffb4145cbaff9fc2b97b2bd6d7d2f3dda29a https://github.com/WebKit/WebKit/commit/1d87ffb4145cbaff9fc2b97b2bd6d7d2f3dda29a Author: Matthew Finkel Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WebCore/en.lproj/Localizable.strings M Source/WebKit/UIProcess/Cocoa/WKStorageAccessAlert.h M Source/WebKit/UIProcess/Cocoa/WKStorageAccessAlert.mm Log Message: --- Further adjustments to the organization storage access prompt https://bugs.webkit.org/show_bug.cgi?id=271007 rdar://124640260 Reviewed by Wenson Hsieh. After receiving additional feedback, adjust the wording and add a disclosure list. If the list of domains is more than 2, then show the domains in a list via a disclosure button. * Source/WebCore/en.lproj/Localizable.strings: * Source/WebKit/UIProcess/Cocoa/WKStorageAccessAlert.h: * Source/WebKit/UIProcess/Cocoa/WKStorageAccessAlert.mm: (-[_WKSSOSiteList initWithSiteList:withAlert:withTableView:]): (-[_WKSSOSiteList numberOfRowsInTableView:]): (-[_WKSSOSiteList tableView:viewForTableColumn:row:]): (-[_WKSSOSiteList toggleTableViewContents:]): (WebKit::presentStorageAccessAlert): (WebKit::presentStorageAccessAlertQuirk): (WebKit::presentStorageAccessAlertSSOQuirk): (WebKit::displayStorageAccessAlert): Canonical link: https://commits.webkit.org/276435@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 243400: Add Matthew Finkel as a reviewer in contributors.json
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 243400dfc4a0c576811cf4410c4ddbc21da39991 https://github.com/WebKit/WebKit/commit/243400dfc4a0c576811cf4410c4ddbc21da39991 Author: Matthew Finkel Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M metadata/contributors.json Log Message: --- Add Matthew Finkel as a reviewer in contributors.json https://bugs.webkit.org/show_bug.cgi?id=271334 rdar://125110632 Reviewed by Charlie Wolfe. Update my entry with my granted reviewer privileges. * metadata/contributors.json: Canonical link: https://commits.webkit.org/276419@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f70606: [JSC] Extend JSBigInt::compare and JSBigInt::compa...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f706066e1e24e20a84f82374480a7b33e1de2d10 https://github.com/WebKit/WebKit/commit/f706066e1e24e20a84f82374480a7b33e1de2d10 Author: Yijia Huang Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/JavaScriptCore/runtime/JSBigInt.cpp M Source/JavaScriptCore/runtime/JSBigInt.h M Source/WTF/wtf/MathExtras.h Log Message: --- [JSC] Extend JSBigInt::compare and JSBigInt::compareToDouble for Int64 and Int32 https://bugs.webkit.org/show_bug.cgi?id=271073 rdar://124706111 Reviewed by Keith Miller. This patch extends JSBigInt::compare and JSBigInt::compareToDouble for Int64 and Int32. * Source/JavaScriptCore/runtime/JSBigInt.cpp: (JSC::Int64BigIntImpl::Int64BigIntImpl): (JSC::Int64BigIntImpl::isZero): (JSC::Int64BigIntImpl::sign): (JSC::Int64BigIntImpl::length): (JSC::Int64BigIntImpl::digit): (JSC::JSBigInt::compare): (JSC::JSBigInt::compareToDouble): * Source/JavaScriptCore/runtime/JSBigInt.h: Canonical link: https://commits.webkit.org/276417@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fbd093: Unreviewed, reverting 276373@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fbd093121b1beaf10159c90404afb7e9e3a325b8 https://github.com/WebKit/WebKit/commit/fbd093121b1beaf10159c90404afb7e9e3a325b8 Author: Commit Queue Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml Log Message: --- Unreviewed, reverting 276373@main. https://bugs.webkit.org/show_bug.cgi?id=271326 exposed issues with rendering captions Reverted changeset: "[visionOS] Enable Linear Media Player by default" https://bugs.webkit.org/show_bug.cgi?id=271172 https://commits.webkit.org/276373@main Canonical link: https://commits.webkit.org/276410@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9aeec6: Unreviewed, reverting 276295@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9aeec6fc24fd0574d6738ad72867e792447d7427 https://github.com/WebKit/WebKit/commit/9aeec6fc24fd0574d6738ad72867e792447d7427 Author: Commit Queue Date: 2024-03-19 (Tue, 19 Mar 2024) Changed paths: M JSTests/wasm/stress/simd-unreachable.js M JSTests/wasm/v8/adapter-frame.js M JSTests/wasm/v8/add-getters.js M JSTests/wasm/v8/anyfunc.js M JSTests/wasm/v8/array-copy-benchmark.js M JSTests/wasm/v8/array-init-from-segment.js M JSTests/wasm/v8/asm-wasm-copy.js M JSTests/wasm/v8/asm-wasm-deopt.js M JSTests/wasm/v8/asm-wasm-exception-in-tonumber.js M JSTests/wasm/v8/asm-wasm-expr.js M JSTests/wasm/v8/asm-wasm-f32.js M JSTests/wasm/v8/asm-wasm-f64.js M JSTests/wasm/v8/asm-wasm-heap.js M JSTests/wasm/v8/asm-wasm-i32.js M JSTests/wasm/v8/asm-wasm-imports.js M JSTests/wasm/v8/asm-wasm-literals.js M JSTests/wasm/v8/asm-wasm-math-intrinsic.js M JSTests/wasm/v8/asm-wasm-memory.js M JSTests/wasm/v8/asm-wasm-names.js M JSTests/wasm/v8/asm-wasm-stack.js M JSTests/wasm/v8/asm-wasm-stdlib.js M JSTests/wasm/v8/asm-wasm-switch.js M JSTests/wasm/v8/asm-wasm-u32.js M JSTests/wasm/v8/asm-wasm.js M JSTests/wasm/v8/asm-with-wasm-off.js M JSTests/wasm/v8/atomics-non-shared.js M JSTests/wasm/v8/atomics-stress.js M JSTests/wasm/v8/atomics.js M JSTests/wasm/v8/atomics64-stress.js M JSTests/wasm/v8/bigint-i64-to-imported-js-func.js M JSTests/wasm/v8/bigint-opt.js M JSTests/wasm/v8/bigint-rematerialize.js M JSTests/wasm/v8/bigint.js M JSTests/wasm/v8/bit-shift-right.js M JSTests/wasm/v8/bounds-check-64bit.js M JSTests/wasm/v8/bounds-check-turbofan.js M JSTests/wasm/v8/bulk-memory.js M JSTests/wasm/v8/call-ref.js M JSTests/wasm/v8/call_indirect.js M JSTests/wasm/v8/calls.js M JSTests/wasm/v8/code-space-overflow.js M JSTests/wasm/v8/committed-code-exhaustion.js M JSTests/wasm/v8/compare-exchange-stress.js M JSTests/wasm/v8/compare-exchange64-stress.js M JSTests/wasm/v8/compilation-hints-async-compilation.js M JSTests/wasm/v8/compilation-hints-decoder.js M JSTests/wasm/v8/compilation-hints-ignored.js M JSTests/wasm/v8/compilation-hints-lazy-validation.js M JSTests/wasm/v8/compilation-hints-streaming-compilation.js M JSTests/wasm/v8/compilation-hints-streaming-lazy-validation.js M JSTests/wasm/v8/compilation-hints-sync-compilation.js M JSTests/wasm/v8/compilation-limits-asm.js M JSTests/wasm/v8/compilation-limits.js M JSTests/wasm/v8/compiled-module-management.js M JSTests/wasm/v8/compiled-module-serialization.js M JSTests/wasm/v8/data-segments.js M JSTests/wasm/v8/disable-trap-handler.js M JSTests/wasm/v8/disallow-codegen.js M JSTests/wasm/v8/divrem-trap.js M JSTests/wasm/v8/element-segments-with-reftypes.js M JSTests/wasm/v8/empirical_max_memory.js M JSTests/wasm/v8/ensure-wasm-binaries-up-to-date.js M JSTests/wasm/v8/errors.js M JSTests/wasm/v8/export-global.js M JSTests/wasm/v8/export-identity.js M JSTests/wasm/v8/export-mutable-global.js M JSTests/wasm/v8/export-table.js M JSTests/wasm/v8/expose-wasm.js M JSTests/wasm/v8/extended-constants.js M JSTests/wasm/v8/externref-globals.js M JSTests/wasm/v8/externref-table.js M JSTests/wasm/v8/externref.js M JSTests/wasm/v8/ffi-error.js M JSTests/wasm/v8/ffi.js M JSTests/wasm/v8/float-constant-folding.js M JSTests/wasm/v8/function-names.js M JSTests/wasm/v8/function-prototype.js M JSTests/wasm/v8/futex.js M JSTests/wasm/v8/gc-buffer.js M JSTests/wasm/v8/gc-casts-from-any.js M JSTests/wasm/v8/gc-casts-invalid.js M JSTests/wasm/v8/gc-casts-subtypes.js M JSTests/wasm/v8/gc-experimental-string-conversions.js M JSTests/wasm/v8/gc-experiments.js M JSTests/wasm/v8/gc-frame.js M JSTests/wasm/v8/gc-js-interop-async-debugger.js M JSTests/wasm/v8/gc-js-interop-collections.js M JSTests/wasm/v8/gc-js-interop-export.mjs M JSTests/wasm/v8/gc-js-interop-global-constructors.js M JSTests/wasm/v8/gc-js-interop-import.mjs M JSTests/wasm/v8/gc-js-interop-numeric.js M JSTests/wasm/v8/gc-js-interop-objects.js M JSTests/wasm/v8/gc-js-interop-wasm.js M JSTests/wasm/v8/gc-js-interop.js M JSTests/wasm/v8/gc-memory.js M JSTests/wasm/v8/gc-nominal.js M JSTests/wasm/v8/gc-optimizations.js M JSTests/wasm/v8/gc-stress.js M JSTests/wasm/v8/gc-typecheck-reducer.js M JSTests/wasm/v8/gdbjit.js M JSTests/wasm/v8/generic-wrapper.js M JSTests/wasm/v8/globals-import-export-identity.js M JSTests/wasm/v8/globals.js M JSTests/wasm/v8/graceful_shutdown.js M JSTests/wasm/v8/graceful_shutdown_during_tierup.js M JSTests/wasm/v8/grow-huge-memory.js M JSTests/wasm/v8/grow-memory-detaching.js M JSTests/wasm/v8/grow-memory
[webkit-changes] [WebKit/WebKit] 80b0cc: [WebAuthn] Unable to submit new requests after can...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 80b0cc5927c72554468e135fcdd28fb6a7316f51 https://github.com/WebKit/WebKit/commit/80b0cc5927c72554468e135fcdd28fb6a7316f51 Author: Pascoe Date: 2024-03-19 (Tue, 19 Mar 2024) Changed paths: M Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp Log Message: --- [WebAuthn] Unable to submit new requests after cancelling conditional mediation via abortSignal rdar://124727713 https://bugs.webkit.org/show_bug.cgi?id=271257 Reviewed by Charlie Wolfe. In https://bugs.webkit.org/show_bug.cgi?id=257176, functionality was introduced to wait for a previous request's cancel to complete before submitting a subsequent one. However, there's currently a bug that does not set the cancel flag to false if there's no subsequent request. This patch fixes that bug by setting m_isCancelling to false once the cancel completes regardless of if there's a subsequent request. * Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp: (WebCore::AuthenticatorCoordinator::create): (WebCore::AuthenticatorCoordinator::discoverFromExternalSource): Canonical link: https://commits.webkit.org/276368@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c1017d: [JSC] Use DeferGCForAWhile instead of DeferGC in c...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c1017d3d1fc53f46679a5e2df2d6d71b66253fd8 https://github.com/WebKit/WebKit/commit/c1017d3d1fc53f46679a5e2df2d6d71b66253fd8 Author: Yijia Huang Date: 2024-03-19 (Tue, 19 Mar 2024) Changed paths: M Source/JavaScriptCore/runtime/ErrorInstance.cpp Log Message: --- [JSC] Use DeferGCForAWhile instead of DeferGC in computeErrorInfo https://bugs.webkit.org/show_bug.cgi?id=268489 rdar://121906810 Reviewed by Mark Lam, Yusuke Suzuki and Justin Michaud. ErrorInstance::computeErrorInfo can be called from GC's Heap::runEndPhase. In the case, we should use DeferGCForAWhile instead of DeferGC since it can trigger another GC in its destruction. * Source/JavaScriptCore/runtime/ErrorInstance.cpp: (JSC::ErrorInstance::computeErrorInfo): Originally-landed-as: 272448.442@safari-7618-branch (58204e87a044). rdar://124554094 Canonical link: https://commits.webkit.org/276346@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 48a7d5: Add Tanmoy Panigrahi as a contributor
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 48a7d5d9c1cbad06030708a4afbee8b56d842be4 https://github.com/WebKit/WebKit/commit/48a7d5d9c1cbad06030708a4afbee8b56d842be4 Author: Tanmoy Panigrahi Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M metadata/contributors.json Log Message: --- Add Tanmoy Panigrahi as a contributor https://bugs.webkit.org/show_bug.cgi?id=271204 rdar://124978532 Reviewed by Aditya Keerthi. I opened my first PR to WebKit today, and hope to contribute more in the future. Adding myself as a contributor will also help prevent benign errors/making it smoother to contribute. * metadata/contributors.json: Canonical link: https://commits.webkit.org/276331@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 27daa9: Unreviewed, reverting 276290@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 27daa90c6ffa89d11aac4bc668d25868b8266f10 https://github.com/WebKit/WebKit/commit/27daa90c6ffa89d11aac4bc668d25868b8266f10 Author: Commit Queue Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: R Source/WebKit/Platform/spi/Cocoa/AccessibilityUtilitiesSPI.h M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm Log Message: --- Unreviewed, reverting 276290@main. https://bugs.webkit.org/show_bug.cgi?id=271192 Introduced build issue Reverted changeset: "Create header file for interface declaration" https://bugs.webkit.org/show_bug.cgi?id=271160 https://commits.webkit.org/276290@main Canonical link: https://commits.webkit.org/276315@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6c9fb3: Unreviewed, reverting 276198@main and 276218@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6c9fb3193d9dbf320747d07b485d275b4adf8f2d https://github.com/WebKit/WebKit/commit/6c9fb3193d9dbf320747d07b485d275b4adf8f2d Author: Commit Queue Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/JavaScriptCore/jsc.cpp M Source/JavaScriptCore/runtime/InitializeThreading.cpp M Source/JavaScriptCore/runtime/MachineContext.h M Source/JavaScriptCore/runtime/VMTraps.cpp M Source/JavaScriptCore/wasm/WasmFaultSignalHandler.cpp M Source/JavaScriptCore/wasm/WasmFaultSignalHandler.h M Source/WTF/WTF.xcodeproj/project.pbxproj M Source/WTF/wtf/PlatformJSCOnly.cmake M Source/WTF/wtf/PlatformMac.cmake M Source/WTF/wtf/PlatformRegisters.cpp M Source/WTF/wtf/PlatformRegisters.h M Source/WTF/wtf/threads/Signals.cpp M Source/WTF/wtf/threads/Signals.h M Source/WTF/wtf/win/SignalsWin.cpp M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in M Source/WebKit/WebProcess/com.apple.WebProcess.sb.in M Tools/TestWebKitAPI/Tests/WTF/Signals.cpp Log Message: --- Unreviewed, reverting 276198@main and 276218@main. https://bugs.webkit.org/show_bug.cgi?id=271182 Broke internal Safari Reverted changesets: "new exception handler adoption" https://bugs.webkit.org/show_bug.cgi?id=269728 https://commits.webkit.org/276198@main "fix darwin_arm_thread_state64 macro usage build issue" https://bugs.webkit.org/show_bug.cgi?id=271097 https://commits.webkit.org/276218@main Canonical link: https://commits.webkit.org/276302@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ee7e9f: [Xcode] Simplify code coverage builds
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ee7e9fa115013e7be28a5ba2f52c16f486d4e55a https://github.com/WebKit/WebKit/commit/ee7e9fa115013e7be28a5ba2f52c16f486d4e55a Author: David Kilzer Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Makefile.shared M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Tools/Scripts/webkitdirs.pm R Tools/coverage/coverage.xcconfig Log Message: --- [Xcode] Simplify code coverage builds https://bugs.webkit.org/show_bug.cgi?id=271055 Reviewed by Alex Christensen. This change simplifies code coverage builds of WebKit using Xcode. Instead of specifying `-xcconfig Tools/coverage/coverage.xcconfig` on the command-line, the CLANG_COVERAGE_MAPPING=YES Xcode variable now enables code coverage builds. * Makefile.shared: - Add support for `CODE_COVERAGE=YES` when using `make` to build. * Source/WebCore/WebCore.xcodeproj/project.pbxproj: (WebCoreTestSupport: InternalSettingsGenerated.cpp): - This file causes clang to hang indefinitely when compiled with code coverage enabled, so add "-fno-profile-instr-generate -fno-coverage-mapping" to COMPILER_FLAGS for just this file. (Has no effect on non-code-coverage builds.) The issue is tracked by . * Tools/Scripts/webkitdirs.pm: (XcodeCoverageSupportOptions): - Use "CLANG_COVERAGE_MAPPING=YES" instead of specifying a path to Tools/coverage/coverage.xcconfig. * Tools/coverage/coverage.xcconfig: Remove. Canonical link: https://commits.webkit.org/276273@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6991ef: Reduce function call in `prepareWhitespaceAtPositi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6991ef6c707e9b2a052dc182c7d3ca9801b1d3a0 https://github.com/WebKit/WebKit/commit/6991ef6c707e9b2a052dc182c7d3ca9801b1d3a0 Author: Ahmad Saleem Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WebCore/editing/CompositeEditCommand.cpp Log Message: --- Reduce function call in `prepareWhitespaceAtPositionForSplit` https://bugs.webkit.org/show_bug.cgi?id=271119 Reviewed by Ryosuke Niwa. This patch is to reduce function call by using local variable introduced above. * Source/WebCore/editing/CompositeEditCommand.cpp: (CompositeEditCommand::prepareWhitespaceAtPositionForSplit): Canonical link: https://commits.webkit.org/276269@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6a79c9: [dav1d] Enable DAV1D_MT_FUZZING for dav1d_fuzzer
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6a79c9fe3e4419a948bd382093ed2c182c7d4f8c https://github.com/WebKit/WebKit/commit/6a79c9fe3e4419a948bd382093ed2c182c7d4f8c Author: David Kilzer Date: 2024-03-17 (Sun, 17 Mar 2024) Changed paths: M Source/WebCore/PAL/ThirdParty/libavif/ThirdParty/dav1d/Configurations/dav1d_fuzzer.xcconfig Log Message: --- [dav1d] Enable DAV1D_MT_FUZZING for dav1d_fuzzer https://bugs.webkit.org/show_bug.cgi?id=271090 Reviewed by Alex Christensen. * Source/WebCore/PAL/ThirdParty/libavif/ThirdParty/dav1d/Configurations/dav1d_fuzzer.xcconfig: (GCC_PREPROCESSOR_DEFINITIONS): Add. - Define DAV1D_MT_FUZZING when building. Canonical link: https://commits.webkit.org/276251@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cf053c: Remove non-standard `HashChangeEvent.initHashChang...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cf053c07242eafb5f2f371db03ce47ac0e261e9d https://github.com/WebKit/WebKit/commit/cf053c07242eafb5f2f371db03ce47ac0e261e9d Author: Ahmad Saleem Date: 2024-03-16 (Sat, 16 Mar 2024) Changed paths: M LayoutTests/fast/events/initEvent-after-dispatching-expected.txt M LayoutTests/fast/events/initEvent-after-dispatching.html M Source/WebCore/dom/HashChangeEvent.h M Source/WebCore/dom/HashChangeEvent.idl Log Message: --- Remove non-standard `HashChangeEvent.initHashChangeEvent` https://bugs.webkit.org/show_bug.cgi?id=271094 Reviewed by Ryosuke Niwa. This patch aligns WebKit with Blink / Chrome and Web Specification [1]: [1] https://html.spec.whatwg.org/multipage/nav-history-apis.html#the-hashchangeevent-interface By removing `initHashChangeEvent`, WebKit aligns with Web Specification and Blink also removed it in 2015 via below commit: Reference: https://src.chromium.org/viewvc/blink?view=revision=202347 * Source/WebCore/dom/HashChangeEvent.idl: * Source/WebCore/dom/HashChangeEvent.h: (initHashChangeEvent): Removed * LayoutTests/fast/events/initEvent-after-dispatching.html: Rebaselined * LayoutTests/fast/events/initEvent-after-dispatching-expected.txt: Rebaselined Canonical link: https://commits.webkit.org/276232@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b6c777: fix darwin_arm_thread_state64 macro usage build issue
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b6c777aed6a812c0f6109ac6245b67cdad61c816 https://github.com/WebKit/WebKit/commit/b6c777aed6a812c0f6109ac6245b67cdad61c816 Author: Brandon Kayes Date: 2024-03-15 (Fri, 15 Mar 2024) Changed paths: M Source/JavaScriptCore/runtime/MachineContext.h Log Message: --- fix darwin_arm_thread_state64 macro usage build issue https://bugs.webkit.org/show_bug.cgi?id=271097 rdar://124720658 Reviewed by Ryosuke Niwa. these macros are not defined on watchos or simulators, so we can safely ignore them. * Source/JavaScriptCore/runtime/MachineContext.h: (JSC::MachineContext::setInstructionPointer): Canonical link: https://commits.webkit.org/276218@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4c23f1: [dav1d] Fix tile_start_off calculations for extrem...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4c23f1a14c60568f0d5c2dd7d832350a561afe50 https://github.com/WebKit/WebKit/commit/4c23f1a14c60568f0d5c2dd7d832350a561afe50 Author: David Kilzer Date: 2024-03-15 (Fri, 15 Mar 2024) Changed paths: M Source/WebCore/PAL/ThirdParty/libavif/ThirdParty/dav1d/src/decode.c M Source/WebCore/PAL/ThirdParty/libavif/ThirdParty/dav1d/src/internal.h Log Message: --- [dav1d] Fix tile_start_off calculations for extremely large frame sizes https://bugs.webkit.org/show_bug.cgi?id=271068 Unreviewed upstream merge of 2b475307dc11be9a1c3cc4358102c76a7f386a51. * Source/WebCore/PAL/ThirdParty/libavif/ThirdParty/dav1d/src/decode.c: (dav1d_decode_frame_init): * Source/WebCore/PAL/ThirdParty/libavif/ThirdParty/dav1d/src/internal.h: Canonical link: https://commits.webkit.org/276207@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fd0252: [WebAuthn] Pass appid extension in modern AS flow
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fd02524abbb7bfb5cf3b8168f52d890325e2d2f9 https://github.com/WebKit/WebKit/commit/fd02524abbb7bfb5cf3b8168f52d890325e2d2f9 Author: Pascoe Date: 2024-03-15 (Fri, 15 Mar 2024) Changed paths: M Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticationServicesForwardDeclarations.h M Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm Log Message: --- [WebAuthn] Pass appid extension in modern AS flow https://bugs.webkit.org/show_bug.cgi?id=270989 rdar://124627462 Reviewed by Brent Fulgham. This patch starts to pass the appID extension in the modern flow using AuthenticationServices.framework. * Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticationServicesForwardDeclarations.h: * Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm: (WebKit::WebAuthenticatorCoordinatorProxy::requestsForAssertion): (WebKit::WebAuthenticatorCoordinatorProxy::performRequest): Canonical link: https://commits.webkit.org/276199@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9bdabe: new exception handler adoption
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9bdabedf3aab2b9b2b562d6f1978aacec147f747 https://github.com/WebKit/WebKit/commit/9bdabedf3aab2b9b2b562d6f1978aacec147f747 Author: Brandon Kayes Date: 2024-03-15 (Fri, 15 Mar 2024) Changed paths: M Source/JavaScriptCore/jsc.cpp M Source/JavaScriptCore/runtime/InitializeThreading.cpp M Source/JavaScriptCore/runtime/MachineContext.h M Source/JavaScriptCore/runtime/VMTraps.cpp M Source/JavaScriptCore/wasm/WasmFaultSignalHandler.cpp M Source/JavaScriptCore/wasm/WasmFaultSignalHandler.h M Source/WTF/WTF.xcodeproj/project.pbxproj M Source/WTF/wtf/PlatformJSCOnly.cmake M Source/WTF/wtf/PlatformMac.cmake M Source/WTF/wtf/PlatformRegisters.cpp M Source/WTF/wtf/PlatformRegisters.h M Source/WTF/wtf/threads/Signals.cpp M Source/WTF/wtf/threads/Signals.h M Source/WTF/wtf/win/SignalsWin.cpp M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in M Source/WebKit/WebProcess/com.apple.WebProcess.sb.in M Tools/TestWebKitAPI/Tests/WTF/Signals.cpp Log Message: --- new exception handler adoption https://bugs.webkit.org/show_bug.cgi?id=269728 rdar://119256062 Reviewed by Keith Miller. This adopts the new hardened mach exception mechanism which was introduced in darwin recently. See the radar for more details. * Source/JavaScriptCore/llint/LLIntData.cpp: * Source/JavaScriptCore/llint/LLIntData.h: * Source/JavaScriptCore/runtime/MachineContext.h: (JSC::MachineContext::setInstructionPointer): * Source/JavaScriptCore/wasm/WasmFaultSignalHandler.cpp: (JSC::Wasm::trapHandler): * Source/WTF/WTF.xcodeproj/project.pbxproj: * Source/WTF/wtf/PlatformHave.h: * Source/WTF/wtf/PlatformJSCOnly.cmake: * Source/WTF/wtf/PlatformMac.cmake: * Source/WTF/wtf/PlatformRegisters.h: * Source/WTF/wtf/threads/Signals.cpp: (WTF::initMachExceptionHandlerThread): (WTF::setExceptionPorts): * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: * Source/WebKit/WebProcess/com.apple.WebProcess.sb.in: Canonical link: https://commits.webkit.org/276198@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fdb77b: Adding layout tests for postMessage CryptoKey for ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fdb77ba046f0ffbbf952879f1f6c7c0c5c4d63e9 https://github.com/WebKit/WebKit/commit/fdb77ba046f0ffbbf952879f1f6c7c0c5c4d63e9 Author: nmahendru Date: 2024-03-15 (Fri, 15 Mar 2024) Changed paths: M LayoutTests/http/tests/workers/service/indexeddb-cryptokey-put-get.https-expected.txt M LayoutTests/http/tests/workers/service/resources/indexeddb-cryptokey-put-get-worker.js M LayoutTests/http/tests/workers/service/resources/indexeddb-cryptokey-put-get.js M LayoutTests/http/tests/workers/service/resources/sw-test-pre.js M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebProcessProxy.cpp M Source/WebKit/UIProcess/WebProcessProxy.h M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreClient.h M Tools/WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm Log Message: --- Adding layout tests for postMessage CryptoKey for ServiceWorkers. https://bugs.webkit.org/show_bug.cgi?id=183167 rdar://124393477 Reviewed by Sihui Liu and Alex Christensen. webCryptoMasterkey in WkWebsiteDataStoreDelegate and webCryptoMasterKeyforWebView in WKNavigationDelegatePrivate both need to return the same masterKey. This is essential for both postMessage from MainPage to ServiceWorker and vice versa to work for CryptoKeys. Here we demonstrate it working via a test. We can remove the webCryptoMasterKeyForWebView and only have the new one once Safari can implement webCryptoMasterKey.(Just like in the test implementation here). Also, WebKitTestRunner is using the V3Navigation client which is actually using a hardcoded value for the key for deterministic tests. So Setting the same value for WKWebsiteDataStoreDelegate. Essentially, ServiceWorkers were enable to do PostMessage of a key but it's just that after 276088@main it just so happened that the ServiceWorker was using the default key but the main Page had a hardcoded key. This patch also fixes that. * LayoutTests/http/tests/workers/service/indexeddb-cryptokey-put-get.https-expected.txt: * LayoutTests/http/tests/workers/service/resources/indexeddb-cryptokey-put-get-worker.js: (async runTest): (async createKeys): Deleted. (async testFetchedKeys): Deleted. * LayoutTests/http/tests/workers/service/resources/indexeddb-cryptokey-put-get.js: (async test): (async checkKey): (async createKeys): (async testKey): (async event): (event.catch): Deleted. * LayoutTests/http/tests/workers/service/resources/sw-test-pre.js: (bytesToHexString): * Tools/WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm: (-[TestWebsiteDataStoreDelegate webCryptoMasterKey]): Canonical link: https://commits.webkit.org/276197@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5680a7: Unreviewed, reverting 276085@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5680a73c86d6441a228665914312d9e812b58a03 https://github.com/WebKit/WebKit/commit/5680a73c86d6441a228665914312d9e812b58a03 Author: Commit Queue Date: 2024-03-15 (Fri, 15 Mar 2024) Changed paths: M Source/JavaScriptCore/llint/InPlaceInterpreter.asm M Source/JavaScriptCore/llint/LowLevelInterpreter.cpp M Source/JavaScriptCore/offlineasm/asm.rb M Source/JavaScriptCore/offlineasm/ast.rb M Source/JavaScriptCore/offlineasm/backends.rb M Source/JavaScriptCore/offlineasm/parser.rb M Source/JavaScriptCore/offlineasm/transform.rb Log Message: --- Unreviewed, reverting 276085@main. https://bugs.webkit.org/show_bug.cgi?id=271065 Broke Safari with newer SDK Reverted changeset: "[JSC] Add aligned label annotation to offlineasm" https://bugs.webkit.org/show_bug.cgi?id=270699 https://commits.webkit.org/276085@main Canonical link: https://commits.webkit.org/276191@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6f20a0: Make WebAuthn interface easier to call from Swift
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6f20a053abaf3366ff82a0fff43fb4d61e24cc46 https://github.com/WebKit/WebKit/commit/6f20a053abaf3366ff82a0fff43fb4d61e24cc46 Author: Garrett Davidson Date: 2024-03-15 (Fri, 15 Mar 2024) Changed paths: M Source/WebKit/UIProcess/API/Cocoa/_WKAuthenticatorAssertionResponse.mm M Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h Log Message: --- Make WebAuthn interface easier to call from Swift rdar://124490616 Reviewed by Brent Fulgham. This patch updates a few bits from the WebAuthn interface to make them easier to call from Swift. * Source/WebKit/UIProcess/API/Cocoa/_WKAuthenticatorAssertionResponse.mm: (-[_WKAuthenticatorAssertionResponse initWithClientDataJSON:rawId:extensions:authenticatorData:signature:userHandle:attachment:]): (-[_WKAuthenticatorAssertionResponse initWithClientDataJSON:rawId:extensionOutputsCBOR:authenticatorData:signature:userHandle:attachment:]): (-[_WKAuthenticatorAssertionResponse dealloc]): None of the ivars in this class were being retained/released. This hasn't been an issue for ObjC because they're all retained by the callsite, but it matters for Swift due to the bridging between Data and NSData. The superclass already retains/releases its ivars correctly. * Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h: All of the results in these completion handlers are nullable (e.g. we never expect to return an assertion _and_ an error). ObjC doesn't care if they're annotated incorrectly, but Swift does. Canonical link: https://commits.webkit.org/276180@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b22c0a: [JSC] Introduce toInt64 and toUInt64 with a double
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b22c0a8acec04b2e967aba07340fe8074982dbd2 https://github.com/WebKit/WebKit/commit/b22c0a8acec04b2e967aba07340fe8074982dbd2 Author: Yijia Huang Date: 2024-03-15 (Fri, 15 Mar 2024) Changed paths: M Source/JavaScriptCore/runtime/MathCommon.cpp M Source/JavaScriptCore/runtime/MathCommon.h Log Message: --- [JSC] Introduce toInt64 and toUInt64 with a double https://bugs.webkit.org/show_bug.cgi?id=271015 rdar://124643241 Reviewed by Yusuke Suzuki. This patch extends the implementation of toInt32Internal for toInt64 and toUInt64. * Source/JavaScriptCore/runtime/MathCommon.cpp: (JSC::JSC_DEFINE_JIT_OPERATION): * Source/JavaScriptCore/runtime/MathCommon.h: (JSC::toIntImpl): (JSC::toInt32): (JSC::toInt64): (JSC::toUInt64): (JSC::toInt32Internal): Deleted. Canonical link: https://commits.webkit.org/276173@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b16014: Bad cast under CachedResourceLoader::preload()
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b160146fcad134e97707386c01bbee11913822e1 https://github.com/WebKit/WebKit/commit/b160146fcad134e97707386c01bbee11913822e1 Author: Chris Dumez Date: 2024-03-15 (Fri, 15 Mar 2024) Changed paths: M Source/WebCore/loader/cache/CachedResourceLoader.cpp Log Message: --- Bad cast under CachedResourceLoader::preload() https://bugs.webkit.org/show_bug.cgi?id=268405 rdar://121745788 Reviewed by Brent Fulgham. In CachedResourceLoader::preload() we were calling requestResource(type) to get a resource. Then if the type we requested was `FontResource`, we assumed the the CachedResource returned was a CachedFont and would cast to that type. However, this cast ends up being incorrect in some cases. I suspect this could happen when requesting resources with the same URL but different types. To address the issue, we now check the actual type of the returned CachedResource before casting it. * Source/WebCore/loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::preload): Originally-landed-as: 272448.421@safari-7618-branch (25c11453b693). rdar://124554524 Canonical link: https://commits.webkit.org/276162@main Commit: 4ad05d788033d176b41c250c29fd5a524df20851 https://github.com/WebKit/WebKit/commit/4ad05d788033d176b41c250c29fd5a524df20851 Author: Abrar Rahman Protyasha Date: 2024-03-15 (Fri, 15 Mar 2024) Changed paths: M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/mac/WebViewImpl.h M Source/WebKit/UIProcess/mac/WebViewImpl.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm Log Message: --- [macOS] Pointer Lock should disengage when client windows present a sheet https://bugs.webkit.org/show_bug.cgi?id=268198 rdar://121694233 Reviewed by Aditya Keerthi. The Pointer Lock API is susceptible to abuse by nefarious webpages since they can (programmatically or otherwise) make client windows show alerts or permission granting sheets while pointer lock is engaged. Since our current implementation of pointer lock stays engaged even when the client window presents a sheet, it leaves the user in a compromised state where they both don't know the location of the mouse cursor and don't have a way to exit the pointer lock state (since the client window where pointer lock is engaged is no longer focused or the key window). This patch addresses this vulnerability by registering observers for the NSWindowWillBeginSheetNotification notification on the WebView's current window, and then requesting for pointer lock to be disengaged whenever we receive a notification that said window will begin presenting a sheet. Test case added in WebKit.ClientDisplaysAlertSheetWhilePointerLockActive that asserts we successfully exit pointer lock when a client window presents an alert sheet. It also tests that we can successfully re-enter pointer lock afterwards. * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/mac/WebViewImpl.h: * Source/WebKit/UIProcess/mac/WebViewImpl.mm: (-[WKWindowVisibilityObserver startObserving:]): (-[WKWindowVisibilityObserver stopObserving:]): (-[WKWindowVisibilityObserver _windowWillBeginSheet:]): (WebKit::WebViewImpl::windowWillBeginSheet): * Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm: (-[PointerLockDelegate resetState]): (-[PointerLockDelegate waitForPointerLockEngaged]): (-[PointerLockDelegate waitForPointerLockLost]): (-[PointerLockDelegate _webViewDidRequestPointerLock:completionHandler:]): (-[PointerLockDelegate _webViewDidLosePointerLock:]): Originally-landed-as: 272448.388@safari-7618-branch (7047e8e918da). rdar://124554592 Canonical link: https://commits.webkit.org/276163@main Commit: 5f24a7c2d2e021a4074f009be7dc1a4537aa7b84 https://github.com/WebKit/WebKit/commit/5f24a7c2d2e021a4074f009be7dc1a4537aa7b84 Author: Erica Li Date: 2024-03-15 (Fri, 15 Mar 2024) Changed paths: A LayoutTests/media/audio-remove-playback-crash-expected.txt A LayoutTests/media/audio-remove-playback-crash.html M Source/WebCore/dom/Document.cpp Log Message: --- ASAN_ILL | WebCore::Document::removePlaybackTargetPickerClient. rdar://120661908 Reviewed by Chris Dumez. Unable to ref the page from removePlaybackTargetPickerClient as it may have started destruction. * LayoutTests/media/audio-remove-playback-crash-expected.txt: Added. * LayoutTests/media/audio-remove-playback-crash.html: Added. * Source/WebCore/dom/Document.cpp: (WebCore::Document::removePlaybackTargetPickerClient): Originally-landed-as: 272448.387@safari-7618-branch (303478e273bd). rdar://124554687 Canonical link: https://commits.webkit.org/276164@main Commit: a0ed946e698fa554e70676482787431c07ede0c9 https://github.com/WebKit/WebKit/commit/a0ed946e698fa554e70676482787431c07ede0c9 Author: Chris Dumez Date: 2024-03-15 (Fri, 15 Mar 2024) Changed paths: M
[webkit-changes] [WebKit/WebKit] 0cc86c: Use "= default" for constructors and destructors i...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0cc86c22fc251208e801b2eeadaf23c326995557 https://github.com/WebKit/WebKit/commit/0cc86c22fc251208e801b2eeadaf23c326995557 Author: Ahmad Saleem Date: 2024-03-15 (Fri, 15 Mar 2024) Changed paths: M Source/WTF/wtf/AutomaticThread.cpp M Source/WTF/wtf/ConcurrentPtrHashSet.cpp M Source/WTF/wtf/FunctionDispatcher.cpp M Source/WTF/wtf/LockedPrintStream.cpp M Source/WTF/wtf/PrintStream.cpp M Source/WTF/wtf/RefCountedLeakCounter.cpp M Source/WTF/wtf/glib/SocketConnection.cpp M Source/WTF/wtf/persistence/PersistentDecoder.cpp M Source/WTF/wtf/persistence/PersistentEncoder.cpp M Source/WTF/wtf/posix/ThreadingPOSIX.cpp M Source/WTF/wtf/text/StringView.cpp M Source/WTF/wtf/win/ThreadingWin.cpp M Source/WebCore/Modules/audiosession/NavigatorAudioSession.cpp M Source/WebCore/Modules/fetch/FetchResponse.cpp M Source/WebCore/Modules/mediastream/RTCDataChannelRemoteHandler.cpp M Source/WebCore/Modules/mediastream/RTCDataChannelRemoteSource.cpp M Source/WebCore/Modules/mediastream/RTCRtpSFrameTransform.cpp M Source/WebCore/Modules/mediastream/RTCRtpSFrameTransformer.cpp M Source/WebCore/Modules/mediastream/RTCRtpScriptTransformer.cpp M Source/WebCore/Modules/mediastream/VideoTrackGenerator.cpp M Source/WebCore/Modules/notifications/NotificationEvent.cpp M Source/WebCore/Modules/push-api/PushEvent.cpp M Source/WebCore/Modules/remoteplayback/RemotePlayback.cpp M Source/WebCore/Modules/speech/SpeechRecognition.cpp M Source/WebCore/Modules/streams/TransformStream.cpp M Source/WebCore/Modules/webauthn/cbor/CBORWriter.cpp M Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoder.cpp M Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoder.cpp M Source/WebCore/Modules/webcodecs/WebCodecsVideoDecoder.cpp M Source/WebCore/Modules/webcodecs/WebCodecsVideoEncoder.cpp M Source/WebCore/PAL/pal/crypto/openssl/CryptoDigestOpenSSL.cpp M Source/WebCore/Scripts/SettingsTemplates/Settings.cpp.erb M Source/WebCore/animation/AnimationEffect.cpp M Source/WebCore/animation/KeyframeEffectStack.cpp M Source/WebCore/animation/StyleOriginatedAnimation.cpp M Source/WebCore/css/FontFaceSet.cpp M Source/WebCore/html/HTMLPictureElement.cpp M Source/WebCore/html/shadow/DataListButtonElement.cpp Log Message: --- Use "= default" for constructors and destructors in more places https://bugs.webkit.org/show_bug.cgi?id=271031 Reviewed by Michael Catanzaro and Chris Dumez. Similar to other patches, this extends our "= default" usage across constructors and destructors in WebKit code. * Source/WebCore/animation/AnimationEffect.cpp: (AnimationEffect::AnimationEffect): (AnimationEffect::~AnimationEffect): * Source/WebCore/animation/KeyframeEffectStack.cpp: (KeyframeEffectStack::KeyframeEffectStack): (KeyframeEffectStack::~KeyframeEffectStack): * Source/WebCore/animation/StyleOriginatedAnimation.cpp: (StyleOriginatedAnimation::~StyleOriginatedAnimation): * Source/WebCore/css/FontFaceSet.cpp: (FontFaceSet::~FontFaceSet): * Source/WebCore/html/HTMLPictureElement.cpp: (HTMLPictureElement::~HTMLPictureElement): * Source/WebCore/html/shadow/DataListButtonElement.cpp: (DataListButtonElement::~DataListButtonElement): * Source/WebCore/Modules/audiosession/NavigatorAudioSession.cpp: (NavigatorAudioSession::NavigatorAudioSession): (NavigatorAudioSession::~NavigatorAudioSession): * Source/WebCore/Modules/fetch/FetchResponse.cpp: (FetchResponse::Loader::~Loader): * Source/WebCore/Modules/mediastream/RTCDataChannelRemoteHandler.cpp: (RTCDataChannelRemoteHandler::~RTCDataChannelRemoteHandler): * Source/WebCore/Modules/mediastream/RTCDataChannelRemoteSource.cpp: (RTCDataChannelRemoteSource::~RTCDataChannelRemoteSource): * Source/WebCore/Modules/mediastream/RTCRtpScriptTransformer.cpp: (RTCRtpScriptTransformer::~RTCRtpScriptTransformer): * Source/WebCore/Modules/mediastream/RTCRtpSFrameTransform.cpp: (RTCRtpSFrameTransform::~RTCRtpSFrameTransform): * Source/WebCore/Modules/mediastream/RTCRtpSFrameTransformer.cpp: (RTCRtpSFrameTransformer::~RTCRtpSFrameTransformer): * Source/WebCore/Modules/mediastream/VideoTrackGenerator.cpp: (VideoTrackGenerator::~VideoTrackGenerator): * Source/WebCore/Modules/notifications/NotificationEvent.cpp: (NotificationEvent::~NotificationEvent): * Source/WebCore/Modules/push-api/PushEvent.cpp: (PushEvent::~PushEvent): * Source/WebCore/Modules/remoteplayback/RemotePlayback.cpp: (RemotePlayback::~RemotePlayback): * Source/WebCore/Modules/speech/SpeechRecognition.cpp: (SpeechRecognition::~SpeechRecognition): * Source/WebCore/Modules/streams/TransformStream.cpp: ( TransformStream::~TransformStream): * Source/WebCore/Modules/webauthn/cbor/CBORWriter.cpp: (CBORWriter::~CBORWriter): * Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoder.cpp: (WebCodecsAudioDecoder::~WebCodecsAudioDecoder): *
[webkit-changes] [WebKit/WebKit] 6117c4: Unreviewed, reverting 275960@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6117c47a2dbb713a207d6ac1158ca9541706e4df https://github.com/WebKit/WebKit/commit/6117c47a2dbb713a207d6ac1158ca9541706e4df Author: Commit Queue Date: 2024-03-15 (Fri, 15 Mar 2024) Changed paths: M Source/WebKit/UIProcess/ProcessThrottler.cpp M Source/WebKit/UIProcess/ProcessThrottler.h M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxyInternals.h Log Message: --- Unreviewed, reverting 275960@main. https://bugs.webkit.org/show_bug.cgi?id=271057 Regressed PLT on iOS by ~3% Reverted changeset: "Regression: Pages that update their title now get suspended when backgrounded" https://bugs.webkit.org/show_bug.cgi?id=270813 https://commits.webkit.org/275960@main Canonical link: https://commits.webkit.org/276158@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 23d83d: Unreviewed, fix build after 276151@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 23d83dc2840498e8cdd628729eaa0cf5a54bfe36 https://github.com/WebKit/WebKit/commit/23d83dc2840498e8cdd628729eaa0cf5a54bfe36 Author: Matthew Finkel Date: 2024-03-15 (Fri, 15 Mar 2024) Changed paths: M Source/WebCore/PAL/pal/spi/cocoa/WebPrivacySPI.h Log Message: --- Unreviewed, fix build after 276151@main https://bugs.webkit.org/show_bug.cgi?id=271054 Define the new properties for when WebPrivacy.h. * Source/WebCore/PAL/pal/spi/cocoa/WebPrivacySPI.h: Canonical link: https://commits.webkit.org/276153@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 798d17: [JSC] TypedArray sorting methods should have a spe...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 798d1789439ab19b30559051cd834481ec7220ac https://github.com/WebKit/WebKit/commit/798d1789439ab19b30559051cd834481ec7220ac Author: Alexey Shvayka Date: 2024-03-14 (Thu, 14 Mar 2024) Changed paths: A JSTests/stress/sorting-boolean-result-comparator-typedarray.js M Source/JavaScriptCore/runtime/JSGenericTypedArrayViewPrototypeFunctions.h Log Message: --- [JSC] TypedArray sorting methods should have a special-case for comparator returning `false` https://bugs.webkit.org/show_bug.cgi?id=268075 Reviewed by Yusuke Suzuki and Justin Michaud. This change aligns TypedArray sorting methods with Array.prototype.sort() to treat `false`, returned from comparator function, like smallest negative number rather than zero, which is a long-time web reality quirk [1] to allow lexicographical comparison: `["c", "b", "a"].sort((a, b) => a > b)`. The spec [2] still lacks normative steps on how to handle comparator return value in the common case. This patch aligns JSC with V8 and SpiderMonkey. However, it appears that V8 have recently removed the special-case for `false` in Array sorting methods. [1]: https://bugs.webkit.org/show_bug.cgi?id=47825 [2]: https://tc39.es/ecma262/#sec-sortindexedproperties (step 4) * JSTests/stress/sorting-boolean-result-comparator-typedarray.js: Added. * Source/JavaScriptCore/runtime/JSGenericTypedArrayViewPrototypeFunctions.h: (JSC::coerceComparatorResultToBoolean): (JSC::genericTypedArrayViewProtoFuncSortImpl): Canonical link: https://commits.webkit.org/276130@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ac5eb1: [WebRTC] Fix broken target for avif_decode_fuzzer
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ac5eb110be5afb3b9ef5ca60842ca337b55b5a75 https://github.com/WebKit/WebKit/commit/ac5eb110be5afb3b9ef5ca60842ca337b55b5a75 Author: David Kilzer Date: 2024-03-14 (Thu, 14 Mar 2024) Changed paths: M Source/WebCore/PAL/ThirdParty/libavif/libavif.xcodeproj/project.pbxproj M Source/WebCore/PAL/ThirdParty/libavif/tests/oss-fuzz/avif_decode_fuzzer.cc Log Message: --- [WebRTC] Fix broken target for avif_decode_fuzzer https://bugs.webkit.org/show_bug.cgi?id=270936 Reviewed by Said Abou-Hallawa. * Source/WebCore/PAL/ThirdParty/libavif/libavif.xcodeproj/project.pbxproj: - Clean up the project by removing many duplicate folders. - Remove the android_jni folder since it was deleted in 275928@main. (avif_decode_fuzzer target): - Fix avif_decode_fuzzer by removing repro_fuzz.cc from the Sources list. This fixes the issue described by the bug. * Source/WebCore/PAL/ThirdParty/libavif/tests/oss-fuzz/avif_decode_fuzzer.cc: (LLVMFuzzerTestOneInput): - Add back declaration that was originally added in 272156@main, but removed in 275291@main. This fixes a -Wmissing-prototypes compiler warning. Canonical link: https://commits.webkit.org/276113@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 55c18e: Removing CLANG_MODULE setting.
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 55c18ec706cda282dcf3b1c87e84db57cdfd5ac2
https://github.com/WebKit/WebKit/commit/55c18ec706cda282dcf3b1c87e84db57cdfd5ac2
Author: nmahendru
Date: 2024-03-14 (Thu, 14 Mar 2024)
Changed paths:
M Source/WebCore/PAL/Configurations/PAL.xcconfig
Log Message:
---
Removing CLANG_MODULE setting.
rdar://124559419
Reviewed by Elliot Williams.
Looks like it's not really needed for Swift interop.
Newer versions of clang are causing the build to fail otherwise.
Error:
In file included from
/Volumes/Data/safari-4/OpenSource/Source/WebCore/PAL/pal/text/TextCodecLatin1.cpp:31:
/Volumes/Data/safari-4/OpenSource/WebKitBuild/Debug/usr/local/include/wtf/text/CString.h:77:17:
error: definition of 'basic_string' must be imported from module 'std_string'
before it is required
77 | std::string toStdString() const { return m_buffer ?
std::string(m_buffer->data()) : std::string(); }
|
* Source/WebCore/PAL/Configurations/PAL.xcconfig:
Canonical link: https://commits.webkit.org/276112@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8b2e50: ASAN_ILL | WebCore::RenderTableSection::layoutRows...
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8b2e50918a1c6a0c064267a241b81c5b6f01115e
https://github.com/WebKit/WebKit/commit/8b2e50918a1c6a0c064267a241b81c5b6f01115e
Author: Erica Li
Date: 2024-03-14 (Thu, 14 Mar 2024)
Changed paths:
A
LayoutTests/fast/multicol/pagination/pagination-diry-sections-crash-expected.txt
A LayoutTests/fast/multicol/pagination/pagination-diry-sections-crash.html
M Source/WebCore/rendering/RenderTable.cpp
Log Message:
---
ASAN_ILL | WebCore::RenderTableSection::layoutRows;
WebCore::RenderTable::simplifiedNormalFlowLayout;
WebCore::RenderBlock::simplifiedLayout.
https://bugs.webkit.org/show_bug.cgi?id=267198
rdar://113940614
Reviewed by Alan Baradlay.
Always setChildNeedsLayout for sections to make sure normalChildNeedsLayout is
flagged,
as for pagination we need to run a full layout on child table sections even
when the initial change,
otherwise requires simplified layout only.
*
LayoutTests/fast/multicol/pagination/pagination-diry-sections-crash-expected.txt:
Added.
* LayoutTests/fast/multicol/pagination/pagination-diry-sections-crash.html:
Added.
*
LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-002-expected.txt:
re-baseline again, adding end of line back.
* Source/WebCore/rendering/RenderTable.cpp:
(WebCore::RenderTable::markForPaginationRelayoutIfNeeded):
Originally-landed-as: 272448.104@safari-7618-branch (8737c0374652).
rdar://124556239
Canonical link: https://commits.webkit.org/276103@main
Commit: ceb7e89febcd92b46d65396ce68e0d58ae6bcd6e
https://github.com/WebKit/WebKit/commit/ceb7e89febcd92b46d65396ce68e0d58ae6bcd6e
Author: Alexey Shvayka
Date: 2024-03-14 (Thu, 14 Mar 2024)
Changed paths:
A JSTests/stress/regress-120777816.js
M Source/JavaScriptCore/builtins/ProxyHelpers.js
M Source/JavaScriptCore/bytecode/BytecodeIntrinsicRegistry.h
M Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp
M Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h
M Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp
M Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp
M Source/JavaScriptCore/runtime/ProxyObject.cpp
Log Message:
---
[JSC] get_by_id_with_this + ProxyObject can leak JSScope objects
https://bugs.webkit.org/show_bug.cgi?id=267425
Reviewed by Yusuke Suzuki and Justin Michaud.
According to the spec [1], `var base = { foo }; with (base) foo();` should be
called with `this`
value of `base`, which is why FunctionCallResolveNode moves resolved scope to
thisRegister().
That is arguably a bad design, and there is an effort [2] to abolish using
JSScope as `this` value.
When `this` value is accessed by JS code, it's being sanitized via ToThis
(JSScope replaced with
`undefined`), yet not in case of `super.property` access calling into
ProxyObject `get` trap,
which passes raw `this` value as receiver parameter, leaking JSScope to be
exploited.
For performance reasons, we can't call toThis() whenever `get_by_id_with_this`
is used, so this
change introduces @toThis() intrinsic specifically for ProxyObject IC helpers,
tweaks DFG to respect
`m_srcDst`, and also fixes baseline code.
Inlineability of ProxyObject IC helpers was verified to remain unaffected
(`performProxyObjectGet`
is smaller then 120 while other helpers were already exceeding inline size
limit).
[1]: https://tc39.es/ecma262/#sec-evaluatecall (step 1.b.iii)
[2]: https://bugs.webkit.org/show_bug.cgi?id=225397
* JSTests/stress/regress-120777816.js: Added.
* Source/JavaScriptCore/builtins/ProxyHelpers.js:
(linkTimeConstant.performProxyObjectGet):
(linkTimeConstant.performProxyObjectGetByVal):
(linkTimeConstant.performProxyObjectSetSloppy):
(linkTimeConstant.performProxyObjectSetStrict):
* Source/JavaScriptCore/bytecode/BytecodeIntrinsicRegistry.h:
* Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitToThis):
* Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::emitToThis):
* Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:
(JSC::BytecodeIntrinsicNode::emit_intrinsic_toThis):
* Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::getThis): Deleted.
(JSC::DFG::ByteCodeParser::setThis): Deleted.
* Source/JavaScriptCore/runtime/ProxyObject.cpp:
(JSC::performProxyGet):
(JSC::ProxyObject::performPut):
Originally-landed-as: 272448.103@safari-7618-branch (e3a75800fe85).
rdar://124556295
Canonical link: https://commits.webkit.org/276104@main
Commit: ffe58e2be703e4f6b69eb8c315b1c186676bb4b5
https://github.com/WebKit/WebKit/commit/ffe58e2be703e4f6b69eb8c315b1c186676bb4b5
Author: Alan Baradlay
Date: 2024-03-14 (Thu, 14 Mar 2024)
Changed paths:
A
LayoutTests/fast/inline/dynamic-inline-content-with-out-of-flow-child-expected.txt
A
[webkit-changes] [WebKit/WebKit] 9854e2: Unreviewed, reverting 276090@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9854e2932ee221bed4a8260dbc9ec7b0d87189ed https://github.com/WebKit/WebKit/commit/9854e2932ee221bed4a8260dbc9ec7b0d87189ed Author: Commit Queue Date: 2024-03-14 (Thu, 14 Mar 2024) Changed paths: M Source/JavaScriptCore/jsc.cpp M Source/JavaScriptCore/runtime/InitializeThreading.cpp M Source/JavaScriptCore/runtime/MachineContext.h M Source/JavaScriptCore/runtime/VMTraps.cpp M Source/JavaScriptCore/wasm/WasmFaultSignalHandler.cpp M Source/JavaScriptCore/wasm/WasmFaultSignalHandler.h M Source/WTF/WTF.xcodeproj/project.pbxproj M Source/WTF/wtf/PlatformJSCOnly.cmake M Source/WTF/wtf/PlatformMac.cmake M Source/WTF/wtf/PlatformRegisters.cpp M Source/WTF/wtf/PlatformRegisters.h M Source/WTF/wtf/threads/Signals.cpp M Source/WTF/wtf/threads/Signals.h M Source/WTF/wtf/win/SignalsWin.cpp M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in M Source/WebKit/WebProcess/com.apple.WebProcess.sb.in M Tools/TestWebKitAPI/Tests/WTF/Signals.cpp Log Message: --- Unreviewed, reverting 276090@main. https://bugs.webkit.org/show_bug.cgi?id=270983 Broke internal builds Reverted changeset: "new exception handler adoption" https://bugs.webkit.org/show_bug.cgi?id=269728 https://commits.webkit.org/276090@main Canonical link: https://commits.webkit.org/276102@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a355db: Use "= default" for few more destructor in Media a...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a355dba7e447883831de3485042dba8c3eddd931 https://github.com/WebKit/WebKit/commit/a355dba7e447883831de3485042dba8c3eddd931 Author: Ahmad Saleem Date: 2024-03-14 (Thu, 14 Mar 2024) Changed paths: M Source/WebCore/html/MediaDocument.cpp M Source/WebCore/html/track/TextTrackList.cpp M Source/WebCore/html/track/TrackListBase.cpp Log Message: --- Use "= default" for few more destructor in Media and Track https://bugs.webkit.org/show_bug.cgi?id=270953 Reviewed by Chris Dumez. Similar to other places, use `=default` for our destructor in `MediaDocument.cpp`, `TextTrackList.cpp` and `TrackListBase.cpp`. * Source/WebCore/html/MediaDocument.cpp: (MediaDocument::~MediaDocument): * Source/WebCore/html/track/TextTrackList.cpp: (TextTrackList::~TextTrackList): * Source/WebCore/html/track/TrackListBase.cpp: (TrackListBase::~TrackListBase): Canonical link: https://commits.webkit.org/276096@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 079bd3: new exception handler adoption
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 079bd31e378144ae39bc940d07cfb8da5814f527 https://github.com/WebKit/WebKit/commit/079bd31e378144ae39bc940d07cfb8da5814f527 Author: Brandon Kayes Date: 2024-03-14 (Thu, 14 Mar 2024) Changed paths: M Source/JavaScriptCore/jsc.cpp M Source/JavaScriptCore/runtime/InitializeThreading.cpp M Source/JavaScriptCore/runtime/MachineContext.h M Source/JavaScriptCore/runtime/VMTraps.cpp M Source/JavaScriptCore/wasm/WasmFaultSignalHandler.cpp M Source/JavaScriptCore/wasm/WasmFaultSignalHandler.h M Source/WTF/WTF.xcodeproj/project.pbxproj M Source/WTF/wtf/PlatformJSCOnly.cmake M Source/WTF/wtf/PlatformMac.cmake M Source/WTF/wtf/PlatformRegisters.cpp M Source/WTF/wtf/PlatformRegisters.h M Source/WTF/wtf/threads/Signals.cpp M Source/WTF/wtf/threads/Signals.h M Source/WTF/wtf/win/SignalsWin.cpp M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in M Source/WebKit/WebProcess/com.apple.WebProcess.sb.in M Tools/TestWebKitAPI/Tests/WTF/Signals.cpp Log Message: --- new exception handler adoption https://bugs.webkit.org/show_bug.cgi?id=269728 rdar://119256062 Reviewed by Keith Miller. This adopts the new hardened mach exception mechanism which was introduced in darwin recently. See the radar for more details. * Source/JavaScriptCore/llint/LLIntData.cpp: * Source/JavaScriptCore/llint/LLIntData.h: * Source/JavaScriptCore/runtime/MachineContext.h: (JSC::MachineContext::setInstructionPointer): * Source/JavaScriptCore/wasm/WasmFaultSignalHandler.cpp: (JSC::Wasm::trapHandler): * Source/WTF/WTF.xcodeproj/project.pbxproj: * Source/WTF/wtf/PlatformHave.h: * Source/WTF/wtf/PlatformJSCOnly.cmake: * Source/WTF/wtf/PlatformMac.cmake: * Source/WTF/wtf/PlatformRegisters.h: * Source/WTF/wtf/threads/Signals.cpp: (WTF::initMachExceptionHandlerThread): (WTF::setExceptionPorts): * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: * Source/WebKit/WebProcess/com.apple.WebProcess.sb.in: Canonical link: https://commits.webkit.org/276090@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 51ae1a: Adding wrap/unwrapCryptoKey to ServiceWorker
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 51ae1a6d501e745cb0af429b3323372ce9aaae62 https://github.com/WebKit/WebKit/commit/51ae1a6d501e745cb0af429b3323372ce9aaae62 Author: nmahendru Date: 2024-03-14 (Thu, 14 Mar 2024) Changed paths: A LayoutTests/http/tests/workers/service/indexeddb-cryptokey-put-get.https-expected.txt A LayoutTests/http/tests/workers/service/indexeddb-cryptokey-put-get.https.html A LayoutTests/http/tests/workers/service/resources/indexeddb-cryptokey-put-get-worker.js A LayoutTests/http/tests/workers/service/resources/indexeddb-cryptokey-put-get.js M Source/WebCore/Headers.cmake M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/bindings/js/SerializedScriptValue.cpp M Source/WebCore/crypto/cocoa/SerializedCryptoKeyWrapMac.mm M Source/WebCore/dom/Document.cpp M Source/WebCore/dom/Document.h M Source/WebCore/dom/EmptyScriptExecutionContext.h M Source/WebCore/dom/ScriptExecutionContext.h M Source/WebCore/loader/EmptyClients.cpp M Source/WebCore/loader/EmptyClients.h M Source/WebCore/page/ChromeClient.h A Source/WebCore/page/CryptoClient.h M Source/WebCore/page/Page.cpp M Source/WebCore/page/Page.h M Source/WebCore/page/PageConfiguration.cpp M Source/WebCore/page/PageConfiguration.h M Source/WebCore/workers/WorkerGlobalScope.cpp M Source/WebCore/workers/WorkerGlobalScope.h M Source/WebCore/worklets/WorkletGlobalScope.h M Source/WebKit/Sources.txt M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm M Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreDelegate.h M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebPageProxy.messages.in M Source/WebKit/UIProcess/WebProcessProxy.cpp M Source/WebKit/UIProcess/WebProcessProxy.h M Source/WebKit/UIProcess/WebProcessProxy.messages.in M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreClient.h M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h A Source/WebKit/WebProcess/WebCoreSupport/WebCryptoClient.cpp A Source/WebKit/WebProcess/WebCoreSupport/WebCryptoClient.h M Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/cocoa/RemoteRealtimeVideoSource.cpp A Source/WebKitLegacy/WebCoreSupport/WebCryptoClient.h A Source/WebKitLegacy/WebCoreSupport/WebCryptoClient.mm M Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj M Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h M Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm M Source/WebKitLegacy/mac/WebView/WebView.mm M Tools/WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.h M Tools/WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm Log Message: --- Adding wrap/unwrapCryptoKey to ServiceWorker https://bugs.webkit.org/show_bug.cgi?id=183167 rdar://88339459 Reviewed by Sihui Liu. At the moment the ServiceWorker flow does not have the wrap and unwrap functionality so any attempt to write a CryptoKey from ServiceWorker to indexDB is failing. This introduces the bridge from SW all the way to UIProcess so that it can call the key wrapping APIs and serialize keys for IndexedDB. * LayoutTests/http/tests/workers/service/indexeddb-cryptokey-put-get.https-expected.txt: Added. * LayoutTests/http/tests/workers/service/indexeddb-cryptokey-put-get.https.html: Added. * LayoutTests/http/tests/workers/service/resources/indexeddb-cryptokey-put-get-worker.js: Added. (async createKeys): (async addValue): (async getValue.): (async getValue): (async testFetchedKeys): (async runTest): (async cleanupDatabase.): (async cleanupDatabase): (async self): * LayoutTests/http/tests/workers/service/resources/indexeddb-cryptokey-put-get.js: Added. (async test): * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/bindings/js/SerializedScriptValue.cpp: (WebCore::wrapCryptoKey): (WebCore::unwrapCryptoKey): (WebCore::CloneSerializer::dumpIfTerminal): (WebCore::CloneDeserializer::readTerminal): * Source/WebCore/crypto/cocoa/SerializedCryptoKeyWrapMac.mm: (WebCore::wrapSerializedCryptoKey): (WebCore::unwrapSerializedCryptoKey): * Source/WebCore/dom/Document.cpp: (WebCore::Document::wrapCryptoKey): (WebCore::std::optional>Document::unwrapCryptoKey): (WebCore::Document::unwrapCryptoKey): Deleted. * Source/WebCore/dom/Document.h: * Source/WebCore/dom/EmptyScriptExecutionContext.h: * Source/WebCore/dom/ScriptExecutionContext.h: * Source/WebCore/loader/EmptyClients.cpp: (WebCore::pageConfigurationWithEmptyClients): * Source/WebCore/loader/EmptyClients.h: *
[webkit-changes] [WebKit/WebKit] 71f803: [JSC] Add aligned label annotation to offlineasm
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 71f803e6ee62ac5bcf8449a8e9cb1d4fd601f74a https://github.com/WebKit/WebKit/commit/71f803e6ee62ac5bcf8449a8e9cb1d4fd601f74a Author: Max Rottenkolber Date: 2024-03-14 (Thu, 14 Mar 2024) Changed paths: M Source/JavaScriptCore/llint/InPlaceInterpreter.asm M Source/JavaScriptCore/llint/LowLevelInterpreter.cpp M Source/JavaScriptCore/offlineasm/asm.rb M Source/JavaScriptCore/offlineasm/ast.rb M Source/JavaScriptCore/offlineasm/backends.rb M Source/JavaScriptCore/offlineasm/parser.rb M Source/JavaScriptCore/offlineasm/transform.rb Log Message: --- [JSC] Add aligned label annotation to offlineasm https://bugs.webkit.org/show_bug.cgi?id=270699 Reviewed by Yusuke Suzuki and Justin Michaud. To express some programs like the InPlaceInterpreter we need to align instructions to specific boundaries (such as 256). We currently to do this via `emit ".balign 256, 0xcc"' (for instance) but this is not reliable on armv7 as its globaladdr implementation can insert code unpredictably (from the point of view of the offlineasm user), hence breaking the alignment. This adds an aligned label annotation which implements this functionality in offlineasm. * Source/JavaScriptCore/llint/InPlaceInterpreter.asm: * Source/JavaScriptCore/llint/LowLevelInterpreter.cpp: * Source/JavaScriptCore/offlineasm/asm.rb: * Source/JavaScriptCore/offlineasm/ast.rb: * Source/JavaScriptCore/offlineasm/backends.rb: * Source/JavaScriptCore/offlineasm/parser.rb: * Source/JavaScriptCore/offlineasm/transform.rb: Canonical link: https://commits.webkit.org/276085@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ed9f21: [JSC] Validate that HasStaticPropertyTable is pres...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ed9f215ec22744e680c5a1f6f382f2b7afca56ad https://github.com/WebKit/WebKit/commit/ed9f215ec22744e680c5a1f6f382f2b7afca56ad Author: Alexey Shvayka Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M Source/JavaScriptCore/runtime/ArrayIteratorPrototype.h M Source/JavaScriptCore/runtime/AsyncGeneratorFunctionPrototype.h M Source/JavaScriptCore/runtime/IntlLocaleConstructor.h M Source/JavaScriptCore/runtime/JSModuleLoader.h M Source/JavaScriptCore/runtime/MapConstructor.cpp M Source/JavaScriptCore/runtime/MapPrototype.h M Source/JavaScriptCore/runtime/RegExpStringIteratorPrototype.h M Source/JavaScriptCore/runtime/SetPrototype.h M Source/JavaScriptCore/runtime/StringIteratorPrototype.h M Source/JavaScriptCore/runtime/Structure.cpp M Source/JavaScriptCore/tools/JSDollarVM.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyArrayConstructor.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyArrayConstructor.h M Source/JavaScriptCore/wasm/js/WebAssemblyArrayPrototype.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyArrayPrototype.h M Source/JavaScriptCore/wasm/js/WebAssemblyCompileErrorConstructor.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyCompileErrorConstructor.h M Source/JavaScriptCore/wasm/js/WebAssemblyCompileErrorPrototype.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyCompileErrorPrototype.h M Source/JavaScriptCore/wasm/js/WebAssemblyExceptionConstructor.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyExceptionConstructor.h M Source/JavaScriptCore/wasm/js/WebAssemblyGlobalConstructor.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyGlobalConstructor.h M Source/JavaScriptCore/wasm/js/WebAssemblyInstanceConstructor.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyInstanceConstructor.h M Source/JavaScriptCore/wasm/js/WebAssemblyInstancePrototype.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyInstancePrototype.h M Source/JavaScriptCore/wasm/js/WebAssemblyLinkErrorConstructor.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyLinkErrorConstructor.h M Source/JavaScriptCore/wasm/js/WebAssemblyLinkErrorPrototype.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyLinkErrorPrototype.h M Source/JavaScriptCore/wasm/js/WebAssemblyMemoryConstructor.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyMemoryConstructor.h M Source/JavaScriptCore/wasm/js/WebAssemblyModulePrototype.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyModulePrototype.h M Source/JavaScriptCore/wasm/js/WebAssemblyRuntimeErrorConstructor.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyRuntimeErrorConstructor.h M Source/JavaScriptCore/wasm/js/WebAssemblyRuntimeErrorPrototype.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyRuntimeErrorPrototype.h M Source/JavaScriptCore/wasm/js/WebAssemblyStructConstructor.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyStructConstructor.h M Source/JavaScriptCore/wasm/js/WebAssemblyStructPrototype.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyStructPrototype.h M Source/JavaScriptCore/wasm/js/WebAssemblyTableConstructor.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyTableConstructor.h M Source/WebCore/bindings/scripts/CodeGeneratorJS.pm M Source/WebCore/bindings/scripts/test/JS/JSDedicatedWorkerGlobalScope.h M Source/WebCore/bindings/scripts/test/JS/JSLocalDOMWindow.h M Source/WebCore/bindings/scripts/test/JS/JSPaintWorkletGlobalScope.h M Source/WebCore/bindings/scripts/test/JS/JSServiceWorkerGlobalScope.h M Source/WebCore/bindings/scripts/test/JS/JSSharedWorkerGlobalScope.h M Source/WebCore/bindings/scripts/test/JS/JSWorkerGlobalScope.h M Source/WebCore/bindings/scripts/test/JS/JSWorkletGlobalScope.h Log Message: --- [JSC] Validate that HasStaticPropertyTable is present only if there is a static property table https://bugs.webkit.org/show_bug.cgi?id=270889 Reviewed by Yusuke Suzuki. This change: 1) Removes empty static property tables. 2) Removes HasStaticPropertyTable structure flag from classes without static property tables. 3) Fixes bindings generator condition for setting HasStaticPropertyTable to match the condition for setting `staticPropHashTable`, which isn't observable because we eagerly reify all static properties. 4) Adds an assertion to validate that HasStaticPropertyTable is present only if there is an own or inherited static property table. 1) and 2) are performance micro-optimizations that avoid calling into getOwnStaticPropertySlot() for property lookup if there is no static property table, own nor inherited, while 4) ensures consistency across the JSC codebase. * Source/JavaScriptCore/runtime/ArrayIteratorPrototype.h: * Source/JavaScriptCore/runtime/AsyncGeneratorFunctionPrototype.h: * Source/JavaScriptCore/runtime/IntlLocaleConstructor.h: *
[webkit-changes] [WebKit/WebKit] 027a60: RefinedForGithub extension cannot be enabled: Inva...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 027a604092f7e3765e9f22f44e71cbd8c506bf90 https://github.com/WebKit/WebKit/commit/027a604092f7e3765e9f22f44e71cbd8c506bf90 Author: Elijah Sawyers Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIActionCocoa.mm M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPICommandsCocoa.mm M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIMenusCocoa.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIAction.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPICommands.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIMenus.mm Log Message: --- RefinedForGithub extension cannot be enabled: Invalid call to permissions.request() https://bugs.webkit.org/show_bug.cgi?id=270918 rdar://123775789 Reviewed by Timothy Hatcher. When requesting permissions (permissions.request()), there is a check to make sure that the method was called when processing a user gesture. As it stands, the check doesn't handle events for actions, context menus, and commands. This patch makes it such that WebCore::UserGestureIndicator::processingUserGesture() returns true when handling those events. * Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIActionCocoa.mm: (WebKit::WebExtensionContextProxy::dispatchActionClickedEvent): * Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPICommandsCocoa.mm: (WebKit::WebExtensionContextProxy::dispatchCommandsCommandEvent): * Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIMenusCocoa.mm: (WebKit::WebExtensionContextProxy::dispatchMenusClickedEvent): Canonical link: https://commits.webkit.org/276065@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 333abc: Remove FIXME about `resetClip` in CanvasDrawPath.idl
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 333abc3ffa529b870b611f130f3745834f3821eb https://github.com/WebKit/WebKit/commit/333abc3ffa529b870b611f130f3745834f3821eb Author: Ahmad Saleem Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M Source/WebCore/html/canvas/CanvasDrawPath.idl Log Message: --- Remove FIXME about `resetClip` in CanvasDrawPath.idl https://bugs.webkit.org/show_bug.cgi?id=270890 Reviewed by Simon Fraser. There is no web specification about `resetClip`, so no reason to keep this FIXME. > https://html.spec.whatwg.org/multipage/canvas.html#canvasdrawpath It was trialed in past for implementation in bug 82801, which was concluded with similar conclusion as below W3C thread: > https://lists.w3.org/Archives/Public/public-whatwg-archive/2013Oct/0057.html "The reason resetClip() is a bad API is that it breaks the ability..." * Source/WebCore/html/canvas/CanvasDrawPath.idl: Canonical link: https://commits.webkit.org/276022@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 930a87: Mark request as same-site when we have a matching ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 930a87998c722414706d546c1f9dfc123fc62daa https://github.com/WebKit/WebKit/commit/930a87998c722414706d546c1f9dfc123fc62daa Author: Matthew Finkel Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/loader/FrameLoader.h M Source/WebCore/page/Page.h M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm Log Message: --- Mark request as same-site when we have a matching CORS-disabling pattern https://bugs.webkit.org/show_bug.cgi?id=270830 rdar://123848604 Reviewed by Alex Christensen. Some requests can be considered as same-site, even if they aren't according to the spec, just like we disble CORS for some requests that are cross-origin. We can leverage the existing CORS-Disabling patterns to decide when a request should be considered same-site. Covered by a new API test. * Source/WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::setOriginalURLForDownloadRequest): (WebCore::FrameLoader::updateRequestAndAddExtraFields): (WebCore::FrameLoader::addSameSiteInfoToRequestIfNeeded): * Source/WebCore/loader/FrameLoader.h: * Source/WebCore/page/Page.h: (WebCore::Page::shouldAssumeSameSiteForRequestTo const): * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm: (TEST): Canonical link: https://commits.webkit.org/276015@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3e73d2: [WebAuthn] Populate excludeCredentials in modern A...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3e73d2ab80517c18e34b74ea0c985739698f3baa https://github.com/WebKit/WebKit/commit/3e73d2ab80517c18e34b74ea0c985739698f3baa Author: Pascoe Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm Log Message: --- [WebAuthn] Populate excludeCredentials in modern AS flow https://bugs.webkit.org/show_bug.cgi?id=270856 rdar://124405037 Reviewed by Chris Dumez. This patch starts passing along the excluded credentials from the request along the modern AS flow. * Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm: (WebKit::WebAuthenticatorCoordinatorProxy::requestsForRegisteration): Canonical link: https://commits.webkit.org/276006@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 18d9a4: AX: VoiceOver doesn't read characters when user pr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 18d9a43b9d86cc2a3e8fa52d54b470294a73b607 https://github.com/WebKit/WebKit/commit/18d9a43b9d86cc2a3e8fa52d54b470294a73b607 Author: Dominic Mazzoni Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: A LayoutTests/accessibility/mac/custom-text-editor-expected.txt A LayoutTests/accessibility/mac/custom-text-editor.html M Source/WebCore/accessibility/AXObjectCache.h M Source/WebCore/accessibility/mac/AXObjectCacheMac.mm Log Message: --- AX: VoiceOver doesn't read characters when user presses left / right arrows in Monaco code editor https://bugs.webkit.org/show_bug.cgi?id=270616 rdar://123984168 Reviewed by Andres Gonzalez. When the character or selection extent moves by just one visible position, infer that it was a character granularity move, rather than a discontiguous selection. * LayoutTests/accessibility/mac/custom-text-editor-expected.txt: Added. * LayoutTests/accessibility/mac/custom-text-editor.html: Added. * Source/WebCore/accessibility/AXObjectCache.h: * Source/WebCore/accessibility/mac/AXObjectCacheMac.mm: (WebCore::AXObjectCache::inferDirectionFromIntent): (WebCore::AXObjectCache::postTextStateChangePlatformNotification): Canonical link: https://commits.webkit.org/275998@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e880d7: chrome.action is undefined if the action key in th...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e880d73dbb4dc6c60f4b36486962a3ffba9e5c42 https://github.com/WebKit/WebKit/commit/e880d73dbb4dc6c60f4b36486962a3ffba9e5c42 Author: Elijah Sawyers Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPINamespaceCocoa.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtension.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIAction.mm Log Message: --- chrome.action is undefined if the action key in the manifest is missing or empty https://bugs.webkit.org/show_bug.cgi?id=270814 rdar://122330191 Reviewed by Timothy Hatcher. All keys in the dictionary in the manifest for action, browser_action, and page_action should be optional. This patch makes the necessary changes for that to be true. * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm: (WebKit::WebExtension::hasAction): (WebKit::WebExtension::hasBrowserAction): (WebKit::WebExtension::hasPageAction): (WebKit::WebExtension::populateActionPropertiesIfNeeded): * Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPINamespaceCocoa.mm: (WebKit::WebExtensionAPINamespace::isPropertyAllowed): Canonical link: https://commits.webkit.org/275991@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7f0b9a: Non-unified build fix after 275657@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7f0b9a8d21af3216db1c78f86f2e4f897fc9b2a5 https://github.com/WebKit/WebKit/commit/7f0b9a8d21af3216db1c78f86f2e4f897fc9b2a5 Author: Pascoe Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M Source/WebKit/UIProcess/WebAuthentication/fido/U2fAuthenticator.cpp Log Message: --- Non-unified build fix after 275657@main https://bugs.webkit.org/show_bug.cgi?id=270863 rdar://124464930 Unreviewed, build fix. This import is needed, but isn't on ToT unified builds. Adding it to fix the build for non-unified. * Source/WebKit/UIProcess/WebAuthentication/fido/U2fAuthenticator.cpp: Canonical link: https://commits.webkit.org/275985@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a88637: Unreviewed, reverting 275922@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a886378aa293617be992a0cb04320ef7c71c4367 https://github.com/WebKit/WebKit/commit/a886378aa293617be992a0cb04320ef7c71c4367 Author: Commit Queue Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/css/CSSStyleRule.idl M Source/WebCore/css/parser/CSSParserContext.cpp M Source/WebCore/css/parser/CSSParserContext.h M Source/WebCore/css/parser/CSSParserImpl.h M Source/WebCore/css/parser/CSSSelectorParser.cpp M Source/WebCore/css/parser/CSSSelectorParserContext.cpp M Source/WebCore/css/parser/CSSSelectorParserContext.h Log Message: --- Unreviewed, reverting 275922@main. https://bugs.webkit.org/show_bug.cgi?id=270855 Caused crashes on fast/css/cssom-mutation-stylerule.html Reverted changeset: "[css-nesting] Remove feature flag" https://bugs.webkit.org/show_bug.cgi?id=270793 https://commits.webkit.org/275922@main Canonical link: https://commits.webkit.org/275979@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e39892: Fix edge cases of keyboard navigations around `anc...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e39892e12f8d3c3a544327c87c9904401e15ef9f https://github.com/WebKit/WebKit/commit/e39892e12f8d3c3a544327c87c9904401e15ef9f Author: Ahmad Saleem Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M LayoutTests/fast/events/anchor-empty-focus-expected.txt M LayoutTests/fast/events/anchor-empty-focus.html M LayoutTests/fast/events/frame-tab-focus-expected.txt M LayoutTests/fast/events/frame-tab-focus.html M LayoutTests/fast/events/tab-focus-anchor-expected.txt A LayoutTests/fast/events/tab-focus-anchor-tab-to-links-expected.txt A LayoutTests/fast/events/tab-focus-anchor-tab-to-links.html M LayoutTests/fast/events/tab-focus-anchor.html A LayoutTests/fast/forms/focus-on-control-with-zero-size-expected.txt A LayoutTests/fast/forms/focus-on-control-with-zero-size.html M LayoutTests/platform/ios/TestExpectations M Source/WebCore/html/HTMLAnchorElement.cpp Log Message: --- Fix edge cases of keyboard navigations around `anchor` elements with `TabsToLink` https://bugs.webkit.org/show_bug.cgi?id=270713 Reviewed by Ryosuke Niwa. This patch is to fix edge cases in keyboard focus navigation around `anchor` elements: Partial Merge: https://chromium.googlesource.com/chromium/blink/+/53f8eba14b6362795bae47c02236ca93303264a6 By merging above, WebKit is trying to fix case around `empty anchor` while `TabsToLinks` enabled. The test case was failing currently in WebKit, so this fixes it. Merge: https://chromium.googlesource.com/chromium/blink/+/7ef69ef071ba2b49ece747b93518b9a1218f9c45 In this merge, WebKit is aligning to allow keyboard navigation to anchors with `TabsToLinks` being disabled if the anchors have explicit tabindex. Beside following, this patch still retains `early return` if it is not focusable. > Changes: * Source/WebCore/html/HTMLAnchorElement.cpp: (HTMLAnchorElement::isKeyboardFocusable): > Test Cases & Expectations: * LayoutTests/fast/events/anchor-empty-focus-expected.txt: * LayoutTests/fast/events/anchor-empty-focus.html: * LayoutTests/fast/events/frame-tab-focus-expected.txt: * LayoutTests/fast/events/frame-tab-focus.html: * LayoutTests/fast/events/tab-focus-anchor-expected.txt: * LayoutTests/fast/events/tab-focus-anchor-tab-to-links-expected.txt: * LayoutTests/fast/events/tab-focus-anchor-tab-to-links.html: * LayoutTests/fast/events/tab-focus-anchor.html: * LayoutTests/fast/forms/focus-on-control-with-zero-size.html: * LayoutTests/fast/forms/focus-on-control-with-zero-size-expected.txt: > Platform Specific Test Expectation: * LayoutTests/platform/ios/TestExpectations: `iOS` don't have 'EventSender` keydown support Canonical link: https://commits.webkit.org/275976@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6ee397: Unreviewed, reverting 275944@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6ee397c69b8869da40b9bb745af166896c39bd6f https://github.com/WebKit/WebKit/commit/6ee397c69b8869da40b9bb745af166896c39bd6f Author: Commit Queue Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M JSTests/test262/expectations.yaml M Source/JavaScriptCore/bytecode/BytecodeList.rb M Source/JavaScriptCore/bytecode/BytecodeUseDef.cpp M Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp M Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h M Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp M Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h M Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp M Source/JavaScriptCore/dfg/DFGClobberize.h M Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp M Source/JavaScriptCore/dfg/DFGDoesGC.cpp M Source/JavaScriptCore/dfg/DFGFixupPhase.cpp M Source/JavaScriptCore/dfg/DFGNode.h M Source/JavaScriptCore/dfg/DFGNodeType.h M Source/JavaScriptCore/dfg/DFGOperations.cpp M Source/JavaScriptCore/dfg/DFGOperations.h M Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp M Source/JavaScriptCore/dfg/DFGSafeToExecute.h M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h M Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp M Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp M Source/JavaScriptCore/ftl/FTLCapabilities.cpp M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp M Source/JavaScriptCore/jit/JIT.cpp M Source/JavaScriptCore/jit/JIT.h M Source/JavaScriptCore/jit/JITOpcodes.cpp M Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm M Source/JavaScriptCore/llint/LowLevelInterpreter64.asm M Source/JavaScriptCore/runtime/CommonSlowPaths.cpp M Source/JavaScriptCore/runtime/CommonSlowPaths.h Log Message: --- Unreviewed, reverting 275944@main. https://bugs.webkit.org/show_bug.cgi?id=270838 8% JetStream2 regression Reverted changeset: "[JSC] Bracket compound assignment should resolve property key at most once" https://bugs.webkit.org/show_bug.cgi?id=270563 https://commits.webkit.org/275944@main Canonical link: https://commits.webkit.org/275962@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cedd7c: WebExtensionContext::loadDeclarativeNetRequestRule...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cedd7cbe98033ae4d91031274c620ba1e09b51c7 https://github.com/WebKit/WebKit/commit/cedd7cbe98033ae4d91031274c620ba1e09b51c7 Author: Rob Hudson Date: 2024-03-11 (Mon, 11 Mar 2024) Changed paths: M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm Log Message: --- WebExtensionContext::loadDeclarativeNetRequestRules takes 1.54s on the main thread loading Ghostery https://webkit.org/b/270327 rdar://123867301 Reviewed by Timothy Hatcher. Compile DNR rulesets on a background thread to prevent hang. * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm: (WebKit::WebExtensionContext::compileDeclarativeNetRequestRules): Canonical link: https://commits.webkit.org/275952@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f5aca8: Add Test Case of a Japanese character inside ruby ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f5aca8555eacdc7aa217dcc1478cd3fadd4110cb https://github.com/WebKit/WebKit/commit/f5aca8555eacdc7aa217dcc1478cd3fadd4110cb Author: Ahmad Saleem Date: 2024-03-11 (Mon, 11 Mar 2024) Changed paths: A LayoutTests/fast/writing-mode/inline-block-baseline-expected.html A LayoutTests/fast/writing-mode/inline-block-baseline.html Log Message: --- Add Test Case of a Japanese character inside ruby is overflowed from background of ruby https://bugs.webkit.org/show_bug.cgi?id=117013 Reviewed by Alan Baradlay. This adds tests for coverage of baseline matching for ruby element with Japanese character while being vertically aligned not overflowing from background of ruby. Test Case Credit to Yuki Sekiguchi . * LayoutTests/fast/writing-mode/inline-block-baseline.html: Add Test Case * LayoutTests/fast/writing-mode/inline-block-baseline-expected.html: Add Test Case Expectation Canonical link: https://commits.webkit.org/275942@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dbeae5: v2: WebCoreTestSupport.h should put export macros ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dbeae5745e4e2e46395c9a0c33265904d55f81d3 https://github.com/WebKit/WebKit/commit/dbeae5745e4e2e46395c9a0c33265904d55f81d3 Author: David Kilzer Date: 2024-03-11 (Mon, 11 Mar 2024) Changed paths: M Source/WebCore/testing/js/WebCoreTestSupport.h Log Message: --- v2: WebCoreTestSupport.h should put export macros to the left of function declarations https://bugs.webkit.org/show_bug.cgi?id=270816 Reviewed by Alex Christensen. * Source/WebCore/testing/js/WebCoreTestSupport.h: (WebCoreTestSupport::testDocumentFragmentParseXML): (WebCoreTestSupport::testSincResamplerProcessBuffer): - Move TEST_SUPPORT_EXPORT to the beginning the function declaration. Canonical link: https://commits.webkit.org/275933@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 01e3f9: Build fix: Remove Source/WebCore/PAL/ThirdParty/li...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 01e3f96ac5ae6cec162115f49bab932bdf231fbf https://github.com/WebKit/WebKit/commit/01e3f96ac5ae6cec162115f49bab932bdf231fbf Author: David Kilzer Date: 2024-03-11 (Mon, 11 Mar 2024) Changed paths: R Source/WebCore/PAL/ThirdParty/libavif/android_jni/.gitignore R Source/WebCore/PAL/ThirdParty/libavif/android_jni/README.md R Source/WebCore/PAL/ThirdParty/libavif/android_jni/avifandroidjni/.gitignore R Source/WebCore/PAL/ThirdParty/libavif/android_jni/avifandroidjni/build.gradle R Source/WebCore/PAL/ThirdParty/libavif/android_jni/avifandroidjni/proguard-rules.pro R Source/WebCore/PAL/ThirdParty/libavif/android_jni/avifandroidjni/src/androidTest/AndroidManifest.xml R Source/WebCore/PAL/ThirdParty/libavif/android_jni/avifandroidjni/src/androidTest/assets/README.md R Source/WebCore/PAL/ThirdParty/libavif/android_jni/avifandroidjni/src/androidTest/assets/animated_avif/Chimera-AV1-10bit-480x270.avif R Source/WebCore/PAL/ThirdParty/libavif/android_jni/avifandroidjni/src/androidTest/assets/animated_avif/alpha_video.avif R Source/WebCore/PAL/ThirdParty/libavif/android_jni/avifandroidjni/src/androidTest/assets/avif/blue-and-magenta-crop.avif R Source/WebCore/PAL/ThirdParty/libavif/android_jni/avifandroidjni/src/androidTest/assets/avif/fox.profile0.10bpc.yuv420.avif R Source/WebCore/PAL/ThirdParty/libavif/android_jni/avifandroidjni/src/androidTest/assets/avif/fox.profile0.10bpc.yuv420.monochrome.avif R Source/WebCore/PAL/ThirdParty/libavif/android_jni/avifandroidjni/src/androidTest/assets/avif/fox.profile0.8bpc.yuv420.avif R Source/WebCore/PAL/ThirdParty/libavif/android_jni/avifandroidjni/src/androidTest/assets/avif/fox.profile0.8bpc.yuv420.monochrome.avif R Source/WebCore/PAL/ThirdParty/libavif/android_jni/avifandroidjni/src/androidTest/assets/avif/fox.profile1.10bpc.yuv444.avif R Source/WebCore/PAL/ThirdParty/libavif/android_jni/avifandroidjni/src/androidTest/assets/avif/fox.profile1.8bpc.yuv444.avif R Source/WebCore/PAL/ThirdParty/libavif/android_jni/avifandroidjni/src/androidTest/assets/avif/fox.profile2.10bpc.yuv422.avif R Source/WebCore/PAL/ThirdParty/libavif/android_jni/avifandroidjni/src/androidTest/assets/avif/fox.profile2.12bpc.yuv420.avif R Source/WebCore/PAL/ThirdParty/libavif/android_jni/avifandroidjni/src/androidTest/assets/avif/fox.profile2.12bpc.yuv420.monochrome.avif R Source/WebCore/PAL/ThirdParty/libavif/android_jni/avifandroidjni/src/androidTest/assets/avif/fox.profile2.12bpc.yuv422.avif R Source/WebCore/PAL/ThirdParty/libavif/android_jni/avifandroidjni/src/androidTest/assets/avif/fox.profile2.12bpc.yuv444.avif R Source/WebCore/PAL/ThirdParty/libavif/android_jni/avifandroidjni/src/androidTest/assets/avif/fox.profile2.8bpc.yuv422.avif R Source/WebCore/PAL/ThirdParty/libavif/android_jni/avifandroidjni/src/androidTest/java/org/aomedia/avif/android/AvifDecoderTest.java R Source/WebCore/PAL/ThirdParty/libavif/android_jni/avifandroidjni/src/androidTest/proguard-rules.pro R Source/WebCore/PAL/ThirdParty/libavif/android_jni/avifandroidjni/src/main/AndroidManifest.xml R Source/WebCore/PAL/ThirdParty/libavif/android_jni/avifandroidjni/src/main/java/org/aomedia/avif/android/AvifDecoder.java R Source/WebCore/PAL/ThirdParty/libavif/android_jni/avifandroidjni/src/main/jni/CMakeLists.txt R Source/WebCore/PAL/ThirdParty/libavif/android_jni/avifandroidjni/src/main/jni/libavif_jni.cc R Source/WebCore/PAL/ThirdParty/libavif/android_jni/build.gradle R Source/WebCore/PAL/ThirdParty/libavif/android_jni/gradle.properties R Source/WebCore/PAL/ThirdParty/libavif/android_jni/gradle/wrapper/gradle-wrapper.jar R Source/WebCore/PAL/ThirdParty/libavif/android_jni/gradle/wrapper/gradle-wrapper.properties R Source/WebCore/PAL/ThirdParty/libavif/android_jni/gradlew R Source/WebCore/PAL/ThirdParty/libavif/android_jni/gradlew.bat R Source/WebCore/PAL/ThirdParty/libavif/android_jni/settings.gradle Log Message: --- Build fix: Remove Source/WebCore/PAL/ThirdParty/libavif/android_jni folder rdar://124330659 https://bugs.webkit.org/show_bug.cgi?id=270747 Reviewed by Alexey Proskuryakov. * Source/WebCore/PAL/ThirdParty/libavif/android_jni/.gitignore: Remove. * Source/WebCore/PAL/ThirdParty/libavif/android_jni/README.md: Remove. * Source/WebCore/PAL/ThirdParty/libavif/android_jni/avifandroidjni/.gitignore: Remove. * Source/WebCore/PAL/ThirdParty/libavif/android_jni/avifandroidjni/build.gradle: Remove. * Source/WebCore/PAL/ThirdParty/libavif/android_jni/avifandroidjni/proguard-rules.pro: Remove. * Source/WebCore/PAL/ThirdParty/libavif/android_jni/avifandroidjni/src/androidTest/AndroidManifest.xml: Remove. * Source/WebCore/PAL/ThirdParty/libavif/android_jni/avifandroidjni/src/androidTest/assets/README.md: Remove. *
[webkit-changes] [WebKit/WebKit] 1cc043: Unreviewed, reverting 275886@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1cc043508ba53ae9f59da6238be80ed26ef02f1d https://github.com/WebKit/WebKit/commit/1cc043508ba53ae9f59da6238be80ed26ef02f1d Author: Mark Lam Date: 2024-03-11 (Mon, 11 Mar 2024) Changed paths: M Source/JavaScriptCore/Scripts/process-entitlements.sh M Source/JavaScriptCore/jit/ExecutableAllocator.cpp M Source/WebKit/Scripts/process-entitlements.sh Log Message: --- Unreviewed, reverting 275886@main https://bugs.webkit.org/show_bug.cgi?id=270808 rdar://124398466 REGRESSION(275886@main): Breaks test runs. Reverted change: Adopt com.apple.developer.cs.allow-jit entitlement for iOS. https://bugs.webkit.org/show_bug.cgi?id=270723 rdar://122841355 https://commits.webkit.org/275886@main Canonical link: https://commits.webkit.org/275913@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 25257b: [WebRTC] Incorrect length check in getSequenceHead...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 25257b2a5f814303f58c5f826d2ce6b05a9bd56a https://github.com/WebKit/WebKit/commit/25257b2a5f814303f58c5f826d2ce6b05a9bd56a Author: David Kilzer Date: 2024-03-11 (Mon, 11 Mar 2024) Changed paths: M Source/WebCore/platform/video-codecs/cocoa/RTCVideoDecoderVTBAV1.mm Log Message: --- [WebRTC] Incorrect length check in getSequenceHeaderOBU() for AV1 decoder support https://bugs.webkit.org/show_bug.cgi?id=270760 Reviewed by Youenn Fablet. * Source/WebCore/platform/video-codecs/cocoa/RTCVideoDecoderVTBAV1.mm: (BitReader::readBit): - Make method private since it's only used within the class. (readULEBSize): - Move std::numeric_limits::max() check after `value` is computed. This was a secondary bug that caused unsigned integer overflow in getSequenceHeaderOBU(). (getSequenceHeaderOBU): - Change `payloadSize` to be a Checked variable. - Fix length check to include `index + payloadSize`. This was the original bug that caused more than data.size() bytes to be read. Canonical link: https://commits.webkit.org/275904@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dd74d7: Adopt com.apple.developer.cs.allow-jit entitlement...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dd74d7957b6db44bbb1be9ac7d9684e87975b12d https://github.com/WebKit/WebKit/commit/dd74d7957b6db44bbb1be9ac7d9684e87975b12d Author: Mark Lam Date: 2024-03-09 (Sat, 09 Mar 2024) Changed paths: M Source/JavaScriptCore/Scripts/process-entitlements.sh M Source/JavaScriptCore/jit/ExecutableAllocator.cpp M Source/WebKit/Scripts/process-entitlements.sh Log Message: --- Adopt com.apple.developer.cs.allow-jit entitlement for iOS. https://bugs.webkit.org/show_bug.cgi?id=270723 rdar://122841355 Reviewed by Justin Michaud. * Source/JavaScriptCore/Scripts/process-entitlements.sh: * Source/JavaScriptCore/jit/ExecutableAllocator.cpp: (JSC::isJITEnabled): (JSC::ExecutableAllocator::disableJIT): * Source/WebKit/Scripts/process-entitlements.sh: Canonical link: https://commits.webkit.org/275886@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4d43d6: Resync Invoker WPTs
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4d43d6cf919e3ca92769de9455757ee77a5ad2ae https://github.com/WebKit/WebKit/commit/4d43d6cf919e3ca92769de9455757ee77a5ad2ae Author: Keith Cirkel Date: 2024-03-09 (Sat, 09 Mar 2024) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/interestelement-interface.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/interestelement-interface.tentative.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invokeelement-interface.tentative-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invokeelement-interface.tentative.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invokeevent-interface.tentative-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invokeevent-interface.tentative.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-button-event-dispatch.tentative-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-button-event-dispatch.tentative.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/w3c-import.log Log Message: --- Resync Invoker WPTs https://bugs.webkit.org/show_bug.cgi?id=270718 Reviewed by Tim Nguyen. Upstream commit: https://github.com/web-platform-tests/wpt/commit/92088377f8a8f322333f5ca2efc6f077e5bedeb6 * LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/interestelement-interface.tentative.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invokeelement-interface.tentative.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invokeevent-interface.tentative.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-button-event-dispatch.tentative.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/w3c-import.log: Canonical link: https://commits.webkit.org/275884@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cd4920: Unreviewed, reverting 275836@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cd492006d90abe023692c5a7c2ac1538dede5e16 https://github.com/WebKit/WebKit/commit/cd492006d90abe023692c5a7c2ac1538dede5e16 Author: Commit Queue Date: 2024-03-09 (Sat, 09 Mar 2024) Changed paths: M Source/JavaScriptCore/runtime/Options.cpp M Source/JavaScriptCore/runtime/OptionsList.h M Source/WTF/wtf/PlatformEnable.h Log Message: --- Unreviewed, reverting 275836@main. https://bugs.webkit.org/show_bug.cgi?id=270746 Large JS2 / JS3 regression Reverted changeset: "Add runtime flag to allow JIT Cage experiments" https://bugs.webkit.org/show_bug.cgi?id=270668 https://commits.webkit.org/275836@main Canonical link: https://commits.webkit.org/275878@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3aba39: Add target for webm_fuzzer
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3aba3902984e20a3e6fbb49cda2049b7f5106618 https://github.com/WebKit/WebKit/commit/3aba3902984e20a3e6fbb49cda2049b7f5106618 Author: David Kilzer Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: A Source/ThirdParty/libwebrtc/Configurations/BaseTarget-libwebm.xcconfig M Source/ThirdParty/libwebrtc/Configurations/h264_bitstream_parser_fuzzer.xcconfig M Source/ThirdParty/libwebrtc/Configurations/h265_bitstream_parser_fuzzer.xcconfig M Source/ThirdParty/libwebrtc/Configurations/libwebm.xcconfig A Source/ThirdParty/libwebrtc/Configurations/webm_fuzzer.xcconfig M Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj Log Message: --- Add target for webm_fuzzer https://bugs.webkit.org/show_bug.cgi?id=270712 Reviewed by Alex Christensen. * Source/ThirdParty/libwebrtc/Configurations/h264_bitstream_parser_fuzzer.xcconfig: (PRODUCT_NAME): Add. * Source/ThirdParty/libwebrtc/Configurations/h265_bitstream_parser_fuzzer.xcconfig: (PRODUCT_NAME): Add. - Drive-by fix to add PRODUCT_NAME to each xcconfig file. * Source/ThirdParty/libwebrtc/Configurations/BaseTarget-libwebm.xcconfig: Copied from Source/ThirdParty/libwebrtc/Configurations/libwebm.xcconfig. * Source/ThirdParty/libwebrtc/Configurations/libwebm.xcconfig: - Extract common variables from libwebm.xcconfig into BaseTarget-libwebm.xcconfig. * Source/ThirdParty/libwebrtc/Configurations/webm_fuzzer.xcconfig: Add. * Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj: - Drive-by fix to remove redundant PRODUCT_NAME variables from various targets. (Fuzzers (libwebrtc)): - Add webm_fuzzer as dependency to aggregate target. (webm_fuzzer target): Add. - Add target to build webm_fuzzer. Canonical link: https://commits.webkit.org/275865@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c76d3a: Unreviewed, reverting 275857@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c76d3aa189af8174847229cb619b5bc930f31995 https://github.com/WebKit/WebKit/commit/c76d3aa189af8174847229cb619b5bc930f31995 Author: Commit Queue Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M Source/WTF/wtf/PlatformUse.h M Source/WebKit/Configurations/BaseExtension.xcconfig M Source/WebKit/Configurations/BaseXPCService.xcconfig M Source/WebKit/Configurations/GPUService.xcconfig M Source/WebKit/Configurations/NetworkService.xcconfig M Source/WebKit/Configurations/WebContentService.xcconfig M Source/WebKit/Configurations/WebKit.xcconfig Log Message: --- Unreviewed, reverting 275857@main. https://bugs.webkit.org/show_bug.cgi?id=270717 Can potentially break perf testing Reverted changeset: "Enable WebKit process extensions on newer OS versions" https://bugs.webkit.org/show_bug.cgi?id=270444 https://commits.webkit.org/275857@main Canonical link: https://commits.webkit.org/275858@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ec04ba: Versioning.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ec04baed9c99710129a149617a291fe6f21e6331 https://github.com/WebKit/WebKit/commit/ec04baed9c99710129a149617a291fe6f21e6331 Author: Dan Robson Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M Configurations/Version.xcconfig Log Message: --- Versioning. WebKit-7619.1.6 Canonical link: https://commits.webkit.org/275851@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0d1d56: [UnifiedPDF] Fix coordinate space for accessibility.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0d1d56d4da989bb82028ad08c8d392dc2b3ab51e https://github.com/WebKit/WebKit/commit/0d1d56d4da989bb82028ad08c8d392dc2b3ab51e Author: Elina Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm M Source/WebKit/WebProcess/Plugins/PDF/WKAccessibilityPDFDocumentObject.h M Source/WebKit/WebProcess/Plugins/PDF/WKAccessibilityPDFDocumentObject.mm Log Message: --- [UnifiedPDF] Fix coordinate space for accessibility. Reviewed by Abrar Rahman Protyasha. - Fix VO cursor position does not match the focused element in unified pdf. There are 2 parts of this change. One in pdfKit and one in webKit - Update the plugin in WKAccessibilityDocumentObject to UnifiedPDFPlugin - Remove extra functions - Add new accessibility support api. * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h: * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm: (WebKit::PDFPluginBase::PDFPluginBase): (WebKit::PDFPluginBase::convertFromPDFViewToRootView const): Deleted. (WebKit::PDFPluginBase::convertFromPDFViewToScreenForAccessibility const): Deleted. (WebKit::PDFPluginBase::convertFromRootViewToPDFView const): Deleted. * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::UnifiedPDFPlugin): (WebKit::UnifiedPDFPlugin::accessibilityScrollToPage): (WebKit::UnifiedPDFPlugin::convertFromPDFPageToScreenForAccessibility const): (WebKit::UnifiedPDFPlugin::accessibilityHitTestIntPoint const): * Source/WebKit/WebProcess/Plugins/PDF/WKAccessibilityPDFDocumentObject.h: * Source/WebKit/WebProcess/Plugins/PDF/WKAccessibilityPDFDocumentObject.mm: (-[WKAccessibilityPDFDocumentObject setPDFPlugin:]): (-[WKAccessibilityPDFDocumentObject accessibilityFocusedUIElement]): (-[WKAccessibilityPDFDocumentObject accessibilityWindow]): (-[WKAccessibilityPDFDocumentObject accessibilityTopLevelUIElement]): (-[WKAccessibilityPDFDocumentObject accessibilityVisibleChildren]): (-[WKAccessibilityPDFDocumentObject accessibilitySubrole]): (-[WKAccessibilityPDFDocumentObject accessibilityFrame]): (-[WKAccessibilityPDFDocumentObject accessibilityParent]): (-[WKAccessibilityPDFDocumentObject accessibilityAttributeValue:]): (-[WKAccessibilityPDFDocumentObject accessibilityArrayAttributeCount:]): (-[WKAccessibilityPDFDocumentObject accessibilityChildren]): (-[WKAccessibilityPDFDocumentObject convertFromPDFPageToScreenForAccessibility:pageIndex:]): (-[WKAccessibilityPDFDocumentObject accessibilityHitTest:]): (-[WKAccessibilityPDFDocumentObject gotoDestination:]): (-[WKAccessibilityPDFDocumentObject parent]): Deleted. [UnifiedPDF] Fix coordinate space for accessibility https://bugs.webkit.org/show_bug.cgi?id=269956 rdar://123459892 Reviewed by Abrar Rahman Protyasha. - Fix VO cursor position does not match the focused element in unified pdf. There are 2 parts of this change. One in pdfKit and one in webKit - Update the plugin in WKAccessibilityDocumentObject to UnifiedPDFPlugin - Remove extra functions - Add new accessibility support api Canonical link: https://commits.webkit.org/275848@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 06b335: Add runtime flag to allow JIT Cage experiments
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 06b3353a1bb84507905d8c052efb433ead7d055f https://github.com/WebKit/WebKit/commit/06b3353a1bb84507905d8c052efb433ead7d055f Author: Marcus Plutowski Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M Source/JavaScriptCore/runtime/Options.cpp M Source/JavaScriptCore/runtime/OptionsList.h M Source/WTF/wtf/PlatformEnable.h Log Message: --- Add runtime flag to allow JIT Cage experiments https://bugs.webkit.org/show_bug.cgi?id=270668 rdar://119832251 Reviewed by Mark Lam. This was previously only configurable at compile time; now, the new allowJITCageExperiments will allow this behavior to be turned on at runtime. * Source/JavaScriptCore/runtime/Options.cpp: (JSC::canUseJITCage): * Source/JavaScriptCore/runtime/OptionsList.h: * Source/WTF/wtf/PlatformEnable.h: Canonical link: https://commits.webkit.org/275836@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c7469f: Unreviewed, reverting 275797@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c7469f3135e5c2c2491c13f679c8c224198062b3 https://github.com/WebKit/WebKit/commit/c7469f3135e5c2c2491c13f679c8c224198062b3 Author: Commit Queue Date: 2024-03-07 (Thu, 07 Mar 2024) Changed paths: M LayoutTests/fast/encoding/char-decoding-mac-expected.txt M LayoutTests/fast/encoding/char-decoding-mac.html M LayoutTests/fast/encoding/char-encoding-mac-expected.txt M LayoutTests/fast/encoding/char-encoding-mac.html M LayoutTests/fast/encoding/legacy-ios-encodings-expected.txt M LayoutTests/fast/encoding/legacy-ios-encodings.html M LayoutTests/fast/encoding/legacy-tec-encodings-expected.txt M LayoutTests/fast/encoding/legacy-tec-encodings.html M LayoutTests/imported/w3c/web-platform-tests/encoding/unsupported-labels-expected.txt M LayoutTests/platform/glib/imported/w3c/web-platform-tests/encoding/unsupported-labels-expected.txt M Source/WebCore/PAL/pal/text/TextCodecCJK.cpp M Source/WebCore/PAL/pal/text/TextCodecICU.cpp Log Message: --- Unreviewed, reverting 275797@main. https://bugs.webkit.org/show_bug.cgi?id=270658 Need to investigate internal usage before removing these encodings Reverted changeset: "Remove non-standard encodings (e.g., 'x-mac-turkish', 'x-mac-greek' etc.)" https://bugs.webkit.org/show_bug.cgi?id=265261 https://commits.webkit.org/275797@main Canonical link: https://commits.webkit.org/275806@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c37138: [WebCore] Add big endian bitmap texture
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c37138cb8d45196e3379961b1f0a91fc30541b2d https://github.com/WebKit/WebKit/commit/c37138cb8d45196e3379961b1f0a91fc30541b2d Author: Dennis Camera Date: 2024-03-07 (Thu, 07 Mar 2024) Changed paths: M Source/WebCore/platform/graphics/texmap/BitmapTexture.cpp Log Message: --- [WebCore] Add big endian bitmap texture https://bugs.webkit.org/show_bug.cgi?id=245446 Reviewed by Michael Catanzaro and Miguel Gomez. Adding the ARGB bitmap for big endian fixes colours when WEBKIT_DISABLE_COMPOSITING_MODE=1 is set. * Source/WebCore/platform/graphics/texmap/BitmapTexture.cpp: add bitmap texture for big endian. Canonical link: https://commits.webkit.org/275780@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 97e744: Reload without content blockers may not appear for...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 97e744cbfdca05fad698f53a482b5c00c3c38a58 https://github.com/WebKit/WebKit/commit/97e744cbfdca05fad698f53a482b5c00c3c38a58 Author: Elijah Sawyers Date: 2024-03-06 (Wed, 06 Mar 2024) Changed paths: M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.h M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIDeclarativeNetRequest.mm Log Message: --- Reload without content blockers may not appear for extensions that use DNR https://webkit.org/b/270552 rdar://124033486 Reviewed by Timothy Hatcher. Clients need to be aware of whether or not a web extension context has any content modification rules rules. This patch adds a new property to expose that information. * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.h: * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.mm: (-[_WKWebExtensionContext hasContentModificationRules]): * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm: (WebKit::WebExtensionContext::hasContentModificationRules): * Source/WebKit/UIProcess/Extensions/WebExtensionContext.h: Canonical link: https://commits.webkit.org/275768@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2b86d3: REGRESSION (275711@main): [ iOS ] 6x TestWebKitAPI...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2b86d34a461912629b0f2d3af7fc57b3da047933 https://github.com/WebKit/WebKit/commit/2b86d34a461912629b0f2d3af7fc57b3da047933 Author: Pascoe Date: 2024-03-06 (Wed, 06 Mar 2024) Changed paths: M Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm Log Message: --- REGRESSION (275711@main): [ iOS ] 6x TestWebKitAPI.WebAuthenticationPanel.MakeCredential (API-Tests) are constant failures https://bugs.webkit.org/show_bug.cgi?id=270590 rdar://124156975 Unreviewed, test gardening. These tests fail because WKTR doesn't have access to the real access group for passkeys, they will be re-enabled after test development to use a different group in tests. * Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/275766@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8c6180: Add myself as a contributor of the WebKit repository
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8c618049b3b1e4cea009f30ce4a968862639f5c5 https://github.com/WebKit/WebKit/commit/8c618049b3b1e4cea009f30ce4a968862639f5c5 Author: Elijah Sawyers Date: 2024-03-06 (Wed, 06 Mar 2024) Changed paths: M metadata/contributors.json Log Message: --- Add myself as a contributor of the WebKit repository Reviewed by Brian Weinstein and Timothy Hatcher. * metadata/contributors.json: Canonical link: https://commits.webkit.org/275759@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2cdc0d: REGRESSION (275711@main): [ iOS ] 6x TestWebKitAPI...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2cdc0db1ae7125d4a2f565263f33e1e11e97bc8d https://github.com/WebKit/WebKit/commit/2cdc0db1ae7125d4a2f565263f33e1e11e97bc8d Author: Pascoe Date: 2024-03-06 (Wed, 06 Mar 2024) Changed paths: M Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm Log Message: --- REGRESSION (275711@main): [ iOS ] 6x TestWebKitAPI.WebAuthenticationPanel.MakeCredential (API-Tests) are constant failures https://bugs.webkit.org/show_bug.cgi?id=270590 rdar://124156975 Unreviewed, test gardening. These tests fail because WKTR doesn't have access to the real access group for passkeys, they will be re-enabled after test development to use a different group in tests. * Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/275757@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c1c024: [Webauthn] Disable tests until test development fo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c1c0248f645301e3c81ed6f67987a181af43fb5d https://github.com/WebKit/WebKit/commit/c1c0248f645301e3c81ed6f67987a181af43fb5d Author: Pascoe Date: 2024-03-06 (Wed, 06 Mar 2024) Changed paths: M LayoutTests/TestExpectations Log Message: --- [Webauthn] Disable tests until test development for access group landed https://bugs.webkit.org/show_bug.cgi?id=270583 rdar://124150813 Unreviewed. * LayoutTests/TestExpectations: These tests fail because WKTR doesn't have access to the real access group for passkeys, they will be re-enabled after test development to use a different group in tests. Canonical link: https://commits.webkit.org/275751@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9c85c7: Make WebCore::WebVTTParser testable
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9c85c7c81e33e375407199f3d3668e9d902e93ce https://github.com/WebKit/WebKit/commit/9c85c7c81e33e375407199f3d3668e9d902e93ce Author: David Kilzer Date: 2024-03-06 (Wed, 06 Mar 2024) Changed paths: M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/html/track/VTTRegion.h M Source/WebCore/html/track/WebVTTParser.h Log Message: --- Make WebCore::WebVTTParser testable https://bugs.webkit.org/show_bug.cgi?id=270526 Reviewed by Alex Christensen. * Source/WebCore/WebCore.xcodeproj/project.pbxproj: - Make BufferedLineReader.h and WebVTTParser.h private headers. * Source/WebCore/html/track/VTTRegion.h: - Export WebCore::VTTRegion class. * Source/WebCore/html/track/WebVTTParser.h: - Export WebCore::WebVTTParser class. (WebCore::WebVTTParser::WebVTTParser): - Delete unused default constructor. Canonical link: https://commits.webkit.org/275743@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3451ab: Unreviewed, reverting 275690@main and 275706@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3451abb11ae972d02bb8cf6490d6404a2a62bc70 https://github.com/WebKit/WebKit/commit/3451abb11ae972d02bb8cf6490d6404a2a62bc70 Author: Commit Queue Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M Tools/Scripts/webkitpy/__init__.py M Tools/Scripts/webkitpy/api_tests/manager.py M Tools/Scripts/webkitpy/autoinstalled/buildbot.py M Tools/Scripts/webkitpy/autoinstalled/twisted.py M Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder.py M Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py M Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py M Tools/Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py M Tools/Scripts/webkitpy/browserperfdash/browserperfdash_runner.py M Tools/Scripts/webkitpy/common/checkout/__init__.py M Tools/Scripts/webkitpy/common/checkout/checkout_unittest.py M Tools/Scripts/webkitpy/common/checkout/scm/__init__.py M Tools/Scripts/webkitpy/common/checkout/scm/git.py M Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py M Tools/Scripts/webkitpy/common/checkout/scm/svn.py M Tools/Scripts/webkitpy/common/net/bugzilla/attachment.py M Tools/Scripts/webkitpy/common/net/bugzilla/bug.py M Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py M Tools/Scripts/webkitpy/common/net/buildbot/__init__.py M Tools/Scripts/webkitpy/common/net/credentials_unittest.py M Tools/Scripts/webkitpy/common/net/file_uploader.py M Tools/Scripts/webkitpy/common/net/resultsjsonparser.py M Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py M Tools/Scripts/webkitpy/common/system/filesystem_mock_unittest.py M Tools/Scripts/webkitpy/common/system/logutils_unittest.py M Tools/Scripts/webkitpy/common/system/path.py M Tools/Scripts/webkitpy/common/system/path_unittest.py M Tools/Scripts/webkitpy/common/system/platforminfo_unittest.py M Tools/Scripts/webkitpy/common/system/systemhost.py M Tools/Scripts/webkitpy/common/system/user.py M Tools/Scripts/webkitpy/common/system/user_mock.py M Tools/Scripts/webkitpy/featuredefines/search.py M Tools/Scripts/webkitpy/generate_xcfilelists_lib/generators.py M Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py M Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py M Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py M Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py M Tools/Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py M Tools/Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py M Tools/Scripts/webkitpy/layout_tests/servers/websocket_server_unittest.py M Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py M Tools/Scripts/webkitpy/port/__init__.py M Tools/Scripts/webkitpy/port/factory.py M Tools/Scripts/webkitpy/port/gtk_unittest.py M Tools/Scripts/webkitpy/port/headlessdriver.py M Tools/Scripts/webkitpy/port/ios_simulator_unittest.py M Tools/Scripts/webkitpy/port/mac_unittest.py M Tools/Scripts/webkitpy/port/port_testcase.py M Tools/Scripts/webkitpy/port/server_process.py M Tools/Scripts/webkitpy/port/simulator_process.py M Tools/Scripts/webkitpy/port/visionos_simulator_unittest.py M Tools/Scripts/webkitpy/port/watch_simulator_unittest.py M Tools/Scripts/webkitpy/port/westondriver.py M Tools/Scripts/webkitpy/port/westondriver_unittest.py M Tools/Scripts/webkitpy/port/win.py M Tools/Scripts/webkitpy/port/win_unittest.py M Tools/Scripts/webkitpy/port/wpe_unittest.py M Tools/Scripts/webkitpy/port/xvfbdriver.py M Tools/Scripts/webkitpy/port/xvfbdriver_unittest.py M Tools/Scripts/webkitpy/static_analysis/results_unittest.py M Tools/Scripts/webkitpy/style/checker_unittest.py M Tools/Scripts/webkitpy/style/checkers/contributors.py M Tools/Scripts/webkitpy/style/checkers/featuredefines.py M Tools/Scripts/webkitpy/style/checkers/png.py M Tools/Scripts/webkitpy/style/checkers/xcscheme.py M Tools/Scripts/webkitpy/style/error_handlers.py M Tools/Scripts/webkitpy/style/error_handlers_unittest.py M Tools/Scripts/webkitpy/style/filereader.py M Tools/Scripts/webkitpy/test/main.py M Tools/Scripts/webkitpy/test/runner.py M Tools/Scripts/webkitpy/thirdparty/BeautifulSoup.py M Tools/Scripts/webkitpy/tool/steps/__init__.py M Tools/Scripts/webkitpy/w3c/test_converter.py M Tools/Scripts/webkitpy/w3c/test_converter_unittest.py M Tools/Scripts/webkitpy/w3c/test_downloader.py M Tools/Scripts/webkitpy/w3c/test_importer.py M Tools/Scripts/webkitpy/w3c/test_parser_unittest.py M Tools/Scripts/webkitpy/w3c/wpt_github.py M Tools/Scripts/webkitpy/w3c/wpt_github_mock.py M Tools
[webkit-changes] [WebKit/WebKit] c0e1cd: [WebAuthn] Navigator matches excludedCredentials f...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c0e1cd6ea54e260139397056ccc5cf2f199aa7f0 https://github.com/WebKit/WebKit/commit/c0e1cd6ea54e260139397056ccc5cf2f199aa7f0 Author: Pascoe Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm Log Message: --- [WebAuthn] Navigator matches excludedCredentials for deleted passkeys in 30 day grace period https://bugs.webkit.org/show_bug.cgi?id=264097 rdar://118182303 Reviewed by Charlie Wolfe. In order to avoid matching recently deleted passkeys in the local authenticator, we match only against the group "com.apple.webkit.webauthn." This works because recently deleted passkeys are moved to another group, "com.apple.webkit.webauthn-recently-deleted." * Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm: (WebKit::LocalAuthenticatorInternal::getExistingCredentials): Canonical link: https://commits.webkit.org/275711@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 04d497: WebAuthn userHandle must be null, not empty string
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 04d4979c9e1d766b1ad11eac36f7593ee8bb268d https://github.com/WebKit/WebKit/commit/04d4979c9e1d766b1ad11eac36f7593ee8bb268d Author: Pascoe Date: 2024-03-04 (Mon, 04 Mar 2024) Changed paths: M Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm Log Message: --- WebAuthn userHandle must be null, not empty string rdar://92305724 https://bugs.webkit.org/show_bug.cgi?id=239737 Reviewed by Brent Fulgham. Whenever we started calling out to AuthenticationServicesAgent, we started passing no user handle as an empty ArrayBuffer instead of null. This isn't allowed by the spec, if there's no user handle we should return null. This change does that by treating an empty user handle as null. This is already checked for in LayoutTests, however, they don't exercise the serialization back and forth from the daemon. * Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm: (WebKit::toArrayBuffer): Canonical link: https://commits.webkit.org/275669@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7db187: [WebAuthn] Add logging for authenticators
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7db187aff8f92fa64a130fecf7d69471eb95aa1e https://github.com/WebKit/WebKit/commit/7db187aff8f92fa64a130fecf7d69471eb95aa1e Author: Pascoe Date: 2024-03-04 (Mon, 04 Mar 2024) Changed paths: M Source/WebCore/Modules/webauthn/WebAuthenticationUtils.cpp M Source/WebCore/Modules/webauthn/WebAuthenticationUtils.h M Source/WebCore/Modules/webauthn/fido/AuthenticatorGetInfoResponse.cpp M Source/WebKit/UIProcess/WebAuthentication/fido/CtapAuthenticator.cpp M Source/WebKit/UIProcess/WebAuthentication/fido/CtapAuthenticator.h M Source/WebKit/UIProcess/WebAuthentication/fido/FidoAuthenticator.cpp M Source/WebKit/UIProcess/WebAuthentication/fido/FidoAuthenticator.h M Source/WebKit/UIProcess/WebAuthentication/fido/U2fAuthenticator.cpp Log Message: --- [WebAuthn] Add logging for authenticators https://bugs.webkit.org/show_bug.cgi?id=270463 rdar://123704181 Reviewed by Charlie Wolfe. This patch adds detailed logging to understand the flows through the CTAP and U2F authenticator code. Sometimes we hit flaky or hard to reproduce error conditions with security keys. This change will aid in debugging these cases. Although challenges are short-lived. We don't log the responses of successful makeCredential and getAssertion calls containing signatures, instead logging only if there was an issue with the response. * Source/WebCore/Modules/webauthn/WebAuthenticationUtils.cpp: (WebCore::toString): * Source/WebCore/Modules/webauthn/WebAuthenticationUtils.h: * Source/WebCore/Modules/webauthn/fido/AuthenticatorGetInfoResponse.cpp: (fido::encodeAsCBOR): (fido::toString): Deleted. * Source/WebKit/UIProcess/WebAuthentication/fido/CtapAuthenticator.cpp: (WebKit::CtapAuthenticator::makeCredential): (WebKit::CtapAuthenticator::continueMakeCredentialAfterResponseReceived): (WebKit::CtapAuthenticator::getAssertion): (WebKit::CtapAuthenticator::continueGetAssertionAfterResponseReceived): (WebKit::CtapAuthenticator::continueGetNextAssertionAfterResponseReceived): (WebKit::CtapAuthenticator::getRetries): (WebKit::CtapAuthenticator::continueGetKeyAgreementAfterGetRetries): (WebKit::CtapAuthenticator::continueRequestPinAfterGetKeyAgreement): (WebKit::CtapAuthenticator::continueGetPinTokenAfterRequestPin): (WebKit::CtapAuthenticator::continueRequestAfterGetPinToken): (WebKit::CtapAuthenticator::tryRestartPin): (WebKit::CtapAuthenticator::tryDowngrade): (WebKit::CtapAuthenticator::aaguidForDebugging const): * Source/WebKit/UIProcess/WebAuthentication/fido/CtapAuthenticator.h: * Source/WebKit/UIProcess/WebAuthentication/fido/FidoAuthenticator.cpp: (WebKit::FidoAuthenticator::transportForDebugging const): * Source/WebKit/UIProcess/WebAuthentication/fido/FidoAuthenticator.h: * Source/WebKit/UIProcess/WebAuthentication/fido/U2fAuthenticator.cpp: (WebKit::U2fAuthenticator::makeCredential): (WebKit::U2fAuthenticator::checkExcludeList): (WebKit::U2fAuthenticator::issueRegisterCommand): (WebKit::U2fAuthenticator::getAssertion): (WebKit::U2fAuthenticator::issueSignCommand): (WebKit::U2fAuthenticator::issueNewCommand): (WebKit::U2fAuthenticator::issueCommand): (WebKit::U2fAuthenticator::continueRegisterCommandAfterResponseReceived): (WebKit::U2fAuthenticator::continueCheckOnlyCommandAfterResponseReceived): (WebKit::U2fAuthenticator::continueBogusCommandExcludeCredentialsMatchAfterResponseReceived): (WebKit::U2fAuthenticator::continueBogusCommandNoCredentialsAfterResponseReceived): (WebKit::U2fAuthenticator::continueSignCommandAfterResponseReceived): Canonical link: https://commits.webkit.org/275657@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dc2a52: [WTF] fix empty initializer of sched_param
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: dc2a5279c02a165ed42491edd7da88d15a5ed738
https://github.com/WebKit/WebKit/commit/dc2a5279c02a165ed42491edd7da88d15a5ed738
Author: Dennis Camera
Date: 2024-03-04 (Mon, 04 Mar 2024)
Changed paths:
M Source/WTF/wtf/linux/RealTimeThreads.cpp
M Source/WTF/wtf/posix/ThreadingPOSIX.cpp
Log Message:
---
[WTF] fix empty initializer of sched_param
https://bugs.webkit.org/show_bug.cgi?id=270474
Reviewed by Michael Catanzaro.
Initializing the sched_param structs to zero with { 0 } fails when using GCC 13.
* Source/WTF/wtf/linux/RealTimeThreads.cpp: change struct sched_param zero
initializer.
* Source/WTF/wtf/posix/ThreadingPOSIX.cpp: change struct sched_param zero
initializer.
Canonical link: https://commits.webkit.org/275655@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b3a8dd: Build fix: WK_LIBFUZZER_COVERAGE should default to...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b3a8dd34740ae0278032de7fe17a10bfc9d8b3a7 https://github.com/WebKit/WebKit/commit/b3a8dd34740ae0278032de7fe17a10bfc9d8b3a7 Author: David Kilzer Date: 2024-03-04 (Mon, 04 Mar 2024) Changed paths: M Configurations/Sanitizers.xcconfig Log Message: --- Build fix: WK_LIBFUZZER_COVERAGE should default to trace-pc-guard when Fuzzilli is enabled https://bugs.webkit.org/show_bug.cgi?id=269796 Unreviewed build fix. Enabling Fuzzilli failed to compile and link with -fsanitize-coverage=trace-pc-guard. The fix is to have separate OTHER_CFLAGS and OTHER_LDFLAGS for Fuzzilli and LibFuzzer that both use the shared $(WK_SANITIZER_COVERAGE). * Configurations/Sanitizers.xcconfig: (WK_SANITIZER_OTHER_CFLAGS): - Rearrange switches. (WK_SANITIZER_OTHER_CPLUSPLUSFLAGS): - Remove $(WK_LIBFUZZER_OTHER_CPLUSPLUSFLAGS_$(ENABLE_LIBFUZZER)) as it is not used. (WK_SANITIZER_OTHER_LDFLAGS): - Add $(WK_FUZZILLI_OTHER_LDFLAGS_$(ENABLE_FUZZILLI)). (WK_SANITIZER_COVERAGE*): - Rename from WK_LIBFUZZER_COVERAGE. (WK_SANITIZER_COVERAGE_OTHER_FLAGS): Add. - This is shared between Fuzzilli and LibFuzzer. (WK_LIBFUZZER_OTHER_CFLAGS_YES): (WK_LIBFUZZER_OTHER_LDFLAGS_YES): (WK_FUZZILLI_OTHER_CFLAGS_YES): Add. (WK_FUZZILLI_OTHER_LDFLAGS_YES): Add. - Make use of $(WK_SANITIZER_COVERAGE_OTHER_FLAGS). Canonical link: https://commits.webkit.org/275632@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 56001e: [JSC] A64DOpcode include
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 56001e951362a5064027b1af81283e523e35559b https://github.com/WebKit/WebKit/commit/56001e951362a5064027b1af81283e523e35559b Author: Dennis Camera Date: 2024-03-04 (Mon, 04 Mar 2024) Changed paths: M Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.h Log Message: --- [JSC] A64DOpcode include https://bugs.webkit.org/show_bug.cgi?id=270394 Reviewed by Michael Catanzaro. When UNIFIED_BUILDS are disabled, the build fails due to missing std::call_once. * Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.h: include . Canonical link: https://commits.webkit.org/275630@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 079924: [WebCore] Disable -allowable_client switches when ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 079924b7373aae7210ae6cc966ede1f0436d720c https://github.com/WebKit/WebKit/commit/079924b7373aae7210ae6cc966ede1f0436d720c Author: David Kilzer Date: 2024-02-29 (Thu, 29 Feb 2024) Changed paths: M Source/WebCore/Configurations/WebCore.xcconfig Log Message: --- [WebCore] Disable -allowable_client switches when libFuzzer is enabled https://bugs.webkit.org/show_bug.cgi?id=270298 Reviewed by Alexey Proskuryakov. * Source/WebCore/Configurations/WebCore.xcconfig: (WEBCORE_ALLOWABLE_CLIENTS): Add. (WEBCORE_ALLOWABLE_CLIENTS_YES): Add. - Move -allowable_client switches from OTHER_LDFLAGS to here. - Disable -allowable_client switches when ENABLE_LIBFUZZER=YES. (WEBCORE_ALLOWABLE_CLIENTS_PLATFORM_cocoatouch): Add. (OTHER_LDFLAGS_PLATFORM_cocoatouch): Remove. - Rename OTHER_LDFLAGS_PLATFORM_cocoatouch to WEBCORE_ALLOWABLE_CLIENTS_PLATFORM_cocoatouch. (OTHER_LDFAGS): - Update to use $(WEBCORE_ALLOWABLE_CLIENTS). Canonical link: https://commits.webkit.org/275519@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 242f32: Add myself (Robin Malhotra) to contributors
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 242f32072d977d6ff9931514d698ae7ee8d8 https://github.com/WebKit/WebKit/commit/242f32072d977d6ff9931514d698ae7ee8d8 Author: Robin Malhotra Date: 2024-02-29 (Thu, 29 Feb 2024) Changed paths: M metadata/contributors.json Log Message: --- Add myself (Robin Malhotra) to contributors https://bugs.webkit.org/show_bug.cgi?id=270261 rdar://123791210 Reviewed by Abrar Rahman Protyasha. * metadata/contributors.json: Canonical link: https://commits.webkit.org/275517@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 54f5d3: [JSC] Support TransitionKind in Structure::dump
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 54f5d3926793c470cad6437ebb8dd755e3ee14ac https://github.com/WebKit/WebKit/commit/54f5d3926793c470cad6437ebb8dd755e3ee14ac Author: Yijia Huang Date: 2024-02-29 (Thu, 29 Feb 2024) Changed paths: M Source/JavaScriptCore/runtime/Structure.cpp M Source/JavaScriptCore/runtime/Structure.h Log Message: --- [JSC] Support TransitionKind in Structure::dump https://bugs.webkit.org/show_bug.cgi?id=270271 rdar://123794287 Reviewed by Alexey Shvayka. Now Structure::dump can print structure TransitionKind. * Source/JavaScriptCore/runtime/Structure.cpp: (JSC::Structure::dump const): (JSC::dumpTransitionKind): * Source/JavaScriptCore/runtime/Structure.h: Canonical link: https://commits.webkit.org/275499@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 768116: [JSC] Remove ArrayPatternNode::emitDirectBinding()
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 76811693b10007dba19a08e3395e0c072c4bc0be https://github.com/WebKit/WebKit/commit/76811693b10007dba19a08e3395e0c072c4bc0be Author: Alexey Shvayka Date: 2024-02-28 (Wed, 28 Feb 2024) Changed paths: M JSTests/microbenchmarks/default-value-destructuring-array.js R JSTests/microbenchmarks/destructuring-array-literal.js M JSTests/microbenchmarks/destructuring-swap.js M JSTests/test262/expectations.yaml M Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp M Source/JavaScriptCore/parser/Nodes.h Log Message: --- [JSC] Remove ArrayPatternNode::emitDirectBinding() https://bugs.webkit.org/show_bug.cgi?id=187085 Reviewed by Yusuke Suzuki. This patch removes special bytecode generation path for code like `[a, b] = [b, a]` that wasn't spec-compliant: it skipped invocation of iterator protocol, which was observable when built-ins like `Array.prototype[Symbol.iterator]` were modified. There is no way to guard the special code path with some sort of built-ins check without bloating the bytecode size: we would still need to emit regular iterator protocol code, which actually isn't even slower after DFG / FTL, as demonstated by existing microbenchmark. Only very obscure / synthetic tests are recorded to be slower after this change. This patch was A/B tested not to affect JS3, SP2, and SP3. Aligns JSC with the spec, V8, and SpiderMonkey. ToT patch destructuring-swap 53.4546+-0.1895 ^ 51.3538+-0.2101^ definitely 1.0409x faster default-value-destructuring-array 36.5455+-0.4078 ! 105.0089+-0.4452! definitely 2.8734x slower * JSTests/microbenchmarks/default-value-destructuring-array.js: * JSTests/microbenchmarks/destructuring-array-literal.js: Removed, it was very synthetic test targeting emitDirectBinding(). * JSTests/microbenchmarks/destructuring-swap.js: * JSTests/test262/expectations.yaml: Mark 24 tests as passing. * Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp: (JSC::DestructuringAssignmentNode::emitBytecode): (JSC::ArrayPatternNode::emitDirectBinding): Deleted. * Source/JavaScriptCore/parser/Nodes.h: (JSC::DestructuringPatternNode::isRestParameter const): (JSC::DestructuringPatternNode::emitDirectBinding): Deleted. Canonical link: https://commits.webkit.org/275474@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] be2916: [WebAuthn] Overrelease in error for multi-origin c...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: be2916dac989bfb95ddfe2acb75c9631f1d00959 https://github.com/WebKit/WebKit/commit/be2916dac989bfb95ddfe2acb75c9631f1d00959 Author: Pascoe Date: 2024-02-28 (Wed, 28 Feb 2024) Changed paths: M Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm Log Message: --- [WebAuthn] Overrelease in error for multi-origin credentials rdar://123357813 https://bugs.webkit.org/show_bug.cgi?id=269942 Reviewed by Chris Dumez. There's evidence for crashes being caused by the over-release of the dictionary inside userInfo[NSUnderlyingErrorKey] for the error returned for multi-origin credentials. This patch is to use RetainPtr in WebKit for this dictionary. I have not been able to reproduce the crash, so this is speculative. * Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm: (WebKit::WebAuthenticatorCoordinatorProxy::performRequest): Canonical link: https://commits.webkit.org/275466@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d4af38: [JSC] Stress tests have bogus asserts due to incor...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d4af38db11471f70862112152e92ffed9443 https://github.com/WebKit/WebKit/commit/d4af38db11471f70862112152e92ffed9443 Author: Alexey Shvayka Date: 2024-02-28 (Wed, 28 Feb 2024) Changed paths: M JSTests/ChakraCore/test/Array/array_splice.js M JSTests/ChakraCore/test/Array/array_splice_double.js M JSTests/stress/dfg-get-private-name-by-id-generic.js M JSTests/stress/dfg-get-private-name-by-id-osr-bad-identifier.js M JSTests/stress/dfg-get-private-name-by-offset-osr-bad-identifier.js M JSTests/stress/dfg-get-private-name-by-offset-osr-bad-structure.js M JSTests/stress/dfg-get-private-name-by-val-generic.js M JSTests/stress/dfg-put-private-name-check-barrier-insertion.js M JSTests/stress/dfg-put-private-name-compiled-as-put-by-id-direct.js M JSTests/stress/dfg-put-private-name-compiled-as-put-private-name-by-id.js M JSTests/stress/get-private-name-with-primitive.js M JSTests/stress/invalidate-array-iterator-prototype-next.js M JSTests/stress/private-method-and-field-named-constructor.js M JSTests/stress/private-method-check-structure-miss.js M JSTests/stress/private-method-invalid-multiple-brand-installation.js M JSTests/stress/private-method-invalidate-compiled-with-constant-symbol.js M JSTests/stress/private-method-polymorphic-with-constant-symbol.js M JSTests/stress/private-method-untyped-use.js M JSTests/stress/put-private-name-by-id-set-do-not-add-structure-trasition.js M JSTests/stress/put-private-name-invalid-define.js M JSTests/stress/put-private-name-invalid-store.js M JSTests/stress/put-private-name-invalidate-compiled-with-constant-symbol.js M JSTests/stress/put-private-name-untyped-use.js M JSTests/stress/put-private-name-with-primitive.js M JSTests/stress/regexp-with-runtime-syntax-errors.js M JSTests/stress/spread-calling.js Log Message: --- [JSC] Stress tests have bogus asserts due to incorrectly negating `instanceof` operator https://bugs.webkit.org/show_bug.cgi?id=261815 Reviewed by Mark Lam. Relational operators in JavaScript, including `instanceof`, have lower precedence than logical negation, meaning `!err instanceof TypeError` evaluates as `false instanceof TypeError` if `err` is an object. This change fixes asserts in our tests to actually validate error constructors, which exposed that one test had wrong expectation of `TypeError` instead of `ReferenceError`: JSC, V8, and SpiderMonkey all throw `ReferenceError` for that code. * JSTests/ChakraCore/test/Array/array_splice.js: * JSTests/ChakraCore/test/Array/array_splice_double.js: * JSTests/stress/dfg-get-private-name-by-id-generic.js: * JSTests/stress/dfg-get-private-name-by-id-osr-bad-identifier.js: * JSTests/stress/dfg-get-private-name-by-offset-osr-bad-identifier.js: * JSTests/stress/dfg-get-private-name-by-offset-osr-bad-structure.js: * JSTests/stress/dfg-get-private-name-by-val-generic.js: * JSTests/stress/dfg-put-private-name-check-barrier-insertion.js: * JSTests/stress/dfg-put-private-name-compiled-as-put-by-id-direct.js: * JSTests/stress/dfg-put-private-name-compiled-as-put-private-name-by-id.js: * JSTests/stress/get-private-name-with-primitive.js: * JSTests/stress/invalidate-array-iterator-prototype-next.js: * JSTests/stress/private-method-and-field-named-constructor.js: * JSTests/stress/private-method-check-structure-miss.js: * JSTests/stress/private-method-invalid-multiple-brand-installation.js: * JSTests/stress/private-method-invalidate-compiled-with-constant-symbol.js: * JSTests/stress/private-method-polymorphic-with-constant-symbol.js: * JSTests/stress/private-method-untyped-use.js: * JSTests/stress/put-private-name-by-id-set-do-not-add-structure-trasition.js: * JSTests/stress/put-private-name-invalid-define.js: * JSTests/stress/put-private-name-invalid-store.js: * JSTests/stress/put-private-name-invalidate-compiled-with-constant-symbol.js: * JSTests/stress/put-private-name-untyped-use.js: * JSTests/stress/put-private-name-with-primitive.js: * JSTests/stress/regexp-with-runtime-syntax-errors.js: * JSTests/stress/spread-calling.js: Canonical link: https://commits.webkit.org/275433@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 26302c: [JSC] emitReturn() should load `this` value from a...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 26302cf8d239273b6b659e4e746829b8322a83b5 https://github.com/WebKit/WebKit/commit/26302cf8d239273b6b659e4e746829b8322a83b5 Author: Alexey Shvayka Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: A JSTests/stress/regress-268864.js M JSTests/test262/expectations.yaml M Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp M Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h M Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp Log Message: --- [JSC] emitReturn() should load `this` value from arrow function lexical environment prior to TDZ check https://bugs.webkit.org/show_bug.cgi?id=268864 Reviewed by Justin Michaud. This change: 1) Hoists first TDZ check of emitReturn() up to FunctionNode::emitBytecode(), and refactors it leveraging semantically equivalent ensureThis(), which makes automatically-inserted return equivalent to `return this`. I confirmed this to be the only call site of emitReturn() with unchecked thisRegister() as `src`. This is non-observable. 2) Adds missing emitLoadThisFromArrowFunctionLexicalEnvironment() before second TDZ check, and refactors it using ensureThis(). This is an observable change that prevents ReferenceError being thrown on totally valid and rather sane code of calling super() inside an arrow function before explicit `return`. Aligns JSC with the spec [1], V8, and SpiderMonkey. 3) Since when `from == ReturnFrom::Finally` is true, `src` is always completionValueRegister(), meaning the check ^^ is useless. Removes it altogether with BytecodeGenerator::ReturnFrom. [1]: https://tc39.es/ecma262/#sec-ecmascript-function-objects-construct-argumentslist-newtarget (step 12) * JSTests/stress/regress-268864.js: Added. * JSTests/test262/expectations.yaml: Mark 6 tests as passing. * Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitReturn): (JSC::BytecodeGenerator::emitFinallyCompletion): * Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h: * Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp: (JSC::FunctionNode::emitBytecode): Canonical link: https://commits.webkit.org/275425@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d691e4: Password manager UI can cause conditional requests...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d691e4579511b2fe0f916d9da1746f98b0519036 https://github.com/WebKit/WebKit/commit/d691e4579511b2fe0f916d9da1746f98b0519036 Author: Pascoe Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm M Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.h M Source/WebKit/UIProcess/WebPageProxy.cpp Log Message: --- Password manager UI can cause conditional requests to pause https://bugs.webkit.org/show_bug.cgi?id=270135 rdar://123659147 Reviewed by Charlie Wolfe and Chris Dumez. The API for autofill assisted passkey requests only allows one request ongoing per UI process. In order to handle this behavior, we currently pause requests whenever their page is not active and resume them whenever the page becomes active. However, bringing up password manager UI as part of an conditional mediation may cause the page to become not active, therefore pausing the request the user is selecting a credential for in the UI. To fix this issue, we don't pause requests whenever a page becomes inactive. Instead we pause the active request whenever another page becomes active. This will result in no pause when brining up password manager UI. * Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm: (WebKit::WebAuthenticatorCoordinatorProxy::pauseConditionalAssertion): (WebKit::WebAuthenticatorCoordinatorProxy::makeActiveConditionalAssertion): (WebKit::WebAuthenticatorCoordinatorProxy::performRequest): * Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::dispatchActivityStateChange): Canonical link: https://commits.webkit.org/275414@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1afa64: Using a predefined path to find PALSwift.h
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1afa64a2afde294bb941e72924dce6d126a185b0 https://github.com/WebKit/WebKit/commit/1afa64a2afde294bb941e72924dce6d126a185b0 Author: nmahendru Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebCore/Configurations/WebCore.xcconfig M Source/WebCore/WebCore.xcodeproj/project.pbxproj Log Message: --- Using a predefined path to find PALSwift.h rdar://123514935 Reviewed by Elliott Williams. The earilier shell script implementation is rather slow and incorrect as it makes assumptions on where the source is checked out. This should be faster and better. Based on excellent suggestions from Elliot Williams. * Source/WebCore/Configurations/WebCore.xcconfig: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/275385@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ad6899: [JSC] try/catch should not intercept errors origin...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ad689935bb77e592b0b622143a71ff5520d6456b https://github.com/WebKit/WebKit/commit/ad689935bb77e592b0b622143a71ff5520d6456b Author: Alexey Shvayka Date: 2024-02-26 (Mon, 26 Feb 2024) Changed paths: A JSTests/stress/regress-268411.js M JSTests/test262/expectations.yaml M Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp M Source/JavaScriptCore/parser/Parser.cpp M Source/JavaScriptCore/parser/Parser.h Log Message: --- [JSC] try/catch should not intercept errors originated in [[Construct]] of derived class https://bugs.webkit.org/show_bug.cgi?id=268411 Reviewed by Justin Michaud. Before this change, if a `return` statement of a derived class constructor was inside a `try` .. `catch` statement, errors thrown at steps 10-12 of [1] were caught by the `catch` block, which is obviously wrong since the userland code should have been evaluated during step 9 of [1]. It's infeasible to perform these checks (super() wasn't called / returned non-undefined primitive) in `op_construct` because we can't distinguish derived class constructors in a performant way, plus accounting for inlining would be challenging. Rather than introducing a mechanism of "fake returns" that jump out from `try` block to perform above-mentioned checks before actually returning, which would be quite complicated, this patch leverages existing emitJumpViaFinallyIfNeeded() logic by creating an empty `finally` block right inside a parser. I argue that containing this whole workaround cohesively in parseTryStatement() is better than passing a CodeFeature that `try` block contains a `return` all the way to TryNode::emitBytecode(). Aligns JSC with the spec [1], V8, and SpiderMonkey. Until very recently, V8 used to have the same bug. [1]: https://tc39.es/ecma262/#sec-ecmascript-function-objects-construct-argumentslist-newtarget * JSTests/stress/regress-268411.js: Added. * JSTests/test262/expectations.yaml: Mark 6 tests as passing. * Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp: (JSC::EmptyStatementNode::emitBytecode): * Source/JavaScriptCore/parser/Parser.cpp: (JSC::Parser::parseReturnStatement): (JSC::Parser::parseTryStatement): * Source/JavaScriptCore/parser/Parser.h: Canonical link: https://commits.webkit.org/275353@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 21dc5d: Pass along clientDataJSON in legacy flow
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 21dc5d50d70cf4207d7626ffe7af5f00ba0741a1 https://github.com/WebKit/WebKit/commit/21dc5d50d70cf4207d7626ffe7af5f00ba0741a1 Author: Pascoe Date: 2024-02-26 (Mon, 26 Feb 2024) Changed paths: M Source/WebKit/Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h M Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm Log Message: --- Pass along clientDataJSON in legacy flow https://bugs.webkit.org/show_bug.cgi?id=270111 rdar://123457653 Reviewed by Brent Fulgham. We started passing along the raw clientDataJSON in the modern flow. We need to do the same in the legacy flow to keep it working since we don't use clientDataHash anymore. * Source/WebKit/Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h: * Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm: (WebKit::configureRegistrationRequestContext): (WebKit::configureAssertionOptions): (WebKit::configurationAssertionRequestContext): (WebKit::WebAuthenticatorCoordinatorProxy::contextForRequest): (WebKit::continueAfterRequest): Canonical link: https://commits.webkit.org/275345@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 09b4cd: Unreviewed, reverting 275316@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 09b4cd863a073e67c494058fbc5067dfa74ec882 https://github.com/WebKit/WebKit/commit/09b4cd863a073e67c494058fbc5067dfa74ec882 Author: Commit Queue Date: 2024-02-26 (Mon, 26 Feb 2024) Changed paths: M Source/WebCore/Headers.cmake M Source/WebCore/PlatformPlayStation.cmake M Source/WebCore/PlatformWin.cmake M Source/WebCore/SourcesGTK.txt M Source/WebCore/SourcesWPE.txt M Source/WebCore/platform/graphics/egl/GLContext.cpp M Source/WebCore/platform/graphics/egl/GLContext.h R Source/WebCore/platform/graphics/egl/GLContextWrapper.cpp R Source/WebCore/platform/graphics/egl/GLContextWrapper.h M Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp M Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.h Log Message: --- Unreviewed, reverting 275316@main. https://bugs.webkit.org/show_bug.cgi?id=270113 GTK, WPE and WinCairo are crashing for WebGL tests Reverted changeset: "[TextureMapper] Add GLContextWrapper to handle the current GL context" https://bugs.webkit.org/show_bug.cgi?id=270078 https://commits.webkit.org/275316@main Canonical link: https://commits.webkit.org/275340@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 298785: Fix build issues around PALSwift.h header
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 29878520d567ad1242cc14257eb8dbb46b08ab93 https://github.com/WebKit/WebKit/commit/29878520d567ad1242cc14257eb8dbb46b08ab93 Author: nmahendru Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M Source/WebCore/WebCore.xcodeproj/project.pbxproj Log Message: --- Fix build issues around PALSwift.h header rdar://123514935 Reviewed by Jonathan Bedard. A few of the builds are structured in a way that assuming the directory `PAL.build` to be right where it usually is not feasible. So this relaxes that but still should manage to get the right header. * Source/WebCore/WebCore.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/275246@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4d395e: Unreviewed, reverting 275195@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4d395e82791b13f534c66c622aecfeb6ec3dcd74 https://github.com/WebKit/WebKit/commit/4d395e82791b13f534c66c622aecfeb6ec3dcd74 Author: Commit Queue Date: 2024-02-22 (Thu, 22 Feb 2024) Changed paths: M Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp M Source/WebKit/UIProcess/AuxiliaryProcessProxy.h M Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp M Source/WebKit/UIProcess/GPU/GPUProcessProxy.h M Source/WebKit/UIProcess/Model/ModelProcessProxy.cpp M Source/WebKit/UIProcess/Model/ModelProcessProxy.h M Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp M Source/WebKit/UIProcess/Network/NetworkProcessProxy.h M Source/WebKit/UIProcess/WebProcessProxy.cpp M Source/WebKit/UIProcess/WebProcessProxy.h M Source/WebKit/UIProcess/ios/WebProcessProxyIOS.mm Log Message: --- Unreviewed, reverting 275195@main. https://bugs.webkit.org/show_bug.cgi?id=269964 Introduced crash Reverted changeset: "Move ProcessThrottler to AuxiliaryProcessProxy" https://bugs.webkit.org/show_bug.cgi?id=269136 https://commits.webkit.org/275195@main Canonical link: https://commits.webkit.org/275215@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 598136: Unreviewed, reverting 275210@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 598136f50543e442f070b6e5348194f53669e1ab https://github.com/WebKit/WebKit/commit/598136f50543e442f070b6e5348194f53669e1ab Author: Commit Queue Date: 2024-02-22 (Thu, 22 Feb 2024) Changed paths: M Source/WebKit/Shared/AuxiliaryProcessExtensions/GPUExtension-Info.plist M Source/WebKit/Shared/AuxiliaryProcessExtensions/WebContentExtension-CaptivePortal-Info.plist M Source/WebKit/Shared/AuxiliaryProcessExtensions/WebContentExtension-Info.plist Log Message: --- Unreviewed, reverting 275210@main. https://bugs.webkit.org/show_bug.cgi?id=269962 Patch needs more work Reverted changeset: "Update identifier for WebKit process extensions" https://bugs.webkit.org/show_bug.cgi?id=269936 https://commits.webkit.org/275210@main Canonical link: https://commits.webkit.org/275214@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 93373b: Adding SHA* implementations using Cryptokit
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 93373b555159aa9bd1f5dfdf9825d23bc3f05e1b https://github.com/WebKit/WebKit/commit/93373b555159aa9bd1f5dfdf9825d23bc3f05e1b Author: nmahendru Date: 2024-02-22 (Thu, 22 Feb 2024) Changed paths: M LayoutTests/crypto/subtle/sha1-digest.html M LayoutTests/crypto/subtle/sha256-digest.html M LayoutTests/crypto/subtle/sha384-digest.html M LayoutTests/crypto/subtle/sha512-digest.html M Source/WebCore/Configurations/WebCore.xcconfig R Source/WebCore/Configurations/WebCoreSwift.xcconfig M Source/WebCore/PAL/Configurations/PAL.xcconfig M Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj A Source/WebCore/PAL/pal/PALSwift/CryptoKitShim.swift M Source/WebCore/PAL/pal/PlatformMac.cmake M Source/WebCore/PAL/pal/crypto/CryptoDigest.h R Source/WebCore/PAL/pal/crypto/commoncrypto/CryptoDigestCommonCrypto.cpp A Source/WebCore/PAL/pal/crypto/commoncrypto/CryptoDigestCommonCrypto.mm M Source/WebCore/PAL/pal/crypto/gcrypt/CryptoDigestGCrypt.cpp M Source/WebCore/PAL/pal/crypto/openssl/CryptoDigestOpenSSL.cpp M Source/WebCore/WebCore.xcodeproj/project.pbxproj R Source/WebCore/WebCoreSwift/CryptoKitShim.swift M Source/WebCore/crypto/CryptoAlgorithm.cpp M Source/WebCore/crypto/CryptoAlgorithm.h M Source/WebCore/crypto/algorithms/CryptoAlgorithmSHA1.cpp M Source/WebCore/crypto/algorithms/CryptoAlgorithmSHA256.cpp M Source/WebCore/crypto/algorithms/CryptoAlgorithmSHA384.cpp M Source/WebCore/crypto/algorithms/CryptoAlgorithmSHA512.cpp M Source/WebCore/crypto/cocoa/CryptoAlgorithmAESGCMMac.mm M Source/WebCore/crypto/cocoa/CryptoAlgorithmAESKWMac.mm Log Message: --- Adding SHA* implementations using Cryptokit rdar://122317816 Reviewed by Alex Christensen. This change re-applies commit ef70f213359b07547c05197ab38d0c70e282a35c which was reverted in 1e8a84a984dbee489a37d35c6167588c84f00475. This change also fixes the issue(that led to revert) in the RunScriptPhase of WebCore target so that it can find the PALSwift.h header for use. The earlier error details are here: rdar://123337721 Revert "Unreviewed, reverting 275070@main" Canonical link: https://commits.webkit.org/275211@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d8aca9: [JSC] Set correct ConstructorKind when reparsing f...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d8aca95c28f69862452c6d9c8a92e169a337c3e5 https://github.com/WebKit/WebKit/commit/d8aca95c28f69862452c6d9c8a92e169a337c3e5 Author: Alexey Shvayka Date: 2024-02-22 (Thu, 22 Feb 2024) Changed paths: M Source/JavaScriptCore/API/JSScriptRef.cpp M Source/JavaScriptCore/builtins/BuiltinExecutables.cpp M Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.cpp M Source/JavaScriptCore/debugger/DebuggerParseData.cpp M Source/JavaScriptCore/parser/Parser.cpp M Source/JavaScriptCore/parser/Parser.h M Source/JavaScriptCore/runtime/CodeCache.cpp M Source/JavaScriptCore/runtime/Completion.cpp M Source/JavaScriptCore/runtime/JSModuleLoader.cpp Log Message: --- [JSC] Set correct ConstructorKind when reparsing functions https://bugs.webkit.org/show_bug.cgi?id=269869 Reviewed by Justin Michaud. Before this change, when reparsing a function, ConstructorKind was always set to None, which prevents a parser-level workaround to fix https://webkit.org/b/268411. Also, ConstructorKind was abused to allow super() in eval(): please see Parser constructor. However, passing down ConstructorKind to parser isn't trivial as it would conflict with `defaultConstructorKindForTopLevelFunction` that is needed only for bytecode validation. To avoid using one parameter for two purposes, this patch extracts parseRootNode(), which has parameters special for debugger / bytecode validation while lacking ones needed only for functions. overrideConstructorKindForTopLevelFunctionExpressions() is introduced for the same purpose. Also, this change: * passes correct DerivedContextType for eval() and reimplements SyntaxError check for super(), all to avoid setting ConstructorKind for non-functions; * hoists ConstructorKind override for bytecode validation up to parseFunctionExpression() to limit the surface of this bytecode validation only hack; * removes unused ParsingContext::Eval. No new tests, no behavior change. * Source/JavaScriptCore/API/JSScriptRef.cpp: (parseScript): * Source/JavaScriptCore/builtins/BuiltinExecutables.cpp: (JSC::BuiltinExecutables::createExecutable): * Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.cpp: (JSC::generateUnlinkedFunctionCodeBlock): * Source/JavaScriptCore/debugger/DebuggerParseData.cpp: (JSC::gatherDebuggerParseData): * Source/JavaScriptCore/parser/Parser.cpp: (JSC::Parser::Parser): (JSC::Parser::parseFunctionInfo): (JSC::Parser::parseFunctionExpression): (JSC::Parser::parseMemberExpression): * Source/JavaScriptCore/parser/Parser.h: (JSC::Scope::setDerivedContextType): (JSC::Scope::derivedContextType const): (JSC::Parser::overrideConstructorKindForTopLevelFunctionExpressions): (JSC::parse): (JSC::parseRootNode): * Source/JavaScriptCore/runtime/CodeCache.cpp: (JSC::generateUnlinkedCodeBlockImpl): * Source/JavaScriptCore/runtime/Completion.cpp: (JSC::checkSyntaxInternal): (JSC::checkModuleSyntax): * Source/JavaScriptCore/runtime/JSModuleLoader.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): Canonical link: https://commits.webkit.org/275189@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 474074: [JSC] Port IPInt entry/exit to armv7
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 474074a02f3ae58188593ed1e15cfcd2b6855d1e https://github.com/WebKit/WebKit/commit/474074a02f3ae58188593ed1e15cfcd2b6855d1e Author: Max Rottenkolber Date: 2024-02-22 (Thu, 22 Feb 2024) Changed paths: M Source/JavaScriptCore/llint/InPlaceInterpreter.asm M Source/JavaScriptCore/wasm/WasmIPIntGenerator.cpp Log Message: --- [JSC] Port IPInt entry/exit to armv7 https://bugs.webkit.org/show_bug.cgi?id=269187 Reviewed by Justin Michaud. This ports the entry and exit sequences of IPInt to armv7. With these changes we can run a basic empty WASM function test case. Further changes are needed to add individual instruction implementations. * Source/JavaScriptCore/llint/InPlaceInterpreter.asm: * Source/JavaScriptCore/wasm/WasmIPIntGenerator.cpp: (JSC::Wasm::IPIntGenerator::addCallCommonData): Canonical link: https://commits.webkit.org/275185@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e7d325: [Apple Pay] Support for PKDisbursementRequest on W...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e7d32568225abe6427fe6c5a3958b43fc9326ec4 https://github.com/WebKit/WebKit/commit/e7d32568225abe6427fe6c5a3958b43fc9326ec4 Author: Robin Malhotra Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: A LayoutTests/http/tests/paymentrequest/ApplePayModifier-disbursementPaymentRequest.https-expected.txt A LayoutTests/http/tests/paymentrequest/ApplePayModifier-disbursementPaymentRequest.https.html M LayoutTests/platform/ios-wk2/TestExpectations M LayoutTests/platform/mac-wk2/TestExpectations M Source/WTF/wtf/PlatformEnableCocoa.h M Source/WebCore/DerivedSources-input.xcfilelist M Source/WebCore/DerivedSources-output.xcfilelist M Source/WebCore/DerivedSources.make M Source/WebCore/Modules/applepay/ApplePayDetailsUpdateBase.h M Source/WebCore/Modules/applepay/ApplePayDetailsUpdateBase.idl A Source/WebCore/Modules/applepay/ApplePayDisbursementPaymentRequest.h A Source/WebCore/Modules/applepay/ApplePayDisbursementPaymentRequest.idl M Source/WebCore/Modules/applepay/ApplePayFeature.h M Source/WebCore/Modules/applepay/ApplePayFeature.idl M Source/WebCore/Modules/applepay/ApplePayLineItem.h M Source/WebCore/Modules/applepay/ApplePayLineItem.idl M Source/WebCore/Modules/applepay/ApplePayMerchantCapability.cpp M Source/WebCore/Modules/applepay/ApplePayMerchantCapability.h M Source/WebCore/Modules/applepay/ApplePayMerchantCapability.idl M Source/WebCore/Modules/applepay/ApplePayPaymentRequest.h M Source/WebCore/Modules/applepay/ApplePayPaymentRequest.idl M Source/WebCore/Modules/applepay/ApplePaySession.cpp M Source/WebCore/Modules/applepay/ApplePaySessionPaymentRequest.h M Source/WebCore/Modules/applepay/PaymentSummaryItems.h M Source/WebCore/Modules/applepay/cocoa/PaymentSummaryItemsCocoa.mm M Source/WebCore/Modules/applepay/paymentrequest/ApplePayModifier.h M Source/WebCore/Modules/applepay/paymentrequest/ApplePayModifier.idl M Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp M Source/WebCore/PAL/pal/cocoa/PassKitSoftLink.h M Source/WebCore/PAL/pal/cocoa/PassKitSoftLink.mm M Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h M Source/WebCore/SourcesCocoa.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/testing/MockPaymentCoordinator.cpp M Source/WebCore/testing/MockPaymentCoordinator.h M Source/WebCore/testing/MockPaymentCoordinator.idl M Source/WebKit/Platform/cocoa/PaymentAuthorizationPresenter.mm A Source/WebKit/Shared/ApplePay/DisbursementPaymentRequest.h A Source/WebKit/Shared/ApplePay/cocoa/DisbursementPaymentRequestCocoa.mm M Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h M Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm M Source/WebKit/Shared/ApplePay/ios/WebPaymentCoordinatorProxyIOS.mm M Source/WebKit/Shared/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/SourcesCocoa.txt M Source/WebKit/WebKit.xcodeproj/project.pbxproj Log Message: --- [Apple Pay] Support for PKDisbursementRequest on WebKit https://bugs.webkit.org/show_bug.cgi?id=267428 rdar://115776022 Reviewed by Alex Christensen. Originally authored by Robin Malhotra. This patch adds support for `PKDisbursementRequest` and associated classes. Since `PKDisbursementPaymentRequest` is a subclass and not a property, the code paths may sometimes diverge from convention. * LayoutTests/http/tests/paymentrequest/ApplePayModifier-disbursementPaymentRequest.https-expected.txt: Added. * LayoutTests/http/tests/paymentrequest/ApplePayModifier-disbursementPaymentRequest.https.html: Added. * LayoutTests/platform/ios-wk2/TestExpectations: * LayoutTests/platform/mac-wk2/TestExpectations: * Source/WTF/wtf/PlatformEnableCocoa.h: * Source/WebCore/DerivedSources-input.xcfilelist: * Source/WebCore/DerivedSources-output.xcfilelist: * Source/WebCore/DerivedSources.make: * Source/WebCore/Modules/applepay/ApplePayDetailsUpdateBase.h: * Source/WebCore/Modules/applepay/ApplePayDetailsUpdateBase.idl: * Source/WebCore/Modules/applepay/ApplePayDisbursementPaymentRequest.h: Copied from Source/WebCore/Modules/applepay/ApplePayMerchantCapability.h. * Source/WebCore/Modules/applepay/ApplePayDisbursementPaymentRequest.idl: Copied from Source/WebCore/Modules/applepay/ApplePayMerchantCapability.idl. * Source/WebCore/Modules/applepay/ApplePayFeature.h: * Source/WebCore/Modules/applepay/ApplePayFeature.idl: * Source/WebCore/Modules/applepay/ApplePayLineItem.h: * Source/WebCore/Modules/applepay/ApplePayLineItem.idl: * Source/WebCore/Modules/applepay/ApplePayMerchantCapability.cpp: (WebCore::convertAndValidate): * Source/WebCore/Modules/applepay/ApplePayMerchantCapability.h: *
[webkit-changes] [WebKit/WebKit] 9b530e: Unreviewed, reverting 275084@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9b530e95cc763506eb74601a08dbe4cdf971a77f https://github.com/WebKit/WebKit/commit/9b530e95cc763506eb74601a08dbe4cdf971a77f Author: Commit Queue Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: R LayoutTests/http/tests/paymentrequest/ApplePayModifier-disbursementPaymentRequest.https-expected.txt R LayoutTests/http/tests/paymentrequest/ApplePayModifier-disbursementPaymentRequest.https.html M LayoutTests/platform/ios-wk2/TestExpectations M LayoutTests/platform/mac-wk2/TestExpectations M Source/WTF/wtf/PlatformEnableCocoa.h M Source/WebCore/DerivedSources-input.xcfilelist M Source/WebCore/DerivedSources-output.xcfilelist M Source/WebCore/DerivedSources.make M Source/WebCore/Modules/applepay/ApplePayDetailsUpdateBase.h M Source/WebCore/Modules/applepay/ApplePayDetailsUpdateBase.idl R Source/WebCore/Modules/applepay/ApplePayDisbursementPaymentRequest.h R Source/WebCore/Modules/applepay/ApplePayDisbursementPaymentRequest.idl M Source/WebCore/Modules/applepay/ApplePayFeature.h M Source/WebCore/Modules/applepay/ApplePayFeature.idl M Source/WebCore/Modules/applepay/ApplePayLineItem.h M Source/WebCore/Modules/applepay/ApplePayLineItem.idl M Source/WebCore/Modules/applepay/ApplePayMerchantCapability.cpp M Source/WebCore/Modules/applepay/ApplePayMerchantCapability.h M Source/WebCore/Modules/applepay/ApplePayMerchantCapability.idl M Source/WebCore/Modules/applepay/ApplePayPaymentRequest.h M Source/WebCore/Modules/applepay/ApplePayPaymentRequest.idl M Source/WebCore/Modules/applepay/ApplePaySession.cpp M Source/WebCore/Modules/applepay/ApplePaySessionPaymentRequest.h M Source/WebCore/Modules/applepay/PaymentSummaryItems.h M Source/WebCore/Modules/applepay/cocoa/PaymentSummaryItemsCocoa.mm M Source/WebCore/Modules/applepay/paymentrequest/ApplePayModifier.h M Source/WebCore/Modules/applepay/paymentrequest/ApplePayModifier.idl M Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp M Source/WebCore/PAL/pal/cocoa/PassKitSoftLink.h M Source/WebCore/PAL/pal/cocoa/PassKitSoftLink.mm M Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h M Source/WebCore/SourcesCocoa.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/testing/MockPaymentCoordinator.cpp M Source/WebCore/testing/MockPaymentCoordinator.h M Source/WebCore/testing/MockPaymentCoordinator.idl M Source/WebKit/Platform/cocoa/PaymentAuthorizationPresenter.mm R Source/WebKit/Shared/ApplePay/DisbursementPaymentRequest.h R Source/WebKit/Shared/ApplePay/cocoa/DisbursementPaymentRequestCocoa.mm M Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h M Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm M Source/WebKit/Shared/ApplePay/ios/WebPaymentCoordinatorProxyIOS.mm M Source/WebKit/Shared/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/SourcesCocoa.txt M Source/WebKit/WebKit.xcodeproj/project.pbxproj Log Message: --- Unreviewed, reverting 275084@main. https://bugs.webkit.org/show_bug.cgi?id=269861 Broke internal builds Reverted changeset: "[Apple Pay] Support for PKDisbursementRequest on WebKit" https://bugs.webkit.org/show_bug.cgi?id=267428 https://commits.webkit.org/275084@main Canonical link: https://commits.webkit.org/275124@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 637fd1: Fill in/fix macros in WebKitTargetConditionals.xcc...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 637fd114532ab3db42ffaf84888b26843e8231b9 https://github.com/WebKit/WebKit/commit/637fd114532ab3db42ffaf84888b26843e8231b9 Author: David Kilzer Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Configurations/WebKitTargetConditionals.xcconfig Log Message: --- Fill in/fix macros in WebKitTargetConditionals.xcconfig https://bugs.webkit.org/show_bug.cgi?id=269799 Reviewed by Alexey Proskuryakov. * Configurations/WebKitTargetConditionals.xcconfig: - Add support for later versions. - Fix multi-version macOS macros which were missing versions in macro names, had incorrect values, or where definitions were just missing. - Remove old unsupported versions. (More clean-up is needed in project *.xcconfig files to remove additional unsupported versions.) Canonical link: https://commits.webkit.org/275122@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3bea24: WK_LIBFUZZER_COVERAGE should default to trace-pc-g...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3bea246beab860f4cdc8e992956cdfda720eeebe https://github.com/WebKit/WebKit/commit/3bea246beab860f4cdc8e992956cdfda720eeebe Author: David Kilzer Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Configurations/Sanitizers.xcconfig Log Message: --- WK_LIBFUZZER_COVERAGE should default to trace-pc-guard when Fuzzilli is enabled https://bugs.webkit.org/show_bug.cgi?id=269796 Reviewed by Yusuke Suzuki. * Configurations/Sanitizers.xcconfig: (WK_SANITIZER_OTHER_LDFLAGS): - Remove support for WK_FUZZILLI_OTHER_LDFLAGS_YES since it's no longer needed. (WK_LIBFUZZER_COVERAGE): - Default to trace-pc-guard when ENABLE_FUZZILLI=YES. (WK_FUZZILLI_OTHER_CFLAGS_YES): - Remove redundant -fsanitize-coverage=trace-pc-guard for Fuzzilli. (WK_FUZZILLI_OTHER_LDFLAGS_YES): Remove. Canonical link: https://commits.webkit.org/275102@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
