[webkit-changes] [295375] trunk/Tools/TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp
Title: [295375] trunk/Tools/TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp
Revision 295375
Author ryanhad...@apple.com
Date 2022-06-07 21:45:04 -0700 (Tue, 07 Jun 2022)
Log Message
REGRESSION (250986@main): [iOS/macOS] ASSERTION FAILED: isASCII(characters[I]) in WTF::ASCIILiteral WTF::StringLiterals::operator""_s(const char *, size_t)
https://bugs.webkit.org/show_bug.cgi?id=241380
Reviewed by Chris Dumez.
One of the subtests in this API test uses a non-ASCII character.
Use StringView::fromLatin1() since that worked on another test in
251205@main.
* Tools/TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp:
(TestWebKitAPI::TEST):
Canonical link: https://commits.webkit.org/251383@main
Modified Paths
trunk/Tools/TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp
Diff
Modified: trunk/Tools/TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp (295374 => 295375)
--- trunk/Tools/TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp 2022-06-08 04:34:24 UTC (rev 295374)
+++ trunk/Tools/TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp 2022-06-08 04:45:04 UTC (rev 295375)
@@ -51,7 +51,7 @@
EXPECT_TRUE(parseCrossOriginResourcePolicyHeader("zameorigin"_s) == CrossOriginResourcePolicy::Invalid);
EXPECT_TRUE(parseCrossOriginResourcePolicyHeader("samesite"_s) == CrossOriginResourcePolicy::Invalid);
EXPECT_TRUE(parseCrossOriginResourcePolicyHeader("same site"_s) == CrossOriginResourcePolicy::Invalid);
-EXPECT_TRUE(parseCrossOriginResourcePolicyHeader("same–site"_s) == CrossOriginResourcePolicy::Invalid);
+EXPECT_TRUE(parseCrossOriginResourcePolicyHeader(StringView::fromLatin1("same–site")) == CrossOriginResourcePolicy::Invalid);
EXPECT_TRUE(parseCrossOriginResourcePolicyHeader("SAMESITE"_s) == CrossOriginResourcePolicy::Invalid);
EXPECT_TRUE(parseCrossOriginResourcePolicyHeader(StringView::fromLatin1("")) == CrossOriginResourcePolicy::Invalid);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295298] trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/AppPrivacyReport.mm
Title: [295298] trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/AppPrivacyReport.mm
Revision 295298
Author ryanhad...@apple.com
Date 2022-06-06 15:04:29 -0700 (Mon, 06 Jun 2022)
Log Message
REGRESSION: [ iOS ] Six TestWebKitAPI.AppPrivacyReport API tests are a consistent timeout
https://bugs.webkit.org/show_bug.cgi?id=241233
Reviewed by Kate Cheney.
Two tests requiring a fix were missed in 251292@main.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/AppPrivacyReport.mm:
Canonical link: https://commits.webkit.org/251343@main
Modified Paths
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/AppPrivacyReport.mm
Diff
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/AppPrivacyReport.mm (295297 => 295298)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/AppPrivacyReport.mm 2022-06-06 21:46:41 UTC (rev 295297)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/AppPrivacyReport.mm 2022-06-06 22:04:29 UTC (rev 295298)
@@ -529,10 +529,12 @@
static void runWebProcessPlugInTest(IsAppInitiated isAppInitiated)
{
+TestWebKitAPI::HTTPServer server(TestWebKitAPI::HTTPServer::respondWithChallengeThenOK);
+
WKWebViewConfiguration *configuration = [WKWebViewConfiguration _test_configurationWithTestPlugInClassName:@"AppPrivacyReportPlugIn"];
auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500) configuration:configuration]);
-NSString *url = ""
+NSString *url = "" stringWithFormat:@"http://127.0.0.1:%d/", server.port()];
__block bool isDone = false;
NSMutableURLRequest *request = [NSMutableURLRequest requestWithURL:[NSURL URLWithString:url]];
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295267] trunk/Tools/CISupport/build-webkit-org
Title: [295267] trunk/Tools/CISupport/build-webkit-org
Revision 295267
Author ryanhad...@apple.com
Date 2022-06-04 11:32:19 -0700 (Sat, 04 Jun 2022)
Log Message
Temporarily disable lldb-webkit-test on Monterey
https://bugs.webkit.org/show_bug.cgi?id=241294
Reviewed by Aakash Jain.
Temporarily disable lldb-webkit-test on Monterey until webkit.org/b/239463
can be resolved or worked around.
* Tools/CISupport/build-webkit-org/factories.py:
(TestFactory.__init__):
* Tools/CISupport/build-webkit-org/factories_unittest.py:
(TestExpectedBuildSteps):
Canonical link: https://commits.webkit.org/251313@main
Modified Paths
trunk/Tools/CISupport/build-webkit-org/factories.py
trunk/Tools/CISupport/build-webkit-org/factories_unittest.py
Diff
Modified: trunk/Tools/CISupport/build-webkit-org/factories.py (295266 => 295267)
--- trunk/Tools/CISupport/build-webkit-org/factories.py 2022-06-04 14:26:54 UTC (rev 295266)
+++ trunk/Tools/CISupport/build-webkit-org/factories.py 2022-06-04 18:32:19 UTC (rev 295267)
@@ -109,7 +109,8 @@
if platform.startswith('win') or platform.startswith('mac') or platform.startswith('ios-simulator'):
self.addStep(RunAPITests())
-if platform.startswith('mac') and (platform != 'mac-catalina'):
+# FIXME: Re-enable these tests for Monterey once webkit.org/b/239463 is resolved.
+if platform.startswith('mac') and (platform != 'mac-monterey'):
self.addStep(RunLLDBWebKitTests())
self.addStep(RunWebKitPyTests())
Modified: trunk/Tools/CISupport/build-webkit-org/factories_unittest.py (295266 => 295267)
--- trunk/Tools/CISupport/build-webkit-org/factories_unittest.py 2022-06-04 14:26:54 UTC (rev 295266)
+++ trunk/Tools/CISupport/build-webkit-org/factories_unittest.py 2022-06-04 18:32:19 UTC (rev 295267)
@@ -90,7 +90,6 @@
'extract-test-results',
'set-permissions',
'run-api-tests',
-'lldb-webkit-test',
'webkitpy-test',
'webkitperl-test',
'bindings-generation-tests',
@@ -116,7 +115,6 @@
'extract-test-results',
'set-permissions',
'run-api-tests',
-'lldb-webkit-test',
'webkitpy-test',
'webkitperl-test',
'bindings-generation-tests',
@@ -142,7 +140,6 @@
'extract-test-results',
'set-permissions',
'run-api-tests',
-'lldb-webkit-test',
'webkitpy-test',
'webkitperl-test',
'bindings-generation-tests',
@@ -168,7 +165,6 @@
'extract-test-results',
'set-permissions',
'run-api-tests',
-'lldb-webkit-test',
'webkitpy-test',
'webkitperl-test',
'bindings-generation-tests',
@@ -224,7 +220,6 @@
'extract-test-results',
'set-permissions',
'run-api-tests',
-'lldb-webkit-test',
'webkitpy-test',
'webkitperl-test',
'bindings-generation-tests',
@@ -250,7 +245,6 @@
'extract-test-results',
'set-permissions',
'run-api-tests',
-'lldb-webkit-test',
'webkitpy-test',
'webkitperl-test',
'bindings-generation-tests',
@@ -276,7 +270,6 @@
'extract-test-results',
'set-permissions',
'run-api-tests',
-'lldb-webkit-test',
'webkitpy-test',
'webkitperl-test',
'bindings-generation-tests',
@@ -302,7 +295,6 @@
'extract-test-results',
'set-permissions',
'run-api-tests',
-'lldb-webkit-test',
'webkitpy-test',
'webkitperl-test',
'bindings-generation-tests',
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295229] trunk/Tools/CISupport/build-webkit-org
Title: [295229] trunk/Tools/CISupport/build-webkit-org
Revision 295229
Author ryanhad...@apple.com
Date 2022-06-03 14:03:40 -0700 (Fri, 03 Jun 2022)
Log Message
Repurpose arm64 iOS simulator GPUP bot as a general arm64 iOS simulator tester
https://bugs.webkit.org/show_bug.cgi?id=241278
Reviewed by Aakash Jain.
* Tools/CISupport/build-webkit-org/config.json:
* Tools/CISupport/build-webkit-org/factories_unittest.py:
(TestExpectedBuildSteps):
* Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot):
Canonical link: https://commits.webkit.org/251284@main
Modified Paths
trunk/Tools/CISupport/build-webkit-org/config.json
trunk/Tools/CISupport/build-webkit-org/factories_unittest.py
trunk/Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js
Diff
Modified: trunk/Tools/CISupport/build-webkit-org/config.json (295228 => 295229)
--- trunk/Tools/CISupport/build-webkit-org/config.json 2022-06-03 21:00:51 UTC (rev 295228)
+++ trunk/Tools/CISupport/build-webkit-org/config.json 2022-06-03 21:03:40 UTC (rev 295229)
@@ -311,7 +311,7 @@
{
"name": "Apple-iOS-15-Simulator-Release-Build", "factory": "BuildFactory",
"platform": "ios-simulator-15", "configuration": "release", "architectures": ["x86_64", "arm64"],
- "triggers": ["ios-simulator-15-release-gpuprocess-arm64-tests-wk2", "ios-simulator-15-release-gpuprocess-tests-wk2", "ios-simulator-15-release-tests-wk2", "ipados-simulator-15-release-tests-wk2"],
+ "triggers": ["ios-simulator-15-release-arm64-tests-wk2", "ios-simulator-15-release-gpuprocess-tests-wk2", "ios-simulator-15-release-tests-wk2", "ipados-simulator-15-release-tests-wk2"],
"workernames": ["bot614", "bot641", "bot682", "bot685", "bot303", "bot305", "bot306"]
},
{
@@ -321,9 +321,9 @@
"workernames": ["bot694", "bot695", "bot307", "bot308"]
},
{
- "name": "Apple-iOS-15-Simulator-Release-GPUProcess-arm64-WK2-Tests", "factory": "TestAllButJSCFactory",
+ "name": "Apple-iOS-15-Simulator-Release-arm64-WK2-Tests", "factory": "TestAllButJSCFactory",
"platform": "ios-simulator-15", "configuration": "release", "architectures": ["x86_64", "arm64"], "device_model": "iphone",
- "additionalArguments": ["--no-retry-failures", "--use-gpu-process", "--accelerated-drawing"],
+ "additionalArguments": ["--no-retry-failures"],
"workernames": ["bot210"]
},
{
@@ -733,8 +733,8 @@
{ "type": "PlatformSpecificScheduler", "platform": "win", "branch": "main", "treeStableTimer": 45.0,
"builderNames": ["Apple-Win-10-Release-Build", "Apple-Win-10-Debug-Build"]
},
-{ "type": "Triggerable", "name": "ios-simulator-15-release-gpuprocess-arm64-tests-wk2",
- "builderNames": ["Apple-iOS-15-Simulator-Release-GPUProcess-arm64-WK2-Tests"]
+{ "type": "Triggerable", "name": "ios-simulator-15-release-arm64-tests-wk2",
+ "builderNames": ["Apple-iOS-15-Simulator-Release-arm64-WK2-Tests"]
},
{ "type": "Triggerable", "name": "ios-simulator-15-release-gpuprocess-tests-wk2",
"builderNames": ["Apple-iOS-15-Simulator-Release-GPUProcess-WK2-Tests"]
Modified: trunk/Tools/CISupport/build-webkit-org/factories_unittest.py (295228 => 295229)
--- trunk/Tools/CISupport/build-webkit-org/factories_unittest.py 2022-06-03 21:00:51 UTC (rev 295228)
+++ trunk/Tools/CISupport/build-webkit-org/factories_unittest.py 2022-06-03 21:03:40 UTC (rev 295229)
@@ -736,7 +736,7 @@
'transfer-to-s3',
'trigger'
],
-'Apple-iOS-15-Simulator-Release-GPUProcess-arm64-WK2-Tests': [
+'Apple-iOS-15-Simulator-Release-arm64-WK2-Tests': [
'configure-build',
'configuration',
'clean-and-update-working-directory',
Modified: trunk/Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js (295228 => 295229)
--- trunk/Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js 2022-06-03 21:00:51 UTC (rev 295228)
+++ trunk/Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js 2022-06-03 21:03:40 UTC (rev 295229)
@@ -61,6 +61,7 @@
}},
"Apple-iOS-15-Release-Build": {platform: Dashboard.Platform.iOS15Device, debug: false, builder: true, architecture: Buildbot.BuildArchitecture.SixtyFourBit},
"Apple-iOS-15-Simulator-Release-Build": {platform: Dashboard.Platform.iOS15Simulator, debug: false, builder: true, architecture:
[webkit-changes] [295130] trunk/LayoutTests/platform/mac-wk2/TestExpectations
Title: [295130] trunk/LayoutTests/platform/mac-wk2/TestExpectations Revision 295130 Author ryanhad...@apple.com Date 2022-06-02 10:20:15 -0700 (Thu, 02 Jun 2022) Log Message [macOS WK2] svg/animations/smil-leak-element-instances.svg is flaky failing https://bugs.webkit.org/show_bug.cgi?id=214579 Unreviewed test gardening. Remove release from the flaky expectation as this affects debug bots as well. * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/251221@main Modified Paths trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (295129 => 295130) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2022-06-02 15:51:24 UTC (rev 295129) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2022-06-02 17:20:15 UTC (rev 295130) @@ -1098,7 +1098,7 @@ webkit.org/b/214478 [ Debug ] http/wpt/webrtc/generateCertificate.html [ Skip ] webkit.org/b/214478 [ Debug ] tiled-drawing/scrolling/fast-scroll-iframe-latched-select.html [ Skip ] -webkit.org/b/214579 [ Release ] svg/animations/smil-leak-element-instances.svg [ Pass Failure ] +webkit.org/b/214579 svg/animations/smil-leak-element-instances.svg [ Pass Failure ] webkit.org/b/214661 [ Debug ] imported/w3c/web-platform-tests/webrtc/RTCSctpTransport-events.html [ Pass Crash Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295095] trunk
Title: [295095] trunk
Revision 295095
Author ryanhad...@apple.com
Date 2022-06-01 10:32:05 -0700 (Wed, 01 Jun 2022)
Log Message
Revert "Allow decidePolicyForNavigation* decisionHandlers to be called on non-main runloops"
Unreviewed, this reverts commit 251175@main.
Canonical link: https://commits.webkit.org/251190@main
Modified Paths
trunk/Source/WebKit/UIProcess/Cocoa/NavigationState.mm
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm
Diff
Modified: trunk/Source/WebKit/UIProcess/Cocoa/NavigationState.mm (295094 => 295095)
--- trunk/Source/WebKit/UIProcess/Cocoa/NavigationState.mm 2022-06-01 17:26:14 UTC (rev 295094)
+++ trunk/Source/WebKit/UIProcess/Cocoa/NavigationState.mm 2022-06-01 17:32:05 UTC (rev 295095)
@@ -575,20 +575,13 @@
};
if (delegateHasWebpagePreferences) {
-auto decisionHandler = [decisionHandlerWithPreferencesOrPolicies = WTFMove(decisionHandlerWithPreferencesOrPolicies)] (WKNavigationActionPolicy actionPolicy, WKWebpagePreferences *preferences) mutable {
-ensureOnMainRunLoop([decisionHandlerWithPreferencesOrPolicies = WTFMove(decisionHandlerWithPreferencesOrPolicies), actionPolicy, retainedPreferences = RetainPtr { preferences }] () mutable {
-decisionHandlerWithPreferencesOrPolicies(actionPolicy, retainedPreferences.get());
-});
-};
if (m_navigationState->m_navigationDelegateMethods.webViewDecidePolicyForNavigationActionWithPreferencesDecisionHandler)
-[navigationDelegate webView:m_navigationState->m_webView decidePolicyForNavigationAction:wrapper(navigationAction) preferences:wrapper(defaultWebsitePolicies) decisionHandler:makeBlockPtr(WTFMove(decisionHandler)).get()];
+[navigationDelegate webView:m_navigationState->m_webView decidePolicyForNavigationAction:wrapper(navigationAction) preferences:wrapper(defaultWebsitePolicies) decisionHandler:makeBlockPtr(WTFMove(decisionHandlerWithPreferencesOrPolicies)).get()];
else
-[(id)navigationDelegate _webView:m_navigationState->m_webView decidePolicyForNavigationAction:wrapper(navigationAction) preferences:wrapper(defaultWebsitePolicies) userInfo:userInfo ? static_cast>(userInfo->wrapper()) : nil decisionHandler:makeBlockPtr(WTFMove(decisionHandler)).get()];
+[(id )navigationDelegate _webView:m_navigationState->m_webView decidePolicyForNavigationAction:wrapper(navigationAction) preferences:wrapper(defaultWebsitePolicies) userInfo:userInfo ? static_cast>(userInfo->wrapper()) : nil decisionHandler:makeBlockPtr(WTFMove(decisionHandlerWithPreferencesOrPolicies)).get()];
} else {
auto decisionHandler = [decisionHandlerWithPreferencesOrPolicies = WTFMove(decisionHandlerWithPreferencesOrPolicies)] (WKNavigationActionPolicy actionPolicy) mutable {
-ensureOnMainRunLoop([decisionHandlerWithPreferencesOrPolicies = WTFMove(decisionHandlerWithPreferencesOrPolicies), actionPolicy] () mutable {
-decisionHandlerWithPreferencesOrPolicies(actionPolicy, nil);
-});
+decisionHandlerWithPreferencesOrPolicies(actionPolicy, nil);
};
[navigationDelegate webView:m_navigationState->m_webView decidePolicyForNavigationAction:wrapper(navigationAction) decisionHandler:makeBlockPtr(WTFMove(decisionHandler)).get()];
}
@@ -661,26 +654,24 @@
return;
auto checker = CompletionHandlerCallChecker::create(navigationDelegate.get(), @selector(webView:decidePolicyForNavigationResponse:decisionHandler:));
-[navigationDelegate webView:m_navigationState->m_webView decidePolicyForNavigationResponse:wrapper(navigationResponse) decisionHandler:makeBlockPtr([localListener = WTFMove(listener), checker = WTFMove(checker)](WKNavigationResponsePolicy responsePolicy) mutable {
-ensureOnMainRunLoop([responsePolicy, checker = WTFMove(checker), localListener = WTFMove(localListener)] {
-if (checker->completionHandlerHasBeenCalled())
-return;
-checker->didCallCompletionHandler();
+[navigationDelegate webView:m_navigationState->m_webView decidePolicyForNavigationResponse:wrapper(navigationResponse) decisionHandler:makeBlockPtr([localListener = WTFMove(listener), checker = WTFMove(checker)](WKNavigationResponsePolicy responsePolicy) {
+if (checker->completionHandlerHasBeenCalled())
+return;
+checker->didCallCompletionHandler();
-switch (responsePolicy) {
-case WKNavigationResponsePolicyAllow:
-localListener->use();
-break;
+switch (responsePolicy) {
+case WKNavigationResponsePolicyAllow:
+localListener->use();
+break;
-case WKNavigationResponsePolicyCancel:
-localListener->ignore();
-break;
+case WKNavigationResponsePolicyCancel:
+localListener->ignore();
+break;
-
[webkit-changes] [295093] trunk/Source
Title: [295093] trunk/Source
Revision 295093
Author ryanhad...@apple.com
Date 2022-06-01 10:04:02 -0700 (Wed, 01 Jun 2022)
Log Message
Revert "[Xcode] Prevent STP and other self-contained builds from overwriting content in the macOS SDK"
Unreviewed, this reverts commit 251168@main to fix internal builds.
Canonical link: https://commits.webkit.org/251188@main
Modified Paths
trunk/Source/_javascript_Core/Configurations/Base.xcconfig
trunk/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig
trunk/Source/_javascript_Core/DerivedSources.make
trunk/Source/_javascript_Core/Scripts/generate-unified-sources.sh
trunk/Source/_javascript_Core/offlineasm/config.rb
trunk/Source/_javascript_Core/offlineasm/parser.rb
trunk/Source/ThirdParty/ANGLE/Configurations/ANGLE-dynamic.xcconfig
trunk/Source/ThirdParty/ANGLE/Configurations/AngleMetalLib.xcconfig
trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig
trunk/Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig
trunk/Source/ThirdParty/libwebrtc/Configurations/boringssl.xcconfig
trunk/Source/ThirdParty/libwebrtc/Configurations/libabsl.xcconfig
trunk/Source/ThirdParty/libwebrtc/Configurations/libsrtp.xcconfig
trunk/Source/ThirdParty/libwebrtc/Configurations/libvpx.xcconfig
trunk/Source/ThirdParty/libwebrtc/Configurations/libwebm.xcconfig
trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig
trunk/Source/ThirdParty/libwebrtc/Configurations/libyuv.xcconfig
trunk/Source/ThirdParty/libwebrtc/Configurations/opus.xcconfig
trunk/Source/ThirdParty/libwebrtc/Configurations/usrsctp.xcconfig
trunk/Source/ThirdParty/libwebrtc/Configurations/yasm.xcconfig
trunk/Source/WTF/Configurations/Base.xcconfig
trunk/Source/WTF/Configurations/WTF.xcconfig
trunk/Source/WTF/Configurations/icu.xcconfig
trunk/Source/WebCore/Configurations/Base.xcconfig
trunk/Source/WebCore/Configurations/WebCore.xcconfig
trunk/Source/WebCore/Configurations/WebCoreTestSupport.xcconfig
trunk/Source/WebCore/DerivedSources.make
trunk/Source/WebCore/PAL/Configurations/PAL.xcconfig
trunk/Source/WebCore/Scripts/generate-unified-sources.sh
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebGPU/Configurations/Base.xcconfig
trunk/Source/WebGPU/Configurations/WGSL.xcconfig
trunk/Source/WebGPU/Configurations/WGSLUnitTests.xcconfig
trunk/Source/WebGPU/Configurations/WebGPU.xcconfig
trunk/Source/WebKit/Configurations/Base.xcconfig
trunk/Source/WebKit/Configurations/BaseTarget.xcconfig
trunk/Source/WebKit/Configurations/SandboxProfiles.xcconfig
trunk/Source/WebKit/Scripts/generate-unified-sources.sh
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
trunk/Source/WebKitLegacy/mac/Configurations/Base.xcconfig
trunk/Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig
trunk/Source/WebKitLegacy/scripts/generate-unified-sources.sh
trunk/Source/bmalloc/Configurations/Base.xcconfig
trunk/Source/bmalloc/Configurations/bmalloc.xcconfig
trunk/Source/bmalloc/Configurations/mbmalloc.xcconfig
Diff
Modified: trunk/Source/_javascript_Core/Configurations/Base.xcconfig (295092 => 295093)
--- trunk/Source/_javascript_Core/Configurations/Base.xcconfig 2022-06-01 16:58:41 UTC (rev 295092)
+++ trunk/Source/_javascript_Core/Configurations/Base.xcconfig 2022-06-01 17:04:02 UTC (rev 295093)
@@ -108,17 +108,8 @@
PREBINDING = NO;
WARNING_CFLAGS = -Wall -Wextra -Wcast-qual -Wchar-subscripts -Wconditional-uninitialized -Wextra-tokens -Wformat=2 -Winit-self -Wmissing-format-attribute -Wmissing-noreturn -Wpacked -Wpointer-arith -Wredundant-decls -Wundef -Wwrite-strings -Wexit-time-destructors -Wglobal-constructors -Wtautological-compare -Wimplicit-fallthrough -Wvla -Wliteral-conversion -Wthread-safety -Wno-profile-instr-out-of-date -Wno-profile-instr-unprofiled;
-HEADER_SEARCH_PATHS = . "$(BUILT_PRODUCTS_DIR)$(WK_LIBRARY_HEADERS_FOLDER_PATH)" $(HEADER_SEARCH_PATHS);
-LIBRARY_SEARCH_PATHS = $(SDK_DIR)$(WK_LIBRARY_INSTALL_PATH) $(inherited);
-SYSTEM_HEADER_SEARCH_PATHS = $(SDK_DIR)$(WK_LIBRARY_HEADERS_FOLDER_PATH) $(inherited);
+HEADER_SEARCH_PATHS = . "${BUILT_PRODUCTS_DIR}/usr/local/include" $(HEADER_SEARCH_PATHS);
-WK_LIBRARY_HEADERS_FOLDER_PATH = $(WK_LIBRARY_HEADERS_FOLDER_PATH_OVERRIDE_$(WK_USE_OVERRIDE_FRAMEWORKS_DIR));
-WK_LIBRARY_HEADERS_FOLDER_PATH_OVERRIDE_NO = /usr/local/include;
-WK_LIBRARY_HEADERS_FOLDER_PATH_OVERRIDE_YES = /usr/local/include/safari-sdk;
-WK_LIBRARY_INSTALL_PATH = $(WK_LIBRARY_INSTALL_PATH_OVERRIDE_$(WK_USE_OVERRIDE_FRAMEWORKS_DIR));
-WK_LIBRARY_INSTALL_PATH_OVERRIDE_NO = /usr/local/lib;
-WK_LIBRARY_INSTALL_PATH_OVERRIDE_YES = /usr/local/lib/safari-sdk;
-
TARGET_MACOS_LEGACY_VERSION_IDENTIFIER = $(TARGET_MACOS_LEGACY_VERSION_IDENTIFIER_$(MACOSX_DEPLOYMENT_TARGET:base))
TARGET_MACOS_LEGACY_VERSION_IDENTIFIER_10 = 10$(MACOSX_DEPLOYMENT_TARGET:suffix:identifier)
Modified: trunk/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig (295092 => 295093)
--- trunk/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig
[webkit-changes] [294771] trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ IndexedDBSuspendImminently.mm
Title: [294771] trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm
Revision 294771
Author ryanhad...@apple.com
Date 2022-05-24 15:31:59 -0700 (Tue, 24 May 2022)
Log Message
[iOS] TestWebKitAPI.IndexedDB.IndexedDBSuspendImminently is consistently timing out on release
https://bugs.webkit.org/show_bug.cgi?id=240886
Unreviewed test gardening.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm:
(TEST): Skip the test.
Canonical link: https://commits.webkit.org/250936@main
Modified Paths
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm
Diff
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm (294770 => 294771)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm 2022-05-24 22:24:37 UTC (rev 294770)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm 2022-05-24 22:31:59 UTC (rev 294771)
@@ -71,7 +71,8 @@
}];
}
-TEST(IndexedDB, IndexedDBSuspendImminently)
+// FIXME: Re-enable this test once webkit.org/b/240886 is resolved.
+TEST(IndexedDB, DISABLED_IndexedDBSuspendImminently)
{
readyToContinue = false;
[[WKWebsiteDataStore defaultDataStore] removeDataOfTypes:[WKWebsiteDataStore allWebsiteDataTypes] modifiedSince:[NSDate distantPast] completionHandler:^() {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294769] trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm
Title: [294769] trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm
Revision 294769
Author ryanhad...@apple.com
Date 2022-05-24 15:18:09 -0700 (Tue, 24 May 2022)
Log Message
[ iOS & MacOS Release ]TestWebKitAPI.WebpagePreferences.WebsitePoliciesAutoplayQuirksAsyncPolicyDelegate is a flaky timeout
Unreviewed test gardening.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
(TEST): Skip the test.
Canonical link: https://commits.webkit.org/250934@main
Modified Paths
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm
Diff
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm (294768 => 294769)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm 2022-05-24 21:55:45 UTC (rev 294768)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm 2022-05-24 22:18:09 UTC (rev 294769)
@@ -927,7 +927,8 @@
}
#endif
-TEST(WebpagePreferences, WebsitePoliciesAutoplayQuirksAsyncPolicyDelegate)
+// FIXME: Re-enable this test once webkit.org/b/230494 is resolved.
+TEST(WebpagePreferences, DISABLED_WebsitePoliciesAutoplayQuirksAsyncPolicyDelegate)
{
auto configuration = adoptNS([[WKWebViewConfiguration alloc] init]);
#if PLATFORM(IOS_FAMILY)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294751] trunk/Tools/CISupport/build-webkit-org/master.cfg
Title: [294751] trunk/Tools/CISupport/build-webkit-org/master.cfg
Revision 294751
Author ryanhad...@apple.com
Date 2022-05-24 09:39:51 -0700 (Tue, 24 May 2022)
Log Message
[build.webkit.org] Allow configuring multiple user credentials
https://bugs.webkit.org/show_bug.cgi?id=240826
Reviewed by Aakash Jain.
Allow configuring multiple user credentials for build.webkit.org as we
did for ews-build.webkit.org in 246332@main. This also loads credentials
from passwords.json instead of environment variables.
* Tools/CISupport/build-webkit-org/master.cfg:
Canonical link: https://commits.webkit.org/250919@main
Modified Paths
trunk/Tools/CISupport/build-webkit-org/master.cfg
Diff
Modified: trunk/Tools/CISupport/build-webkit-org/master.cfg (294750 => 294751)
--- trunk/Tools/CISupport/build-webkit-org/master.cfg 2022-05-24 16:15:40 UTC (rev 294750)
+++ trunk/Tools/CISupport/build-webkit-org/master.cfg 2022-05-24 16:39:51 UTC (rev 294751)
@@ -42,17 +42,16 @@
}
if not is_test_mode_enabled:
-admin_username = load_password('ADMIN_USERNAME')
-admin_password = load_password('ADMIN_PASSWORD')
-if not admin_username or not admin_password:
-print('\n\nERROR: Admin username/password missing from passwords.json.\n')
+credentials = load_password('BUILD_WEBKIT_CREDENTIALS')
+if not credentials:
+print('BUILD_WEBKIT credentials not found. Please ensure BUILD_WEBKIT_CREDENTIALS is configured either in env variables or in passwords.json')
sys.exit(1)
# See https://docs.buildbot.net/2.10.0/manual/configuration/www.html#example-configs
authz = util.Authz(
allowRules=[util.AnyControlEndpointMatcher(role="admin")],
-roleMatchers=[util.RolesFromEmails(admin=[admin_username])]
+roleMatchers=[util.RolesFromEmails(admin=list(credentials.keys()))]
)
-auth = util.UserPasswordAuth({admin_username: admin_password})
+auth = util.UserPasswordAuth(credentials)
c['www']['auth'] = auth
c['www']['authz'] = authz
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294261] trunk
Title: [294261] trunk
Revision 294261
Author ryanhad...@apple.com
Date 2022-05-16 14:37:00 -0700 (Mon, 16 May 2022)
Log Message
Unreviewed, reverting r294238.
Breaks internal builds
Reverted changeset:
"Use _adoptEffectiveConfiguration instead of a separate
NSURLSession without credentials"
https://bugs.webkit.org/show_bug.cgi?id=240362
https://commits.webkit.org/r294238
Modified Paths
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Preconnect.mm
trunk/Tools/TestWebKitAPI/cocoa/HTTPServer.mm
Diff
Modified: trunk/Source/WebCore/PAL/ChangeLog (294260 => 294261)
--- trunk/Source/WebCore/PAL/ChangeLog 2022-05-16 21:21:17 UTC (rev 294260)
+++ trunk/Source/WebCore/PAL/ChangeLog 2022-05-16 21:37:00 UTC (rev 294261)
@@ -1,3 +1,16 @@
+2022-05-16 Ryan Haddad
+
+Unreviewed, reverting r294238.
+
+Breaks internal builds
+
+Reverted changeset:
+
+"Use _adoptEffectiveConfiguration instead of a separate
+NSURLSession without credentials"
+https://bugs.webkit.org/show_bug.cgi?id=240362
+https://commits.webkit.org/r294238
+
2022-05-16 Alex Christensen
Use _adoptEffectiveConfiguration instead of a separate NSURLSession without credentials
Modified: trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h (294260 => 294261)
--- trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h 2022-05-16 21:21:17 UTC (rev 294260)
+++ trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h 2022-05-16 21:37:00 UTC (rev 294261)
@@ -280,7 +280,6 @@
@end
@interface NSURLSessionTask ()
-- (void) _adoptEffectiveConfiguration:(NSURLSessionConfiguration*) newConfiguration;
- (NSDictionary *)_timingData;
@property (readwrite, copy) NSString *_pathToDownloadTaskFile;
@property (copy) NSString *_storagePartitionIdentifier;
Modified: trunk/Source/WebKit/ChangeLog (294260 => 294261)
--- trunk/Source/WebKit/ChangeLog 2022-05-16 21:21:17 UTC (rev 294260)
+++ trunk/Source/WebKit/ChangeLog 2022-05-16 21:37:00 UTC (rev 294261)
@@ -1,3 +1,16 @@
+2022-05-16 Ryan Haddad
+
+Unreviewed, reverting r294238.
+
+Breaks internal builds
+
+Reverted changeset:
+
+"Use _adoptEffectiveConfiguration instead of a separate
+NSURLSession without credentials"
+https://bugs.webkit.org/show_bug.cgi?id=240362
+https://commits.webkit.org/r294238
+
2022-05-16 J Pascoe
REGRESSION (250501@main): [ Mac ] 2 TestWebKitAPI.WebAuthenticationPanel.GetAssertionLA tests failing
Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm (294260 => 294261)
--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm 2022-05-16 21:21:17 UTC (rev 294260)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm 2022-05-16 21:37:00 UTC (rev 294261)
@@ -356,20 +356,6 @@
m_task = [m_sessionWrapper->session dataTaskWithRequest:nsRequest.get()];
-switch (parameters.storedCredentialsPolicy) {
-case WebCore::StoredCredentialsPolicy::Use:
-ASSERT(m_sessionWrapper->session.get().configuration.URLCredentialStorage);
-break;
-case WebCore::StoredCredentialsPolicy::EphemeralStateless:
-ASSERT(!m_sessionWrapper->session.get().configuration.URLCredentialStorage);
-break;
-case WebCore::StoredCredentialsPolicy::DoNotUse:
-NSURLSessionConfiguration *effectiveConfiguration = m_sessionWrapper->session.get().configuration;
-effectiveConfiguration.URLCredentialStorage = nil;
-[m_task _adoptEffectiveConfiguration:effectiveConfiguration];
-break;
-};
-
WTFBeginSignpost(m_task.get(), "DataTask", "%{public}s pri: %.2f preconnect: %d", url.string().ascii().data(), toNSURLSessionTaskPriority(request.priority()), parameters.shouldPreconnectOnly == PreconnectOnly::Yes);
RELEASE_ASSERT(!m_sessionWrapper->dataTaskMap.contains([m_task taskIdentifier]));
Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h (294260 => 294261)
--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h 2022-05-16 21:21:17 UTC (rev 294260)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h 2022-05-16 21:37:00 UTC (rev 294261)
@@ -68,6 +68,7 @@
WTF_MAKE_FAST_ALLOCATED;
public:
SessionWrapper sessionWithCredentialStorage;
+SessionWrapper sessionWithoutCredentialStorage;
WallTime lastUsed;
};
@@ -86,6 +87,7 @@
std::unique_ptr appBoundSession;
SessionWrapper sessionWithCredentialStorage;
+SessionWrapper sessionWithoutCredentialStorage;
SessionWrapper ephemeralStatelessSession;
private:
Modified:
[webkit-changes] [293116] trunk/Tools/CISupport
Title: [293116] trunk/Tools/CISupport
Revision 293116
Author ryanhad...@apple.com
Date 2022-04-20 14:41:33 -0700 (Wed, 20 Apr 2022)
Log Message
Update archs for watchOS build queues
https://bugs.webkit.org/show_bug.cgi?id=239553
Reviewed by Aakash Jain.
Remove the deprecated i386 arch from watchOS simulator builders and switch
EWS + trunk bots to arm64 to expand build coverage for this architecture.
* Tools/CISupport/build-webkit-org/config.json:
* Tools/CISupport/ews-build/config.json:
Canonical link: https://commits.webkit.org/249822@main
Modified Paths
trunk/Tools/CISupport/build-webkit-org/config.json
trunk/Tools/CISupport/ews-build/config.json
Diff
Modified: trunk/Tools/CISupport/build-webkit-org/config.json (293115 => 293116)
--- trunk/Tools/CISupport/build-webkit-org/config.json 2022-04-20 21:37:12 UTC (rev 293115)
+++ trunk/Tools/CISupport/build-webkit-org/config.json 2022-04-20 21:41:33 UTC (rev 293116)
@@ -368,12 +368,12 @@
},
{
"name": "Apple-watchOS-8-Release-Build", "factory": "BuildFactory", "builddir": "watchos-8-release",
- "platform": "watchos-8", "configuration": "release", "architectures": ["arm64_32", "armv7k"],
+ "platform": "watchos-8", "configuration": "release", "architectures": ["arm64_32", "arm64"],
"workernames": ["bot609"]
},
{
"name": "Apple-watchOS-Simulator-8-Release-Build", "factory": "BuildFactory", "builddir": "watchos-simulator-8-release",
- "platform": "watchos-simulator-8", "configuration": "release", "architectures": ["i386"],
+ "platform": "watchos-simulator-8", "configuration": "release", "architectures": ["arm64"],
"workernames": ["bot672"]
},
{
Modified: trunk/Tools/CISupport/ews-build/config.json (293115 => 293116)
--- trunk/Tools/CISupport/ews-build/config.json 2022-04-20 21:37:12 UTC (rev 293115)
+++ trunk/Tools/CISupport/ews-build/config.json 2022-04-20 21:41:33 UTC (rev 293116)
@@ -212,13 +212,13 @@
{
"name": "watchOS-8-Build-EWS", "shortname": "watch", "icon": "buildOnly",
"factory": "watchOSBuildFactory", "platform": "watchos-8",
- "configuration": "release", "architectures": ["arm64_32", "armv7k"],
+ "configuration": "release", "architectures": ["arm64_32", "arm64"],
"workernames": ["ews163", "ews164", "ews165"]
},
{
"name": "watchOS-8-Simulator-Build-EWS", "shortname": "watch-sim", "icon": "buildOnly",
"factory": "watchOSBuildFactory", "platform": "watchos-simulator-8",
- "configuration": "release", "architectures": ["i386"],
+ "configuration": "release", "architectures": ["arm64"],
"workernames": ["ews164", "ews165", "ews166"]
},
{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292965] trunk/LayoutTests
Title: [292965] trunk/LayoutTests Revision 292965 Author ryanhad...@apple.com Date 2022-04-18 12:49:44 -0700 (Mon, 18 Apr 2022) Log Message REGRESSION (249698@main): 4 payment request layout tests failing on Big Sur https://bugs.webkit.org/show_bug.cgi?id=239461 Unreviewed test gardening. * platform/mac-bigsur/http/tests/paymentrequest/payment-request-change-shipping-option.https-expected.txt: Added. * platform/mac-bigsur/http/tests/paymentrequest/updateWith-shippingOptions.https-expected.txt: Added. * platform/mac-bigsur/imported/w3c/web-platform-tests/payment-request/payment-request-constructor.https.sub-expected.txt: Added. * platform/mac-bigsur/imported/w3c/web-platform-tests/payment-request/payment-request-shippingOption-attribute.https-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/mac-bigsur/http/ trunk/LayoutTests/platform/mac-bigsur/http/tests/ trunk/LayoutTests/platform/mac-bigsur/http/tests/paymentrequest/ trunk/LayoutTests/platform/mac-bigsur/http/tests/paymentrequest/payment-request-change-shipping-option.https-expected.txt trunk/LayoutTests/platform/mac-bigsur/http/tests/paymentrequest/updateWith-shippingOptions.https-expected.txt trunk/LayoutTests/platform/mac-bigsur/imported/w3c/web-platform-tests/payment-request/ trunk/LayoutTests/platform/mac-bigsur/imported/w3c/web-platform-tests/payment-request/payment-request-constructor.https.sub-expected.txt trunk/LayoutTests/platform/mac-bigsur/imported/w3c/web-platform-tests/payment-request/payment-request-shippingOption-attribute.https-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (292964 => 292965) --- trunk/LayoutTests/ChangeLog 2022-04-18 19:36:51 UTC (rev 292964) +++ trunk/LayoutTests/ChangeLog 2022-04-18 19:49:44 UTC (rev 292965) @@ -9,6 +9,18 @@ * platform/ios/TestExpectations: +2022-04-18 Ryan Haddad + +REGRESSION (249698@main): 4 payment request layout tests failing on Big Sur +https://bugs.webkit.org/show_bug.cgi?id=239461 + +Unreviewed test gardening. + +* platform/mac-bigsur/http/tests/paymentrequest/payment-request-change-shipping-option.https-expected.txt: Added. +* platform/mac-bigsur/http/tests/paymentrequest/updateWith-shippingOptions.https-expected.txt: Added. +* platform/mac-bigsur/imported/w3c/web-platform-tests/payment-request/payment-request-constructor.https.sub-expected.txt: Added. +* platform/mac-bigsur/imported/w3c/web-platform-tests/payment-request/payment-request-shippingOption-attribute.https-expected.txt: Added. + 2022-04-18 Martin Robinson TestRunner testdriver does not properly focus elements before sending keys to them Added: trunk/LayoutTests/platform/mac-bigsur/http/tests/paymentrequest/payment-request-change-shipping-option.https-expected.txt (0 => 292965) --- trunk/LayoutTests/platform/mac-bigsur/http/tests/paymentrequest/payment-request-change-shipping-option.https-expected.txt (rev 0) +++ trunk/LayoutTests/platform/mac-bigsur/http/tests/paymentrequest/payment-request-change-shipping-option.https-expected.txt 2022-04-18 19:49:44 UTC (rev 292965) @@ -0,0 +1,3 @@ + +FAIL Test for PaymentRequest shippingOption attribute assert_equals: Must be 'initially-selected', as the selected member is true expected "initially-selected" but got "valid-1" + Added: trunk/LayoutTests/platform/mac-bigsur/http/tests/paymentrequest/updateWith-shippingOptions.https-expected.txt (0 => 292965) --- trunk/LayoutTests/platform/mac-bigsur/http/tests/paymentrequest/updateWith-shippingOptions.https-expected.txt (rev 0) +++ trunk/LayoutTests/platform/mac-bigsur/http/tests/paymentrequest/updateWith-shippingOptions.https-expected.txt 2022-04-18 19:49:44 UTC (rev 292965) @@ -0,0 +1,4 @@ + +PASS Calling `updateWith` with a new `shippingOptions` without `requestShipping` should not update any values. +FAIL Calling `updateWith` with a new `shippingOptions` should not update any other values. assert_equals: shipping option 0 selected should change expected (boolean) false but got (undefined) undefined + Added: trunk/LayoutTests/platform/mac-bigsur/imported/w3c/web-platform-tests/payment-request/payment-request-constructor.https.sub-expected.txt (0 => 292965) --- trunk/LayoutTests/platform/mac-bigsur/imported/w3c/web-platform-tests/payment-request/payment-request-constructor.https.sub-expected.txt (rev 0) +++ trunk/LayoutTests/platform/mac-bigsur/imported/w3c/web-platform-tests/payment-request/payment-request-constructor.https.sub-expected.txt 2022-04-18 19:49:44 UTC (rev 292965) @@ -0,0 +1,32 @@ + +PASS If details.id is missing, assign an identifier +PASS If details.id is missing, assign a unique identifier +PASS If the same id is provided, then use it +PASS Use ids even if they are strange +PASS Use provided request ID +PASS If the length of the methodData sequence is zero, then throw a
[webkit-changes] [292246] trunk/LayoutTests
Title: [292246] trunk/LayoutTests Revision 292246 Author ryanhad...@apple.com Date 2022-04-01 17:43:34 -0700 (Fri, 01 Apr 2022) Log Message REGRESSION(r292072): [ Mac iOS ] http/tests/webAPIStatistics/canvas-read-and-write-data-collection.html is a constant text failure https://bugs.webkit.org/show_bug.cgi?id=238580 Unreviewed test gardening. Remove expectations as cause has been reverted. * platform/ios-wk2/TestExpectations: * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (292245 => 292246) --- trunk/LayoutTests/ChangeLog 2022-04-02 00:41:55 UTC (rev 292245) +++ trunk/LayoutTests/ChangeLog 2022-04-02 00:43:34 UTC (rev 292246) @@ -1,3 +1,15 @@ +2022-04-01 Ryan Haddad + +REGRESSION(r292072): [ Mac iOS ] http/tests/webAPIStatistics/canvas-read-and-write-data-collection.html is a constant text failure +https://bugs.webkit.org/show_bug.cgi?id=238580 + +Unreviewed test gardening. + +Remove expectations as cause has been reverted. + +* platform/ios-wk2/TestExpectations: +* platform/mac-wk2/TestExpectations: + 2022-04-01 Commit Queue Unreviewed, reverting r292072. Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (292245 => 292246) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2022-04-02 00:41:55 UTC (rev 292245) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2022-04-02 00:43:34 UTC (rev 292246) @@ -2251,6 +2251,4 @@ webkit.org/b/237849 imported/w3c/web-platform-tests/css/filter-effects/filters-drop-shadow-003.html [ ImageOnlyFailure ] -webkit.org/b/238580 http/tests/webAPIStatistics/canvas-read-and-write-data-collection.html [ Pass Failure ] - -webkit.org/b/238634 media/video-object-fit.html [ ImageOnlyFailure ] \ No newline at end of file +webkit.org/b/238634 media/video-object-fit.html [ ImageOnlyFailure ] Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (292245 => 292246) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2022-04-02 00:41:55 UTC (rev 292245) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2022-04-02 00:43:34 UTC (rev 292246) @@ -1664,8 +1664,6 @@ webkit.org/b/235605 [ arm64 ] fast/scrolling/mac/j-shaped-scroll-rubberband.html [ Failure ] -webkit.org/b/238580 http/tests/webAPIStatistics/canvas-read-and-write-data-collection.html [ Failure ] - # Plugins # FIXME: Remove these tests. platform/mac-wk2/plugins/npruntime/remove-property-from-_javascript_.html [ Skip ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292245] trunk
Title: [292245] trunk Revision 292245 Author ryanhad...@apple.com Date 2022-04-01 17:41:55 -0700 (Fri, 01 Apr 2022) Log Message Unreviewed, reverting r292072. https://bugs.webkit.org/show_bug.cgi?id=238690 Caused webAPIStatistics test failures Reverted changeset: "[Cocoa] Automatically relayout the page when new fonts are installed" https://bugs.webkit.org/show_bug.cgi?id=238483 https://commits.webkit.org/r292072 Patch by Commit Queue on 2022-04-01 Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/platform/ios/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/Page.cpp trunk/Source/WebCore/platform/graphics/FontCache.cpp trunk/Source/WebCore/platform/graphics/FontCache.h Removed Paths trunk/LayoutTests/fast/text/install-font-style-recalc-expected.txt trunk/LayoutTests/fast/text/install-font-style-recalc.html Diff Modified: trunk/LayoutTests/ChangeLog (292244 => 292245) --- trunk/LayoutTests/ChangeLog 2022-04-02 00:25:06 UTC (rev 292244) +++ trunk/LayoutTests/ChangeLog 2022-04-02 00:41:55 UTC (rev 292245) @@ -1,3 +1,17 @@ +2022-04-01 Commit Queue + +Unreviewed, reverting r292072. +https://bugs.webkit.org/show_bug.cgi?id=238690 + +Caused webAPIStatistics test failures + +Reverted changeset: + +"[Cocoa] Automatically relayout the page when new fonts are +installed" +https://bugs.webkit.org/show_bug.cgi?id=238483 +https://commits.webkit.org/r292072 + 2022-04-01 Matteo Flores REGRESSION(r290822?): [ wk1 ] storage/websql/change-version.html is a flaky timeout Modified: trunk/LayoutTests/TestExpectations (292244 => 292245) --- trunk/LayoutTests/TestExpectations 2022-04-02 00:25:06 UTC (rev 292244) +++ trunk/LayoutTests/TestExpectations 2022-04-02 00:41:55 UTC (rev 292245) @@ -5207,6 +5207,3 @@ # Only certain ports have WebGPU implementations. http/tests/webgpu [ Failure ImageOnlyFailure Pass Timeout ] - -# Only some ports automatically relayout if a font is installed while the page is open -fast/text/install-font-style-recalc.html [ Failure ] Deleted: trunk/LayoutTests/fast/text/install-font-style-recalc-expected.txt (292244 => 292245) --- trunk/LayoutTests/fast/text/install-font-style-recalc-expected.txt 2022-04-02 00:25:06 UTC (rev 292244) +++ trunk/LayoutTests/fast/text/install-font-style-recalc-expected.txt 2022-04-02 00:41:55 UTC (rev 292245) @@ -1,11 +0,0 @@ -This test makes sure that installing a font causes a style recalc. The test only runs in DumpRenderTree/WebKitTestRunner. It passes if the text above is rendered as black boxes (aka in Ahem). - -On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". - - -PASS target.offsetWidth became 200 -PASS The font was used. -PASS successfullyParsed is true - -TEST COMPLETE - Deleted: trunk/LayoutTests/fast/text/install-font-style-recalc.html (292244 => 292245) --- trunk/LayoutTests/fast/text/install-font-style-recalc.html 2022-04-02 00:25:06 UTC (rev 292244) +++ trunk/LayoutTests/fast/text/install-font-style-recalc.html 2022-04-02 00:41:55 UTC (rev 292245) @@ -1,21 +0,0 @@ - - - - - - -