Re: [webkit-dev] CSS properties vs. their JS bindings on the style object

On Tue, Feb 28, 2012 at 9:48 PM, wrote: > Seriously, I'm not sure how to proceed on this.  It does seem to be > outside the spec. Either update the spec or create a path to deprecate the "bug". Personally, this "feature" sounds like it could be useful for web developers so updating the spec mig

Re: [webkit-dev] CSS properties vs. their JS bindings on the style object

Sorry, I posted the wrong Microsoft link. Here's the one I meant ... http://msdn.microsoft.com/en-us/library/ie/ms537842%28v=vs.85%29.aspx --Tom > Yeah, but how many people really use this "Trident" thing ;) > > Seriously, I'm not sure how to proceed on this. It does seem to be > outside the

Re: [webkit-dev] CSS properties vs. their JS bindings on the style object

Yeah, but how many people really use this "Trident" thing ;) Seriously, I'm not sure how to proceed on this. It does seem to be outside the spec. Humorously, even Microsoft's has references that imply that the script binding is named differently from the CSS attribute. http://msdn.microsoft.co

Re: [webkit-dev] 48459: Glyphs in vertical text tests are rotated 90 degrees clockwise on Windows

Thank you Dave, I'll go that way. I'm thinking to write a code that parses OpenType tables only assuming platforms have an API to get specified OpenType tables as raw byte arrays. Hopefully other platforms can use the same code. CSS is going to define its own glyph orientation definitions, and

Re: [webkit-dev] The Care and Feeding of WebCore Modules

On Tue, Feb 28, 2012 at 5:46 PM, Kentaro Hara wrote: > >> So my answer to Maciej's second question: > >> > >>> 2) To what extent should Module-like techniques be applied to > non-Modules? > >> > >> is that "let us stop applying Module-like techniques to non-Modules, > >> until the modularization

Re: [webkit-dev] The Care and Feeding of WebCore Modules

>> So my answer to Maciej's second question: >> >>> 2) To what extent should Module-like techniques be applied to non-Modules? >> >> is that "let us stop applying Module-like techniques to non-Modules, >> until the modularization techniques mature well and the advantages of >> applying it become ob

Re: [webkit-dev] The Care and Feeding of WebCore Modules

On Tue, Feb 28, 2012 at 4:43 PM, Kentaro Hara wrote: > First of all, I am sorry we have done things too aggressively without > a community consensus. I'll stop committing patches until reaching a > consensus, and am happy to revert some patches that have already > committed. > > As Maciej pointed

Re: [webkit-dev] CSS properties vs. their JS bindings on the style object

See also this thread: Apparently this pattern works in Trident. Simon On Feb 28, 2012, at 5:14 PM, Simon Fraser wrote: > Yes, of which there is plenty. > > Simon > > On Feb 28, 2012, at 5:10 PM, Eric Seidel wrote: > >> It wou

Re: [webkit-dev] The Care and Feeding of WebCore Modules

Anecdotally, I think putting web intents into a module was clearer given the existing example of how that worked. A lot of the WebCore classes are large and intimidating. It was convenient to put the new feature in a Modules dir, especially when there was an example to follow to give some help as t

Re: [webkit-dev] CSS properties vs. their JS bindings on the style object

Yes, of which there is plenty. Simon On Feb 28, 2012, at 5:10 PM, Eric Seidel wrote: > It would have to be WebKit-only content, correct? > > On Tue, Feb 28, 2012 at 5:04 PM, Simon Fraser wrote: > On Feb 28, 2012, at 5:00 PM, Tom Zakrajsek wrote: > >> While investigating https://bugs.webkit.or

Re: [webkit-dev] Moving WTF out of JavaScriptCore

On 2012-02-28, at 17:11, Eric Seidel wrote: > I'm fine with Source/wtf. Very easy to implement. I think this has the potential to cause problems. It would lead to adding the Source directory to the header search path for some build systems, which would cause all sorts of weird #include styl

Re: [webkit-dev] Moving WTF out of JavaScriptCore

I'm fine with Source/wtf. Very easy to implement. On Tue, Feb 28, 2012 at 4:59 PM, Geoffrey Garen wrote: > My current plan is to have a WTF/wtf directory to avoid this exact issue. :) > > > "WTF/wtf" makes the think, "WTF?" -- which is a fun mental onomatopoeia, but > probably not a great design

Re: [webkit-dev] CSS properties vs. their JS bindings on the style object

It would have to be WebKit-only content, correct? On Tue, Feb 28, 2012 at 5:04 PM, Simon Fraser wrote: > On Feb 28, 2012, at 5:00 PM, Tom Zakrajsek wrote: > > While investigating https://bugs.webkit.org/show_bug.cgi?id=77427, Dave > and I have been trekking through the bindings code. > > Multiwor

Re: [webkit-dev] CSS properties vs. their JS bindings on the style object

On Feb 28, 2012, at 5:00 PM, Tom Zakrajsek wrote: > While investigating https://bugs.webkit.org/show_bug.cgi?id=77427, Dave and I > have been trekking through the bindings code. > > Multiword CSS property names are hyphen-delimited and lower-case, while the > equivalent JS binding names are c

[webkit-dev] CSS properties vs. their JS bindings on the style object

While investigating https://bugs.webkit.org/show_bug.cgi?id=77427, Dave and I have been trekking through the bindings code. Multiword CSS property names are hyphen-delimited and lower-case, while the equivalent JS binding names are camel-case. In the implementation, our binding code is actua

Re: [webkit-dev] Moving WTF out of JavaScriptCore

> My current plan is to have a WTF/wtf directory to avoid this exact issue. :) "WTF/wtf" makes the think, "WTF?" -- which is a fun mental onomatopoeia, but probably not a great design. Just plain "Source/wtf" looks better to me. > And to avoid the annoyance of 131 files in the root WTF director

Re: [webkit-dev] The Care and Feeding of WebCore Modules

First of all, I am sorry we have done things too aggressively without a community consensus. I'll stop committing patches until reaching a consensus, and am happy to revert some patches that have already committed. As Maciej pointed out, let us clarify > 1) What should be a Module? IMO, the feat

Re: [webkit-dev] Moving WTF out of JavaScriptCore

My current plan is to have a WTF/wtf directory to avoid this exact issue. :) And to avoid the annoyance of 131 files in the root WTF directory. I'm open to other suggestions if folks have them. -eric On Tue, Feb 28, 2012 at 3:59 PM, Mark Rowe wrote: > > On 2012-02-28, at 07:38, Osztrogonac Csa

Re: [webkit-dev] Moving WTF out of JavaScriptCore

2012/2/28 Mark Rowe : > > On 2012-02-28, at 07:38, Osztrogonac Csaba wrote: > >> Hi, >> >> I uploaded the necessary buildfix for Qt to the bugzilla: >> https://bugs.webkit.org/show_bug.cgi?id=79783 . >> >> Please be careful with moving JavaScriptCore/wtf to WTF, because we >> need zillion trivial

Re: [webkit-dev] Moving WTF out of JavaScriptCore

On 2012-02-28, at 07:38, Osztrogonac Csaba wrote: > Hi, > > I uploaded the necessary buildfix for Qt to the bugzilla: > https://bugs.webkit.org/show_bug.cgi?id=79783 . > > Please be careful with moving JavaScriptCore/wtf to WTF, because we > need zillion trivial fixes for case sensitive file

Re: [webkit-dev] Moving WTF out of JavaScriptCore

I'm going to push off the move, probably until next week. Thank you for the Qt patch! I'll post a patch for Mark and we can discuss further from there. -eric On Tue, Feb 28, 2012 at 7:38 AM, Osztrogonac Csaba wrote: > Hi, > > I uploaded the necessary buildfix for Qt to the bugzilla: > https://

Re: [webkit-dev] The Care and Feeding of WebCore Modules

On Tue, Feb 28, 2012 at 1:59 PM, Maciej Stachowiak wrote: > On Feb 28, 2012, at 12:20 PM, Adam Barth wrote: >> On Tue, Feb 28, 2012 at 11:52 AM, Maciej Stachowiak wrote: >>> But it seems like what is actually happening is wholesale rapid application >>> of this pattern to all of WebCore, includin

Re: [webkit-dev] The Care and Feeding of WebCore Modules

On Feb 28, 2012, at 12:20 PM, Adam Barth wrote: > On Tue, Feb 28, 2012 at 11:52 AM, Maciej Stachowiak wrote: >> But it seems like what is actually happening is wholesale rapid application >> of this pattern to all of WebCore, including even things that aren't in the >> Modules directory. So it's

Re: [webkit-dev] (no subject)

On Tue, Feb 28, 2012 at 10:58 AM, Ojan Vafai wrote: > On Mon, Feb 27, 2012 at 5:56 PM, Dirk Pranke wrote: >> >> Hi all, >> >> If you don't use webkit-patch and Git, you can stop reading now. Otherwise >> ... >> >> Currently, webkit-patch -g has some special logic for figuring out >> what to diff

Re: [webkit-dev] The Care and Feeding of WebCore Modules

On Tue, Feb 28, 2012 at 11:52 AM, Maciej Stachowiak wrote: > From the initial mail about modules, I got the (perhaps mistaken) impression > that it would be used only for selected features that had very loose > coupling and were perhaps not even of interest to every port. That seemed > like a fine

Re: [webkit-dev] The Care and Feeding of WebCore Modules

2012/2/28 Alexey Proskuryakov : > - separation of concerns seems incorrect (not all code with "WebSocket" in > the name is WebSocket code is the concern of engineers who solely focus on > WebSocket). Do you have a concrete example of this sort of code? It's easier to talk concretely about specifi

Re: [webkit-dev] The Care and Feeding of WebCore Modules

On Tue, Feb 28, 2012 at 11:52 AM, Maciej Stachowiak wrote: > But it seems like what is actually happening is wholesale rapid application > of this pattern to all of WebCore, including even things that aren't in the > Modules directory. So it's starting to seem more like a major restructuring > of

Re: [webkit-dev] The Care and Feeding of WebCore Modules

On Tue, Feb 28, 2012 at 11:24 AM, Maciej Stachowiak wrote: > One thing that would be helpful to add is an explanation of what types of > subsystems should be turned into Modules and what types should not. Also > advantages and disadvantages of turning a particular piece of code into a > Module.

Re: [webkit-dev] The Care and Feeding of WebCore Modules

28.02.2012, в 11:25, Darin Fisher написал(а): > Is this something the build system could help address? Perhaps a by-product > of the build is or could be a single file that contains everything that will > be exposed on WorkerContext / DOMWindow? Some of these concerns could be alleviated with

Re: [webkit-dev] The Care and Feeding of WebCore Modules

On Feb 28, 2012, at 11:25 AM, Darin Fisher wrote: > On Tue, Feb 28, 2012 at 11:11 AM, Alexey Proskuryakov wrote: > > Having read the wiki page, I'm even more unhappy with the approach that has > been taken than I used to be. In fact, it is harmful even to the goals of the > refactoring. > >

Re: [webkit-dev] The Care and Feeding of WebCore Modules

On Tue, Feb 28, 2012 at 11:11 AM, Alexey Proskuryakov wrote: > > Having read the wiki page, I'm even more unhappy with the approach that > has been taken than I used to be. In fact, it is harmful even to the goals > of the refactoring. > > If a single #ifdefed line in DOMWindow.idl is a burden fo

Re: [webkit-dev] The Care and Feeding of WebCore Modules

One thing that would be helpful to add is an explanation of what types of subsystems should be turned into Modules and what types should not. Also advantages and disadvantages of turning a particular piece of code into a Module. I think part of the confusion/controversy around these changes ma

Re: [webkit-dev] The Care and Feeding of WebCore Modules

Having read the wiki page, I'm even more unhappy with the approach that has been taken than I used to be. In fact, it is harmful even to the goals of the refactoring. If a single #ifdefed line in DOMWindow.idl is a burden for development, what about adding several new files to each and every b

Re: [webkit-dev] The Care and Feeding of WebCore Modules

The main issue isn't that the settings are large and unwieldy. I thought the point of the modularization effort was to enable partitioning of features. That means eliminating files that enumerate each feature. That said, we might still have classes that need to mention all features, so to addres

Re: [webkit-dev] (no subject)

On Mon, Feb 27, 2012 at 5:56 PM, Dirk Pranke wrote: > Hi all, > > If you don't use webkit-patch and Git, you can stop reading now. Otherwise > ... > > Currently, webkit-patch -g has some special logic for figuring out > what to diff against for Git checkouts. > > Specifically, webkit-patch "-g co

Re: [webkit-dev] The Care and Feeding of WebCore Modules

Yeah. I haven't studied the Settings issue carefully yet. If you look at patches that add a new setting, they need to add a ridiculous amount of boilerplate code, especially if they want to test the setting. Reducing this overhead seems valuable (whether by autogeneration or other means), especi

Re: [webkit-dev] RDF related stuff in WebKit.

I think many of us in the WebKit community are skeptical of the value of implementing RDFa on the client side, at least for now. The proposed API is rather complicated, the processing rules are quite complicated, and it's not clear there is demand for authors. HTML Microdata is a similar forma

Re: [webkit-dev] The Care and Feeding of WebCore Modules

"Let's auto generate it" doesn't logically follow from "it's getting large and unwieldy" to me. It seems that a better approach would be to figure out how to simplify Settings (do we still need them all?), and if we do, perhaps to break it up somehow. Simon On Feb 28, 2012, at 10:27 AM, Darin

Re: [webkit-dev] The Care and Feeding of WebCore Modules

Good idea! -Darin On Tue, Feb 28, 2012 at 8:46 AM, Adam Barth wrote: > We haven't done anything about Settings yet, but Setting is also kind > of growing out of control. My initial read is that we should try to > autogenerate Settings (and maybe some/all of the Settings-related > boilerplate in

[webkit-dev] RDF related stuff in WebKit.

Hi, I stumble across the RDF work in W3C. I was wondering if that make sense for WebKit. What WebKit could do with the semantic data extracted from the document? Feeding some underlaying indexing application? Or to help some application embedding WebKit but interested in extracting the data using

Re: [webkit-dev] The Care and Feeding of WebCore Modules

We haven't done anything about Settings yet, but Setting is also kind of growing out of control. My initial read is that we should try to autogenerate Settings (and maybe some/all of the Settings-related boilerplate in the WebKit layer) from an "in" file. Adam On Tue, Feb 28, 2012 at 7:40 AM, D

Re: [webkit-dev] 48459: Glyphs in vertical text tests are rotated 90 degrees clockwise on Windows

WebKitSystemInterface is owned by Apple. I would implement the fix without assuming that wkGetVerticalGlyphsForCharacters is available for Windows. Dave On Feb 26, 2012, at 4:46 AM, Koji Ishii wrote: > I found another library issue for how to get vertical alternate glyphs. > > Currently, >

Re: [webkit-dev] webkit

This account has been unsubscribed. Dave On Feb 25, 2012, at 6:57 PM, Eric Seidel wrote: > Please ban this spammer. > > On Sat, Feb 25, 2012 at 1:27 PM, Tyler Cumberton wrote: >> I have a question : webkit site >> >> -- >> -Tyler. >> >> ___ >> web

Re: [webkit-dev] The Care and Feeding of WebCore Modules

Nice. Is there a plan for modularizing Settings? On Feb 28, 2012 12:30 AM, "Adam Barth" wrote: > I wrote up a short wiki page explaining how the modules system works > and how to use it when building new features: > > https://trac.webkit.org/wiki/Modules > > We've been making good progress refac

Re: [webkit-dev] Moving WTF out of JavaScriptCore

Hi, I uploaded the necessary buildfix for Qt to the bugzilla: https://bugs.webkit.org/show_bug.cgi?id=79783 . Please be careful with moving JavaScriptCore/wtf to WTF, because we need zillion trivial fixes for case sensitive file systems. (~4000 files!!!) I made it locally to be able prepare th

Re: [webkit-dev] (no subject)

Hi Dirk, On Mon, 2012-02-27 at 17:56 -0800, Dirk Pranke wrote: > 1) Do you use "-g foo" to upload a single change? Yes, it's pretty much the only way I use it. > If so, would you be > annoyed if I changed that syntax to a different argument That would be fine. > , or > eliminated it complete

[webkit-dev] The Care and Feeding of WebCore Modules

I wrote up a short wiki page explaining how the modules system works and how to use it when building new features: https://trac.webkit.org/wiki/Modules We've been making good progress refactoring some existing features to use the system. This refactoring both improves the hackability of WebCore