Re: [webkit-dev] cr-linux-ews migration

2012-07-13 Thread Adam Barth
The cr-linux-ews migration seems to have gone well. I'm now migrating the commit-queue. Please let me know if you notice any problems. Thanks! Adam On Mon, Jul 2, 2012 at 12:32 AM, Adam Barth aba...@webkit.org wrote: Hi webkit-dev, I've moved the cr-linux-ews from EC2 to Google Compute

Re: [webkit-dev] Updates on Chromium's content_shell

2012-07-13 Thread Adam Barth
want to join the effort later can read it up? In general, I agree with your proposal. I guess starting with something small like EventSender might be a good first step. best -jochen On Fri, Jul 13, 2012 at 10:20 PM, Adam Barth aba...@webkit.org wrote: On Fri, Jul 13, 2012 at 1:10 PM

Re: [webkit-dev] Updates on Chromium's content_shell

2012-07-13 Thread Adam Barth
On Fri, Jul 13, 2012 at 2:15 PM, Darin Fisher da...@chromium.org wrote: On Fri, Jul 13, 2012 at 2:10 PM, Adam Barth aba...@webkit.org wrote: Yeah, EventSender is likely a good place to start. Here are some more details about what I had in mind: 1) We'll need to create a new target

Re: [webkit-dev] Updates on Chromium's content_shell

2012-07-13 Thread Adam Barth
On Fri, Jul 13, 2012 at 2:24 PM, Adam Barth aba...@webkit.org wrote: On Fri, Jul 13, 2012 at 2:15 PM, Darin Fisher da...@chromium.org wrote: On Fri, Jul 13, 2012 at 2:10 PM, Adam Barth aba...@webkit.org wrote: Yeah, EventSender is likely a good place to start. Here are some more details

Re: [webkit-dev] Web APIs and class name collisions

2012-07-12 Thread Adam Barth
One common thing we do is prefix DOM to DOM-level concepts. For example, DOMWindow and DOMFileSystem. I'm not sure if we have an established convention for CSS-level concepts. Adam On Thu, Jul 12, 2012 at 9:18 AM, Andrei Bucur abu...@adobe.com wrote: Hello Webkittens! While implementing

Re: [webkit-dev] New feature flag: ENABLE_CSS_POSITION_STICKY

2012-07-11 Thread Adam Barth
Yes. Thanks for holding off for a bit. :) Adam On Wed, Jul 11, 2012 at 11:03 AM, Simon Fraser simon.fra...@apple.comwrote: I think we've resolved our differences around the fixed position scrolling issues, so that's OK. Simon On Jun 27, 2012, at 6:38 PM, Adam Barth aba...@webkit.org

Re: [webkit-dev] C++ unit tests for WebKit?

2012-07-11 Thread Adam Barth
Generally speaking, WebKit's testing philosophy is to test at API boundaries, typically either a given port's WebKit API or the web platform API. The benefit of that approach is that it makes it easier for us to refactor the internals of WebCore without being constrained by fragile tests---only

Re: [webkit-dev] C++ unit tests for WebKit?

2012-07-11 Thread Adam Barth
. Adam From: Adam Barth aba...@webkit.org To: Hans Muller hmul...@adobe.com Cc: Benjamin Poulain benja...@webkit.org, Konrad Piascik kpias...@rim.com, webkit-dev webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] C++ unit tests for WebKit? Generally speaking, WebKit's testing philosophy

[webkit-dev] iOS parsing of the viewport meta tag

2012-07-10 Thread Adam Barth
Hi webkit-dev, I'm working on the following bug: Parse the viewport meta tag like iOS https://bugs.webkit.org/show_bug.cgi?id=72722 Is the parsing code for the viewport meta tag in iOS open source? If not, would it be possible for someone from Apple with access to the source to contribute it

Re: [webkit-dev] iOS parsing of the viewport meta tag

2012-07-10 Thread Adam Barth
On Tue, Jul 10, 2012 at 9:16 AM, David Kilzer ddkil...@webkit.org wrote: On Jul 10, 2012, at 8:48 AM, Adam Barth wrote: Parse the viewport meta tag like iOS https://bugs.webkit.org/show_bug.cgi?id=72722 Is the parsing code for the viewport meta tag in iOS open source? It's on http

Re: [webkit-dev] Removing BUILDING_ON / TARGETING macros in favor of system availability macros

2012-07-10 Thread Adam Barth
Tony and Mark (Mentovai) would know more, but I believe the Chromium port uses these macros in order to build against a specific SDK. For example, the Chromium port currently builds against the 10.5 SDK. (This is slated to change shortly as the Chromium project has dropped support for 10.5.)

Re: [webkit-dev] lineNumber() and textPosition() methods in HTMLDocumentParser

2012-07-04 Thread Adam Barth
They can probably be combined. It's done this way because there are other subclasses of DocumentParser besides HTMLDocumentParser. I'm not sure it's a big deal either way. Adam On Tue, Jul 3, 2012 at 9:28 PM, KwangYul Seo sk...@company100.net wrote: Hi. I have a question regarding

[webkit-dev] cr-linux-ews migration

2012-07-02 Thread Adam Barth
Hi webkit-dev, I've moved the cr-linux-ews from EC2 to Google Compute Engine. In the process, I've doubled the capacity. If you notice anything wonky, please let me know. If this transition goes well, I'll move the commit-queue (and expand its capacity) as well. Happy hacking! Adam

Re: [webkit-dev] Let's use only 'ENABLE_CUSTOM_SCHEME_HANDLER' flag, and remove 'ENABLE_REGISTER_PROTOCOL_HANDLER' flag.

2012-06-28 Thread Adam Barth
According to http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/features.gypi, Chromium currently enables REGISTER_PROTOCOL_HANDLER but not CUSTOM_SCHEME_HANDLER. Until the Chromium project decides to ship CUSTOM_SCHEME_HANDLER, having two ENABLE flags is valuable. Please do not

Re: [webkit-dev] Let's use only 'ENABLE_CUSTOM_SCHEME_HANDLER' flag, and remove 'ENABLE_REGISTER_PROTOCOL_HANDLER' flag.

2012-06-28 Thread Adam Barth
is likely why Chromium has the feature disabled. Adam On Thu, Jun 28, 2012 at 8:06 AM, Adam Barth aba...@webkit.org wrote: According to http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/features.gypi, Chromium currently enables REGISTER_PROTOCOL_HANDLER

Re: [webkit-dev] New feature flag: ENABLE_CSS_POSITION_STICKY

2012-06-27 Thread Adam Barth
There seems to be some amount of controversy at the moment regarding how we should implement scrolling and fixed position elements. As long as that discussion doesn't drag on too long, we might want to let the dust settle a bit before moving forward with new features in this area. Adam On Tue,

Re: [webkit-dev] [PATCH] Errors from build-webkit --debug --minimal

2012-06-25 Thread Adam Barth
Hopefully this email won't come off as rude, but it's not clear to me whether the WinCE port being actively developed. http://trac.webkit.org/wiki/WinCE says that the port is maintained by Torch Mobile, but http://www.torchmobile.com/ says Torch Mobile is focused on BlackBerry these days. Looking

Re: [webkit-dev] Issue regarding Same Origin check with Blobs and XMLHttpRequest

2012-06-19 Thread Adam Barth
[webkit-dev - bcc] What URL are you trying to load? The error message doesn't say. I wonder if you're trying to load a relative URL, which is trying to be resolved relative to the blob URL. It might work better with an absolute URL. Adam On Thu, May 10, 2012 at 1:32 AM, Vishal Shah

Re: [webkit-dev] Feature announcement: Content-Security-Policy 1.1

2012-06-17 Thread Adam Barth
On Sun, Jun 17, 2012 at 1:35 AM, Mike West mk...@chromium.org wrote: On Fri, May 4, 2012 at 3:13 AM, Adam Barth aba...@webkit.org wrote: As CSP 1.1 matures (both in specification and implementation), I plan to upstream the csp11 branch using this meta bug: https://bugs.webkit.org/show_bug.cgi

Re: [webkit-dev] EditBugs permission

2012-06-15 Thread Adam Barth
Done. Folks should feel free to ping me on #webkit rather than emailing webkit-dev abou this sort of thing. Adam On Fri, Jun 15, 2012 at 12:03 PM, Pablo Flouret pab...@motorola.com wrote: Hey, Could i get EditBugs for my bugzilla account? (pab...@motorola.com) I'm not a commiter, but i've

Re: [webkit-dev] TestExpectations syntax changes, last call (for a while, at least) ...

2012-06-14 Thread Adam Barth
On Thu, Jun 14, 2012 at 4:22 PM, Maciej Stachowiak m...@apple.com wrote: On Jun 14, 2012, at 1:47 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Jun 14, 2012 at 1:44 PM, Peter Kasting pkast...@chromium.org wrote: On Thu, Jun 14, 2012 at 1:39 PM, Elliot Poger epo...@chromium.org wrote: Can

Re: [webkit-dev] IMAGE+TEXT WAS: TestExpectations syntax changes, last call (for a while, at least) ...

2012-06-14 Thread Adam Barth
On Thu, Jun 14, 2012 at 8:56 PM, Ojan Vafai o...@chromium.org wrote: On Thu, Jun 14, 2012 at 4:34 PM, Dirk Pranke dpra...@chromium.org wrote: On Thu, Jun 14, 2012 at 4:22 PM, Maciej Stachowiak m...@apple.com wrote: On Jun 14, 2012, at 1:47 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Jun

Re: [webkit-dev] IMAGE+TEXT WAS: TestExpectations syntax changes, last call (for a while, at least) ...

2012-06-14 Thread Adam Barth
On Thu, Jun 14, 2012 at 9:02 PM, Ojan Vafai o...@chromium.org wrote: On Thu, Jun 14, 2012 at 9:00 PM, Adam Barth aba...@webkit.org wrote: On Thu, Jun 14, 2012 at 8:56 PM, Ojan Vafai o...@chromium.org wrote: On Thu, Jun 14, 2012 at 4:34 PM, Dirk Pranke dpra...@chromium.org wrote: On Thu

Re: [webkit-dev] malloc(0)

2012-06-12 Thread Adam Barth
There was some discussion about how to handle malloc(0) a year or so ago. I don't remember if it was on webkit-dev, but you might want to check the archives. Eric Seidel might remember what conclusions (if any) we came to. Adam On Tue, Jun 12, 2012 at 3:03 PM, Myles C. Maxfield

Re: [webkit-dev] Adding nonstandard features (was Re: Adding ENABLE_NAVIGATOR_BUILDTYPE to WebCore)

2012-06-11 Thread Adam Barth
On Mon, Jun 11, 2012 at 6:29 PM, Maciej Stachowiak m...@apple.com wrote: On Jun 7, 2012, at 1:10 PM, Adam Barth aba...@webkit.org wrote: On Thu, Jun 7, 2012 at 1:00 PM, Ryosuke Niwa rn...@webkit.org wrote: On Wed, Jun 6, 2012 at 1:51 PM, Annie Sullivan sulli...@chromium.org wrote: I wanted

Re: [webkit-dev] can we stop using Skipped files?

2012-06-10 Thread Adam Barth
On Sun, Jun 10, 2012 at 4:54 AM, Balazs Kelemen kbal...@webkit.org wrote: So the unit tests are superfluous. In particular, if I had to pick between only having unit tests or only having regression tests, I might pick unit tests. But if I already have regression tests then I'm unlikely to

Re: [webkit-dev] EditBugs permissions for bugs.webkit.org account

2012-06-07 Thread Adam Barth
Done. On Thu, Jun 7, 2012 at 8:35 AM, Simon Pena sp...@igalia.com wrote: Hi, I'd like to request EditBugs permissions to be added to my bugs.webkit.org account (spena at igalia.com) I'm not a committer, but I have worked on several patches already, mainly for the GTK port. Thanks in

Re: [webkit-dev] Adding ENABLE_NAVIGATOR_BUILDTYPE to WebCore

2012-06-07 Thread Adam Barth
On Thu, Jun 7, 2012 at 11:48 AM, Konstantin Tokarev annu...@yandex.ru wrote: 07.06.2012, 21:07, Annie Sullivan sulli...@chromium.org: Oops, forgot to reply-all. On Thu, Jun 7, 2012 at 9:05 AM, Annie Sullivan sulli...@chromium.org wrote: On Wed, Jun 6, 2012 at 4:59 PM, Darin Adler

Re: [webkit-dev] Adding ENABLE_NAVIGATOR_BUILDTYPE to WebCore

2012-06-07 Thread Adam Barth
On Thu, Jun 7, 2012 at 12:53 PM, Annie Sullivan sulli...@chromium.org wrote: On Thu, Jun 7, 2012 at 3:43 PM, Dean Jackson d...@apple.com wrote: On 07/06/2012, at 12:05 PM, Annie Sullivan sulli...@chromium.org wrote: In many browsers in the past, it's been pretty easy to determine from a and b

Re: [webkit-dev] Adding ENABLE_NAVIGATOR_BUILDTYPE to WebCore

2012-06-07 Thread Adam Barth
On Thu, Jun 7, 2012 at 1:00 PM, Ryosuke Niwa rn...@webkit.org wrote: On Wed, Jun 6, 2012 at 1:51 PM, Annie Sullivan sulli...@chromium.org wrote: I wanted to let you know that I plan to add support for navigator.buildType (e.g., nightly, beta, final) to WebKit. This feature isn't on the

Re: [webkit-dev] Renaming DumpRenderTree to WebKitTestRunner or merging those two

2012-06-04 Thread Adam Barth
On Mon, Jun 4, 2012 at 10:51 AM, Sam Weinig wei...@apple.com wrote: On Jun 3, 2012, at 6:10 PM, Ryosuke Niwa rn...@webkit.org wrote: On Sun, Jun 3, 2012 at 6:01 PM, Adam Barth aba...@webkit.org wrote: On Sun, Jun 3, 2012 at 5:54 PM, Ryosuke Niwa rn...@webkit.org wrote: On Sun, Jun 3, 2012

Re: [webkit-dev] Renaming DumpRenderTree to WebKitTestRunner or merging those two

2012-06-03 Thread Adam Barth
On Sun, Jun 3, 2012 at 5:54 PM, Ryosuke Niwa rn...@webkit.org wrote: On Sun, Jun 3, 2012 at 5:33 PM, Maciej Stachowiak m...@apple.com wrote: On Jun 3, 2012, at 8:05 PM, Ryosuke Niwa rn...@webkit.org wrote: On Sun, Jun 3, 2012 at 3:55 PM, Maciej Stachowiak m...@apple.com wrote: I am on

Re: [webkit-dev] Renaming DumpRenderTree to WebKitTestRunner or merging those two

2012-06-02 Thread Adam Barth
We might also want to define the layoutTestController object with IDL so we don't have to hand-write bindings every time we change it. Using IDL for window.internals seems to have worked out well. It would be nice to replicate that success with layoutTestController. Adam On Sat, Jun 2, 2012 at

Re: [webkit-dev] Device and page scaling

2012-06-01 Thread Adam Barth
I've posted a patch to remove target-densitydpi: https://bugs.webkit.org/show_bug.cgi?id=88047 There's some concern that target-densitydpi is used by some apps that are bundled with Android, but folks appear willing to deprecate the feature and to migrate those apps to using other mechanisms,

Re: [webkit-dev] Adding ENABLE_HTML_MEDIA_CAPTURE to WebCore

2012-06-01 Thread Adam Barth
On Fri, Jun 1, 2012 at 2:39 AM, Anssi Kostiainen anssi.kostiai...@nokia.com wrote: Hi Adam, On 10.5.2012, at 14.20, ext Anssi Kostiainen wrote: On 9.5.2012, at 23.22, ext Adam Barth wrote: Thanks.  I just have two pieces of feedback: 1) As far as I know, we don't have any plans to implement

[webkit-dev] Removing target-densitydpi (was Re: Device and page scaling)

2012-06-01 Thread Adam Barth
From: webkit-dev-boun...@lists.webkit.org [webkit-dev-boun...@lists.webkit.org] on behalf of Adam Barth [aba...@webkit.org] Sent: Friday, June 01, 2012 2:21 AM To: Maciej Stachowiak Cc: kenn...@webkit.org; webkit-dev@lists.webkit.org Subject: Re: [webkit-dev

Re: [webkit-dev] [webkit-changes] [119113] trunk/Source/WebKit/gtk

2012-05-31 Thread Adam Barth
+mrobinson Looks like the odd ChangeLog was in a patch uploaded by mrobinson: https://bugs.webkit.org/attachment.cgi?id=143171action=review Adam On Thu, May 31, 2012 at 1:43 PM, Dan Bernstein m...@apple.com wrote: On May 31, 2012, at 9:36 AM, commit-qu...@webkit.org wrote:

[webkit-dev] Settings::devicePixelRatio and Settings::defaultDeviceScaleFactor

2012-05-31 Thread Adam Barth
Is there any difference between Settings::devicePixelRatio [1] and Settings::defaultDeviceScaleFactor [2] ? They appear to be used by disjoint sets of ports. Shall we delete one in favor of the other? Adam [1] http://trac.webkit.org/browser/trunk/Source/WebCore/page/Settings.h#L478 [2]

Re: [webkit-dev] Settings::devicePixelRatio and Settings::defaultDeviceScaleFactor

2012-05-31 Thread Adam Barth
be obtained from the platform code in WebCore/WebKit, or pushed in via API. Simon On May 31, 2012, at 3:48 PM, Adam Barth wrote: Is there any difference between Settings::devicePixelRatio [1] and Settings::defaultDeviceScaleFactor [2] ?  They appear to be used by disjoint sets of ports.  Shall

Re: [webkit-dev] Device and page scaling

2012-05-30 Thread Adam Barth
On Wed, May 30, 2012 at 12:08 AM, Kenneth Rohde Christiansen kenneth.christian...@gmail.com wrote: I don't think we are doing that much differently. Desktop Safari is scaling directly in WebCore using the pageScaleFactor whereas Qt like iOS scales outside of WebCore (using a tiled backing

Re: [webkit-dev] Block 3rd part cookies implementation

2012-05-29 Thread Adam Barth
On Tue, May 29, 2012 at 10:55 AM, Giorgio Mazzucchelli giorgio@gmail.com wrote: Thank you for replying me and for your suggestions. Through trac, I a looking up for the class (not sure if technically speaking is a class): FirstPartyForCookies It compares in many files: how to

Re: [webkit-dev] Block 3rd part cookies implementation

2012-05-29 Thread Adam Barth
This list is not the appropriate forum for your questions. Adam On May 29, 2012 11:39 AM, Giorgio Mazzucchelli giorgio@gmail.com wrote: Is the mechanism of handling 3rd part cookies by WebKit documented somewhere? Not directly referring to source code. Giorgio

[webkit-dev] Device and page scaling

2012-05-29 Thread Adam Barth
There's a lot of confusion in the code base about how page and device scaling works. Different ports are using Page::deviceScaleFactor for incompatible purposes. On Mac, Page::deviceScaleFactor represents the actual scaling factor of the physical device. It can change over time because a given

Re: [webkit-dev] Device and page scaling

2012-05-29 Thread Adam Barth
On Tue, May 29, 2012 at 7:03 PM, Fady Samuel fsam...@chromium.org wrote: This sounds good to me, but is there any reason why we can't support physical device changes (switching monitors) and support target-densitydpi? This would be highly desirable for us. We can support that. We just need to

Re: [webkit-dev] Device and page scaling

2012-05-29 Thread Adam Barth
/show_bug.cgi?id=87407. The short answer is that they will be keyed off of Page::deviceScaleFactor, which means they won't be affected by changes to the target-densitydpi. Adam - Original Message - From: Adam Barth [mailto:aba...@webkit.org] Sent: Tuesday, May 29, 2012 10:10 PM To: Fady

Re: [webkit-dev] Block 3rd part cookies implementation

2012-05-22 Thread Adam Barth
On Tue, May 22, 2012 at 12:29 PM, Giorgio Mazzucchelli giorgio@gmail.com wrote: Is Safari's privacy option, which allows users to block 3rd part cookies, implemented in WebKit or in the browser itself? Any code reference would be very helpful. Parts are implemented in WebKit and parts

Re: [webkit-dev] Regarding cr-linux bot and the test failure

2012-05-14 Thread Adam Barth
Have you tried building Chromium locally? That's likely to be a tighter debugging loop than using the bot. There are instructions on the wiki: http://trac.webkit.org/wiki/Chromium Adam On Mon, May 14, 2012 at 3:18 AM, Vivek Galatage vivekgalat...@gmail.com wrote: Hello Webkit-dev, I am

Re: [webkit-dev] A more detailed source tree overview

2012-05-14 Thread Adam Barth
Unfortunately, the information in WebKitSourceLayout.md is much too detailed. It contains many facts that happen to be true at this moment, but are likely to change at any moment. It's unlikely that we'll keep this documentation up to date, which means it's just going to get stale and perhaps

Re: [webkit-dev] Issue regarding Same Origin check with Blobs and XMLHttpRequest

2012-05-11 Thread Adam Barth
Just to close the loop on this topic, I spoke with Vishal off-list and we figured out the problem. Thanks everyone. Adam On Thu, May 10, 2012 at 1:32 AM, Vishal Shah vis...@sokrati.com wrote: Hello, I have implemented a web worker that handles XMLHttpRequest object for my application When

Re: [webkit-dev] spamming the developer console

2012-05-11 Thread Adam Barth
On Fri, May 11, 2012 at 2:21 PM, Ojan Vafai o...@chromium.org wrote: The amount of spam we throw in the developer console has grown quite a bit. spam == things logged to the console that web developers have no control over Unlike uncaught javascript exceptions (which can easily just be

Re: [webkit-dev] spamming the developer console

2012-05-11 Thread Adam Barth
On Fri, May 11, 2012 at 2:29 PM, Ojan Vafai o...@chromium.org wrote: On Fri, May 11, 2012 at 2:25 PM, Adam Barth aba...@webkit.org wrote: On Fri, May 11, 2012 at 2:21 PM, Ojan Vafai o...@chromium.org wrote: The amount of spam we throw in the developer console has grown quite a bit. spam

Re: [webkit-dev] Adding ENABLE_HTML_MEDIA_CAPTURE to WebCore

2012-05-09 Thread Adam Barth
Jongseok, Did you get around to contributing your patch? I've uploaded a work-in-progress implementation of one part of the spec here: https://bugs.webkit.org/show_bug.cgi?id=85958 Thanks, Adam On Sun, Feb 19, 2012 at 9:36 PM, JongSeok Yang js45.y...@samsung.com wrote: It's unrelated to

Re: [webkit-dev] Adding ENABLE_HTML_MEDIA_CAPTURE to WebCore

2012-05-09 Thread Adam Barth
That's a good question. I happened upon this feature because it's implemented in Chrome on Android, and we want to fully merge Chrome on Android's WebKit with upstream. Adam On Wed, May 9, 2012 at 1:44 AM, TAMURA, Kent tk...@chromium.org wrote: I wonder if the standardization is active.  Even

Re: [webkit-dev] Adding ENABLE_HTML_MEDIA_CAPTURE to WebCore

2012-05-09 Thread Adam Barth
On Wed, May 9, 2012 at 1:12 PM, Anssi Kostiainen anssi.kostiai...@nokia.com wrote: On 9.5.2012, at 11.44, ext TAMURA, Kent wrote: I wonder if the standardization is active.  Even the editor's draft has not been updated for one year. Good that you ask -- the spec has been waiting for

[webkit-dev] Feature announcement: Content-Security-Policy 1.1

2012-05-03 Thread Adam Barth
Hi webkit-dev, Content-Security-Policy 1.0 is nearing Working Group Last Call in the W3C WebAppSec working group. Over the next few weeks, I'm going to polish up our implementation of CSP 1.0 to match the final specification. Our implementation is quite close to the spec, so these changes

Re: [webkit-dev] Following up on removing -khtml- and -apple- CSS vendor prefixes

2012-05-03 Thread Adam Barth
vendor prefixes To: Adam Barth aba...@webkit.org Cc: Alexey Proskuryakov a...@webkit.org, webkit-dev@lists.webkit.org On Fri, Apr 6, 2012 at 4:27 PM, Adam Barth aba...@webkit.org wrote: 2012/4/5 Alexey Proskuryakov a...@webkit.org: 05.04.2012, в 01:08, Adam Barth написал(а): Based

Re: [webkit-dev] Feature Announcement: Adding iframe seamless

2012-05-02 Thread Adam Barth
On Wed, May 2, 2012 at 12:11 PM, Maciej Stachowiak m...@apple.com wrote: On May 2, 2012, at 11:48 AM, Jarred Nicholls jar...@webkit.org wrote: On Wed, May 2, 2012 at 2:03 PM, Maciej Stachowiak m...@apple.com wrote: On May 2, 2012, at 6:14 AM, Jarred Nicholls jar...@webkit.org wrote: On Tue,

Re: [webkit-dev] Feature Announcement: Adding iframe seamless

2012-05-01 Thread Adam Barth
On Tue, May 1, 2012 at 3:50 PM, Maciej Stachowiak m...@apple.com wrote: On May 1, 2012, at 3:31 PM, Eric Seidel e...@webkit.org wrote: Is your goal to be able to disable the feature to prevent a late-known security issue? Or is your goal to universally disable seamless for a port entirely?

[webkit-dev] Maciej's prefixing questions (was Re: webkitPostMessage)

2012-05-01 Thread Adam Barth
On Sun, Apr 29, 2012 at 7:33 PM, Maciej Stachowiak m...@apple.com wrote: In the longer term, here's a few things we should think about: - Historically, we've almost never removed prefixed versions of features that get promoted to unprefixed. The marginal maintenance cost is low and there's

Re: [webkit-dev] Using GitHub to Contribute to WebKit (Experimental)

2012-04-29 Thread Adam Barth
On Tue, Apr 24, 2012 at 6:14 AM, Adam Roben aro...@webkit.org wrote: On Fri, Mar 16, 2012 at 5:40 PM, Adam Barth aba...@webkit.org wrote: On Fri, Mar 16, 2012 at 2:32 PM, Ryosuke Niwa rn...@webkit.org wrote: Can we do some Bugzilla integration as Jarred suggested? If you're excited about

Re: [webkit-dev] github mirror

2012-04-29 Thread Adam Barth
Tor, I think we should retire the author rewriting script on GitHub. Jame's is right that there's a lot of value in having git.webkit.org and GitHub using the same hashes. For example, both Eric and Gavin requested that when they started using GitHub. We would have some trouble adopting the

Re: [webkit-dev] webkitPostMessage

2012-04-29 Thread Adam Barth
, Adam Barth aba...@webkit.org wrote: I'm trying to understand why we have both DOMWindow.webkitPostMessage and DOMWindow.postMessage.  I'm also trying to understand the following comment in {JS,V8}DOMWindowCustom.cpp:    // This function has variable arguments and can be:    // Per current spec

Re: [webkit-dev] webkitPostMessage

2012-04-29 Thread Adam Barth
behavior, but if you wish to try this, I don't know of any big reason not to. Ok, I'll make these changes in separate patches in case either causes trouble down the line. Thanks! Adam On Sun, Apr 29, 2012 at 11:01 AM, Adam Barth aba...@webkit.org wrote: I read https://trac.webkit.org/wiki

Re: [webkit-dev] webkitPostMessage

2012-04-29 Thread Adam Barth
On Sun, Apr 29, 2012 at 12:34 PM, Maciej Stachowiak m...@apple.com wrote: On Apr 29, 2012, at 11:01 AM, Adam Barth aba...@webkit.org wrote: I read https://trac.webkit.org/wiki/DeprecatingFeatures, but I'm still unsure how to proceed with removing webkitPostMessage and aligning postMessage

Re: [webkit-dev] webkitPostMessage

2012-04-29 Thread Adam Barth
On Sun, Apr 29, 2012 at 1:06 PM, Maciej Stachowiak m...@apple.com wrote: On Apr 29, 2012, at 12:53 PM, Ryosuke Niwa rn...@webkit.org wrote: On Sun, Apr 29, 2012 at 12:34 PM, Maciej Stachowiak m...@apple.com wrote: On Apr 29, 2012, at 11:01 AM, Adam Barth aba...@webkit.org wrote: I read

Re: [webkit-dev] webkitPostMessage

2012-04-29 Thread Adam Barth
On Sun, Apr 29, 2012 at 2:25 PM, Maciej Stachowiak m...@apple.com wrote: On Apr 29, 2012, at 1:35 PM, Adam Barth aba...@webkit.org wrote: There is very little cost on the WebKit project to maintain webkitPostMessage in addition to postMessage. Instead, supporting webkitPostMessage imposes

Re: [webkit-dev] webkitPostMessage

2012-04-11 Thread Adam Barth
[+dslomov] I found a thread on public-webapps that seems related to this question. Dmitry, do you know what current status is here? I'd like to make sure we're on a path towards interoperability with other browsers. Thanks, Adam On Tue, Apr 10, 2012 at 9:08 PM, Adam Barth aba...@webkit.org

[webkit-dev] webkitPostMessage

2012-04-10 Thread Adam Barth
I'm trying to understand why we have both DOMWindow.webkitPostMessage and DOMWindow.postMessage. I'm also trying to understand the following comment in {JS,V8}DOMWindowCustom.cpp: // This function has variable arguments and can be: // Per current spec: // postMessage(message,

Re: [webkit-dev] Is it OK to remove Frame::setIsDisconnected() and isDisconnected() ?

2012-04-09 Thread Adam Barth
On Wed, Apr 15, 2009 at 2:21 PM, Maciej Stachowiak m...@apple.com wrote: On Apr 15, 2009, at 1:29 PM, Sverrir Á. Berg wrote: Hi Adam, Thanks for the links.  These are simply exposing the functions as a formal a API's.  I understand that you typically don't want to change externally exposed

Re: [webkit-dev] Is it OK to remove Frame::setIsDisconnected() and isDisconnected() ?

2012-04-09 Thread Adam Barth
On Mon, Apr 9, 2012 at 3:24 PM, Maciej Stachowiak m...@apple.com wrote: On Apr 9, 2012, at 12:27 PM, Adam Barth wrote: On Wed, Apr 15, 2009 at 2:21 PM, Maciej Stachowiak m...@apple.com wrote: On Apr 15, 2009, at 1:29 PM, Sverrir Á. Berg wrote: Hi Adam, Thanks for the links.  These are simply

Re: [webkit-dev] Following up on removing -khtml- and -apple- CSS vendor prefixes

2012-04-06 Thread Adam Barth
2012/4/5 Alexey Proskuryakov a...@webkit.org: 05.04.2012, в 01:08, Adam Barth написал(а): Based on this information, I've posted a patch that limits the -apple- and -khtml- vendor prefixes to ENABLE(DASHBOARD_SUPPORT): https://bugs.webkit.org/show_bug.cgi?id=83256 This approach lets ports

[webkit-dev] List of prefixed APIs in WebKit

2012-04-06 Thread Adam Barth
As you might be aware, there's been some amount of debate in the browser community recently about the use of vendor prefixes in the web platform. I'm sure many of you have opinions on this topic, but rather than triggering a long thread about this topic, I'd like to start by gathering some data

[webkit-dev] Following up on removing -khtml- and -apple- CSS vendor prefixes

2012-04-05 Thread Adam Barth
In July 2010, there was a thread on webkit-dev about removing support for the -khtml- and -apple- vendor prefixes: https://lists.webkit.org/pipermail/webkit-dev/2010-July/013519.html At the time, we tried an approach recommended by David Hyatt

Re: [webkit-dev] Following up on removing -khtml- and -apple- CSS vendor prefixes

2012-04-05 Thread Adam Barth
, 2012 10:14 AM, Alexey Proskuryakov a...@webkit.org wrote: 05.04.2012, в 01:08, Adam Barth написал(а): Based on this information, I've posted a patch that limits the -apple- and -khtml- vendor prefixes to ENABLE(DASHBOARD_SUPPORT): https://bugs.webkit.org/show_bug.cgi?id=83256

Re: [webkit-dev] Following up on removing -khtml- and -apple- CSS vendor prefixes

2012-04-05 Thread Adam Barth
Proskuryakov a...@webkit.org wrote: 05.04.2012, в 01:08, Adam Barth написал(а): Based on this information, I've posted a patch that limits the -apple- and -khtml- vendor prefixes to ENABLE(DASHBOARD_SUPPORT): https://bugs.webkit.org/show_bug.cgi?id=83256 This approach lets ports that wish

Re: [webkit-dev] Following up on removing -khtml- and -apple- CSS vendor prefixes

2012-04-05 Thread Adam Barth
(Previous email got cut off) ...release blocking bugs. On Apr 5, 2012 2:25 PM, Adam Barth aba...@webkit.org wrote: One option is to start evaluating the compat implications by disabling the prefixes in Chrome. If we have a positive experience we can disable them in more ports/configurations

Re: [webkit-dev] XSSAuditor Bypass Question

2012-03-31 Thread Adam Barth
The XSS auditor isn't able to detect injections into script contexts. Sometimes it will catch these sorts of injections by accident, but often there's a way to bypass the auditor in these scenarios. The auditor is much better at catching injections in attribute values and between tags. The IE

[webkit-dev] [Chromium] Changing how WebKit interfaces with Chromium

2012-03-31 Thread Adam Barth
tl;dr: We're changing how WebKit interfaces with Chromium. This email describes what we're changing and why. If you've not interested in the Chromium port, you should feel free to skip this message. == Overview == Chromium is removing the PlatformSupport abstraction. Platform support exists

[webkit-dev] Feature Announcement: Adding iframe srcdoc

2012-03-30 Thread Adam Barth
Per http://www.webkit.org/coding/adding-features.html I'm working on adding iframe srcdoc support to WebKit: http://www.whatwg.org/specs/web-apps/current-work/#dom-iframe-srcdoc. Because I'm enamored with GitHub at the moment, I'm working on the feature on a branch:

Re: [webkit-dev] Hosting the webkitgtk.org site on svn.webkit.org

2012-03-27 Thread Adam Barth
By a new top-level directory, do you mean a peer to trunk and branches? If so, I'm not sure expected about that prospect. It sort of goes against the normal layout of SVN repositories. We already have http://trac.webkit.org/browser/trunk/Websites, which would seem like the natural place to put

Re: [webkit-dev] Throwing SECURITY_ERR on cross-origin window.location property accesses

2012-03-26 Thread Adam Barth
I've started a thread on whatwg in case folks with like to discuss this topic further: http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-March/035188.html Thanks, Adam On Thu, Mar 22, 2012 at 9:21 PM, Adam Barth aba...@webkit.org wrote: I wonder if we could expose the parent document's

Re: [webkit-dev] Throwing SECURITY_ERR on cross-origin window.location property accesses

2012-03-23 Thread Adam Barth
That's a risk, but you could also worry that the name would leak in the iframe's document.referrer property. Adam On Mar 23, 2012 12:02 PM, David Levin le...@chromium.org wrote: On Thu, Mar 22, 2012 at 9:21 PM, Adam Barth aba...@webkit.org wrote: I wonder if we could expose the parent

Re: [webkit-dev] UPDATED Re: Version control survey

2012-03-22 Thread Adam Barth
On Sat, Mar 10, 2012 at 12:49 PM, Maciej Stachowiak m...@apple.com wrote: I made a bad choice of survey site. They want to charge me to see more than 100 responses or to export the data, but they won't take my money. Sadness. Please try this survey instead, it will run through the 17th. The

Re: [webkit-dev] Throwing SECURITY_ERR on cross-origin window.location property accesses

2012-03-22 Thread Adam Barth
I wonder if we could expose the parent document's origin, so you could write the check as follows: if (parent.location.origin != location.origin) return; It's slightly subtle because we wouldn't want to expose the origin of child frames (then you could probe the redirect structure of private

Re: [webkit-dev] ChangeLogs

2012-03-21 Thread Adam Barth
On Wed, Mar 21, 2012 at 3:45 PM, Timothy Hatcher timo...@apple.com wrote: On Mar 21, 2012, at 2:46 PM, Adam Barth wrote: On Wed, Mar 21, 2012 at 2:29 PM, Timothy Hatcher timo...@apple.com wrote: Lately I have observed more and more and more changes going into WebKit that lack any details about

Re: [webkit-dev] Magic Iframe removal proposed

2012-03-20 Thread Adam Barth
Yeah, normally I would have waited longer, but the patch fixed a crash in WebKit2 that was making the bots red. There was a discussion in another bug (sorry, don't have the link handy) where folks graciously held off fixing the crash, and I didn't want them to wait any longer than necessary.

Re: [webkit-dev] Upstreaming Support for W3C Sensor API

2012-03-16 Thread Adam Barth
The specification appears to be here: http://dvcs.w3.org/hg/dap/raw-file/tip/sensor-api/Overview.html Has this specification reached FPWD yet? http://www.w3.org/TR/sensor/ returns a 404. Adam 2012/3/16 Dominik Röttsches dominik.rottsc...@linux.intel.com: Hello webkit-dev, We would like to

Re: [webkit-dev] Using GitHub to Contribute to WebKit (Experimental)

2012-03-16 Thread Adam Barth
On Fri, Mar 16, 2012 at 12:20 PM, John Yani van...@gmail.com wrote: On 16 March 2012 18:34, Ryosuke Niwa rn...@webkit.org wrote: If some reviewer and committer decide to use this process, where can I see review comments and other discussions? See point 3  of Landing your code. Reviewer adds a

Re: [webkit-dev] Using GitHub to Contribute to WebKit (Experimental)

2012-03-16 Thread Adam Barth
On Fri, Mar 16, 2012 at 12:41 PM, Ariya Hidayat ariya.hida...@gmail.com wrote: See point 3  of Landing your code. Reviewer adds a link to pull request  in changelog. But now it means I have to search in two places: Bugzilla and Github, in case I want to look up some past issues/problems.

Re: [webkit-dev] Upstreaming Support for W3C Sensor API

2012-03-16 Thread Adam Barth
the WebKit community without being blocked on merging your feature into trunk. Adam 2012/3/16 Adam Barth aba...@webkit.org: The specification appears to be here: http://dvcs.w3.org/hg/dap/raw-file/tip/sensor-api/Overview.html Has this specification reached FPWD yet?  http://www.w3.org/TR/sensor

Re: [webkit-dev] Using GitHub to Contribute to WebKit (Experimental)

2012-03-16 Thread Adam Barth
On Fri, Mar 16, 2012 at 2:32 PM, Ryosuke Niwa rn...@webkit.org wrote: Can we do some Bugzilla integration as Jarred suggested? If you're excited about using GitHub, you should feel free to do that work. Note: I'm not advocating for the use of GitHub. I'm just documenting a way that

Re: [webkit-dev] WebKitIDL syntax: unsigned int

2012-03-15 Thread Adam Barth
I recommend posting a patch and getting the appropriate folks to review it rather than emailing all of webkit-dev for such a small detail. Adam On Thu, Mar 15, 2012 at 10:34 AM, Seo Sanghyeon sanx...@gmail.com wrote: unsigned int is an invalid Type in WebIDL.

[webkit-dev] Using GitHub to Contribute to WebKit (Experimental)

2012-03-15 Thread Adam Barth
Hi webkit-dev, After reading last week's discussion about switching the project to git, I wondered if it would be possible to get some of the benefits of git-style development without forcing everyone to switch to git. One of the benefits of git-style development is the ability to review a

Re: [webkit-dev] Removing Custom bindings for type array.

2012-03-14 Thread Adam Barth
It looks like you're getting some good comments on the bug. Thanks for working on removing custom bindings code. Adam On Wed, Mar 14, 2012 at 5:30 AM, Vineet Chaudhary rgf...@motorola.com wrote: Hi All, I am trying to remove the custom bindings for the type Array.(ref : Bug 80696) Below

Re: [webkit-dev] Separating ENABLE(NOTIFICATIONS) and ENABLE(LEGACY_NOTIFICATIONS)

2012-03-12 Thread Adam Barth
That sounds like a good approach. Chromium will likely need to remember to disable NOTIFICATIONS on any upcoming release branches (until the work is complete). Adam On Mon, Mar 12, 2012 at 6:58 PM, Jon Lee jon...@apple.com wrote: Hi WebKit! In order to ease the migration path for the

Re: [webkit-dev] exporting symbols for building .so/.dll's

2012-03-11 Thread Adam Barth
On Sun, Mar 11, 2012 at 10:49 AM, Ami Fischman fisch...@chromium.org wrote: I'm inclined to give this thread one more business day and then call it Tuesday morning pacific time. On current showing I think the approach in the patch on the bug (incl. morrita@'s preference for

Re: [webkit-dev] exporting symbols for building .so/.dll's

2012-03-11 Thread Adam Barth
On Sun, Mar 11, 2012 at 11:13 AM, Adam Barth aba...@webkit.org wrote: On Sun, Mar 11, 2012 at 10:49 AM, Ami Fischman fisch...@chromium.org wrote: I'm inclined to give this thread one more business day and then call it Tuesday morning pacific time. On current showing I think the approach

Re: [webkit-dev] exporting symbols for building .so/.dll's

2012-03-11 Thread Adam Barth
On Sun, Mar 11, 2012 at 5:16 PM, Ami Fischman fisch...@chromium.org wrote: Adam wrote: I'm not sure I understand your proposal fully.  Specifically, how would these macros work for, say, the Chromium, Apple-Mac, and Apple-Win ports, which export overlapping, but not identical, sets of symbols?

Re: [webkit-dev] Test conversion to use W3C testharness.js

2012-03-09 Thread Adam Barth
I looked at the patch you uploaded, but it wasn't clear from the text dump whether the subtests passed or failed. Maybe testharness.js uses a table and/or colors to present that information? It's important that we can easily determine which subtests pass or fail from a text dump. Adam On Fri,

Re: [webkit-dev] Test conversion to use W3C testharness.js

2012-03-09 Thread Adam Barth
output.  Since we are dumping as text, that isn't possible, but other customizations in testharnessreport.js are.  I will look into this further. On 3/9/12 3:21 PM, Adam Barth aba...@webkit.org wrote: I looked at the patch you uploaded, but it wasn't clear from the text dump whether

<    1   2   3   4   5   6   7   8   9   10   >