[webkit-dev] Reminder: include everything that you use in implementation files

, reducing developer velocity. And obviosuly it's super annoying to encounter completely unrelated build failures that must be nonetheless addressed. Let's all do our part so that hacking on WebKit remains delightful. Thanks, Brian Burg (he/they)  WebKit Developer Experience

Re: [webkit-dev] Transitioning commit-queue to new EWS and deprecating old EWS

Awesome! Thanks for your hard work on WebKit CI and EWS! -Brian > On Mar 18, 2020, at 12:12 PM, Aakash Jain wrote: > > Hello Everyone, > > I have transitioned commit-queue from old EWS to new EWS. This was the last > queue on old EWS. I will soon start deleting old EWS code from the

Re: [webkit-dev] Tools/TestWebKitAPI

I am in favor of a top-level Tests directory which would contain the various *Tests/ directories within it. Any relative directory paths (i.e.,

Re: [webkit-dev] Don Olmstead and Ross Kirsling are now WebKit reviewers

Congrats everyone! > On Dec 13, 2018, at 1:46 PM, Fujii Hironori wrote: > > Hi everyone, > > I would like to announce that Don Olmstead (dolmstead on #webkit) and > Ross Kirsling (rkirsling) are now WebKit reviewers. They have worked > on WinCairo port and PlayStation port, and Ross worked on

Re: [webkit-dev] WebKit support in web-platform-tests

Hi Zan! > On Feb 12, 2018, at 7:06 AM, z...@falconsigh.net wrote: > > Hi, > > the web-platform-tests repository includes tooling that enables running those > tests against a supported browser product. I'd like to propose adding generic > WebKit support there. > > > Current changes only

Re: [webkit-dev] Formatting style for inline comments in Python code

> 2017/10/26 午前9:21、Alexey Proskuryakov のメール: > > > >> 25 окт. 2017 г., в 18:21, Michael Catanzaro > > написал(а): >> >> On Wed, Oct 25, 2017 at 4:58 PM, Aakash Jain >

Re: [webkit-dev] Formatting style for inline comments in Python code

In this case, I always prefer the PEP8 rules, because check-webkit-style will complain if you don't do so. Brian > 2017/10/25 午後0:13、Aakash Jain のメール: > > Hi All, > > There is one case in which Webkit style guidelines and Python style > guidelines do not match. This is

[webkit-dev] WEB_SOCKETS enabled on all ports - let's remove the flag

Hi WebKittens, In WebKit, the Web Sockets API is guarded by the ENABLE_WEB_SOCKETS feature flag. It seems that ENABLE_WEB_SOCKETS is turned on for Xcode and CMake build systems by default for several years on all ports. I think it’s time to remove the feature flag. Are there any objections?

[webkit-dev] WEB_TIMING enabled on all ports - let's remove the flag?

Hi WebKittens, In WebKit, the various web-exposed timing APIs–Resource Timing, User Timing, and Navigation Timing are guarded by the ENABLE_WEB_TIMING feature flag. It seems that ENABLE_WEB_TIMING is turned on for Xcode and CMake build systems by default, and we have not experienced any

Re: [webkit-dev] Another WPT bite

> On May 12, 2017, at 7:31 PM, Alexey Proskuryakov wrote: > >> >> 12 мая 2017 г., в 16:12, Sam Weinig > > написал(а): >> >> >> >>> On May 12, 2017, at 2:49 PM, Alexey Proskuryakov >> >

Re: [webkit-dev] Another WPT bite

> On May 12, 2017, at 2:10 PM, Simon Fraser wrote: > >> >> On May 12, 2017, at 12:04 PM, Alexey Proskuryakov > > wrote: >> >> >>> 12 мая 2017 г., в 11:52, Ben Kelly >> >

Re: [webkit-dev] Proposal to limit the size of the captured exception stack

> On Mar 16, 2017, at 10:09 PM, Mark Lam wrote: > > Hi folks, > > Currently, if we have an exception stack that is incredibly deep (especially > for a StackOverflowError), JSC may end up thrashing memory just to capture > the large stack trace in memory.This is bad

Re: [webkit-dev] ReadMe.md on Github

> On Feb 21, 2017, at 10:53 PM, Ryosuke Niwa wrote: > > Hi, > > I recently added ReadMe.md file to WebKit's top-level directory for the > convenience of Github users: https://github.com/WebKit/webkit > > > I've added a very abridged

Re: [webkit-dev] On Mac and iOS ports, you may need to trigger clean rebuilds after r203337

It was reproducible for me, but I nuked my build directory and moved on. Looking at the Makefile, it seems we don't prefix the bindings files with $(WEBCORE) so it might not even be looking at the right files. Let's continue investigation here: https://bugs.webkit.org/show_bug.cgi?id=160031 >

Re: [webkit-dev] RFC: stop using std::chrono, go back to using doubles for time

+1 to Michael’s point. Naming of variables holding seconds/milliseconds is all over the place. So, I would favor using Seconds/WallTime/MonotonicTime classes, since they will basically guarantee that the variable name and/or type will describe the units near use-sites and avoid ambiguity. Not

Re: [webkit-dev] WebKit project repo size

Hi Marcus, It’s unclear what your actual problem is. If you have trouble downloading 7GB at once due to a slow or flaky connection, you can fetch earlier git commits to finish the initial repository checkout, and then fetch more commits in batches. If you just want a subset of the

Re: [webkit-dev] Proposal: Use #pragma once instead of header guards

Cool! It sounds like something good for new headers and drive-by cleanups, to start. To clarify, it would always go after the license block? Is the pragma name stable and understandable enough to paste everywhere? -Brian > On Mar 9, 2016, at 17:27, Anders Carlsson

Re: [webkit-dev] CC on reviewed bugs

The only reason that normal commenting will CC you is that the [X] Add me to CC list is checked by default. I agree it would be reasonable to duplicate that behavior when commenting via the review tool. To do this, you’d have to modify “sub update()” in attachment.cgi, and pass in some new

[webkit-dev] Use the 'EasyFix' and 'GoodFirstBug' Bugzilla keywords to mentor WebKit newcomers!

Hello WebKittens, At the WebKit contributors meeting, we held a session to brainstorm ways to increase the size of the WebKit community. (You can see our notes on the wiki: http://trac.webkit.org/wiki/November%202015%20Meeting ) One thing

Re: [webkit-dev] Preferred style for checking for undefined in our built-in JavaScript code?

Web Inspector’s frontend code tends to use “x === undefined”, as we’ve found it the easiest to read. > On Nov 30, 2015, at 11:57 AM, Geoffrey Garen wrote: > > For the time being, I like “x === undefined”. > > Long term, I’d like us to switch to “x === @undefined”. > > We

[webkit-dev] OUTAGE: Bugzilla not sending emails properly

Hi all, We’ve been getting reports that Bugzilla has not sent any mail out in the past 24 hours. :-( The server admins are investigating what’s up and will send out an email when it’s fixed. -Brian ___ webkit-dev mailing list

Re: [webkit-dev] OUTAGE: Bugzilla not sending emails properly

After some debugging and fixing, Bugzilla email seems to be working again. We apologize for the disruption! > On Nov 17, 2015, at 10:07 AM, Brian Burg <bb...@apple.com> wrote: > > Hi all, > > We’ve been getting reports that Bugzilla has not sent any mail out in

Re: [webkit-dev] Youenn Fablet is now a WebKit reviewer

Congrats Youenn! > On Oct 26, 2015, at 19:15, Mark Lam wrote: > > Hello everyone, > > I would like to announce that Youenn Fablet is now a WebKit reviewer. Please > send him your congratulations, and some requests for patch reviews too. :-) > > Youenn, congratulations. >

Re: [webkit-dev] [webkit-help] Issue with Web Inspector debugger breakpoint handling (on Wincairo)

If this reproduces on tip-of-tree WinCairo in the WebKit repository, then you should file a Web Inspector/WinCairo bug in Bugzilla and continue this discussion there. I really have no way of knowing what’s going on just by reading these steps. You could also try reaching the relevant folks on

Re: [webkit-dev] Bugzilla default assignees

It should be possible for an administrator to set a component's default assignee and default cc: list. We use the default-cc approach for the Web Inspector component (though it often goes out of date). However, the default assignee approach seems nice from a self-service POV, and we don’t seem

Re: [webkit-dev] Fwd: *.webkit.org network issues

Possibly related, bugs.webkit.org http://bugs.webkit.org/ was timing out and returning HTTP 500 internal server errors over the weekend (from Comcast). It works for me now, though. On May 18, 2015, at 10:00 AM, Ryosuke Niwa rn...@webkit.org wrote: On Mon, May 18, 2015 at 9:03 AM,

Re: [webkit-dev] Planning on Requiring Python 2.7 Soon

IIRC, some GTK bots still run Python 2.6. (But not all of them?) Here’s a relevant workaround I landed a while ago: http://trac.webkit.org/changeset/172686 On Sep 10, 2014, at 4:31 PM, Brent Fulgham bfulg...@apple.com wrote: Hi Everyone, Now that I’ve worked through the minor issues that

[webkit-dev] Announcement: web replay support

Hello all, I’m excited to announce that I’ve begun work on upstreaming web replay support into WebKit. Web replay functionality allows developers to debug their web applications by exactly recording interactions with a web program, and then replaying the resulting execution at will. A

Re: [webkit-dev] Announcement: web replay support

: On 1/13/14, 4:03 PM, Brian Burg wrote: I’m excited to announce that I’ve begun work on upstreaming web replay support into WebKit. Web replay functionality allows developers to debug their web applications by exactly recording interactions with a web program, and then replaying the resulting