Re: [webkit-dev] Plan to move TypedArray out of WebGL feature guard

2010-12-23 Thread Chris Marrin
On Dec 22, 2010, at 5:34 PM, Jian Li wrote: Hi, TypedArray has been used in some non-WebGL areas, like File API and XHR. It would be nice if we move it out of WebGL feature guard. Any objection? It would probably be best if it had its own guard. Then its various users could turn it on in

Re: [webkit-dev] Plan to move TypedArray out of WebGL feature guard

2010-12-23 Thread Jian Li
Sounds like a good idea. I am going to add TYPED_ARRAY guard for this. Thanks, Jian On Thu, Dec 23, 2010 at 8:13 AM, Chris Marrin cmar...@apple.com wrote: On Dec 22, 2010, at 5:34 PM, Jian Li wrote: Hi, TypedArray has been used in some non-WebGL areas, like File API and XHR. It would

Re: [webkit-dev] Plan to move TypedArray out of WebGL feature guard

2010-12-23 Thread Mo, Zhenyao
Just make sure if WebGL is on, TypedArray is always there. Mo On Thu, Dec 23, 2010 at 10:23 AM, Jian Li jia...@chromium.org wrote: Sounds like a good idea. I am going to add TYPED_ARRAY guard for this. Thanks, Jian On Thu, Dec 23, 2010 at 8:13 AM, Chris Marrin cmar...@apple.com wrote: On

Re: [webkit-dev] Plan to move TypedArray out of WebGL feature guard

2010-12-23 Thread Chris Marrin
On Dec 23, 2010, at 11:01 AM, Darin Adler wrote: Yes, we want correct conditionals, and TypedArray should not be in the WebGL feature guard if it’s used in other features. Adding a feature new guard would not be good if it has to be set explicitly. It would be much better if the build

Re: [webkit-dev] Plan to move TypedArray out of WebGL feature guard

2010-12-23 Thread Jian Li
Currently the definition of TypedArray is guarded by ENABLE(3D_CANVAS) || ENABLE(BLOB). It has been used in the following features: - WebGL - File API: FileReader and BlobBuilder - XMLHttpRequest: send and response We do not add an additional check expression when TypedArray is added to

Re: [webkit-dev] Plan to move TypedArray out of WebGL feature guard

2010-12-23 Thread Darin Adler
On Dec 23, 2010, at 11:17 AM, Chris Marrin wrote: Is there any reason for it NOT to be unguarded? If this was used in any unconditional feature we wouldn’t need this discussion. Generally speaking we don’t want to put new DOM classes into WebKit that are there to support new features if the

Re: [webkit-dev] Plan to move TypedArray out of WebGL feature guard

2010-12-23 Thread Darin Adler
On Dec 23, 2010, at 11:21 AM, Jian Li wrote: We do not add an additional check expression when TypedArray is added to XHR. Is the TypedArray support in XHR a feature in its own right? Should it be off by default or is it ready to be on for all versions of WebKit? -- Darin

Re: [webkit-dev] Plan to move TypedArray out of WebGL feature guard

2010-12-23 Thread Jian Li
Currently it is guarded by the same guarding expression. CC Chris who implemented this feature since he knows whether it is ready all versions or not. On Thu, Dec 23, 2010 at 11:23 AM, Darin Adler da...@apple.com wrote: On Dec 23, 2010, at 11:21 AM, Jian Li wrote: We do not add an

Re: [webkit-dev] Plan to move TypedArray out of WebGL feature guard

2010-12-23 Thread Maciej Stachowiak
It should probably have its own feature define. It doesn't really make sense to have ArrayBuffer support in XHR only if you have either WebGL or File support. Regards, Maciej On Dec 23, 2010, at 12:29 PM, Jian Li wrote: Currently it is guarded by the same guarding expression. CC Chris who

Re: [webkit-dev] Plan to move TypedArray out of WebGL feature guard

2010-12-23 Thread Chris Marrin
On Dec 23, 2010, at 11:23 AM, Darin Adler wrote: On Dec 23, 2010, at 11:21 AM, Jian Li wrote: We do not add an additional check expression when TypedArray is added to XHR. Is the TypedArray support in XHR a feature in its own right? Should it be off by default or is it ready to be on

Re: [webkit-dev] Plan to move TypedArray out of WebGL feature guard

2010-12-23 Thread Chris Marrin
On Dec 23, 2010, at 1:47 PM, Charles Pritchard wrote: You need to have Blobs for ArrayBuffer to be of much use for XHR, because you need to be able to set the Content-Type, and browsers may/will fiddle with the content-type header you set, if you have not passed a Blob. Blobs are defined

Re: [webkit-dev] Plan to move TypedArray out of WebGL feature guard

2010-12-23 Thread Darin Adler
On Dec 23, 2010, at 2:04 PM, Chris Marrin wrote: How would we go about feeling comfortable about the security risk? The point isn’t the security risk, but rather the security risk with no benefit. It’s OK to make this class unconditional unless there is someone planning to ship WebKit that

[webkit-dev] Plan to move TypedArray out of WebGL feature guard

2010-12-22 Thread Jian Li
Hi, TypedArray has been used in some non-WebGL areas, like File API and XHR. It would be nice if we move it out of WebGL feature guard. Any objection? Thanks, Jian ___ webkit-dev mailing list webkit-dev@lists.webkit.org