[webkit-dev] Using Google-URL in WebKit

2008-10-02 Thread Brett Wilson
About a year ago, Google released the Google URL Parsing and Canonicalization Library (Google-URL) as a separate open-source project: http://code.google.com/p/google-url It was developed for Chromium with an eye toward being used in other client apps at Google and elsewhere. We think there are a

Re: [webkit-dev] Using Google-URL in WebKit

2008-10-02 Thread David Hyatt
Kind of an unrelated note, but it would be nice to rename KURL to something else e.g., WebCoreURL, URL, WebURL, etc. dave On Oct 2, 2008, at 3:07 PM, Brett Wilson wrote: About a year ago, Google released the Google URL Parsing and Canonicalization Library (Google-URL) as a separate

Re: [webkit-dev] Using Google-URL in WebKit

2008-10-02 Thread Alex Iskander
WURL? Short, but has the required letters -- though perhaps sounds too funny. Alex On Oct 2, 2008, at 3:10 PM, David Hyatt wrote: Kind of an unrelated note, but it would be nice to rename KURL to something else e.g., WebCoreURL, URL, WebURL, etc. dave On Oct 2, 2008, at 3:07 PM,

Re: [webkit-dev] Using Google-URL in WebKit

2008-10-02 Thread Brett Wilson
On Thu, Oct 2, 2008 at 1:13 PM, Alex Iskander [EMAIL PROTECTED] wrote: WURL? Short, but has the required letters -- though perhaps sounds too funny. We're using GURL which is pretty funny! Brett ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] Using Google-URL in WebKit

2008-10-02 Thread Peter Kasting
On Thu, Oct 2, 2008 at 2:23 PM, Maciej Stachowiak [EMAIL PROTECTED] wrote: I consider the option of completely replacing WebKit's URL implementation with an external dependency to be a nonstarter. Assume that we wound up in a world where GURL formed the basis of the WebKit URL

Re: [webkit-dev] Using Google-URL in WebKit

2008-10-02 Thread David Hyatt
It's kind of ridiculous to have an external dependency on a piece of code this tiny. dave On Oct 2, 2008, at 4:41 PM, Peter Kasting wrote: On Thu, Oct 2, 2008 at 2:23 PM, Maciej Stachowiak [EMAIL PROTECTED] wrote: I consider the option of completely replacing WebKit's URL implementation

Re: [webkit-dev] Using Google-URL in WebKit

2008-10-02 Thread Darin Fisher
On Thu, Oct 2, 2008 at 2:23 PM, Maciej Stachowiak [EMAIL PROTECTED] wrote: On Oct 2, 2008, at 1:07 PM, Brett Wilson wrote: About a year ago, Google released the Google URL Parsing and Canonicalization Library (Google-URL) as a separate open-source project:

Re: [webkit-dev] Using Google-URL in WebKit

2008-10-02 Thread Maciej Stachowiak
On Oct 2, 2008, at 2:41 PM, Peter Kasting wrote: On Thu, Oct 2, 2008 at 2:23 PM, Maciej Stachowiak [EMAIL PROTECTED] wrote: I consider the option of completely replacing WebKit's URL implementation with an external dependency to be a nonstarter. Assume that we wound up in a world where GURL

Re: [webkit-dev] Using Google-URL in WebKit

2008-10-02 Thread Maciej Stachowiak
On Oct 2, 2008, at 2:53 PM, Darin Fisher wrote: I agree that it would be very nice to share implementations here. One thing I'd like to highlight: It is a requirement for Chromium to use consistent URL parsing throughout the entire application. This includes all processes, the

Re: [webkit-dev] Using Google-URL in WebKit

2008-10-02 Thread Geoffrey Garen
One thing I'd like to highlight: It is a requirement for Chromium to use consistent URL parsing throughout the entire application. Can you explain this requirement more? I think that's an important data point, since other WebKit ports, including the Mac port, use KURL in WebKit and a

Re: [webkit-dev] Using Google-URL in WebKit

2008-10-02 Thread Darin Fisher
On Thu, Oct 2, 2008 at 3:01 PM, Geoffrey Garen [EMAIL PROTECTED] wrote: One thing I'd like to highlight: It is a requirement for Chromium to use consistent URL parsing throughout the entire application. Can you explain this requirement more? I think that's an important data point, since

Re: [webkit-dev] Using Google-URL in WebKit

2008-10-02 Thread Darin Fisher
On Thu, Oct 2, 2008 at 3:27 PM, David Hyatt [EMAIL PROTECTED] wrote: On Oct 2, 2008, at 4:23 PM, Maciej Stachowiak wrote: I have mentioned optionally replacing KURL with an ifdef to a number of WebKit members. The reception has been tentatively yes. As one of the people who were asked

Re: [webkit-dev] Using Google-URL in WebKit

2008-10-02 Thread David Hyatt
On Oct 2, 2008, at 5:35 PM, Darin Fisher wrote: On Thu, Oct 2, 2008 at 3:27 PM, David Hyatt [EMAIL PROTECTED] wrote: On Oct 2, 2008, at 4:23 PM, Maciej Stachowiak wrote: I have mentioned optionally replacing KURL with an ifdef to a number of WebKit members. The reception has been

Re: [webkit-dev] Using Google-URL in WebKit

2008-10-02 Thread Maciej Stachowiak
On Oct 2, 2008, at 3:43 PM, David Hyatt wrote: On Oct 2, 2008, at 5:35 PM, Darin Fisher wrote: On Thu, Oct 2, 2008 at 3:27 PM, David Hyatt [EMAIL PROTECTED] wrote: On Oct 2, 2008, at 4:23 PM, Maciej Stachowiak wrote: I have mentioned optionally replacing KURL with an ifdef to a number

Re: [webkit-dev] Using Google-URL in WebKit

2008-10-02 Thread Geoffrey Garen
KURL depends on WebCore types, and was found to have bugs, so Brett did a study of other URL parsers and wrote the Google URL library as a template library (and wrote GURL as an example class using it with std::string). This part I don't get. Brett found some bugs. Why didn't he fix them?

Re: [webkit-dev] Using Google-URL in WebKit

2008-10-02 Thread Peter Kasting
On Thu, Oct 2, 2008 at 3:49 PM, Maciej Stachowiak [EMAIL PROTECTED] wrote: I would rather we seriously look at a way to unfork the URL parsing code, before discussing mechanics of how to keep it forked. We don't normally put ifdef paths in core code in WebKit that the WebKit project is not

Re: [webkit-dev] Using Google-URL in WebKit

2008-10-02 Thread Darin Fisher
On Thu, Oct 2, 2008 at 3:43 PM, David Hyatt [EMAIL PROTECTED] wrote: On Oct 2, 2008, at 5:35 PM, Darin Fisher wrote: On Thu, Oct 2, 2008 at 3:27 PM, David Hyatt [EMAIL PROTECTED] wrote: On Oct 2, 2008, at 4:23 PM, Maciej Stachowiak wrote: I have mentioned optionally replacing KURL with

Re: [webkit-dev] Using Google-URL in WebKit

2008-10-02 Thread Darin Fisher
On Thu, Oct 2, 2008 at 3:53 PM, Geoffrey Garen [EMAIL PROTECTED] wrote: KURL depends on WebCore types, and was found to have bugs, so Brett did a study of other URL parsers and wrote the Google URL library as a template library (and wrote GURL as an example class using it with std::string).