Re: [webkit-dev] XHR responseArrayBuffer attribute

2010-09-28 Thread Chris Marrin
On Sep 27, 2010, at 6:37 PM, Maciej Stachowiak wrote: On Sep 27, 2010, at 3:19 PM, Michael Nordman wrote: Webkit's XHR currently does not keep two copies of the data that I can see. I think we should avoid that. We could keep the raw data around, which hopefully is directly usable as

Re: [webkit-dev] XHR responseArrayBuffer attribute

2010-09-28 Thread Chris Marrin
On Sep 27, 2010, at 6:40 PM, James Robinson wrote: On Mon, Sep 27, 2010 at 6:37 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 27, 2010, at 3:19 PM, Michael Nordman wrote: Webkit's XHR currently does not keep two copies of the data that I can see. I think we should avoid that. We

Re: [webkit-dev] X-Purpose on prefetching requests

2010-09-28 Thread 蓋文彼德斯
Noone has commented on this thread in some time; is this less controversial now? On 24 September 2010 21:27, Alexey Proskuryakov a...@webkit.org wrote: Eric has made another good point in Bugzilla - we don't explain the purpose in lots of other cases, from loading into a display:none frame to

Re: [webkit-dev] X-Purpose on prefetching requests

2010-09-28 Thread Alexey Proskuryakov
28.09.2010, в 07:58, Gavin Peters (蓋文彼德斯) написал(а): Noone has commented on this thread in some time; is this less controversial now? I've presented some concerns about the effect of this on enterprise network monitors. It it also not really clear what the benefits of the proposed

Re: [webkit-dev] X-Purpose on prefetching requests

2010-09-28 Thread 蓋文彼德斯
On 28 September 2010 11:58, Alexey Proskuryakov a...@webkit.org wrote: 28.09.2010, в 07:58, Gavin Peters (蓋文彼德斯) написал(а): Noone has commented on this thread in some time; is this less controversial now? I've presented some concerns about the effect of this on enterprise network

Re: [webkit-dev] X-Purpose on prefetching requests

2010-09-28 Thread 蓋文彼德斯
Forgive the second follow up, I want to just clarify something. See below. On 28 September 2010 11:58, Alexey Proskuryakov a...@webkit.org wrote: I've presented some concerns about the effect of this on enterprise network monitors. I've thought about this some more, and and I think I don't

Re: [webkit-dev] XHR responseArrayBuffer attribute

2010-09-28 Thread Maciej Stachowiak
On Sep 28, 2010, at 7:15 AM, Chris Marrin wrote: On Sep 27, 2010, at 6:37 PM, Maciej Stachowiak wrote: On Sep 27, 2010, at 3:19 PM, Michael Nordman wrote: Webkit's XHR currently does not keep two copies of the data that I can see. I think we should avoid that. We could keep the

Re: [webkit-dev] Ruby Text Enhancements

2010-09-28 Thread David Hyatt
On Sep 27, 2010, at 3:40 PM, Eric Mader wrote: Are you saying that subclassing computeLogicalWidth() would still mean that I'm computing the margins at the initial calculation time? You'd be computing them whenever the ruby run's layout changed. The problem with that is if you're

Re: [webkit-dev] XHR responseArrayBuffer attribute

2010-09-28 Thread Chris Marrin
On Sep 28, 2010, at 9:45 AM, Maciej Stachowiak wrote: On Sep 28, 2010, at 7:15 AM, Chris Marrin wrote: On Sep 27, 2010, at 6:37 PM, Maciej Stachowiak wrote: On Sep 27, 2010, at 3:19 PM, Michael Nordman wrote: Webkit's XHR currently does not keep two copies of the data that I can

Re: [webkit-dev] Ruby Text Enhancements

2010-09-28 Thread Yasuo Kida
On 2010/09/28, at 10:11, David Hyatt wrote: On Sep 27, 2010, at 3:40 PM, Eric Mader wrote: Are you saying that subclassing computeLogicalWidth() would still mean that I'm computing the margins at the initial calculation time? You'd be computing them whenever the ruby run's layout changed.

Re: [webkit-dev] XHR responseArrayBuffer attribute

2010-09-28 Thread Kenneth Russell
On Tue, Sep 28, 2010 at 9:45 AM, Maciej Stachowiak m...@apple.com wrote: On Sep 28, 2010, at 7:15 AM, Chris Marrin wrote: On Sep 27, 2010, at 6:37 PM, Maciej Stachowiak wrote: On Sep 27, 2010, at 3:19 PM, Michael Nordman wrote: Webkit's XHR currently does not keep two copies of the data

Re: [webkit-dev] XHR responseArrayBuffer attribute

2010-09-28 Thread Maciej Stachowiak
On Sep 28, 2010, at 11:05 AM, Kenneth Russell wrote: On Tue, Sep 28, 2010 at 9:45 AM, Maciej Stachowiak m...@apple.com wrote: On Sep 28, 2010, at 7:15 AM, Chris Marrin wrote: On Sep 27, 2010, at 6:37 PM, Maciej Stachowiak wrote: On Sep 27, 2010, at 3:19 PM, Michael Nordman wrote:

Re: [webkit-dev] X-Purpose on prefetching requests

2010-09-28 Thread Alexey Proskuryakov
28.09.2010, в 9:43, Gavin Peters (蓋文彼德斯) написал(а): I've presented some concerns about the effect of this on enterprise network monitors. I've thought about this some more, and and I think I don't get this actually. Could you clarify for me? I think that it changes false positives to

Re: [webkit-dev] Ruby Text Enhancements

2010-09-28 Thread Eric Mader
On Sep 28, 2010, at 7:11 AM, David Hyatt wrote: The ruby element allows one or more spans of phrasing content to be marked with ruby annotations. * That the text for the ruby text and ruby base are always the direct child of the RenderRubyText and RenderRubyBase object. I doubt that's

Re: [webkit-dev] X-Purpose on prefetching requests

2010-09-28 Thread Adam Barth
2010/9/28 Alexey Proskuryakov a...@webkit.org: 28.09.2010, в 9:43, Gavin Peters (�w文彼德斯) написал(а): I've presented some concerns about the effect of this on enterprise network monitors. I've thought about this some more, and and I think I don't get this actually. Could you clarify for me?

Re: [webkit-dev] X-Purpose on prefetching requests

2010-09-28 Thread Adam Barth
I guess I don't understand your perspective. Are you arguing that prefetch is a misfeature and folks should use image tags instead? That doesn't really make sense to me. For example, using an explicit prefect API means the prefetch gets properly prioritized and doesn't delay the load event.

[webkit-dev] Should we recommend explicit constructors as part of WebKit style?

2010-09-28 Thread David Levin
This came up before: https://lists.webkit.org/pipermail/webkit-dev/2010-May/012873.html but I'd like to understand it a bit better. It feels there were two points of view: 1. Use explicit only when necessary to prevent an undesirable implicit conversion like int to vector. 2. Use

Re: [webkit-dev] Should we recommend explicit constructors as part of WebKit style?

2010-09-28 Thread Darin Fisher
On Tue, Sep 28, 2010 at 4:26 PM, David Levin le...@google.com wrote: This came up before: https://lists.webkit.org/pipermail/webkit-dev/2010-May/012873.html but I'd like to understand it a bit better. It feels there were two points of view: 1. Use explicit only when necessary to prevent

Re: [webkit-dev] Should we recommend explicit constructors as part of WebKit style?

2010-09-28 Thread Maciej Stachowiak
On Sep 28, 2010, at 4:26 PM, David Levin wrote: This came up before: https://lists.webkit.org/pipermail/webkit-dev/2010-May/012873.html but I'd like to understand it a bit better. It feels there were two points of view: Use explicit only when necessary to prevent an undesirable implicit

Re: [webkit-dev] X-Purpose on prefetching requests

2010-09-28 Thread Maciej Stachowiak
On Sep 28, 2010, at 4:16 PM, Adam Barth wrote: I guess I don't understand your perspective. Are you arguing that prefetch is a misfeature and folks should use image tags instead? That doesn't really make sense to me. For example, using an explicit prefect API means the prefetch gets

Re: [webkit-dev] Should we recommend explicit constructors as part of WebKit style?

2010-09-28 Thread Darin Adler
On Sep 28, 2010, at 4:31 PM, Maciej Stachowiak wrote: I think the rule should be something like: 3. Do not explicit when the single-argument constructor can be thought of as a type conversion - the class will be in some sense an alternate form of its sole parameter. Do use explicit when

Re: [webkit-dev] Should we recommend explicit constructors as part of WebKit style?

2010-09-28 Thread David Levin
On Tue, Sep 28, 2010 at 4:30 PM, Oliver Hunt oli...@apple.com wrote: Pro's for #1 It is a pain to remember to put explicit every time you have a constructor with one argument. Could check-webkit-style be beaten into forcing this for us? Yep, check-webkit-style could check this

Re: [webkit-dev] X-Purpose on prefetching requests

2010-09-28 Thread Alexey Proskuryakov
28.09.2010, в 16:16, Adam Barth написал(а): I guess I don't understand your perspective. Are you arguing that prefetch is a misfeature and folks should use image tags instead? That doesn't really make sense to me. For example, using an explicit prefect API means the prefetch gets properly

Re: [webkit-dev] Ruby Text Enhancements

2010-09-28 Thread Yasuo Kida
Thanks. Looks like hooking findNextLineBreak is something we should try. - kida On 2010/09/28, at 12:56, David Hyatt wrote: On Sep 28, 2010, at 12:20 PM, Yasuo Kida wrote: On 2010/09/28, at 10:11, David Hyatt wrote: On Sep 27, 2010, at 3:40 PM, Eric Mader wrote: Are you saying that

Re: [webkit-dev] X-Purpose on prefetching requests

2010-09-28 Thread Alexey Proskuryakov
28.09.2010, в 17:07, Gavin Peters (蓋文彼德斯) написал(а): If you're questioning if prefetch can make page loads faster, I can say that on the web today it does. Thank you for the information. Does the performance increase come at the cost of correctness? I.e., are these sites requiring

Re: [webkit-dev] X-Purpose on prefetching requests

2010-09-28 Thread 蓋文彼德斯
On 28 September 2010 20:25, Alexey Proskuryakov a...@webkit.org wrote: 28.09.2010, в 17:07, Gavin Peters (蓋文彼德斯) написал(а): If you're questioning if prefetch can make page loads faster, I can say that on the web today it does. Thank you for the information. Does the performance increase

[webkit-dev] JSC binding code question

2010-09-28 Thread Kinuko Yasuda
Hi Webkit folks, I'm writing a JSC binding code (custom binding code for now) for a method that can take JSON-format parameters, and I want to know what would be the right/recommended way. I mean, I want to write a binding code that can executes javascript code like: