Re: [webkit-dev] Re: Should we consider switching to git over svn?

2007-10-09 Thread Mike Hommey
On Wed, Oct 10, 2007 at 03:15:52AM +0100, Alp Toker wrote: > Thumbs up on this one. git certainly has the potential to make WebKit > development more accessible and transparent. > > It might be worth talking with other large projects that have migrated from > CVS or SVN (like xorg, freedesktop.or

Re: [webkit-dev] Build question on QT window version

2007-10-09 Thread George Staikos
On 10-Oct-07, at 12:49 AM, Jerry K wrote: Hi George, I tried your patch, but I saw other compiling error. +#if PLATFORM(QT) && defined(Q_WS_WIN32) +#define localtime_r(x, y) localtime_s(y, x) +#endif \qt\WebKit\WebCore\loader\FTPDirectoryDocument.cpp:237: error: `localtime_s' undecl

Re: [webkit-dev] Build question on QT window version

2007-10-09 Thread Jerry K
Hi George, I tried your patch, but I saw other compiling error. +#if PLATFORM(QT) && defined(Q_WS_WIN32) +#define localtime_r(x, y) localtime_s(y, x) +#endif \qt\WebKit\WebCore\loader\FTPDirectoryDocument.cpp:237: error: `localtime_s' undeclared (first use this function) I also searc

Re: [webkit-dev] Build question on Window (Safari version)

2007-10-09 Thread Jerry K
Hi Adam, I did this "-- debug flag or have run `set-webkit-configuration --debug` and it fixed my problem." Thanks Jerry Adam Roben wrote: > > On Oct 9, 2007, at 9:26 AM, Jerry K wrote: > >> >> Hi Adam, >> >> Here is what I found. >> I built webkit debug and release version. >> >> The webk

[webkit-dev] Re: Should we consider switching to git over svn?

2007-10-09 Thread Alp Toker
Thumbs up on this one. git certainly has the potential to make WebKit development more accessible and transparent. It might be worth talking with other large projects that have migrated from CVS or SVN (like xorg, freedesktop.org, wine) to see if they have any useful commit history post-proces

Re: [webkit-dev] could someone try building with my patch to gtk and qt?

2007-10-09 Thread Alice Liu
Alice Liu wrote: Hello, I'm making a change to WebKit that will change the return type of FrameLoaderClient::createFrame() from Frame* to PassRefPtr. In my patch I also included the necessary changes to gtk and qt frame loader classes to remain compatible with my change. In an effort to no

[webkit-dev] could someone try building with my patch to gtk and qt?

2007-10-09 Thread Alice Liu
Hello, I'm making a change to WebKit that will change the return type of FrameLoaderClient::createFrame() from Frame* to PassRefPtr. In my patch I also included the necessary changes to gtk and qt frame loader classes to remain compatible with my change. In an effort to not break the gtk an

Re: [webkit-dev] Webkit Building failed on Windows

2007-10-09 Thread Adam Roben
On Oct 9, 2007, at 2:48 PM, James tu wrote: 7. open Cygwin console, run WebKit/WebKitTools/Scripts/build-webkit the error message is as follow Unsupported platform, can't determine built library locations. at D:/ Profiles/w3 0339.DS/WebKit/WebKitTools/Scripts/webkitdirs.pm line 343. Does any

[webkit-dev] Webkit Building failed on Windows

2007-10-09 Thread James tu
Hello guys, I tried to build the webkit on windows but failed. Here are the steps I followed 1. Install Visual C++ 2005 Express 2. Install Microsoft Visual C++ Express 2005 Service Pack 1 3 .Install the Windows Platform SD. Add the path following the installation guide 4. Install Cy

Re: [webkit-dev] for review: RefPtr document

2007-10-09 Thread Geoffrey Garen
Having this document as a reference will be great! History Many objects in WebKit are reference counted. The pattern used is that classes have member functionsref and deref that increment and decrement the reference count. Each call to ref has to be matched by a call to deref. When the ref

Re: [webkit-dev] McAfee VirusScan considers the following files as (Trojan) in window

2007-10-09 Thread David D. Kilzer
This is a known issue: McAfee Antivirus reports false positive when checking out WebKit source on Windows http://bugs.webkit.org/show_bug.cgi?id=14649 If you would like this issue resolved, please contact McAfee technical support and reference the case numbers mentioned here: http://bugs.webkit.

Re: [webkit-dev] McAfee VirusScan considers the following files as (Trojan) in window

2007-10-09 Thread Darin Adler
Sorry, I don't understand. Are you asking the folks in the WebKit project to make some kind of change? Why does it matter to our project that VirusScan thinks these files are "(Trojan)"? -- Darin ___ webkit-dev mailing list webkit-dev@lists.w

Re: [webkit-dev] Webkit Building on Windows

2007-10-09 Thread Adam Roben
On Oct 9, 2007, at 3:06 AM, Jith Thomas wrote: On 10/8/07, Adam Roben <[EMAIL PROTECTED]> wrote: On Oct 8, 2007, at 2:42 AM, Jith Thomas wrote: On 10/5/07, Adam Roben <[EMAIL PROTECTED]> wrote: Jith Thomas wrote: > *$ WebKit/WebKitTools/Scripts/update-webkit* > and the result was, > > *Updat

[webkit-dev] McAfee VirusScan considers the following files as (Trojan) in window

2007-10-09 Thread Jerry K
Deleted \WebKit\LayoutTests\fast\encoding\utf-32-big-endian-nobom.xml Exploit-ObscuredHtml (Trojan) Deleted \WebKit\LayoutTests\fast\encoding\.svn\text-base\utf-32-big-endian-nobom.xml.svn-base Exploit-ObscuredHtml (Trojan) Moved (Clean failed) \WebKit\LayoutTests\fast\encoding\.svn\text

RE: [webkit-dev] Should we consider switching to git over svn?

2007-10-09 Thread Chris Brichford
If switching webkit to git makes it easier to import webkit code into perforce ( and export changes from perforce ), then that alone would justify the change from my team's point of view. Chris Brichford Adobe AIR Team -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL

Re: [webkit-dev] Build question on Window (Safari version)

2007-10-09 Thread Adam Roben
On Oct 9, 2007, at 9:26 AM, Jerry K wrote: Hi Adam, Here is what I found. I built webkit debug and release version. The webkit.dll release version is okey to load by Safari.exe. The webkit_debug.dll debug version showed "module can't be found" during loaded by Safari.exe. Has any one used

Re: [webkit-dev] for review: RefPtr document

2007-10-09 Thread David D. Kilzer
Random thoughts: - A link to auto_ptr examples/documentation would be nice when it's first mentioned. - I'm not clear what this statement says because I'm not sure what "donor" means (the rvalue of the assignment statement?) and I'm not sure what is being set to zero (the reference count or the v

Re: [webkit-dev] for review: RefPtr document

2007-10-09 Thread Brady Eidson
I seem to recall reviewing it at the time, but I just went over it once more. I see no technical inaccuracies, I think it's written at a great level for introducing people unfamiliar with the concept to our RefPtr infrastructure, and I don't want to get into arguing tiny ways I would rewo

[webkit-dev] for review: RefPtr document

2007-10-09 Thread Darin Adler
Hi folks. Six months ago, I wrote a document about RefPtr webkit.org/coding/RefPtr.html>. I haven't yet put a link to it in the website or the wiki. I'd appreciate feedback on the content, especially from people who have contributed patches using RefPtr and PassRefPtr in the past. -- Da

Re: [webkit-dev] Build question on Window (Safari version)

2007-10-09 Thread Jerry K
Hi Adam, Here is what I found. I built webkit debug and release version. The webkit.dll release version is okey to load by Safari.exe. The webkit_debug.dll debug version showed "module can't be found" during loaded by Safari.exe. Has any one used the webkit_debug.dll and also saw the error? Th

Re: [webkit-dev] Should we consider switching to git over svn?

2007-10-09 Thread Adam Roben
On Oct 9, 2007, at 6:40 AM, David D. Kilzer wrote: The biggest issue I see from using a git development model is that the WebKit project would need its own "Linus" to integrate changes from branches/clones into the main tree, unless using git is simply another means-to-an- end for generati

Re: [webkit-dev] Should we consider switching to git over svn?

2007-10-09 Thread David D. Kilzer
Oliver Hunt <[EMAIL PROTECTED]> wrote: > On the other hand, those of us using git currently have to use the > git-svn bridge which, while functional, is somewhat slow. I think > (and i'm hoping others agree) that despite the slightly more complex > interface the improved merging, branching,

Re: [webkit-dev] Webkit Building on Windows

2007-10-09 Thread Jith Thomas
On 10/8/07, Adam Roben <[EMAIL PROTECTED]> wrote: > > On Oct 8, 2007, at 2:42 AM, Jith Thomas wrote: > > On 10/5/07, Adam Roben <[EMAIL PROTECTED]> wrote: > > > Jith Thomas wrote: > > > *$ WebKit/WebKitTools/Scripts/update-webkit* > > > and the result was, > > > > > > *Updating OpenSource > > > s

Re: [webkit-dev] Bus error while building WebKit on Mac

2007-10-09 Thread Song Yuan
I was planning to update Xcode anyway, so I did it. I installed the latest release as you recommended and now my Xcode is "2.4.1", Gcc is "powerpc-apple-darwin8-gcc-4.0.1 (GCC) 4.0.1 (Apple Computer, Inc. build 5367)". After doing all this, WebKit was successfully built and run within Safari with n

Re: [webkit-dev] Should we consider switching to git over svn?

2007-10-09 Thread Lars Knoll
I'll just add my 2 cents here. I'm very much in favor of switching over to git at some point. There are many reasons for that, but I'll try to highlight the main ones that come to my mind (in addition to the ones Oliver mentioned already): * local repository and working offline: I often have to

Re: [webkit-dev] Should we consider switching to git over svn?

2007-10-09 Thread Oliver Hunt
On Oct 9, 2007, at 12:35 AM, Brady Eidson wrote: On Oct 8, 2007, at 11:30 PM, Oliver Hunt wrote: The average user uses update-webkit + some manual work, svn-create- patch, svn-apply-patch Behind the scenes these do, svn up, svn diff + some magic, patch + magic Yup Under git they would

Re: [webkit-dev] Should we consider switching to git over svn?

2007-10-09 Thread Mark Rowe
On 09/10/2007, at 17:31, Mike Hommey wrote: On Mon, Oct 08, 2007 at 10:40:27PM -0700, Oliver Hunt <[EMAIL PROTECTED] > wrote: ... and only follows the trunk, AFAICS. Whether you switch to git or not, I'd like at least the feature-branch to be available in a git- svn bridge. Git has it's

Re: [webkit-dev] Should we consider switching to git over svn?

2007-10-09 Thread Brady Eidson
On Oct 8, 2007, at 11:30 PM, Oliver Hunt wrote: The average user uses update-webkit + some manual work, svn-create- patch, svn-apply-patch Behind the scenes these do, svn up, svn diff + some magic, patch + magic Yup Under git they would be git fetch && git rebase origin/master + unfortuna

Re: [webkit-dev] Should we consider switching to git over svn?

2007-10-09 Thread Mike Hommey
On Mon, Oct 08, 2007 at 10:40:27PM -0700, Oliver Hunt <[EMAIL PROTECTED]> wrote: > > > > >... and only follows the trunk, AFAICS. Whether you switch to git or > >not, I'd like at least the feature-branch to be available in a git-svn > >bridge. > > > Git has it's own svn bridge, if you add I was t

Re: [webkit-dev] Should we consider switching to git over svn?

2007-10-09 Thread Alexey Proskuryakov
On 10/9/07 8:29 AM, "Oliver Hunt" <[EMAIL PROTECTED]> wrote: > Unfortunately, git is still not as user friendly as svn, and has a > relatively steep learning curve (largely due to it using some similar > commands to svn for completely different purposes :-/ ) My understanding is that tool suppo