Re: [webkit-dev] Yet another bug-less change hosed the tree.

2010-05-11 Thread Adam Barth
On Tue, May 11, 2010 at 2:11 PM, Geoffrey Garen wrote: >> For fun, I scrolled back through WebCore/ChangeLog looking for a >> non-build fix that was missing a bug link.  The first one I found was >> 160 revs ago.  I suspect the vast majority of patches already have bug >> reports. > > Did you veri

Re: [webkit-dev] Yet another bug-less change hosed the tree.

2010-05-11 Thread Maciej Stachowiak
On May 11, 2010, at 2:30 PM, Geoffrey Garen wrote: Maybe I would use webkit-patch if it really were quite easy. I tried it in earnest for a while, but I had to give it up because: * I couldn't find a ChangeLog workflow that fit its demands, so using it was actually more complicated than doin

Re: [webkit-dev] Yet another bug-less change hosed the tree.

2010-05-11 Thread Geoffrey Garen
>> Maybe I would use webkit-patch if it really were quite easy. I tried it in >> earnest for a while, but I had to give it up because: >> * I couldn't find a ChangeLog workflow that fit its demands, so using it was >> actually more complicated than doing everything by hand > > Can you explain th

Re: [webkit-dev] Yet another bug-less change hosed the tree.

2010-05-11 Thread Peter Kasting
On Tue, May 11, 2010 at 2:20 PM, Geoffrey Garen wrote: > > Yes, this way of doing things has more overhead for you personally but > > saves overhead for everyone else in the project. > > I don't think it's fair to frame my perspective as "me personally" and your > perspective as "everyone else in

Re: [webkit-dev] Yet another bug-less change hosed the tree.

2010-05-11 Thread Geoffrey Garen
>> True, if what you're really asking for is not just a bug report but also a >> "cooling off period" during which you wait for a result from the EWS bot, >> even if you get a review right away. You get greater value in the case of a >> bad patch, but also greater cost in the case of every patch

Re: [webkit-dev] Yet another bug-less change hosed the tree.

2010-05-11 Thread Geoffrey Garen
> For fun, I scrolled back through WebCore/ChangeLog looking for a > non-build fix that was missing a bug link. The first one I found was > 160 revs ago. I suspect the vast majority of patches already have bug > reports. Did you verify that they all waited for EWS bot results before committing?

Re: [webkit-dev] Behavior of file:// URLs when dragging

2010-05-11 Thread Dmitry Titov
On Mon, May 10, 2010 at 5:48 PM, Daniel Cheng wrote: > From the discussion on https://bugs.webkit.org/show_bug.cgi?id=25882, I > believe the general consensus is that file:// URLs should not be exposed > when dragging and dropping. > > Removing file:// URL population from event.dataTransfer is pr

Re: [webkit-dev] Yet another bug-less change hosed the tree.

2010-05-11 Thread Maciej Stachowiak
On May 11, 2010, at 9:51 AM, Alexey Proskuryakov wrote: 11.05.2010, в 0:56, Maciej Stachowiak написал(а): I do think making it capable of handling subdirectories would be an improvement for SVN users. Also, I suspect it doesn't work as well as it could for people who prefer to edit Change

[webkit-dev] Clearing a textfield's 'autofilled' status on change, not focus

2010-05-11 Thread Jens Alfke
HTMLInputElement's 'autofilled' property is cleared when the field gets focused[1]. This has the visible effect of clearing the pale- yellow background color to white. Safari only seems to use this background-color highlighting for autofill of names, emails, addresses, etc., but Chrome also

[webkit-dev] webkit-patch vs manual steps [was Re: Yet another bug-less change hosed the tree.]

2010-05-11 Thread David Levin
- On Tue, May 11, 2010 at 9:51 AM, Alexey Proskuryakov wrote: > > 11.05.2010, в 0:56, Maciej Stachowiak написал(а): > > > I do think making it capable of handling subdirectories would be an >> improvement for SVN users. Also, I suspect it doesn't work as well as it >> could for people who p

Re: [webkit-dev] Yet another bug-less change hosed the tree.

2010-05-11 Thread Jeremy Orlow
On Tue, May 11, 2010 at 5:51 PM, Alexey Proskuryakov wrote: > > 11.05.2010, в 0:56, Maciej Stachowiak написал(а): > > > I do think making it capable of handling subdirectories would be an >> improvement for SVN users. Also, I suspect it doesn't work as well as it >> could for people who prefer t

Re: [webkit-dev] Yet another bug-less change hosed the tree.

2010-05-11 Thread Alexey Proskuryakov
11.05.2010, в 0:56, Maciej Stachowiak написал(а): I do think making it capable of handling subdirectories would be an improvement for SVN users. Also, I suspect it doesn't work as well as it could for people who prefer to edit ChangeLogs in a non- command-line editor, and for people who are

Re: [webkit-dev] Yet another bug-less change hosed the tree.

2010-05-11 Thread Maciej Stachowiak
On May 10, 2010, at 11:45 PM, Eric Seidel wrote: As Maciej states, webkit-patch upload is pretty quick (at least for git users). I'm not a git user but I still find it more convenient than any other approach because it has fewer steps and it helps me avoid some common mistakes. I do th