On Dec 23, 2010, at 2:04 PM, Chris Marrin wrote:
> How would we go about feeling comfortable about the security risk?
The point isn’t the security risk, but rather the security risk with no benefit.
It’s OK to make this class unconditional unless there is someone planning to
ship WebKit that ha
On Dec 23, 2010, at 1:47 PM, Charles Pritchard wrote:
> You need to have Blobs for ArrayBuffer to be of much use for XHR,
> because you need to be able to set the Content-Type, and browsers may/will
> fiddle with the content-type header you set, if you have not passed a Blob.
>
> Blobs are defin
On Dec 23, 2010, at 11:23 AM, Darin Adler wrote:
> On Dec 23, 2010, at 11:21 AM, Jian Li wrote:
>
>> We do not add an additional check expression when TypedArray is added to XHR.
>
> Is the TypedArray support in XHR a feature in its own right? Should it be off
> by default or is it ready to be
You need to have Blobs for ArrayBuffer to be of much use for XHR,
because you need to be able to set the Content-Type, and browsers may/will
fiddle with the content-type header you set, if you have not passed a Blob.
Blobs are defined under the File API (I believe).
Blob is already under the XHR
On Dec 22, 2010, at 11:53 AM, Mark Rowe wrote:
>
> On 2010-12-22, at 10:45, Kenneth Russell wrote:
>
>> I see. The GLU tessellator was integrated because it was the only
>> viable option for helping implement GPU-accelerated path rendering in
>> WebKit. (This work is still in early stages, and
It should probably have its own feature define. It doesn't really make sense to
have ArrayBuffer support in XHR only if you have either WebGL or File support.
Regards,
Maciej
On Dec 23, 2010, at 12:29 PM, Jian Li wrote:
> Currently it is guarded by the same guarding expression.
>
> CC Chris w
On Dec 22, 2010, at 12:06 PM, Adam Barth wrote:
> [Forking the thread]
>
> On Wed, Dec 22, 2010 at 10:40 AM, Mark Rowe wrote:
>> On 2010-12-22, at 10:34, Adam Barth wrote:
>>> As an aside, would creating the Sources directory make it easier to
>>> move WTF out of JavaScriptCore?
>>
>> I don't
Currently it is guarded by the same guarding expression.
CC Chris who implemented this feature since he knows whether it is ready all
versions or not.
On Thu, Dec 23, 2010 at 11:23 AM, Darin Adler wrote:
> On Dec 23, 2010, at 11:21 AM, Jian Li wrote:
>
> > We do not add an additional check exp
On Dec 23, 2010, at 11:21 AM, Jian Li wrote:
> We do not add an additional check expression when TypedArray is added to XHR.
Is the TypedArray support in XHR a feature in its own right? Should it be off
by default or is it ready to be on for all versions of WebKit?
-- Darin
___
On Dec 23, 2010, at 11:17 AM, Chris Marrin wrote:
> Is there any reason for it NOT to be unguarded?
If this was used in any unconditional feature we wouldn’t need this discussion.
Generally speaking we don’t want to put new DOM classes into WebKit that are
there to support new features if the f
Currently the definition of TypedArray is guarded by ENABLE(3D_CANVAS) ||
ENABLE(BLOB). It has been used in the following features:
- WebGL
- File API: FileReader and BlobBuilder
- XMLHttpRequest: send and response
We do not add an additional check expression when TypedArray is added to
On Dec 23, 2010, at 11:01 AM, Darin Adler wrote:
> Yes, we want correct conditionals, and TypedArray should not be in the WebGL
> feature guard if it’s used in other features.
>
> Adding a feature new guard would not be good if it has to be set explicitly.
> It would be much better if the buil
Yes, we want correct conditionals, and TypedArray should not be in the WebGL
feature guard if it’s used in other features.
Adding a feature new guard would not be good if it has to be set explicitly. It
would be much better if the build just decided correctly based on the other
feature guards.
On Dec 23, 2010, at 6:02 AM, Carl Lobo wrote:
> I'm not very sure if this is relevant but here goes:
> I'm working on a javascript hosting framework (it's open source:
> https://github.com/directi/webkit_titanium/tree/webkit_clean).
> I'd pulled webkit git a couple of weeks back and then again a f
Just make sure if WebGL is on, TypedArray is always there.
Mo
On Thu, Dec 23, 2010 at 10:23 AM, Jian Li wrote:
> Sounds like a good idea. I am going to add TYPED_ARRAY guard for this.
> Thanks,
> Jian
>
> On Thu, Dec 23, 2010 at 8:13 AM, Chris Marrin wrote:
>>
>> On Dec 22, 2010, at 5:34 PM, Ji
Sounds like a good idea. I am going to add TYPED_ARRAY guard for this.
Thanks,
Jian
On Thu, Dec 23, 2010 at 8:13 AM, Chris Marrin wrote:
>
> On Dec 22, 2010, at 5:34 PM, Jian Li wrote:
>
> > Hi,
> >
> > TypedArray has been used in some non-WebGL areas, like File API and XHR.
> It would be nice
On Dec 22, 2010, at 5:34 PM, Jian Li wrote:
> Hi,
>
> TypedArray has been used in some non-WebGL areas, like File API and XHR. It
> would be nice if we move it out of WebGL feature guard. Any objection?
It would probably be best if it had its own guard. Then its various users could
turn it on
Hi,
I'm not very sure if this is relevant but here goes:
I'm working on a javascript hosting framework (it's open source:
https://github.com/directi/webkit_titanium/tree/webkit_clean).
I'd pulled webkit git a couple of weeks back and then again a few
hours ago and I get apparently random crashes in
The CommitQueue machines are all Snow Leopard, so these
timeout/crashes must be caused by more than just Chromium code. :)
Thanks for looking at it!
On Thu, Dec 23, 2010 at 3:15 AM, Ilya Tikhonovsky wrote:
> I just fixed one place yesterday in chromium DRT and I'm looking for the
> others.
>
>
I just fixed one place yesterday in chromium DRT and I'm looking for the others.
Regards,
Tim.
On Thu, Dec 23, 2010 at 11:47 AM, Eric Seidel wrote:
> Long ago we taught the commit-queue how to be tolerant of flaky tests
> (just running the tests again and again until it gets consistent
> resul
Long ago we taught the commit-queue how to be tolerant of flaky tests
(just running the tests again and again until it gets consistent
results). Recently we taught it how to report to bugzilla when it
finds flaky tests.
We're still working on improving the information it reports (including
crash
21 matches
Mail list logo
