Good catch. It would be really helpful if you would file a bug and post a
patch to remove it. See http://webkit.org/coding/contributing.html for
information about how to do this. Thanks again.
-Sam
On 8/21/07, Anyang Ren [EMAIL PROTECTED] wrote:
r24862 added an unused variable
It has always bugged me that WTF was in JavaScriptCore at all. Perhaps now
is a good time to move it to its own project. I am not sure what the
concerns in the past were about separating WTF from JavaScriptCore. Were
they performance related?
-Sam
___
like JSCore or JSC. I prefer JSCore.
-Sam
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
On Wed, Oct 1, 2008 at 1:46 AM, Geoffrey Garen [EMAIL PROTECTED] wrote:
In the Chrome tree, every object inheriting from RefCounted incurs
an extra pointer in size, but this is clearly more than necessary
since many RefCounted objects do not have bindings.
If we believe that JS wrappers
On Wed, Oct 1, 2008 at 4:01 PM, Eric Seidel [EMAIL PROTECTED] wrote:
enum SVGStitchOptions {
SVG_STITCHTYPE_UNKNOWN = 0,
SVG_STITCHTYPE_STITCH = 1,
SVG_STITCHTYPE_NOSTITCH = 2
};
This style is usually used to stay consistent with the DOM IDLs. I don't
think we should change
On Thu, Oct 2, 2008 at 8:31 AM, Peter Kasting [EMAIL PROTECTED] wrote:
On Wed, Oct 1, 2008 at 10:41 PM, Mike Hommey [EMAIL PROTECTED][EMAIL
PROTECTED]
wrote:
On Wed, Oct 01, 2008 at 04:03:32PM -0700, Mike Belshe wrote:
Total size Potential savings
On Tue, Oct 14, 2008 at 3:15 PM, Ojan Vafai [EMAIL PROTECTED] wrote:
I currently see nameGetter, namedItem
and getNamedItem in a number of different files that all currently have
custom bindings that normalize to a nameGetter function.
Can we just have all the collection types normalize on
Hi Dmitry,
The first example using a closure executes in the parent scope because
functions execute in lexical scope regardless of where they are called from,
capturing variables as required. The string version is simply executed as a
program by the caller and has no knowledge of the scope in
I just noticed several patches have put up for review that contain new files
using the Apache license. Current WebKit policy is that code should be
licensed under either a BSD license or GNU Lesser General Public License
v.2.1 (mentioned explicitly when submitting patches on bugs.webkit.org). In
On Tue, May 26, 2009 at 11:08 AM, John Abd-El-Malek j...@google.com wrote:
I agree that this approach is powerful. However there are (not too
frequent) situations when a port like Chromium wants to use both the WebKit
implementation and its own implementation, switching in runtime. For
On Tue, May 26, 2009 at 4:20 PM, Drew Wilson atwil...@google.com wrote:
To give the list some insight into the discussions we've had with the
Chrome UX folks:
1) We want to associate some set of enhanced permissions with a given
origin (e.g. https://mail.yahoo.com), and we want the user to
On Tue, May 26, 2009 at 5:04 PM, Drew Wilson atwil...@google.com wrote:
On Tue, May 26, 2009 at 4:43 PM, Sam Weinig sam.wei...@gmail.com wrote:
On Tue, May 26, 2009 at 4:20 PM, Drew Wilson atwil...@google.com wrote:
To give the list some insight into the discussions we've had
On Tue, May 26, 2009 at 9:18 PM, David Levin le...@chromium.org wrote:
On Tue, May 26, 2009 at 8:57 PM, Sam Weinig sam.wei...@gmail.com wrote:
On Tue, May 26, 2009 at 5:04 PM, Drew Wilson atwil...@google.com wrote:
On Tue, May 26, 2009 at 4:43 PM, Sam Weinig sam.wei...@gmail.comwrote
it wants
to grant, etc.
What do you think?
-atw
On Tue, May 26, 2009 at 9:49 PM, Sam Weinig sam.wei...@gmail.com wrote:
On Tue, May 26, 2009 at 9:18 PM, David Levin le...@chromium.org wrote:
On Tue, May 26, 2009 at 8:57 PM, Sam Weinig sam.wei...@gmail.comwrote:
On Tue, May 26
On Mon, Jun 1, 2009 at 3:50 PM, Jeremy Orlow jor...@chromium.org wrote:
I have 2 questions about SecurityOrigins.
First of all, in SecurityOrigin::databaseIdentifier() (in
http://trac.webkit.org/browser/trunk/WebCore/page/SecurityOrigin.h) the
following comment appears: Serialize the
While clearly a personal preference, I don't like the default
prepare-changelog default text and would much rather we revert to the old
one. I don't think the new text adds anything and will likely be ignored by
most. Can we leave the --bug= option and revert to the old template?
-Sam
On Wed,
On Fri, Jul 3, 2009 at 2:42 PM, Drew Wilson atwil...@google.com wrote:
I'm working on refactoring some code out of WebCore::Worker into a common
base class to be shared between SharedWorker and Worker.
So I've defined a new AbstractWorker.idl and its associated JS bindings.
AbstractWorker is
On Mon, Jul 13, 2009 at 1:57 PM, Eric Seidel e...@webkit.org wrote:
On Mon, Jul 13, 2009 at 1:36 PM, Geoffrey Garengga...@apple.com wrote:
I'm not sure what you guys have been meaning by the phrase correct
heap.
Barring workers, all WebCore objects are allocated from the same heap.
We had
I believe it is quite well established that a space should not be allowed
before a ; or , in such circumstances. (I have r-ed for it even ;) ). I
think we should definitely explicitly call this out in the
guidelines if it is not already.
-Sam
On Tue, Jul 21, 2009 at 4:05 PM, Kenneth
Making this JS only for now seems fine. If we want to enable MessagePorts
for other binding languages we can define the mapping ourselves. For
example, for a sequence, the clear mapping for ObjC would be to NSArray*.
-Sam
On Wed, Aug 26, 2009 at 5:03 PM, Drew Wilson atwil...@google.com wrote:
On Wed, Aug 26, 2009 at 8:27 PM, Maciej Stachowiak m...@apple.com wrote:
On Aug 26, 2009, at 9:26 AM, Sam Weinig wrote:
Making this JS only for now seems fine. If we want to enable MessagePorts
for other binding languages we can define the mapping ourselves. For
example, for a sequence
On Thu, Sep 10, 2009 at 3:12 PM, Chris Campbell campb...@flock.com wrote:
Hi All,
I had it in mind to implement support for passing data structures
through postMessage() using the structured clone algorithm laid out
in the HTML5 spec:
On Thu, Sep 10, 2009 at 3:55 PM, Drew Wilson atwil...@google.com wrote:
The other approach we discussed was leaving the postMessage() APIs in
WebCore as they are (taking a DOMString parameter) and doing the
serialization/de-serialization in the JS bindings instead.
My one concern about
I also think this change is the right way to go. r=me.
On Tue, Sep 22, 2009 at 1:20 PM, Brady Eidson beid...@apple.com wrote:
I've always hated the indentation in header files.
I have no objections.
~Brady
On Sep 22, 2009, at 1:06 PM, David Hyatt wrote:
I had thought that we resolved
This is a question that is better suited for webkit-help. This list is for
the discussion of the development of webkit.
-Sam
On Mon, Oct 5, 2009 at 4:37 PM, Xiaomei Ji x...@chromium.org wrote:
I am trying to display a tooltip under the mouse when mouse stays at a
position long enough.
I am
Hi Folks,
I am not happy with the way these runtime settings have been implemented so
far as they break runtime detection using the technique we evangelize to
developers, specifically, using the (property in window) method. A
feature that is turned off at runtime should not be detectable at all,
be singling out
SharedWorkers or WebSockets - if we feel strongly that this needs to be
addressed, we can update all of those features accordingly. If people with
knowledge of the internals of V8 and JSC can chime in, we can discuss how
best to approach this.
-atw
On Mon, Oct 5, 2009 at 5:04 PM, Sam
On Mon, Oct 5, 2009 at 5:46 PM, Drew Wilson atwil...@google.com wrote:
I'm surprised to see these objections coming up now, weeks after the
original discussion, and only after my patch has landed in the tree.
Sorry, I seemed to have missed that thread. I did however file a bug as soon
as the
On Mon, Oct 5, 2009 at 6:33 PM, Drew Wilson atwil...@google.com wrote:
On Mon, Oct 5, 2009 at 6:20 PM, Sam Weinig sam.wei...@gmail.com wrote:
On Mon, Oct 5, 2009 at 5:46 PM, Drew Wilson atwil...@google.com wrote:
I'm surprised to see these objections coming up now, weeks after
On Mon, Oct 5, 2009 at 7:50 PM, Drew Wilson atwil...@google.com wrote:
Ooops, meant to reply to all.
On Mon, Oct 5, 2009 at 7:49 PM, Drew Wilson atwil...@google.com wrote:
On Mon, Oct 5, 2009 at 6:40 PM, Sam Weinig sam.wei...@gmail.com wrote:
That is not true, they are also available
On Wed, Oct 7, 2009 at 10:02 PM, Eric Seidel e...@webkit.org wrote:
Now from the right email address...
-- Forwarded message --
From: Eric Seidel esei...@google.com
Date: Thu, Oct 8, 2009 at 1:02 AM
Subject: Re: [webkit-dev] Point 3 of the WebKit Style Guidelines
Hi WebKit Developers,
As nice as it may be to have a bot landing your patches, I think developers
who have a commit bit should try and make the effort to land their own
patches. Mainly I think this is a good idea since the creator of the patch
has a much better chance of fixing the issue or
Hi Dmitry,
As I have noted to others on the Chrome team, I do not think this is good
idea and I don't think we should have it in WebKit. It adds extra
complexity to WebKit and gives little beyond what is possible using
inter-window communication and SharedWorkers. I think we need to give more
On Wed, Dec 2, 2009 at 9:57 PM, Dan Bernstein m...@apple.com wrote:
On Dec 2, 2009, at 9:46 PM, Peter Kasting wrote:
On Wed, Dec 2, 2009 at 9:19 PM, Mark Rowe mr...@apple.com wrote:
On 2009-12-02, at 21:00, Peter Kasting wrote:
I find this tricky to read and error-prone. I propose that
Generally, we don't run fuzz testing suites with the rest of the regression
tests due to the length of time they take to run, but rather run them
periodically (for instance, before releases), fixing any issues they that
show up. Fuzz tests tend to cover much more ground at the cost of a longer
I would prefer we stick with the run prefix.
I am also not sure why we would have separate testing scripts based by
language. I think it would make a lot more sense to base the scripts on what
they were testing as is currently done (run-webkit-tests tests webkit,
run-javascriptcore-tests tests
On Fri, Jan 1, 2010 at 7:13 PM, Chris Fleizach cfleiz...@apple.com wrote:
I need to have a layout test register a callback with DRT, then have that
callback be called at the appropriate time (in order to test accessibility
notifications)
I can't figure out the right incantations to do so.
On Tue, Feb 23, 2010 at 12:58 PM, Dirk Schulze vb...@gmx.de wrote:
Am Dienstag, den 23.02.2010, 08:34 -0800 schrieb Simon Fraser:
It could be an image, or it could be a configuration of div elements,
or a table, or something else that can be configured to look exactly the
same as the CSS
I am not sure why we would make a distinction between development tools and
and supported platforms. Any scripts checked in need to run on Tiger. If we
need to fix a Tiger bug, we boot up Tiger and develop there.
-Sam
On Wed, Mar 3, 2010 at 3:47 PM, David Levin le...@chromium.org wrote:
I
And our own http://planet.webkit.org/.
-Sam
On Mon, Mar 22, 2010 at 3:11 PM, Chris Jerdonek cjerdo...@webkit.orgwrote:
On Mon, Mar 22, 2010 at 2:30 PM, Eric Seidel e...@webkit.org wrote:
Interesting. Looks like the WebKit icon on CIA is different from
webkit.org. I could have sworn they
The version in the OpenSource tree does not match what we ship on Mac OS X
or Windows as part of Safari. We are going to update it to the same version
that is used by Snow Leopard (version 3.6.12) shortly. Thanks for bringing
this to our attention.
- Sam
On Thu, Mar 25, 2010 at 5:34 PM,
We are now updated to version 3.6.12 as of
http://trac.webkit.org/changeset/56607.
-Sam
On Thu, Mar 25, 2010 at 6:39 PM, Sam Weinig sam.wei...@gmail.com wrote:
The version in the OpenSource tree does not match what we ship on Mac OS X
or Windows as part of Safari. We are going to update
In fairness to Mark Rowe, he did the work.
On Fri, Mar 26, 2010 at 12:32 PM, Dumitru Daniliuc d...@chromium.orgwrote:
it's a new test that i haven't submitted yet.
sam: thanks for upgrading sqlite. i'm running that test right now.
dumi
On Fri, Mar 26, 2010 at 9:43 AM, Brady Eidson
I am not sure which tests you are referring to that use the user-agent to
change behavior, but that is not the way it is supposed to be done. Instead,
tests that test a platform specific behavior should go in the
LayoutTest/YOURPLATFORM directory. If it is just a platform specific result,
the
On Sun, Mar 28, 2010 at 7:14 PM, Dan Bernstein m...@apple.com wrote:
On Mar 28, 2010, at 7:08 PM, Sam Weinig wrote:
I am not sure which tests you are referring to that use the user-agent to
change behavior, but that is not the way it is supposed to be done. Instead,
tests that test
On Thu, Apr 8, 2010 at 4:25 PM, Gustavo Sverzut Barbieri
barbi...@profusion.mobi wrote:
On Thu, Apr 8, 2010 at 3:01 PM, Anders Carlsson ander...@apple.com
wrote:
Hello everyone,
This is a heads-up that we will shortly start landing patches for a new
WebKit framework that we at Apple
On Wed, Apr 28, 2010 at 7:10 AM, Nayan naya...@gmail.com wrote:
Hi,
What's the status of Webkit2? I've built the latest webkit version on
Windows with --webkit2 option and I see that there is only one process
shown in Task Manager irrespective of the number of Windows that I
open.
Reagrds,
This was my understanding as well.
-Sam
On Thu, May 6, 2010 at 9:54 PM, Alexey Proskuryakov a...@webkit.org wrote:
I thought the agreement was that essential tools shouldn't add more
requirements on the installed tools. Is it not the case?
- WBR, Alexey Proskuryakov
06.05.2010, в 21:30,
of an individual file.
Dave
--
*From:* John Gregg john...@google.com
*To:* Sam Weinig sam.wei...@gmail.com
*Cc:* webkit-dev@lists.webkit.org
*Sent:* Tue, June 1, 2010 3:09:00 PM
*Subject:* Re: [webkit-dev] Directory upload experimental feature
My proposal
Now that I have had a little time to think about it, I think my biggest
concern with this type of API is the unintentional ability for an attacker
to gain information from the engine consuming specifics amount of memory.
Let's take the visited link history stealing attack as an example. Even
On Wed, Jun 2, 2010 at 2:45 PM, Mikhail Naganov mnaga...@chromium.orgwrote:
Used memory count can be restricted to include only objects reachable
from the caller execution context. In this case, an app could only see
the amount of memory consumed by itself, not by the whole engine.
I don't
I should note, I don't think this is possible for JS objects, it certainly
would not be possible for arbitrary WebCore/WebKit objects. I noticed the
patch was re-landed, which surprises me since we are still discussing it,
why was this?
-Sam
On Thu, Jun 3, 2010 at 5:02 PM, Timothy Hatcher
After talking it over with some folks here at Apple, I want to formally
object to adding the Console.memory extension to the Console object and I
think we should remove support for Console.profiles as soon as we can. They
both provide information to users that are not generally useful (beyond the
Hi.
On Wed, Jul 7, 2010 at 7:02 AM, Balazs Kelemen k...@inf.u-szeged.hu wrote:
Hi folks!
While I worked on the Qt port of WebKit2, I faced with some build
issues. To solve these problems it seems like common parts of WebKit2
should change, that is why I thought that discussing them in the
On Wed, Jul 7, 2010 at 8:30 AM, Matt 'Murph' Finnicum mattf...@gmail.comwrote:
I know this sounds a bit silly, but it's a simplified version of what i'm
doing.
Let's say I decided to replace every webpage with hello world. I
decided to do this from finishedParsing() within dom/Document.cpp:
On Wed, Aug 4, 2010 at 1:29 AM, Nikolas Zimmermann
zimmerm...@physik.rwth-aachen.de wrote:
namespace WebCore {
...
} // namespace WebCore
2. ENABLE(FOO) #endif comments
#if ENABLE(FOO)
..
#endif // ENABLE(FOO)
I like these two forms of comments.
-Sam
I am not sure this is true across the board, in many places we set the
exception code to TYPE_MISMATCH_ERR on null input in the implementation (the
first one I looked at was CanvasRenderingContext2D::drawImage). Can you go
into more detail about why the WebGL bindings need to be more strict than
is.
On Wed, Aug 11, 2010 at 8:14 PM, Sam Weinig sam.wei...@gmail.com wrote:
I am not sure this is true across the board, in many places we set the
exception code to TYPE_MISMATCH_ERR on null input in the implementation
(the
first one I looked at was CanvasRenderingContext2D::drawImage). Can you
On Wed, Aug 11, 2010 at 10:29 PM, Cedric Vivier cedr...@neonux.com wrote:
On Thu, Aug 12, 2010 at 13:26, Sam Weinig sam.wei...@gmail.com wrote:
For this specific case, it seems like you could easily check for a null
WebGLProgram* in WebGLRenderingContext::useProgram and set the
ExceptionCode
On Wed, Aug 11, 2010 at 10:58 PM, Darin Fisher da...@chromium.org wrote:
On Wed, Aug 11, 2010 at 10:37 PM, Sam Weinig sam.wei...@gmail.com wrote:
On Wed, Aug 11, 2010 at 10:29 PM, Cedric Vivier cedr...@neonux.comwrote:
On Thu, Aug 12, 2010 at 13:26, Sam Weinig sam.wei...@gmail.com wrote
On Thu, Aug 12, 2010 at 9:20 AM, Sam Weinig sam.wei...@gmail.com
wrote:
On Wed, Aug 11, 2010 at 10:58 PM, Darin Fisher da...@chromium.org
wrote:
On Wed, Aug 11, 2010 at 10:37 PM, Sam Weinig sam.wei...@gmail.com
wrote:
On Wed, Aug 11, 2010 at 10:29 PM, Cedric Vivier cedr
I am not sure I agree. Does our behavior actually cause any real bugs in
the places you have tracked down? The log spam really doesn't seem like an
issue, we can remove it if we want to, but have found it useful in the
past.
I agree with Maciej that the current behavior is in many ways better,
Hi Balazs,
Does it not work currently? If not, can you please file bugs on what is not
working. We plan on making the shared process model the default model for
the API, but it will probably have the caveat that it will not support
InjectedBundles.
-Sam
On Mon, Aug 30, 2010 at 6:08 AM, Balazs
Sorry, I seemed to have missed this thread. Please do not rewrite scripts
just to rewrite them in a language you like. WebKit's dependency on Ruby is
here to stay. Just because python is common at Google does not make it
universal.
-Sam
On Wed, Sep 1, 2010 at 4:48 PM, TAMURA, Kent
on this because it is important for our
project to know which way should we go on with WebKit2. Thank you!
Balazs Kelemen
On 08/30/2010 08:22 PM, Sam Weinig wrote:
Hi Balazs,
Does it not work currently? If not, can you please file bugs on what
is not working. We plan on making the shared process
On Fri, Sep 10, 2010 at 5:15 AM, Adam Roben aro...@apple.com wrote:
On Sep 10, 2010, at 8:11 AM, Adam Roben wrote:
It's interesting that ~45 minutes elapse between builds for the Windows
WebKit2 bot, but only ~18 minutes elapse between builds for the SnowLeopard
WebKit2 bot. We should
It seems the dependency on Frame is now gone (as of last night I guess?)
with the advent of the NetworkingContext.
-Sam
On Sat, Sep 11, 2010 at 3:42 PM, Maciej Stachowiak m...@apple.com wrote:
On Sep 11, 2010, at 2:57 AM, Adam Barth wrote:
I don't mean to spam this list with design
Just a general question as to why the decision was made to put the mock
implementation classes (DeviceOrientationClientMock, GeolocationServiceMock
and SpeechInputClientMock) beneath WebCore/platform. WebCore/platform is
not supposed to know about classes outside of WebCore/platform in WebCore
It is for historical reasons that both have an origin. The idea was that we
were going to move the DOMWindow to be owned by the Document, and when that
was done, remove the DOMWindow's origin. I seem to remember there being a
theoretical time when the two could differ, but looking
at
No one (that I know of) is currently working on making plugins work with the
PageCache. The most pressing road block to make it work is infrastructure to
kill and restart plugins (or alternatively, and reliable way to pause them,
perhaps using their current out of process nature, or perhaps
We also have WebKit2 API tests (or soon will if they aren't landed yet).
The WebKit2 tests have been in the tree (under Tools/TestWebKitAPI) for bit
now. The harness can also be used to test WTF data structures and has a
sample test of basic testing of Vector.
-Sam
On Mon, Dec 27, 2010 at 11:14 AM, Adam Barth aba...@webkit.org wrote:
Is it really a good idea to move platform out of WebCore? Lots of stuff
there seems quite WebCore related.
There seem to be a couple people who aren't sold on moving platform
out of WebCore. It sounds like we should
WebKit has had the ability to run plugins out of process on the mac for
quite some time. We recently reimplemented a bunch of that functionality to
share infrastructure with WebKit's general out-of-process strategy, and that
code can be found
I am really not an expert on testing frameworks, and just put together
something that met my needs (as has been the tradition in this project). That
said, the only features I like about TestWebKitAPI is that I know how it works
and can hack
it to do what I want, and that it has the ability to
Would we want this to be web facing? Or should we limit it to inside the
built-in stylesheets?
-Sam
On Apr 26, 2011, at 1:18 PM, Dimitri Glazkov wrote:
Hello,
SUMMARY: we would like to introduce a webkit-resource URL scheme for
CSS, which would refer to images baked into WebKit.
It doesn't look like they have have exposed API to do this yet. Please file an
enhancement request at bugs.webkit.org.
-Sam
On May 24, 2011, at 8:33 PM, naren.me...@gmail.com wrote:
Thanks for the response, Sam.
On Tue, May 24, 2011 at 10:19 PM, Sam Weinig wei...@apple.com wrote
I don't think we should do this. EventTarget is really just an abstract
interface, and changing its implementation globally is of limited utility.
-Sam
On Jun 8, 2011, at 5:54 PM, Dominic Cooney wrote:
[If you don't care about JSC or V8 bindings you can safely ignore
this.]
TL;DR I want
Why should we implement this spec? We already have one flex box implementation
that we can never remove (and corresponds closely to Firefox's) so it seems to
me that we should work on standardizing that model. Adding a large bunch of
code that duplicates existing functionality seems foolish.
Since it is confusing to me (and may be to others), perhaps a different name
than ENABLE_FLEXBOX should be used, given that we already have flexbox. Maybe,
ENABLE_NEW_FLEXBOX?
-Sam
On Jun 10, 2011, at 2:42 PM, David Hyatt wrote:
Just so people know, it was my recommendation that they just
Great!
-Sam
On Jun 13, 2011, at 9:37 AM, Tony Chang wrote:
Sure, no problem. I'll rename it to ENALBE_NEW_FLEXBOX.
On Fri, Jun 10, 2011 at 6:12 PM, Sam Weinig wei...@apple.com wrote:
Since it is confusing to me (and may be to others), perhaps a different name
than ENABLE_FLEXBOX should
rename it to ENALBE_NEW_FLEXBOX.
On Fri, Jun 10, 2011 at 6:12 PM, Sam Weinig wei...@apple.com wrote:
Since it is confusing to me (and may be to others), perhaps a different name
than ENABLE_FLEXBOX should be used, given that we already have flexbox.
Maybe, ENABLE_NEW_FLEXBOX?
-Sam
it to ENALBE_NEW_FLEXBOX.
On Fri, Jun 10, 2011 at 6:12 PM, Sam Weinig wei...@apple.com wrote:
Since it is confusing to me (and may be to others), perhaps a different name
than ENABLE_FLEXBOX should be used, given that we already have flexbox.
Maybe, ENABLE_NEW_FLEXBOX?
-Sam
On Jun
Hi Dimitri,
First of all, nice work on getting to this point!
It is not clear to me why we wouldn't stick with XBL2 for now, at least until
there is more community consensus on going another way, and a spec and editor
are available to take the API forward. I think it would help if you could
Hi Carlos,
Unfortunately, there is not much to report here. We have not made any decisions
on whether we are going to migrate to a C++ API. If you are implementing a
layer on top of the C API, that should continue to work for the foreseeable
future.
-Sam
On Jul 14, 2011, at 12:10 AM,
I think we should let the spec mature a bit before diving in.
-Sam
On Jul 26, 2011, at 10:53 PM, Adam Barth wrote:
Hi webkit-dev,
As some of you are probably aware, Mozilla is experimenting with
exposing some basic cryptographic primitives to web applications:
This list doesn't seem to include the changes in behavior to addEventListener
and removeEventListerner (from patches like
http://trac.webkit.org/changeset/92469 http://trac.webkit.org/changeset/92433).
Are those intentionally left out?
-Sam
On Aug 5, 2011, at 12:44 PM, Mark Pilgrim wrote:
In general, we have preferred index style.
-Sam
On Oct 17, 2011, at 2:48 PM, Adam Klein wrote:
A small style question came up in a review today, and I was curious if
there's any consensus on this: when iterating over a WTF::Vector, does
WebKit style prefer using a size_t vs a
Hazzah! Great work Adam and friends!
-Sam
On Oct 18, 2011, at 10:37 AM, Adam Barth wrote:
As discussed previously on webkit-dev, we've been cleaning up some of
the ENABLE macros in WebKit:
https://lists.webkit.org/pipermail/webkit-dev/2011-September/017988.html
As part of this effort,
For the specific case of Event, we do need some sort of poor man's RTTI here
for the sake of the bindings, but we could consider alternatives. Since you
need to identify the subclasses, you need to either use many virtual functions,
as we do currently for Event, or have some tagging mechanism,
, 2011 6:10 PM, Sam Weinig wei...@apple.com wrote:
For the specific case of Event, we do need some sort of poor man's RTTI here
for the sake of the bindings, but we could consider alternatives. Since you
need to identify the subclasses, you need to either use many virtual
functions, as we do
Another benefit to using the static keyword is that you can tell at a glance
that the function is internal to the translation unit, while you may not notice
the anonymous namespace.
-Sam
On Oct 19, 2011, at 3:45 PM, Darin Adler wrote:
The guideline is not to disallow anonymous namespaces.
It should long term be generated from the EventInit dictionary IDLs, but it was
handy to implement it in a macro based DSL initially.
-Sam
On Nov 2, 2011, at 11:02 AM, Adam Barth wrote:
This file seems to be growing a list of ever feature in the project:
It seems acceptable to me to require SQLite.
-Sam
On Dec 3, 2011, at 10:47 AM, Ryosuke Niwa wrote:
Hi,
Recent removal of OFFLINE_WEB_APPLICATIONS flag in
http://trac.webkit.org/changeset/96123 made SQLite a new requirement to port
WebKit. However, there are many operating systems and
On Mar 7, 2012, at 9:25 PM, Darin Adler wrote:
On Mar 7, 2012, at 9:34 AM, Adam Barth wrote:
The WindowProxy is implemented in WebKit using the WindowShell class.
Idle thought: We might want to consider renaming our WindowShell class
WindowProxy, just to match the HTML specification
On Mar 7, 2012, at 4:41 PM, Ojan Vafai wrote:
I just did a first pass a greening the Chromium Lion bot:
http://trac.webkit.org/changeset/110096. Of these hundreds of tests, ~99% of
them are perfect candidates for being reftests (e.g. they contain one line of
text and a solid box or two
, or about whether this meeting is
appropriate for you to attend, you may email me at wei...@apple.com.
We hope to see you there!
Thanks,
Sam Weinig
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit
at 2:16 PM, Sam Weinig sam.wei...@gmail.com wrote:
I am not sure I agree. Does our behavior actually cause any real bugs in the
places you have tracked down? The log spam really doesn't seem like an
issue, we can remove it if we want to, but have found it useful in the past.
Speaking
On Mar 22, 2012, at 6:41 PM, Ojan Vafai o...@chromium.org wrote:
I've recently been greening Chromium's expectations for css3/selectors3. ~10%
of these test need interaction (e.g. hovering over a link or selecting text).
Given that this is an imported test suite does it make sense to add
Hi Balazs,
This is something we don't want at this time. Dealing with V8 in WebCore is
pretty big maintenance burden and one I would rather not have in WebKit2 unless
there is considerable demand for it.
In your patch (attached to https://bugs.webkit.org/show_bug.cgi?id=84457),
there are
Without considerable more demand, I don't think we want this.
-Sam
On Apr 23, 2012, at 3:20 PM, Balazs Kelemen kbal...@webkit.org wrote:
On 04/23/2012 11:53 PM, Sam Weinig wrote:
Hi Balazs,
This is something we don't want at this time. Dealing with V8 in WebCore is
pretty big
1 - 100 of 185 matches
Mail list logo
