Re: [webkit-dev] Generating compile_commands.json when building WebKit on MacOS

2020-07-27 Thread Carlos Alberto Lopez Perez
On 25/07/2020 20:16, shriva...@firemail.cc wrote: >> Perhaps you can try to use the WebKitGTK port for Linux ? > You mean that I should try to build WebKitGTK port for Linux on macOS or > simply move to Linux? In theory it is possible to build the WebKitGTK port on MacOS, but in practice i don't

Re: [webkit-dev] Generating compile_commands.json when building WebKit on MacOS

2020-07-22 Thread Carlos Alberto Lopez Perez
On 22/07/2020 10:15, shriva...@firemail.cc wrote: > > Your assistance would be much appreciated. Perhaps you can try to use the WebKitGTK port for Linux ? CMake support for it is actively maintained and should work without any issue. Check: https://trac.webkit.org/wiki/BuildingGtk

[webkit-dev] Proposal to start automating the process of updating imported WPT tests inside WebKit.

2020-03-02 Thread Carlos Alberto Lopez Perez
Hello webkit-dev, I would like to start a discussion about our current process for updating WPT tests, and to see if we can agree on some process to semi-automate it. Currently the process of updating WPT tests its a very manual task which involves: 1. Raise the WPT commit in

Re: [webkit-dev] Enabling debugging for libwebkit on Linux

2020-02-04 Thread Carlos Alberto Lopez Perez
On 03/02/2020 21:11, Ben Greear wrote: > Hello, > > Is there an easy way to add a 'show source' button to the right-click > menu, or enable some > other feature that would help determine what content libwebkit is trying > to render (printing > to stdout is good enough for me). > > Thanks, > Ben

Re: [webkit-dev] Can the WebKit logo be used for WebKit ports? (like WebKitGTK)

2019-10-17 Thread Carlos Alberto Lopez Perez
On 10/10/2019 22:08, Ryosuke Niwa wrote: > People often associate the term "WebKit" with Apple's WebKit port in > practice. The risk here is really about people not understanding the nuance > of port specific bugs & set of features. WebKit's ports are unlike Gecko's > & Blink's because while they

[webkit-dev] Adrian Perez de Castro is now a WebKit reviewer

2019-10-14 Thread Carlos Alberto Lopez Perez
Hi everyone, I would like to announce that Adrian Perez de Castro (aperezdc on #webkit) is now a WebKit reviewer. Adrian has several years of experience working with the WebKitGTK and WPE WebKit ports. He is the release manager of the WPE port and the main developer behind the Cog WPE browser.

Re: [webkit-dev] Issues running remote debug inspector for WPE instance with Epiphany dev preview

2019-10-11 Thread Carlos Alberto Lopez Perez
On 11/10/2019 18:07, Ryan Walklin wrote: > Thanks for letting me know. Is there any workaround not requiring the edits > to the Web Inspector UI mentioned in > https://bugs.webkit.org/show_bug.cgi?id=202321#c4 (which I assume would > necessitate a custom Epiphany build) on Fedora currently?

Re: [webkit-dev] Implementing OffscreenCanvas

2019-10-11 Thread Carlos Alberto Lopez Perez
On 11/10/2019 11:09, Chris Lord wrote: > This sounds good to me, I'll file a bug and write a patch for this. I > assume there are ways of enabling features when tests are run? While a > user (or a developer) using WebKit wouldn't want this feature to be > enabled, I think it should be enabled for

Re: [webkit-dev] Can the WebKit logo be used for WebKit ports? (like WebKitGTK)

2019-10-10 Thread Carlos Alberto Lopez Perez
On 09/10/2019 21:53, Maciej Stachowiak wrote: > In terms of legalities: > > The WebKit logo (as well as the term WebKit) is trademarked by Apple, but > there are acceptable use guidelines in the Terms of Use: > https://webkit.org/terms-of-use/ . I am not a lawyer and cannot give legal >

Re: [webkit-dev] Can the WebKit logo be used for WebKit ports? (like WebKitGTK)

2019-10-09 Thread Carlos Alberto Lopez Perez
On 03/10/2019 00:43, Ryosuke Niwa wrote: > I don't know the rules regarding the logo use but it might be a bit > misleading to use WebKit logo without any qualification for GTK+ port on > wpt.fyi. > > I'd imagine people who visiting wpt.fyi may not realize how different GTK+ > and Apple's WebKit

[webkit-dev] Can the WebKit logo be used for WebKit ports? (like WebKitGTK)

2019-10-02 Thread Carlos Alberto Lopez Perez
Hi, I'm working on having daily runs of WebKitGTK (with minibrowser) at https://wpt.fyi but then I noticed that the WebKitGTK project doesn't have a logo as such. So, I wonder... Would it be OK to use the WebKit logo for the WebKitGTK port? (to show on wpt.fyi at the top of the column for the

Re: [webkit-dev] Hosting precompiled `jsc` binaries for Linux

2017-12-13 Thread Carlos Alberto Lopez Perez
On 12/12/17 21:18, Mathias Bynens wrote: >> We do not have any Linux binaries blessed, approved or endorsed by Apple, >> and we never will, regardless of what domain it's hosted on. However, you >> can get official Linux binaries from parties that own Linux ports. > > If the hosting domain

Re: [webkit-dev] Hosting precompiled `jsc` binaries for Linux

2017-12-12 Thread Carlos Alberto Lopez Perez
On 12/12/17 19:58, Mathias Bynens wrote: > Yes, there is such an expectation. jsvu has a policy of only using URLs > “that are controlled by the creators of the JavaScript engine”: > https://github.com/GoogleChromeLabs/jsvu#security-considerations > > Anything not on *.webkit.org or similar, or

Re: [webkit-dev] Hosting precompiled `jsc` binaries for Linux

2017-12-11 Thread Carlos Alberto Lopez Perez
On 08/12/17 18:07, Lucas Forschler wrote: > If the GTK team wanted to support making these accessible, > they have everything they need. They could either choose to open up > their firewall so external folks could access them. Or, they could put > full archives on build.webkit.org

Re: [webkit-dev] Buildbot upgrade on build.webkit.org

2017-12-10 Thread Carlos Alberto Lopez Perez
On 07/12/17 21:47, Aakash Jain wrote: > For people using build.webkit.org , I would > like to know what pages you use most of the time (e.g.: builder page, > console view etc.) and what are your primary use-cases (purpose to > visit build.webkit.org

Re: [webkit-dev] SVN server broken?

2017-09-08 Thread Carlos Alberto Lopez Perez
On 08/09/17 11:56, Carlos Alberto Lopez Perez wrote: > On 08/09/17 04:07, Ling Ho wrote: >> We have completed server maintenance works. Please email >> ad...@webkit.org if you encounter any problem. > > It seems there is an issue with the SVN server? > Is rejecting both c

[webkit-dev] SVN server broken? (was: Re: Webkit.org server maintenance - 5-7pm PDT, Thu Sep 7, 2017)

2017-09-08 Thread Carlos Alberto Lopez Perez
On 08/09/17 04:07, Ling Ho wrote: > We have completed server maintenance works. Please email > ad...@webkit.org if you encounter any problem. It seems there is an issue with the SVN server? Is rejecting both commits from commit-queue or manually landed. $ git svn dcommit Committing to

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Carlos Alberto Lopez Perez
On 29/08/17 02:37, Keith Miller wrote: > Bundling happens as part of the CMake configuration process, in the > CMake build. In the Xcode build it’s more complicated since we cannot > dynamically choose the files we are going to compile. The onlysolution > I know of is to pre-list a bunch of files

Re: [webkit-dev] Python

2017-08-07 Thread Carlos Alberto Lopez Perez
On 07/08/17 17:44, Andy Estes wrote: >>> last I checked, macOS did not provide a python2 binary either. I am hoping >>> that has changed in the past few years. Has it? >> Nope. > macOS does have /usr/bin/python2.7, though. > That's a good thing. I believe all Linux distros we support have

Re: [webkit-dev] What's the rationale for not including config.h in any header files?

2017-08-04 Thread Carlos Alberto Lopez Perez
On 02/08/17 12:14, Konstantin Tokarev wrote: > FWIW, I use ENABLE_ALLINONE_BUILD=ON as a default build option in Qt > port and don't have any "terrible" development experience. Even when I > need to make a change in file that is not port-specific, usually just > one of AllInOne files needs to be

Re: [webkit-dev] update GCC version?

2017-07-17 Thread Carlos Alberto Lopez Perez
On 05/07/17 17:10, Michael Catanzaro wrote: > On Wed, Jul 5, 2017 at 6:32 AM, Carlos Alberto Lopez Perez > <clo...@igalia.com> wrote: >> I think the default build toolchain should be supported also, >> at least without the requirement of "one year after the release&

Re: [webkit-dev] Bring back ARMv6 support to JSC

2017-07-05 Thread Carlos Alberto Lopez Perez
On 05/07/17 23:24, Saam barati wrote: > What’s the testing plan here? Do y'all plan to add a bot that ensures ARMv6 > stays working? > > - Saam We do. I will deploy one at https://build-webkit.igalia.com/waterfall?category=misc ASAP (hopefully this week), and then propose a patch to move it to

Re: [webkit-dev] update GCC version?

2017-07-05 Thread Carlos Alberto Lopez Perez
On 23/06/17 19:55, Michael Catanzaro wrote: > On Fri, Jun 23, 2017 at 12:36 PM, Yusuke SUZUKI > wrote: >> It's middle of 2017! And Debian stable is released. >> >> We discussed a bit about updating GCC and MSVC in [1]. >> Based on the comment from JF[1], I think start of

[webkit-dev] WebKit project in Coverity

2017-06-02 Thread Carlos Alberto Lopez Perez
Hi, Coverity is an static analysis tool that allows to find bugs and vulnerabilities on the source code via static analysis. For open source projects, they offer free usage of their platform. The WebKit project is already registered there since a while. [1] To read the reports in detail or run

Re: [webkit-dev] Commits in branches triggering build in the bots now

2017-05-04 Thread Carlos Alberto Lopez Perez
On 05/05/17 00:55, Carlos Alberto Lopez Perez wrote: > But the buildbot config should only trigger branches for changes on > trunk due to the change_filter": "trunk_filter" below: I mean: "But the buildbot config should only trigger _builds_ for signature.asc De

Re: [webkit-dev] Commits in branches triggering build in the bots now

2017-05-04 Thread Carlos Alberto Lopez Perez
On 05/05/17 00:24, Lucas Forschler wrote: > Hi Carlos! > > I recently updated the svn post commit hook to use the newest version of > svn_buildbot.py from > https://github.com/buildbot/buildbot-contrib/blob/master/master/contrib/svn_buildbot.py > >

Re: [webkit-dev] Compile time increase over time

2017-04-24 Thread Carlos Alberto Lopez Perez
On 24/04/17 21:02, Konstantin Tokarev wrote: > > 24.04.2017, 21:10, "Alex Christensen" : >> Thanks for the data, Carlos! This is a growing problem that is hurting >> productivity. We’ve discussed it a bit and haven’t done enough about it. >> Here are some of the ideas

[webkit-dev] Compile time increase over time

2017-04-24 Thread Carlos Alberto Lopez Perez
Hi, Inspired by a similar thread on the Chromium mailing lists [1], I have measured the build times of WebKitGTK+ over the past 2.5 years. I benchmarked two different compilers (GCC and Clang). The summary is: since September 2014 the time for building WebKitGTK+ has increased in a 62% for GCC

Re: [webkit-dev] Carlos Alberto Lopez Perez is now a WebKit Reviewer

2017-03-30 Thread Carlos Alberto Lopez Perez
On 30/03/17 19:10, Mark Lam wrote: > Hi folks, > > I just want to announce that Carlos Alberto Lopez Perez (clopez on > #webkit) is now a WebKit Reviewer. Carlos has been contributing on the > WebKitGTK+ port and has expertise on tools and build/test > infrastructu

Re: [webkit-dev] build.webkit.org transition today at 3pm PDT

2017-03-22 Thread Carlos Alberto Lopez Perez
On 17/03/17 17:30, Lucas Forschler wrote: > Hi Carlos, > > The results folder is being copied over, it’s just taking a long time since > it’s many TB of data. > > Interesting on the build counter being reset to zero… that is unexpected. I > will investigate. Thanks for pointing it out! > >

Re: [webkit-dev] build.webkit.org transition today at 3pm PDT

2017-03-17 Thread Carlos Alberto Lopez Perez
On 16/03/17 22:40, Ling Ho wrote: > Hello WebKit developers: > > We are continuing our transitioning of webkit.org servers today and > tomorrow. Between 3pm and 4pm Pacific, we will be moving > build.webkit.org. Please email us at ad...@webkit.org if you encounter > any issue with your build bots

Re: [webkit-dev] MiniBrowser

2017-03-15 Thread Carlos Alberto Lopez Perez
On 15/03/17 13:46, Jerry Geis wrote: > I am running CentOS 7 and MiniBrowser... > I am running XMLhttprequest() with a URL like > http://localhost:6500/FrameCheck > To see if the there is a new URL to load into a frame. > > I run the inspect Element and view the console and I see > > Failed to

Re: [webkit-dev] SVN trouble

2017-02-24 Thread Carlos Alberto Lopez Perez
On 24/02/17 20:16, Alexey Proskuryakov wrote: > > How does one create a local git-svn checkout to try this out? Given that > the offending file has been effectively deleted from svn, I think that > git-svn should work too. You have the script: Tools/Scripts/webkit-patch setup-git-clone And

Re: [webkit-dev] SVN trouble

2017-02-24 Thread Carlos Alberto Lopez Perez
On 24/02/17 18:46, Carlos Alberto Lopez Perez wrote: > On 24/02/17 18:08, Alexey Proskuryakov wrote: >> >>> 24 февр. 2017 г., в 7:48, Antti Koivisto <koivi...@iki.fi >>> <mailto:koivi...@iki.fi>> написал(а): >>> >>> Hi, >>> >>

Re: [webkit-dev] SVN trouble

2017-02-24 Thread Carlos Alberto Lopez Perez
On 24/02/17 18:08, Alexey Proskuryakov wrote: > >> 24 февр. 2017 г., в 7:48, Antti Koivisto > > написал(а): >> >> Hi, >> >> Looks like https://bugs.webkit.org/show_bug.cgi?id=168774 caused some >> sort of SVN problem. Please hold commits until this is

Re: [webkit-dev] SVN trouble

2017-02-24 Thread Carlos Alberto Lopez Perez
On 24/02/17 18:08, Alexey Proskuryakov wrote: > >> 24 февр. 2017 г., в 7:48, Antti Koivisto > > написал(а): >> >> Hi, >> >> Looks like https://bugs.webkit.org/show_bug.cgi?id=168774 caused some >> sort of SVN problem. Please hold commits until this is

Re: [webkit-dev] update GCC version?

2017-01-09 Thread Carlos Alberto Lopez Perez
On 09/01/17 16:47, Michael Catanzaro wrote: > On Mon, 2017-01-09 at 16:39 +0100, Carlos Alberto Lopez Perez wrote: >> I strongly oppose to do (a). Also, it is false that Debian doesn't >> take >> our updates. They take our updates in the backports repository for >&g

Re: [webkit-dev] update GCC version?

2017-01-09 Thread Carlos Alberto Lopez Perez
On 09/01/17 01:09, Michael Catanzaro wrote: > On Sun, 2017-01-08 at 18:59 +0100, z...@falconsigh.net wrote: >> For the record, GCC 5 has complete C++14 support. The current >> requirement is 4.9, so the bump would be minimal. >> https://gcc.gnu.org/projects/cxx-status.html#cxx14 > We would need to

Re: [webkit-dev] SPAM on trac.webkit.org

2016-04-29 Thread Carlos Alberto Lopez Perez
On 29/04/16 19:58, Lucas Forschler wrote: >> I wonder if it would be possible to also allow contributors (as listed >> in the "Contributors" field of contributors.json) to edit the wiki? >> >> We have a need to allow WebKitGTK+ gardeners (some of them still not >> committers) to edit the WiKi. >

Re: [webkit-dev] SPAM on trac.webkit.org

2016-04-29 Thread Carlos Alberto Lopez Perez
On 21/04/16 19:30, Lucas Forschler wrote: > Hello everyone, > > I’d like to follow up on the current wiki situation. > > In the past, any authenticated trac.webkit.org user was allowed to > modify or create wiki entries. However, with the recent spam > infiltration, this is no longer viable. To

Re: [webkit-dev] Build slave for JSCOnly Linux MIPS

2016-04-19 Thread Carlos Alberto Lopez Perez
On 18/04/16 21:50, Filip Pizlo wrote: > I don't want a buildbot for MIPS. It's not a relevant architecture > anymore. I don't think that JSC developers should have to expend > effort towards keeping this architecture working. > MIPS is still relevant on embedded devices (mainly set-top boxes).

Re: [webkit-dev] Some text about the B3 compiler

2016-02-03 Thread Carlos Alberto Lopez Perez
On 02/02/16 00:27, Ryosuke Niwa wrote: > > We've been running those benchmarks with > http://trac.webkit.org/browser/trunk/Tools/Scripts/run-benchmark > > It might be useful for Mac and other ports to have bots available on > build.webkit.org as well. > After discussing this with Carlos

Re: [webkit-dev] Some text about the B3 compiler

2016-02-02 Thread Carlos Alberto Lopez Perez
On 02/02/16 00:27, Ryosuke Niwa wrote: > On Mon, Feb 1, 2016 at 7:32 AM, Carlos Alberto Lopez Perez > <clo...@igalia.com> wrote: >> On 31/01/16 05:16, Filip Pizlo wrote: >>> As my original message said, I was wondering if there was any support >>> for runni

Re: [webkit-dev] Some text about the B3 compiler

2016-02-02 Thread Carlos Alberto Lopez Perez
On 02/02/16 19:58, Ryosuke Niwa wrote: > On Tue, Feb 2, 2016 at 10:42 AM, Carlos Alberto Lopez Perez >> But this script seems focused on comparing the performance between >> different browsers (safari vs chrome vs firefox) rather than in testing >> and comparing the performa

Re: [webkit-dev] Some text about the B3 compiler

2016-02-01 Thread Carlos Alberto Lopez Perez
On 31/01/16 05:16, Filip Pizlo wrote: > As my original message said, I was wondering if there was any support > for running some JavaScript tests *in browser*. run-jsc-stress-tests > doesn’t support that because it doesn’t know what a browser is. > > Some tests, like Kraken, Octane, JetStream,

Re: [webkit-dev] Thought about Nix JavaScriptCore port

2016-02-01 Thread Carlos Alberto Lopez Perez
On 01/02/16 00:22, Eric Wing wrote: >> Updated version of patch is here: >> > >> > https://github.com/annulen/webkit/commit/80e914373fc0702708e9fda0cee36ae5ccc22339 >> > > > This is very cool. Thank you for doing this. I did something very > similar in order to build JavaScriptCore for Android.

[webkit-dev] How to deal with 1-pixel differences in reftests ?

2015-11-18 Thread Carlos Alberto Lopez Perez
Hi, Some reference tests give a 1-pixel or very few pixel differences [1]. I'm not sure if this really indicates a problem in the WebKit code, or it indicates that we are just too strict not allowing even a very small percentage in pixel differences for this kind of tests. Should we tolerate a

Re: [webkit-dev] Switching servers for EWS and flakiness dashboard

2015-07-31 Thread Carlos Alberto Lopez Perez
On 30/07/15 17:30, Alexey Proskuryakov wrote: Hi, Which are the bots that you found missing? I don't expect any changes to how frequently the dashboard code is updated just because of the switch. However, the code is in svn (Tools/TestResultServer), so you are encouraged to update the

Re: [webkit-dev] Running new/modified tests on EWS bots

2015-03-19 Thread Carlos Alberto Lopez Perez
On 19/03/15 16:46, youenn fablet wrote: Hi, Related to the webkit contributor meeting discussion related to ports, I would find it useful if EWS bots (gtk, efl, win, ios) were running the tests that are modified/created by a patch. The idea would be to turn yellow the port bubble whenever