Re: [webkit-dev] LocalStorage spec and structured cloning

On Fri, Jun 3, 2011 at 1:40 AM, Jeremy Orlow wrote: > You can't store much data in cookies and thus you're only shooting yourself > in the foot with a bb gun. 5mb means you're shooting yourself in the foot > with a real gun. And if you're allowing over 5mb, it&#

Re: [webkit-dev] LocalStorage spec and structured cloning

You can't store much data in cookies and thus you're only shooting yourself in the foot with a bb gun. 5mb means you're shooting yourself in the foot with a real gun. And if you're allowing over 5mb, it's a bazooka. Anyway, I've written extensively about this many times on many different lists.

Re: [webkit-dev] bugid in ChangeLog

On Mon, Mar 28, 2011 at 11:51 AM, Jeremy Orlow wrote: > On Mon, Mar 28, 2011 at 11:48 AM, Maciej Stachowiak wrote: > >> I think it's better to have no exceptions than a very narrow exception. >> > > This seems to be a reason for saying we should always have a bug f

Re: [webkit-dev] bugid in ChangeLog

On Mon, Mar 28, 2011 at 11:48 AM, Maciej Stachowiak wrote: > I think it's better to have no exceptions than a very narrow exception. > This seems to be a reason for saying we should always have a bug for anything that's reviewed... J ___ webkit-dev ma

Re: [webkit-dev] bugid in ChangeLog

it's possible to claim it's useful here: http://trac.webkit.org/changeset/81864 J > On Mon, Mar 28, 2011 at 9:58 AM, Jeremy Orlow wrote: > >> Can you please explain why? Its very little overhead and is useful for >> tracking regressions and such. >> >>

Re: [webkit-dev] bugid in ChangeLog

Can you please explain why? Its very little overhead and is useful for tracking regressions and such. J On Mar 28, 2011 9:52 AM, "Darin Adler" wrote: > On Mar 27, 2011, at 1:31 AM, Jeremy Orlow wrote: > >> I'd even go a bit further and say that if something is worth

Re: [webkit-dev] bugid in ChangeLog

On Sat, Mar 26, 2011 at 2:26 PM, Patrick Gansterer wrote: > > Am 26.03.2011 um 19:30 schrieb Brent Fulgham: > > I don't want to have a bug report for everything either, but I do agree > that my failure to include it in the changelog for the FontPlatformData > change was a stupid oversight. > > I'l

Re: [webkit-dev] Towards a unified build system

On Tue, Mar 1, 2011 at 1:59 PM, David Levin wrote: > On Tue, Mar 1, 2011 at 1:13 PM, Jeremy Orlow wrote: > > We could quickly find ourselves in the position of generating build files > > for many different ports every time we submit patches, which could add > > several

Re: [webkit-dev] Towards a unified build system

On Tue, Mar 1, 2011 at 11:08 AM, Nikolas Zimmermann < zimmerm...@physik.rwth-aachen.de> wrote: > > Am 01.03.2011 um 18:33 schrieb Maciej Stachowiak: > > > > > On Mar 1, 2011, at 5:18 AM, Adam Roben wrote: > > > >> Reducing the number of build systems is a face-meltingly worthy goal. I > have one s

Re: [webkit-dev] Getting CC-ed on webkit.org/new-inspector-bug

It seems like it'd be nice to be able to watch bugs that are assigned to someone too though. On Thu, Feb 10, 2011 at 11:18 AM, Alexey Proskuryakov wrote: > > 10.02.2011, в 10:58, Darin Fisher написал(а): > > What Mozilla does is they set the "QA Contact" field to an email address of > the form @

Re: [webkit-dev] Using Visual Studio 2010 for Apple's Windows WebKit port

How hard will the transition be? If it's going to take a lot of time and cause a lot of churn anyway, would this be a good time to try and make that port use GYP or CMake? (I assume the answer is probably no, but figured it was worth asking anyway. :-) J On Mon, Jan 31, 2011 at 12:46 PM, Adam R

Re: [webkit-dev] Same Origin Restriction on WOFF fonts across WebKit

On Fri, Jan 28, 2011 at 3:11 PM, Maciej Stachowiak wrote: > > On Jan 28, 2011, at 3:06 PM, Tab Atkins Jr. wrote: > > > The WOFF font specification requires that browsers apply Same Origin > > Restrictions (SOR) to WOFF fonts. So far, Firefox and IE9 follow this > > requirement, while we and Oper

Re: [webkit-dev] Blog post(s) about layout tests

On Thu, Jan 27, 2011 at 9:32 AM, Ryan Leavengood wrote: > On Tue, Jan 25, 2011 at 9:24 PM, Mihai Parparita > wrote: > > The post is link-heavy (generally into Trac, and > > Bugzilla), I'm hoping that would also encourage exploration of the > code/site > > by people interested in contributing. > >

Re: [webkit-dev] Using Git for WebKit development

The info is on https://trac.webkit.org/wiki/UsingGitWithWebKit as well. On Tue, Jan 18, 2011 at 8:42 AM, Philippe Normand wrote: > On Tue, 2011-01-18 at 11:26 +0300, Konstantin Tokarev wrote: > > Hi all, > > > > When I'm trying to cherry-pick or rebase something in my WebKit git > clone, > > I co

Re: [webkit-dev] RuntimeEnabledFeatures for JSC (was RE: Getting at Settings object from WorkerContext)

On Thu, Jan 6, 2011 at 8:57 PM, Adam Barth wrote: > On Thu, Jan 6, 2011 at 12:47 PM, Darin Adler wrote: > > On Jan 6, 2011, at 12:41 PM, Joe Mason wrote: > >> I took a look at CodeGeneratorJS.pm to see how hard it would be to port > this over. I have no idea where to start… The structure of > C

Re: [webkit-dev] Getting at Settings object from WorkerContext

2011 at 7:38 PM, Jeremy Orlow wrote: > Hmm. It might still be v8-only, though I'm surprised since the class was > moved from the v8 directory to generic. If that's the case, then I suppose > it'll need to be ported to JSC. > > J > > On Thu, Jan 6, 2011 at 7:

Re: [webkit-dev] Getting at Settings object from WorkerContext

ce that RuntimeEnabledFeatures is referenced in CodeGeneratorV8.pm, > but not any other code generator. Is this a V8-only thing? > > > > Joe > > > > *From:* webkit-dev-boun...@lists.webkit.org [mailto: > webkit-dev-boun...@lists.webkit.org] *On Behalf Of *Joe Mason > *

Re: [webkit-dev] Getting at Settings object from WorkerContext

The RuntimeEnabledFeatures class [1] seems like what you're looking for. J [1] http://codesearch.google.com/codesearch/p?hl=en#OAMlx_jo-ck/src/third_party/WebKit/WebCore/bindings/generic/RuntimeEnabledFeatures.h&q=RuntimeFeature&exact_package=chromium&d=6 On Thu, Jan 6, 2011 at 6:05 PM, Joe Maso

Re: [webkit-dev] Tip: Use 64-bit git binaries on Mac OS X

For what it's worth, on my 12GB of ram mac pro: $ sudo sysctl -w kern.maxvnodes=384000 kern.maxvnodes: 197632 -> 384000 Took times from 2.11-2.06 down to 2.05-2.02. I.e. it made a small difference, but not much. The 64 bit patch definitely seemed to help, but I didn't think to time before and a

Re: [webkit-dev] [chromium] using WEBKIT_API properly

You forgot to mention virtual functions, which is another case where you do _not_ use WEBKIT_API. J On Thu, Dec 2, 2010 at 9:27 PM, Darin Fisher wrote: > If you do not work on the Chromium port of WebKit, you can stop reading > now. > > I've noticed that there is some confusion about how to use

Re: [webkit-dev] Why are the mock implementations in WebCore/platform?

Note that it's still a bit of an open question as to where mocks should live in general. IIRC, the top candidates are like device orientation and speech do now, somehow in some central place but not compiled into production libraries, or in DRT (which means more copied code, but the platform layers

Re: [webkit-dev] Enhancements

On Tue, Nov 23, 2010 at 10:51 PM, Jack Allegrezza wrote: > Hello, >I am proposing that WebKit have an "Enhancements" ability - Here is > what the reason is - with abilities of WebKit to draw and handle THML,SVG, > Canvas and Video, along with access to resources via AJAX and WebSockets and

Re: [webkit-dev] Buildbots soon to require apache mod_bw

On Fri, Nov 5, 2010 at 11:53 AM, Gustavo Noronha Silva wrote: > On Fri, 2010-11-05 at 01:52 -0700, Eric Seidel wrote: > > This is a bad idea. Please don't do this. > > > > Unless mod_bw comes installed in a normal Apache distribution, you're > > asking that *every* webkit developer install mod_bw

Re: [webkit-dev] Tiger?

Ping? On Mon, Oct 11, 2010 at 9:26 AM, Adam Barth wrote: > I don't see a Tiger buildbot anymore. Does that mean I'm allowed to > break the Tiger build? If so, can we rip out all the Tiger-specific > code? > > Adam > ___ > webkit-dev mailing list > we

Re: [webkit-dev] Pixel test experiment

ss rebaselines in > WebKit currently? We've built a number of tools to deal with the Chromium > expectations, but since this has been a need unique to Chromium so far the > tools only work for Chromium. > > - James > > On Fri, Oct 8, 2010 at 11:18 PM, Nikolas Zimmerm

Re: [webkit-dev] Pixel test experiment

I'm not an expert on Pixel tests, but my understanding is that in Chromium (where we've always run with tolerance 0) we've seen real regressions that would have slipped by with something like tolerance 0.1. When you have 0 tolerance, it is more maintenance work, but if we can avoid regressions, it

Re: [webkit-dev] Pixel test experiment

This does seem like a great idea. The more pixel tests we can run on the bots, the better! J On Thu, Oct 7, 2010 at 11:06 AM, Dirk Schulze wrote: > I strongly support pixel tests for SVG on the bots! Niko and me are hard > working to get SVG pxiel perfect at all time. We run pixel tests on eve

[webkit-dev] Upgrading VS (WAS: Any objections to switching to Xcode 3.2.4 or newer?)

Although this is a noble goal, wouldn't it require either 1) Us maintaining yet another build system or 2) Any Windows based WebKit hackers needing to upgrade their Visual Studio...which would require $$? [1] Either way, what's our migration plan (since we can't use VS 2005 forever)? J [1] Yes

Re: [webkit-dev] landed

Given that a ping really doesn't open up any new privacy holes (just makes it easier for sites to get the data they're going to gather anyway without slowing down the experience for the user), it seems like we might as well enable it by default. If a port doesn't want it, they can always disable i

Re: [webkit-dev] Disable sheriffbot bug posts?

They've also helped me on occasion. I get enough bug spam already that even in the worst case, I don't find the notices all that obtrusive. More useful messages would be nice though. J On Thu, Sep 23, 2010 at 10:28 PM, Geoffrey Garen wrote: > > Does anyone find the sheriffbot bug posts useful

Re: [webkit-dev] Bug system: Platform and OS fields don't quite align

On Tue, Sep 14, 2010 at 6:32 PM, David Levin wrote: > > > On Tue, Sep 14, 2010 at 10:28 AM, Adam Barth wrote: > >> We're not very good at using these fields in Bugzilla. In this >> situation, folks will usually prefix the summary of the bug with >> "[Chromium]". This is a signal to reviewers t

Re: [webkit-dev] GTK Skiplist

is in a broadcast manner. (If it were some nit in a particular part of a code, I would have done it differently.) Btw, I find it humorous that, by your own logic, you probably should have sent your rebuke in a private email. :-) J > dave > > On Fri, Sep 3, 2010 at 9:54 AM, Jer

Re: [webkit-dev] GTK Skiplist

I promise to only put IndexedDB tests in the indexeddb directory. :-) On Fri, Sep 3, 2010 at 5:52 PM, Darin Adler wrote: > On Sep 3, 2010, at 5:50 AM, Jeremy Orlow wrote: > > > Recently in a code review for IndexedDB, I was told that I should be > adding every test individuall

[webkit-dev] GTK Skiplist

Recently in a code review for IndexedDB, I was told that I should be adding every test individually to GTK's skip list. The reason cited was this comment at the top "# Also, no grouping should occur. Every test for itself." For features like IndexedDB which are not turned on by a port, is it stil

Re: [webkit-dev] How to specify files to be copied to WebKitBuild/Debug/WebCore.framework/PrivateHeaders/ ?

Is this documented somewhere? It seems like it comes up every now and then and can be quite frustrating. On the other hand, I really don't know where makes sense to document it. :-) Note that this is also what you do when needing to export something form wtf. J On Thu, Sep 2, 2010 at 12:37 PM

Re: [webkit-dev] Arena is crufty?

Isn't ref counting supposed to be _really_ optimized for exactly this use? It seems like a good match--unless you have major issues with cycles...which might be the issue? J On Thu, Sep 2, 2010 at 3:20 AM, Kenneth Russell wrote: > I would be happy to not add another Arena client, but the prima

Re: [webkit-dev] Misplaced files

like this in the past. Also, is there a reason why they're necessary? > On Tue, Aug 31, 2010 at 9:00 AM, Jeremy Orlow wrote: > >> You're talking about the "module" part of the IDL? Is that even used by >> anything or specified anywhere? As far as I can tell, t

Re: [webkit-dev] Misplaced files

be a good idea. > > On Tue, Aug 31, 2010 at 3:02 AM, Jeremy Orlow wrote: > >> On Mon, Aug 30, 2010 at 5:17 PM, Darin Fisher wrote: >> >>> On Mon, Aug 30, 2010 at 9:11 AM, Maciej Stachowiak wrote: >>> >>>> >>>> On Aug 30, 2010, at 8:36 AM

Re: [webkit-dev] Script programming language: Perl, Python, or Ruby?

The fewer languages we use, the easier it is for people to hack on stuff. Python is especially nice because it's optimized for readability and predictability, so it's more approachable to people who aren't experts in that language. If we currently have only a small dependency on Ruby, it makes se

Re: [webkit-dev] Misplaced files

On Mon, Aug 30, 2010 at 5:17 PM, Darin Fisher wrote: > On Mon, Aug 30, 2010 at 9:11 AM, Maciej Stachowiak wrote: > >> >> On Aug 30, 2010, at 8:36 AM, Darin Fisher wrote: >> >> On Mon, Aug 30, 2010 at 12:18 AM, Adam Barth wrote: >> >>> On Fri, Aug 27, 2010 at 8:12 PM, Maciej Stachowiak >>> wrot

Re: [webkit-dev] Place For new Core Module

On Tue, Aug 24, 2010 at 11:50 PM, Chinmaya Sn wrote: > Thanks All. I think I am getting the general idea of what can get into > to WebKit and how things fit. > > Right now both the standard and implementation are WIP, spec is intended to > be a Web standard. At this point, neither the standard no

Re: [webkit-dev] Not enough space message when linking webkit (lots of free disk space)

The Kernel usually reserves 1/4 (but up to 3/4 on some OSes) of the address space for itself + you can get fragmentation. So the linker only can use part of the 4gb of ram in your machine. So switching to a 64 bit linker would probably fix the problem for now. Another option is to disable some p

Re: [webkit-dev] Getting rid of WebCore.xcodeproj developmentRegion diff

In that case, can we please standardize on the Xcode 3 behavior and ask those using the beta to keep it out manually? J On Tue, Aug 17, 2010 at 7:41 PM, Jeff Johnson wrote: > Actually, this is caused by Xcode 4 (still in beta). > > See rdar://problem/8295614 Xcode 4 fights with Xcode 3 over > d

Re: [webkit-dev] Tests that separate JS and HTML

On Fri, Aug 13, 2010 at 11:17 AM, Alexey Proskuryakov wrote: > > On multiple occasions, I've been noticing that separating JavaScript for > tests into its own file has been causing me pain. There are several > disadvantages that I know of: > > 1. One doesn't see test content when a tool (such as

Re: [webkit-dev] Throwing SECURITY_ERR on cross-origin window.location property accesses

On Fri, Aug 13, 2010 at 8:42 AM, Maciej Stachowiak wrote: > > On Aug 12, 2010, at 8:08 PM, Mihai Parparita wrote: > > I was wondering if it would be a reasonable change to make accessing > location.href (and other location properties) throw SECURITY_ERR when > accessed across origins (https://web

Re: [webkit-dev] Build system complexity

projects on the mac port) is out of hand--and has been for some time. And I'm hoping we can come to some sort of conclusion that'll start the project moving in the right direction--even if it's slowly. That's it. I promise! J On Thu, Aug 12, 2010 at 3:37 PM, Jeremy Orlow wro

Re: [webkit-dev] Build system complexity

On Thu, Aug 12, 2010 at 7:18 AM, David Kilzer wrote: > On Aug 12, 2010, at 3:54 AM, Dumitru Daniliuc wrote: > > > i completely agree with jeremy. is it possible to at least drop the > cryptic hashcodes/timestamps? without them, the .xcodeproj files should at > least be editable by hand. > > Does

[webkit-dev] Build system complexity

Are there currently any plans for simplifying the situation regarding build systems? I haven't seen any threads for a while, which I assume means no. Is there any low hanging fruit out there? Since many of the build systems are little more than lists of files, it really seems like we should be a

Re: [webkit-dev] HTML5 tree builder enabled

Impressive! Thanks Eric+Adam for all the work on this! You guys are quite a team. J On Thu, Aug 5, 2010 at 9:10 AM, Adam Barth wrote: > The HTML5 tree builder is enabled as of > . Check out our awesome > SVG-in-HTML demo (in a post r64712 build, of cou

Re: [webkit-dev] Some new coding style rules

On Wed, Aug 4, 2010 at 9:29 AM, Nikolas Zimmermann < zimmerm...@physik.rwth-aachen.de> wrote: > Good morning WebKit crowd, > > I'd like to discuss some style issues, that I'm frequently unsure about: > > 1. namespace closing brace > It was discussed in > http://article.gmane.org/gmane.os.opendarwi

Re: [webkit-dev] Rendering a PDF on an HTML5 Canvas using WebKit/AIR

This is not the right mailing list for such questions. Please see http://webkit.org/contact.html On Tue, Aug 3, 2010 at 4:26 AM, Andrew Sealy-Bell < andyamsterdam2...@gmail.com> wrote: > Hi, > > I'd like to know if anybody has experience with rendering a PDF on an HTML5 > canvas? I'd like to to

Re: [webkit-dev] Sharing WebKit mocks across platforms

Why wasn't it done that way originally? That sounds (to my uneducated ear) much better than what's done today. J On Thu, Jul 29, 2010 at 11:19 PM, Adam Barth wrote: > WebCore::LayoutTestController would be exposed to JavaScript running > in LayoutTests directly (like the DOM), so we can skip t

Re: [webkit-dev] Remove me from your mailing list..

Seriously? It's the first result: http://www.lmgtfy.com/?q=webkit-dev Clearly you overly value your own time if you couldn't even do a quick search on how to properly unsubscribe and instead spammed an entire mailing list. J On Mon, Jul 12, 2010 at 11:23 AM, Johnson, Christopher < christopher.j

Re: [webkit-dev] Frustrated at inconsiderate behavior

On Fri, Jul 9, 2010 at 2:14 AM, Xan Lopez wrote: > On Thu, Jul 8, 2010 at 8:09 PM, Adam Barth wrote: > > Originally, we had the commit-queue to land only if all the core > > builders were green. One recent change we made to make the > > commit-queue more agressive is to land when the commit-que

Re: [webkit-dev] Does any port implements Navigator.registerProtocolHandler and Navigator.registerContentHandler?

That would be the standard thing to do. The sooner someone gets started on the feature, the easier it'll be to revert the patch that removes the code. :-) J On Thu, Jul 8, 2010 at 10:55 AM, David Levin wrote: > > > On Wed, Jul 7, 2010 at 5:24 PM, Peter Kasting wrote: > >> On Wed, Jul 7, 2010

[webkit-dev] Frustrated at inconsiderate behavior

On Thu, Jul 8, 2010 at 10:19 AM, Oliver Hunt wrote: > > On Jul 7, 2010, at 7:16 PM, Tony Gentilcore wrote: > > > > On Wed, Jul 7, 2010 at 6:50 PM, Mo, Zhenyao wrote: > >> Maybe I should complain this in a different threads, but recently the >> commit bot waiting time is way too long. Several ti

Re: [webkit-dev] Frustrated at inconsiderate behavior

On Thu, Jul 8, 2010 at 2:03 AM, Alexey Proskuryakov wrote: > > 07.07.2010, в 9:49, Jeremy Orlow написал(а): > > Why did not one of those people roll the patch out when it was clear that > there were failures and Alexey wasn't in the process of fixing them? >

Re: [webkit-dev] Frustrated at inconsiderate behavior

I agree with Maciej's response, but at the same time I can understand why Adam was so frustrated. He (and others) have pointed out stuff like this on and off list over and over again with little apparent change... But that's not what I'm most worried about; why this was broken in the tree for 12

Re: [webkit-dev] strategy for evaluating performance issues related to memory.

On Mon, Jun 21, 2010 at 7:08 PM, Mike Marchywka wrote: > > > Unless you're actively working on this problem within WebKit, these > emails seem out of scope for webkit-dev. > > The topic addresses this doesn't it? I would think that outlining a > development strategy would be "actively working." >

Re: [webkit-dev] strategy for evaluating performance issues related to memory.

On Mon, Jun 21, 2010 at 2:21 PM, Mike Marchywka wrote: > > > So where does this stand right now? I hope to actually contribute at some > point. > but right now I'm just trying to determine approaches to even finding the > problems. > ( and yes my disk light still comes on for minutes at a time lo

Re: [webkit-dev] A proposal for "Platform Mechanisms"

Overall, looks great!! On Wed, Jun 16, 2010 at 6:05 PM, Anders Carlsson wrote: > > Also, PlatformMechanism is a Factory, and should be named accordingly. Or > maybe it's a Source of clients/mechanisms. > > > > Good point, it is a factory. > Is it a factory? If so, I'd expect it to return Pass

Re: [webkit-dev] Style question: static, protected, or public members

On Sun, Jun 13, 2010 at 12:46 AM, Maciej Stachowiak wrote: > > On Jun 4, 2010, at 3:54 PM, Joe Mason wrote: > > > I'm strongly in favour of g_. It seems weird and ugly to me to have > > prefixes for some non-local scopes but not all. And it's very helpful > > to be able to look at a variable re

Re: [webkit-dev] Pyjamas-Desktop patch to webkit ??

Apologies. Given that no one had responded, I just assumed that it was still abandoned. On Wed, Jun 9, 2010 at 11:09 AM, Xan Lopez wrote: > On Wed, Jun 9, 2010 at 12:05 PM, Jeremy Orlow wrote: > > The patch needs a champion who's willing to take the time to get it into >

Re: [webkit-dev] Pyjamas-Desktop patch to webkit ??

The patch needs a champion who's willing to take the time to get it into landable shape. This mainly means splitting it up into small bits for review, cleaning up the code, and fixing problems brought up in review. It will probably require a lot of work. J On Sat, Jun 5, 2010 at 8:34 PM, Sarava

Re: [webkit-dev] sick of forgetting bugzilla email addresses?

This will save me so many iterations of trying a name into gmail and then copying it over to bugzilla. :-) Thanks Ojan! On Mon, Jun 7, 2010 at 9:28 PM, Adam Barth wrote: > Wow, that's pretty awesome. Thanks Ojan. > > Adam > > > On Mon, Jun 7, 2010 at 1:25 PM, Ojan Vafai wrote: > > I sure am.

Re: [webkit-dev] How to handle a new protocol for Blob.url support?

On Thu, Jun 3, 2010 at 2:08 AM, Darin Adler wrote: > On Jun 1, 2010, at 5:14 PM, Jian Li wrote: > > I am working on Blob.url support as defined in the latest version of File > API (http://dev.w3.org/2006/webapi/FileAPI/). The Blob.url will return a > URL that can be used to refer to the blob obje

Re: [webkit-dev] Troubles with Chromium DEPS roll (in WebKit)

Oh, and until you can find someone to help you with the bot, the best course of action is probably to roll back your change. Sheriffbot on #webkit can help. On Tue, Jun 1, 2010 at 1:10 PM, Jeremy Orlow wrote: > On Tue, Jun 1, 2010 at 1:08 PM, Jeremy Orlow wrote: > >> This mai

Re: [webkit-dev] Troubles with Chromium DEPS roll (in WebKit)

On Tue, Jun 1, 2010 at 1:08 PM, Jeremy Orlow wrote: > This mail is full of etiquette fail. First of all, you've now cross posted > between webkit-dev and chromium-dev (using the @googlegroups address which > was deprecated) so the majority of people who might respond can only

Re: [webkit-dev] Style question: static, protected, or public members

On Tue, May 25, 2010 at 12:19 AM, Darin Adler wrote: > On May 20, 2010, at 8:54 PM, TAMURA, Kent wrote: > > > What's the naming rule for non-const static members? > > > > Some classes give "s_" prefixes: > > WebCore/page/DOMTimer.h:static double s_minTimerInterval; > > WebCore/page/Geoloc

Re: [webkit-dev] What is the webkit-patch version of svn-unapply?

On Wed, May 19, 2010 at 7:15 PM, Adam Barth wrote: > On Wed, May 19, 2010 at 11:06 AM, Darin Adler wrote: > > On May 19, 2010, at 10:56 AM, Adam Barth wrote: > > > >> On Wed, May 19, 2010 at 10:41 AM, Darin Adler wrote: > >>> Lets say I just did "webkit-patch upload" and I am Subversion user an

Re: [webkit-dev] Need more diagnostic information for ApplicationCache events

If you want to change the web platform (which adding information to events is), sending an email to WhatWG [1] is probably the right first step. The other option is to think about how to extend the existing developer tools to aid in debugging. Personally, that makes more sense to me, and I believ

Re: [webkit-dev] Local Storage (SQL Database) not working in my app built with XCode

See the enable functions in WebCore/page/Settings.h. On Fri, May 14, 2010 at 2:48 PM, Adam Thorsen wrote: > I've got a minimal browser app that is linked against the WebKit framework > that I'm building with XCode. I'm developing a website that uses some HTML5 > local storage features, including

Re: [webkit-dev] Ancient patches in pending-review

On Thu, May 13, 2010 at 5:41 PM, David Levin wrote: > > > On Thu, May 13, 2010 at 9:12 AM, Adam Barth wrote: > >> One of the least fun things in the project is to pour a bunch of >> effort into writing a patch only to see it sit forever waiting for >> review. In the past, I've tried to single-h

Re: [webkit-dev] Yet another bug-less change hosed the tree.

On Tue, May 11, 2010 at 10:11 PM, Geoffrey Garen wrote: > > We require a ChangeLog for every patch. Isn't that a TPS report? > > No. A ChangeLog is much less time-consuming to manage. > For me, letting webkit-patch make the bug for me and post updates to the bug is maybe 10-15 seconds longer th

Re: [webkit-dev] Yet another bug-less change hosed the tree.

On Tue, May 11, 2010 at 5:51 PM, Alexey Proskuryakov wrote: > > 11.05.2010, в 0:56, Maciej Stachowiak написал(а): > > > I do think making it capable of handling subdirectories would be an >> improvement for SVN users. Also, I suspect it doesn't work as well as it >> could for people who prefer t

Re: [webkit-dev] Testing changes to CodeGenerator*.pm

On Thu, Apr 29, 2010 at 9:05 PM, Adam Barth wrote: > On Thu, Apr 29, 2010 at 12:43 PM, Maciej Stachowiak wrote: > > > It seems to me a better model would be to regenerate the bindings test > file > > automatically as part of the build. Then the changes can still be > reviewed > > by you, or as p

Re: [webkit-dev] Testing changes to CodeGenerator*.pm

On Thu, Apr 29, 2010 at 5:44 PM, Alexey Proskuryakov wrote: > > On 26.04.2010, at 22:06, Adam Barth wrote: > > If you make changes to CodeGenerator*.pm, please test your >> change using the following command: >> >> ~/git/webkit$ ./WebKitTools/Scripts/run-bindings-tests >> > > > I don't understan

Re: [webkit-dev] webkit-patch, check-webkit-style and git now support --squash and --git-commit

This is awesome Ojan. Thanks so much! On Mon, Apr 26, 2010 at 6:55 PM, Ojan Vafai wrote: > The behavior of git and webkit-patch changed with > http://trac.webkit.org/changeset/58261. > > Many webkit-patch commands (e.g. upload and land) and check-webkit-style > now take --squash and --git-commi

Re: [webkit-dev] MD5 in WebCore

Agreed. Can you give us a pointer to the email thread this decision was made on? On Tue, Apr 20, 2010 at 12:12 PM, Alex Russell wrote: > Hate to ask a dumb question, but why MD5? Isn't it on its last legs as > a secure hash? New protocols should be avoiding it. > > On Tue, Apr 20, 2010 at 11:48

Re: [webkit-dev] Announcing WebKit2

On Fri, Apr 9, 2010 at 2:33 AM, Adam Treat wrote: > On Thursday 08 April 2010 09:24:32 pm Darin Adler wrote: > > On Apr 8, 2010, at 6:23 PM, Adam Treat wrote: > > > Can someone please point to the bug report and the forum where this > > > development was discussed by the greater WebKit community?

Re: [webkit-dev] [webkit-changes] [57262] trunk/JavaScriptCore

On Thu, Apr 8, 2010 at 5:59 PM, Alexey Proskuryakov wrote: > > On 08.04.2010, at 1:16, o...@webkit.org wrote: > > + // [Qt]r57240 broke Qt build (might be a gcc bug) > > + // FIXME! See: https://bugs.webkit.org/show_bug.cgi?id=37253 > > > "FIXME! " is different from "FIXME: " in that Xcode doesn'

Re: [webkit-dev] Windows mobile build

On Sun, Apr 4, 2010 at 10:45 AM, Patrick Roland Gansterer wrote: > Hi, > > i had the same problem some months ago > (https://lists.webkit.org/pipermail/webkit-dev/2010-January/011160.html), > but > didn't get any final reply. > I had a look onto other (meta) buildsystems, but most of them lack Wi

Re: [webkit-dev] WebKit Icon license?

On Wed, Mar 24, 2010 at 12:28 AM, Maciej Stachowiak wrote: > > On Mar 23, 2010, at 3:25 AM, Jeremy Orlow wrote: > > It seems as though we should at very least change the main icon on > webkit.org to match what is apparently the official webkit logo. The > icons for the Mac and

Re: [webkit-dev] WebKit Icon license?

And does anyone know where the original artwork is and/or came from? On Tue, Mar 23, 2010 at 10:25 AM, Jeremy Orlow wrote: > It seems as though we should at very least change the main icon on > webkit.org to match what is apparently the official webkit logo. The > icons for the Mac an

Re: [webkit-dev] WebKit Icon license?

7;ing Marcelo, who is our Brazilian Head of User Experience and > >> >> Design. > >> >> > >> >> Cheers, > >> >> Kenneth > >> >> > >> >> On Mon, Mar 22, 2010 at 12:55 PM, Dimitri Glazkov > >> >>

Re: [webkit-dev] WebKit Icon license?

On Fri, Mar 19, 2010 at 4:00 PM, Darin Adler wrote: > On Mar 19, 2010, at 8:40 AM, Dimitri Glazkov wrote: > > > Would you happen to know how WebKit icon is licensed? > > The icon currently on webkit.org has the icon for Apple’s Safari web > browser in it. Because of that, Apple has provided no li

Re: [webkit-dev] Unofficial reviews (WAS: Why I'm reviewing patches outside my area (and why you should too))

On Wed, Mar 10, 2010 at 1:16 PM, Adam Treat wrote: > On Wednesday 10 March 2010 07:06:16 am Jeremy Orlow wrote: > > I can give you a success story though: michaeln is probably the most > > qualified reviewer of WebSQLDatabase code these days. He looks at most > > patches th

[webkit-dev] Unofficial reviews (WAS: Why I'm reviewing patches outside my area (and why you should too))

On Wed, Mar 10, 2010 at 7:45 AM, Zoltan Herczeg wrote: > Hi, > > > It's also a big help when peers (which aren't necessarily WebKit > > reviewers) > > look over it and give review-style feedback as well. Especially when > said > > peers know more about that code than any of the official reviewers

Re: [webkit-dev] Why I'm reviewing patches outside my area (and why you should too)

On Tue, Mar 9, 2010 at 9:39 PM, David Levin wrote: > >> (3) Someone reviewed an earlier version of the patch but then didn't >> follow up. I think having a partial review by one person encourages >> other people to assume that person will finish the review. That cause >> the patch to float upw

Re: [webkit-dev] Increasing the number of cross-platform/port expected results

On Tue, Mar 9, 2010 at 9:19 AM, Robert O'Callahan wrote: > > Mozilla has been using this technique for years. Perhaps we can pick their >> brains for some good tricks. Or, dare I say it, share some tests. >> >> >> > Hi, hope I'm not crashing the party, and sorry I'm late :-). Let me just > say a f

Re: [webkit-dev] minimum python version to support

There difference between Python 2.3 and 2.5 is pretty large. What was added was not esoteric. Take a look at http://docs.python.org/whatsnew/2.4.html and http://docs.python.org/whatsnew/2.5.html Included in there is stuff like try/catch/finally. I totally agree that basic tools (like build-web

Re: [webkit-dev] The tree is on fire: a tragedy of the commons

On Fri, Feb 26, 2010 at 9:00 PM, Jeremy Orlow wrote: > On Fri, Feb 26, 2010 at 8:53 PM, Maciej Stachowiak wrote: > >> >> On Feb 26, 2010, at 11:43 AM, Simon Fraser wrote: >> >> >>> Mozilla has (or at least had when I worked there) two additional "tre

Re: [webkit-dev] The tree is on fire: a tragedy of the commons

On Fri, Feb 26, 2010 at 8:53 PM, Maciej Stachowiak wrote: > > On Feb 26, 2010, at 11:43 AM, Simon Fraser wrote: > > >> Mozilla has (or at least had when I worked there) two additional "tree >> rules" that helped keep the tree green: >> >> 1. A sheriff was appointed at all times, and had the autho

Re: [webkit-dev] Accessibility for Mac OSX Chromium?

+ chromium-dev bcc webkit-dev On Wed, Feb 24, 2010 at 9:29 AM, Chris Fleizach wrote: > Hi Chromium devs, > > I noticed in the latest Chromium beta it seemed that there was still no > accessibility for the mac. > > It should be a fairly straightforward process of enabling accessibility. > > Pleas

Re: [webkit-dev] The tree is on fire: a tragedy of the commons

On Fri, Feb 26, 2010 at 7:06 PM, Maciej Stachowiak wrote: > > On Feb 26, 2010, at 9:56 AM, Alexey Proskuryakov wrote: > > >> On 26.02.2010, at 9:29, Maciej Stachowiak wrote: >> >> I'd like it if we had an IRC bot that announced build breakage on >>> #webkit. >>> >> >> >> Perhaps better yet, on #

Re: [webkit-dev] The tree is on fire: a tragedy of the commons

On Fri, Feb 26, 2010 at 6:47 PM, Dimitri Glazkov wrote: > On Fri, Feb 26, 2010 at 9:44 AM, Eric Seidel wrote: > > The bots take 15 minutes to cycle. The moment the build is broken, > > thats FIX_TIME + BOT_CYCLE_TIME until their green again. > > > > I think we should cap the fix grace period at

Re: [webkit-dev] Crashes during testing

Personally, I've found those kind of changes are responsible for a disproportionate percentage of build errors and bugs. :-) On Fri, Feb 26, 2010 at 5:16 PM, Darin Adler wrote: > On Feb 26, 2010, at 1:42 AM, Jeremy Orlow wrote: > > > Did you run the layout tests at all? > &

Re: [webkit-dev] The tree is on fire: a tragedy of the commons

On Fri, Feb 26, 2010 at 10:36 AM, Adam Barth wrote: > Not to point fingers, but we've been having trouble keeping > build.webkit.org green these past few weeks. As I write this message, > every platform is broken, again. As the project scales, polluting the > build with brokenness impacts more

Re: [webkit-dev] Crashes during testing

On Fri, Feb 26, 2010 at 12:03 AM, Oliver Hunt wrote: > But any regressions would have been blamed on eric. > His name would show up in the SVN log, sure, but I don't think that'd fool your average WebKit developer for long. webkit-patch land does the correct thing, but i disable the testing pri

Re: [webkit-dev] [webkit-changes] [55234] trunk/JavaScriptCore

I already started the process of doing a revert and submitting it with a better change log. J On Thu, Feb 25, 2010 at 7:11 PM, Alexey Proskuryakov wrote: > > On 25.02.2010, at 10:00, David Levin wrote: > > All the information being provided now explains the why. Unfortunately, > this thread doe

  1   2   3   >