Re: [webkit-dev] Fwd: Review queue needs love

Great, thanks for the responses, all - I feel much better knowing that we're one big WebKit family :) I agree that it's a good practice to tag platform-specific bugs, but I wasn't aware how to do this - I'll make sure I add the appropriate annotations on any future chrome-specific bugs I submit. C

Re: [webkit-dev] Fwd: Review queue needs love

On Jun 19, 2009, at 11:46 AM, Maciej Stachowiak wrote: On Jun 19, 2009, at 11:05 AM, Drew Wilson wrote: I absolutely understand that there are ways to proactively find reviewers, and I'm *not* complaining about the time being taken (I understand the constraints that most of the webkit rev

Re: [webkit-dev] Fwd: Review queue needs love

I think this is a great way to distinguish bugs. I just posted on chromium-dev recommending this. :DG< On Fri, Jun 19, 2009 at 11:46 AM, Maciej Stachowiak wrote: > > On Jun 19, 2009, at 11:05 AM, Drew Wilson wrote: > > I absolutely understand that there are ways to proactively find reviewers, > a

Re: [webkit-dev] Fwd: Review queue needs love

On Jun 19, 2009, at 11:05 AM, Drew Wilson wrote: I absolutely understand that there are ways to proactively find reviewers, and I'm *not* complaining about the time being taken (I understand the constraints that most of the webkit reviewers have been under the last few weeks with WWDC, etc

Re: [webkit-dev] Fwd: Review queue needs love

On Jun 19, 2009, at 11:05 AM, Drew Wilson wrote: I absolutely understand that there are ways to proactively find reviewers, and I'm *not* complaining about the time being taken (I understand the constraints that most of the webkit reviewers have been under the last few weeks with WWDC, etc

Re: [webkit-dev] Fwd: Review queue needs love

On Friday 19 June 2009 02:05:23 pm Drew Wilson wrote: > I was more specifically wondering if there was something about this patch > that made it not show up on the list Eric provided below. My concern is > because the bugfix came from a google.com address, it might have been > getting lumped in wit

Re: [webkit-dev] Fwd: Review queue needs love

I absolutely understand that there are ways to proactively find reviewers, and I'm *not* complaining about the time being taken (I understand the constraints that most of the webkit reviewers have been under the last few weeks with WWDC, etc). As you say, we can always ping people on IRC to find re

Re: [webkit-dev] Fwd: Review queue needs love

Drew, if you go to http://nightly.webkit.org/start/, then click "*Patches awaiting Review ".* * That is the list folks work off of, but it doesn't hurt to figure out the appropriate person to review the patch (find out who has changed the file a lot) and ping them

Re: [webkit-dev] Fwd: Review queue needs love

I note that this bug fix: https://bugs.webkit.org/show_bug.cgi?id=23721 ...was not on the list below, and has been waiting for some reviewer love for a couple of weeks now. Is it falling through the cracks somehow? -atw On Fri, Jun 19, 2009 at 4:18 AM, Andrei Popescu wrote: > Hi, > > On Fri, J

Re: [webkit-dev] Fwd: Review queue needs love

Hi, On Fri, Jun 19, 2009 at 3:03 AM, Eric Seidel wrote: > > The other 24 remaining patches consist of 6 Gtk patches, 3 Chromium > patches, and a bunch of huge new feature patches. > No quite. The following two are rather small patches to common code (appcache and database): https://bugs.webkit.o

[webkit-dev] Fwd: Review queue needs love

Oh how I wish that my @webkit.org address and gmail would get along... -eric -- Forwarded message -- From: Eric Seidel Date: Thu, Jun 18, 2009 at 7:02 PM Subject: Re: [webkit-dev] Review queue needs love To: Adam Treat Cc: webkit-dev@lists.webkit.org I've gone through the queu