Re: [webkit-dev] Introducing RenderPtr!

2013-12-31 Thread Ryosuke Niwa
On Tuesday, December 31, 2013, Ryosuke Niwa wrote: Nice! Does this also make render objects less dangerous? (For security) On Monday, December 30, 2013, Andreas Kling wrote: Sup WebKittens, I’ve just added a “RenderPtr smart pointer to the rendering code and am in the process of

Re: [webkit-dev] Introducing RenderPtr!

2013-12-31 Thread Maciej Stachowiak
If we comprehensively deploy smart pointers in place of raw pointers and manual memory management, then yes. The render tree does have places where non-owning references are held, and these can be some of the biggest security risks. One notable example is the m_floats member in

[webkit-dev] Introducing RenderPtr!

2013-12-30 Thread Andreas Kling
Sup WebKittens, I’ve just added a “RenderPtr smart pointer to the rendering code and am in the process of switching code from using raw pointers to this. Check out the code here: https://trac.webkit.org/r161115 (note that I’ve since renamed createRenderObject to createRenderer per Antti’s