Re: [webkit-dev] Proposal: Rect based HitTest for a better touch experience

2010-07-07 Thread Antonio Gomes (:tonikitoo)
In the later sample output, note that it did not reach body , whose boundary obvious intersects any possible given Z rect. That would happen if the div in case encloses the rect Z completely, and it would be the stop point for the hit test. In Mozilla's implementation, nodesFromRect does not

Re: [webkit-dev] Proposal: Rect based HitTest for a better touch experience

2010-07-07 Thread Grace Kloba
If we want to return all the nodes, it is actually a simple change as we just remove the code to check the enclosure. But this may affect the hit test performance. thanks, Grace On Wed, Jul 7, 2010 at 5:59 AM, Antonio Gomes (:tonikitoo) toniki...@gmail.com wrote: In the later sample output,

Re: [webkit-dev] Proposal: Rect based HitTest for a better touch experience

2010-07-06 Thread Antonio Gomes (:tonikitoo)
Hi Simon. Thank you join the discussion! On Tue, Jul 6, 2010 at 1:46 AM, Simon Fraser simon.fra...@apple.com wrote: On Jul 5, 2010, at 7:35 PM, Antonio Gomes (:tonikitoo) wrote: * adds a Document::nodesFromRect method, exposing the functionality to the dom. It returns a NodeList with all

Re: [webkit-dev] Proposal: Rect based HitTest for a better touch experience

2010-07-06 Thread Simon Fraser
On Jul 6, 2010, at 5:54 AM, Antonio Gomes (:tonikitoo) wrote: Hi Simon. Thank you join the discussion! On Tue, Jul 6, 2010 at 1:46 AM, Simon Fraser simon.fra...@apple.com wrote: On Jul 5, 2010, at 7:35 PM, Antonio Gomes (:tonikitoo) wrote: * adds a Document::nodesFromRect method,

Re: [webkit-dev] Proposal: Rect based HitTest for a better touch experience

2010-07-05 Thread Antonio Gomes (:tonikitoo)
Hi guys. We've uploaded a patch for review in bug https://bugs.webkit.org/show_bug.cgi?id=40197 (attachment https://bugs.webkit.org/attachment.cgi?id=59789 - chromium build fixed in r61955) - Grace and I joint effort in fixing this issue. As ways to expose the functionality, the patch: *

Re: [webkit-dev] Proposal: Rect based HitTest for a better touch experience

2010-07-05 Thread Simon Fraser
On Jul 5, 2010, at 7:35 PM, Antonio Gomes (:tonikitoo) wrote: * adds a Document::nodesFromRect method, exposing the functionality to the dom. It returns a NodeList with all nodes that intersect the given hit-tested area. Is there a reason to use different terminology from the existing

Re: [webkit-dev] Proposal: Rect based HitTest for a better touch experience

2010-06-10 Thread Antonio Gomes (:tonikitoo)
Hi, As Grace pointed out in the spun-off thread, bug 40197 was filed and a patch was put up for feedback there. I looked over the patch, and since it took a different path from what I had in mind to fix the problem, I also took a couple of days and implemented mine prototype. I explained

Re: [webkit-dev] Proposal: Rect based HitTest for a better touch experience

2010-06-10 Thread Antonio Gomes (:tonikitoo)
Hi, as a follow up on this and based on a quick chat with hyatt on irc, the minimalistic approach seems to be the way to go. tonikitoo dhyatt, david, could you join the discussion about rect based hit test on bug 40197 dhyatt just need me to make a decision on the right naming? tonikitoo dhyatt,

Re: [webkit-dev] Proposal: Rect based HitTest for a better touch experience

2010-06-10 Thread David Hyatt
Yes, I got schooled on this days ago, but welcome to the party! ;) dave On Jun 10, 2010, at 6:00 PM, Maciej Stachowiak wrote: On Jun 2, 2010, at 1:22 PM, David Hyatt wrote: I really don't think hit testing needs to be modified to get what you want. You can do a scattershot sampling

Re: [webkit-dev] Proposal: Rect based HitTest for a better touch experience

2010-06-06 Thread Antti Koivisto
On Wed, Jun 2, 2010 at 11:22 PM, David Hyatt hy...@apple.com wrote: I really don't think hit testing needs to be modified to get what you want.   You can do a scattershot sampling using multiple candidate points within the rect and apply whatever heuristics you want to choose a node.  I'm

[webkit-dev] Proposal: Rect based HitTest for a better touch experience

2010-06-04 Thread Grace Kloba
We (Android) are also looking at this area. We are working on a patch. Will file a bug and provide a patch for the feedback. thanks, Grace ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

[webkit-dev] Proposal: Rect based HitTest for a better touch experience

2010-06-02 Thread Antonio Gomes (:tonikitoo)
Hi, As most of you have experienced, the precision of a mouse click on Desktop applications, including Web browsers, is much higher than the precision of a touch tap on a mobile device. It is not a new problem, and many solutions have been proposed to improve that situation. One of the common

Re: [webkit-dev] Proposal: Rect based HitTest for a better touch experience

2010-06-02 Thread David Hyatt
On Jun 2, 2010, at 2:46 PM, Antonio Gomes (:tonikitoo) wrote: Hi, As most of you have experienced, the precision of a mouse click on Desktop applications, including Web browsers, is much higher than the precision of a touch tap on a mobile device. It is not a new problem, and many

Re: [webkit-dev] Proposal: Rect based HitTest for a better touch experience

2010-06-02 Thread David Hyatt
On Jun 2, 2010, at 3:22 PM, David Hyatt wrote: Before going this way, I would like to know of any known problem or show stoppers. I really don't think hit testing needs to be modified to get what you want. You can do a scattershot sampling using multiple candidate points within the

Re: [webkit-dev] Proposal: Rect based HitTest for a better touch experience

2010-06-02 Thread Antonio Gomes (:tonikitoo)
Hi David. Although I understand your concern, however I still do not think the change would complicate things that much, but basically extend the current support. For example, in bool InlineTextBox::nodeAtPoint(const HitTestRequest, HitTestResult result, int x, int y, int tx, int ty) { (...)

Re: [webkit-dev] Proposal: Rect based HitTest for a better touch experience

2010-06-02 Thread Peter Kasting
On Wed, Jun 2, 2010 at 1:52 PM, Antonio Gomes (:tonikitoo) toniki...@gmail.com wrote: If a port do not want to take advantage of the new support, the current functionality should and would be kept, i.e. Rect(x,y,1,1,) would do the trick. Be careful to check whether you really want 1, 1 or

Re: [webkit-dev] Proposal: Rect based HitTest for a better touch experience

2010-06-02 Thread David Hyatt
He would want 1,1. dave On Jun 2, 2010, at 3:58 PM, Peter Kasting wrote: On Wed, Jun 2, 2010 at 1:52 PM, Antonio Gomes (:tonikitoo) toniki...@gmail.com wrote: If a port do not want to take advantage of the new support, the current functionality should and would be kept, i.e.