On Wed, May 16, 2012 at 10:37 PM, Benjamin Poulain benja...@webkit.orgwrote:
On Wed, May 16, 2012 at 9:34 PM, Ryosuke Niwa rn...@webkit.org wrote:
I would go for something verbose in a easy to understand format. E.g.
{ test: 'fast/html/keygen.html',
platform: 'mac, linux',
bug:
On Wed, May 16, 2012 at 11:04 PM, Ryosuke Niwa rn...@webkit.org wrote:
{ test: 'fast/html/keygen.html',
platform: 'mac, linux',
bug: 'webkit.org/b/6',
expectedResults: ['crash', 'text', 'image'],
action: 'skip' }
As far as I know, a lot of people edit this file on a text editor so
On Wed, May 16, 2012 at 11:33 PM, Benjamin Poulain benja...@webkit.orgwrote:
On Wed, May 16, 2012 at 11:04 PM, Ryosuke Niwa rn...@webkit.org wrote:
Also, complex syntax tends to be error-prone. One of the pain points of
the
current syntax is that many people forget to add : and =, or put
On May 16, 2012, at 10:39 PM, Dirk Pranke dpra...@chromium.org wrote:
There was a semi-logical basis, in that the stuff on the right of the
test clearly specified the outcome of the test (PASS, IMAGE, TEXT,
etc.). The stuff on the left was less well defined: there's the bug
numbers, the
On Thu, May 17, 2012 at 1:06 AM, Maciej Stachowiak m...@apple.com wrote:
On May 16, 2012, at 10:39 PM, Dirk Pranke dpra...@chromium.org wrote:
There was a semi-logical basis, in that the stuff on the right of the
test clearly specified the outcome of the test (PASS, IMAGE, TEXT,
etc.).
I have a proposal that hopefully addresses everyone's concerns, is
minimally different from the current format *and* unifies the format with
Skipped lists (i.e. Skipped lists as they exist today are valid
test_expectations.txt format). The changes from the current format are as
follows:
-Leaving
On May 17, 2012, at 4:30 AM, Ojan Vafai wrote:
I have a proposal that hopefully addresses everyone's concerns, is minimally
different from the current format *and* unifies the format with Skipped lists
(i.e. Skipped lists as they exist today are valid test_expectations.txt
format). The
On Thu, May 17, 2012 at 9:11 AM, Darin Adler da...@apple.com wrote:
On May 17, 2012, at 4:30 AM, Ojan Vafai wrote:
I have a proposal that hopefully addresses everyone's concerns, is minimally
different from the current format *and* unifies the format with Skipped
lists (i.e. Skipped lists as
Seriously, syntax is a significant barrier. Having to know which special
characters to use. I don’t see this “clear delineation” you speak of. Just
special punctuation I have to use to satisfy the computer.
-- Darin
___
webkit-dev mailing list
Could that be because you haven't actually tried using it? :)
On Thu, May 17, 2012 at 4:40 PM, Darin Adler da...@apple.com wrote:
Seriously, syntax is a significant barrier. Having to know which special
characters to use. I don’t see this “clear delineation” you speak of. Just
special
Sorry, didn't mean to come across as flip. To illustrate, here's an example:
WIN SNOWLEOPARD : foo.html = TEXT IMAGE # on all windows platforms and
SL, test foo.html is flaky -- fails either with text or pixel results.
Easy.
TEXT WIN SNOWLEOPARD IMAGE foo.html # fails with text on all windows
On Thu, May 17, 2012 at 9:11 AM, Darin Adler da...@apple.com wrote:
I don’t understand why we need the : or + separators.
Unfortunately, image+text is different is image text. The former
indicates that the test will have mismatches in both .txt and .png files
while the latter indicates that
On Thu, May 17, 2012 at 9:26 AM, Dimitri Glazkov dglaz...@chromium.orgwrote:
I actually quite like
the clear delineation between test modifiers and test expectations.
Me too. Please please please leave them on opposite sides. All these
proposals that try to put them both before the test
On Thu, May 17, 2012 at 11:08 AM, Peter Kasting pkast...@google.com wrote:
On Thu, May 17, 2012 at 9:26 AM, Dimitri Glazkov dglaz...@chromium.orgwrote:
I actually quite like
the clear delineation between test modifiers and test expectations.
Me too. Please please please leave them on
On May 17, 2012, at 11:28 AM, Ryosuke Niwa rn...@webkit.org wrote:
On Thu, May 17, 2012 at 11:08 AM, Peter Kasting pkast...@google.com wrote:
On Thu, May 17, 2012 at 9:26 AM, Dimitri Glazkov dglaz...@chromium.org
wrote:
I actually quite like
the clear delineation between test modifiers and
On Tue, May 15, 2012 at 11:46 AM, Peter Kasting pkast...@chromium.orgwrote:
On Tue, May 15, 2012 at 11:37 AM, Ryosuke Niwa rn...@webkit.org wrote:
On May 15, 2012 10:53 AM, Peter Kasting pkast...@chromium.org wrote:
Given how little of std:: we actually use (since WTF is used instead
for
On Thu, May 17, 2012 at 11:54 AM, Maciej Stachowiak m...@apple.com wrote:
On May 17, 2012, at 11:28 AM, Ryosuke Niwa rn...@webkit.org wrote:
On Thu, May 17, 2012 at 11:08 AM, Peter Kasting pkast...@google.comwrote:
On Thu, May 17, 2012 at 9:26 AM, Dimitri Glazkov
On Thu, May 17, 2012 at 12:02 PM, Ryosuke Niwa rn...@webkit.org wrote:
It appears to me using fully qualified names (e.g. std::max(~) at call
site) is far superior to using directive for individual symbols (e.g. using
std::max).
It sounds in general like a number of people have been in favor
On May 17, 2012, at 12:33 PM, Peter Kasting pkast...@chromium.org wrote:
On Thu, May 17, 2012 at 12:02 PM, Ryosuke Niwa rn...@webkit.org wrote:
It appears to me using fully qualified names (e.g. std::max(~) at call site)
is far superior to using directive for individual symbols (e.g. using
On Thu, May 17, 2012 at 12:19 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Thu, May 17, 2012 at 11:54 AM, Maciej Stachowiak m...@apple.com wrote:
Perhaps aligning the fields column after the bug URL would improve
readability (though it makes things a little harder to edit):
We certainly
There's lot of good discussion going on in this thread ... I'm going
to attempt to reply to various threads in one message, hixie-style :)
On Thu, May 17, 2012 at 1:06 AM, Maciej Stachowiak m...@apple.com wrote:
SKIP and WONTFIX seem parallel to PASS to me.
[and]
On Thu, May 17, 2012 at 11:07
On Thu, May 17, 2012 at 12:36 PM, Dirk Pranke dpra...@chromium.org wrote:
On Thu, May 17, 2012 at 4:30 AM, Ojan Vafai o...@chromium.org wrote:
-Make everything but the test name case-insensitive.
I don't think I like this; it could lead to a lot of arbitrarily
different formatting in the
On Thu, May 17, 2012 at 1:06 AM, Maciej Stachowiak m...@apple.com wrote:
What does the build configuration info do? Does it apply the line to only
those configurations? If that is the case, it does seem potentially different
in kind, though maybe also better expressed by being able to combine
On Thu, May 17, 2012 at 12:48 PM, Dirk Pranke dpra...@chromium.org wrote:
On Thu, May 17, 2012 at 1:06 AM, Maciej Stachowiak m...@apple.com wrote:
What does the build configuration info do? Does it apply the line to only
those configurations? If that is the case, it does seem potentially
On Thu, May 17, 2012 at 12:47 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Thu, May 17, 2012 at 12:36 PM, Dirk Pranke dpra...@chromium.org wrote:
On Thu, May 17, 2012 at 4:30 AM, Ojan Vafai o...@chromium.org wrote:
-Make everything but the test name case-insensitive.
I don't think I like
On Thu, May 17, 2012 at 1:34 PM, Ojan Vafai o...@chromium.org wrote:
2. Make outcomes optional. If they are left out, then the test is skipped
(unless the test is marked SLOW, in which case it's expected to pass).
There is no SKIP modifier.
I don't think we should do this. It seems very
On Thu, May 17, 2012 at 1:37 PM, Peter Kasting pkast...@chromium.orgwrote:
On Thu, May 17, 2012 at 1:34 PM, Ojan Vafai o...@chromium.org wrote:
2. Make outcomes optional. If they are left out, then the test is skipped
(unless the test is marked SLOW, in which case it's expected to pass).
Seems reasonable as the first step except:
On Thu, May 17, 2012 at 1:34 PM, Ojan Vafai o...@chromium.org wrote:
6. Use the same character as a separator before and after the test (:).
I counter-propose to drop : or any other delimiter altogether. Delimiters
are the biggest pain points in the
On Thu, May 17, 2012 at 2:06 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Thu, May 17, 2012 at 2:05 PM, Ojan Vafai o...@chromium.org wrote:
On Thu, May 17, 2012 at 2:02 PM, Ryosuke Niwa rn...@webkit.org wrote:
Seems reasonable as the first step except:
On Thu, May 17, 2012 at 1:34 PM, Ojan
On Thu, May 17, 2012 at 2:11 PM, Ojan Vafai o...@chromium.org wrote:
Oh, I supposed I misread Peter's earlier email as being opposed to this.
But, I for one am opposed to it. I find the jumble of modifiers in the
second set of lines here much harder to quickly parse than the groupings in
the
On Thu, May 17, 2012 at 2:16 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Thu, May 17, 2012 at 2:11 PM, Ojan Vafai o...@chromium.org wrote:
Oh, I supposed I misread Peter's earlier email as being opposed to this.
But, I for one am opposed to it. I find the jumble of modifiers in the
second
On Thu, May 17, 2012 at 2:11 PM, Ojan Vafai o...@chromium.org wrote:
Oh, I supposed I misread Peter's earlier email as being opposed to this.
You didn't misread me. I have the same opinion as you: this would be a
change for the worse.
PK
___
On Thu, May 17, 2012 at 2:19 PM, Ojan Vafai o...@chromium.org wrote:
On Thu, May 17, 2012 at 2:16 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Thu, May 17, 2012 at 2:11 PM, Ojan Vafai o...@chromium.org wrote:
Oh, I supposed I misread Peter's earlier email as being opposed to this.
But, I for
On Thu, May 17, 2012 at 2:29 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Thu, May 17, 2012 at 2:19 PM, Ojan Vafai o...@chromium.org wrote:
On Thu, May 17, 2012 at 2:16 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Thu, May 17, 2012 at 2:11 PM, Ojan Vafai o...@chromium.org wrote:
Oh, I
On Thu, May 17, 2012 at 2:28 PM, Peter Kasting pkast...@chromium.org wrote:
On Thu, May 17, 2012 at 2:11 PM, Ojan Vafai o...@chromium.org wrote:
Oh, I supposed I misread Peter's earlier email as being opposed to this.
You didn't misread me. I have the same opinion as you: this would be a
On Thu, May 17, 2012 at 2:34 PM, Ojan Vafai o...@chromium.org wrote:
I'm just trying to make forward progress on the things we agree on.
Anyway, the said changes (replace bogus BUGCR/BUGWK with URLs) and moving
SKIP/WONTFIX to after test names sound like a good change anyways. I have
no
On Thu, May 17, 2012 at 2:39 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Thu, May 17, 2012 at 2:36 PM, Dirk Pranke dpra...@chromium.org wrote:
On Thu, May 17, 2012 at 2:28 PM, Peter Kasting pkast...@chromium.org
wrote:
On Thu, May 17, 2012 at 2:11 PM, Ojan Vafai o...@chromium.org wrote:
On Thu, May 17, 2012 at 3:01 PM, Dirk Pranke dpra...@chromium.org wrote:
As I said before, I believe they increase the readability of the file.
I see them as pure noise.
I believe the cost of learning to put delimiters in is near zero,
That clearly isn't near zero. Or else people wouldn't
On Thu, May 17, 2012 at 3:21 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Thu, May 17, 2012 at 3:01 PM, Dirk Pranke dpra...@chromium.org wrote:
As I said before, I believe they increase the readability of the file.
I see them as pure noise.
Clearly, different people can have different
On Thu, May 17, 2012 at 3:37 PM, Dirk Pranke dpra...@chromium.org wrote:
On Thu, May 17, 2012 at 3:21 PM, Ryosuke Niwa rn...@webkit.org wrote:
Perhaps we can address these two problems using some tools. e.g. I don't
care about the format of test_expectations.txt at all if there was a GUI
On Thu, May 17, 2012 at 3:37 PM, Dirk Pranke dpra...@chromium.org wrote:
On Thu, May 17, 2012 at 3:21 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Thu, May 17, 2012 at 3:01 PM, Dirk Pranke dpra...@chromium.org
wrote:
As I said before, I believe they increase the readability of the file.
I
On May 17, 2012, at 12:53 PM, Dirk Pranke dpra...@chromium.org wrote:
On Thu, May 17, 2012 at 12:47 PM, Ryosuke Niwa rn...@webkit.org wrote:
I find either all-lowercase or all-caps to be much harder to read than
capitalized words. They look like a blob of letters to me.
We might have to
On May 17, 2012, at 3:37 PM, Dirk Pranke dpra...@chromium.org wrote:
On Thu, May 17, 2012 at 3:21 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Thu, May 17, 2012 at 3:01 PM, Dirk Pranke dpra...@chromium.org wrote:
As I said before, I believe they increase the readability of the file.
I
On Thu, May 17, 2012 at 4:00 PM, Maciej Stachowiak m...@apple.com wrote:
On May 17, 2012, at 12:53 PM, Dirk Pranke dpra...@chromium.org wrote:
On Thu, May 17, 2012 at 12:47 PM, Ryosuke Niwa rn...@webkit.org wrote:
I find either all-lowercase or all-caps to be much harder to read than
On May 17, 2012, at 4:17 PM, Dirk Pranke dpra...@chromium.org wrote:
On Thu, May 17, 2012 at 4:00 PM, Maciej Stachowiak m...@apple.com wrote:
On May 17, 2012, at 12:53 PM, Dirk Pranke dpra...@chromium.org wrote:
On Thu, May 17, 2012 at 12:47 PM, Ryosuke Niwa rn...@webkit.org wrote:
I
On May 17, 2012, at 1:42 PM, Ojan Vafai o...@chromium.org wrote:
On Thu, May 17, 2012 at 1:37 PM, Peter Kasting pkast...@chromium.org wrote:
On Thu, May 17, 2012 at 1:34 PM, Ojan Vafai o...@chromium.org wrote:
2. Make outcomes optional. If they are left out, then the test is skipped
(unless
On Thu, May 17, 2012 at 4:16 PM, Maciej Stachowiak m...@apple.com wrote:
On May 17, 2012, at 3:37 PM, Dirk Pranke dpra...@chromium.org wrote:
On Thu, May 17, 2012 at 3:21 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Thu, May 17, 2012 at 3:01 PM, Dirk Pranke dpra...@chromium.org wrote:
As I
On May 17, 2012, at 4:40 PM, Dirk Pranke dpra...@chromium.org wrote:
On Thu, May 17, 2012 at 4:16 PM, Maciej Stachowiak m...@apple.com wrote:
Let's take an example. TEXT next to a test name apparently means that the
text fails. There is no way in the world I would guess that just from
On Thu, May 17, 2012 at 4:50 PM, Maciej Stachowiak m...@apple.com wrote:
On May 17, 2012, at 4:40 PM, Dirk Pranke dpra...@chromium.org wrote:
On Thu, May 17, 2012 at 4:16 PM, Maciej Stachowiak m...@apple.com wrote:
Let's take an example. TEXT next to a test name apparently means that the
Hello webkit folks,
I'm happy to inform you that the EFL 32-bit release buildbot got online.
By the way, this build bot only runs build test for now because of hardware
performance.
I will change this bot with build and test bot in future.
On Thu, May 17, 2012 at 4:29 PM, Maciej Stachowiak m...@apple.com wrote:
On May 17, 2012, at 1:42 PM, Ojan Vafai o...@chromium.org wrote:
On Thu, May 17, 2012 at 1:37 PM, Peter Kasting pkast...@chromium.orgwrote:
On Thu, May 17, 2012 at 1:34 PM, Ojan Vafai o...@chromium.org wrote:
2. Make
Closing the loop...bug filed
https://bugs.webkit.org/show_bug.cgi?id=86796 minus
item 2 since that turned out to be controversial.
On Thu, May 17, 2012 at 1:34 PM, Ojan Vafai o...@chromium.org wrote:
We are arguing about too many orthogonal things at once. It seems like
there are a few things
On Thu, May 17, 2012 at 7:27 PM, Ojan Vafai o...@chromium.org wrote:
On Thu, May 17, 2012 at 4:29 PM, Maciej Stachowiak m...@apple.com wrote:
On May 17, 2012, at 1:42 PM, Ojan Vafai o...@chromium.org wrote:
On Thu, May 17, 2012 at 1:37 PM, Peter Kasting pkast...@chromium.orgwrote:
On Thu,
On Thu, May 17, 2012 at 7:27 PM, Ojan Vafai o...@chromium.org wrote:
On Thu, May 17, 2012 at 4:29 PM, Maciej Stachowiak m...@apple.com wrote:
On May 17, 2012, at 1:42 PM, Ojan Vafai o...@chromium.org wrote:
On Thu, May 17, 2012 at 1:37 PM, Peter Kasting pkast...@chromium.org
wrote:
On
On May 17, 2012, at 7:27 PM, Ojan Vafai o...@chromium.org wrote:
On Thu, May 17, 2012 at 4:29 PM, Maciej Stachowiak m...@apple.com wrote:
On May 17, 2012, at 1:42 PM, Ojan Vafai o...@chromium.org wrote:
On Thu, May 17, 2012 at 1:37 PM, Peter Kasting pkast...@chromium.org wrote:
On Thu,
55 matches
Mail list logo
