Re: [webkit-dev] Where do we put WPT tests to be exported

On Tue, Jul 11, 2017 at 4:14 PM, Ali Juma wrote: > > Just wanted to check what the current recommended approach is for new WPT > tests. Is it now ok to add new tests directly in > LayoutTests/imported/w3c/web-platform-tests and then upstream them, or > should tests still be

Re: [webkit-dev] Where do we put WPT tests to be exported

Hi Ali, I think it is valuable to upload a patch containing source code changes with the new/modified WPT tests covering these changes. I would recommend to do the GitHub submission in parallel and add a reference to the GitHub PR in WebKit bugzilla. Ideally, the GitHub PR would be merged before

Re: [webkit-dev] Where do we put WPT tests to be exported

Hi all, Just wanted to check what the current recommended approach is for new WPT tests. Is it now ok to add new tests directly in LayoutTests/imported/w3c/web-platform-tests and then upstream them, or should tests still be added elsewhere first (in LayoutTests/http/wpt?), upstreamed, and then

Re: [webkit-dev] Where do we put WPT tests to be exported

Filed https://bugs.webkit.org/show_bug.cgi?id=172435 about that Le dim. 21 mai 2017 à 00:40, Maciej Stachowiak a écrit : > On May 18, 2017, at 2:08 PM, Philip Jägenstedt wrote: > > On Tue, May 16, 2017 at 5:38 PM youenn fablet wrote: > >>

Re: [webkit-dev] Where do we put WPT tests to be exported

> On May 18, 2017, at 2:08 PM, Philip Jägenstedt wrote: > > On Tue, May 16, 2017 at 5:38 PM youenn fablet > wrote: > > There was a suggestion that LayoutTests/imported/w3c/web-platform-tests be > moved to a shorter path like

Re: [webkit-dev] Where do we put WPT tests to be exported

> > Sure, it is good to test conformance, but there is no longer regression > > testing on the deprecated feature behavior itself. > > Ideally, this would require tighter syncing between the browsers. Might > have > > positive and/or negative consequences. > > I don't think we should be changing

Re: [webkit-dev] Where do we put WPT tests to be exported

On Fri, May 19, 2017 at 10:17 AM, youenn fablet wrote: > > > Le ven. 19 mai 2017 à 09:44, Anne van Kesteren a écrit : >> >> On Fri, May 19, 2017 at 5:11 PM, youenn fablet wrote: >> > When a spec gets updated, the WPT tests will ideally be

Re: [webkit-dev] Where do we put WPT tests to be exported

Le ven. 19 mai 2017 à 09:44, Anne van Kesteren a écrit : > On Fri, May 19, 2017 at 5:11 PM, youenn fablet wrote: > > When a spec gets updated, the WPT tests will ideally be updated at the > same > > time. > > The updated tests will no longer ensure

Re: [webkit-dev] Where do we put WPT tests to be exported

On Fri, May 19, 2017 at 5:11 PM, youenn fablet wrote: > When a spec gets updated, the WPT tests will ideally be updated at the same > time. > The updated tests will no longer ensure non-regression until the browser > implements the new behavior. Ideally if importing test

Re: [webkit-dev] Where do we put WPT tests to be exported

Le jeu. 18 mai 2017 à 05:09, Philip Jägenstedt a écrit : > >> FWIW, I think it makes sense to treat wpt as both regression tests and > conformance tests. They're regression tests because they can in fact catch > regressions. And they're conformance tests because they're

Re: [webkit-dev] Where do we put WPT tests to be exported

On Tue, May 16, 2017 at 8:42 AM, Konstantin Tokarev wrote: > > > 16.05.2017, 17:54, "Michael Catanzaro" : >> On Mon, May 15, 2017 at 11:01 PM, Ryosuke Niwa wrote: >>> Hi all, >>> >>> Youenn is working on a patch to automatically

Re: [webkit-dev] Where do we put WPT tests to be exported

16.05.2017, 17:54, "Michael Catanzaro" : > On Mon, May 15, 2017 at 11:01 PM, Ryosuke Niwa wrote: >>  Hi all, >> >>  Youenn is working on a patch to automatically create a GitHub PR to >>  export tests from a WebKit patch which includes changes to >>  

Re: [webkit-dev] Where do we put WPT tests to be exported

That is a fair point! For importing tests, effort was done to ease the use of the import-w3c-tests script. Documentation should be in "Tools/Scripts/import-w3c-tests --help" I will be happy to beef it up based on suggestions. y Le mar. 16 mai 2017 à 07:55, Michael Catanzaro

Re: [webkit-dev] Where do we put WPT tests to be exported

Le lun. 15 mai 2017 à 23:15, Maciej Stachowiak a écrit : > > On May 15, 2017, at 9:08 PM, youenn fablet wrote: > > I see two main cases: > - Writer of the patch is making sure to upstream WPT test changes at > WebKit landing time. It is ok to make the changes

Re: [webkit-dev] Where do we put WPT tests to be exported

On Mon, May 15, 2017 at 11:01 PM, Ryosuke Niwa wrote: Hi all, Youenn is working on a patch to automatically create a GitHub PR to export tests from a WebKit patch which includes changes to web-platform-tests [1]. That raises a question as to where we should put new tests or

Re: [webkit-dev] Where do we put WPT tests to be exported

> On May 15, 2017, at 9:08 PM, youenn fablet wrote: > > I see two main cases: > - Writer of the patch is making sure to upstream WPT test changes at WebKit > landing time. It is ok to make the changes directly in > LayoutTests/imported/w3c/web-platform-tests/ > - Writer

Re: [webkit-dev] Where do we put WPT tests to be exported

I see two main cases: - Writer of the patch is making sure to upstream WPT test changes at WebKit landing time. It is ok to make the changes directly in LayoutTests/imported/w3c/web-platform-tests/ - Writer plans to upstream WPT test changes at some point but wants more time. It is better to

[webkit-dev] Where do we put WPT tests to be exported

Hi all, Youenn is working on a patch to automatically create a GitHub PR to export tests from a WebKit patch which includes changes to web-platform-tests [1]. That raises a question as to where we should put new tests or modified tests intended to be exported to web-platform-tests from WebKit.