Re: [webkit-dev] Feature Announcement: Adding iframe seamless

2012-05-02 Thread Jarred Nicholls
On Tue, May 1, 2012 at 7:39 PM, Maciej Stachowiak m...@apple.com wrote: On May 1, 2012, at 4:04 PM, Adam Barth aba...@webkit.org wrote: On Tue, May 1, 2012 at 3:50 PM, Maciej Stachowiak m...@apple.com wrote: On May 1, 2012, at 3:31 PM, Eric Seidel e...@webkit.org wrote: Is your goal to

Re: [webkit-dev] Feature Announcement: Adding iframe seamless

2012-05-02 Thread Jarred Nicholls
On Wed, May 2, 2012 at 2:03 PM, Maciej Stachowiak m...@apple.com wrote: On May 2, 2012, at 6:14 AM, Jarred Nicholls jar...@webkit.org wrote: On Tue, May 1, 2012 at 7:39 PM, Maciej Stachowiak m...@apple.com wrote: I'm not too picky about how it's done, but I'd feel more comfortable with

Re: [webkit-dev] Feature Announcement: Adding iframe seamless

2012-05-02 Thread Maciej Stachowiak
On May 2, 2012, at 11:48 AM, Jarred Nicholls jar...@webkit.org wrote: On Wed, May 2, 2012 at 2:03 PM, Maciej Stachowiak m...@apple.com wrote: On May 2, 2012, at 6:14 AM, Jarred Nicholls jar...@webkit.org wrote: On Tue, May 1, 2012 at 7:39 PM, Maciej Stachowiak m...@apple.com wrote:

Re: [webkit-dev] Feature Announcement: Adding iframe seamless

2012-05-02 Thread Adam Barth
On Wed, May 2, 2012 at 12:11 PM, Maciej Stachowiak m...@apple.com wrote: On May 2, 2012, at 11:48 AM, Jarred Nicholls jar...@webkit.org wrote: On Wed, May 2, 2012 at 2:03 PM, Maciej Stachowiak m...@apple.com wrote: On May 2, 2012, at 6:14 AM, Jarred Nicholls jar...@webkit.org wrote: On Tue,

Re: [webkit-dev] Feature Announcement: Adding iframe seamless

2012-05-02 Thread Maciej Stachowiak
On May 2, 2012, at 1:03 PM, Adam Barth aba...@webkit.org wrote: One example from this case is seamless navigation. I implemented seamless navigation in two steps: 1) Refactoring the existing codepaths to go through a common function. 2) Teaching the common function how to redirect

Re: [webkit-dev] Feature Announcement: Adding iframe seamless

2012-05-01 Thread Eric Seidel
Work is complete, fully working. Passing all the tests I could come up with: https://github.com/eseidel/webkit/compare/master...seamless I'm uploading and landing patches once reviewed again in bugzilla. I do not plan to add an ENABLE, as this work is complete and will all be landed by end of

Re: [webkit-dev] Feature Announcement: Adding iframe seamless

2012-05-01 Thread Maciej Stachowiak
On May 1, 2012, at 12:20 PM, Eric Seidel e...@webkit.org wrote: Work is complete, fully working. Passing all the tests I could come up with: https://github.com/eseidel/webkit/compare/master...seamless I'm uploading and landing patches once reviewed again in bugzilla. I do not plan to

Re: [webkit-dev] Feature Announcement: Adding iframe seamless

2012-05-01 Thread Dimitri Glazkov
On Tue, May 1, 2012 at 2:06 PM, Maciej Stachowiak m...@apple.com wrote: On May 1, 2012, at 12:20 PM, Eric Seidel e...@webkit.org wrote: Work is complete, fully working.  Passing all the tests I could come up with: https://github.com/eseidel/webkit/compare/master...seamless I'm

Re: [webkit-dev] Feature Announcement: Adding iframe seamless

2012-05-01 Thread Eric Seidel
Is your goal to be able to disable the feature to prevent a late-known security issue? Or is your goal to universally disable seamless for a port entirely? On Tue, May 1, 2012 at 2:06 PM, Maciej Stachowiak m...@apple.com wrote: On May 1, 2012, at 12:20 PM, Eric Seidel e...@webkit.org wrote:

Re: [webkit-dev] Feature Announcement: Adding iframe seamless

2012-05-01 Thread Maciej Stachowiak
On May 1, 2012, at 3:31 PM, Eric Seidel e...@webkit.org wrote: Is your goal to be able to disable the feature to prevent a late-known security issue? Or is your goal to universally disable seamless for a port entirely? I'm not sure I understand the difference between these. The capability

Re: [webkit-dev] Feature Announcement: Adding iframe seamless

2012-05-01 Thread Adam Barth
On Tue, May 1, 2012 at 3:50 PM, Maciej Stachowiak m...@apple.com wrote: On May 1, 2012, at 3:31 PM, Eric Seidel e...@webkit.org wrote: Is your goal to be able to disable the feature to prevent a late-known security issue? Or is your goal to universally disable seamless for a port entirely?

Re: [webkit-dev] Feature Announcement: Adding iframe seamless

2012-05-01 Thread Maciej Stachowiak
On May 1, 2012, at 4:04 PM, Adam Barth aba...@webkit.org wrote: On Tue, May 1, 2012 at 3:50 PM, Maciej Stachowiak m...@apple.com wrote: On May 1, 2012, at 3:31 PM, Eric Seidel e...@webkit.org wrote: Is your goal to be able to disable the feature to prevent a late-known security issue? Or

Re: [webkit-dev] Feature Announcement: Adding iframe seamless

2012-03-31 Thread Alexey Proskuryakov
30.03.2012, в 20:11, Darin Fisher написал(а): I think it is a risky practice for WebKit to have half-baked webkit prefixed features enabled by default on trunk. I agree. The patch that exposed this to be removed attribute (https://bugs.webkit.org/show_bug.cgi?id=82795) also added a number

Re: [webkit-dev] Feature Announcement: Adding iframe seamless

2012-03-30 Thread Darin Fisher
[Oops, I meant to reply on list.] I think it is a risky practice for WebKit to have half-baked webkit prefixed features enabled by default on trunk. It puts the burden on all WebKit ports to know which features are half-baked, whereas individual authors of new features would know best how stable