Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

2020-06-24 Thread Geoffrey Garen
OK. Geooff > On Jun 24, 2020, at 12:19 PM, Saam Barati wrote: > > If we're only doing this for JSC, I don't think we need this, as none of us > care. > > If we want to do it for all of WK testing, we should include this for folks > who care about having O0-style stack traces. > > - Saam >

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

2020-06-24 Thread Saam Barati
If we're only doing this for JSC, I don't think we need this, as none of us care. If we want to do it for all of WK testing, we should include this for folks who care about having O0-style stack traces. - Saam > On Jun 24, 2020, at 12:17 PM, Geoffrey Garen wrote: > > Is "-fno-inline

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

2020-06-24 Thread Geoffrey Garen
Is "-fno-inline -fno-optimize-sibling-calls” still on the table? Thanks, Geoff > On Jun 24, 2020, at 10:28 AM, Mark Lam wrote: > > I forgot to add ... > >> On Jun 24, 2020, at 10:26 AM, Mark Lam > > wrote: >> >> Based on all the feedback given so far, it looks like

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

2020-06-24 Thread Mark Lam
I forgot to add ... > On Jun 24, 2020, at 10:26 AM, Mark Lam wrote: > > Based on all the feedback given so far, it looks like we can move forward > with the following plan: > 1. JSC Debug test bots will build their own local jsc with O3 before running > the tests. 1.5 JSC EWS bot will also

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

2020-06-24 Thread Mark Lam
Based on all the feedback given so far, it looks like we can move forward with the following plan: 1. JSC Debug test bots will build their own local jsc with O3 before running the tests. 2. The rest of the build and test bots will remain unchanged. Let's move forward with this and get the Debug

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

2020-06-19 Thread Alexey Proskuryakov
> 19 июня 2020 г., в 1:11 PM, Mark Lam написал(а): > > > >> On Jun 19, 2020, at 10:24 AM, Geoffrey Garen > > wrote: >> On Jun 19, 2020, at 8:04 AM, Geoffrey Garen >>> > wrote: Can you explain more about what "O3 with

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

2020-06-19 Thread Mark Lam
> On Jun 19, 2020, at 1:04 PM, Alexey Proskuryakov wrote: > > > >> 19 июня 2020 г., в 10:24 AM, Geoffrey Garen > > написал(а): >> On Jun 19, 2020, at 8:04 AM, Geoffrey Garen >>> > wrote: Can you explain more about what "O3

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

2020-06-19 Thread Saam Barati
> On Jun 19, 2020, at 1:04 PM, Alexey Proskuryakov wrote: > > > >> 19 июня 2020 г., в 10:24 AM, Geoffrey Garen > > написал(а): >> On Jun 19, 2020, at 8:04 AM, Geoffrey Garen >>> > wrote: Can you explain more about what "O3

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

2020-06-19 Thread Mark Lam
> On Jun 19, 2020, at 10:24 AM, Geoffrey Garen wrote: > >>> On Jun 19, 2020, at 8:04 AM, Geoffrey Garen >> > wrote: >>> >>> Can you explain more about what "O3 with no-inlining” is? How does >>> --force-opt=O3 avoid inlining? Would this fully resolve Simon concern

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

2020-06-19 Thread Alexey Proskuryakov
> 19 июня 2020 г., в 10:24 AM, Geoffrey Garen написал(а): > >>> On Jun 19, 2020, at 8:04 AM, Geoffrey Garen >> > wrote: >>> >>> Can you explain more about what "O3 with no-inlining” is? How does >>> --force-opt=O3 avoid inlining? Would this fully resolve Simon

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

2020-06-19 Thread Mark Lam
> On Jun 19, 2020, at 10:02 AM, Alexey Proskuryakov wrote: > > > >> 19 июня 2020 г., в 9:59 AM, Mark Lam > > написал(а): >> >> >> >>> On Jun 19, 2020, at 9:53 AM, Alexey Proskuryakov >> > wrote: >>> >>> >>> 18 июня 2020 г., в 9:30

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

2020-06-19 Thread Geoffrey Garen
>> On Jun 19, 2020, at 8:04 AM, Geoffrey Garen > > wrote: >> >> Can you explain more about what "O3 with no-inlining” is? How does >> --force-opt=O3 avoid inlining? Would this fully resolve Simon concern about >> stack traces, or would something still be different about

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

2020-06-19 Thread Saam Barati
> On Jun 19, 2020, at 10:02 AM, Saam Barati wrote: > > > >> On Jun 19, 2020, at 8:04 AM, Geoffrey Garen > > wrote: >> >> Can you explain more about what "O3 with no-inlining” is? How does >> --force-opt=O3 avoid inlining? Would this fully resolve Simon concern

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

2020-06-19 Thread Alexey Proskuryakov
> 19 июня 2020 г., в 9:59 AM, Mark Lam написал(а): > > > >> On Jun 19, 2020, at 9:53 AM, Alexey Proskuryakov > > wrote: >> >> >> >>> 18 июня 2020 г., в 9:30 PM, Saam Barati >> > написал(а): >>> >>> Why are we insisting on doing something

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

2020-06-19 Thread Saam Barati
> On Jun 19, 2020, at 8:04 AM, Geoffrey Garen wrote: > > Can you explain more about what "O3 with no-inlining” is? How does > --force-opt=O3 avoid inlining? Would this fully resolve Simon concern about > stack traces, or would something still be different about stack traces? There doesn't

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

2020-06-19 Thread Mark Lam
> On Jun 19, 2020, at 9:53 AM, Alexey Proskuryakov > wrote: > > > >> 18 июня 2020 г., в 9:30 PM, Saam Barati > > написал(а): >> >> Why are we insisting on doing something on the bots that takes ~10x longer >> to run than necessary? I’d

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

2020-06-19 Thread Alexey Proskuryakov
> 18 июня 2020 г., в 9:30 PM, Saam Barati написал(а): > > Why are we insisting on doing something on the bots that takes ~10x longer to > run than necessary? I’d rather have that time spent running more tests. Replying to this point specifically, I wanted to point out that WebKit tests take

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

2020-06-19 Thread Geoffrey Garen
Can you explain more about what "O3 with no-inlining” is? How does --force-opt=O3 avoid inlining? Would this fully resolve Simon concern about stack traces, or would something still be different about stack traces? And again, I think this discussion would get a lot more focused if the change

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

2020-06-18 Thread Saam Barati
Why are we insisting on doing something on the bots that takes ~10x longer to run than necessary? I’d rather have that time spent running more tests. Overall, how we’re doing things now feels like a bad allocation of bot resources. The differences I see between O3 with no-inlining vs O0 is: -

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

2020-06-18 Thread Geoffrey Garen
Better JSC debugging in exchange for worse debugging in non-JSC code that calls through to WTF is not a great tradeoff. Is there a way to localize this change to only JSC? Do we know for sure that this change would get stress tests running, or are we just guessing? Can we find out? It’s easier

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

2020-06-18 Thread Ryan Haddad
> On Jun 18, 2020, at 9:44 AM, Alex Christensen wrote: > > It sounds to me like Mark’s suggestion does not lose anything. It’s just for > JSC “Debug” The post-commit JSC bots use the same build products as the other debug testers, so with our current setup it would have to apply to other

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

2020-06-18 Thread Alex Christensen
It sounds to me like Mark’s suggestion does not lose anything. It’s just for JSC “Debug” which currently is not running because it’s too slow. If he called it “ReleaseWithAssert” it would make it more clear what is going on and we would all appreciate the additional information those bots

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

2020-06-17 Thread Simon Fraser
I also object to losing good stack traces for crashes on Debug bots. Also, I don't think Debug bots should build something different from what I build at my desk. Simon > On Jun 17, 2020, at 1:36 PM, Mark Lam wrote: > > Hi folks, > > We're planning to switch the JSC EWS bot and

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

2020-06-17 Thread Yusuke Suzuki
In JSC EWS bots. For the other Debug EWS bots, (Like, WebCore Debug builds), I have no strong opinion. -Yusuke > On Jun 17, 2020, at 6:07 PM, Yusuke Suzuki wrote: > > For EWS, we are running Release build right now. So in terms of stack traces, > nothing is changed. > > -Yusuke > >> On Jun

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

2020-06-17 Thread Yusuke Suzuki
For EWS, we are running Release build right now. So in terms of stack traces, nothing is changed. -Yusuke > On Jun 17, 2020, at 5:21 PM, Alexey Proskuryakov wrote: > > > I frequently find it critically useful to see stack traces from debug builds, > because of no inlining. So I don't think

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

2020-06-17 Thread Alexey Proskuryakov
I frequently find it critically useful to see stack traces from debug builds, because of no inlining. So I don't think that we should do this. A local build does not help when the issue is not readily reproducible. - Alexey > 17 июня 2020 г., в 1:36 PM, Mark Lam написал(а): > > Hi folks, >