Prashant Srinivasan wrote:
*** usr/src/cmd/ruby18/Makefile.sfw
- Do not redefine GMAKE, it's already defined by Makefile.master
Jyri, doesn't $GMAKE refer to the build time location of gmake? The
build time location and the runtime location of gmake are, of course,
currently the same.
*** usr/src/cmd/ruby18/Makefile.sfw
- Do not redefine GMAKE, it's already defined by Makefile.master
Jyri, doesn't $GMAKE refer to the build time location of gmake? The
build time location and the runtime location of gmake are, of course,
currently the same.
But is it guaranteed to stay
Gopalakrishnan Sankaran wrote:
http://cr.opensolaris.org/~gs193864/cr6644643/
*** usr/src/cmd/ruby18/Makefile.sfw
- Do not redefine GMAKE, it's already defined by Makefile.master
*** usr/src/cmd/ruby18/postinstall-ruby
- For rbconfig.rb file that gets generated, even if you don't provide a
Hi Prashant,
I have updated the man page as per your suggestions.
http://cr.opensolaris.org/~gs193864/cr6644643/
Thanks,
Gopal.
Jyri Virkki wrote:
Gopalakrishnan Sankaran wrote:
Hi Siva, Jyri,
I have made the changes reqd (including the appropriate #ident). I ran
wx pbchk
Gopal,
This looks good to me.
-ps
Gopalakrishnan Sankaran wrote:
Hi Prashant,
I have updated the man page as per your suggestions.
http://cr.opensolaris.org/~gs193864/cr6644643/
Thanks,
Gopal.
Jyri Virkki wrote:
Gopalakrishnan Sankaran wrote:
Hi Siva, Jyri,
I have made
Hi Jyri,
Have made the changes and have updated the webrev.
http://cr.opensolaris.org/~gs193864/cr6644643/
Thanks,
Gopal.
Jyri Virkki wrote:
Gopalakrishnan Sankaran wrote:
Hi Siva, Jyri,
I have made the changes reqd (including the appropriate #ident). I ran
wx pbchk which returned
Gopal,
A couple of comments.
Please change the Webrev comments to have the 'exact' bug synopsis
against all the files.
You could do a 'wx pbchk' to find errors
postinstall-ruby:
You could use another file name instead of just 'temp'. May be use
rbconfig.$$ or similar.
Other changes look
Hi Siva,
Have made the changes. Please review it again.
http://cr.opensolaris.org/~gs193864/cr6644643/
Thanks,
Gopal.
Sivakumar Shanmugasundaram wrote:
Gopal,
A couple of comments.
Please change the Webrev comments to have the 'exact' bug synopsis
against all the files.
You could do a
Gopal,
Looks good to me. I assume you have done 'wx pbchk' on your wokspace and
do not get any errors from this command.
Oh, I do not see Jyri's comments addressed. Please fix them. Add the
appropriate '#ident' and do 'wx redelget'
Siva
Gopalakrishnan Sankaran wrote:
Hi Siva,
Have made
Hi Siva, Jyri,
I have made the changes reqd (including the appropriate #ident). I ran
wx pbchk which returned no errors.
Kindly review the code changes.
http://cr.opensolaris.org/~gs193864/cr6644643/
Thanks,
Gopal.
Sivakumar Shanmugasundaram wrote:
Gopal,
Looks good to me. I assume you
Gopalakrishnan Sankaran wrote:
Hi Siva, Jyri,
I have made the changes reqd (including the appropriate #ident). I ran
wx pbchk which returned no errors.
Kindly review the code changes.
http://cr.opensolaris.org/~gs193864/cr6644643/
Not sure if you saw my comment from Apr.4 but the
Hi,
Here is the webrev after making the changes required (as suggested in
the initial round of review)
Kindly review the changes.
http://cr.opensolaris.org/~gs193864/cr6644643/
--
Thanks,
Gopal
http://blogs.sun.com/gkrish
Gopalakrishnan Sankaran wrote:
Hi,
Here is the webrev after making the changes required (as suggested in
the initial round of review)
Kindly review the changes.
http://cr.opensolaris.org/~gs193864/cr6644643/
Thanks, I see that both my requested changes (1) prepend gmake with
path,
Gopalakrishnan Sankaran wrote:
Here is the webrev after making the changes required (as suggested in
the initial round of review)
Kindly review the changes.
http://cr.opensolaris.org/~gs193864/cr6644643/
Hi,
Please let us know which set of gems did you use for testing the
native
Jyri Virkki wrote:
Gopalakrishnan Sankaran wrote:
Here is the webrev after making the changes required (as suggested in
the initial round of review)
Kindly review the changes.
http://cr.opensolaris.org/~gs193864/cr6644643/
Hi,
Please let us know which set of gems did you use
15 matches
Mail list logo
