[Bug 14717] wikibits includes nonexistent stylesheet, KHTMLfixes.css
https://bugzilla.wikimedia.org/show_bug.cgi?id=14717 Jools Wills b...@exotica.org.uk changed: What|Removed |Added Attachment #5157 is|0 |1 obsolete|| Attachment #5839 is|0 |1 obsolete|| --- Comment #13 from Jools Wills b...@exotica.org.uk 2010-01-13 19:53:29 UTC --- Created an attachment (id=6953) -- (https://bugzilla.wikimedia.org/attachment.cgi?id=6953) add skin specific config to choose fixes for wikibits.js to include Earlier patch was rejected by Brion, as it was monobook specific, and didn't address the other css files for other browsers. Here is a patch that has an additional skin variable that contains an associative array where each buggy browser can have an associated css fix file with it. I have included this for monobook. I don't think any of the other skin's need these fixes. I also changed the parameter for makeGlobalVariablesScript to be the skin object/class rather than just the name of the skin, so it can get the data about the required css' from the skin to pass to the javascript. I chose this over adding an additional parameter, in case more stuff was needed in the future, but feel free to make it two parameters if preferred, -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14717] wikibits includes nonexistent stylesheet, KHTMLfixes.css
https://bugzilla.wikimedia.org/show_bug.cgi?id=14717 Jools Wills b...@exotica.org.uk changed: What|Removed |Added Status|RESOLVED|REOPENED Keywords|easy| Resolution|INVALID | --- Comment #14 from Jools Wills b...@exotica.org.uk 2010-01-13 19:54:52 UTC --- reopening bug : see previous patch -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14717] wikibits includes nonexistent stylesheet(s)
https://bugzilla.wikimedia.org/show_bug.cgi?id=14717 Jools Wills b...@exotica.org.uk changed: What|Removed |Added Summary|wikibits includes |wikibits includes |nonexistent stylesheet, |nonexistent stylesheet(s) |KHTMLfixes.css | -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14717] wikibits includes nonexistent stylesheet(s)
https://bugzilla.wikimedia.org/show_bug.cgi?id=14717 Jools Wills b...@exotica.org.uk changed: What|Removed |Added Attachment #6953 is|0 |1 obsolete|| --- Comment #15 from Jools Wills b...@exotica.org.uk 2010-01-13 19:57:24 UTC --- Created an attachment (id=6954) -- (https://bugzilla.wikimedia.org/attachment.cgi?id=6954) add skin specific config to choose fixes for wikibits.js to include Sorry. wrong version. here is correct diff -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14717] wikibits includes nonexistent stylesheet(s)
https://bugzilla.wikimedia.org/show_bug.cgi?id=14717 --- Comment #16 from Aryeh Gregor simetrical+wikib...@gmail.com 2010-01-13 20:21:56 UTC --- Is there a big advantage here over just hardcoding it into wikibits.js? In practice, it looks like nothing but Monobook (and Chick, which is closely patterned off Monobook) actually uses separate fixes files. Third-party skins can always inject their own CSS fixes through other means if they really want them, or just use CSS selector hacks like Vector does. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14717] wikibits includes nonexistent stylesheet(s)
https://bugzilla.wikimedia.org/show_bug.cgi?id=14717 --- Comment #17 from Jools Wills b...@exotica.org.uk 2010-01-13 20:27:01 UTC --- well hardcoding it would have been much easier based on skin name, but a previous patch got reverted for this reason by brion, so i made it as was requested here. Im happy with any fix. I just want the 404's outta my stats ;-) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14717] wikibits includes nonexistent stylesheet(s)
https://bugzilla.wikimedia.org/show_bug.cgi?id=14717 Aryeh Gregor simetrical+wikib...@gmail.com changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||FIXED --- Comment #18 from Aryeh Gregor simetrical+wikib...@gmail.com 2010-01-13 20:40:08 UTC --- Committed a hardcoded check for Monobook in r61023. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14717] wikibits includes nonexistent stylesheet(s)
https://bugzilla.wikimedia.org/show_bug.cgi?id=14717 --- Comment #19 from Jools Wills b...@exotica.org.uk 2010-01-13 20:41:29 UTC --- Created an attachment (id=6955) -- (https://bugzilla.wikimedia.org/attachment.cgi?id=6955) alternative fix for fixes css inclusion here is an alternative css fix which hardcodes the skinnames. I removed the typedef checks, as I couldn't see how you could get to this point without skinname/stylepath being defined. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22093] New: Native Microsoft SQL Server Support
https://bugzilla.wikimedia.org/show_bug.cgi?id=22093 Summary: Native Microsoft SQL Server Support Product: MediaWiki Version: 1.15.1 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: Normal Component: Database AssignedTo: wikibugs-l@lists.wikimedia.org ReportedBy: a-cpu...@microsoft.com Created an attachment (id=6956) -- (https://bugzilla.wikimedia.org/attachment.cgi?id=6956) Native Microsoft SQL Server Support Patch Currently Mediawiki only supports the community mssql driver for php. I've created a Mediawiki 1.15.1 driver package that uses the Native SQL Server driver for PHP which was recently released by Microsoft (currently in v1.1). More information regarding the Native SQL Server driver for PHP can be found here: http://www.microsoft.com/downloads/details.aspx?FamilyId=61BF87E0-D031-466B-B09A-6597C21A2E2Adisplaylang=en I've attached the full patch file that adds Native SQL Server support to Mediawiki 1.15.1 to this request and would love to work with the maintainers in order to have this package officially supported. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 15676] Duplicate image reuploading should be forbidden
https://bugzilla.wikimedia.org/show_bug.cgi?id=15676 Bryan Tong Minh bryan.tongm...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Comment #7 from Bryan Tong Minh bryan.tongm...@gmail.com 2010-01-13 21:21:07 UTC --- Seems not worth the hassle at all. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22093] Native Microsoft SQL Server Support
https://bugzilla.wikimedia.org/show_bug.cgi?id=22093
Bryan Tong Minh bryan.tongm...@gmail.com changed:
What|Removed |Added
CC||bryan.tongm...@gmail.com
--- Comment #1 from Bryan Tong Minh bryan.tongm...@gmail.com 2010-01-13
21:33:23 UTC ---
I only took a quick look, but some general comments. Does it really need to
duplicate every single function from DatabaseBase? selectSQLText() looks
completely copied. I also think there may be unnecessary duplication between
the two mssql database classes. Things like SQL generation can be completely
shared, only things that call the underlying database interface ought to be
different.
What is exactly the advantage between using the two drivers?
Also some specific notes:
-...@ini_set( display_errors, true );
+...@ini_set( display_errors, false );
?
+ # since MSSQL doesn't recognize the infinity keyword, set date
manually
+ # TO-DO: refactor for better DB portability and remove magic
date
+ $dbw = wfGetDB(DB_MASTER);
+ if($dbw instanceof DatabaseMssqlnative)
+ {
+ return '3000-01-31 00:00:00.000';
+ }
This should be implemented as Database*::infinity()
- GROUP BY tl_namespace, tl_title
+ GROUP BY tl_title, tl_namespace
Why?
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22094] Allow users to subscribe to a revision without commenting on it.
https://bugzilla.wikimedia.org/show_bug.cgi?id=22094 Roan Kattouw roan.katt...@gmail.com changed: What|Removed |Added CC||roan.katt...@gmail.com --- Comment #1 from Roan Kattouw roan.katt...@gmail.com 2010-01-13 21:45:16 UTC --- bug 22046 related -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22046] Allow users to subscribe to all CR comments
https://bugzilla.wikimedia.org/show_bug.cgi?id=22046 Roan Kattouw roan.katt...@gmail.com changed: What|Removed |Added CC||roan.katt...@gmail.com --- Comment #1 from Roan Kattouw roan.katt...@gmail.com 2010-01-13 21:45:26 UTC --- bug 22094 related -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22058] Blocked users can edit monobook.css etc.
https://bugzilla.wikimedia.org/show_bug.cgi?id=22058 --- Comment #16 from DaSch dasch...@gmx.net 2010-01-13 22:21:36 UTC --- so the solution for this bug is to force everybody to use firefox and install this extensions? Sorry, but: That's just stupid. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 16451] GIF scaling limit should be applied to animated GIFs only
https://bugzilla.wikimedia.org/show_bug.cgi?id=16451 Platonides platoni...@gmail.com changed: What|Removed |Added CC||platoni...@gmail.com --- Comment #37 from Platonides platoni...@gmail.com 2010-01-13 22:24:58 UTC --- The fix was reverted, follow up on bug 22041 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22058] Blocked users can edit monobook.css etc.
https://bugzilla.wikimedia.org/show_bug.cgi?id=22058 --- Comment #17 from Mike.lifeguard mike.lifegu...@gmail.com 2010-01-13 22:24:59 UTC --- (In reply to comment #7) Indeed; I kind of took it for granted that Platonides was saying that it should be WONTFIXed *because they could become* unwanted platforms. Sorry, I was reading things as being opposite. Platonides is correct the I'd consider changing MediaWiki as requested to be introducing a bug. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 18801] Don't make me choose between Atom and RSS
https://bugzilla.wikimedia.org/show_bug.cgi?id=18801 Aryeh Gregor simetrical+wikib...@gmail.com changed: What|Removed |Added CC||simetrical+wikib...@gmail.co ||m Status|NEW |RESOLVED Resolution||FIXED --- Comment #1 from Aryeh Gregor simetrical+wikib...@gmail.com 2010-01-13 22:45:31 UTC --- Should be largely fixed in r61026. There might be some places where a double option is still offered -- if you find any, reopen, or file a new bug and CC me. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 3646] RSS, Atom, XML syndication feeds (tracking)
https://bugzilla.wikimedia.org/show_bug.cgi?id=3646 Bug 3646 depends on bug 18801, which changed state. Bug 18801 Summary: Don't make me choose between Atom and RSS https://bugzilla.wikimedia.org/show_bug.cgi?id=18801 What|Old Value |New Value Status|NEW |RESOLVED Resolution||FIXED -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 21598] Don't run Tests if only certain files/directories changed
https://bugzilla.wikimedia.org/show_bug.cgi?id=21598 Bryan Tong Minh bryan.tongm...@gmail.com changed: What|Removed |Added CC||bryan.tongm...@gmail.com --- Comment #1 from Bryan Tong Minh bryan.tongm...@gmail.com 2010-01-13 22:46:19 UTC --- But it doesn't hurt. Creating a bunch of special cases does not seem worth to me the slight speed increase. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22058] Blocked users can edit monobook.css etc.
https://bugzilla.wikimedia.org/show_bug.cgi?id=22058 Alex Z. mrzmanw...@gmail.com changed: What|Removed |Added CC||mrzmanw...@gmail.com --- Comment #18 from Alex Z. mrzmanw...@gmail.com 2010-01-13 22:46:22 UTC --- (In reply to comment #16) so the solution for this bug is to force everybody to use firefox and install this extensions? Sorry, but: That's just stupid. No, not everyone, just the tiny minority of users who are blocked and want to be able to change CSS/JS but aren't willing to contact an administrator. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22093] Native Microsoft SQL Server Support
https://bugzilla.wikimedia.org/show_bug.cgi?id=22093 --- Comment #2 from Chris Pucci a-cpu...@microsoft.com 2010-01-13 22:53:24 UTC --- Hi Bryan, Thanks for the comments. I've tried to address them below: Does it really need to duplicate every single function from DatabaseBase? selectSQLText() looks completely copied. Yeah, we definitely want to minimize or remove duplication if it exists. In the method you mentioned, there are actually some slight differences in regards to limits and offsets which is why it was extended in the mssqlnative.php database class. It is something to be aware of though and I will go back and ensure that we aren't needlessly duplicating existing code. I also think there may be unnecessary duplication between the two mssql database classes. Things like SQL generation can be completely shared... This is absolutely true with one example being the tables.sql file that is basically identicle for the mssql and the mssqlnative drivers. There were basically two reasons we chose to create new files for the native driver even if they were identicle instead of simply including or pointing to the existing mssql version. The first was to maintain the existing Mediawiki file structure in regards each individual driver and the associated files for said driver. The second reason was to maintain separate files in case future changes need to be made that may affect one driver and not the other. I'm open to changing that however if necessary though as part of our goal with submitting this patch is to develop in the light, so any community or project suggestions are appreciated. What is exactly the advantage between using the two drivers? There are actually quite a few differences and advantages to using the Native SQL Server driver. First, it is my understanding that community MSSQL driver is no longer officially maintained or supported whereas the Native driver is still in active development, is feature rich and is actively supported and maintained. There are also a few key features that the Native driver provides such as built-in UTF-8 support, (MSSQL driver requires a bridge for UTF-8), and MARS support which means it is compatible with SQL Azure which is a cloud based DB offering. There are other benefits as well and full information about the Native driver can be found here: http://www.microsoft.com/downloads/details.aspx?FamilyID=ccdf728b-1ea0-48a8-a84a-5052214caad9displaylang=en As for your other notes, I'll look into implementing the database::infinity solution. I've also updated the patch file and removed some unnecessary artifacts from testing/debugging. Regards, Chris -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22093] Native Microsoft SQL Server Support
https://bugzilla.wikimedia.org/show_bug.cgi?id=22093 Chris Pucci a-cpu...@microsoft.com changed: What|Removed |Added Attachment #6956 is|0 |1 obsolete|| --- Comment #3 from Chris Pucci a-cpu...@microsoft.com 2010-01-13 22:56:01 UTC --- Created an attachment (id=6957) -- (https://bugzilla.wikimedia.org/attachment.cgi?id=6957) Updated Native SQL Server Patch -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22093] Native Microsoft SQL Server Support
https://bugzilla.wikimedia.org/show_bug.cgi?id=22093 Chad H. innocentkil...@gmail.com changed: What|Removed |Added CC||innocentkil...@gmail.com --- Comment #4 from Chad H. innocentkil...@gmail.com 2010-01-13 23:35:18 UTC --- If the old driver has been discontinued, I would be in favor of dropping support for it in favor of this. IIRC, the current MSSQL class barely even works and has been practically abandoned for some time. Also, don't use @ for error suppression, use wfSuppressWarnings() and wfRestoreWarnings() before and after the error you wish to suppress. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22010] SQL error while deleting on SQLite
https://bugzilla.wikimedia.org/show_bug.cgi?id=22010 Chad H. innocentkil...@gmail.com changed: What|Removed |Added CC||innocentkil...@gmail.com --- Comment #4 from Chad H. innocentkil...@gmail.com 2010-01-13 23:39:30 UTC --- (In reply to comment #3) The bug is pretty critical when deleting files, because SQL error at that time does not lead to rollback of non-database changes, such as move of file to archive storage. Page deletion seems to fail gracefully. That's related to bug 17560 and its friend bug 19751. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22093] Native Microsoft SQL Server Support
https://bugzilla.wikimedia.org/show_bug.cgi?id=22093
Aryeh Gregor simetrical+wikib...@gmail.com changed:
What|Removed |Added
CC||simetrical+wikib...@gmail.co
||m
--- Comment #5 from Aryeh Gregor simetrical+wikib...@gmail.com 2010-01-13
23:42:12 UTC ---
If there are only slight changes to a method like selectSQLText(), you should
probably adjust the parent method a little so that the differences are pulled
out into separate methods you can override in child classes. Notice how
selectSQLText() already calls methods like limitResult() so child classes don't
have to duplicate code; it's not meant to be overridden by children.
Also, if your class has some methods identical to DatabaseMssql's, you might
want to inherit from it instead of DatabaseBase. It can stay in a separate
file, the autoloader will take care of include order. You should definitely
share code wherever possible -- don't feel too bound by current conventions as
far as file arrangement, since this is the first time we've got support for two
different drivers for the same DB. If it makes more sense to use the same
schema, say, then do that.
You should consider requesting commit access here:
http://www.mediawiki.org/wiki/Commit_access_requests
Someone who wants to do general-purpose commits normally needs to get a bunch
of patches approved first, but if your only aim is to maintain support for a
database, you can probably get commit access for that purpose right away, or at
least that's been the case sometimes in the past. But it can sometimes take a
while before new requests get looked at.
Comments:
diff -rupN
/home/chris/Desktop/RemoteDesktop/mediawiki-1.15.1.tar/mediawiki-1.15.1/mediawiki115/config/index.php
Patches should be submitted against SVN trunk so they apply cleanly. See
http://www.mediawiki.org/wiki/Subversion. On Windows, your best bet is
probably to use TortoiseSVN, check out
http://svn.wikimedia.org/svnroot/mediawiki/trunk/phase3 someplace, make your
changes, right-click and select Create Patch (or whatever, haven't used it
for years). Failing that, it would help if you at least made your patches
against nightly tarballs: http://toolserver.org/~vvv/mw-nightly/
-
- if( $conf-DBtype == 'mysql' ) {
...
+ switch($conf-DBtype) {
+ case 'mysql':
This is a good place to use a switch, you're right, but it's best if you don't
make unrelated changes like this in your patches. They make it harder to
review. Especially since you've changed indentation, so all the lines are
changed and it's hard to see which ones are actually different.
+ 'SearchMssqlnative' = 'includes/SearchMSSQLNative.php',
...
+ 'DatabaseMssqlnative' = 'includes/db/DatabaseMssqlnative.php',
Probably SearchMssqlNative, DatabaseMssqlNative, DatabaseMssqlNative.php would
be more expected capitalizations.
+ # since MSSQL doesn't recognize the infinity keyword, set date
manually
+ # TO-DO: refactor for better DB portability and remove magic
date
+ $dbw = wfGetDB(DB_MASTER);
+ if($dbw instanceof DatabaseMssqlnative)
+ {
+ return '3000-01-31 00:00:00.000';
+ }
I think the easiest way to handle this is how DatabaseOracle does it:
if ( preg_match( '/^timestamp.*/i', $col_type ) == 1
strtolower( $val ) == 'infinity' ) {
$val = '31-12-2030 12:00:00.00';
}
That just has that in DatabaseOracle::insertOneRow(). You might need it in a
couple other methods, but this is easier to do than changing all callers, and
should be reliable.
I notice you aren't consistently following
http://www.mediawiki.org/wiki/Manual:Coding_conventions. In particular,
indentation should be one tab (no spaces), and all parentheses should have a
space inside (e.g., is_object( $v ) not is_object($v)). You can run
stylize.php
http://svn.wikimedia.org/viewvc/mediawiki/trunk/tools/code-utils/stylize.php?view=markup
on your file to fix a lot of this stuff, or just leave it and someone else can
do it before committing.
+class DatabaseMssqlnative extends Database {
You should extend DatabaseBase. Database is a legacy-compat class that's the
same as DatabaseMysql.
+ global $wgOut;
+ # Can't get a reference if it hasn't been set yet
+ if ( !isset( $wgOut ) ) {
+ $wgOut = NULL;
+ }
Surely you mean to set $this-mOut here? But you never seem to use
$this-mOut, so maybe you should just not set it at all. I'm not sure why
you'd want it, anyway.
+// lotsa components seem to think that all databases support limits
via LIMIT N after the WHERE clause
+//
[Bug 22093] Native Microsoft SQL Server Support
https://bugzilla.wikimedia.org/show_bug.cgi?id=22093 --- Comment #6 from Chris Pucci a-cpu...@microsoft.com 2010-01-14 00:03:50 UTC --- Aryeh, Thanks for the comments and thorough review. I will work on your suggestions and update when complete. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 21497] Malayalam characters not visible
https://bugzilla.wikimedia.org/show_bug.cgi?id=21497 Bawolff bawolff...@gmail.com changed: What|Removed |Added CC||bawolff...@gmail.com --- Comment #2 from Bawolff bawolff...@gmail.com 2010-01-14 00:17:06 UTC --- This is definitely a font issue. I just tried using the timeline extension with a different font (FreeSerif. wikimedia uses FreeSans for this extension), and the Malayalam characters rendered fine (well what i assume to be fine. I can't read Malayalam, so it could be giberish for all i know, but it looked what i imagine Malayalam would look like). Since we don't have a font that covers everything, and even if we did, I could imagine cases where people would want to specify a different font then the default for their timeline, perhaps the solution would be to have a font parameter for the timeline tag timeline font=someFonttimeline code.../timeline Currently the font to use is passed as a hard coded command line argument to ploticus in EasyTimeline.pl , So i'd imagine it wouldn't be too difficult to allow alternate fonts to be selected by the user. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 3169] Enable DynamicPageList for Wikibooks
https://bugzilla.wikimedia.org/show_bug.cgi?id=3169 Chad H. innocentkil...@gmail.com changed: What|Removed |Added CC||innocentkil...@gmail.com Status|REOPENED|RESOLVED Resolution||FIXED --- Comment #6 from Chad H. innocentkil...@gmail.com 2010-01-14 00:44:00 UTC --- Special:Version says it's running on en.wikibooks. Marking this as FIXED (since a long time ago?) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 6798] too long width in edit compare function en.wikipedia.org
https://bugzilla.wikimedia.org/show_bug.cgi?id=6798 Chad H. innocentkil...@gmail.com changed: What|Removed |Added CC||innocentkil...@gmail.com Status|NEW |RESOLVED Resolution||DUPLICATE --- Comment #4 from Chad H. innocentkil...@gmail.com 2010-01-14 00:55:48 UTC --- *** This bug has been marked as a duplicate of bug 1229 *** -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 1229] Balance diff display more evenly
https://bugzilla.wikimedia.org/show_bug.cgi?id=1229 Chad H. innocentkil...@gmail.com changed: What|Removed |Added CC||ww...@yahoo.com --- Comment #25 from Chad H. innocentkil...@gmail.com 2010-01-14 00:55:48 UTC --- *** Bug 6798 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22095] New: File for Wikimedia Brasil
https://bugzilla.wikimedia.org/show_bug.cgi?id=22095 Summary: File for Wikimedia Brasil Product: Wikimedia Version: unspecified Platform: All URL: http://br.wikimedia.org OS/Version: All Status: NEW Severity: major Priority: Normal Component: Site requests AssignedTo: wikibugs-l@lists.wikimedia.org ReportedBy: wikimedia.lest...@gmail.com Volunteers of the Wikimedia Brazil have an entry in the Google API service, and to confirm and enable this application, we need to set up a simple html file with the code below: googlee764e70c06f2cbad That this file need be present in the url http://br.wikimedia.org/googlehostedservice.html for the google bot indexing and confirm our request, the file should be online only for a day and then can be removed. Thanks [[m:user:Sir Lestaty de Lioncourt]] -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 6922] Section editing by right-clicking doesn't work in Opera
https://bugzilla.wikimedia.org/show_bug.cgi?id=6922 Chad H. innocentkil...@gmail.com changed: What|Removed |Added CC||innocentkil...@gmail.com Component|General/Unknown |Page editing Priority|Low |Normal Product|Wikimedia |MediaWiki --- Comment #2 from Chad H. innocentkil...@gmail.com 2010-01-14 01:00:02 UTC --- Tweaking product, not WMF issue. Also, I kind of agree with Brion about removing the feature. Do we have any stats on how widely this is actually used? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 10034] Multiple script enabling
https://bugzilla.wikimedia.org/show_bug.cgi?id=10034 Chad H. innocentkil...@gmail.com changed: What|Removed |Added Keywords||i18n -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 15876] Special:ChangePass: move password change form from Preferences, and add reset/usurp features
https://bugzilla.wikimedia.org/show_bug.cgi?id=15876 Chad H. innocentkil...@gmail.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED | --- Comment #5 from Chad H. innocentkil...@gmail.com 2010-01-14 01:15:02 UTC --- Which was reverted in r48780. Don't know why we never reopened the bug -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22041] All animated GIFs unexpectedly thumbnailed as still images
https://bugzilla.wikimedia.org/show_bug.cgi?id=22041 --- Comment #7 from Derk-Jan Hartman hart...@videolan.org 2010-01-14 01:24:59 UTC --- all GIF scaling has been disabled again a few hours ago. Purge pages if needed to force redrawing. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 15477] Install the DynamicPageList2 extension on nl.wikibooks
https://bugzilla.wikimedia.org/show_bug.cgi?id=15477 Chad H. innocentkil...@gmail.com changed: What|Removed |Added CC||innocentkil...@gmail.com --- Comment #1 from Chad H. innocentkil...@gmail.com 2010-01-14 01:26:35 UTC --- I know the sysadmins have been very much against installing DPL2 on WMF sites, and are leery against installing the original DPL much further than it already is. WONTFIX? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 15624] Wikimedia contact form does not like + in the email address
https://bugzilla.wikimedia.org/show_bug.cgi?id=15624 Chad H. innocentkil...@gmail.com changed: What|Removed |Added CC||innocentkil...@gmail.com Status|REOPENED|RESOLVED Resolution||FIXED --- Comment #13 from Chad H. innocentkil...@gmail.com 2010-01-14 01:31:54 UTC --- Reclosing as FIXED, as the original request has been taken care of. Enhancement requests to the ContactPage extension should be filed as their own bugs (although I'm leery about nabbing IPs and putting them in the e-mail). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22096] New: Remove support for MSIE 6
https://bugzilla.wikimedia.org/show_bug.cgi?id=22096 Summary: Remove support for MSIE 6 Product: MediaWiki Version: unspecified Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: Normal Component: General/Unknown AssignedTo: wikibugs-l@lists.wikimedia.org ReportedBy: chinch...@gmail.com As summary said. According to http://stats.wikimedia.org/wikimedia/squids/SquidReportClients.htm MSIE versions below 6 have an usage of aprox. 0.13%, which I think is not worthy to support with aditional CSS/JS hacks. Maybe not right now but something to do in future! -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22096] Remove support for MSIE 6
https://bugzilla.wikimedia.org/show_bug.cgi?id=22096 p858snake p858sn...@yahoo.com.au changed: What|Removed |Added CC||p858sn...@yahoo.com.au Component|General/Unknown |Page rendering -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22090] 404 on mobile sites
https://bugzilla.wikimedia.org/show_bug.cgi?id=22090 Reedy s...@reedyboy.net changed: What|Removed |Added Component|iphone |server Summary|404 when accessing with a |404 on mobile sites |iPod touch | --- Comment #2 from Reedy s...@reedyboy.net 2010-01-13 08:00:46 UTC --- Confirmed on android. Confirmed with tech server is down -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22010] SQL error while deleting on SQLite
https://bugzilla.wikimedia.org/show_bug.cgi?id=22010 --- Comment #3 from Max Semenik maxsem.w...@gmail.com 2010-01-13 09:15:38 UTC --- Yes, I should have given more details. This bug was just a quick note to myself, while doing something else. Error 19: column ar_len is not unique. Doesn't happen at all times, does not happen frequently. I was able to reproduce it consistently on one page, but it vanished after I edited it. The bug is pretty critical when deleting files, because SQL error at that time does not lead to rollback of non-database changes, such as move of file to archive storage. Page deletion seems to fail gracefully. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22091] New: Special:Newpages transclusion option summarytoggle
https://bugzilla.wikimedia.org/show_bug.cgi?id=22091
Summary: Special:Newpages transclusion option summarytoggle
Product: MediaWiki
Version: unspecified
Platform: All
OS/Version: All
Status: NEW
Severity: enhancement
Priority: Normal
Component: Special pages
AssignedTo: wikibugs-l@lists.wikimedia.org
ReportedBy: lond...@gmail.com
Please include an option to show or not show the edit summary, when this page
is transcluded.
Example: {{Special:NewPages/summary=none}} or {{Special:NewPages/nosummary}}
The reason for this is that the summary makes the list quite messy. The
overview of the newpages would be made clear with this option.
Thanks for considering
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22090] 404 on mobile sites
https://bugzilla.wikimedia.org/show_bug.cgi?id=22090 Hampton Catlin hcat...@wikimedia.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #3 from Hampton Catlin hcat...@wikimedia.org 2010-01-13 10:40:08 UTC --- I was unaware of this downtime as I was in bed. :P It has been corrected and we are investigating why no other WMF staff in PST corrected the problem or noticed it. This is seriously bad. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22061] API: add prop=headitems to action=parse
https://bugzilla.wikimedia.org/show_bug.cgi?id=22061 Reedy s...@reedyboy.net changed: What|Removed |Added Attachment #6942 is|0 |1 obsolete|| --- Comment #6 from Reedy s...@reedyboy.net 2010-01-13 12:14:12 UTC --- Created an attachment (id=6952) -- (https://bugzilla.wikimedia.org/attachment.cgi?id=6952) Fixup post conflict from whitespace changes -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22061] API: add prop=headitems to action=parse
https://bugzilla.wikimedia.org/show_bug.cgi?id=22061 --- Comment #7 from Reedy s...@reedyboy.net 2010-01-13 12:34:47 UTC --- I'm gonna end up feeling thick here... But with that patch, what sort of things is it supposed to be outputting? As i've just got my test wiki, with literally nothing on it. Did install Geshi.. I was also about to make a really thick comment, but then i realised what i was that issue was. ;) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22089] Import sources for cr.wiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=22089 Chad H. innocentkil...@gmail.com changed: What|Removed |Added Component|Export/Import |Site requests Keywords||shell Product|MediaWiki |Wikimedia -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 16281] Show copyright system message on special pages
https://bugzilla.wikimedia.org/show_bug.cgi?id=16281 Reedy s...@reedyboy.net changed: What|Removed |Added CC||s...@reedyboy.net Status|NEW |RESOLVED Resolution||FIXED --- Comment #2 from Reedy s...@reedyboy.net 2010-01-13 13:19:11 UTC --- fixed in rev r61005 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 21225] ProofreadPage: special buttons are missing when using enhanced editing toolbar
https://bugzilla.wikimedia.org/show_bug.cgi?id=21225 ThomasV thoma...@gmx.de changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #5 from ThomasV thoma...@gmx.de 2010-01-13 13:41:52 UTC --- this is fixed in svn -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 13260] post expand size counted multiple times for nested transclusions
https://bugzilla.wikimedia.org/show_bug.cgi?id=13260 geometry...@gmail.com changed: What|Removed |Added CC||geometry...@gmail.com --- Comment #6 from geometry...@gmail.com 2010-01-13 14:23:24 UTC --- This continues to be a severe inconvenience. Templates have to be written with opaque code in order to minimize nested transclusions, and some dedicated maintainers of dynamic pages (e.g. content review) have to be constantly vigilant about post-expand sizes to avoid breaking pages which would be nowhere near the limit were it not for this bug. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 19846] {{int:Conversionname}} cannot be always rendered correctly in Sitenotice
https://bugzilla.wikimedia.org/show_bug.cgi?id=19846 Andy Glew webmas...@comp-arch.net changed: What|Removed |Added CC||webmas...@comp-arch.net --- Comment #4 from Andy Glew webmas...@comp-arch.net 2010-01-13 15:17:41 UTC --- Piling on: I want to use variables such as PAGENAMEE inside the Sitenotice, so that there may be different links inside the sitenotice for different pages. However, the caching of sitenotice gets in the way. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 20973] Additional transwiki import sources on Incubator
https://bugzilla.wikimedia.org/show_bug.cgi?id=20973 Rob Halsell rhals...@wikimedia.org changed: What|Removed |Added Status|REOPENED|ASSIGNED --- Comment #4 from Rob Halsell rhals...@wikimedia.org 2010-01-13 16:11:13 UTC --- I can see what you mean, attempting to import from a source like w:fr results in an import failed, even though it is listed in the drop down and in the configuration file. I am not sure why this is, so I am going to email some of the other techs about it and get back to you. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 20508] Please enable Extention:NewUserMessage on en.Wikinews
https://bugzilla.wikimedia.org/show_bug.cgi?id=20508 Rob Halsell rhals...@wikimedia.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #2 from Rob Halsell rhals...@wikimedia.org 2010-01-13 16:22:44 UTC --- The above extension has been added to enwikinews with the specified options. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 21077] Enable the Collection extension on cswv
https://bugzilla.wikimedia.org/show_bug.cgi?id=21077 Rob Halsell rhals...@wikimedia.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #5 from Rob Halsell rhals...@wikimedia.org 2010-01-13 17:06:27 UTC --- The collection extension has been enabled on cswv as requested. The later question in regards to when the pdf rendering cluster will be online: We currently have in place two servers, and are working with PediaPress to get them online and load balanced between them within the software they have created. There is currently no immediate ETA, but it is a high priority. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 21174] Setting Special:Book for wp:ca
https://bugzilla.wikimedia.org/show_bug.cgi?id=21174 Rob Halsell rhals...@wikimedia.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #1 from Rob Halsell rhals...@wikimedia.org 2010-01-13 17:06:34 UTC --- Done! -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22041] All animated GIFs unexpectedly thumbnailed as still images
https://bugzilla.wikimedia.org/show_bug.cgi?id=22041 Derk-Jan Hartman hart...@videolan.org changed: What|Removed |Added CC||hart...@videolan.org Severity|normal |major --- Comment #5 from Derk-Jan Hartman hart...@videolan.org 2010-01-13 18:16:11 UTC --- Since werdna doesn't have the time atm, and roan apparently is on a plane, it is probably better to revert the animated GIF changes until someone who understands the code can fix it. There have been 5 threads about this on VP/T already. Better no thumbs I think. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22058] Blocked users can edit monobook.css etc.
https://bugzilla.wikimedia.org/show_bug.cgi?id=22058 --- Comment #6 from Platonides platoni...@gmail.com 2010-01-13 18:32:23 UTC --- Precisely, we shouldn't open those additional pages. Protecting the talk page is one action. Protecting any .css/.js subpage he may want to create is not. There would also be issues if his .js were included by third users. But using javascript from an untrusted user is always unsafe. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22058] Blocked users can edit monobook.css etc.
https://bugzilla.wikimedia.org/show_bug.cgi?id=22058 --- Comment #7 from Happy-melon happy-me...@live.com 2010-01-13 18:37:02 UTC --- Indeed; I kind of took it for granted that Platonides was saying that it should be WONTFIXed *because they could become* unwanted platforms. Are you saying that we *should* open up these pages, Mike, or are we actually all singing from the same songsheet here? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22058] Blocked users can edit monobook.css etc.
https://bugzilla.wikimedia.org/show_bug.cgi?id=22058 Chad H. innocentkil...@gmail.com changed: What|Removed |Added CC||innocentkil...@gmail.com Status|NEW |RESOLVED Resolution||WONTFIX --- Comment #8 from Chad H. innocentkil...@gmail.com 2010-01-13 18:39:01 UTC --- If an editor is blocked, they cannot edit. Period. We make an exception to user talk pages so they can retain a method to appeal a block. I don't really agree with the could be another soapbox argument, but I certainly agree with the suggestion to WONTFIX this. Marking as such. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22058] Blocked users can edit monobook.css etc.
https://bugzilla.wikimedia.org/show_bug.cgi?id=22058 DaSch dasch...@gmx.net changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WONTFIX | --- Comment #9 from DaSch dasch...@gmx.net 2010-01-13 18:44:51 UTC --- Well that's a little bit to fast for me. The thing is, that the .css and .js are some kind of settings. Is there any argument why a user should not be able to change his settings while he is blocked? When the personal .css and .js are blocked so the settings should be blocked too. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22058] Blocked users can edit monobook.css etc.
https://bugzilla.wikimedia.org/show_bug.cgi?id=22058
Aryeh Gregor simetrical+wikib...@gmail.com changed:
What|Removed |Added
CC||simetrical+wikib...@gmail.co
||m
--- Comment #11 from Aryeh Gregor simetrical+wikib...@gmail.com 2010-01-13
18:51:01 UTC ---
I agree with the logic of comment #9, but these are public settings that can
contain arbitrary text, so they're somewhat different. Also, if we whitelist
User:Foo/*.{css,js}, then they could just create unlimited pages and admins
would be unable to stop them. Currently admins can shut up abusive blocked
users by protecting only their user talk page, and this would make that more
difficult or impossible.
Overall, the idea is nice, but I don't think this feature is worth the
complications it would cause. If a blocked user really wants custom CSS/JS,
they can use their browser's support of that, if applicable. Or maybe create a
new account to view with and not use it to edit, if possible. Or ask an admin,
as Happy-melon says. I don't think we need to go to great lengths to make this
possible. So I agree with WONTFIX.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22058] Blocked users can edit monobook.css etc.
https://bugzilla.wikimedia.org/show_bug.cgi?id=22058 Andrew Garrett agarr...@wikimedia.org changed: What|Removed |Added CC||agarr...@wikimedia.org --- Comment #12 from Andrew Garrett agarr...@wikimedia.org 2010-01-13 18:52:12 UTC --- I don't have a problem with users changing their settings while blocked, but I don't think that it's a good idea to be making exceptions to the no editing pages when you're blocked rule because a particular edit could be considered editing settings. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22058] Blocked users can edit monobook.css etc.
https://bugzilla.wikimedia.org/show_bug.cgi?id=22058 Happy-melon happy-me...@live.com changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||WONTFIX --- Comment #10 from Happy-melon happy-me...@live.com 2010-01-13 18:49:09 UTC --- Yes: the ability to do anything on a wiki is a privilege, not a right. If a user doesn't want to lose the ability to edit their settings, that user should not get themselves blocked. If there is something they desperately need or if the page is broken, they can ask an admin to change the page for them. Or use browser styles. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22058] Blocked users can edit monobook.css etc.
https://bugzilla.wikimedia.org/show_bug.cgi?id=22058 DaSch dasch...@gmx.net changed: What|Removed |Added Resolution|WONTFIX |LATER --- Comment #13 from DaSch dasch...@gmx.net 2010-01-13 18:59:18 UTC --- I think that is something that should be kept in mind. For example the creation of a new account is not always a solution. For example with a global account you have to login to the wiki your are blocked with another account just to have the abillity to have you're styles. And the go to antoher wiki and have to login with your other account. That's not really a solution. By the way some users are getting blocked by purpouse because they to not want to edit, but maybe the need there styles for reading and it would be very complicated to always ask an admin to change their styles. It should be considerd that editing and reading are two different things and personal styles are also mostly for reading and not for editing. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22058] Blocked users can edit monobook.css etc.
https://bugzilla.wikimedia.org/show_bug.cgi?id=22058 Chad H. innocentkil...@gmail.com changed: What|Removed |Added Resolution|LATER |WONTFIX --- Comment #14 from Chad H. innocentkil...@gmail.com 2010-01-13 19:10:59 UTC --- (In reply to comment #13) By the way some users are getting blocked by purpouse because they to not want to edit but maybe the need there styles for reading and it would be very complicated to always ask an admin to change their styles. That's just stupid. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 21063] Upload api exception when using upload by url
https://bugzilla.wikimedia.org/show_bug.cgi?id=21063 Chad H. innocentkil...@gmail.com changed: What|Removed |Added CC||innocentkil...@gmail.com Status|RESOLVED|REOPENED Resolution|REMIND | --- Comment #4 from Chad H. innocentkil...@gmail.com 2010-01-13 19:15:44 UTC --- Is this fixed for sure? If yes, should be resolved as FIXED. If not, should remain open. Leaving as RESOLVED-REMIND hides it from open bug searches. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22092] Disable access keys gadget doesn't work with Vector skin
https://bugzilla.wikimedia.org/show_bug.cgi?id=22092 Bawolff bawolff...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Comment #1 from Bawolff bawolff...@gmail.com 2010-01-13 19:21:07 UTC --- Thats a problem with the gadget in question, not vector. You should probably report it to [[Wikipedia talk:WikiProject User scripts/Scripts/removeAccessKeys]] Closing as invalid. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22088] Skin Templated using smarty...
https://bugzilla.wikimedia.org/show_bug.cgi?id=22088 Alexandre Emsenhuber [IAlex] alex.emsenhu...@bluewin.ch changed: What|Removed |Added Status|NEW |RESOLVED Resolution||DUPLICATE --- Comment #2 from Alexandre Emsenhuber [IAlex] alex.emsenhu...@bluewin.ch 2010-01-13 19:41:04 UTC --- *** This bug has been marked as a duplicate of bug 5844 *** -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 5844] Smarty Template @ skins
https://bugzilla.wikimedia.org/show_bug.cgi?id=5844 Alexandre Emsenhuber [IAlex] alex.emsenhu...@bluewin.ch changed: What|Removed |Added CC||dmar...@tekconxus.com --- Comment #4 from Alexandre Emsenhuber [IAlex] alex.emsenhu...@bluewin.ch 2010-01-13 19:41:04 UTC --- *** Bug 22088 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 5844] Smarty Template @ skins
https://bugzilla.wikimedia.org/show_bug.cgi?id=5844 Chad H. innocentkil...@gmail.com changed: What|Removed |Added CC||innocentkil...@gmail.com Resolution|FIXED |WONTFIX --- Comment #5 from Chad H. innocentkil...@gmail.com 2010-01-13 19:43:47 UTC --- (In reply to comment #1) Some initial work was done with Smarty before PHPTAL was adopted. Since Smarty has the same speed and reliability problems that lead us to abandon PHPTAL (it has to create compiled PHP files from templates, then execute them), I don't think there would be much benefit to trying it again though. I'm reading this as WONTFIX. Not sure why this was marked FIXED. Changing accordingly. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
