[Bug 27544] SVG images that are invalid XML no longer rendered

2011-03-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27544 --- Comment #26 from Derk-Jan Hartman 2011-03-15 07:46:42 UTC --- Yes, I believe both of those are known issues, and filed somewhere under the "depends" of ticket #8901 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=e

[Bug 27544] SVG images that are invalid XML no longer rendered

2011-03-14 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27544 --- Comment #25 from Rainald Koch 2011-03-14 23:46:46 UTC --- Reclosing is ok, I reopened it only to be heard and appreciating the decision of Brian to exclude files which are not namespace-well-formed. Thank you for the hint at bug #27537.

[Bug 27544] SVG images that are invalid XML no longer rendered

2011-03-14 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27544 Derk-Jan Hartman changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|

[Bug 27544] SVG images that are invalid XML no longer rendered

2011-03-14 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27544 Rainald Koch changed: What|Removed |Added Status|RESOLVED|REOPENED CC|

[Bug 27544] SVG images that are invalid XML no longer rendered

2011-02-21 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27544 Aryeh Gregor changed: What|Removed |Added CC||Simetrical+wikibugs@gmail.c

[Bug 27544] SVG images that are invalid XML no longer rendered

2011-02-21 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27544 --- Comment #21 from Brion Vibber 2011-02-21 20:25:05 UTC --- Just a terminology clarification: what we're checking for well-formedness here including the namespaces is called "namespace-well-formed"ness, and is again not related to what XML te

[Bug 27544] SVG images that are invalid XML no longer rendered

2011-02-21 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27544 Mark A. Hershberger changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

[Bug 27544] SVG images that are invalid XML no longer rendered

2011-02-21 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27544 --- Comment #19 from Bryan Tong Minh 2011-02-21 18:24:46 UTC --- (In reply to comment #18) > Failure to live through our XML/SVG-specific checks MUST NOT be > overridden by some other generic check. The best way to fix this is to split the va

[Bug 27544] SVG images that are invalid XML no longer rendered

2011-02-21 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27544 --- Comment #18 from Brion Vibber 2011-02-21 18:18:05 UTC --- I got a little lost reading the backscroll here, but let me just summarize the expected behavior: * invalid[1] SVG file MUST be rejected on upload * invalid[1] SVG file that's alrea

[Bug 27544] SVG images that are invalid XML no longer rendered

2011-02-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27544 --- Comment #17 from Mark A. Hershberger 2011-02-19 22:48:38 UTC --- See r43627 for where Brion forces the use of xml_parser_create_ns() instead of allowing xml_parser_create(). Thinking this is too picky per the bug. -- Configure bugmail: h

[Bug 27544] SVG images that are invalid XML no longer rendered

2011-02-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27544 --- Comment #16 from Bryan Tong Minh 2011-02-19 22:28:31 UTC --- To clarify, for people who have not followed the IRC discussion: * The original assumption that the non-rendering of certain SVGs was caused by the new SvgMetadataExtrator was fa

[Bug 27544] SVG images that are invalid XML no longer rendered

2011-02-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27544 Mark A. Hershberger changed: What|Removed |Added Blocks||26676 -- Configure bugmail: htt

[Bug 27544] SVG images that are invalid XML no longer rendered

2011-02-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27544 --- Comment #15 from Mark A. Hershberger 2011-02-19 17:41:42 UTC --- (In reply to comment #9) > I'm not too familiar with XML, but does that mean that the DTD is fetched from > w3.org every time an SVG file is viewed? No. The URIs in xmlns a

[Bug 27544] SVG images that are invalid XML no longer rendered

2011-02-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27544 --- Comment #14 from Derk-Jan Hartman 2011-02-19 17:37:45 UTC --- two options, rewrite to XMLReader, or set XmlTypeCheck to ignore namespaces all together. Implications of the latter not fully understood yet. Best consult Brion or Tim on this,

[Bug 27544] SVG images that are invalid XML no longer rendered

2011-02-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27544 --- Comment #13 from Bryan Tong Minh 2011-02-19 17:11:13 UTC --- detectMimeType uses one of the mime detection PHP extensions. I don't see any changes between 1.16 and 1.17 that would explain the difference. The bug is with XmlTypeCheck thoug

[Bug 27544] SVG images that are invalid XML no longer rendered

2011-02-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27544 --- Comment #12 from Derk-Jan Hartman 2011-02-19 16:22:58 UTC --- summary, on wmf servers, guessMimeType returns 'application/xml' instead of 'image/svg+xml'. guess mimetype calls doGuessMimeType(), which will call XmlTypeCheck() $xml = new X

[Bug 27544] SVG images that are invalid XML no longer rendered

2011-02-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27544 --- Comment #11 from Derk-Jan Hartman 2011-02-19 14:22:10 UTC --- like i said, false should be the default value anyways. At least from what I understand. but we could run a test on wmf servers i guess to make sure. /me has no access. -- Co

[Bug 27544] SVG images that are invalid XML no longer rendered

2011-02-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27544 --- Comment #10 from Bryan Tong Minh 2011-02-19 14:17:37 UTC --- $this->reader->setParserProperty( XMLReader::VALIDATE, false ); would presumably fix it. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- Yo

[Bug 27544] SVG images that are invalid XML no longer rendered

2011-02-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27544 --- Comment #9 from Bryan Tong Minh 2011-02-19 14:13:14 UTC --- (In reply to comment #7) > Seems to me that the WMF version of XMLReader is validating the file, while as > far as I know, that is not the default mode of XMLReader. I'm not too

[Bug 27544] SVG images that are invalid XML no longer rendered

2011-02-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27544 --- Comment #8 from Derk-Jan Hartman 2011-02-19 09:20:05 UTC --- Created attachment 8170 --> https://bugzilla.wikimedia.org/attachment.cgi?id=8170 example file -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --

[Bug 27544] SVG images that are invalid XML no longer rendered

2011-02-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27544 --- Comment #7 from Derk-Jan Hartman 2011-02-19 09:19:47 UTC --- Seems to me that the WMF version of XMLReader is validating the file, while as far as I know, that is not the default mode of XMLReader. -- Configure bugmail: https://bugzilla.

[Bug 27544] SVG images that are invalid XML no longer rendered

2011-02-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27544 --- Comment #6 from Derk-Jan Hartman 2011-02-19 09:04:17 UTC --- i don't have the problem at home btw, so I guess the XMLReader version installed on wikimedia servers behaves different from the one I have installed. -- Configure bugmail: htt

[Bug 27544] SVG images that are invalid XML no longer rendered

2011-02-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27544 --- Comment #5 from Derk-Jan Hartman 2011-02-19 08:41:56 UTC --- we didn't use the xmlreader pull parser before. I swithed the whole thing from XmlTypeCheck to SVGReader in r75968 -- Configure bugmail: https://bugzilla.wikimedia.org/userpref

[Bug 27544] SVG images that are invalid XML no longer rendered

2011-02-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27544 Rob Lanphier changed: What|Removed |Added CC||ro...@wikimedia.org --- Comment #4 from

[Bug 27544] SVG images that are invalid XML no longer rendered

2011-02-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27544 --- Comment #3 from Mark A. Hershberger 2011-02-18 20:39:42 UTC --- This should be fixed. I understand why that one doesn't display, but errors like that (undeclared, but well-known namespaces), shouldn't cause a problem with display. Would

[Bug 27544] SVG images that are invalid XML no longer rendered

2011-02-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27544 --- Comment #2 from Bryan Tong Minh 2011-02-18 20:28:43 UTC --- http://commons.wikimedia.org/wiki/File:Tinizong-Rona_wappen.svg -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail

[Bug 27544] SVG images that are invalid XML no longer rendered

2011-02-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27544 Mark A. Hershberger changed: What|Removed |Added CC||m...@everybody.org --- Comment #

[Bug 27544] SVG images that are invalid XML no longer rendered

2011-02-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27544 Raimond Spekking changed: What|Removed |Added CC||raimond.spekk...@gmail.com

[Bug 27544] SVG images that are invalid XML no longer rendered

2011-02-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27544 Reedy changed: What|Removed |Added Summary|SVG images that are invalid |SVG images that are invalid