[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

Mrjohncummings added a comment. thumbs up TASK DETAIL https://phabricator.wikimedia.org/T213704 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mrjohncummings Cc: Rosalie_WMDE, Seantime, Richard_Nevell_WMUK, WMDE-leszek, Jakob_WMDE,

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

Mrjohncummings added a comment. Can we wait to let me make some more tours to test? I've tried some things and it worked fine but I feel like I really need to test it TASK DETAIL https://phabricator.wikimedia.org/T213704 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

Addshore added a comment. A couple months down the line, any movement here? Is this done? TASK DETAIL https://phabricator.wikimedia.org/T213704 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Rosalie_WMDE, Seantime,

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

Mrjohncummings added a comment. @Rosalie_WMDE thanks very much again, @Ladsgroup could you press the magic buttons to make it work on Wikidata pretty please? TASK DETAIL https://phabricator.wikimedia.org/T213704 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

Rosalie_WMDE added a comment. In T213704#5415502 , @WMDE-leszek wrote: > All credit to @Rosalie_WMDE, she fixed it all! I was just a messenger. Thanks! I foward all the credit to the wikidata team. ;) > Or were there more files

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

WMDE-leszek added a comment. All credit to @Rosalie_WMDE, she fixed it all! I was just a messenger. @Mrjohncummings: to get this to Wikidata, one of interface administrators (https://www.wikidata.org/wiki/Special:ListUsers?username==interface-admin) would need to update Wikidata's

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

Mrjohncummings added a comment. @WMDE-leszek @Rosalie_WMDE @NavinoEvans it works for me as well :) Thanks so much for making it happen :) What needs to happen next to make it work on Wikidata? TASK DETAIL https://phabricator.wikimedia.org/T213704 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

NavinoEvans added a comment. @WMDE-leszek @Rosalie_WMDE Thank you so much for this, for me the issues are completely resolved in the test version :-) @Mrjohncummings is that the same for you? Thanks again @WMDE-leszek for picking this up, you've really saved the day. we have quite a

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

Rosalie_WMDE added a comment. @Mrjohncummings @NavinoEvans The tool behaviour on test.wikidata.org https://test.wikidata.org/w/index.php?title=Q1027=wbqualifiers2=ok. Please not that for testing purposes the changes were added to wbqualifiers**2** different from wbqualifiers. TASK

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

WMDE-leszek added a comment. Following up quickly the comment above: Per https://test.wikidata.org/wiki/Special:ListUsers?username==interface-admin pinging @Pasleim @Ladsgroup @Rosalie_WMDE: maybe you folks could help with bring changes linked in

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

Mrjohncummings added a comment. @WMDE-leszek this would be great feature to have working for Wikimania, we are having several GLAM workshops which include Wikidata and lack of good quality instructions is a real issue TASK DETAIL https://phabricator.wikimedia.org/T213704 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

Mrjohncummings added a comment. @WMDE-leszek amazing, thanks, how did you get on? Let me know if/how I can help TASK DETAIL https://phabricator.wikimedia.org/T213704 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mrjohncummings Cc: WMDE-leszek,

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

WMDE-leszek added a comment. @Mrjohncummings apologies for the suboptimal response time. At WMDE we're in the middle of getting two bigger features through the door, which steals the most of my focus currently. I will personally have a look at those two bugs at Wikimedia Hackathon this

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

Mrjohncummings added a comment. @WMDE-leszek if it is easier to have a call about this to discuss with myself and @NavinoEvans please let us know, we are both in the UK. TASK DETAIL https://phabricator.wikimedia.org/T213704 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

NavinoEvans added a comment. Just to confirm from my previous message after some further testing, there are in fact two separate issues: Bug 1 - User can reach a step where the tour popup needs to attach to an element which is not visible

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

NavinoEvans added a comment. @WMDE-leszek Thanks so much for taking a look at this! Yes, the issue you describe on step 8 in your example is the main problem to solve. To me the root of the issue is that the user is allowed to skip through steps //without// having actually completed the

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

WMDE-leszek added a comment. Hi @Mrjohncummings and others. WMDE Wikidata engineers will try to help the problem with this Guided Tour. To be clear about it: WMDE is not going to be able to drive overhauling GuidedTours gadget, should this become the part of the solution. This seems

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

MartinPoulter added a comment. I don't get the confusion. John has explained why he is asking these questions: an important feature of Wikidata, used in an ongoing project, is not working properly and he's just trying to find out what steps are necessary to get it fixed. You've been asked

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

thiemowmde added a comment. I'm somewhat confused what the relevance of these questions is, why they are asked, and who asks them. Are you a WMF or WMDE employee I'm not aware of? I don't know who "owns" the feature this ticket is about. It's on wikidata.org and falls into the #Wikidata

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

Mrjohncummings added a comment. @thiemowmde, thanks, it seems like there are a few issues, please let me know if I missed something: 1. Technical knowledge needed to write the fix for the issue (one way or another) 2. The permissions to review the code and implement it from someone at

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

thiemowmde added a comment. > you would be able to fix this issue if you were given it as a task by your line manager? It's open source software. People can change it and fix everything. The only question is how many resources people are willing to spend. In a worst-case scenario it

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

Mrjohncummings added a comment. In T213704#5135055 , @thiemowmde wrote: > I believe we run into a very similar issue in the tour we have in the #two-column-edit-conflict-merge

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

Tarrow added a comment. Just to update this ticket: As can be seen in https://test.wikidata.org/w/index.php?title=MediaWiki:Guidedtour-lib.js=history both the hack by @Ladsgroup and @Sebastian_Berlin-WMSE have been put on test.wikidata.org and "tested". Even with the latest code by

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

Mrjohncummings added a comment. Thanks @Ladsgroup , @Jakob_WMDE and @thiemowmde if there's any tasks I can swap you for or any other favours that would free up a bit of time to look at this please let me know (I'm a muggle with no programming skills) TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

Mrjohncummings added a comment. @Ladsgroup thanks very much, do you know who would be the right person/people to ask about frontend who could assess it? Thanks again TASK DETAIL https://phabricator.wikimedia.org/T213704 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

Ladsgroup added a comment. Hey, I really like to implement @Sebastian_Berlin-WMSE's fix in Wikidata but I can't test it and my knowledge of frontend is not good enough to understand it and its implications (for example if all of supported browsers support the implementation). If another

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

Mrjohncummings added a comment. @Ladsgroup @Pasleim @Addshore please can you help with trying to make this work? We are really dependent on this working so we can have tours to onboard new people, both in general and for our project FindingGLAMs (trying to create a worldwide database of

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

Sebastian_Berlin-WMSE added a comment. In T213704#5068924 , @Ladsgroup wrote: > In T213704#5068921 , @Sebastian_Berlin-WMSE wrote: > > > It's hard to work on this without being able

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

Sebastian_Berlin-WMSE added a comment. In T213704#5051741 , @Pasleim wrote: > Otherwise I think we can proceed with the hack by @Ladsgroup. The problem with this solution is that it's quite fragile: if the delay for the other

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

Ladsgroup added a comment. In T213704#5068921 , @Sebastian_Berlin-WMSE wrote: > It's hard to work on this without being able to test the code myself. Is it possible to setup my common.js to run the tour code in a way that I can

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

Sebastian_Berlin-WMSE added a comment. It's hard to work on this without being able to test the code myself. Is it possible to setup my common.js to run the tour code in a way that I can experiment there? I had a look at that, but couldn't figure out how to do it properly. Alternatively if

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

Pasleim added a comment. @Sebastian_Berlin-WMSE I implemented your patch on test.wikidata but it does not seem to work. Do you know how to improve it? Otherwise I think we can proceed with the hack by @Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T213704 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

Addshore added a comment. I'v got a bit lost in this ticket now. What is the extra bit of patching that we have? Where is it? :) It looks like perhaps this is already being solved in https://www.wikidata.org/wiki/Wikidata:Project_chat#Code_review_request_to_fix_Wikidata_Tours ? TASK

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

Mrjohncummings added a comment. @Addshore is there a process for getting a code review for something working on beta Wikidata? TASK DETAIL https://phabricator.wikimedia.org/T213704 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mrjohncummings

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

Mrjohncummings added a comment. @Sebastian_Berlin-WMSE I think I've found someone who could do a code review, but I don't know how to answer his question, see https://www.wikidata.org/wiki/Wikidata:Project_chat#Code_review_request_to_fix_Wikidata_Tours TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

Mrjohncummings added a comment. In T213704#5023783 , @Sebastian_Berlin-WMSE wrote: > My proposed code hasn't been added. Someone with the necessary user right needs to do this; I don't have those. Thanks for writing it :) Who

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

Sebastian_Berlin-WMSE added a comment. My proposed code hasn't been added. Someone with the necessary user right needs to do this; I don't have those. TASK DETAIL https://phabricator.wikimedia.org/T213704 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

Mrjohncummings added a comment. I'm still seeing boxes in the wrong place :( TASK DETAIL https://phabricator.wikimedia.org/T213704 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mrjohncummings Cc: Ladsgroup, Addshore, Sebastian_Berlin-WMSE,

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

Mrjohncummings added a comment. @Ladsgroup , did it work? TASK DETAIL https://phabricator.wikimedia.org/T213704 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mrjohncummings Cc: Ladsgroup, Addshore, Sebastian_Berlin-WMSE, Lydia_Pintscher, johl,

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

Mrjohncummings added a comment. @Lydia_Pintscher I don't think this is resolved yet, a fix has been suggested by not implemented (unless it just hasn't been commented on yet) TASK DETAIL https://phabricator.wikimedia.org/T213704 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

Sebastian_Berlin-WMSE added a comment. I did some experiments and I think this might work: if($(step.attachTo).length === 0 { var observer = new MutationObserver(function (mutationList, observer) { for(var mutation of mutationList) { for(var node of mutation.addedNodes) {

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

Sebastian_Berlin-WMSE added a comment. Eww, race conditions. Would it be feasible to do something with MutationObserver to not have to use timers? That is if I understand it correctly, that the element we want to attach to hasn't been added yet when we want to attach it.TASK

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

Ladsgroup added a comment. Yes, my guess was correct and it's a race condition. This hack fixes it: https://test.wikidata.org/w/index.php?title=MediaWiki:Guidedtour-lib.js=470003=460451TASK DETAILhttps://phabricator.wikimedia.org/T213704EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

Ladsgroup added a comment. I looked into this and these are the easiest way to reproduce the problem: Go to https://test.wikidata.org/w/index.php?title=Q1027=wbtest=""> Click on "Edit" as it's attached to it: F28245474: image.png Click on "add qualifier" as it's attached to it: F28245491:

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

Sebastian_Berlin-WMSE added a comment. The fact that I put it in my "This Week" initially means that I will investigate this; I haven't worked with tours before, so I need to figure out what's going on. @Addshore, do you know how tours work and have time to work on this? If so, you're more

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

Mrjohncummings added a comment. In T213704#4947316, @Lydia_Pintscher wrote: We'll have a look. Great, thanks :)TASK DETAILhttps://phabricator.wikimedia.org/T213704EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MrjohncummingsCc: Lydia_Pintscher, johl,

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

Mrjohncummings added a comment. In T213704#4916198, @NavinoEvans wrote: In T213704#4904187, @Mrjohncummings wrote: I guess my question is what function does the forward arrow serve, is it useful and would we lose a function if it was removed? Does anyone know who designed it? We still always

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

NavinoEvans added a comment. In T213704#4904187, @Mrjohncummings wrote: I guess my question is what function does the forward arrow serve, is it useful and would we lose a function if it was removed? Does anyone know who designed it? We still always need the forward arrow available for steps

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

Mrjohncummings added a comment. I guess my question is what function does the forward arrow serve, is it useful and would we lose a function if it was removed? Does anyone know who designed it?TASK DETAILhttps://phabricator.wikimedia.org/T213704EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

NavinoEvans added a comment. In T213704#4900587, @Mrjohncummings wrote: @NavinoEvans unfortunately I get the errors without using the arrows, so removing the arrows won't fix the issue. Excitingly the boxes break at different places in different browsers for me Ah ok, so it's not quit ethat

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

Mrjohncummings added a comment. @NavinoEvans unfortunately I get the errors without using the arrows, so removing the arrows won't fix the issue. Excitingly the boxes break at different places in different browsers for meTASK DETAILhttps://phabricator.wikimedia.org/T213704EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

NavinoEvans added a comment. In T213704#4885309, @Ragesoss wrote: It seems to be working for me (in both the real tour and the example), as long as I click 'add qualifier' rather than use the guider arrow to advance to that step. Maybe it's behaving differently in your browser than mine?