[Wikidata-bugs] [Maniphest] [Commented On] T173710: Job queue is increasing non-stop
Daimona added a comment. Today on it.wiki I noticed a massive increase in search results for some queries related to errors that I'm currently trying to fix. This search: https://it.wikipedia.org/w/index.php?search=insource%3A%2F%27%27parlate+prego%27%27%5C%3C%5C%2F%2F=Speciale:Ricerca=""> now has 6 results, but they're all fixed since yesterday. The weird thing is, today at 11AM the search only returned something like 4 results, while the other (already fixed) pages were added at around 4PM. We suppose that this is still due to troubles with job queue, is that right?TASK DETAILhttps://phabricator.wikimedia.org/T173710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DaimonaCc: Daimona, YOUR1, Tbayer, mobrovac, Nikerabbit, Mholloway, Legoktm, ema, Joe, GWicke, Nemo_bis, Andreasmperu, BBlack, Peachey88, Liuxinyu970226, daniel, Stashbot, Agabi10, Daniel_Mietchen, XXN, Pasleim, Bugreporter, Sjoerddebruin, Magnus, Mr.Ibrahem, gerritbot, EBernhardson, Esc3300, jcrespo, WMDE-leszek, Jdforrester-WMF, Krinkle, aaron, fgiunchedi, Aklapper, Ladsgroup, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Hfbn0, Ramalepe, Liugev6, QZanden, EBjune, Vali.matei, Avner, Lewizho99, Zppix, Maathavan, debt, Gehel, FloNight, Izno, Eevans, Hardikj, Wikidata-bugs, aude, jayvdb, faidon, Mbch331, Jay8g, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T201310: Prefill the representation when adding the first Form
Daimona removed a project: Patch-For-Review.Daimona added a comment. Wrong taskTASK DETAILhttps://phabricator.wikimedia.org/T201310EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DaimonaCc: Daimona, gerritbot, Micru, KaMan, Lydia_Pintscher, Lea_Lacroix_WMDE, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T199222: Diff page shows diff lines in wrong order
Daimona closed this task as a duplicate of T197157: New diffs show lines in the wrong order. TASK DETAILhttps://phabricator.wikimedia.org/T199222EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DaimonaCc: Aklapper, JeroenDeDauw, Marc, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Merged] T198973: Wikibase tests are failing CI on unrelated changes
Daimona added a subscriber: Reedy.Daimona merged a task: T198975: Wikibase causing test failures. TASK DETAILhttps://phabricator.wikimedia.org/T198973EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DaimonaCc: Reedy, TerraCodes, Liuxinyu970226, Aklapper, Anomie, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, thcipriani, Wikidata-bugs, aude, Mbch331, Jay8g, hashar, greg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T198975: Wikibase causing test failures
Daimona closed this task as a duplicate of T198973: Wikibase tests are failing CI on unrelated changes.Herald removed a subscriber: Liuxinyu970226. TASK DETAILhttps://phabricator.wikimedia.org/T198975EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DaimonaCc: TerraCodes, Aklapper, Reedy, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Liuxinyu970226___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T189329: jquery.wikibase.edittoolbar and other qunit tests are flaky
Daimona added a comment. This is strictly related to T189411, which offers examples for this and a similar case of failing (thus I didn't merge it here).TASK DETAILhttps://phabricator.wikimedia.org/T189329EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DaimonaCc: Daimona, WMDE-leszek, SBisson, Jdforrester-WMF, Lucas_Werkmeister_WMDE, Huji, Mholloway, Legoktm, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T189329: jquery.wikibase.edittoolbar and other qunit tests are flaky
Daimona added a comment. I'd say not fixed: https://integration.wikimedia.org/ci/job/mediawiki-extensions-qunit-jessie/56813/console just now.TASK DETAILhttps://phabricator.wikimedia.org/T189329EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DaimonaCc: hoo, Mbch331, Jonas, TerraCodes, Liuxinyu970226, Niharika, Gilles, Daimona, WMDE-leszek, SBisson, Jdforrester-WMF, Lucas_Werkmeister_WMDE, Huji, Mholloway, Legoktm, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T73545: Argument 1 passed to AbuseFilter::contentToString() must implement interface Content
Daimona added a comment. Hm, looking at this, it seems like $revision::getContent() is returning null although $revision is not null. However, looking at RevisionRecord and similar classes, I couldn't find a case when this can happen, given that we use RAW as audience (so deleted content shouldn't be a problem). To avoid the error we could just check that $oldcontent is not null, but this wouldn't help much, as we should understand the root cause.TASK DETAILhttps://phabricator.wikimedia.org/T73545EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DaimonaCc: Daimona, Krinkle, Zoglun, Wikidata-bugs, aude, wikibugs-l-list, werdna, Lydia_Pintscher, hoo, dmaza, Litanwei, Wong128hk, Luke081515, Nirmos, Huji, Jdforrester-WMF, Jackmcbarn, Jay8g, Krenair, chasemp___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T73545: Argument 1 passed to AbuseFilter::contentToString() must implement interface Content
Daimona added a project: User-Daimona. TASK DETAILhttps://phabricator.wikimedia.org/T73545EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DaimonaCc: Krinkle, Zoglun, Wikidata-bugs, aude, wikibugs-l-list, werdna, Lydia_Pintscher, hoo, dmaza, Daimona, Litanwei, Wong128hk, Luke081515, Nirmos, Huji, Jdforrester-WMF, Jackmcbarn, Jay8g, Krenair, chasemp___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T205254: Investigate usage of "text" in AbuseFilter rules on wikidata.org
Daimona added a comment. Just a comment: "_text" variables are for page title, and so are "_prefixedtext" variables. So, if you're interested in covering such variables, then you also have to include "_title" and "_prefixedtitle" per T173889.TASK DETAILhttps://phabricator.wikimedia.org/T205254EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DaimonaCc: Daimona, Lea_Lacroix_WMDE, Lydia_Pintscher, gerritbot, Aklapper, Addshore, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, D3r1ck01, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T210929: Timeout exceeded for WikibaseReferenceOnProtectedPage Selenium test
Daimona created this task.Daimona added projects: Wikidata, MediaWiki-extensions-WikibaseRepository, Wikimedia-production-error.Restricted Application added a subscriber: Aklapper. TASK DESCRIPTIONThe test called "WikibaseReferenceOnProtectedPage can expand collapsed references on a protected page as unprivileged user" seems to fail randomly, and a recheck solves the problem. See for instance here (PS23) or here (PS24); I've seen this thrice in the last two days. Here is the console output: 17:29:39 [chrome #0-10] 1) WikibaseReferenceOnProtectedPage can expand collapsed references on a protected page as unprivileged user: 17:29:39 [chrome #0-10] Timeout of 6ms exceeded. Try to reduce the run time or increase your timeout for test specs (http://webdriver.io/guide/testrunner/timeouts.html); if returning a Promise, ensure it resolves. (/workspace/src/extensions/Wikibase/repo/tests/selenium/specs/readmode.references.js) 17:29:39 [chrome #0-10] Error: Timeout of 6ms exceeded. Try to reduce the run time or increase your timeout for test specs (http://webdriver.io/guide/testrunner/timeouts.html); if returning a Promise, ensure it resolves. (/workspace/src/extensions/Wikibase/repo/tests/selenium/specs/readmode.references.js) 17:29:39 [chrome #0-10] at Test.Runnable._timeoutError (/workspace/src/node_modules/mocha/lib/runnable.js:440:10) 17:29:39 [chrome #0-10] at Timeout. (/workspace/src/node_modules/mocha/lib/runnable.js:251:24) 17:29:39 [chrome #0-10] at ontimeout (timers.js:386:14) 17:29:39 [chrome #0-10] at tryOnTimeout (timers.js:250:5) 17:29:39 [chrome #0-10] at Timer.listOnTimeout (timers.js:214:5) Looking at the video, everything seems to be happening correctly, but it actually takes 60 seconds to get to the logout phase. Since the test was added in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/474301/, I'm CC'ing people from gerrit.TASK DETAILhttps://phabricator.wikimedia.org/T210929EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DaimonaCc: Aklapper, Lucas_Werkmeister_WMDE, Michael, Daimona, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T210929: Timeout exceeded for WikibaseReferenceOnProtectedPage Selenium test
Daimona edited projects, added Wikimedia-production-error (Shared Build Failure); removed Wikimedia-production-error. TASK DETAILhttps://phabricator.wikimedia.org/T210929EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DaimonaCc: Aklapper, Lucas_Werkmeister_WMDE, Michael, Daimona, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T106136: Wikidata edits are not tagged by AbuseFilter on item creations
Daimona added a comment. The system used for applying tags is not ideal (relies on global state etc.), but I'm unsure what an alternative could be, since tags cannot be applied when filters are executed (per design in core). To keep the process simple, we use an identifier which can be constructed with data available both when running filters (and we have plenty of data at that point), AND when saving the recent change. However, for the latter we only have a RecentChange object passed in by the hook, and not much info we can extract from there aside from user, action and title.TASK DETAILhttps://phabricator.wikimedia.org/T106136EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DaimonaCc: Daimona, Lydia_Pintscher, daniel, StudiesWorld, Sjoerddebruin, Bugreporter, aude, hoo, Addshore, Aklapper, Luke081515, matej_suchanek, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Litanwei, _jensen, D3r1ck01, MGChecker, Wong128hk, Nirmos, Wikidata-bugs, Huji, TTO, Jackmcbarn, Mbch331, chasemp___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T73545: Argument 1 passed to AbuseFilter::contentToString() must implement interface Content
Daimona added a comment. Hm, unseen in the last 30 days. Maybe this was fixed in rEABF688eccea477a3a537c86066112bda7da202a8463?TASK DETAILhttps://phabricator.wikimedia.org/T73545EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DaimonaCc: Daimona, Krinkle, Zoglun, Wikidata-bugs, aude, wikibugs-l-list, werdna, Lydia_Pintscher, hoo, Litanwei, Wong128hk, Luke081515, Nirmos, Huji, Jdforrester-WMF, Jackmcbarn, Jay8g, Krenair, chasemp___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T73545: Argument 1 passed to AbuseFilter::contentToString() must implement interface Content
Daimona closed this task as "Resolved". Daimona claimed this task. Daimona added a comment. Calling resolved, given that the EditFilterMergedContent hook is guaranteed to provide a valid Content object (that is then passed to contentToString). TASK DETAIL https://phabricator.wikimedia.org/T73545 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Daimona, Krinkle, Zoglun, Wikidata-bugs, aude, werdna, Lydia_Pintscher, hoo, DannyS712, Litanwei, TerraCodes, Wong128hk, Nirmos, Huji, Jdforrester-WMF, Jackmcbarn, Jay8g, Krenair, chasemp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T205254: Investigate usage of "text" in AbuseFilter rules on wikidata.org
Daimona added a comment. Just a random comment: data actually used by existing abuse filters like the rank can be moved from added_lines to new AF variables defined via hooks. TASK DETAIL https://phabricator.wikimedia.org/T205254 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: matej_suchanek, Daimona, Lea_Lacroix_WMDE, Lydia_Pintscher, gerritbot, Aklapper, Addshore, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T215380: Content too big! Entity: Q27972199
Daimona added a comment. (For the record, it happens every time the entity is edited, which is roughly 900 times in the last 12 hours.)TASK DETAILhttps://phabricator.wikimedia.org/T215380EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DaimonaCc: Daimona, Lydia_Pintscher, Addshore, Aklapper, mmodell, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, Jonas, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T205254: Investigate usage of "text" in AbuseFilter rules on wikidata.org
Daimona updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION... - edit_diff, edit_diff_pst...TASK DETAILhttps://phabricator.wikimedia.org/T205254EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DaimonaCc: Daimona, Lea_Lacroix_WMDE, Lydia_Pintscher, gerritbot, Aklapper, Addshore, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T205254: Investigate usage of "text" in AbuseFilter rules on wikidata.org
Daimona updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION... - Use of- AbuseFilter text / lines-related variables (from https://www.mediawiki.org/wiki/Extension:AbuseFilter/Rules_format): - *- old_wikitext, new_wikitextt - edit_diff, edit_diff_pst - *_text- added_lines, added_lines_pst, removed_lines, removed_lines_pst - *_lines- new_pst, new_html,new_text For example...TASK DETAILhttps://phabricator.wikimedia.org/T205254EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DaimonaCc: Daimona, Lea_Lacroix_WMDE, Lydia_Pintscher, gerritbot, Aklapper, Addshore, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T205254: Investigate usage of "text" in AbuseFilter rules on wikidata.org
Daimona added a comment. Description updated! Searching for all of the variables yields 76 matches. Checking by hand is feasible, but not optimal. Is there a list of what data we're looking for (e.g. GUIDs and rank, mentioned in task desc)? I'd like to see if I can extract a regex from there.TASK DETAILhttps://phabricator.wikimedia.org/T205254EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DaimonaCc: Daimona, Lea_Lacroix_WMDE, Lydia_Pintscher, gerritbot, Aklapper, Addshore, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme
Daimona added a comment. @noarave It actually did. It's just that phan completed its analysis and found several errors. Of note, you should also add a phan config file - I can amend your patch, although I don't know if I'll have time to fix all the errors. @hashar Actually, it's not Lexeme. It's the phan runner, specifically this line <https://gerrit.wikimedia.org/r/plugins/gitiles/integration/config/+/master/dockerfiles/mediawiki-phan/run.sh#31> which chooses 0.8.0 as fallback if it cannot find phan in the composer. So basically, this issue also affects any repo where no phan version is specified. Changing the fallback option to phan 1.3.4 could solve it - unless it creates more troubles. TASK DETAIL https://phabricator.wikimedia.org/T226244 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: hashar, noarave, Daimona, Aklapper, Jdforrester-WMF, Michael, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Redabr4, Zanziii, Sadisticturd, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme
Daimona added a comment. In T226244#5273866 <https://phabricator.wikimedia.org/T226244#5273866>, @alaa_wmde wrote: > @Daimona understood. I also think the clean-up work is necessary. I'm not such a fan of statements of the sort "extensions must use mediawiki config rather than overriding/changing them" but that's a separate topic anyway. Ah, I haven't been clear. Extensions *should* override the default config, e.g. to define additional dependencies (many extensions do that). But it's vital that the default config is first included, then overridden for the necessary part. What happened for Lexeme (and WB itself) is that the default config has just been copypasted. And you'll probably agree that copypastas are always very bad for maintainability in the long term. > I would actually like to merge my patch first to fix the build first.. your patch can then rebase on it. Is that fine by you? Definitely, I implicitly meant that. TASK DETAIL https://phabricator.wikimedia.org/T226244 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: alaa_wmde, hashar, noarave, Daimona, Aklapper, Jdforrester-WMF, Michael, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Redabr4, Zanziii, Sadisticturd, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme
Daimona added a comment. AIUI, only the last mentioned patch is culprit. The dependency on Wikibase should only be used to tell what MW extensions to install before testing Lexeme, but that shouldn't be related to the phan version to use. What happened, instead, is that IMHO phan72 jobs were made live too early. Currently, the phan runner still supports phan 0.8.0, which in turn can only run on PHP70. Lexeme doesn't specify a phan version to run, and for some reason the 0.8.0 version is picked. I think some solutions could be to: 1. Explicitly require phan config 0.6.1 in Lexeme's composer.json 2. Make the phan72 job install a recent version of phan (not 0.8.0) CC @Jdforrester-WMF TASK DETAIL https://phabricator.wikimedia.org/T226244 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Daimona, Aklapper, Jdforrester-WMF, Michael, darthmon_wmde, Redabr4, Zanziii, Sadisticturd, Nandana, A.S.Kochergin, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, hashar ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme
Daimona added a comment. In T226244#5273853 <https://phabricator.wikimedia.org/T226244#5273853>, @alaa_wmde wrote: > In T226244#5273849 <https://phabricator.wikimedia.org/T226244#5273849>, @gerritbot wrote: > > > Change 518256 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy): > > [mediawiki/extensions/WikibaseLexeme@master] [WIP] Update phan, cleanup config > > > > https://gerrit.wikimedia.org/r/518256 > > > @Daimona think you are trying to achieve the same effect I did with https://gerrit.wikimedia.org/r/518249 (https://phabricator.wikimedia.org/T226244#5273778). > > Though I wouldn't add an explicit dependency here on Wikibase phan config. Lexeme and Wikibase can have different configurations in the long run. What do you think? @alaa_wmde Actually, not really. With the phan dependency in composer, we can use the standard MediaWiki config (source <https://github.com/wikimedia/mediawiki-tools-phan>), which is what all extensions should do. For some reason, Wikibase redeclares its own config, so that it'll inevitably drift from the default. My change introduces a dependency on the standard config, not the Wikibase one, so this is the right way to go :-) I also tried to *remove* all suppressions to see what's really left to fix. The first thing I noticed is that all "A inherits B which is declared at X and also at Y" warnings have gone, and that was due to misconfiguration including Wikibase twice, probably. Now it complains about some methods not being declared (instead of being declared twice, eheh), but that's probably something we can fix via config. You'll also notice many warnings like "...can usually be simplified to...". They come from a phan plugin which is included in the standard config, but not in Wikibase - that's what I meant with "it'll inevitably drift from the default". At this point, I'd like to fix all issues reported for my patch, but that could take some time. And at the end, the same config change will have to be applied to Wikibase itself. TASK DETAIL https://phabricator.wikimedia.org/T226244 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: alaa_wmde, hashar, noarave, Daimona, Aklapper, Jdforrester-WMF, Michael, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Redabr4, Zanziii, Sadisticturd, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T227270: Phan cannot find classes after namespace move
Daimona added a comment. Mediawiki-phan 0.6.1 added phan support for class_alias, but wikibase isn't included because for some reason it has its own phan config file, instead of requiring the base one. And for that I sent https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/518287/ If you're interested in reviewing. It's big, but trivial. TASK DETAIL https://phabricator.wikimedia.org/T227270 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Daimona, Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Claimed] T226254: Fix and unsuppress reported Phan errors on WikibaseLexeme
Daimona claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T226254 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Aklapper, alaa_wmde, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Claimed] T227270: Phan cannot find classes after namespace move
Daimona claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T227270 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Daimona, Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Claimed] T224775: Use mediawiki/mediawiki-phan-config in extension WikibaseLexeme
Daimona claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T224775 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Aklapper, Umherirrender, darthmon_wmde, Nandana, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Darkdadaah, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T226977: Wikibase Travis CI failing, Failed asserting that file "LocalSettings.php" exists.
Daimona added a comment. Note that this also makes the coverage job fail, see for instance one <https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-patch-docker/14676/console>, two <https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-patch-docker/14677/console>, three <https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-patch-docker/14665/console>. TASK DETAIL https://phabricator.wikimedia.org/T226977 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Daimona Cc: Daimona, Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, alaa_wmde, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T226977: Wikibase Travis CI failing, Failed asserting that file "LocalSettings.php" exists.
Daimona added a comment. In T226977#5297201 <https://phabricator.wikimedia.org/T226977#5297201>, @Lucas_Werkmeister_WMDE wrote: > @Daimona are the coverage builds now fixed as well? (I tried to look at recent jobs in the same Jenkins project but couldn’t make much sense of it.) I think yes, looking e.g. at https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-patch-docker/14682/console (errors are unrelated). TASK DETAIL https://phabricator.wikimedia.org/T226977 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Daimona Cc: Daimona, Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, alaa_wmde, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T221380: Wikidata: Special:Contributions times out for many high-activity users
Daimona added a comment.
name=message
[XLxsMQpAADsAAImQla8AAACB]
/w/index.php?title=Special:Contributions=20190418104744=1=KrBot
WMFTimeoutException from line 39 of
/srv/mediawiki/wmf-config/set-time-limit.php: the execution time limit of 60
seconds was exceeded
name=trace
#0
/srv/mediawiki/php-1.34.0-wmf.1/includes/exception/MWExceptionHandler.php(196):
{closure}(integer)
#1 [internal function]: MWExceptionHandler::handleError(integer, string,
string, integer, array)
#2
/srv/mediawiki/php-1.34.0-wmf.1/includes/libs/rdbms/database/DatabaseMysqli.php(46):
mysqli->query(string)
#3
/srv/mediawiki/php-1.34.0-wmf.1/includes/libs/rdbms/database/Database.php(1322):
Wikimedia\Rdbms\DatabaseMysqli->doQuery(string)
#4
/srv/mediawiki/php-1.34.0-wmf.1/includes/libs/rdbms/database/Database.php(1224):
Wikimedia\Rdbms\Database->attemptQuery(string, string, boolean, string)
#5
/srv/mediawiki/php-1.34.0-wmf.1/includes/libs/rdbms/database/Database.php(1784):
Wikimedia\Rdbms\Database->query(string, string)
#6
/srv/mediawiki/php-1.34.0-wmf.1/includes/specials/pagers/ContribsPager.php(205):
Wikimedia\Rdbms\Database->select(array, array, array, string, array, array)
#7 /srv/mediawiki/php-1.34.0-wmf.1/includes/pager/IndexPager.php(249):
ContribsPager->reallyDoQuery(string, integer, boolean)
#8 /srv/mediawiki/php-1.34.0-wmf.1/includes/pager/IndexPager.php(602):
IndexPager->doQuery()
#9
/srv/mediawiki/php-1.34.0-wmf.1/includes/specials/SpecialContributions.php(236):
IndexPager->getNumRows()
#10
/srv/mediawiki/php-1.34.0-wmf.1/includes/specialpage/SpecialPage.php(569):
SpecialContributions->execute(NULL)
#11
/srv/mediawiki/php-1.34.0-wmf.1/includes/specialpage/SpecialPageFactory.php(578):
SpecialPage->run(NULL)
#12 /srv/mediawiki/php-1.34.0-wmf.1/includes/MediaWiki.php(288):
MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#13 /srv/mediawiki/php-1.34.0-wmf.1/includes/MediaWiki.php(865):
MediaWiki->performRequest()
#14 /srv/mediawiki/php-1.34.0-wmf.1/includes/MediaWiki.php(515):
MediaWiki->main()
#15 /srv/mediawiki/php-1.34.0-wmf.1/index.php(42): MediaWiki->run()
#16 /srv/mediawiki/w/index.php(3): require(string)
#17 {main}
And this doesn't tell much. OTOH, I could find the culprit query on tendril,
at least the one for KrBot's contributions with offset = 20190418104744 and
limit 1. Given that I couldn't find any private data in there, here is the
paste:
SELECT /* IndexPager::buildQueryInfo (contributions page unfiltered) */
rev_page, rev_minor_edit, rev_deleted, rev_len, rev_parent_id, rev_sha1,
comment_rev_comment.comment_text AS `rev_comment_text`,
comment_rev_comment.comment_data AS `rev_comment_data`,
comment_rev_comment.comment_id AS `rev_comment_cid`, actor_rev_user.actor_user
AS `rev_user`, actor_rev_user.actor_name AS `rev_user_text`,
temp_rev_user.revactor_actor AS `rev_actor`, page_namespace, page_title,
page_id, page_latest, page_is_redirect, page_len, user_name, page_is_new,
revactor_timestamp AS `rev_timestamp`, revactor_rev AS `rev_id`, (SELECT
GROUP_CONCAT(ctd_name SEPARATOR ', ') FROM `change_tag` JOIN `change_tag_def`
ON ((ct_tag_id=ctd_id)) WHERE ct_rev_id=rev_id ) AS `ts_tags`,
ores_damaging_cls.oresc_probability AS `ores_damaging_score`, 0.387 AS
`ores_damaging_threshold` FROM `revision` JOIN `revision_comment_temp`
`temp_rev_comment` ON ((temp_rev_comment.revcomment_rev = rev_id)) JOIN
`comment` `comment_rev_comment` ON ((comment_rev_comment.comment_id =
temp_rev_comment.revcomment_comment_id)) JOIN `revision_actor_temp`
`temp_rev_user` FORCE INDEX (actor_timestamp) ON ((temp_rev_user.revactor_rev =
rev_id)) JOIN `actor` `actor_rev_user` ON ((actor_rev_user.actor_id =
temp_rev_user.revactor_actor)) JOIN `page` ON ((page_id = rev_page)) LEFT JOIN
`user` ON ((actor_rev_user.actor_user != 0) AND (user_id =
actor_rev_user.actor_user)) LEFT JOIN `ores_classification` `ores_damaging_cls`
ON (ores_damaging_cls.oresc_model = '11' AND
(ores_damaging_cls.oresc_rev=rev_id) AND ores_damaging_cls.oresc_class = '1')
WHERE ((temp_rev_user.revactor_actor = '122')) AND ((rev_deleted & 12) != 12)
AND (rev_timestamp>='20190418104744') ORDER BY rev_timestamp, rev_id LIMIT 1
I'd like to provide an EXPLAIN for it, but the revision_comment_temp table is
not available on quarry, nor in the sql optimizer.
TASK DETAIL
https://phabricator.wikimedia.org/T221380
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Daimona
Cc: Daimona, matej_suchanek, MisterSynergy, Framawiki, TerraCodes,
Liuxinyu970226, Aklapper, Jc86035, alaa_wmde, DannyS712, Nandana, Lahi, Gq86,
Lsherwinforone, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer,
Sethakill, _jensen, rosalieper, Wong128hk, Wikidata-bugs, aude, Mbch331
___
[Wikidata-bugs] [Maniphest] [Updated] T218149: Abuse filter support for depicts and statements
Daimona added a project: AbuseFilter. Daimona added a comment. Tagging, and CC'ing myself in case any help is needed with AF. TASK DETAIL https://phabricator.wikimedia.org/T218149 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Keegan, Daimona Cc: Daimona, Elitre, Ramsey-WMF, Aklapper, Keegan, darthmon_wmde, DannyS712, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, V4switch, LawExplorer, Litanwei, Salgo60, JJMC89, Silverfish, _jensen, rosalieper, Susannaanas, Wong128hk, Nirmos, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Huji, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Jackmcbarn, Steinsplitter, Matanya, Mbch331, Qgil, chasemp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T47537: [Bug] AbuseFilter warnings not triggered when creating an item
Daimona closed this task as "Resolved". Daimona claimed this task. Daimona added a comment. This is now working as intended, see for instance https://wikidata.beta.wmflabs.org/wiki/Special:AbuseLog/411; I also got the warning: F30076822: wikidata-filter-warning.png <https://phabricator.wikimedia.org/F30076822> TASK DETAIL https://phabricator.wikimedia.org/T47537 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Daimona, Aklapper, Addshore, Legoktm, Ajraddatz, matej_suchanek, Lydia_Pintscher, hoo, darthmon_wmde, 94rain, Dinadineke, DannyS712, Nandana, tabish.shaikh91, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, Jayprakash12345, JakeTheDeveloper, QZanden, merbst, LawExplorer, Litanwei, JJMC89, TerraCodes, _jensen, rosalieper, Wong128hk, Nirmos, Wikidata-bugs, aude, Huji, TheDJ, Jackmcbarn, Mbch331, chasemp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Unblock] T76230: [Epic] data quality and trust
Daimona closed subtask T47537: [Bug] AbuseFilter warnings not triggered when creating an item as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T76230 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: 99of9, Cirdan, Hjfocs, AfroThundr3007730, Agabi10, Capankajsmilyo, Herzi.Pinki, SandraF_WMF, Tbayer, abian, Aklapper, Ricordisamoa, Elitre, Liuxinyu970226, Lydia_Pintscher, darthmon_wmde, DannyS712, Nickleh, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Dinoguy1000, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T65632: AbuseFilter *_links variables incorrect on item edits.
Daimona added a comment. I'm sorry, I'm pretty ignorant about wikidata. How exactly am I supposed to reproduce the problem? I tried here <https://wikidata.beta.wmflabs.org/wiki/Q416076>, but I'm unsure if that's right. If it is, then indeed we don't get _links variables. TASK DETAIL https://phabricator.wikimedia.org/T65632 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Daimona, matej_suchanek, Lydia_Pintscher, daniel, hoo, darthmon_wmde, 94rain, Dinadineke, DannyS712, Nandana, tabish.shaikh91, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, Jayprakash12345, JakeTheDeveloper, QZanden, merbst, LawExplorer, Litanwei, JJMC89, _jensen, rosalieper, Wong128hk, Nirmos, Wikidata-bugs, aude, Huji, TheDJ, Jackmcbarn, Mbch331, chasemp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T232862: Lexeme search on Wikidata result in fatal exceptions
Daimona added a comment.
name=message
[XXvNjwpAMFAAABEsrycAAADE]
/w/index.php?search==L%3Ani=Special%3ASearch=G%C3%A5+til
Error from line 57 of
/srv/mediawiki/php-1.34.0-wmf.22/extensions/WikibaseLexemeCirrusSearch/src/LexemeResult.php:
Call to a member function setFragment() on null
name=trace
#0
/srv/mediawiki/php-1.34.0-wmf.22/extensions/WikibaseLexemeCirrusSearch/src/LexemeResultSet.php(72):
Wikibase\Lexeme\Search\Elastic\LexemeResult->__construct(Language,
Wikibase\Lexeme\DataAccess\LexemeDescription, array)
#1
/srv/mediawiki/php-1.34.0-wmf.22/extensions/CirrusSearch/includes/Search/BaseCirrusSearchResultSet.php(162):
Wikibase\Lexeme\Search\Elastic\LexemeResultSet->transformOneResult(Elastica\Result)
#2
/srv/mediawiki/php-1.34.0-wmf.22/includes/search/SearchResultSetTrait.php(58):
CirrusSearch\Search\BaseCirrusSearchResultSet->extractResults()
#3
/srv/mediawiki/php-1.34.0-wmf.22/extensions/CirrusSearch/includes/RequestLogger.php(374):
CirrusSearch\Search\BaseCirrusSearchResultSet->getIterator()
#4
/srv/mediawiki/php-1.34.0-wmf.22/extensions/CirrusSearch/includes/RequestLogger.php(181):
CirrusSearch\RequestLogger->extractTitleStrings(Wikibase\Lexeme\Search\Elastic\LexemeResultSet)
#5
/srv/mediawiki/php-1.34.0-wmf.22/extensions/CirrusSearch/includes/ElasticsearchIntermediary.php(118):
CirrusSearch\RequestLogger->setResultPages(array)
#6
/srv/mediawiki/php-1.34.0-wmf.22/extensions/CirrusSearch/includes/CirrusSearch.php(205):
CirrusSearch\ElasticsearchIntermediary::setResultPages(array)
#7 /srv/mediawiki/php-1.34.0-wmf.22/includes/search/SearchEngine.php(86):
CirrusSearch\CirrusSearch->doSearchText(string)
#8 /srv/mediawiki/php-1.34.0-wmf.22/includes/search/SearchEngine.php(172):
SearchEngine->{closure}()
#9 /srv/mediawiki/php-1.34.0-wmf.22/includes/search/SearchEngine.php(87):
SearchEngine->maybePaginate(Closure)
#10
/srv/mediawiki/php-1.34.0-wmf.22/includes/specials/SpecialSearch.php(356):
SearchEngine->searchText(string)
#11
/srv/mediawiki/php-1.34.0-wmf.22/includes/specials/SpecialSearch.php(179):
SpecialSearch->showResults(string)
#12
/srv/mediawiki/php-1.34.0-wmf.22/includes/specialpage/SpecialPage.php(573):
SpecialSearch->execute(NULL)
#13
/srv/mediawiki/php-1.34.0-wmf.22/includes/specialpage/SpecialPageFactory.php(601):
SpecialPage->run(NULL)
#14 /srv/mediawiki/php-1.34.0-wmf.22/includes/MediaWiki.php(296):
MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#15 /srv/mediawiki/php-1.34.0-wmf.22/includes/MediaWiki.php(892):
MediaWiki->performRequest()
#16 /srv/mediawiki/php-1.34.0-wmf.22/includes/MediaWiki.php(523):
MediaWiki->main()
#17 /srv/mediawiki/php-1.34.0-wmf.22/index.php(44): MediaWiki->run()
#18 /srv/mediawiki/w/index.php(3): require(string)
#19 {main}
TASK DETAIL
https://phabricator.wikimedia.org/T232862
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Daimona
Cc: Daimona, Aklapper, Fnielsen, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86,
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs,
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T232862: Lexeme search on Wikidata result in fatal exceptions
Daimona added a project: Wikimedia-production-error. TASK DETAIL https://phabricator.wikimedia.org/T232862 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Daimona, Aklapper, Fnielsen, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T224775: Use mediawiki/mediawiki-phan-config in extension WikibaseLexeme
Daimona closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T224775 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Aklapper, Umherirrender, darthmon_wmde, DannyS712, Nandana, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Darkdadaah, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T226254: Fix and unsuppress reported Phan errors on WikibaseLexeme
Daimona closed this task as "Resolved". Daimona added a comment. After my patch, we have: $cfg['suppress_issue_types'][] = 'PhanParamSignatureMismatch'; // False positives with methods taking nullables $cfg['suppress_issue_types'][] = 'PhanParamReqAfterOpt'; // @todo Remove the next line once HHVM is gone. Many instances are on ArrayObjects, and on HHVM the // coalesce operator doesn't behave well on them. $cfg['suppress_issue_types'][] = 'PhanPluginDuplicateConditionalNullCoalescing'; The former is to avoid tons of false positives, ditto for the second, and the third one is HHVM-only, so calling this resolved. TASK DETAIL https://phabricator.wikimedia.org/T226254 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Aklapper, alaa_wmde, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T227270: Phan cannot find classes after namespace move
Daimona closed this task as "Resolved". Daimona added a comment. WBLexeme is now importing the base config which supports class_alias. TASK DETAIL https://phabricator.wikimedia.org/T227270 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Daimona, Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T198342: Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo().
Daimona added a comment. So I see AF is mentioned here... I'm glad to help. To give you some context, we do access the text table directly in AbuseFilter::storeVarDump and AbuseFilter::loadVarDump, but that's not for getting revision text, as we save our custom data in the text table. It's also not related to Revision(Store)::getQueryInfo, so I don't know whether it should be handled in a separate task. Anyway, I hope to have saved you some time for investigation. TASK DETAIL https://phabricator.wikimedia.org/T198342 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: BPirkle, Daimona Cc: Daimona, Nikerabbit, BPirkle, Aklapper, aude, Anomie, Jdforrester-WMF, Tgr, gerritbot, daniel, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, WDoranWMF, holger.knust, EvanProdromou, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Sario528, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Agabi10, Pchelolo, Wikidata-bugs, Mbch331, Ltrlg ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Merged] T233763: Error searching Lexeme:Danke on Wikidata: "Call to a member function setFragment() on null"
Daimona merged a task: T233981: Call to a member function setFragment() on null. Daimona added a subscriber: mmodell. TASK DETAIL https://phabricator.wikimedia.org/T233763 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: mmodell, Smalyshev, VIGNERON, ArthurPSmith, Lea_Lacroix_WMDE, Lydia_Pintscher, Aklapper, Denny, darthmon_wmde, DannyS712, Nandana, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Darkdadaah, Jdforrester-WMF, Mbch331, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T233981: Call to a member function setFragment() on null
Daimona closed this task as a duplicate of T233763: Error searching Lexeme:Danke on Wikidata: Call to a member function setFragment() on null. TASK DETAIL https://phabricator.wikimedia.org/T233981 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: mmodell, darthmon_wmde, DannyS712, Nandana, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, jayvdb, Darkdadaah, Jdforrester-WMF, Mbch331, Jay8g, Krenair, jeremyb ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T235326: Wikibase PHPUnit tests are broken
Daimona closed this task as "Resolved". Daimona removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T235326 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Ladsgroup, Lucas_Werkmeister_WMDE, thiemowmde, Aklapper, Daimona, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Meekrab2012, joker88john, CucyNoiD, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, WSH1906, Lewizho99, Maathavan ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T239265: Special:Diff: Bad value for parameter $title: invalid name 'Diff/1_'
Daimona edited projects, added MediaWiki-Special-pages; removed Wikidata, MediaWiki-extensions-Diff. TASK DETAIL https://phabricator.wikimedia.org/T239265 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Aklapper, Daimona, Amorymeltzer, Lsherwinforone, Jayprakash12345, Sethakill, Wong128hk, Jdforrester-WMF, Rxy, Jay8g, Krenair, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T239265: Special:Diff: Bad value for parameter $title: invalid name 'Diff/1_'
Daimona created this task. Daimona added projects: Wikimedia-production-error, MediaWiki-extensions-Diff. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION Error - `MediaWiki version:` **`1.35.0-wmf.5`** name=message [Xd1zIQpAAD0AAH@TyZMAAACC] /wiki/Speciale:Diff Wikimedia\Assert\ParameterAssertionException from line 63 of /srv/mediawiki/php-1.35.0-wmf.5/vendor/wikimedia/assert/src/Assert.php: Bad value for parameter $title: invalid name 'Diff/1_' Impact -- The page fatals. Instead, it should fail gracefully and inform the user that the input is invalid (or trim the input). Notes - Can be triggered by heading to Special:Diff, then paste something ending with a space (e.g. "1 ") in "Revision ID of difference" and hit "Show differences". As I wrote above, it should either fail gracefully, or (probably better) trim the input. TASK DETAIL https://phabricator.wikimedia.org/T239265 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Aklapper, Daimona, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T233763: Error searching Lexeme:Danke on Wikidata: "Call to a member function setFragment() on null"
Daimona added a comment. In T233763#5551443 <https://phabricator.wikimedia.org/T233763#5551443>, @Daimona wrote: > AFAICS, mTitle is not defined as property, and this happens as of https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CirrusSearch/+/531450/ Uh, actually, not completely culprit. I was deceived by my IDE which still had to load the RevisionSearchResultTrait. Which //does// have an mTitle property; however, although it's documented as Title only, it can also be null. TASK DETAIL https://phabricator.wikimedia.org/T233763 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Daimona, mmodell, Smalyshev, VIGNERON, ArthurPSmith, Lea_Lacroix_WMDE, Lydia_Pintscher, Aklapper, Denny, darthmon_wmde, DannyS712, Nandana, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Darkdadaah, Jdforrester-WMF, Mbch331, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T233763: Error searching Lexeme:Danke on Wikidata: "Call to a member function setFragment() on null"
Daimona added a comment. Curiously, PHPUnit is failing on the WikibaseLexemeCirrusSearch repo with "Call to a member function setFragment() on null". I don't know if it's exactly the same error, but oh well... TASK DETAIL https://phabricator.wikimedia.org/T233763 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Daimona, mmodell, Smalyshev, VIGNERON, ArthurPSmith, Lea_Lacroix_WMDE, Lydia_Pintscher, Aklapper, Denny, darthmon_wmde, DannyS712, Nandana, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Darkdadaah, Jdforrester-WMF, Mbch331, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T233763: Error searching Lexeme:Danke on Wikidata: "Call to a member function setFragment() on null"
Daimona added a comment. AFAICS, mTitle is not defined as property, and this happens as of https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CirrusSearch/+/531450/ IMHO, it's pretty sad that: - This wasn't spotted when updating the class; - Nothing triggered (PHPUnit) tests in WBLCS in the last month, and hence the error remained unnoticed; - Phan wouldn't have caught it anyway, because we use stubs. That's a failure across the board... I'm going to fix the code itself, and make phan more powerful. And, as a side note, it'd be great to automatically run tests in a repo when no changes were sent in say the last month. TASK DETAIL https://phabricator.wikimedia.org/T233763 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Daimona, mmodell, Smalyshev, VIGNERON, ArthurPSmith, Lea_Lacroix_WMDE, Lydia_Pintscher, Aklapper, Denny, darthmon_wmde, DannyS712, Nandana, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Darkdadaah, Jdforrester-WMF, Mbch331, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Claimed] T233763: Error searching Lexeme:Danke on Wikidata: "Call to a member function setFragment() on null"
Daimona claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T233763 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Daimona, mmodell, Smalyshev, VIGNERON, ArthurPSmith, Lea_Lacroix_WMDE, Lydia_Pintscher, Aklapper, Denny, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, aude, Darkdadaah, Jdforrester-WMF, Mbch331, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T233763: Error searching Lexeme:Danke on Wikidata: "Call to a member function setFragment() on null"
Daimona closed this task as "Resolved". Daimona removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T233763 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Jdforrester-WMF, Daimona, mmodell, Smalyshev, VIGNERON, ArthurPSmith, Lea_Lacroix_WMDE, Lydia_Pintscher, Aklapper, Denny, darthmon_wmde, DannyS712, Nandana, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Darkdadaah, Mbch331, Jay8g, Krenair, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Meekrab2012, joker88john, CucyNoiD, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, WSH1906, Lewizho99, Maathavan ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Raised Priority] T235007: ReflectionException: Property languageNameCache does not exist
Daimona raised the priority of this task from "High" to "Unbreak Now!". Daimona added a comment. Restricted Application added a subscriber: Liuxinyu970226. It's blocking merges to various extensions. For instance, ArticlePlaceholder <https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/ArticlePlaceholder/+/541669/>, PropertySuggester <https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/PropertySuggester/+/541676/>, and WikimediaBadges <https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikimediaBadges/+/541678/>. TASK DETAIL https://phabricator.wikimedia.org/T235007 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Liuxinyu970226, Daimona, Reedy, darthmon_wmde, DannyS712, Nandana, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Darkdadaah, Jdforrester-WMF, Mbch331, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T235007: ReflectionException: Property languageNameCache does not exist
Daimona added a comment. What about just calling Language::clearCaches(), instead of making a private property accessible? TASK DETAIL https://phabricator.wikimedia.org/T235007 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Liuxinyu970226, Daimona, Reedy, darthmon_wmde, DannyS712, Nandana, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Darkdadaah, Jdforrester-WMF, Mbch331, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T235007: ReflectionException: Property languageNameCache does not exist
Daimona closed this task as "Resolved". Daimona assigned this task to Ladsgroup. Daimona added a comment. Restricted Application added a project: User-Ladsgroup. Fixed with https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikibaseLexeme/+/541815/ TASK DETAIL https://phabricator.wikimedia.org/T235007 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Daimona Cc: Liuxinyu970226, Daimona, Reedy, darthmon_wmde, DannyS712, Nandana, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Darkdadaah, Jdforrester-WMF, Mbch331, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T234752: Many QUnit warnings: WARN: 'jQuery.Deferred exception: Cannot read property 'id' of undefined'
Daimona created this task. Daimona added projects: Browser-Tests, Lexicographical data. Restricted Application added a project: Wikidata. TASK DESCRIPTION Seen e.g. in https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-docker/22927/consoleFull#console-section-5. The QUnit section has roughly 20 samples of: 13:34:41 WARN: 'jQuery.Deferred exception: Cannot read property 'id' of undefined', 'TypeError: Cannot read property 'id' of undefined 13:34:41 at Object.deserializeForm (http://localhost:9876/load.php?lang=en=oojs-ui.styles.icons-editing-advanced%2Cicons-editing-citation%2Cicons-editing-core%2Cicons-editing-list%2Cicons-editing-styling%2Cicons-interactions%2Cicons-layout%2Cicons-media%2Cicons-moderation%2Cicons-movement%2Cicons-user%2Cicons-wikimedia%2Cindicators%7Cpapaparse%2Cpromise-polyfill%2Crangefix%2Cspark-md5%2CtreeDiffer%2Cunicodejs%2CvalueFormatters%2CvalueParsers%2Cvue2%2Cvuex%2Cwikibase%7Csocket.io%7Ctest.ArticlePlaceholder%2CCentralAuth%2CEventLogging%2CMinervaNeue%2CVisualEditor%2CWikiEditor%2Csinonjs%7Ctest.mediawiki.qunit.suites%2Ctestrunner%7Ctests.mobilefrontend%7Cuser.defaults%7Cutil.CombiningMessageProvider%2CContentLanguages%2CExtendable%2CHashMessageProvider%2CMessageProvider%2CNotifier%2CPrefixingMessageProvider%2ChighlightSubstring%2Cinherit%7CvalueParsers.ValueParserStore%7Cwikibase.EntityInitializer%2CSite%2CWikibaseContentLanguages%2CbuildErrorOutput%2Cdatamodel%2CgetLanguageNameByCode%2CgetUserLanguages%2Clexeme%7Cwikibase.EntityInitializer.tests%7Cwikibase.Site.tests%7Cwikibase.api.RepoApi%2CRepoApiError%7Cwikibase.dataTypes.DataType.tests%7Cwikibase.dataTypes.DataTypeStore.tests%7Cwikibase.datamodel.Claim%2CEntity%2CEntityId%2CFingerprint%2CFingerprintableEntity%2CGroup%2CGroupableCollection%2CItem%2CList%2CMap%2CMultiTerm%2CMultiTermMap%2CProperty%2CPropertyNoValueSnak%2CPropertySomeValueSnak%2CPropertyValueSnak%2CReference%2CReferenceList%2CSet%2CSiteLink%2CSiteLinkSet%2CSnak%2CSnakList%2CStatement%2CStatementGroup%2CStatementGroupSet%2CStatementList%2CTerm%2CTermMap%2C__namespace%7Cwikibase.entityChangers.EntityChangersFactory%7Cwikibase.experts.Entity%2CForm%2CItem%2CLexeme%2CProperty%2CSense%2C__namespace%2Cmodules%7Cwikibase.experts.Item.tests%7Cwikibase.experts.Property.tests%7Cwikibase.lexeme.datamodel.Form%2CSense%7Cwikibase.lexeme.serialization.LexemeDeserializer%7Cwikibase.lexeme.view.ViewFactoryFactory%7Cwikibase.lexeme.widgets.GrammaticalFeatureListWidget%2CItemSelectorWidget%7Cwikibase.serialization.ClaimSerializer=vector=19f9x:1883:452) 13:34:41 at http://localhost:9876/load.php?lang=en=WikibaseLexeme.tests%7CWikibaseLexeme.tests.ControllerViewFactory%2CFormChanger%2CItemLookup%2CLanguageFromItemExtractor%2CLexemeDeserializer%2CLexemeLanguageFieldObserver%2CLexemeRevisionStore%2CSenseChanger%2CViewFactoryFactory%7CWikibaseLexeme.tests.datamodel.Lexeme%7CWikibaseLexeme.tests.serialization.FormSerializer%2CSenseSerializer%7Ccolor-picker%2CdataValues%2CdiffMatchPatch%2Cdompurify%7CdataValues.DataValue%2CTimeValue%2Cvalues%7Cext.articleplaceholder.createArticle%7Cext.centralauth.ForeignApi%7Cext.cite.style%2Cstyles%2CvisualEditor%7Cext.cite.visualEditor.core%2Cdata%2Ctest%7Cext.echo.api%2Cdm%2Cinit%7Cext.echo.dm.tests%7Cext.eventLogging%7Cext.eventLogging.debug%7Cext.templateData.test%7Cext.templateDataGenerator.data%7Cext.uls.common%2Ci18n%2Cinit%2Clanguagenames%2Cmediawiki%2Cmessages%2Cpreferences%2Ctests%7Cext.visualEditor.data%2CmoduleIcons%2CmoduleIndicators%2Cmwextensionmessages%7CglobeCoordinate.js%7Cjquery.AnimationEvent%2CPurposedCallbacks%2CanimateWithEvent%2Cclient%2Ccolor%2Ccookie%2CgetAttrs%2ChighlightText%2Ci18n%2Cinputautoexpand%2ClengthLimit%2CmakeCollapsible%2Csuggestions%2CtabIndex%2Ctablesorter%2CtextSelection%2Cthrottle-debounce%2Ctipsy%2Culs%2Cvalueview%7Cjquery.event.special.eachchange%7Cjquery.makeCollapsible.styles%7Cjquery.tablesorter.styles%7Cjquery.ui.EditableTemplatedWidget%2Ccommonssuggester%2Clanguagesuggester%2Csuggester%2Ctoggler%2Cunitsuggester%7Cjquery.uls.data%2Cgrid%7Cjquery.util.getDirectionality%7Cjquery.valueview.Expert%2CExpertExtender%2CExpertStore%2CViewState%2Cexperts%2Cvalueview%7Cjquery.valueview.ExpertExtender.Container%2CListrotator%2CPreview%7Cjquery.valueview.experts.CommonsMediaType%2CEmptyValue%2CGeoShape%2CGlobeCoordinateInput%2CMonolingualText%2CQuantityInput%2CStringValue%2CTabularData%2CTimeInput%2CUnsupportedValue%7Cjquery.valueview.tests.MockViewState%2CtestExpert%7Cjquery.wikibase.entitysearch.tests%7Cjquery.wikibase.entityselector%2Centityview%2Clexemeview=vector=1kvem:59:351 13:34:41 at mightThrow (http://localhost:9876/load.php?lang=en=jquery%7Cmediawiki.base=vector=1j0dr:48:916) 13:34:41 at process (http://localhost:9876/load.php?lang=en=jquery%7Cmediawiki.base=vector=1j0dr:49:589)', undefined Some of them have different traces, but the error message is the same. The test still succeeds, but these warnings look pretty scary
[Wikidata-bugs] [Maniphest] [Commented On] T235326: Wikibase PHPUnit tests are broken
Daimona added a comment. In T235326#5569844 <https://phabricator.wikimedia.org/T235326#5569844>, @Ladsgroup wrote: > 1.0.0 supposed to be released now. I don't know if packagist picked it up or not. Let's hope so. I'm starting with Wikibase-related repos, and doing Wikibase itself last, for the same reason about signatures. TASK DETAIL https://phabricator.wikimedia.org/T235326 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Ladsgroup, Lucas_Werkmeister_WMDE, thiemowmde, Aklapper, Daimona, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T235326: Wikibase PHPUnit tests are broken
Daimona added a comment. In T235326#5569744 <https://phabricator.wikimedia.org/T235326#5569744>, @Ladsgroup wrote: > Can you make a pull request? It looks like a breaking change, a major version bump is needed https://github.com/wmde/WikibaseCodeSniffer/pull/55 is for release notes etc. I cannot actually tag a new version by myself. TASK DETAIL https://phabricator.wikimedia.org/T235326 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Ladsgroup, Lucas_Werkmeister_WMDE, thiemowmde, Aklapper, Daimona, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Claimed] T235326: Wikibase PHPUnit tests are broken
Daimona claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T235326 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Ladsgroup, Lucas_Werkmeister_WMDE, thiemowmde, Aklapper, Daimona, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T235326: Wikibase PHPUnit tests are broken
Daimona added a comment. In T235326#5569865 <https://phabricator.wikimedia.org/T235326#5569865>, @Daimona wrote: > In T235326#5569844 <https://phabricator.wikimedia.org/T235326#5569844>, @Ladsgroup wrote: > >> 1.0.0 supposed to be released now. I don't know if packagist picked it up or not. > > Let's hope so. I'm starting with Wikibase-related repos, and doing Wikibase itself last, for the same reason about signatures. Everything's on gerrit now, but instead, we should start with Wikibase itself. The tests are broken for related repos, too. TASK DETAIL https://phabricator.wikimedia.org/T235326 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Ladsgroup, Lucas_Werkmeister_WMDE, thiemowmde, Aklapper, Daimona, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Triaged] T235326: Wikibase PHPUnit tests are broken
Daimona triaged this task as "High" priority. TASK DETAIL https://phabricator.wikimedia.org/T235326 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Aklapper, Daimona, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T235326: Wikibase PHPUnit tests are broken
Daimona created this task. Daimona added a project: Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Seen e.g. in https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-docker/24311/console: > PHP Fatal error: Declaration of Wikibase\Client\Tests\DataAccess\Scribunto\Scribunto_LuaWikibaseLibraryTestCase::tearDown() must be compatible with Scribunto_LuaEngineTestBase::tearDown(): void in /workspace/src/extensions/Wikibase/client/tests/phpunit/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseLibraryTestCase.php on line 224 That's because we're upgrading to PHPCS 28.0.0, which forces you to add :void typehints to setUp and tearDown (because they were added in PHPUnit 8). Scribunto was already upgraded, hence it now has the typehints. But Wikibase extends some of those Scribunto classes without using typehints, and hence it broke. A quick way to unbreak the world would be to upgrade wikibase-codesniffer to use mediawiki-codesniffer 28.0.0, then run phpcbf. TASK DETAIL https://phabricator.wikimedia.org/T235326 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Aklapper, Daimona, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T235326: Wikibase PHPUnit tests are broken
Daimona added subscribers: thiemowmde, Lucas_Werkmeister_WMDE, Ladsgroup. Daimona added a comment. https://github.com/wmde/WikibaseCodeSniffer/pull/54 TASK DETAIL https://phabricator.wikimedia.org/T235326 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Ladsgroup, Lucas_Werkmeister_WMDE, thiemowmde, Aklapper, Daimona, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T235326: Wikibase PHPUnit tests are broken
Daimona added a comment. In T235326#5569733 <https://phabricator.wikimedia.org/T235326#5569733>, @Ladsgroup wrote: > In T235326#5569704 <https://phabricator.wikimedia.org/T235326#5569704>, @Daimona wrote: > >> https://github.com/wmde/WikibaseCodeSniffer/pull/54 > > Merged, let me know when you make the patch in wikibase repos Thanks! I can do it now, if you release a new version. TASK DETAIL https://phabricator.wikimedia.org/T235326 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Ladsgroup, Lucas_Werkmeister_WMDE, thiemowmde, Aklapper, Daimona, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T243296: Release a new version of WikibaseCodeSniffer
Daimona added subscribers: Ladsgroup, Daimona. Daimona added a comment. CC @Ladsgroup as releaser of the last two versions and (AFAICS) most active maintainer. TASK DETAIL https://phabricator.wikimedia.org/T243296 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Daimona, Ladsgroup, Jdforrester-WMF, Aklapper, MaxSem, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Lethexie, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, thiemowmde, Mbch331, Jay8g, Legoktm ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T243296: Release a new version of WikibaseCodeSniffer
Daimona added a comment. In T243296#5821602 <https://phabricator.wikimedia.org/T243296#5821602>, @Legoktm wrote: > I think we could ship it inside the MediaWiki-Codesniffer repo so it doesn't fall behind at least. I think this is a great idea to get started with. I guess the plan would be to: - Export WB sniffs to MW-CS (the ones that we want to keep) - Move the WB ruleset to MW-CS - Archive the WB-CS repo - For each repo using WB-CS: - composer: remove WB-CS, add MW-CS - .phpcs.xml: load the WB ruleset from the new location TASK DETAIL https://phabricator.wikimedia.org/T243296 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Legoktm, thiemowmde, WMDE-leszek, Lucas_Werkmeister_WMDE, Daimona, Ladsgroup, Jdforrester-WMF, Aklapper, MaxSem, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Lethexie, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T243296: Release a new version of WikibaseCodeSniffer
Daimona added a comment. Not if we move the main ruleset file per T243296#5826268 <https://phabricator.wikimedia.org/T243296#5826268>. And, of course, unless it turns out to be impossible to have two different rulesets in MW-CS. TASK DETAIL https://phabricator.wikimedia.org/T243296 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Legoktm, thiemowmde, WMDE-leszek, Lucas_Werkmeister_WMDE, Daimona, Ladsgroup, Jdforrester-WMF, Aklapper, MaxSem, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Lethexie, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T243296: Release a new version of WikibaseCodeSniffer
Daimona added a comment. In T243296#5826260 <https://phabricator.wikimedia.org/T243296#5826260>, @Lucas_Werkmeister_WMDE wrote: > (Unless “Move the WB ruleset to MW-CS” includes disabling those rules for all of MW-CS?) Sort of, yes. I believe it's possible to have two different rulesets, and choose which one to use. WB repos would still point to the same ruleset, just at another location. TASK DETAIL https://phabricator.wikimedia.org/T243296 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Legoktm, thiemowmde, WMDE-leszek, Lucas_Werkmeister_WMDE, Daimona, Ladsgroup, Jdforrester-WMF, Aklapper, MaxSem, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Lethexie, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8
Daimona added a comment. In T237164#5827203 <https://phabricator.wikimedia.org/T237164#5827203>, @Jdforrester-WMF wrote: > Is this going anywhere, or are we just going to leave it disabled forever? I guess it's going to sit in the bitrot limbo until a new version is released upstream. Which, in turn, seems implausible, judging from the last commit dates and the open issues/PRs. TASK DETAIL https://phabricator.wikimedia.org/T237164 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Daimona, Jdforrester-WMF, Ladsgroup, thiemowmde, Aklapper, MaxSem, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T243296: Release a new version of WikibaseCodeSniffer
Daimona added a comment. In T243296#5829712 <https://phabricator.wikimedia.org/T243296#5829712>, @Addshore wrote: > I'm going to go around and update this in various places that it is used. I can help with review. > Also going forward we will consider if we even want this seperate library or if this should be merged into the mediawiki bit Note that there might be two separate discussions: 1-whether we want a separate *repository*, 2-whether we want a separate *ruleset*. We can merge the repositories while keeping a standalone config for WB, which IMHO requires less discussion and is a good idea to make it happen. TASK DETAIL https://phabricator.wikimedia.org/T243296 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore, Daimona Cc: Addshore, Legoktm, thiemowmde, WMDE-leszek, Lucas_Werkmeister_WMDE, Daimona, Ladsgroup, Jdforrester-WMF, Aklapper, MaxSem, Iflorez, darthmon_wmde, alaa_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Lethexie, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T245629: mediawiki/core webdriver.io tests fail in EntitySchema extension
Daimona added a comment. That change is not responsible, but the extension is broken: https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-docker/47112/artifact/log/mw-error.log TASK DETAIL https://phabricator.wikimedia.org/T245629 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Daimona, Aklapper, Lucas_Werkmeister_WMDE, darthmon_wmde, pdehaye, Nandana, Lahi, Gq86, Andrawaag, GoranSMilovanovic, QZanden, YULdigitalpreservation, LawExplorer, Salgo60, _jensen, rosalieper, Scott_WUaS, MisterSynergy, abian, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8
Daimona added a comment. In T237164#5896034 <https://phabricator.wikimedia.org/T237164#5896034>, @Addshore wrote: > It looks like that was removed in https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/552166/ but not linked to this ticket. Ah, thanks, I forgot about that step. > And then this starts becoming messier +1 > I'd propose we also restore this require-dev in the core composer.json for now pinned to the same version as in Wikibase, essentially restoring the way things were. And +1, let's restore the status quo. TASK DETAIL https://phabricator.wikimedia.org/T237164 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Rosalie_WMDE, Daimona Cc: Rosalie_WMDE, Addshore, Daimona, Jdforrester-WMF, Ladsgroup, thiemowmde, Aklapper, MaxSem, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Iflorez, darthmon_wmde, alaa_wmde, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8
Daimona added a comment. For some reason, cache/integration-tests is not being installed, see https://integration.wikimedia.org/ci/job/wikibase-repo-docker/11815/console. This used to work before the test was disabled. Also, the library is currently broken: its public interface is using symfony/phpunit-bridge, but it's listed in `require-dev` instead of `require`, see https://github.com/php-cache/integration-tests/pull/107. I believe we had discussed this briefly on gerrit at the time, and agreed that disabling the test was the best solution for the time being. TASK DETAIL https://phabricator.wikimedia.org/T237164 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Rosalie_WMDE, Daimona Cc: Rosalie_WMDE, Addshore, Daimona, Jdforrester-WMF, Ladsgroup, thiemowmde, Aklapper, MaxSem, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Iflorez, darthmon_wmde, alaa_wmde, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T243122: Math master is currently broken due to a Wikibase change
Daimona created this task. Daimona added projects: Math, Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION As observed in r565622 <https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Math/+/565622/>, tests currently fail on Math because of: > PHP Fatal error: Declaration of MathMLRdfBuilder::addValue(Wikimedia\Purtle\RdfWriter $writer, $propertyValueNamespace, $propertyValueLName, $dataType, Wikibase\DataModel\Snak\PropertyValueSnak $snak) must be compatible with Wikibase\Rdf\ValueSnakRdfBuilder::addValue(Wikimedia\Purtle\RdfWriter $writer, $propertyValueNamespace, $propertyValueLName, $dataType, $snakNamespace, Wikibase\DataModel\Snak\PropertyValueSnak $snak) in /workspace/src/extensions/Math/src/MathMLRdfBuilder.php on line 7 This failure is clearly not spurious, and was caused by r533202 <https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/533202/> for Wikibase. I'm unsure what the fix is [1], but either way, this needs to be fixed before the next train. [1] - Maybe just adding that extra parameter would suffice, but I'm no confident enough with Wikibase to know if that's true. TASK DETAIL https://phabricator.wikimedia.org/T243122 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Aklapper, Daimona, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, Maosef, QZanden, LawExplorer, Debenben, _jensen, rosalieper, Scott_WUaS, Izno, Wikidata-bugs, aude, fredw, Physikerwelt, Pkra, scfc, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T243122: Math master is currently broken due to a Wikibase change
Daimona added a parent task: T233864: 1.35.0-wmf.16 deployment blockers. TASK DETAIL https://phabricator.wikimedia.org/T243122 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Aklapper, Daimona, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, Maosef, QZanden, LawExplorer, Debenben, _jensen, rosalieper, Scott_WUaS, Izno, Wikidata-bugs, aude, fredw, Physikerwelt, Pkra, scfc, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T243124: Class "Wikibase\Lib\Store\EntityTitleLookup" does not exist.
Daimona added a project: MediaWiki-extensions-PropertySuggester. TASK DETAIL https://phabricator.wikimedia.org/T243124 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Aklapper, Reedy, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Sjoerddebruin, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Raised Priority] T243122: Math master is currently broken due to a Wikibase change
Daimona raised the priority of this task from "Medium" to "Unbreak Now!". Daimona added a comment. In T243122#5814763 <https://phabricator.wikimedia.org/T243122#5814763>, @Physikerwelt wrote: > I think this is not ubn. Why not disable the test? Because it's not a faulty test: there's a signature mismatch, and it will produce a PHP warning (at least) as soon as the file is loaded. I believe this is enough to qualify as train blocker, hence ubn. TASK DETAIL https://phabricator.wikimedia.org/T243122 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Physikerwelt, Liuxinyu970226, RhinosF1, Reedy, Aklapper, Daimona, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Maosef, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, Debenben, _jensen, rosalieper, Scott_WUaS, Izno, Wikidata-bugs, aude, fredw, Pkra, scfc, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T241947: Stop using $wgUser in Wikibase
Daimona added a comment. In T241947#5802562 <https://phabricator.wikimedia.org/T241947#5802562>, @Addshore wrote: > In T241947#5776623 <https://phabricator.wikimedia.org/T241947#5776623>, @Daimona wrote: > >> Note: there are two usages in the entry point which I'm unsure how to fix. > > I guess they could come from "Context". > I don't obviously see anything else in core that could be used at this second. > Which would mean something like: > > RequestContext::getMain()->getUser() > > In place of the global Yeah, that's also the only alternative I can think of, given how early the entry point is executed. Given that RequestContext::getMain is almost the same as $wgUser, I'd suggest waiting; in case some new code introduces an alternative... TASK DETAIL https://phabricator.wikimedia.org/T241947 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Addshore, Daimona, Aklapper, Chaytanya, darthmon_wmde, DannyS712, Nandana, Kieubinhtb, Guilhermebm, Mh-3110, Amorymeltzer, Asad_Ali_Palijo, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, RazeSoldier, Jayprakash12345, JakeTheDeveloper, QZanden, LawExplorer, _jensen, rosalieper, D3r1ck01, Scott_WUaS, Jonas, MuhammadShuaib, Izno, MGChecker, Tmalhotra, SimmeD, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T241947: Stop using $wgUser in Wikibase
Daimona added a comment. In T241947#5802594 <https://phabricator.wikimedia.org/T241947#5802594>, @Addshore wrote: > Well, RequestContext::getMain is slightly less evil that the global probably. Yeah, well, a little bit... I believe the only difference is that, when using RequestContext, any piece of code writing to $wgUser and RequestContext::getMain only has to write to the latter. Aside from this, they're the same thing <https://gerrit.wikimedia.org/g/mediawiki/core/+/0ff789715c7e9d4a560bf26242072ad4cb2aea10/includes/Setup.php#837>. > So I'd go for lets just make that patch and hen resolve this task for now :) > If someone wants to get rid of RequestContext::getMain then that is a whole different kettle of fish to tackle later down the line. Sure :) In places where a User object can be injected, I believe that it's not worth it to use RequestContext::getMain now, and replace it with proper DI later. But, where there's no clear way to inject a User, I think RequestContext::getMain is acceptable. TASK DETAIL https://phabricator.wikimedia.org/T241947 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Addshore, Daimona, Aklapper, Chaytanya, darthmon_wmde, DannyS712, Nandana, Kieubinhtb, Guilhermebm, Mh-3110, Amorymeltzer, Asad_Ali_Palijo, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, RazeSoldier, Jayprakash12345, JakeTheDeveloper, QZanden, LawExplorer, _jensen, rosalieper, D3r1ck01, Scott_WUaS, Jonas, MuhammadShuaib, Izno, MGChecker, Tmalhotra, SimmeD, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T240884: Standalone service to evaluate user-provided regular expressions
Daimona added a comment. In T240884#5810160 <https://phabricator.wikimedia.org/T240884#5810160>, @sbassett wrote: > In T240884#5810094 <https://phabricator.wikimedia.org/T240884#5810094>, @Ladsgroup wrote: > >> One complicating factor here is that AbuseFilter and SpamBlacklist both don't have a clear maintainer. > > I think @Daimona is understood to be the de facto AF maintainer these days (trusted dev, wmf-NDA, etc.) and is pretty active <https://gerrit.wikimedia.org/r/q/project:mediawiki%252Fextensions%252FAbuseFilter> in its current development. So, I'm going to answer for myself. I think a re2-like solution would indeed improve performance [1] for regexps-related extensions. AbuseFilter and SpamBlacklist for sure, but also TitleBlacklist, and CentralAuth as of T101615 <https://phabricator.wikimedia.org/T101615>. Given the number of possible consumers, I believe that a reusable service would be the best choice. Of note, there's also T187669 <https://phabricator.wikimedia.org/T187669> about adding a static ReDoS validator, in case you want to explore it as an alternative. [1] - About AbuseFilter performance, some numbers are on grafana <https://grafana.wikimedia.org/d/00393/mediawiki-abusefilter-profiling?orgId=1>, and there's also a dashboard <https://logstash.wikimedia.org/app/kibana#/dashboard/941a0560-b9b2-11e7-a3f7-cb9288bcae84?_g=h@1251ff0&_a=h@cf77ba6> on logstash, although regexps aren't the only responsible for slowness. TASK DETAIL https://phabricator.wikimedia.org/T240884 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Daimona, daniel, tstarling, Bawolff, Joe, WMDE-leszek, Volans, sbassett, Krinkle, Agabi10, Lucas_Werkmeister_WMDE, Addshore, Aklapper, Ladsgroup, darthmon_wmde, DannyS712, Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, RazeSoldier, QZanden, LawExplorer, _jensen, rosalieper, D3r1ck01, Scott_WUaS, Izno, SBisson, Perhelion, Wikidata-bugs, Base, aude, GWicke, jayvdb, fbstj, santhosh, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Ltrlg, bd808, Legoktm ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T241947: Stop using $wgUser in Wikibase
Daimona added a comment. Note: there are two usages in the entry point which I'm unsure how to fix. TASK DETAIL https://phabricator.wikimedia.org/T241947 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Daimona, Aklapper, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Amorymeltzer, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Izno, MGChecker, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T241947: Stop using $wgUser in Wikibase
Daimona created this task. Daimona added projects: Technical-Debt (Deprecation process), MediaWiki-extensions-WikibaseRepository. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION TASK DETAIL https://phabricator.wikimedia.org/T241947 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Daimona, Aklapper, darthmon_wmde, DannyS712, Nandana, Amorymeltzer, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Izno, MGChecker, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T247595: Make Wikibase compatible with PHP 7.4
Daimona added a comment. Now it should be compatible. Can we enable PHP74 tests as voting? TASK DETAIL https://phabricator.wikimedia.org/T247595 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Daimona, Aklapper, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Nikerabbit, MaxSem, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T247670: PHPUnit warning noise from ClientParserOutputDataUpdaterTest (Wikibase)
Daimona added a comment. It doesn't seem a recent regression, see https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Wikibase/+blame/de5e309c258b121bf0626728d8d9a6fd2ab0c717/client/tests/phpunit/includes/ClientParserOutputDataUpdaterTest.php#170 The fix should be as easy as doing what PHPUnit suggest. TASK DETAIL https://phabricator.wikimedia.org/T247670 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Daimona, Aklapper, Krinkle, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T250570: AFPException when saving filter on wikidata: Refusing to cast DUNDEFINED to something else
Daimona added a comment. I think explicit casts aren't special-cased in the DUNDEFINED check, should be an easy fix TASK DETAIL https://phabricator.wikimedia.org/T250570 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Daimona, DannyS712, Aklapper, darthmon_wmde, 94rain, Nandana, Lahi, Gq86, Pablo-WMDE, GoranSMilovanovic, ihojose, QZanden, LawExplorer, Litanwei, JJMC89, _jensen, rosalieper, Scott_WUaS, Wong128hk, Nirmos, Wikidata-bugs, aude, Nullzero, Huji, Jdforrester-WMF, Jackmcbarn, Mbch331, Rxy, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T250570: AFPException when saving filter on wikidata: Refusing to cast DUNDEFINED to something else
Daimona added a comment. Or actually, I think it's because checking `getType() == UNDEFINED` (at least in callKeyword and callFunc, perhaps elsewhere) doesn't work well for arrays (it doesn't recurse). Adding AFPData::hasUndefined() as a recursive method would be the solution. TASK DETAIL https://phabricator.wikimedia.org/T250570 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Daimona, DannyS712, Aklapper, darthmon_wmde, 94rain, Nandana, Lahi, Gq86, Pablo-WMDE, GoranSMilovanovic, ihojose, QZanden, LawExplorer, Litanwei, JJMC89, _jensen, rosalieper, Scott_WUaS, Wong128hk, Nirmos, Wikidata-bugs, aude, Nullzero, Huji, Jdforrester-WMF, Jackmcbarn, Mbch331, Rxy, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Retitled] T250570: AFPException when saving filter on wikidata: Refusing to cast DUNDEFINED to something else
Daimona renamed this task from "AFPException when saving filter on wikidata" to "AFPException when saving filter on wikidata: Refusing to cast DUNDEFINED to something else". Daimona updated the task description. Daimona edited Stack Trace. TASK DETAIL https://phabricator.wikimedia.org/T250570 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Daimona, DannyS712, Aklapper, darthmon_wmde, 94rain, Nandana, Lahi, Gq86, Pablo-WMDE, GoranSMilovanovic, ihojose, QZanden, LawExplorer, Litanwei, JJMC89, _jensen, rosalieper, Scott_WUaS, Wong128hk, Nirmos, Wikidata-bugs, aude, Nullzero, Huji, Jdforrester-WMF, Jackmcbarn, Mbch331, Rxy, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T250720: Wikidata edit filter does not fire when test tool says it should
Daimona added a comment. Haven't checked deeply, but a possible hint is that AF doesn't see automatic edit summaries (I think there was a task for that) which, however, it sees when retrospectively examinating edits. TASK DETAIL https://phabricator.wikimedia.org/T250720 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Daimona, Aklapper, Bovlb, darthmon_wmde, 94rain, Nandana, Lahi, Gq86, GoranSMilovanovic, ihojose, QZanden, LawExplorer, Litanwei, JJMC89, _jensen, rosalieper, Scott_WUaS, Wong128hk, Nirmos, Wikidata-bugs, aude, Nullzero, Huji, Jackmcbarn, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Claimed] T250570: AFPException when saving filter on wikidata: Refusing to cast DUNDEFINED to something else
Daimona claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T250570 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: matej_suchanek, Daimona, DannyS712, Aklapper, Blissjay007, Oblanco79, Alter-paule, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Kent7301, Meekrab2012, joker88john, 94rain, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, Pablo-WMDE, GoranSMilovanovic, Adik2382, ihojose, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Litanwei, WSH1906, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Scott_WUaS, Wong128hk, Nirmos, Wikidata-bugs, aude, Nullzero, Huji, Jdforrester-WMF, Jackmcbarn, Mbch331, Rxy, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T250570: AFPException when saving filter on wikidata: Refusing to cast DUNDEFINED to something else
Daimona closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T250570 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: matej_suchanek, Daimona, DannyS712, Aklapper, darthmon_wmde, 94rain, Nandana, Lahi, Gq86, GoranSMilovanovic, ihojose, QZanden, LawExplorer, Litanwei, JJMC89, _jensen, rosalieper, Scott_WUaS, Wong128hk, Nirmos, Wikidata-bugs, aude, Nullzero, Huji, Jdforrester-WMF, Jackmcbarn, Mbch331, Rxy, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T250720: Wikidata edit filter does not fire when test tool says it should
Daimona added a comment. In T250720#6073559 <https://phabricator.wikimedia.org/T250720#6073559>, @Ahmad252 wrote: > In T250720#6072828 <https://phabricator.wikimedia.org/T250720#6072828>, @Daimona wrote: > >> Haven't checked deeply, but a possible hint is that AF doesn't see automatic edit summaries (I think there was a task for that) which, however, it sees when retrospectively examinating edits. > > But still, the edit summary it sees (the *real* summary) is something like `/* undo:0||REVID|USERNAME */`. It depends on how you define "real". I have to say, I'm not at all certain about the summary that the filter is effectively seeing, so... I don't even know where the 'undo:0 ...' part is coming from in Wikibase, so I can't tell whether it can be read by the AF. In T250720#6074608 <https://phabricator.wikimedia.org/T250720#6074608>, @matej_suchanek wrote: > For testing, I re-used blank https://www.wikidata.org/wiki/Special:AbuseFilter/31 with > > 'undo:0' in summary > > During the test, there were at least 9 undo actions (tagged as `mw-undo`, example <https://www.wikidata.org/w/index.php?title=Q1659640=1593296=1162557029=1161698093>) but none of them triggered the filter. So @Daimona may be right... Not surprising... I'd be glad to confirm this and investigate it locally, but I don't have Wikibase installed on my wiki, and it's also not so easy to install IIRC (also I'm not practical with it). TASK DETAIL https://phabricator.wikimedia.org/T250720 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: matej_suchanek, Ahmad252, Daimona, Aklapper, Bovlb, darthmon_wmde, 94rain, Nandana, Lahi, Gq86, GoranSMilovanovic, ihojose, QZanden, LawExplorer, Litanwei, JJMC89, _jensen, rosalieper, Scott_WUaS, Wong128hk, Nirmos, Wikidata-bugs, aude, Nullzero, Huji, Jackmcbarn, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T250570: AFPException when saving filter on wikidata: Refusing to cast DUNDEFINED to something else
Daimona added a comment. In T250570#6068356 <https://phabricator.wikimedia.org/T250570#6068356>, @Daimona wrote: > Or actually, I think it's because checking `getType() == UNDEFINED` (at least in callKeyword and callFunc, perhaps elsewhere) doesn't work well for arrays (it doesn't recurse). Yeah, this one. MWE: `'x' in [ user_name ]` TASK DETAIL https://phabricator.wikimedia.org/T250570 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Daimona, DannyS712, Aklapper, darthmon_wmde, 94rain, Nandana, Lahi, Gq86, Pablo-WMDE, GoranSMilovanovic, ihojose, QZanden, LawExplorer, Litanwei, JJMC89, _jensen, rosalieper, Scott_WUaS, Wong128hk, Nirmos, Wikidata-bugs, aude, Nullzero, Huji, Jdforrester-WMF, Jackmcbarn, Mbch331, Rxy, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T243590: Fix WikibaseDataModel CI for php 7.4
Daimona added a comment. In T243590#5962809 <https://phabricator.wikimedia.org/T243590#5962809>, @Jdforrester-WMF wrote: > Is this the same set of issues that emit errors in the CI run? Apparently, no. Filed T247595 <https://phabricator.wikimedia.org/T247595> for that. TASK DETAIL https://phabricator.wikimedia.org/T243590 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Daimona, Jdforrester-WMF, srishakatux, Reedy, Addshore, Aklapper, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Nikerabbit, MaxSem, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T247595: Make Wikibase compatible with PHP 7.4
Daimona created this task.
Daimona added projects: PHP 7.4 support, Wikidata.
Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION
From T243590#5962809 <https://phabricator.wikimedia.org/T243590#5962809>:
00:18:23.529 There were 3 errors:
00:18:23.529
00:18:23.529 1)
Wikibase\Client\Tests\Api\ApiPropsEntityUsageTest::testEntityUsage with data
set "by title" (array('query', 'entityusage', 'Vienna11|Berlin22'),
array(array(array(array(array('O', 'S', array(array(array(array('S')),
array(array('S'))
00:18:23.529 === Logs generated by test case
00:18:23.529 [localisation] [debug] LocalisationCache using store
LCStoreNull []
00:18:23.529 [localisation] [debug] LocalisationCache using store
LCStoreNull []
00:18:23.529 [MessageCache] [debug] MessageCache using store {class}
{"class":"HashBagOStuff"}
00:18:23.529 [objectcache] [debug] MainWANObjectCache using store {class}
{"class":"EmptyBagOStuff"}
00:18:23.529 ===
00:18:23.529 Trying to access array offset on value of type null
00:18:23.529
00:18:23.529 /workspace/src/includes/api/ApiPageSet.php:127
00:18:23.529
/workspace/src/extensions/Wikibase/client/tests/phpunit/includes/Api/ApiPropsEntityUsageTest.php:117
00:18:23.529
/workspace/src/extensions/Wikibase/client/tests/phpunit/includes/Api/ApiPropsEntityUsageTest.php:164
00:18:23.529
/workspace/src/extensions/Wikibase/client/tests/phpunit/includes/Api/ApiPropsEntityUsageTest.php:226
00:18:23.529
/workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
00:18:23.529 /workspace/src/maintenance/doMaintenance.php:99
00:18:23.529
00:18:23.529 2)
Wikibase\Client\Tests\Api\ApiPropsEntityUsageTest::testEntityUsage with data
set "by entity" (array('query', 'entityusage', 'Vienna11|Berlin22', 'Q3|Q4'),
array(array(array(array(array('O', 'S', array(array(array(array('S')),
array(array('S'))
00:18:23.529 === Logs generated by test case
00:18:23.529 [objectcache] [debug] MainWANObjectCache using store {class}
{"class":"EmptyBagOStuff"}
00:18:23.529 [localisation] [debug] LocalisationCache using store
LCStoreNull []
00:18:23.529 [localisation] [debug] LocalisationCache using store
LCStoreNull []
00:18:23.529 [MessageCache] [debug] MessageCache using store {class}
{"class":"HashBagOStuff"}
00:18:23.529 [objectcache] [debug] MainWANObjectCache using store {class}
{"class":"EmptyBagOStuff"}
00:18:23.529 ===
00:18:23.529 Trying to access array offset on value of type null
00:18:23.529
00:18:23.529 /workspace/src/includes/api/ApiPageSet.php:127
00:18:23.529
/workspace/src/extensions/Wikibase/client/tests/phpunit/includes/Api/ApiPropsEntityUsageTest.php:117
00:18:23.529
/workspace/src/extensions/Wikibase/client/tests/phpunit/includes/Api/ApiPropsEntityUsageTest.php:164
00:18:23.529
/workspace/src/extensions/Wikibase/client/tests/phpunit/includes/Api/ApiPropsEntityUsageTest.php:226
00:18:23.529
/workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
00:18:23.529 /workspace/src/maintenance/doMaintenance.php:99
00:18:23.529
00:18:23.529 3)
Wikibase\Client\Tests\Changes\ChangeRunCoalescerTest::testCoalesceChanges with
data set "local link breaks" (array(Wikibase\Lib\Changes\ItemChange Object
(...), Wikibase\Lib\Changes\ItemChange Object (...)),
array(Wikibase\Lib\Changes\ItemChange Object (...),
Wikibase\Lib\Changes\ItemChange Object (...)))
00:18:23.529 === Logs generated by test case
00:18:23.529 [objectcache] [debug] MainWANObjectCache using store {class}
{"class":"EmptyBagOStuff"}
00:18:23.529 ===
00:18:23.529
Wikibase\Client\Changes\ChangeRunCoalescer::coalesceRuns:array_key_exists():
Using array_key_exists() on objects is deprecated. Use isset() or
property_exists() instead [Called from
Wikibase\Client\Changes\ChangeRunCoalescer::coalesceRuns in
/workspace/src/extensions/Wikibase/client/includes/Changes/ChangeRunCoalescer.php
at line 287]
00:18:23.529
00:18:23.529 /workspace/src/includes/debug/MWDebug.php:333
00:18:23.529 /workspace/src/includes/debug/MWDebug.php:188
00:18:23.529 /workspace/src/includes/GlobalFunctions.php:1068
00:18:23.529
/workspace/src/extensions/Wikibase/client/includes/Changes/ChangeRunCoalescer.php:287
00:18:23.529
/workspace/src/extensions/Wikibase/client/includes/Changes/ChangeRunCoalescer.php:80
00:18:23.529
/workspace/src/extensions/Wikibase/client/tests/phpunit/includes/Changes/ChangeRunCoalescerTest.php:386
00:18:23.529
/workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
00:18:23.529 /workspace/src/maintenance/doMaintenance.php:99
TASK DETAIL
https://phabricator.wikimedia.org/T247595
EMAIL PREFERENCES
https://phabricator.wik
[Wikidata-bugs] [Maniphest] [Commented On] T247782: WikibaseLexeme CI broken due to Title constructor being private
Daimona added a comment. Meh, I thought these test-only errors would have been spotted by the wmf-gate jobs. Sorry for the breakage :( TASK DETAIL https://phabricator.wikimedia.org/T247782 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Lucas_Werkmeister_WMDE, Daimona, Alter-paule, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T247806: Make WikibaseLexeme compatible with PHP 7.4
Daimona added a comment. Not because of PHP 7.4 :-[ TASK DETAIL https://phabricator.wikimedia.org/T247806 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Daimona, Reedy, Aklapper, Jdforrester-WMF, darthmon_wmde, Nandana, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Nikerabbit, MaxSem, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Merged] T247782: WikibaseLexeme CI broken due to Title constructor being private
Daimona merged a task: T247806: Make WikibaseLexeme compatible with PHP 7.4. Daimona added subscribers: Jdforrester-WMF, Reedy, Aklapper. TASK DETAIL https://phabricator.wikimedia.org/T247782 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Aklapper, Reedy, Jdforrester-WMF, WMDE-leszek, Lucas_Werkmeister_WMDE, Daimona, Alter-paule, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T247806: Make WikibaseLexeme compatible with PHP 7.4
Daimona closed this task as a duplicate of T247782: WikibaseLexeme CI broken due to Title constructor being private. TASK DETAIL https://phabricator.wikimedia.org/T247806 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Reedy, Aklapper, Jdforrester-WMF, darthmon_wmde, Nandana, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Nikerabbit, MaxSem, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T105325: [Bug] edit_diff_pst variable is broken on Wikidata
Daimona added a project: TestMe. Daimona added a comment. Based on a couple random edits on wikidata, this seems to be working correctly now. Leaving open for confirmation. If it's still broken, this task can be considered for the upcoming overhaul. TASK DETAIL https://phabricator.wikimedia.org/T105325 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Daimona, hoo, Addshore, Aklapper, Luke081515, matej_suchanek, Akuckartz, darthmon_wmde, 94rain, Nandana, Lahi, Gq86, GoranSMilovanovic, ihojose, QZanden, LawExplorer, Litanwei, JJMC89, TerraCodes, _jensen, rosalieper, Scott_WUaS, Wong128hk, Nirmos, Wikidata-bugs, aude, Nullzero, Huji, Billinghurst, Jackmcbarn, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T264841: Flaky selenium test: WikibaseReferenceOnProtectedPage
Daimona created this task.
Daimona added projects: MediaWiki-extensions-WikibaseClient, ci-test-error
(WMF-deployed Build Failure).
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: Wikidata.
TASK DESCRIPTION
Recently I've been consistently facing a flaky selenium test from
Wikibase/client/data-bridge, which is making the build fail on other repos.
I've spotted this error roughly 5 times in the last week, for AbuseFilter
patches. Recent example
<https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php72-docker/62784/console>:
01:24:19 [chrome 73.0.3683.75 Linux #0-3] Spec:
/workspace/src/extensions/Wikibase/repo/tests/selenium/specs/readmode.references.js
01:24:19 [chrome 73.0.3683.75 Linux #0-3] Running: chrome (v73.0.3683.75)
on Linux
01:24:19 [chrome 73.0.3683.75 Linux #0-3] Session ID:
f78ee0e565857c3801d9ec06375be73c
01:24:19 [chrome 73.0.3683.75 Linux #0-3]
01:24:19 [chrome 73.0.3683.75 Linux #0-3] WikibaseReferenceOnProtectedPage
01:24:19 [chrome 73.0.3683.75 Linux #0-3]✖ can expand collapsed
references on a protected page as unprivileged user
01:24:19 [chrome 73.0.3683.75 Linux #0-3]
01:24:19 [chrome 73.0.3683.75 Linux #0-3] 1 failing (28.1s)
01:24:19 [chrome 73.0.3683.75 Linux #0-3]
01:24:19 [chrome 73.0.3683.75 Linux #0-3] 1)
WikibaseReferenceOnProtectedPage can expand collapsed references on a protected
page as unprivileged user
01:24:19 [chrome 73.0.3683.75 Linux #0-3] element
(".wikibase-statementview-references-container
.wikibase-statementview-references-heading a.ui-toggler") still not displayed
after 1ms
01:24:19 [chrome 73.0.3683.75 Linux #0-3] Error: element
(".wikibase-statementview-references-container
.wikibase-statementview-references-heading a.ui-toggler") still not displayed
after 1ms
01:24:19 [chrome 73.0.3683.75 Linux #0-3] at Context.
(/workspace/src/extensions/Wikibase/repo/tests/selenium/specs/readmode.references.js:19:111)
and the screenshot
<https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php72-docker/62784/artifact/log/can-expand-collapsed-references-on-a-protected-page-as-unprivileged-user.png>
doesn't seem to show anything suspicious.
TASK DETAIL
https://phabricator.wikimedia.org/T264841
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Daimona
Cc: Aklapper, Daimona, Akuckartz, darthmon_wmde, DannyS712, Nandana, lucamauri,
Lahi, Gq86, Pablo-WMDE, GoranSMilovanovic, QZanden, LawExplorer, _jensen,
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T264841: Flaky selenium test: WikibaseReferenceOnProtectedPage
Daimona triaged this task as "High" priority. Daimona added a comment. I'm seeing this error more and more, e.g. today on r629233 <https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AbuseFilter/+/629233>. I'm unsure about the status for other gated extensions, but it's quite annoying. Could someone please take a look? TASK DETAIL https://phabricator.wikimedia.org/T264841 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Aklapper, Daimona, Akuckartz, darthmon_wmde, DannyS712, Nandana, lucamauri, Lahi, Gq86, Pablo-WMDE, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
