[Wikidata-bugs] [Maniphest] [Commented On] T204791: Wikibase critical error "Failed to format entity ID. Cache key contains characters that are not allowed"

[Krinkle]

Krinkle added a comment.
This is the first time I've seen a log error in MediaWiki with severity CRITICAL. Given that this issue has been around for over 30 days and that the urls it applies to  all seem to render fine, this is probably incorrect use of this severity.TASK DETAILhttps://phabricator.wikimedia.org/T204791EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Aklapper, Krinkle, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Created] T204791: Wikibase critical error "Failed to format entity ID. Cache key contains characters that are not allowed"

[Krinkle]

Krinkle created this task.Krinkle added projects: Wikimedia-production-error, Wikidata, MediaWiki-extensions-WikibaseRepository.Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTIONError

Request ID: W6GY@QrAIEAAAIfoQdwO 

messageFailed to format entity ID. Using fallback formatter.

Error: Cache key contains characters that are not allowed

stacktrace#0 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Wikibase/lib/includes/SimpleCacheWithBagOStuff.php(262): Wikibase\Lib\SimpleCacheWithBagOStuff->invalidArgument(string)
#1 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Wikibase/lib/includes/SimpleCacheWithBagOStuff.php(67): Wikibase\Lib\SimpleCacheWithBagOStuff->assertKeyIsValid(string)
#2 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Wikibase/lib/includes/Store/CachingFallbackLabelDescriptionLookup.php(121): Wikibase\Lib\SimpleCacheWithBagOStuff->get(string, string)
#3 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Wikibase/lib/includes/Store/CachingFallbackLabelDescriptionLookup.php(107): Wikibase\Lib\Store\CachingFallbackLabelDescriptionLookup->getTerm(Wikibase\DataModel\Entity\ItemId, string, string)
#4 /srv/mediawiki/php-1.32.0-wmf.20/vendor/wikibase/data-model-services/src/EntityId/EntityIdLabelFormatter.php(53): Wikibase\Lib\Store\CachingFallbackLabelDescriptionLookup->getLabel(Wikibase\DataModel\Entity\ItemId)
#5 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Wikibase/lib/includes/Formatters/ItemIdHtmlLinkFormatter.php(65): Wikibase\DataModel\Services\EntityId\EntityIdLabelFormatter->lookupEntityLabel(Wikibase\DataModel\Entity\ItemId)
#6 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Wikibase/lib/includes/Formatters/ControlledFallbackEntityIdFormatter.php(76): Wikibase\Lib\Formatters\ItemIdHtmlLinkFormatter->formatEntityId(Wikibase\DataModel\Entity\ItemId)
#7 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Wikibase/lib/includes/Formatters/EntityIdValueFormatter.php(44): Wikibase\Lib\Formatters\ControlledFallbackEntityIdFormatter->formatEntityId(Wikibase\DataModel\Entity\ItemId)
#8 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Wikibase/lib/includes/Formatters/DispatchingValueFormatter.php(75): Wikibase\Lib\EntityIdValueFormatter->format(Wikibase\DataModel\Entity\EntityIdValue)
#9 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Wikibase/lib/includes/Formatters/PropertyValueSnakFormatter.php(148): Wikibase\Lib\Formatters\DispatchingValueFormatter->formatValue(Wikibase\DataModel\Entity\EntityIdValue, string)
#10 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Wikibase/lib/includes/Formatters/PropertyValueSnakFormatter.php(117): Wikibase\Lib\PropertyValueSnakFormatter->formatValue(Wikibase\DataModel\Entity\EntityIdValue, string)
#11 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Wikibase/lib/includes/Formatters/DispatchingSnakFormatter.php(151): Wikibase\Lib\PropertyValueSnakFormatter->formatSnak(Wikibase\DataModel\Snak\PropertyValueSnak)
#12 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Wikibase/lib/includes/Formatters/ErrorHandlingSnakFormatter.php(68): Wikibase\Lib\DispatchingSnakFormatter->formatSnak(Wikibase\DataModel\Snak\PropertyValueSnak)
#13 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Wikibase/view/src/SnakHtmlGenerator.php(129): Wikibase\Lib\Formatters\ErrorHandlingSnakFormatter->formatSnak(Wikibase\DataModel\Snak\PropertyValueSnak)
#14 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Wikibase/view/src/SnakHtmlGenerator.php(79): Wikibase\View\SnakHtmlGenerator->getFormattedSnakValue(Wikibase\DataModel\Snak\PropertyValueSnak)
#15 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Wikibase/view/src/StatementHtmlGenerator.php(181): Wikibase\View\SnakHtmlGenerator->getSnakHtml(Wikibase\DataModel\Snak\PropertyValueSnak, boolean)
#16 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Wikibase/view/src/StatementHtmlGenerator.php(161): Wikibase\View\StatementHtmlGenerator->getSnaklistviewHtml(array)
#17 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Wikibase/view/src/StatementHtmlGenerator.php(132): Wikibase\View\StatementHtmlGenerator->getHtmlForReference(Wikibase\DataModel\Reference)
#18 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Wikibase/view/src/StatementHtmlGenerator.php(88): Wikibase\View\StatementHtmlGenerator->getHtmlForReferences(Wikibase\DataModel\ReferenceList)
#19 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Wikibase/view/src/StatementGroupListView.php(154): Wikibase\View\StatementHtmlGenerator->getHtmlForStatement(Wikibase\DataModel\Statement\Statement, string)
#20 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Wikibase/view/src/StatementGroupListView.php(138): Wikibase\View\StatementGroupListView->getHtmlForStatementListView(array, string)
#21 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Wikibase/view/src/StatementGroupListView.php(71): Wikibase\View\StatementGroupListView->getHtmlForStatementGroupView(array)
#22 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Wikibase/view/src/StatementSectionsView.php(71): Wikibase\View\StatementGroupListView->getHtml(arr

[Wikidata-bugs] [Maniphest] [Edited] T204791: Wikibase critical error "Failed to format entity ID. Cache key contains characters that are not allowed"

[Krinkle]

Krinkle updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...This error was recorded 2,479 times in the last 30 days. With bursts on 4 September, 6 September and 19 September (today). Only on wikidata.org and test.wikidata.org, not others wikis. 

This is the first time I've seen a log error in MediaWiki with severity `CRITICAL`. Given that this issue has been around for over 30 days and that the urls it applies to seem to render fine, this is probably incorrect use of this severity. It should be noted that we try to take our logs seriously.

TASK DETAILhttps://phabricator.wikimedia.org/T204791EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Aklapper, Krinkle, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T144248: No RDF builder defined for data type time nor for value type bad in DispatchingValueSnakRdfBuilder::getValueBuilder

[Krinkle]

Krinkle added a comment.
Still seen. About 450 samples in the last 7 days. Recent sample:

[{exception_id}] {exception_url}   ErrorException from line 309 of /srv/mediawiki/php-1.32.0-wmf.20/includes/debug/MWDebug.php: PHP Warning: Wikibase\Rdf\DispatchingValueSnakRdfBuilder::getValueBuilder: No RDF builder defined for data type globe-coordinat

reqId: W5kWiApAIDEAAKI5PVCM
wiki: www.wikidata.org
url: /wiki/Special:EntityData/Q3629997.ttl?nocache=1536759432200=dump
http_method: GET

trace#3 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Wikibase/repo/includes/Rdf/DispatchingValueSnakRdfBuilder.php(75): wfLogWarning(string)
#4 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Wikibase/repo/includes/Rdf/DispatchingValueSnakRdfBuilder.php(50): Wikibase\Rdf\DispatchingValueSnakRdfBuilder->getValueBuilder(string, string)
#5 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Wikibase/repo/includes/Rdf/SnakRdfBuilder.php(132): Wikibase\Rdf\DispatchingValueSnakRdfBuilder->addValue(Wikimedia\Purtle\TurtleRdfWriter, string, string, string, Wikibase\DataModel\Snak\PropertyValueSnak)
#6 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Wikibase/repo/includes/Rdf/SnakRdfBuilder.php(83): Wikibase\Rdf\SnakRdfBuilder->addSnakValue(Wikimedia\Purtle\TurtleRdfWriter, Wikibase\DataModel\Snak\PropertyValueSnak, string)
#7 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Wikibase/repo/includes/Rdf/TruthyStatementRdfBuilder.php(91): Wikibase\Rdf\SnakRdfBuilder->addSnak(Wikimedia\Purtle\TurtleRdfWriter, Wikibase\DataModel\Snak\PropertyValueSnak, string)
#8 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Wikibase/repo/includes/Rdf/TruthyStatementRdfBuilder.php(63): Wikibase\Rdf\TruthyStatementRdfBuilder->addMainSnak(Wikibase\DataModel\Entity\ItemId, Wikibase\DataModel\Statement\Statement)
#9 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Wikibase/repo/includes/Rdf/TruthyStatementRdfBuilder.php(103): Wikibase\Rdf\TruthyStatementRdfBuilder->addStatements(Wikibase\DataModel\Entity\ItemId, Wikibase\DataModel\Statement\StatementList)
#10 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Wikibase/repo/includes/Rdf/RdfBuilder.php(400): Wikibase\Rdf\TruthyStatementRdfBuilder->addEntity(Wikibase\DataModel\Entity\Item)
#11 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Wikibase/repo/includes/LinkedData/EntityDataSerializationService.php(229): Wikibase\Rdf\RdfBuilder->addEntity(Wikibase\DataModel\Entity\Item)
#12 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Wikibase/repo/includes/LinkedData/EntityDataSerializationService.php(175): Wikibase\Repo\LinkedData\EntityDataSerializationService->rdfSerialize(Wikibase\Lib\Store\EntityRevision, NULL, array, Wikibase\Rdf\RdfBuilder, string)
#13 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Wikibase/repo/includes/LinkedData/EntityDataRequestHandler.php(453): Wikibase\Repo\LinkedData\EntityDataSerializationService->getSerializedData(string, Wikibase\Lib\Store\EntityRevision, NULL, array, string)
#14 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Wikibase/repo/includes/LinkedData/EntityDataRequestHandler.php(246): Wikibase\Repo\LinkedData\EntityDataRequestHandler->showData(WebRequest, OutputPage, string, Wikibase\DataModel\Entity\ItemId, integer)
#15 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Wikibase/repo/includes/Specials/SpecialEntityData.php(153): Wikibase\Repo\LinkedData\EntityDataRequestHandler->handleRequest(string, WebRequest, OutputPage)
#16 /srv/mediawiki/php-1.32.0-wmf.20/includes/specialpage/SpecialPage.php(569): Wikibase\Repo\Specials\SpecialEntityData->execute(string)
#17 /srv/mediawiki/php-1.32.0-wmf.20/includes/specialpage/SpecialPageFactory.php(581): SpecialPage->run(string)
#18 /srv/mediawiki/php-1.32.0-wmf.20/includes/MediaWiki.php(288): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#19 /srv/mediawiki/php-1.32.0-wmf.20/includes/MediaWiki.php(868): MediaWiki->performRequest()
#20 /srv/mediawiki/php-1.32.0-wmf.20/includes/MediaWiki.php(525): MediaWiki->main()
#21 /srv/mediawiki/php-1.32.0-wmf.20/index.php(42): MediaWiki->run()TASK DETAILhttps://phabricator.wikimedia.org/T144248EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, thiemowmde, Aklapper, Dereckson, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Changed Project Column] T122520: Error running `extensions/Wikibase/lib/maintenance/populateSitesTable.php --force-protocol https` on jbowiki

[Krinkle]

Krinkle moved this task from Production Impact to Regressed <= 1.32-wmf.19 on the Wikimedia-production-error board.Krinkle added a comment.
Still an issue?TASK DETAILhttps://phabricator.wikimedia.org/T122520WORKBOARDhttps://phabricator.wikimedia.org/project/board/1055/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, Stashbot, Reedy, hoo, Aklapper, Krenair, StudiesWorld, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Closed] T146069: "TypeError: undefined is not an object (evaluating 'mw.util.addPortletLink')" while opening item in new tab (on background) in Safari

[Krinkle]

Krinkle closed this task as "Resolved".Krinkle claimed this task.Krinkle added a comment.
mw.util.addPortletLink is a method of the mw.util singleton, which needs to be ensured by any code that uses it by declaring a deepndency on mediawiki.util.

When that is done, the system automatically makes sure that that is loaded before executing the rest of the code. This is working as intended.

I can not reproduce this in background tabs in Safari, Firefox or Chrome. If you see it again, please create a new task, and ideally with a "stack trace". You can find the stack trace by clicking the < triangle next to the error message. This will help us find which extension or which gadget is causing the problem.TASK DETAILhttps://phabricator.wikimedia.org/T146069EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, abian, Nikki, Sjoerddebruin, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T202764: Wikidata produces a lot of failed requests for recentchanges API

[Krinkle]

Krinkle added a comment.
@Marostegui So to confirm, recentchanges db hosts are the same within and between eqiad/codfw. But the api db hosts are different, right? Only api dbhosts in codfw have the two extra indexes. Is that right?

Also, are there differences between recentchanges db hosts and api db hosts?TASK DETAILhttps://phabricator.wikimedia.org/T202764EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Marostegui, Banyek, Reedy, gerritbot, Krinkle, Addshore, Yurik, jcrespo, Imarlier, Ladsgroup, Lydia_Pintscher, WMDE-leszek, Aklapper, Gehel, Smalyshev, AndyTan, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Davinaclare77, Adrian1985, Qtn1293, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Adik2382, Th3d3v1ls, Hfbn0, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Vali.matei, Lewizho99, Minhnv-2809, Zppix, Maathavan, Jonas, Xmlizer, Wong128hk, Luke081515, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, faidon, Mbch331, Jay8g, Krenair, fgiunchedi___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T203805: codesniffer detects unparenthesized ternary in mediawiki/core Article.php

[Krinkle]

Krinkle added subscribers: Tgr, Krinkle.Krinkle added a project: Structured-Data-Commons.Krinkle added a comment.Restricted Application added a project: Wikidata.
(Follows-up T174035)TASK DETAILhttps://phabricator.wikimedia.org/T203805EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, Tgr, daniel, Umherirrender, Aklapper, Phukettaxigroup, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, Jayprakash12345, QZanden, Tramullas, Acer, LawExplorer, Susannaanas, Aschroet, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T202764: Wikidata produces a lot of failed requests for recentchanges API

[Krinkle]

Krinkle added a comment.
Earlier when I was investigating with Stas, performing the slow recentchanges api request with X-Wikimedia-Debug: log shows the following in Logstash:

[DEBUG] [DBConnection] Wikimedia\Rdbms\LoadBalancer::getReaderIndex: using server db2080 for group 'api'

Which indeed shows that it is using a dbhost from the "api" group instead of the "rc" group.

The actual query:

[DEBUG] [DBQuery]

SELECT rc_id,rc_timestamp, rc_namespace,rc_title,rc_cur_id, rc_type,rc_deleted, rc_this_oldid,rc_last_oldid  FROM `recentchanges`WHERE (rc_timestamp>='2018091411') AND rc_namespace IN ('0','120')  AND rc_type IN ('0','1','3','6')   ORDER BY rc_timestamp ASC,rc_id ASC LIMIT 101

runtime: 27.811768054962 seconds

I do note that while I can reproduce maybe 8 of 10 times with the codfw mwdebug hosts, I could not on the eqiad mwdebug hosts.

Stas found the same when executing it from the command-line, that it is slow from mwmaint2001.codfw but normal from mwmaint1001.eqiad.

I haven't looked further, but I would assume that either means that in eqiad it is correctly picking the "rc" group, or that in eqiad the query is fast on dbhosts from the "api" group.TASK DETAILhttps://phabricator.wikimedia.org/T202764EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Reedy, gerritbot, Krinkle, Addshore, Yurik, jcrespo, Imarlier, Ladsgroup, Lydia_Pintscher, WMDE-leszek, Aklapper, Gehel, Smalyshev, AndyTan, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Davinaclare77, Adrian1985, Qtn1293, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Adik2382, Th3d3v1ls, Hfbn0, Ramalepe, Liugev6, QZanden, EBjune, Marostegui, merbst, LawExplorer, Vali.matei, Lewizho99, Minhnv-2809, Zppix, Maathavan, Jonas, Xmlizer, Wong128hk, Luke081515, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, faidon, Mbch331, Jay8g, Krenair, fgiunchedi___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Unassigned] T202764: Wikidata produces a lot of failed requests for recentchanges API

[Krinkle]

Krinkle removed Krinkle as the assignee of this task.Krinkle edited projects, added Performance-Team (Radar); removed Performance-Team.
TASK DETAILhttps://phabricator.wikimedia.org/T202764EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: gerritbot, Krinkle, Addshore, Yurik, jcrespo, Imarlier, Ladsgroup, Lydia_Pintscher, WMDE-leszek, Aklapper, Gehel, Smalyshev, AndyTan, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Davinaclare77, Adrian1985, Qtn1293, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Adik2382, Th3d3v1ls, Hfbn0, Ramalepe, Liugev6, QZanden, EBjune, Marostegui, merbst, LawExplorer, Vali.matei, Lewizho99, Minhnv-2809, Zppix, Maathavan, Jonas, Xmlizer, Wong128hk, Luke081515, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, faidon, Mbch331, Jay8g, Krenair, fgiunchedi___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Edited] T147981: Deadlock in SiteLinkTable::insertLinks on Item merges

[Krinkle]

Krinkle updated the task description. (Show Details)Krinkle set Risk Rating to N/A.
CHANGES TO TASK DESCRIPTIONWarning: [data-update-failed]: A data update callback triggered an exception (A database query error has occurred. Did you forget to run your application's database schema updater after upgrading? Query: INSERT IGNORE INTO `wb_items_per_site` (ips_item_id,ips_site_id,ips_site_page) VALUES ('346509','ukwiki','Нитка (значення)') Function: Wikibase\Lib\Store\SiteLinkTable::insertLinks Error: 1213 Deadlock found when trying to get lock; try restarting transaction (10.64.16.144) ) [Called from Wikibase\Updates\DataUpdateAdapter::doUpdate in /srv/mediawiki/php-1.28.0-wmf.22/extensions/Wikidata/extensions/Wikibase/repo/includes/updates/DataUpdateAdapter.php at line 73] in /srv/mediawiki/php-1.28.0-wmf.22/includes/debug/MWDebug.php on line 311

See also: T151789TASK DETAILhttps://phabricator.wikimedia.org/T147981EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: aude, daniel, hoo, Aklapper, Matanya, Base, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T147981: Deadlock in SiteLinkTable::insertLinks on Item merges

[Krinkle]

Krinkle added a parent task: T30599: Deadlock tracking bug (tracking).
TASK DETAILhttps://phabricator.wikimedia.org/T147981EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: aude, daniel, hoo, Aklapper, Matanya, Base, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T151789: Wikibase\\TermSqlIndex::deleteTerms: Deadlock found when trying to get lock; try restarting transaction

[Krinkle]

Krinkle added a parent task: T30599: Deadlock tracking bug (tracking).
TASK DETAILhttps://phabricator.wikimedia.org/T151789EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, Aklapper, hoo, tabish.shaikh91, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, Jayprakash12345, JakeTheDeveloper, QZanden, merbst, LawExplorer, D3r1ck01, Wikidata-bugs, aude, TheDJ, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Changed Project Column] T151789: Wikibase\\TermSqlIndex::deleteTerms: Deadlock found when trying to get lock; try restarting transaction

[Krinkle]

Krinkle moved this task from Production Impact to Production 1.32-wmf.20+ on the Wikimedia-production-error board.Krinkle added a comment.
Still seen:

exception.message:
Wikimedia\Rdbms\DBTransactionStateError
Cannot execute query from Wikibase\Repo\Content\DataUpdateAdapter::doUpdate while transaction status is ERROR.

exception.previous.message:
A database query error has occurred. 
Query: DELETE FROM `wb_terms` WHERE term_language = 'ru' AND term_type = 'label' AND term_text = 'Соловецкий (Архангельская область)' AND term_full_entity_id = 'Q3964446'
Function: Wikibase\Lib\Store\Sql\TermSqlIndex::deleteTerms
Error: 1213 Deadlock found when trying to get lock; try restarting transaction (10.64.48.26)

exception.previous.trace:
#0 /srv/mediawiki/php-1.32.0-wmf.20/includes/libs/rdbms/database/Database.php(1192): Wikimedia\Rdbms\Database->makeQueryException(string, integer, string, string)
#1 /srv/mediawiki/php-1.32.0-wmf.20/includes/libs/rdbms/database/Database.php(2907): Wikimedia\Rdbms\Database->query(string, string)
#2 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Wikibase/lib/includes/Store/Sql/TermSqlIndex.php(390): Wikimedia\Rdbms\Database->delete(string, string, string)
#3 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Wikibase/lib/includes/Store/Sql/TermSqlIndex.php(169): Wikibase\Lib\Store\Sql\TermSqlIndex->deleteTerms(Wikibase\DataModel\Entity\ItemId, array, Wikimedia\Rdbms\DatabaseMysqli)
#4 [internal function]: Wikibase\Lib\Store\Sql\TermSqlIndex->saveTermsOfEntity(Wikibase\DataModel\Entity\Item)
#5 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Wikibase/repo/includes/Content/DataUpdateAdapter.php(64): call_user_func_array(array, array)
#6 /srv/mediawiki/php-1.32.0-wmf.20/includes/deferred/DeferredUpdates.php(268): Wikibase\Repo\Content\DataUpdateAdapter->doUpdate()
#7 /srv/mediawiki/php-1.32.0-wmf.20/includes/deferred/DeferredUpdates.php(214): DeferredUpdates::runUpdate(Wikibase\Repo\Content\DataUpdateAdapter, Wikimedia\Rdbms\LBFactoryMulti, string, integer)
#8 /srv/mediawiki/php-1.32.0-wmf.20/includes/deferred/DeferredUpdates.php(134): DeferredUpdates::execute(array, string, integer)
#9 /srv/mediawiki/php-1.32.0-wmf.20/includes/MediaWiki.php(914): DeferredUpdates::doUpdates(string)
#10 /srv/mediawiki/php-1.32.0-wmf.20/includes/MediaWiki.php(734): MediaWiki->restInPeace(string, boolean)
#11 [internal function]: Closure$MediaWiki::doPostOutputShutdown()
#12 {main}

reqId: W5NWcgpAEMQAAD@Ex1wAAABP
wiki: www.wikidata.org
url: /w/api.phpTASK DETAILhttps://phabricator.wikimedia.org/T151789WORKBOARDhttps://phabricator.wikimedia.org/project/board/1055/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, Aklapper, hoo, tabish.shaikh91, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, Jayprakash12345, JakeTheDeveloper, QZanden, merbst, LawExplorer, D3r1ck01, Wikidata-bugs, aude, TheDJ, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Changed Status] T179195: Replace use of .eslintignore with ignore in Gruntfile.js in all repos, for consistency

[Krinkle]

Krinkle changed the task status from "Open" to "Stalled".Krinkle added a comment.
I think moving to Gruntfile is a viable option, but it there are other options. If we really want to defocus on tooling integration, we should move eslintrc to Gruntfile as well. Or, keep the integration and keep both config+ignores out of Gruntfile (either in .eslint* files, or in package.json).

See T204176 for details.TASK DETAILhttps://phabricator.wikimedia.org/T179195EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: gerritbot, WMDE-leszek, Aklapper, Samwilson, Paladox, Krinkle, Florian, Addshore, Jdforrester-WMF, thiemowmde, hashar, Legoktm, Umherirrender, Mh-3110, tabish.shaikh91, Lahi, SilvioAryneutro, Gq86, Timoavax79, GoranSMilovanovic, Soteriaspace, Jayprakash12345, JakeTheDeveloper, QZanden, enigmaeth, rohitt, merbst, LawExplorer, D3r1ck01, Dixtosa, Wikidata-bugs, aude, Dinoguy1000, TheDJ, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Edited] T204159: Fatal "Call getPrefixedText on a non-object" from WikibaseClient on ApiEchoNotifications

[Krinkle]

Krinkle updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...```name=stacktrace,lines=10
#0 [internal function]: Wikibase\Client\Notifications\PageConnectionPresentationModel->callbackForBundleCount(EchoEvent)...TASK DETAILhttps://phabricator.wikimedia.org/T204159EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, Aklapper, kostajh, MMiller_WMF, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Taiwania_Justo, SBisson, Luke081515, Wikidata-bugs, aude, Catrope, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Created] T204159: Fatal "Call getPrefixedText on a non-object" from WikibaseClient on ApiEchoNotifications

[Krinkle]

Krinkle created this task.Krinkle added projects: Wikimedia-production-error, MediaWiki-extensions-WikibaseClient, Notifications.Restricted Application added a subscriber: Aklapper.Restricted Application added projects: Growth-Team, Wikidata.
TASK DESCRIPTIONError

Request ID: W5laWwrAAFAAADp8ycsO

messageBadMethodCallException: Call to a member function getPrefixedText() on a non-object (null)

stacktrace#0 [internal function]: Wikibase\Client\Notifications\PageConnectionPresentationModel->callbackForBundleCount(EchoEvent)
#1 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Echo/includes/formatters/EventPresentationModel.php(220): array_map(array, array)
#2 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Echo/includes/formatters/EventPresentationModel.php(240): EchoEventPresentationModel->getBundleCount(boolean, array)
#3 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Wikibase/client/includes/Notifications/PageConnectionPresentationModel.php(54): EchoEventPresentationModel->getNotificationCountForOutput(boolean, array)
#4 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Echo/includes/formatters/EventPresentationModel.php(520): Wikibase\Client\Notifications\PageConnectionPresentationModel->getHeaderMessage()
#5 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Echo/includes/formatters/EchoModelFormatter.php(13): EchoEventPresentationModel->jsonSerialize()
#6 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Echo/includes/formatters/EchoEventFormatter.php(64): EchoModelFormatter->formatModel(Wikibase\Client\Notifications\PageConnectionPresentationModel)
#7 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Echo/includes/DataOutputFormatter.php(181): EchoEventFormatter->format(EchoEvent)
#8 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Echo/includes/DataOutputFormatter.php(141): EchoDataOutputFormatter::formatNotification(EchoEvent, User, string, Language)
#9 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Echo/includes/api/ApiEchoNotifications.php(287): EchoDataOutputFormatter::formatOutput(EchoNotification, string, User, Language)
#10 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Echo/includes/api/ApiEchoNotifications.php(107): ApiEchoNotifications->getPropList(User, array, array, integer, NULL, string, NULL, boolean, boolean)
#11 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Echo/includes/api/ApiEchoNotifications.php(38): ApiEchoNotifications->getLocalNotifications(array)
#12 /srv/mediawiki/php-1.32.0-wmf.20/includes/api/ApiQuery.php(249): ApiEchoNotifications->execute()
#13 /srv/mediawiki/php-1.32.0-wmf.20/includes/api/ApiMain.php(1587): ApiQuery->execute()
#14 /srv/mediawiki/php-1.32.0-wmf.20/includes/api/ApiMain.php(531): ApiMain->executeAction()
#15 /srv/mediawiki/php-1.32.0-wmf.20/includes/api/ApiMain.php(502): ApiMain->executeActionWithErrorHandling()
#16 /srv/mediawiki/php-1.32.0-wmf.20/api.php(87): ApiMain->execute()



NotesTASK DETAILhttps://phabricator.wikimedia.org/T204159EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, Aklapper, kostajh, MMiller_WMF, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Taiwania_Justo, SBisson, Luke081515, Wikidata-bugs, aude, Catrope, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T88258: Convert WikibaseClient, WikibaseLib and WikibaseRepository to use extension registration

[Krinkle]

Krinkle added a parent task: T87875: Convert all Wikimedia-deployed extensions and skins to use extension registration.
TASK DETAILhttps://phabricator.wikimedia.org/T88258EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: hashar, WMDE-leszek, Addshore, Tobi_WMDE_SW, gerritbot, Ricordisamoa, Jdlrobson, JanZerebecki, hoo, aude, Lydia_Pintscher, Aklapper, Legoktm, Liuxinyu970226, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Jonas, Izno, Wikidata-bugs, Dinoguy1000, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Edited] T174047: Hide deprecated/unused fields on toolforge replica [MCR]

[Krinkle]

Krinkle updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONFields that will become unused with MCR schema migration should be hidden in the toolforge replica of the wiki databases, to avoid tools from reading incomplete/inconsistent data. These fields will eventually be dropped anyway, and will stop to be updated when T198312 is done, which is expected to happen by the end of the year [[https://docs.google.com/spreadsheets/d/1TkznqoaMH6HTQBSMxXPRhSOo8auf1oMLx6c-Cjjf-Sk/edit?ts=5b43c255#gid=0|MCR migration plan]]. Affected fields are:...TASK DETAILhttps://phabricator.wikimedia.org/T174047EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Stashbot, jcrespo, gerritbot, Bstorm, Tgr, bd808, Anomie, Aklapper, daniel, AndyTan, Gaboe420, Zylc, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 1978Gage2001, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Chicocvenancio, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tbscho, LawExplorer, Lewizho99, JJMC89, Maathavan, Agabi10, srodlund, Wikidata-bugs, aude, Gryllida, scfc, Jdforrester-WMF, Mbch331, Ltrlg, Krenair, chasemp___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T88258: Convert WikibaseClient, WikibaseLib and WikibaseRepository to use extension registration

[Krinkle]

Krinkle edited parent tasks, added: T140852: Load all Wikimedia-deployed extensions and skins via extension registration; removed: T87875: Convert all Wikimedia-deployed extensions and skins to use extension registration.
TASK DETAILhttps://phabricator.wikimedia.org/T88258EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: hashar, WMDE-leszek, Addshore, Tobi_WMDE_SW, gerritbot, Ricordisamoa, Jdlrobson, JanZerebecki, hoo, aude, Lydia_Pintscher, Aklapper, Legoktm, Liuxinyu970226, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Jonas, Izno, Wikidata-bugs, Dinoguy1000, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T97368: Investigate more efficient memcached solution for CacheAwarePropertyInfoStore

[Krinkle]

Krinkle added a project: Wikimedia-Incident.
TASK DETAILhttps://phabricator.wikimedia.org/T97368EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Joe, mark, Addshore, jijiki, akosiaris, Krinkle, JanZerebecki, thiemowmde, aude, daniel, Aklapper, hoo, AndyTan, Davinaclare77, Qtn1293, Imarlier, Lahi, Gq86, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, LawExplorer, Vali.matei, Zppix, Wong128hk, Wikidata-bugs, ArielGlenn, faidon, He7d3r, Jdforrester-WMF, Mbch331, Jay8g, fgiunchedi, greg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T97368: Investigate more efficient memcached solution for CacheAwarePropertyInfoStore

[Krinkle]

Krinkle edited projects, added Performance-Team, wikidata-tech-focus, Operations; removed Performance.
TASK DETAILhttps://phabricator.wikimedia.org/T97368EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Joe, mark, Addshore, jijiki, akosiaris, Krinkle, JanZerebecki, thiemowmde, aude, daniel, Aklapper, hoo, AndyTan, Davinaclare77, Qtn1293, Imarlier, Lahi, Gq86, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, LawExplorer, Vali.matei, Zppix, Wong128hk, Wikidata-bugs, faidon, Mbch331, Jay8g, fgiunchedi, Darkminds3113, Volker_E, GWicke, Dinoguy1000___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Retitled] T97368: Investigate more efficient memcached solution for CacheAwarePropertyInfoStore

[Krinkle]

Krinkle renamed this task from "[Task] Investigate about more efficient PropertyInfoStore implementations" to "Investigate more efficient memcached solution for CacheAwarePropertyInfoStore ".
TASK DETAILhttps://phabricator.wikimedia.org/T97368EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Joe, mark, Addshore, jijiki, akosiaris, Krinkle, JanZerebecki, thiemowmde, aude, daniel, Aklapper, hoo, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, Volker_E, Wikidata-bugs, GWicke, Dinoguy1000, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T97368: [Task] Investigate about more efficient PropertyInfoStore implementations

[Krinkle]

Krinkle added a subscriber: akosiaris.Krinkle added a comment.

At T204083, @akosiaris wrote:
SRE team noticed that a specific host (mc1023) is close to saturating the uplink network connection [1]. More investigation into the grafana graphs for the entire cluster [2] showed that this is a recurring pattern that seems to follow hosts around. Doing a memkeys on mc1023 we found out that the key

wikibase_shared/1_32_0-wmf_20-wikidatawiki-hhvm:CacheAwarePropertyInfoStore

is doing >600Mbps of traffic. The fact the train version is coded in the key name supports the theory of the key name following the train and being hashed to a different server, explaining the fact the traffic seems to follow hosts around.

This will cause an outage soon, needs to be fixed

[1] https://grafana.wikimedia.org/dashboard/db/prometheus-machine-stats?panelId=8=1=mc1023=eqiad%20prometheus%2Fops=now-7d=now-1m

[2]  https://grafana.wikimedia.org/dashboard/db/prometheus-cluster-breakdown?orgId=1=now-30m=now=eqiad%20prometheus%2Fops=memcached=All





In T204083#4575357, @akosiaris wrote:
https://grafana.wikimedia.org/dashboard/db/t204083?orgId=1 shows the excessive traffic moving around the various memcached hosts for the last 1 year.


TASK DETAILhttps://phabricator.wikimedia.org/T97368EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: akosiaris, Krinkle, JanZerebecki, thiemowmde, aude, daniel, Aklapper, hoo, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, Volker_E, Wikidata-bugs, GWicke, Dinoguy1000, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Merged] T204083: wikibase_shared/-wikidatawiki-hhvm:CacheAwarePropertyInfoStore memcached key not well distributed, causing excessive traffic

[Krinkle]

Krinkle closed this task as a duplicate of T97368: [Task] Investigate about more efficient PropertyInfoStore implementations.
TASK DETAILhttps://phabricator.wikimedia.org/T204083EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: jijiki, Addshore, Aklapper, mark, Krinkle, Joe, akosiaris, AndyTan, Davinaclare77, Qtn1293, Imarlier, Lahi, Gq86, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, LawExplorer, Vali.matei, Zppix, Wong128hk, Wikidata-bugs, aude, faidon, Mbch331, Jay8g, fgiunchedi___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T97368: [Task] Investigate about more efficient PropertyInfoStore implementations

[Krinkle]

Krinkle added subscribers: jijiki, Addshore, mark, Joe.Krinkle merged a task: T204083: wikibase_shared/-wikidatawiki-hhvm:CacheAwarePropertyInfoStore memcached key not well distributed, causing excessive traffic.
TASK DETAILhttps://phabricator.wikimedia.org/T97368EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Joe, mark, Addshore, jijiki, akosiaris, Krinkle, JanZerebecki, thiemowmde, aude, daniel, Aklapper, hoo, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, Volker_E, Wikidata-bugs, GWicke, Dinoguy1000, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Raised Priority] T97368: [Task] Investigate about more efficient PropertyInfoStore implementations

[Krinkle]

Krinkle raised the priority of this task from "Normal" to "High".Krinkle added a comment.
Raising priority as the use of this memcached key brings the network link for the Memcached server it maps to dangerously close to not being able to handle it.

Whichever Memcached server contains this key, has ~80% of its network traffic dedicated to handling this one Memcached key.

In addition, due to this cache key containing the wmf-branch name, its hashed differently each week, and changes which Memcached server it is stored, which means SRE/infrastructure gets struck with an "ethernet capacity" alert from a different server each week, uncertain whether it's this known issue, or something even more critical, with very little time to respond.TASK DETAILhttps://phabricator.wikimedia.org/T97368EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, JanZerebecki, thiemowmde, aude, daniel, Aklapper, hoo, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, Volker_E, Wikidata-bugs, GWicke, Dinoguy1000, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Claimed] T202764: Wikidata produces a lot of failed requests for recentchanges API

[Krinkle]

Krinkle moved this task from Inbox to Doing on the Performance-Team board.Krinkle claimed this task.Krinkle added a comment.
I'll investigate a bit to try to determine whether MediaWiki recentchanges may have regressed more generally or whether this might be specific to the Wikidata setup.TASK DETAILhttps://phabricator.wikimedia.org/T202764WORKBOARDhttps://phabricator.wikimedia.org/project/board/1212/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, Addshore, Yurik, jcrespo, Imarlier, Ladsgroup, Lydia_Pintscher, WMDE-leszek, Aklapper, Gehel, Smalyshev, AndyTan, Davinaclare77, Qtn1293, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, EBjune, merbst, LawExplorer, Vali.matei, Zppix, Jonas, Xmlizer, Wong128hk, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, faidon, Mbch331, Jay8g, fgiunchedi___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Changed Project Column] T203696: Drastically reduce the number of ResourceLoader modules that Wikibase creates

[Krinkle]

Krinkle moved this task from Inbox to Radar on the Performance-Team board.Krinkle edited projects, added Performance-Team (Radar); removed Performance-Team.
TASK DETAILhttps://phabricator.wikimedia.org/T203696WORKBOARDhttps://phabricator.wikimedia.org/project/board/1212/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Aklapper, Krinkle, Jdforrester-WMF, Imarlier, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, Volker_E, Wikidata-bugs, aude, GWicke, Dinoguy1000, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Declined] T130561: FlaggedRevsHooks::autoMarkPatrolled hook from RecentChange::save sometimes failed with "Lock wait timeout exceeded"

[Krinkle]

Krinkle closed this task as "Declined".Krinkle moved this task from Production 1.32-wmf.19+ to Production Impact on the Wikimedia-production-error board.Krinkle added a comment.
Mistook it for another one. This one hasn't been seen for at least 30 days. Closing for now.TASK DETAILhttps://phabricator.wikimedia.org/T130561WORKBOARDhttps://phabricator.wikimedia.org/project/board/1055/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, Cenarium, aude, Lydia_Pintscher, aaron, Aklapper, hoo, kostajh, MMiller_WMF, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, TerraCodes, Taiwania_Justo, Zache, Wikidata-bugs, jeblad, Jdforrester-WMF, Jackmcbarn, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T130561: FlaggedRevsHooks::autoMarkPatrolled hook from RecentChange::save sometimes failed with "Lock wait timeout exceeded"

[Krinkle]

Krinkle added a comment.
Assuming the write isn't a no-op, it should indeed use an earlier hook to inform the value to be written instead of changing it immediately afterwards.

It's still curious that it would deadlock, though, and even curiouser that it isn't deterministic.TASK DETAILhttps://phabricator.wikimedia.org/T130561EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, Cenarium, aude, Lydia_Pintscher, aaron, Aklapper, hoo, kostajh, MMiller_WMF, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, TerraCodes, Taiwania_Justo, Zache, Wikidata-bugs, jeblad, Jdforrester-WMF, Jackmcbarn, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Retitled] T130561: FlaggedRevsHooks::autoMarkPatrolled hook from RecentChange::save sometimes failed with "Lock wait timeout exceeded"

[Krinkle]

Krinkle renamed this task from "FlaggedRevsHooks::autoMarkPatrolled shouldn't need to update the RC entry that has just been saved" to "FlaggedRevsHooks::autoMarkPatrolled hook from RecentChange::save sometimes failed with "Lock wait timeout exceeded"".Krinkle removed projects: MediaWiki-Recent-changes, Performance.
TASK DETAILhttps://phabricator.wikimedia.org/T130561EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Cenarium, aude, Lydia_Pintscher, aaron, Aklapper, hoo, kostajh, MMiller_WMF, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, TerraCodes, Taiwania_Justo, Zache, Wikidata-bugs, jeblad, Jdforrester-WMF, Jackmcbarn, Mbch331, Jay8g, Krenair, Darkminds3113, Vali.matei, Volker_E, GWicke, Dinoguy1000___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T130561: FlaggedRevsHooks::autoMarkPatrolled shouldn't need to update the RC entry that has just been saved

[Krinkle]

Krinkle added a parent task: T30499: 1205: Lock wait timeout exceeded; try restarting transaction (tracking).Restricted Application added a project: Growth-Team.
TASK DETAILhttps://phabricator.wikimedia.org/T130561EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Cenarium, aude, Lydia_Pintscher, aaron, Aklapper, hoo, kostajh, MMiller_WMF, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, TerraCodes, Taiwania_Justo, Volker_E, Zache, Wikidata-bugs, GWicke, Dinoguy1000, jeblad, Jdforrester-WMF, Jackmcbarn, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Closed] T191282: Wikimedia\Rdbms\LoadBalancer::{closure}: found writes pending

[Krinkle]

Krinkle closed this task as "Resolved".Krinkle claimed this task.Krinkle added a comment.
There are indeed a few hits still, but this has become an tracking task for a category of issues, which doesn't seem useful.

The found writes pending error is a symptom of an underlying problem. The only way to make the error go away permanently is to remove MediaWiki's ability to detect the issue.

Many specific problems in core and in various extensions that are detected by this warning have been mentioned here and fixed. I'll close this for now in favour of opening new tasks for remaining/future instances of this problem.TASK DETAILhttps://phabricator.wikimedia.org/T191282EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, Joe, Ladsgroup, hoo, RazShuty, gerritbot, Tgr, Pchelolo, mmodell, Marostegui, aaron, mobrovac, Aklapper, jcrespo, Akovalyov, Rayssa-, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Eevans, JAllemandou, Hardikj, Wikidata-bugs, aude, GWicke, Dinoguy1000, Mbch331, Jay8g, Krenair, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Closed] T199855: WikidataPageBanner breaks Vector page subtitle

[Krinkle]

Krinkle removed a project: Patch-For-Review.Krinkle closed this task as "Resolved".Krinkle claimed this task.Krinkle added a comment.
Backported and verified on mwdebug and in prod.TASK DETAILhttps://phabricator.wikimedia.org/T199855EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Stashbot, gerritbot, Jdlrobson, Aklapper, Krinkle, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, Jrbranaa, QZanden, LawExplorer, Winter, Wong128hk, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T196349: wbgetentities API call for a Form ID results in Serializers\\Exceptions\\UnsupportedObjectException

[Krinkle]

Krinkle moved this task from Backlog to Production Impact on the Wikimedia-log-errors board.Krinkle added a project: Wikidata-Campsite.Krinkle added a comment.
(Triaging from backlog by ensuring a team tag or equivalent is present; Please confirm whether this error still exists case. Feel free to move to "No/Low important" if it is not a priority.)TASK DETAILhttps://phabricator.wikimedia.org/T196349WORKBOARDhttps://phabricator.wikimedia.org/project/board/1055/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, Lydia_Pintscher, matej_suchanek, Addshore, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Salgo60, Jonas, Wikidata-bugs, aude, Darkdadaah, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T194374: Special:EntitiesWithout* allows selecting Lexeme, however it just throws an exception

[Krinkle]

Krinkle added a project: Wikidata-Campsite.
TASK DETAILhttps://phabricator.wikimedia.org/T194374EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Aklapper, Lydia_Pintscher, daniel, Addshore, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Salgo60, Jonas, Luke081515, Wikidata-bugs, aude, Darkdadaah, Mbch331, Jay8g, Krenair, greg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Declined] T189841: Bad value for parameter $pageTitle: must be a string

[Krinkle]

Krinkle closed this task as "Declined".Krinkle added a comment.
No exceptions or errors for SiteLinkTable in last 7 days,TASK DETAILhttps://phabricator.wikimedia.org/T189841EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, Aklapper, Reedy, stebsco, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, Jrbranaa, QZanden, LawExplorer, Wong128hk, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T110022: Create a library with HTTP related functions/code

[Krinkle]

Krinkle added a comment.

In T110022#4508947, @Legoktm wrote:

In T110022#4502131, @Krinkle wrote:



I think this can also work backwards, like if upstream doesn't add support for newer PHP versions, then we're stuck.


I agree that's a general concern to be aware of when comparing vendors. WordPress specifically, though, has no precedent for being slow to support new PHP versions. They've been as fast or faster than us. (PHP7.0 both in late 2015, PHP 7.2 also on par, or arguably we're behind if we also consider warnings).TASK DETAILhttps://phabricator.wikimedia.org/T110022EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Imarlier, BPirkle, Nikerabbit, Dereckson, Ladsgroup, Krinkle, PokestarFan, Tgr, Lydia_Pintscher, Ricordisamoa, Legoktm, Addshore, Aklapper, Arch2all, Lahi, Gq86, dmaza, GoranSMilovanovic, DFelten, QZanden, LawExplorer, HakanIST, Abbe98, Hannolans, Samwilson, Wikidata-bugs, aude, Dinoguy1000, fbstj, Tpt, Mbch331, bd808___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Edited] T202097: Avoid invoking Parser in WikibaseClient ResourceLoaderJqueryMsgModuleMagicWords hook

[Krinkle]

Krinkle updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONTo generaWhen generating the startup response for a wiki, ResourceLoader needs to compute the content and/or version of the `mediawiki.jqueryMsg` module,. ResourceLoader This currently indirectlyvolves invoking the Parser.

This is adding undesirableThe Parser adds performance overhead and generally seems like something that was likelyad that I believe may've been unintentionalTASK DETAILhttps://phabricator.wikimedia.org/T202097EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Addshore, Aklapper, Krinkle, Imarlier, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T202097: Avoid invoking Parser in WikibaseClient ResourceLoaderJqueryMsgModuleMagicWords hook

[Krinkle]

Krinkle added a comment.
I'd recommend considering Message::text() instead of Message::parse(). This would disallow templates and parser functions, which aren't currently used in those messages.

https://codesearch.wmflabs.org/search/?q=wikibase-repo-name.%2B%5B%5C%5B%5C%5D%7B%7D%27%3C%3E%5D=nopeTASK DETAILhttps://phabricator.wikimedia.org/T202097EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Aklapper, Krinkle, Imarlier, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Created] T202097: Avoid invoking Parser in WikibaseClient ResourceLoaderJqueryMsgModuleMagicWords hook

[Krinkle]

Krinkle created this task.Krinkle added projects: Performance-Team, MediaWiki-extensions-WikibaseClient.Restricted Application added a subscriber: Aklapper.Restricted Application added a project: Wikidata.
TASK DESCRIPTIONTo generate the content and/or version of the mediawiki.jqueryMsg module, ResourceLoader is currently indirectly invoking the Parser.

This is adding undesirable performance overhead and generally seems like something that was likely unintentional.

It is coming from WikibaseClient's ResourceLoaderJqueryMsgModuleMagicWords  hook.

Flame graph:
F25024603: Screen Shot 2018-08-16 at 21.20.03.png

Code:
https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/e46b4e97f3dc87612adde85d5b2a512c49629956/client/includes/Hooks/MagicWordHookHandlers.php#126

# function doResourceLoaderJqueryMsgModuleMagicWords {
$magicWords['WBREPONAME'] = $this->getRepoName( $lang );

# function getRepoName {
$message = new Message( $repoSiteName );
$message->inLanguage( $lang );
if ( $message->exists() ) {
	return $message->parse();TASK DETAILhttps://phabricator.wikimedia.org/T202097EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Aklapper, Krinkle, Imarlier, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Closed] T201453: Flaky test case in SimpleCacheWithBagOStuffTest

[Krinkle]

Krinkle closed this task as "Resolved".Krinkle removed projects: MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T201453EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDE, KrinkleCc: gerritbot, Addshore, WMDE-leszek, Aleksey_WMDE, Krinkle, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Volker_E, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Krenair, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T110022: Create a library with HTTP related functions/code

[Krinkle]

Krinkle added a comment.
I agree that non-static state and active maintenance are desirable traits. I haven't recently checked either library for those aspects, but I trust @BPirkle and @Tgr  that Guzzle is better in that regard.

I'd like to instead provide feedback on another aspect: Stability.

Stability

Being part of WordPress has a very strong benefit with regards to stability. In particular:


WordPress is very serious about backwards compatibility.
WordPress is very serious about PHP compatibility.


This means we can be reasonably certain that we can always use the latest stable version of the library, with upstream support for any issues that may arise in either its public interface or compatibility with any of the PHP versions MediaWiki supports.

It also means there likely isn't going to be a major release any time soon that would drop support for a PHP version we support, or that would make a breaking change in its public interface. This reduces the chances of getting stuck with an older or unsupported version.TASK DETAILhttps://phabricator.wikimedia.org/T110022EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Imarlier, BPirkle, Nikerabbit, Dereckson, Ladsgroup, Krinkle, PokestarFan, Tgr, Lydia_Pintscher, Ricordisamoa, Legoktm, Addshore, Aklapper, Arch2all, Lahi, Gq86, dmaza, GoranSMilovanovic, DFelten, QZanden, LawExplorer, HakanIST, Abbe98, Hannolans, Samwilson, Wikidata-bugs, aude, Dinoguy1000, fbstj, Tpt, Mbch331, bd808___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T110022: Create a library with HTTP related functions/code

[Krinkle]

Krinkle added a comment.

In T110022#4479395, @Tgr wrote:

In T110022#4478166, @Krinkle wrote:
We'd basically map the exception class to a localisation message somewhere [..]


[..]
 Mapping by class is not really useful. Mapping by message would involve regex parsing messages - possible but a bit icky (also fragile).





In T110022#4483081, @BPirkle wrote:
I wish we could map by exception class, but it seems challenging to do that in a useful way.   [..]


I was suggesting only a simple map, or a catch-all even – not any form of message extraction. Looking at MediaWiki's current Http, MWHttpRequest and MultiHttpClient class, we also don't provide localisation for low-level details about the error, such as the path to a CA bundle. We have those in exception messages only, not localised. The only user-facing messages we have are:


http-invalid-url ($1: url) – Based on a validation check before the request is made.
http-bad-status ($1: statusCode, $2: statusText) – After a successful response, read from a public interface.
http-internal-error (no params) – Everything else.


This is feasible with either of the two library options (Guzzle and Requests), and likely other libraries as well.TASK DETAILhttps://phabricator.wikimedia.org/T110022EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Imarlier, BPirkle, Nikerabbit, Dereckson, Ladsgroup, Krinkle, PokestarFan, Tgr, Lydia_Pintscher, Ricordisamoa, Legoktm, Addshore, Aklapper, Arch2all, Lahi, Gq86, dmaza, GoranSMilovanovic, DFelten, QZanden, LawExplorer, HakanIST, Abbe98, Hannolans, Samwilson, Wikidata-bugs, aude, Dinoguy1000, fbstj, Tpt, Mbch331, bd808___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Changed Project Column] T172443: Wikibase: Unresolved redirect in WikiPageEntityRevisionLookup.php:103

[Krinkle]

Krinkle moved this task from Backlog to Production Impact on the Wikimedia-log-errors board.Krinkle added a comment.
Still seen several times per day in the last 7 days on wikidata.org with the current branch (1.32.0-wmf.16).

Recent sample:

Unresolved redirect to Q52155568

exception_id: W3E9jApAIDkAAH3Smz4Y
exception_url: /w/api.php
http_method: POST
exception.trace:
#0 /srv/mediawiki/php-1.32.0-wmf.16/extensions/Wikibase/lib/includes/Store/DispatchingEntityRevisionLookup.php(59): Wikibase\Lib\Store\Sql\WikiPageEntityRevisionLookup->getEntityRevision(Wikibase\DataModel\Entity\ItemId, integer, string)
#1 /srv/mediawiki/php-1.32.0-wmf.16/extensions/Wikibase/lib/includes/Store/TypeDispatchingEntityRevisionLookup.php(55): Wikibase\Lib\Store\DispatchingEntityRevisionLookup->getEntityRevision(Wikibase\DataModel\Entity\ItemId, integer, string)
#2 /srv/mediawiki/php-1.32.0-wmf.16/extensions/Wikibase/repo/includes/EditEntity.php(268): Wikibase\Lib\Store\TypeDispatchingEntityRevisionLookup->getEntityRevision(Wikibase\DataModel\Entity\ItemId, integer, string)
#3 /srv/mediawiki/php-1.32.0-wmf.16/extensions/Wikibase/repo/includes/EditEntity.php(687): Wikibase\EditEntity->getLatestRevision()
#4 /srv/mediawiki/php-1.32.0-wmf.16/extensions/Wikibase/repo/includes/Api/EntitySavingHelper.php(351): Wikibase\EditEntity->attemptSave(Wikibase\DataModel\Entity\Item, string, integer, string)
#5 /srv/mediawiki/php-1.32.0-wmf.16/extensions/Wikibase/repo/includes/Api/SetClaim.php(137): Wikibase\Repo\Api\EntitySavingHelper->attemptSaveEntity(Wikibase\DataModel\Entity\Item, string)
#6 /srv/mediawiki/php-1.32.0-wmf.16/includes/api/ApiMain.php(1579): Wikibase\Repo\Api\SetClaim->execute()
#7 /srv/mediawiki/php-1.32.0-wmf.16/includes/api/ApiMain.php(533): ApiMain->executeAction()
#8 /srv/mediawiki/php-1.32.0-wmf.16/includes/api/ApiMain.php(504): ApiMain->executeActionWithErrorHandling()
#9 /srv/mediawiki/php-1.32.0-wmf.16/api.php(83): ApiMain->execute()
#10 /srv/mediawiki/w/api.php(3): include(string)TASK DETAILhttps://phabricator.wikimedia.org/T172443WORKBOARDhttps://phabricator.wikimedia.org/project/board/1055/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, Aklapper, mmodell, PokestarFan, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Created] T201453: Flaky test case in SimpleCacheWithBagOStuffTest

[Krinkle]

Krinkle created this task.Krinkle added projects: MediaWiki-extensions-WikibaseClient, Wikidata, Wikimedia-log-errors (Shared Build Failure).Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTIONWikibase\Lib\Tests\SimpleCacheWithBagOStuffTest::testSetMultipleTtl
Failed asserting that null matches expected 'value2'.

Caused tests to intermittently fail for https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/450936/.

Follows-up rEWBAcf03dc4cc8ae: Implementation of `Psr\SimpleCache\CacheInterface` using `BagOStuff`.TASK DETAILhttps://phabricator.wikimedia.org/T201453EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Aleksey_WMDE, Krinkle, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Volker_E, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T200009: Archive mediawiki/extensions/Wikidata (Wikidata build)

[Krinkle]

Krinkle added a comment.

In T29#4483270, @mmodell wrote:
What is the benefit to emptying the repository? [..] no need to obscure it from history.


In the context of #cleanup, "emptying the repo" means adding a new commit to the master branch that removes all files except the README or "ARCHIVED" file, which we replace with a note. The commit history and previous branches/trees remain unaffected, and once this new commit is merged, the Gerrit repo is set to "Read Only".

This has the benefit of not continuing to yield search results for old code, and a few other accumulated minor reasons. It's part of the checklist and we've done this for for every extension we archived over the last 5 years (I estimate about 70 extensions, including VectorBeta, Reflect, VisualChat - to name a few).

I don't think these are particularly strong reasons, but, given we've consistently done it, I think it would be appropriate to ask why extensions/Wikidata should be handled differently? Do its prior maintainers have a particular need for that?TASK DETAILhttps://phabricator.wikimedia.org/T29EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Zoranzoki21, KrinkleCc: Krinkle, mmodell, Liuxinyu970226, Aklapper, Bugreporter, Reari, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T110022: Create a library with HTTP related functions/code

[Krinkle]

Krinkle added a comment.
A wrapper would be straight-forward indeed, but another idea to consider could be to handle localisation at a higher layer that catches the exception, and responsible for printing it in some way. That approach might be easier to scale to other libraries we use, including those used indirectly by other libraries that we don't control.

We'd basically map the exception class to a localisation message somewhere, quite similar to what we already do for various exception types in various places. Perhaps we could centralise that a bit within MediaWiki :)TASK DETAILhttps://phabricator.wikimedia.org/T110022EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: BPirkle, Nikerabbit, Dereckson, Ladsgroup, Krinkle, PokestarFan, Tgr, Lydia_Pintscher, Ricordisamoa, Legoktm, Addshore, Aklapper, Arch2all, Lahi, Gq86, dmaza, GoranSMilovanovic, DFelten, QZanden, LawExplorer, HakanIST, Abbe98, Hannolans, Samwilson, Wikidata-bugs, aude, Dinoguy1000, fbstj, Tpt, Mbch331, bd808___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T135461: Exploratory: Making Wikidata content accessible on foundation.wikimedia.org

[Krinkle]

Krinkle added a project: WMF-Communications.
TASK DETAILhttps://phabricator.wikimedia.org/T135461EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, PokestarFan, Liuxinyu970226, Lydia_Pintscher, aude, Heather, JAnstee_WMF, Aklapper, Varnent, Zppix, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, jrbs, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T135461: Exploratory: Making Wikidata content accessible on foundation.wikimedia.org

[Krinkle]

Krinkle added a comment.
@Varnent Is this still sought-after? I assume not, but just checking :)TASK DETAILhttps://phabricator.wikimedia.org/T135461EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, PokestarFan, Liuxinyu970226, Lydia_Pintscher, aude, Heather, JAnstee_WMF, Aklapper, Varnent, Zppix, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Retitled] T135461: Exploratory: Making Wikidata content accessible on foundation.wikimedia.org

[Krinkle]

Krinkle renamed this task from "Exploratory: Making Wikidata content accessible on wikimediafoundation.org" to "Exploratory: Making Wikidata content accessible on foundation.wikimedia.org".Krinkle updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONCurious if it would be possible to make Wikidata content available for things like feeding templates, on wikimediaon https://foundation.wikimedia.org...TASK DETAILhttps://phabricator.wikimedia.org/T135461EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: PokestarFan, Liuxinyu970226, Lydia_Pintscher, aude, Heather, JAnstee_WMF, Aklapper, Varnent, Zppix, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T197616: Create a production test wiki in group0 to parallel Wikimedia Commons

[Krinkle]

Krinkle added a comment.

In T197616#4461712, @daniel wrote:
Do you believe that the test wikis on the live cluster should be removed [..]


Yes and no.

Yes, I'd prefer we not see test-wikis as ways to catch regressions during normal deployments, because almost none of our procedures (apart from train/group0) include test wikis. And for train/group0 we have other wikis that serve this purpose better, e.g. www.mediawiki.org. I don't see this as a problem because test wikis are in production, that's too late for testing. At this point, we might as well perform QA against an actual production wiki that doesn't have different or dated configuration.

No, I'd prefer we keep at least test.wikipedia and test2.wikipedia, for testing with multiversion. This is why, test2.wikipedia is on group2 (or group1?) instead of group0. Although I do think that in the long-term we should phase this out. Especially now that we have a Beta Cluster and X-Wikimedia-Debug. Beta can be used to enable upcoming features before their deployment in prod, and XWD can be used to verify changes in prod during a deployment.TASK DETAILhttps://phabricator.wikimedia.org/T197616EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Ramsey-WMF, Tgr, Anomie, Krinkle, Liuxinyu970226, Jdforrester-WMF, Fjalapeno, Abit, Aklapper, greg, Reedy, CCicalese_WMF, daniel, Lahi, PDrouin-WMF, Gq86, E1presidente, JunaidHafeez, Cparle, BJ6123C7BTD, Anooprao, SandraF_WMF, GoranSMilovanovic, Jayprakash12345, QZanden, Tramullas, Acer, Zoranzoki21, LawExplorer, DatGuy, Devwaker, Niklitov, Urbanecm, Liudvikas, JEumerus, StevenJ81, Susannaanas, Tulsi_Bhagat, Wong128hk, Luke081515, SimmeD, Aschroet, Jane023, Wikidata-bugs, Snowolf, Base, matthiasmullie, aude, Dcljr, Ebe123, Koavf, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, zeljkofilipin, Rschen7754, Steinsplitter, Matanya, Mbch331, Rxy, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T162562: Choose a field length for entity id columns and stick to it

[Krinkle]

Krinkle removed a project: MediaWiki-Database.
TASK DETAILhttps://phabricator.wikimedia.org/T162562EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Marostegui, aude, Ladsgroup, daniel, Aklapper, hoo, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, Mbch331, Rayssa-, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T197616: Create a production test wiki in group0 to parallel Wikimedia Commons

[Krinkle]

Krinkle added a comment.

In T197616#4429492, @Krinkle wrote:

In T197616#4297600, @daniel wrote:
The beta setup is probably not going to cover all the angles for e.g. wikibase change propagation.



@Krinkle Can you clarify what angles you think aren't going to covered and [..]

This was a statement from @daniel, not me. I don’t have a stake in terms of what needs to be covered.

Reading the rest of Daniel’s comment, I believe his main concern is that “changeprop” is not installed on Beta Cluster currently. I was saying, we should consider installing it if that’s the case, and therefore use the existing Commons in Beta, instead of creating a test-commons in production.

Mainly because doing it in prod would demand on-going maintenance from lots of teams, and create technical debt as result of having two commons’ in the same realm. The Beta Commons on the other hand naturally matches the production configuration without any manual labour.TASK DETAILhttps://phabricator.wikimedia.org/T197616EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Tgr, Anomie, Krinkle, Liuxinyu970226, Jdforrester-WMF, Fjalapeno, Abit, Aklapper, greg, Reedy, CCicalese_WMF, daniel, Lahi, PDrouin-WMF, Gq86, E1presidente, JunaidHafeez, Ramsey-WMF, Cparle, BJ6123C7BTD, Anooprao, SandraF_WMF, GoranSMilovanovic, Jayprakash12345, QZanden, Tramullas, Acer, Zoranzoki21, LawExplorer, DatGuy, Devwaker, Niklitov, Urbanecm, Liudvikas, JEumerus, StevenJ81, Susannaanas, Tulsi_Bhagat, Wong128hk, Luke081515, SimmeD, Aschroet, Jane023, Wikidata-bugs, Snowolf, Base, matthiasmullie, aude, Dcljr, Ebe123, Koavf, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, zeljkofilipin, Rschen7754, Steinsplitter, Matanya, Mbch331, Rxy, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T176312: Don’t check format constraint via SPARQL (safely evaluating user-provided regular expressions)

[Krinkle]

Krinkle added a comment.
Hi, just wanted to mention that TechCom has been reading along here. Let us know if you need our input and/or would like an IRC meeting for finding more options, or narrowing down options, or approving a specific option.TASK DETAILhttps://phabricator.wikimedia.org/T176312EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Halfak, Anomie, Smalyshev, tstarling, daniel, GWicke, Joe, Lucas_Werkmeister_WMDE, Krinkle, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, merbst, LawExplorer, Agabi10, SBisson, Wikidata-bugs, aude, jayvdb, fbstj, santhosh, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Ltrlg, bd808, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T200340: Wikibase\DataModel\Entity\EntityIdParsingException $serialization must not be an empty string

[Krinkle]

Krinkle removed a parent task: T191060: 1.32.0-wmf.14 deployment blockers.
TASK DETAILhttps://phabricator.wikimedia.org/T200340EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, KrinkleCc: Pablo-WMDE, Addshore, Ladsgroup, gerritbot, Krinkle, TerraCodes, Liuxinyu970226, Aklapper, zeljkofilipin, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T200340: Wikibase\DataModel\Entity\EntityIdParsingException $serialization must not be an empty string

[Krinkle]

Krinkle removed a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T200340EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, KrinkleCc: Pablo-WMDE, Addshore, Ladsgroup, gerritbot, Krinkle, TerraCodes, Liuxinyu970226, Aklapper, zeljkofilipin, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Krenair, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T200340: Wikibase\DataModel\Entity\EntityIdParsingException $serialization must not be an empty string

[Krinkle]

Krinkle added a project: Wikimedia-log-errors.
TASK DETAILhttps://phabricator.wikimedia.org/T200340EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Addshore, Ladsgroup, gerritbot, Krinkle, TerraCodes, Liuxinyu970226, Aklapper, zeljkofilipin, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Edited] T200340: Wikibase\DataModel\Entity\EntityIdParsingException $serialization must not be an empty string

[Krinkle]

Krinkle updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...[{exception_id}] {exception_url} Wikibase\DataModel\Entity\EntityIdParsingException from line 49 of /srv/mediawiki/php-1.32.0-wmf.13/vendor/wikibase/data-model/src/Entity/DispatchingEntityIdParser.php: $serialization must not be an empty string 

server: www.wikidata.org
method: POST
url: /w/api.php

exception_id: W1iQPQpAMDgAAB7gqzID
exception.trace:

#0 /srv/mediawiki/php-1.32.0-wmf.13/vendor/wikibase/data-model/src/Entity/EntityId.php(89): Wikibase\DataModel\Entity\EntityId::assertValidSerialization(string)
#1 /srv/mediawiki/php-1.32.0-wmf.13/vendor/wikibase/data-model/src/Entity/DispatchingEntityIdParser.php(45): Wikibase\DataModel\Entity\EntityId::splitSerialization(string)
#2 /srv/mediawiki/php-1.32.0-wmf.13/extensions/Wikibase/repo/includes/WikibaseRepo.php(1459): Wikibase\DataModel\Entity\DispatchingEntityIdParser->parse(string)
#3 /srv/mediawiki/php-1.32.0-wmf.13/vendor/data-values/serialization/src/Deserializers/DataValueDeserializer.php(122): Closure$Wikibase\Repo\WikibaseRepo::getDataValueDeserializer(array)
#4 /srv/mediawiki/php-1.32.0-wmf.13/vendor/data-values/serialization/src/Deserializers/DataValueDeserializer.php(91): DataValues\Deserializers\DataValueDeserializer->getDeserialization(array)
#5 /srv/mediawiki/php-1.32.0-wmf.13/vendor/wikibase/data-model-serialization/src/Deserializers/SnakDeserializer.php(118): DataValues\Deserializers\DataValueDeserializer->deserialize(array)
#6 /srv/mediawiki/php-1.32.0-wmf.13/vendor/wikibase/data-model-serialization/src/Deserializers/SnakDeserializer.php(108): Wikibase\DataModel\Deserializers\SnakDeserializer->deserializeDataValue(array)
#7 /srv/mediawiki/php-1.32.0-wmf.13/vendor/wikibase/data-model-serialization/src/Deserializers/SnakDeserializer.php(90): Wikibase\DataModel\Deserializers\SnakDeserializer->newValueSnak(array)
#8 /srv/mediawiki/php-1.32.0-wmf.13/vendor/wikibase/data-model-serialization/src/Deserializers/SnakDeserializer.php(72): Wikibase\DataModel\Deserializers\SnakDeserializer->getDeserialized(array)
#9 /srv/mediawiki/php-1.32.0-wmf.13/vendor/wikibase/data-model-serialization/src/Deserializers/StatementDeserializer.php(110): Wikibase\DataModel\Deserializers\SnakDeserializer->deserialize(array)
#10 /srv/mediawiki/php-1.32.0-wmf.13/vendor/wikibase/data-model-serialization/src/Deserializers/StatementDeserializer.php(100): Wikibase\DataModel\Deserializers\StatementDeserializer->getDeserialized(array)
#11 /srv/mediawiki/php-1.32.0-wmf.13/extensions/Wikibase/repo/includes/Api/SetClaim.php(191): Wikibase\DataModel\Deserializers\StatementDeserializer->deserialize(array)
#12 /srv/mediawiki/php-1.32.0-wmf.13/extensions/Wikibase/repo/includes/Api/SetClaim.php(109): Wikibase\Repo\Api\SetClaim->getStatementFromParams(array)
#13 /srv/mediawiki/php-1.32.0-wmf.13/includes/api/ApiMain.php(1582): Wikibase\Repo\Api\SetClaim->execute()
#14 /srv/mediawiki/php-1.32.0-wmf.13/includes/api/ApiMain.php(535): ApiMain->executeAction()
#15 /srv/mediawiki/php-1.32.0-wmf.13/includes/api/ApiMain.php(506): ApiMain->executeActionWithErrorHandling()
#16 /srv/mediawiki/php-1.32.0-wmf.13/api.php(83): ApiMain->execute()
#17 /srv/mediawiki/w/api.php(3): include(string)
#18 {main}
```TASK DETAILhttps://phabricator.wikimedia.org/T200340EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Addshore, Ladsgroup, gerritbot, Krinkle, TerraCodes, Liuxinyu970226, Aklapper, zeljkofilipin, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Retitled] T200072: MCR broke Undelete action (and made Cognate tests fail) "The given Title does not belong to page ID"

[Krinkle]

Krinkle renamed this task from "MCR causes Cognate integration test fails: The given Title does not belong to page ID 2 but actually belongs to 4" to "MCR broke Undelete action (and made Cognate tests fail) "The given Title does not belong to page ID"".Krinkle edited projects, added MediaWiki-Page-deletion, Wikimedia-log-errors; removed Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T200072EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Anomie, KrinkleCc: Stashbot, Liuxinyu970226, daniel, zeljkofilipin, TerraCodes, greg, Anomie, Krinkle, gerritbot, Tobi_WMDE_SW, Addshore, hashar, Aklapper, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, JJMC89, Agabi10, Susannaanas, Thibaut120094, Aschroet, Fjalapeno, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Darkdadaah, Steinsplitter, Mbch331, Jay8g, Ltrlg, Krenair, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Edited] T199855: WikidataPageBanner breaks Vector page subtitle

[Krinkle]

Krinkle updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...| {F23876255}| {F23875640}
| {F23876682} | {F23875941}...TASK DETAILhttps://phabricator.wikimedia.org/T199855EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Aklapper, Krinkle, Lahi, Gq86, GoranSMilovanovic, Jrbranaa, QZanden, LawExplorer, Winter, Wong128hk, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Created] T199855: WikidataPageBanner breaks Vector page subtitle

[Krinkle]

Krinkle created this task.Krinkle added a project: Wikidata-Page-Banner.Herald added a subscriber: Aklapper.Herald added a project: Wikidata.
TASK DESCRIPTIONI've noticed this on test2.wikipedia.org where the extension was enabled.


F23876255: capture3.pngF23875640: capture.pngF23875941: capture2.png



The subtitle is meant to be inside a div#contentSub element, which is styled with a grey text color and a smaller font-size.

However, on wikis where WikidataPageBanner is enabled the subtitle is absent, and its contents are instead output inside a custom div.ext-wpb-pagebanner-subtitle element, which is missing the correct positioning and styling.

Traced it down to the following code:


https://gerrit.wikimedia.org/g/mediawiki/extensions/WikidataPageBanner/+/7d39c374cc589d9ecd714976d5508ca5f6b133c9/includes/WikidataPageBanner.hooks.php#44
rEWDP7d39c374cc58: Allow skins to render subtitle after banner
T113642: Should be possible to print breadcrumbs above the heading to avoid reflows on Wikivoyage
TASK DETAILhttps://phabricator.wikimedia.org/T199855EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Aklapper, Krinkle, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T199855: WikidataPageBanner breaks Vector page subtitle

[Krinkle]

Krinkle added projects: Regression, Readers-Web-Backlog.
TASK DETAILhttps://phabricator.wikimedia.org/T199855EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Aklapper, Krinkle, Lahi, Gq86, GoranSMilovanovic, Jrbranaa, QZanden, LawExplorer, Winter, Wong128hk, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T197616: Create a production test wiki in group0 to parallel Wikimedia Commons

[Krinkle]

Krinkle added a comment.

In T197616#4297600, @daniel wrote:
The beta setup is probably not going to cover all the angles for e.g. wikibase change propagation.


Can we fix that in Beta Cluster?

I do not think it is unreasonable to require new projects to work properly in Beta Cluster from day -1. Missing dependencies should be provisioned first.

I don't know the internals of Wikibase changeprop, but if it is a blocker to gaining confidence in SDC testing, it is probably also significant for general testing in Beta Cluster. Continued absence of it, would decrease value of overall QA efforts, and the efforts from other teams currently operating their services in Beta Cluster.TASK DETAILhttps://phabricator.wikimedia.org/T197616EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, Liuxinyu970226, Jdforrester-WMF, Fjalapeno, Abit, Aklapper, greg, Reedy, CCicalese_WMF, daniel, Lahi, PDrouin-WMF, Gq86, E1presidente, JunaidHafeez, Ramsey-WMF, Cparle, BJ6123C7BTD, Anooprao, SandraF_WMF, GoranSMilovanovic, Jayprakash12345, QZanden, Tramullas, Acer, Zoranzoki21, LawExplorer, DatGuy, Devwaker, Niklitov, Urbanecm, Liudvikas, JEumerus, StevenJ81, Susannaanas, Tulsi_Bhagat, Wong128hk, Luke081515, SimmeD, Aschroet, Jane023, Wikidata-bugs, Snowolf, Base, matthiasmullie, aude, Dcljr, Ebe123, Koavf, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, zeljkofilipin, Rschen7754, Steinsplitter, Matanya, Mbch331, Rxy, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Closed] T196351: Fatal error: Call to undefined method Wikibase\\Lexeme\\DataModel\\Lexeme::getRepresentations()

[Krinkle]

Krinkle closed this task as "Resolved".Krinkle claimed this task.Krinkle added a comment.
Not seen in production in the last 30 days (php-1.32.0-wmf.8, php-1.32.0-wmf.10, php-1.32.0-wmf.12). Must've been fixed or rendered unreachable in wmf.7.TASK DETAILhttps://phabricator.wikimedia.org/T196351EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, WMDE-leszek, Addshore, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T162555: Stop using MockTermIndex

[Krinkle]

Krinkle edited projects, added Technical-Debt; removed Technical-Debt (Deprecation).
TASK DETAILhttps://phabricator.wikimedia.org/T162555EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: aude, Aklapper, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Wikidata-bugs, Dinoguy1000, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T123221: [Task] Remove IE8 workarounds from Wikibase

[Krinkle]

Krinkle edited projects, added Technical-Debt; removed Technical-Debt (Deprecation).
TASK DETAILhttps://phabricator.wikimedia.org/T123221EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, gerritbot, Ladsgroup, Ricordisamoa, Jonas, adrianheine, thiemowmde, StudiesWorld, Legoktm, Aklapper, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, Jayprakash12345, JakeTheDeveloper, QZanden, merbst, LawExplorer, Wikidata-bugs, aude, Dinoguy1000, TheDJ, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T143038: Remove use of jquery.tipsy in Wikibase

[Krinkle]

Krinkle edited projects, added Technical-Debt; removed Technical-Debt (Deprecation).
TASK DETAILhttps://phabricator.wikimedia.org/T143038EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: MZMcBride, Addshore, thiemowmde, Jonas, Aklapper, Jdforrester-WMF, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, enigmaeth, rohitt, LawExplorer, Dixtosa, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T143038: Remove use of jquery.tipsy in Wikibase

[Krinkle]

Krinkle edited projects, added Technical-Debt (Deprecation); removed Technical-Debt.
TASK DETAILhttps://phabricator.wikimedia.org/T143038EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: MZMcBride, Addshore, thiemowmde, Jonas, Aklapper, Jdforrester-WMF, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, enigmaeth, rohitt, LawExplorer, Dixtosa, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T123221: [Task] Remove IE8 workarounds from Wikibase

[Krinkle]

Krinkle edited projects, added Technical-Debt (Deprecation); removed Technical-Debt.
TASK DETAILhttps://phabricator.wikimedia.org/T123221EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, gerritbot, Ladsgroup, Ricordisamoa, Jonas, adrianheine, thiemowmde, StudiesWorld, Legoktm, Aklapper, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, Jayprakash12345, JakeTheDeveloper, QZanden, merbst, LawExplorer, Wikidata-bugs, aude, Dinoguy1000, TheDJ, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T162555: Stop using MockTermIndex

[Krinkle]

Krinkle edited projects, added Technical-Debt (Deprecation); removed Technical-Debt.
TASK DETAILhttps://phabricator.wikimedia.org/T162555EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: aude, Aklapper, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Wikidata-bugs, Dinoguy1000, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T98033: [Task] Drop API-Style wrapper from JSON output of Special:EntityData

[Krinkle]

Krinkle edited projects, added Technical-Debt (Deprecation); removed Technical-Debt.
TASK DETAILhttps://phabricator.wikimedia.org/T98033EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: PokestarFan, Addshore, Aklapper, daniel, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T98035: [Task] Drop support for php-serialized output from Special:EntityData

[Krinkle]

Krinkle edited projects, added Technical-Debt (Deprecation); removed Technical-Debt.
TASK DETAILhttps://phabricator.wikimedia.org/T98035EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Addshore, PokestarFan, Jonas, thiemowmde, gerritbot, daniel, Aklapper, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T191282: Wikimedia\Rdbms\LoadBalancer::{closure}: found writes pending

[Krinkle]

Krinkle removed projects: MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Patch-For-Review, Analytics.Herald added a project: Analytics.
TASK DETAILhttps://phabricator.wikimedia.org/T191282EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Joe, Ladsgroup, hoo, RazShuty, gerritbot, Tgr, Pchelolo, mmodell, Marostegui, aaron, mobrovac, Aklapper, jcrespo, Rayssa-, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Eevans, JAllemandou, Hardikj, Wikidata-bugs, aude, GWicke, Mbch331, Jay8g, Krenair, jeremyb, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Declined] T178810: Wikibase: Increase batch size for HTMLCacheUpdateJobs triggered by repo changes.

[Krinkle]

Krinkle closed this task as "Declined".Krinkle added a comment.
Closing out as this seems specific to the old Redis-based JobQueue and JobRunner that are no longer as of last week. Please re-open if it still applies.TASK DETAILhttps://phabricator.wikimedia.org/T178810EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Aklapper, aude, thiemowmde, hoo, Ladsgroup, Krinkle, Joe, daniel, AndyTan, Davinaclare77, Qtn1293, Lahi, Gq86, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, LawExplorer, Zppix, Wong128hk, Wikidata-bugs, faidon, Mbch331, Jay8g, fgiunchedi___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Unblock] T173710: Job queue is increasing non-stop

[Krinkle]

Krinkle closed subtask T178810: Wikibase: Increase batch size for HTMLCacheUpdateJobs triggered by repo changes. as "Declined".
TASK DETAILhttps://phabricator.wikimedia.org/T173710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, KrinkleCc: Jeff_G, Addshore, zhuyifei1999, RP88, Jack_who_built_the_house, elukey, debt, mxn, Daimona, YOUR1, Tbayer, mobrovac, Nikerabbit, Mholloway, Legoktm, ema, Joe, GWicke, Nemo_bis, Andreasmperu, BBlack, Peachey88, daniel, Stashbot, Agabi10, Daniel_Mietchen, Pasleim, Bugreporter, Sjoerddebruin, Magnus, Mr.Ibrahem, gerritbot, EBernhardson, Esc3300, jcrespo, WMDE-leszek, Jdforrester-WMF, Krinkle, aaron, fgiunchedi, Aklapper, Ladsgroup, AndyTan, Davinaclare77, Qtn1293, Imarlier, Lahi, Gq86, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, LawExplorer, Vali.matei, Zppix, Wong128hk, Eevans, Hardikj, Wikidata-bugs, aude, faidon, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Closed] T124418: Investigate massive increase in htmlCacheUpdate jobs in Dec/Jan

[Krinkle]

Krinkle closed this task as "Resolved".Krinkle assigned this task to aaron.Krinkle moved this task from External to Ours done on the Performance-Team (Radar) board.Krinkle added a comment.
Marking as resolved for now given the new JobQueue based on EventBus. If the rate remains an issue, or becomes an issue again, we should file a new task for that.TASK DETAILhttps://phabricator.wikimedia.org/T124418WORKBOARDhttps://phabricator.wikimedia.org/project/board/2923/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: aaron, KrinkleCc: PokestarFan, Gilles, GWicke, ArielGlenn, Krinkle, Peter, EBernhardson, Smalyshev, gerritbot, Legoktm, daniel, hoo, aude, Lydia_Pintscher, JanZerebecki, MZMcBride, Luke081515, aaron, faidon, Joe, ori, BBlack, Aklapper, AndyTan, Davinaclare77, Qtn1293, Imarlier, Lahi, Gq86, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, LawExplorer, Vali.matei, Zppix, Wong128hk, Wikidata-bugs, Mbch331, Jay8g, fgiunchedi___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198816: WikibaseRepo "dataRightsUrl " setting should not bypass MediaWiki's configuration logic

[Krinkle]

Krinkle added a comment.
By the way, while it's fine for this setting to exist in Wikibase, it's worth checking whether it still has a use case. A simpler solution is always to remove code :)TASK DETAILhttps://phabricator.wikimedia.org/T198816EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Aklapper, Krinkle, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Created] T198816: WikibaseRepo "dataRightsUrl " setting should not bypass MediaWiki's configuration logic

[Krinkle]

Krinkle created this task.Krinkle added projects: MediaWiki-extensions-WikibaseRepository, Technical-Debt.Herald added a subscriber: Aklapper.Herald added a project: Wikidata.
TASK DESCRIPTIONCurrently Wikibase has its own dataRightsUrl setting that defaults to core's setting of wgRightsUrl.

This is a problem because the core variable is documented as being a fallback for $wgRightsPage. Which means sites may configure wgRightsUrl and have forgotten about it (e.g incorrect or invalid value) and reasonably expect it to not be used when they have already $wgRightsPage, which has precedence.

However, Wikibase's logic is bypassing this and using it directly.

For Wikimedia production, this isn't currently an issue as wmf-config assigns it directly:

$wgWBRepoSettings['dataRightsUrl'] = 'https://creativecommons.org/publicdomain/zero/1.0/';

I propose that once MediaWiki's core access for this variable is abstracted, Wikibase can use that instead. Which means that the fallback URL will automatically be determined by core based on either of these variables.

See https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/443528/ for the on-going work on that abstraction.TASK DETAILhttps://phabricator.wikimedia.org/T198816EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Aklapper, Krinkle, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T73461: [hhvm] MemcachedPeclBagOStuff.php: Error at offset 0 of 6 bytes

[Krinkle]

Krinkle closed this task as a duplicate of T184854: hhvm memcached and php7 memcached extensions do not play well together.Herald added a project: Wikidata.
TASK DETAILhttps://phabricator.wikimedia.org/T73461EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Wikidata-bugs, ori, aude, daniel, Unknown Object (MLST), Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T193858: Make monolingual text datatype indexable in wikibase

[Krinkle]

Krinkle removed projects: Hashtags, Gamepress, Tamil-Sites.
TASK DETAILhttps://phabricator.wikimedia.org/T193858EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Cparle, KrinkleCc: Aklapper, GerritBot, Cparle, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331, AndyTan, Zylc, 1978Gage2001, Chicocvenancio, Tbscho, JJMC89, srodlund, Gryllida, scfc, Krenair, chasemp___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

[Krinkle]

Krinkle added a comment.

In T173949#4312026, @Physikerwelt wrote:
I think a good solution is that the Math extension follows the standard procedure for all tag extensions that require custom CSS and js for their content. Is there a good example of such an extension?


Yes.


SyntaxHighlighter: SyntaxHighlight#parserHook.
Kartographer: MapLink.php#L24-L26, MapFrame.php#L33-L99.
TASK DETAILhttps://phabricator.wikimedia.org/T173949EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Agabi10, gerritbot, Physikerwelt, Krinkle, brion, Niedzielski, greg, TerraCodes, Liuxinyu970226, Peter, Jdlrobson, Volker_E, Aklapper, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Imarlier, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Maosef, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Winter, Vali.matei, Lewizho99, JJMC89, Maathavan, Debenben, Bianjiang, Izno, Nirmos, Cwek, Wikidata-bugs, Hydriz, aude, fredw, Pkra, Dinoguy1000, ssastry, scfc, Arlolra, Jackmcbarn, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Unblock] T195520: Multiple projects reporting Cannot access the database: No working replica DB server

[Krinkle]

Krinkle closed subtask T195525: MWExceptionRenderer.php doesn't always declare the encoding used. as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T195520EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, KrinkleCc: Jdforrester-WMF, Mateusz_Konieczny, eranroz, MichaelSchoenitzer_WMDE, Tractopelle-jaune, Florian, Jeff_G, Vachovec1, Tbayer, Ivanhercaz, Lixxx235, Stashbot, Addshore, MrFulano, daniel, Lydia_Pintscher, Tarawneh, PetrohsW, Sunpriat2, Ladsgroup, Legoktm, gerritbot, Thryduulf, matmarex, Krenair, dgstranz, Cirdan, Amorymeltzer, Yarl, Doc_James, Masti, Wiki-1776, Baloch007, abian, Pigsonthewing, putnik, Classicwiki, Jarekt, Jayprakash12345, 1339861mzb, KTC, Bharel, Daimona, Smartyllama, ToBeFree, Paladox, Urbanecm, Davey2010, alanajjar, Mh-3110, Lucas_Werkmeister_WMDE, JEumerus, Samtar, Lofhi, Marostegui, TerraCodes, Framawiki, Mainframe98, Stryn, Aklapper, Boshomi, AndyTan, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Davinaclare77, Adrian1985, Qtn1293, Cpaulf30, Lahi, Gq86, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Hfbn0, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Zppix, Maathavan, Wong128hk, Wikidata-bugs, aude, ArielGlenn, faidon, He7d3r, Mbch331, Jay8g, fgiunchedi, greg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T173949: ext.math.styles is sometimes loaded when not needed - causing CSS size in production to fluctuate - parser cache pollution?

[Krinkle]

Krinkle removed a project: Performance.
TASK DETAILhttps://phabricator.wikimedia.org/T173949EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Physikerwelt, Krinkle, brion, Niedzielski, greg, TerraCodes, Liuxinyu970226, Peter, Jdlrobson, Volker_E, Aklapper, Imarlier, Lahi, Gq86, GoranSMilovanovic, Maosef, QZanden, LawExplorer, Winter, Vali.matei, JJMC89, Debenben, Bianjiang, Nirmos, Cwek, Wikidata-bugs, aude, fredw, Pkra, Dinoguy1000, ssastry, scfc, Arlolra, Jackmcbarn, Mbch331, Darkminds3113, GWicke, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T173949: ext.math.styles is sometimes loaded when not needed - causing CSS size in production to fluctuate - parser cache pollution?

[Krinkle]

Krinkle added a comment.
@Jdlrobson It does indeed appear to be a bug somewhere relating to cache pollution, in particular it seems a cache key somewhere is being shared between mobile and desktop that shouldn't be.

I can reproduce the following in Incognito mode (with disabled cache):


(Desktop) View https://en.wikipedia.org/wiki/Barack_Obama, check Dev Tools/Network/CSS. Observe main stylesheet does not include ext.math.styles.
(Mobile) View https://en.m.wikipedia.org/wiki/Barack_Obama, observe the main stylesheet includes ext.math.styles.
(Mobile purge) https://en.m.wikipedia.org/wiki/Barack_Obama?action="">, confirm. Then reload https://en.m.wikipedia.org/wiki/Barack_Obama, observe the main stylesheet still includes ext.math.styles.
(Desktop) View https://en.wikipedia.org/wiki/Barack_Obama, observe the main stylesheet now also includes ext.math.styles.
(Desktop purge) View https://en.wikipedia.org/wiki/Barack_Obama?action="">, confirm. Reload and confirm it is no longer included on desktop.  (Mobile) View https://en.m.wikipedia.org/wiki/Barack_Obama, observe the main stylesheet does not include ext.math.styles.



Point 1Point 2Point 3
F22262922: cap1-desktop.pngF22263103: cap3-mobile.pngF22263104: cap2-mobile.png






Point 4Point 5
F22263105: cap5-mobile.pngF22263106: cap4-desktop.png



So it seems that whenever the last purge came from mobile, the module is included, whenever the last purge came from desktop, it is (correctly) not included.

I'd recommend trying to reproduce it locally, and on Beta Cluster, and on different production wikis. That would help narrow it down somewhat.TASK DETAILhttps://phabricator.wikimedia.org/T173949EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Physikerwelt, Krinkle, brion, Niedzielski, greg, TerraCodes, Liuxinyu970226, Peter, Jdlrobson, Volker_E, Aklapper, Imarlier, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, Maosef, QZanden, LawExplorer, Winter, Vali.matei, JJMC89, Debenben, Bianjiang, Nirmos, Cwek, Wikidata-bugs, aude, fredw, GWicke, Pkra, Dinoguy1000, ssastry, scfc, Arlolra, Jackmcbarn, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T123221: [Task] Remove IE8 workarounds from Wikibase

[Krinkle]

Krinkle added subscribers: gerritbot, Krinkle.Krinkle added a comment.

In T123218#3916627, @gerritbot wrote:
[mediawiki/extensions/Wikibase@master] Remove some of IE8 hacks (wikibase/templates.js) 
 https://gerrit.wikimedia.org/r/392663


TASK DETAILhttps://phabricator.wikimedia.org/T123221EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, gerritbot, Ladsgroup, Ricordisamoa, Jonas, adrianheine, thiemowmde, StudiesWorld, Legoktm, Aklapper, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, Jayprakash12345, JakeTheDeveloper, QZanden, LawExplorer, Wikidata-bugs, aude, Dinoguy1000, TheDJ, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T195906: Phan fails for Wikibase on wmf.x branches

[Krinkle]

Krinkle removed a project: Wikimedia-log-errors (Shared Build Failure).
TASK DETAILhttps://phabricator.wikimedia.org/T195906EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Jdforrester-WMF, TerraCodes, Liuxinyu970226, Stashbot, Legoktm, Lucas_Werkmeister_WMDE, Aklapper, thcipriani, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331, Volker_E, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T189538: Reduce complexity of Wikibase JS module registration

[Krinkle]

Krinkle added a comment.
The remaining work here is to apply "Reduce indirection in resources files" to the rest of Wikibase. The above commit (https://gerrit.wikimedia.org/r/419334) was merely an example for one of the modules (view/wikibase-data-model).TASK DETAILhttps://phabricator.wikimedia.org/T189538EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Lydia_Pintscher, gerritbot, thiemowmde, WMDE-leszek, Addshore, Aklapper, Krinkle, Imarlier, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T189538: Reduce complexity of Wikibase JS module registration

[Krinkle]

Krinkle removed projects: MW-1.32-release-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)), MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Patch-For-Review.Krinkle updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...* [x]  / {e9b71a058b24}
* [ * [x]  / {d4f0dd2b51dfeef95abb4edae3bff349e27f2541}
* .. 

---...TASK DETAILhttps://phabricator.wikimedia.org/T189538EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Lydia_Pintscher, gerritbot, thiemowmde, WMDE-leszek, Addshore, Aklapper, Krinkle, Imarlier, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, Wikidata-bugs, aude, Mbch331, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T152185: Map code throwing JS exception on IE11 Windows 7 causing Pagebanner not to be shown and Common.js not running due to JS error thrown by leaflet

[Krinkle]

Krinkle added a project: Performance-Team.
TASK DETAILhttps://phabricator.wikimedia.org/T152185EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jdlrobson, KrinkleCc: Krinkle, gerritbot, JGirault, Massimo_Telo, Nicholas.tsg, Jdlrobson, ovasileva, Andyrom75, Aklapper, Imarlier, Winter, Vali.matei, Wikidata-bugs, Lydia_Pintscher___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T152185: Map code throwing JS exception on IE11 Windows 7 causing Pagebanner not to be shown and Common.js not running due to JS error thrown by leaflet

[Krinkle]

Krinkle added a comment.
@Jdlrobson Yes, there is some form of sandboxing at the level of module loading. Which means that if you define module "a" and "b" as a.js and b.js, and load them separately but in the same request with "a" before "b", then even if "a" throws an exception during initialisation (e.g. syntax error or some other error that happens when first executing the file), then "b" should still run without issue.

Can you still reproduce a problem locally when RelatedArticles is without the above patch? If so, could you try to make a more minimal test case that ends up with e.g. putting a certain piece of code in module X that makes it fail and something in module Y, where Y won't get executed?TASK DETAILhttps://phabricator.wikimedia.org/T152185EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jdlrobson, KrinkleCc: Krinkle, gerritbot, JGirault, Massimo_Telo, Nicholas.tsg, Jdlrobson, ovasileva, Andyrom75, Aklapper, Winter, Wikidata-bugs, Lydia_Pintscher___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T195906: Phan fails for Wikibase on wmf.x branches

[Krinkle]

Krinkle added a project: Wikidata.
TASK DETAILhttps://phabricator.wikimedia.org/T195906EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: TerraCodes, Liuxinyu970226, Stashbot, Legoktm, Lucas_Werkmeister_WMDE, Aklapper, thcipriani, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Volker_E, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Closed] T189329: jquery.wikibase qunit tests are flaky (Pending Ajax requests)

[Krinkle]

Krinkle closed this task as "Resolved".Krinkle claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T189329EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Tgr, hashar, gerritbot, Reedy, Krinkle, dcausse, Jdlrobson, hoo, Mbch331, Jonas, TerraCodes, Liuxinyu970226, Gilles, Daimona, WMDE-leszek, SBisson, Jdforrester-WMF, Lucas_Werkmeister_WMDE, Huji, Mholloway, Legoktm, Aklapper, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Volker_E, Wikidata-bugs, aude, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T195868: CI failures in php70: Undefined constant 'Wikibase\Client\Store\NS_MAIN'

[Krinkle]

Krinkle added a project: Wikidata.
TASK DETAILhttps://phabricator.wikimedia.org/T195868EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Stashbot, thcipriani, Legoktm, Liuxinyu970226, TerraCodes, Krinkle, Jdforrester-WMF, Aleksey_WMDE, daniel, Smalyshev, gerritbot, Ladsgroup, WMDE-leszek, Lucas_Werkmeister_WMDE, Aklapper, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Volker_E, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Edited] T191965: Structured Data on Wikimedia Commons: introduction and Q

[Krinkle]

Krinkle updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...* **Where**: Sala de projectes (QC/0011)
* Next session: {T194275}



What is #structured-data-commons? What is the team working on at this moment? Which new features will be rolled out this year? How can you contribute to the project? Got any feedback or requests for the developers and the whole team?...TASK DETAILhttps://phabricator.wikimedia.org/T191965EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Keegan, KrinkleCc: Edouard-lopez, Lahi, 0x010C, Rfarrand, jgleeson, Abit, Cparle, matthiasmullie, Aklapper, Abbe98, Mholloway, ESM, SandraF_WMF, Keegan, MarkTraceur, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Culex, Susannaanas, Aschroet, Jane023, Wikidata-bugs, PKM, Base, aude, Husky, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Edited] T191965: Structured Data on Wikimedia Commons: introduction and Q

[Krinkle]

Krinkle updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION* **When**: Friday 18 May, 16:00 - 17:00
* **Where**: Sala de projectes (QC/0011)



What is #structured-data-commons? What is the team working on at this moment? Which new features will be rolled out this year? How can you contribute to the project? Got any feedback or requests for the developers and the whole team?...@Keegan and @marktraceur introduce you to everything you need to know, and answer your questions.
TASK DETAILhttps://phabricator.wikimedia.org/T191965EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Keegan, KrinkleCc: Edouard-lopez, Lahi, 0x010C, Rfarrand, jgleeson, Abit, Cparle, matthiasmullie, Aklapper, Abbe98, Mholloway, ESM, SandraF_WMF, Keegan, MarkTraceur, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Culex, Susannaanas, Aschroet, Jane023, Wikidata-bugs, PKM, Base, aude, Husky, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T189329: jquery.wikibase qunit tests are flaky (Pending Ajax requests)

[Krinkle]

Krinkle added a comment.
it's unfortunate the unit tests didn't complain in this browser test. Anyway we can get these more isolated?

I'm not sure I understand. What exactly didn't complain where?TASK DETAILhttps://phabricator.wikimedia.org/T189329EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Tgr, hashar, gerritbot, Reedy, Krinkle, dcausse, Jdlrobson, hoo, Mbch331, Jonas, TerraCodes, Liuxinyu970226, Niharika, Gilles, Daimona, WMDE-leszek, SBisson, Jdforrester-WMF, Lucas_Werkmeister_WMDE, Huji, Mholloway, Legoktm, Aklapper, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Volker_E, Wikidata-bugs, aude, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T189329: jquery.wikibase qunit tests are flaky (Pending Ajax requests)

[Krinkle]

Krinkle removed a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T189329EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Tgr, hashar, gerritbot, Reedy, Krinkle, dcausse, Smalyshev, Jdlrobson, hoo, Mbch331, Jonas, TerraCodes, Liuxinyu970226, Niharika, Gilles, Daimona, WMDE-leszek, SBisson, Jdforrester-WMF, Lucas_Werkmeister_WMDE, Huji, Mholloway, Legoktm, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Volker_E, Wikidata-bugs, aude, Jay8g, Krenair, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Changed Project Column] T189329: jquery.wikibasea qunit tests are flaky (Pending Ajax requests)

[Krinkle]

Krinkle moved this task from Resolved to Backlog on the Wikimedia-log-errors (Jenkins Failure) board.Krinkle added a comment.
Still happening for

jquery.wikibase.sitelinkview
✖ Create and destroy
afterEach failed on Create and destroy: Pending AJAX requests: 0 (active: 3)TASK DETAILhttps://phabricator.wikimedia.org/T189329WORKBOARDhttps://phabricator.wikimedia.org/project/board/3298/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Tgr, hashar, gerritbot, Reedy, Krinkle, dcausse, Smalyshev, Jdlrobson, hoo, Mbch331, Jonas, TerraCodes, Liuxinyu970226, Niharika, Gilles, Daimona, WMDE-leszek, SBisson, Jdforrester-WMF, Lucas_Werkmeister_WMDE, Huji, Mholloway, Legoktm, Aklapper, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Volker_E, Wikidata-bugs, aude, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs