[Wikidata-bugs] [Maniphest] [Commented On] T223410: Split group1 so that Commons and Wikidata aren't in the general group1, but their own buckets

2020-05-27 Thread Krinkle
Krinkle added a comment. In T223410#5783502 <https://phabricator.wikimedia.org/T223410#5783502>, @mmodell wrote: > I generally like this proposal, however, I dislike the growing complexity of the groups and their naming. (I was thinking the same). I don't have a prefere

[Wikidata-bugs] [Maniphest] [Commented On] T248866: Consider having a linter that could catch config file entries that set unused variables

2020-05-27 Thread Krinkle
Krinkle added a comment. Does this help? https://wikitech.wikimedia.org/wiki/Technical_debt/Unused_config TASK DETAIL https://phabricator.wikimedia.org/T248866 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Jdforrester

[Wikidata-bugs] [Maniphest] [Commented On] T253624: Evaluate the future of wikibase-codesniffer

2020-05-26 Thread Krinkle
Krinkle added a comment. Note that `.phpcs` is controllable per repository. The same way that we disable some rules in repositories not yet ready to follow a newer convention, it is also possible to enable additional rules on a per-repo bases. So these rulesets could easily be put

[Wikidata-bugs] [Maniphest] [Retitled] T253366: PHPUnit warning from Wikibase\Lib\CachingKartographerEmbeddingHandlerTest

2020-05-21 Thread Krinkle
Krinkle renamed this task from "PHPUnit warnign from Wikibase\Lib\CachingKartographerEmbeddingHandlerTest" to "PHPUnit warning from Wikibase\Lib\CachingKartographerEmbeddingHandlerTest". Krinkle added a project: ci-test-error. TASK DETAIL https://phabricator.wikimedi

[Wikidata-bugs] [Maniphest] [Created] T253366: PHPUnit warnign from Wikibase\Lib\CachingKartographerEmbeddingHandlerTest

2020-05-21 Thread Krinkle
Krinkle created this task. Krinkle added projects: Wikidata, Wikidata-Campsite, MediaWiki-extensions-WikibaseClient. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION - Gerrit change for mediawiki/extension/Translate <https://gerrit.wikimedia.org/r/#/c/mediawiki/extensi

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

2020-05-19 Thread Krinkle
Krinkle added a comment. Seen on www.wikidata.org as well. - reqId: `4a83c7b9-dff6-4185-9a7d-b9dac050a1ab` - reqId: `a0bb4945-e080-4b41-a402-4c0edb562eff` - reqId: `081d5f57-ff6a-4f29-9971-fa722d7eae6b` - reqId: `df03dd06-c3cd-4853-b04a-dba00183800f` wikidatawiki /w

[Wikidata-bugs] [Maniphest] [Declined] T122520: Error running `extensions/Wikibase/lib/maintenance/populateSitesTable.php --force-protocol https` on jbowiki

2020-05-17 Thread Krinkle
Krinkle closed this task as "Declined". TASK DETAIL https://phabricator.wikimedia.org/T122520 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Ladsgroup, Krinkle, Stashbot, Reedy, hoo, Aklapper, Krenair, StudiesWorld, dar

[Wikidata-bugs] [Maniphest] [Unblock] T158751: Make populateSitesTable.php more robust

2020-05-17 Thread Krinkle
Krinkle closed subtask T122520: Error running `extensions/Wikibase/lib/maintenance/populateSitesTable.php --force-protocol https` on jbowiki as Declined. TASK DETAIL https://phabricator.wikimedia.org/T158751 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Commented On] T252091: RFC: Site-wide edit rate limiting with PoolCounter

2020-05-13 Thread Krinkle
Krinkle added a comment. @Ladsgroup wrote: > […] The edit rate on this wiki has been going up to 1,000 edits per minute and has been testing our infrastructure scalability […] The edits have been mostly done by bots […] and bot operators want to edit in full speed w

[Wikidata-bugs] [Maniphest] [Retitled] T252061: [data-update-failed]: Avoiding infinite loop due to possibily undetectable existing records (Wikibase DataUpdateAdapter)

2020-05-13 Thread Krinkle
Krinkle renamed this task from "DeferredUpdates: PHP Warning: [data-update-failed]: A data update callback triggered an exception" to " [data-update-failed]: Avoiding infinite loop due to possibily undetectable existing records (Wikibase DataUpdateAdapter)".

[Wikidata-bugs] [Maniphest] [Unblock] T95663: [Story] Use composer-merge-plugin to include Wikidata components in mediawiki-vendor

2020-05-11 Thread Krinkle
Krinkle closed subtask T90303: Fetch dependencies using composer instead of cloning mediawiki/vendor for non-wmf branches as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T95663 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc

[Wikidata-bugs] [Maniphest] [Unblock] T110172: [Task] Make Wikibase-JavaScript-API testextension job run composer

2020-05-11 Thread Krinkle
Krinkle closed subtask T90303: Fetch dependencies using composer instead of cloning mediawiki/vendor for non-wmf branches as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T110172 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki

[Wikidata-bugs] [Maniphest] [Unblock] T107834: [Task] change phpunit CI job for Wikidata.org to use composer

2020-05-11 Thread Krinkle
Krinkle closed subtask T90303: Fetch dependencies using composer instead of cloning mediawiki/vendor for non-wmf branches as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T107834 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki

[Wikidata-bugs] [Maniphest] [Unblock] T86176: Fix Job for running WBJSAPI QUnit tests on Jenkins

2020-05-11 Thread Krinkle
Krinkle closed subtask T90303: Fetch dependencies using composer instead of cloning mediawiki/vendor for non-wmf branches as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T86176 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki

[Wikidata-bugs] [Maniphest] [Commented On] T249587: Wikidata API wbgetentities: Allowed memory size exceeded

2020-05-07 Thread Krinkle
Krinkle added a comment. --- a/includes/api/ApiResult.php +++ b/includes/api/ApiResult.php @@ -396,9 +396,15 @@ class ApiResult implements ApiSerializable { if ( !( $flags & self::NO_SIZE_CHECK ) ) { // self::size needs the validated value. Then

[Wikidata-bugs] [Maniphest] [Updated] T251876: wbsgetsuggestions RevisionedUnresolvedRedirectException logspam

2020-05-06 Thread Krinkle
Krinkle removed a project: Wikimedia-production-error. TASK DETAIL https://phabricator.wikimedia.org/T251876 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Aklapper, WMDE-leszek, Ladsgroup, Addshore, Iflorez, darthmon_wmde

[Wikidata-bugs] [Maniphest] [Updated] T251878: UpdateRepoOnMove RevisionedUnresolvedRedirectException logspam

2020-05-06 Thread Krinkle
Krinkle removed a project: Wikimedia-production-error. TASK DETAIL https://phabricator.wikimedia.org/T251878 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Aklapper, WMDE-leszek, Ladsgroup, Addshore, Iflorez, darthmon_wmde

[Wikidata-bugs] [Maniphest] [Updated] T251880: Special:Search RevisionedUnresolvedRedirectException logspam

2020-05-06 Thread Krinkle
Krinkle removed a project: Wikimedia-production-error. TASK DETAIL https://phabricator.wikimedia.org/T251880 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Aklapper, WMDE-leszek, Ladsgroup, Addshore, Iflorez, darthmon_wmde

[Wikidata-bugs] [Maniphest] [Commented On] T251457: LoadBalancer: Transaction spent [n] second(s) in writes, exceeding the limit of [n]

2020-04-30 Thread Krinkle
Krinkle added a comment. @daniel How did it work before? What needed to change? What actually changed? TASK DETAIL https://phabricator.wikimedia.org/T251457 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Agusbou2015, Pchelolo, daniel

[Wikidata-bugs] [Maniphest] [Updated] T251538: bridge selenium: 'back from a save' errorHandling times out

2020-04-30 Thread Krinkle
Krinkle removed a project: ci-test-error (WMF-deployed Build Failure). TASK DETAIL https://phabricator.wikimedia.org/T251538 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Lucas_Werkmeister_WMDE, Jakob_WMDE, Aklapper, Pablo-WMDE, Sarai

[Wikidata-bugs] [Maniphest] [Updated] T224546: Make WikibaseLexeme browser tests less flaky

2020-04-30 Thread Krinkle
Krinkle removed a project: ci-test-error (WMF-deployed Build Failure). TASK DETAIL https://phabricator.wikimedia.org/T224546 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Michael, Tarrow, Jdforrester-WMF, Liuxinyu970226, SBisson

[Wikidata-bugs] [Maniphest] [Updated] T251457: LoadBalancer: Transaction spent [n] second(s) in writes, exceeding the limit of [n]

2020-04-30 Thread Krinkle
Krinkle added a parent task: T249962: 1.35.0-wmf.30 deployment blockers. TASK DETAIL https://phabricator.wikimedia.org/T251457 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Jdforrester-WMF, Krinkle, Marostegui, Liuxinyu970226, brennen

[Wikidata-bugs] [Maniphest] [Commented On] T251457: LoadBalancer: Transaction spent [n] second(s) in writes, exceeding the limit of [n]

2020-04-30 Thread Krinkle
Krinkle added a comment. Definitely a new problem, and it is causing about 200 user actions per hour to be aborted/prevented (presumably edits, but may be other stuff as well). F31788692: Screenshot 2020-04-30 at 18.22.38.png <https://phabricator.wikimedia.org/F31788692> TASK

[Wikidata-bugs] [Maniphest] [Changed Project Column] T250728: Wikibase Client data-bridge selenium test failure

2020-04-23 Thread Krinkle
Krinkle moved this task from Backlog to WMF-deployed Build Failure on the ci-test-error board. Krinkle edited projects, added ci-test-error (WMF-deployed Build Failure); removed ci-test-error. TASK DETAIL https://phabricator.wikimedia.org/T250728 WORKBOARD https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Closed] T157651: sql.php must not run LoadExtensionSchemaUpdates

2020-04-21 Thread Krinkle
Krinkle closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T157651 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel, Krinkle Cc: Demian, Jdforrester-WMF, kostajh, WMDE-leszek, Addshore, Anomie, alaa_wmd

[Wikidata-bugs] [Maniphest] [Commented On] T157651: sql.php must not run LoadExtensionSchemaUpdates

2020-04-21 Thread Krinkle
Krinkle added a comment. In T157651#4765173 <https://phabricator.wikimedia.org/T157651#4765173>, @gerritbot wrote: > [mediawiki/core@master] Structure test for wrong calls in LoadExtensionSchemaUpdates > https://gerrit.wikimedia.org/r/475065 @daniel I noticed a patc

[Wikidata-bugs] [Maniphest] [Retitled] T157651: sql.php must not run LoadExtensionSchemaUpdates

2020-04-21 Thread Krinkle
Krinkle renamed this task from "sql.php runs LoadExtensionSchemaUpdates" to "sql.php must not run LoadExtensionSchemaUpdates". TASK DETAIL https://phabricator.wikimedia.org/T157651 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To

[Wikidata-bugs] [Maniphest] [Updated] T65015: [Bug] SpamBlacklist hook causes Wikibase LinkTitle api phpunit tests to fail

2020-04-19 Thread Krinkle
Krinkle removed a subscriber: wikibugs-l-list. Krinkle removed a project: ci-test-error (WMF-deployed Build Failure). TASK DETAIL https://phabricator.wikimedia.org/T65015 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Umherirrender

[Wikidata-bugs] [Maniphest] [Updated] T227266: Find out why 'old revisions do not have edit links' selenium test is flaky on CI

2020-04-19 Thread Krinkle
Krinkle removed a project: ci-test-error (WMF-deployed Build Failure). TASK DETAIL https://phabricator.wikimedia.org/T227266 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Addshore, Pablo-WMDE, Jakob_WMDE, Ladsgroup, WMDE-leszek

[Wikidata-bugs] [Maniphest] [Updated] T224546: Make WikibaseLexeme browser tests less flaky

2020-04-18 Thread Krinkle
Krinkle edited projects, added ci-test-error (WMF-deployed Build Failure); removed Wikimedia-production-error (Shared Build Failure). TASK DETAIL https://phabricator.wikimedia.org/T224546 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc

[Wikidata-bugs] [Maniphest] [Updated] T65015: [Bug] SpamBlacklist hook causes Wikibase LinkTitle api phpunit tests to fail

2020-04-18 Thread Krinkle
Krinkle edited projects, added ci-test-error (WMF-deployed Build Failure); removed Wikimedia-production-error (Shared Build Failure). TASK DETAIL https://phabricator.wikimedia.org/T65015 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc

[Wikidata-bugs] [Maniphest] [Updated] T245824: Error in "App closes on clicking the cancel button"

2020-04-18 Thread Krinkle
Krinkle edited projects, added ci-test-error (WMF-deployed Build Failure); removed Wikimedia-production-error (Shared Build Failure). TASK DETAIL https://phabricator.wikimedia.org/T245824 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE

[Wikidata-bugs] [Maniphest] [Updated] T250305: wmf-quibble-vendor-mysql-php72-docker failed on Special:EntityData

2020-04-18 Thread Krinkle
Krinkle edited projects, added ci-test-error (WMF-deployed Build Failure); removed Wikimedia-production-error (Shared Build Failure). TASK DETAIL https://phabricator.wikimedia.org/T250305 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc

[Wikidata-bugs] [Maniphest] [Updated] T227266: Find out why 'old revisions do not have edit links' selenium test is flaky on CI

2020-04-18 Thread Krinkle
Krinkle edited projects, added ci-test-error (WMF-deployed Build Failure); removed ci-test-error, Wikimedia-production-error (Shared Build Failure). TASK DETAIL https://phabricator.wikimedia.org/T227266 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Updated] T246456: Performance review of Wikidata Bridge

2020-04-14 Thread Krinkle
Krinkle added a subtask: T248840: Don’t polyfill Promise in Bridge modules. TASK DETAIL https://phabricator.wikimedia.org/T246456 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: aaron, Krinkle Cc: Jakob_WMDE, Lydia_Pintscher, Addshore, Krinkle

[Wikidata-bugs] [Maniphest] [Updated] T248840: Don’t polyfill Promise in Bridge modules

2020-04-14 Thread Krinkle
Krinkle added a parent task: T246456: Performance review of Wikidata Bridge. TASK DETAIL https://phabricator.wikimedia.org/T248840 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Lucas_Werkmeister_WMDE, Aklapper, Sarai-WMDE, darthmon_wmde

[Wikidata-bugs] [Maniphest] [Updated] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

2020-04-14 Thread Krinkle
Krinkle removed a project: MediaWiki-Cache. Restricted Application added a subscriber: Masumrezarock100. TASK DETAIL https://phabricator.wikimedia.org/T173949 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson, Krinkle Cc: Masumrezarock100

[Wikidata-bugs] [Maniphest] [Updated] T157651: sql.php runs LoadExtensionSchemaUpdates

2020-04-09 Thread Krinkle
Krinkle removed projects: DBA, Wikimedia-database-error, Beta-Cluster-reproducible. TASK DETAIL https://phabricator.wikimedia.org/T157651 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Jdforrester-WMF, kostajh, WMDE-leszek, Addshore

[Wikidata-bugs] [Maniphest] [Commented On] T157651: sql.php runs LoadExtensionSchemaUpdates

2020-04-08 Thread Krinkle
Krinkle added a comment. As said, I don't mind keeping `sql.php` as a cross-rdbms debug tool if there's interest for that. However, I think use in production is problematic and should not be allowed for the same reason that `echo | mwscript eval.php` shouldn't be used as part

[Wikidata-bugs] [Maniphest] [Updated] T249348: Wikibase error when calling getProperty(). Property data type lookup failed for: P727

2020-04-08 Thread Krinkle
Krinkle added projects: WikibaseMediaInfo, Structured Data Engineering, Wikidata. Restricted Application added a project: Structured-Data-Backlog. TASK DETAIL https://phabricator.wikimedia.org/T249348 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Commented On] T157651: sql.php runs LoadExtensionSchemaUpdates

2020-04-07 Thread Krinkle
Krinkle added a comment. In T157651#6035533 <https://phabricator.wikimedia.org/T157651#6035533>, @daniel wrote: > Looking at the code, there seems to be a whole set of dubious things going on which all together caused the disaster above > > - … > - the only thin

[Wikidata-bugs] [Maniphest] [Updated] T249533: testwikidata wiki is broken with "Cannot access the database"

2020-04-06 Thread Krinkle
Krinkle added a project: Wikimedia-Incident. TASK DETAIL https://phabricator.wikimedia.org/T249533 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, cscott, Michael, Framawiki, Liuxinyu970226, Aklapper, Bugreporter, darthmon_wmde

[Wikidata-bugs] [Maniphest] [Updated] T249533: testwikidata wiki is broken with "Cannot access the database"

2020-04-06 Thread Krinkle
Krinkle added a project: Wikimedia-production-error. TASK DETAIL https://phabricator.wikimedia.org/T249533 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, cscott, Michael, Framawiki, Liuxinyu970226, Aklapper, Bugreporter

[Wikidata-bugs] [Maniphest] [Commented On] T249533: testwikidata wiki is broken with "Cannot access the database"

2020-04-06 Thread Krinkle
Krinkle added a comment. This started at 2020-04-06T14:51:00 and is still on-going. https://logstash.wikimedia.org/goto/52e6eca628f5380e1dbb3b5783cd4300 F31737987: Screenshot 2020-04-07 at 02.04.32.png <https://phabricator.wikimedia.org/F31737987> one sample:

[Wikidata-bugs] [Maniphest] [Updated] T249565: Wikidata's wb_items_per_site table has suddenly disappeared, creating DBQueryErrors on page views

2020-04-06 Thread Krinkle
Krinkle added a comment. Evidence of T157651: sql.php runs LoadExtensionSchemaUpdates <https://phabricator.wikimedia.org/T157651> This is from the 23:00:00 UTC cron from puppet `cron/wikibase/dumpwikibaserdf.sh`, which calls `cron/wikibase/wikibasedumps-shared.sh`, which calls `s

[Wikidata-bugs] [Maniphest] [Edited] T214362: RFC: Store WikibaseQualityConstraint check data in persistent storage

2020-04-03 Thread Krinkle
Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T214362 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: eprodromou, CCicalese_WMF, kchapman, Krinkle, mobrovac, abian, Lydia_Pintscher

[Wikidata-bugs] [Maniphest] [Commented On] T214362: RFC: Store WikibaseQualityConstraint check data in persistent storage

2020-04-03 Thread Krinkle
Krinkle added a comment. **Task description** > The constrain checks are accessible via 3 methods: > > - RDF action > - Special page > - API > > […] The RDF page-action exists for use by the WDQS and will not run the constraint check itself, it only expos

[Wikidata-bugs] [Maniphest] [Edited] T214362: RFC: Store WikibaseQualityConstraint check data in persistent storage

2020-04-03 Thread Krinkle
Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T214362 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: eprodromou, CCicalese_WMF, kchapman, Krinkle, mobrovac, abian, Lydia_Pintscher

[Wikidata-bugs] [Maniphest] [Updated] T204024: Store WikibaseQualityConstraint check data in persistent storage instead of in the cache

2020-04-03 Thread Krinkle
Krinkle added a subtask: T214362: RFC: Store WikibaseQualityConstraint check data in persistent storage. TASK DETAIL https://phabricator.wikimedia.org/T204024 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Lydia_Pintscher, Pintoch, Tpt

[Wikidata-bugs] [Maniphest] [Updated] T214362: RFC: Store WikibaseQualityConstraint check data in persistent storage

2020-04-03 Thread Krinkle
Krinkle added a parent task: T204024: Store WikibaseQualityConstraint check data in persistent storage instead of in the cache. TASK DETAIL https://phabricator.wikimedia.org/T214362 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc

[Wikidata-bugs] [Maniphest] [Edited] T214362: RFC: Store WikibaseQualityConstraint check data in persistent storage

2020-04-03 Thread Krinkle
Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T214362 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: eprodromou, CCicalese_WMF, kchapman, Krinkle, mobrovac, abian, Lydia_Pintscher

[Wikidata-bugs] [Maniphest] [Commented On] T176312: Don’t check format constraint via SPARQL (safely evaluating user-provided regular expressions)

2020-04-03 Thread Krinkle
Krinkle added a comment. I've merged the RFC bits into T176312 <https://phabricator.wikimedia.org/T176312>, which seems to be about the same thing. TASK DETAIL https://phabricator.wikimedia.org/T176312 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailprefe

[Wikidata-bugs] [Maniphest] [Updated] T176312: Don’t check format constraint via SPARQL (safely evaluating user-provided regular expressions)

2020-04-03 Thread Krinkle
Krinkle removed a project: TechCom-RFC. Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T176312 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, EBernhardson, Bawolff, abian, Addshore, Ladsgroup

[Wikidata-bugs] [Maniphest] [Retitled] T240884: RFC: How to evaluate user-provided regular expressions

2020-04-03 Thread Krinkle
Krinkle renamed this task from "Standalone service to evaluate user-provided regular expressions" to "RFC: How to evaluate user-provided regular expressions". Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T240884 EMAIL

[Wikidata-bugs] [Maniphest] [Edited] T176312: Don’t check format constraint via SPARQL (safely evaluating user-provided regular expressions)

2020-04-03 Thread Krinkle
Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T176312 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, EBernhardson, Bawolff, abian, Addshore, Ladsgroup, Milimetric, Nikerabbit, Anomie

[Wikidata-bugs] [Maniphest] [Updated] T248147: Wikimedia\Rdbms\Database::normalizeUpsertKeys called with deprecated parameter style: the unique key array should be a string or array of string arrays g

2020-03-26 Thread Krinkle
Krinkle edited projects, added Wikimedia-General-or-Unknown, PageCuration, Wikidata-Campsite, ProofreadPage, AntiSpoof; removed Train Deployments, Release. Restricted Application added projects: Growth-Team, Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T248147 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Retitled] T213318: RFC: Wikibase Front-End Architecture

2020-03-24 Thread Krinkle
Krinkle renamed this task from "Wikibase Front-End Architecture" to "RFC: Wikibase Front-End Architecture". Krinkle closed this task as "Resolved". Krinkle triaged this task as "Medium" priority. TASK DETAIL https://phabricator.wikimedi

[Wikidata-bugs] [Maniphest] [Commented On] T245396: SimpleCacheWithBagOStuff shouldnt be so easy to use bad keys with

2020-03-19 Thread Krinkle
Krinkle added a comment. Yes, all keys passed to get/set must come from makeKey or makeGlobalKey from the same BagOStuff class. Where to call that depends on whether you intent to expose a general cache interface or one that has a finegrained purpose. Two examples. The generic one

[Wikidata-bugs] [Maniphest] [Commented On] T246207: Track down unusual callers to SimpleCacheWithBagOfStuff

2020-03-19 Thread Krinkle
Krinkle added a comment. If there are functional problems in Wikibase with these values, then by all means file bugs for them and validate them where it makes sense. But I would strongly recommend investing effort into "fixing" unusual callers. I believe that would create more

[Wikidata-bugs] [Maniphest] [Merged] T247466: SimpleCacheWithBagOStuff: Cache key contains characters that are not allowed

2020-03-19 Thread Krinkle
Krinkle closed this task as a duplicate of T245396: SimpleCacheWithBagOStuff shouldnt be so easy to use bad keys with. Restricted Application removed a subscriber: Liuxinyu970226. TASK DETAIL https://phabricator.wikimedia.org/T247466 EMAIL PREFERENCES https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Updated] T245396: SimpleCacheWithBagOStuff shouldnt be so easy to use bad keys with

2020-03-19 Thread Krinkle
Krinkle merged a task: T247466: SimpleCacheWithBagOStuff: Cache key contains characters that are not allowed. Krinkle added subscribers: brennen, hashar, Ladsgroup, Agusbou2015, Liuxinyu970226. TASK DETAIL https://phabricator.wikimedia.org/T245396 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Updated] T245396: SimpleCacheWithBagOStuff shouldnt be so easy to use bad keys with

2020-03-19 Thread Krinkle
Krinkle added a project: Wikimedia-production-error. TASK DETAIL https://phabricator.wikimedia.org/T245396 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Lydia_Pintscher, Jdforrester-WMF, WMDE-leszek, Addshore, Jakob_WMDE

[Wikidata-bugs] [Maniphest] [Commented On] T245396: SimpleCacheWithBagOStuff shouldnt be so easy to use bad keys with

2020-03-19 Thread Krinkle
Krinkle added a comment. @Tarrow I'm looking at the SimpleCacheWithBagOStuff source, and not only is it not proxying makeKey - it doesn't even have a makeKey or similar method from what I can see. How is it currently supposed to be used? I tried to find a usage example, and the first

[Wikidata-bugs] [Maniphest] [Commented On] T247466: SimpleCacheWithBagOStuff: Cache key contains characters that are not allowed

2020-03-19 Thread Krinkle
Krinkle added a comment. The uselang is a red herring. Yes it can be strange, but that is supported <https://www.mediawiki.org/wiki/Manual:Uselang_hack>. It is possible that there is a bug and that this value should be discarded, but that is not the bug for this task. Our Bag

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T248006: PHP Notice: Undefined property: Wikibase\DataModel\Term\TermList::$Ø

2020-03-19 Thread Krinkle
Krinkle added subscribers: Ladsgroup, Krinkle. Krinkle added a comment. This code relates to the termbox layer of Wikibase which has recently changed and is now receiving more traffic into a new previouly unexposed codepath. It is indeed not new in the train, but it is newly deployed

[Wikidata-bugs] [Maniphest] [Retitled] T247553: Fail-safe exception from ReplicaMasterAwareRecordIdsAcquirer via Wikibase DataUpdateAdapter::doUpdate

2020-03-18 Thread Krinkle
Krinkle renamed this task from "PHP Warning: [data-update-failed]: A data update callback triggered an exception (Fail-safe exception. Avoiding infinite loop due to possibily undetectable existing records in master. It may be due to encoding incompatibility between database values and v

[Wikidata-bugs] [Maniphest] [Updated] T231084: Assert.php: Bad value for parameter $oldContent: must be a TextContent|null [Story Points 5]

2020-03-16 Thread Krinkle
Krinkle set Request URL to https://www.wikidata.org//w/index.php?title=Q33232729=34683193=11=772301402. Krinkle set Request ID to XV-edQpAIC0AAFFJeEMAAABM. Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T231084 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Closed] T247458: PHP Notice: Undefined index: wgKartographerLiveData

2020-03-16 Thread Krinkle
Krinkle closed this task as "Resolved". Krinkle claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T247458 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: TheDJ, Liuxinyu970226, Mholloway, hoo, thiemowmde, A

[Wikidata-bugs] [Maniphest] [Lowered Priority] T247466: SimpleCacheWithBagOStuff: Cache key contains characters that are not allowed

2020-03-16 Thread Krinkle
Krinkle lowered the priority of this task from "Medium" to "Low". Krinkle removed a project: MW-1.35-notes (1.35.0-wmf.23; 2020-03-10). TASK DETAIL https://phabricator.wikimedia.org/T247466 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferen

[Wikidata-bugs] [Maniphest] [Commented On] T247466: SimpleCacheWithBagOStuff: Cache key contains characters that are not allowed

2020-03-16 Thread Krinkle
Krinkle added a comment. In T247466#5964879 <https://phabricator.wikimedia.org/T247466#5964879>, @gerritbot wrote: > Change 579302 **merged** by jenkins-bot: > [mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.23] Do not try to load label in unknown languages in L

[Wikidata-bugs] [Maniphest] [Updated] T247458: PHP Notice: Undefined index: wgKartographerLiveData

2020-03-15 Thread Krinkle
Krinkle removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T247458 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: TheDJ, Liuxinyu970226, Mholloway, hoo, thiemowmde, Agusbou2015, Krinkle, Aklapper, brennen

[Wikidata-bugs] [Maniphest] [Edited] T213426: Deprecate jquery.throttle-debounce in favour of mw.util.debounce or OO.ui.debounce/throttle

2020-03-15 Thread Krinkle
Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T213426 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: TheDJ, Xover, Od1n, Woolvia, Esanders, Krinkle, Aklapper, gerritbot, Jdforrester-WMF, Jdlrobson

[Wikidata-bugs] [Maniphest] [Created] T247670: PHPUnit warning noise from ClientParserOutputDataUpdaterTest (Wikibase)

2020-03-14 Thread Krinkle
Krinkle created this task. Krinkle added projects: Developer Productivity, MediaWiki-extensions-WikibaseClient, Wikidata-Campsite. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION These are making it hard for developers

[Wikidata-bugs] [Maniphest] [Retitled] T242717: Wikidata daily browser tests fails on Beta due to "Unable to store text to external storage"

2020-03-12 Thread Krinkle
Krinkle renamed this task from ""Unable to store text to external storage" during wikidata daily browser tests on beta" to "Wikidata daily browser tests fails on Beta due to "Unable to store text to external storage"". TASK DETAIL https://phabricator.

[Wikidata-bugs] [Maniphest] [Commented On] T242717: Wikidata daily browser tests fails on Beta due to "Unable to store text to external storage"

2020-03-12 Thread Krinkle
Krinkle added a comment. I'll leave this open as being about the browser test failure itself, in case there is a way to work around it and to make sure it isn't forgotten about in that context. Underlying issue is now tracked at T228088 <https://phabricator.wikimedia.org/T228

[Wikidata-bugs] [Maniphest] [Updated] T242717: "Unable to store text to external storage" during wikidata daily browser tests on beta

2020-03-12 Thread Krinkle
Krinkle added a subtask: T228088: BetaCluster: ExternalStoreException - Unable to store text to external storage. TASK DETAIL https://phabricator.wikimedia.org/T242717 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Etonkovidova

[Wikidata-bugs] [Maniphest] [Edited] T247458: PHP Notice: Undefined index: wgKartographerLiveData

2020-03-12 Thread Krinkle
Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T247458 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Agusbou2015, Krinkle, Aklapper, brennen, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic

[Wikidata-bugs] [Maniphest] [Triaged] T247466: SimpleCacheWithBagOStuff: Cache key contains characters that are not allowed

2020-03-11 Thread Krinkle
Krinkle triaged this task as "Unbreak Now!" priority. Restricted Application added a subscriber: Liuxinyu970226. TASK DETAIL https://phabricator.wikimedia.org/T247466 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Liuxinyu97022

[Wikidata-bugs] [Maniphest] [Commented On] T247466: SimpleCacheWithBagOStuff: Cache key contains characters that are not allowed

2020-03-11 Thread Krinkle
Krinkle added a comment. This is a fatal error from WikibaseClient code as seen on group1 with Commons. The stack trace suggests it is encountered while parsing wikitext, which suggests to me that it is quite likely this will also start breaking Wikipedia pages views and make some pages

[Wikidata-bugs] [Maniphest] [Updated] T245396: SimpleCacheWithBagOStuff shouldnt be so easy to use bad keys with

2020-03-11 Thread Krinkle
Krinkle added a comment. Seen again in prod: T247466: SimpleCacheWithBagOStuff: Cache key contains characters that are not allowed <https://phabricator.wikimedia.org/T247466> TASK DETAIL https://phabricator.wikimedia.org/T245396 EMAIL PREFERENCES https://phabricator.wikimed

[Wikidata-bugs] [Maniphest] [Updated] T247466: SimpleCacheWithBagOStuff: Cache key contains characters that are not allowed

2020-03-11 Thread Krinkle
Krinkle added a parent task: T233871: 1.35.0-wmf.23 deployment blockers. TASK DETAIL https://phabricator.wikimedia.org/T247466 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Aklapper, brennen, darthmon_wmde, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Updated] T247466: SimpleCacheWithBagOStuff: Cache key contains characters that are not allowed

2020-03-11 Thread Krinkle
Krinkle edited projects, added Wikidata, MediaWiki-extensions-WikibaseClient, Wikidata-Campsite; removed MediaWiki-extensions-Scribunto. TASK DETAIL https://phabricator.wikimedia.org/T247466 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc

[Wikidata-bugs] [Maniphest] [Updated] T247458: PHP Notice: Undefined index: wgKartographerLiveData

2020-03-11 Thread Krinkle
Krinkle added a project: Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T247458 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Aklapper, brennen, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden

[Wikidata-bugs] [Maniphest] [Commented On] T247458: PHP Notice: Undefined index: wgKartographerLiveData

2020-03-11 Thread Krinkle
Krinkle added a comment. Undefined variables seem quite serious, especially config variables. Blocker imho. TASK DETAIL https://phabricator.wikimedia.org/T247458 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Aklapper

[Wikidata-bugs] [Maniphest] [Updated] T247458: PHP Notice: Undefined index: wgKartographerLiveData

2020-03-11 Thread Krinkle
Krinkle added a parent task: T233871: 1.35.0-wmf.23 deployment blockers. TASK DETAIL https://phabricator.wikimedia.org/T247458 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Aklapper, brennen, darthmon_wmde, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Merged] T246892: UnresolvedEntityRedirectException: Unresolved redirect from Q211857 to Q211858

2020-03-11 Thread Krinkle
Krinkle closed this task as a duplicate of T243779: Fatal UnresolvedEntityRedirectException when viewing certain Wikidata item pages. TASK DETAIL https://phabricator.wikimedia.org/T246892 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc

[Wikidata-bugs] [Maniphest] [Updated] T243779: Fatal UnresolvedEntityRedirectException when viewing certain Wikidata item pages

2020-03-11 Thread Krinkle
Krinkle merged a task: T246892: UnresolvedEntityRedirectException: Unresolved redirect from Q211857 to Q211858. Krinkle added a subscriber: LarsWirzenius. TASK DETAIL https://phabricator.wikimedia.org/T243779 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Retitled] T246892: UnresolvedEntityRedirectException: Unresolved redirect from Q211857 to Q211858

2020-03-11 Thread Krinkle
Krinkle renamed this task from "Unresolved redirect from Q211857 to Q211858" to "UnresolvedEntityRedirectException: Unresolved redirect from Q211857 to Q211858". Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T246892 EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T245629: mediawiki/core webdriver.io tests fail in EntitySchema extension

2020-03-10 Thread Krinkle
Krinkle added a project: Core Platform Team. TASK DETAIL https://phabricator.wikimedia.org/T245629 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Umherirrender, thiemowmde, Jdforrester-WMF, Legoktm, Krinkle, Addshore, Daimona, Aklapper

[Wikidata-bugs] [Maniphest] [Updated] T107595: [RFC] Multi-Content Revisions

2020-03-10 Thread Krinkle
Krinkle edited projects, added TechCom-RFC (TechCom-RFC-Closed); removed Wikidata-Sprint-2015-11-17, Wikidata-Sprint-2015-09-15, TechCom-RFC. TASK DETAIL https://phabricator.wikimedia.org/T107595 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brion

[Wikidata-bugs] [Maniphest] [Updated] T124792: RFC: Service Locator for MediaWiki core

2020-03-10 Thread Krinkle
Krinkle edited projects, added TechCom-RFC (TechCom-RFC-Closed); removed MW-1.27-release (WMF-deploy-2016-04-05_(1.27.0-wmf.20)), Patch-For-Review, TechCom-RFC. TASK DETAIL https://phabricator.wikimedia.org/T124792 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Updated] T105638: RFC: Streamlining Composer usage

2020-03-10 Thread Krinkle
Krinkle edited projects, added TechCom-RFC (TechCom-RFC-Closed); removed TechCom-RFC. TASK DETAIL https://phabricator.wikimedia.org/T105638 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Samwilson, dmaza, TBolliger, Reedy, WMDE-leszek

[Wikidata-bugs] [Maniphest] [Commented On] T245629: mediawiki/core webdriver.io tests fail in EntitySchema extension

2020-03-09 Thread Krinkle
Krinkle added a comment. There are no (obvious) team tags associated with this task. Who is waiting for what/whom? TASK DETAIL https://phabricator.wikimedia.org/T245629 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Umherirrender

[Wikidata-bugs] [Maniphest] [Assigned] T246643: TitleBlacklist: Call to a member function isOK() on array when action=query=info=edit

2020-03-02 Thread Krinkle
Krinkle assigned this task to Lucas_Werkmeister_WMDE. Krinkle added a comment. Yikes, didnt think about the cached use case. Thanks! I've reviewed the patch now. TASK DETAIL https://phabricator.wikimedia.org/T246643 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Updated] T238199: SpecialFewestRevisions::reallyDoQuery takes more than 9h to run

2020-02-29 Thread Krinkle
Krinkle edited projects, added Wikimedia-database-error; removed Wikimedia-production-error. TASK DETAIL https://phabricator.wikimedia.org/T238199 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Lea_Lacroix_WMDE, jcrespo, Addshore

[Wikidata-bugs] [Maniphest] [Commented On] T246288: Using Special:NewItem on wikidata.org sometimes times out

2020-02-29 Thread Krinkle
Krinkle added a comment. @Addshore Time outs often happen in unrelated code. It is not an indicating that the unrelated code is where the time was spent, it is merely where the timeout was finally reached. In this case, the hypothesis would be that the main code behind Wikibase's

[Wikidata-bugs] [Maniphest] [Declined] T246288: Using Special:NewItem on wikidata.org sometimes times out

2020-02-29 Thread Krinkle
Krinkle closed this task as "Declined". TASK DETAIL https://phabricator.wikimedia.org/T246288 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Addshore, Hogue, Aklapper, Adidsone1, darthmon_wmde, DannyS712

[Wikidata-bugs] [Maniphest] [Retitled] T246288: Using Special:NewItem on wikidata.org sometimes times out

2020-02-29 Thread Krinkle
Krinkle renamed this task from "Internal Error in Wikidata" to "Using Special:NewItem on wikidata.org sometimes times out". TASK DETAIL https://phabricator.wikimedia.org/T246288 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] [Commented On] T243779: Fatal UnresolvedEntityRedirectException when viewing certain Wikidata item pages

2020-02-24 Thread Krinkle
Krinkle added a comment. In T243779#5839611 <https://phabricator.wikimedia.org/T243779#5839611>, @Addshore wrote: > I created an example of this happening on test https://test.wikidata.org/w/index.php?title=Q211856=no > […] > The page content displays the fact the pag

[Wikidata-bugs] [Maniphest] [Commented On] T227699: Creating a Commons gallery page incorrectly states "This entity does not exist."

2020-02-13 Thread Krinkle
Krinkle added a comment. The bug is currently obscured on Wikimedia Commons. It looks like someone has overidden the "This entity interface message for English to say "This page" instead. My interface langauge is `en-gb`, which the community has not worked around fo

<    1   2   3   4   5   6   7   8   9   10   >