[Wikidata-bugs] [Maniphest] [Created] T233794: React to app's cancel event

2019-09-25 Thread Pablo-WMDE
Pablo-WMDE created this task. Pablo-WMDE added projects: Wikidata, Wikidata-Bridge-Sprint-6. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION - in `subscribeToAppEvents()` - in `mock-entry` TASK DETAIL https://phabricator.wikimedia.org/T233794 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Created] T233795: Add cancel button to app and emit close event

2019-09-25 Thread Pablo-WMDE
Pablo-WMDE created this task. Pablo-WMDE added projects: Wikidata, Wikidata-Bridge-Sprint-6. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION TASK DETAIL https://phabricator.wikimedia.org/T233795 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Created] T233793: React to escape

2019-09-25 Thread Pablo-WMDE
Pablo-WMDE created this task. Pablo-WMDE added projects: Wikidata, Wikidata-Bridge-Sprint-6. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION TASK DETAIL https://phabricator.wikimedia.org/T233793 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Created] T233791: Add cancel button

2019-09-25 Thread Pablo-WMDE
Pablo-WMDE created this task. Pablo-WMDE added projects: Wikidata, Wikidata-Bridge-Sprint-6. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION - pimp EventEmittingButton to contain the cancel modification - add asset (@Charlie_WMDE are we right in assuming this is

[Wikidata-bugs] [Maniphest] [Commented On] T232595: Make it possible to collapse the "All entered languages" section when at the end of the section

2019-09-25 Thread Pablo-WMDE
Pablo-WMDE added a comment. https://gerrit.wikimedia.org/r/534766 was done when this issue was first discussed and may or may not help with resolving this, now that there is a formal ticket for it. TASK DETAIL https://phabricator.wikimedia.org/T232595 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Updated] T232998: Pass wgEditSubmitButtonLabelPublish variable from bridge config (init) to ProcessDialog component

2019-09-25 Thread Pablo-WMDE
Pablo-WMDE added a project: Wikidata-Bridge-Sprint-6. TASK DETAIL https://phabricator.wikimedia.org/T232998 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Matthias_Geisler_WMDE, Pablo-WMDE Cc: Aklapper, Lucas_Werkmeister_WMDE, Hook696, Daryl-TTMG

[Wikidata-bugs] [Maniphest] [Updated] T228261: Extract TermTextField to a 3rd repo and use it from there

2019-09-25 Thread Pablo-WMDE
Pablo-WMDE edited projects, added Wikidata-Bridge; removed Wikidata-Bridge-Sprint-5, Wikidata-Bridge-Sprint-4, Wikidata-Bridge-Sprint-3, Wikidata-Bridge-Sprint-2. TASK DETAIL https://phabricator.wikimedia.org/T228261 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Updated] T232997: Add wgEditSubmitButtonLabelPublish to data bridge config

2019-09-25 Thread Pablo-WMDE
Pablo-WMDE added a project: Wikidata-Bridge-Sprint-6. TASK DETAIL https://phabricator.wikimedia.org/T232997 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Matthias_Geisler_WMDE, Pablo-WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, Hook696, Daryl-TTMG

[Wikidata-bugs] [Maniphest] [Updated] T232999: Make ProcessDialog use different message keys depending on wgEditSubmitButtonLabelPublish setting

2019-09-25 Thread Pablo-WMDE
Pablo-WMDE added a project: Wikidata-Bridge-Sprint-6. TASK DETAIL https://phabricator.wikimedia.org/T232999 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Matthias_Geisler_WMDE, Pablo-WMDE Cc: Aklapper, Lucas_Werkmeister_WMDE, Hook696, Daryl-TTMG

[Wikidata-bugs] [Maniphest] [Updated] T231887: investigation for ensuring editing with the same credentials

2019-09-25 Thread Pablo-WMDE
Pablo-WMDE added a project: Wikidata-Bridge-Sprint-6. TASK DETAIL https://phabricator.wikimedia.org/T231887 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, Pablo-WMDE Cc: Matthias_Geisler_WMDE, Addshore, Aklapper, Lydia_Pintscher

[Wikidata-bugs] [Maniphest] [Updated] T228260: obey wgEditSubmitButtonLabelPublish setting in Wikidata Bridge

2019-09-25 Thread Pablo-WMDE
Pablo-WMDE added a project: Wikidata-Bridge-Sprint-6. TASK DETAIL https://phabricator.wikimedia.org/T228260 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Pablo-WMDE, Aklapper, Lydia_Pintscher, darthmon_wmde, Michael, DannyS712

[Wikidata-bugs] [Maniphest] [Edited] T231887: investigation for ensuring editing with the same credentials

2019-09-24 Thread Pablo-WMDE
Pablo-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T231887 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, Pablo-WMDE Cc: Matthias_Geisler_WMDE, Addshore, Aklapper, Lydia_Pintscher, darthmon_wmde, Michael

[Wikidata-bugs] [Maniphest] [Updated] T228260: obey wgEditSubmitButtonLabelPublish setting in Wikidata Bridge

2019-09-23 Thread Pablo-WMDE
Pablo-WMDE added a comment. FTR Core also differentiates in success messages (e.g. T183901: Reword post edit notification to reflect save->publish change on desktop <https://phabricator.wikimedia.org/T183901>), should we ever get to that. TASK DETAIL https://phabricator.wiki

[Wikidata-bugs] [Maniphest] [Commented On] T233599: Translate save button

2019-09-23 Thread Pablo-WMDE
Pablo-WMDE added a comment. Beta <https://de.wikipedia.beta.wmflabs.org/wiki/Data-Bridge> should show the translated button now. TASK DETAIL https://phabricator.wikimedia.org/T233599 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-W

[Wikidata-bugs] [Maniphest] [Commented On] T233599: Translate save button

2019-09-23 Thread Pablo-WMDE
Pablo-WMDE added a comment. Looks like what we know as save button from article editing is provided by the message "savechanges". TASK DETAIL https://phabricator.wikimedia.org/T233599 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pab

[Wikidata-bugs] [Maniphest] [Claimed] T233599: Translate save button

2019-09-23 Thread Pablo-WMDE
Pablo-WMDE claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T233599 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Aklapper, Pablo-WMDE, darthmon_wmde, Michael, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic

[Wikidata-bugs] [Maniphest] [Created] T233599: Translate save button

2019-09-23 Thread Pablo-WMDE
Pablo-WMDE created this task. Pablo-WMDE added projects: Wikidata, Wikidata-Bridge-Sprint-5. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION With "save" message from client wiki TASK DETAIL https://phabricator.wikimedia.org/T233599 EMAIL PREFERENC

[Wikidata-bugs] [Maniphest] [Commented On] T231203: track "closing event" with and without change

2019-09-20 Thread Pablo-WMDE
Pablo-WMDE added a comment. > Thanks! That is intended Sure. Was more meant as a note to the dev: our initial assumption ("for free") was partially flawed. TASK DETAIL https://phabricator.wikimedia.org/T231203 EMAIL PREFERENCES https://phabricator.wikimedia.org/s

[Wikidata-bugs] [Maniphest] [Closed] T232993: Create Vue plugin/mixin for translatable messages

2019-09-20 Thread Pablo-WMDE
Pablo-WMDE closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T232993 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Pablo-WMDE Cc: Pablo-WMDE, Lydia_Pintscher, Matthias_Geisler_WMDE

[Wikidata-bugs] [Maniphest] [Unblock] T228259: Adapt buttons' texts to the user interface language

2019-09-20 Thread Pablo-WMDE
Pablo-WMDE closed subtask T232993: Create Vue plugin/mixin for translatable messages as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T228259 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Aklapper, Lydia

[Wikidata-bugs] [Maniphest] [Updated] T231203: track "closing event" with and without change

2019-09-19 Thread Pablo-WMDE
Pablo-WMDE added a comment. Possible logical flaw detected: programmers so far assumed that the same logic we implement for T230342: enable/disable save button depending on Bridge state <https://phabricator.wikimedia.org/T230342> was identical to the one to determine which bucket we c

[Wikidata-bugs] [Maniphest] [Edited] T230329: Use header component & save button

2019-09-18 Thread Pablo-WMDE
Pablo-WMDE added a subscriber: Charlie_WMDE. Pablo-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T230329 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Charlie_WMDE, Aklapper, Pablo-WMDE, Hook696

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T232993: Create Vue plugin/mixin for translatable messages

2019-09-18 Thread Pablo-WMDE
Pablo-WMDE added subscribers: Lydia_Pintscher, Pablo-WMDE. Pablo-WMDE added a comment. @Lydia_Pintscher With regards to the "choosing an official name for the client editing feature" discussion back when and [0], is there any preference from product/marketing how the message keys

[Wikidata-bugs] [Maniphest] [Closed] T232991: Create MessageService & add to service container

2019-09-18 Thread Pablo-WMDE
Pablo-WMDE closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T232991 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Matthias_Geisler_WMDE, Pablo-WMDE Cc: Aklapper, Pablo-WMDE, darthmon_wmde, Michael, DannyS71

[Wikidata-bugs] [Maniphest] [Unblock] T228259: Adapt buttons' texts to the user interface language

2019-09-18 Thread Pablo-WMDE
Pablo-WMDE closed subtask T232991: Create MessageService & add to service container as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T228259 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Aklapper, L

[Wikidata-bugs] [Maniphest] [Unblock] T227003: Add an edit tag parameter and tag the edits made via data bridge with "Data Bridge"

2019-09-17 Thread Pablo-WMDE
Pablo-WMDE closed subtask T232581: Use config variable to initialize the WritingEntityRepository with tag(s) as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T227003 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE

[Wikidata-bugs] [Maniphest] [Closed] T232581: Use config variable to initialize the WritingEntityRepository with tag(s)

2019-09-17 Thread Pablo-WMDE
Pablo-WMDE closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T232581 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Matthias_Geisler_WMDE, Pablo-WMDE Cc: Aklapper, Pablo-WMDE, Hook696, Daryl-TTMG, RomaAmorRoma,

[Wikidata-bugs] [Maniphest] [Created] T232991: Create MessageService & add to service container

2019-09-16 Thread Pablo-WMDE
Pablo-WMDE created this task. Pablo-WMDE added projects: Wikidata-Bridge, Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION - wraps `mw.message` - only operate on message for now - no support for message parameters yet TASK DETAIL https

[Wikidata-bugs] [Maniphest] [Created] T232987: Browser test property label

2019-09-16 Thread Pablo-WMDE
Pablo-WMDE created this task. Pablo-WMDE added projects: Wikidata, Wikidata-Bridge-Sprint-5. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION i.e. that the HTML form is labeled correctly by - the property label in best case - the property id as a fall-back TASK

[Wikidata-bugs] [Maniphest] [Retitled] T232581: Use config variable to initialize the WritingEntityRepository with tag(s)

2019-09-13 Thread Pablo-WMDE
Pablo-WMDE renamed this task from "Use config variable to initialize the WritingEntityRepository" to "Use config variable to initialize the WritingEntityRepository with tag(s)". TASK DETAIL https://phabricator.wikimedia.org/T232581 EMAIL PREFERENCES https://phabr

[Wikidata-bugs] [Maniphest] [Merged] T230329: Use header component & save button

2019-09-12 Thread Pablo-WMDE
Pablo-WMDE merged a task: T232196: Wire up header. TASK DETAIL https://phabricator.wikimedia.org/T230329 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Aklapper, Pablo-WMDE, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Updated] T232196: Wire up header

2019-09-12 Thread Pablo-WMDE
Pablo-WMDE closed this task as a duplicate of T230329: Use header component & save button. TASK DETAIL https://phabricator.wikimedia.org/T232196 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Aklapper, Pablo-WMDE, darthmon_

[Wikidata-bugs] [Maniphest] [Claimed] T230329: Use header component & save button

2019-09-12 Thread Pablo-WMDE
Pablo-WMDE claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T230329 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Aklapper, Pablo-WMDE, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden

[Wikidata-bugs] [Maniphest] [Commented On] T227266: Find out why 'old revisions do not have edit links' selenium test is flaky on CI

2019-09-11 Thread Pablo-WMDE
Pablo-WMDE added a comment. Also dropped something there: https://phabricator.wikimedia.org/T232363#5484262 TASK DETAIL https://phabricator.wikimedia.org/T227266 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Pablo-WMDE Cc: Pablo

[Wikidata-bugs] [Maniphest] [Commented On] T232363: Occasional Wikibase CI failures: Cannot read property 'set' of undefined (test: item old revisions do not have an edit link)

2019-09-11 Thread Pablo-WMDE
Pablo-WMDE added a comment. Agree with @Lucas_Werkmeister_WMDE in that the test could needs some love. The `ItemPage.editItemDescription()` is definitely still part of the arrange phase <http://wiki.c2.com/?ArrangeActAssert> so it could be done via the API just as well (=> second

[Wikidata-bugs] [Maniphest] [Closed] T232497: Handle properties with no label whatsoever

2019-09-11 Thread Pablo-WMDE
Pablo-WMDE closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T232497 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Aklapper, Matthias_Geisler_WMDE, Lucas_Werkmeister_WMDE, Michael, Pablo-WMD

[Wikidata-bugs] [Maniphest] [Unblock] T227759: Show label for Property in Wikidata Bridge modal

2019-09-11 Thread Pablo-WMDE
Pablo-WMDE closed subtask T232497: Handle properties with no label whatsoever as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T227759 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Pablo-WMDE, Charlie_WMD

[Wikidata-bugs] [Maniphest] [Closed] T230339: Show error in case saving failed

2019-09-11 Thread Pablo-WMDE
Pablo-WMDE closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T230339 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Matthias_Geisler_WMDE, Pablo-WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, Pablo-WMDE, dar

[Wikidata-bugs] [Maniphest] [Unblock] T226999: Save Wikidata edit when submitting client edit modal

2019-09-11 Thread Pablo-WMDE
Pablo-WMDE closed subtask T230339: Show error in case saving failed as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T226999 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Pablo-WMDE, Charlie_WMDE, Lucas_Werkme

[Wikidata-bugs] [Maniphest] [Claimed] T230326: Reuse EventEmittingButton from termbox

2019-09-11 Thread Pablo-WMDE
Pablo-WMDE claimed this task. Pablo-WMDE added a subscriber: Matthias_Geisler_WMDE. TASK DETAIL https://phabricator.wikimedia.org/T230326 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Matthias_Geisler_WMDE, alaa_wmde

[Wikidata-bugs] [Maniphest] [Created] T232588: Test tags via browser test

2019-09-11 Thread Pablo-WMDE
Pablo-WMDE created this task. Pablo-WMDE added projects: Wikidata, Wikidata-Bridge-Sprint-5. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION - create tag on repo via `managetags` API - perform save - assert via article history API (`action=query&prop=revisions&am

[Wikidata-bugs] [Maniphest] [Edited] T232582: configure tag on beta

2019-09-11 Thread Pablo-WMDE
Pablo-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T232582 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Aklapper, Pablo-WMDE, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic

[Wikidata-bugs] [Maniphest] [Created] T232582: configure tag on beta

2019-09-11 Thread Pablo-WMDE
Pablo-WMDE created this task. Pablo-WMDE added projects: Wikidata, Wikidata-Bridge-Sprint-5. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION "Data bridge" per story TASK DETAIL https://phabricator.wikimedia.org/T232582 EMAIL PREFERENC

[Wikidata-bugs] [Maniphest] [Created] T232581: Use config variable to initialize the WritingEntityRepository

2019-09-11 Thread Pablo-WMDE
Pablo-WMDE created this task. Pablo-WMDE added projects: Wikidata, Wikidata-Bridge-Sprint-5. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION see todo in `createServices()` TASK DETAIL https://phabricator.wikimedia.org/T232581 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Created] T232580: Create config variable for tags

2019-09-11 Thread Pablo-WMDE
Pablo-WMDE created this task. Pablo-WMDE added projects: Wikidata, Wikidata-Bridge-Sprint-5. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION - configure in $wgWBClientSettings as dataBridgeEditTags - add to JS as wbDataBridgeConfig.editTags - defaults to empty array

[Wikidata-bugs] [Maniphest] [Updated] T231833: standardize language codes to standard ones for HTML

2019-09-11 Thread Pablo-WMDE
Pablo-WMDE added a project: Wikidata-Bridge-Sprint-5. TASK DETAIL https://phabricator.wikimedia.org/T231833 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Matthias_Geisler_WMDE, Pablo-WMDE Cc: Aklapper, Lucas_Werkmeister_WMDE, Charlie_WMDE, Pablo

[Wikidata-bugs] [Maniphest] [Updated] T232497: Handle properties with no label whatsoever

2019-09-11 Thread Pablo-WMDE
Pablo-WMDE added a project: Wikidata-Bridge-Sprint-5. TASK DETAIL https://phabricator.wikimedia.org/T232497 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Aklapper, Matthias_Geisler_WMDE, Lucas_Werkmeister_WMDE, Michael, Pablo-WMDE

[Wikidata-bugs] [Maniphest] [Updated] T229582: Ensure responsiveness

2019-09-11 Thread Pablo-WMDE
Pablo-WMDE added a project: Wikidata-Bridge-Sprint-5. TASK DETAIL https://phabricator.wikimedia.org/T229582 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Matthias_Geisler_WMDE, Pablo-WMDE Cc: Agabi10, Pablo-WMDE, Lucas_Werkmeister_WMDE, Aklapper

[Wikidata-bugs] [Maniphest] [Updated] T230339: Show error in case saving failed

2019-09-11 Thread Pablo-WMDE
Pablo-WMDE added a project: Wikidata-Bridge-Sprint-5. TASK DETAIL https://phabricator.wikimedia.org/T230339 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Matthias_Geisler_WMDE, Pablo-WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, Pablo-WMDE

[Wikidata-bugs] [Maniphest] [Updated] T231468: Save label of edited property in bridge store

2019-09-11 Thread Pablo-WMDE
Pablo-WMDE added a project: Wikidata-Bridge-Sprint-5. TASK DETAIL https://phabricator.wikimedia.org/T231468 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Matthias_Geisler_WMDE, Pablo-WMDE Cc: Pablo-WMDE, Matthias_Geisler_WMDE

[Wikidata-bugs] [Maniphest] [Updated] T230326: Reuse EventEmittingButton from termbox

2019-09-11 Thread Pablo-WMDE
Pablo-WMDE added a project: Wikidata-Bridge-Sprint-5. TASK DETAIL https://phabricator.wikimedia.org/T230326 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Matthias_Geisler_WMDE, Pablo-WMDE Cc: alaa_wmde, Hanna_Petruschat_WMDE, Lucas_Werkmeister_WMDE

[Wikidata-bugs] [Maniphest] [Updated] T231471: Create label component

2019-09-11 Thread Pablo-WMDE
Pablo-WMDE added a project: Wikidata-Bridge-Sprint-5. TASK DETAIL https://phabricator.wikimedia.org/T231471 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Pablo-WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, Hook696, Daryl-TTMG

[Wikidata-bugs] [Maniphest] [Updated] T228261: Extract TermTextField to a 3rd repo and use it from there

2019-09-11 Thread Pablo-WMDE
Pablo-WMDE added a project: Wikidata-Bridge-Sprint-5. TASK DETAIL https://phabricator.wikimedia.org/T228261 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Matthias_Geisler_WMDE, Lucas_Werkmeister_WMDE, Aklapper, Lydia_Pintscher

[Wikidata-bugs] [Maniphest] [Updated] T230329: Use header component & save button

2019-09-11 Thread Pablo-WMDE
Pablo-WMDE added a project: Wikidata-Bridge-Sprint-5. TASK DETAIL https://phabricator.wikimedia.org/T230329 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Aklapper, Pablo-WMDE, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Updated] T231473: Wire up repository for entity label with services

2019-09-11 Thread Pablo-WMDE
Pablo-WMDE added a project: Wikidata-Bridge-Sprint-5. TASK DETAIL https://phabricator.wikimedia.org/T231473 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Matthias_Geisler_WMDE, Aklapper, Lucas_Werkmeister_WMDE, darthmon_wmde

[Wikidata-bugs] [Maniphest] [Updated] T230337: Close Application on successful save

2019-09-11 Thread Pablo-WMDE
Pablo-WMDE added a project: Wikidata-Bridge-Sprint-5. TASK DETAIL https://phabricator.wikimedia.org/T230337 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Matthias_Geisler_WMDE, Pablo-WMDE Cc: Aklapper, Pablo-WMDE, Hook696, Daryl-TTMG, RomaAmorRoma

[Wikidata-bugs] [Maniphest] [Updated] T227759: Show label for Property in Wikidata Bridge modal

2019-09-11 Thread Pablo-WMDE
Pablo-WMDE added a project: Wikidata-Bridge-Sprint-5. TASK DETAIL https://phabricator.wikimedia.org/T227759 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Pablo-WMDE, Charlie_WMDE, Michael, Lucas_Werkmeister_WMDE, Aklapper

[Wikidata-bugs] [Maniphest] [Updated] T231708: Add browser test

2019-09-11 Thread Pablo-WMDE
Pablo-WMDE added a project: Wikidata-Bridge-Sprint-5. TASK DETAIL https://phabricator.wikimedia.org/T231708 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Aklapper, Pablo-WMDE, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Updated] T232196: Wire up header

2019-09-11 Thread Pablo-WMDE
Pablo-WMDE added a project: Wikidata-Bridge-Sprint-5. TASK DETAIL https://phabricator.wikimedia.org/T232196 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Aklapper, Pablo-WMDE, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Updated] T231472: Connect label component and StringDataValue in DataBridge

2019-09-11 Thread Pablo-WMDE
Pablo-WMDE added a project: Wikidata-Bridge-Sprint-5. TASK DETAIL https://phabricator.wikimedia.org/T231472 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, darthmon_wmde, DannyS712, Nandana, Lahi

[Wikidata-bugs] [Maniphest] [Updated] T226999: Save Wikidata edit when submitting client edit modal

2019-09-11 Thread Pablo-WMDE
Pablo-WMDE added a project: Wikidata-Bridge-Sprint-5. TASK DETAIL https://phabricator.wikimedia.org/T226999 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Pablo-WMDE, Charlie_WMDE, Lucas_Werkmeister_WMDE, Aklapper, darthmon_wmde

[Wikidata-bugs] [Maniphest] [Updated] T227003: Add an edit tag parameter and tag the edits made via data bridge with "Data Bridge"

2019-09-11 Thread Pablo-WMDE
Pablo-WMDE edited projects, added Wikidata-Bridge-Sprint-5; removed Wikidata-Bridge. TASK DETAIL https://phabricator.wikimedia.org/T227003 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Pablo-WMDE, Aklapper, Lucas_Werkmeister_WMDE

[Wikidata-bugs] [Maniphest] [Claimed] T232497: Handle properties with no label whatsoever

2019-09-10 Thread Pablo-WMDE
Pablo-WMDE claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T232497 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Aklapper, Matthias_Geisler_WMDE, Lucas_Werkmeister_WMDE, Michael, Pablo-WMDE, darthmon_wmde, DannyS712

[Wikidata-bugs] [Maniphest] [Edited] T232497: Handle properties with no label whatsoever

2019-09-10 Thread Pablo-WMDE
Pablo-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T232497 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Aklapper, Matthias_Geisler_WMDE, Lucas_Werkmeister_WMDE, Michael, Pablo-WMDE, darthmon_wmde

[Wikidata-bugs] [Maniphest] [Unblock] T227759: Show label for Property in Wikidata Bridge modal

2019-09-10 Thread Pablo-WMDE
Pablo-WMDE closed subtask T231465: Create a repository for entity label in specific language as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T227759 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Pablo-WMDE, Ch

[Wikidata-bugs] [Maniphest] [Closed] T231465: Create a repository for entity label in specific language

2019-09-10 Thread Pablo-WMDE
Pablo-WMDE closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T231465 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Michael, Aklapper, Lucas_Werkmeister_WMDE, darthmon_wmde, DannyS712, Nandana,

[Wikidata-bugs] [Maniphest] [Created] T232497: Handle properties with no label whatsoever

2019-09-10 Thread Pablo-WMDE
Pablo-WMDE created this task. Pablo-WMDE added projects: Wikidata, Wikidata-Bridge-Sprint-4. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Despite us using the language fallback chain, and despite the fact that "this should never be the case", there st

[Wikidata-bugs] [Maniphest] [Edited] T228066: Error States of Data-Bridge [Tracking]

2019-09-10 Thread Pablo-WMDE
Pablo-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T228066 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Lydia_Pintscher, Charlie_WMDE, Aklapper, Michael, darthmon_wmde, DannyS712, Nandana, Lahi

[Wikidata-bugs] [Maniphest] [Updated] T227759: Show label for Property in Wikidata Bridge modal

2019-09-10 Thread Pablo-WMDE
Pablo-WMDE added subscribers: Charlie_WMDE, Pablo-WMDE. Pablo-WMDE added a comment. Amended the AC following a discussion with @Charlie_WMDE and added the error case to T228066: Error States of Data-Bridge [Tracking] <https://phabricator.wikimedia.org/T228066> to reconsider if and

[Wikidata-bugs] [Maniphest] [Edited] T227759: Show label for Property in Wikidata Bridge modal

2019-09-10 Thread Pablo-WMDE
Pablo-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T227759 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Michael, Lucas_Werkmeister_WMDE, Aklapper, Lydia_Pintscher, darthmon_wmde, DannyS712

[Wikidata-bugs] [Maniphest] [Reopened] T231465: Create a repository for entity label in specific language

2019-09-10 Thread Pablo-WMDE
Pablo-WMDE reopened this task as "Open". TASK DETAIL https://phabricator.wikimedia.org/T231465 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Michael, Aklapper, Lucas_Werkmeister_WMDE, darthmon_wmde, DannyS712, Nandana,

[Wikidata-bugs] [Maniphest] [Block] T227759: Show label for Property in Wikidata Bridge modal

2019-09-10 Thread Pablo-WMDE
Pablo-WMDE reopened subtask T231465: Create a repository for entity label in specific language as "Open". TASK DETAIL https://phabricator.wikimedia.org/T227759 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE C

[Wikidata-bugs] [Maniphest] [Commented On] T231465: Create a repository for entity label in specific language

2019-09-10 Thread Pablo-WMDE
Pablo-WMDE added a comment. I'm actually still at rebasing and polishing https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/533934 at this very moment. TASK DETAIL https://phabricator.wikimedia.org/T231465 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/

[Wikidata-bugs] [Maniphest] [Edited] T228066: Error States of Data-Bridge [Tracking]

2019-09-10 Thread Pablo-WMDE
Pablo-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T228066 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Lydia_Pintscher, Charlie_WMDE, Aklapper, Michael, darthmon_wmde, DannyS712, Nandana, Lahi

[Wikidata-bugs] [Maniphest] [Claimed] T231465: Create a repository for entity label in specific language

2019-09-10 Thread Pablo-WMDE
Pablo-WMDE claimed this task. Pablo-WMDE added a subscriber: Michael. TASK DETAIL https://phabricator.wikimedia.org/T231465 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Michael, Aklapper, Lucas_Werkmeister_WMDE, Hook696, Daryl-TTMG

[Wikidata-bugs] [Maniphest] [Commented On] T230326: Reuse EventEmittingButton from termbox

2019-09-09 Thread Pablo-WMDE
Pablo-WMDE added a comment. Talked with @Hanna_Petruschat_WMDE ragarding "bullet 3", i.e. the reasoning back when during termbox. She confirmed that the "primaryprogressive" button implemented for termbox is indeed supposed to follow the OOUI specification and all

[Wikidata-bugs] [Maniphest] [Unblock] T227759: Show label for Property in Wikidata Bridge modal

2019-09-09 Thread Pablo-WMDE
Pablo-WMDE closed subtask T231467: Enable store to contain several entities as "Invalid". TASK DETAIL https://phabricator.wikimedia.org/T227759 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Michael, Lucas_Werkmeister_WMDE

[Wikidata-bugs] [Maniphest] [Edited] T231468: Save label of edited property in bridge store

2019-09-09 Thread Pablo-WMDE
Pablo-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T231468 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Pablo-WMDE, Matthias_Geisler_WMDE, Lucas_Werkmeister_WMDE, Aklapper, darthmon_wmde

[Wikidata-bugs] [Maniphest] [Closed] T231467: Enable store to contain several entities

2019-09-09 Thread Pablo-WMDE
Pablo-WMDE closed this task as "Invalid". TASK DETAIL https://phabricator.wikimedia.org/T231467 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Aklapper, Lucas_Werkmeister_WMDE, darthmon_wmde, DannyS712, Nandana, L

[Wikidata-bugs] [Maniphest] [Commented On] T231468: Save label of edited property in bridge store

2019-09-09 Thread Pablo-WMDE
Pablo-WMDE added a comment. During a post-daily discussion regarding this task we, partially reverting the idea from task break-down, decided against making the property label part of the entity store. Reason is that it creates challenges (having a partial fingerprintable entity in a store

[Wikidata-bugs] [Maniphest] [Retitled] T231468: Save label of edited property in bridge store

2019-09-09 Thread Pablo-WMDE
Pablo-WMDE renamed this task from "Save label of edited property in store" to "Save label of edited property in bridge store". Pablo-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T231468 EMAIL PREFERENCES https://phabricator.wikimedi

[Wikidata-bugs] [Maniphest] [Assigned] T229582: Ensure responsiveness

2019-09-09 Thread Pablo-WMDE
Pablo-WMDE assigned this task to Matthias_Geisler_WMDE. TASK DETAIL https://phabricator.wikimedia.org/T229582 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Matthias_Geisler_WMDE, Pablo-WMDE Cc: Agabi10, Pablo-WMDE, Lucas_Werkmeister_WMDE, Aklapper

[Wikidata-bugs] [Maniphest] [Edited] T231476: Termbox (v2) does not map nonstandard language codes to standard ones for HTML

2019-09-06 Thread Pablo-WMDE
Pablo-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T231476 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: WMDE-leszek, Pablo-WMDE, Aklapper, Lucas_Werkmeister_WMDE, darthmon_wmde, DannyS712

[Wikidata-bugs] [Maniphest] [Updated] T232196: Wire up header

2019-09-06 Thread Pablo-WMDE
Pablo-WMDE removed a project: Wikidata-Bridge-Sprint-3. Pablo-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T232196 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Aklapper, Pablo-WMDE, darthmon_wmde

[Wikidata-bugs] [Maniphest] [Created] T232196: Wire up header

2019-09-06 Thread Pablo-WMDE
Pablo-WMDE created this task. Pablo-WMDE added projects: Wikidata, Wikidata-Bridge-Sprint-3, Wikidata-Bridge-Sprint-4. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION TASK DETAIL https://phabricator.wikimedia.org/T232196 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Lowered Priority] T231799: LuaWikibaseEntityLibraryTest: CI failing en masse

2019-09-06 Thread Pablo-WMDE
Pablo-WMDE lowered the priority of this task from "Unbreak Now!" to "Normal". Pablo-WMDE added a comment. Is anyone still working on this? E.g. https://gerrit.wikimedia.org/r/533944 is still dangling... TASK DETAIL https://phabricator.wikimedia.org/T231799 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T230326: Reuse EventEmittingButton from termbox

2019-09-05 Thread Pablo-WMDE
Pablo-WMDE added a comment. Thanks for following up on this @Charlie_WMDE > is there a discrepancy between the OOUI primary progressive button and the one that was implemented for termbox? I would not know but I heard rumors there are. The good thing is It does not really mat

[Wikidata-bugs] [Maniphest] [Commented On] T227003: Add an edit tag parameter and tag the edits made via data bridge with "Data Bridge"

2019-09-05 Thread Pablo-WMDE
Pablo-WMDE added a comment. Agreed, thanks! We can copy these to become (sub)tasks of the story once it is picked. We might want to revise the existing estimation a bit, I think. TASK DETAIL https://phabricator.wikimedia.org/T227003 EMAIL PREFERENCES https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Edited] T227003: Add an edit tag parameter and tag the edits made via data bridge with "Data Bridge"

2019-09-05 Thread Pablo-WMDE
Pablo-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T227003 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Pablo-WMDE, Aklapper, Lucas_Werkmeister_WMDE, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T230326: Reuse EventEmittingButton from termbox

2019-09-05 Thread Pablo-WMDE
Pablo-WMDE added a subscriber: Hanna_Petruschat_WMDE. Pablo-WMDE added a comment. Had a brief chat with @Lydia_Pintscher @Charlie_WMDE - the following may (or may not) be considered obvious but I'm making the expressed mutual understanding explicit to eliminate other interpretations.

[Wikidata-bugs] [Maniphest] [Commented On] T232063: RuntimeException breaking CI builds

2019-09-05 Thread Pablo-WMDE
Pablo-WMDE added a comment. 2.2.1 release is out: https://github.com/DataValues/DataValues/releases TASK DETAIL https://phabricator.wikimedia.org/T232063 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: alaa_wmde, Pablo-WMDE Cc: Pablo-WMDE, hashar

[Wikidata-bugs] [Maniphest] [Triaged] T231968: Wikibase OutputPageBeforeHTMLHookHandlerTest::testOutputPageBeforeHTMLHookHandler failing on Travis CI

2019-09-05 Thread Pablo-WMDE
Pablo-WMDE triaged this task as "High" priority. TASK DETAIL https://phabricator.wikimedia.org/T231968 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow, Pablo-WMDE Cc: Aklapper, Pablo-WMDE, Tarrow, WMDE-leszek, Hook696,

[Wikidata-bugs] [Maniphest] [Commented On] T230895: Problem: the ooui dialog has a padding that we want/need _inside_ of our app, not around it

2019-09-04 Thread Pablo-WMDE
Pablo-WMDE added a comment. I looked at the patch <https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/532729> as it evolved and tried to rebase it. In the mean time changes by the same author were merged (for T230328 <https://phabricator.wikimedia.org/T230328>) in

[Wikidata-bugs] [Maniphest] [Edited] T228066: Error States of Data-Bridge [Tracking]

2019-09-04 Thread Pablo-WMDE
Pablo-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T228066 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Lydia_Pintscher, Charlie_WMDE, Aklapper, Michael, darthmon_wmde, DannyS712, Nandana, Lahi

[Wikidata-bugs] [Maniphest] [Unassigned] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-09-04 Thread Pablo-WMDE
Pablo-WMDE removed Pablo-WMDE as the assignee of this task. Pablo-WMDE added a comment. @Mholloway @Cparle I created two patches which show a less invasive alternative to https://gerrit.wikimedia.org/r/533907. If you still feel like this would be the right direction for the product please

[Wikidata-bugs] [Maniphest] [Claimed] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-09-03 Thread Pablo-WMDE
Pablo-WMDE claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T231276 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: daniel, Pablo-WMDE, Urbanecm, Zoranzoki21, Yann, WMDE-leszek, Lydia_Pintscher, Cparle, Mholloway

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-09-03 Thread Pablo-WMDE
Pablo-WMDE added a comment. Just realized this affects the API, when searching via title, as well. e.g. https://commons.wikimedia.org/w/api.php?action=wbgetentities&titles=File:Bolsonaro_with_Israeli_PM_Benjamin_Netanyahu,_Tel_Aviv,_31_March_2019.jpg&sites=com

[Wikidata-bugs] [Maniphest] [Updated] T231876: Wikibase CI failing with “Service disabled: DBLoadBalancerFactory”

2019-09-03 Thread Pablo-WMDE
Pablo-WMDE added a comment. Possibly a manifestation of T229601: Service disabled: DBLoadBalancerFactory while CLI installation failed <https://phabricator.wikimedia.org/T229601> TASK DETAIL https://phabricator.wikimedia.org/T231876 EMAIL PREFERENCES https://phabricator.wikimed

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-09-03 Thread Pablo-WMDE
Pablo-WMDE added a comment. @Cparle > AFAICS the introduction of EntityLookup::getEntity() has revealed a problem rather than causing one. The problem is that MediaInfo ids for a slot on a page are based on the id of the page, Well put, no discussion on that. > IMO @Ur

[Wikidata-bugs] [Maniphest] [Updated] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-09-03 Thread Pablo-WMDE
Pablo-WMDE added a comment. It appears the call to `EntityLookup::getEntity()` was introduced relatively recently (2019-08-05), during https://gerrit.wikimedia.org/r/527560 for T229572: Write a new js config var containing the MediaInfo entity on the File page <ht

<    4   5   6   7   8   9   10   11   12   13   >