Sarai-WMDE updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T324366
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: noarave, Sarai-WMDE
Cc: Aklapper, Sarai-WMDE, Astuthiodit_1, karapayneWMDE, Invadibot,
Manishagoenka
Sarai-WMDE added a comment.
Agreed. That standard design for SPA exists and was applied to the Mismatch
Finder. Unfortunately, the need for it was detected only right after the Query
Builder and the Item Quality Evaluator were done, thus the needed adjustments.
If the comment is more
Sarai-WMDE added a comment.
Hey! Thanks for the heads-up about the comment, @Michael. The answer is: none
of the above. In all SPAs, the footer should have a 2.5rem of spacing above
itself. This is regardless of the breakpoint.
There's no need to make any changes as part of this t
Sarai-WMDE added a comment.
Initial mocks are available in this Figma page
<https://www.figma.com/file/giI7PSmAju8t80OE65jBfZ/Mismatch-Finder-v2?node-id=3474%3A5017&t=8sl8PCJzmP0Lg4nn-0>.
Some open questions:
1. Button placement: I don’t think it’s a problem, but if we fee
Sarai-WMDE added a comment.
Looking great! 🎉 Only one question: would it be possible to maintain the
1.5rem top margin in the responsive version of the header (aka below the 609px
breakpoint)? It now gets reduced to 1rem (same as all other page margins), but
it shouldn't. Than
Sarai-WMDE added a comment.
Good catch! The fix seems appropriate 👍🏻
TASK DETAIL
https://phabricator.wikimedia.org/T324841
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Sarai-WMDE
Cc: Lydia_Pintscher, Sarai-WMDE, Aklapper
Sarai-WMDE added a subscriber: LucasWerkmeister.
Sarai-WMDE added a comment.
In T288931#8456973 <https://phabricator.wikimedia.org/T288931#8456973>,
@Lucas_Werkmeister_WMDE wrote:
> I might be missing something, but I don’t see a variable like
`$font.weight.style.heading-bold`
Sarai-WMDE added a comment.
In T322686#8401616 <https://phabricator.wikimedia.org/T322686#8401616>,
@Sarai-WMDE wrote:
>> You can actually create the lexeme without tabbing out of the lexical
category field at all, by pressing Enter there.
>
> Probably @Nikki (l
Sarai-WMDE added a comment.
After checking the behavior of `PageUp` and `PageDown` in OOUI, I realized
that these keys seem to correspond exactly to `ctrl+Home` and `ctrl+End`,
shortcuts that are currently available in the Codex Menu component (see it in
the context of Lookup
<ht
Sarai-WMDE added a comment.
My take to try to unblock this task sooner than later would be to eliminate
the Codex migration from the equation for now, and instead apply contextual
adjustments to the WiKit component. The reason for this being that, as we know,
the available Codex Lookup
Sarai-WMDE added a comment.
Please note that this task should ideally be followed up by
{https://phabricator.wikimedia.org/T288931} (Currently available in the Unified
prioritized backlog)
TASK DETAIL
https://phabricator.wikimedia.org/T288939
EMAIL PREFERENCES
https
Sarai-WMDE updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T324653
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Sarai-WMDE
Cc: Aklapper, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, Invadibot,
maantietaja
Sarai-WMDE added a comment.
Thanks for the clear feedback @Tagishsimon. Looks like we should not only
limit the size of the dropdown menu, but maybe also we could reorder the
buttons to get the popup further out of the way:
F35840582: Screenshot 2022-12-06 at 10.37.49.png
<ht
Sarai-WMDE added a comment.
Yes, definitely the width should be adjusted to make the content readable. We
could simply change the min-width of the dropdown menu to 25em (It's generally
a good idea to use relative units to size text containers, although I think
fonts in that pag
Sarai-WMDE updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T324366
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Sarai-WMDE
Cc: Aklapper, Sarai-WMDE, Astuthiodit_1, karapayneWMDE, Invadibot,
Manishagoenka, maantietaja
Sarai-WMDE created this task.
Sarai-WMDE added projects: Wikidata Dev Team, Design, Wikidata, Mismatch Finder.
TASK DESCRIPTION
**Problem**
Some of the visual features of the Mismatch Finder footer (typographic
styles, spacing on mobile) are not aligned with its original specifications
Sarai-WMDE updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T324356
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Sarai-WMDE
Cc: Aklapper, Sarai-WMDE, Astuthiodit_1, karapayneWMDE, Invadibot,
Manishagoenka, maantietaja
Sarai-WMDE created this task.
Sarai-WMDE added projects: Wikidata Dev Team, Design, Wikidata, Mismatch Finder.
TASK DESCRIPTION
**Problem**
The current 'Wikidata Mismatch Finder' logo is quite wide, which can cause
spacing issues (logo could be cut-off) in smaller mobile devices
Sarai-WMDE renamed this task from "Query builder: Adjust footer content and
style" to "Query Builder: Adjust footer content and style".
TASK DETAIL
https://phabricator.wikimedia.org/T324356
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferen
Sarai-WMDE renamed this task from "Query Builder: Replace visible h1 by title"
to "Query Builder: Replace visible h1".
TASK DETAIL
https://phabricator.wikimedia.org/T288931
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Sar
Sarai-WMDE created this task.
Sarai-WMDE added projects: Wikidata Dev Team, Design, Wikidata, Wikidata Query
Builder.
TASK DESCRIPTION
**Problem**
The Query builder's footer presents a couple of visual inconsistencies
(styles, spacing) with that of the similarly structured tool
Sarai-WMDE updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T288939
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Sarai-WMDE
Cc: Aklapper, Sarai-WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja,
ItamarWMDE
Sarai-WMDE updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T288939
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Sarai-WMDE
Cc: Aklapper, Sarai-WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja,
ItamarWMDE
Sarai-WMDE updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T324351
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Sarai-WMDE
Cc: Aklapper, Sarai-WMDE, Astuthiodit_1, karapayneWMDE, Invadibot,
Manishagoenka, maantietaja
Sarai-WMDE renamed this task from "Query Builder: Edit main title and
description" to "Query Builder: Replace visible h1 by title".
TASK DETAIL
https://phabricator.wikimedia.org/T288931
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences
Sarai-WMDE renamed this task from "Apply visual adjustments to make QB's
interface consistent with other SPAs" to "Query Builder: Edit main title and
description".
Sarai-WMDE updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T288931
Sarai-WMDE renamed this task from "Add header to Query Builder" to "Query
Builder: Add main header".
TASK DETAIL
https://phabricator.wikimedia.org/T288939
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Sarai-WMDE
Cc:
Sarai-WMDE updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T288939
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Sarai-WMDE
Cc: Aklapper, Sarai-WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja,
ItamarWMDE
Sarai-WMDE renamed this task from "Add Wikidata header to Query Builder UI" to
"Add header to Query Builder".
Sarai-WMDE updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T288939
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/pa
Sarai-WMDE added a parent task: T324351: Standardize the layout of SPA tools.
TASK DETAIL
https://phabricator.wikimedia.org/T288931
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Sarai-WMDE
Cc: Aklapper, Sarai-WMDE, Astuthiodit_1, karapayneWMDE
Sarai-WMDE added a parent task: T324351: Standardize the layout of SPA tools.
TASK DETAIL
https://phabricator.wikimedia.org/T288939
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Sarai-WMDE
Cc: Aklapper, Sarai-WMDE, Astuthiodit_1, karapayneWMDE
Sarai-WMDE added a subscriber: LucasWerkmeister.
Sarai-WMDE added a comment.
Thanks so much for all the changes and for your patient support,
@LucasWerkmeister! 🙏🏻
After taking a look at the specs and changes again, I realized that we might
need to increase the spacing under the '
Sarai-WMDE added a comment.
Summary of what's causing confusion: rather than fully adhering to creating a
'compact' look, the spacing changes included in the mock have the purpose of
fixing the heading dimensions, and solving some spacing inconsistencies between
the main
Sarai-WMDE updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T323678
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Sarai-WMDE
Cc: Michael, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Sarai-WMDE, Nikki,
Aklapper
Sarai-WMDE updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T323680
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Lucas_Werkmeister_WMDE, Sarai-WMDE
Cc: Lydia_Pintscher, Sarai-WMDE, Nikki, Aklapper, Astuthiodit_1
Sarai-WMDE updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T323678
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Sarai-WMDE
Cc: Michael, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Sarai-WMDE, Nikki,
Aklapper
Sarai-WMDE updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T323680
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Lucas_Werkmeister_WMDE, Sarai-WMDE
Cc: Lydia_Pintscher, Sarai-WMDE, Nikki, Aklapper, Astuthiodit_1
Sarai-WMDE updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T323680
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Lucas_Werkmeister_WMDE, Sarai-WMDE
Cc: Lydia_Pintscher, Sarai-WMDE, Nikki, Aklapper, Astuthiodit_1
Sarai-WMDE added a comment.
In T323680#8425225 <https://phabricator.wikimedia.org/T323680#8425225>,
@Lucas_Werkmeister_WMDE wrote:
> The new logo SVG has a solid white background, whereas the old one
(Wikidata only) is transparent – is that a required change?
No! That&#x
Sarai-WMDE attached a referenced file: F35821937: Mismatch finder logo.svg.
TASK DETAIL
https://phabricator.wikimedia.org/T323680
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Sarai-WMDE
Cc: Lydia_Pintscher, Sarai-WMDE, Nikki, Aklapper
Sarai-WMDE updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T323680
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Sarai-WMDE
Cc: Lydia_Pintscher, Sarai-WMDE, Nikki, Aklapper, Astuthiodit_1, karapayneWMDE,
Invadibot
Sarai-WMDE updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T323678
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Sarai-WMDE
Cc: Lydia_Pintscher, Sarai-WMDE, Nikki, Aklapper, Astuthiodit_1, karapayneWMDE,
Invadibot
Sarai-WMDE renamed this task from "Mismatch Finder: Only the text in item
headers included in the results page should be clickable" to "Mismatch Finder:
Only the text in the results page headers should be clickable".
TASK DETAIL
https://phabricator.wikimedia.org/T32382
Sarai-WMDE added a comment.
Makes sense, of course. Adding to to do list...
TASK DETAIL
https://phabricator.wikimedia.org/T323680
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Sarai-WMDE
Cc: Lydia_Pintscher, Sarai-WMDE, Nikki, Aklapper
Sarai-WMDE added a comment.
Sounds good! I agree with your replacement of 'new' by 'more': good idea.
Thanks for updating the task description 🙏🏻
TASK DETAIL
https://phabricator.wikimedia.org/T323682
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/pa
Sarai-WMDE renamed this task from "Change placement of 'External source'
column" to "Mismatch Finder: Change placement of 'External source' column".
TASK DETAIL
https://phabricator.wikimedia.org/T323819
EMAIL PREFERENCES
https://phabricator.wikimedia.
Sarai-WMDE added a comment.
In T323734#8420048 <https://phabricator.wikimedia.org/T323734#8420048>,
@Lucas_Werkmeister_WMDE wrote:
> Note that the patch also reduces the visual size of the main / English logo
at 100% zoom (left is old / without the patch, right is new / with
Sarai-WMDE added a comment.
>> I'm not sure what the proper fix would be either, but strangely enough,
just disabling the `auto` height applied to the image (which I guess is
enforcing the original size and keeping the aspect ratio) seems to do the
trick? I'm not sure
Sarai-WMDE attached a referenced file: F35817343: Group 16 (1).png.
TASK DETAIL
https://phabricator.wikimedia.org/T321571
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Sarai-WMDE
Cc: Mohammed_Sadat_WMDE, MisterSynergy, Sarai-WMDE, Lydia_Pintscher
Sarai-WMDE added a comment.
Thanks @MisterSynergy for the amazingly fast changes! 😄
> What's missing:
>
> - The background image ("hero") seems to scale okay-ish on desktop now, but
there is some CSS definition in the mobile skin (as much as I am aware) which
Sarai-WMDE attached a referenced file: F35816213: Group 16.png.
TASK DETAIL
https://phabricator.wikimedia.org/T321571
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Sarai-WMDE
Cc: Mohammed_Sadat_WMDE, MisterSynergy, Sarai-WMDE, Lydia_Pintscher
Sarai-WMDE added a comment.
Hello there! It looks like getting a new image will take a bit longer than
expected. For that reason, I'd like to suggest trying to solve the technical
issues that are preventing the current image from adjusting to screen size
changes. While at it, we could
Sarai-WMDE added a comment.
I'd try to 'feed two birds with one scone' and update the button copy to make
it clear that this is the way to go back to the main page (See
https://phabricator.wikimedia.org/T323682).
Another (non-conflicting) solution could be to add the name
Sarai-WMDE added a comment.
'Refine item selection' is definitely a very accurate label for the button in
case you accessed the results page from the tool's main page. I agree, though,
that this might sound confusing for gadget users, who follow a different path
there. So
Sarai-WMDE attached a referenced file: F35794133: T313469.png.
TASK DETAIL
https://phabricator.wikimedia.org/T313469
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Sarai-WMDE
Cc: Sarai-WMDE, jmkeil, Aklapper, Lydia_Pintscher, Astuthiodit_1
Sarai-WMDE attached a referenced file: F35794129: T313469.png.
TASK DETAIL
https://phabricator.wikimedia.org/T313469
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Sarai-WMDE
Cc: Sarai-WMDE, jmkeil, Aklapper, Lydia_Pintscher, Astuthiodit_1
Sarai-WMDE attached a referenced file: F35794168: T313469.png.
TASK DETAIL
https://phabricator.wikimedia.org/T313469
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Sarai-WMDE
Cc: Sarai-WMDE, jmkeil, Aklapper, Lydia_Pintscher, Astuthiodit_1
Sarai-WMDE attached a referenced file: F35794422: T313469.png.
TASK DETAIL
https://phabricator.wikimedia.org/T313469
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Sarai-WMDE
Cc: Sarai-WMDE, jmkeil, Aklapper, Lydia_Pintscher, Astuthiodit_1
Sarai-WMDE attached a referenced file: F35794423: T313469.png.
TASK DETAIL
https://phabricator.wikimedia.org/T313469
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Sarai-WMDE
Cc: Sarai-WMDE, jmkeil, Aklapper, Lydia_Pintscher, Astuthiodit_1
Sarai-WMDE attached a referenced file: F35794447: T313469.png.
TASK DETAIL
https://phabricator.wikimedia.org/T313467
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Sarai-WMDE
Cc: Sarai-WMDE, jmkeil, Aklapper, Lydia_Pintscher, Astuthiodit_1
Sarai-WMDE attached a referenced file: F35794451: T313469.png.
TASK DETAIL
https://phabricator.wikimedia.org/T313467
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Sarai-WMDE
Cc: Sarai-WMDE, jmkeil, Aklapper, Lydia_Pintscher, Astuthiodit_1
Sarai-WMDE added a comment.
> I'm sorry, for using a shorthand. I'm referring to the messages in the core
MediaWiki repository, specifically in languages/i18n/en.json
<https://github.com/wikimedia/mediawiki/blob/master/languages/i18n/en.json>
There it can be
Sarai-WMDE added a comment.
In T322683#8405170 <https://phabricator.wikimedia.org/T322683#8405170>,
@Michael wrote:
> In T322683#8403690 <https://phabricator.wikimedia.org/T322683#8403690>,
@Sarai-WMDE wrote:
>
>>> That's a simple change, we ju
Sarai-WMDE added a comment.
Terminological mismatches: Request for feedback on designs
--
Like in the case of {https://phabricator.wikimedia.org/T313467}, this task
requires redesigning of the Mismatch Finder's results page a
Sarai-WMDE added a comment.
Qualifier mismatches: Request for feedback on designs
-
This task, as well as {https://phabricator.wikimedia.org/T313469}, requires
the redesign of the Mismatch Finder's results page and/or table.
Sarai-WMDE added a comment.
> Mh, the reasoning given in that blog-post for using an icon instead of an
asterisk is that the `aria-hidden` is not respected in focus mode. Sadly, it
doesn't specify what screen reader or "focus mode" that refers to. But that
article is fr
Sarai-WMDE added a subscriber: LucasWerkmeister.
Sarai-WMDE added a comment.
Wasn't aware of these necessary copy changes. Thanks so much for bringing
these up, @LucasWerkmeister 🙏🏻 Allow me to suggest some small alterations:
New `confirmation-dialog-message-tip-1` message:
Sarai-WMDE claimed this task.
TASK DETAIL
https://phabricator.wikimedia.org/T323106
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Sarai-WMDE
Cc: Sarai-WMDE, Manuel, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot,
maantietaja, ItamarWMDE
Sarai-WMDE added a comment.
> As far as I know, the Codex Lookup does not yet have a configuration to
automatically select the first available option. But maybe that would be a
useful addition?
That's correct. Both the Codex and WiKit lookup components present a
different int
Sarai-WMDE added a comment.
> Pressing enter after entering a language name or lexical category tries to
submit the form instead of selecting the top entry.
Now with more insight regarding the behavior of the NewLexeme form (see
https://phabricator.wikimedia.org/T322686#8401616): t
Sarai-WMDE added a comment.
> You can actually create the lexeme without tabbing out of the lexical
category field at all, by pressing Enter there.
Probably @Nikki (like myself) wasn't aware of this behavior, which removes
the need to actually tab and select the button in
Sarai-WMDE added a comment.
> You can actually create the lexeme without tabbing out of the lexical
category field at all, by pressing Enter there.
Oh wow. Ok, that actually removes the extra tabbing inconvenience for heavy
keyboard users entirely. At the same time, this sounds qu
Sarai-WMDE attached a referenced file: F35786262: Nov-16-2022 15-33-34.gif.
TASK DETAIL
https://phabricator.wikimedia.org/T322686
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Michael, Sarai-WMDE
Cc: Michael, noarave, Lucas_Werkmeister_WMDE
Sarai-WMDE attached a referenced file: F35786452: Group 1.png.
TASK DETAIL
https://phabricator.wikimedia.org/T322686
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Michael, Sarai-WMDE
Cc: Michael, noarave, Lucas_Werkmeister_WMDE, mrephabricator
Sarai-WMDE added a comment.
I see your point. But the outcome of modifying the default tab order as a
result of the changes applied via #328
<https://github.com/wmde/new-lexeme-special-page/pull/328> is disrupting the
page's structure and navigation order for both keyboard and sc
Sarai-WMDE added a comment.
In T322686#8399322 <https://phabricator.wikimedia.org/T322686#8399322>,
@Michael wrote:
>> Add tabindex=-1 to the copyright/terms of use links (this seems to be the
preferred way a11y-wise )
>
> I think, I would challenge that notion
Sarai-WMDE added a comment.
> Pressing enter after entering a language name or lexical category tries to
submit the form instead of selecting the top entry.
I'm not able to reproduce the issue (as I interpret it). Tried the new lexeme
page <https://www.wikida
Sarai-WMDE added a comment.
Providing some inline clarifications and recommendations about the required
symbol:
> It is not following the style used by MediaWiki elsewhere
While working on the new unified design system for Wikimedia (Codex), it was
tentatively decided to actua
Sarai-WMDE added a comment.
Hello there. There's no perfect solution for this: If we placed the text
below the button, we would risk hiding the conditions from screen reader users
(and making them easier to ignore, due to reading order, for everyone else). I
think we should follow the
Sarai-WMDE added a comment.
Roger that. Thanks, Lydia!
TASK DETAIL
https://phabricator.wikimedia.org/T318310
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Sarai-WMDE
Cc: Sarai-WMDE, Lydia_Pintscher, ItamarWMDE, Lucas_Werkmeister_WMDE, Abbe98
Sarai-WMDE added a comment.
Hey there. Just wanted to confirm that no UX support is required to fulfill
this task. My assumption is that Lexeme identifiers would be visualized in the
same way that Item identifiers are:
F35731725: Screenshot 2022-11-09 at 14.52.08.png
<ht
Sarai-WMDE added a comment.
In T306932#8356470 <https://phabricator.wikimedia.org/T306932#8356470>,
@AnneT wrote:
> Could we accept such a slight divergence between Codex and OOUI? I would
hate to hold back Codex because of the old system, and I'm not convinced that
both
Sarai-WMDE added a comment.
Hey all. Regarding the removal of that //-1px// border-top. The change (which
I still support) was suggested a while back (see original task, T307767
<https://phabricator.wikimedia.org/T307767>): me and Alex
<https://phabricator.wikimedia.org/T30355
Sarai-WMDE added a comment.
In T313468#8344673 <https://phabricator.wikimedia.org/T313468#8344673>,
@Lydia_Pintscher wrote:
> @Sarai-WMDE will look into improving the wording in the status column to
make sure it is not confusing for an empty value on the Wikidata side:
Sarai-WMDE moved this task from Design Sign-Off to QTE Sign-off on the
Design-Systems-Team (Design-Systems-Sprint) board.
Sarai-WMDE reassigned this task from Sarai-WMDE to EUdoh-WMF.
TASK DETAIL
https://phabricator.wikimedia.org/T306932
WORKBOARD
https://phabricator.wikimedia.org/project
Sarai-WMDE added a comment.
This task can be signed-off from a design perspective. Following the ACs,
users of the Menu component can now define the number of visible items that the
menu will display in context. Further options are available on scroll. As
specified, the scroll position is
Sarai-WMDE added a comment.
Tiniest nitpick about the demo, but the width of the input to enter the
number of visible items should be increased, so it can take two digits:
F35531089: Screenshot 2022-09-23 at 20.39.29.png
<https://phabricator.wikimedia.org/F35531089>
I think
Sarai-WMDE added a comment.
All up to date! Input-type components now display the right placeholder color
(and opacity) in the last Query builder build (pun always intended). Thanks
@guergana.tzatchkova!
(Verified in Chrome v104, Safari v15.6 and Firefox Nightly v106 on macOS
Monterey
Sarai-WMDE added a project: Wikidata Lexicographical data.
TASK DETAIL
https://phabricator.wikimedia.org/T312655
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Sarai-WMDE
Cc: Aklapper, Sarai-WMDE, Astuthiodit_1, STH, karapayneWMDE, Invadibot
Sarai-WMDE added a project: Wikidata Lexicographical data.
TASK DETAIL
https://phabricator.wikimedia.org/T312656
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Sarai-WMDE
Cc: Aklapper, Sarai-WMDE, Astuthiodit_1, STH, karapayneWMDE, Invadibot
Sarai-WMDE attached a referenced file: F35312144: Screenshot 2022-07-08 at
16.54.42.png.
TASK DETAIL
https://phabricator.wikimedia.org/T312656
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Sarai-WMDE
Cc: Aklapper, Sarai-WMDE, Astuthiodit_1, STH
Sarai-WMDE added a comment.
✅ All fixes done and looking great.
Checked using Chrome 104, Safari 15.6 and Firefox 104 on macOS Monterey.
TASK DETAIL
https://phabricator.wikimedia.org/T312652
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To
Sarai-WMDE updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T312652
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: noarave, Sarai-WMDE
Cc: guergana.tzatchkova, Lucas_Werkmeister_WMDE, Aklapper, Sarai-WMDE,
Hellket777
Sarai-WMDE added a comment.
TextInput, Lookup and TextArea have been fixed in WiKit, and they now display
the right placeholder color (#72777d). The Special:NewLexeme page in Beta is
displaying the right styles, and so is Mismatch finder. I believe, though, that
the version of Wikit hasn&#
Sarai-WMDE added a comment.
The page is looking amazing in Beta
<https://wikidata.beta.wmflabs.org/wiki/Special:NewLexemeAlpha> with the latest
changes! Thanks for all the changes, @noarave.
I just noticed a side effect that requires a small last fix:
- The vertical spacing b
Sarai-WMDE added a comment.
Just a couple of comments after reviewing the design touch ups in Beta
<https://wikidata.beta.wmflabs.org/wiki/Special:NewLexemeAlpha>:
1. Regarding...
> All elements within the infopanel should have a vertical spacing of 16px
(1rem) bet
Sarai-WMDE updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T312652
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: noarave, Sarai-WMDE
Cc: guergana.tzatchkova, Lucas_Werkmeister_WMDE, Aklapper, Sarai-WMDE,
Hellket777
Sarai-WMDE closed this task as "Declined".
TASK DETAIL
https://phabricator.wikimedia.org/T243742
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Sarai-WMDE
Cc: Aklapper, Sarai-WMDE, Astuthiodit_1, STH, karapayneWMDE, Invadibot,
m
Sarai-WMDE added a comment.
Oh! Makes sense because these are different components. I totally forgot to
check. We should create and apply an opacity component token for TextArea, same
we did for Input. Should we apply changes in the same patch?
TASK DETAIL
https
Sarai-WMDE added a comment.
Thanks for the change, @guergana.tzatchkova! Looks like the input now display
the right color in Chrome and Safari. The problem with Firefox is that the
browser applies an opacity of 0.54 by default, that's what causing the lower
contrast:
F353
801 - 900 of 1626 matches
Mail list logo
